Re: Discussion - /jkstatus and stylesheets
Hi, As an alternative to the above method I suggest use of an 'external' stylesheet, which has the following advantages: 1. The choice of colour palette is made external to the program and easier to try different variations. 2. It is in keeping with W3C preferences. agreed. While the first method requires the least work to implement, the second approach offers more flexibility for user environments. If the latter method were adopted I see it as more appropriate to add the path variable (called 'style' above) as a property of the status worker rather than as a general environment one. I'm fine with second one: introduce a style property. By way of deciding a default 'jkstatus.css' that might be supplied with the connector, at least three methods are feasible: 1. Implement a stylesheet that emulates the current default colour/style scheme, 2. Have the Developers choose one obtained by any method, 3. Make a 'request for suggestions' on the TC-user list. I would like to suggest a 4. one: test for presense of the the style property, and if not present fallback to the hardcoded style Henri introduced. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: IIS-Tomcat redirector isapi_redirector2.dll linking issue
Hi, Configuration: isapi - Win32 Release Linking... Creating library Release/isapi_redirector2.lib and object Release/isapi_redirector2.exp apr-1.lib(apr_atomic.obj) : error LNK2001: unresolved external symbol _InterlockedCompareExchangePointer Release/isapi_redirector2.dll : fatal error LNK1120: 1 unresolved externals Error executing link.exe. isapi_redirector2.dll - 2 error(s), 0 warning(s) I know this issue well, it is related to latest APR 1.0; please use APR 0.9.x for now; APR 1.0 cant be compiled with MSVC6, but this issue is a Platform SDK problem; I've heard that MSVC7 doesnt have this issue. So either update the Platform SDK or compiler, or use APR 0.9.x Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Minimal HOWTO for jk2 2.0.4 - proposal
Hi, How did users see documentation in tomcat-docs ? after this simple setup you are at once able to browse the tomcat-docs through the connector; see Mladen's minimal wokers2.properties file... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2 BUILD.txt
Hi, +There is a known issue with the latest APR 1.0 and MSVC6. +If you want to use MSVC6, please use APR 0.9.x for now. +MSVC7 doesnt have this issue, and could be used with APR 1.0. + cool! I've just fired a message to apr list, perhaps I get this time soemthing back...; have an eye on it... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2 BUILD.txt
Hi, additions for NetWare: = Buid the JK2 connector for NetWare platform. The current NWNGUmakefile uses the same build system as Apache2 self for NetWare target. Simply extract the downloaded archive, and follow the guideline which describes compilation of Apache2 self. After you have compiled Apache2 (this is mandatory for now since the prebuild process must have finished) you can simply call the makefile with 'make -f NWGNUmakefile', this builds the connector for Apache2 in a release or debug subdirectory, dependent if you specify to build a debug version or not. It is recommended to use Metrowerks CodeWarrior compiler for now; although the connector builds with GCC for NetWare, it is not tested yet if it works - there are known issues with a bitfied and alignment which have to be solved. = I have also another build version which I believe is more simple, but this would require that we add another Makefile.netware to the apache2 dir; this uses a ready-to-use 'apache2 sdk' which is the same as what comes with the Win32 Apache2 by default (include and lib dirs); so no compile of whole Apache2 mandatory. I offer this 'apache2 sdk' on Novell Forge. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Minimal HOWTO for jk2 2.0.4 - proposal
Hi Kurt, I like the idea of this and the text is good. I would think you would need to cover how to install if the user is using a non-default directory structure. I'm not sure if its common on Netware and W32, but the *BSD's each use different locations for conf and modules. right, that's missing; will add soon. I'd like to see the mod_jk2.conf. At what location in httpd.conf should it be included? You probably want to be specific about that. hmm, since we have fixed recently the hooks it shouldnt matter anymore where you load mod_jk2; here's the rest od my minimal config, and my main goal was that the host:port does only appear _once_ in the config: http://www.gknw.com/development/apache/docs/win32/mod_jk2/ http://www.gknw.com/development/apache/docs/win32/mod_jk2/min_w2.properties another thing we should get around are the sometimes nasty defaults: if you specify f.e. myworkers2.prop as file, but have also a workers2.properties in the conf dir, then _both_ are used by mod_jk2, this isnt a good behavior; but unfortunately I had no time yet to look at this closer... Just a nitpick, but you may want to change 'volume' to 'drive' for win32. ups! copypaste error, will fix. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Minimal HOWTO for jk2 2.0.4 - proposal
Hi Kurt, hmm, since we have fixed recently the hooks it shouldnt matter anymore where you load mod_jk2; D'oh!. ;-) Out of habbit I always do the LoadModule in the DSO section, but you're right it shouldn't matter. in theory what really happens will tell us BugZilla after we have 2.0.4 out the door, smile... but I believe it is always good if you load mod_jk2 as last module cause last=first in the chain, just take a look at /server-info and you see that the order is reversed. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2 BUILD.txt
Hi Henri, I hope you don't mind, but I rewrote the build instructions for Unix-like systems. If its OK with you I'd like to commit this (or something like it). Of course comments, additions or criticisms welcome too. ;-) -Kurt looks very good! +1 Guenter. Information on building mod_jk2: Starting with 2.0.4, APR is mandatory for jk2. For Apache 2.0 or greater jk2 will use APR that was used to build Apache 2.0. For Apache 1.3, jk2 must build APR and APR_UTIL from source. DSO build instructions for Unix-like systems: The compiler used to build jk2 must match the one used to build Apache. You may need to set an environment variable before configuring such as CC=cc. `apxs -q CC` will tell you what compiler was used for Apache. The most straightforward way to configure jk2 is to use apxs that comes with Apache. Linux distributions may need to have additional rpm's installed such as Apache2 devel rpm, httpd-devel or apache2-devel or for Apache 13, Apache devel rpm, httpd-devel or apache-devel depending on your distribution. Example Apache2 build and install: cd jakarta-tomcat-connectors/jk/native2 ./configure --with-apxs2=/your/path/to/apxs make cd ../build/jk2/apache2 apxs -n jk2 -i mod_jk2.so Example Apache13 build and install: apr and apr-util will be configured and built for you while configuring and building jk2. There is no need to separately configure and build them. cd jakarta-tomcat-connectors/jk/native2 ./configure --with-apxs=/your/path/to/apxs \ --with-apr=/your/path/to/apr-source \ --with-apr-util=/your/path/to/apr-util-source make cd ../build/jk2/apache13 apxs -n jk2 -i mod_jk2.so NOTE: pthread support may be automatically detected and built into apr. If apache13 was not built with pthread support, you can either disable it by adding --disable-apr-threads while configuring, or load the pthread library in httpd.conf using the LoadFile directive. Optional configure arguments (for 1.3 and 2.0): If you want to have JNI support, add --with-jni and be sure to have the JAVA_HOME environment variable point to your Java Environment. This will build inprocess jni support into mod_jk2.so and additionally build libjkjni.so. libjkjni.so can be used by tomcat to provide support for channel unix and should be installed in the apache libexec dir. Use `apxs -q LIBEXECDIR` if you are unsure of its location. Libjkjni.so will be located in the same directory as mod_jk2.so after building with this option. If you want to have PCRE (Perl Compatible Regular Expressions) support for jk2 uri directives, add --with-pcre while configuring. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[DOCUMENTATION] ask for help to clarify terms and other questions
Hi all, Sorry, it took some longer, but I've just put together a basic document of terms coupled with a guestbook script: http://www.gknw.com/test/jtc_terms/index.html every help in completing such a docu is greatly appreciated! Please add your comments! Guenter. PS: I had no time to make it nice, but at least everyone can add a comment - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Minimal HOWTO for jk2 2.0.4 - proposal
Hi, Here are the HOWTOs I use for binary distributions: NetWare: This is a binary package of mod_jk2. If you have installed Apache2 to the default location /Apache2 then simply extract this archive directly to the root of your volume. Use the 'Include' directive to add mod_jk2.conf to your httpd.conf. Rename the workers2.properties.minimal to workers2.properties, then edit the file and change the host and port setting if necessary. On NW 6.0 the default Tomcat listens on 9009 while with NW 6.5 Tomcat listens on 9010. After restarting Apache2 you should be able to browse the Tomcat documentation with this link: http://your.domain.com/tomcat-docs/ This docs also include mod_jk2. version : 2.0.4 license : http://www.apache.org/licenses/LICENSE-2.0.txt Win32: This is a binary package of mod_jk2. If you have installed Apache2 to the default location /Apache2 then simply extract this archive directly to the root of your volume. Use the 'Include' directive to add mod_jk2.conf to your httpd.conf. Rename the workers2.properties.minimal to workers2.properties, then edit the file and change the host and port setting if necessary. After restarting Apache2 you should be able to browse the Tomcat documentation with this link: http://your.domain.com/tomcat-docs/ This docs also include mod_jk2. version : 2.0.4 license : http://www.apache.org/licenses/LICENSE-2.0.txt here follows the directory structure I use: ./apache2 /conf /workers2.properties.minimal /mod_jk2.conf /modules /mod_jk2.dll|nlm|so /ver-info /mod_jk2 /README /CHANGES /STATUS /INSTALL comments? Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [Vote] Guenter Knauf as commiter
Hi all, thank you all for your votes! I want to introduce a bit who I am and what I'm doing when I'm not on the list. I'm a self-employee, and my daily work is mainly keeping the various servers (NetWare, Linux, Win32) of my customers running. In addition I also write interfaces to special databases, backup scripts, tools, etc., all very special for my customers. I do a lot with Perl and PHP, but NetWare often forces me to write in C since some of the scripting languages lack of functions which I have on Linux and Win32. In my freetime I maintain my website with a couple of Apache module binaries as well as Apache self. I started initially only with NetWare binaries, that was with Apache 1.3.12; later I added Win32 binaries because I always needed to have something to compare to see if issues are NetWare only, or apply to all suported platforms. Win32 was the choice because of the similar file system structure, both have 'drive letters', on NetWare they are called volumes, and can be much longer than only one letter (but minimum I think 2 chars, or is it 3?). Meanwhile I have Win32 downloads ten times as much as NetWare... Also I'm a SysOp of the Novell Developer forums, and try to help there other developers in getting their Apache1|2 / Perl / PHP problems solved. Also I maintain mod_edir which is a Novell OpenSource module for access control. This is my relationship to Novell, and although I get an _excellent_ support from Novell, I'm not hired. How came I to this list?? Well, mostly Norm and other developers on the forums where guilty for that. There were always questions about 'when will we get mod_jk2 on NetWare?' which I couldnt ask, and Norm kept the ball in move consequently, he tried everything he could manage from his side, but he had to struggle always because our official compiler is is a thing which nobody buys just for fun, just like MSVC. Although meanwhile we have also gcc available, we have still issues with the builds together with Apache (alignment stuff, bitfiels in Apache). Well, now I can answer the questions in the forums that we _have_ mod_jk2 for NetWare..., smile... so thanks again to all for their patience with all the commits! my main focus for the future will be JK and JK2 connectors, keep them compilable with latest Apache2.1 on NetWare, Win32 and Linux (I'm also on the httpd dev list, and seems that we will soon get a first 2.1.0, thanks Sander!). thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Minimal HOWTO for jk2 2.0.4 - Was: [Fwd: Releasing JK 2.0.4]
Hi all, probably now I get the -1's back, but nevertheless I'll give it a try...! Did some of you, JFC, Mladen, Guenter, Kurt, Norm could works on a little HOWTO (text based will be suffisant) for jk2, explaining how to set up jk2 in IIS and Apache 2 web-servers ? It could be added to the release and will help remove tons of questions from tomcat-users :) Volunteers welcome (I can't work on it right now) hmm, I think Norm has already offered that he's more than willing to improve the Apache2 docu; and in addition he has already put together such an document in html for NetWare, and I modified it slighty for Win32 (I linked to recently). But since we have to deal with a lot of terms which are almost not or insuffient explained, I think we should all here put the heads together, specially also those which have started with the initial mod_jk2 project, so that we can find proper descriptions of all those terms which also f.e. appear on the jkstatus pages. While I digged last time through BugZilla, I also have read a bunch of cvs commit logs to understand why what was changed, changed then back and so on; and I got the strong feeling that even those who have commited the changes often only did what users requested, but didnt know for sure what's right and what's wrong behaviour. What I have heard a lot is 'read the code', but that isnt allways the best answer, its useless to read the code and understand what's going on unless you know from a docu what's right and what's wrong behaviour; we all should know what the module _should_ do before we try to archive that. I've forwarded a html document to Henri and Mladen which Norm has created, and we all are not able to answer the questions fully and decribe what the terms really mean. Norm will be online in about 1 hour (Australia), and I hope he agrees that we make his document here available It would be very great if all here familar with the connector stuff could clarify this, so that we have a good starting point for any further documentation. I believe that we in one day could put all info together if everyone reads this document with the terms in question, and posts what he thinks is the best description; and also I would like to get replies from all other non-commiters here if that what we put together is understandable at all. something other we should perhaps also discuss is the format of the docu. I think that it is most likely that someone who installs a web connector has also a web browser; and therefore I'm +1 for a html document; however everyone has certainly a text editor, and IIRC Henri and Mladen are +1 for plain text. Since it doesnt matter what we use, I would like to see some feedback from those admins who have to install the connectors what they would prefer. thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Thanks to all commiters here
Hi all, I want to say a big THANKS to all commiters here for their fantastic work and co-work with the others here from the list -- that makes participating on an OpenSource project like the jt connectors much more fun. Now we have not only made compiling for NetWare a lot easier, but also got mod_jk2 running on NetWare, and improved the mod_jk2 module for all platforms! Also I want to give some more positive feedback I got from other users which where brave enough to test all the CVS builds I did in the past even already in production: they all said mod_jk2 is faster than mod_jk, and that on both NetWare and Win32 platforms! Now only a release can show up the remaining issues if there are any. Again, thanks for all your help! greets, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] makefiles for native on NetWare
Hi Henri, here are 3 makefiles for compiling jni, netscape and apache-1.3 targets for NetWare without Ant. would be nice to have them in CVS. http://www.gknw.com/test/jtc_makefiles.zip thanks, Guenter. Commited thanks; but unfortunately there where dependencies to Makefile.NetWare which now do not work since you lowercased to Makefile.netware. Can you please then also do a s/Makefile.NetWare/Makefile.netware/g through the three makefiles to fix this? thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] ./jk/native/isapi/isapi.dsp - remove notes.lib dependence
Hi, this patch removes wrong dependence on notes.lib from isapi.dsp. http://www.gknw.com/test/isapi.dsp.diff --- isapi.dsp.orig Thu Feb 12 10:34:34 2004 +++ isapi.dsp Tue Mar 16 14:56:58 2004 @@ -54,7 +54,7 @@ # ADD BSC32 /nologo LINK32=link.exe # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /nologo /dll /machine:I386 -# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib notes.lib /nologo /dll /machine:I386 /out:Release/tomcat_redirector.dll /libpath:C:\notesapi\lib\mswin32 +# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib /nologo /dll /machine:I386 /out:Release/tomcat_redirector.dll !ELSEIF $(CFG) == isapi - Win32 Debug @@ -81,7 +81,7 @@ # ADD BSC32 /nologo LINK32=link.exe # ADD BASE LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib /nologo /dll /debug /machine:I386 /pdbtype:sept -# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib notes.lib /nologo /dll /debug /machine:I386 /out:Debug/tomcat_redirector.dll /pdbtype:sept /libpath:C:\notesapi\lib\mswin32 +# ADD LINK32 kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib odbc32.lib odbccp32.lib wsock32.lib /nologo /dll /debug /machine:I386 /out:Debug/tomcat_redirector.dll /pdbtype:sept !ENDIF Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal
great!! That was really missing!
Guenter.
mturk 2004/03/16 07:30:34
Added: jk/conf workers2.properties.minimal
Log:
Add the minimal workers2.properties.
It can be used as a drop-in working config for standard instalation
where the TC and server are on the same box.
Revision ChangesPath
1.1
jakarta-tomcat-connectors/jk/conf/workers2.properties.minimal
Index: workers2.properties.minimal
===
#
# This is the minimal JK2 connector configuration file.
#
[logger]
info=Native logger
level=ERROR
[config:]
file=${serverRoot}/conf/workers2.properties
debug=0
debugEnv=0
[uriMap:]
info=Maps the requests.
debug=0
[shm:]
info=Scoreboard. Required for reconfiguration and status with
multiprocess servers
file=anonymous
debug=0
[workerEnv:]
info=Global server options
timing=0
debug=0
[lb:lb]
info=Default load balancer.
debug=0
[channel.socket:localhost:8009]
info=Ajp13 forwarding over socket
debug=0
tomcatId=localhost:8009
[uri:/admin]
info=Tomcat HTML based administration web application.
debug=0
[uri:/manager]
info=A scriptable management web application for the Tomcat Web Server.
debug=0
[uri:/jsp-examples]
info=JSP 2.0 Examples.
debug=0
[uri:/servlets-examples]
info=Servlet 2.4 Examples.
debug=0
[uri:/*.jsp]
info=JSP Extension mapping.
debug=0
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal
Hi Mladen, Well, not such a big deal :). but was missing... What I'd like to do is to make a JK2 distribution (perhaps even 2.0.4) to include the README, INSTALL, and CHANGES. Inside INSTALL can be few workers2 samples, README and CHANGES are already in jk/native2. that's exactly what I already do with my binaries, just look at my site; but with latest I believe I had even a better idea: I have packed it in such a way that you can directly extract it over the Apache2 dir so that all files are already in place; my structure looks like: ./apache2 /conf /workers2.properties.minimal /mod_jk2.conf /modules /mod_jk2.dll|nlm|so /ver-info /mod_jk2 /README /CHANGES /STATUS /INSTALL The INSTALL can include some except from xdocs. I can make that, but would rather see some native speaker involved. here's what Norm has put together: http://www.gknw.com/development/apache/docs/win32/mod_jk2/ http://www.gknw.com/development/apache/docs/netware/mod_jk2/ I think this is a good base. That would change the distribution types from simply shiping .dll (or .so) to creating either .zip or .tgz archives for particular platfom. that should be no problem since I brought that already on the table, and there was a common agreement. please take a look at this archive: http://www.gknw.com/development/apache/httpd-2.0/netware/modules/mod_jk2-20040228232017-2.0.49-dev-nw.zip which is a sample of the above, and in addition uses also an archive comment which is displayed when opened with WinZip. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: cvs commit: jakarta-tomcat-connectors/jk/conf workers2.properties.minimal
Hi Mladen, here's what Norm has put together: http://www.gknw.com/development/apache/docs/win32/mod_jk2/ http://www.gknw.com/development/apache/docs/netware/mod_jk2/ I think this is a good base. Well, i was thinking to something like txt file (INSTALL from Apache2 for example), I meant more the content, not the format; its easy to convert this to a plain text document. that has both httpd.conf and workers2.minimal in it along with either .rpm install instructions, or howto build from source. hmm, I thought we are talking about binary dists, so building from source shouldnt be covered there; IMO building from source should go into a separate document, because that's probably a far bigger document if we really cover building for all platforms. My intention was to get ready within 2 minutes, that means that in the ideal case you only have to extract the binary archive over the Apache2 directory and put one line 'Include conf/mod_jk2.conf' into httpd.conf, and after a restart you are already able to check the Tomcat samples - of course provided that TC runs on the same host. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c
Hi Henri,
[EMAIL PROTECTED] wrote:
hgomez 2004/03/01 05:47:23
Modified:jk/native/common jk_ajp_common.c
Log:
More debug/trace infos on remote tomcats
I added more infos on IP/PORT of remote tomcats in jk, since I've some
reports that there is a problem for admins to determine which tomcat
is down when they have many workers defined...
I overcome the inet_ntoa by using a jk_dump_hinfo function which should
works also in multi-threaded env.
It should works on Unixes, but I'd like to have reports from
Win32, Netware and others exotics OS users...
the change of
--- jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/02/24 08:45:48 1.17
+++ jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/03/01 13:37:38 1.18
breaks all targets on NetWare: netscape, apache-1.3 and apache-2;
the problem is that in_addr_t and in_port_t are not defined.
Futhermore I consider in_addr_t as a dangerous var, google a bit and you will see that
some OSes define it as unsigned long (which is what we need here) while others define
it to a struct in_addr. NetWare also defines it to the in_addr struct so that its
useless here - and even more ugly it would be if I had to include netinet/in.h for
other reasons, then I would have to undef at least in_addr_t.
So we should avoid these typedefs at all, and simply use ulong and ushort.
--- jk_connect.c.orig Mon Mar 15 16:04:08 2004
+++ jk_connect.c Mon Mar 15 18:16:28 2004
@@ -288,8 +288,8 @@
*/
char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
{
- in_addr_t laddr = htonl(saddr-sin_addr.s_addr);
- in_port_t lport = htons(saddr-sin_port);
+ unsigned long laddr = htonl(saddr-sin_addr.s_addr);
+ unsigned short lport = htons(saddr-sin_port);
sprintf(buf, %d.%d.%d.%d:%d,
(int)(laddr 24), (int)((laddr 16) 0xff), (int)((laddr 8)
0xff), (int)(laddr 0xff), (int)lport);
I've not tested this yet, but at least I can now compile again. In addtion our older
clib has a strange behavior with these functions, so there's certainly another
additional patch needed for apache-1.3 and netscape; apache-2 should work with the
above.
btw: we should really take care of tabs and avoid them - as outlined in the ASF
developer docs. Currently there are a couple of files which contain tabs, they should
be removed IMO.
Guenter.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] makefiles for native on NetWare
Hi, here are 3 makefiles for compiling jni, netscape and apache-1.3 targets for NetWare without Ant. would be nice to have them in CVS. http://www.gknw.com/test/jtc_makefiles.zip thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native/common jk_connect.c
Hi Henri,
just tested that it breaks compilation on Win32 platform to -- my patch solved it.
Guenter.
[EMAIL PROTECTED] wrote:
hgomez 2004/03/01 05:47:23
Modified:jk/native/common jk_ajp_common.c
Log:
More debug/trace infos on remote tomcats
I added more infos on IP/PORT of remote tomcats in jk, since I've some
reports that there is a problem for admins to determine which tomcat
is down when they have many workers defined...
I overcome the inet_ntoa by using a jk_dump_hinfo function which should
works also in multi-threaded env.
It should works on Unixes, but I'd like to have reports from
Win32, Netware and others exotics OS users...
the change of
--- jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/02/24
08:45:48 1.17
+++ jakarta-tomcat-connectors/jk/native/common/jk_connect.c 2004/03/01
13:37:38 1.18
breaks all targets on NetWare: netscape, apache-1.3 and apache-2;
the problem is that in_addr_t and in_port_t are not defined.
Futhermore I consider in_addr_t as a dangerous var, google a bit and you
will see that some OSes define it as unsigned long (which is what we need
here) while others define it to a struct in_addr. NetWare also defines it
to the in_addr struct so that its useless here - and even more ugly it
would be if I had to include netinet/in.h for other reasons, then I would
have to undef at least in_addr_t.
So we should avoid these typedefs at all, and simply use ulong and ushort.
--- jk_connect.c.origMon Mar 15 16:04:08 2004
+++ jk_connect.c Mon Mar 15 18:16:28 2004
@@ -288,8 +288,8 @@
*/
char * jk_dump_hinfo(struct sockaddr_in *saddr, char * buf)
{
-in_addr_t laddr = htonl(saddr-sin_addr.s_addr);
-in_port_t lport = htons(saddr-sin_port);
+unsigned long laddr = htonl(saddr-sin_addr.s_addr);
+unsigned short lport = htons(saddr-sin_port);
sprintf(buf, %d.%d.%d.%d:%d,
(int)(laddr 24), (int)((laddr 16) 0xff), (int)((laddr
8) 0xff), (int)(laddr 0xff), (int)lport);
I've not tested this yet, but at least I can now compile again. In addtion
our older clib has a strange behavior with these functions, so there's
certainly another additional patch needed for apache-1.3 and netscape;
apache-2 should work with the above.
btw: we should really take care of tabs and avoid them - as outlined in
the ASF developer docs. Currently there are a couple of files which
contain tabs, they should be removed IMO.
Guenter.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 new shmem using APR
Hi, I believe there's a problem with the file rights, not with SHM self. I think the scoreboard is created by the init process, but later on when the child wants to access it it has insufficient rights. I think I'm seeing that same problem with Apache 2.0.48 and the latest j-t-c code on Debian. thanks for letting us know here! So seems we have to insert some code to make sure the file rights are fine Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] ./jk/native2/common/jk_worker_status.c - dont print style with text/plain
Hi,
this simple patch supresses the output of the style when we are in text/plain mode.
--- jk_worker_status.c.orig Mon Mar 15 16:04:08 2004
+++ jk_worker_status.c Tue Mar 16 04:02:24 2004
@@ -953,7 +953,10 @@
s-head(env, s );
-s-jkprintf(env, s, style%s/style\n, DEFAULT_CSS );
+if( !(s-query_string != NULL
+strncmp( s-query_string, qry=, 4) == 0 ) ) {
+s-jkprintf(env, s, style%s/style\n, DEFAULT_CSS );
+}
/** Process the query string.
*/
Guenter.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: Re: cvs commit: jakarta-tomcat-connectors/jk/xdocs/jk2 configwebcom.xml
Oh, how I love this: the one idiot's virus replies to the other idiot's virus or something like that!! VERY GREAT! Well, one more, and I (and probably 20 more) unsubscribe! That makes no fun anymore here on the list!!! now since the viruses reply to each other anyway no real human poster is necessary any more to keep traffic on the list. --- [EMAIL PROTECTED] wrote: This account does not exist - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] __ Do you Yahoo!? Yahoo! Mail - More reliable, more storage, less spam http://mail.yahoo.com - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: libjkjni and pcre build
Hi Kurt, thanks for going this way - I have no choice on NetWare since the PCRE functions are not exported at all. Guenter. I misstated something before. The pcre change is not a problem for inprocess mode, its a problem for jni out of process mode (i.e. apr.NativeSo=libjkjni.so). I think the most reasonable solution is to work as follows: --with-pcre and no --with-jni, use apache pcre functions --with-pcre and --with-jni, use external pcre functions --with-pcre is absent, no pcre support. So if you want pcre you will need to specify it when configuring. You will get either apache pcre or external pcre depending if you specify --with-jni or not. I'll go forward with this unless someone has a better idea. -Kurt From: Kurt Miller [EMAIL PROTECTED] libjkjni is built when --with-jni is not specified at configure time. When this happens it is not usable, so I'll be changing the build to only build libjkjni when --with-jni is specified. I overlooked one thing with the recent pcre changes I committed. The functions ap_pregcomp and ap_regexec will not be available to libjkjni.so and are left unresolved. This will be a problem for jni inprocess mode. I have to make a change to correct this. Two options I see are: 1) Revert to old behavior and not use ap_pregcomp and ap_regexec at all. This is the most straightforward. If you want pcre then you must specify it with --with-pcre. 2) Use ap_pregcomp and ap_regexec only when --with-jni is not specified. This would behave as follows: a) if --with-pcre and --with-jni are not specified then use ap_pregcomp and ap_regexec. b) if --with-jni is specified but -with-pcre is not, then no pcre support. c) if --with-jni and --with-pcre are specified then use regcomp and regexec. Option two is a bit more confusing but gives more flexibility. I'm leaning towards reverting to the old behavior. Thoughts anyone? -Kurt - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 new shmem using APR
Hi, [EMAIL PROTECTED] wrote: As per above, Solaris apr build appears to have bugs. As yet I have not had the time to look at why. I believe there's a problem with the file rights, not with SHM self. I think the scoreboard is created by the init process, but later on when the child wants to access it it has insufficient rights. Greg who reported the problem on Solaris posted an 'ls' of the files created from APR and created from the older code which Henri did put in for me, and there you could see the difference... Greg, can you please repost this? I saw these problems with another 3rd party module too (mod_watch), and I looked for a solution, I've looked at this: /** * Set a file to be inherited by child processes. * */ APR_DECLARE_INHERIT_SET(file); which might probably solve it, but not tested yet with mod_jk2; with the other module it didnt work, and I asked at the httpd-dev list and was told that I should look at mod_ssl which does some tricks to make sure that files created by init are later accessable from this point of view APR is probably not broken, and we need to do some more than only open the scoreboard file to make sure it is later accessable. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[OT] unsubscribe stupid users with auto-replies
Hi all, I think that it is only fair for all others that those on the list which are too stupid to setup a separate mail account are directly unsubscribed once the list gets auto-replies about their absence. We have already enough spam, and its nearly impossible to filter those senseless mails. If this continues it will not last long till those who really want to follow the list and post useful stuff will leave - but then the problem is also solved because: no real posts = no stupid auto-replies = dead list. thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] ./jk/native2/server/apache2/mod_jk2.c - correct log entries
Hi,
found some misleading entries in the logs...
http://www.gknw.com/test/mod_jk2.c.diff
--- ./jk/native2/server/apache2/mod_jk2.c.orig Thu Mar 04 18:24:50 2004
+++ ./jk/native2/server/apache2/mod_jk2.c Mon Mar 08 04:08:44 2004
@@ -193,7 +193,7 @@
* Here we must now 'fix' the content of the object passed in.
* Apache doesn't care what we do here as it has the reference to the unique
object that has been
* created. What we need to do is ensure that the data given to mod_jk2 is
correct. Hopefully in the long run
- * we can ignore some of the mod_jk details...
+ * we can ignore some of the mod_jk2 details...
*/
/* if applicable we will set the hostname etc variables. */
@@ -405,11 +405,11 @@
if( s-is_virtual ) {
/* Virtual host */
ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, p,
- mod_jk Create config for virtual host %s,
+ mod_jk2 Create config for virtual host %s,
s-server_hostname );
} else {
ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, p,
- mod_jk Create config for default server %s,
+ mod_jk2 Create config for default server %s,
s-server_hostname );
}
@@ -436,7 +436,7 @@
jk_uriEnv_t *overrides = (jk_uriEnv_t *)overridesv;
ap_log_perror(APLOG_MARK, APLOG_DEBUG, 0, p,
- mod_jk Merging workerEnv);
+ mod_jk2 Merging workerEnv);
/* The 'mountcopy' option should be implemented in common.
@@ -508,7 +508,7 @@
*mainPool=gPool;
/* We have a global pool ! */
-apr_pool_userdata_get( data, mod_jk_init, gPool );
+apr_pool_userdata_get( data, mod_jk2_init, gPool );
if( data==NULL ) {
return JK_OK;
} else {
@@ -540,14 +540,14 @@
if( rc == JK_OK gPool != NULL ) {
/* This is the first step */
env-l-jkLog(env, env-l, JK_LOG_INFO,
- mod_jk.post_config() first invocation\n);
+ mod_jk2.post_config() first invocation\n);
-apr_pool_userdata_set( INITOK, mod_jk_init, NULL, gPool );
+apr_pool_userdata_set( INITOK, mod_jk2_init, NULL, gPool );
return OK;
}
env-l-jkLog(env, env-l, JK_LOG_INFO,
- mod_jk.post_config() second invocation\n );
+ mod_jk2.post_config() second invocation\n );
workerEnv-parentInit( env, workerEnv);
return OK;
@@ -621,11 +621,11 @@
jk2_init( env, pconf, workerEnv, s );
if (workerEnv-childId = 0)
-env-l-jkLog(env, env-l, JK_LOG_INFO, mod_jk child %d initialized\n,
+env-l-jkLog(env, env-l, JK_LOG_INFO, mod_jk2 child %d initialized\n,
workerEnv-childId);
}
if (workerEnv-childGeneration)
-env-l-jkLog(env, env-l, JK_LOG_ERROR, mod_jk child workerEnv in error
state %d\n,
+env-l-jkLog(env, env-l, JK_LOG_ERROR, mod_jk2 child workerEnv in error
state %d\n,
workerEnv-childGeneration);
/* Restore the process generation */
@@ -674,7 +674,7 @@
/* Set up r-read_chunked flags for chunked encoding, if present */
if(rc = ap_setup_client_block(r, REQUEST_CHUNKED_DECHUNK)) {
env-l-jkLog(env, env-l, JK_LOG_INFO,
- mod_jk.handler() Can't setup client block %d\n, rc);
+ mod_jk2.handler() Can't setup client block %d\n, rc);
workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
return rc;
}
@@ -684,21 +684,21 @@
if( worker==NULL uriEnv-workerName != NULL ) {
worker=env-getByName( env, uriEnv-workerName);
env-l-jkLog(env, env-l, JK_LOG_INFO,
- mod_jk.handler() finding worker for %#lx %#lx %s\n,
+ mod_jk2.handler() finding worker for %#lx %#lx %s\n,
worker, uriEnv, uriEnv-workerName);
uriEnv-worker=worker;
}
if(worker==NULL || worker-mbean == NULL || worker-mbean-localName==NULL ) {
env-l-jkLog(env, env-l, JK_LOG_ERROR,
- mod_jk.handle() No worker for %s\n, r-uri);
+ mod_jk2.handle() No worker for %s\n, r-uri);
workerEnv-globalEnv-releaseEnv( workerEnv-globalEnv, env );
return HTTP_INTERNAL_SERVER_ERROR;
}
if( uriEnv-mbean-debug 0 )
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
- mod_jk.handler() serving %s with %#lx %#lx %s\n,
+ mod_jk2.handler() serving %s with %#lx %#lx %s\n,
uriEnv-mbean-localName, worker, worker-mbean,
worker-mbean-localName );
/* Get a pool for the request XXX move it in workerEnv to
@@ -708,7 +708,7 @@
rPool=worker-mbean-pool-create( env, worker-mbean-pool,
Re: DO NOT REPLY [Bug 15278] - Yoav, please unsubscribe!
This account does not exist Yoav, can you please unsubscibe this address: [EMAIL PROTECTED] thanks! Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi, Also, we adopted the APR as mandatory, so, all platform specific code except JNI has to go out (sooner or later). sure, I know - but you cant expect that every APR also supports SHM/MMAP; so cant we take only those things which are common to all platforms? Does it work in APR from CVS? no. If not then it's a bug in APR. no. If it's a APR bug are there any patches that we can propose? no. The problem is the NetWare OS self. We had formerly no SHM support at all on NetWare, and since about a year we got mmap() silently, but with EXPERIMENTAL status. Since we ship recent NetWare versions with Apache (1.3 with NW6 and 2.0 with NW6.5) I cant introduce another Apache with experimental stuff in it - instead I have to rely on what's officially released - NW admins are just used to fetch a binary and drop it in, they have no plan of recompiling Apache, nor they are able to do even if they would like since NetWare doesnt ship with a compiler at all. The netware, and windows doesn't need shm at all. that's not true from APR sight: if I look into apr.h for NetWare I have not one define for SHM, but looking at apr.h from Win32 platform I can see: #define APR_HAS_SHARED_MEMORY 1 #define APR_HAS_MMAP 1 The final solution would be adding jk2_shm_ (for specific platform), inside commons/arch. I'm not in favor of using #defines to solve that. +1. If the number of needed platform specific workarounds is too high, then we made a mistake switching to APR, but I doubt. no, the switch is OK, but it was probably only too early to make it mandatory. I would have left the old code in; it was known to work, and didnt bite someone; and at least for Apache 1.3 I'm not happy with the change to APR. If I had choosen to make APR mandatory I also would have dropped Apache 1.3 support at all from mod_jk2. Let's make and test, and then we'll see how to solve the particular problem for a XXX.XXX platform. what we all need is time - those working at APR, as well as the OS core folks - I'm sure all these things will be fixed sooner or later, but unless Apache 2.x gets widely accepted there will not be so much pressure to fix those things I feel I'm next month at Novell and will certainly discuss this issue with the core OS team - after that I hope I have an idea if we get mmap() and friends exported by the OS officially, and how long it may take. I really would like to have APR_HAS_MMAP on NetWare since a couple of other interesting modules rely on it; and be sure that I bother them at Novell enough with this. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [OT] problems posting attachments to the list - Yoav??
Hi Yoav, That's because OE6 will strip potentially dangerous attachements (= nearly anything). I dont use OE, so that's not the problem for me. Basically, no ;) I can't look into it, as the policy regarding attachements is ASF-general. The tomcat lists are no different from all other ASF lists, I couldn't make them different even if I tried. That's not true: - I'm suscribed to apr and httpd-dev lists, and there attachments work. - The Tomcat list _is_ different since it's the only list appending the unsubscribe information footer. I bed that the issue is gone if you remove the footer. Consider using Bugzilla to attach patches to known issues. A patch without a matching Bugzilla attachment is more likely to be ignored/missed anyways. that's not ok for a developer's list; the list is for proposed patches and discussions about patches, buzilla is for bugs. According to your oppinion we can close then this mailing list here and do all conversation through bugzilla. In addition its totally senseless if we ask people for unified diffs, and the attachments are then dropped and the one who wants to commit the patch has to copypaste from the mail my 2ct. thanks for your reply. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [OT] problems posting attachments to the list - Yoav??
Hi, I bed that the issue is gone if you remove the footer. That's not in my power to try: contact the general apache mail administrator with your concerns and suggestions for this issue. ok, thanks. No, read what I said carefully. You can discuss things all you want here, and it's the right place to do it. A patch without an issue (including enhancement issues) is not likely to be applied, because it's bugzilla we primarily consult when doing releases. ok got that. thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi, Look at my today post (JK2 shm). It's going to use the shm. If the platform is missing APR_HAS_SHARED_MEMORY the shm will be disabled. Also you can alway set the shm to disabled if the APR platform MMAP is buggy. but what will we all loose if then the scoreboard isnt active?? Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi Mladen, but what will we all loose if then the scoreboard isnt active?? In case of single child mpm, nothing. On others, jkstatus at least. so the scoreboard is only for collecting stats? Also, we adopted the APR as mandatory, so, all platform specific code except JNI has to go out (sooner or later). sure, I know - but you cant expect that every APR also supports SHM/MMAP; so cant we take only those things which are common to all platforms? I mean, I see there's a workaround for HPUX, so why not a workaround for NetWare and Solaris and whatever else platform with broken shm too? Apache2 works without shm/mmap in general, so it would be fine if mod_jk2 doesnt expect more than Apache2 from APR Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] ./jk/native2/common/jk_worker_status.c - output non-caching headers
Hi, here's a patch to put non-caching headers out; maybe an 'Expires' header is also needed..? --- jk_worker_status.c.orig Fri Feb 27 12:24:12 2004 +++ jk_worker_status.c Sun Feb 29 19:30:24 2004 @@ -944,6 +944,10 @@ s-headers_out-put(env, s-headers_out, Content-Type, text/html, NULL); } +s-headers_out-put(env, s-headers_out, +Pragma, no-cache, NULL); +s-headers_out-put(env, s-headers_out, +Cache-Control, no-cache, NULL); s-head(env, s ); s-jkprintf(env, s, style%s/style\n, DEFAULT_CSS ); Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[OT] problems posting attachments to the list - Yoav??
Hi Yoav, since you are the list moderator, maybe you can also look into the attachment problem I (and probably others too) have? Every time I attach a patch, when my post returns through the list the attachment is replaced by a 'noname.txt' containing the footer which is normally appended to each post. Can you perhaps solve this issue?? Am I the only one having this problem, or are there others seeing this too? I use AkMail and have no problems on other Apache lists, so it's most likely that there's a problem with the footer which is automatically added, and then destroys the attachment... thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi, Testing the jk2-2.0.3 cvs we seem to get this error, which makes 2.0.3-dev useable for us. you mean 2.0.4-dev? I can only assume others are not seeing this (apache 1.3.26 + mod_perl) on Solaris 2.8 (sparc). Has anyone had any success with 1.3.x on Solaris with the jk2-dev code? look at your apr.h for APR_HAS_MMAP and tell us how this is set... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] jki_shm.c revert code removal v1.35-v1.36
Hi all, I would like to get the MMAP code back into CVS which was removed with version 1.36: http://cvs.apache.org/viewcvs.cgi/jakarta-tomcat-connectors/jk/native2/common/jk_shm.c?r1=1.35r2=1.36 This code would enable the scoreboard working on NetWare; and probably on other platforms too where mmap() support isnt in APR for whatever reason (Solaris?) I've the problem that I cant compile Apache2 with APR_HAS_MMAP cause the mmap() support is new in the NetWare OS, and currently marked as experimental. Nevertheless it works with mod_jk2's scoreboard, and so would enable to test further with mod_jk2 on NetWare... If this gets accepted I can provide also a patch. thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi Greg, look at your apr.h for APR_HAS_MMAP and tell us how this is set... #define APR_HAS_MMAP 1 thats strange. Is is possible that there's a permission issue with creating the file? Can you please try to configure the shm file to be created in a public writable dir, f.e. /tmp or such? Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: JK2 Close to 2.0.4
Hi, -Original Message- From: jean-frederic clere Are there any pending issues that I can help with, so we can make the release. Bugzilla reports 59 bugs... Help is _needed_ !!! How did you came to that number? I'm seeing only 25 of them. I've also have some problems with the bugzilla query; Jean-Frederic, is it possible that you post here the query URL so that we all look at the same...? G. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Hi, Let's go Guenter, send the patch for review http://www.gknw.com/test/jk_shm.c.diff thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Q: why was jk2 doc removed from TC5?
Hi, found yesterday that the jk2 folder belows tomcat-docs is now removed, and the link now goes online to apache.org? what was the reason for this change? Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] jki_shm.c revert code removal v1.35-v1.36
Hi, jean-frederic clere wrote: That is a work-around... The correct would be to fix APR. sure, agreed; and I work closely together with those maintaining Apache at Novell, as well as with the core OS folks; but I cant expect that I have mmap support in APR before the next half year... I agree, but let fix this problem in jk 2.0.4 and will remove it as soon as APR is fixed. thanks, and I promise to provide another patch as soon as we get fixed APR and OS. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi, Permissions should be ok. It does create a file, but with 0 size (even though we have set something like 16m) ie: -rw-r--r-- 1 root other 0 Feb 27 12:31 cr.sandwich.pfizer.com_81.shm Compared to the old version (same config bar the name and old conector used) -rwxr-xr-x 1 root root 1000448 Feb 24 11:14 shm.file hmm, seems not so ok to me; I believe the init creates the file, and the child cant access it... can you please try to change the file open in jk_shm.c at line 100 and test if it perhaps fixes the issue? /* First make sure the file exists and is big enough */ rc=apr_file_open( file, shm-fname, APR_READ | APR_WRITE | APR_CREATE | APR_BINARY, APR_WREAD|APR_WWRITE|APR_WEXECUTE, globalShmPool); Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi Greg, Same sort of issue: [Fri Feb 27 15:12:08 2004] (error ) [jk_shm.c (163)] shm.create(): error creating /tmp/cr.sandwich.pfizer.com_81.shm 2117992 22 0x1f5020 Invalid argument [Fri Feb 27 15:12:08 2004] (error ) [jk_shm.c (238)] shm.create(): error mmapping /tmp/cr.sandwich.pfizer.com_81.shm ( 22 = Invalid argument ) Ideas? hmm, you could check to use the old mmap code which Henri just has checked in again; get latest jk_shm.c from cvs and modifiy it to ignore APR_HAS_MMAP and use HAVE_MMAP instead; if that works then we know for sure that APR mmap supportg is somehow broken on Solaris, and you have to ask in the apr group for a fix... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: [OT] [FW: Please update your email address...]
Hi, There are a variety of causes. We've seen a great increase in the number of 'smart' spam mailers than can subscribe themselves to our lists. Accordingly, the amount of things like the above has increased. The fact that only you get these three messages suggest it's your computer or a computer along the way, such as in your company, that's corrupted with one of these spam mailer worms. I get exactly the same too - and a coule of others also. First I use latest virus scanners, second I use regulary standalone scanners to get those which deactivate scanners, and third which is the most inportant point: I dont use a SPAM mailer such as Outlook; so chances that a worm has subscribed to one of those lists from my machine is == 0. In addition I believe that many do just the same as I: they have a separate account for list post, and a white list which only accepts post from the list server, so normally they dont see those spam... Negative side effect of course is that all private replies to this address get also into the spam folder... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: allowTrace attribute causing problems inthe adminapplication
Hi Jeff, I've not seen the first post from you, so ignore if that isnt your problem... I just did the following steps: 1) downloaded jakarta-tomcat-4.1.30.zip from jakarta.apache.org 2) unzipped the zip file 3) edited conf\tomcat-users.xml, adding the admin and manager roles to the tomcat user 4) Start up Tomcat (catalina start) 5) hit http://localhost:8080 6) Navigate to the Tomcat Administration link 7) login as tomcat 8) Click on the icon that expances Service(Tomcat-Standalone) 9) Click on Connector(8009) 10) have the problem port 8009 isnt free on NetWare but used by RemoteManager, you have to configure another one for the connector in server.xml Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] use ap_ prefixed PCRE functions
Hi Henri, +#include httpd.h httpd.h may not be found for IIS or Netscape, so it will brake these. Ditto for others. yep - found this already; please see my second patch which shouldnt break any other platforms. BTW while testing with this I found that on Linux when compiled with APXS also no PCRE is used... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: jk2 buglets
Hi, Sorry, this seems to be a bad week. The diff should be: $ diff jk_shm.c.org jk_shm.c can you please use unified diffs: diff -u jk_shm.c.org jk_shm.c this is the preferred patch form with all ASF stuff... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] use ap_ prefixed PCRE functions - take 3
Hi Kurt,
I've reviewed your patch and have some comments included inline below.
regcomp and ap_pregcomp are not interchangeable like this. ap_pregcomp
needs an apr_pool to be passed to it and it returns the regex_t. I
think (apr_pool_t *)uriEnv-pool-_private is correct here (Henri?,
Jean-Frederic?).
ok, I believe I got that now. For easier review I copy here the relevant parts of the
headers, followed by the new patch. Please review again - if it is ok so, I put the
patchfile on my host, and add the other suggestions to the makefiles.
thanks, Guenter.
/**
* Compile a regular expression to be used later
* @param p The pool to allocate from
* @param pattern the regular expression to compile
* @param cflags The bitwise or of one or more of the following:
* @li #REG_EXTENDED - Use POSIX extended Regular Expressions
* @li #REG_ICASE- Ignore case
* @li #REG_NOSUB- Support for substring addressing of matches
* not required
* @li #REG_NEWLINE - Match-any-character operators don't match new-line
* @return The compiled regular expression
*/
AP_DECLARE(regex_t *) ap_pregcomp(apr_pool_t *p, const char *pattern,
int cflags);
/**
* Match a null-terminated string against a pre-compiled regex.
* @param preg The pre-compiled regex
* @param string The string to match
* @param nmatch Provide information regarding the location of any matches
* @param pmatch Provide information regarding the location of any matches
* @param eflags Bitwise or of any of:
* @li #REG_NOTBOL - match-beginning-of-line operator always
* fails to match
* @li #REG_NOTEOL - match-end-of-line operator always fails to match
* @return 0 for successful match, #REG_NOMATCH otherwise
*/
AP_DECLARE(int)ap_regexec(regex_t *preg, const char *string,
size_t nmatch, regmatch_t pmatch[], int eflags);
extern int regcomp(regex_t *, const char *, int);
extern int regexec(regex_t *, const char *, size_t, regmatch_t *, int);
###
--- jk_uriEnv.c.origTue Feb 24 12:30:10 2004
+++ jk_uriEnv.c Thu Feb 26 20:34:46 2004
@@ -28,9 +28,15 @@
#include jk_uriMap.h
#include jk_registry.h
+#ifdef HAS_AP_PCRE
+#include httpd.h
+#define PREGCOMP ap_pregcomp
+#else
#ifdef HAS_PCRE
#include pcre.h
#include pcreposix.h
+#define PREGCOMP regcomp
+#endif
#endif
/* return non-zero if pattern has any glob chars in it */
@@ -65,7 +71,7 @@
int pcre = 0;
if (*name == '$') {
-#ifdef HAS_PCRE
+#if defined(HAS_PCRE) || defined(HAS_AP_PCRE)
++name;
uriEnv-uri = uriEnv-pool-pstrdup(env, uriEnv-pool, name);
uriEnv-match_type = MATCH_TYPE_REGEXP;
@@ -74,7 +80,11 @@
name);
{
regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
+#ifdef HAS_AP_PCRE
+if ((preg = ap_pregcomp((apr_pool_t *)uriEnv-pool-_private,
uriEnv-uri, REG_EXTENDED)) == NULL) {
+#else
if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
+#endif
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
uri);
@@ -132,14 +142,18 @@
if (pcre) {
++uri;
uriEnv-match_type = MATCH_TYPE_REGEXP;
-#ifdef HAS_PCRE
+#if defined(HAS_PCRE) || defined(HAS_AP_PCRE)
uriEnv-uri = uriEnv-pool-pstrdup(env, uriEnv-pool, uri);
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() parsing regexp %s\n,
uri);
{
regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
+#ifdef HAS_AP_PCRE
+if ((preg = ap_pregcomp((apr_pool_t *)uriEnv-pool-_private,
uriEnv-uri, REG_EXTENDED)) == NULL) {
+#else
if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
+#endif
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
uri);
###
--- jk_uriMap.c.origTue Feb 24 12:30:10 2004
+++ jk_uriMap.c Thu Feb 26 19:03:32 2004
@@ -34,9 +34,15 @@
#include jk_uriMap.h
#include jk_registry.h
+#ifdef HAS_AP_PCRE
+#include httpd.h
+#define REGEXEC ap_regexec
+#else
#ifdef HAS_PCRE
#include pcre.h
#include pcreposix.h
+#define REGEXEC regexec
+#endif
#endif
static INLINE const char *jk2_findExtension(jk_env_t *env, const char *uri);
@@ -304,7 +310,7 @@
return uriMap-vhosts-get(env, uriMap-vhosts, *);
}
-#ifdef HAS_PCRE
+#if defined(HAS_PCRE) || defined(HAS_AP_PCRE)
static jk_uriEnv_t *jk2_uriMap_regexpMap(jk_env_t *env, jk_uriMap_t *uriMap,
jk_map_t *mapTable, const char *uri)
{
@@ -317,7 +323,7 @@
if (uwr-regexp) {
Re: [PATCH] use ap_ prefixed PCRE functions
Henri, BTW while testing with this I found that on Linux when compiled with APXS also no PCRE is used... What do you means ? just to confirm this quickly I just inserted a line 'xxx' inside the HAS_PCRE in jk_uriEnv.c and compilation went trough without error, while if I add '-DHAS_PCRE' then compilation breaks, so this confirms that HAS_PCRE isnt defined somewhere else, and therefore missing in Makefile.apxs; however I dont know if its ok to add the define to Makefile.apxs.in, or if its better to detect presence of PCRE and let configure add '-DHAS_PCRE' dynamically... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 : ap_hook_translate_name should be APR_HOOK_MIDDLE
Hi, With the actual code in jk2, we can't use mod_alias, for instance ErrorDocument. I changed the ap_hook_translate_name from APR_HOOK_FIRST to APR_HOOK_MIDDLE and I've get the ErrorDocument. jk use also APR_HOOK_MIDDLE for ap_hook_translate_name, so I wonder why it's set to APR_HOOK_FIRST in jk2 (seems to be a bug). I'm waiting for explanation before commiting the fix : Gleen, Mladen, Jean-Frederic, Gunter, advices please I will test that soon; and I believe that APR_HOOK_MIDDLE gives also the user a chance to change something with the load order; I think with APR_HOOK_FIRST there's no chance to change something regardless if you load as first or last module... Also I found some more whoes with APR_HOOK_REALLY_FIRST: I use it in a very simple module which only appends a string to the signature, and I wanted to make sure that the string appears directly after the server signature; while it works fine with Linux and NetWare, on Win32 I get different results: one start it behaves as expected, another start and the string appears _before_ (!!) the server signature as very first string! So the point is that at least on Win32 the hook priority isnt constant but _can_ differ from start to start! here's the simple module if someone wants to test with: http://www.gknw.com/development/apache/httpd-2.0/unix/modules/mod_avc-0.1.1.tar.gz NetWare and Win32 binaries also on my site... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: unknown: TROJAN HORSE?
Hi Michael, I never look at these emails I get because I fear they are spoofs. Are thats best you can do - delete then immediatly. they? This was an email that said it came from the list via [EMAIL PROTECTED] and had an attached file called friend.zip. Is this a trojan horse? its one of those nasty worms, and like all worms it fakes the sender address - so dont be suprised if you see tomorrow one with you as sender Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
RE: Steven Hatala/PH/Novartis is out of the office.
Hi, I'm unsubscribing you so we don't get these automatic responses. thanks is it possible to filter some more from the subject? f.e. recent worms with 're:hi' and 're:unknown' etc.? and perhaps 'autoresponder' too? that would help a lot I believe Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] ./jk/native2/common/jk_worker_status.c - be more verbose
Hi,
patch to be a bit more verbose than showing a blank page when no scoreboard
available...
Guenter.
--- jk_worker_status.c.orig Tue Feb 24 12:30:10 2004
+++ jk_worker_status.c Fri Feb 27 03:43:30 2004
@@ -173,6 +173,7 @@
int needHeader=JK_TRUE;
if( wenv-shm==NULL || wenv-shm-head==NULL) {
+s-jkprintf(env, s, h3No Scoreboard avaiable/h3\n);
return;
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] use ap_ prefixed PCRE functions - take 4
Hi Kurt,
Just a tweak or two and its ready. The preg calloc only applies to the
HAS_PCRE case and PREGCOMP isn't needed. Otherwise it looks good. I'll
test and commit it tomorrow.
thanks again for reviewing and comments!
Guenter.
http://www.gknw.com/test/pcre_patch4
###
--- ./jk/native2/common/jk_uriEnv.c.orig2004-02-24 12:30:10.0 +0100
+++ ./jk/native2/common/jk_uriEnv.c 2004-02-27 00:04:20.0 +0100
@@ -28,10 +28,14 @@
#include jk_uriMap.h
#include jk_registry.h
+#ifdef HAS_AP_PCRE
+#include httpd.h
+#else
#ifdef HAS_PCRE
#include pcre.h
#include pcreposix.h
#endif
+#endif
/* return non-zero if pattern has any glob chars in it */
@@ -65,7 +69,7 @@
int pcre = 0;
if (*name == '$') {
-#ifdef HAS_PCRE
+#if defined(HAS_PCRE) || defined(HAS_AP_PCRE)
++name;
uriEnv-uri = uriEnv-pool-pstrdup(env, uriEnv-pool, name);
uriEnv-match_type = MATCH_TYPE_REGEXP;
@@ -73,8 +77,13 @@
uriEnv.parseName() parsing %s regexp\n,
name);
{
+#ifdef HAS_AP_PCRE
+regex_t *preg = ap_pregcomp((apr_pool_t *)uriEnv-pool-_private,
uriEnv-uri, REG_EXTENDED);
+if (preg == NULL) {
+#else
regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
+#endif
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
uri);
@@ -132,14 +141,19 @@
if (pcre) {
++uri;
uriEnv-match_type = MATCH_TYPE_REGEXP;
-#ifdef HAS_PCRE
+#if defined(HAS_PCRE) || defined(HAS_AP_PCRE)
uriEnv-uri = uriEnv-pool-pstrdup(env, uriEnv-pool, uri);
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() parsing regexp %s\n,
uri);
{
+#ifdef HAS_AP_PCRE
+regex_t *preg = ap_pregcomp((apr_pool_t *)uriEnv-pool-_private,
uriEnv-uri, REG_EXTENDED);
+if (preg == NULL) {
+#else
regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
+#endif
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
uri);
###
--- ./jk/native2/common/jk_uriMap.c.orig2004-02-24 12:30:10.0 +0100
+++ ./jk/native2/common/jk_uriMap.c 2004-02-26 19:03:32.0 +0100
@@ -34,9 +34,15 @@
#include jk_uriMap.h
#include jk_registry.h
+#ifdef HAS_AP_PCRE
+#include httpd.h
+#define REGEXEC ap_regexec
+#else
#ifdef HAS_PCRE
#include pcre.h
#include pcreposix.h
+#define REGEXEC regexec
+#endif
#endif
static INLINE const char *jk2_findExtension(jk_env_t *env, const char *uri);
@@ -304,7 +310,7 @@
return uriMap-vhosts-get(env, uriMap-vhosts, *);
}
-#ifdef HAS_PCRE
+#if defined(HAS_PCRE) || defined(HAS_AP_PCRE)
static jk_uriEnv_t *jk2_uriMap_regexpMap(jk_env_t *env, jk_uriMap_t *uriMap,
jk_map_t *mapTable, const char *uri)
{
@@ -317,7 +323,7 @@
if (uwr-regexp) {
regex_t *r = (regex_t *)uwr-regexp;
regmatch_t regm[10];
-if (!regexec(r, uri, r-re_nsub + 1, regm, 0)) {
+if (!REGEXEC(r, uri, r-re_nsub + 1, regm, 0)) {
return uwr;
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] use PCRE on NetWare - update
Hi, if my last patch for PCRE functions gets accepted, this patch to the makefile makes usage of the PCRE on NetWare. Guenter. http://www.gknw.com/test/NWGNUmakefile.diff ### --- ./jk/native2/server/apache2/NWGNUmakefile.orig Thu Nov 20 01:26:30 2003 +++ ./jk/native2/server/apache2/NWGNUmakefile Fri Feb 27 00:05:02 2004 @@ -59,9 +59,8 @@ -D__NOVELL_LIBC__ \ -D_POSIX_SOURCE \ -DHAS_APR \ + -DHAS_AP_PCRE \ $(EOLIST) - -# -DHAS_PCRE # # These flags will be added to the link.opt file - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] mod_jk2 use AP_PCRE on Win32
Hi, if my last patch for PCRE functions gets accepted, this patch to the makefile makes usage of the AP_PCRE on Win32. Guenter. http://www.gknw.com/test/mod_jk2.dsp.diff ### --- ./jk/native2/server/apache2/mod_jk2.dsp.origWed Feb 25 00:14:30 2004 +++ ./jk/native2/server/apache2/mod_jk2.dsp Fri Feb 27 04:29:10 2004 @@ -43,7 +43,7 @@ # PROP Ignore_Export_Lib 0 # PROP Target_Dir # ADD BASE CPP /nologo /MD /W3 /GX /O2 /D WIN32 /D NDEBUG /D _WINDOWS /D _MBCS /D _USRDLL /D MOD_JK2_EXPORTS /YX /FD /c -# ADD CPP /nologo /MD /W3 /GX /O2 /I ..\..\include /I $(JAVA_HOME)\include /I $(JAVA_HOME)\include\win32 /I $(APACHE2_HOME)\include /I $(APACHE2_HOME)\os\win32 /D NDEBUG /D WIN32 /D _WINDOWS /D _MBCS /D _USRDLL /D MOD_JK2_EXPORTS /D HAVE_JNI /D HAS_APR /D HAS_PCRE /FR /YX /FD /c +# ADD CPP /nologo /MD /W3 /GX /O2 /I ..\..\include /I $(JAVA_HOME)\include /I $(JAVA_HOME)\include\win32 /I $(APACHE2_HOME)\include /I $(APACHE2_HOME)\os\win32 /D NDEBUG /D WIN32 /D _WINDOWS /D _MBCS /D _USRDLL /D MOD_JK2_EXPORTS /D HAVE_JNI /D HAS_APR /D HAS_AP_PCRE /FR /YX /FD /c # ADD BASE MTL /nologo /D NDEBUG /mktyplib203 /win32 # ADD MTL /nologo /D NDEBUG /mktyplib203 /win32 # ADD BASE RSC /l 0xc0a /d NDEBUG @@ -69,7 +69,7 @@ # PROP Ignore_Export_Lib 0 # PROP Target_Dir # ADD BASE CPP /nologo /MTd /W3 /Gm /GX /ZI /Od /D WIN32 /D _DEBUG /D _WINDOWS /D _MBCS /D _USRDLL /D MOD_JK2_EXPORTS /YX /FD /GZ /c -# ADD CPP /nologo /MDd /W3 /Gm /GX /ZI /Od /I ..\..\include /I $(JAVA_HOME)\include /I $(JAVA_HOME)\include\win32 /I $(APACHE2_HOME)\include /I $(APACHE2_HOME)\os\win32 /D _DEBUG /D WIN32 /D _WINDOWS /D _MBCS /D _USRDLL /D MOD_JK2_EXPORTS /D HAVE_JNI /D HAS_APR /D HAS_PCRE /FR /YX /FD /GZ /c +# ADD CPP /nologo /MDd /W3 /Gm /GX /ZI /Od /I ..\..\include /I $(JAVA_HOME)\include /I $(JAVA_HOME)\include\win32 /I $(APACHE2_HOME)\include /I $(APACHE2_HOME)\os\win32 /D _DEBUG /D WIN32 /D _WINDOWS /D _MBCS /D _USRDLL /D MOD_JK2_EXPORTS /D HAVE_JNI /D HAS_APR /D HAS_AP_PCRE /FR /YX /FD /GZ /c # SUBTRACT CPP /X # ADD BASE MTL /nologo /D _DEBUG /mktyplib203 /win32 # ADD MTL /nologo /D _DEBUG /mktyplib203 /win32 - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] use ap_ prefixed PCRE functions - take 3
Hi Kurt,
Just a tweak or two and its ready. The preg calloc only applies to the
HAS_PCRE case and PREGCOMP isn't needed. Otherwise it looks good. I'll
test and commit it tomorrow.
yep, forgot to remove PREGCOMP.
you mean perhaps so:
{
#ifdef HAS_AP_PCRE
regex_t *preg = ap_pregcomp((apr_pool_t *)uriEnv-pool-_private,
uriEnv-uri, REG_EXTENDED);
if (preg == NULL) {
#else
regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
#endif
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
uri);
return JK_ERR;
}
uriEnv-regexp = preg;
}
return JK_OK;
#else
env-l-jkLog(env, env-l, JK_LOG_INFO,
uriEnv.parseName() parsing regexp %s not supported\n,
uri);
return JK_ERR;
#endif
}
Guenter.
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] use ap_ prefixed PCRE functions - take 2
Hi Kurt, I've reviewed your patch and have some comments included inline below. regcomp and ap_pregcomp are not interchangeable like this. ap_pregcomp needs an apr_pool to be passed to it and it returns the regex_t. I think (apr_pool_t *)uriEnv-pool-_private is correct here (Henri?, Jean-Frederic?). for that I did the trick with '#define REGEX_POOL'... I'm not a fan of undef/def functions like this. If the functions were interchangeable, I would have just created a new define like PREGCOMP that points to the correct function. I totally agree, but I wasnt sure what gets here more acceptance. I create a new patch shortly. Since Apache2 always comes with pcre whole define section would be better like this: #ifdef HAS_AP_PCRE #include httpd.h #else #ifdef HAS_PCRE #include pcre.h #include pcreposix.h #endif #endif ok. Thanks for reviewing; I come up soon with a new patch with your suggestions. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: jk2 : ap_hook_translate_name should be APR_HOOK_MIDDLE
Hi, looks like this was already done by Mladen with mod_jk2 version 1.42, but two days later the patch was reverted again with 1.43 by BoJan... Guenter. With the actual code in jk2, we can't use mod_alias, for instance ErrorDocument. I changed the ap_hook_translate_name from APR_HOOK_FIRST to APR_HOOK_MIDDLE and I've get the ErrorDocument. jk use also APR_HOOK_MIDDLE for ap_hook_translate_name, so I wonder why it's set to APR_HOOK_FIRST in jk2 (seems to be a bug). I'm waiting for explanation before commiting the fix : Gleen, Mladen, Jean-Frederic, Gunter, advices please - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: mod_deflate - mod_jk mod_jk2
Hi, In cvs... and in http://cvs.apache.org/builds/jakarta-tomcat-5/nightly/. Probably it would be nice to have a http://cvs.apache.org/builds/jakarta-tomcat-connectors/nightly. I would run buildconf.sh in native and native2 to prevent problems with libtool/autoconf/automake. there are also cvs snapshots available every six hours: http://cvs.apache.org/snapshots/jakarta-tomcat-connectors/ Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[POPOSAL] change extension of Win32 Apache connectors to .so
Hi all, before this gets again forgotten, here's the reminder: should we change the Win32 binary extention of the Apache modules to .so instead of .dll ?? Apache changed that with version 1.3.15 already; and I got a lot of questions about that at this time... now the questions are the other turn: why is mod_jk/mod_jk2 a dll? where do I have to put it in? so I'm +1 for changing to .so because I think then the chances are better that the user puts the module into the Apache modules folder... please vote for this: [+/-]1 for changing to .so thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[REMINDER] remove obsolete *.dsw files
Hi all, there were still some *.dsw in yesterday's CVS: ./jk/native/domino/dsapi.dsw ./jk/native2/server/dsapi/dsapi.dsw ./jk/native2/server/isapi/isapi.dsw Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [REMINDER] remove obsolete *.dsw files
Hi all, there were still some *.dsw in yesterday's CVS: ./jk/native/domino/dsapi.dsw ./jk/native2/server/dsapi/dsapi.dsw ./jk/native2/server/isapi/isapi.dsw sorry, but just found that these *.dsw are not the simple autocreated ones, but include other *.dsp; so seems they have to stay! excuse me for not checking before posting! Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: cvs commit: jakarta-tomcat-connectors/jk/native2/server/dsapi dsapi.dsw
Henri, please forgive me! hgomez 2004/02/25 07:00:04 Removed: jk/native/domino dsapi.dsw this is ok and obsolete. jk/native2/server/isapi isapi.dsw jk/native2/server/dsapi dsapi.dsw these two must be back again - they include other *.dsp sorry again! Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
binaries for testing
Hi all, for those who normally use only binaries I have uploaded mod_jk2 binaries of CVS snapshot 20040224172400 to my site: http://www.gknw.com/development/apache/ and also I've just build the isapi redirector: http://www.gknw.com/test/jtc/ have fun with testing! Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] use ap_ prefixed PCRE functions
Hi all,
I would like to get this patch into CVS in order to use PCRE on NetWare where only the
ap_ prefixed pcre functions are exported. I have tested that the patch below compiles
fine with NetWare, Linux and Win32.
As a positive side effect on Win32 the binary is about 24 kb smaller.
Guenter.
http://www.gknw.com/test/pcre_patch
###
--- ./jk/native2/include/jk_global.h.orig 2004-02-24 12:30:10.0 +0100
+++ ./jk/native2/include/jk_global.h2004-02-25 20:44:36.0 +0100
@@ -32,6 +32,7 @@
#include apr_errno.h
#include apr_version.h
#include apr_time.h
+#include httpd.h
#include stdio.h
#include stdlib.h
###
--- ./jk/native2/common/jk_uriEnv.c.orig2004-02-24 12:30:10.0 +0100
+++ ./jk/native2/common/jk_uriEnv.c 2004-02-25 20:43:59.0 +0100
@@ -73,8 +73,8 @@
uriEnv.parseName() parsing %s regexp\n,
name);
{
-regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
-if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
+apr_pool_t *preg = (apr_pool_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
+if (ap_pregcomp(preg, uriEnv-uri, REG_EXTENDED)) {
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
uri);
@@ -138,8 +138,8 @@
uriEnv.parseName() parsing regexp %s\n,
uri);
{
-regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
-if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
+apr_pool_t *preg = (apr_pool_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
+if (ap_pregcomp(preg, uriEnv-uri, REG_EXTENDED)) {
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
uri);
###
--- ./jk/native2/common/jk_uriMap.c.orig2004-02-24 12:30:10.0 +0100
+++ ./jk/native2/common/jk_uriMap.c 2004-02-25 20:43:47.0 +0100
@@ -317,7 +317,7 @@
if (uwr-regexp) {
regex_t *r = (regex_t *)uwr-regexp;
regmatch_t regm[10];
-if (!regexec(r, uri, r-re_nsub + 1, regm, 0)) {
+if (!ap_regexec(r, uri, r-re_nsub + 1, regm, 0)) {
return uwr;
}
}
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] use PCRE on NetWare
Hi, if my last patch for PCRE functions gets accepted, this patch to the makefile makes usage of the PCRE on NetWare. Guenter. http://www.gknw.com/test/NWGNUmakefile.diff ### --- ./jk/native2/server/apache2/NWGNUmakefile.orig Thu Nov 20 01:26:30 2003 +++ ./jk/native2/server/apache2/NWGNUmakefile Wed Feb 25 22:04:04 2004 @@ -59,9 +59,8 @@ -D__NOVELL_LIBC__ \ -D_POSIX_SOURCE \ -DHAS_APR \ + -DHAS_PCRE \ $(EOLIST) - -# -DHAS_PCRE # # These flags will be added to the link.opt file - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] use ap_ prefixed PCRE functions - take 2
Hi all,
the previous patch seems to break non-Apache connectors, so here's another patch which
shouldnt break anything unless you set the HAVE_AP_PCRE.
I would like to get this patch into CVS in order to use PCRE on NetWare where only the
ap_ prefixed pcre functions are exported. I have tested that the patch below compiles
fine with NetWare, Linux and Win32.
As a positive side effect on Win32 the binary is about 24 kb smaller.
Also this time tested that the isapi redirector still compiles fine.
thanks, Guenter.
http://www.gknw.com/test/pcre_patch2
###
--- ./jk/native2/common/jk_uriEnv.c.orig2004-02-24 12:30:10.0 +0100
+++ ./jk/native2/common/jk_uriEnv.c 2004-02-26 00:12:57.0 +0100
@@ -29,8 +29,16 @@
#include jk_registry.h
#ifdef HAS_PCRE
-#include pcre.h
-#include pcreposix.h
+ #ifdef HAS_AP_PCRE
+#include httpd.h
+#undef regcomp
+#define regcomp ap_pregcomp
+#define REGEX_POOL apr_pool_t
+ #else
+#include pcre.h
+#include pcreposix.h
+#define REGEX_POOL regex_t
+ #endif
#endif
/* return non-zero if pattern has any glob chars in it */
@@ -73,7 +81,7 @@
uriEnv.parseName() parsing %s regexp\n,
name);
{
-regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
+REGEX_POOL *preg = (REGEX_POOL *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
@@ -138,7 +146,7 @@
uriEnv.parseName() parsing regexp %s\n,
uri);
{
-regex_t *preg = (regex_t *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
+REGEX_POOL *preg = (REGEX_POOL *)uriEnv-pool-calloc( env, uriEnv-pool,
sizeof(regex_t));
if (regcomp(preg, uriEnv-uri, REG_EXTENDED)) {
env-l-jkLog(env, env-l, JK_LOG_DEBUG,
uriEnv.parseName() error compiling regexp %s\n,
###
--- ./jk/native2/common/jk_uriMap.c.orig2004-02-24 12:30:10.0 +0100
+++ ./jk/native2/common/jk_uriMap.c 2004-02-26 00:13:09.0 +0100
@@ -35,8 +35,14 @@
#include jk_registry.h
#ifdef HAS_PCRE
-#include pcre.h
-#include pcreposix.h
+ #ifdef HAS_AP_PCRE
+#include httpd.h
+#undef regexec
+#define regexec ap_regexec
+ #else
+#include pcre.h
+#include pcreposix.h
+ #endif
#endif
static INLINE const char *jk2_findExtension(jk_env_t *env, const char *uri);
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.19] Release vote
Hi Remy, two things I found (which are probably older bugs, seen them with 5.0.18 too): - if I call snoop.jsp directly through Tomcat I get 'Content length: -1' while through mod_jk2 I get 'Content length: 0' Both are acceptable, but -1 is more accurate. ok. - redirection to the welcome file doesnt work properly. With TC4 it seems that there happens a redirection to the location of the welcome file, while with TC5 it looks more that the file is fetched and served from base location This is as intended, and is indeed a change in behavior. I understand it could cause trouble for some applications, but is a lot cleaner and more efficient. but it prevents to move applications from TC4 to TC5 since they dont work out-of-the-box as before, f.e. *.war. isnt there a setting to archive the old behaviour?? other than that, I've tested with a few other apps which work fine so far... just found another small issue (seen on Linux and Win32) - the link on the Tomcat main page to webdav now produces a directory listing rather than call index.html Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [5.0.19] Release vote
Hi, ballot Release 5.0.19 as Stable: [x] Yes [ ] No /ballot tested that it starts fine and that the samples work on: SuSE Linux 7.0 + 8.2 mod_jk2 JVM Sun 1.4.2_03 Novell NetWare 6.5 mod_jk2 JVM Sun 1.4.2_02 Novell NetWare 6.0 mod_jk2 JVM Sun 1.4.1_05 Win2K SP4 mod_jk2 JVM Sun 1.4.2_03 WinXP SP1 mod_jk2 JVM Sun 1.4.2_03 two things I found (which are probably older bugs, seen them with 5.0.18 too): - if I call snoop.jsp directly through Tomcat I get 'Content length: -1' while through mod_jk2 I get 'Content length: 0' - redirection to the welcome file doesnt work properly. With TC4 it seems that there happens a redirection to the location of the welcome file, while with TC5 it looks more that the file is fetched and served from base location other than that, I've tested with a few other apps which work fine so far... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[PATCH] ./jk/native2/Makefile.in - add apxs install target
Hi, the patch below adds an install target for apxs build to the Makefile. http://www.gknw.com/test/Makefile.in.diff == --- ./jk/native2/Makefile.in.orig Mon Nov 10 12:15:04 2003 +++ ./jk/native2/Makefile.inWed Feb 11 23:54:12 2004 @@ -22,6 +22,15 @@ fi; \ done; +jk2-build-apxs-install: + list='@WEBSERVERS@'; \ + for i in $$list; do \ + echo Making $$target in $$i and installing; \ + if test $$i != .; then \ + (cd $$i $(MAKE) -f Makefile.apxs install) || exit 1; \ + fi; \ + done; + jk2-clean: list='@WEBSERVERS@'; \ for i in $$list; do \ Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] ./jk/native2/Makefile.in - add apxs install target
Hi Kurt, There isn't an install target in server/apache13/Makefile.apxs yet. I will be committing one soon (along with some other changes). but there's one already in server/apache2/Makefile.apxs... with this change I can directly build and install out of native2 dir with: configure --with-apxs2= make jk2-build-apxs-install thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
[POPOSAL] change extension of Win32 Apache connectors to .so
Hi all, before this gets again forgotten, here's the reminder: should we change the Win32 binary extention of the Apache modules to .so instead of .dll ?? Apache changed that with version 1.3.15 already; and I got a lot of questions about that at this time... now the questions are the other turn: why is mod_jk/mod_jk2 a dll? where do I have to put it in? so I'm +1 for changing to .so because I think then the chances are better that the user puts the module into the Apache modules folder... please vote for this: [+/-]1 for changing to .so thanks, Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: Mod_Jk2 - Default Worker
Hi Costin, Good morning Costin. Apologies for the silence. I had hoped there might have been a little more input from others on this topic. I think it is also necessary to discuss a bit the proper configuration of mod_jk2. The docu is all other but clear, mixed up with the docu for mod_jk, and I see that the jkstatus output differs heavily with only slight other configs; also I think we should add a minimal config to the binary distributions; I want to have a config which is easy to change, and works without change in 98% of installations; and is just enough to connect to TC, access the docu, and execute the samples. here's a sample which works without a workers2.properties file: http://www.gknw.com/development/apache/docs/win32/mod_jk2/mod_jk2x.conf and here a nearly mininal workers2.properties file: http://www.gknw.com/development/apache/docs/win32/mod_jk2/min_w2.properties common with both configs is that there's only one place where you have to change the host and port if necessary; and that's what I call user-friendly. also would be nice to have some hints in the docu about where to put uri stuff, benefit of having them in mod_jk2.conf, and samples for lb mode. if you have a few minutes please test both configs and check how the jkstatus differs... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: HOWTO: building mod_jk2 with Visual studio .net 2003
Hi, maybe we should export the .mak files and check into CVS, just as with Apache? Please try if this works: http://www.gknw.com/test/mod_jk2.mak Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: HOWTO: building mod_jk2 with Visual studio .net 2003
Hi, maybe we should export the .mak files and check into CVS, just as with Apache? Please try if this works: http://www.gknw.com/test/mod_jk2.mak I already did that, and it worked fine. That's why I prefaced my comment by stating this was an issue with vs2003 .net. Do you want my makefile? no, I can export self - I was more asking if you think it would help when we check such makefiles into CVS in addition to the dsp projects...?? And if my exported makefile works for you... Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: HOWTO: building mod_jk2 with Visual studio .net 2003
Hi Aryeh, I'm using 2.0.2, and your makefile fails at link time with a missing symbol jk2_channel_socket_factory. I assume that's a 2.0.4 issue. Other than that, the compile was file. ok, that sounds good. If you perhaps could do a test with recent CVS that would be fine; then I would create *.mak for all *.dsp... if you dont know already: there's a snapshot server where you can download snapshots from current CVS every 6 hours: http://cvs.apache.org/snapshots/jakarta-tomcat-connectors/ Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
TC 5.0.18 problems with welcome file
Hi all, I have problems with some webapps where the welcome file doesnt work as with TC 3.3 and TC4. these apps are have this structure: app \ documentation \ index.html \WEB-INF \ web.xml web.xml contains: web-app welcome-file-list welcome-file/documentation/index.html/welcome-file /welcome-file-list /web-app now if I drop the app below the webapps folder this works fine with TC 3.3 and TC4.1.30; but with TC5.0.18 I get only the index page back, but all links in the docu are broken because they are relative; it sems to me that TC3 and 4 does a changedir to the folder where the welcome file is located while TC5 only fetches the page and then serves it as if it would be located in the app folder. Is this a bug with TC5, or something I'm missing with my config perhaps?? I've tested this with TC 5.0.18 JVM 1.4.2_03 on SuSE Linux and Win2K, and on both platforms the same behavior. Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] ./native/netscape/nsapi.dsp - remove obsolete files
Hi Henri, the patch below removes the obsolete files from the project file; in addition I'd suggest to remove both *.dsw files from ./jk/native/netscape and ./jk/native/jni folders cause they are not needed - MSVC creates then self. removed, should I do the same for isapi ? yes, the *.dsw are all obsolete and useless - *.dsp are the single projects while *.dsw is normally the master work bench; so a *.dsw would only make sense if it would be in a higher level directory, and then include all other *.dsp so that they are compilable from one place; look for Apache as sample, there you have one Apache.dsw in the top-level dir which contains all other *.dsp Guenter. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
Re: [PATCH] ./native/netscape/nsapi.dsp - remove obsolete files
Hi Henri, Commited Thanks hmm, doesnt work, maybe another copypaste error? --- nsapi.dsp.orig Mon Feb 09 20:41:02 2004 +++ nsapi.dsp Sun Feb 08 22:21:13 2004 @@ -242,8 +242,7 @@ SOURCE=..\common\jk_worker.h # End Source File -# Begin Source File - +# End Group # Begin Group Resource Files # PROP Default_Filter ico;cur;bmp;dlg;rc2;rct;bin;rgs;gif;jpg;jpeg;jpe Mike/Mladen, ok to remove *.dsw ? - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
