Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+-
 Reporter:  special  |  Owner:  nickm
 Type:  defect   | Status:  closed
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs,  |  implemented
  review-group-10|  Actual Points:  1
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by nickm):

 * status:  merge_ready => closed
 * resolution:   => implemented


Comment:

 (Merged!)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+-
 Reporter:  special  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs,  |  Actual Points:  1
  review-group-10|
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_information => merge_ready


Comment:

 Should we then move `ControlSocket` to the deprecated option list? :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+-
 Reporter:  special  |  Owner:  nickm
 Type:  defect   | Status:
 |  merge_ready
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs,  |  Actual Points:  1
  review-group-10|
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by nickm):

 I'd take a patch. :)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+-
 Reporter:  special  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs,  |  Actual Points:  1
  review-group-10|
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-

Comment (by nickm):

 I think we now generally prefer the newer `FooPort unix:` syntax to
 the older `FooSocket ...` syntax.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+-
 Reporter:  special  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_information
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs,  |  Actual Points:  1
  review-group-10|
Parent ID:   | Points:  1
 Reviewer:  dgoulet  |Sponsor:
-+-
Changes (by dgoulet):

 * status:  needs_review => needs_information
 * reviewer:   => dgoulet


Comment:

 This lgtm and works well for SocksPort, HS Port and ControlPort but
 doesn't work with `ControlSocket` which takes a path (without `unix:`
 prefix though). Do we care about that one not having the possibility to
 put spaces or quoted string?

 Here is an example of it not working:
 {{{
 ControlSocket "/tmp/a control socket"
 }}}

 Apart from that, lgtm;

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  nickm
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.9.x-final
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:  1
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * milestone:  Tor: 0.2.??? => Tor: 0.2.9.x-final


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+-
 Reporter:  special  |  Owner:  nickm
 Type:  defect   | Status:
 |  needs_review
 Priority:  Medium   |  Milestone:  Tor:
 |  0.2.9.x-final
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs,  |  Actual Points:  1
  review-group-10|
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+-
Changes (by nickm):

 * keywords:  nickm-deferred-20160905, tbb-needs => nickm-deferred-20160905,
 tbb-needs, review-group-10


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  nickm
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:  1
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * cc: h9F7Gn (added)


Comment:

 Resolved #20327 as duplicate.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  nickm
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:  1
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by mcs):

 This change should work for Tor Browser. We need to modify Tor Launcher to
 use the new quoted syntax for the `ControlPort` and `SocksPort` options,
 and we need to modify Torbutton to correctly parse responses to `GETINFO
 net/listeners/socks`. But Kathy and I made enough of a start on the Tor
 Launcher and Torbutton changes to convince ourselves that this tor patch
 works.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  nickm
 Type:  defect  | Status:
|  needs_review
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:  1
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * status:  accepted => needs_review


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  nickm
 Type:  defect  | Status:  accepted
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:  1
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by nickm):

 * owner:  yawning => nickm
 * status:  needs_information => accepted
 * actualpoints:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  yawning
 Type:  defect  | Status:
|  needs_information
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by nickm):

 Branch `spaces_in_unix_addrs` in my public repository may DTRT here.
 Needs review and acceptance testing.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  yawning
 Type:  defect  | Status:
|  needs_information
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by mcs):

 Replying to [comment:8 gk]:
 > mcs/brade: Do you have a preferred syntax for this fix?

 We do not have a syntax in mind; anything that works well and fits with
 tor's configuration philosophy is good as far as we are concerned. The
 syntax suggested by nickm in #tor-dev would be fine:
  SocksPort unix:"/foo/bar/baz quux/socket" IPv6Traffic PreferIPv6Automap

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  yawning
 Type:  defect  | Status:
|  needs_information
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--

Comment (by bugzilla):

 You are going to push a socket into the interface intended for a port and
 try to make it work.
 (OT: What about #3501?)

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  yawning
 Type:  defect  | Status:
|  needs_information
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * status:  assigned => needs_information


Comment:

 If we could this bug back on track for 0.2.9 that would be neat, although
 I guess we want to backport a fix for the tor we ship in Tor Browser
 anyway.

 mcs/brade: Do you have a preferred syntax for this fix?

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
+--
 Reporter:  special |  Owner:  yawning
 Type:  defect  | Status:  assigned
 Priority:  Medium  |  Milestone:  Tor:
|  0.2.???
Component:  Core Tor/Tor|Version:
 Severity:  Normal  | Resolution:
 Keywords:  nickm-deferred-20160905, tbb-needs  |  Actual Points:
Parent ID:  | Points:  1
 Reviewer:  |Sponsor:
+--
Changes (by gk):

 * keywords:  nickm-deferred-20160905 => nickm-deferred-20160905, tbb-needs


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+--
 Reporter:  special  |  Owner:  yawning
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+--
Changes (by mcs):

 * cc: brade, mcs (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
-+--
 Reporter:  special  |  Owner:  yawning
 Type:  defect   | Status:  assigned
 Priority:  Medium   |  Milestone:  Tor: 0.2.???
Component:  Core Tor/Tor |Version:
 Severity:  Normal   | Resolution:
 Keywords:  nickm-deferred-20160905  |  Actual Points:
Parent ID:   | Points:  1
 Reviewer:   |Sponsor:
-+--
Changes (by gk):

 * cc: gk (added)


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
--+
 Reporter:  special   |  Owner:  yawning
 Type:  defect| Status:  assigned
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by yawning):

 * status:  new => assigned
 * owner:   => yawning


Comment:

 I'll take this.  The functionality here is likely needed for the future
 Tor Browser sandboxing efforts.  We should also re-examine our control
 port stuff that deals with paths to ensure sanity.

--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs

Re: [tor-bugs] #18753 [Core Tor/Tor]: Unix socket paths cannot contain spaces

[Tor Bug Tracker & Wiki]

#18753: Unix socket paths cannot contain spaces
--+
 Reporter:  special   |  Owner:
 Type:  defect| Status:  new
 Priority:  Medium|  Milestone:  Tor: 0.2.9.x-final
Component:  Core Tor/Tor  |Version:
 Severity:  Normal| Resolution:
 Keywords:|  Actual Points:
Parent ID:| Points:  1
 Reviewer:|Sponsor:
--+
Changes (by nickm):

 * points:   => 1


--
Ticket URL: 
Tor Bug Tracker & Wiki 
The Tor Project: anonymity online
___
tor-bugs mailing list
tor-bugs@lists.torproject.org
https://lists.torproject.org/cgi-bin/mailman/listinfo/tor-bugs