date:20130715

Re: [U-Boot] Patman failure on Linux Mint 14

2013-07-15 Thread Stefano Babic

Hi Gerhard,

On 14/07/2013 12:18, Gerhard Sittig wrote:
 Hi there!
 
 Patman for some reason doesn't work for me.  It won't find
 commits from the sandbox/repo, but wants me to specify -c
 manually.  Then it won't detect or cannot grok subject prefixes
 and fails to determine email addresses.  From the documentation I
 see how useful the tool is and feel how great and desirable it is
 to have such a tool at hand when iterating a series through
 review.  It's a pity that it won't run here.  Since it works for
 others, the problem must be in my setup.
 
 
 The git history suggests that Python 2.7.4 is required, while my
 distribution (Linux Mint 14, derived from Ubuntu 12.10) ships
 with 2.7.3.

It is not definetly a problem. It works on Ubuntu 12.04 LTS (python
2.7.3), as well as on later versions.

One point could be your ~/.patman file. You should define an alias for
each pattern in the subject line. Let's take as example the commit
7d47d1caa01682fd7b12631409927139f09ba041, it has a subject line:

arm: omap4: panda: Add reading of the board revision

patman tries to resolv an e-mail address for each pattern, and I have in
my ~/.patman an entry for each of them (arm--Albert, omap and panda --
Tom).

The other question is if you have set up the toolchain when you run
patman. If you set up ELDK, some tools are taken from the toolchain
instead from the PC, and patman fails - sometimes with weird errors. I
usually run patman in a shell where I have not set the environment for
the cross-compiler.

 
 OTOH this very Python version works for others, and a local
 installation of 2.7.5 (default configure except for --prefix
 $HOME) doesn't help either.
 
 
 The unit test output is rather lengthy, yet apparently condenses
 into just two spots and a lot of followup errors:
 
 The testIndent() case in test.py won't pass (succeeds although
 it's supposed to fail).  Changing 'tab' in GetData() from a
 verbatim tab in quotes into an explicit '\t' doesn't help (but
 visually more clearly reflects the specific type of whitespace).
 Running the script under 'env LC_ALL=C' didn't help either.  Is
 this some language or locale specific stuff that can be overcome
 from outside, or do I have a more severe problem with the
 Python runtime where string operation and whitespace handling
 isn't dependable?

It seems to me too much and an indication that your environment could be
responsible for this issue. I do not think that your Ubuntu derivative
is the problem.

Have you tried with a fresh shell or by logging with another user if you
have the same errors ?

 
 Am I missing some external dependencies or proper configuration
 (either in the system, in Python, in git, or in patman)?

IMHO you get in python an error by import if something is missing, and
this is not your case. By the way, I have not set up anything, and
patman works flawlessly.

  What
 can I do to better diagnose the issue or make patman work here as
 well?  It's so great a tool!

My first suggestion should be to try to check your environment, or try
with another user if you have not changed for some reason /etc/profile.

Regards,
Stefano

-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] mx6qsabrelite: Remove mx6qsabrelite code in favor of nitrogen6x

2013-07-15 Thread Stefano Babic

Hi Fabio,

On 15/07/2013 04:40, Fabio Estevam wrote:
 From: Fabio Estevam fabio.este...@freescale.com
 
 mx6qsabrelite and nitrogen6q boards are hardware compatible, so let's avoid 
 the
 code duplication and only use the nitrogen6x source code to make board code
 maintainance easier.
 
 Tested booting a mainline device tree kernel on a mx6qsabrelite board.
 
 Signed-off-by: Fabio Estevam fabio.este...@freescale.com
 ---
  .../nitrogen6x/README.mx6qsabrelite}   |   0
  .../nitrogen6x/{README = README.nitrogen6x}   |   0
  board/freescale/mx6qsabrelite/Makefile |  41 -
  board/freescale/mx6qsabrelite/mx6qsabrelite.c  | 848 
 -
  boards.cfg |   2 +-
  include/configs/mx6qsabrelite.h| 297 
  include/configs/nitrogen6x.h   |  80 +-

Should we update the MAINTAINERS, too ? It is weird that we have two
maintainers for the same code.

Best regards,
Stefano

-- 
=
DENX Software Engineering GmbH, MD: Wolfgang Denk  Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/1] OMAP3: igep00x0: allow booting with a FDT from MMC

2013-07-15 Thread Enric Balletbo Serra

Hi Javier,

2013/7/14 Javier Martinez Canillas jav...@dowhile0.org:
 IGEP boards now have Device Tree support in the mainline
 kernel. To boot an IGEP board using a DT, a uEnv.txt plain
 text file could be used to define a custom uenvcmd that will
 be run by the default boot command.

 It is more convenient to change the default boot command to
 allow loading a FDT if it is stored in a uSD/MMC partition.
 If no FDT is found then the command behaves just as it used
 so this change won't break existing setup for current users.

 Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk
 ---
  board/isee/igep00x0/igep00x0.c |   14 ++
  include/configs/igep00x0.h |9 +
  2 files changed, 23 insertions(+), 0 deletions(-)

 diff --git a/board/isee/igep00x0/igep00x0.c b/board/isee/igep00x0/igep00x0.c
 index 0d4679d..fdd2773 100644
 --- a/board/isee/igep00x0/igep00x0.c
 +++ b/board/isee/igep00x0/igep00x0.c
 @@ -154,6 +154,18 @@ int board_mmc_init(bd_t *bis)
  }
  #endif

 +void set_fdt(void)
 +{
 +   switch (gd-bd-bi_arch_number) {
 +   case MACH_TYPE_IGEP0020:
 +   setenv(fdtfile, omap3-igep0020.dtb);
 +   break;
 +   case MACH_TYPE_IGEP0030:
 +   setenv(fdtfile, omap3-igep0030.dtb);
 +   break;
 +   }
 +}
 +
  /*
   * Routine: misc_init_r
   * Description: Configure board specific parts
 @@ -166,6 +178,8 @@ int misc_init_r(void)

 dieid_num_r();

 +   set_fdt();
 +
 return 0;
  }

 diff --git a/include/configs/igep00x0.h b/include/configs/igep00x0.h
 index 1d8090b..72752af 100644
 --- a/include/configs/igep00x0.h
 +++ b/include/configs/igep00x0.h
 @@ -149,6 +149,7 @@
  #define CONFIG_EXTRA_ENV_SETTINGS \
 usbtty=cdc_acm\0 \
 loadaddr=0x8200\0 \
 +   fdtaddr=0x8160\0 \
 usbtty=cdc_acm\0 \
 console=ttyO2,115200n8\0 \
 mpurate=auto\0 \
 @@ -180,9 +181,12 @@
 importbootenv=echo Importing environment from mmc ...;  \
 env import -t $loadaddr $filesize\0 \
 loaduimage=fatload mmc ${mmcdev} ${loadaddr} uImage\0 \
 +   loadfdt=fatload mmc ${mmcdev} ${fdtaddr} ${fdtfile}\0 \
 mmcboot=echo Booting from mmc ...;  \
 run mmcargs;  \
 bootm ${loadaddr}\0 \
 +   mmcbootfdt=echo Booting with DT from mmc ...;  \
 +   bootm ${loadaddr} - ${fdtaddr}\0 \
 nandboot=echo Booting from onenand ...;  \
 run nandargs;  \
 onenand read ${loadaddr} 28 40;  \
 @@ -199,6 +203,11 @@
 run uenvcmd; \
 fi; \
 if run loaduimage; then  \
 +   if test -n $fdtfile; then  \
 +   if run loadfdt; then  \
 +   run mmcbootfdt; \
 +   fi; \
 +   fi; \
 run mmcboot; \
 fi; \
 fi; \
 --
 1.7.7.6


As merge window is closed, I think we have time to discuss a bit more
this patch before sending for next merge window. I think it's time to
redefine the default boot arguments for all IGEP boards and unify as
possible the bootargs for IGEP0020, IGEP0030, IGEP0032 and IGEP0033.

I made also some work in this line, but is not finished yet. We can
send a the patch series for next merge window. These are the things
that I think the patches should have.

   1. Enable the use of CMD_EXT4, CMD_FS_GENERIC and zImage.
   
https://github.com/eballetbo/u-boot/commit/38036e80a66f266f2c3fae82906c5c46a575f06b
   As uImage is deprecated we should use zImages.

2. Add support for Flattened Device Tree.
For IGEP0033
   
https://github.com/eballetbo/u-boot/commit/46ddafddc5bb6968190848d273b9ca8fbbd120de
For IGEP0020/30/32
   Your patch

Note that I made some modifications on where the zImage and the DTB
file is located. MLO and u-boot.img are from boot partition, and
zImage and dtb file are from rootfs partition (/boot/ directory). What
do you think about this ?

3. Boot from NAND using a ubifs
 
https://github.com/eballetbo/u-boot/commit/ebd8ab99b02ccbf08b4d50c60107b04c8129a8dd
I think is better use ubifs instead of jffs2, also note that
the zImage and the dtb are from rootfs partition using the ubifsload.

More ideas, comments ...

I would like that the bootargs betwen IGEP0020/30/32 and IGEP0033 were
as similar as possible.

Best regards,

Enric
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH 1/3] spi: bfin_spi: Use DIV_ROUND_UP instead of open-coded

2013-07-15 Thread Sonic Zhang

Acked-by: Sonic Zhang sonic.zh...@analog.com

On Fri, Jul 12, 2013 at 5:39 PM, Axel Lin axel@ingics.com wrote:
 Use DIV_ROUND_UP to simplify the code.

 Signed-off-by: Axel Lin axel@ingics.com
 ---
  drivers/spi/bfin_spi.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

 diff --git a/drivers/spi/bfin_spi.c b/drivers/spi/bfin_spi.c
 index a9a4d92..f7192c2 100644
 --- a/drivers/spi/bfin_spi.c
 +++ b/drivers/spi/bfin_spi.c
 @@ -144,10 +144,8 @@ void spi_set_speed(struct spi_slave *slave, uint hz)
 u32 baud;

 sclk = get_sclk();
 -   baud = sclk / (2 * hz);
 /* baud should be rounded up */
 -   if (sclk % (2 * hz))
 -   baud += 1;
 +   baud = DIV_ROUND_UP(sclk, 2 * hz);
 if (baud  2)
 baud = 2;
 else if (baud  (u16)-1)
 --
 1.8.1.2



 ___
 U-Boot mailing list
 U-Boot@lists.denx.de
 http://lists.denx.de/mailman/listinfo/u-boot
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH] net: fec: Avoid MX28 bus sync issue

2013-07-15 Thread Hector Palacios

Hi Marek,

On 07/12/2013 06:48 PM, Marek Vasut wrote:

[...]

but I found something:
It is very strange that the timeouts appear always after transferring
between 20 and 24 MiB. So I thought maybe it was not an issue with the
size of the file or the number of packets received, but instead a timed
issue (an issue that happens after some period of time). I checked, and in
fact the timeouts occur exactly 10 seconds after running the tftp command.
I verified that this is what is happening by adding a udelay(10) at
fec_send(). In this case, the timeout also occurs after 10 seconds, but
due to the delay, I have transferred only a few Kbytes.

Holy moly!

I tried to change different timeout related constants at tftp.c but still
the issue happens after 10s.
It's like if, after these 10 seconds, the PHY lost the link or something.
Really odd. Does it tell you anything?

LAN8720 phy, right? Try implementing something like [1], by clearing the
EDPWRDOWN bit , the PHY will never enter low-power mode. It's just a simple PHY
register RMW which you can stick somewhere into the PHY net/phy/smsc.c code.

[1]
https://kernel.googlesource.com/pub/scm/linux/kernel/git/djbw/dmaengine/+/b629820d18fa65cc598390e4b9712fd5f83ee693%5E!/#F0

No, my PHY is a Micrel KSZ8031RNLI.

The hint about the PHY possibly going to power down mode is interesting but I checked
the PHY registers and EDPD mode (Energy Detect Power Down) is off, at least before
running the tftp command. Power Down mode is off too, so unless these are somehow
enabled during the TFTP process, this is not what's happening.

The sniffer shows that the TFTP server simply stops sending data packets. I can see
however the target sending several times the ACK packet to the last received data
packet. This would point to the TFTP server (as Albert suggested), but the fact is the
problem occurs with different TFTP servers (I tried three different servers) and it
does not happen with an old v2009 U-Boot using the same target.

78 matches

Mail list logo