Re: [U-Boot] Kirkwood / Sheevaplug build failure
-Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of rektide Sent: Monday, August 24, 2009 7:00 PM To: u-boot@lists.denx.de Subject: [U-Boot] Kirkwood / Sheevaplug build failure Hello everyone; I'm new to U-Boot, but I hope you can help. I'm trying to build the Sheevaplug board / Kirkwood mach-- an ARM system-- and getting a greviously long list of undefined reference errors towards what looks like the end of the build cycle. I'm attempting to use Emdebian's cross compiler arm-linux-gnueabi-gcc, which is presently version 4.3.2. To do this, I am doing: export CROSS_COMPILE=arm-linux-gnueabi Hi I hope you are referring latest u-boot If it is not typo, then I feel there is small mistake in exporting CROSS_COMPILE ie. arm-linux-gnueabi- (last hyphen was missing) Secondly you need to define following before make $ USE_PRIVATE_LIBGCC=yes $ export USE_PRIVATE_LIBGCC Regards.. Prafulla . . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6] Add support for the DevKit8000 board
On Tuesday 25 August 2009 07:54:57 Frederik Kriewitz wrote: include/configs/devkit8000.h | 307 + include/configs/omap3_devkit8000.h | 307 + why do you duplicate it? maybe an miss when updating the patch This is a version of the patch Dirk asked for. Without timll vendor directory and with omap3_ config file prefix: No, Jean-Christophe referred to the 2 config headers: devkit8000.h *and* omap3_devkit8000.h. You probably forgot to remove one of those files. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v6] Add support for the DevKit8000 board
On Tue, Aug 25, 2009 at 8:25 AM, Stefan Roeses...@denx.de wrote: On Tuesday 25 August 2009 07:54:57 Frederik Kriewitz wrote: include/configs/devkit8000.h | 307 + include/configs/omap3_devkit8000.h | 307 + why do you duplicate it? maybe an miss when updating the patch This is a version of the patch Dirk asked for. Without timll vendor directory and with omap3_ config file prefix: No, Jean-Christophe referred to the 2 config headers: devkit8000.h *and* omap3_devkit8000.h. You probably forgot to remove one of those files. Oh yes, do we really need a v7? Or is v4 (with timll vendor directory) ok. Sorry for the patch spam. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Phy lib again
Hi Ben, I saw you have phy lib in your branch. What is the current state? Are there any problems? When do you want to add to mainline? Thanks, Michal -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Blacfin.
On Tuesday 25 August 2009 01:45:57 benix samuel wrote: I am a newbie, would like to tailor U-Boot specific to my board. Where to start? you didnt describe your hardware at all. are you using a Blackfin part like your truncated subject indicates ? -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Phy lib again
Hi Michal, On Tuesday 25 August 2009 09:02:14 Michal Simek wrote: I saw you have phy lib in your branch. What is the current state? Are there any problems? When do you want to add to mainline? IIRC, Jean-Christophe is also working on a PHY lib implementation (port from the Linux version). Jean-Christophe, what's the current status of this work? I suggest you start sending ideas/patches for discussion soon, perhaps as RFC in the first stage. Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] ARM: compiler options cleanup - improve tool chain support
On Mon, 24 Aug 2009 12:01:54 +0200 Wolfgang Denk w...@denx.de wrote: Dear Simon Kagstrom, In message 20090824105935.038bd...@marrow.netinsight.se you wrote: I updated my git tree today and got this patch (among other things). It does not work very well for me, unfortunately. I've tried three toolchains (4.3.3, 4.3.4, 4.4.1) built with crosstool-ng, and all of them build an image which doesn't run correct. Hm... aren't there known issues with these compiler versions on ARM? Small update: I've tried with the ELDK toolchains 4.1 and 4.2 (2007-01-21 and 2008-11-24). Both these fail as well, albeit in a slightly different way. The printfs are correct, but 4.2 still has the nand_bbt issue: U-Boot 2009.08-rc3-00013-g853ae64 (Aug 25 2009 - 08:28:05) Marvell-OpenRD_base SoC: Kirkwood 88F6281_A0 DRAM: 512 MB NAND: 512 MiB nand_bbt: Can't scan flash and build the RAM-based BBT Net: egiga0 88E1116 Initialized on egiga0 Hit any key to stop autoboot: 0 Marvell The 4.1 version just hangs on the NAND printout. I've tested both with USE_PRIVATE_LIBGCC=yes and USE_PRIVATE_LIBGCC unset, and get the same results. // Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Phy lib again
Hi Stefan, Stefan Roese wrote: Hi Michal, On Tuesday 25 August 2009 09:02:14 Michal Simek wrote: I saw you have phy lib in your branch. What is the current state? Are there any problems? When do you want to add to mainline? IIRC, Jean-Christophe is also working on a PHY lib implementation (port from the Linux version). Jean-Christophe, what's the current status of this work? I suggest you start sending ideas/patches for discussion soon, perhaps as RFC in the first stage. Ben has it at http://git.denx.de/?p=u-boot/u-boot-net.git;a=shortlog;h=refs/heads/phylib Thanks, Michal Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot -- Michal Simek, Ing. (M.Eng) w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/ Microblaze U-BOOT custodian ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-boot environment on Sheevaplug
Hi again! I just wanted to check if there has been any progress on the issue below (4-bit ECC support to read for the kernel / U-boot) during the summer. On Wed, 8 Jul 2009 15:59:27 +0200 Simon Kagstrom simon.kagst...@netinsight.net wrote: Hi Prafulla (and the list)! I'm wondering a bit how Sheevaplug handles the U-boot environment area. On OpenRD base it's stored on the NAND flash, and is protected by a 4-bit ECC as required when read by the boot prom - it just goes together with the rest of the u-boot image. The Marvell-supplied 1.1.4 version has code to handle this (basically switches to Reed-Solomon when reading/saving the environment), but it doesn't work with upstream U-boot. If I disable ECC altogether (in kirkwood_nand.c) I can read the environment, but since U-boot doesn't use Reed-Solomon, the soft ECC option doesn't cut it. Is the situation the same with sheevaplug? I see there are patches for OpenOCD to handle the same thing there, http://lists.berlios.de/pipermail/openocd-development/2009-May/006413.html so perhaps something similar is bound for U-boot as well? // Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RTC value corruption on QIL-A9G20 startup
Hi Stephen, On Mon, Aug 24, 2009 at 10:01:16PM -0400, Stephen Caudle wrote : I tried using your patches for the TNY-A9G20 on my QIL-A9G20 board from Calao. I guess you mean SBC35-A9G20? Everything seems to work properly except the RTC. They use the same M41T94 part and the CS is the same on both boards (PA3). I can set the RTC using the date command and read back the value okay. However, when I power cycle the board, the value is getting corrupted at startup due to some erroneous SPI write. I don't believe the code you submitted is causing this problem because the RTC is getting corrupted even if I compile out SPI and RTC support completely. I was just wondering if you have seen this problem on your board? Yes, I also experience this issue. I probed the CS line with an oscilloscope and I am definitely seeing it go low on U-Boot startup for a short time, but the clock line seems to be floating. I believe the activation of the CS at startup is causing junk data to be written to the RTC, which is corrupting it. Any idea why this might be happenning? Currently, I don't really have any idea. Besides, it's going to be hard for me to debug this, as I don't have an oscilloscope at hand. Would you please try to run u-boot within a debugger to see where exactly the CS line is driven low? Thanks for your feedback. Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Blacfin.
I am using Blackfin BF531 ( a customized board). when I browsed the u-boot code it has chunks of folder for different platforms. Can you provide me the source code for this particulare platform alone? Thanks, Benix. On Tue, Aug 25, 2009 at 12:33 PM, Mike Frysinger vap...@gentoo.org wrote: On Tuesday 25 August 2009 01:45:57 benix samuel wrote: I am a newbie, would like to tailor U-Boot specific to my board. Where to start? you didnt describe your hardware at all. are you using a Blackfin part like your truncated subject indicates ? -mike -- Thanks and regards, Benix Samuel. Cisco Systems India Pvt Ltd. The superior man is modest in speech, but exceeds in actions ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Fix issues introduced by 16fc32f: unify {CONFIG_, }ENV_IS_EMBEDDED
Commit 16fc32f introduced an error in include/environment.h, which makes u-boot
fail to compile due to a missing #endif.
This also fixes a merge conflict remaining in include/configs/EB+MCF-EV123.h
which was caused by the same commit
Signed-off-by: Albin Tonnerre albin.tonne...@free-electrons.com
---
include/configs/EB+MCF-EV123.h |7 ---
include/environment.h |1 +
2 files changed, 1 insertions(+), 7 deletions(-)
diff --git a/include/configs/EB+MCF-EV123.h b/include/configs/EB+MCF-EV123.h
index 1333a17..a0b27a8 100644
--- a/include/configs/EB+MCF-EV123.h
+++ b/include/configs/EB+MCF-EV123.h
@@ -63,13 +63,6 @@
#define CONFIG_ENV_ADDR0xF003C000 /* End of 256K */
#define CONFIG_ENV_SECT_SIZE 0x4000
#define CONFIG_ENV_IS_IN_FLASH 1
- HEAD:include/configs/EB+MCF-EV123.h
-===
-/*
-#define CONFIG_ENV_ADDR_REDUND 0xF0018000
-#define CONFIG_ENV_SECT_SIZE_REDUND0x4000
-*/
- unify {CONFIG_,}ENV_IS_EMBEDDED:include/configs/EB+MCF-EV123.h
#else
#define CONFIG_ENV_ADDR0xFFE04000
#define CONFIG_ENV_SECT_SIZE 0x2000
diff --git a/include/environment.h b/include/environment.h
index 6188457..b9924fd 100644
--- a/include/environment.h
+++ b/include/environment.h
@@ -100,6 +100,7 @@
!defined(CONFIG_ENV_IS_IN_NAND) \
!defined(CONFIG_ENV_IS_IN_ONENAND)
# error CONFIG_ENV_IS_EMBEDDED not supported for your flash type
+# endif
#endif
/*
--
1.6.0.4
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] mpc83xx: update LCRR register handling
MPC8379E RM says (10-34): Once LCRR[CLKDIV] is written, the register should be read, and then an isync should be executed. So update this in code. Also define a LCRR mask for processors, which uses not all bits in the LCRR register (as for example mpc832x did). Signed-off-by: Heiko Schocher h...@denx.de --- cpu/mpc83xx/cpu_init.c | 11 +-- include/mpc83xx.h |5 + 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/cpu/mpc83xx/cpu_init.c b/cpu/mpc83xx/cpu_init.c index ea4f2af..b733fce 100644 --- a/cpu/mpc83xx/cpu_init.c +++ b/cpu/mpc83xx/cpu_init.c @@ -23,8 +23,8 @@ #include common.h #include mpc83xx.h #include ioports.h -#ifdef CONFIG_USB_EHCI_FSL #include asm/io.h +#ifdef CONFIG_USB_EHCI_FSL #include usb/ehci-fsl.h #endif @@ -194,7 +194,14 @@ void cpu_init_f (volatile immap_t * im) im-reset.rmr = (RMR_CSRE (1RMR_CSRE_SHIFT)); /* LCRR - Clock Ratio Register (10.3.1.16) */ - im-lbus.lcrr = CONFIG_SYS_LCRR; + out_be32(im-lbus.lcrr, ((in_be32(im-lbus.lcrr) ~LCRR_MASK) | \ + (CONFIG_SYS_LCRR LCRR_MASK))); + /* MPC8379E RM 10-34 says after writting this register +* the register should be reread and an isync should be +* executed. +*/ + in_be32(im-lbus.lcrr); + isync(); /* Enable Time Base Decrimenter ( so we will have udelay() )*/ im-sysconf.spcr |= SPCR_TBEN; diff --git a/include/mpc83xx.h b/include/mpc83xx.h index 44115c9..41bb845 100644 --- a/include/mpc83xx.h +++ b/include/mpc83xx.h @@ -198,6 +198,7 @@ #define SICRL_URT_CTPR 0x0600 #define SICRL_IRQ_CTPR 0x00C0 +#define LCRR_MASK 0x0003000f #elif defined(CONFIG_MPC8313) /* SICRL bits - MPC8313 specific */ #define SICRL_LBC 0x3000 @@ -1200,6 +1201,10 @@ #define PEX_GCLK_RATIO 0x440 +#if !defined(LCRR_MASK) +#define LCRR_MASK 0x +#endif + #ifndef __ASSEMBLY__ struct pci_region; void mpc83xx_pci_init(int num_buses, struct pci_region **reg, int warmboot); -- 1.6.0.6 -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mpc83xx: update LCRR register handling
MPC8379E RM says (10-34): Once LCRR[CLKDIV] is written, the register should be read, and then an isync should be executed. So update this in code. Also define a LCRR mask for processors, which uses not all bits in the LCRR register (as for example mpc832x did). Signed-off-by: Heiko Schocher h...@denx.de --- cpu/mpc83xx/cpu_init.c | 11 +-- include/mpc83xx.h |5 + 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/cpu/mpc83xx/cpu_init.c b/cpu/mpc83xx/cpu_init.c index ea4f2af..b733fce 100644 --- a/cpu/mpc83xx/cpu_init.c +++ b/cpu/mpc83xx/cpu_init.c @@ -23,8 +23,8 @@ #include common.h #include mpc83xx.h #include ioports.h -#ifdef CONFIG_USB_EHCI_FSL #include asm/io.h +#ifdef CONFIG_USB_EHCI_FSL #include usb/ehci-fsl.h #endif @@ -194,7 +194,14 @@ void cpu_init_f (volatile immap_t * im) im-reset.rmr = (RMR_CSRE (1RMR_CSRE_SHIFT)); /* LCRR - Clock Ratio Register (10.3.1.16) */ - im-lbus.lcrr = CONFIG_SYS_LCRR; + out_be32(im-lbus.lcrr, ((in_be32(im-lbus.lcrr) ~LCRR_MASK) | \ + (CONFIG_SYS_LCRR LCRR_MASK))); + /* MPC8379E RM 10-34 says after writting this register + * the register should be reread and an isync should be + * executed. + */ + in_be32(im-lbus.lcrr); + isync(); Hi Heiko, It would be great if you guy can move this code to cpu_init_r. If we change the local bus clock freq while the code is running from the local bus, it is not safe. Thanks, Dave ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Blacfin.
On Tuesday 25 August 2009 04:45:14 benix samuel wrote: please do not top post I am using Blackfin BF531 ( a customized board). when I browsed the u-boot code it has chunks of folder for different platforms. Can you provide me the source code for this particulare platform alone? please read the documentation: http://docs.blackfin.uclinux.org/doku.php?id=bootloaders:u-boot -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Phy lib again
On 09:08 Tue 25 Aug , Stefan Roese wrote: Hi Michal, On Tuesday 25 August 2009 09:02:14 Michal Simek wrote: I saw you have phy lib in your branch. What is the current state? Are there any problems? When do you want to add to mainline? IIRC, Jean-Christophe is also working on a PHY lib implementation (port from the Linux version). Jean-Christophe, what's the current status of this work? I suggest you start sending ideas/patches for discussion soon, perhaps as RFC in the first stage. as I've nearly finish but yes I can send an RFC Best Regards, J. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RTC value corruption on QIL-A9G20 startup
Hi, Albin Tonnerre a écrit : Currently, I don't really have any idea. Besides, it's going to be hard for me to debug this, as I don't have an oscilloscope at hand. Would you please try to run u-boot within a debugger to see where exactly the CS line is driven low? isn't the RTC connected to the SPI chip select that the internal firmware toggle on boot to probe for a SPI Flash ? Eric ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] U-boot environment on Sheevaplug
-Original Message- From: Simon Kagstrom [mailto:simon.kagst...@netinsight.net] Sent: Tuesday, August 25, 2009 1:00 PM To: U-Boot ML Cc: Prafulla Wadaskar; Nicolas Pitre Subject: Re: [U-Boot] U-boot environment on Sheevaplug Hi again! I just wanted to check if there has been any progress on the issue below (4-bit ECC support to read for the kernel / U-boot) during the summer. Hi Simon For u-boot, so far no progress for this :-( Regards.. Prafulla . ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix issues introduced by 16fc32f: unify {CONFIG_, }ENV_IS_EMBEDDED
On Tuesday 25 August 2009 04:46:07 Albin Tonnerre wrote: Commit 16fc32f introduced an error in include/environment.h, which makes u-boot fail to compile due to a missing #endif. This also fixes a merge conflict remaining in include/configs/EB+MCF-EV123.h which was caused by the same commit this is only an issue for the next branch ... my local git tree has the right number of #endif's, so i guess i must have sent out the wrong patch guess this needs to get squashed into the relevant change rather than added as a new commit. thanks for the update. -mike signature.asc Description: This is a digitally signed message part. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v3 15/17] Move low level eNET board init into dedicated sections (Abandoned)
This patch has been abandoned - It's place in the patch series has been kept so as not to disrupt the versioning of later patches Signed-off-by: Graeme Russ graeme.r...@gmail.com --- ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 16/17] Move low level eNET board init into dedicated sections
This patch is in readiness for moving all u-boot code + data from Flash to
RAM. Low level init code is not needed after bootstrap and therefore does
not need to be copied. Moving this code into dedicated sections makes it
easier
Signed-off-by: Graeme Russ graeme.r...@gmail.com
---
Version 2
- Modified slightly to account for dropping of patch 15 (no functional
changes)
board/eNET/eNET_start.S |3 +++
board/eNET/u-boot.lds |4 ++--
board/sc520_cdp/sc520_cdp_asm.S |1 +
board/sc520_cdp/u-boot.lds |4 ++--
board/sc520_spunk/sc520_spunk_asm.S |1 +
board/sc520_spunk/u-boot.lds|4 ++--
cpu/i386/sc520/sc520_asm.S |2 +-
cpu/i386/start.S|2 +-
8 files changed, 13 insertions(+), 8 deletions(-)
diff --git a/board/eNET/eNET_start.S b/board/eNET/eNET_start.S
index 1b07d62..1309ac7 100644
--- a/board/eNET/eNET_start.S
+++ b/board/eNET/eNET_start.S
@@ -23,6 +23,9 @@
#include hardware.h
+.section .start32, ax
+
+
/* board early intialization */
.globl early_board_init
early_board_init:
diff --git a/board/eNET/u-boot.lds b/board/eNET/u-boot.lds
index 4ea424d..284d2bd 100644
--- a/board/eNET/u-boot.lds
+++ b/board/eNET/u-boot.lds
@@ -78,8 +78,8 @@ SECTIONS
* The fff0 offset of resetvec is important, however.
*/
- . = 0xfe00;
- .start32 : AT (0x3807fe00) { *(.start32); }
+ . = 0xee00;
+ .start32 : AT (0x3807ee00) { *(.start32); }
. = 0xf800;
.start16 : AT (0x3807f800) { *(.start16); }
diff --git a/board/sc520_cdp/sc520_cdp_asm.S b/board/sc520_cdp/sc520_cdp_asm.S
index 3a8a03f..904cfb9 100644
--- a/board/sc520_cdp/sc520_cdp_asm.S
+++ b/board/sc520_cdp/sc520_cdp_asm.S
@@ -25,6 +25,7 @@
* We can then use the leds to display status information.
*/
+.section .start32, ax
sc520_cdp_registers:
/* sizeoffsetvalue */
.word 1 ; .word 0x040 ; .long 0x00 /* SDRAM buffer control */
diff --git a/board/sc520_cdp/u-boot.lds b/board/sc520_cdp/u-boot.lds
index df437c7..d232dc1 100644
--- a/board/sc520_cdp/u-boot.lds
+++ b/board/sc520_cdp/u-boot.lds
@@ -79,8 +79,8 @@ SECTIONS
*/
- . = 0xfe00;
- .start32 : AT (0x387ffe00) { *(.start32); }
+ . = 0xee00;
+ .start32 : AT (0x3807ee00) { *(.start32); }
. = 0xff00;
.start16 : AT (0x387fff00) { *(.start16); }
diff --git a/board/sc520_spunk/sc520_spunk_asm.S
b/board/sc520_spunk/sc520_spunk_asm.S
index eda7e91..020bd02 100644
--- a/board/sc520_spunk/sc520_spunk_asm.S
+++ b/board/sc520_spunk/sc520_spunk_asm.S
@@ -25,6 +25,7 @@
* We can then use the leds to display status information.
*/
+.section .start32, ax
sc520_cdp_registers:
/* sizeoffsetvalue */
.word 1 ; .word 0x040 ; .long 0x00 /* SDRAM buffer control */
diff --git a/board/sc520_spunk/u-boot.lds b/board/sc520_spunk/u-boot.lds
index efb570b..f6d1abf 100644
--- a/board/sc520_spunk/u-boot.lds
+++ b/board/sc520_spunk/u-boot.lds
@@ -80,8 +80,8 @@ SECTIONS
*/
- . = 0xfe00;
- .start32 : AT (0x387ffe00) { *(.start32); }
+ . = 0xee00;
+ .start32 : AT (0x3807ee00) { *(.start32); }
. = 0xff00;
.start16 : AT (0x387fff00) { *(.start16); }
diff --git a/cpu/i386/sc520/sc520_asm.S b/cpu/i386/sc520/sc520_asm.S
index 2042d9b..07e2acd 100644
--- a/cpu/i386/sc520/sc520_asm.S
+++ b/cpu/i386/sc520/sc520_asm.S
@@ -106,7 +106,7 @@
#include config.h
-.section .text
+.section .start32, ax
.equDRCCTL, 0x0fffef010 /* DRAM control register */
.equDRCTMCTL, 0x0fffef012 /* DRAM timing control register */
.equDRCCFG, 0x0fffef014 /* DRAM bank configuration register
*/
diff --git a/cpu/i386/start.S b/cpu/i386/start.S
index 59089ef..bb4a5cf 100644
--- a/cpu/i386/start.S
+++ b/cpu/i386/start.S
@@ -27,7 +27,7 @@
#include version.h
-.section .text
+.section .start32, ax
.code32
.globl _start
.type _start, @function
--
1.6.4.1.174.g32f4c
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix issues introduced by 16fc32f: unify {CONFIG_, }ENV_IS_EMBEDDED
On Tue, Aug 25, 2009 at 06:16:24AM -0400, Mike Frysinger wrote : On Tuesday 25 August 2009 04:46:07 Albin Tonnerre wrote: Commit 16fc32f introduced an error in include/environment.h, which makes u-boot fail to compile due to a missing #endif. This also fixes a merge conflict remaining in include/configs/EB+MCF-EV123.h which was caused by the same commit this is only an issue for the next branch ... my local git tree has the right number of #endif's, so i guess i must have sent out the wrong patch guess this needs to get squashed into the relevant change rather than added as a new commit. thanks for the update. How exactly would you do that? The commit actually got pushed, and AFAIK next doesn't get rebased Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] include/s3c24x0.h: fix S3C24X0_SPI_CHANNEL declaration
The SPI controller on the S3C24X0 has 8 bit registers, not 32 bit.
Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com
Signed-off-by: Wolfgang Denk w...@denx.de
---
include/s3c24x0.h | 22 ++
1 files changed, 14 insertions(+), 8 deletions(-)
diff --git a/include/s3c24x0.h b/include/s3c24x0.h
index 71f35a5..4fa8000 100644
--- a/include/s3c24x0.h
+++ b/include/s3c24x0.h
@@ -550,14 +550,20 @@ typedef struct {
/* SPI (see manual chapter 22) */
typedef struct {
- S3C24X0_REG32 SPCON;
- S3C24X0_REG32 SPSTA;
- S3C24X0_REG32 SPPIN;
- S3C24X0_REG32 SPPRE;
- S3C24X0_REG32 SPTDAT;
- S3C24X0_REG32 SPRDAT;
- S3C24X0_REG32 res[2];
-} __attribute__((__packed__)) S3C24X0_SPI_CHANNEL;
+ S3C24X0_REG8SPCON;
+ S3C24X0_REG8res1[3];
+ S3C24X0_REG8SPSTA;
+ S3C24X0_REG8res2[3];
+ S3C24X0_REG8SPPIN;
+ S3C24X0_REG8res3[3];
+ S3C24X0_REG8SPPRE;
+ S3C24X0_REG8res4[3];
+ S3C24X0_REG8SPTDAT;
+ S3C24X0_REG8res5[3];
+ S3C24X0_REG8SPRDAT;
+ S3C24X0_REG8res6[3];
+ S3C24X0_REG8res7[16];
+} /*__attribute__((__packed__))*/ S3C24X0_SPI_CHANNEL;
typedef struct {
S3C24X0_SPI_CHANNEL ch[S3C24X0_SPI_CHANNELS];
--
1.6.0.6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 16/17] Move low level eNET board init into dedicated sections
Dear Graeme Russ, In message 1251195588-7799-1-git-send-email-graeme.r...@gmail.com you wrote: This patch is in readiness for moving all u-boot code + data from Flash to RAM. Low level init code is not needed after bootstrap and therefore does not need to be copied. Moving this code into dedicated sections makes it easier But is this worth the effort? It makes the design more complicated. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de In a business, marketroids, salespukes, and lawyers have different goals from those who actually do work and produce something. Usually, is is the former who triumph over the latter, due to the simple rule that those who print the money make the rules. -- Tom Christiansen in 5jdcls$b0...@csnews.cs.colorado.edu ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix issues introduced by 16fc32f: unify {CONFIG_, }ENV_IS_EMBEDDED
Dear Albin Tonnerre, In message 20090825102110.ge10...@pc-ras4041.res.insa you wrote: guess this needs to get squashed into the relevant change rather than added as a new commit. thanks for the update. How exactly would you do that? The commit actually got pushed, and AFAIK next doesn't get rebased It gets rebased when there is a need to do so. This seems to be such a case. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de 1 1 was a race-horse, 2 2 was 1 2. When 1 1 1 1 race, 2 2 1 1 2. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API
Dear Ben Warren, In message 4a9069e9.2030...@gmail.com you wrote: Tested on mx31ads: works like a charm. Great news! Thanks! Will try to debug the trab issues later tonight (if I manage to find a matching JTAG connector for this board ). OK, tested on trab (= SMDK2400), too. [The observed problems were caused by other, unrelated issues.] You might want to consider adding this patch, though: From e1236c57d747c4b686f9918dba2333d4df539a54 Mon Sep 17 00:00:00 2001 From: Wolfgang Denk w...@denx.de Date: Tue, 25 Aug 2009 11:55:16 +0200 Subject: [PATCH] cs8900.c: Fix implicit integer to pointer conversion --- drivers/net/cs8900.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c index bfe..587f7f6 100644 --- a/drivers/net/cs8900.c +++ b/drivers/net/cs8900.c @@ -68,12 +68,13 @@ static u16 get_reg_init_bus(struct eth_device *dev, int regno) /* force 16 bit busmode */ volatile u8 c; struct cs8900_priv *priv = (struct cs8900_priv *)(dev-priv); + uint8_t volatile * const iob = (uint8_t volatile * const)dev-iobase; - c = readb(dev-iobase); - c = readb(dev-iobase + 1); - c = readb(dev-iobase); - c = readb(dev-iobase + 1); - c = readb(dev-iobase); + c = readb(iob); + c = readb(iob + 1); + c = readb(iob); + c = readb(iob + 1); + c = readb(iob); REG_WRITE(regno, priv-regs-pptr); return REG_READ(priv-regs-pdata); -- 1.6.0.6 With or without that: Tested-by: Wolfgang Denk w...@denx.de Acked-by: Wolfgang Denk w...@denx.de Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The goal of science is to build better mousetraps. The goal of nature is to build better mice. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 16/17] Move low level eNET board init into dedicated sections
Wolfgang Denk wrote: Dear Graeme Russ, In message 1251195588-7799-1-git-send-email-graeme.r...@gmail.com you wrote: This patch is in readiness for moving all u-boot code + data from Flash to RAM. Low level init code is not needed after bootstrap and therefore does not need to be copied. Moving this code into dedicated sections makes it easier But is this worth the effort? It makes the design more complicated. Actually I think the opposite is true - The low level asm code is all placed at the bottom (or is it top?) end of the Boot Flash rather than interleaved in the rest of the .text section. This is critical for the real mode code as there is a tight limit on the jump lengths. This patch makes it all the more consistent Best regards, Wolfgang Denk Regards, G ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Fix issues introduced by 16fc32f: unify {CONFIG_, }ENV_IS_EMBEDDED
Dear Albin Tonnerre, In message 1251189967-11702-1-git-send-email-albin.tonne...@free-electrons.com you wrote: Commit 16fc32f introduced an error in include/environment.h, which makes u-boot fail to compile due to a missing #endif. This also fixes a merge conflict remaining in include/configs/EB+MCF-EV123.h which was caused by the same commit Signed-off-by: Albin Tonnerre albin.tonne...@free-electrons.com --- include/configs/EB+MCF-EV123.h |7 --- include/environment.h |1 + 2 files changed, 1 insertions(+), 7 deletions(-) Applied to next branch (and rebased next to clean up the mess). Thanks for catching / fixing this. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de You don't have to worry about me. I might have been born yesterday... but I stayed up all night. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [STATUS] next branch rebased
Hi all, unfortunately some merge conflicts have creeped in undetected into the next branch. To fix the mess I had to rebase the next branch. Sorry if this is causing inconveniences. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A wise person makes his own decisions, a weak one obeys public opinion. -- Chinese proverb ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] mpc83xx: update LCRR register handling
MPC8379E RM says (10-34):
Once LCRR[CLKDIV] is written, the register should be read, and then
an isync should be executed.
So update this in code.
Also define a LCRR mask for processors, which uses not all bits
in the LCRR register (as for example mpc832x did).
Signed-off-by: Heiko Schocher h...@denx.de
---
- added comment from DaveLiu. moved LCRR setting to
cpu_init_r()
cpu/mpc83xx/cpu_init.c | 19 +++
include/mpc83xx.h |5 +
2 files changed, 20 insertions(+), 4 deletions(-)
diff --git a/cpu/mpc83xx/cpu_init.c b/cpu/mpc83xx/cpu_init.c
index ea4f2af..3ca57aa 100644
--- a/cpu/mpc83xx/cpu_init.c
+++ b/cpu/mpc83xx/cpu_init.c
@@ -23,8 +23,8 @@
#include common.h
#include mpc83xx.h
#include ioports.h
-#ifdef CONFIG_USB_EHCI_FSL
#include asm/io.h
+#ifdef CONFIG_USB_EHCI_FSL
#include usb/ehci-fsl.h
#endif
@@ -193,9 +193,6 @@ void cpu_init_f (volatile immap_t * im)
*/
im-reset.rmr = (RMR_CSRE (1RMR_CSRE_SHIFT));
- /* LCRR - Clock Ratio Register (10.3.1.16) */
- im-lbus.lcrr = CONFIG_SYS_LCRR;
-
/* Enable Time Base Decrimenter ( so we will have udelay() )*/
im-sysconf.spcr |= SPCR_TBEN;
@@ -329,8 +326,22 @@ void cpu_init_f (volatile immap_t * im)
int cpu_init_r (void)
{
+ volatile immap_t *im = (volatile immap_t *)CONFIG_SYS_IMMR;
#ifdef CONFIG_QE
uint qe_base = CONFIG_SYS_IMMR + 0x0010; /* QE immr base */
+#endif
+
+ /* LCRR - Clock Ratio Register (10.3.1.16) */
+ out_be32(im-lbus.lcrr, ((in_be32(im-lbus.lcrr) ~LCRR_MASK) | \
+ (CONFIG_SYS_LCRR LCRR_MASK)));
+ /* MPC8379E RM 10-34 says after writting this register
+* the register should be reread and an isync should be
+* executed.
+*/
+ in_be32(im-lbus.lcrr);
+ isync();
+
+#ifdef CONFIG_QE
qe_init(qe_base);
qe_reset();
#endif
diff --git a/include/mpc83xx.h b/include/mpc83xx.h
index 44115c9..41bb845 100644
--- a/include/mpc83xx.h
+++ b/include/mpc83xx.h
@@ -198,6 +198,7 @@
#define SICRL_URT_CTPR 0x0600
#define SICRL_IRQ_CTPR 0x00C0
+#define LCRR_MASK 0x0003000f
#elif defined(CONFIG_MPC8313)
/* SICRL bits - MPC8313 specific */
#define SICRL_LBC 0x3000
@@ -1200,6 +1201,10 @@
#define PEX_GCLK_RATIO 0x440
+#if !defined(LCRR_MASK)
+#define LCRR_MASK 0x
+#endif
+
#ifndef __ASSEMBLY__
struct pci_region;
void mpc83xx_pci_init(int num_buses, struct pci_region **reg, int warmboot);
--
1.6.0.6
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v4] use common code for Matrix Vision boards
Wolfgang,
is there any chance this patch can be applied before the merge window
closes ?
Is there anything you want me to do or change, i.e. have I missed
something ?
Surely I don't want to bother you - just asking.
Regards,
Andre
On Wed, 2009-08-19 at 13:41 +0200, André Schwarz wrote:
clean up existing boards (mvBC-P/MPC5200 and mvBL-M7/MPC8343)
by using common code.
Signed-off-by: André Schwarz andre.schw...@matrix-vision.de
---
Wolfgang,
this is my current diff against your latest master repository - I'm
unable to split it anymore.
Unfortunately the e1000 is currently not working on the mvBC-P but this
is due to changes in drivers/net/e1000.c ... using the last released
version is working fine. Will contact the maintainer to fix it.
Hopefully you'll nevertheless apply this patch so that everybody using
the boards can get up-to-date again.
Regards,
André
board/matrix_vision/mvbc_p/mvbc_p.c | 97
+-
board/matrix_vision/mvbc_p/mvbc_p.h |2 +-
board/matrix_vision/mvbc_p/mvbc_p_autoscript | 10 ++-
board/matrix_vision/mvblm7/mvblm7.c | 54 ++
board/matrix_vision/mvblm7/mvblm7.h |3 +-
board/matrix_vision/mvblm7/pci.c | 35 ++
include/configs/MVBC_P.h |2 +-
include/configs/MVBLM7.h | 49 +
8 files changed, 77 insertions(+), 175 deletions(-)
diff --git a/board/matrix_vision/mvbc_p/mvbc_p.c
b/board/matrix_vision/mvbc_p/mvbc_p.c
index a300342..0cbe900 100644
--- a/board/matrix_vision/mvbc_p/mvbc_p.c
+++ b/board/matrix_vision/mvbc_p/mvbc_p.c
@@ -39,6 +39,7 @@
#include asm/io.h
#include fpga.h
#include mvbc_p.h
+#include ../common/mv_common.h
#define SDRAM_MODE 0x00CD
#define SDRAM_CONTROL0x504F
@@ -134,23 +135,6 @@ void mvbc_init_gpio(void)
printf(sint_gpioe : 0x%08x\n, gpio-sint_gpioe);
}
-void reset_environment(void)
-{
- char *s, sernr[64];
-
- printf(\n*** RESET ENVIRONMENT ***\n);
- memset(sernr, 0, sizeof(sernr));
- s = getenv(serial#);
- if (s) {
- printf(found serial# : %s\n, s);
- strncpy(sernr, s, 64);
- }
- gd-env_valid = 0;
- env_relocate();
- if (s)
- setenv(serial#, sernr);
-}
-
int misc_init_r(void)
{
char *s = getenv(reset_env);
@@ -166,7 +150,7 @@ int misc_init_r(void)
return 0;
}
printf( === FACTORY RESET ===\n);
- reset_environment();
+ mv_reset_environment();
saveenv();
return -1;
@@ -206,19 +190,28 @@ void flash_afterinit(ulong size)
void pci_mvbc_fixup_irq(struct pci_controller *hose, pci_dev_t dev)
{
unsigned char line = 0xff;
+ char *s = getenv(pci_latency);
u32 base;
+ u8 val = 0;
+
+ if (s)
+ val = simple_strtoul(s, NULL, 16);
if (PCI_BUS(dev) == 0) {
switch (PCI_DEV (dev)) {
case 0xa: /* FPGA */
line = 3;
pci_hose_read_config_dword(hose, dev,
PCI_BASE_ADDRESS_0, base);
- printf(found FPA - enable arbitration\n);
+ printf(found FPGA - enable arbitration\n);
writel(0x03, (u32*)(base + 0x80c0));
writel(0xf0, (u32*)(base + 0x8080));
+ if (val)
+ pci_hose_write_config_byte(hose, dev,
PCI_LATENCY_TIMER, val);
break;
case 0xb: /* LAN */
line = 2;
+ if (val)
+ pci_hose_write_config_byte(hose, dev,
PCI_LATENCY_TIMER, val);
break;
case 0x1a:
break;
@@ -234,85 +227,31 @@ struct pci_controller hose = {
fixup_irq:pci_mvbc_fixup_irq
};
-int mvbc_p_load_fpga(void)
-{
- size_t data_size = 0;
- void *fpga_data = NULL;
- char *datastr = getenv(fpgadata);
- char *sizestr = getenv(fpgadatasize);
-
- if (datastr)
- fpga_data = (void *)simple_strtoul(datastr, NULL, 16);
- if (sizestr)
- data_size = (size_t)simple_strtoul(sizestr, NULL, 16);
-
- return fpga_load(0, fpga_data, data_size);
-}
-
extern void pci_mpc5xxx_init(struct pci_controller *);
void pci_init_board(void)
{
- char *s;
- int load_fpga = 1;
-
mvbc_p_init_fpga();
- s = getenv(skip_fpga);
- if (s) {
- printf(found 'skip_fpga' - FPGA _not_ loaded !\n);
- load_fpga = 0;
- }
- if (load_fpga) {
- printf(loading FPGA ... );
- mvbc_p_load_fpga();
- printf(done\n);
- }
+ mv_load_fpga();
pci_mpc5xxx_init(hose);
}
-u8 *dhcp_vendorex_prep(u8 *e)
-{
- char *ptr;
-
- /*
Re: [U-Boot] [PATCH v2] mpc83xx: update LCRR register handling
-Original Message- From: Heiko Schocher [mailto:h...@denx.de] Sent: Tuesday, August 25, 2009 7:32 PM To: Liu Dave-R63238 Cc: Phillips Kim-R1AAHA; U-Boot user list Subject: [PATCH v2] mpc83xx: update LCRR register handling MPC8379E RM says (10-34): Once LCRR[CLKDIV] is written, the register should be read, and then an isync should be executed. So update this in code. Also define a LCRR mask for processors, which uses not all bits in the LCRR register (as for example mpc832x did). Signed-off-by: Heiko Schocher h...@denx.de Acked-by: Dave Liu dave...@freescale.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RTC value corruption on QIL-A9G20 startup
Hi Albin, On Tue, Aug 25, 2009 at 4:37 AM, Albin Tonnerre albin.tonne...@free-electrons.com wrote: I guess you mean SBC35-A9G20? I actually tried it with the patches for both boards (TNY SBC35) and saw the same result. Everything seems to work properly except the RTC. They use the same M41T94 part and the CS is the same on both boards (PA3). I can set the RTC using the date command and read back the value okay. However, when I power cycle the board, the value is getting corrupted at startup due to some erroneous SPI write. I don't believe the code you submitted is causing this problem because the RTC is getting corrupted even if I compile out SPI and RTC support completely. I was just wondering if you have seen this problem on your board? Yes, I also experience this issue. Well, at least I'm not the only one. :) I probed the CS line with an oscilloscope and I am definitely seeing it go low on U-Boot startup for a short time, but the clock line seems to be floating. I believe the activation of the CS at startup is causing junk data to be written to the RTC, which is corrupting it. Any idea why this might be happenning? Currently, I don't really have any idea. Besides, it's going to be hard for me to debug this, as I don't have an oscilloscope at hand. Would you please try to run u-boot within a debugger to see where exactly the CS line is driven low? I upgraded to the next branch and the problem seems to have gone away. I will continue to investigate the root cause of this and let you know what I find. Regards, Stephen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RTC value corruption on QIL-A9G20 startup
Hello Eric, On Tue, Aug 25, 2009 at 5:38 AM, Eric Bénarde...@eukrea.com wrote: isn't the RTC connected to the SPI chip select that the internal firmware toggle on boot to probe for a SPI Flash ? That is certainly possible. This problem went away for me when I upgraded to the next branch. Could the SPI dataflash code have been removed between v2009.06 and next? I'll look into this some more. Thanks for the hint! Regards, Stephen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix
Renato Andreola wrote:
From 21d84ab72266f118794233176bd356d8b1cfdf35 Mon Sep 17 00:00:00 2001
From: Renato Andreola renato.andre...@imagos.it
Date: Fri, 21 Aug 2009 18:05:51 +0200
Subject: [PATCH] drivers/mtd/cfi_flash: precision and underflow problem in
tout calculation
With old configuration it could happen tout=0 if CONFIG_SYS_HZ1000.
Signed-off-by: Alessandro Rubini rub...@gnudd.com Renato Andreola
renato.andre...@imagos.it
---
drivers/mtd/cfi_flash.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 81ac5d3..0d8fc54 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -660,9 +660,11 @@ static int flash_status_check (flash_info_t * info,
flash_sect_t sector,
ulong start;
#if CONFIG_SYS_HZ != 1000
- tout *= CONFIG_SYS_HZ/1000;
-#endif
-
+ if ((ulong)CONFIG_SYS_HZ 10)
+ tout *= (ulong)CONFIG_SYS_HZ/1000; /* for a big HZ, avoid
overflow */
+ else
+ tout = DIV_ROUND_UP(tout*(ulong)CONFIG_SYS_HZ, 1000);
+#endif
/* Wait for command completion */
start = get_timer (0);
while (flash_is_busy (info, sector)) {
What should to be fixed first in this case, would be your CONFIG_SYS_HZ
setting, that is NIOS2? timer implementation, yeah really. But I would
also point out that there is another case flash_status_check() doensn't
work as expected.
One of my colleagues found that with some flash device(s) (I don't
recall precisely, sorry), 'tout' would be probed to be zero. In that
case, a workaround something like above still doesn't work.
We have not sorted out where the problem is; it might be in cfi_flash.c,
or in the flash device itself. This is observed with v2009.03 release,
and we've been having a workaround for it for months. I'd like to have
a look someday.
Anyway, checking to see if 'tout' is zero or not would be sometimes
worth a try, when you think cfi_flash.c doesn't work as expected.
Just for your information,
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 2/3] Reset interrupted i2c slaves (galaxy5200)
Reset any i2c devices that may have been interrupted by a system reset.
Normally this would be accomplished by clocking the line until SCL and SDA
are released and then sending a start condtiion (From an Atmel datasheet).
But since there is only write access to these lines on the MPC5200 we can
only attempt to reset any slave devices by sending more start commands than
bits the slave is attempting to transmit.
Signed-off-by: Eric Millbrandt emillbra...@dekaresearch.com
---
Some whitespace cleanup and typos are included in this patch
board/galaxy5200/galaxy5200.c | 41 +
include/configs/galaxy5200.h |9 +
2 files changed, 46 insertions(+), 4 deletions(-)
diff --git a/board/galaxy5200/galaxy5200.c b/board/galaxy5200/galaxy5200.c
index 5aa9d3a..c38e7de 100644
--- a/board/galaxy5200/galaxy5200.c
+++ b/board/galaxy5200/galaxy5200.c
@@ -155,6 +155,47 @@ phys_size_t initdram(int board_type)
return dramsize + dramsize2;
}
+/*
+ * Reset any i2c devices that may have been interrupted by a system reset.
+ * Normally this would be accomplished by clocking the line until SCL and SDA
+ * are released and then sending a start condtiion (From an Atmel datasheet).
+ * But since there is only write access to these lines on the MPC5200 we can
+ * only attempt to reset any slave devices by sending more start commands than
+ * bits the slave is attempting to transmit.
+ */
+int misc_init_f(void)
+{
+ volatile struct mpc5xxx_gpio *gpio =
+ (struct mpc5xxx_gpio *)MPC5XXX_GPIO;
+ int i;
+ u16 state;
+
+ state = gpio-outo_gpioe;
+
+ /* Enable gpio on i2c1 and i2c2 */
+ gpio-outo_gpioe |= 0xf;
+
+ /*
+* Send an i2c start command 16 times to reset the state machines on
+* any slave devices transmitting on the bus.
+*/
+ for (i = 0; i 16; i++) {
+ gpio-outo_dvo = 0x5;
+ udelay(5);
+ gpio-outo_dvo |= 0xa;
+ udelay(5);
+ gpio-outo_dvo = 0xa;
+ udelay(5);
+ gpio-outo_dvo = 0x0;
+ udelay(5);
+ }
+
+ /* Return control of i2c1 and i2c2 */
+ gpio-outo_gpioe = state;
+
+ return 0;
+}
+
int checkboard(void)
{
puts(Board: galaxy5200\n);
diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h
index e9a4569..eb2cae6 100644
--- a/include/configs/galaxy5200.h
+++ b/include/configs/galaxy5200.h
@@ -81,8 +81,8 @@
#endif
/* RAMBOOT will be defined automatically in memory section */
-#define MTDIDS_DEFAULT nor0=physmap-flash.0
-#define MTDPARTS_DEFAULT mtdparts=physmap-flash.0:256k(ubootl), \
+#define MTDIDS_DEFAULT nor0=physmap-flash.0
+#define MTDPARTS_DEFAULT mtdparts=physmap-flash.0:256k(ubootl), \
1792k(kernel),13312k(jffs2),256k(uboot)ro,256k(oftree),-(space)
/*
@@ -94,7 +94,7 @@
#undef CONFIG_BOOTARGS
#define CONFIG_PREBOOT echo; \
- echo Welcome to U-Boot\
+ echo Welcome to U-Boot;\
echo
/*
@@ -110,6 +110,7 @@
#define CONFIG_SYS_I2C_MODULE 2/* Select I2C module #1 or #2 */
#define CONFIG_SYS_I2C_SPEED 10/* 100 kHz */
#define CONFIG_SYS_I2C_SLAVE 0x7F
+#define CONFIG_MISC_INIT_F 1 /* Reset i2c busses */
/*
* EEPROM CAT24WC32 configuration
@@ -376,7 +377,7 @@
#define CONFIG_SYS_BOOTCS_STARTCONFIG_SYS_FLASH_BASE
#define CONFIG_SYS_BOOTCS_SIZE CONFIG_SYS_FLASH_SIZE
-#define CONFIG_SYS_RESET_ADDRESS 0xff00
+#define CONFIG_SYS_RESET_ADDRESS 0xff00
/*
* USB settings
--
1.6.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 3/3] Add chip select region to galaxy5200
Add chip select region for an Epson S1D15313. Signed-off-by: Eric Millbrandt emillbra...@dekaresearch.com --- include/configs/galaxy5200.h |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h index eb2cae6..54c6b80 100644 --- a/include/configs/galaxy5200.h +++ b/include/configs/galaxy5200.h @@ -212,6 +212,11 @@ #define CONFIG_SYS_CS1_SIZE0x9 #define CONFIG_SYS_CS1_CFG 0x0002d900 +/* Chip Select configuration for Epson S1D13513 */ +#define CONFIG_SYS_CS3_START 0x1000 +#define CONFIG_SYS_CS3_SIZE0x103f +#define CONFIG_SYS_CS3_CFG 0x3d10 + /* * Ethernet configuration */ -- 1.6.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH 1/3] Modify mpc5xxx_gpio to include i2c registers
Modify mpc5xxx_gpio structure to include the i2c output-only enable
and data value out registers.
Signed-off-by: Eric Millbrandt emillbra...@dekaresearch.com
---
A quick string search shows that no in-tree code is currently using any of
the modified fields and the structure size does not change.
include/mpc5xxx.h |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/mpc5xxx.h b/include/mpc5xxx.h
index 476d149..4a642a4 100644
--- a/include/mpc5xxx.h
+++ b/include/mpc5xxx.h
@@ -691,10 +691,10 @@ struct mpc5xxx_gpio {
volatile u32 simple_ddr;/* GPIO + 0x0c */
volatile u32 simple_dvo;/* GPIO + 0x10 */
volatile u32 simple_ival; /* GPIO + 0x14 */
- volatile u8 outo_gpioe; /* GPIO + 0x18 */
- volatile u8 reserved1[3]; /* GPIO + 0x19 */
- volatile u8 outo_dvo; /* GPIO + 0x1c */
- volatile u8 reserved2[3]; /* GPIO + 0x1d */
+ volatile u16 outo_gpioe;/* GPIO + 0x18 */
+ volatile u8 reserved1[2]; /* GPIO + 0x1a */
+ volatile u16 outo_dvo; /* GPIO + 0x1c */
+ volatile u8 reserved2[2]; /* GPIO + 0x1e */
volatile u8 sint_gpioe; /* GPIO + 0x20 */
volatile u8 reserved3[3]; /* GPIO + 0x21 */
volatile u8 sint_ode; /* GPIO + 0x24 */
--
1.6.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] After many resets, MPC8548 hangs when relocate code to RAM
Hi, I'm having a big problem with my board reset that it's very similar to MPC8548CDS. I've been using for a long time a reset just in MPC8548 core, using DBCR0 register. But after many resets, my u-boot crash when try to relocate code to ram, and I can't debug it with BDI. I saw the MPC8548 erratas and GEN14 errata advice to use the HRESET. So I tried using a sequencer power source that could solve my problem. As the core reset, this approach works fine for a while, but after many resets, it hangs in the same point. I'd review my ddr configurations, tlbs, laws and I'm really stuck at this time. Any suggestion of where my problem resides? Thanks a lot, Nedel, Werner. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] After many resets, MPC8548 hangs when relocate code to RAM
The time that the sequencer power source stays the HRESET down is configurable, as the time waiting to rise up. On Tue, Aug 25, 2009 at 11:14 AM, Werner Nedel wmne...@gmail.com wrote: Hi, I'm having a big problem with my board reset that it's very similar to MPC8548CDS. I've been using for a long time a reset just in MPC8548 core, using DBCR0 register. But after many resets, my u-boot crash when try to relocate code to ram, and I can't debug it with BDI. I saw the MPC8548 erratas and GEN14 errata advice to use the HRESET. So I tried using a sequencer power source that could solve my problem. As the core reset, this approach works fine for a while, but after many resets, it hangs in the same point. I'd review my ddr configurations, tlbs, laws and I'm really stuck at this time. Any suggestion of where my problem resides? Thanks a lot, Nedel, Werner. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/3] Reset interrupted i2c slaves (galaxy5200)
Hi Eric, On Tue, 2009-08-25 at 08:57 -0500, Eric Millbrandt wrote: Reset any i2c devices that may have been interrupted by a system reset. Normally this would be accomplished by clocking the line until SCL and SDA are released and then sending a start condtiion (From an Atmel datasheet). But since there is only write access to these lines on the MPC5200 we can only attempt to reset any slave devices by sending more start commands than bits the slave is attempting to transmit. snip diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h index e9a4569..eb2cae6 100644 --- a/include/configs/galaxy5200.h +++ b/include/configs/galaxy5200.h @@ -81,8 +81,8 @@ #endif /* RAMBOOT will be defined automatically in memory section */ -#define MTDIDS_DEFAULT nor0=physmap-flash.0 -#define MTDPARTS_DEFAULT mtdparts=physmap-flash.0:256k(ubootl), \ +#define MTDIDS_DEFAULT nor0=physmap-flash.0 +#define MTDPARTS_DEFAULT mtdparts=physmap-flash.0:256k(ubootl), \ 1792k(kernel),13312k(jffs2),256k(uboot)ro,256k(oftree),-(space) /* @@ -94,7 +94,7 @@ #undef CONFIG_BOOTARGS #define CONFIG_PREBOOT echo; \ - echo Welcome to U-Boot\ + echo Welcome to U-Boot;\ echo /* @@ -110,6 +110,7 @@ #define CONFIG_SYS_I2C_MODULE 2 /* Select I2C module #1 or #2 */ #define CONFIG_SYS_I2C_SPEED 10 /* 100 kHz */ #define CONFIG_SYS_I2C_SLAVE 0x7F +#define CONFIG_MISC_INIT_F 1 /* Reset i2c busses */ /* * EEPROM CAT24WC32 configuration @@ -376,7 +377,7 @@ #define CONFIG_SYS_BOOTCS_START CONFIG_SYS_FLASH_BASE #define CONFIG_SYS_BOOTCS_SIZE CONFIG_SYS_FLASH_SIZE -#define CONFIG_SYS_RESET_ADDRESS 0xff00 +#define CONFIG_SYS_RESET_ADDRESS 0xff00 Other than the #define CONFIG_MISC_INIT_F 1 change, the modifications to include/configs/galaxy5200.h should be separated out into a different patch (if you want to have them committed) as they don't have anything to do with the patch's title and description. Best, Peter ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix
This patch is necessary to fix the common case in which CONFIG_SYS_HZ is
just below 1000 (e.g. 999 that results from an integer division between
a system clock frequency like 8333Hz and a divisor like 83334).
In that case the CONFIG_SYS_HZ/1000 expression returns 0 and the tout *=
CONFIG_SYS_HZ/1000 multiplication is always 0.
As you said, an incorrect Common Flash Interface interrogation of the
flash registers can lead to a tout of 0 but this misbehavior should have
been caught by the first stages of the flash interrogation code.
Note that the AMD/Spansion chips does not work correctly in a Nios2
environment due to spurious read cycles generated when flash bus width
is lower than 32.
If the flash chip you used is not an Intel/Numoyx than you should have
to do some work to make them behave correctly (e.g. add extra wait state
into the procedures or some other tricks).
Renato
Shinya Kuribayashi wrote:
Renato Andreola wrote:
From 21d84ab72266f118794233176bd356d8b1cfdf35 Mon Sep 17 00:00:00 2001
From: Renato Andreola renato.andre...@imagos.it
Date: Fri, 21 Aug 2009 18:05:51 +0200
Subject: [PATCH] drivers/mtd/cfi_flash: precision and underflow problem in
tout calculation
With old configuration it could happen tout=0 if CONFIG_SYS_HZ1000.
Signed-off-by: Alessandro Rubini rub...@gnudd.com Renato Andreola
renato.andre...@imagos.it
---
drivers/mtd/cfi_flash.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 81ac5d3..0d8fc54 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -660,9 +660,11 @@ static int flash_status_check (flash_info_t * info,
flash_sect_t sector,
ulong start;
#if CONFIG_SYS_HZ != 1000
-tout *= CONFIG_SYS_HZ/1000;
-#endif
-
+if ((ulong)CONFIG_SYS_HZ 10)
+tout *= (ulong)CONFIG_SYS_HZ/1000; /* for a big HZ, avoid
overflow */
+else
+tout = DIV_ROUND_UP(tout*(ulong)CONFIG_SYS_HZ, 1000);
+#endif
/* Wait for command completion */
start = get_timer (0);
while (flash_is_busy (info, sector)) {
What should to be fixed first in this case, would be your CONFIG_SYS_HZ
setting, that is NIOS2? timer implementation, yeah really. But I would
also point out that there is another case flash_status_check() doensn't
work as expected.
One of my colleagues found that with some flash device(s) (I don't
recall precisely, sorry), 'tout' would be probed to be zero. In that
case, a workaround something like above still doesn't work.
We have not sorted out where the problem is; it might be in cfi_flash.c,
or in the flash device itself. This is observed with v2009.03 release,
and we've been having a workaround for it for months. I'd like to have
a look someday.
Anyway, checking to see if 'tout' is zero or not would be sometimes
worth a try, when you think cfi_flash.c doesn't work as expected.
Just for your information,
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 2/3] Reset interrupted i2c slaves (galaxy5200)
Reset any i2c devices that may have been interrupted by a system reset.
Normally this would be accomplished by clocking the line until SCL and SDA
are released and then sending a start condtiion (From an Atmel datasheet).
But since there is only write access to these lines on the MPC5200 we can
only attempt to reset any slave devices by sending more start commands than
bits the slave is attempting to transmit.
Signed-off-by: Eric Millbrandt emillbra...@dekaresearch.com
---
Changes since v1:
- Remove non-related modifications to a different patch per Peter's suggestion
board/galaxy5200/galaxy5200.c | 41 +
include/configs/galaxy5200.h |1 +
2 files changed, 42 insertions(+), 0 deletions(-)
diff --git a/board/galaxy5200/galaxy5200.c b/board/galaxy5200/galaxy5200.c
index 5aa9d3a..c38e7de 100644
--- a/board/galaxy5200/galaxy5200.c
+++ b/board/galaxy5200/galaxy5200.c
@@ -155,6 +155,47 @@ phys_size_t initdram(int board_type)
return dramsize + dramsize2;
}
+/*
+ * Reset any i2c devices that may have been interrupted by a system reset.
+ * Normally this would be accomplished by clocking the line until SCL and SDA
+ * are released and then sending a start condtiion (From an Atmel datasheet).
+ * But since there is only write access to these lines on the MPC5200 we can
+ * only attempt to reset any slave devices by sending more start commands than
+ * bits the slave is attempting to transmit.
+ */
+int misc_init_f(void)
+{
+ volatile struct mpc5xxx_gpio *gpio =
+ (struct mpc5xxx_gpio *)MPC5XXX_GPIO;
+ int i;
+ u16 state;
+
+ state = gpio-outo_gpioe;
+
+ /* Enable gpio on i2c1 and i2c2 */
+ gpio-outo_gpioe |= 0xf;
+
+ /*
+* Send an i2c start command 16 times to reset the state machines on
+* any slave devices transmitting on the bus.
+*/
+ for (i = 0; i 16; i++) {
+ gpio-outo_dvo = 0x5;
+ udelay(5);
+ gpio-outo_dvo |= 0xa;
+ udelay(5);
+ gpio-outo_dvo = 0xa;
+ udelay(5);
+ gpio-outo_dvo = 0x0;
+ udelay(5);
+ }
+
+ /* Return control of i2c1 and i2c2 */
+ gpio-outo_gpioe = state;
+
+ return 0;
+}
+
int checkboard(void)
{
puts(Board: galaxy5200\n);
diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h
index 8d530d8..eb2cae6 100644
--- a/include/configs/galaxy5200.h
+++ b/include/configs/galaxy5200.h
@@ -110,6 +110,7 @@
#define CONFIG_SYS_I2C_MODULE 2/* Select I2C module #1 or #2 */
#define CONFIG_SYS_I2C_SPEED 10/* 100 kHz */
#define CONFIG_SYS_I2C_SLAVE 0x7F
+#define CONFIG_MISC_INIT_F 1 /* Reset i2c busses */
/*
* EEPROM CAT24WC32 configuration
--
1.6.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] Cleanup typo and trailing whitespace
Cleanup typo and trailing whitespace from galaxy5200.h Signed-off-by: Eric Millbrandt emillbra...@dekaresearch.com --- include/configs/galaxy5200.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/configs/galaxy5200.h b/include/configs/galaxy5200.h index e9a4569..8d530d8 100644 --- a/include/configs/galaxy5200.h +++ b/include/configs/galaxy5200.h @@ -81,8 +81,8 @@ #endif /* RAMBOOT will be defined automatically in memory section */ -#define MTDIDS_DEFAULT nor0=physmap-flash.0 -#define MTDPARTS_DEFAULT mtdparts=physmap-flash.0:256k(ubootl), \ +#define MTDIDS_DEFAULT nor0=physmap-flash.0 +#define MTDPARTS_DEFAULT mtdparts=physmap-flash.0:256k(ubootl), \ 1792k(kernel),13312k(jffs2),256k(uboot)ro,256k(oftree),-(space) /* @@ -94,7 +94,7 @@ #undef CONFIG_BOOTARGS #define CONFIG_PREBOOT echo; \ - echo Welcome to U-Boot\ + echo Welcome to U-Boot;\ echo /* @@ -376,7 +376,7 @@ #define CONFIG_SYS_BOOTCS_STARTCONFIG_SYS_FLASH_BASE #define CONFIG_SYS_BOOTCS_SIZE CONFIG_SYS_FLASH_SIZE -#define CONFIG_SYS_RESET_ADDRESS 0xff00 +#define CONFIG_SYS_RESET_ADDRESS 0xff00 /* * USB settings -- 1.6.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] How can I make a second serial port on a motorola 8248 Chip known to Linux.
Hello, I am working with a mpc8260ads(actually QUICC 8248 processor) based board. There are two hardware rs-232 ports available. I can switch the console between the two by switching the CONFIG_CONS_INDEX configuration variable between 1 and 4. I would like to have both ports in service, when Linux comes up. One as the console and the second to communicate with(i.e. acquire data from) a third party rs-232 device. Eventually, the third party device may be a telephone modem. Can anyone explain how to accomplish this, and if not, what constraints are blocking the accomplishment of my requirements. Any suggestions will be appreciated. Thank You. -- View this message in context: http://www.nabble.com/How-can-I-make-a-second-serial-port-on-a-motorola-8248-Chip-known-to-Linux.-tp25136771p25136771.html Sent from the Uboot - Users mailing list archive at Nabble.com. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2] mpc83xx: update LCRR register handling
On Tue, 25 Aug 2009 13:31:34 +0200
Heiko Schocher h...@denx.de wrote:
MPC8379E RM says (10-34):
Once LCRR[CLKDIV] is written, the register should be read, and then
an isync should be executed.
So update this in code.
Also define a LCRR mask for processors, which uses not all bits
in the LCRR register (as for example mpc832x did).
Signed-off-by: Heiko Schocher h...@denx.de
---
thanks for this Heiko...some comments:
int cpu_init_r (void)
{
+ volatile immap_t *im = (volatile immap_t *)CONFIG_SYS_IMMR;
#ifdef CONFIG_QE
uint qe_base = CONFIG_SYS_IMMR + 0x0010; /* QE immr base */
+#endif
+
+ /* LCRR - Clock Ratio Register (10.3.1.16) */
+ out_be32(im-lbus.lcrr, ((in_be32(im-lbus.lcrr) ~LCRR_MASK) | \
+ (CONFIG_SYS_LCRR LCRR_MASK)));
..
+ /* MPC8379E RM 10-34 says after writting this register
+ * the register should be reread and an isync should be
+ * executed.
+ */
+ in_be32(im-lbus.lcrr);
+ isync();
in_be32 and friends does the isync for you. In fact, you can probably
do it in one fell swoop by using setbits/clrsetbits?
+++ b/include/mpc83xx.h
@@ -198,6 +198,7 @@
#define SICRL_URT_CTPR 0x0600
#define SICRL_IRQ_CTPR 0x00C0
+#define LCRR_MASK0x0003000f
I thought we discussed this - shouldn't this be 0x7fff?
Kim
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix
On Monday 24 August 2009 10:32:17 Renato Andreola wrote:
From 21d84ab72266f118794233176bd356d8b1cfdf35 Mon Sep 17 00:00:00 2001
From: Renato Andreola renato.andre...@imagos.it
Date: Fri, 21 Aug 2009 18:05:51 +0200
Subject: [PATCH] drivers/mtd/cfi_flash: precision and underflow problem in
tout calculation
With old configuration it could happen tout=0 if CONFIG_SYS_HZ1000.
Signed-off-by: Alessandro Rubini rub...@gnudd.com Renato Andreola
renato.andre...@imagos.it
A few mostly formal comments about this patch:
- Patch doesn't apply:
[ste...@stefan-desktop u-boot-cfi-flash (master)]$ git am -s patches_misc/\[U-
Boot\]\ PATCH\ mtd\ CFI\ flash\:\ timeout\ calculation\ underflow\ if\
imprecise\ 1kHz\ timer\:\ fix.mbox
Applying: PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz
timer: fix
/home/stefan/git/u-boot/u-boot-cfi-flash/.git/rebase-apply/patch:20: trailing
whitespace.
#endif
error: patch failed: drivers/mtd/cfi_flash.c:660
error: drivers/mtd/cfi_flash.c: patch does not apply
Please fix by using git format-patch and git send-email.
- Patch subject is mangled:
Applying your patch (if possible) would lead to this commit text/subject:
PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer:
fix. This is because your email subject is incorrect (e.g. PATCH should be
[PATCH]). And the subject it too long as well. Please use a shorter line here.
- Minor coding style problem (see below)
---
drivers/mtd/cfi_flash.c |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mtd/cfi_flash.c b/drivers/mtd/cfi_flash.c
index 81ac5d3..0d8fc54 100644
--- a/drivers/mtd/cfi_flash.c
+++ b/drivers/mtd/cfi_flash.c
@@ -660,9 +660,11 @@ static int flash_status_check (flash_info_t * info,
flash_sect_t sector, ulong start;
#if CONFIG_SYS_HZ != 1000
- tout *= CONFIG_SYS_HZ/1000;
-#endif
-
+ if ((ulong)CONFIG_SYS_HZ 10)
+ tout *= (ulong)CONFIG_SYS_HZ/1000; /* for a big HZ, avoid
overflow */
Please insert spaces before and after the / above.
+ else
+ tout = DIV_ROUND_UP(tout*(ulong)CONFIG_SYS_HZ, 1000);
+#endif
/* Wait for command completion */
start = get_timer (0);
while (flash_is_busy (info, sector)) {
Thanks.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] PATCH mtd CFI flash: timeout calculation underflow if imprecise 1kHz timer: fix
On Tuesday 25 August 2009 17:39:56 Stefan Roese wrote: + if ((ulong)CONFIG_SYS_HZ 10) + tout *= (ulong)CONFIG_SYS_HZ/1000; /* for a big HZ, avoid overflow */ Please insert spaces before and after the / above. + else + tout = DIV_ROUND_UP(tout*(ulong)CONFIG_SYS_HZ, 1000); And spaces before and after the * above as well. Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/1] ppc4xx: Fix ECC Correction bug with SMC ordering for NDFC driver
On Friday 21 August 2009 19:59:42 Feng Kan wrote: Fix ECC Correction bug where the byte offset location were double flipped causing correction routine to toggle the wrong byte location in the ECC segment. The ndfc_calculate_ecc routine change the order of getting the ECC code. /* The NDFC uses Smart Media (SMC) bytes order */ ecc_code[0] = p[2]; ecc_code[1] = p[1]; ecc_code[2] = p[3]; But in the Correction algorithm when calculating the byte offset location, the s1 is used as the upper part of the address. Which again reverse the order making the final byte offset address location incorrect. byteoffs = (s1 0) 0x80; . . byteoffs |= (s0 4) 0x08; The order is change to read it in straight and let the correction function to revert it to SMC order. Signed-off-by: Feng Kan f...@amcc.com Acked-by: Victor Gallardo vgalla...@amcc.com Acked-by: Prodyut Hazarika phazar...@amcc.com Applied to u-boot-ppc4xx/master. Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-ppc4xx/master
Hi Wolfgang, please pull this fix into master. Thanks. The following changes since commit a794f59a75bf9fd4a44f1ad2349cae903c42b89c: Jean-Christophe PLAGNIOL-VILLARD (1): sh/rsk7203: add missing include net.h are available in the git repository at: git://www.denx.de/git/u-boot-ppc4xx.git master Feng Kan (1): ppc4xx: Fix ECC Correction bug with SMC ordering for NDFC driver drivers/mtd/nand/ndfc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Question about Netconsole
Hi Detlev- I just wanted to let you know that I got Netconsole to work on my board. It turned out that the NetLoop routine was halting and initialing the TSEC driver over and over as part of the packet reception process. This was causing the interface to go up and down over and over and the packets were getting missed. My temporary workaround has been to update the tsec init and halt routines so that they don't do anything if stdin is configured to nc (I figure that the interface is already in use so it doesn't need to be updated). This seems to solve my problem for the time being and lets me continue on. Thank you for your suggestion. I really appreciate your help. Jared -Original Message- From: Detlev Zundel [mailto:d...@denx.de] Sent: Friday, August 21, 2009 5:58 AM To: Jared Lewis Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] Question about Netconsole Hi Jared, I have been having troubles getting Netconsole to work on eTSEC2 of a MPC8548 chip. I was hoping that maybe someone here might be able to help me. I'm currently using U-Boot v2009.01. Using the bash script code located in the README.Netconsole file, I have been able to successfully transmit data from the 8548 to my host machine over netcat (using v0.7.1 on Fedora Core 11). I've tested that this path works consistently by only piping stdout to 'nc'. My problem comes when I try to send data from the host machine to the 8548 (piping stdin to 'nc'). It seems like the data is getting transmitted by Netconsole (verified using wireshark), but it isn't getting consistently received by U-Boot. I set the ET_DEBUG flag to 1 so that I could get extra debug information. On rare occasions I have seen that packets are getting received, but this is very rarely. I do know that the connection is OK. I am able to transfer files using tftp without any problems. On one occasion I was able to print out an environment variable (a small victory), but it happened randomly. Does anyone have any idea why this might be happening? Any help would be greatly appreciated. You should check what your actual network driver is doing. As U-Boot is not interrupt driven, the big question is if and how packets on the network interface are buffered when U-Boot is not currently idle waiting. Unfortunately I have to admit that I do not know the exact control flow of netconsole coupled to the tsec driver, but what you could do is to trace tsec_halt and startup_tsec. Maybe they are called too often and/or take too long... Cheers Detlev -- Some people unfortunately like jumping up and down about spaces but not code. [...] I'd rather read good poetry written in very bad hand writing than bad poetry written in beautiful handwriting, and I think the same is true of code. -- Alan Cox 20090701130018.115ce...@lxorguk.ukuu.org.uk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API
Wolfgang, Wolfgang Denk wrote: Dear Ben Warren, In message 4a9069e9.2030...@gmail.com you wrote: Tested on mx31ads: works like a charm. Great news! Thanks! Will try to debug the trab issues later tonight (if I manage to find a matching JTAG connector for this board ). OK, tested on trab (= SMDK2400), too. [The observed problems were caused by other, unrelated issues.] Great! You might want to consider adding this patch, though: From e1236c57d747c4b686f9918dba2333d4df539a54 Mon Sep 17 00:00:00 2001 From: Wolfgang Denk w...@denx.de Date: Tue, 25 Aug 2009 11:55:16 +0200 Subject: [PATCH] cs8900.c: Fix implicit integer to pointer conversion --- drivers/net/cs8900.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c index bfe..587f7f6 100644 --- a/drivers/net/cs8900.c +++ b/drivers/net/cs8900.c @@ -68,12 +68,13 @@ static u16 get_reg_init_bus(struct eth_device *dev, int regno) /* force 16 bit busmode */ volatile u8 c; struct cs8900_priv *priv = (struct cs8900_priv *)(dev-priv); + uint8_t volatile * const iob = (uint8_t volatile * const)dev-iobase; - c = readb(dev-iobase); - c = readb(dev-iobase + 1); - c = readb(dev-iobase); - c = readb(dev-iobase + 1); - c = readb(dev-iobase); + c = readb(iob); + c = readb(iob + 1); + c = readb(iob); + c = readb(iob + 1); + c = readb(iob); REG_WRITE(regno, priv-regs-pptr); return REG_READ(priv-regs-pdata); I'll add this and put this in the net/next branch. Thanks for the help! regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Phy lib again
Hi Michal, Michal Simek wrote: Hi Stefan, Stefan Roese wrote: Hi Michal, On Tuesday 25 August 2009 09:02:14 Michal Simek wrote: I saw you have phy lib in your branch. What is the current state? Are there any problems? When do you want to add to mainline? IIRC, Jean-Christophe is also working on a PHY lib implementation (port from the Linux version). Jean-Christophe, what's the current status of this work? I suggest you start sending ideas/patches for discussion soon, perhaps as RFC in the first stage. Ben has it at http://git.denx.de/?p=u-boot/u-boot-net.git;a=shortlog;h=refs/heads/phylib A while ago I started porting the Linux PHY library to U-boot but got distracted. This branch contains the incomplete, untested work. I suspect JC is further along, so let's see what he comes up with. This is a complicated thing that requires a well-thought-out design, so I expect there will be much iteration. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RTC value corruption on QIL-A9G20 startup
On Tue, Aug 25, 2009 at 08:51:56AM -0400, Stephen Caudle wrote : Hello Eric, On Tue, Aug 25, 2009 at 5:38 AM, Eric Bénarde...@eukrea.com wrote: isn't the RTC connected to the SPI chip select that the internal firmware toggle on boot to probe for a SPI Flash ? That is certainly possible. This problem went away for me when I upgraded to the next branch. Could the SPI dataflash code have been removed between v2009.06 and next? I'll look into this some more. Thanks for the hint! Using the next branch doesn't help here. Anyway, the code Eric is referring to is the firmware code the CPU executes from its internal ROM very early in the boot process, so you likely won't find anything remotely related to this in U-Boot. Regards, -- Albin Tonnerre, Free Electrons Kernel, drivers and embedded Linux development, consulting, training and support. http://free-electrons.com signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] How can I make a second serial port on a motorola 8248 Chip known to Linux.
On Tue, Aug 25, 2009 at 08:37:11AM -0700, AGKohler wrote: Hello, I am working with a mpc8260ads(actually QUICC 8248 processor) based board. There are two hardware rs-232 ports available. I can switch the console between the two by switching the CONFIG_CONS_INDEX configuration variable between 1 and 4. I would like to have both ports in service, when Linux comes up. One as the console and the second to communicate with(i.e. acquire data from) a third party rs-232 device. Eventually, the third party device may be a telephone modem. Can anyone explain how to accomplish this, and if not, what constraints are blocking the accomplishment of my requirements. Any suggestions will be appreciated. This isn't a U-Boot issue, except insofar as U-Boot passes a device tree to Linux (assuming it does even that -- you don't mention which kernel or u-boot version you're using). If your device tree contains both serial ports, then Linux should be able to use them both. If it doesn't work, make sure all the pins are configured correctly, typically by Linux platform code for your board (though ideally U-Boot should set them up as well). -Scott ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] reloacting uboot
Dear E Robertson, In message 200908251403.20809.e.robertson@gmail.com you wrote: I am using the at91sam9263 device from which the bootstrap code load u-boot to the desired ram address. However, I would like to re-relocate this at the different address based on memory availability. Can / or should this be done? Yes, it can be done, and it should be done. The fact that we don't do it so far is due to the fact that the guys who did the original ARM code found this too complicated (even though they had a working example in the PowerPC code) and not worth the effort. We're suffering since from this misconception. But there is no reason why you would have to copy the code again - just copy it to the correct address right from the beginning, like we do in PowerPC. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de f u cn rd ths, itn tyg h myxbl cd. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] reloacting uboot
On Tuesday 25 August 2009 02:11:36 pm Wolfgang Denk wrote: Dear E Robertson, In message 200908251403.20809.e.robertson@gmail.com you wrote: I am using the at91sam9263 device from which the bootstrap code load u-boot to the desired ram address. However, I would like to re-relocate this at the different address based on memory availability. Can / or should this be done? Yes, it can be done, and it should be done. The fact that we don't do it so far is due to the fact that the guys who did the original ARM code found this too complicated (even though they had a working example in the PowerPC code) and not worth the effort. We're suffering since from this misconception. But there is no reason why you would have to copy the code again - just copy it to the correct address right from the beginning, like we do in PowerPC. I don't follow: Yes, but no reason to do so? On the 9263, it's copied once to ram at boot. Are you saying their is no reason to copy it again? If so, yes, in most cases that would be true but I would like to move it again after that initial relocation. Since I've already specified my start address, I wasn't sure about. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] reloacting uboot
Hi All, I am using the at91sam9263 device from which the bootstrap code load u-boot to the desired ram address. However, I would like to re-relocate this at the different address based on memory availability. Can / or should this be done? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] reloacting uboot
On Tuesday 25 August 2009 02:11:36 pm Wolfgang Denk wrote: Dear E Robertson, In message 200908251403.20809.e.robertson@gmail.com you wrote: I am using the at91sam9263 device from which the bootstrap code load u-boot to the desired ram address. However, I would like to re-relocate this at the different address based on memory availability. Can / or should this be done? Yes, it can be done, and it should be done. The fact that we don't do it so far is due to the fact that the guys who did the original ARM code found this too complicated (even though they had a working example in the PowerPC code) and not worth the effort. We're suffering since from this misconception. But there is no reason why you would have to copy the code again - just copy it to the correct address right from the beginning, like we do in PowerPC. By the way, my reason for doing this is that i want to maintain a proportional memory space available so if I increase the ram size I would like to relocate the boot loader without doing a separate build. Make sense? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v4][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API
All in-tree boards that use this controller have CONFIG_NET_MULTI added
Also:
- changed CONFIG_DRIVER_CS8900 to CONFIG_CS8900
- changed CS8900_BASE to CONFIG_CS8900_BASE
- changed CS8900_BUS?? to CONFIG_CS8900_BUS??
- cleaned up line lengths
- modified VCMA9 command function that accesses the device
- removed MAC address initialization from lib_arm/board.c
Signed-off-by: Ben Warren biggerbadder...@gmail.com
Tested-by: Wolfgang Denk w...@denx.de
Acked-by: Wolfgang Denk w...@denx.de
---
v4: Changed 8-bit accesses to use volatile keyword (change made by w...@denx.de)
v3: Added accessor macros to ensure proper bus access
v2: Fixed typo: CS8900_BUS32 - CONFIG_CS8900_BUS32
Added more descriptive printf in cs8900_init as suggested by Wolfgang
Initialize 'priv' data structure in cs8900_initialize()
board/altera/dk1c20/dk1c20.c | 12 ++
board/altera/dk1s10/dk1s10.c | 12 ++
board/armadillo/armadillo.c | 12 ++
board/csb226/csb226.c | 12 ++
board/ep7312/ep7312.c | 12 ++
board/freescale/mx31ads/mx31ads.c | 12 ++
board/impa7/impa7.c | 12 ++
board/lart/lart.c | 12 ++
board/mpl/vcma9/cmd_vcma9.c | 28 +++--
board/mpl/vcma9/vcma9.c | 12 ++
board/mx1ads/mx1ads.c | 12 ++
board/samsung/smdk2400/smdk2400.c | 12 ++
board/samsung/smdk2410/smdk2410.c | 12 ++
board/samsung/smdk6400/smdk6400.c | 12 ++
board/sbc2410x/sbc2410x.c | 12 ++
board/ssv/adnpesc1/adnpesc1.c | 12 ++
board/trab/trab.c | 12 ++
drivers/net/Makefile |2 +-
drivers/net/cs8900.c | 276 ++---
drivers/net/cs8900.h | 41 ---
include/configs/ADNPESC1.h| 14 +-
include/configs/DK1C20.h | 14 +-
include/configs/DK1S10.h | 14 +-
include/configs/VCMA9.h |7 +-
include/configs/armadillo.h |9 +-
include/configs/csb226.h |7 +-
include/configs/ep7312.h |9 +-
include/configs/impa7.h |7 +-
include/configs/lart.h|7 +-
include/configs/mx1ads.h |7 +-
include/configs/mx31ads.h |7 +-
include/configs/sbc2410x.h|7 +-
include/configs/smdk2400.h|7 +-
include/configs/smdk2410.h|7 +-
include/configs/smdk6400.h|7 +-
include/configs/trab.h|7 +-
include/netdev.h |1 +
lib_arm/board.c |9 --
38 files changed, 476 insertions(+), 210 deletions(-)
diff --git a/board/altera/dk1c20/dk1c20.c b/board/altera/dk1c20/dk1c20.c
index 11c19b7..0bcaa4f 100644
--- a/board/altera/dk1c20/dk1c20.c
+++ b/board/altera/dk1c20/dk1c20.c
@@ -25,6 +25,7 @@
*/
#include common.h
+#include netdev.h
#include nios-io.h
#ifdefined(CONFIG_SEVENSEG)
#include ../common/sevenseg.h
@@ -79,3 +80,14 @@ int ide_preinit (void)
return 0;
}
#endif
+
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+ int rc = 0;
+#ifdef CONFIG_CS8900
+ rc = cs8900_initialize(0, CONFIG_CS8900_BASE);
+#endif
+ return rc;
+}
+#endif
diff --git a/board/altera/dk1s10/dk1s10.c b/board/altera/dk1s10/dk1s10.c
index 64d591e..fb96501 100644
--- a/board/altera/dk1s10/dk1s10.c
+++ b/board/altera/dk1s10/dk1s10.c
@@ -22,6 +22,7 @@
*/
#include common.h
+#include netdev.h
#ifdefined(CONFIG_SEVENSEG)
#include ../common/sevenseg.h
#endif
@@ -58,3 +59,14 @@ phys_size_t initdram (int board_type)
{
return (0);
}
+
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+ int rc = 0;
+#ifdef CONFIG_CS8900
+ rc = cs8900_initialize(0, CONFIG_CS8900_BASE);
+#endif
+ return rc;
+}
+#endif
diff --git a/board/armadillo/armadillo.c b/board/armadillo/armadillo.c
index ca5bd1d..a825144 100644
--- a/board/armadillo/armadillo.c
+++ b/board/armadillo/armadillo.c
@@ -26,6 +26,7 @@
*/
#include common.h
+#include netdev.h
#include clps7111.h
DECLARE_GLOBAL_DATA_PTR;
@@ -58,3 +59,14 @@ int dram_init (void)
return (0);
}
+
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+ int rc = 0;
+#ifdef CONFIG_CS8900
+ rc = cs8900_initialize(0, CONFIG_CS8900_BASE);
+#endif
+ return rc;
+}
+#endif
diff --git a/board/csb226/csb226.c b/board/csb226/csb226.c
index 80caf8b..0a6c13d 100644
--- a/board/csb226/csb226.c
+++ b/board/csb226/csb226.c
@@ -24,6 +24,7 @@
*/
#include common.h
+#include netdev.h
#include asm/arch/pxa-regs.h
DECLARE_GLOBAL_DATA_PTR;
@@ -151,3 +152,14 @@ void show_boot_progress (int status)
return;
}
+
+#ifdef CONFIG_CMD_NET
+int board_eth_init(bd_t *bis)
+{
+ int rc = 0;
+#ifdef CONFIG_CS8900
+ rc = cs8900_initialize(0, CONFIG_CS8900_BASE);
+#endif
+ return rc;
+}
+#endif
diff --git a/board/ep7312/ep7312.c b/board/ep7312/ep7312.c
index 6968a5d..8ed14ad 100644
---
Re: [U-Boot] [PATCH v4][Net] Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API
Ben Warren wrote: All in-tree boards that use this controller have CONFIG_NET_MULTI added Also: - changed CONFIG_DRIVER_CS8900 to CONFIG_CS8900 - changed CS8900_BASE to CONFIG_CS8900_BASE - changed CS8900_BUS?? to CONFIG_CS8900_BUS?? - cleaned up line lengths - modified VCMA9 command function that accesses the device - removed MAC address initialization from lib_arm/board.c Signed-off-by: Ben Warren biggerbadder...@gmail.com Tested-by: Wolfgang Denk w...@denx.de Acked-by: Wolfgang Denk w...@denx.de --- Applied to net/next regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Pull request - net/next
Wolfgang, The following changes since commit 307ecb6db04eebdc06b8c87d48bf48d3cbd5e9d7: Eric Millbrandt (1): Add support for USB on PSC3 for the mpc5200 are available in the git repository at: git://git.denx.de/u-boot-net.git next Alessandro Rubini (4): net: defragment IP packets tftp: get the tftp block size from config file and from the environment nfs: accept CONFIG_NFS_READ_SIZE from config file arm nomadik: activate defrag choose 4k transfer block size Ben Warren (1): Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API Kim Phillips (1): net: tsec - handle user interrupt while waiting for PHY auto negotiation to complete Robin Getz (2): Add debug message for Blackfin Ethernet Rx function. Add Transfer Size Option to tftp board/altera/dk1c20/dk1c20.c | 12 ++ board/altera/dk1s10/dk1s10.c | 12 ++ board/armadillo/armadillo.c | 12 ++ board/csb226/csb226.c | 12 ++ board/ep7312/ep7312.c | 12 ++ board/freescale/mx31ads/mx31ads.c | 12 ++ board/impa7/impa7.c | 12 ++ board/lart/lart.c | 12 ++ board/mpl/vcma9/cmd_vcma9.c | 28 +++-- board/mpl/vcma9/vcma9.c | 12 ++ board/mx1ads/mx1ads.c | 12 ++ board/samsung/smdk2400/smdk2400.c | 12 ++ board/samsung/smdk2410/smdk2410.c | 12 ++ board/samsung/smdk6400/smdk6400.c | 12 ++ board/sbc2410x/sbc2410x.c | 12 ++ board/ssv/adnpesc1/adnpesc1.c | 12 ++ board/trab/trab.c | 12 ++ drivers/net/Makefile |2 +- drivers/net/bfin_mac.c|3 + drivers/net/cs8900.c | 276 ++--- drivers/net/cs8900.h | 41 --- drivers/net/tsec.c|7 + include/configs/ADNPESC1.h| 14 +- include/configs/DK1C20.h | 14 +- include/configs/DK1S10.h | 14 +- include/configs/VCMA9.h |7 +- include/configs/armadillo.h |9 +- include/configs/csb226.h |7 +- include/configs/ep7312.h |9 +- include/configs/impa7.h |7 +- include/configs/lart.h|7 +- include/configs/mx1ads.h |7 +- include/configs/mx31ads.h |7 +- include/configs/nhk8815.h |4 + include/configs/sbc2410x.h|7 +- include/configs/smdk2400.h|7 +- include/configs/smdk2410.h|7 +- include/configs/smdk6400.h|7 +- include/configs/trab.h|7 +- include/netdev.h |1 + lib_arm/board.c |9 -- net/net.c | 188 - net/nfs.h | 10 +- net/tftp.c| 51 +++- 44 files changed, 728 insertions(+), 221 deletions(-) regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] reloacting uboot
Dear E Robertson, In message 200908251428.55255.e.robertson@gmail.com you wrote: In message 200908251403.20809.e.robertson@gmail.com you wrote: I am using the at91sam9263 device from which the bootstrap code load u-boot to the desired ram address. However, I would like to re-relocate this at the different address based on memory availability. Can / or should this be done? Yes, it can be done, and it should be done. The fact that we don't do it so far is due to the fact that the guys who did the original ARM code found this too complicated (even though they had a working example in the PowerPC code) and not worth the effort. We're suffering since from this misconception. But there is no reason why you would have to copy the code again - just copy it to the correct address right from the beginning, like we do in PowerPC. I don't follow: Yes, but no reason to do so? You wrote: re-relocate. This is bogus. Just relocate it once, to the correct address. On the 9263, it's copied once to ram at boot. Are you saying their is no reason to copy it again? If so, yes, in most cases that would be true but I would like to move it again after that initial relocation. Since I've already specified my start address, I wasn't sure about. Fix the ARM relocating scheme such that it works like in PowerPC: link the image not for a RAM address, but for the address in flash. Then, after determining the RAM size, copy relocate the code once to RAM. Only one copy. Not two. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Old programmers never die, they just branch to a new address. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add debug message for Blackfin Ethernet Rx function.
Robin Getz wrote: Add a simple print for the Blackfin's Ethernet Rx function, so we can debug incomming Ethernet functions easier. Signed-off-by: Robin Getz rg...@blackfin.uclinux.org --- drivers/net/bfin_mac.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/net/bfin_mac.c b/drivers/net/bfin_mac.c index 12d98c2..ec45b63 100644 --- a/drivers/net/bfin_mac.c +++ b/drivers/net/bfin_mac.c @@ -186,6 +186,9 @@ static int bfin_EMAC_recv(struct eth_device *dev) printf(Ethernet: bad frame\n); break; } + + debug(%s: len = %d\n, __func__, length - 4); + NetRxPackets[rxIdx] = (volatile uchar *)(rxbuf[rxIdx]-FrmData-Dest); NetReceive(NetRxPackets[rxIdx], length - 4); Applied to net/next regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] RAM burst mode problem
Dear Mikhail Zaturenskiy,
In message 97dd5fd20908251235ic0e64eela7c75fb138143...@mail.gmail.com you
wrote:
static uint sdram_table[] = { /* Single read (offset 0x00 in UPM RAM) */
0x0F03C004, 0x0FFFC004, 0x00FCC004, 0x0FFFC000, 0x0FF30004, 0x0FFFC004,
0xC005, 0xC005, /* Burst read (offset 0x08 in UPM RAM) */
0x0F03C004, 0x0FFFC004, 0x00FCC004, 0x00FFC000, 0x00FFC000, 0x00FFC000,
0x00FFC000, 0x00FFC000, 0x00FFC000, 0x00FFC000, 0x0FF3, 0x0FFFC004,
0xC005, 0xC005, 0xC005, 0xC005, /* Single write (offset 0x18
in UPM RAM) */ 0x0F03C004, 0x0FFFC004, 0x00FC0004, 0x0FFFC002, 0x0FF30004,
0X0FFFC004, 0xC005, 0xC005, /* Burst write (offset 0x20 in UPM RAM)
*/ 0x0F03C004, 0x0FFFC004, 0x00FC0004, 0X00FFC000, 0x00FFC000, 0x00FFC000,
0x00FFC000, 0X00FFC000, 0x00FFC000, 0x00FFC000, 0x0FF30002, 0x0FFFC004,
0xC005, 0xC005, 0xC005, 0xC005, /* Refresh (offset 0x30 in
UPM RAM) */ 0x0FF0C004, 0x0FFFC004, 0x0FFFC004, 0x0FFFC004, 0xC005,
0x0FA30004, 0x0FFFC004, 0x0FF0C084, 0x0FFFC004, 0x0FFFC004, 0x0FFFC004,
0x0FFFC084, /* Exception (offset 0x3C in UPM RAM) */ 0x0FFFC004, 0x0FF4,
0x0FFFC004, 0xC005 };
Nice formatting.
And the following is my ram init function:
phys_size_t initdram (int board_type) { long int msize; volatile immap_t
*immap = (volatile immap_t *)CONFIG_SYS_IMMR; volatile memctl8xx_t *memctl =
immap-im_memctl; upmconfig(UPMA, sdram_table, sizeof(sdram_table) /
sizeof(uint)); /* Configure SDRAM refresh */ memctl-memc_mptpr =
MPTPR_PTP_DIV2; /* BRGCLK/2 */ memctl-memc_mamr = (65 24) |
CONFIG_SYS_MAMR; /* No refresh */ udelay(100); /* Run MRS pattern from
location 0x35 */ // MZ - was 0x36 memctl-memc_mar = 0x46; // MZ - was 0x88
memctl-memc_mcr = 0x80002235; // MZ - was 0x80002236 udelay(100);
memctl-memc_mamr |= MAMR_PTAE; /* Enable refresh */ memctl-memc_or1 =
~(CONFIG_SYS_SDRAM_MAX_SIZE - 1) | OR_CSNT_SAM; // memctl-memc_or1 =
~(CONFIG_SYS_SDRAM_MAX_SIZE - 1) | OR_CSNT_SAM | OR_BI; // MZ - temp, burst
inhibit memctl-memc_br1 = CONFIG_SYS_SDRAM_BASE | BR_PS_16 | BR_MS_UPMA |
BR_V; msize = get_ram_size(CONFIG_SYS_SDRAM_BASE,
CONFIG_SYS_SDRAM_MAX_SIZE); memctl-memc_or1 |= ~(msize - 1); return msize;
}
That's even better. Do you suppose anybody will bother to read any
code after you formatted it like this?
Note that this is the U-Boot mailing list, not the submission of
entries for the IOCCC.
Also attached is a spreadsheet which illustrates the RAM timing.
Is there something wrong with my RAM table? Am I missing any flags?
Something else wrong?
For one, your style of formatting and posting is terribly wrong.
Please see http://www.catb.org/~esr/faqs/smart-questions.html
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
Like winter snow on summer lawn, time past is time gone.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] reloacting uboot
Dear E Robertson, In message 200908251442.53461.e.robertson@gmail.com you wrote: By the way, my reason for doing this is that i want to maintain a proportional memory space available so if I increase the ram size I would like to relocate the boot loader without doing a separate build. Make sense? That's how it's supposed to be. On PowerPC, we will relocate U-Boot to the very end of available RAM. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de It's certainly convenient the way the crime (or condition) of stupidity carries with it its own punishment, automatically admisistered without remorse, pity, or prejudice. :-) -- Tom Christiansen in 559seq$ag...@csnews.cs.colorado.edu ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] include/s3c24x0.h: fix S3C24X0_SPI_CHANNEL declaration
In message 1251197076-20081-1-git-send-email...@denx.de I wrote: The SPI controller on the S3C24X0 has 8 bit registers, not 32 bit. Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD plagn...@jcrosoft.com Signed-off-by: Wolfgang Denk w...@denx.de --- include/s3c24x0.h | 22 ++ 1 files changed, 14 insertions(+), 8 deletions(-) Applied. Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The perversity of nature is nowhere better demonstrated by the fact that, when exposed to the same atmosphere, bread becomes hard while crackers become soft. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request u-boot-blackfin.git
Dear Mike Frysinger, In message 1251149433-30297-1-git-send-email-vap...@gentoo.org you wrote: The following changes since commit a794f59a75bf9fd4a44f1ad2349cae903c42b89c: Jean-Christophe PLAGNIOL-VILLARD (1): sh/rsk7203: add missing include net.h are available in the git repository at: git://www.denx.de/git/u-boot-blackfin.git master Harald Krapfenbauer (1): Blackfin: cm-bf527/cm-bf537: increase flash sectors Mike Frysinger (1): Blackfin: fix typos in gpio comments board/cm-bf527/gpio_cfi_flash.c |6 +++--- board/cm-bf537e/gpio_cfi_flash.c |6 +++--- board/tcm-bf537/gpio_cfi_flash.c |6 +++--- include/configs/cm-bf527.h |2 +- include/configs/cm-bf537e.h |2 +- 5 files changed, 11 insertions(+), 11 deletions(-) Applied, thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de The more we disagree, the more chance there is that at least one of us is right. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ppc4xx/master
Dear Stefan Roese, In message 200908251747.23905...@denx.de you wrote: Hi Wolfgang, please pull this fix into master. Thanks. The following changes since commit a794f59a75bf9fd4a44f1ad2349cae903c42b89c: Jean-Christophe PLAGNIOL-VILLARD (1): sh/rsk7203: add missing include net.h are available in the git repository at: git://www.denx.de/git/u-boot-ppc4xx.git master Feng Kan (1): ppc4xx: Fix ECC Correction bug with SMC ordering for NDFC driver drivers/mtd/nand/ndfc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. What about this patch: 08/21 Dirk Eibach [PATCH v2] ppc4xx: Rename compactcenter to intip Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Dear Lord: I just want *one* one-armed manager so I never have to hear On the other hand, again. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH][Net] Convert SMC91111 Ethernet driver to CONFIG_NET_MULTI API
Hi Robin, Robin Getz wrote: On Mon 27 Jul 2009 17:47, Ben Warren pondered: Ben Warren wrote: All in-tree boards that use this controller have CONFIG_NET_MULTI added Also: - changed CONFIG_DRIVER_SMC9 to CONFIG_SMC9 - cleaned up line lengths - modified all boards that override weak function in this driver - modified all eeprom standalone apps to work with new driver Signed-off-by: Ben Warren biggerbadder...@gmail.com This patch is pretty big (~98k) and should probably be split up in its final incarnation. This is really meant as a test patch. Since I don't have boards with this chip family, I'm unable to test for anything beyond clean compiling. I don't have a blackfin toolchain installed, but it does build cleanly on 'MAKEALL ARM9' using ELDK 4.1 for ARM. If anybody is able to test, please do and let me know the results. I have a few boards in the office - I'll try tomorrow. Did you ever get a chance to try this out? If it works for you, I'll send out v2 addressing some style stuff. regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] mpc8315 DDR2 controller
Dears, I am using u-boot 1.2.0 for mpc8315e processor with BDI2000 debugger in a new design based on MPC8315ERDB. Our board has a different DDR2 and Flash memory. The flash memory works fine. The problem could be DDR2. We are using Samsung K4T1G164QE DDR2 Memory. I can read/write DDR2 memory with BDI2000, but I have problems when u-boot try to write the first information in DDR2 memory (lib_ppc/board.c line 493 = *s-- = 0). After that, the program does not work. There is a breakpoint in this line. After the breakpoint accours, I do a step command and I receive this message from gdb: Program received signal SIGSTOP, Stopped (signal). 0x1200 in ?? () It could be a problem with DDR2 configuration registers? Thanks in advance, Marcos Cunha Electrical Enginner Instituto Atlântico www.atlantico.com.br ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add Transfer Size Option to tftp
Robin Getz wrote: Optionally add RFC 2349 Transfer Size Option, so we can minimize the time spent sending data over the UART (now print a single line during a tftp transfer). - If turned on (CONFIG_TFTP_TSIZE), U-Boot asks for the size of the file. - if receives the file size, a single line (50 chars) are printed. one hash mark == 2% of the file downloaded. - if it doesn't receive the file size (the server doesn't support RFC 2349, prints standard hash marks (one mark for each UDP frame). Signed-off-by: Robin Getz rg...@blackfin.uclinux.org --- net/tftp.c | 42 -- 1 files changed, 40 insertions(+), 2 deletions(-) Applied to net/next regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] net: tsec - handle user interrupt while waiting for PHY auto negotiation to complete
Kim Phillips wrote:
if you don't have firmware installed for the PHY to come to life, this
wait can be painful - let's give the option to avoid it if we want.
Signed-off-by: Kim Phillips kim.phill...@freescale.com
---
drivers/net/tsec.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/net/tsec.c b/drivers/net/tsec.c
index 9c9fd37..5c3d261 100644
--- a/drivers/net/tsec.c
+++ b/drivers/net/tsec.c
@@ -17,6 +17,7 @@
#include net.h
#include command.h
#include tsec.h
+#include asm/errno.h
#include miiphy.h
@@ -380,6 +381,12 @@ uint mii_parse_sr(uint mii_reg, struct tsec_private *
priv)
return 0;
}
+ if (ctrlc()) {
+ puts(user interrupt!\n);
+ priv-link = 0;
+ return -EINTR;
+ }
+
if ((i++ % 1000) == 0) {
putc('.');
}
Applied to net/next
regards,
Ben
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Pull request - net/next
Dear Ben Warren, In message 4a944bb0.9010...@gmail.com you wrote: Wolfgang, The following changes since commit 307ecb6db04eebdc06b8c87d48bf48d3cbd5e9d7: Eric Millbrandt (1): Add support for USB on PSC3 for the mpc5200 are available in the git repository at: git://git.denx.de/u-boot-net.git next Alessandro Rubini (4): net: defragment IP packets tftp: get the tftp block size from config file and from the environment nfs: accept CONFIG_NFS_READ_SIZE from config file arm nomadik: activate defrag choose 4k transfer block size Ben Warren (1): Convert CS8900 Ethernet driver to CONFIG_NET_MULTI API Kim Phillips (1): net: tsec - handle user interrupt while waiting for PHY auto negotiation to complete Robin Getz (2): Add debug message for Blackfin Ethernet Rx function. Add Transfer Size Option to tftp board/altera/dk1c20/dk1c20.c | 12 ++ board/altera/dk1s10/dk1s10.c | 12 ++ board/armadillo/armadillo.c | 12 ++ board/csb226/csb226.c | 12 ++ board/ep7312/ep7312.c | 12 ++ board/freescale/mx31ads/mx31ads.c | 12 ++ board/impa7/impa7.c | 12 ++ board/lart/lart.c | 12 ++ board/mpl/vcma9/cmd_vcma9.c | 28 +++-- board/mpl/vcma9/vcma9.c | 12 ++ board/mx1ads/mx1ads.c | 12 ++ board/samsung/smdk2400/smdk2400.c | 12 ++ board/samsung/smdk2410/smdk2410.c | 12 ++ board/samsung/smdk6400/smdk6400.c | 12 ++ board/sbc2410x/sbc2410x.c | 12 ++ board/ssv/adnpesc1/adnpesc1.c | 12 ++ board/trab/trab.c | 12 ++ drivers/net/Makefile |2 +- drivers/net/bfin_mac.c|3 + drivers/net/cs8900.c | 276 ++--- drivers/net/cs8900.h | 41 --- drivers/net/tsec.c|7 + include/configs/ADNPESC1.h| 14 +- include/configs/DK1C20.h | 14 +- include/configs/DK1S10.h | 14 +- include/configs/VCMA9.h |7 +- include/configs/armadillo.h |9 +- include/configs/csb226.h |7 +- include/configs/ep7312.h |9 +- include/configs/impa7.h |7 +- include/configs/lart.h|7 +- include/configs/mx1ads.h |7 +- include/configs/mx31ads.h |7 +- include/configs/nhk8815.h |4 + include/configs/sbc2410x.h|7 +- include/configs/smdk2400.h|7 +- include/configs/smdk2410.h|7 +- include/configs/smdk6400.h|7 +- include/configs/trab.h|7 +- include/netdev.h |1 + lib_arm/board.c |9 -- net/net.c | 188 - net/nfs.h | 10 +- net/tftp.c| 51 +++- 44 files changed, 728 insertions(+), 221 deletions(-) Applied to next. Thanks. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de A door is what a dog is perpetually on the wrong side of. - Ogden Nash ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Xilinx LL temac update
Hi Michal, mon...@monstr.eu wrote: Hi Ben, I updated LL-temac driver - all fixes are there. Ad to your point Microblaze uses only one ethernet core. It is possible to use a lot of IPs but I don't have board like this to test it that's why I don't want change it. If it's possible, somebody will do it. You don't need to have a board with more than one to test that it works, just create the data structures to encapsulate data that's specific to each instance, such as base address etc. Look at the new CS8900 driver or SMC911X for examples of how to do this. If you find any other problem please let me know. If is OK - I'll create net branch with these changes (LL_TEMAC/Emaclite + removing old Emac driver) You won't need to do that. I'll put it in the main net tree. Thanks, Michal regards, Ben ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] mpc8315 DDR2 controller
Dear Marcos Cunha, In message 4a944ee0.1000...@atlantico.com.br you wrote: I am using u-boot 1.2.0 for mpc8315e processor with BDI2000 debugger in a new design based on MPC8315ERDB. Our board has a different DDR2 and Flash memory. The flash memory works fine. The problem could be DDR2. U-Boot 1.2.0 is more than 2 years old. You really should not use such ancient stuff for a new design. You get the expected reply: please update, use current code and try again. If the problem still persists, please report back. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Some programming languages manage to absorb change, but withstand progress. -- Epigrams in Programming, ACM SIGPLAN Sept. 1982 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add ability for arch code to make changes before we boot
On Aug 15, 2009, at 9:24 AM, Jean-Christophe PLAGNIOL-VILLARD wrote:
On 15:45 Fri 14 Aug , Kumar Gala wrote:
On Aug 14, 2009, at 3:13 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
On 14:00 Fri 14 Aug , Kumar Gala wrote:
Added a arch_preboot() function that cpu specific code can
implement to
allow for various modifications to the state of the machine
right before
we boot. This can be useful to setup register state to a specific
configuration.
Signed-off-by: Kumar Gala ga...@kernel.crashing.org
---
common/cmd_bootm.c | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
index 86c8122..766889a 100644
--- a/common/cmd_bootm.c
+++ b/common/cmd_bootm.c
@@ -166,6 +166,13 @@ void __arch_lmb_reserve(struct lmb *lmb)
}
void arch_lmb_reserve(struct lmb *lmb) __attribute__((weak,
alias(__arch_lmb_reserve)));
+/* Allow for arch specific config before we boot */
+void __arch_preboot(void)
+{
+ /* please define platform specific arch_preboot() */
+}
+void arch_preboot(void) __attribute__((weak,
alias(__arch_preboot)));
+
why not a section so you will be able to have multiple callback so
it can be
arch or soc or board too in any combination
Because the use I have for it is a simple single case at this point.
If and when we need more complexity we can add it.
we have already it
as example the usb drivers that need to be stop before start an os
I forget some but I'm sure to have seen oher
We already handle USB in the bootm code. I don't see any reason to go
add a bunch of code for the one case we handle.
- k
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] Add ability for arch code to make changes before we boot
On Aug 14, 2009, at 2:00 PM, Kumar Gala wrote: Added a arch_preboot() function that cpu specific code can implement to allow for various modifications to the state of the machine right before we boot. This can be useful to setup register state to a specific configuration. Signed-off-by: Kumar Gala ga...@kernel.crashing.org --- common/cmd_bootm.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) Wolfgang, Can you look at either commenting on this or picking it up for 'next'. Its one patch the current '85xx next' tree depends on. - k ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-ppc4xx/master
Hi Wolfgang, On Tuesday 25 August 2009 22:53:54 Wolfgang Denk wrote: Feng Kan (1): ppc4xx: Fix ECC Correction bug with SMC ordering for NDFC driver drivers/mtd/nand/ndfc.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Applied, thanks. Thanks. What about this patch: 08/21 Dirk Eibach [PATCH v2] ppc4xx: Rename compactcenter to intip It's queued for the next merge window. I'll send a pull request soon. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: off...@denx.de ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
