Re: [U-Boot] [PATCH 0/5] ARM: sheevaplug: refresh for 201410
Hi Everybody,
Sorry for being inactive on the thread...
I will pull these patches and provide a pull request to albert soon...
Regards...
Prafulla . . .
> -Original Message-
> From: Nobuhiro Iwamatsu [mailto:iwama...@nigauri.org]
> Sent: 09 September 2014 12:08
> To: Albert ARIBAUD
> Cc: U-Boot; Prafulla Wadaskar; Pantelis Antoniou;
> Gerald Kerma; Tom Rini
> Subject: Re: [PATCH 0/5] ARM: sheevaplug: refresh for
> 201410
>
> Hi, Albert.
>
> These patches are not taken for a long time.
> If possible and Prafulla is OK, can you apply to u-
> boot-arm directly?
>
> Best regards,
> Nobuhiro
>
> 2014-09-08 1:01 GMT+09:00 Gerald Kerma
> :
> > This serie of patches add some needed features to
> sheevaplug
> >
> > Gerald Kerma (5):
> > ARM: sheevaplug: change env location
> > ARM: sheevaplug: add MVSATA driver
> > ARM: sheevaplug: add MTD defaults
> > ARM: sheevaplug: redefine MTDPARTS
> > ARM: sheevaplug: add HUSH parser
> >
> > include/configs/sheevaplug.h | 46
> +++-
> > 1 file changed, 41 insertions(+), 5 deletions(-)
> >
> > --
> > 1.9.1
> >
>
>
>
> --
> Nobuhiro Iwamatsu
>iwamatsu at {nigauri.org / debian.org}
>GPG ID: 40AD1FA6
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/7] ARM: sunxi: Add basic support for Allwinner A31 (sun6i)
Hi, On 09/08/2014 03:28 PM, Chen-Yu Tsai wrote: > Hi everyone, > > This series add basic support for Allwinner's A31 SoC. The patches, > excluding the first one, were cherry-picked from u-boot-sunxi. Due to > the difference between u-boot mainline and u-boot-sunxi, some patches > were rearranged or squashed to better fit the current state of u-boot, > and not introduce any build breaks. It follows Ian's initial merge > method of sun7i support: introducing various components first, then > enabling them in the last commit. I tried to keep the commits separate, > thus retaining the original author and Signed-off-bys. > > Patch 1 adds a wrapper around "func(USB, usb, 0)" in BOOT_TARGET_DEVICES > to deal with breakage when USB support is not enabled. > > Patch 2 adds memory addresses for some hardware blocks new in sun6i. > > Patch 3 adds support for the new PRCM (power reset and clock management) > block, which also contains PLL bias voltage control. > > Patch 4 adds support for the clock module. This patch is a bunch of > different sun6i related patches on the clock code, from when sun6i > support was introduced to u-boot-sunxi, up to its current form. > This is done to avoid various conflicts and needlessly introducing > then removing macros. > > Patch 5 adds mmc support on sun6i. > > Patch 6 adds uart0 muxing on sun6i. > > Patch 7 enables sun6i support and adds defconfig for the Colombus board. Chen, Many thanks for working on this! Just a quick not for people celebrating too early, this is the *incomplete* sun7i support from the linux-sunxi/u-boot-sunxi git repo. It is fine to merge this upstream, but this does not include SPL support. This allows replacing u-boot.bin on allwinnner sd-card images, which is very useful. But it does not get us all the way to booting sun7i devices we still need boot0 and boot1 binaries from allwinner for that (for now). Regards, Hans ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Spansion SPI flash read timeout with AM335x
Hello,
I am doing some work with the TI AM3358 Starter Kit and a Spansion S25FL164K
SPI NOR flash.
Trying both U-Boot 2013.10, which ships with the TI kit, and 2014.04 I have
made the changes to board configuration file to enable SPI0 and disable I2C1
in the board pin mux, have included Spansion flash support and have added
the following entry into the Spansion devices listed in sf_params.c
{"S25FL164K", 0x014017, 0x0140, 4 * 1024, 2048, RD_FULL,
SECT_4K},
Using the am335x_evm_spiboot configuration I have MLO and u-boot.img files
which I can program to the SPI flash successfully and also boot the board
from. I have a problem with read timeouts in the omap3_spi_read() function
in drivers/spi/omap3_spi.c trying to read the Linux kernel.
Having run some more tests (results below) it appears that with an "sf read"
command requesting more than about 0x16E000 bytes will fail. On occasion,
typically the first failed attempt, the status returns 0x0002 rather
than 0x0007.
U-Boot# sf read ${loadaddr} 0xE 0x10
SF: 1048576 bytes @ 0xe Read: OK
U-Boot# sf read ${loadaddr} 0xE 0x14
SF: 1310720 bytes @ 0xe Read: OK
U-Boot# sf read ${loadaddr} 0xE 0x15
SF: 1376256 bytes @ 0xe Read: OK
U-Boot# sf read ${loadaddr} 0xE 0x16
SF: 1441792 bytes @ 0xe Read: OK
U-Boot# sf read ${loadaddr} 0xE 0x17
omap3_spi_read SPI RXS timed out, status=0x0007
SF: 1507328 bytes @ 0xe Read: ERROR
U-Boot# sf read ${loadaddr} 0xE 0x168000
SF: 1474560 bytes @ 0xe Read: OK
U-Boot# sf read ${loadaddr} 0xE 0x16C000
SF: 1490944 bytes @ 0xe Read: OK
U-Boot# sf read ${loadaddr} 0xE 0x16E000
SF: 1499136 bytes @ 0xe Read: OK
U-Boot# sf read ${loadaddr} 0xE 0x16F000
omap3_spi_read SPI RXS timed out, status=0x0007
SF: 1503232 bytes @ 0xe Read: ERROR
Can anyone give me some guidance on how to resolve this?
Thanks,
Andy.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] Please pull u-boot-sunxi.git/master
Hi Ian, On Fri, 05 Sep 2014 14:23:01 +0100, Ian Campbell wrote: > (resend since I managed to forget the list in the CC, sorry about that) > > The following changes since commit d6c1ffc7d23f4fe4ae8c91101861055b8e1501b6: > > Prepare v2014.10-rc2 (2014-09-02 16:58:29 -0400) > > are available in the git repository at: > > git://git.denx.de/u-boot-sunxi.git > > for you to fetch changes up to b86d54b2c38a4beb97d580d7d9c8c6a5e57fc510: > > sun7i: Add support for Olimex A20-OLinuXino-LIME (2014-09-05 08:30:38 +0100) > > > FUKAUMI Naoki (1): > sun7i: Add support for Olimex A20-OLinuXino-LIME > > Ian Campbell (1): > sunxi: Correct typo CONFIG_FTDFILE => CONFIG_FDTFILE > > Masahiro Yamada (1): > kconfig: remove redundant "SPL" from CONFIG_SYS_EXTRA_OPTIONS > > board/sunxi/Kconfig | 4 ++-- > board/sunxi/MAINTAINERS | 6 ++ > board/sunxi/Makefile | 1 + > board/sunxi/dram_a20_olinuxino_l.c| 31 +++ > configs/A10-OLinuXino-Lime_defconfig | 4 ++-- > configs/A10s-OLinuXino-M_defconfig| 4 ++-- > configs/A13-OLinuXinoM_defconfig | 4 ++-- > configs/A13-OLinuXino_defconfig | 4 ++-- > configs/A20-OLinuXino-Lime_defconfig | 5 + > configs/A20-OLinuXino_MICRO_defconfig | 4 ++-- > configs/Auxtek-T004_defconfig | 4 ++-- > configs/Bananapi_defconfig| 4 ++-- > configs/Cubieboard2_FEL_defconfig | 2 +- > configs/Cubieboard2_defconfig | 4 ++-- > configs/Cubieboard_defconfig | 4 ++-- > configs/Cubietruck_FEL_defconfig | 2 +- > configs/Cubietruck_defconfig | 4 ++-- > configs/Linksprite_pcDuino3_defconfig | 4 ++-- > configs/Mele_A1000G_defconfig | 4 ++-- > configs/Mele_A1000_defconfig | 4 ++-- > configs/Mini-X-1Gb_defconfig | 4 ++-- > configs/Mini-X_defconfig | 4 ++-- > configs/ba10_tv_box_defconfig | 4 ++-- > configs/gwventana_defconfig | 2 +- > configs/i12-tvbox_defconfig | 4 ++-- > configs/qt840a_defconfig | 4 ++-- > configs/r7-tv-dongle_defconfig| 4 ++-- > include/configs/sunxi-common.h| 2 +- > 28 files changed, 87 insertions(+), 44 deletions(-) > create mode 100644 board/sunxi/dram_a20_olinuxino_l.c > create mode 100644 configs/A20-OLinuXino-Lime_defconfig > > Applied to u-boot-arm/master, thanks! (still having 5 errors and 2 warnings, so there is no regression) Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH RESEND] vf610twr: Tune DDR initialization settings
Hi Stefan, On Sat, 6 Sep 2014 19:47:06 +0200, Stefan Agner wrote: > From: Anthony Felice > > Removed settings in unsupported register fields. They didn’t > do anything, and in most cases, were not documented in the > reference manual. > > Changed register settings to comply with JEDEC required values. > > Changed timing parameters because they included full clock > periods that were doing nothing. > > Signed-off-by: Anthony Felice > [rebased on v2014.10-rc2] > Signed-off-by: Stefan Agner > --- > As discuessed in the initial patch set this fixes a lot of wrong/ > undocummented access and it would be nice to have in the next U-Boot > release. Verified the patchset after rebase again using memtester > on Vybrid Tower. > > arch/arm/include/asm/arch-vf610/imx-regs.h| 49 +++--- > arch/arm/include/asm/arch-vf610/iomux-vf610.h | 44 +++-- > arch/arm/include/asm/imx-common/iomux-v3.h| 2 + > board/freescale/vf610twr/vf610twr.c | 94 > +-- > 4 files changed, 127 insertions(+), 62 deletions(-) > > diff --git a/arch/arm/include/asm/arch-vf610/imx-regs.h > b/arch/arm/include/asm/arch-vf610/imx-regs.h > index bb00217..9d797db 100644 > --- a/arch/arm/include/asm/arch-vf610/imx-regs.h > +++ b/arch/arm/include/asm/arch-vf610/imx-regs.h > @@ -103,9 +103,11 @@ > /* DDRMC */ > #define DDRMC_PHY_DQ_TIMING 0x2613 > #define DDRMC_PHY_DQS_TIMING 0x2615 > -#define DDRMC_PHY_CTRL 0x01210080 > +#define DDRMC_PHY_CTRL 0x0021 > #define DDRMC_PHY_MASTER_CTRL0x0001012a > -#define DDRMC_PHY_SLAVE_CTRL 0x00012020 > +#define DDRMC_PHY_SLAVE_CTRL 0x2000 > +#define DDRMC_PHY_OFF0x > +#define DDRMC_PHY_PROC_PAD_ODT 0x00010101 > > #define DDRMC_PHY50_DDR3_MODE(1 << 12) > #define DDRMC_PHY50_EN_SW_HALF_CYCLE (1 << 8) > @@ -138,7 +140,7 @@ > #define DDRMC_CR21_CCMAP_EN 1 > #define DDRMC_CR22_TDAL(v) (((v) & 0x3f) << 16) > #define DDRMC_CR23_BSTLEN(v) (((v) & 0x7) << 24) > -#define DDRMC_CR23_TDLL(v) ((v) & 0xff) > +#define DDRMC_CR23_TDLL(v) ((v) & 0x) > #define DDRMC_CR24_TRP_AB(v) ((v) & 0x1f) > #define DDRMC_CR25_TREF_EN (1 << 16) > #define DDRMC_CR26_TREF(v) (((v) & 0x) << 16) > @@ -151,7 +153,7 @@ > #define DDRMC_CR33_EN_QK_SREF(1 << 16) > #define DDRMC_CR34_CKSRX(v) (((v) & 0xf) << 16) > #define DDRMC_CR34_CKSRE(v) (((v) & 0xf) << 8) > -#define DDRMC_CR38_FREQ_CHG_EN (1 << 8) > +#define DDRMC_CR38_FREQ_CHG_EN(v)(((v) & 0x1) << 8) > #define DDRMC_CR39_PHY_INI_COM(v)(((v) & 0x) << 16) > #define DDRMC_CR39_PHY_INI_STA(v)(((v) & 0xff) << 8) > #define DDRMC_CR39_FRQ_CH_DLLOFF(v) ((v) & 0x3) > @@ -163,7 +165,7 @@ > #define DDRMC_CR67_ZQCS(v) ((v) & 0xfff) > #define DDRMC_CR69_ZQ_ON_SREF_EX(v) (((v) & 0xf) << 8) > #define DDRMC_CR70_REF_PER_ZQ(v) (v) > -#define DDRMC_CR72_ZQCS_ROTATE (1 << 24) > +#define DDRMC_CR72_ZQCS_ROTATE(v)(((v) & 0x1) << 24) > #define DDRMC_CR73_APREBIT(v)(((v) & 0xf) << > 24) > #define DDRMC_CR73_COL_DIFF(v) (((v) & 0x7) << > 16) > #define DDRMC_CR73_ROW_DIFF(v) (((v) & 0x3) << > 8) > @@ -182,9 +184,10 @@ > #define DDRMC_CR77_CS_MAP(1 << 24) > #define DDRMC_CR77_DI_RD_INTLEAVE(1 << 8) > #define DDRMC_CR77_SWAP_EN 1 > +#define DDRMC_CR78_Q_FULLNESS(v) (((v) & 0x7) << 24) > #define DDRMC_CR78_BUR_ON_FLY_BIT(v) ((v) & 0xf) > -#define DDRMC_CR79_CTLUPD_AREF (1 << 24) > -#define DDRMC_CR82_INT_MASK 0x1fff > +#define DDRMC_CR79_CTLUPD_AREF(v)(((v) & 0x1) << 24) > +#define DDRMC_CR82_INT_MASK 0x1000 > #define DDRMC_CR87_ODT_WR_MAPCS0 (1 << 24) > #define DDRMC_CR87_ODT_RD_MAPCS0 (1 << 16) > #define DDRMC_CR88_TODTL_CMD(v) (((v) & 0x1f) > << 16) > @@ -192,9 +195,17 @@ > #define DDRMC_CR91_R2W_SMCSDL(v) (((v) & 0x7) << 16) > #define DDRMC_CR96_WLMRD(v) (((
Re: [U-Boot] Please pull u-boot-sunxi.git/master
On Tue, 2014-09-09 at 09:58 +0200, Albert ARIBAUD wrote: > Applied to u-boot-arm/master, thanks! Thank you. > (still having 5 errors and 2 warnings, so there is no regression) MAKEALL -s sunxi is only showing a single generic error for me (on every target): In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c: In function ‘get_symbol_str’: scripts/kconfig/menu.c:590:18: warning: ‘jump’ may be used uninitialized in this function [-Wmaybe-uninitialized] jump->offset = strlen(r->s); ^ In file included from scripts/kconfig/zconf.tab.c:2537:0: scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here struct jump_key *jump; ^ What are you seeing? Ian. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] dfu, usb: set usb descriptor to values defined in dfu spec 1.1
Hello Marek, Am 05.09.2014 00:42, schrieb Marek Vasut: On Thursday, September 04, 2014 at 12:21:40 PM, Heiko Schocher wrote: Hi Heiko, I'll just rant a bit, but please wait until Lukasz does a proper runthrough. set bDeviceClass, bDeviceSubClass and bcdUSB to the values defined in dfu spec 1.1 chapter 4.2.1 found here: http://www.usb.org/developers/devclass_docs/DFU_1.1.pdf This URL gives me a website with: " Resource not found. Please check the URL and try again. " Ah! Here the correct link: http://www.usb.org/developers/docs/devclass_docs/DFU_1.1.pdf I change this for v2. bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] generic board for socfpga
Hi Pavel, On Tue, 27 May 2014 14:50:30 +0200, Pavel Machek wrote: > > Socfpga u-boot works fine with CONFIG_SYS_GENERIC_BOARD, so enable > that option as documentation suggests. > > Signed-off-by: Pavel Machek > > diff --git a/include/configs/socfpga_cyclone5.h > b/include/configs/socfpga_cyclone5.h > index 2fc16ef..72d77f4 100644 > --- a/include/configs/socfpga_cyclone5.h > +++ b/include/configs/socfpga_cyclone5.h > @@ -16,6 +16,8 @@ > /* Virtual target or real hardware */ > #define CONFIG_SOCFPGA_VIRTUAL_TARGET > > +#define CONFIG_SYS_GENERIC_BOARD > + > #define CONFIG_ARMV7 > #define CONFIG_SYS_DCACHE_OFF > #undef CONFIG_USE_IRQ Sorry, I let this last too long before I reviewed it and now it does not apply cleanly at all. Can you have a look? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] relocation problem on powerpc
Chris Packham wrote on 2014/09/09 01:07:51:
> From: Chris Packham
> To: Joakim Tjernlund ,
> Cc: u-boot
> Date: 2014/09/09 01:08
> Subject: Re: [U-Boot] relocation problem on powerpc
>
> Hi Jocke,
>
> On Tue, Sep 9, 2014 at 12:22 AM, Joakim Tjernlund
> wrote:
> >>
> >> >
> >> > There are some disadvantages to living in a weird timezone, mostly
> >> > that you end up having conversations with yourself.
> >> >
> >> > On Mon, Sep 8, 2014 at 4:32 PM, Chris Packham
> >
> >> wrote:
> >> > > Hi All,
> >> > >
> >> > > I have come across what I think is a relocation problem for
powerpc.
> >> > >
> >> > > I've added the following to ArpTimeoutCheck
> >> > >
> >> > > + printf("NetArpWaitTimerStart = %ld\n",
> > NetArpWaitTimerStart);
> >> > > + printf("&NetArpWaitTimerStart = %p\n",
> > &NetArpWaitTimerStart);
> >> > > + printf("NetArpWaitTry = %d\n", NetArpWaitTry);
> >> > > + printf("&NetArpWaitTry = %p\n", &NetArpWaitTry);
> >> > > + printf("NetArpWaitTxPacketSize = %d\n",
> >> NetArpWaitTxPacketSize);
> >> > > + printf("&NetArpWaitTxPacketSize = %p\n",
> >> &NetArpWaitTxPacketSize);
> >> > >
> >> > > Which yields the following output
> >> > >
> >> > > NetArpWaitTimerStart = 0
> >> > > &NetArpWaitTimerStart = f0d0
> >> > > NetArpWaitTry = 1
> >> > > &NetArpWaitTry = 7ffb0058
> >> > > NetArpWaitTxPacketSize = 42
> >> > > &NetArpWaitTxPacketSize = 7ffb0078
> >> > >
> >> > > That looks to me like NetArpWaitTimerStart hasn't been relocated
for
> >> > > some reason. Looking at my u-boot.map NetArpWaitTimerStart is the
> > last
> >> > > item in the .sbss section
> >> > >
> >> > > Here's the relevant snippets for the variables I'm displaying
> >> > >
> >> > > 0xf058NetArpWaitTry
> >> > > 0xf078NetArpWaitTxPacketSize
> >> > > 0xf0d0NetArpWaitTimerStart
> >> > >
> >> > > The actual problem for me is that ARPs timeout and various
network
> >> > > things fail. Has anyone got any clues as to why this one
particular
> >> > > variable isn't getting relocated.
> >> > >
> >> > > Thanks,
> >> > > Chris
> >> > >
> >> > > More info:
> >> > > I'm building P2041RDB_config
> >> > >
> >> > > $ git describe
> >> > > v2014.10-rc2-15-g2ec8915
> >> > >
> >> > > => version
> >> > > U-Boot 2014.10-rc2-00015-g2ec8915-dirty (Sep 08 2014 -
16:18:42)
> >> > > powerpc-e500-linux-gnu-gcc (Gentoo 4.6.3-r1 p1.9, pie-0.5.2)
4.6.3
> >> > > GNU ld (GNU Binutils) 2.21
> >> >
> >> > I'm not confident enough to say it's a fix but the following seems
to
> >> > solve the relocation problem for NetArpWaitTimerStart.
> >> >
> >> > diff --git a/arch/powerpc/cpu/mpc85xx/u-boot.lds
> >> > b/arch/powerpc/cpu/mpc85xx/u-boot.lds
> >> > index 2cf0b25..36711b0 100644
> >> > --- a/arch/powerpc/cpu/mpc85xx/u-boot.lds
> >> > +++ b/arch/powerpc/cpu/mpc85xx/u-boot.lds
> >> > @@ -54,7 +54,7 @@ SECTIONS
> >> > _FIXUP_TABLE_ = .;
> >> > KEEP(*(.fixup))
> >> >}
> >> > - __got2_entries = ((_GLOBAL_OFFSET_TABLE_ - _GOT2_TABLE_) >> 2) -
1;
> >> > + __got2_entries = ((_GLOBAL_OFFSET_TABLE_ - _GOT2_TABLE_) >> 2);
> >> >__fixup_entries = (. - _FIXUP_TABLE_) >> 2;
> >>
> >> This looks like the correct fix, The relevant code that uses
> >> __got2_entries is in start.S:
> >>
> >> in_ram:
> >>
> >> /*
> >> * Relocation Function, r12 point to got2+0x8000
> >> *
> >> * Adjust got2 pointers, no need to check for 0, this code
> >> * already puts a few entries in the table.
> >> */
> >> li r0,__got2_entries@sectoff@l
> >> la r3,GOT(_GOT2_TABLE_)
> >> lwz r11,GOT(_GOT2_TABLE_)
> >> mtctr r0
> >> sub r11,r3,r11
> >> addir3,r3,-4
> >> 1: lwzur0,4(r3)
> >> cmpwi r0,0
> >> beq-2f
> >> add r0,r0,r11
> >> stw r0,0(r3)
> >> 2: bdnz1b
> >>
> >> bdnz does decrement then test for zero so __got2_entries should hold
the
> >
> >> number of entries to relocate.
> >>
> >> Seems like most(all?) ppc cpu has this error.
> >
> > Looking at u-boot.lds:
> > .reloc :
> > {
> > _GOT2_TABLE_ = .;
> > KEEP(*(.got2))
> > KEEP(*(.got))
> > PROVIDE(_GLOBAL_OFFSET_TABLE_ = . + 4);
> > _FIXUP_TABLE_ = .;
> > KEEP(*(.fixup))
> > }
> > __got2_entries = ((_GLOBAL_OFFSET_TABLE_ - _GOT2_TABLE_) >> 2) - 1;
> > __fixup_entries = (. - _FIXUP_TABLE_) >> 2;
> >
> >
> > There is something more to this error. Since _GLOBAL_OFFSET_TABLE_ is
> > defined to
> > _GLOBAL_OFFSET_TABLE_ = . + 4
> > there is one extra entry added( for brlr insn inserted by the linker)
so
> > something is
> > amiss here, is there a brlr insns at _GLOBAL_OFFSET_TABLE_-4 in your
> > u-boot?
> >
> > Jocke
> >
>
> Here's some more info from a build without any of my modifications.
>
> $ git describe
> v2014.10-rc2-12-g0b703db
>
> $ powerpc-e500
Re: [U-Boot] [PATCH 7/8] samsung: Move s5p_goni to use exynos-common config
Hello Simon,
On 07/23/2014 02:11 PM, Simon Glass wrote:
Change this board to use the exynos common config and add a device tree.
This also adds a pinmux header file - but it is just a copy of the exynos
one so may be incorrect.
Signed-off-by: Simon Glass
---
arch/arm/dts/Makefile | 1 +
arch/arm/dts/s5pc1xx-goni.dts | 21 ++
arch/arm/include/asm/arch-s5pc1xx/periph.h | 61 ++
arch/arm/include/asm/arch-s5pc1xx/pinmux.h | 50
drivers/mmc/s5p_sdhci.c| 2 -
include/configs/s5p_goni.h | 55 +--
6 files changed, 143 insertions(+), 47 deletions(-)
create mode 100644 arch/arm/dts/s5pc1xx-goni.dts
create mode 100644 arch/arm/include/asm/arch-s5pc1xx/periph.h
create mode 100644 arch/arm/include/asm/arch-s5pc1xx/pinmux.h
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 3b760ff..6a6e664 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -1,3 +1,4 @@
+dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
dtb-$(CONFIG_EXYNOS4) += exynos4210-origen.dtb \
exynos4210-smdkv310.dtb \
exynos4210-universal_c210.dtb \
diff --git a/arch/arm/dts/s5pc1xx-goni.dts b/arch/arm/dts/s5pc1xx-goni.dts
new file mode 100644
index 000..c390c8f
--- /dev/null
+++ b/arch/arm/dts/s5pc1xx-goni.dts
@@ -0,0 +1,21 @@
+/*
+ * Samsung's Exynos4210-based SMDKV310 board device tree source
+ *
+ * Copyright (c) 2014 Google, Inc
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+/dts-v1/;
This is a mistake. Exynos4 is different than s5pc1xx(which was later
called exynos3 and is also called s5pv210(kernel)).
So the s5pc1xx-goni.dts should include:
model = "Samsung Goni based on S5PC110";
compatible = "samsung,goni", "samsung,s5pc110";
And the base addresses are different than exynos4. Please look at:
arch/arm/include/asm/arch-s5pc1xx/cpu.h
This will require also a common file for s5pc1xx: s5pc1xx-common.dts.
Moreover, the S5PC100 and S5PC110 have lot of differences.
Simon, I think that this is a job for goni's maintainer, since you can't
test it on a hardware.
Robert, can you look at this?
+/include/ "exynos4.dtsi"
+
+/ {
+ model = "Samsung SMDKV310 on Exynos4210";
+ compatible = "samsung,smdkv310", "samsung,exynos4210";
+
+ aliases {
+ serial0 = "/serial@1380";
+ console = "/serial@1382";
+ };
+
+};
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marc...@samsung.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 8/8] samsung: Move smdkc100 to use exynos-common config
Hello Simon,
On 07/23/2014 02:11 PM, Simon Glass wrote:
Change this board to use the exynos common config and add a device tree.
Signed-off-by: Simon Glass
---
arch/arm/dts/Makefile | 1 +
arch/arm/dts/s5pc1xx-smdkc100.dts | 21 +++
include/configs/smdkc100.h| 57 +--
3 files changed, 35 insertions(+), 44 deletions(-)
create mode 100644 arch/arm/dts/s5pc1xx-smdkc100.dts
diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
index 6a6e664..ed67844 100644
--- a/arch/arm/dts/Makefile
+++ b/arch/arm/dts/Makefile
@@ -1,3 +1,4 @@
+dtb-$(CONFIG_S5PC100) += s5pc1xx-smdkc100.dtb
dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
dtb-$(CONFIG_EXYNOS4) += exynos4210-origen.dtb \
exynos4210-smdkv310.dtb \
diff --git a/arch/arm/dts/s5pc1xx-smdkc100.dts
b/arch/arm/dts/s5pc1xx-smdkc100.dts
new file mode 100644
index 000..409812d
--- /dev/null
+++ b/arch/arm/dts/s5pc1xx-smdkc100.dts
@@ -0,0 +1,21 @@
+/*
+ * Samsung's Exynos4210-based SMDKV310 board device tree source
+ *
+ * Copyright (c) 2014 Google, Inc
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+/dts-v1/;
The same as in s5pc110:
+/include/ "exynos4.dtsi"
+
+/ {
+ model = "Samsung SMDKC100";
+ compatible = "samsung,smdkc100";
+
+ aliases {
Bad base addresses:
+ serial0 = "/serial@1380";
+ console = "/serial@1382";
+ };
+
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marc...@samsung.com
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/8] samsung: Use common config files with Samsung boards (help wanted)
Hi, I will test this patch set on a trats2 board - today evening. On 09/09/2014 08:05 AM, Simon Glass wrote: Hi Minkyu, On 25 July 2014 08:43, Simon Glass wrote: Hi Lucasz, On 24 July 2014 09:34, Lukasz Majewski wrote: Hi Simon, This series tries to unify the Samsung board configs into a few header files for exynos5 and exynos5. The purpose is to make it easier to move to driver model. In that case I would like things like the GPIO drivers and serial drivers to work in a standard way, and not need to support device tree and platform data at the same time. That would be quite painful. Another reason is that the Chrome OS EC drivers are currently included in boards that don't have a Chrome OS EC. This concern was raised by the Samsung maintainer (Minkyu) a while back. There are still a few boards that don't use CONFIG_OF_CONTROL so I have updated these with the most rudimentary of device tree files. Unfortunately I don't have boards for most of these (for testing) and I am hoping that the maintainers can come to the rescue and fix up any patches that have problems. I am also worried that I have used a common exynos file for things like smdkv310, when in fact they have some other chip in common. So maintainers, please can you test this and re-issue the patch, or make comments on my attempts? We will do our best to test our Exynos4 based boards. Thanks - please feel free to re-issue the patches and I will drop mine (if you cc me). Can you please review this series? We are already at rc2. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marc...@samsung.com ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCHv2] generic board for socfpga
Socfpga u-boot works fine with CONFIG_SYS_GENERIC_BOARD, so enable that option as documentation suggests. Signed-off-by: Pavel Machek --- > Sorry, I let this last too long before I reviewed it and now it does > not apply cleanly at all. Can you have a look? Here you go. diff --git a/include/configs/socfpga_cyclone5.h b/include/configs/socfpga_cyclone5.h index 5d145cd..d3d1e48 100644 --- a/include/configs/socfpga_cyclone5.h +++ b/include/configs/socfpga_cyclone5.h @@ -11,6 +11,8 @@ #include "../../board/altera/socfpga/iocsr_config.h" #include "../../board/altera/socfpga/pll_config.h" +#define CONFIG_SYS_GENERIC_BOARD + /* * High level configuration */ -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] VxWorks Booting using U-boot as Bootloader
Thanks Again, which u-boot version are you referring, because I am using 2013.04 version and in this there is no directory named board/BuR/KWB. can you please send the Boot Arguments which you used to boot the vxworks and which method are you using to boot vxworks? On Mon, Sep 8, 2014 at 10:16 PM, Hannes Petermaier wrote: > Hi Ashish, > > okay - i am using vxworks 6.9.3.3, and there is is a issue around the > interrupt vectors. In later versions 6.9.4 upwards windriver takes care > about this and sets up the interruptvectors. > U-Boot does sets them to some address within u-boot code, but vxWorks > expects that the interrupt vector are at the place where they are after > poweron-reset. > > In my case (using AM3352 from TI) i've set the interrupt vectors back to > original state (have a look to my KWB-Board, board/BuR/kwb/board.c). > > BTW: i am using a stripped image which i directly start with "go > ", but that shouldn't matter. > > best regards, > Hannes > > > > On 2014-09-09 03:56, Ashish Khetan wrote: > >> Hi Hannes >> Thanks for your reply. I am using VxWorks 6.7 and the image is not >> stripped. The loadaddress is also same within kernel configuration. I am >> using bootvx command to boot VxWorks. Do I need to update boot >> parameters? >> On Sep 8, 2014 4:11 PM, "Hannes Petermaier" < >> hannes.peterma...@br-automation.com> wrote: >> >> Hi Ashish, >>> >>> i had a problem booting vxworks in the past around interrupt vectors. >>> Which version of vxworks you are using ? do you use a stripped image ? >>> is the loadaddress the same within kernel configuration ? >>> >>> best regards, >>> hannes >>> >>> From: Ashish Khetan To: u-boot@lists.denx.de Date: 04.09.2014 14:13 Subject: [U-Boot] VxWorks Booting using U-boot as Bootloader Sent by: u-boot-boun...@lists.denx.de Hi, I was trying to boot vxworks using u-boot bootloader for learning >>> purpose >>> on MPC8640DHPCN board. Previously I successfully ported QNX os along >>> with >>> linux on same board using u-boot. while booting using bootvx command its not booting and stucking after showing the following message: tftp 0100 vxWorks Speed: 1000, full duplex Using eTSEC1 device TFTP from server 192.168.10.2; our IP address is 192.168.10.4 Filename 'vxWorks'. Load address: 0x100 Loading: >>> * # >>> # # 12.3 MiB/s done Bytes transferred = 2392432 (248170 hex) BOSSv2.0=> bootvx 0010 100 ## Ethernet MAC address not copied to NV RAM ## Using bootline (@ 0x4200): root=/dev/nfs rw nfsroot=192.168.10.2:/opt/eldk-5.3/powerpc/rootfs-basic ip=192.168.10.4:192.168.10.2:192.168.10.1:255.255.255.0:Boss:eth0:off panic=1 console=ttyS0,115200 ## Starting vxWorks at 0x0010 ... please somebody provide me some link or any pointer to help me get more understanding about booting multiple os using uboot. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot >>> >>> >> > ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] arch/arm: Add individual TLB size support.
Hi Xiubo, On Mon, 7 Jul 2014 13:19:11 +0800, Xiubo Li wrote: > This adds CONFIG_TLB_SIZE for individual board, whose TLB size maybe > larger than PGTABLE_SIZE. > > Signed-off-by: Xiubo Li > --- > arch/arm/lib/board.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/lib/board.c b/arch/arm/lib/board.c > index dc34190..b7327ce 100644 > --- a/arch/arm/lib/board.c > +++ b/arch/arm/lib/board.c > @@ -353,7 +353,11 @@ void board_init_f(ulong bootflag) > > #if !(defined(CONFIG_SYS_ICACHE_OFF) && defined(CONFIG_SYS_DCACHE_OFF)) > /* reserve TLB table */ > +#ifdef CONFIG_TLB_SIZE > + gd->arch.tlb_size = CONFIG_TLB_SIZE; > +#else > gd->arch.tlb_size = PGTABLE_SIZE; > +#endif > addr -= gd->arch.tlb_size; > > /* round down to next 64 kB limit */ There is no code in current mainline which defines CONFIG_TLB_SIZE; that makes the patch a dead code addition. Besides, what's the point of this as opposed to, e.g., just defining the right PGTABLE_SIZE, or renaming PGTABLE_SIZE as CONFIG_TLB_SIZE? Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] watchdog disable for socfpga
This adds watchdog disable. It is neccessary for running Linux kernel.
Signed-off-by: Pavel Machek
diff --git a/arch/arm/cpu/armv7/socfpga/reset_manager.c
b/arch/arm/cpu/armv7/socfpga/reset_manager.c
index e320c01..5503059 100644
--- a/arch/arm/cpu/armv7/socfpga/reset_manager.c
+++ b/arch/arm/cpu/armv7/socfpga/reset_manager.c
@@ -14,6 +14,19 @@ DECLARE_GLOBAL_DATA_PTR;
static const struct socfpga_reset_manager *reset_manager_base =
(void *)SOCFPGA_RSTMGR_ADDRESS;
+#define RSTMGR_PERMODRST_L4WD0_LSB 6
+
+/* Disable the watchdog (toggle reset to watchdog) */
+void watchdog_disable(void)
+{
+ /* assert reset for watchdog */
+ setbits_le32(&reset_manager_base->per_mod_reset,
+(1
[U-Boot] [PATCH] base addresses for more subsystems
Add base addresses for more subsystems. Signed-off-by: Pavel Machek diff --git a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h index 2d3152d..39a7874 100644 --- a/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h +++ b/arch/arm/include/asm/arch-socfpga/socfpga_base_addrs.h @@ -7,9 +7,15 @@ #ifndef _SOCFPGA_BASE_ADDRS_H_ #define _SOCFPGA_BASE_ADDRS_H_ +#define SOCFPGA_EMAC0_ADDRESS 0xff70 +#define SOCFPGA_EMAC1_ADDRESS 0xff702000 +#define SOCFPGA_SDMMC_ADDRESS 0xff704000 +#define SOCFPGA_FPGAMGRREGS_ADDRESS 0xff706000 #define SOCFPGA_L3REGS_ADDRESS 0xff80 +#define SOCFPGA_FPGAMGRDATA_ADDRESS 0xffb9 #define SOCFPGA_UART0_ADDRESS 0xffc02000 #define SOCFPGA_UART1_ADDRESS 0xffc03000 +#define SOCFPGA_SDR_ADDRESS 0xffc2 #define SOCFPGA_OSC1TIMER0_ADDRESS 0xffd0 #define SOCFPGA_L4WD0_ADDRESS 0xffd02000 #define SOCFPGA_CLKMGR_ADDRESS 0xffd04000 -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] fix compilation of socfpga_dw_mmc
Fix compilation of socfpga_dw_mmc.
Signed-off-by: Pavel Machek
diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
index 1f96382..d8da7f5 100644
--- a/drivers/mmc/socfpga_dw_mmc.c
+++ b/drivers/mmc/socfpga_dw_mmc.c
@@ -16,6 +16,8 @@ static const struct socfpga_clock_manager *clock_manager_base
=
static const struct socfpga_system_manager *system_manager_base =
(void *)SOCFPGA_SYSMGR_ADDRESS;
+#define CLKMGR_PERPLLGRP_EN_SDMMCCLK_MASK (1 << 8)
+
static void socfpga_dwmci_clksel(struct dwmci_host *host)
{
unsigned int drvsel;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] cleanup drivers/net/phy/micrel.c
Old saying says that more than three exclamation marks in a row are
sign of mental disease. Cleanup micrel.c.
Signed-off-by: Pavel Machek
diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 5d7e3be..06a31b0 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -25,8 +25,7 @@ static struct phy_driver KSZ804_driver = {
#ifndef CONFIG_PHY_MICREL_KSZ9021
/*
* I can't believe Micrel used the exact same part number
- * for the KSZ9021
- * Shame Micrel, Shame!
+ * for the KSZ9021. Shame Micrel, Shame!
*/
static struct phy_driver KS8721_driver = {
.name = "Micrel KS8721BL",
@@ -40,7 +39,7 @@ static struct phy_driver KS8721_driver = {
#endif
-/**
+/*
* KSZ9021 - KSZ9031 common
*/
@@ -69,8 +68,8 @@ static int ksz90xx_startup(struct phy_device *phydev)
phydev->speed = SPEED_10;
return 0;
}
-#ifdef CONFIG_PHY_MICREL_KSZ9021
+#ifdef CONFIG_PHY_MICREL_KSZ9021
/*
* KSZ9021
*/
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] fix compilation of socfpga_dw_mmc
On Tuesday, September 09, 2014 at 02:08:13 PM, Pavel Machek wrote:
> Fix compilation of socfpga_dw_mmc.
>
> Signed-off-by: Pavel Machek
>
> diff --git a/drivers/mmc/socfpga_dw_mmc.c b/drivers/mmc/socfpga_dw_mmc.c
> index 1f96382..d8da7f5 100644
> --- a/drivers/mmc/socfpga_dw_mmc.c
> +++ b/drivers/mmc/socfpga_dw_mmc.c
> @@ -16,6 +16,8 @@ static const struct socfpga_clock_manager
> *clock_manager_base = static const struct socfpga_system_manager
> *system_manager_base = (void *)SOCFPGA_SYSMGR_ADDRESS;
>
> +#define CLKMGR_PERPLLGRP_EN_SDMMCCLK_MASK (1 << 8)
> +
> static void socfpga_dwmci_clksel(struct dwmci_host *host)
> {
> unsigned int drvsel;
This macro should go into arch/arm/include/asm/arch-socfpga/clock_manager.h
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] dfu, usb: set usb descriptor to values defined in dfu spec 1.1
On Tuesday, September 09, 2014 at 10:45:57 AM, Heiko Schocher wrote: > Hello Marek, > > Am 05.09.2014 00:42, schrieb Marek Vasut: > > On Thursday, September 04, 2014 at 12:21:40 PM, Heiko Schocher wrote: > > > > Hi Heiko, > > > > I'll just rant a bit, but please wait until Lukasz does a proper > > runthrough. > > > >> set bDeviceClass, bDeviceSubClass and bcdUSB to the values > >> defined in dfu spec 1.1 chapter 4.2.1 found here: > >> > >> http://www.usb.org/developers/devclass_docs/DFU_1.1.pdf > > > > This URL gives me a website with: > > " > > Resource not found. > > Please check the URL and try again. > > " > > Ah! Here the correct link: > > http://www.usb.org/developers/docs/devclass_docs/DFU_1.1.pdf > > I change this for v2. Cool, thank you! :) Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] watchdog disable for socfpga
On Tuesday, September 09, 2014 at 02:03:28 PM, Pavel Machek wrote:
> This adds watchdog disable. It is neccessary for running Linux kernel.
Why do we not enable WDT in Linux instead ? Also, I recall there was a call to
explicitly enable the L4 watchdog, so why do we not get rid of that instead ?
> Signed-off-by: Pavel Machek
>
> diff --git a/arch/arm/cpu/armv7/socfpga/reset_manager.c
> b/arch/arm/cpu/armv7/socfpga/reset_manager.c index e320c01..5503059 100644
> --- a/arch/arm/cpu/armv7/socfpga/reset_manager.c
> +++ b/arch/arm/cpu/armv7/socfpga/reset_manager.c
> @@ -14,6 +14,19 @@ DECLARE_GLOBAL_DATA_PTR;
> static const struct socfpga_reset_manager *reset_manager_base =
> (void *)SOCFPGA_RSTMGR_ADDRESS;
>
> +#define RSTMGR_PERMODRST_L4WD0_LSB 6
> +
> +/* Disable the watchdog (toggle reset to watchdog) */
> +void watchdog_disable(void)
> +{
> + /* assert reset for watchdog */
> + setbits_le32(&reset_manager_base->per_mod_reset,
> + (1< + /* deassert watchdog from reset (watchdog in not running state) */
> + clrbits_le32(&reset_manager_base->per_mod_reset,
> + (1< +}
> +
> /*
> * Write the reset manager register to cause reset
> */
> diff --git a/arch/arm/include/asm/arch-socfpga/reset_manager.h
> b/arch/arm/include/asm/arch-socfpga/reset_manager.h index 3e95476..eb95c5b
> 100644
> --- a/arch/arm/include/asm/arch-socfpga/reset_manager.h
> +++ b/arch/arm/include/asm/arch-socfpga/reset_manager.h
> @@ -10,6 +10,8 @@
> void reset_cpu(ulong addr);
> void reset_deassert_peripherals_handoff(void);
>
> +void watchdog_disable(void);
> +
> struct socfpga_reset_manager {
> u32 status;
> u32 ctrl;
Best regards,
Marek Vasut
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] watchdog disable for socfpga
On Tue 2014-09-09 14:20:23, Marek Vasut wrote: > On Tuesday, September 09, 2014 at 02:03:28 PM, Pavel Machek wrote: > > This adds watchdog disable. It is neccessary for running Linux kernel. > > Why do we not enable WDT in Linux instead ? Also, I recall there was a call > to > explicitly enable the L4 watchdog, so why do we not get rid of that > instead ? Booting linux kernel without watchdog support should be valid operation. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] relocation problem on powerpc
> > Here's some more info from a build without any of my modifications. > > > > $ git describe > > v2014.10-rc2-12-g0b703db > > > > $ powerpc-e500-linux-gnu-gcc --version > > powerpc-e500-linux-gnu-gcc (Gentoo 4.6.3-r1 p1.9, pie-0.5.2) 4.6.3 > > > > $ grep '_GOT2_TABLE_\|_GLOBAL_OFFSET_TABLE_\|__got2_entries' u-boot.map > > 0xeffb5100_GOT2_TABLE_ = . > > 0xeffb7d38_GLOBAL_OFFSET_TABLE_ > > 0xeffb7d48PROVIDE (_GLOBAL_OFFSET_TABLE_, (. + 0x4)) > > 0x0b0d__got2_entries = > > (((_GLOBAL_OFFSET_TABLE_ - _GOT2_TABLE_) >> 0x2) - 0x1) > > > > $ gdb-multiarch u-boot > > (gdb) disassemble /r 0xeffb5100,0xeffb7d48 > > Dump of assembler code from 0xeffb5100 to 0xeffb7d48: > > 0xeffb5100 <_GOT2_TABLE_+0>: ef fb 51 00 .long 0xeffb5100 > > 0xeffb5104 <_GOT2_TABLE_+4>: ef fb 7d 44 dtstsf cr7,f27,f15 > > 0xeffb5108 <_GOT2_TABLE_+8>: ef f4 00 00 .long 0xeff4 > > 0xeffb510c <_GOT2_TABLE_+12>:ef f4 01 00 .long 0xeff40100 > > > > 0xeffb7d30 <_GOT2_TABLE_+11312>: ef f6 6e 74 .long 0xeff66e74 > > 0xeffb7d34 <_GOT2_TABLE_+11316>: f0 00 00 d0 psq_st f0,208(r0),0,0 > > 0xeffb7d38 <_GLOBAL_OFFSET_TABLE_+0>:00 00 00 00 .long 0x0 > > 0xeffb7d3c <_GLOBAL_OFFSET_TABLE_+4>:00 00 00 00 .long 0x0 > > 0xeffb7d40 <_GLOBAL_OFFSET_TABLE_+8>:00 00 00 00 .long 0x0 > > 0xeffb7d44 <_FIXUP_TABLE_+0>:ef fb 99 d4 .long 0xeffb99d4 > > > > So no there is no brlr at the end of the table. > > There should be, see http://www.freescale.com/files/32bit/doc/ref_manual/E500ABIUG.pdf, chap 4.3.2 So I did a quick test too with my copy of u-boot: (gdb) disass /r 0xeffa0a48,0xeffa0a68 Dump of assembler code from 0xeffa0a48 to 0xeffa0a68: 0xeffa0a48 <_GOT2_TABLE_+9800>: f0 00 00 dc .long 0xf0dc 0xeffa0a4c <_GOT2_TABLE_+9804>: ef f6 29 48 .long 0xeff62948 0xeffa0a50 <_GOT2_TABLE_+9808>: f0 00 00 e0 .long 0xf0e0 0xeffa0a54 <_GOT2_TABLE_+9812>: 4e 80 00 21 blrl ^ 0xeffa0a58 <_GLOBAL_OFFSET_TABLE_+0>:00 00 00 00 .long 0x0 0xeffa0a5c <_GLOBAL_OFFSET_TABLE_+4>:00 00 00 00 .long 0x0 0xeffa0a60 <_GLOBAL_OFFSET_TABLE_+8>:00 00 00 00 .long 0x0 0xeffa0a64 <_FIXUP_TABLE_+0>:ef fa 23 1c .long 0xeffa231c $ powerpc-softfloat_4.5.3-linux-gnu-ld --version GNU ld (GNU Binutils) 2.21.1 I don't know it this is tool(ld) problem or if something in u-boot's build env. Try dropping --gc-sections, see if that changes anything, or add --bss-plt or similar ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] watchdog disable for socfpga
On Tuesday, September 09, 2014 at 02:30:01 PM, Pavel Machek wrote: > On Tue 2014-09-09 14:20:23, Marek Vasut wrote: > > On Tuesday, September 09, 2014 at 02:03:28 PM, Pavel Machek wrote: > > > This adds watchdog disable. It is neccessary for running Linux kernel. > > > > Why do we not enable WDT in Linux instead ? Also, I recall there was a > > call to explicitly enable the L4 watchdog, so why do we not get rid of > > that instead ? > > Booting linux kernel without watchdog support should be valid > operation. If you watchdog is enabled, then not so much. Also, why can we not just disable the WDT in U-Boot instead using a config option ? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: nitrogen6x: Replace 'fatload' by 'load' command in env settings to be filesystem independent
Ping.
Guillaume
Le 01/09/2014 20:27, Eric Nelson a écrit :
Hi all,
On 08/31/2014 07:24 PM, Fabio Estevam wrote:
On Tue, Aug 26, 2014 at 7:05 AM, Guillaume GARDET
wrote:
nitrogen6x.h file defines CONFIG_CMD_FS_GENERIC, so we are able to use generic
'load' command instead of 'fatload'. It allows to use ext filesystem and keep
compatibilty with fat filesystem.
Signed-off-by: Guillaume GARDET
Cc: Stefano Babic
Adding Eric Nelson on Cc.
Thanks Fabio. I stopped delivery from the list while on vacation and
hadn't re-started it.
---
include/configs/nitrogen6x.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/configs/nitrogen6x.h b/include/configs/nitrogen6x.h
index b2b17ce..d4b0ac9 100644
--- a/include/configs/nitrogen6x.h
+++ b/include/configs/nitrogen6x.h
@@ -192,11 +192,11 @@
I've been wondering if anyone was using this section of nitrogen6x.h,
and I guess this answers the question.
"mmcargs=setenv bootargs console=${console},${baudrate} " \
"root=${mmcroot}\0" \
"loadbootscript=" \
- "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
+ "load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
"bootscript=echo Running bootscript from mmc ...; " \
"source\0" \
- "loaduimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
- "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
+ "loaduimage=load mmc ${mmcdev}:${mmcpart} ${loadaddr} ${uimage}\0" \
+ "loadfdt=load mmc ${mmcdev}:${mmcpart} ${fdt_addr} ${fdt_file}\0" \
"mmcboot=echo Booting from mmc ...; " \
"run mmcargs; " \
"if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
--
1.8.4.5
I don't have a copy of the original e-mail, but:
Acked-By: Eric Nelson
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v1 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only
This patchserie adds the new config option CONFIG_DFU_FULLSPEED. If this is enabled DFU uses fullspeed only. This is used on the siemens boards. Cc: Tom Rini Cc: Lukasz Majewski Cc: Marek Vasut Cc: Liu Bin Cc: Lukas Stockmann Heiko Schocher (2): usb: dfu: add config option to use in dfu mode fullspeed only arm: am335x: siemens board use in DFU mode fullspeed only README | 3 +++ drivers/usb/gadget/f_dfu.c | 3 +++ drivers/usb/gadget/g_dnl.c | 3 +++ include/configs/siemens-am33x-common.h | 3 ++- 4 files changed, 11 insertions(+), 1 deletion(-) -- 1.8.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v1 2/2] arm: am335x: siemens board use in DFU mode fullspeed only
Siemens boards are now using DFU in fullspeed only. Signed-off-by: Heiko Schocher Cc: Tom Rini Cc: Lukasz Majewski Cc: Marek Vasut Cc: Liu Bin Cc: Lukas Stockmann --- include/configs/siemens-am33x-common.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/configs/siemens-am33x-common.h b/include/configs/siemens-am33x-common.h index b8fb77e..6fa5ddf 100644 --- a/include/configs/siemens-am33x-common.h +++ b/include/configs/siemens-am33x-common.h @@ -233,7 +233,7 @@ #define CONFIG_MUSB_GADGET #define CONFIG_MUSB_PIO_ONLY #define CONFIG_MUSB_DISABLE_BULK_COMBINE_SPLIT -#define CONFIG_USB_GADGET_DUALSPEED +#undef CONFIG_USB_GADGET_DUALSPEED #define CONFIG_USB_GADGET_VBUS_DRAW2 #define CONFIG_MUSB_HOST @@ -267,6 +267,7 @@ #define CONFIG_CMD_DFU #define CONFIG_SYS_DFU_DATA_BUF_SIZE (1 << 20) #define DFU_MANIFEST_POLL_TIMEOUT 25000 +#define CONFIG_DFU_FULLSPEED #endif /* CONFIG_SPL_BUILD */ -- 1.8.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v1 1/2] usb: dfu: add config option to use in dfu mode fullspeed only
add the new config option CONFIG_DFU_FULLSPEED. With this
option enabled, DFU uses fullspeed only.
Signed-off-by: Heiko Schocher
Cc: Tom Rini
Cc: Lukasz Majewski
Cc: Marek Vasut
Cc: Liu Bin
Cc: Lukas Stockmann
---
README | 3 +++
drivers/usb/gadget/f_dfu.c | 3 +++
drivers/usb/gadget/g_dnl.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/README b/README
index 0a0f528..1413392 100644
--- a/README
+++ b/README
@@ -1607,6 +1607,9 @@ The following options need to be configured:
entering dfuMANIFEST state. Host waits this timeout, before
sending again an USB request to the device.
+ CONFIG_DFU_FULLSPEED
+ use for the dfu functionality fullspeed only.
+
- USB Device Android Fastboot support:
CONFIG_CMD_FASTBOOT
This enables the command "fastboot" which enables the Android
diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index 1145aab..dfa9f3b 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = dfu_strings;
f_dfu->usb_function.hs_descriptors = f_dfu->function;
+ f_dfu->usb_function.descriptors = f_dfu->function;
f_dfu->dfu_state = DFU_STATE_dfuIDLE;
}
@@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = NULL;
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
}
static int handle_upload(struct usb_request *req, u16 len)
@@ -809,6 +811,7 @@ static int dfu_bind_config(struct usb_configuration *c)
return -ENOMEM;
f_dfu->usb_function.name = "dfu";
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
f_dfu->usb_function.bind = dfu_bind;
f_dfu->usb_function.unbind = dfu_unbind;
f_dfu->usb_function.set_alt = dfu_set_alt;
diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
index 58cad11..79e0c9c 100644
--- a/drivers/usb/gadget/g_dnl.c
+++ b/drivers/usb/gadget/g_dnl.c
@@ -143,6 +143,9 @@ static int g_dnl_config_register(struct usb_composite_dev
*cdev)
config->bConfigurationValue = CONFIGURATION_NUMBER;
config->iConfiguration = STRING_USBDOWN;
config->bind = g_dnl_do_config;
+#if defined(CONFIG_DFU_FULLSPEED)
+ config->fullspeed = 1;
+#endif
return usb_add_config(cdev, config);
}
--
1.8.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: nitrogen6x: Replace 'fatload' by 'load' command in env settings to be filesystem independent
Hi Guillaume, On 09/09/2014 14:31, Guillaume Gardet wrote: > Ping. Sorry, I was not in office in the last two weeks. I will go through all i.MX patches (it seems I have something to do..) and I will apply the ones are ready, as yours. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] watchdog disable for socfpga
On Tue 2014-09-09 14:31:46, Marek Vasut wrote: > On Tuesday, September 09, 2014 at 02:30:01 PM, Pavel Machek wrote: > > On Tue 2014-09-09 14:20:23, Marek Vasut wrote: > > > On Tuesday, September 09, 2014 at 02:03:28 PM, Pavel Machek wrote: > > > > This adds watchdog disable. It is neccessary for running Linux kernel. > > > > > > Why do we not enable WDT in Linux instead ? Also, I recall there was a > > > call to explicitly enable the L4 watchdog, so why do we not get rid of > > > that instead ? > > > > Booting linux kernel without watchdog support should be valid > > operation. > > If you watchdog is enabled, then not so much. Also, why can we not just > disable > the WDT in U-Boot instead using a config option ? It seems that watchdog is enabled by default (by hardware or SPL), so yes, watchdog disable operation (and this patch) in u-boot is a good idea. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox
Hi Fabio, On 09/09/2014 01:52, Fabio Estevam wrote: > Hi Tom, > > On Sat, Aug 30, 2014 at 4:21 PM, Tom Rini wrote: >> On Sat, Aug 30, 2014 at 02:22:22PM -0300, Fabio Estevam wrote: >>> Tom, Joe or Stefano, >>> >>> On Mon, Aug 25, 2014 at 4:51 PM, Marek Vasut wrote: On Monday, August 25, 2014 at 06:34:16 PM, Fabio Estevam wrote: > mx6solox has a requirement for 64 bytes alignment for RX DMA transfer. > Other SoCs work with the standard 32 bytes alignment. > > Adjust it accordingly by using 64 bytes aligment in the FEC RX DMA > buffers, > which addresses the needs from mx6solox and also works for the other SoCs. > > Signed-off-by: Fabio Estevam Acked-by: Marek Vasut >>> >>> Could this one be applied for 2014.10-rc? >> >> I'd like this via the imx tree. > > Unfortunately, I am not getting any response from Stefano for quite some time. > Sorry, I was not in office in last two weeks. > Can you apply this series as we are already in rc2 now? Applied to u-boot-imx, thanks ! Fabio, I will try to dig in all patches that queue in last two weeks. If you can, please take a look next week what is still missing and send me a remind - thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 2/2] net: fec_mxc: Poll FEC_TBD_READY after polling TDAR
On 25/08/2014 18:34, Fabio Estevam wrote: > When testing the FEC driver on a mx6solox we noticed that the TDAR bit gets > always cleared prior then the READY bit is cleared in the last BD, which > causes > FEC packets reception to always fail. > > As explained by Ye Li: > > "The TDAR bit is cleared when the descriptors are all out from TX ring, but > on > mx6solox we noticed that the READY bit is still not cleared right after TDAR. > These are two distinct signals, and in IC simulation, we found that TDAR > always > gets cleared prior than the READY bit of last BD becomes cleared. > In mx6solox, we use a later version of FEC IP. It looks like that this > intrinsic behaviour of TDAR bit has changed in this newer FEC version." > > Fix this by polling the READY bit of BD after the TDAR polling, which covers > the > mx6solox case and does not harm the other SoCs. > > No performance drop has been noticed with this patch applied when testing TFTP > transfers on several boards of different i.mx SoCs. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: ventana: base SPL MMDC calibration on width and size not board
On 21/08/2014 08:31, Tim Harvey wrote: > The IMX6 MMDC calibration registers depend on propagation delay and capacitive > loading between the SoC's MMDC and the DDR3 chips. On the Ventana boards the > board layout varies little in trace-lengths such that propagation delays are > irrelevant thus we can simply things by using calibration values obtained > from various board layouts based on a common SoC and DDR chip configuration. > > This eliminates board-model from being needed allowing more flexibility. These > values were tested on a large sample size of Gateworks Ventana boards ranging > in layout, and memory configuration over the entire temperature range > supported. > > Signed-off-by: Tim Harvey > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: ventana: add GW5520 support
On 21/08/2014 08:35, Tim Harvey wrote: > The GW5520 has an IMX6Q SoC with 512MB of DDR3, 256MB of NAND flash as well > as: > * 2x MiniPCIe sockets > * 2x USB host sockets > * 2x i210 GigE > * HDMI out > * digital I/O expansion > > Signed-off-by: Tim Harvey > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: ventana: updated notes regarding NAND boot errata
On 21/08/2014 08:30, Tim Harvey wrote: > Signed-off-by: Tim Harvey > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] sort drivers/mmc/Makefile
Sort drivers/mmc makefile, as requested by wd. Signed-off-by: Pavel Machek diff --git a/drivers/mmc/Makefile b/drivers/mmc/Makefile index 464cee1..461d7d8 100644 --- a/drivers/mmc/Makefile +++ b/drivers/mmc/Makefile @@ -5,37 +5,39 @@ # SPDX-License-Identifier: GPL-2.0+ # +obj-$(CONFIG_ARM_PL180_MMCI) += arm_pl180_mmci.o +obj-$(CONFIG_BCM2835_SDHCI) += bcm2835_sdhci.o obj-$(CONFIG_BFIN_SDH) += bfin_sdh.o obj-$(CONFIG_DAVINCI_MMC) += davinci_mmc.o +obj-$(CONFIG_DWMMC) += dw_mmc.o +obj-$(CONFIG_EXYNOS_DWMMC) += exynos_dw_mmc.o obj-$(CONFIG_FSL_ESDHC) += fsl_esdhc.o obj-$(CONFIG_FTSDC010) += ftsdc010_mci.o obj-$(CONFIG_FTSDC021) += ftsdc021_sdhci.o obj-$(CONFIG_GENERIC_MMC) += mmc.o obj-$(CONFIG_GENERIC_ATMEL_MCI) += gen_atmel_mci.o +obj-$(CONFIG_KONA_SDHCI) += kona_sdhci.o obj-$(CONFIG_MMC_SPI) += mmc_spi.o -obj-$(CONFIG_ARM_PL180_MMCI) += arm_pl180_mmci.o +obj-$(CONFIG_MMC_SUNXI) += sunxi_mmc.o obj-$(CONFIG_MV_SDHCI) += mv_sdhci.o +obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o obj-$(CONFIG_MXC_MMC) += mxcmmc.o obj-$(CONFIG_MXS_MMC) += mxsmmc.o obj-$(CONFIG_OMAP_HSMMC) += omap_hsmmc.o obj-$(CONFIG_PXA_MMC_GENERIC) += pxa_mmc_gen.o -obj-$(CONFIG_SDHCI) += sdhci.o -obj-$(CONFIG_BCM2835_SDHCI) += bcm2835_sdhci.o -obj-$(CONFIG_KONA_SDHCI) += kona_sdhci.o +obj-$(CONFIG_SUPPORT_EMMC_RPMB) += rpmb.o obj-$(CONFIG_S3C_SDI) += s3c_sdi.o obj-$(CONFIG_S5P_SDHCI) += s5p_sdhci.o +obj-$(CONFIG_SDHCI) += sdhci.o obj-$(CONFIG_SH_MMCIF) += sh_mmcif.o +obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o obj-$(CONFIG_SPEAR_SDHCI) += spear_sdhci.o obj-$(CONFIG_TEGRA_MMC) += tegra_mmc.o -obj-$(CONFIG_DWMMC) += dw_mmc.o -obj-$(CONFIG_EXYNOS_DWMMC) += exynos_dw_mmc.o -obj-$(CONFIG_MMC_SUNXI) += sunxi_mmc.o obj-$(CONFIG_ZYNQ_SDHCI) += zynq_sdhci.o -obj-$(CONFIG_SOCFPGA_DWMMC) += socfpga_dw_mmc.o -obj-$(CONFIG_SUPPORT_EMMC_RPMB) += rpmb.o + ifdef CONFIG_SPL_BUILD obj-$(CONFIG_SPL_MMC_BOOT) += fsl_esdhc_spl.o else obj-$(CONFIG_GENERIC_MMC) += mmc_write.o endif -obj-$(CONFIG_MVEBU_MMC) += mvebu_mmc.o + -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 02/11] imx: ventana: added cputype env var
On 08/08/2014 07:35, Tim Harvey wrote: > There are many similarities between the IMX6QUAD/IMX6DUAL and there are > many similarities between the IMX6SOLO/IMX6DUALITE. Add a 'soctype' env > variable that tells you which type you have. > > Signed-off-by: Tim Harvey > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] cleanup disk/part.c whitespace
Cleanup disk/part.c
Signed-off-by: Pavel Machek
diff --git a/disk/part.c b/disk/part.c
index ecc5e7e..cfd77b0 100644
--- a/disk/part.c
+++ b/disk/part.c
@@ -133,7 +133,7 @@ typedef lbaint_t lba512_t;
* Overflowless variant of (block_count * mul_by / div_by)
* when div_by > mul_by
*/
-static lba512_t lba512_muldiv (lba512_t block_count, lba512_t mul_by, lba512_t
div_by)
+static lba512_t lba512_muldiv(lba512_t block_count, lba512_t mul_by, lba512_t
div_by)
{
lba512_t bc_quot, bc_rem;
@@ -215,7 +215,8 @@ void dev_print (block_dev_desc_t *dev_desc)
lba512 = (lba * (dev_desc->blksz/512));
/* round to 1 digit */
- mb = lba512_muldiv(lba512, 10, 2048); /* 2048 = (1024 * 1024)
/ 512 MB */
+ /* 2048 = (1024 * 1024) / 512 MB */
+ mb = lba512_muldiv(lba512, 10, 2048);
mb_quot = mb / 10;
mb_rem = mb - (10 * mb_quot);
@@ -248,7 +249,7 @@ void dev_print (block_dev_desc_t *dev_desc)
#ifdef HAVE_BLOCK_DEVICE
-void init_part (block_dev_desc_t * dev_desc)
+void init_part(block_dev_desc_t *dev_desc)
{
#ifdef CONFIG_ISO_PARTITION
if (test_part_iso(dev_desc) == 0) {
@@ -295,7 +296,7 @@ void init_part (block_dev_desc_t * dev_desc)
defined(CONFIG_AMIGA_PARTITION) || \
defined(CONFIG_EFI_PARTITION)
-static void print_part_header (const char *type, block_dev_desc_t * dev_desc)
+static void print_part_header(const char *type, block_dev_desc_t *dev_desc)
{
puts ("\nPartition Map for ");
switch (dev_desc->if_type) {
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] relocation problem on powerpc
Joakim Tjernlund/Transmode wrote on 2014/09/09 14:30:13: > From: Joakim Tjernlund/Transmode > To: > Cc: Chris Packham , u-boot > Date: 2014/09/09 14:30 > Subject: Re: [U-Boot] relocation problem on powerpc > > > > > Here's some more info from a build without any of my modifications. > > > > > > $ git describe > > > v2014.10-rc2-12-g0b703db > > > > > > $ powerpc-e500-linux-gnu-gcc --version > > > powerpc-e500-linux-gnu-gcc (Gentoo 4.6.3-r1 p1.9, pie-0.5.2) 4.6.3 > > > > > > $ grep '_GOT2_TABLE_\|_GLOBAL_OFFSET_TABLE_\|__got2_entries' u-boot.map > > > 0xeffb5100_GOT2_TABLE_ = . > > > 0xeffb7d38_GLOBAL_OFFSET_TABLE_ > > > 0xeffb7d48PROVIDE (_GLOBAL_OFFSET_TABLE_, (. + 0x4)) > > > 0x0b0d__got2_entries = > > > (((_GLOBAL_OFFSET_TABLE_ - _GOT2_TABLE_) >> 0x2) - 0x1) > > > > > > $ gdb-multiarch u-boot > > > (gdb) disassemble /r 0xeffb5100,0xeffb7d48 > > > Dump of assembler code from 0xeffb5100 to 0xeffb7d48: > > > 0xeffb5100 <_GOT2_TABLE_+0>: ef fb 51 00 .long 0xeffb5100 > > > 0xeffb5104 <_GOT2_TABLE_+4>: ef fb 7d 44 dtstsf cr7,f27,f15 > > > 0xeffb5108 <_GOT2_TABLE_+8>: ef f4 00 00 .long 0xeff4 > > > 0xeffb510c <_GOT2_TABLE_+12>:ef f4 01 00 .long 0xeff40100 > > > > > > 0xeffb7d30 <_GOT2_TABLE_+11312>: ef f6 6e 74 .long 0xeff66e74 > > > 0xeffb7d34 <_GOT2_TABLE_+11316>: f0 00 00 d0 psq_st f0,208(r0),0,0 > > > 0xeffb7d38 <_GLOBAL_OFFSET_TABLE_+0>:00 00 00 00 .long 0x0 > > > 0xeffb7d3c <_GLOBAL_OFFSET_TABLE_+4>:00 00 00 00 .long 0x0 > > > 0xeffb7d40 <_GLOBAL_OFFSET_TABLE_+8>:00 00 00 00 .long 0x0 > > > 0xeffb7d44 <_FIXUP_TABLE_+0>:ef fb 99 d4 .long 0xeffb99d4 > > > > > > So no there is no brlr at the end of the table. > > > > There should be, see http://www.freescale.com/files/32bit/doc/ref_manual/E500ABIUG.pdf, chap 4.3.2 > > So I did a quick test too with my copy of u-boot: > (gdb) disass /r 0xeffa0a48,0xeffa0a68 >Dump of assembler code from 0xeffa0a48 to 0xeffa0a68: >0xeffa0a48 <_GOT2_TABLE_+9800>: f0 00 00 dc .long 0xf0dc >0xeffa0a4c <_GOT2_TABLE_+9804>: ef f6 29 48 .long 0xeff62948 >0xeffa0a50 <_GOT2_TABLE_+9808>: f0 00 00 e0 .long 0xf0e0 >0xeffa0a54 <_GOT2_TABLE_+9812>: 4e 80 00 21 blrl > ^ >0xeffa0a58 <_GLOBAL_OFFSET_TABLE_+0>: 00 00 00 00 .long 0x0 >0xeffa0a5c <_GLOBAL_OFFSET_TABLE_+4>: 00 00 00 00 .long 0x0 >0xeffa0a60 <_GLOBAL_OFFSET_TABLE_+8>: 00 00 00 00 .long 0x0 >0xeffa0a64 <_FIXUP_TABLE_+0>: ef fa 23 1c .long 0xeffa231c > $ powerpc-softfloat_4.5.3-linux-gnu-ld --version > GNU ld (GNU Binutils) 2.21.1 > > I don't know it this is tool(ld) problem or if something in u-boot's build env. Try dropping > --gc-sections, see if that changes anything, or add --bss-plt or similar --bss-plt seems to be the answer: http://lists.denx.de/pipermail/u-boot/2014-February/173134.html Jocke ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 1/2] net: fec_mxc: Adjust RX DMA alignment for mx6solox
Hi Stefano, On Tue, Sep 9, 2014 at 10:09 AM, Stefano Babic wrote: > Fabio, I will try to dig in all patches that queue in last two weeks. If > you can, please take a look next week what is still missing and send me > a remind - thanks ! Excellent, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only
Hi Heiko, > This patchserie adds the new config option CONFIG_DFU_FULLSPEED. Is there any special reason to support Full Speed (12 Mbit/sec - USB 1.1) and not rely solely on the High Speed (USB 2.0) as we do now? > If this is enabled DFU uses fullspeed only. This is used on the > siemens boards. Is there any DFU problem with the mentioned Siemens board, that we must use USB 1.1? I'd also appreciate more verbose rationale for this patch series - why this change is needed? What is the expected improvement? Thanks in advance. > > Cc: Tom Rini > Cc: Lukasz Majewski > Cc: Marek Vasut > Cc: Liu Bin > Cc: Lukas Stockmann > > Heiko Schocher (2): > usb: dfu: add config option to use in dfu mode fullspeed only > arm: am335x: siemens board use in DFU mode fullspeed only > > README | 3 +++ > drivers/usb/gadget/f_dfu.c | 3 +++ > drivers/usb/gadget/g_dnl.c | 3 +++ > include/configs/siemens-am33x-common.h | 3 ++- > 4 files changed, 11 insertions(+), 1 deletion(-) > -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V4 00/19] Introduce cm-fx6 board
Hi Nikita, On 31/08/2014 10:09, Nikita Kiryanov wrote: > Hi Tom, Stefano, > > We really want this series to make it into the next release (V1 was > submitted only a day after the merge window closed). If there are no > other comments, can we maybe start applying it? > Patch 1/19, 4/19 and 5/19 were already applied by Jagan - I do not merge them into u-boot-imx. I applied 2/19 after rebasing on current u-boot-imx. I have nothing against the helper introduced in 3/19, but this touch more boards - I will make a short check before applying it. However, it is orthogonal and can be applied later. I applied as well 6/19 through 19/19 into u-boot-imx - thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only
Lukasz, On 09/09/2014 08:43 AM, Lukasz Majewski wrote: Hi Heiko, This patchserie adds the new config option CONFIG_DFU_FULLSPEED. Is there any special reason to support Full Speed (12 Mbit/sec - USB 1.1) and not rely solely on the High Speed (USB 2.0) as we do now? The drivers must support full-speed anyway based on the USB2.0 Specs. I have seen many cases in which only full-speed is suitable due to either board design or specific USB use case. One example is that to better fit to the production firmware flashing automation, a board does not use standard USB receptacle or plug, but a four touch pads on the PCB, so that the robot can grab the board and touch the pads to download the firmware. In this case signal integrity is a concern, but not download speed. Regards, -Bin. If this is enabled DFU uses fullspeed only. This is used on the siemens boards. Is there any DFU problem with the mentioned Siemens board, that we must use USB 1.1? I'd also appreciate more verbose rationale for this patch series - why this change is needed? What is the expected improvement? Thanks in advance. Cc: Tom Rini Cc: Lukasz Majewski Cc: Marek Vasut Cc: Liu Bin Cc: Lukas Stockmann Heiko Schocher (2): usb: dfu: add config option to use in dfu mode fullspeed only arm: am335x: siemens board use in DFU mode fullspeed only README | 3 +++ drivers/usb/gadget/f_dfu.c | 3 +++ drivers/usb/gadget/g_dnl.c | 3 +++ include/configs/siemens-am33x-common.h | 3 ++- 4 files changed, 11 insertions(+), 1 deletion(-) ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/2] usb: dfu: add config option to use in dfu mode fullspeed only
Heiko,
On 09/09/2014 07:37 AM, Heiko Schocher wrote:
add the new config option CONFIG_DFU_FULLSPEED. With this
option enabled, DFU uses fullspeed only.
Can we not introduce the new config option but check the gadget driver
speed in runtime as what the ether gadget driver does?
I don't want two config options (CONFIG_USB_GADGET_DUALSPEED and
CONFIG_DFU_FULLSPEED) to control one feature, as in your patch 2/2.
Regards,
-Bin.
Signed-off-by: Heiko Schocher
Cc: Tom Rini
Cc: Lukasz Majewski
Cc: Marek Vasut
Cc: Liu Bin
Cc: Lukas Stockmann
---
README | 3 +++
drivers/usb/gadget/f_dfu.c | 3 +++
drivers/usb/gadget/g_dnl.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/README b/README
index 0a0f528..1413392 100644
--- a/README
+++ b/README
@@ -1607,6 +1607,9 @@ The following options need to be configured:
entering dfuMANIFEST state. Host waits this timeout, before
sending again an USB request to the device.
+ CONFIG_DFU_FULLSPEED
+ use for the dfu functionality fullspeed only.
+
- USB Device Android Fastboot support:
CONFIG_CMD_FASTBOOT
This enables the command "fastboot" which enables the Android
diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index 1145aab..dfa9f3b 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = dfu_strings;
f_dfu->usb_function.hs_descriptors = f_dfu->function;
+ f_dfu->usb_function.descriptors = f_dfu->function;
f_dfu->dfu_state = DFU_STATE_dfuIDLE;
}
@@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = NULL;
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
}
static int handle_upload(struct usb_request *req, u16 len)
@@ -809,6 +811,7 @@ static int dfu_bind_config(struct usb_configuration *c)
return -ENOMEM;
f_dfu->usb_function.name = "dfu";
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
f_dfu->usb_function.bind = dfu_bind;
f_dfu->usb_function.unbind = dfu_unbind;
f_dfu->usb_function.set_alt = dfu_set_alt;
diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
index 58cad11..79e0c9c 100644
--- a/drivers/usb/gadget/g_dnl.c
+++ b/drivers/usb/gadget/g_dnl.c
@@ -143,6 +143,9 @@ static int g_dnl_config_register(struct usb_composite_dev
*cdev)
config->bConfigurationValue = CONFIGURATION_NUMBER;
config->iConfiguration = STRING_USBDOWN;
config->bind = g_dnl_do_config;
+#if defined(CONFIG_DFU_FULLSPEED)
+ config->fullspeed = 1;
+#endif
return usb_add_config(cdev, config);
}
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] watchdog disable for socfpga
On Tuesday, September 09, 2014 at 03:09:48 PM, Pavel Machek wrote: > On Tue 2014-09-09 14:31:46, Marek Vasut wrote: > > On Tuesday, September 09, 2014 at 02:30:01 PM, Pavel Machek wrote: > > > On Tue 2014-09-09 14:20:23, Marek Vasut wrote: > > > > On Tuesday, September 09, 2014 at 02:03:28 PM, Pavel Machek wrote: > > > > > This adds watchdog disable. It is neccessary for running Linux > > > > > kernel. > > > > > > > > Why do we not enable WDT in Linux instead ? Also, I recall there was > > > > a call to explicitly enable the L4 watchdog, so why do we not get > > > > rid of that instead ? > > > > > > Booting linux kernel without watchdog support should be valid > > > operation. > > > > If you watchdog is enabled, then not so much. Also, why can we not just > > disable the WDT in U-Boot instead using a config option ? > > It seems that watchdog is enabled by default (by hardware or SPL), so > yes, watchdog disable operation (and this patch) in u-boot is a good > idea. OK. Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 0/2] imx: ventana: Add pci fixup for PLX switch
On 21/08/2014 08:37, Tim Harvey wrote: > On Thu, Aug 7, 2014 at 10:49 PM, Tim Harvey wrote: >> Many of the Gateworks Ventana boards have a PLX PCIe switch where GPIO >> on the switch is used as the PERST# of the downstream ports. In the Linux >> kernel there is a PCI fixup that asserts these properly when the upstream >> port is enumerated. >> >> The first patch in this serial adds a board_pci_fixup_dev function define >> to allow hooking similarly to the kernel pci fixup functionality. >> >> The second patch uses the board_pci_fixup_dev function to perform the >> GPIO configuration on the switch for the downstream ports. >> >> Tim Harvey (2): >> pci: add support for board_pci_fixup_dev function >> imx: ventana: add pci fixup for PLX PEX860x switch GPIO >> >> board/gateworks/gw_ventana/gw_ventana.c | 30 ++ >> drivers/pci/pci.c | 4 >> include/configs/gw_ventana.h| 1 + >> include/pci.h | 7 +++ >> 4 files changed, 42 insertions(+) >> >> -- >> 1.8.3.2 >> > > Any comments on these? I'm wondering if there is someone else I should > be including with regards to reviewing pci changes. > No comment, and I do not see any bad influence on other boards - I am going to apply them. Regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] pci: add support for board_pci_fixup_dev function
Hi Tim, On 08/08/2014 07:49, Tim Harvey wrote: > Some board-level drivers may wish to have per-device fixup functions > for PCI devices. > > Signed-off-by: Tim Harvey > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] imx: ventana: add pci fixup for PLX PEX860x switch GPIO
Hi Tim, On 08/08/2014 07:49, Tim Harvey wrote: > Most Gateworks Ventana boards use a PLX PEX860x PCIe switch for PCIe > expansion. > These boards use GPIO on the PLX device as PERST# for the downstream ports > thus we assert this when the PLX is enumerated. > > Signed-off-by: Tim Harvey > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] mtd: nand: am335x: Fix 'bit-flip' errors in SPL
OMAP GPMC driver used with some NAND Flash devices
(e.g. Spansion S34ML08G1) causes that U-boot shows
hundreds of 'nand: bit-flip corrected' error messages.
Possible cause was discussed in the mailinglist thread:
http://lists.denx.de/pipermail/u-boot/2014-April/177508.html
The issue was partially fixed with the cc81a5291910d7a.git
however this has to be done to fix the SPL.
The original author of the code is Belisko Marek
Signed-off-by: Rostislav Lisovy
---
drivers/mtd/nand/am335x_spl_bch.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/mtd/nand/am335x_spl_bch.c
b/drivers/mtd/nand/am335x_spl_bch.c
index ce65d8e..bf8b2ee 100644
--- a/drivers/mtd/nand/am335x_spl_bch.c
+++ b/drivers/mtd/nand/am335x_spl_bch.c
@@ -64,14 +64,18 @@ static int nand_command(int block, int page, uint32_t offs,
NAND_CTRL_ALE | NAND_CTRL_CHANGE); /* A[7:0] */
hwctrl(&nand_info[0], (offs >> 8) & 0xff, NAND_CTRL_ALE); /* A[11:9] */
/* Row address */
- hwctrl(&nand_info[0], (page_addr & 0xff), NAND_CTRL_ALE); /* A[19:12] */
- hwctrl(&nand_info[0], ((page_addr >> 8) & 0xff),
+ if (cmd != NAND_CMD_RNDOUT) {
+ hwctrl(&nand_info[0], (page_addr & 0xff),
+ NAND_CTRL_ALE); /* A[19:12] */
+ hwctrl(&nand_info[0], ((page_addr >> 8) & 0xff),
NAND_CTRL_ALE); /* A[27:20] */
#ifdef CONFIG_SYS_NAND_5_ADDR_CYCLE
- /* One more address cycle for devices > 128MiB */
- hwctrl(&nand_info[0], (page_addr >> 16) & 0x0f,
+ /* One more address cycle for devices > 128MiB */
+ hwctrl(&nand_info[0], (page_addr >> 16) & 0x0f,
NAND_CTRL_ALE); /* A[31:28] */
#endif
+ }
+
hwctrl(&nand_info[0], NAND_CMD_NONE, NAND_NCE | NAND_CTRL_CHANGE);
if (cmd == NAND_CMD_READ0) {
--
1.9.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only
Hello Lukasz, Am 09.09.2014 15:43, schrieb Lukasz Majewski: Hi Heiko, This patchserie adds the new config option CONFIG_DFU_FULLSPEED. Is there any special reason to support Full Speed (12 Mbit/sec - USB 1.1) and not rely solely on the High Speed (USB 2.0) as we do now? If this is enabled DFU uses fullspeed only. This is used on the siemens boards. Is there any DFU problem with the mentioned Siemens board, that we must use USB 1.1? I'd also appreciate more verbose rationale for this patch series - why this change is needed? What is the expected improvement? They have a "USB HW protection circuit" and therefore they only allowed to use fullspeed ... @Lukas Stockman: Maybe you could answer this better than me? bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] tools: imximage: Fix the maximum DCD size for mx53/mx6
On 01/09/2014 14:56, Fabio Estevam wrote: > According to mx53 and mx6 reference manuals: > > "The maximum size of the DCD limited to 1768 bytes." > > As each DCD entry consists of 8 bytes, we have a total of 1768 / 8 = 221, and > excluding the first entry, which is the header leads to 220 as the maximum > number for DCD size. > > Reported-by: Jonas Karlsson > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only
Hi Bin, > Lukasz, > > On 09/09/2014 08:43 AM, Lukasz Majewski wrote: > > Hi Heiko, > > > >> This patchserie adds the new config option CONFIG_DFU_FULLSPEED. > > > > Is there any special reason to support Full Speed (12 Mbit/sec - USB > > 1.1) and not rely solely on the High Speed (USB 2.0) as we do now? > > > > The drivers must support full-speed anyway based on the USB2.0 Specs. > > I have seen many cases in which only full-speed is suitable due to > either board design or specific USB use case. > > One example is that to better fit to the production firmware flashing > automation, a board does not use standard USB receptacle or plug, but > a four touch pads on the PCB, so that the robot can grab the board > and touch the pads to download the firmware. In this case signal > integrity is a concern, but not download speed. Thanks for example. Best regards, Lukasz > > Regards, > -Bin. > > >> If this is enabled DFU uses fullspeed only. This is used on the > >> siemens boards. > > > > Is there any DFU problem with the mentioned Siemens board, that we > > must use USB 1.1? > > > > I'd also appreciate more verbose rationale for this patch series - > > why this change is needed? What is the expected improvement? > > > > Thanks in advance. > > > >> > >> Cc: Tom Rini > >> Cc: Lukasz Majewski > >> Cc: Marek Vasut > >> Cc: Liu Bin > >> Cc: Lukas Stockmann > >> > >> Heiko Schocher (2): > >>usb: dfu: add config option to use in dfu mode fullspeed only > >>arm: am335x: siemens board use in DFU mode fullspeed only > >> > >> README | 3 +++ > >> drivers/usb/gadget/f_dfu.c | 3 +++ > >> drivers/usb/gadget/g_dnl.c | 3 +++ > >> include/configs/siemens-am33x-common.h | 3 ++- > >> 4 files changed, 11 insertions(+), 1 deletion(-) > >> > > > > > > > -- Best regards, Lukasz Majewski Samsung R&D Institute Poland (SRPOL) | Linux Platform Group ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/2] usb: dfu: add config option to use in dfu mode fullspeed only
Hi Bin,
> Heiko,
>
> On 09/09/2014 07:37 AM, Heiko Schocher wrote:
> > add the new config option CONFIG_DFU_FULLSPEED. With this
> > option enabled, DFU uses fullspeed only.
>
> Can we not introduce the new config option but check the gadget
> driver speed in runtime as what the ether gadget driver does?
>
> I don't want two config options (CONFIG_USB_GADGET_DUALSPEED and
> CONFIG_DFU_FULLSPEED) to control one feature, as in your patch 2/2.
+1
>
> Regards,
> -Bin.
>
> >
> > Signed-off-by: Heiko Schocher
> > Cc: Tom Rini
> > Cc: Lukasz Majewski
> > Cc: Marek Vasut
> > Cc: Liu Bin
> > Cc: Lukas Stockmann
> > ---
> > README | 3 +++
> > drivers/usb/gadget/f_dfu.c | 3 +++
> > drivers/usb/gadget/g_dnl.c | 3 +++
> > 3 files changed, 9 insertions(+)
> >
> > diff --git a/README b/README
> > index 0a0f528..1413392 100644
> > --- a/README
> > +++ b/README
> > @@ -1607,6 +1607,9 @@ The following options need to be configured:
> > entering dfuMANIFEST state. Host waits this
> > timeout, before sending again an USB request to the device.
> >
> > + CONFIG_DFU_FULLSPEED
> > + use for the dfu functionality fullspeed only.
> > +
> > - USB Device Android Fastboot support:
> > CONFIG_CMD_FASTBOOT
> > This enables the command "fastboot" which enables
> > the Android diff --git a/drivers/usb/gadget/f_dfu.c
> > b/drivers/usb/gadget/f_dfu.c index 1145aab..dfa9f3b 100644
> > --- a/drivers/usb/gadget/f_dfu.c
> > +++ b/drivers/usb/gadget/f_dfu.c
> > @@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu
> > *f_dfu) {
> > f_dfu->usb_function.strings = dfu_strings;
> > f_dfu->usb_function.hs_descriptors = f_dfu->function;
> > + f_dfu->usb_function.descriptors = f_dfu->function;
> > f_dfu->dfu_state = DFU_STATE_dfuIDLE;
> > }
> >
> > @@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu
> > *f_dfu) {
> > f_dfu->usb_function.strings = NULL;
> > f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> > + f_dfu->usb_function.descriptors = dfu_runtime_descs;
> > }
> >
> > static int handle_upload(struct usb_request *req, u16 len)
> > @@ -809,6 +811,7 @@ static int dfu_bind_config(struct
> > usb_configuration *c) return -ENOMEM;
> > f_dfu->usb_function.name = "dfu";
> > f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
> > + f_dfu->usb_function.descriptors = dfu_runtime_descs;
> > f_dfu->usb_function.bind = dfu_bind;
> > f_dfu->usb_function.unbind = dfu_unbind;
> > f_dfu->usb_function.set_alt = dfu_set_alt;
> > diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
> > index 58cad11..79e0c9c 100644
> > --- a/drivers/usb/gadget/g_dnl.c
> > +++ b/drivers/usb/gadget/g_dnl.c
> > @@ -143,6 +143,9 @@ static int g_dnl_config_register(struct
> > usb_composite_dev *cdev) config->bConfigurationValue =
> > CONFIGURATION_NUMBER; config->iConfiguration = STRING_USBDOWN;
> > config->bind = g_dnl_do_config;
> > +#if defined(CONFIG_DFU_FULLSPEED)
> > + config->fullspeed = 1;
> > +#endif
> >
> > return usb_add_config(cdev, config);
> > }
> >
>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: ventana: Avoid undefined behaviour
On 22/08/2014 09:46, Thierry Reding wrote:
> From: Thierry Reding
>
> The leds array within struct ventana has space for 3 elements, but the
> setup_board_gpio() function tries to set up 4 GPIOs for LEDs. Recent
> versions of GCC complain about that:
>
> board/gateworks/gw_ventana/gw_ventana.c: In function 'setup_board_gpio':
> board/gateworks/gw_ventana/gw_ventana.c:987:27: warning: iteration 3u
> invokes undefined behavior [-Waggressive-loop-optimizations]
> if (gpio_cfg[board].leds[i])
> ^
> board/gateworks/gw_ventana/gw_ventana.c:986:2: note: containing loop
> for (i = 0; i < 4; i++) {
> ^
>
> Fix this by making the upper bound of the loop match the array size.
>
> Signed-off-by: Thierry Reding
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] iMX6: Disable the L2 before chaning the PL310 latency
On 20/08/2014 11:18, Ye.Li wrote: > From: "Ye.Li" > > The Latency parameters of PL310 Tag RAM latency control register and > Data RAM Latency control register are set in L2 cache enable. And > setting these registers must have PL310 NOT enabled. > > But when using Plugin mode boot, the PL310 is enabled by bootrom. > The patch disables the PL310 before applying this setting. > > Signed-off-by: Ye.Li > --- Applied to u-boot-imx, thanks ! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/8] Makefile: default to cc for host compiler
Hi Jeroen, Masahiro, On Thu, 31 Jul 2014 19:01:22 +0900, Masahiro Yamada wrote: > > HOSTCXX = g++ > > HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer > For consistency, > > HOSTCXX = c++ > > ? So, Jeroen, what is your pick ? Will you send a v3 7/8, or are you sticking with g++? (or if everyone agrees, I could to the change to v2 7/8 when applying it, and add a comment about it in the commit message.) Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 1/2] usb: eth: add ASIX AX88179 DRIVER
On Wednesday, September 03, 2014 at 04:31:20 PM, Rene Griessl wrote:
> changes in v2:
> -added usb_ether.h to change list
> -added 2nd patch to enable driver for arndale board
>
> Signed-off-by: Rene Griessl
I see that in Linux, there is asix_common.c stuff. Can this driver share any
parts with drivers/net/ax88* ?
> ---
> drivers/usb/eth/Makefile| 3 +
> drivers/usb/eth/asix88179.c | 641
> drivers/usb/eth/usb_ether.c |
> 7 +
> include/usb_ether.h | 6 +
> 4 files changed, 657 insertions(+)
> create mode 100644 drivers/usb/eth/asix88179.c
>
> diff --git a/drivers/usb/eth/Makefile b/drivers/usb/eth/Makefile
> index 94551c4..fad4acd 100644
> --- a/drivers/usb/eth/Makefile
> +++ b/drivers/usb/eth/Makefile
> @@ -8,5 +8,8 @@ obj-$(CONFIG_USB_HOST_ETHER) += usb_ether.o
> ifdef CONFIG_USB_ETHER_ASIX
> obj-y += asix.o
> endif
> +ifdef CONFIG_USB_ETHER_ASIX_88179
> +obj-y += asix88179.o
> +endif
This should be obj-$(CONFIG) as seen below. Fix the asix one in a separate
patch please.
[...]
> +/* ASIX AX88179 based USB 3.0 Ethernet Devices */
> +#define AX88179_PHY_ID 0x03
> +#define AX_EEPROM_LEN0x100
> +#define AX88179_EEPROM_MAGIC 0x17900b95
> +#define AX_MCAST_FLTSIZE 8
> +#define AX_MAX_MCAST 64
> +#define AX_INT_PPLS_LINK ((u32)BIT(16))
The u32 cast is not needed. Also, please drop the BIT() macro, it's just
obfuscating the code, just use (1 << 16) instead. Please fix globally.
> +#define AX_RXHDR_L4_TYPE_MASK0x1c
> +#define AX_RXHDR_L4_TYPE_UDP 4
> +#define AX_RXHDR_L4_TYPE_TCP 16
> +#define AX_RXHDR_L3CSUM_ERR 2
> +#define AX_RXHDR_L4CSUM_ERR 1
> +#define AX_RXHDR_CRC_ERR ((u32)BIT(29))
> +#define AX_RXHDR_DROP_ERR((u32)BIT(31))
> +#define AX_ACCESS_MAC0x01
> +#define AX_ACCESS_PHY0x02
> +#define AX_ACCESS_EEPROM 0x04
> +#define AX_ACCESS_EFUS 0x05
> +#define AX_PAUSE_WATERLVL_HIGH 0x54
> +#define AX_PAUSE_WATERLVL_LOW0x55
[...]
> +static inline int asix_get_phy_addr(struct ueth_data *dev)
> +{
> + ALLOC_CACHE_ALIGN_BUFFER(u8, buf, 2);
> + int ret = -1;
> + if (dev->pusb_dev->descriptor.idProduct == 0x1790) {
> + ret = asix_read_cmd(dev, AX_ACCESS_MAC, 0x10, 6, 6, buf);
> + debug("asix_get_phy_addr() returning
0x%02x%02x%02x%02x%02x%02x\n",
> + buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
> + }
> + else {
> + }
Uh, this check needs some rework, right ? Also, you want to lint your patches
with ./scripts/checkpatch.pl tool before resubmitting.
> + return ret;
> +}
> +
> +
> +static int asix_read_mac(struct eth_device *eth)
> +{
> + struct ueth_data *dev = (struct ueth_data *)eth->priv;
> + ALLOC_CACHE_ALIGN_BUFFER(unsigned char, buf, ETH_ALEN);
> +
> + if (dev->pusb_dev->descriptor.idProduct == 0x1790) {
> + asix_read_cmd(dev, AX_ACCESS_MAC, 0x10, 6, 6, buf);
> + debug("asix_read_mac() returning 0x%02x%02x%02x%02x%02x%02x\n",
> + buf[0], buf[1], buf[2], buf[3], buf[4], buf[5]);
> + memcpy(eth->enetaddr, buf, ETH_ALEN);
> + }
> + return 0;
> +}
> +
> +
> +
> +static int asix_basic_reset(struct ueth_data *dev)
> +{
> + ALLOC_CACHE_ALIGN_BUFFER(u8, buf, 6);
Why does the buffer need to be aligned here ? It's just a buffer that is not
used for DMA, no ?
> + u16 *tmp16;
Is it because you were getting unaligned accesses , since when the buffer
itself
was not aligned and you did cast it to u16, the CPU triggered unaligned access ?
> + u8 *tmp;
[...]
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/2] usb: dfu: add config option to use in dfu mode fullspeed only
Hello Bin Liu,
Am 09.09.2014 16:09, schrieb Bin Liu:
Heiko,
On 09/09/2014 07:37 AM, Heiko Schocher wrote:
add the new config option CONFIG_DFU_FULLSPEED. With this
option enabled, DFU uses fullspeed only.
Can we not introduce the new config option but check the gadget driver speed in
runtime as what the ether gadget driver does?
I don't want two config options (CONFIG_USB_GADGET_DUALSPEED and
CONFIG_DFU_FULLSPEED) to control one feature, as in your patch 2/2.
Hmm.. I am not sure, if I understand you correct. I could use
CONFIG_USB_GADGET_DUALSPEED instead the new config option
for setting "config->fullspeed = 1;" in g_dnl_config_register()
If you mean this, yes, thats would be a good change...
bye,
Heiko
Regards,
-Bin.
Signed-off-by: Heiko Schocher
Cc: Tom Rini
Cc: Lukasz Majewski
Cc: Marek Vasut
Cc: Liu Bin
Cc: Lukas Stockmann
---
README | 3 +++
drivers/usb/gadget/f_dfu.c | 3 +++
drivers/usb/gadget/g_dnl.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/README b/README
index 0a0f528..1413392 100644
--- a/README
+++ b/README
@@ -1607,6 +1607,9 @@ The following options need to be configured:
entering dfuMANIFEST state. Host waits this timeout, before
sending again an USB request to the device.
+ CONFIG_DFU_FULLSPEED
+ use for the dfu functionality fullspeed only.
+
- USB Device Android Fastboot support:
CONFIG_CMD_FASTBOOT
This enables the command "fastboot" which enables the Android
diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index 1145aab..dfa9f3b 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = dfu_strings;
f_dfu->usb_function.hs_descriptors = f_dfu->function;
+ f_dfu->usb_function.descriptors = f_dfu->function;
f_dfu->dfu_state = DFU_STATE_dfuIDLE;
}
@@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = NULL;
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
}
static int handle_upload(struct usb_request *req, u16 len)
@@ -809,6 +811,7 @@ static int dfu_bind_config(struct usb_configuration *c)
return -ENOMEM;
f_dfu->usb_function.name = "dfu";
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
f_dfu->usb_function.bind = dfu_bind;
f_dfu->usb_function.unbind = dfu_unbind;
f_dfu->usb_function.set_alt = dfu_set_alt;
diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
index 58cad11..79e0c9c 100644
--- a/drivers/usb/gadget/g_dnl.c
+++ b/drivers/usb/gadget/g_dnl.c
@@ -143,6 +143,9 @@ static int g_dnl_config_register(struct usb_composite_dev
*cdev)
config->bConfigurationValue = CONFIGURATION_NUMBER;
config->iConfiguration = STRING_USBDOWN;
config->bind = g_dnl_do_config;
+#if defined(CONFIG_DFU_FULLSPEED)
+ config->fullspeed = 1;
+#endif
return usb_add_config(cdev, config);
}
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imximage: Fix imximage IVT bug for EIM-NOR boot
Hi Ye, On 21/08/2014 09:04, Li Ye-B37916 wrote: > There are two minor impacts if putting the check in the function > "parse_cfg_cmd": > > 1. The "imximage_version" must be got before parsing a CMD_BOOT_FROM > command. This compels the CMD_IMAGE_VERSION preceding the > CMD_BOOT_FROM in script. imximage_init_loadsize is only needed by V2 > version. I know abot this, and this is a minor impact. It is common that a version number of a document must be set first in the document. > > 2. Since the "imximage_generate" function already implements post > fixing for imximage_init_loadsize, this post fixing needs be > removed. > > Actually, putting the check in the parsing or post the parsing are ok > for me. Both can resolve the issue. The comment for > "FLASH_LOADSIZE_NOR" sources from iMX reference manual, it is > correct. Well, I think it is clear for both of us because we worked with i-IM images. But setting a size to 0x0 with the comment that this is the size of whole image can be confusing (I think I was the author of this comment, so I am guilty for that). Anyway, it is a very minor issue. I hope that people will read carefully the manual together with code. Anyway, comments are very minor issues - I will apply the patch. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/2] usb: dfu: add config option to use in dfu mode fullspeed only
Heiko,
On 09/09/2014 09:37 AM, Heiko Schocher wrote:
Hello Bin Liu,
Am 09.09.2014 16:09, schrieb Bin Liu:
Heiko,
On 09/09/2014 07:37 AM, Heiko Schocher wrote:
add the new config option CONFIG_DFU_FULLSPEED. With this
option enabled, DFU uses fullspeed only.
Can we not introduce the new config option but check the gadget driver
speed in runtime as what the ether gadget driver does?
I don't want two config options (CONFIG_USB_GADGET_DUALSPEED and
CONFIG_DFU_FULLSPEED) to control one feature, as in your patch 2/2.
Hmm.. I am not sure, if I understand you correct. I could use
CONFIG_USB_GADGET_DUALSPEED instead the new config option
for setting "config->fullspeed = 1;" in g_dnl_config_register()
If you mean this, yes, thats would be a good change...
No, I did not mean this build time macro, but was thinking you can check
g->speed at the same place in runtime.
I think you can refer to ether.c, which supports full-speed but does not
use any macro.
Regards,
-Bin.
bye,
Heiko
Regards,
-Bin.
Signed-off-by: Heiko Schocher
Cc: Tom Rini
Cc: Lukasz Majewski
Cc: Marek Vasut
Cc: Liu Bin
Cc: Lukas Stockmann
---
README | 3 +++
drivers/usb/gadget/f_dfu.c | 3 +++
drivers/usb/gadget/g_dnl.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/README b/README
index 0a0f528..1413392 100644
--- a/README
+++ b/README
@@ -1607,6 +1607,9 @@ The following options need to be configured:
entering dfuMANIFEST state. Host waits this timeout, before
sending again an USB request to the device.
+ CONFIG_DFU_FULLSPEED
+ use for the dfu functionality fullspeed only.
+
- USB Device Android Fastboot support:
CONFIG_CMD_FASTBOOT
This enables the command "fastboot" which enables the Android
diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index 1145aab..dfa9f3b 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = dfu_strings;
f_dfu->usb_function.hs_descriptors = f_dfu->function;
+ f_dfu->usb_function.descriptors = f_dfu->function;
f_dfu->dfu_state = DFU_STATE_dfuIDLE;
}
@@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu
*f_dfu)
{
f_dfu->usb_function.strings = NULL;
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
}
static int handle_upload(struct usb_request *req, u16 len)
@@ -809,6 +811,7 @@ static int dfu_bind_config(struct
usb_configuration *c)
return -ENOMEM;
f_dfu->usb_function.name = "dfu";
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
f_dfu->usb_function.bind = dfu_bind;
f_dfu->usb_function.unbind = dfu_unbind;
f_dfu->usb_function.set_alt = dfu_set_alt;
diff --git a/drivers/usb/gadget/g_dnl.c b/drivers/usb/gadget/g_dnl.c
index 58cad11..79e0c9c 100644
--- a/drivers/usb/gadget/g_dnl.c
+++ b/drivers/usb/gadget/g_dnl.c
@@ -143,6 +143,9 @@ static int g_dnl_config_register(struct
usb_composite_dev *cdev)
config->bConfigurationValue = CONFIGURATION_NUMBER;
config->iConfiguration = STRING_USBDOWN;
config->bind = g_dnl_do_config;
+#if defined(CONFIG_DFU_FULLSPEED)
+ config->fullspeed = 1;
+#endif
return usb_add_config(cdev, config);
}
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] imx6: add Bachmann OT1200 board
This patch adds support for the OT1200 series of devices.
Following components are used in u-boot:
+ ethernet
+ i2c
+ emmc
+ gpio
The main difference between the different models of the OT1200
series is how ethernet is connected (directly to a switch or
to a normal phy).
Signed-off-by: Christian Gmeiner
---
arch/arm/Kconfig | 4 +
board/bachmann/ot1200/Kconfig | 23
board/bachmann/ot1200/MAINTAINERS | 6 +
board/bachmann/ot1200/Makefile| 9 ++
board/bachmann/ot1200/ot1200.c| 262 ++
configs/ot1200_defconfig | 3 +
include/configs/ot1200.h | 195
7 files changed, 502 insertions(+)
create mode 100644 board/bachmann/ot1200/Kconfig
create mode 100644 board/bachmann/ot1200/MAINTAINERS
create mode 100644 board/bachmann/ot1200/Makefile
create mode 100644 board/bachmann/ot1200/ot1200.c
create mode 100644 configs/ot1200_defconfig
create mode 100644 include/configs/ot1200.h
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 22f0f09..c93dcb6 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -412,6 +412,9 @@ config TARGET_HUMMINGBOARD
config TARGET_TQMA6
bool "TQ Systems TQMa6 board"
+config TARGET_OT1200
+ bool "Bachmann OT1200"
+
config OMAP34XX
bool "OMAP34XX SoC"
@@ -564,6 +567,7 @@ source "board/atmel/at91sam9rlek/Kconfig"
source "board/atmel/at91sam9x5ek/Kconfig"
source "board/atmel/sama5d3_xplained/Kconfig"
source "board/atmel/sama5d3xek/Kconfig"
+source "board/bachmann/ot1200/Kconfig"
source "board/balloon3/Kconfig"
source "board/barco/titanium/Kconfig"
source "board/bluegiga/apx4devkit/Kconfig"
diff --git a/board/bachmann/ot1200/Kconfig b/board/bachmann/ot1200/Kconfig
new file mode 100644
index 000..55a825d
--- /dev/null
+++ b/board/bachmann/ot1200/Kconfig
@@ -0,0 +1,23 @@
+if TARGET_OT1200
+
+config SYS_CPU
+ string
+ default "armv7"
+
+config SYS_BOARD
+ string
+ default "ot1200"
+
+config SYS_VENDOR
+ string
+ default "bachmann"
+
+config SYS_SOC
+ string
+ default "mx6"
+
+config SYS_CONFIG_NAME
+ string
+ default "ot1200"
+
+endif
diff --git a/board/bachmann/ot1200/MAINTAINERS
b/board/bachmann/ot1200/MAINTAINERS
new file mode 100644
index 000..ad75c24
--- /dev/null
+++ b/board/bachmann/ot1200/MAINTAINERS
@@ -0,0 +1,6 @@
+BACHMANN ELECTRONIC OT1200 BOARD
+M: Christian Gmeiner
+S: Maintained
+F: board/bachmann/ot1200
+F: include/configs/ot1200.h
+F: configs/ot1200*_defconfig
diff --git a/board/bachmann/ot1200/Makefile b/board/bachmann/ot1200/Makefile
new file mode 100644
index 000..1bd42e8
--- /dev/null
+++ b/board/bachmann/ot1200/Makefile
@@ -0,0 +1,9 @@
+#
+# Copyright (C) 2012-2013, Guennadi Liakhovetski
+# (C) Copyright 2012-2013 Freescale Semiconductor, Inc.
+# Copyright (C) 2013, Boundary Devices
+#
+# SPDX-License-Identifier: GPL-2.0+
+#
+
+obj-y := ot1200.o
diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
new file mode 100644
index 000..1c04f45
--- /dev/null
+++ b/board/bachmann/ot1200/ot1200.c
@@ -0,0 +1,262 @@
+/*
+ * Copyright (C) 2010-2013 Freescale Semiconductor, Inc.
+ * Copyright (C) 2014, Bachmann electronic GmbH
+ *
+ * SPDX-License-Identifier:GPL-2.0+
+ */
+
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+#include
+
+DECLARE_GLOBAL_DATA_PTR;
+
+#define UART_PAD_CTRL (PAD_CTL_PUS_100K_UP | \
+ PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm | \
+ PAD_CTL_SRE_FAST | PAD_CTL_HYS)
+
+#define USDHC_PAD_CTRL (PAD_CTL_PUS_47K_UP | \
+ PAD_CTL_SPEED_LOW | PAD_CTL_DSE_80ohm | \
+ PAD_CTL_SRE_FAST | PAD_CTL_HYS)
+
+#define ENET_PAD_CTRL (PAD_CTL_PUS_100K_UP | \
+ PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm | PAD_CTL_HYS)
+
+#define SPI_PAD_CTRL (PAD_CTL_HYS | PAD_CTL_SPEED_MED |\
+ PAD_CTL_DSE_40ohm | PAD_CTL_SRE_FAST)
+
+#define I2C_PAD_CTRL (PAD_CTL_PUS_100K_UP | \
+ PAD_CTL_SPEED_MED | PAD_CTL_DSE_40ohm | PAD_CTL_HYS | \
+ PAD_CTL_ODE | PAD_CTL_SRE_FAST)
+
+#define OUTPUT_40OHM (PAD_CTL_SPEED_MED|PAD_CTL_DSE_40ohm)
+
+int dram_init(void)
+{
+ gd->ram_size = get_ram_size((void *)PHYS_SDRAM, PHYS_SDRAM_SIZE);
+
+ return 0;
+}
+
+static iomux_v3_cfg_t const uart1_pads[] = {
+ MX6_PAD_CSI0_DAT10__UART1_TX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
+ MX6_PAD_CSI0_DAT11__UART1_RX_DATA | MUX_PAD_CTRL(UART_PAD_CTRL),
+};
+
+static void setup_iomux_uart(void)
+{
+ imx_iomux_v3_setup_multiple_pads(uart1_pads, ARRAY_SIZE(uart1_pads));
+}
+
+static iomux_v3_cfg_t const enet_pads[] = {
+ MX6_PAD_KEY_ROW1__ENET_COL | MUX_PAD_CTRL(ENET_PAD_CTRL),
+ MX6_PAD
Re: [U-Boot] [PATCH] mx6: Fix ECSPI typo in soc_boot_modes
On 10/08/2014 19:03, picmas...@mail.bg wrote: > From: Nikolay Dimitrov > > Signed-off-by: Nikolay Dimitrov > Cc: Stefano Babic > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] arm: vf610: lpuart: fix status register handling
On 19/08/2014 17:54, Stefan Agner wrote: > The status register 1 (S1) is not writeable, hence we should not > write it. In order to clear the RDRF flag we only need to read > the data register. > > Also, when stressing U-Boot a lot with serial input, an overflow can > occur which asserts the S1_OR flag (while not asserting the S1_RDRF > flag). To clear this flag we again just need to read the data > register, hence add this flag to the abort conditions for the while > loop. > > Insert a compiler barrier to make sure reading the data register > gets executed after reading the status register. > > Signed-off-by: Stefan Agner > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 2/2] arm: vf610: lpuart: disable FIFO on initializaton
On 19/08/2014 17:54, Stefan Agner wrote: > UART does not use the UART FIFO, but we should also not rely that > the UART FIFO is diabled by default. For instance, when loading > U-Boot using the boot ROMs serial downloader protocol over UART, > FIFO is enabled at U-Boot start time. > > This patch disables the RX and TX FIFO, sets back their thresholds > and flushes them. > > Signed-off-by: Stefan Agner > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] mx6dlsabresd: Use its own DCD table
On 21/08/2014 15:02, Fabio Estevam wrote: > Currently mx6dlsabresd shares the same DCD settings with the nitrogen board. > > Provide a DCD configuration file specific to mx6dlsabresd with the settings > recommended by the Freescale hardware team. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] imx: nitrogen6x: Replace 'fatload' by 'load' command in env settings to be filesystem independent
On 26/08/2014 12:05, Guillaume GARDET wrote: > nitrogen6x.h file defines CONFIG_CMD_FS_GENERIC, so we are able to use generic > 'load' command instead of 'fatload'. It allows to use ext filesystem and keep > compatibilty with fat filesystem. > > Signed-off-by: Guillaume GARDET > Cc: Stefano Babic > > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V4 00/19] Introduce cm-fx6 board
On 09/09/14 16:45, Stefano Babic wrote: Hi Nikita, On 31/08/2014 10:09, Nikita Kiryanov wrote: Hi Tom, Stefano, We really want this series to make it into the next release (V1 was submitted only a day after the merge window closed). If there are no other comments, can we maybe start applying it? Patch 1/19, 4/19 and 5/19 were already applied by Jagan - I do not merge them into u-boot-imx. I applied 2/19 after rebasing on current u-boot-imx. I have nothing against the helper introduced in 3/19, but this touch more boards - I will make a short check before applying it. However, it is orthogonal and can be applied later. I applied as well 6/19 through 19/19 into u-boot-imx - thanks ! Thanks! I'm a little confused about what you meant by patch 3 though... Jagan took patch number 3 (and 1, and 4), and I can see in your tree that all 16 remaining patches are there. What patch were you referring to? Best regards, Stefano Babic -- Regards, Nikita Kiryanov ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH V4 00/19] Introduce cm-fx6 board
Hi Nikita, On 09/09/2014 17:00, Nikita Kiryanov wrote: > > > On 09/09/14 16:45, Stefano Babic wrote: >> Hi Nikita, >> >> On 31/08/2014 10:09, Nikita Kiryanov wrote: >>> Hi Tom, Stefano, >>> >>> We really want this series to make it into the next release (V1 was >>> submitted only a day after the merge window closed). If there are no >>> other comments, can we maybe start applying it? >>> >> >> Patch 1/19, 4/19 and 5/19 were already applied by Jagan - I do not merge >> them into u-boot-imx. >> I applied 2/19 after rebasing on current u-boot-imx. >> >> I have nothing against the helper introduced in 3/19, but this touch >> more boards - I will make a short check before applying it. However, it >> is orthogonal and can be applied later. >> >> I applied as well 6/19 through 19/19 into u-boot-imx - thanks ! > > Thanks! > I'm a little confused about what you meant by patch 3 though... > Jagan took patch number 3 (and 1, and 4), I have not seen that Jagan picked up patch 3, I found only 1, 4 and 5. > and I can see in your tree > that all 16 remaining patches are there. What patch were you referring > to? Then all patches should be already merged and will flow into Tom's tree at next pull request. Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH RESEND] vf610twr: Tune DDR initialization settings
Hi Albert, The RESEND version of the patch is actually an updated version (maybe I should have increased the version number?) For me, that patch applies cleanly on U-Boot master 0b703dbcee7103f07804d0a4328d1593355c4324 patman: Fix detection of git version Also I tested on U-Boot ARM master and next branch, applies without errors for me. -- Stefan Am 2014-09-09 10:26, schrieb Albert ARIBAUD: > Hi Stefan, > > On Sat, 6 Sep 2014 19:47:06 +0200, Stefan Agner > wrote: > >> From: Anthony Felice >> >> Removed settings in unsupported register fields. They didn’t >> do anything, and in most cases, were not documented in the >> reference manual. >> >> Changed register settings to comply with JEDEC required values. >> >> Changed timing parameters because they included full clock >> periods that were doing nothing. >> >> Signed-off-by: Anthony Felice >> [rebased on v2014.10-rc2] >> Signed-off-by: Stefan Agner >> --- >> As discuessed in the initial patch set this fixes a lot of wrong/ >> undocummented access and it would be nice to have in the next U-Boot >> release. Verified the patchset after rebase again using memtester >> on Vybrid Tower. >> >> arch/arm/include/asm/arch-vf610/imx-regs.h| 49 +++--- >> arch/arm/include/asm/arch-vf610/iomux-vf610.h | 44 +++-- >> arch/arm/include/asm/imx-common/iomux-v3.h| 2 + >> board/freescale/vf610twr/vf610twr.c | 94 >> +-- >> 4 files changed, 127 insertions(+), 62 deletions(-) >> >> diff --git a/arch/arm/include/asm/arch-vf610/imx-regs.h >> b/arch/arm/include/asm/arch-vf610/imx-regs.h >> index bb00217..9d797db 100644 >> --- a/arch/arm/include/asm/arch-vf610/imx-regs.h >> +++ b/arch/arm/include/asm/arch-vf610/imx-regs.h >> @@ -103,9 +103,11 @@ >> /* DDRMC */ >> #define DDRMC_PHY_DQ_TIMING 0x2613 >> #define DDRMC_PHY_DQS_TIMING0x2615 >> -#define DDRMC_PHY_CTRL 0x01210080 >> +#define DDRMC_PHY_CTRL 0x0021 >> #define DDRMC_PHY_MASTER_CTRL 0x0001012a >> -#define DDRMC_PHY_SLAVE_CTRL0x00012020 >> +#define DDRMC_PHY_SLAVE_CTRL0x2000 >> +#define DDRMC_PHY_OFF 0x >> +#define DDRMC_PHY_PROC_PAD_ODT 0x00010101 >> >> #define DDRMC_PHY50_DDR3_MODE (1 << 12) >> #define DDRMC_PHY50_EN_SW_HALF_CYCLE(1 << 8) >> @@ -138,7 +140,7 @@ >> #define DDRMC_CR21_CCMAP_EN 1 >> #define DDRMC_CR22_TDAL(v) (((v) & 0x3f) << 16) >> #define DDRMC_CR23_BSTLEN(v)(((v) & 0x7) << >> 24) >> -#define DDRMC_CR23_TDLL(v) ((v) & 0xff) >> +#define DDRMC_CR23_TDLL(v) ((v) & 0x) >> #define DDRMC_CR24_TRP_AB(v)((v) & 0x1f) >> #define DDRMC_CR25_TREF_EN (1 << 16) >> #define DDRMC_CR26_TREF(v) (((v) & 0x) << 16) >> @@ -151,7 +153,7 @@ >> #define DDRMC_CR33_EN_QK_SREF (1 << 16) >> #define DDRMC_CR34_CKSRX(v) (((v) & 0xf) << 16) >> #define DDRMC_CR34_CKSRE(v) (((v) & 0xf) << 8) >> -#define DDRMC_CR38_FREQ_CHG_EN (1 << 8) >> +#define DDRMC_CR38_FREQ_CHG_EN(v) (((v) & 0x1) << 8) >> #define DDRMC_CR39_PHY_INI_COM(v) (((v) & 0x) << 16) >> #define DDRMC_CR39_PHY_INI_STA(v) (((v) & 0xff) << 8) >> #define DDRMC_CR39_FRQ_CH_DLLOFF(v) ((v) & 0x3) >> @@ -163,7 +165,7 @@ >> #define DDRMC_CR67_ZQCS(v) ((v) & 0xfff) >> #define DDRMC_CR69_ZQ_ON_SREF_EX(v) (((v) & 0xf) << 8) >> #define DDRMC_CR70_REF_PER_ZQ(v)(v) >> -#define DDRMC_CR72_ZQCS_ROTATE (1 << 24) >> +#define DDRMC_CR72_ZQCS_ROTATE(v) (((v) & 0x1) << 24) >> #define DDRMC_CR73_APREBIT(v) (((v) & 0xf) << >> 24) >> #define DDRMC_CR73_COL_DIFF(v) (((v) & 0x7) << >> 16) >> #define DDRMC_CR73_ROW_DIFF(v) (((v) & 0x3) << >> 8) >> @@ -182,9 +184,10 @@ >> #define DDRMC_CR77_CS_MAP (1 << 24) >> #define DDRMC_CR77_DI_RD_INTLEAVE (1 << 8) >> #define DDRMC_CR77_SWAP_EN 1 >> +#define DDRMC_CR78_Q_FULLNESS(v)(((v) & 0x7) << 24) >> #define DDRMC_CR78_BUR_ON_FLY_BIT(v)((v) & 0xf) >> -#define DDRMC_CR79_CTLUPD_AREF (1 << 24) >> -#define DDRMC_CR82_INT_MASK 0x1fff >> +#define DDRMC
Re: [U-Boot] [PATCH] mx6qsabreauto: Remove imx6q-sabreauto.dts
Hi Masahiro,
On 09/09/2014 07:11, Masahiro Yamada wrote:
> Hi Stefano,
>
>
>
> On Fri, 5 Sep 2014 16:26:48 -0300
> Otavio Salvador wrote:
>
>> On Fri, Sep 5, 2014 at 3:36 PM, Fabio Estevam wrote:
>>> From: Fabio Estevam
>>>
>>> Commit fa9c021632473 ("mx6: add example DTB for mx6qsabreauto") introduced
>>> 'imx6q-sabreauto.dts' but it adds no real value as the dts file only
>>> contains
>>> the 'model' and 'compatible' strings.
>>>
>>> After this commit the final binary is also changed from 'u-boot.imx' to
>>> 'u-boot-dtb.imx', which may confuse users.
>>>
>>> So revert it until a more complete and useful device tree could be provided.
>>>
>>> Signed-off-by: Fabio Estevam
>>
>> Acked-by: Otavio Salvador
>>
>
>
> Could you pick up this trivial one and send a pull-req?
>
> I am moving CONFIG_OF_SEPARATE and CONFIG_DEFAULT_DEVICE_TREE
> to Kconfig.
>
> Ideally, this patch should come first.
>
>
> See this thread:
> http://thread.gmane.org/gmane.comp.boot-loaders.u-boot/
>
I am preparing the PR - it comes soon.
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 1/3] mx6: imx-regs: Provide a structure for GPC registers
On 25/08/2014 19:26, Fabio Estevam wrote: > Introduce a structure for accessing the General Power Controller block (GPC) > registers. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3] env_mmc: correct fini partition to match init partition
Hi Peter,
On 09/03/14 20:22, Peter A. Bigot wrote:
> The code to set the MMC partition uses an weak function to obtain the
> correct partition number. Use that instead of the compile-time default
> when deciding whether it needs to switch back.
>
> Fixes: 6e7b7df4df43574 ("env_mmc: support env partition setup in runtime")
It is sometimes also useful to Cc the original author of the patch.
Cc: Dmitry Lifshitz
> Signed-off-by: Peter A. Bigot
> ---
> V3:
> * Add Fixes line as requested
>
> V2:
> * Preserve desired behavior of avoiding diagnostic when no HW partition
> supported
> * Supersedes https://patchwork.ozlabs.org/patch/385355/
>
> common/env_mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/common/env_mmc.c b/common/env_mmc.c
> index a7621a8..14648e3 100644
> --- a/common/env_mmc.c
> +++ b/common/env_mmc.c
> @@ -113,7 +113,7 @@ static void fini_mmc_for_env(struct mmc *mmc)
> #ifdef CONFIG_SPL_BUILD
> dev = 0;
> #endif
> - if (CONFIG_SYS_MMC_ENV_PART != mmc->part_num)
> + if (mmc_get_env_part(mmc) != mmc->part_num)
> mmc_switch_part(dev, mmc->part_num);
> #endif
> }
>
--
Regards,
Igor.
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH RESEND] vf610twr: Tune DDR initialization settings
Hi Stefan, Albert, On 09/09/2014 17:14, Stefan Agner wrote: > Hi Albert, > > The RESEND version of the patch is actually an updated version (maybe I > should have increased the version number?) > > For me, that patch applies cleanly on U-Boot master > > 0b703dbcee7103f07804d0a4328d1593355c4324 > patman: Fix detection of git version > > Also I tested on U-Boot ARM master and next branch, applies without > errors for me. > I have tried myself and I can confirm that patch can be applied fine. Albert, should I apply it to u-boot-imx (vf610twr is part of iMX) and then send it in my next PR ? Stefano -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 2/3] pcie_imx: Add mx6solox support
On 25/08/2014 19:26, Fabio Estevam wrote: > Let PCI on mx6solox also be supported. > > Signed-off-by: Fabio Estevam > --- Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH] README.imximage: Fix the maximum DCD size
Hi Fabio,
On 09/09/2014 17:28, Fabio Estevam wrote:
> In commit 021e79c85371 ("tools: imximage: Fix the maximum DCD size for
> mx53/mx6") we have fixed the maximum DCD size for mx53/mx53.
>
> Do the same on the README document for consistency.
>
> Reported-by: Jonas Karlsson
> Signed-off-by: Fabio Estevam
> ---
> doc/README.imximage | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/README.imximage b/doc/README.imximage
> index dcda200..27d3354 100644
> --- a/doc/README.imximage
> +++ b/doc/README.imximage
> @@ -120,7 +120,7 @@ Configuration command line syntax:
> DATA 4 0x73FA88a0 0x200
>
> The processor support up to 60 register programming commands for
> IMXIMAGE_VERSION 1
> -and 121 register programming commands for IMXIMAGE_VERSION 2.
> +and 220 register programming commands for IMXIMAGE_VERSION 2.
> An error is generated if more commands are found in the configuration file.
>
Correct. Thanks for fixing the documentation, too.
Acked-by: Stefano Babic
Best regards,
Stefano Babic
--
=
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v3 3/3] mx6sxsabresd: Add PCI support
On 25/08/2014 19:26, Fabio Estevam wrote: > Tested with an Intel Wireless PCI 7260HMW card: > > U-Boot 2014.10-rc1-16576-g4a8a8a8-dirty (Aug 23 2014 - 16:05:11) > > > > CPU: Freescale i.MX6SX rev1.0 at 792 MHz > > Reset cause: WDOG > > Board: MX6SX SABRE SDB > > I2C: ready > > DRAM: 1 GiB > > MMC: FSL_SDHC: 0 > > 00:01.0 - 16c3:abcd - Bridge device > >01:00.0- 8086:08b1 - Network controller > > > Signed-off-by: Fabio Estevam > --- I have no problem with the commit message. Applied to u-boot-imx, thanks! Best regards, Stefano Babic -- = DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de = ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] README.imximage: Fix the maximum DCD size
In commit 021e79c85371 ("tools: imximage: Fix the maximum DCD size for
mx53/mx6") we have fixed the maximum DCD size for mx53/mx53.
Do the same on the README document for consistency.
Reported-by: Jonas Karlsson
Signed-off-by: Fabio Estevam
---
doc/README.imximage | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/README.imximage b/doc/README.imximage
index dcda200..27d3354 100644
--- a/doc/README.imximage
+++ b/doc/README.imximage
@@ -120,7 +120,7 @@ Configuration command line syntax:
DATA 4 0x73FA88a0 0x200
The processor support up to 60 register programming commands for
IMXIMAGE_VERSION 1
-and 121 register programming commands for IMXIMAGE_VERSION 2.
+and 220 register programming commands for IMXIMAGE_VERSION 2.
An error is generated if more commands are found in the configuration file.
3. All commands are optional to program.
--
1.9.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2] README.imximage: Fix the maximum DCD size
In commit 021e79c85371 ("tools: imximage: Fix the maximum DCD size for
mx53/mx6") we have fixed the maximum DCD size for mx53/mx6.
Do the same on the README document for consistency.
Reported-by: Jonas Karlsson
Signed-off-by: Fabio Estevam
---
Changes since v1:
- Fixed a typo in the commit log (mx53/mx53 --> mx53/mx6)
- Added Stefano's Acked-by tag
doc/README.imximage | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/README.imximage b/doc/README.imximage
index dcda200..27d3354 100644
--- a/doc/README.imximage
+++ b/doc/README.imximage
@@ -120,7 +120,7 @@ Configuration command line syntax:
DATA 4 0x73FA88a0 0x200
The processor support up to 60 register programming commands for
IMXIMAGE_VERSION 1
-and 121 register programming commands for IMXIMAGE_VERSION 2.
+and 220 register programming commands for IMXIMAGE_VERSION 2.
An error is generated if more commands are found in the configuration file.
3. All commands are optional to program.
--
1.9.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] commit 83e359adf9f578a58f20daf2e4425a754defac7b breaks mmc
Hi, commit 83e359a (am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT) breaks MMC on some boards. I believe it only breaks if EMMC has no partition on it, so that would point out to a bug on spl env support itself and this has only exposed it. Here's a bisection log anyway: git bisect start # good: [524123a70761110c5cf3ccc5f52f6d4da071b959] Prepare v2014.07 git bisect good 524123a70761110c5cf3ccc5f52f6d4da071b959 # bad: [0b703dbcee7103f07804d0a4328d1593355c4324] patman: Fix detection of git version git bisect bad 0b703dbcee7103f07804d0a4328d1593355c4324 # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic env var for flash layout git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645 # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic env var for flash layout git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645 # good: [04b43f32731c1171877541050bb3f2bfeb100e3d] tools/genboardscfg.py: ignore defconfigs starting with a dot git bisect good 04b43f32731c1171877541050bb3f2bfeb100e3d # bad: [6defdc0b5552ab1af4a66a8abac8196cbb6b9e15] Merge branch 'master' of git://git.denx.de/u-boot-ti git bisect bad 6defdc0b5552ab1af4a66a8abac8196cbb6b9e15 # good: [6af857c50df4e62ec08e51ad73c96f63f1480386] Merge branch 'master' of http://git.denx.de/u-boot-sunxi git bisect good 6af857c50df4e62ec08e51ad73c96f63f1480386 # good: [7f14fb20f895016fb38d30ce71aeb4d441b5bcb8] Merge branch 'zynq' of git://www.denx.de/git/u-boot-microblaze git bisect good 7f14fb20f895016fb38d30ce71aeb4d441b5bcb8 # bad: [61f66fd5a81b97478e9d14326c1059baa6626680] keystone2: use EFUSE_BOOTROM information to configure PLLs git bisect bad 61f66fd5a81b97478e9d14326c1059baa6626680 # bad: [fea9543f1bd1d068a372ef378f624941c25989a8] board/ti/am335x: update configs for parallel NAND git bisect bad fea9543f1bd1d068a372ef378f624941c25989a8 # good: [e017fd61c5a89e32db682d94d8d669df1709edbb] tseries: Set CONFIG_ENV_IS_NOWHERE for SPL+NAND git bisect good e017fd61c5a89e32db682d94d8d669df1709edbb # bad: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT git bisect bad 83e359adf9f578a58f20daf2e4425a754defac7b # good: [00e385325fce36fa13d48091d73b1b3428394b6b] common/Makefile: Consolidate SPL ENV options, correct inclusion git bisect good 00e385325fce36fa13d48091d73b1b3428394b6b # first bad commit: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT Revert that commit also makes it work, btw. On a further dig into this, it looks like when enabling CONFIG_SPL_ENV_SUPPORT, somehow MMC numbering changes and u-boot ends up trying to read environment from a non-formatted EMMC. -- balbi signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] commit 83e359adf9f578a58f20daf2e4425a754defac7b breaks mmc
Hi, On Tue, Sep 09, 2014 at 12:09:02PM -0500, Felipe Balbi wrote: > Hi, > > commit 83e359a (am335x_evm: Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT) > breaks MMC on some boards. I believe it only breaks if EMMC has no > partition on it, so that would point out to a bug on spl env support > itself and this has only exposed it. > > Here's a bisection log anyway: > > git bisect start > # good: [524123a70761110c5cf3ccc5f52f6d4da071b959] Prepare v2014.07 > git bisect good 524123a70761110c5cf3ccc5f52f6d4da071b959 > # bad: [0b703dbcee7103f07804d0a4328d1593355c4324] patman: Fix detection of > git version > git bisect bad 0b703dbcee7103f07804d0a4328d1593355c4324 > # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic > env var for flash layout > git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645 > # good: [63b85adcecdd019f049cbbebf10119cea45d3645] imx: ventana: set dynamic > env var for flash layout > git bisect good 63b85adcecdd019f049cbbebf10119cea45d3645 > # good: [04b43f32731c1171877541050bb3f2bfeb100e3d] tools/genboardscfg.py: > ignore defconfigs starting with a dot > git bisect good 04b43f32731c1171877541050bb3f2bfeb100e3d > # bad: [6defdc0b5552ab1af4a66a8abac8196cbb6b9e15] Merge branch 'master' of > git://git.denx.de/u-boot-ti > git bisect bad 6defdc0b5552ab1af4a66a8abac8196cbb6b9e15 > # good: [6af857c50df4e62ec08e51ad73c96f63f1480386] Merge branch 'master' of > http://git.denx.de/u-boot-sunxi > git bisect good 6af857c50df4e62ec08e51ad73c96f63f1480386 > # good: [7f14fb20f895016fb38d30ce71aeb4d441b5bcb8] Merge branch 'zynq' of > git://www.denx.de/git/u-boot-microblaze > git bisect good 7f14fb20f895016fb38d30ce71aeb4d441b5bcb8 > # bad: [61f66fd5a81b97478e9d14326c1059baa6626680] keystone2: use > EFUSE_BOOTROM information to configure PLLs > git bisect bad 61f66fd5a81b97478e9d14326c1059baa6626680 > # bad: [fea9543f1bd1d068a372ef378f624941c25989a8] board/ti/am335x: update > configs for parallel NAND > git bisect bad fea9543f1bd1d068a372ef378f624941c25989a8 > # good: [e017fd61c5a89e32db682d94d8d669df1709edbb] tseries: Set > CONFIG_ENV_IS_NOWHERE for SPL+NAND > git bisect good e017fd61c5a89e32db682d94d8d669df1709edbb > # bad: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: Enable > CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT > git bisect bad 83e359adf9f578a58f20daf2e4425a754defac7b > # good: [00e385325fce36fa13d48091d73b1b3428394b6b] common/Makefile: > Consolidate SPL ENV options, correct inclusion > git bisect good 00e385325fce36fa13d48091d73b1b3428394b6b > # first bad commit: [83e359adf9f578a58f20daf2e4425a754defac7b] am335x_evm: > Enable CONFIG_SPL_ENV_SUPPORT on EMMC_BOOT > > Revert that commit also makes it work, btw. > > On a further dig into this, it looks like when enabling > CONFIG_SPL_ENV_SUPPORT, somehow MMC numbering changes and u-boot ends up > trying to read environment from a non-formatted EMMC. forgot to mention, this is all on BBB and affects only am335x-based boards, of course. -- balbi signature.asc Description: Digital signature ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/8] Makefile: default to cc for host compiler
Hello Albert, On 09-09-14 16:31, Albert ARIBAUD wrote: On Thu, 31 Jul 2014 19:01:22 +0900, Masahiro Yamada wrote: HOSTCXX = g++ HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer For consistency, HOSTCXX = c++ ? So, Jeroen, what is your pick ? Will you send a v3 7/8, or are you sticking with g++? (or if everyone agrees, I could to the change to v2 7/8 when applying it, and add a comment about it in the commit message.) I did check Masahiro's statement that cpp is actually used in u-boot and it is; make xconfig uses it, if I recall correctly. And as Masahiro suggested I sent it to linux-kbuild mailinglist, but I am in the impression it never arrived, perhaps I need to be subscribed or something... Anyway, Masahiro's suggestion is sound and I am fine you changing it while applying. I tested it on FreeBSD, Xubuntu and Debian. Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 7/8] samsung: Move s5p_goni to use exynos-common config
Hi Przemyslaw,
On 9 September 2014 04:26, Przemyslaw Marczak wrote:
> Hello Simon,
>
>
> On 07/23/2014 02:11 PM, Simon Glass wrote:
>
>> Change this board to use the exynos common config and add a device tree.
>>
>> This also adds a pinmux header file - but it is just a copy of the exynos
>> one so may be incorrect.
>>
>> Signed-off-by: Simon Glass
>> ---
>>
>> arch/arm/dts/Makefile | 1 +
>> arch/arm/dts/s5pc1xx-goni.dts | 21 ++
>> arch/arm/include/asm/arch-s5pc1xx/periph.h | 61
>> ++
>> arch/arm/include/asm/arch-s5pc1xx/pinmux.h | 50
>>
>> drivers/mmc/s5p_sdhci.c| 2 -
>> include/configs/s5p_goni.h | 55
>> +--
>> 6 files changed, 143 insertions(+), 47 deletions(-)
>> create mode 100644 arch/arm/dts/s5pc1xx-goni.dts
>> create mode 100644 arch/arm/include/asm/arch-s5pc1xx/periph.h
>> create mode 100644 arch/arm/include/asm/arch-s5pc1xx/pinmux.h
>>
>> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
>> index 3b760ff..6a6e664 100644
>> --- a/arch/arm/dts/Makefile
>> +++ b/arch/arm/dts/Makefile
>> @@ -1,3 +1,4 @@
>> +dtb-$(CONFIG_S5PC110) += s5pc1xx-goni.dtb
>> dtb-$(CONFIG_EXYNOS4) += exynos4210-origen.dtb \
>> exynos4210-smdkv310.dtb \
>> exynos4210-universal_c210.dtb \
>> diff --git a/arch/arm/dts/s5pc1xx-goni.dts b/arch/arm/dts/s5pc1xx-goni.
>> dts
>> new file mode 100644
>> index 000..c390c8f
>> --- /dev/null
>> +++ b/arch/arm/dts/s5pc1xx-goni.dts
>> @@ -0,0 +1,21 @@
>> +/*
>> + * Samsung's Exynos4210-based SMDKV310 board device tree source
>> + *
>> + * Copyright (c) 2014 Google, Inc
>> + *
>> + * SPDX-License-Identifier:GPL-2.0+
>> + */
>> +
>> +/dts-v1/;
>>
>
> This is a mistake. Exynos4 is different than s5pc1xx(which was later
> called exynos3 and is also called s5pv210(kernel)).
> So the s5pc1xx-goni.dts should include:
> model = "Samsung Goni based on S5PC110";
> compatible = "samsung,goni", "samsung,s5pc110";
>
Thanks for the review.
>
> And the base addresses are different than exynos4. Please look at:
> arch/arm/include/asm/arch-s5pc1xx/cpu.h
>
OK
>
> This will require also a common file for s5pc1xx: s5pc1xx-common.dts.
> Moreover, the S5PC100 and S5PC110 have lot of differences.
>
> Simon, I think that this is a job for goni's maintainer, since you can't
> test it on a hardware.
>
Yes that would be great. To be clear, my intent is to make all these boards
similar so that it is possible to change over the GPIO and serial drivers
to use driver model.
>
> Robert, can you look at this?
>
> +/include/ "exynos4.dtsi"
>> +
>> +/ {
>> + model = "Samsung SMDKV310 on Exynos4210";
>> + compatible = "samsung,smdkv310", "samsung,exynos4210";
>> +
>> + aliases {
>> + serial0 = "/serial@1380";
>> + console = "/serial@1382";
>> + };
>> +
>> +};
>>
>
>
> Best regards,
> --
> Przemyslaw Marczak
> Samsung R&D Institute Poland
> Samsung Electronics
> p.marc...@samsung.com
>
Regards,
Simon
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v7 05/13] tegra: Convert tegra GPIO driver to use driver model
Hi, On 3 September 2014 17:37, Simon Glass wrote: > This is an implementation of GPIOs for Tegra that uses driver model. It has > been tested on trimslice and also using the new iotrace feature. > > The implementation uses a top-level GPIO device (which has no actual > GPIOS). > Under this all the banks are created as separate GPIO devices. > > The GPIOs are named as per the Tegra datasheet/header files: A0..A7, > B0..B7, > ..., Z0..Z7, AA0..AA7, etc. > > Since driver model is not yet available before relocation, or in SPL, a > special function is provided for seaboard's SPL code. > > Signed-off-by: Simon Glass > I've tested this series as much as I can, and in particular on Tegra 20, 30 and 124. Are there any final comments before I pull it into dm/master? I'd like to allow plenty of test time before the release. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v5 14/14] dm: tegra: Enable driver model for serial
Hi, On 4 September 2014 16:27, Simon Glass wrote: > Use driver model for serial ports. > > Since Tegra now uses driver model for serial, adjust the definition of > V_NS16550_CLK so that it is clear that this is only used for SPL. > > Signed-off-by: Simon Glass > --- > > I've tested this series as much as I can, and in particular on Tegra 20, 30 and 124. Are there any final comments before I pull it into dm/master? I'd like to allow plenty of test time before the release. Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/8] Makefile: default to cc for host compiler
Hi Jeroen, On Tue, 09 Sep 2014 19:34:44 +0200, Jeroen Hofstee wrote: > Hello Albert, > > On 09-09-14 16:31, Albert ARIBAUD wrote: > > On Thu, 31 Jul 2014 19:01:22 +0900, Masahiro Yamada > > wrote: > > > >>> HOSTCXX = g++ > >>> HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer > >> For consistency, > >> > >> HOSTCXX = c++ > >> > >> ? > > So, Jeroen, what is your pick ? Will you send a v3 7/8, or are you > > sticking with g++? > > > > (or if everyone agrees, I could to the change to v2 7/8 when applying > > it, and add a comment about it in the commit message.) > > I did check Masahiro's statement that cpp is actually used in u-boot > and it is; make xconfig uses it, if I recall correctly. And as Masahiro > suggested I sent it to linux-kbuild mailinglist, but I am in the impression > it never arrived, perhaps I need to be subscribed or something... > > Anyway, Masahiro's suggestion is sound and I am fine you changing > it while applying. I tested it on FreeBSD, Xubuntu and Debian. I've tried building rpi_b as per the README, but I keep getting /usr/bin/as: unrecognized option '-mfloat-abi=soft' clang: error: assembler command failed with exit code 1 (use -v to see invocation) Shouldn't rpi_b build properly since it is the one given as an example for Debian-based building? > Regards, > Jeroen Amicalement, -- Albert. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH 1/2] arm: Make reset position-independent
Hi Albert, On Fri, Sep 5, 2014 at 3:41 PM, Magnus Lilja wrote: > Hi > > On 3 September 2014 23:32, Benoît Thébaudeau > wrote: >> Some boards, like mx31pdk and tx25, require the beginning of the SPL >> code to be position-independent. For these two boards, this is because >> they use the i.MX external NAND boot, which starts by executing the >> first NAND Flash page from the NFC page buffer. The SPL then needs to >> copy itself to its actual link address in order to free the NFC page >> buffer and use it to load the non-SPL image from Flash before running >> it. This means that the SPL runtime address differs from its link >> address between the reset and the initial copy performed by >> board_init_f(), so this part of the SPL binary must be >> position-independent. >> >> This requirement was broken by commit 41623c9 'arm: move exception >> handling out of start.S files', which used an absolute address to branch >> to the reset routine. This new commit restores the original behavior, >> which just performed a relative branch. This fixes the boot of mx31pdk >> and tx25. >> >> Signed-off-by: Benoît Thébaudeau >> Reported-by: Helmut Raiger >> Cc: Albert Aribaud >> Cc: Magnus Lilja >> Cc: John Rigby >> --- > > Tested-by: Magnus Lilja Should this one go through your tree? ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v2 7/8] Makefile: default to cc for host compiler
Hi, On 09-09-14 21:59, Albert ARIBAUD wrote: Hi Jeroen, On Tue, 09 Sep 2014 19:34:44 +0200, Jeroen Hofstee wrote: Hello Albert, On 09-09-14 16:31, Albert ARIBAUD wrote: On Thu, 31 Jul 2014 19:01:22 +0900, Masahiro Yamada wrote: HOSTCXX = g++ HOSTCFLAGS = -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer For consistency, HOSTCXX = c++ ? So, Jeroen, what is your pick ? Will you send a v3 7/8, or are you sticking with g++? (or if everyone agrees, I could to the change to v2 7/8 when applying it, and add a comment about it in the commit message.) I did check Masahiro's statement that cpp is actually used in u-boot and it is; make xconfig uses it, if I recall correctly. And as Masahiro suggested I sent it to linux-kbuild mailinglist, but I am in the impression it never arrived, perhaps I need to be subscribed or something... Anyway, Masahiro's suggestion is sound and I am fine you changing it while applying. I tested it on FreeBSD, Xubuntu and Debian. I've tried building rpi_b as per the README, but I keep getting /usr/bin/as: unrecognized option '-mfloat-abi=soft' clang: error: assembler command failed with exit code 1 (use -v to see invocation) Shouldn't rpi_b build properly since it is the one given as an example for Debian-based building? As discussed with Albert there seems to be some Debian / Ubuntu specific changes to the package causing trouble. Checking out the llvm 3.5 branch works fine, using the package fails with above mentioned error. No idea why at the moment, patches are fine... Regards, Jeroen ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Please pull u-boot-x86.git branch 'buildman'
Hi Tom, Here are all the pending changes for patman/buildman. Mostly these add tests but there are also several fixes, some found by the tests. I believe it is worth applying these now, to make it easier to find other issues that might come up. Branch is 'buildman'. The following changes since commit 0b703dbcee7103f07804d0a4328d1593355c4324: patman: Fix detection of git version (2014-09-05 13:40:43 -0600) are available in the git repository at: git://git.denx.de/u-boot-x86.git for you to fetch changes up to d0ea61d9caf85e4285d5c2da508db9fac70e4aba: buildman: fix typos of --dry-run help message (2014-09-09 16:48:06 -0600) Masahiro Yamada (1): buildman: fix typos of --dry-run help message Simon Glass (18): patman: Add a way of recording terminal output for testing buildman: Send builder output through a function for testing buildman: Enhance basic test to check summary output patman: RunPipe() should not pipe stdout/stderr unless asked buildman: Move the command line code into its own file buildman: Move full help code into the control module patman: Provide a way to intercept commands for testing buildman: Add a functional test buildman: Set up bsettings outside the control module buildman: Avoid looking at config file or toolchains in tests buildman: Allow tests to have their own boards buildman: Correct counting of build failures on retry buildman: Provide an internal option to clean the outpur dir patman: Start with a clean series when needed buildman: Add additional functional tests buildman: Expand output test to cover directory prefixes buildman: Permit branch names with an embedded '/' buildman: Ignore conflicting tags Thierry Reding (1): buildman: Create parent directories as necessary Vadim Bendebury (1): patman: make run results better visible tools/buildman/bsettings.py | 15 ++- tools/buildman/builder.py | 60 +- tools/buildman/builderthread.py | 22 ++-- tools/buildman/buildman.py | 98 ++-- tools/buildman/cmdline.py | 85 ++ tools/buildman/control.py | 73 tools/buildman/func_test.py | 519 +++ tools/buildman/test.py | 153 +++-- tools/buildman/toolchain.py | 4 +- tools/patman/command.py | 22 tools/patman/gitutil.py | 8 +- tools/patman/patchstream.py | 6 +- tools/patman/patman.py | 7 +- tools/patman/terminal.py| 72 14 files changed, 972 insertions(+), 172 deletions(-) create mode 100644 tools/buildman/cmdline.py create mode 100644 tools/buildman/func_test.py Regards, Simon ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] relocation problem on powerpc
Hi Jocke On Wed, Sep 10, 2014 at 1:20 AM, Joakim Tjernlund wrote: > Joakim Tjernlund/Transmode wrote on 2014/09/09 14:30:13: > >> From: Joakim Tjernlund/Transmode >> To: >> Cc: Chris Packham , u-boot > >> Date: 2014/09/09 14:30 >> Subject: Re: [U-Boot] relocation problem on powerpc >> >> >> > > Here's some more info from a build without any of my modifications. >> > > >> > > $ git describe >> > > v2014.10-rc2-12-g0b703db >> > > >> > > $ powerpc-e500-linux-gnu-gcc --version >> > > powerpc-e500-linux-gnu-gcc (Gentoo 4.6.3-r1 p1.9, pie-0.5.2) 4.6.3 >> > > >> > > $ grep '_GOT2_TABLE_\|_GLOBAL_OFFSET_TABLE_\|__got2_entries' > u-boot.map >> > > 0xeffb5100_GOT2_TABLE_ = . >> > > 0xeffb7d38_GLOBAL_OFFSET_TABLE_ >> > > 0xeffb7d48PROVIDE (_GLOBAL_OFFSET_TABLE_, > (. + 0x4)) >> > > 0x0b0d__got2_entries = >> > > (((_GLOBAL_OFFSET_TABLE_ - _GOT2_TABLE_) >> 0x2) - 0x1) >> > > >> > > $ gdb-multiarch u-boot >> > > (gdb) disassemble /r 0xeffb5100,0xeffb7d48 >> > > Dump of assembler code from 0xeffb5100 to 0xeffb7d48: >> > > 0xeffb5100 <_GOT2_TABLE_+0>: ef fb 51 00 .long 0xeffb5100 >> > > 0xeffb5104 <_GOT2_TABLE_+4>: ef fb 7d 44 dtstsf cr7,f27,f15 >> > > 0xeffb5108 <_GOT2_TABLE_+8>: ef f4 00 00 .long 0xeff4 >> > > 0xeffb510c <_GOT2_TABLE_+12>:ef f4 01 00 .long > 0xeff40100 >> > > >> > > 0xeffb7d30 <_GOT2_TABLE_+11312>: ef f6 6e 74 .long > 0xeff66e74 >> > > 0xeffb7d34 <_GOT2_TABLE_+11316>: f0 00 00 d0 psq_st > f0,208(r0),0,0 >> > > 0xeffb7d38 <_GLOBAL_OFFSET_TABLE_+0>:00 00 00 00 .long > 0x0 >> > > 0xeffb7d3c <_GLOBAL_OFFSET_TABLE_+4>:00 00 00 00 .long > 0x0 >> > > 0xeffb7d40 <_GLOBAL_OFFSET_TABLE_+8>:00 00 00 00 .long > 0x0 >> > > 0xeffb7d44 <_FIXUP_TABLE_+0>:ef fb 99 d4 .long > 0xeffb99d4 >> > > >> > > So no there is no brlr at the end of the table. >> > >> > There should be, see > http://www.freescale.com/files/32bit/doc/ref_manual/E500ABIUG.pdf, chap > 4.3.2 Yep that's pretty unambiguous "The word at _GLOBAL_OFFSET_TABLE_[-1] shall contain a blrl instruction". No "should", "may" or "can" in sight. >> >> So I did a quick test too with my copy of u-boot: >> (gdb) disass /r 0xeffa0a48,0xeffa0a68 >>Dump of assembler code from 0xeffa0a48 to 0xeffa0a68: >>0xeffa0a48 <_GOT2_TABLE_+9800>: f0 00 00 dc .long 0xf0dc >>0xeffa0a4c <_GOT2_TABLE_+9804>: ef f6 29 48 .long 0xeff62948 >>0xeffa0a50 <_GOT2_TABLE_+9808>: f0 00 00 e0 .long 0xf0e0 >>0xeffa0a54 <_GOT2_TABLE_+9812>: 4e 80 00 21 blrl >> ^ >>0xeffa0a58 <_GLOBAL_OFFSET_TABLE_+0>: 00 00 00 00 .long 0x0 >>0xeffa0a5c <_GLOBAL_OFFSET_TABLE_+4>: 00 00 00 00 .long 0x0 >>0xeffa0a60 <_GLOBAL_OFFSET_TABLE_+8>: 00 00 00 00 .long 0x0 >>0xeffa0a64 <_FIXUP_TABLE_+0>: ef fa 23 1c .long 0xeffa231c > >> $ powerpc-softfloat_4.5.3-linux-gnu-ld --version >> GNU ld (GNU Binutils) 2.21.1 >> >> I don't know it this is tool(ld) problem or if something in u-boot's > build env. Try dropping >> --gc-sections, see if that changes anything, or add --bss-plt or similar > > --bss-plt seems to be the answer: > http://lists.denx.de/pipermail/u-boot/2014-February/173134.html > > Jocke > Same question as that original thread '--bss-plt' or '-mbss-plt'? The former works (I'll send a patch through) but I can only find documentation for the latter. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [RFC PATCH v1] powerpc: Fix off-by-one error in relocation
Hi All, On Tue, Sep 9, 2014 at 12:22 PM, Chris Packham wrote: > When the got2 pointers were adjusted after relocation the last entry was > missed. For most builds was something innocuous and there was no > observable problem but at least for the P2041RDB board this ended up > being NetArpWaitTimerStart which caused the ARP packets to timeout > immediately. > > On Mon, Sep 8, 2014 at 9:04 PM, > Joakim Tjernlund wrote: >> >> The relevant code that uses >> __got2_entries is in start.S: >> >> in_ram: >> >> /* >> * Relocation Function, r12 point to got2+0x8000 >> * >> * Adjust got2 pointers, no need to check for 0, this code >> * already puts a few entries in the table. >> */ >> li r0,__got2_entries@sectoff@l >> la r3,GOT(_GOT2_TABLE_) >> lwz r11,GOT(_GOT2_TABLE_) >> mtctr r0 >> sub r11,r3,r11 >> addir3,r3,-4 >> 1: lwzur0,4(r3) >> cmpwi r0,0 >> beq-2f >> add r0,r0,r11 >> stw r0,0(r3) >> 2: bdnz1b >> >> bdnz does decrement then test for zero so __got2_entries should hold the >> number of entries to relocate. > > But __got2_entries is 1 less than it should be. Fix this by removing the > -1 from the __got2_entries calculation. > > Cc: Joakim Tjernlund > Signed-off-by: Chris Packham > --- > So here's a patch that addresses the issue. I've tested it on a P2041RDB > (mpc85xx/QorIq). I am aware that I'm touching a lot of platforms so I > need some help testing. > > I've deliberately left off the following board specific files which at a > glance have the same off-by-one error: > Sorry for the noise but Jocke has pointed me in the direction of a better fix. I'll submit that as a new patch. This one can be abandoned. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [RFC PATCH v1] powerpc: add --bss-plt to LDFLAGS
With some versions of gcc (that we know of 4.6.3 and 4.8.2 are affected) it is necessary to specify --bss-plt to get the final blrl in the _GOT2_TABLE_. Without this the last symbol does not get it's address relocated. For the P2041RDB board this ended up being NetArpWaitTimerStart which caused the ARP packets to timeout immediately. Helped-by: Joakim Tjernlund Signed-off-by: Chris Packham --- Technically this is v2 of http://lists.denx.de/pipermail/u-boot/2014-September/188365.html but the solution is so different that I'm treating it as a new patch series. arch/powerpc/config.mk |1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/config.mk b/arch/powerpc/config.mk index 6329b6c..fec02f2 100644 --- a/arch/powerpc/config.mk +++ b/arch/powerpc/config.mk @@ -11,6 +11,7 @@ endif CONFIG_STANDALONE_LOAD_ADDR ?= 0x4 LDFLAGS_FINAL += --gc-sections +LDFLAGS_FINAL += --bss-plt PLATFORM_RELFLAGS += -fpic -mrelocatable -ffunction-sections -fdata-sections \ -meabi PLATFORM_CPPFLAGS += -D__powerpc__ -ffixed-r2 -- 1.7.9.5 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH] imx: imx6q/dlsabreauto: Add PMIC Pfuze100 support
Initialize the Pfuze100 at board late init.
Signed-off-by: Ye.Li
---
board/freescale/mx6qsabreauto/mx6qsabreauto.c | 52 -
include/configs/mx6qsabreauto.h |6 +++
2 files changed, 57 insertions(+), 1 deletions(-)
diff --git a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
index bfb9b6a..76b024b 100644
--- a/board/freescale/mx6qsabreauto/mx6qsabreauto.c
+++ b/board/freescale/mx6qsabreauto/mx6qsabreauto.c
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2012 Freescale Semiconductor, Inc.
+ * Copyright (C) 2012-2014 Freescale Semiconductor, Inc.
*
* Author: Fabio Estevam
*
@@ -23,6 +23,8 @@
#include
#include
#include
+#include
+#include
DECLARE_GLOBAL_DATA_PTR;
@@ -43,6 +45,8 @@ DECLARE_GLOBAL_DATA_PTR;
#define PC MUX_PAD_CTRL(I2C_PAD_CTRL)
+#define I2C_PMIC 1
+
int dram_init(void)
{
gd->ram_size = (phys_size_t)CONFIG_DDR_MB * 1024 * 1024;
@@ -259,6 +263,51 @@ int board_init(void)
return 0;
}
+static int pfuze_init(void)
+{
+ struct pmic *p;
+ int ret;
+ unsigned int reg;
+
+ ret = power_pfuze100_init(I2C_PMIC);
+ if (ret)
+ return ret;
+
+ p = pmic_get("PFUZE100");
+ ret = pmic_probe(p);
+ if (ret)
+ return ret;
+
+ pmic_reg_read(p, PFUZE100_DEVICEID, ®);
+ printf("PMIC: PFUZE100 ID=0x%02x\n", reg);
+
+ /* Set SW1AB stanby volage to 0.975V */
+ pmic_reg_read(p, PFUZE100_SW1ABSTBY, ®);
+ reg &= ~0x3f;
+ reg |= 0x1b;
+ pmic_reg_write(p, PFUZE100_SW1ABSTBY, reg);
+
+ /* Set SW1AB/VDDARM step ramp up time from 16us to 4us/25mV */
+ pmic_reg_read(p, PUZE_100_SW1ABCONF, ®);
+ reg &= ~0xc0;
+ reg |= 0x40;
+ pmic_reg_write(p, PUZE_100_SW1ABCONF, reg);
+
+ /* Set SW1C standby voltage to 0.975V */
+ pmic_reg_read(p, PFUZE100_SW1CSTBY, ®);
+ reg &= ~0x3f;
+ reg |= 0x1b;
+ pmic_reg_write(p, PFUZE100_SW1CSTBY, reg);
+
+ /* Set SW1C/VDDSOC step ramp up time from 16us to 4us/25mV */
+ pmic_reg_read(p, PFUZE100_SW1CCONF, ®);
+ reg &= ~0xc0;
+ reg |= 0x40;
+ pmic_reg_write(p, PFUZE100_SW1CCONF, reg);
+
+ return 0;
+}
+
#ifdef CONFIG_CMD_BMODE
static const struct boot_mode board_boot_modes[] = {
/* 4 bit bus width */
@@ -272,6 +321,7 @@ int board_late_init(void)
#ifdef CONFIG_CMD_BMODE
add_board_boot_modes(board_boot_modes);
#endif
+ pfuze_init();
return 0;
}
diff --git a/include/configs/mx6qsabreauto.h b/include/configs/mx6qsabreauto.h
index e8580e6..d82563f 100644
--- a/include/configs/mx6qsabreauto.h
+++ b/include/configs/mx6qsabreauto.h
@@ -40,6 +40,12 @@
#define CONFIG_SYS_I2C_MXC
#define CONFIG_SYS_I2C_SPEED 10
+/* PMIC */
+#define CONFIG_POWER
+#define CONFIG_POWER_I2C
+#define CONFIG_POWER_PFUZE100
+#define CONFIG_POWER_PFUZE100_I2C_ADDR 0x08
+
#define CONFIG_OF_SEPARATE
#define CONFIG_DEFAULT_DEVICE_TREE imx6q-sabreauto
--
1.7.4.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] Policy for porting drivers from Linux
Hi List, This has probably come up before but I did a quick search and couldn't find anything. If it exists please point me at it. So at $dayjob we're looking at adding support for the BCM5718 Ethernet chipset to u-boot. We've actually got things working and I'm looking at preparing the code for submission. Naturally I'm getting a bunch of checkpatch errors that I need to work through. And I wonder how this type of porting _should_ be done? Some of the checkpatch errors things that exist in the upstream kernel. Others are because of subtle differences in the internal apis between linux an u-boot. For example pci_read_config_word() under u-boot takes a pci_dev_t (usually these are declared deviceno) as it's first argument while under linux it takes a struct pci_dev* (usually called pdev). Because of the difference in naming there are a bunch of lines >80 chars. Obviously I could fix this by changing deviceno to pdev but I actually think that'd be more confusing. Then there's also code that won't be used under u-boot (e.g. firmware loading, smp, locking). Some of this we've deleted other parts we've #if 0'd out. This is mostly because 2 poeple were doing the work and made arbitrary choices. I personally think the latter is better because it makes taking fixes from Linux easier but is that something we actually should care about? I think I've seen one instance on this mailing list of taking the Linux code verbatim as patch 1/2 then the porting/cleanup as patch 2/2. This seems like a good idea but it may still lose the ability to take fixes. Any comments/suggestions? Thanks, Chris ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
Re: [U-Boot] [PATCH v1 1/2] usb: dfu: add config option to use in dfu mode fullspeed only
Hello Bin Liu, Am 09.09.2014 16:42, schrieb Bin Liu: Heiko, On 09/09/2014 09:37 AM, Heiko Schocher wrote: Hello Bin Liu, Am 09.09.2014 16:09, schrieb Bin Liu: Heiko, On 09/09/2014 07:37 AM, Heiko Schocher wrote: add the new config option CONFIG_DFU_FULLSPEED. With this option enabled, DFU uses fullspeed only. Can we not introduce the new config option but check the gadget driver speed in runtime as what the ether gadget driver does? I don't want two config options (CONFIG_USB_GADGET_DUALSPEED and CONFIG_DFU_FULLSPEED) to control one feature, as in your patch 2/2. Hmm.. I am not sure, if I understand you correct. I could use CONFIG_USB_GADGET_DUALSPEED instead the new config option for setting "config->fullspeed = 1;" in g_dnl_config_register() If you mean this, yes, thats would be a good change... No, I did not mean this build time macro, but was thinking you can check g->speed at the same place in runtime. I think you can refer to ether.c, which supports full-speed but does not use any macro. Yep, you are right, I can get rid completely of this new define! The speed selection is done in drivers/usb/gadget/composite.c I removed it, do some tests, and send a v2. Thanks! bye, Heiko -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 2/2] arm: am335x: siemens board use in DFU mode fullspeed only
Siemens boards are now using DFU in fullspeed only. For this CONFIG_USB_GADGET_DUALSPEED is undefined. Signed-off-by: Heiko Schocher Cc: Tom Rini Cc: Lukasz Majewski Cc: Marek Vasut Cc: Liu Bin Cc: Lukas Stockmann --- On the siemens board this is needed because of a protection circuit. The device is 24V AC powered, if someone uses a non galvanically isolated transformer and misswires it, it could burn down the USB host. That's why we have a protection on the USB side which limits the speed to 12Mbit/sec. - changes for v2: - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu suggested. --- include/configs/siemens-am33x-common.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/configs/siemens-am33x-common.h b/include/configs/siemens-am33x-common.h index b8fb77e..4dcd690 100644 --- a/include/configs/siemens-am33x-common.h +++ b/include/configs/siemens-am33x-common.h @@ -233,7 +233,7 @@ #define CONFIG_MUSB_GADGET #define CONFIG_MUSB_PIO_ONLY #define CONFIG_MUSB_DISABLE_BULK_COMBINE_SPLIT -#define CONFIG_USB_GADGET_DUALSPEED +#undef CONFIG_USB_GADGET_DUALSPEED #define CONFIG_USB_GADGET_VBUS_DRAW2 #define CONFIG_MUSB_HOST -- 1.8.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 1/2] usb: dfu: add fullspeed support for DFU
DFU now can use also fullspeed.
Signed-off-by: Heiko Schocher
Cc: Tom Rini
Cc: Lukasz Majewski
Cc: Marek Vasut
Cc: Liu Bin
Cc: Lukas Stockmann
---
- changes for v2:
- get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu
suggested.
---
drivers/usb/gadget/f_dfu.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/gadget/f_dfu.c b/drivers/usb/gadget/f_dfu.c
index 1145aab..dfa9f3b 100644
--- a/drivers/usb/gadget/f_dfu.c
+++ b/drivers/usb/gadget/f_dfu.c
@@ -238,6 +238,7 @@ static inline void to_dfu_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = dfu_strings;
f_dfu->usb_function.hs_descriptors = f_dfu->function;
+ f_dfu->usb_function.descriptors = f_dfu->function;
f_dfu->dfu_state = DFU_STATE_dfuIDLE;
}
@@ -245,6 +246,7 @@ static inline void to_runtime_mode(struct f_dfu *f_dfu)
{
f_dfu->usb_function.strings = NULL;
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
}
static int handle_upload(struct usb_request *req, u16 len)
@@ -809,6 +811,7 @@ static int dfu_bind_config(struct usb_configuration *c)
return -ENOMEM;
f_dfu->usb_function.name = "dfu";
f_dfu->usb_function.hs_descriptors = dfu_runtime_descs;
+ f_dfu->usb_function.descriptors = dfu_runtime_descs;
f_dfu->usb_function.bind = dfu_bind;
f_dfu->usb_function.unbind = dfu_unbind;
f_dfu->usb_function.set_alt = dfu_set_alt;
--
1.8.3.1
___
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
[U-Boot] [PATCH v2 0/2] usb: dfu: am335x: allow dfu in fullspeed mode only
This patchserie allows fullspeed for DFU, and configures the siemens boards to use fullspeed only. - changes for v2: - get rid of config option CONFIG_DFU_FULLSPEED as Bin Liu suggested. Cc: Tom Rini Cc: Lukasz Majewski Cc: Marek Vasut Cc: Liu Bin Cc: Lukas Stockmann Heiko Schocher (2): usb: dfu: add fullspeed support for DFU arm: am335x: siemens board use in DFU mode fullspeed only drivers/usb/gadget/f_dfu.c | 3 +++ include/configs/siemens-am33x-common.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) -- 1.8.3.1 ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
