[Bug 1612638] Re: [MIR] ubuntu-push
Override component to main ubuntu-push 0.68+16.10.20160825.4-0ubuntu1 in yakkety: universe/net -> main golang-ubuntu-push-dev 0.68+16.10.20160825.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160825.4-0ubuntu1 in yakkety arm64: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160825.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160825.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160825.4-0ubuntu1 in yakkety powerpc: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160825.4-0ubuntu1 in yakkety ppc64el: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160825.4-0ubuntu1 in yakkety s390x: universe/net/optional/100% -> main ubuntu-push-autopilot 0.68+16.10.20160825.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main ubuntu-push-autopilot 0.68+16.10.20160825.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main ubuntu-push-autopilot 0.68+16.10.20160825.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160825.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160825.4-0ubuntu1 in yakkety arm64: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160825.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160825.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160825.4-0ubuntu1 in yakkety powerpc: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160825.4-0ubuntu1 in yakkety ppc64el: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160825.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160825.4-0ubuntu1 in yakkety arm64: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160825.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160825.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160825.4-0ubuntu1 in yakkety powerpc: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160825.4-0ubuntu1 in yakkety ppc64el: universe/net/optional/100% -> main 23 publications overridden. ** Changed in: ubuntu-push (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1612638 Title: [MIR] ubuntu-push To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1612638] Re: [MIR] ubuntu-push
Nothing that depends on ubuntu-push has yet been seeded in main. Re- demoting until this is done. ** Changed in: ubuntu-push (Ubuntu) Status: Fix Released => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1612638 Title: [MIR] ubuntu-push To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1612638] Re: [MIR] ubuntu-push
Override component to main ubuntu-push 0.68+16.10.20160718.4-0ubuntu1 in yakkety: universe/net -> main golang-ubuntu-push-dev 0.68+16.10.20160718.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160718.4-0ubuntu1 in yakkety arm64: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160718.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160718.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160718.4-0ubuntu1 in yakkety powerpc: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160718.4-0ubuntu1 in yakkety ppc64el: universe/net/optional/100% -> main golang-ubuntu-push-dev 0.68+16.10.20160718.4-0ubuntu1 in yakkety s390x: universe/net/optional/100% -> main ubuntu-push-autopilot 0.68+16.10.20160718.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main ubuntu-push-autopilot 0.68+16.10.20160718.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main ubuntu-push-autopilot 0.68+16.10.20160718.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160718.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160718.4-0ubuntu1 in yakkety arm64: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160718.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160718.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160718.4-0ubuntu1 in yakkety powerpc: universe/net/optional/100% -> main ubuntu-push-client 0.68+16.10.20160718.4-0ubuntu1 in yakkety ppc64el: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160718.4-0ubuntu1 in yakkety amd64: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160718.4-0ubuntu1 in yakkety arm64: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160718.4-0ubuntu1 in yakkety armhf: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160718.4-0ubuntu1 in yakkety i386: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160718.4-0ubuntu1 in yakkety powerpc: universe/net/optional/100% -> main ubuntu-push-dev-server 0.68+16.10.20160718.4-0ubuntu1 in yakkety ppc64el: universe/net/optional/100% -> main 23 publications overridden. ** Changed in: ubuntu-push (Ubuntu) Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1612638 Title: [MIR] ubuntu-push To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1612638] Re: [MIR] ubuntu-push
OK, with a bug subscriber, this is fine. Please look into enabling all the tests if possible (and addressing the other nits). Thanks! ** Changed in: ubuntu-push (Ubuntu) Status: Incomplete => Fix Committed -- You received this bug notification because you are a member of Ubuntu Bugs, which is subscribed to Ubuntu. https://bugs.launchpad.net/bugs/1612638 Title: [MIR] ubuntu-push To manage notifications about this bug go to: https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions -- ubuntu-bugs mailing list ubuntu-bugs@lists.ubuntu.com https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1612638] Re: [MIR] ubuntu-push
> Needs a proper team LP bug subscriber.
Will subscribe phablet-team.
> acceptance and http13client tests are skipped during debuild. Why? Do the
> http tests actually try to hit the network, instead of setting up a mock http
> server?
Why acceptance is skipped I don't know, I'll have to refer you to John and
Samuele. Why the http13client test even exist, is due to the fact that the 1.2
client was too buggy, so 1.3 was backported, which included the tests. I can,
when time, check out if we still run 1.2 anywhere (I fear we do).
> What's the story with bug 1475612, are we ftbfs in some cases?
I've requested information from the reporter, but I haven't seen a ftbfs like
that.
> There are a lot of warnings during test runs. Presumably ignorable, but it
> would be hard to notice something that wasn't ignorable among all the chaff.
It's super hard, will see if there's an easy fix to this.
> "${misc:Depends}" should be added to ubuntu-push-autopilot's Depends. It's
> empty now, so it's not a big deal. But for cleanliness and in case in the
> future it isn't empty...
Ack.
> This is an Ubuntu-centric package and we're not worried about being in sync
> with Debian, so I'm not going to block on this, but the -dev package name is
> wrong. According to Debian Go packaging guidelines [1], it should be
> golang-launchpad-ubuntu-push-dev. (i.e. we're currently missing the
> 'launchpad').
Okay, will change.
> You can't currently debuild twice in a row because the clean target doesn't
> properly clean signing-helper/. It might help if you changed the build
> override to run cmake into a special build dir and installed the signing
> helper from that dir in ubuntu-push-client.install. Then add a clean override
> to get rid of that build dir.
Right, that seemed hacky to me too, so will take a look at improving that.
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1612638
Title:
[MIR] ubuntu-push
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
[Bug 1612638] Re: [MIR] ubuntu-push
Blockers:
- Needs a proper team LP bug subscriber.
Questions:
- acceptance and http13client tests are skipped during debuild. Why?
Do the http tests actually try to hit the network, instead of setting up
a mock http server?
- What's the story with bug 1475612, are we ftbfs in some cases?
Non blocking notes:
- There are a lot of warnings during test runs. Presumably ignorable,
but it would be hard to notice something that wasn't ignorable among all
the chaff.
- "DEB_BUILD_OPTIONS := nocheck" in debian/rules doesn't do anything,
because the given override_dh_auto_test rules doesn't look for nocheck,
it only looks at testskip_architectures. I suspect that line can be
removed.
- "${misc:Depends}" should be added to ubuntu-push-autopilot's Depends.
It's empty now, so it's not a big deal. But for cleanliness and in case
in the future it isn't empty...
- This is an Ubuntu-centric package and we're not worried about being in
sync with Debian, so I'm not going to block on this, but the -dev
package name is wrong. According to Debian Go packaging guidelines [1],
it should be golang-launchpad-ubuntu-push-dev. (i.e. we're currently
missing the 'launchpad').
- This will need a security look at some point before the LTS, but the
security team doesn't want to block this MIR on that.
- You can't currently debuild twice in a row because the clean target
doesn't properly clean signing-helper/. It might help if you changed
the build override to run cmake into a special build dir and installed
the signing helper from that dir in ubuntu-push-client.install. Then
add a clean override to get rid of that build dir.
[1] http://pkg-go.alioth.debian.org/packaging.html
Answers:
- You weren't sure about debconf. It's just a system that some
packages use to ask a user to make a choice during package install (or
upgrade). They are generally something we try to avoid, since it's a
bad user experience. Most packages don't have them.
- You weren't sure about debian/watch. It's a file that some packages
have that describe where upstream tarballs are. That way, a package
developer can use "uscan" to see if there's a new update for the
package. And so can automated tools. Mostly useful when you a
packaging a separate upstream rather than like this package, where we
are the upstream.
** Changed in: ubuntu-push (Ubuntu)
Status: New => Incomplete
--
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1612638
Title:
[MIR] ubuntu-push
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ubuntu-push/+bug/1612638/+subscriptions
--
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs
