[Bug 1638329] Re: Improve qemu message when SMT != off

[Launchpad Bug Tracker]

This bug was fixed in the package qemu - 1:2.6.1+dfsg-0ubuntu8

---
qemu (1:2.6.1+dfsg-0ubuntu8) zesty; urgency=medium

  [ Breno Leitao ]
  * d/qemu-kvm-init, d/kvm.powerpc: Adding a check SMT on ppc64el (LP: #1638329)

 -- Christian Ehrhardt   Thu, 01 Dec
2016 13:44:33 +0100

** Changed in: qemu (Ubuntu)
   Status: Confirmed => Fix Released

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[ChristianEhrhardt]

Ok, added the bug to be closed by LP once it migrated into zesty properly.
I tested things on amd64 as I had no ppc around, but that was done by you.
So I have good expectations of this upload.

Thank you for your contribution on this Breno!

That said - Uploaded into zesty
(https://launchpad.net/ubuntu/+source/qemu/1:2.6.1+dfsg-0ubuntu8), as
usual we have to wait for official build and autopkgtest tests now.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[Breno Leitão]

Hi Christian,

> let me know if this shall become your upload?

Yes, it sounds much better now. Thanks for your help, and we can proceed
with this new patch.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[ChristianEhrhardt]

Thanks for the update Breno,

I like it now:
- all I referred to is fixed.
- The changes are only to Ubuntu Delta (kvm wrapper and qemu-kvm-init are 
current Delta anyway);
  so no extra need to sync (other than our efforts to sync anyway)
- changes are local to only ppc code (so nearly no chance to affect others in a 
bad way)
- no bad effect on the service anymore
- the new dependency to powerpc-utils is local to qemu-system-ppc for now

Remaining comments on further review:
- Dependencies: the init script is part of qemu-system-common which can be 
installed without 
  qemu-system-ppc (for not much use cases I think, but possible). That means 
that would need the  
  new dependency as well to be sure we are not having an init script which runs 
into "program not 
  found" issues.
- the kvm wrapper is part of qemu-kvm package which already has a dependency to 
qemu-system-ppc, 
  but still this might change, so I'd rather add the dependency there. This is 
a bit trickier, as 
  the package exists for powerpc and ppc64el, but powerpc-utils does not exist 
for the former.   
  Yet your usage of the tool is safe behind a check to uname -m == ppc64*.
  Due to that we "only" have to move the Dependency to qemu-kvm instead of 
qemu-system-ppc.
- the use of logger in the kvm wrapper is already covered by the lsb-base 
depend which is auto-added
- you also had some whitespace damage in the init script (trailing whitespace)
- double spaces on the message
- the Changelog did not mention the kvm wrapper

I fixed all those issues up for you and prepared an upload as I'd be
sponsoring it given your ack.

Please check out the debdiff attached here and the ppa at
https://launchpad.net/~paelzer/+archive/ubuntu/bug-1638329-qemu-smt-
messaging and let me know if this shall become your upload?

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[ChristianEhrhardt]

Please review the debdiff if the fixups I made for you are ok.

** Patch added: "debdiff of a fixed up version for the ppa"
   
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+attachment/4785752/+files/qemu_kvm_ppc64_smt-v3.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[Breno Leitão]

** Information type changed from Public Security to Public

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[Breno Leitão]

** Information type changed from Public to Public Security

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[Ubuntu Foundations Team Bug Bot]

The attachment "qemu_kvm_ppc64_smt.debdiff" seems to be a debdiff.  The
ubuntu-sponsors team has been subscribed to the bug report so that they
can review and hopefully sponsor the debdiff.  If the attachment isn't a
patch, please remove the "patch" flag from the attachment, remove the
"patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe
the team.

[This is an automated message performed by a Launchpad user owned by
~brian-murray, for any issue please contact him.]

** Tags added: patch

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[Breno Leitão]

Hi Christian,

Thanks for the feedback, here is the version 2 of the patch. Let me know
if it is better now.


** Patch added: "qemu_kvm_ppc64_smt.debdiff"
   
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+attachment/4784713/+files/qemu_kvm_ppc64_smt.debdiff

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[ChristianEhrhardt]

Hi,
all changes are to the Ubuntu only bits - so that part is ok until we merge and 
reduce further Delta.

Reviewing your latest diff I don't like that the system service should fail if 
SMT is not set.
Especially since it exits before making any of its usual adjustments which is 
as TL;DR to apply anything in /etc/default/qemu-kvm

If one on power would run that, see the service failing, fix up SMT at
runtime he could start kvm guests but not have the config applied e.g.
ksm config and hugepage checks.

That said what would you think of chaning the init script portion of this to 
something like this for the message:
  logger -t qemu-kvm "Error: You must disable SMT if you want to run QEMU/KVM 
on ppc64le  archtecture"
  logger -t qemu-kvm "In order to disable SMT, run: # ppc64_cpu --smt=off"!"
And remove the exit 1 in there to let it still continue with the service.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[ChristianEhrhardt]

Thanks for the patch Breno, the syncing with Debian suggestion here is true but 
complex.
The per-arch kvm wrappers is part of the Delta that Serge started to get rid of 
but still is left.

For now until the wider topic of getting Debian/Ubuntu in sync on those
it will only apply to Ubuntu.

We need to hear from the Debian-Qemu people and Serge some of the History why 
this part isn't in Debian yet - there surely is a reason.
Subscribed Serge to comment on the History of that.

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs

[Bug 1638329] Re: Improve qemu message when SMT != off

[Jon Grimm]

I haven't looked deeply at the patch, but if we do something like this
we should align with Debian on it.

** Changed in: qemu (Ubuntu)
   Status: New => Confirmed

** Changed in: qemu (Ubuntu)
   Importance: Undecided => Wishlist

-- 
You received this bug notification because you are a member of Ubuntu
Bugs, which is subscribed to Ubuntu.
https://bugs.launchpad.net/bugs/1638329

Title:
  Improve qemu message when SMT != off

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1638329/+subscriptions

-- 
ubuntu-bugs mailing list
ubuntu-bugs@lists.ubuntu.com
https://lists.ubuntu.com/mailman/listinfo/ubuntu-bugs