Re: AjaxSubmitLink javadocs

2010-04-16 Thread Xavier López 
Thanks for the answer, Jeremy.

I just created issue https://issues.apache.org/jira/browse/WICKET-2837.

I'm with you on what you state, it was obvious the only possible way to do a
submit without JS is to have an html submit mechanism, anyway, I was just
being cautious in case I was missing something.
I'm just glad to contribute improving this great framework, even though it's
on a lesser thing like this.

Cheers,
Xavier


2010/4/16 Jeremy Thomerson jer...@wickettraining.com

 This appears to be an issue in the documentation of the AjaxSubmitLink.  I
 just checked and the documentation is still the same in 1.4.  I will try to
 verify this and fix it tomorrow.  In the meantime, it would be helpful if
 you opened a JIRA issue to keep track of this (post the link back to this
 thread).

 Anyway, the documentation is written as if this were a fallback component
 (i.e. AjaxFallbackLink).  However, it is not.  Obviously, if you do not
 have
 JS enabled, you can not submit a form with a link in the browser.  You
 could
 only submit it with a submit button.

 --
 Jeremy Thomerson
 http://www.wickettraining.com



 On Thu, Apr 15, 2010 at 4:12 AM, Xavier López xavil...@gmail.com wrote:

  Hi,
 
  I'm a liitle confused about AjaxSubmitLink's JavaDoc, and the code inside
  it... I'm using Wicket 1.3.6:
 
  If/when javascript is turned off in the browser, or it doesn't support
   javascript, then the
   browser will not respond to the onclick event, using the href directly.
   Wicket will then use a
   normal request target, and call the serverside onClick with a null
 {...@link
   AjaxRequestTarget}.
  
 
  First question is, does it really mean 'serverside onClick' ? Or should
 it
  read 'serverside onSubmit' ?
 
  And then, in the code, I see :
 
  protected void onComponentTag(ComponentTag tag)
   {
   super.onComponentTag(tag);
  
   if (isLinkEnabled())
   {
   if (tag.getName().toLowerCase().equals(a))
   {
   tag.put(href, #);
   }
   }
   else
   {
   disableLink(tag);
   }
   }
  
 
  So it seems this component never gets to have anything else than # in its
  href, so it won't do anything when js is not enabled...
 
  Is this an error in the documentation ?
 
  Thanks,
  Xavier
 




-- 
Klein bottle for rent--inquire within.

Re: AjaxSubmitLink javadocs

2010-04-16 Thread Jeremy Thomerson 
Every little bit helps - look how long it's been and nobody noticed it and
brought it to our attention - but it could have thrown some people off.
 Thanks for the help!

I'll commit a fix this weekend when I get a few free minutes.  :)

--
Jeremy Thomerson
http://www.wickettraining.com



On Fri, Apr 16, 2010 at 3:03 AM, Xavier López xavil...@gmail.com wrote:

 Thanks for the answer, Jeremy.

 I just created issue https://issues.apache.org/jira/browse/WICKET-2837.

 I'm with you on what you state, it was obvious the only possible way to do
 a
 submit without JS is to have an html submit mechanism, anyway, I was just
 being cautious in case I was missing something.
 I'm just glad to contribute improving this great framework, even though
 it's
 on a lesser thing like this.

 Cheers,
 Xavier


 2010/4/16 Jeremy Thomerson jer...@wickettraining.com

  This appears to be an issue in the documentation of the AjaxSubmitLink.
  I
  just checked and the documentation is still the same in 1.4.  I will try
 to
  verify this and fix it tomorrow.  In the meantime, it would be helpful if
  you opened a JIRA issue to keep track of this (post the link back to this
  thread).
 
  Anyway, the documentation is written as if this were a fallback component
  (i.e. AjaxFallbackLink).  However, it is not.  Obviously, if you do not
  have
  JS enabled, you can not submit a form with a link in the browser.  You
  could
  only submit it with a submit button.
 
  --
  Jeremy Thomerson
  http://www.wickettraining.com
 
 
 
  On Thu, Apr 15, 2010 at 4:12 AM, Xavier López xavil...@gmail.com
 wrote:
 
   Hi,
  
   I'm a liitle confused about AjaxSubmitLink's JavaDoc, and the code
 inside
   it... I'm using Wicket 1.3.6:
  
   If/when javascript is turned off in the browser, or it doesn't support
javascript, then the
browser will not respond to the onclick event, using the href
 directly.
Wicket will then use a
normal request target, and call the serverside onClick with a null
  {...@link
AjaxRequestTarget}.
   
  
   First question is, does it really mean 'serverside onClick' ? Or should
  it
   read 'serverside onSubmit' ?
  
   And then, in the code, I see :
  
   protected void onComponentTag(ComponentTag tag)
{
super.onComponentTag(tag);
   
if (isLinkEnabled())
{
if (tag.getName().toLowerCase().equals(a))
{
tag.put(href, #);
}
}
else
{
disableLink(tag);
}
}
   
  
   So it seems this component never gets to have anything else than # in
 its
   href, so it won't do anything when js is not enabled...
  
   Is this an error in the documentation ?
  
   Thanks,
   Xavier
  
 



 --
 Klein bottle for rent--inquire within.

AjaxSubmitLink javadocs

2010-04-15 Thread Xavier López 
Hi,

I'm a liitle confused about AjaxSubmitLink's JavaDoc, and the code inside
it... I'm using Wicket 1.3.6:

If/when javascript is turned off in the browser, or it doesn't support
 javascript, then the
 browser will not respond to the onclick event, using the href directly.
 Wicket will then use a
 normal request target, and call the serverside onClick with a null {...@link
 AjaxRequestTarget}.


First question is, does it really mean 'serverside onClick' ? Or should it
read 'serverside onSubmit' ?

And then, in the code, I see :

protected void onComponentTag(ComponentTag tag)
 {
 super.onComponentTag(tag);

 if (isLinkEnabled())
 {
 if (tag.getName().toLowerCase().equals(a))
 {
 tag.put(href, #);
 }
 }
 else
 {
 disableLink(tag);
 }
 }


So it seems this component never gets to have anything else than # in its
href, so it won't do anything when js is not enabled...

Is this an error in the documentation ?

Thanks,
Xavier

Re: AjaxSubmitLink javadocs

2010-04-15 Thread Jeremy Thomerson 
This appears to be an issue in the documentation of the AjaxSubmitLink.  I
just checked and the documentation is still the same in 1.4.  I will try to
verify this and fix it tomorrow.  In the meantime, it would be helpful if
you opened a JIRA issue to keep track of this (post the link back to this
thread).

Anyway, the documentation is written as if this were a fallback component
(i.e. AjaxFallbackLink).  However, it is not.  Obviously, if you do not have
JS enabled, you can not submit a form with a link in the browser.  You could
only submit it with a submit button.

--
Jeremy Thomerson
http://www.wickettraining.com



On Thu, Apr 15, 2010 at 4:12 AM, Xavier López xavil...@gmail.com wrote:

 Hi,

 I'm a liitle confused about AjaxSubmitLink's JavaDoc, and the code inside
 it... I'm using Wicket 1.3.6:

 If/when javascript is turned off in the browser, or it doesn't support
  javascript, then the
  browser will not respond to the onclick event, using the href directly.
  Wicket will then use a
  normal request target, and call the serverside onClick with a null {...@link
  AjaxRequestTarget}.
 

 First question is, does it really mean 'serverside onClick' ? Or should it
 read 'serverside onSubmit' ?

 And then, in the code, I see :

 protected void onComponentTag(ComponentTag tag)
  {
  super.onComponentTag(tag);
 
  if (isLinkEnabled())
  {
  if (tag.getName().toLowerCase().equals(a))
  {
  tag.put(href, #);
  }
  }
  else
  {
  disableLink(tag);
  }
  }
 

 So it seems this component never gets to have anything else than # in its
 href, so it won't do anything when js is not enabled...

 Is this an error in the documentation ?

 Thanks,
 Xavier