Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
Petri Helin wrote:
Rolf Ahrenberg wrote:
On Sat, 12 Apr 2008, Ville Skyttä wrote:
After figuring out how to access the subtitles menu (my remote.conf was from
1.4.x series so there was no button binding for it), yes, I do see an entry
named 57 there. Selecting it gives me the Finnish subtitles I was looking
for. Thanks for the tip.
You could also map 57 to fin in info.vdr of all those old recordings
and afterwards VDR automatically selects subtitles according to
preferred languages.
Is 57 dependent on the in subtitling language, or is it constant for
all old recordings?
It is constant. 57 is for the first subtitle track, 58 for the second.
If it is constant, could VDR be patched easily to
select 57 in case preferred subtitles are not found?
Yes. Patch attached.
--
Anssi Hannula
Index: vdr-1.6.0-57/device.c
===
--- vdr-1.6.0-57/device.c
+++ vdr-1.6.0-57/device.c 2008-05-04 18:33:18.0 +0300
@@ -1100,7 +1100,9 @@
int LanguagePreference = INT_MAX; // higher than the maximum possible
value
for (int i = ttSubtitleFirst; i = ttSubtitleLast; i++) {
const tTrackId *TrackId = GetTrack(eTrackType(i));
- if (TrackId TrackId-id
I18nIsPreferredLanguage(Setup.SubtitleLanguages, TrackId-language,
LanguagePreference))
+ // Fall back to languageless ttSubtitleFirst+8 track created by old
subtitles patch if present
+ if (TrackId TrackId-id
(I18nIsPreferredLanguage(Setup.SubtitleLanguages, TrackId-language,
LanguagePreference)
+ || ((i == ttSubtitleFirst + 8) !(*TrackId-language)
LanguagePreference == INT_MAX)))
PreferredTrack = eTrackType(i);
}
// Make sure we're set to an available subtitle track:
___
vdr mailing list
vdr@linuxtv.org
http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
On Saturday 12 April 2008, Rolf Ahrenberg wrote: On Sat, 12 Apr 2008, Ville Skyttä wrote: After figuring out how to access the subtitles menu (my remote.conf was from 1.4.x series so there was no button binding for it), yes, I do see an entry named 57 there. Selecting it gives me the Finnish subtitles I was looking for. Thanks for the tip. You could also map 57 to fin in info.vdr of all those old recordings and afterwards VDR automatically selects subtitles according to preferred languages. I tried to do that, but did not succeed so far. The old recordings I tried this with had no X lines in info.vdr, but they do have this selectable 57 entry in the subtitles menu. New recordings from the same channel (MTV3 Scifi) have both X 3 03 fin and X 3 03 sve there, and Finnish subtitles do show up automatically when replaying these. So I tried X 3 03 fin , X 3 57 fin , and X 57 03 fin in the old recordings' info.vdr but that did not seem have any effect. Tried also touching .update and restarting VDR in between, as well as replacing 57 with 39 and 87 (just in case there would have been a dec-hex conversion somewhere). SubtitleLanguages = fin 57 hack in setup.conf didn't help either. Did I miss something? ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
On 04/13/08 09:27, Ville Skyttä wrote: On Saturday 12 April 2008, Rolf Ahrenberg wrote: On Sat, 12 Apr 2008, Ville Skyttä wrote: After figuring out how to access the subtitles menu (my remote.conf was from 1.4.x series so there was no button binding for it), yes, I do see an entry named 57 there. Selecting it gives me the Finnish subtitles I was looking for. Thanks for the tip. You could also map 57 to fin in info.vdr of all those old recordings and afterwards VDR automatically selects subtitles according to preferred languages. I tried to do that, but did not succeed so far. The old recordings I tried this with had no X lines in info.vdr, but they do have this selectable 57 entry in the subtitles menu. New recordings from the same channel (MTV3 Scifi) have both X 3 03 fin and X 3 03 sve there, and Finnish subtitles do show up automatically when replaying these. So I tried X 3 03 fin , X 3 57 fin , and X 57 03 fin in the old recordings' info.vdr but that did not seem have any effect. Tried also touching .update and restarting VDR in between, as well as replacing 57 with 39 and 87 (just in case there would have been a dec-hex conversion somewhere). SubtitleLanguages = fin 57 hack in setup.conf didn't help either. Did I miss something? The old subtitle patch/plugin used 0x28 as the starting offset for subtitle tracks, while the current implementation uses 0x20. I guess this was because the old remux.c had the line ts2pes[numTracks++] = new cTS2PES(*SPids++, resultBuffer, IPACKS, 0x00, 0x28 + n++); commented as future... and the subtitle patch just enabled this one. When I implemented subtitle handling in the core VDR code, I realized that this should actually be 0x20 instead. You can work around this by adding the lines X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 fin suomi to your info.vdr files. This fills up the first 8 slots and puts suomi into the 9th slot. Don't forget to touch /video/.update after this change. Of course we could also modify cDevice::PlayPesPacket() to subtract 8 from SubStreamIndex in case the // Compatibility mode for old subtitles plugin check was positive, but you would still have to add X 3 03 fin suomi to your info.vdr files in order to get automatic subtitle track selection. So I guess the above workaround should do just fine. Klaus ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
On Sunday 13 April 2008, Klaus Schmidinger wrote: You can work around this by adding the lines X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 X 3 03 fin suomi to your info.vdr files. This fills up the first 8 slots and puts suomi into the 9th slot. That works for me, thanks! ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
[vdr] Watching old recordings with DVB subtitles with 1.6.0
Hello, I have quite a few old recordings with DVB subtitles that were recorded and watchable with 1.4.x and the subtitles plugin. When replaying these with VDR 1.6.0, the subtitles aren't shown (new recordings made with 1.6.0 seem to be fine). I see there's some kind of a compatibility mode for old subtitles plugin in 1.6.0 sources, so I guess they should be. Thoughts? ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
On Sat, 12 Apr 2008, Klaus Schmidinger wrote: On 04/12/08 11:21, Ville Skyttä wrote: I have quite a few old recordings with DVB subtitles that were recorded and watchable with 1.4.x and the subtitles plugin. When replaying these with VDR 1.6.0, the subtitles aren't shown (new recordings made with 1.6.0 seem to be fine). I see there's some kind of a compatibility mode for old subtitles plugin in 1.6.0 sources, so I guess they should be. Thoughts? IIRC I had tested that with an old recording somebody gave me, and it worked just fine. Well, I was the driving force behind the old subtitles compatibility mode and it worked on my recordings made with vdr-1.5.x and subtitles plugin. There were broken subtitles patches that generated faulty recordings (ie. ProjectX didn't like these either), that might be the source of Ville's problem. BR, -- rofa ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
Ville Skyttä wrote: Hello, I have quite a few old recordings with DVB subtitles that were recorded and watchable with 1.4.x and the subtitles plugin. When replaying these with VDR 1.6.0, the subtitles aren't shown (new recordings made with 1.6.0 seem to be fine). I see there's some kind of a compatibility mode for old subtitles plugin in 1.6.0 sources, so I guess they should be. Thoughts? I think you need to select the subtitles manually for older recordings. Do you see any entries in the subtitles menu? -Petri ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
On Sat, 12 Apr 2008, Ville Skyttä wrote: After figuring out how to access the subtitles menu (my remote.conf was from 1.4.x series so there was no button binding for it), yes, I do see an entry named 57 there. Selecting it gives me the Finnish subtitles I was looking for. Thanks for the tip. You could also map 57 to fin in info.vdr of all those old recordings and afterwards VDR automatically selects subtitles according to preferred languages. BR, -- rofa ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
Re: [vdr] Watching old recordings with DVB subtitles with 1.6.0
Rolf Ahrenberg wrote: On Sat, 12 Apr 2008, Ville Skyttä wrote: After figuring out how to access the subtitles menu (my remote.conf was from 1.4.x series so there was no button binding for it), yes, I do see an entry named 57 there. Selecting it gives me the Finnish subtitles I was looking for. Thanks for the tip. You could also map 57 to fin in info.vdr of all those old recordings and afterwards VDR automatically selects subtitles according to preferred languages. Is 57 dependent on the in subtitling language, or is it constant for all old recordings? If it is constant, could VDR be patched easily to select 57 in case preferred subtitles are not found? -Petri ___ vdr mailing list vdr@linuxtv.org http://www.linuxtv.org/cgi-bin/mailman/listinfo/vdr
