Change in vdsm[master]: Support bridgeless ovirt node in vdsm-reg
Antoni Segura Puimedon has abandoned this change. Change subject: Support bridgeless ovirt node in vdsm-reg .. Abandoned The other alternative to solve this got merged. -- To view, visit http://gerrit.ovirt.org/17728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I2d50b2516db3bc6a204e4b8d3a0fba937e4287ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Antoni Segura Puimedon has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) It is partly as Mark says. These dirs are only necessary when the configuration vars are set to use "unified". Additionally, and I might be wrong with this, I thought that since /var/run can be a tmpfs, it doesn't hurt to create it just in case. Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Support bridgeless ovirt node in vdsm-reg
Alon Bar-Lev has posted comments on this change. Change subject: Support bridgeless ovirt node in vdsm-reg .. Patch Set 2: please close -- To view, visit http://gerrit.ovirt.org/17728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d50b2516db3bc6a204e4b8d3a0fba937e4287ac Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: deployUtil: Remove null character from the id on IBM POWER
Alon Bar-Lev has posted comments on this change. Change subject: deployUtil: Remove null character from the id on IBM POWER .. Patch Set 1: Please merge or close... -- To view, visit http://gerrit.ovirt.org/17423 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I05d29598e025ae94d13036c8fca6b054343f54fe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Load softdog if hardware watchdog is not available
Zhou Zheng Sheng has posted comments on this change. Change subject: vdsm: Load softdog if hardware watchdog is not available .. Patch Set 4: Bug is reported to Ubuntu at https://bugs.launchpad.net/ubuntu/+source/sanlock/+bug/1229525 -- To view, visit http://gerrit.ovirt.org/17814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17ca3dea7acd60b0ba5bb3634c06b656b41dde1d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: bug fix for listing and adding hook
Timothy Asir has posted comments on this change.
Change subject: gluster: bug fix for listing and adding hook
..
Patch Set 8:
(3 comments)
File vdsm/gluster/hooks.py
Line 243: @checkArgs
Line 244: @makePublic
Line 245: def hookAdd(glusterCmd, hookLevel, hookName, hookData, hookMd5Sum,
Line 246: enable=False):
Line 247: hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel)
I will send a seperate cleanup and enhancement patch for this.
Line 248: if not os.path.isdir(hookPath):
Line 249: try:
Line 250: os.makedirs(hookPath)
Line 251: except OSError as e:
Line 244: @makePublic
Line 245: def hookAdd(glusterCmd, hookLevel, hookName, hookData, hookMd5Sum,
Line 246: enable=False):
Line 247: hookPath = os.path.join(_glusterHooksPath, glusterCmd, hookLevel)
Line 248: if not os.path.isdir(hookPath):
Done
Line 249: try:
Line 250: os.makedirs(hookPath)
Line 251: except OSError as e:
Line 252: errMsg = "[Errno %s] %s: '%s'" % (e.errno, e.strerror,
e.filename)
Line 255:#silently ignore restorecon exceptios, when SELinux is disabled
Line 256: try:
Line 257: selinux.restorecon(hookPath, recursive=True)
Line 258: except OSError:
Line 259: logging.error('restorecon %s failed', hookPath,
exc_info=True)
Done
Line 260:
Line 261: try:
Line 262: return _hookUpdateOrAdd(glusterCmd, hookLevel, hookName,
hookData,
Line 263: hookMd5Sum, update=False,
enable=enable)
--
To view, visit http://gerrit.ovirt.org/18345
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I470470da153edef3fe7eb3a7d41a775bac208449
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Bala.FA
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Timothy Asir
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
Federico Simoncelli has posted comments on this change.
Change subject: vm: add the transient disk support
..
Patch Set 7:
(1 comment)
File vdsm/vm.py
Line 3384: # We lookup the drive by UUIDs since the image path
could
Line 3385: # be transient.
Line 3386: drive = self._findDriveByUUIDs(diskParams)
Line 3387: else:
Line 3388: drive = self._findDriveByPath(diskParams['path'])
This doesn't mix well in case we want a transient LUN disk.
Line 3389: except LookupError:
Line 3390: self.log.error("Hotunplug disk failed - Disk not found:
%s",
Line 3391:diskParams)
Line 3392: return {'status': {
--
To view, visit http://gerrit.ovirt.org/18326
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Deepak C Shetty
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Deepak C Shetty
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Itamar Heim
Gerrit-Reviewer: Liron Ar
Gerrit-Reviewer: Timothy Asir
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: add the transient disk support
oVirt Jenkins CI Server has posted comments on this change. Change subject: vm: add the transient disk support .. Patch Set 7: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4588/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4510/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3703/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/18326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3dfec35e324c47d8c86a965947e3ae4ae48c7524 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Deepak C Shetty Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Deepak C Shetty Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Liron Ar Gerrit-Reviewer: Timothy Asir Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
Douglas Schilling Landgraf has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prevent stale vm stats if qemu process exits
Greg Padgett has posted comments on this change. Change subject: vdsm: prevent stale vm stats if qemu process exits .. Patch Set 1: @Dan - thanks, makes sense. I was thinking about it from the hosted engine context, where we expected the process to close. -- To view, visit http://gerrit.ovirt.org/19470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Add SSL support to asyncore transport
Saggi Mizrahi has posted comments on this change. Change subject: jsonrpc: Add SSL support to asyncore transport .. Patch Set 6: (2 comments) File lib/yajsonrpc/betterAsyncore.py Line 78: Line 79: return result Line 80: Line 81: def _loadCAs(self): Line 82: context = self.context I don't understand, what param? Do you mean variable? doing x = self.x just makes things a bit faster and helps make sure you don't do stupid typos since pyflakes can check local variables and not instance variables Line 83: Line 84: if self.ca_cert: Line 85: context.load_verify_locations(self.ca_cert) Line 86: context.set_verify( File lib/yajsonrpc/protonReactor.py Line 63: self._connected = False Line 64: Line 65: def setTimeout(self, timeout): Line 66: # TODO Line 67: pass Log what? That we still have not implemented timeout? Line 68: Line 69: def closed(self): Line 70: return (self.connector is None or Line 71: proton.pn_connector_closed(self.connector)) -- To view, visit http://gerrit.ovirt.org/15426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad305e26d7d62fd967c71e5ac4dbd8157639a36d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - Still Failing!
Thanks! On Mon, Sep 23, 2013 at 03:11:40PM -0400, Eyal Edri wrote: > already fixed: > > http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ > > thanks, > > Eyal > > - Original Message - > > From: "Dan Kenigsberg" > > To: ee...@redhat.com > > Cc: vdsm-patches@lists.fedorahosted.org, sbona...@redhat.com > > Sent: Monday, September 23, 2013 8:16:50 PM > > Subject: Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - > > Still Failing! > > > > On Mon, Sep 23, 2013 at 04:11:34PM +0100, Jenkins ci oVirt Server wrote: > > > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ > > > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/683/ > > > Build Number: 683 > > > Build Status: Still Failing > > > Triggered By: Started by upstream project "vdsm_create_rpms" build number > > > 683 > > > > > > - > > > Changes Since Last Success: > > > - > > > Changes for Build #682 > > > > > > Changes for Build #683 > > > [Sandro Bonazzola] packaging: spec: selinux-policy-targeted requirements > > > > This fails due to a missing BuildRequires on that centos64 slave. > > > > error: Failed build dependencies: > > libselinux-python is needed by vdsm-4.12.0-146.gitc2a54cb.el6.x86_64 > > > > can it be fixed? > > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prevent stale vm stats if qemu process exits
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: prevent stale vm stats if qemu process exits .. Patch Set 1: Code-Review-2 Vdsm must not release the Vm resources automatically. It must give Engine the chance to collect the reason of failure, and issue a destroy verb. -- To view, visit http://gerrit.ovirt.org/19470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Dan Kenigsberg has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - Still Failing!
already fixed: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ thanks, Eyal - Original Message - > From: "Dan Kenigsberg" > To: ee...@redhat.com > Cc: vdsm-patches@lists.fedorahosted.org, sbona...@redhat.com > Sent: Monday, September 23, 2013 8:16:50 PM > Subject: Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - > Still Failing! > > On Mon, Sep 23, 2013 at 04:11:34PM +0100, Jenkins ci oVirt Server wrote: > > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ > > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/683/ > > Build Number: 683 > > Build Status: Still Failing > > Triggered By: Started by upstream project "vdsm_create_rpms" build number > > 683 > > > > - > > Changes Since Last Success: > > - > > Changes for Build #682 > > > > Changes for Build #683 > > [Sandro Bonazzola] packaging: spec: selinux-policy-targeted requirements > > This fails due to a missing BuildRequires on that centos64 slave. > > error: Failed build dependencies: > libselinux-python is needed by vdsm-4.12.0-146.gitc2a54cb.el6.x86_64 > > can it be fixed? > ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
Dan Kenigsberg has posted comments on this change.
Change subject: caps: coarse-grain libvirt.rpm may be missing
..
Patch Set 2: Verified+1
in patchset1 I was plainly lazy. both in writing the two-liner and in not
verifying it. Sorry for your lost time.
now
vdsClient -s 0 getVdsCaps |grep -A2 libvirt
has
'libvirt': {'buildtime': 1375400611,
'release': '1.fc19',
'version': '1.0.5.5'},
--
To view, visit http://gerrit.ovirt.org/19295
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Douglas Schilling Landgraf
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
oVirt Jenkins CI Server has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4587/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4509/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3702/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Re: [oVirt Jenkins] vdsm_create_rpms » centos64 - Build # 683 - Still Failing!
On Mon, Sep 23, 2013 at 04:11:34PM +0100, Jenkins ci oVirt Server wrote: > Project: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/ > Build: http://jenkins.ovirt.org/job/vdsm_create_rpms/./label=centos64/683/ > Build Number: 683 > Build Status: Still Failing > Triggered By: Started by upstream project "vdsm_create_rpms" build number 683 > > - > Changes Since Last Success: > - > Changes for Build #682 > > Changes for Build #683 > [Sandro Bonazzola] packaging: spec: selinux-policy-targeted requirements This fails due to a missing BuildRequires on that centos64 slave. error: Failed build dependencies: libselinux-python is needed by vdsm-4.12.0-146.gitc2a54cb.el6.x86_64 can it be fixed? ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: packaging: spec: selinux-policy-targeted requirements
Dan Kenigsberg has posted comments on this change. Change subject: packaging: spec: selinux-policy-targeted requirements .. Patch Set 1: Code-Review+2 That's the least of our issues with F18.. -- To view, visit http://gerrit.ovirt.org/19061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2773b19ff0b49ccdae394ae8e4e3618d9b027a23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
mooli tayer has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 1: (1 comment) File vdsm/caps.py Line 331: 'mom': 'mom', Line 332: } Line 333: Line 334: if getos() in (OSName.OVIRT, OSName.FEDORA): Line 335: KEY_PACKAGES['libvirt-daemon-kvm'] Maybe it was meant to be: del KEY_PACKAGES['libvirt']? Line 336: Line 337: if _glusterEnabled: Line 338: KEY_PACKAGES.update(GLUSTER_RPM_PACKAGES) Line 339: -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: packaging: spec: selinux-policy-targeted requirements
Dan Kenigsberg has submitted this change and it was merged. Change subject: packaging: spec: selinux-policy-targeted requirements .. packaging: spec: selinux-policy-targeted requirements fixed selinux policy-targeted requirements for fedora. Change-Id: I2773b19ff0b49ccdae394ae8e4e3618d9b027a23 Signed-off-by: Sandro Bonazzola Reviewed-on: http://gerrit.ovirt.org/19061 Reviewed-by: Dan Kenigsberg --- M vdsm.spec.in 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2773b19ff0b49ccdae394ae8e4e3618d9b027a23 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4586/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4508/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3701/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Adding ppc64 handling to getVdsCaps
Vitor de Lima has posted comments on this change. Change subject: vdsm: Adding ppc64 handling to getVdsCaps .. Patch Set 8: (2 comments) File lib/vdsm/utils.py Line 66: Line 67: Line 68: class Architecture: Line 69: X86_64 = 'x86_64' Line 70: PPC64 = 'ppc64' It is used in another patch, the one that creates the VMs for PPC64 Line 71: Line 72: Line 73: class IOCLASS: Line 74: REALTIME = 1 Line 464: def execCmd(command, sudo=False, cwd=None, data=None, raw=False, logErr=True, Line 465: printable=None, env=None, sync=True, nice=None, ioclass=None, Line 466: ioclassdata=None, setsid=False, execCmdLogger=logging.root, Line 467: deathSignal=0): Line 468: """ Sorry, I didn't change anything in this function... I think. Line 469: Executes an external command, optionally via sudo. Line 470: Line 471: IMPORTANT NOTE: don't define a deathSignal when sync=False Line 472: """ -- To view, visit http://gerrit.ovirt.org/17437 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42c4d00ace06805edbe765d975b40c9311a1fa9b Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vitor de Lima Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Leonardo Bianconi Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: Vitor de Lima Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 2: Thanks, Yaniv! -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Dan Kenigsberg has submitted this change and it was merged. Change subject: supervdsmServer was not passing kwargs to fuser .. supervdsmServer was not passing kwargs to fuser Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1006203 Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/19250 Reviewed-by: Yeela Kaplan Reviewed-by: Saggi Mizrahi --- M vdsm/supervdsmServer 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Yeela Kaplan: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Saggi Mizrahi: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 9: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4585/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4507/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3700/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prevent stale vm stats if qemu process exits
Sandro Bonazzola has posted comments on this change. Change subject: vdsm: prevent stale vm stats if qemu process exits .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prevent stale vm stats if qemu process exits
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: prevent stale vm stats if qemu process exits .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4584/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4506/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3699/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: prevent stale vm stats if qemu process exits
Greg Padgett has uploaded a new change for review. Change subject: vdsm: prevent stale vm stats if qemu process exits .. vdsm: prevent stale vm stats if qemu process exits If the qemu process stops, releaseVm() is called, but the deleteVm() method isn't. This leaves stale metadata about the vm, causing subsequent vm startup attempts to fail with "Virtual machine already exists". Fix this by adding the missing call to deleteVm(). Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f Bug-Url: https://bugzilla.redhat.com/1010980 Signed-off-by: Greg Padgett --- M vdsm/vm.py 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/19470/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index f356c08..c008b86 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -2165,6 +2165,8 @@ self.setDownStatus(NORMAL, 'User shut down') else: self.setDownStatus(ERROR, "Lost connection with qemu process") +# Clean VM from the system +self.deleteVm() def _loadCorrectedTimeout(self, base, doubler=20, load=None): """ -- To view, visit http://gerrit.ovirt.org/19470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b726d8bca0f9d61a6409acdb1a1a2b27a85323f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments and usi...
Dan Kenigsberg has submitted this change and it was merged. Change subject: respawn script fix: Adding -- after logger arguments and using $* .. respawn script fix: Adding -- after logger arguments and using $* Without using -- the usage of $@ in the string can count as more arguments to logger call instead of part of the string. This crashes the respawn process. The replacement of $@ to $* is to avoid spaces during the print. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=986635 Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Signed-off-by: Yaniv Bronhaim Reviewed-on: http://gerrit.ovirt.org/19462 Reviewed-by: Dan Kenigsberg Reviewed-by: Alon Bar-Lev --- M init/sysvinit/respawn 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: minor changes in libvirt connection
oVirt Jenkins CI Server has posted comments on this change. Change subject: minor changes in libvirt connection .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4583/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4505/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3698/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4b1ddea998adc3003255593dc139ca4321cbd0 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments and usi...
Alon Bar-Lev has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments and using $* .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing redundant code that reads the pools list
Yaniv Bronhaim has posted comments on this change. Change subject: Removing redundant code that reads the pools list .. Patch Set 1: (1 comment) File vdsm/storage/hsm.py Line 2099:want to check it's tasks. Line 2100: :type spUUID: UUID (deprecated) Line 2101: :options: ? Line 2102: """ Line 2103: # getSharedLock(tasksResource...) check the bz - anyhow, in any way you look at it, checking the first cell in pools doesn't mean anything. the only thing that was needed is using sp for that. The function is under @secured decorator and that takes care of what we want (SPM only api) Line 2104: allTasksStatus = sp.getAllTasksStatuses() Line 2105: return dict(allTasksStatus=allTasksStatus) Line 2106: Line 2107: @public -- To view, visit http://gerrit.ovirt.org/18843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27c74956a9304dfaa2c0f6badf8fdbd2ea02a5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: refactor buildConfDevices and getConfDevices into sing...
Michal Skrivanek has posted comments on this change. Change subject: vdsm: refactor buildConfDevices and getConfDevices into single function .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd3a209967f97a55fe861c4446e8f93e1a1da08e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: minor changes in libvirt connection
Yaniv Bronhaim has posted comments on this change. Change subject: minor changes in libvirt connection .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4b1ddea998adc3003255593dc139ca4321cbd0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments and usi...
Yaniv Bronhaim has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments and using $* .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4582/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4504/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3697/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments and usi...
Dan Kenigsberg has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments and using $* .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Mark Wu has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: Code-Review+1 (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) I guess it's because the dir is only needed when unified persistence is configured. If we choose the static approach, vdsm-tmpfiles.d.conf needs be updated accordingly to make it persist across reboot. Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments and usi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments and using $* .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4581/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4503/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3696/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: minor changes in libvirt connection
Saggi Mizrahi has posted comments on this change. Change subject: minor changes in libvirt connection .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/19463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4b1ddea998adc3003255593dc139ca4321cbd0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: minor changes in libvirt connection
oVirt Jenkins CI Server has posted comments on this change. Change subject: minor changes in libvirt connection .. Patch Set 1: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4580/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4502/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3695/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b4b1ddea998adc3003255593dc139ca4321cbd0 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments and usi...
oVirt Jenkins CI Server has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments and using $* .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4579/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4501/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3694/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 7: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4578/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4500/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3693/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments and usi...
Yaniv Bronhaim has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments and using $* .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: minor changes in libvirt connection
mooli tayer has uploaded a new change for review.
Change subject: minor changes in libvirt connection
..
minor changes in libvirt connection
change logging levels and use functools.wraps
Change-Id: I5b4b1ddea998adc3003255593dc139ca4321cbd0
Signed-off-by: Mooli Tayer
---
M lib/vdsm/libvirtconnection.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/63/19463/1
diff --git a/lib/vdsm/libvirtconnection.py b/lib/vdsm/libvirtconnection.py
index f0ac646..9d2dca6 100644
--- a/lib/vdsm/libvirtconnection.py
+++ b/lib/vdsm/libvirtconnection.py
@@ -26,6 +26,7 @@
import libvirt
from vdsm import constants, utils
+from functools import wraps
log = logging.getLogger("libvirtconnection")
@@ -71,6 +72,7 @@
take the current process down.
"""
def wrapMethod(f):
+@wraps(f)
def wrapper(pingLibvirt=True, *args, **kwargs):
try:
ret = f(*args, **kwargs)
@@ -93,10 +95,10 @@
if pingLibvirt:
__connections.get(id(target)).getLibVersion(pingLibvirt=False)
else:
-log.error('connection to libvirt broken.'
- ' ecode: %d edom: %d', ecode, edom)
+log.warning('connection to libvirt broken.'
+' ecode: %d edom: %d', ecode, edom)
if killOnFailure:
-log.error('taking calling process down.')
+log.critical('taking calling process down.')
os.kill(os.getpid(), signal.SIGTERM)
else:
raise
@@ -104,8 +106,6 @@
'level: %d message: %s', ecode, edom,
e.get_error_level(), e.get_error_message())
raise
-wrapper.__name__ = f.__name__
-wrapper.__doc__ = f.__doc__
return wrapper
def req(credentials, user_data):
--
To view, visit http://gerrit.ovirt.org/19463
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b4b1ddea998adc3003255593dc139ca4321cbd0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments
Yaniv Bronhaim has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments .. Patch Set 1: both can be used. /me start to like shell -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 6: Code-Review-1 Verified-1 Build Failed http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4577/ : FAILURE http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4499/ : UNSTABLE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3692/ : FAILURE -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments
Alon Bar-Lev has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments .. Patch Set 1: Code-Review+1 we can do either $@ or $*, but adding -- is healthy to stop parsing args. -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments
Alon Bar-Lev has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments .. Patch Set 1: this will have no effect, what we need is to tell logger to stop parsing parameters. /me love shell -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments
Dan Kenigsberg has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments .. Patch Set 1: Code-Review-1 how about using $* instead? it would be safer. it shoud be just like $@, but without breaking words. (/me hates shell) -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments
oVirt Jenkins CI Server has posted comments on this change. Change subject: respawn script fix: Adding -- after logger arguments .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4576/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4498/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3691/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Zhou Zheng Sheng Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: respawn script fix: Adding -- after logger arguments
Yaniv Bronhaim has uploaded a new change for review. Change subject: respawn script fix: Adding -- after logger arguments .. respawn script fix: Adding -- after logger arguments Without using -- the usage of $@ in the string can count as more arguments to logger call instead of part of the string. This crashes the respawn process. Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Signed-off-by: Yaniv Bronhaim --- M init/sysvinit/respawn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/19462/1 diff --git a/init/sysvinit/respawn b/init/sysvinit/respawn index df91d7b..8ee5913 100755 --- a/init/sysvinit/respawn +++ b/init/sysvinit/respawn @@ -78,15 +78,15 @@ then if [[ -n "$thrash_start" ]] && \ [[ $[d1-thrash_start] -gt "$MAX_THRASH_INTERVAL" ]]; then -logger -t respawn "slave '$@' died too quickly for more than $MAX_THRASH_INTERVAL seconds, master sleeping for $POST_FAIL_INTERVAL seconds" +logger -t respawn -- "slave '$@' died too quickly for more than $MAX_THRASH_INTERVAL seconds, master sleeping for $POST_FAIL_INTERVAL seconds" thrash_start= sleep "$POST_FAIL_INTERVAL" else -logger -t respawn "slave '$@' died too quickly, respawning slave" +logger -t respawn -- "slave '$@' died too quickly, respawning slave" [[ -z "$thrash_start" ]] && thrash_start=$d1 fi else -logger -t respawn "slave '$@' died, respawning slave" +logger -t respawn -- "slave '$@' died, respawning slave" thrash_start= fi d0=$d1 -- To view, visit http://gerrit.ovirt.org/19462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibc82adf5b612cbb79a2db40d6c486a6e7490d8b7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
mooli tayer has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 5:
(2 comments)
File lib/vdsm/libvirtconnection.py
Line 89: libvirt.VIR_ERR_INTERNAL_ERROR,
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if _pingLibvirt:
what if libvirt is down and gitLibVersion is called? we won't catch the error.
From the users perspective i'm concerned that in all other cases he gets one
behavior and in gitLibVersion another and he knows nothing about it.
Line 94: conn = __connections.get(id(target))
Line 95: conn.getLibVersion(_pingLibvirt=False)
Line 96: else:
Line 97: log.error('connection to libvirt broken.'
File tests/libvirtconnectionTests.py
Line 46: def get_error_domain(self):
Line 47: return LibvirtMock.VIR_FROM_RPC
Line 48:
Line 49: def get_error_level(self):
Line 50: return 3
Nope, unrelated, this is just some log level. I'll add a variable for it to
prevent confusion.
Line 51:
Line 52: def get_error_message(self):
Line 53: return ''
Line 54:
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: iscsiadm: Filter out IPv6 addresses when discovering targets
Ayal Baron has posted comments on this change. Change subject: iscsiadm: Filter out IPv6 addresses when discovering targets .. Patch Set 1: Code-Review+2 Saggi, filtering at hsm level is useless and incorrect as it would imply that the underlying layer supports ipv6 when in fact it does not (e.g. login would fail). There is no BC issue since we can just return the 'full' dataset in a new dictionary but then we'd risk having an ipv6 target returned and user actually expecting it to work. What is really required is to add support for ipv6 targets. In the meantime (until such support is properly added) there is no reason to fail for non ipv6 targets when ipv6 targets are present and this patch is minimal in allowing that, so I disagree with you. -- To view, visit http://gerrit.ovirt.org/19431 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f6d60e780e9ac50041cdcaa0c45394e392b52f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [3/4] - Restore network configur...
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [3/4] - Restore network configuration .. Patch Set 9: (1 comment) File lib/vdsm/netconfpersistence.py Line 168: def __init__(self): Line 169: super(PersistentConfig, self).__init__(CONF_PERSIST_DIR) Line 170: Line 171: def restore(self): Line 172: cmd_service = [service.cmd, "vdsm-restore-net-config", "restart"] Antoni what do you think? Line 173: utils.execCmd(cmd_service, sudo=True) -- To view, visit http://gerrit.ovirt.org/17010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Assaf Muller has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) I don't know. Antoni? Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for S3/S4 suspend calls
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm: add support for S3/S4 suspend calls .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4575/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4497/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3690/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19389 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic30016c5cd555f5771dde8db3f1340e1c11b3da7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: add support for ram/vram on QXL device
Martin Polednik has posted comments on this change.
Change subject: vdsm: add support for ram/vram on QXL device
..
Patch Set 3: Code-Review-1
(2 comments)
File vdsm/vm.py
Line 1206: """
Line 1207: Create domxml for video device
Line 1208: """
Line 1209: video = self.createXmlElem('video', None, ['address'])
Line 1210: if 'ram' in self.specParams:
We could reduce code duplication by creating a dict
that holds parameters to be passed to final function
call:
sourceAttrs = {'vram': self.specParams.get('vram', '32768'),
'heads': self.specParams.get('heads', '1')}
if 'ram' in self.specParams:
sourceAttrs['ram'] = self.specParams.get('ram', '65536')
video.appendChildWithArgs('model', type=self.device, **sourceAttrs)
Line 1211: video.appendChildWithArgs('model', type=self.device,
Line 1212: vram=self.specParams.get('vram',
'32768'),
Line 1213: ram=self.specParams.get('ram',
'65536'),
Line 1214: heads=self.specParams.get('heads',
'1'))
Line 1209: video = self.createXmlElem('video', None, ['address'])
Line 1210: if 'ram' in self.specParams:
Line 1211: video.appendChildWithArgs('model', type=self.device,
Line 1212: vram=self.specParams.get('vram',
'32768'),
Line 1213: ram=self.specParams.get('ram',
'65536'),
The default ram value could be removed as the parameter won't
be set unless it has been sent by engine: incorrect received value might
point to an issue in engine
Line 1214: heads=self.specParams.get('heads',
'1'))
Line 1215: else:
Line 1216: video.appendChildWithArgs('model', type=self.device,
Line 1217: vram=self.specParams.get('vram',
'32768'),
--
To view, visit http://gerrit.ovirt.org/19361
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71cc51acf22dbce66373009f0c6ec8e2022a4f87
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Peter V. Saveliev
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 1: I stand corrected. Now only waiting for V+1. -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: coarse-grain libvirt.rpm may be missing
Yaniv Bronhaim has posted comments on this change. Change subject: caps: coarse-grain libvirt.rpm may be missing .. Patch Set 1: (1 comment) File vdsm/caps.py Line 331: 'mom': 'mom', Line 332: } Line 333: Line 334: if getos() in (OSName.OVIRT, OSName.FEDORA): Line 335: KEY_PACKAGES['libvirt-daemon-kvm'] doesn't it throw a KeyError here? shouldn't it be: KEY_PACKAGES['libvirt'] = 'libvirt-daemon-kvm' ? or removing 'libvirt' key at all, maybe i missed the meaning here.. it will still search for libvirt.rpm that way Line 336: Line 337: if _glusterEnabled: Line 338: KEY_PACKAGES.update(GLUSTER_RPM_PACKAGES) Line 339: -- To view, visit http://gerrit.ovirt.org/19295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I733a1a2411c910caa030e435c2a7f751a8e4dad4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Douglas Schilling Landgraf Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: mooli tayer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Removing redundant code that reads the pools list
Dan Kenigsberg has posted comments on this change. Change subject: Removing redundant code that reads the pools list .. Patch Set 1: Code-Review-1 (1 comment) File vdsm/storage/hsm.py Line 2099:want to check it's tasks. Line 2100: :type spUUID: UUID (deprecated) Line 2101: :options: ? Line 2102: """ Line 2103: # getSharedLock(tasksResource...) the original code is bad since it overwrites the module sp with a local variable. but are you sure the suggested code would even work? I do not thinkg that there's a module-level getAllTasksStatuses() function. Line 2104: allTasksStatus = sp.getAllTasksStatuses() Line 2105: return dict(allTasksStatus=allTasksStatus) Line 2106: Line 2107: @public -- To view, visit http://gerrit.ovirt.org/18843 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27c74956a9304dfaa2c0f6badf8fdbd2ea02a5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ignore this patch - for testing
Yaniv Bronhaim has abandoned this change. Change subject: ignore this patch - for testing .. Abandoned -- To view, visit http://gerrit.ovirt.org/18422 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ief5b01dcdaff78e1bba45ee4843a6508cf05796e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Saggi Mizrahi has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 1: https://bugzilla.redhat.com/show_bug.cgi?id=1006203#c2 -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Yaniv Bronhaim has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 5: (2 comments) File tests/libvirtconnectionTests.py Line 36: VIR_FROM_REMOTE = 4 Line 37: VIR_ERR_SYSTEM_ERROR = 5 Line 38: VIR_ERR_INTERNAL_ERROR = 6 Line 39: VIR_ERR_NO_CONNECT = 7 Line 40: VIR_ERR_INVALID_CONN = 8 you can do VIR_CRED_AUTHNAME, VIR_CRED_PASSPHRASE, ... = range(n) Line 41: Line 42: class libvirtError(Exception): Line 43: def get_error_code(self): Line 44: return LibvirtMock.VIR_ERR_SYSTEM_ERROR Line 46: def get_error_domain(self): Line 47: return LibvirtMock.VIR_FROM_RPC Line 48: Line 49: def get_error_level(self): Line 50: return 3 what is 3 ? VIR_FROM_RPC? Line 51: Line 52: def get_error_message(self): Line 53: return '' Line 54: -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 1: According to Saggi on IRC, what I want already happens - but nobody noticed it until now. 10:41:30 AM) saggi: danken: "TypeError: fuser() got an unexpected keyword argument 'mountPoint' " isn't enough? (10:42:09 AM) saggi: danken: This is what happens now -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 5:
(3 comments)
File lib/vdsm/libvirtconnection.py
Line 70: Wrap methods of connection object so that they catch
disconnection, and
Line 71: take the current process down.
Line 72: """
Line 73: def wrapMethod(f):
Line 74: def wrapper(_pingLibvirt=True, *args, **kwargs):
underscore is to specified private variables in an object or globals. please
omit it from this context
Line 75: try:
Line 76: ret = f(*args, **kwargs)
Line 77: if isinstance(ret, libvirt.virDomain):
Line 78: for name in dir(ret):
Line 89: libvirt.VIR_ERR_INTERNAL_ERROR,
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if _pingLibvirt:
Don't you agree with me that omitting this _pingLibvirt parameter that we pass
to each method and instead not wrapping getLibVersion is better here? The only
catch is if someone calls the getLibVersion and expects the wrapping flow,
which doesn't really hurt here. The caller will see the regular exception.
Line 94: conn = __connections.get(id(target))
Line 95: conn.getLibVersion(_pingLibvirt=False)
Line 96: else:
Line 97: log.error('connection to libvirt broken.'
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if _pingLibvirt:
Line 94: conn = __connections.get(id(target))
Line 95: conn.getLibVersion(_pingLibvirt=False)
much better, even in one line:
__connections.get(id(target)).getLibVersion(_pingLibvirt=False)
Line 96: else:
Line 97: log.error('connection to libvirt broken.'
Line 98: ' ecode: %d edom: %d', ecode, edom)
Line 99: if killOnFailure:
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Text: add 'dstqemu' to vds client migration command description
Yaniv Bronhaim has posted comments on this change.
Change subject: Text: add 'dstqemu' to vds client migration command description
..
Patch Set 2:
(1 comment)
File client/vdsClient.py
Line 1957: ' name:value,name:value'
Line 1958: )),
Line 1959: 'migrate': (serv.do_migrate,
Line 1960: ('vmId= method=
src= '
Line 1961: 'dst= dstqemu=',
If modifying the port is supported I think its important to doc it as optional,
and I think it is - we sent the address to qemu as:
muri = 'tcp://%s' % self._vm.conf['_migrationParams']['dstqemu']
seems like tcp://1.1.1.1:888 will work here.
Line 1962: 'Migrate a desktop from src machine to dst host
using '
Line 1963: 'the specified ports'
Line 1964: )),
Line 1965: 'migrateStatus': (serv.do_mStat,
--
To view, visit http://gerrit.ovirt.org/19277
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib160ef79f842fb2dc75cfb229f281806bc801464
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Better Saggi
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Dan Kenigsberg has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 1: I would expect supervdsmProxy.call to explode with an exception if it receives unexpected arguments - just like local function call. I agree that your patch solves the quoted bug. But before we take it in, I would like to make sure that the cause this bug was hidden from us is understood. -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4574/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4496/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3689/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [3/4] - Restore network configur...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [3/4] - Restore network
configuration
..
Patch Set 9: Code-Review-1
(2 comments)
File lib/vdsm/netconfpersistence.py
Line 168: def __init__(self):
Line 169: super(PersistentConfig, self).__init__(CONF_PERSIST_DIR)
Line 170:
Line 171: def restore(self):
Line 172: cmd_service = [service.cmd, "vdsm-restore-net-config",
"restart"]
use vdsm-tool service for that
Line 173: utils.execCmd(cmd_service, sudo=True)
File vdsm/vdsm-restore-net-config
Line 56:
Line 57:
Line 58: def main():
Line 59: try:
Line 60: logging.config.fileConfig("/etc/vdsm/svdsm.logger.conf")
why do you load svdsm conf file here?? please explain deeply because it's odd.
if it runs in supervdsm context, the logging config should be loaded already.
Line 61: except:
Line 62: logging.basicConfig(filename='/dev/stdout', filemode='w+',
Line 63: level=logging.DEBUG)
Line 64: logging.error("Could not init proper logging", exc_info=True)
--
To view, visit http://gerrit.ovirt.org/17010
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I73462b160ecfbaa7efe71eed905a3bbd69ee6c23
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Livnat Peer
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Petr Šebek
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.1/4.*] - Upgrade mechanism
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
(2 comments)
Commit Message
Line 3: AuthorDate: 2013-08-04 11:08:51 +0300
Line 4: Commit: Assaf Muller
Line 5: CommitDate: 2013-09-22 17:05:05 +0300
Line 6:
Line 7: Unified network persistence [4.1/4.*] - Upgrade mechanism
you explain the whole mechanism here, you don't explain the upgrade.py usage
and why is it under vdsm-tool in separate module.
Better explaining the specific part here and put link to feature wiki page in
each part.
Line 8:
Line 9: First half of unified network persistence upgrade.
Line 10: Unified network persistence: For each setupNetworks that
Line 11: we get from the engine, we store the parameters for each
File lib/vdsm/tool/upgrade.py
Line 27: def __init__(self):
Line 28: self.upgradeName = self.__class__.__name__
Line 29: self.upgradeFilePath = constants.P_VDSM_LIB + "upgrade/%s" % \
Line 30: self.upgradeName
Line 31: self.log = logging.getLogger('vds')
you don't have logging conf loaded here. set default handler to a new
vdsm-tool.log file, or use syslog\stderr
Line 32:
Line 33: def runIfNeeded(self):
Line 34: if self.isNeeded():
Line 35: self.log.debug("Running upgrade %s" % self.upgradeName)
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba3c9c34f03134c192db1c2add31084824e195d9
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: ping libvirt upon disconnection .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4573/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4495/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/3688/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/19444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: mooli tayer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [4.2/4.*] - Upgrade updates runn...
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
..
Patch Set 11: Code-Review-1
(4 comments)
Commit Message
Line 10: config of the unified network persistence.
Line 11:
Line 12: To-Do:
Line 13: * Bonds that don't have a network over them are unnoticed
Line 14:
where is a link to 4.3 as you put in 4.1?
Line 15: Change-Id: I051b0f168b6357e60184409845ea410c5891b083
File lib/vdsm/tool/unifiedPersistence.py
Line 21: from vdsm.config import config
Line 22: from vdsm.netconfpersistence import RunningConfig
Line 23: from vdsm.tool import expose
Line 24:
Line 25: from vdsm.tool.upgrade import Upgrade
only here you use upgrade.py, squash both to one patch
Line 26:
Line 27:
Line 28: class UnifiedPersistence(Upgrade):
Line 29: def __init__(self):
Line 117: runningConfig.store()
Line 118:
Line 119:
Line 120: @expose('unifiedPersistence')
Line 121: def main():
add explanation. please follow previous comments, wrote it in last ps.
File vdsm/vdsmd.init.in
Line 261: return 1
Line 262: fi
Line 263:
Line 264: "$VDSM_TOOL" unifiedPersistence
Line 265:
you haven't rebased as I suggested. you should move this call to
vdsmd_init_common.sh.in
Line 266: echo $"Starting up vdsm daemon: "
Line 267: local vdsm_nice="$("${GETCONFITEM}" "${CONF_FILE}" vars vdsm_nice
-5)"
Line 268:
Line 269: LIBVIRT_LOG_FILTERS="$("${GETCONFITEM}" "${CONF_FILE}" vars
libvirt_env_variable_log_filters "")" \
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller
Gerrit-Reviewer: Alon Bar-Lev
Gerrit-Reviewer: Antoni Segura Puimedon
Gerrit-Reviewer: Assaf Muller
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Giuseppe Vallarelli
Gerrit-Reviewer: Mark Wu
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Add SSL support to asyncore transport
Yaniv Bronhaim has posted comments on this change. Change subject: jsonrpc: Add SSL support to asyncore transport .. Patch Set 8: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/15426 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad305e26d7d62fd967c71e5ac4dbd8157639a36d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_binding: Simplify bindings by using object mappers
Yaniv Bronhaim has posted comments on this change.
Change subject: java_binding: Simplify bindings by using object mappers
..
Patch Set 6: Code-Review-1
(2 comments)
you did here much more than just simplify bindings. please arrange this huge
patch, fix tabs and another nits, split to different patches whatever is not
related to simplify binding
File
client/java/vdsm-test-server/src/main/java/org/ovirt/vdsm/JsonRpcServer.java
Line 4: import java.io.*;
Line 5: import java.net.*;
Line 6: import java.security.*;
Line 7: import java.security.cert.*;
Line 8: import java.util.*;
why? do all those beauty changes separately
Line 9:
Line 10: public final class JsonRpcServer {
Line 11:
Line 12: final private Process _proc;
Line 26:
Line 27: private KeyManagerFactory _kmf;
Line 28: private TrustManagerFactory _tmf;
Line 29:
Line 30: public JsonRpcServer() throws IOException {
put back the tabs
Line 31:Runtime runtime = Runtime.getRuntime();
Line 32:final ByteArrayOutputStream os;
Line 33:try (InputStream stream =
Object.class.getResourceAsStream(
Line 34:JsonRpcServer.RESOURCE_PATH)) {
--
To view, visit http://gerrit.ovirt.org/17196
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida303667cbba365bf14cc10147bbf507e3b730d6
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Barak Azulay
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: mooli tayer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 3:
(1 comment)
File lib/vdsm/libvirtconnection.py
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if not vdsmLibvirtPing:
Line 94: conn.getLibVersion(vdsmLibvirtPing=True)
btw, why not using conn = __connections.get(id(target)) -
you have target here, instead of passing conn
Line 95: else:
Line 96: log.error('connection to libvirt broken.'
Line 97: ' ecode: %d edom: %d', ecode, edom)
Line 98: if killOnFailure:
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Yaniv Bronhaim has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 3:
(4 comments)
File lib/vdsm/libvirtconnection.py
Line 70: Wrap methods of connection object so that they catch
disconnection, and
Line 71: take the current process down.
Line 72: """
Line 73: def wrapMethod(conn, f):
Line 74: def wrapper(vdsmLibvirtPing=False, *args, **kwargs):
I prefer to omit this variable and don't wrap getLibVersion at all. when
testing connectivity we'll call to conn.getLibVersion and if libvirtError is
raise we can suicide.
Line 75: try:
Line 76: ret = f(*args, **kwargs)
Line 77: if isinstance(ret, libvirt.virDomain):
Line 78: for name in dir(ret):
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if not vdsmLibvirtPing:
Line 94: conn.getLibVersion(vdsmLibvirtPing=True)
why block? doesn't matter much .. first fail ping we'll die, doesn't matter if
in parallel another ping call runs
Line 95: else:
Line 96: log.error('connection to libvirt broken.'
Line 97: ' ecode: %d edom: %d', ecode, edom)
Line 98: if killOnFailure:
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if not vdsmLibvirtPing:
Line 94: conn.getLibVersion(vdsmLibvirtPing=True)
Line 95: else:
Line 96: log.error('connection to libvirt broken.'
not related to the patch much, change it in another patch
Line 97: ' ecode: %d edom: %d', ecode, edom)
Line 98: if killOnFailure:
Line 99: log.error('taking calling process down.')
Line 100: os.kill(os.getpid(), signal.SIGTERM)
Line 104: 'level: %d message: %s', ecode, edom,
Line 105: e.get_error_level(), e.get_error_message())
Line 106: raise
Line 107: wrapper.__name__ = f.__name__
Line 108: wrapper.__doc__ = f.__doc__
just use @wraps(f) in the same patch you change the logs level
Line 109: return wrapper
Line 110:
Line 111: def req(credentials, user_data):
Line 112: passwd =
file(constants.P_VDSM_LIBVIRT_PASSWD).readline().rstrip("\n")
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: java_bindings: Minor imporovements
Yaniv Bronhaim has posted comments on this change.
Change subject: java_bindings: Minor imporovements
..
Patch Set 11:
(4 comments)
minor comments. please response
Commit Message
Line 5: CommitDate: 2013-08-12 14:23:56 +0300
Line 6:
Line 7: java_bindings: Minor imporovements
Line 8:
Line 9: - Move more code to a common location
did you move something? I haven't seen, maybe you added more or less
indentations
Line 10: - Make it so that calls don't throw an exception if it fails to connect
Line 11: to the server. Instead they return an error through the regular
Line 12: json-rpc mechanism.
Line 13:
File client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMClientBase.java
Line 24:return _transport.closed();
Line 25:}
Line 26:
Line 27:protected Future> _call(RequestBuilder rb,
Line 28:VDSMObject.TypeAdapter rtypeAdapter) {
spaces..
Line 29:
Line 30:final JsonRpcRequest __req = rb.build();
Line 31:final Future __call =
_transport.call(__req);
Line 32:return new FutureResultWrapper<>(
File
client/java/vdsm-api/src/main/java/org/ovirt/vdsm/VDSMTransportProvider.java
Line 92:request.id());
Line 93:
Line 94:}
Line 95:});
Line 96:fakeTask.run();
no report about the timeout ? only futureTask with response?
Line 97:return fakeTask;
Line 98:}
Line 99:
Line 100: return client.call(request);
Line 101: }
Line 102:
Line 103: public Future> batchCall(
Line 104: List requests)
Line 105: throws TimeoutException {
it was more readable the way the indentation was..
Line 106: final JsonRpcClient client = getClient();
Line 107: return client.batchCall(requests);
Line 108: }
Line 109:
--
To view, visit http://gerrit.ovirt.org/14821
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ceb7f58122accf6c911120b99b87d38b656e8e4
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 8: (1 comment) File lib/vdsm/unifiedpersistence.py Line 28: import utils Line 29: Line 30: Line 31: CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/' Line 32: CONF_PERSIST_DIR = constants.P_VDSM_LIB + 'persistence/netconf/' I wish you had an in-code comment about it. If you're not in the ovirt-node mindset, it's hard to guess the reason. Line 33: Line 34: Line 35: class Config(object): Line 36: def __init__(self, savePath): -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [2/4] Respond to setSafeNetworkC...
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [2/4] Respond to setSafeNetworkConfig .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/17009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I320677e40ff5b11da684d3ab7195d018135356b2 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Assaf Muller Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsmServer was not passing kwargs to fuser
Yaniv Bronhaim has posted comments on this change. Change subject: supervdsmServer was not passing kwargs to fuser .. Patch Set 1: Fist, I'm not sure this patch solves the bug attached, for me it was a request for an api change. *args should be enough there and the mountPoint=True should passed as expected in the proxy call that is mentioned in the bz. Second I don't understand what extra arguments I can protect from . fuser can get *args, means whatever you'll pass, it'll work. How can I protect it? In our case : def fuser(self, *args):-> whatever you pass will be accepted. return fuser.fuser(*args) -> and will be passed forwards what protection can be added? Having **kwargs is right and standard, so I added it, but also without it, the last parameters will be added to *args. Third, we have more supervdsm api functions that don't get *args and **kwargs at all. maybe this should be changed -- To view, visit http://gerrit.ovirt.org/19250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55eaedc884d30e8ab0476558351e91bdd58d9ef7 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Better Saggi Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Unified network persistence [1/4] - Save running config
Dan Kenigsberg has posted comments on this change. Change subject: Unified network persistence [1/4] - Save running config .. Patch Set 24: Code-Review+1 (1 comment) File lib/vdsm/netconfpersistence.py Line 80: @staticmethod Line 81: def _setConfig(config, path): Line 82: dirPath = os.path.dirname(path) Line 83: try: Line 84: os.makedirs(dirPath) still, why do we even need to create the directory during runtime? Line 85: except OSError as ose: Line 86: if errno.EEXIST != ose.errno: Line 87: raise Line 88: with open(path, 'w') as configurationFile: -- To view, visit http://gerrit.ovirt.org/16699 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7137a96f84abd2c5e532c6c37737e36ef17567a9 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon Gerrit-Reviewer: Antoni Segura Puimedon Gerrit-Reviewer: Assaf Muller Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Giuseppe Vallarelli Gerrit-Reviewer: Livnat Peer Gerrit-Reviewer: Mark Wu Gerrit-Reviewer: Petr Šebek Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: packaging: spec: selinux-policy-targeted requirements
Sandro Bonazzola has posted comments on this change. Change subject: packaging: spec: selinux-policy-targeted requirements .. Patch Set 1: > However, note that the package for fedora 18 has not hit updates-testing yet. https://bugzilla.redhat.com/show_bug.cgi?id=1005950 selinux-policy-3.11.1-103.fc18 has been pushed to the Fedora 18 stable repository. -- To view, visit http://gerrit.ovirt.org/19061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2773b19ff0b49ccdae394ae8e4e3618d9b027a23 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola Gerrit-Reviewer: Alon Bar-Lev Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Sandro Bonazzola Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: libvirtconnection: ping libvirt upon disconnection
Dan Kenigsberg has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
..
Patch Set 3: Code-Review-1
(3 comments)
reminder: -1 does not mean "I hate your patch". It means: "I read it, and it is
not completely ready".
Thanks for your patch!
File lib/vdsm/libvirtconnection.py
Line 89: libvirt.VIR_ERR_INTERNAL_ERROR,
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if not vdsmLibvirtPing:
the logic here is confusing. I'd expect that if the function is told to ping
libvirt, it would do it:
if pingLibvirt:
conn.getLibVersion()
(I think Saggi has alluded to this, too)
Line 94: conn.getLibVersion(vdsmLibvirtPing=True)
Line 95: else:
Line 96: log.error('connection to libvirt broken.'
Line 97: ' ecode: %d edom: %d', ecode, edom)
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if not vdsmLibvirtPing:
Line 94: conn.getLibVersion(vdsmLibvirtPing=True)
Why should we not block? If getLibVersion() blocks (due to libvirt's sudden
hang), there is no reason to return a value. Libvirt could have hung a
microsecond earlier, when the wrapped method was called.
Line 95: else:
Line 96: log.error('connection to libvirt broken.'
Line 97: ' ecode: %d edom: %d', ecode, edom)
Line 98: if killOnFailure:
File tests/libvirtconnectionTests.py
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
it's 2013
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit http://gerrit.ovirt.org/19444
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
