Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
Yaniv Bronhaim has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: spec: add BuildRequires: python-cpopen
Yaniv Bronhaim has posted comments on this change. Change subject: spec: add BuildRequires: python-cpopen .. Patch Set 1: please add reviewed on link, can't find the change-id in master -- To view, visit http://gerrit.ovirt.org/24873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic389d7d51b1c3bff54a245339f5e2cb83c0c0859 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: spec: add BuildRequires: python-cpopen
Yaniv Bronhaim has posted comments on this change. Change subject: spec: add BuildRequires: python-cpopen .. Patch Set 1: oh sorry, didn't notice the abandoned status. -- To view, visit http://gerrit.ovirt.org/24873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic389d7d51b1c3bff54a245339f5e2cb83c0c0859 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4
Eduardo has posted comments on this change.
Change subject: [WIP] lvm: Add an option to replace locking type 4
..
Patch Set 2: Code-Review-1
(4 comments)
http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 256: self._filterStale = False
Line 257:
Line 258: return self._extraCfg
Line 259:
Line 260: def _addExtraCfg(self, cmd, devices=tuple(), safe):
Safe should have a default value or be before devices.
Line 261: newcmd = [constants.EXT_LVM, cmd[0]]
Line 262: if devices:
Line 263: conf = _buildConfig(devices)
Line 264: else:
Line 291: self._pvs = {}
Line 292: self._vgs = {}
Line 293: self._lvs = {}
Line 294:
Line 295: def cmd(self, cmd, devices=tuple(), safe=True):
May be better (TM) to change safe=True for lvm cluster safe commands?
(Inverting the value semantics.)
Line 296:
Line 297: Use safe as False only for lvm cluster safe commands.
Line 298: These are cmds that don't change metadata of an existing VG.
Line 299:
Line 945: cmd = [vgcreate] + options + [vgName] + pvs
Line 946: rc, out, err = _lvminfo.cmd(cmd, tuple(pvs), False)
Line 947: if rc == 0:
Line 948: _lvminfo._invalidatepvs(pvs)
Line 949: _lvminfo._invalidatevgs(vgName)
May be worth to add stubs instead invalidating the whole cache since this
operations are now orthogonal to any value already present in the caches.
Anyway this is a different patch.
Line 950: log.debug(Cache after createvg %s, _lvminfo._vgs)
Line 951: else:
Line 952: raise se.VolumeGroupCreateError(vgName, pvs)
Line 953:
Line 946: rc, out, err = _lvminfo.cmd(cmd, tuple(pvs), False)
Line 947: if rc == 0:
Line 948: _lvminfo._invalidatepvs(pvs)
Line 949: _lvminfo._invalidatevgs(vgName)
Line 950: log.debug(Cache after createvg %s, _lvminfo._vgs)
This log should be removed in production code.
Line 951: else:
Line 952: raise se.VolumeGroupCreateError(vgName, pvs)
Line 953:
Line 954:
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Fix in testLeakFd to avoid potential races during the check
Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix in testLeakFd to avoid potential races during the check .. Fix in testLeakFd to avoid potential races during the check To avoid corrupted tests that leaves fds open, clean the fds before checking the first fds state. Change-Id: Ic6a6e0586c3e225771701cd594f485aae9b00b6e Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24739 Reviewed-by: Dan Kenigsberg dan...@redhat.com Reviewed-by: Nir Soffer nsof...@redhat.com --- M tests/miscTests.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24739 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6a6e0586c3e225771701cd594f485aae9b00b6e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: collect vdsm-config.log
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG Commit Message: Line 7: collect you change the log location, please explain why or where was this location change firstly introduced? -- To view, visit http://gerrit.ovirt.org/24862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot transient disk check should be per disk
Dan Kenigsberg has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/24867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3775e2218186e56e99740c6f91c8c98484529892 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reload daemon file after each install
Yaniv Bronhaim has posted comments on this change. Change subject: Reload daemon file after each install .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Reload daemon file after each install
Dan Kenigsberg has submitted this change and it was merged. Change subject: Reload daemon file after each install .. Reload daemon file after each install Currently we load the daemon file only on first install. After upgrade we could fail with: Warning: Unit file changed on disk, 'systemctl --system daemon-reload' recommended. This patch perform the reload after each installation of vdsm. Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063772 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24535 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yaniv Bronhaim: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Reload daemon file after each install
Hello Dan Kenigsberg, I'd like you to do a code review. Please visit http://gerrit.ovirt.org/24898 to review the following change. Change subject: Reload daemon file after each install .. Reload daemon file after each install Currently we load the daemon file only on first install. After upgrade we could fail with: Warning: Unit file changed on disk, 'systemctl --system daemon-reload' recommended. This patch perform the reload after each installation of vdsm. Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1063772 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24535 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/24898/1 diff --git a/vdsm.spec.in b/vdsm.spec.in index 149793e..a90d1a4 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -725,8 +725,8 @@ if [ $1 -eq 1 ] ; then /bin/systemctl enable vdsmd.service /dev/null 21 || : /bin/systemctl enable supervdsmd.service /dev/null 21 || : -/bin/systemctl daemon-reload /dev/null 21 || : fi +/bin/systemctl daemon-reload /dev/null 21 || : exit 0 %endif -- To view, visit http://gerrit.ovirt.org/24898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.4]: Reload daemon file after each install
Yaniv Bronhaim has posted comments on this change. Change subject: Reload daemon file after each install .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.ovirt.org/24898 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d6e6e292494da78052a9593c5cbe94ac35ea0d9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.4 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: collect vdsm-config.log
Dan Kenigsberg has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-02-21 11:52:22 + Line 4: Commit: Dan Kenigsberg dan...@redhat.com Line 5: CommitDate: 2014-02-21 11:58:27 + Line 6: Line 7: vdsm-reg: collect vdsm-config.log you change the log location, please explain why or where was this location I do not think much thought has been invested into the former location of /var/log/vdsm-config. /var/log/vdsm-reg/vdsm-config is clearer (since vdsm-config is part of the registration flow) and is collected by sosreport. Are you looking for a deeper reasoning? Line 8: Line 9: Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e -- To view, visit http://gerrit.ovirt.org/24862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: collect vdsm-config.log
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/24862/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-02-21 11:52:22 + Line 4: Commit: Dan Kenigsberg dan...@redhat.com Line 5: CommitDate: 2014-02-21 11:58:27 + Line 6: Line 7: vdsm-reg: collect vdsm-config.log I do not think much thought has been invested into the former location of / that's the all point of this change. why is it required? because its more clearer is also a reason, but should be specified Line 8: Line 9: Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e -- To view, visit http://gerrit.ovirt.org/24862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4
Yeela Kaplan has posted comments on this change.
Change subject: [WIP] lvm: Add an option to replace locking type 4
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 256: self._filterStale = False
Line 257:
Line 258: return self._extraCfg
Line 259:
Line 260: def _addExtraCfg(self, cmd, devices=tuple(), safe):
Safe should have a default value or be before devices.
Was done in a later patch when testing,
will move it here. thanks.
Line 261: newcmd = [constants.EXT_LVM, cmd[0]]
Line 262: if devices:
Line 263: conf = _buildConfig(devices)
Line 264: else:
Line 291: self._pvs = {}
Line 292: self._vgs = {}
Line 293: self._lvs = {}
Line 294:
Line 295: def cmd(self, cmd, devices=tuple(), safe=True):
May be better (TM) to change safe=True for lvm cluster safe commands?
In my point of view,
safe stands for :
safe mode == default config of the host
unsafe mode == we allow locking type 1 for cluster safe commands...
If you think it's critical then I can change it.
Line 296:
Line 297: Use safe as False only for lvm cluster safe commands.
Line 298: These are cmds that don't change metadata of an existing VG.
Line 299:
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Towards a more (block) secure HSM.
Ayal Baron has posted comments on this change. Change subject: [WIP] Towards a more (block) secure HSM. .. Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/hsm.py File vdsm/storage/hsm.py: Line 310: Line 311: def validateSPM(self, spUUID): Line 312: pool = self.getPool(spUUID) Line 313: if pool.spmRole != sp.SPM_ACQUIRED: Line 314: lvm.setLvmROMD() redundant Line 315: raise se.SpmStatusError(spUUID) Line 316: Line 317: def validateNotSPM(self, spUUID): Line 318: pool = self.getPool(spUUID) Line 601: :raises: :exc:`storage_exception.TaskInProgress` Line 602: if there are tasks running for this pool. Line 603: Line 604: Line 605: lvm.setLvmROMD() should be in stopSpm inside sp Line 606: vars.task.setDefaultException(se.SpmStopError(spUUID)) Line 607: vars.task.getExclusiveLock(STORAGE, spUUID) Line 608: Line 609: pool = self.getPool(spUUID) http://gerrit.ovirt.org/#/c/2218/7/vdsm/storage/sp.py File vdsm/storage/sp.py: Line 267: Line 268: try: Line 269: self.lver = int(oldlver) + 1 Line 270: Line 271: blockSD.lvm.setLvmRWMD() # Do it later 1. do it later where? why? Line 272: Line 273: self._backend.setSpmStatus(self.lver, self.id, Line 274:__securityOverride=True) Line 275: self._maxHostID = maxHostID -- To view, visit http://gerrit.ovirt.org/2218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30df4ee5cdb6b44cf14d8cb155436aac7442a07d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo ewars...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Haim Ateya haim.at...@gmail.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4
Ayal Baron has posted comments on this change.
Change subject: [WIP] lvm: Add an option to replace locking type 4
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 291: self._pvs = {}
Line 292: self._vgs = {}
Line 293: self._lvs = {}
Line 294:
Line 295: def cmd(self, cmd, devices=tuple(), safe=True):
In my point of view,
safe indeed sounds more like 'readonly' than 'safe to run in cluster mode'.
But since it is obviously not immediately clear then name should be rwaccess or
something that is unambiguous
Line 296:
Line 297: Use safe as False only for lvm cluster safe commands.
Line 298: These are cmds that don't change metadata of an existing VG.
Line 299:
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage domain using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (5 comments) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 516: raise se.StorageDomainIsMadeFromTooManyPVs() Line 517: Line 518: # Create metadata service volume Line 519: metasize = cls.metaSize(vgName) Line 520: lvm.createLV(vgName, sd.METADATA, %s % (metasize), safe=False) Look at the lvm code comment. Line 521: # Create the mapping right now so the index 0 is guaranteed Line 522: # to belong to the metadata volume. Since the metadata is at Line 523: # least SDMETADATA/METASIZE units, we know we can use the first Line 524: # SDMETADATA bytes of the metadata volume for the SD metadata. http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 654: This fuction is so restrictive as we can do. Line 655: log.debug(### _current_lvmconf %s, globals()[_current_lvmconf]) Line 656: globals()[_current_lvmconf] = _current_lvmconf.replace(locking_type=4, Line 657: locking_type=1) Line 658: log.debug(### _current_lvmconf %s, globals()[_current_lvmconf]) These logs should be updated before production. Line 659: Line 660: Line 661: def bootstrap(refreshlvs=()): Line 662: Line 1061: # Line 1062: Line 1063: Line 1064: def createLV(vgName, lvName, size, activate=True, contiguous=False, Line 1065: initialTag=None, safe=True): createLV operates on an existing VG making safe parameters misuse very dangerous at this time. If the intention is to use this parameter only when the SD is created may be an alternative method should be found lioke spliting the function for createLV() for images volumes and createSpecialVolumes which are created only at SD creation and never modified, making this parameter redundant. Line 1066: Line 1067: Size units: MB (1024 ** 2 = 2 ** 20)B. Line 1068: Line 1069: # WARNING! From man vgs: Line 1280: Line 1281: return os.path.exists(lvPath(vgName, lvName)) Line 1282: Line 1283: Line 1284: def changeVGTags(vgName, delTags=(), addTags=(), safe=True): Again, this change is dangerous and very misleading. IMHO separating the only valid case for a non-SPM doing this operation (create) will be more in line with the purpose of this series. The new function should be more simple than the actual changeVGTags since it operates in a known set of tags. Please note that actually createSD() is the only user of replaceVGtags . Therefore you can change it there and the split is natural and you need not to change changeVGTags() function. Line 1285: delTags = set(delTags) Line 1286: addTags = set(addTags) Line 1287: if delTags.intersection(addTags): Line 1288: raise se.VolumeGroupReplaceTagError( Line 1321: if rc != 0: Line 1322: raise se.VolumeGroupRemoveTagError(vgName) Line 1323: Line 1324: Line 1325: def replaceVGTag(vg, oldTag, newTag, safe=True): Please see above. Line 1326: changeVGTags(vg, [oldTag], [newTag], safe) Line 1327: Line 1328: Line 1329: def addVGTags(vgName, tags): -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage pool using command type 1
Ayal Baron has posted comments on this change.
Change subject: [WIP] Create storage pool using command type 1
..
Patch Set 2:
(5 comments)
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 529: # to belong to the metadata volume. Since the metadata is at
Line 530: # least SDMETADATA/METASIZE units, we know we can use the
first
Line 531: # SDMETADATA bytes of the metadata volume for the SD metadata.
Line 532: # pass metadata's dev to ensure it is the first mapping
Line 533: #mapping = cls.getMetaDataMapping(vgName)
in final version comment needs to move with code and this needs to disappear
Line 534:
Line 535: # Create the rest of the BlockSD internal volumes
Line 536: lvm.createLV(vgName, sd.LEASES, sd.LEASES_SIZE, safe=False)
Line 537: lvm.createLV(vgName, sd.IDS, sd.IDS_SIZE, safe=False)
Line 572: # no one reads it from here anyway
Line 573: initialMetadata = {
Line 574: sd.DMDK_VERSION: version,
Line 575: sd.DMDK_SDUUID: sdUUID,
Line 576: sd.DMDK_TYPE: sd.storageType(storageType),
this looks like a change in semantics that shouldn't be here or in the least
deserves an explanation?
Line 577: sd.DMDK_CLASS: sd.class2name(domClass),
Line 578: sd.DMDK_DESCRIPTION: domainName,
Line 579: sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 580: sd.DMDK_POOLS: '',
Line 573: initialMetadata = {
Line 574: sd.DMDK_VERSION: version,
Line 575: sd.DMDK_SDUUID: sdUUID,
Line 576: sd.DMDK_TYPE: sd.storageType(storageType),
Line 577: sd.DMDK_CLASS: sd.class2name(domClass),
same
Line 578: sd.DMDK_DESCRIPTION: domainName,
Line 579: sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 580: sd.DMDK_POOLS: '',
Line 581: sd.DMDK_LOCK_POLICY: '',
Line 576: sd.DMDK_TYPE: sd.storageType(storageType),
Line 577: sd.DMDK_CLASS: sd.class2name(domClass),
Line 578: sd.DMDK_DESCRIPTION: domainName,
Line 579: sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 580: sd.DMDK_POOLS: '',
?
Line 581: sd.DMDK_LOCK_POLICY: '',
Line 582: sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC:
sd.DEFAULT_LEASE_PARAMS[
Line 583: sd.DMDK_LOCK_RENEWAL_INTERVAL_SEC],
Line 584: sd.DMDK_LEASE_TIME_SEC: sd.DEFAULT_LEASE_PARAMS[
Line 593: }
Line 594:
Line 595: initialMetadata.update(mapping)
Line 596: toAdd = encodeVgTags(initialMetadata)
Line 597: lvm.changeVGTags(vgName, delTags=(), addTags=toAdd,
safe=False)
if it is not safe/possible to call md.update then need to explain this
Line 598:
Line 599: # Mark VG with Storage Domain Tag
Line 600: try:
Line 601: lvm.replaceVGTag(vgName, STORAGE_UNREADY_DOMAIN_TAG,
--
To view, visit http://gerrit.ovirt.org/23647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64f6dd2df38d2968f03ce66094f3ba7b4343503
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage domain using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot transient disk check should be per disk
Liron Ar has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24867/2/vdsm/vm.py File vdsm/vm.py: Line 3955: self.log.debug(The volume is already in use: %s, tgetDrv) Line 3956: continue # Next drive Line 3957: Line 3958: try: Line 3959: vmDrive = self._findDriveByUUIDs(baseDrv) question - for transient won't we fail here already (before the added check) with lookup eror? as the engine doesn't know the volume id of the currently transient volume. Line 3960: except LookupError: Line 3961: # The volume we want to snapshot doesn't exist Line 3962: self.log.error(The base volume doesn't exist: %s, baseDrv) Line 3963: return errCode['snapshotErr'] -- To view, visit http://gerrit.ovirt.org/24867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3775e2218186e56e99740c6f91c8c98484529892 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage pool using command type 1
Eduardo has posted comments on this change.
Change subject: [WIP] Create storage pool using command type 1
..
Patch Set 2: Code-Review-1
(6 comments)
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 529: # to belong to the metadata volume. Since the metadata is at
Line 530: # least SDMETADATA/METASIZE units, we know we can use the
first
Line 531: # SDMETADATA bytes of the metadata volume for the SD metadata.
Line 532: # pass metadata's dev to ensure it is the first mapping
Line 533: #mapping = cls.getMetaDataMapping(vgName)
in final version comment needs to move with code and this needs to disappea
We already know that the mapping is redundant and it can be removed.
This is a different patch.
Line 534:
Line 535: # Create the rest of the BlockSD internal volumes
Line 536: lvm.createLV(vgName, sd.LEASES, sd.LEASES_SIZE, safe=False)
Line 537: lvm.createLV(vgName, sd.IDS, sd.IDS_SIZE, safe=False)
Line 593: }
Line 594:
Line 595: initialMetadata.update(mapping)
Line 596: toAdd = encodeVgTags(initialMetadata)
Line 597: lvm.changeVGTags(vgName, delTags=(), addTags=toAdd,
safe=False)
if it is not safe/possible to call md.update then need to explain this
IMHO is better to use the unused addVGTags() here. Since this function is
actually unused can be safely converted to lock_type=1 only and assert that no
new consumers are added. This is probably True since for any other option than
a create will use changeVGTags() since a set of tags already exists.
Line 598:
Line 599: # Mark VG with Storage Domain Tag
Line 600: try:
Line 601: lvm.replaceVGTag(vgName, STORAGE_UNREADY_DOMAIN_TAG,
Line 1318: for k, v in params.iteritems():
Line 1319: enc = poolMD.getEncoder(k)
Line 1320: newParams[k] = enc(v)
Line 1321: toAdd = encodeVgTags(newParams)
Line 1322: lvm.changeVGTags(vgName, deltags=(), addTags=toAdd,
safe=False)
Use addVGTags() instead as discussed.
Line 1323:
Line 1324: def setMasterDomainParams(self, spUUID, leaseParams):
Line 1325: vgUUID = self.getInfo()['vguuid']
Line 1326: vg = lvm.getVGbyUUID(vgUUID)
Line 1330: sd.DMDK_ROLE: sd.MASTER_DOMAIN})
Line 1331: toDel = encodeVgTags({sd.DMDK_ROLE: sd.REGULAR_DOMAIN,
Line 1332: sd.DMDK_POOLS: spUUID,
Line 1333: sd.DMDK_POOLS: ''})
Line 1334: lvm.changeVGTags(vgName, delTags=toDel, addTags=toAdd,
safe=False)
IMHO simpler using the replaceVGTags() change already discussed.
Line 1335:
Line 1336: def refreshDirTree(self):
Line 1337: # create domain images folder
Line 1338: imagesPath = os.path.join(self.domaindir, sd.DOMAIN_IMAGES)
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 941: misc.validateUUID(spUUID, 'spUUID')
Line 942: if masterDom not in domList:
Line 943: raise se.InvalidParameterException(masterDom,
str(masterDom))
Line 944:
Line 945: if len(domList) 1:
==1 semantics will be more strict.
Line 946: raise NotImplementedError(Create storage pool
Line 947: only with master domain)
Line 948:
Line 949: if len(poolName) MAX_POOL_DESCRIPTION_SIZE:
http://gerrit.ovirt.org/#/c/23647/2/vdsm/storage/sd.py
File vdsm/storage/sd.py:
Line 768:
Line 769: def isMaster(self):
Line 770: return self.getMetaParam(DMDK_ROLE).capitalize() ==
MASTER_DOMAIN
Line 771:
Line 772: @classmethod
initMasterParams() is always called as an instance method. Then this should not
be a classmethod.
Since this called during pool creation/reconstruction all this redundant calls,
including the spbackend mess can be avoided IMHO.
Line 773: def initMasterParams(cls, poolMD, params):
Line 774: poolMD.update(params)
Line 775:
Line 776: def setMasterDomainParams(self, spUUID, leaseParams):
--
To view, visit http://gerrit.ovirt.org/23647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia64f6dd2df38d2968f03ce66094f3ba7b4343503
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: snapshot transient disk check should be per disk
Liron Ar has posted comments on this change. Change subject: vm: snapshot transient disk check should be per disk .. Patch Set 2: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/24867 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3775e2218186e56e99740c6f91c8c98484529892 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Liron Ar lara...@redhat.com Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: vm: recover must finish with libvirt connection
Yaniv Bronhaim has posted comments on this change. Change subject: vm: recover must finish with libvirt connection .. Patch Set 3: Code-Review-1 the bz you attached is targeted to 3.4 -- To view, visit http://gerrit.ovirt.org/24822 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c33a62c29fc70170b6f802a20b6016b301e96de Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] lvm: Add an option to replace locking type 4
Yeela Kaplan has posted comments on this change.
Change subject: [WIP] lvm: Add an option to replace locking type 4
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/23645/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 256: self._filterStale = False
Line 257:
Line 258: return self._extraCfg
Line 259:
Line 260: def _addExtraCfg(self, cmd, devices=tuple(), safe):
Was done in a later patch when testing,
Done
Line 261: newcmd = [constants.EXT_LVM, cmd[0]]
Line 262: if devices:
Line 263: conf = _buildConfig(devices)
Line 264: else:
Line 291: self._pvs = {}
Line 292: self._vgs = {}
Line 293: self._lvs = {}
Line 294:
Line 295: def cmd(self, cmd, devices=tuple(), safe=True):
safe indeed sounds more like 'readonly' than 'safe to run in cluster mode'.
Done.
Line 296:
Line 297: Use safe as False only for lvm cluster safe commands.
Line 298: These are cmds that don't change metadata of an existing VG.
Line 299:
--
To view, visit http://gerrit.ovirt.org/23645
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9a67a7fa20145763d8ab5cdbf293a9c3eb070067
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
oVirt Jenkins CI Server has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_3.3_install_rpm_sanity_gerrit/362/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] destroy storage pool using command type 1
Eduardo has posted comments on this change.
Change subject: [WIP] destroy storage pool using command type 1
..
Patch Set 1: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/24398/1/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:
Line 1366: self.log.error(
Line 1367: Can't remove pool %s from domain %s pool list %s,
Line 1368: it does not exist,
Line 1369: spUUID, self.sdUUID, str(pools))
Line 1370: return
Use an else: block please instead this ugly return.
Line 1371: vgUUID = self.getInfo()['vguuid']
Line 1372: vg = lvm.getVGbyUUID(vgUUID)
Line 1373: vgName = vg.name
Line 1374: toAdd = encodeVgTags({sd.DMDK_POOLS: '',
Line 1369: spUUID, self.sdUUID, str(pools))
Line 1370: return
Line 1371: vgUUID = self.getInfo()['vguuid']
Line 1372: vg = lvm.getVGbyUUID(vgUUID)
Line 1373: vgName = vg.name
This block (3 lines) seems to me to be an echo from code a long time gone.
vgName is self.sdUUID.
Please remove this redundant calls.
Line 1374: toAdd = encodeVgTags({sd.DMDK_POOLS: '',
Line 1375: sd.DMDK_ROLE: sd.REGULAR_DOMAIN})
Line 1376: toDel = encodeVgTags({sd.DMDK_POOLS: spUUID,
Line 1377: sd.DMDK_ROLE: sd.MASTER_DOMAIN})
Line 1374: toAdd = encodeVgTags({sd.DMDK_POOLS: '',
Line 1375: sd.DMDK_ROLE: sd.REGULAR_DOMAIN})
Line 1376: toDel = encodeVgTags({sd.DMDK_POOLS: spUUID,
Line 1377: sd.DMDK_ROLE: sd.MASTER_DOMAIN})
Line 1378: lvm.changeVGTags(vgName, delTags=toDel, addTags=toAdd,
safe=False)
Since detachMaster is called only from hsm.destroyStoragePool() and the domain
was already removed from the pool MD, you can avoid here the use of
changeVGtags replacing it by addVGTags and remVGTags as was discussed in a
previous patch.
The operations will be logically atomic and no one should try ever to access
the domain between the removal and the adiditon of the role tag.
You can lock the master domain at hsm.destroyStoragePool() to be sure and this
covers the previous forceDetach() call.
Line 1379:
Line 1380: def refresh(self):
Line 1381: self.refreshDirTree()
Line 1382: lvm.invalidateVG(self.sdUUID)
--
To view, visit http://gerrit.ovirt.org/24398
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67cda9abd0bbc01d7d0642d5d3327f8687d7f728
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] destroy storage pool using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] destroy storage pool using command type 1 .. Patch Set 1: After review the engine part: 1) all the regular domains are detached and removed. 2) destroy StoragePool is sent and afterwards the former master domain is removed. Therefore this patch can be greatly simplified if the MSD is removed when the pool is destroyed in a unique lvm operation. -- To view, visit http://gerrit.ovirt.org/24398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67cda9abd0bbc01d7d0642d5d3327f8687d7f728 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage domain using command type 1
Yeela Kaplan has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (4 comments) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/blockSD.py File vdsm/storage/blockSD.py: Line 516: raise se.StorageDomainIsMadeFromTooManyPVs() Line 517: Line 518: # Create metadata service volume Line 519: metasize = cls.metaSize(vgName) Line 520: lvm.createLV(vgName, sd.METADATA, %s % (metasize), safe=False) Look at the lvm code comment. Done Line 521: # Create the mapping right now so the index 0 is guaranteed Line 522: # to belong to the metadata volume. Since the metadata is at Line 523: # least SDMETADATA/METASIZE units, we know we can use the first Line 524: # SDMETADATA bytes of the metadata volume for the SD metadata. http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 654: This fuction is so restrictive as we can do. Line 655: log.debug(### _current_lvmconf %s, globals()[_current_lvmconf]) Line 656: globals()[_current_lvmconf] = _current_lvmconf.replace(locking_type=4, Line 657: locking_type=1) Line 658: log.debug(### _current_lvmconf %s, globals()[_current_lvmconf]) These logs should be updated before production. Noted, thanks/ Line 659: Line 660: Line 661: def bootstrap(refreshlvs=()): Line 662: Line 1061: # Line 1062: Line 1063: Line 1064: def createLV(vgName, lvName, size, activate=True, contiguous=False, Line 1065: initialTag=None, safe=True): createLV operates on an existing VG making safe parameters misuse very da Done Line 1066: Line 1067: Size units: MB (1024 ** 2 = 2 ** 20)B. Line 1068: Line 1069: # WARNING! From man vgs: Line 1280: Line 1281: return os.path.exists(lvPath(vgName, lvName)) Line 1282: Line 1283: Line 1284: def changeVGTags(vgName, delTags=(), addTags=(), safe=True): Again, this change is dangerous and very misleading. create is not the only valid case non-SPM doing this operation, Please see following patches. Line 1285: delTags = set(delTags) Line 1286: addTags = set(addTags) Line 1287: if delTags.intersection(addTags): Line 1288: raise se.VolumeGroupReplaceTagError( -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Create storage domain using command type 1
Eduardo has posted comments on this change. Change subject: [WIP] Create storage domain using command type 1 .. Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/23646/2/vdsm/storage/lvm.py File vdsm/storage/lvm.py: Line 1280: Line 1281: return os.path.exists(lvPath(vgName, lvName)) Line 1282: Line 1283: Line 1284: def changeVGTags(vgName, delTags=(), addTags=(), safe=True): create is not the only valid case non-SPM doing this operation, Please look at the comments in the last patch of this series. changeVGtags() can be avoided in the destroySP(). In addition destroyStoragePool can remove the entire MD of the domain or remove it enterily without changes to the subsequent formatStorageDomain(). The actual logic is inconsistent. In any case changeVGTags with locking type 1 without being SPM is not required. Line 1285: delTags = set(delTags) Line 1286: addTags = set(addTags) Line 1287: if delTags.intersection(addTags): Line 1288: raise se.VolumeGroupReplaceTagError( -- To view, visit http://gerrit.ovirt.org/23646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I127af299086ec5572d29686451d4892c9ff0330d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: collect vdsm-config.log
oVirt Jenkins CI Server has posted comments on this change. Change subject: vdsm-reg: collect vdsm-config.log .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6460/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7244/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7362/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24862 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I124442ecc81fa1ff849ddd57af406a8a68c40f9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use same constants for configuring and check configure of sa...
Dan Kenigsberg has posted comments on this change. Change subject: Use same constants for configuring and check configure of sanlock .. Patch Set 3: Code-Review-1 I should probably say that I share Federico's about class constant and needles %s. -- To view, visit http://gerrit.ovirt.org/24011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I424fdf30e0c5377846976505633d674f21ee7438 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
Nir Soffer has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: Verified+1 Rebase over dependent patch. Verified on RHEL 6.5 host and ovirt-engine 3.4 beta2: - starting and stopping vms - create and delete snapshot - create and delete template - create vm from template - remove vm -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: threadLocal: Cleanup thread local storage
Nir Soffer has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 4: Verified+1 Rebase over current master. Verified on RHEL 6.5 host and ovirt-engine 3.4 beta2: - starting and stopping vms - create and delete snapshot - create and delete template - create vm from template - remove vm -- To view, visit http://gerrit.ovirt.org/24309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Ensure that XMLRPC threads do not delay shutdown
Nir Soffer has posted comments on this change. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. Patch Set 2: Verified+1 Rebase over dependent patch. Verified on RHEL 6.5 host and ovirt-engine 3.4 beta2: - starting and stopping vms - create and delete snapshot - create and delete template - create vm from template - remove vm -- To view, visit http://gerrit.ovirt.org/24555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d3a1b062e7de61e7878b47291cca946f0f13af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
oVirt Jenkins CI Server has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6461/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7245/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7363/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: threadLocal: Cleanup thread local storage
oVirt Jenkins CI Server has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6463/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7247/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7365/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Ensure that XMLRPC threads do not delay shutdown
oVirt Jenkins CI Server has posted comments on this change. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6462/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7246/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7364/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/24555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67d3a1b062e7de61e7878b47291cca946f0f13af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-reg: eliminate the VDSMBRIDGE macro
Douglas Schilling Landgraf has posted comments on this change. Change subject: vdsm-reg: eliminate the VDSMBRIDGE macro .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa1dae084ae9df44c10e0f6ae43584544dab2b8d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: Ensure that XMLRPC threads do not delay shutdown
Dan Kenigsberg has submitted this change and it was merged. Change subject: utils: Ensure that XMLRPC threads do not delay shutdown .. utils: Ensure that XMLRPC threads do not delay shutdown The threads created by the XMLRPC server are not daemon threads, so they may delay vdsm shutdown if a long request happen to run during shutdown. This patch configure XMLRPC server to use daemon threads. The daemon_threads class attribute is used by SocketServer.ThreadingMixIn. When defined in base class, both the simple and secure servers get this configuration through inheritance. This change is required for adding HTTP/1.1 support, where XMLRPC server threads become long living threads. Change-Id: I67d3a1b062e7de61e7878b47291cca946f0f13af Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24555 Reviewed-by: Antoni Segura Puimedon asegu...@redhat.com Reviewed-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M lib/vdsm/utils.py 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nir Soffer: Verified Adam Litke: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Antoni Segura Puimedon: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24555 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67d3a1b062e7de61e7878b47291cca946f0f13af Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: threadLocal: Cleanup thread local storage
Dan Kenigsberg has posted comments on this change. Change subject: threadLocal: Cleanup thread local storage .. Patch Set 4: Code-Review+2 I like the code and I trust the verification. -- To view, visit http://gerrit.ovirt.org/24309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: threadLocal: Cleanup thread local storage
Dan Kenigsberg has submitted this change and it was merged. Change subject: threadLocal: Cleanup thread local storage .. threadLocal: Cleanup thread local storage We keep some data in thread local storage, but never clean up. This can lead to using stale data when handling many requests in the same tread, or to temporary leak, when a long running thread holds a reference to a finished task, preventing garbage collection of anything referenced from the task. This patch ensures that anything we set thread local storage is cleaned up when not needed. Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Signed-off-by: Nir Soffer nsof...@redhat.com Reviewed-on: http://gerrit.ovirt.org/24309 Reviewed-by: Adam Litke ali...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/BindingXMLRPC.py M vdsm/storage/dispatcher.py M vdsm/storage/storage_mailbox.py M vdsm/storage/task.py 4 files changed, 25 insertions(+), 6 deletions(-) Approvals: Nir Soffer: Verified Adam Litke: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/24309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I97b110db1c5f94e8561b4ba15a3c27b43043ed6f Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: Support HTTP 1.1
Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 .. Patch Set 6: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/24294/6//COMMIT_MSG Commit Message: Line 16: methods are used only on Python 2.6. Python 2.7 already include these Line 17: changes. Then the protocol_version is set to HTTP/1.1, enabling Line 18: automatic keep-alive. Line 19: Line 20: A new configuration option xmlrpc_http11 can be used to disbale this Configuration options are evil. I'm being over-dramatic, but they put the burden of choosing the right value on someone less familiar with the code. Why do we need this new configurable? Are there any expected side effects to using http/1.1 ? Who should disable it? When? Line 21: feature and use HTTP/1.0 as used before. Line 22: Line 23: We can see in the logs that only few threads are created now for service Line 24: XMLRPC requests, and most requests are handled by the same thread. -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Roy Golan rgo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.3]: packaging: update python-cpopen requirement to 1.3
Francesco Romani has posted comments on this change. Change subject: packaging: update python-cpopen requirement to 1.3 .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/24874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01cbf9668beff756051f61878fa1c8a5b3581295 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.3 Gerrit-Owner: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Douglas Schilling Landgraf dougsl...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stats: report detailed VM down status
oVirt Jenkins CI Server has posted comments on this change. Change subject: stats: report detailed VM down status .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/353/ : FAILURE http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6464/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/7248/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7366/ : FAILURE -- To view, visit http://gerrit.ovirt.org/22631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d7064fe79d1cd34499fbb32ed0644757cbe05dd Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
