Change in vdsm[master]: storage: Filter incomplete volumes from volume queries

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Filter incomplete volumes from volume queries
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56086
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I92acef22de8b1faaed0754fbddedfc2273095c3b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata
..

tests: volume_artifacts: validate FileVolumeArtifacts metadata

We now have the VolumeMetadata class which makes it possible to import
raw volume metadata for the purposes of verification.  Use this
infrastructure to validate the metadata created as part of
FileVolumeArtifacts create() in the same way we already do for
BlockVolumeArtifacts.

Change-Id: I366fd989b1387aa483a74e14dcfdc91b9f422060
Signed-off-by: Adam Litke 
---
M tests/storage_volume_artifacts_test.py
1 file changed, 11 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/56172/1

diff --git a/tests/storage_volume_artifacts_test.py 
b/tests/storage_volume_artifacts_test.py
index 47d3ea5..a0ea93a 100644
--- a/tests/storage_volume_artifacts_test.py
+++ b/tests/storage_volume_artifacts_test.py
@@ -256,10 +256,20 @@
 self.assertEqual(has_volume, os.path.exists(artifacts.volume_path))
 
 def validate_artifacts(self, artifacts, env):
-self.assertTrue(os.path.exists(artifacts.meta_volatile_path))
+self.validate_metadata(env, artifacts)
 self.assertTrue(os.path.exists(artifacts.volume_path))
 self.assertTrue(os.path.exists(artifacts.lease_path))
 
+def validate_metadata(self, env, artifacts):
+meta_path = artifacts.meta_volatile_path
+self.assertTrue(os.path.exists(meta_path))
+md_lines = env.sd_manifest.oop.directReadLines(meta_path)
+md = volume.VolumeMetadata.from_lines(md_lines)
+
+# Test a few fields just to check that metadata was written
+self.assertEqual(artifacts.sd_manifest.sdUUID, md.sd_id)
+self.assertEqual(artifacts.img_id, md.img_id)
+
 def failure(*args):
 raise ExpectedFailure()
 


-- 
To view, visit https://gerrit.ovirt.org/56172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I366fd989b1387aa483a74e14dcfdc91b9f422060
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: FakeLVM: Always create lv file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: FakeLVM: Always create lv file
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: storagetestlib: normalize make_file_volume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: storagetestlib: normalize make_file_volume
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56170
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I79a94da73e370541277ad6fa55fcf4655681e1c2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: storagetestlib: normalize make_file_volume

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: storagetestlib: normalize make_file_volume
..

tests: storagetestlib: normalize make_file_volume

The test utility make_block_volume was recently improved so that the
created volume had correct metadata in the fake storage domain.  Do the
same for make_file_volume and normalize the interface so that it works
like make_block_volume (ie. requires image and volume ids).

Change-Id: I79a94da73e370541277ad6fa55fcf4655681e1c2
Signed-off-by: Adam Litke 
---
M tests/domain_manifest_test.py
M tests/storagetestlib.py
M tests/storagetestlibTests.py
3 files changed, 45 insertions(+), 19 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/70/56170/1

diff --git a/tests/domain_manifest_test.py b/tests/domain_manifest_test.py
index 0d9a543..202fdfc 100644
--- a/tests/domain_manifest_test.py
+++ b/tests/domain_manifest_test.py
@@ -20,7 +20,7 @@
 import os
 import uuid
 
-from testlib import VdsmTestCase, make_file, recorded
+from testlib import VdsmTestCase, recorded
 from storagetestlib import (
 make_file_volume,
 fake_block_env,
@@ -35,21 +35,27 @@
 
 class FileManifestTests(VdsmTestCase):
 
+def setUp(self):
+self.img_id = str(uuid.uuid4())
+self.vol_id = str(uuid.uuid4())
+
 def test_getreaddelay(self):
 with fake_file_env() as env:
 self.assertIsInstance(env.sd_manifest.getReadDelay(), float)
 
 def test_getvsize(self):
 with fake_file_env() as env:
-sd_manifest = env.sd_manifest
-imguuid, voluuid = make_file_volume(sd_manifest.domaindir, VOLSIZE)
-self.assertEqual(VOLSIZE, sd_manifest.getVSize(imguuid, voluuid))
+make_file_volume(env.sd_manifest, VOLSIZE,
+ self.img_id, self.vol_id)
+self.assertEqual(VOLSIZE, env.sd_manifest.getVSize(
+self.img_id, self.vol_id))
 
 def test_getvallocsize(self):
 with fake_file_env() as env:
-sd_manifest = env.sd_manifest
-imguuid, voluuid = make_file_volume(sd_manifest.domaindir, VOLSIZE)
-self.assertEqual(0, sd_manifest.getVAllocSize(imguuid, voluuid))
+make_file_volume(env.sd_manifest, VOLSIZE,
+ self.img_id, self.vol_id)
+self.assertEqual(0, env.sd_manifest.getVAllocSize(
+self.img_id, self.vol_id))
 
 def test_getisodomainimagesdir(self):
 with fake_file_env() as env:
@@ -72,17 +78,16 @@
 def test_getallimages(self):
 with fake_file_env() as env:
 self.assertEqual(set(), env.sd_manifest.getAllImages())
-img_uuid = str(uuid.uuid4())
-make_file_volume(env.sd_manifest.domaindir, VOLSIZE, img_uuid)
-self.assertIn(img_uuid, env.sd_manifest.getAllImages())
+img_id = str(uuid.uuid4())
+vol_id = str(uuid.uuid4())
+make_file_volume(env.sd_manifest, VOLSIZE, img_id, vol_id)
+self.assertIn(img_id, env.sd_manifest.getAllImages())
 
 
 class BlockManifestTests(VdsmTestCase):
 
 def test_getreaddelay(self):
 with fake_block_env() as env:
-vg_name = env.sd_manifest.sdUUID
-make_file(env.lvm.lvPath(vg_name, 'metadata'))
 self.assertIsInstance(env.sd_manifest.getReadDelay(), float)
 
 def test_getvsize_active_lv(self):
diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index ebe2e0d..d005e28 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -136,15 +136,32 @@
 return manifest
 
 
-def make_file_volume(domaindir, size, imguuid=None, voluuid=None):
-imguuid = imguuid or str(uuid.uuid4())
-voluuid = voluuid or str(uuid.uuid4())
-volpath = os.path.join(domaindir, "images", imguuid, voluuid)
+def make_file_volume(sd_manifest, size, imguuid, voluuid,
+ parent_vol_id=volume.BLANK_UUID,
+ vol_format=volume.RAW_FORMAT,
+ prealloc=volume.SPARSE_VOL,
+ disk_type=image.UNKNOWN_DISK_TYPE,
+ desc='fake volume'):
+volpath = os.path.join(sd_manifest.domaindir, "images", imguuid, voluuid)
 mdfiles = [volpath + '.meta', volpath + '.lease']
 make_file(volpath, size)
 for mdfile in mdfiles:
 make_file(mdfile)
-return imguuid, voluuid
+
+size_blk = size / volume.BLOCK_SIZE
+vol_class = sd_manifest.getVolumeClass()
+vol_class.newMetadata(
+(volpath,),
+sd_manifest.sdUUID,
+imguuid,
+parent_vol_id,
+size_blk,
+volume.type2name(vol_format),
+volume.type2name(prealloc),
+volume.type2name(volume.LEAF_VOL),
+disk_type,
+desc,
+volume.LEGAL_VOL)
 
 
 def make_block_volume(lvm, sd_manifest, size, imguuid, voluuid,
diff --git 

Change in vdsm[master]: tests: FakeLVM: Always create lv file

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: FakeLVM: Always create lv file
..

tests: FakeLVM: Always create lv file

When creating Fake LVs always create a regular file at lvm.lvPath(...)
of the size passed into lvm.createLV.  This makes sure that storage code
will be able read from and write to the fake LV.

Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296
Signed-off-by: Adam Litke 
---
M tests/storagefakelib.py
M tests/storagetestlib.py
2 files changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/56169/1

diff --git a/tests/storagefakelib.py b/tests/storagefakelib.py
index b17a526..320842a 100644
--- a/tests/storagefakelib.py
+++ b/tests/storagefakelib.py
@@ -23,7 +23,7 @@
 from contextlib import contextmanager
 from copy import deepcopy
 
-from testlib import recorded
+from testlib import make_file, recorded
 
 from vdsm.storage import exception as se
 
@@ -133,6 +133,9 @@
 self.lvmd[(vgName, lvName)] = lv_md
 self.vgmd[vgName]['lv_count'] = str(lv_count)
 
+# Create a regular file so we have a place to write data
+make_file(self.lvPath(vgName, lvName), int(size))
+
 def activateLVs(self, vgName, lvNames):
 for lv in lvNames:
 try:
diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index 236adb4..ebe2e0d 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -90,11 +90,6 @@
   blockSD.VG_METADATASIZE)
 fake_lvm.createLV(sduuid, sd.METADATA, blockSD.SD_METADATA_SIZE)
 
-# Create the metadata LV for storing volume metadata
-metafile_path = fake_lvm.lvPath(sduuid, sd.METADATA)
-make_file(metafile_path,
-  blockSD.BlockStorageDomainManifest.metaSize(sduuid) * MB)
-
 # Create the rest of the special LVs
 for metafile, sizemb in sd.SPECIAL_VOLUME_SIZES_MIB.iteritems():
 fake_lvm.createLV(sduuid, metafile, sizemb)


-- 
To view, visit https://gerrit.ovirt.org/56169
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia364588a9fbe3a987b9117522db025e92c8ed296
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_missing_tags for block storage

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add test_missing_tags for block storage
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Refactor metadata operations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Refactor metadata operations
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/52671
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4fee56b30c13a3c1cede8489338ed60f4e1d5eab
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: volume_artifacts: validate FileVolumeArtifacts metadata

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: volume_artifacts: validate FileVolumeArtifacts metadata
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56172
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I366fd989b1387aa483a74e14dcfdc91b9f422060
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add test_missing_tags for block storage

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: tests: Add test_missing_tags for block storage
..

tests: Add test_missing_tags for block storage

Add a simple test that verifies that volumes with missing tags are not
returned by getAllVolumes.

Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Signed-off-by: Adam Litke 
---
M tests/Makefile.am
M tests/blocksdTests.py
A tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out
3 files changed, 10 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/56171/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 86aee59..5020fd9 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -224,6 +224,7 @@
glusterVolumeTasks.xml \
iscsiadm_-m_iface.out \
lvs_3386c6f2-926f-42c4-839c-38287fac8998.out \
+   lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out \
mem_info.out \
toolTests_empty.conf \
toolTests_lconf_ssl.conf \
diff --git a/tests/blocksdTests.py b/tests/blocksdTests.py
index 0ba9244..dc522d5 100644
--- a/tests/blocksdTests.py
+++ b/tests/blocksdTests.py
@@ -84,3 +84,9 @@
 sdName = "3386c6f2-926f-42c4-839c-38287fac8998"
 allVols = blockSD.getAllVolumes(sdName)
 self.assertEqual(len(allVols), 23)
+
+@MonkeyPatch(lvm, 'getLV', fakeGetLV)
+def test_missing_tags(self):
+sdName = "f9e55e18-67c4-4377-8e39-5833ca422bef"
+allVols = blockSD.getAllVolumes(sdName)
+self.assertEqual(len(allVols), 1)
diff --git a/tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out 
b/tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out
new file mode 100644
index 000..119693a
--- /dev/null
+++ b/tests/lvs_f9e55e18-67c4-4377-8e39-5833ca422bef.out
@@ -0,0 +1,3 @@
+  
3oqnyE-86gI-ZcF4-or87-Jt1j-6DdQ-hcGUyl|0574c3f6-3d44-4cc7-98e3-6d90626dd95f|f9e55e18-67c4-4377-8e39-5833ca422bef|-wi-|2147483648|0|/dev/mapper/1Dafna-rhevm11333889(195)|MD_17,IU_ae863f0d-0f24-41d4-b6ed-333c6634c7dc
+  
c6fE1p-7Uwi-tnPA-CZjt-uxwg-j5aK-bWbs34|0641b528-c72c-45ed-94bc-7090085a0d4b|f9e55e18-67c4-4377-8e39-5833ca422bef|-wi-|2147483648|0|/dev/mapper/1Dafna-rhevm11333889(259)|PU_----,MD_21
+  
ju1mna-9CU4-QwEH-lC74-fOM1-bq2w-rMhTAx|128f0b4a-2ed0-4ea1-84a5-105c6721f4b7|f9e55e18-67c4-4377-8e39-5833ca422bef|-wi-|2147483648|0|/dev/mapper/1Dafna-rhevm11333889(211)|MD_24,PU_----,IU_8e6eef9f-457b-4145-ace7-19d35938a80b


-- 
To view, visit https://gerrit.ovirt.org/56171
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb789cf146a4a9919e4dc864a0ae744e06510cec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: VolumeMetadata: Add from_lines factory method

[automation]

gerrit-hooks has posted comments on this change.

Change subject: VolumeMetadata: Add from_lines factory method
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/52672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7f63dce8e42e99d3240f4e916a9bd6ee5ee4b61
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: travis: Add missing packages to Dockerfile

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: travis: Add missing packages to Dockerfile
..


Patch Set 2:

ping?

-- 
To view, visit https://gerrit.ovirt.org/55738
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie71d2e6825c0d27b30c38df086c6155e275902d7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Add basic BlockVolumeArtifacts
..


Patch Set 2:

(5 comments)

https://gerrit.ovirt.org/#/c/55987/2/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 103: self.img_id, str(uuid.uuid4()))
Line 104: self.assertRaises(se.InvalidParameterException, 
second.create,
Line 105:   *BASE_RAW_PARAMS)
Line 106: 
Line 107: def test_create_same_volume_in_image(self):
> look at using brokentest
Done
Line 108: with self.fake_env() as env:
Line 109: artifacts = env.sd_manifest.get_volume_artifacts(
Line 110: self.img_id, self.vol_id)
Line 111: artifacts.create(*BASE_RAW_PARAMS)


Line 138: self.assertEqual(str(disk_type), vol.getDiskType())
Line 139: 
Line 140: # Artifacts visibility
Line 141: 
Line 142: def test_getallvolumes(self):
> this test duplicates blocksdtests and filesdtests logic.
Decided to keep this since it tests using artifacts code and also using our 
fake env whereas blocksdtests test by using faked lvm output.
Line 143: # Artifacts must not be recognized as volumes until commit is 
called.
Line 144: with fake_file_env() as env:
Line 145: self.assertEqual({}, env.sd_manifest.getAllVolumes())
Line 146: artifacts = env.sd_manifest.get_volume_artifacts(


Line 140: # Artifacts visibility
Line 141: 
Line 142: def test_getallvolumes(self):
Line 143: # Artifacts must not be recognized as volumes until commit is 
called.
Line 144: with fake_file_env() as env:
> use self.fake_env()
Done
Line 145: self.assertEqual({}, env.sd_manifest.getAllVolumes())
Line 146: artifacts = env.sd_manifest.get_volume_artifacts(
Line 147: self.img_id, self.vol_id)
Line 148: artifacts.create(*BASE_RAW_PARAMS)


Line 296: artifacts.commit()
Line 297: vol = env.sd_manifest.produceVolume(self.img_id, 
self.vol_id)
Line 298: self.assertEqual(volume.PREALLOCATED_VOL, vol.getType())
Line 299: 
Line 300: def validate_artifacts(self, artifacts, env):
> put this at the end.
Done
Line 301: try:
Line 302: lv = env.lvm.getLV(artifacts.sd_manifest.sdUUID, 
artifacts.vol_id)
Line 303: except se.LogicalVolumeDoesNotExistError:
Line 304: raise AssertionError("LV missing")


Line 305: 
Line 306: if TEMP_VOL_LVTAG not in lv.tags:
Line 307: raise AssertionError("Missing TEMP_VOL_LVTAG")
Line 308: 
Line 309: # TODO: Validate lease and metadata allocation
> Use VolumeArtifacts patches to validate the metadata block.
Added support for validating metadata.  Lease cannot be verified since lease 
initialization currently does nothing.
Line 310: 
Line 311: # Invalid use of artifacts
Line 312: 
Line 313: def test_commit_without_create(self):


-- 
To view, visit https://gerrit.ovirt.org/55987
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4120c557fc89d82cc6bc854a9fdc8935e53bc93d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Validate qcow2_compat configuration

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Validate qcow2_compat configuration
..


Patch Set 2:

Version 2 document the supported options in the configuration file comments.

 # Recent qemu-img supports two incompatible qcow2 versions. We use
 # 0.10 format by default so hosts with older qemu can consume images
 # created by newer versions. See https://bugzilla.redhat.com/1139707
 # (supported versions: 0.10, 1.1)
 # qcow2_compat = 0.10

-- 
To view, visit https://gerrit.ovirt.org/56110
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e217ec42a803d53403947a5fb140cb51202fbfa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Gashev 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Make QCOW2_COMPAT configurable

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Make QCOW2_COMPAT configurable
..


Patch Set 4:

* #1317850::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1317850::OK, public bug
* Check Product::#1317850::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/54759
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5272171a4b4931698911ab251e3a34c286908be4
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Pavel Gashev 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Validate qcow2_compat configuration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Validate qcow2_compat configuration
..


Patch Set 2:

* #1317850::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1317850::OK, public bug
* Check Product::#1317850::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56110
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e217ec42a803d53403947a5fb140cb51202fbfa
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Gashev 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[alitke]

Adam Litke has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 28: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[alitke]

Adam Litke has submitted this change and it was merged.

Change subject: rwlock: Add simpler RWLock
..


rwlock: Add simpler RWLock

This is a rewrite of storage.misc.RWLock, simplifying it and making it
easier to understand. The behavior of the lock should be the same,
acquiring the lock in the order of the requests, and supporting
recursive locking, required for old storage code locking the same
resource from different layers.

This implementation does not support lock demotion (replacing a write
lock with a read lock). This feature was broken in the previous
implementation.

This implementation is using a list of waiters instead of a Queue, since
we don't need any of the features provided by a Queue. Important
property of a list is the possibility to remove a waiter from the middle
of the list, in case of a timeout. This is used by future patch
supporting timed acquire.

This implementation has less overhead, as seen in the stress tests
with many writers and readers. The test measure the number of times each
thread could take a shared (readers) or exclusive (writers) lock during
the test (1 second). Larger numbers mean more throughput. Tested on
Lenovo T450s.

storage_rwlock_test.RWLockStressTests

test_lock_contention(1, 2, )
writers: 1 readers: 2
writes  avg=5438.00 med=5438 min=5438 max=5438
reads   avg=5449.50 med=5450 min=5449 max=5450

test_lock_contention(1, 2, )
writers: 1 readers: 2
writes  avg=6574.00 med=6574 min=6574 max=6574
reads   avg=6598.00 med=6625 min=6571 max=6625

test_lock_contention(2, 8, )
writers: 2 readers: 8
writes  avg=1334.50 med=1335 min=1334 max=1335
reads   avg=1334.50 med=1335 min=1334 max=1335

test_lock_contention(2, 8, )
writers: 2 readers: 8
writes  avg=1504.50 med=1505 min=1504 max=1505
reads   avg=1504.00 med=1504 min=1503 max=1507

test_lock_contention(3, 32, )
writers: 3 readers: 32
writes  avg=386.00 med=386 min=386 max=386
reads   avg=386.12 med=386 min=385 max=387

test_lock_contention(3, 32, )
writers: 3 readers: 32
writes  avg=403.00 med=403 min=403 max=403
reads   avg=403.50 med=403 min=403 max=408

test_lock_contention(4, 128, )
writers: 4 readers: 128
writes  avg=101.00 med=101 min=101 max=101
reads   avg=101.15 med=101 min=101 max=103

test_lock_contention(4, 128, )
writers: 4 readers: 128
writes  avg=101.00 med=101 min=101 max=101
reads   avg=101.93 med=102 min=101 max=108

test_readers(1, )
reads   avg=47546.00 med=47546 min=47546 max=47546

test_readers(1, )
reads   avg=170239.00 med=170239 min=170239 max=170239

test_readers(128, )
reads   avg=136.00 med=135 min=134 max=167

test_readers(128, )
reads   avg=361.10 med=332 min=330 max=1321

test_readers(16, )
reads   avg=1125.75 med=1100 min=1096 max=1391

test_readers(16, )
reads   avg=3070.19 med=2945 min=2803 max=3658

test_readers(2, )
reads   avg=10040.50 med=10053 min=10028 max=10053

test_readers(2, )
reads   avg=30227.50 med=31197 min=29258 max=31197

test_readers(32, )
reads   avg=551.56 med=541 min=540 max=832

test_readers(32, )
reads   avg=1480.53 med=1404 min=1401 max=2348

test_readers(4, )
reads   avg=4708.25 med=4758 min=4583 max=4869

test_readers(4, )
reads   avg=12305.25 med=12789 min=11618 max=13065

test_readers(64, )
reads   avg=279.27 med=276 min=275 max=403

test_readers(64, )
reads   avg=727.44 med=686 min=683 max=1747

test_readers(8, )
reads   avg=2264.38 med=2230 min=2226 max=2471

test_readers(8, )
reads   avg=6466.88 med=6520 min=5674 max=7277

To run this test, use:

./run_tests_local.sh --enable-stress-tests -s 
storage_rwlock_test.py:RWLockStressTests

Change-Id: I2466c137c89598772fb46347eb02195916883cac
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/42908
Continuous-Integration: Jenkins CI
Reviewed-by: Adam Litke 
---
M debian/vdsm-python.install
M lib/vdsm/storage/Makefile.am
A lib/vdsm/storage/rwlock.py
M tests/Makefile.am
R tests/storage_rwlock_test.py
M vdsm.spec.in
6 files changed, 263 insertions(+), 93 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 

Change in vdsm[master]: rwlock: Add simpler RWLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 29:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 29
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 28:

This version change the tests so we test both old and new implementations, so 
we can merge this code now before the next patch.

The commit message was updated with the tests of both locks on newer machine.

-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 28: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: qemu-kvm-img to handle unaligned images

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: qemu-kvm-img to handle unaligned images
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/56142/1//COMMIT_MSG
Commit Message:

Line 15: in EL's qemu-kvm-[rh]ev-2.3.0-31.el7_2.6 (available on RHEL/CentOS
Line 16: 7.2.z).
Line 17: 
Line 18: This patch bumps the requirements to make sure we're using a qemu-img
Line 19: version which fixes this issue.
> Why do we care about this? are we using non-aligned images?
AFAIK, PPC is hit by this. Daniel?
Line 20: 
Line 21: Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Line 22: Bug-Url: https://bugzilla.redhat.com/1283278


Line 18: This patch bumps the requirements to make sure we're using a qemu-img
Line 19: version which fixes this issue.
Line 20: 
Line 21: Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Line 22: Bug-Url: https://bugzilla.redhat.com/1283278
> According to https://bugzilla.redhat.com/show_bug.cgi?id=1283278#c7
I don't get how the version bump introduced in that patch fixes this. The 
numbering looks off.


-- 
To view, visit https://gerrit.ovirt.org/56142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add readers contention rwlock test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add readers contention rwlock test
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add readers contention rwlock test

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: tests: Add readers contention rwlock test
..


tests: Add readers contention rwlock test

Add timing test for taking a shared lock on a RWLock. This should be a
common operation, and it is interesting to see how it differ from
readers and writers connotation.

Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/51923
Reviewed-by: Adam Litke 
Continuous-Integration: Jenkins CI
---
M tests/rwlock_test.py
1 file changed, 31 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Replace misc.RWLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rwlock: Replace misc.RWLock
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/43423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ae6064e8e031339303e64606a70673807c4083a
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 28:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 28
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockVolume: Move _calculate_volume_alloc_size to Manifest

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: blockVolume: Move _calculate_volume_alloc_size to Manifest
..


blockVolume: Move _calculate_volume_alloc_size to Manifest

_calculate_volume_alloc_size contains logic that is generally useful for
creating new block volumes.  Move it to the BlockVolumeManifest class
(and make it public) so that it can be used by the SDM VolumeArtifacts
class in the future.

Change-Id: I53e0a5f231a91a0405a5cad4133fd52f6db79f63
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/55986
Reviewed-by: Freddy Rolland 
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/blockVolumeTests.py
M tests/sdm_indirection_tests.py
M vdsm/storage/blockVolume.py
3 files changed, 51 insertions(+), 35 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53e0a5f231a91a0405a5cad4133fd52f6db79f63
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add readers contention rwlock test

[alitke]

Adam Litke has posted comments on this change.

Change subject: tests: Add readers contention rwlock test
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockVolume: Move _calculate_volume_alloc_size to Manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockVolume: Move _calculate_volume_alloc_size to Manifest
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e0a5f231a91a0405a5cad4133fd52f6db79f63
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: Add readers contention rwlock test

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add readers contention rwlock test
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/51923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Add simpler RWLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rwlock: Add simpler RWLock
..


Patch Set 27:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/42908
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac
Gerrit-PatchSet: 27
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dima Kuznetsov 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: rwlock: Replace misc.RWLock

[automation]

gerrit-hooks has posted comments on this change.

Change subject: rwlock: Replace misc.RWLock
..


Patch Set 23:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/43423
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ae6064e8e031339303e64606a70673807c4083a
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockVolume: Move _calculate_volume_alloc_size to Manifest

[alitke]

Adam Litke has posted comments on this change.

Change subject: blockVolume: Move _calculate_volume_alloc_size to Manifest
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e0a5f231a91a0405a5cad4133fd52f6db79f63
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: blockVolume: Move _calculate_volume_alloc_size to Manifest

[automation]

gerrit-hooks has posted comments on this change.

Change subject: blockVolume: Move _calculate_volume_alloc_size to Manifest
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55986
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e0a5f231a91a0405a5cad4133fd52f6db79f63
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: qemu-kvm-img to handle unaligned images

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: qemu-kvm-img to handle unaligned images
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56142/1//COMMIT_MSG
Commit Message:

Line 18: This patch bumps the requirements to make sure we're using a qemu-img
Line 19: version which fixes this issue.
Line 20: 
Line 21: Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Line 22: Bug-Url: https://bugzilla.redhat.com/1283278
According to https://bugzilla.redhat.com/show_bug.cgi?id=1283278#c7
the issue was already fixed in https://gerrit.ovirt.org/50435


-- 
To view, visit https://gerrit.ovirt.org/56142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: fixes for pep8 1.6.x

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: fixes for pep8 1.6.x
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56084/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 109: # verify that the cached path is the one used in 
libvirt.
Line 110: # We already hit few times the problem that after a 
live
Line 111: # migration the paths were not in sync anymore 
(BZ#1059482).
Line 112: if (hasattr(d, 'alias') and d.alias == alias and
Line 113:d.path != devPath):
> Indented like you suggested (which was my first choice btw):
This is our current style, enforced by pep 1.5.7. Any reason to change it?
Line 114: vm.log.warning('updating drive %s path from %s to 
%s',
Line 115:d.alias, d.path, devPath)
Line 116: d.path = devPath
Line 117: if d.path == devPath:


-- 
To view, visit https://gerrit.ovirt.org/56084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06319d0be2cc927ecd3f2bf15f0688bdac11dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configure: add support for nosetests/python 3.5

[fromani]

Francesco Romani has posted comments on this change.

Change subject: configure: add support for nosetests/python 3.5
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:

Line 289:   fi
Line 290: 
Line 291:   AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
Line 292:   if test "x$PYTHON3_NOSE" = "x"; then
Line 293: AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.5])
> Sounds better, do you plan to replace this check with import check?
yes, and to do so I'll need to refresh my autoconf knowledge
Line 294:   fi
Line 295:   if test "x$PYTHON3_NOSE" = "x"; then
Line 296: AC_MSG_ERROR([python3-nose not found])
Line 297:   fi


-- 
To view, visit https://gerrit.ovirt.org/56083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: fixes for pep8 1.6.x

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: fixes for pep8 1.6.x
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56084/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 109: # verify that the cached path is the one used in 
libvirt.
Line 110: # We already hit few times the problem that after a 
live
Line 111: # migration the paths were not in sync anymore 
(BZ#1059482).
Line 112: if (hasattr(d, 'alias') and d.alias == alias and
Line 113:d.path != devPath):
> This is accepted by pep8?!
Indented like you suggested (which was my first choice btw):

[fromani@fedrkt vdsm]$ pep8 --version
1.6.2
[fromani@fedrkt vdsm]$ pep8 vdsm/virt/vmdevices/storage.py 
vdsm/virt/vmdevices/storage.py:113:5: E129 visually indented line with same 
indent as next logical line

however, if indent another level, so the source code ends up like

if (hasattr(d, 'alias') and d.alias == alias and
d.path != devPath):

pep8 doesn't complain.
Line 114: vm.log.warning('updating drive %s path from %s to 
%s',
Line 115:d.alias, d.path, devPath)
Line 116: d.path = devPath
Line 117: if d.path == devPath:


-- 
To view, visit https://gerrit.ovirt.org/56084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06319d0be2cc927ecd3f2bf15f0688bdac11dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configure: add support for nosetests/python 3.5

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: configure: add support for nosetests/python 3.5
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:

Line 289:   fi
Line 290: 
Line 291:   AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
Line 292:   if test "x$PYTHON3_NOSE" = "x"; then
Line 293: AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.5])
> I agree, the correct fix is to check if python3 can import nose.
Sounds better, do you plan to replace this check with import check?

python3 -c 'import nose'?
Line 294:   fi
Line 295:   if test "x$PYTHON3_NOSE" = "x"; then
Line 296: AC_MSG_ERROR([python3-nose not found])
Line 297:   fi


-- 
To view, visit https://gerrit.ovirt.org/56083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configure: add support for nosetests/python 3.5

[fromani]

Francesco Romani has posted comments on this change.

Change subject: configure: add support for nosetests/python 3.5
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:

Line 289:   fi
Line 290: 
Line 291:   AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
Line 292:   if test "x$PYTHON3_NOSE" = "x"; then
Line 293: AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.5])
> This is crazy, why should we care about python 3.4 and 3.5? python3 should 
I agree, the correct fix is to check if python3 can import nose.
Line 294:   fi
Line 295:   if test "x$PYTHON3_NOSE" = "x"; then
Line 296: AC_MSG_ERROR([python3-nose not found])
Line 297:   fi


-- 
To view, visit https://gerrit.ovirt.org/56083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hsm: add untrusted image verification.
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hsm: add untrusted image verification.

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: hsm: add untrusted image verification.
..


hsm: add untrusted image verification.

In some flows, where an image can be imported into oVirt's storage from
external sources, e.g in the image upload flow- a VDSM's image is being
generated and data is being sent into the created volume inside.

As this flow is risky in cases where the data is a QCOW file with an
invalid backing file, or wrong disk format is sent, VDSM should verify
the image in the upload process.

This patch adds a verb for untrusted image's volume verification, which
verifies that there is no backing file for a QCOW image, and that the
format of the uploaded image fits to what the user has specified.

Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Signed-off-by: Amit Aviram 
Reviewed-on: https://gerrit.ovirt.org/55746
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M lib/api/vdsmapi-schema.json
M lib/vdsm/storage/exception.py
M vdsm/API.py
M vdsm/storage/hsm.py
4 files changed, 57 insertions(+), 0 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Amit Aviram: Verified



-- 
To view, visit https://gerrit.ovirt.org/55746
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf85061536eb4ddff021539c742a674f183a8984
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Greg Padgett 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: qemu-kvm-img to handle unaligned images

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: qemu-kvm-img to handle unaligned images
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56142/1//COMMIT_MSG
Commit Message:

Line 15: in EL's qemu-kvm-[rh]ev-2.3.0-31.el7_2.6 (available on RHEL/CentOS
Line 16: 7.2.z).
Line 17: 
Line 18: This patch bumps the requirements to make sure we're using a qemu-img
Line 19: version which fixes this issue.
Why do we care about this? are we using non-aligned images?
Line 20: 
Line 21: Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Line 22: Bug-Url: https://bugzilla.redhat.com/1283278


-- 
To view, visit https://gerrit.ovirt.org/56142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: support new dd output

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: support new dd output
..


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56091/2/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 214
Line 215
Line 216
Line 217
Line 218
Please use the logic in storage/check.py:

- separate the last line, fail on empty output
- extract the seconds 
- parse the value as float


Line 210: log.error("Unable to find dd statistics to parse")
Line 211: raise se.MiscFileReadException(path)
Line 212: 
Line 213: if time_elapsed.endswith(' s'):
Line 214: time_elapsed = time_elapsed[:-2]
It always ends with s, and we don't care how many spaces separate the s from 
the number. Use split(None, 1)[0] to extract the number.
Line 215: 
Line 216: try:
Line 217: seconds = float(time_elapsed)
Line 218: except ValueError:


-- 
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: readspeed: drop useless return value

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: readspeed: drop useless return value
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/56160/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 187
Line 188
Line 189
Line 190
Line 191
Please remove the group, we are not interested in capturing it.


Line 193: "([\de\-.]+|Infinity) [kMGT]*B/s"
Line 194: )
Line 195: 
Line 196: 
Line 197: def read_delay(path, buffersize=None):
This function is going to be removed, don't rename it, and it is also not 
related to the real change.
Line 198: """
Line 199: Measures the amount of bytes transferred and the time elapsed
Line 200: reading the content of the file/device
Line 201: """


-- 
To view, visit https://gerrit.ovirt.org/56160
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22cc27a04603e8f53c5103283c3b4d64a4fabcec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configure: add support for nosetests/python 3.5

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: configure: add support for nosetests/python 3.5
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56083/3/configure.ac
File configure.ac:

Line 289:   fi
Line 290: 
Line 291:   AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.4])
Line 292:   if test "x$PYTHON3_NOSE" = "x"; then
Line 293: AC_PATH_PROG([PYTHON3_NOSE], [nosetests-3.5])
This is crazy, why should we care about python 3.4 and 3.5? python3 should be 
good enough for us.
Line 294:   fi
Line 295:   if test "x$PYTHON3_NOSE" = "x"; then
Line 296: AC_MSG_ERROR([python3-nose not found])
Line 297:   fi


-- 
To view, visit https://gerrit.ovirt.org/56083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: fixes for pep8 1.6.x

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: fixes for pep8 1.6.x
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/56084/3/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 109: # verify that the cached path is the one used in 
libvirt.
Line 110: # We already hit few times the problem that after a 
live
Line 111: # migration the paths were not in sync anymore 
(BZ#1059482).
Line 112: if (hasattr(d, 'alias') and d.alias == alias and
Line 113:d.path != devPath):
This is accepted by pep8?!

This should be:

if (condition ... and
other condition):

It must be aligned with the (, if pep8 want it or not.
Line 114: vm.log.warning('updating drive %s path from %s to 
%s',
Line 115:d.alias, d.path, devPath)
Line 116: d.path = devPath
Line 117: if d.path == devPath:


-- 
To view, visit https://gerrit.ovirt.org/56084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06319d0be2cc927ecd3f2bf15f0688bdac11dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: improve miscTests::ReadSpeed

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: improve miscTests::ReadSpeed
..


Patch Set 1:

(1 comment)

This better than the old tests, but the function and the tests are going to be 
removed, so there is no point in this change. I would just add the missing 
tests.

https://gerrit.ovirt.org/#/c/56159/1/tests/miscTests.py
File tests/miscTests.py:

Line 879: with MonkeyPatchScope([(misc, 'execCmd', _fake_exec_cmd)]):
Line 880: speed = misc.readspeed('useless')
Line 881: 
Line 882: self.assertEquals(speed["bytes"], int(bytes_read))
Line 883: self.assertAlmostEqual(speed["seconds"], float(seconds))
misc.readspeed is about to die soon, replaced by storage.check.CheckResult, 
which is much easier to test, so I don't think we should invest in improving 
these tests by mocking execCmd. The best way to test this is to test only the 
parsing, as done in storage_check_test.py.

See https://gerrit.ovirt.org/#/c/54757/34/tests/storage_check_test.py
Line 884: 
Line 885: 
Line 886: class PidExists(TestCaseBase):
Line 887: 


-- 
To view, visit https://gerrit.ovirt.org/56159
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5aef61848b0d237c2250fd8b8e6b4ee9ee88e299
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: improve miscTests::ReadSpeed

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: improve miscTests::ReadSpeed
..


Patch Set 1: Verified+1

took additional preparatory cleanup step. Verified running the tests themselves

-- 
To view, visit https://gerrit.ovirt.org/56159
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5aef61848b0d237c2250fd8b8e6b4ee9ee88e299
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: support new dd output

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: support new dd output
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56091/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 188: return str(ctime)
Line 189: 
Line 190: _readspeed_regex = re.compile(
Line 191: "(?P\d+) bytes?"
Line 192: "(|( \([\de\-.]+ [kMGT]*B(|, [\de\-.]+ [KMGT]*iB)\))) copied, "
> I would do this:
I took action before to read this, but I'll fix to make sure I'm following 
those directions.
Line 193: "(?P[\de\-.]+) s, "
Line 194: "([\de\-.]+|Infinity) [kMGT]*B/s"
Line 195: )
Line 196: 


-- 
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: improve miscTests::ReadSpeed

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: improve miscTests::ReadSpeed
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56159
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5aef61848b0d237c2250fd8b8e6b4ee9ee88e299
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: fixes for pep8 1.6.x

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: fixes for pep8 1.6.x
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56084
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e06319d0be2cc927ecd3f2bf15f0688bdac11dc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: configure: add support for nosetests/python 3.5

[automation]

gerrit-hooks has posted comments on this change.

Change subject: configure: add support for nosetests/python 3.5
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1d5f0a8545ff0d3f3071a58f327a61892a57a71a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: readspeed: drop useless return value

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: storage: readspeed: drop useless return value
..

storage: readspeed: drop useless return value

storage.misc.readspeed used to return a two-item
dictionary, with both bytes read and the time in seconds
the read took.

The code never uses the bytes attribute, so this patch
simplifies the return value to just one float, the
elapsed time.

The function was also rename 'read_delay' to make
it more descriptive.

Change-Id: I22cc27a04603e8f53c5103283c3b4d64a4fabcec
Signed-off-by: Francesco Romani 
---
M tests/miscTests.py
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/misc.py
4 files changed, 19 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/56160/1

diff --git a/tests/miscTests.py b/tests/miscTests.py
index 638326a..2a24e6c 100644
--- a/tests/miscTests.py
+++ b/tests/miscTests.py
@@ -841,32 +841,22 @@
 
 
 @expandPermutations
-class ReadSpeed(TestCaseBase):
+class TestReadDelay(TestCaseBase):
 
 @permutations([
-# output line, bytes read, seconds
-("1 byte (1 B) copied, 1 s, 1 B/s",
- "1", "1"),
-("1024 bytes (1 kB) copied, 1 s, 1 kB/s",
- "1024", "1"),
-("1572864 bytes (1.5 MB) copied, 1.5 s, 1 MB/s",
- "1572864", "1.5"),
-("1610612736 bytes (1.5 GB) copied, 1000.5 s, 1.53 MB/s",
- "1610612736", "1000.5"),
-("479 bytes (479 B) copied, 5.6832e-05 s, 8.4 MB/s",
- "479", "5.6832e-05"),
-("512 bytes (512e-3 MB) copied, 1 s, 512e-3 MB/s",
- "512", "1"),
-("524288 bytes (512e3 B) copied, 1 s, 512e3 B/s",
- "524288", "1"),
-("517 bytes (517 B) copied, 0 s, Infinity B/s",
- "517", "0"),
-("4096 bytes (4.1 kB) copied, 0.00135703 s, 3.0 MB/s",
- "4096", "0.00135703"),
-("30 bytes (30 B) copied, 0.0033204 s, 9.0 kB/s",
- "30", "0.0033204"),
+# output line, seconds
+("1 byte (1 B) copied, 1 s, 1 B/s", "1"),
+("1024 bytes (1 kB) copied, 1 s, 1 kB/s", "1"),
+("1572864 bytes (1.5 MB) copied, 1.5 s, 1 MB/s", "1.5"),
+("1610612736 bytes (1.5 GB) copied, 1000.5 s, 1.53 MB/s", "1000.5"),
+("479 bytes (479 B) copied, 5.6832e-05 s, 8.4 MB/s", "5.6832e-05"),
+("512 bytes (512e-3 MB) copied, 1 s, 512e-3 MB/s", "1"),
+("524288 bytes (512e3 B) copied, 1 s, 512e3 B/s", "1"),
+("517 bytes (517 B) copied, 0 s, Infinity B/s", "0"),
+("4096 bytes (4.1 kB) copied, 0.00135703 s, 3.0 MB/s", "0.00135703"),
+("30 bytes (30 B) copied, 0.0033204 s, 9.0 kB/s", "0.0033204"),
 ])
-def test_readspeed(self, output_line, bytes_read, seconds):
+def test_read_delay(self, output_line, seconds):
 output = (
 "0+1 records in",
 "0+1 records out",
@@ -877,10 +867,9 @@
 return 0, None, output
 
 with MonkeyPatchScope([(misc, 'execCmd', _fake_exec_cmd)]):
-speed = misc.readspeed('useless')
+delay = misc.read_delay('useless')
 
-self.assertEquals(speed["bytes"], int(bytes_read))
-self.assertAlmostEqual(speed["seconds"], float(seconds))
+self.assertAlmostEqual(delay, float(seconds))
 
 
 class PidExists(TestCaseBase):
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index e2d413a..4fd52bb 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -433,8 +433,7 @@
 return meta
 
 def getReadDelay(self):
-stats = misc.readspeed(lvm.lvPath(self.sdUUID, sd.METADATA), 4096)
-return stats['seconds']
+return misc.read_delay(lvm.lvPath(self.sdUUID, sd.METADATA), 4096)
 
 def getVSize(self, imgUUUID, volUUID):
 """ Return the block volume size in bytes. """
diff --git a/vdsm/storage/fileSD.py b/vdsm/storage/fileSD.py
index dac383d..887eee2 100644
--- a/vdsm/storage/fileSD.py
+++ b/vdsm/storage/fileSD.py
@@ -171,8 +171,7 @@
 raise se.StorageDomainMetadataNotFound(self.sdUUID, self.metafile)
 
 def getReadDelay(self):
-stats = misc.readspeed(self.metafile, 4096)
-return stats['seconds']
+return misc.read_delay(self.metafile, 4096)
 
 def getVSize(self, imgUUID, volUUID):
 """ Returns file volume size in bytes. """
diff --git a/vdsm/storage/misc.py b/vdsm/storage/misc.py
index 75a43d3..c8247f6 100644
--- a/vdsm/storage/misc.py
+++ b/vdsm/storage/misc.py
@@ -194,7 +194,7 @@
 )
 
 
-def readspeed(path, buffersize=None):
+def read_delay(path, buffersize=None):
 """
 Measures the amount of bytes transferred and the time elapsed
 reading the content of the file/device
@@ -221,10 +221,7 @@
 log.error("Unable to parse dd output: '%s'", err[-1])
 raise se.MiscFileReadException(path)
 
-return {
-'bytes': int(m.group('bytes')),
-

Change in vdsm[master]: storage: readspeed: drop useless return value

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: readspeed: drop useless return value
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56160
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22cc27a04603e8f53c5103283c3b4d64a4fabcec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: support new dd output

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: support new dd output
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: improve miscTests::ReadSpeed

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: tests: improve miscTests::ReadSpeed
..

tests: improve miscTests::ReadSpeed

miscTests::ReadSpeed where meant to test the storage.misc.readspeed()
function, but they where testing against an implementation detail,
rather than the interface.

This patch modifies the tests, using monkeypatching, to test
against the interface, preparing the ground for more tests
and for future patch to enhance the compatibility with the new
dd output (coreutils >= 8.25.5).

We also add few more test cases, taken from real environment and
not made up.

Change-Id: I5aef61848b0d237c2250fd8b8e6b4ee9ee88e299
Signed-off-by: Francesco Romani 
---
M tests/miscTests.py
1 file changed, 21 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/56159/1

diff --git a/tests/miscTests.py b/tests/miscTests.py
index 74f5636..638326a 100644
--- a/tests/miscTests.py
+++ b/tests/miscTests.py
@@ -43,7 +43,7 @@
 import storage.misc as misc
 import storage.fileUtils as fileUtils
 
-from monkeypatch import MonkeyPatch
+from monkeypatch import MonkeyPatch, MonkeyPatchScope
 from testValidation import checkSudo
 
 EXT_CHMOD = "/bin/chmod"
@@ -844,6 +844,7 @@
 class ReadSpeed(TestCaseBase):
 
 @permutations([
+# output line, bytes read, seconds
 ("1 byte (1 B) copied, 1 s, 1 B/s",
  "1", "1"),
 ("1024 bytes (1 kB) copied, 1 s, 1 kB/s",
@@ -859,14 +860,27 @@
 ("524288 bytes (512e3 B) copied, 1 s, 512e3 B/s",
  "524288", "1"),
 ("517 bytes (517 B) copied, 0 s, Infinity B/s",
- "517", "0")
+ "517", "0"),
+("4096 bytes (4.1 kB) copied, 0.00135703 s, 3.0 MB/s",
+ "4096", "0.00135703"),
+("30 bytes (30 B) copied, 0.0033204 s, 9.0 kB/s",
+ "30", "0.0033204"),
 ])
-def testReadSpeedRegExp(self, output, bytes, seconds):
-m = misc._readspeed_regex.match(output)
-self.assertNotEqual(m, None)
+def test_readspeed(self, output_line, bytes_read, seconds):
+output = (
+"0+1 records in",
+"0+1 records out",
+output_line,
+)
 
-self.assertEqual(m.group("bytes"), bytes)
-self.assertEqual(m.group("seconds"), seconds)
+def _fake_exec_cmd(*args):
+return 0, None, output
+
+with MonkeyPatchScope([(misc, 'execCmd', _fake_exec_cmd)]):
+speed = misc.readspeed('useless')
+
+self.assertEquals(speed["bytes"], int(bytes_read))
+self.assertAlmostEqual(speed["seconds"], float(seconds))
 
 
 class PidExists(TestCaseBase):


-- 
To view, visit https://gerrit.ovirt.org/56159
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5aef61848b0d237c2250fd8b8e6b4ee9ee88e299
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ci:Fixed execution on el* chroots

[dcaro]

David Caro has posted comments on this change.

Change subject: ci:Fixed execution on el* chroots
..


Patch Set 1: Verified+1

I seem to be unable to actually run the tests, it seems there's some issue when 
reconfiguring vdsm (though the vm creation and start works as expected)

http://fpaste.org/355433/45662146/

-- 
To view, visit https://gerrit.ovirt.org/56139
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88823d4c94883ef94989197296860913a9c36322
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: build: Remove pep8 and pyflakes requirement
..


Patch Set 1:

The el7 did not run any of the tests, I think this patch is missing the fix 
Yaniv added in the automation script.

-- 
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: Remove pep8 and pyflakes requirement
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: support new dd output

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: support new dd output
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56091/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 188: return str(ctime)
Line 189: 
Line 190: _readspeed_regex = re.compile(
Line 191: "(?P\d+) bytes?"
Line 192: "(|( \([\de\-.]+ [kMGT]*B(|, [\de\-.]+ [KMGT]*iB)\))) copied, "
> OK, do you want me to simplify the regex first then (perhaps?) replace it w
I would do this:

- drop the parsing of the unneeded bytes value and the return value.
- add failing tests for the new human readable format
- simplify parsing so we are not effected by new the human readable format, 
fixing the broken tests.

Note that this code and the tests are removed and replaced by 
https://gerrit.ovirt.org/#/c/54757/34/tests/storage_check_test.py

I want to merge that patch soon.
Line 193: "(?P[\de\-.]+) s, "
Line 194: "([\de\-.]+|Infinity) [kMGT]*B/s"
Line 195: )
Line 196: 


-- 
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: build: Remove pep8 and pyflakes requirement
..

build: Remove pep8 and pyflakes requirement

We use to build-require both pep8 and pyflakes, which cause trouble when
using older version. This leads to build failures, or to horrible code
tyring to make old buggy pyflakes happy.

Vdsm does not require pep8 or pyflakes for building packages; these are
development tools that should be installed on a development machine or
on CI environment, using the versions supported by current vdsm code.

In the makefile, "make check" during make rpm was disabled on EL,
because incompatible or missing pep8 and pyflakes versions; This hack
was removed, so make rpm will do the same thing all platforms.

In the makfile, we run pep8 or pyflakes checks only if these tools are
installed.

4 copies of incompatible pep8 and pyflakes version were removed from the
packages list.

Finally, we install the correct version of these tools in the CI
environment using pip.

Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Signed-off-by: Nir Soffer 
---
M Makefile.am
M automation/build-artifacts.sh
M automation/check-merged.packages.el7
M automation/check-merged.packages.fc23
M automation/check-patch.packages.el7
M automation/check-patch.packages.fc23
M automation/check-patch.sh
M vdsm.spec.in
8 files changed, 23 insertions(+), 33 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/52/56152/1

diff --git a/Makefile.am b/Makefile.am
index 4ce5ec5..b124ffb 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -102,19 +102,27 @@
 
 .PHONY: pyflakes
 pyflakes: all
-   python -c 'import pyflakes; print("pyflakes-%s" % pyflakes.__version__)'
-   ( find . -path './.git' -prune -type f -o \
-   -name '*.py' && \
-   echo $(WHITELIST) ) | xargs $(PYFLAKES)
+   if [ -n "$(PYFLAKES)" ]; then \
+   python -c 'import pyflakes; print("pyflakes-%s" % 
pyflakes.__version__)'; \
+   ( find . -path './.git' -prune -type f -o \
+   -name '*.py' && \
+   echo $(WHITELIST) ) | xargs $(PYFLAKES); \
+   else \
+   echo "Warning: pyflakes is not installed, skipping check"; \
+   fi
 
 .PHONY: pep8
 pep8: all
-   $(PEP8) --version
-   for x in $(PEP8_BLACKLIST); do \
-   exclude="$${exclude},$${x}" ; \
-   done ; \
-   $(PEP8) --exclude="$${exclude}" --filename '*.py' . \
-   $(WHITELIST)
+   if [ -n "$(PEP8)" ]; then \
+   $(PEP8) --version; \
+   for x in $(PEP8_BLACKLIST); do \
+   exclude="$${exclude},$${x}" ; \
+   done ; \
+   $(PEP8) --exclude="$${exclude}" --filename '*.py' . \
+   $(WHITELIST); \
+   else \
+   echo "Warning: pep8 is not installed, skipping check"; \
+   fi
 
 .PHONY: python3
 python3: all
diff --git a/automation/build-artifacts.sh b/automation/build-artifacts.sh
index 0ee45c3..9576756 100755
--- a/automation/build-artifacts.sh
+++ b/automation/build-artifacts.sh
@@ -16,7 +16,7 @@
 make
 # tests will be done elsewhere
 yum-builddep ./vdsm.spec
-make PYFLAKES=true PEP8=true NOSE_EXCLUDE=.* rpm
+make PYFLAKES="" PEP8="" NOSE_EXCLUDE=.* rpm
 
 find "$BUILDS" \
 -iname \*.rpm \
diff --git a/automation/check-merged.packages.el7 
b/automation/check-merged.packages.el7
index feebc90..6ae3d94 100644
--- a/automation/check-merged.packages.el7
+++ b/automation/check-merged.packages.el7
@@ -8,7 +8,6 @@
 make
 mom
 policycoreutils-python
-pyflakes
 python-blivet
 python-coverage
 python-devel
@@ -16,7 +15,6 @@
 python-ioprocess
 python-netaddr
 python-nose
-python-pep8
 python-pthreading
 python-rtslib
 python-six
diff --git a/automation/check-merged.packages.fc23 
b/automation/check-merged.packages.fc23
index dd5c7f2..5387eea 100644
--- a/automation/check-merged.packages.fc23
+++ b/automation/check-merged.packages.fc23
@@ -8,7 +8,6 @@
 make
 mom
 policycoreutils-python
-pyflakes
 python-blivet
 python-coverage
 python-devel
@@ -16,7 +15,6 @@
 python-ioprocess
 python-netaddr
 python-nose
-python-pep8
 python-pthreading
 python-rtslib
 python-six
diff --git a/automation/check-patch.packages.el7 
b/automation/check-patch.packages.el7
index feebc90..bba5556 100644
--- a/automation/check-patch.packages.el7
+++ b/automation/check-patch.packages.el7
@@ -8,7 +8,6 @@
 make
 mom
 policycoreutils-python
-pyflakes
 python-blivet
 python-coverage
 python-devel
@@ -16,9 +15,9 @@
 python-ioprocess
 python-netaddr
 python-nose
-python-pep8
 python-pthreading
 python-rtslib
+python-setuptools
 python-six
 python34-nose
 python34-six
diff --git a/automation/check-patch.packages.fc23 
b/automation/check-patch.packages.fc23
index fa342d4..e0dd375 100644
--- a/automation/check-patch.packages.fc23
+++ b/automation/check-patch.packages.fc23
@@ -7,7 +7,6 @@
 

Change in vdsm[master]: build: Remove pep8 and pyflakes requirement

[automation]

gerrit-hooks has posted comments on this change.

Change subject: build: Remove pep8 and pyflakes requirement
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56152
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0cdf21f18604c3fe81fa724aab0e613fb04289
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add rollback_trigger to Config()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: add rollback_trigger to Config()
..


Patch Set 2:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add rollback_trigger to Config()

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: add rollback_trigger to Config()
..


Patch Set 2: Verified+1

Passed conf_persistence_test.py

-- 
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: split to-be-removed and to-be-added

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: native ovs: split to-be-removed and to-be-added
..


Patch Set 8: Verified+1

Passed ovs_tests

-- 
To view, visit https://gerrit.ovirt.org/55313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c8065561db3876ee28e007305d4578ab05b2971
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: qemu-kvm-img to handle unaligned images

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: spec: qemu-kvm-img to handle unaligned images
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56142
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I411b14cfc9eb72ceebb005284a95d316bba783c6
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: split to-be-removed and to-be-added

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs: split to-be-removed and to-be-added
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c8065561db3876ee28e007305d4578ab05b2971
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs: split to-be-removed and to-be-added

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: native ovs: split to-be-removed and to-be-added
..


Patch Set 8:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c8065561db3876ee28e007305d4578ab05b2971
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: migration: Add Dynamic Bounded Semaphores

[mbetak]

Martin Betak has posted comments on this change.

Change subject: migration: Add Dynamic Bounded Semaphores
..


Patch Set 23: Verified+1

Verfied using unit tests. Since last patch-set was test-only change, restoring 
+V.

-- 
To view, visit https://gerrit.ovirt.org/53304
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I67376d0bd990f89e0a013887cef1a0cb05fb855d
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: build: Make sure run_tests*.sh scripts are executable
..


Patch Set 1:

its the definition of @top_srcdir@ , I prefer to leave it generated

-- 
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add rollback_trigger to Config()

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: add rollback_trigger to Config()
..


Patch Set 1:

* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: build: Make sure run_tests*.sh scripts are executable

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: build: Make sure run_tests*.sh scripts are executable
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/55949/1/build-aux/Makefile.subs
File build-aux/Makefile.subs:

Line 38: 
Line 39: CONFIGSUBST = $(top_builddir)/config.status --file=-
Line 40: 
Line 41: %.sh: %.sh.in
Line 42:@echo "  SED $@"; $(PATHSUBST) $< |$(CONFIGSUBST) >$@
> maybe you should have specific rules for this 2 scripts in tests/Makefile.a
I tried it, unfortunately the paths are still wrong (indeed, Makefile.subs is 
included there so there is little real difference). I'm tempted to hardcode 
".." into the scripts -- would it break anything?
Line 43:chmod +x $@
Line 44: 
Line 45: %: %.in


-- 
To view, visit https://gerrit.ovirt.org/55949
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc1e3dc8ace7f69801b765262352903020cc8aef
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: add rollback_trigger to Config()

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net: add rollback_trigger to Config()
..

net: add rollback_trigger to Config()

This patch introduces rollback_trigger() method to Config().
Is will be used as a rollback trigger for OVS switch and could
also replace unified rollback mechanism from legacy switch.

Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček 
---
M lib/vdsm/netconfpersistence.py
M tests/network/conf_persistence_test.py
2 files changed, 52 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/56149/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 6397a7c..7bda855 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -19,11 +19,14 @@
 #
 
 from __future__ import absolute_import
+from contextlib import contextmanager
+from copy import deepcopy
 import errno
 import json
 import logging
 import os
 import pwd
+import sys
 
 from .config import config
 from .tool.restore_nets import restore
@@ -31,6 +34,7 @@
 from . import constants
 from . import utils
 from vdsm.network.canonicalize import canonicalize_networks
+from vdsm.network import errors as ne
 
 CONF_RUN_DIR = constants.P_VDSM_RUN + 'netconf/'
 # The persistent path is inside of an extra "persistence" dir in order to get
@@ -195,6 +199,22 @@
 _clear_dir(self.networksPath)
 _clear_dir(self.bondingsPath)
 
+@contextmanager
+def rollback_trigger(self, in_rollback):
+self._backup = deepcopy(self)
+try:
+yield
+except:
+type, value, traceback = sys.exc_info()
+if in_rollback:
+logging.error('Failed rollback transaction to last known good '
+  'network.', exc_info=(type, value, traceback))
+raise
+else:
+config_diff = self.diffFrom(self.backup)
+if config_diff:
+raise ne.RollbackIncomplete(config_diff, type, value)
+
 
 class RunningConfig(Config):
 def __init__(self):
diff --git a/tests/network/conf_persistence_test.py 
b/tests/network/conf_persistence_test.py
index 4f52557..0646bb6 100644
--- a/tests/network/conf_persistence_test.py
+++ b/tests/network/conf_persistence_test.py
@@ -29,6 +29,7 @@
 from nose.plugins.attrib import attr
 
 from vdsm.netconfpersistence import Config
+from vdsm.network import errors as ne
 from vdsm.utils import rmFile
 
 from testlib import VdsmTestCase as TestCaseBase
@@ -114,3 +115,34 @@
 configB.removeNetwork(NETWORK)
 diff = configA.diffFrom(configB)
 self.assertIn(NETWORK, diff.networks)
+
+def test_rollback_successful_setup(self):
+config = Config(self.tempdir)
+with self.assertNotRaises():
+with config.rollback_trigger(in_rollback=False):
+pass
+
+def test_rollback_failed_setup(self):
+config = Config(self.tempdir)
+config.setNetwork('to-stay', {'nic': 'eth0'})
+config.setNetwork('to-edit', {'nic': 'eth1'})
+config.setNetwork('to-remove', {'nic': 'eth2'})
+
+try:
+with config.rollback_trigger(in_rollback=False):
+config.setNetwork('to-add', {'nic': 'eth3'})
+config.setNetwork('to-edit', {'nic': 'eth4'})
+config.removeNetwork('to-remove')
+raise Exception('Setup failed, rollback please.')
+except ne.RollbackIncomplete as roi:
+diff, _, _ = roi
+self.assertEquals(diff.networks['to-remove']['nic'], 'eth2')
+self.assertEquals(diff.networks['to-add'], {'remove': True})
+else:
+raise
+
+def test_rollback_failed_setup_in_rollback(self):
+config = Config(self.tempdir)
+with self.assertRaises(RuntimeError):
+with config.rollback_trigger(in_rollback=True):
+raise RuntimeError()


-- 
To view, visit https://gerrit.ovirt.org/56149
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iab1dcf346a5d5de15f01148a58abc4ae6e0ab97d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: OVS configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: OVS configurator
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/55958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require specific pep8 version

[automation]

gerrit-hooks has posted comments on this change.

Change subject: require specific pep8 version
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie47f108c2065d5bd0e4e0e987121f91db4868397
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: require specific pep8 version

[ybronhei]

Yaniv Bronhaim has uploaded a new change for review.

Change subject: require specific pep8 version
..

require specific pep8 version

Change-Id: Ie47f108c2065d5bd0e4e0e987121f91db4868397
Signed-off-by: Yaniv Bronhaim 
---
M automation/check-patch.packages.el7
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/56148/1

diff --git a/automation/check-patch.packages.el7 
b/automation/check-patch.packages.el7
index feebc90..ffeeb59 100644
--- a/automation/check-patch.packages.el7
+++ b/automation/check-patch.packages.el7
@@ -16,7 +16,7 @@
 python-ioprocess
 python-netaddr
 python-nose
-python-pep8
+python-pep8=1.5.7
 python-pthreading
 python-rtslib
 python-six


-- 
To view, visit https://gerrit.ovirt.org/56148
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie47f108c2065d5bd0e4e0e987121f91db4868397
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: Run make check over el7 in automation CI

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: Run make check over el7 in automation CI
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabbb09920de316a4e26447a0ca77ba9f30e517cd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: remove model_tests.py form py3 tests

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: tests: remove model_tests.py form py3 tests
..


Patch Set 2: Code-Review-1

okok, missed Dan's desire. with https://gerrit.ovirt.org/56072 we won't run 
python3 parts over el7 by default so it should be fine unless you specify 
--enable-python3 to configure\autogen.sh . keep it as it is. and I would keep 
the old patchset that adds the requirements to el7 packages with -1 until the 
package will build

-- 
To view, visit https://gerrit.ovirt.org/56119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I44fc7e80fc01efe154c678aa1fc967314a090a33
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: automation: add python3-netaddr and libvirt-python3
..


automation: add python3-netaddr and libvirt-python3

commit 51594c added these packages only to check-patch, but we need them
in check-merged as well.

Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/56143
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Francesco Romani 
Continuous-Integration: Jenkins CI
Reviewed-by: Eyal Edri 
---
M automation/check-merged.packages.fc23
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Eyal Edri: Looks good to me, but someone else must approve
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: support new dd output

[fromani]

Francesco Romani has posted comments on this change.

Change subject: storage: support new dd output
..


Patch Set 1:

(4 comments)

https://gerrit.ovirt.org/#/c/56091/1/tests/Makefile.am
File tests/Makefile.am:

Line 138:   storageMailboxTests.py \
Line 139:   storageMonitorTests.py \
Line 140:   storageServerTests.py \
Line 141:   storagetestlibTests.py \
Line 142:   storage_misc_test.py \
> Did  you look at miscTests.py?
nope! I'm guilty, i cut corners here :)
But will move those tests in the place you suggested in another comment :)
Line 143:   storage_sdm_api_test.py \
Line 144:   storage_sdm_create_volume_test.py \
Line 145:   storage_volume_artifacts_test.py \
Line 146:   tasksetTests.py \


https://gerrit.ovirt.org/#/c/56091/1/tests/storage_misc_test.py
File tests/storage_misc_test.py:

Line 23: 
Line 24: from monkeypatch import MonkeyPatchScope
Line 25: 
Line 26: 
Line 27: class TestReadSpeed(VdsmTestCase):
> We already test this in miscTests.py:ReadSpeed.testReadSpeedRegExp.
sure thing
Line 28: 
Line 29: def test_zero_size(self):
Line 30: output = (
Line 31: "0+0 records in",


Line 44: output = (
Line 45: "1+0 records in",
Line 46: "1+0 records out",
Line 47: "4096 bytes (4.1 kB, 4.0 KiB) copied, 0.00887814 s, 461 
kB/s")
Line 48: self.assertNotRaises(self._speed_from_output, output)
> assert not raises is not good enough, we want to get the time from that str
ok, will change the tests accordingly.
Line 49: 
Line 50: def test_read_30_bytes_human_readable(self):
Line 51: output = (
Line 52: "0+1 records in",


https://gerrit.ovirt.org/#/c/56091/1/vdsm/storage/misc.py
File vdsm/storage/misc.py:

Line 188: return str(ctime)
Line 189: 
Line 190: _readspeed_regex = re.compile(
Line 191: "(?P\d+) bytes?"
Line 192: "(|( \([\de\-.]+ [kMGT]*B(|, [\de\-.]+ [KMGT]*iB)\))) copied, "
> This probably works but too fragile. We don't care about the values which d
OK, do you want me to simplify the regex first then (perhaps?) replace it with 
string.split() and friends or should I just rewrite the parsing?
Line 193: "(?P[\de\-.]+) s, "
Line 194: "([\de\-.]+|Infinity) [kMGT]*B/s"
Line 195: )
Line 196: 


-- 
To view, visit https://gerrit.ovirt.org/56091
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I632d99cdc2b41e96a75bdce12e86710241fa0939
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: add python3-netaddr and libvirt-python3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: automation: add python3-netaddr and libvirt-python3
..


Patch Set 1: Code-Review+2 Verified+1

not really verified, let's hope check-merged flies.

-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[eedri]

Eyal Edri has posted comments on this change.

Change subject: automation: add python3-netaddr and libvirt-python3
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: qemuimg: Validate qcow2_compat configuration

[alitke]

Adam Litke has posted comments on this change.

Change subject: qemuimg: Validate qcow2_compat configuration
..


Patch Set 1:

Should we document the supported ones in config.py.in file as well?

-- 
To view, visit https://gerrit.ovirt.org/56110
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8e217ec42a803d53403947a5fb140cb51202fbfa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Gashev 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 2: Code-Review+1

we now have a plan to go forward

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Revert "hostdev: don't implicitly reattach devices"

This reverts commit 2bdcf4f99e4723f08886 as SR-IOV feature
depends on implicit reattchement of VFs. Commit 74ac384510b
makes sure that the reversal would affect only SRIOV NICs
and not generic host devices.

Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/56013
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik 
Reviewed-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 2: Code-Review+2 Verified+1

copying V+1

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev/sr-iov: don't reattach devices"

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Revert "hostdev/sr-iov: don't reattach devices"
..


Revert "hostdev/sr-iov: don't reattach devices"

This reverts commit e80ab7fc74b7715. SR-IOV feature depends
on automatic re-binding of VFs to their network driver.
Without that, the VFs are no longer recognized as available
host NICs after a VM using VFs is taken down, or after
hotunplug of a VFs.

Change-Id: Ia19d4a761023f2ca9fa3f7274fed97159bed1fae
Bug-Url: https://bugzilla.redhat.com/1234328
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/55993
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik 
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia19d4a761023f2ca9fa3f7274fed97159bed1fae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev/sr-iov: don't reattach devices"

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Revert "hostdev/sr-iov: don't reattach devices"
..


Patch Set 3:

* #1234328::Update tracker: OK
* Set MODIFIED::bug 1234328#1234328FAILED, illegal change from ASSIGNED

-- 
To view, visit https://gerrit.ovirt.org/55993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia19d4a761023f2ca9fa3f7274fed97159bed1fae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev/sr-iov: don't reattach devices"

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Revert "hostdev/sr-iov: don't reattach devices"
..


Patch Set 2: Code-Review+2 Verified+1

copying v+1

-- 
To view, visit https://gerrit.ovirt.org/55993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia19d4a761023f2ca9fa3f7274fed97159bed1fae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev/sr-iov: don't reattach devices"

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: Revert "hostdev/sr-iov: don't reattach devices"
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/55993
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia19d4a761023f2ca9fa3f7274fed97159bed1fae
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Revert "hostdev: don't implicitly reattach devices"

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: Revert "hostdev: don't implicitly reattach devices"
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56013
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia46068b4905d480e50957d3611bd9ae74e45a77d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[fromani]

Francesco Romani has posted comments on this change.

Change subject: automation: add python3-netaddr and libvirt-python3
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: automation: add python3-netaddr and libvirt-python3
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ci:Fixed execution on el* chroots

[eedri]

Eyal Edri has posted comments on this change.

Change subject: ci:Fixed execution on el* chroots
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/56139
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88823d4c94883ef94989197296860913a9c36322
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: David Caro 
Gerrit-Reviewer: David Caro 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: automation: add python3-netaddr and libvirt-python3
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6'])

-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: automation: add python3-netaddr and libvirt-python3

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: automation: add python3-netaddr and libvirt-python3
..

automation: add python3-netaddr and libvirt-python3

commit 51594c added these packages only to check-patch, but we need them
in check-merged as well.

Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Signed-off-by: Dan Kenigsberg 
---
M automation/check-merged.packages.fc23
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/56143/1

diff --git a/automation/check-merged.packages.fc23 
b/automation/check-merged.packages.fc23
index dd5c7f2..d63aecb 100644
--- a/automation/check-merged.packages.fc23
+++ b/automation/check-merged.packages.fc23
@@ -4,6 +4,7 @@
 lago
 lago-ovirt
 libguestfs-tools-c
+libvirt-python3
 m2crypto
 make
 mom
@@ -20,6 +21,7 @@
 python-pthreading
 python-rtslib
 python-six
+python3-netaddr
 python3-nose
 python3-six
 rpm-build


-- 
To view, visit https://gerrit.ovirt.org/56143
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0baebe2e113149d9b9ae6370b7fe02592d1ba42b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches