Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm
Francesco Romani has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build
Francesco Romani has submitted this change and it was merged. Change subject: build: enable vdsm-gluster build .. build: enable vdsm-gluster build and pull in gluster client packages except on ppc Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117 Bug-Url: https://bugzilla.redhat.com/1225728 Signed-off-by: Sahina Bose Reviewed-on: https://gerrit.ovirt.org/58605 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/60329 Reviewed-by: Francesco Romani --- M contrib/rhev_build.sh M vdsm.spec.in 2 files changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Sahina Bose: Verified -- To view, visit https://gerrit.ovirt.org/60329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sahina Bose Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: build: enable vdsm-gluster build
gerrit-hooks has posted comments on this change. Change subject: build: enable vdsm-gluster build .. Patch Set 3: * #1225728::Update tracker: OK * Set MODIFIED::bug 1225728#1225728IGNORE, not all related patches are closed, check 57862 -- To view, visit https://gerrit.ovirt.org/60329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If0adff4489b541becbdfb1f414a2c560b12a8117 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Sahina Bose Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Sahina Bose Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 3: Continuous-Integration+1 unrelated CI error: 06:03:13 Error: nothing provides ovirt-imageio-common needed by vdsm-4.18.6-6.gitd93fd14.fc23.x86_64. -- To view, visit https://gerrit.ovirt.org/60897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm
Anonymous Coward #1001177 has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/60897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm
Dan Kenigsberg has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm
gerrit-hooks has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 5: * #1314371::Update tracker: OK * Set MODIFIED::bug 1314371#1314371IGNORE, not all related patches are closed, check 58810 -- To view, visit https://gerrit.ovirt.org/60896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: openstacknet hook: include after_vm_start hook in rpm
gerrit-hooks has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 3: * #1314371::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1314371::OK, public bug * Check Product::#1314371::OK, Correct classification oVirt * Check TM::#1314371::ERROR, wrong target milestone for stable branch, ovirt-3.6.9 should match ^.*4.0.* * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60897 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm
Dan Kenigsberg has submitted this change and it was merged. Change subject: openstacknet hook: include after_vm_start hook in rpm .. openstacknet hook: include after_vm_start hook in rpm commit a655be4 excluded an important piece of the code from the distribution. Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Bug-Url: https://bugzilla.redhat.com/1314371 Signed-off-by: Dan Kenigsberg Reviewed-on: https://gerrit.ovirt.org/60896 Continuous-Integration: Jenkins CI Reviewed-by: Petr Horáček --- M vdsm.spec.in M vdsm_hooks/openstacknet/Makefile.am 2 files changed, 11 insertions(+), 0 deletions(-) Approvals: Anonymous Coward #1001177: Verified Jenkins CI: Passed CI tests Petr Horáček: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/60896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: openstacknet hook: include after_vm_start hook in rpm
Anonymous Coward #1001177 has posted comments on this change. Change subject: openstacknet hook: include after_vm_start hook in rpm .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/60896 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I421d9a693bdf8c5ea3689cb4d23d86be81cbaf55 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Marcin Mirecki Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: qemu chain verification
Adam Litke has posted comments on this change. Change subject: storagetestlib: qemu chain verification .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88008b26f340a87466e9fa98ffb34b5df7509390 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: Add fake_env() helper
gerrit-hooks has posted comments on this change. Change subject: storagetestlib: Add fake_env() helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabf3bc79e80340071c8b9873db5b493339a401ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: Allow creating multiple block volumes in an ...
gerrit-hooks has posted comments on this change. Change subject: storagetestlib: Allow creating multiple block volumes in an image .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c46faa52349431dfad6a2dab1bfe094c7c8f8f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: Allow creating multiple block volumes in an ...
Adam Litke has posted comments on this change. Change subject: storagetestlib: Allow creating multiple block volumes in an image .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c46faa52349431dfad6a2dab1bfe094c7c8f8f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Implement SDM.copy_data
gerrit-hooks has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60420 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30ff635c0c73f67b296033b4a506fc3b9ededfbe Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: Add fake_env() helper
Adam Litke has posted comments on this change. Change subject: storagetestlib: Add fake_env() helper .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60998 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabf3bc79e80340071c8b9873db5b493339a401ad Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: qemu chain verification
gerrit-hooks has posted comments on this change. Change subject: storagetestlib: qemu chain verification .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60999 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88008b26f340a87466e9fa98ffb34b5df7509390 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: Add fake_env() helper
Adam Litke has uploaded a new change for review.
Change subject: storagetestlib: Add fake_env() helper
..
storagetestlib: Add fake_env() helper
Permutated tests would like to test 'file' and 'block' environments. Add a
helper to make it easy for tests to produce both environments while displaying
user-friendly test output.
Change-Id: Iabf3bc79e80340071c8b9873db5b493339a401ad
Signed-off-by: Adam Litke
---
M tests/storagetestlib.py
1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/60998/1
diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index 44a4e31..f685403 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -101,6 +101,15 @@
yield FakeBlockEnv(tmpdir, sd_manifest, fake_sdc, lvm)
+def fake_env(storage_type):
+if storage_type == 'file':
+return fake_file_env()
+elif storage_type == 'block':
+return fake_block_env()
+else:
+raise ValueError("Invalid storage_type: %r" % storage_type)
+
+
class FakeMetadata(dict):
@contextmanager
def transaction(self):
--
To view, visit https://gerrit.ovirt.org/60998
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iabf3bc79e80340071c8b9873db5b493339a401ad
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: Allow creating multiple block volumes in an ...
Adam Litke has uploaded a new change for review. Change subject: storagetestlib: Allow creating multiple block volumes in an image .. storagetestlib: Allow creating multiple block volumes in an image Due to an unchecked directory creation, we could not create multiple block volumes in the same image. Check if the image dir exists before creating it. Change-Id: I3c46faa52349431dfad6a2dab1bfe094c7c8f8f1 Signed-off-by: Adam Litke --- M tests/storagetestlib.py 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/60997/1 diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py index 5c72ae7..44a4e31 100644 --- a/tests/storagetestlib.py +++ b/tests/storagetestlib.py @@ -221,7 +221,8 @@ sduuid = sd_manifest.sdUUID image_manifest = image.ImageManifest(sd_manifest.getRepoPath()) imagedir = image_manifest.getImageDir(sduuid, imguuid) -os.makedirs(imagedir) +if not os.path.exists(imagedir): +os.makedirs(imagedir) size_mb = utils.round(size, MB) / MB lvm.createLV(sduuid, voluuid, size_mb) -- To view, visit https://gerrit.ovirt.org/60997 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c46faa52349431dfad6a2dab1bfe094c7c8f8f1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storagetestlib: qemu chain verification
Adam Litke has uploaded a new change for review.
Change subject: storagetestlib: qemu chain verification
..
storagetestlib: qemu chain verification
Add utilities for:
- creating a volume chain with properly initialized qcow2 headers
- Writing a poisoned pattern to each layer of the chain
- Verifying the correctness of the chain by reading through the leaf volume
Change-Id: I88008b26f340a87466e9fa98ffb34b5df7509390
Signed-off-by: Adam Litke
---
M tests/storagetestlib.py
M tests/storagetestlibTests.py
2 files changed, 86 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/60999/1
diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py
index f685403..16f7c31 100644
--- a/tests/storagetestlib.py
+++ b/tests/storagetestlib.py
@@ -27,6 +27,7 @@
from vdsm import cmdutils
from vdsm import commands
+from vdsm import qemuimg
from vdsm import utils
from vdsm.storage import constants as sc
@@ -275,3 +276,69 @@
if rc != 0:
raise cmdutils.Error(cmd, rc, out, err)
return "Pattern verification failed" not in out
+
+
+def _gen_pattern_bytes():
+# Produce a predictable sequence of pattern bytes (eg. '1', '2', '3')
+byte_list = ['1', '2', '3', '4', '5', '6', '7', '8', '9']
+while byte_list:
+yield byte_list.pop(0)
+
+
+def write_qemu_chain(vol_list):
+# Starting with the base volume in vol_list, write to the chain in a
+# pattern like the following:
+#
+# vol chain index: 0K 1K 2K 3K
+# 0:
+# 1:
+# 2:
+# 3:
+# This allows us to verify the integrity of the whole chain.
+byte_generator = _gen_pattern_bytes()
+for i, vol in list(enumerate(vol_list)):
+vol_fmt = sc.fmt2str(vol.getFormat())
+offset = "{}K".format(i)
+pattern = byte_generator.next()
+qemu_pattern_write(vol.volumePath, vol_fmt, offset=offset,
+ len='1k', pattern=pattern)
+
+
+class ChainVerificationError(Exception):
+pass
+
+
+def verify_qemu_chain(vol_list):
+# Check the integrity of a volume chain by reading the leaf volume
+# and verifying the pattern written by write_chain.
+byte_generator = _gen_pattern_bytes()
+vol = vol_list[-1]
+vol_fmt = sc.fmt2str(vol.getFormat())
+for i in list(range(len(vol_list))):
+offset = "{}K".format(i)
+pattern = byte_generator.next()
+if not qemu_pattern_verify(vol.volumePath, vol_fmt, offset=offset,
+ len='1k', pattern=pattern):
+raise ChainVerificationError("Verification failed at offset %s" %
+ offset)
+
+
+def make_qemu_chain(env, size, base_vol_fmt, chain_len):
+vol_list = []
+img_id = str(uuid.uuid4())
+parent_vol_id = sc.BLANK_UUID
+vol_fmt = base_vol_fmt
+for i in range(chain_len):
+vol_id = str(uuid.uuid4())
+if parent_vol_id != sc.BLANK_UUID:
+vol_fmt = sc.COW_FORMAT
+env.make_volume(size, img_id, vol_id,
+parent_vol_id=parent_vol_id, vol_format=vol_fmt)
+vol = env.sd_manifest.produceVolume(img_id, vol_id)
+if vol_fmt == sc.COW_FORMAT:
+backing = parent_vol_id if parent_vol_id != sc.BLANK_UUID else None
+qemuimg.create(vol.volumePath, size=size,
+ format=qemuimg.FORMAT.QCOW2, backing=backing)
+vol_list.append(vol)
+parent_vol_id = vol_id
+return vol_list
diff --git a/tests/storagetestlibTests.py b/tests/storagetestlibTests.py
index 0012c83..964c887 100644
--- a/tests/storagetestlibTests.py
+++ b/tests/storagetestlibTests.py
@@ -24,11 +24,14 @@
from testlib import namedTemporaryDir
from testlib import VdsmTestCase
from testlib import TEMPDIR
+from storagetestlib import fake_env
from storagetestlib import fake_block_env
from storagetestlib import fake_file_env
from storagetestlib import make_block_volume
from storagetestlib import make_file_volume
from storagetestlib import qemu_pattern_write, qemu_pattern_verify
+from storagetestlib import make_qemu_chain, write_qemu_chain, verify_qemu_chain
+from storagetestlib import ChainVerificationError
from storage import blockSD, fileSD, fileVolume, sd
@@ -235,6 +238,22 @@
self.assertFalse(qemu_pattern_verify(path, img_format,
pattern='4'))
+@permutations((('file',), ('block',)))
+def test_verify_chain(self, storage_type):
+with fake_env(storage_type) as env:
+vol_list = make_qemu_chain(env, MB, sc.RAW_FORMAT, 2)
+write_qemu_chain(vol_list)
+verify_qemu_chain(vol_list)
+
+@permutations((('file',), ('block',)))
+def test_bad_chain_raises(self, storage_type):
+with fake_e
Change in vdsm[master]: sos report: _importVdsmPylibModule can import all vdsm modules
Irit Goihman has posted comments on this change.
Change subject: sos report: _importVdsmPylibModule can import all vdsm modules
..
Patch Set 6: Verified+1
(1 comment)
verified importing vdsm.jsonrpcvdscli and vdsm.storage.constants
https://gerrit.ovirt.org/#/c/60627/4/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:
Line 39: parts = fullName.split(".")
Line 40: fullName = ""
Line 41: for name in parts:
Line 42: if fullName:
Line 43: fullName += "."
> Testing with other modules show that we need the qualified name
Done
Line 44: fullName += name
Line 45: f, path, desc = imp.find_module(name, [search])
Line 46: try:
Line 47: module = imp.load_module(fullName, f, path, desc)
--
To view, visit https://gerrit.ovirt.org/60627
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab7570d843590ac5fccb669cb13bc758b218655f
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sos report: _importVdsmPylibModule can import all vdsm modules
gerrit-hooks has posted comments on this change. Change subject: sos report: _importVdsmPylibModule can import all vdsm modules .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60627 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab7570d843590ac5fccb669cb13bc758b218655f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Only allow compat designated by config
Nir Soffer has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Use --output json for 'check' and 'info'
Nir Soffer has posted comments on this change. Change subject: qemuimg: Use --output json for 'check' and 'info' .. Patch Set 2: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/60979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Check compatibility version
Nir Soffer has posted comments on this change. Change subject: verify_untrusted_volume: Check compatibility version .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Introduce supports_compat helper
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce supports_compat helper .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Add tests for verify_untrusted_volume
Nir Soffer has posted comments on this change. Change subject: tests: Add tests for verify_untrusted_volume .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44d3bbe33430a34e3a3b985e1485c6d46ebdc3aa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Use FakeStorageDomainCache in fake env
Nir Soffer has posted comments on this change. Change subject: tests: Use FakeStorageDomainCache in fake env .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: hsm: Use manifest in verify_untrusted_volume
Nir Soffer has posted comments on this change. Change subject: hsm: Use manifest in verify_untrusted_volume .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e615f0ad97149d49b13b530819d9c8e58fcdb81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Report qcow2 compat version
Nir Soffer has posted comments on this change. Change subject: qemuimg: Report qcow2 compat version .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91ee8ee96bdc3a230463987f857fd7e88c629b6a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Use --output json for 'check' and 'info'
Nir Soffer has posted comments on this change. Change subject: qemuimg: Use --output json for 'check' and 'info' .. Patch Set 2: This must be submitted with https://gerrit.ovirt.org/60987, since this breaks qemuimg.check(). -- To view, visit https://gerrit.ovirt.org/60979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Keep supported qcow2 versions as a tuple
Nir Soffer has posted comments on this change. Change subject: qemuimg: Keep supported qcow2 versions as a tuple .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I488deba3ab8b33ab6617a23e2dd9eaca1427befc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Fix tests with non-default qcow2_compat
Nir Soffer has posted comments on this change. Change subject: qemuimg: Fix tests with non-default qcow2_compat .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icebec8f2272df605867bf16e351daa48547c0d78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Unbreak qmemuimg.check
Nir Soffer has posted comments on this change. Change subject: qemuimg: Unbreak qmemuimg.check .. Patch Set 2: Please rebase on top of https://gerrit.ovirt.org/60979 -- To view, visit https://gerrit.ovirt.org/60987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: flush IP config from attached ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: flush IP config from attached ifaces .. Patch Set 11: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/59958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66e0be6ea8583fae1814bb8fc776dd243932b192 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net address: ignore not existing iface on flush
gerrit-hooks has posted comments on this change. Change subject: net address: ignore not existing iface on flush .. Patch Set 3: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/59957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I340c4862e01bd8a665f4ef6e2ba5d0d0dd23e5cc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: flush IP config from attached ifaces
Petr Horáček has abandoned this change. Change subject: ovs: flush IP config from attached ifaces .. Abandoned -- To view, visit https://gerrit.ovirt.org/59958 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I66e0be6ea8583fae1814bb8fc776dd243932b192 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net address: ignore not existing iface on flush
Petr Horáček has abandoned this change. Change subject: net address: ignore not existing iface on flush .. Abandoned -- To view, visit https://gerrit.ovirt.org/59957 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I340c4862e01bd8a665f4ef6e2ba5d0d0dd23e5cc Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: introduce acquire module
gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Unbreak qmemuimg.check
Jenkins CI has posted comments on this change. Change subject: qemuimg: Unbreak qmemuimg.check .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/60987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Add tests for verify_untrusted_volume
Jenkins CI has posted comments on this change. Change subject: tests: Add tests for verify_untrusted_volume .. Patch Set 2: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/60983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44d3bbe33430a34e3a3b985e1485c6d46ebdc3aa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire external ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 21: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire external ifaces
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 20: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire external ifaces
Petr Horáček has posted comments on this change.
Change subject: ovs: acquire external ifaces
..
Patch Set 18:
(7 comments)
https://gerrit.ovirt.org/#/c/60404/18/tests/network/ovs_switch_test.py
File tests/network/ovs_switch_test.py:
PS18, Line 21: as ovs_driver
> We are in an ovs_ module, I do not think it is needed.
Done
PS18, Line 24: as TestCaseBase
> What for?
Done
PS18, Line 29: SetupListExternalIfacesTests
> How about ListAcquiredIfacesTests ?
Done
PS18, Line 49: set()
> Why not use '{}' like you did everywhere else?
{} is an empty dictionary, it can be used only for non-empty sets.
PS18, Line 73: _test
> _assert_acquired_ifaces_post_switch_setup
Done
PS18, Line 80: if bonds2edit
> Ah.. this is not so nice... too much noise.
Done
PS18, Line 87: s
> using it outside the with block is too strange.
Done
--
To view, visit https://gerrit.ovirt.org/60404
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Keep supported qcow2 versions as a tuple
Jenkins CI has posted comments on this change. Change subject: qemuimg: Keep supported qcow2 versions as a tuple .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/60978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I488deba3ab8b33ab6617a23e2dd9eaca1427befc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: hsm: Use manifest in verify_untrusted_volume
Jenkins CI has posted comments on this change. Change subject: hsm: Use manifest in verify_untrusted_volume .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/60981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e615f0ad97149d49b13b530819d9c8e58fcdb81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Fix tests with non-default qcow2_compat
Jenkins CI has posted comments on this change. Change subject: qemuimg: Fix tests with non-default qcow2_compat .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/60977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icebec8f2272df605867bf16e351daa48547c0d78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Use FakeStorageDomainCache in fake env
Jenkins CI has posted comments on this change. Change subject: tests: Use FakeStorageDomainCache in fake env .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/60982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Moving vmstatus to vdsm.common.virt
Yaniv Bronhaim has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 9: ping? -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71baea312884e72c0d9485f73b0792b9900b3c21 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Use --output json for 'check' and 'info'
Jenkins CI has posted comments on this change. Change subject: qemuimg: Use --output json for 'check' and 'info' .. Patch Set 2: Continuous-Integration+1 Propagate review hook: Continuous Integration value inherited from patch 1 -- To view, visit https://gerrit.ovirt.org/60979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Unbreak qmemuimg.check
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Unbreak qmemuimg.check .. Patch Set 2: -Verified * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Only allow compat designated by config
gerrit-hooks has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config .. Patch Set 2: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Send vm info report each sampling interval from HostMonitor
Yaniv Bronhaim has posted comments on this change.
Change subject: Send vm info report each sampling interval from HostMonitor
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/59523/3/lib/vdsm/virt/sampling.py
File lib/vdsm/virt/sampling.py:
Line 517: if log_status:
Line 518: self._log.debug(
Line 519: 'sampled timestamp %r elapsed %.3f acquired %r
domains %s',
Line 520: timestamp, self._stats_cache.clock() - timestamp,
acquired,
Line 521: 'all' if fast_path else len(doms))
here I have the _translate(bulk_stats), but not direct access to cif to get the
normalized values. so what I have is something like:
I'm signing what I plan to send as metric, what as metadata and what I ignore
(in X).
please let me know what you think
'a16f0a60-0f36-4b19-833e-097ece7d82cc': (I don't have vmname)
{
'cpu.time': 20198421045L, <- metric
'cpu.system': 171L, <- metric
'cpu.user': 38000L, <- metric
'state.reason': 1, X
'state.state': 1,X
'vcpu.0.time': 1787000L,
'vcpu.maximum': 16, <- metadata
'vcpu.0.state': 1,
'vcpu.current': 1,
'net.count': 1, <- metadata
'net.0.name': 'vnet2', <- metadata
'net.0.tx.pkts': 104L,<- metric
'net.0.tx.bytes': 6833L, <- metric
'net.0.rx.pkts': 576L,<- metric
'net.0.rx.drop': 12501L,<- metric
'net.0.rx.errs': 0L, <- metric
'net.0.tx.drop': 0L, <- metric
'net.0.tx.errs': 0L, <- metric
'net.0.rx.bytes': 134742L, <- metric
'block.0.rd.reqs': 0L,<- metric
'block.0.name': 'hdc',<- metadata
'block.0.wr.reqs': 0L,<- metric
'block.count': 1, X
'block.0.rd.times': 0L, X
'block.0.physical': 0L, X
'block.0.fl.reqs': 0L,X
'block.0.fl.times': 0L}, X
'block.0.wr.times': 0L, X
'block.0.allocation': 0L, X
'block.0.wr.bytes': 0L, <- metric
'block.0.rd.bytes': 0L, <- metric
'balloon.current': 1048576L, X
'balloon.maximum': 1048576L, X
Line 522:
Line 523: def _get_responsive_doms(self):
Line 524: vms = self._get_vms()
Line 525: doms = []
--
To view, visit https://gerrit.ovirt.org/59523
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia44f97279e37265deb47ded60557dc98411fb9fc
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Introduce supports_compat helper
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce supports_compat helper .. Patch Set 2: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Use FakeStorageDomainCache in fake env
gerrit-hooks has posted comments on this change. Change subject: tests: Use FakeStorageDomainCache in fake env .. Patch Set 2: -Verified * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Check compatibility version
gerrit-hooks has posted comments on this change. Change subject: verify_untrusted_volume: Check compatibility version .. Patch Set 2: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Add tests for verify_untrusted_volume
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for verify_untrusted_volume .. Patch Set 2: -Verified * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44d3bbe33430a34e3a3b985e1485c6d46ebdc3aa Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Report qcow2 compat version
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Report qcow2 compat version .. Patch Set 2: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91ee8ee96bdc3a230463987f857fd7e88c629b6a Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: hsm: Use manifest in verify_untrusted_volume
gerrit-hooks has posted comments on this change. Change subject: hsm: Use manifest in verify_untrusted_volume .. Patch Set 2: -Verified * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e615f0ad97149d49b13b530819d9c8e58fcdb81 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Keep supported qcow2 versions as a tuple
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Keep supported qcow2 versions as a tuple .. Patch Set 2: -Verified * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I488deba3ab8b33ab6617a23e2dd9eaca1427befc Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Use --output json for 'check' and 'info'
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Use --output json for 'check' and 'info' .. Patch Set 2: -Verified * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Fix tests with non-default qcow2_compat
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Fix tests with non-default qcow2_compat .. Patch Set 2: -Verified * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icebec8f2272df605867bf16e351daa48547c0d78 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Use FakeStorageDomainCache in fake env
gerrit-hooks has posted comments on this change. Change subject: tests: Use FakeStorageDomainCache in fake env .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Report qcow2 compat version
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Report qcow2 compat version .. Patch Set 1: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60980 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I91ee8ee96bdc3a230463987f857fd7e88c629b6a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Unbreak qmemuimg.check
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Unbreak qmemuimg.check .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60987 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Only allow compat designated by config
gerrit-hooks has posted comments on this change. Change subject: verify_untrusted_volume: Only allow compat designated by config .. Patch Set 1: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60986 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Introduce supports_compat helper
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce supports_compat helper .. Patch Set 1: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60984 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Check compatibility version
gerrit-hooks has posted comments on this change. Change subject: verify_untrusted_volume: Check compatibility version .. Patch Set 1: * #1344289::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1344289::OK, public bug * Check Product::#1344289::OK, Correct classification oVirt * Check TM::#1344289::OK, correct target milestone ovirt-4.0.1 * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60985 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Add tests for verify_untrusted_volume
gerrit-hooks has posted comments on this change. Change subject: tests: Add tests for verify_untrusted_volume .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44d3bbe33430a34e3a3b985e1485c6d46ebdc3aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: hsm: Use manifest in verify_untrusted_volume
gerrit-hooks has posted comments on this change. Change subject: hsm: Use manifest in verify_untrusted_volume .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e615f0ad97149d49b13b530819d9c8e58fcdb81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Use --output json for 'check' and 'info'
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Use --output json for 'check' and 'info' .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60979 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Keep supported qcow2 versions as a tuple
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Keep supported qcow2 versions as a tuple .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60978 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I488deba3ab8b33ab6617a23e2dd9eaca1427befc Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Fix tests with non-default qcow2_compat
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Fix tests with non-default qcow2_compat .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is required for the stable branch * Check merged to previous::OK, change not open on any previous branch -- To view, visit https://gerrit.ovirt.org/60977 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icebec8f2272df605867bf16e351daa48547c0d78 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Fix tests with non-default qcow2_compat
Hello Nir Soffer, Freddy Rolland, Ala Hino,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60977
to review the following change.
Change subject: qemuimg: Fix tests with non-default qcow2_compat
..
qemuimg: Fix tests with non-default qcow2_compat
In commit 808ccde4de35 (qemuimg: Make QCOW2_COMPAT configurable) we
added a configuration for qcow2_compat. When running the tests on a
hypervisor with non-default configuration, the tests assuming the
hardcoded value are now failing.
Fix by using standard configuration in the tests, overriding the host
/etc/vdsm/vdsm.conf contents.
Change-Id: Icebec8f2272df605867bf16e351daa48547c0d78
Signed-off-by: Nir Soffer
Reviewed-on: https://gerrit.ovirt.org/57457
Continuous-Integration: Jenkins CI
Reviewed-by: Tal Nisan
Reviewed-by: Freddy Rolland
Reviewed-by: Ala Hino
---
M tests/qemuimgTests.py
1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/77/60977/1
diff --git a/tests/qemuimgTests.py b/tests/qemuimgTests.py
index ffc9428..3426557 100644
--- a/tests/qemuimgTests.py
+++ b/tests/qemuimgTests.py
@@ -28,6 +28,8 @@
QEMU_IMG = qemuimg._qemuimg.cmd
+CONFIG = make_config([('irs', 'qcow2_compat', '0.10')])
+
class CommandTests(TestCaseBase):
@@ -152,6 +154,7 @@
with MonkeyPatchScope([(qemuimg, '_supports_qcow2_compat',
self.supported('create', True)),
+ (qemuimg, 'config', CONFIG),
(commands, 'execCmd', create)]):
qemuimg.create('image', format='qcow2')
@@ -199,6 +202,7 @@
self.supported('convert', True)),
(qemuimg, '_supports_src_cache',
self.supported('convert', False)),
+ (qemuimg, 'config', CONFIG),
(qemuimg, 'QemuImgOperation', convert)]):
qemuimg.convert('src', 'dst', dstFormat='qcow2')
@@ -212,6 +216,7 @@
self.supported('convert', True)),
(qemuimg, '_supports_src_cache',
self.supported('convert', False)),
+ (qemuimg, 'config', CONFIG),
(qemuimg, 'QemuImgOperation', convert)]):
qemuimg.convert('src', 'dst', dstFormat='qcow2')
@@ -226,6 +231,7 @@
self.supported('convert', True)),
(qemuimg, '_supports_src_cache',
self.supported('convert', False)),
+ (qemuimg, 'config', CONFIG),
(qemuimg, 'QemuImgOperation', convert)]):
qemuimg.convert('src', 'dst', dstFormat='qcow2',
backing='bak')
@@ -240,6 +246,7 @@
self.supported('convert', True)),
(qemuimg, '_supports_src_cache',
self.supported('convert', False)),
+ (qemuimg, 'config', CONFIG),
(qemuimg, 'QemuImgOperation', convert)]):
qemuimg.convert('src', 'dst', dstFormat='qcow2',
backingFormat='qcow2')
@@ -255,6 +262,7 @@
self.supported('convert', True)),
(qemuimg, '_supports_src_cache',
self.supported('convert', False)),
+ (qemuimg, 'config', CONFIG),
(qemuimg, 'QemuImgOperation', convert)]):
qemuimg.convert('src', 'dst', dstFormat='qcow2',
backing='bak', backingFormat='qcow2')
--
To view, visit https://gerrit.ovirt.org/60977
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icebec8f2272df605867bf16e351daa48547c0d78
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Ala Hino
Gerrit-Reviewer: Freddy Rolland
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Add tests for verify_untrusted_volume
Hello Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60983 to review the following change. Change subject: tests: Add tests for verify_untrusted_volume .. tests: Add tests for verify_untrusted_volume Add some tests to check that verify_untrusted_volume works as expected. Tests are placed in a new storage_hsm_test module which can accomodate tests for other HSM verbs. Change-Id: I44d3bbe33430a34e3a3b985e1485c6d46ebdc3aa Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/60060 Reviewed-by: Nir Soffer Continuous-Integration: Jenkins CI --- M tests/Makefile.am A tests/storage_hsm_test.py 2 files changed, 85 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/83/60983/1 diff --git a/tests/Makefile.am b/tests/Makefile.am index d9ffbf7..8b881d8 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -118,6 +118,7 @@ storagetestlibTests.py \ storage_asyncevent_test.py \ storage_check_test.py \ + storage_hsm_test.py \ storage_monitor_test.py \ storage_rwlock_test.py \ storage_sdm_api_test.py \ @@ -224,6 +225,7 @@ stompAsyncDispatcherTests.py \ stompTests.py \ storageMailboxTests.py \ + storage_hsm_test.py \ storage_monitor_test.py \ storageServerTests.py \ storage_rwlock_test.py \ diff --git a/tests/storage_hsm_test.py b/tests/storage_hsm_test.py new file mode 100644 index 000..e2c565b --- /dev/null +++ b/tests/storage_hsm_test.py @@ -0,0 +1,83 @@ +# +# Copyright 2016 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +import uuid +from contextlib import contextmanager + +from testlib import VdsmTestCase +from testlib import permutations, expandPermutations +from storagetestlib import fake_file_env +from storagetestlib import make_file_volume + +from vdsm import qemuimg +from vdsm.storage import constants as sc +from vdsm.storage import exception as se + +from storage import hsm + + +class FakeHSM(hsm.HSM): +def __init__(self): +pass + + +@expandPermutations +class VerifyUntrustedVolumeTest(VdsmTestCase): +SIZE = 1024 * 1024 + +@permutations(((sc.RAW_FORMAT,), (sc.COW_FORMAT,))) +def test_ok(self, vol_fmt): +with self.fake_volume(vol_fmt) as vol: +qemu_fmt = sc.FMT2STR[vol_fmt] +qemuimg.create(vol.volumePath, size=self.SIZE, format=qemu_fmt) +h = FakeHSM() +self.assertNotRaises(h.verify_untrusted_volume, + 'sp', vol.sdUUID, vol.imgUUID, vol.volUUID) + +@permutations(( +(sc.RAW_FORMAT, qemuimg.FORMAT.QCOW2), +(sc.COW_FORMAT, qemuimg.FORMAT.RAW), +)) +def test_wrong_format_raises(self, vol_fmt, qemu_fmt): +with self.fake_volume(vol_fmt) as vol: +qemuimg.create(vol.volumePath, size=self.SIZE, format=qemu_fmt) +h = FakeHSM() +self.assertRaises(se.ImageVerificationError, + h.verify_untrusted_volume, + 'sp', vol.sdUUID, vol.imgUUID, vol.volUUID) + +def test_backingfile_raises(self): +with self.fake_volume(sc.COW_FORMAT) as vol: +qemu_fmt = qemuimg.FORMAT.QCOW2 +qemuimg.create(vol.volumePath, size=self.SIZE, format=qemu_fmt, + backing='foo') +h = FakeHSM() +self.assertRaises(se.ImageVerificationError, + h.verify_untrusted_volume, + 'sp', vol.sdUUID, vol.imgUUID, vol.volUUID) + +@contextmanager +def fake_volume(self, vol_fmt): +with fake_file_env() as env: +img_id = str(uuid.uuid4()) +vol_id = str(uuid.uuid4()) +make_file_volume(env.sd_manifest, self.SIZE, img_id, vol_id, + vol_format=vol_fmt) +yield env.sd_manifest.produceVolume(img_id, vol_id) -- To view, visit https://gerrit.ovirt.org/60983 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I44d3bbe33430a34e3a3b985e14
Change in vdsm[ovirt-4.0]: qemuimg: Use --output json for 'check' and 'info'
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60979
to review the following change.
Change subject: qemuimg: Use --output json for 'check' and 'info'
..
qemuimg: Use --output json for 'check' and 'info'
We now depend on qemu-2.3.0 or later which can report information about
images as a json string. Get rid of the old parsing code which was
complex, fragile, and inefficient by switching to the json output format
for the info() and check() commands.
Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85
Signed-off-by: Adam Litke
Reviewed-on: https://gerrit.ovirt.org/59649
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer
---
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
2 files changed, 119 insertions(+), 140 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/60979/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index 85e196f..201b69f 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -19,6 +19,7 @@
#
from __future__ import absolute_import
+import json
import logging
import os
import re
@@ -46,32 +47,6 @@
_QCOW2_COMPAT_SUPPORTED = ("0.10", "1.1")
-__iregex = {
-'format': re.compile("^file format: (?P\w+)$"),
-'virtualsize': re.compile("^virtual size: "
- "[\d.]+[KMGT] \((?P\d+) bytes\)$"),
-'clustersize': re.compile("^cluster_size: (?P\d+)$"),
-'backingfile': re.compile("^backing file: (?P.+) \(actual path"),
-'offset': re.compile("^Image end offset: (?P\d+)$"),
-}
-
-# The first row of qemu-img info output where optional fields may appear
-_INFO_OPTFIELDS_STARTIDX = 4
-
-# The first row of qemu-img check output where the 'offset' may appear
-_CHECK_OPTFIELDS_STARTIDX = 1
-
-
-class _RegexSearchError(Exception):
-pass
-
-
-def __iregexSearch(pattern, text):
-m = __iregex[pattern].search(text)
-if m is None:
-raise _RegexSearchError()
-return m.group("value")
-
class QImgError(Exception):
def __init__(self, ecode, stdout, stderr, message=None):
@@ -86,34 +61,33 @@
def info(image, format=None):
-cmd = [_qemuimg.cmd, "info"]
+cmd = [_qemuimg.cmd, "info", "--output", "json"]
if format:
cmd.extend(("-f", format))
cmd.append(image)
-rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL)
-
+rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL, raw=True)
if rc != 0:
raise QImgError(rc, out, err)
try:
-info = {
-'format': __iregexSearch("format", out[1]),
-'virtualsize': int(__iregexSearch("virtualsize", out[2])),
-}
-except _RegexSearchError:
-raise QImgError(rc, out, err, "unable to parse qemu-img info output")
+qemu_info = _parse_qemuimg_json(out)
+except ValueError:
+raise QImgError(rc, out, err, "Failed to process qemu-img output")
-# Scan for optional fields in the output
-row = _INFO_OPTFIELDS_STARTIDX
-for field, filterFn in (('clustersize', int), ('backingfile', str)):
-try:
-info[field] = filterFn(__iregexSearch(field, out[row]))
-except (_RegexSearchError, IndexError):
-pass
-else:
-row = row + 1
+try:
+info = {
+'format': qemu_info['format'],
+'virtualsize': qemu_info['virtual-size'],
+}
+except KeyError as key:
+raise QImgError(rc, out, err, "Missing field: %r" % key)
+
+if 'cluster-size' in qemu_info:
+info['clustersize'] = qemu_info['cluster-size']
+if 'backing-filename' in qemu_info:
+info['backingfile'] = qemu_info['backing-filename']
return info
@@ -148,7 +122,7 @@
def check(image, format=None):
-cmd = [_qemuimg.cmd, "check"]
+cmd = [_qemuimg.cmd, "check", "--output", "json"]
if format:
cmd.extend(("-f", format))
@@ -159,18 +133,15 @@
# FIXME: handle different error codes and raise errors accordingly
if rc != 0:
raise QImgError(rc, out, err)
-# Scan for 'offset' in the output
-for row in range(_CHECK_OPTFIELDS_STARTIDX, len(out)):
-try:
-check = {
-'offset': int(__iregexSearch("offset", out[row]))
-}
-return check
-except _RegexSearchError:
-pass
-except:
-break
-raise QImgError(rc, out, err, "unable to parse qemu-img check output")
+
+try:
+qemu_check = _parse_qemuimg_json(out)
+except ValueError:
+raise QImgError(rc, out, err, "Failed to process qemu-img output")
+try:
+return {"offset": qemu_check["image-end-offset"]}
+except KeyError:
+raise QImgError(rc, out, err, "unable to parse qemu-img check output")
def convert(srcImage, dstImage, srcFormat=None, dstFormat=None,
@@ -386,3 +357,10 @@
# conver
Change in vdsm[ovirt-4.0]: qemuimg: Unbreak qmemuimg.check
Hello Nir Soffer, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60987
to review the following change.
Change subject: qemuimg: Unbreak qmemuimg.check
..
qemuimg: Unbreak qmemuimg.check
Since commit 3e7a11954582 (qemuimg: Use --output json for 'check' and
'info') qemuimg.check is broken, but the tests are passing. This is
caused by unneeded mocking.
qemuimg.check fails now with this error:
File "/usr/lib/python2.7/site-packages/vdsm/qemuimg.py", line 309, in
_parse_qemuimg_json
obj = json.loads(output)
File "/usr/lib64/python2.7/json/__init__.py", line 338, in loads
return _default_decoder.decode(s)
File "/usr/lib64/python2.7/json/decoder.py", line 365, in decode
obj, end = self.raw_decode(s, idx=_w(s, 0).end())
TypeError: expected string or buffer
Replace the harmful mocking with running qemuimg.check with a real
image, and add the missing raw=True to get a string from the command.
Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41
Signed-off-by: Nir Soffer
Reviewed-on: https://gerrit.ovirt.org/60168
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani
Reviewed-by: Adam Litke
---
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
2 files changed, 8 insertions(+), 14 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/60987/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index c9d73fe..59a580a 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -137,7 +137,7 @@
cmd.extend(("-f", format))
cmd.append(image)
-rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL)
+rc, out, err = commands.execCmd(cmd, deathSignal=signal.SIGKILL, raw=True)
# FIXME: handle different error codes and raise errors accordingly
if rc != 0:
diff --git a/tests/qemuimgTests.py b/tests/qemuimgTests.py
index ac7c0b1..574bb25 100644
--- a/tests/qemuimgTests.py
+++ b/tests/qemuimgTests.py
@@ -385,20 +385,14 @@
class CheckTests(TestCaseBase):
-def _fake_info(self):
-return {
-"image-end-offset": 262144,
-"total-clusters": 16,
-"check-errors": 0,
-"filename": "/var/tmp/leaf.img",
-"format": "qcow2"
-}
-
+@MonkeyPatch(qemuimg, 'config', CONFIG)
def test_check(self):
-with MonkeyPatchScope([(commands, "execCmd",
-partial(fake_json_call, self._fake_info()))]):
-check = qemuimg.check('unused')
-self.assertEqual(262144, check['offset'])
+with namedTemporaryDir() as tmpdir:
+path = os.path.join(tmpdir, 'test.qcow2')
+qemuimg.create(path, size=1048576, format=qemuimg.FORMAT.QCOW2)
+info = qemuimg.check(path)
+# The exact value depends on qcow2 internals
+self.assertEqual(int, type(info['offset']))
def test_offset_no_match(self):
with MonkeyPatchScope([(commands, "execCmd",
--
To view, visit https://gerrit.ovirt.org/60987
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I732b8bb7285352ed92d69b295b8cf6c2598b8f41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: hsm: Use manifest in verify_untrusted_volume
Hello Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60981 to review the following change. Change subject: hsm: Use manifest in verify_untrusted_volume .. hsm: Use manifest in verify_untrusted_volume New users of storage objects should generally use the new *Manifest versions rather than the original objects which have unneeded complexity. Also, the new storagetestlib infrastructure is only compatible with the newer *Manifest objects. Change-Id: I6e615f0ad97149d49b13b530819d9c8e58fcdb81 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/60059 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M vdsm/storage/hsm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/60981/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index e92edfd..c9b2216 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -1491,7 +1491,7 @@ @public def verify_untrusted_volume(self, spUUID, sdUUID, imgUUID, volUUID): -dom = sdCache.produce(sdUUID=sdUUID) +dom = sdCache.produce(sdUUID=sdUUID).manifest vol = dom.produceVolume(imgUUID, volUUID) qemu_info = qemuimg.info(vol.getVolumePath()) -- To view, visit https://gerrit.ovirt.org/60981 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6e615f0ad97149d49b13b530819d9c8e58fcdb81 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Report qcow2 compat version
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60980
to review the following change.
Change subject: qemuimg: Report qcow2 compat version
..
qemuimg: Report qcow2 compat version
The verification code for image upload wants to validate that a volume's
compat version is supported by this vdsm. The first step is to start
returning the compat value in qemuimg.info.
Change-Id: I91ee8ee96bdc3a230463987f857fd7e88c629b6a
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344289
Signed-off-by: Adam Litke
Reviewed-on: https://gerrit.ovirt.org/59408
Reviewed-by: Nir Soffer
Continuous-Integration: Jenkins CI
---
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
2 files changed, 30 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/80/60980/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index 201b69f..7290f5d 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -88,6 +88,11 @@
info['clustersize'] = qemu_info['cluster-size']
if 'backing-filename' in qemu_info:
info['backingfile'] = qemu_info['backing-filename']
+if qemu_info['format'] == FORMAT.QCOW2:
+try:
+info['compat'] = qemu_info['format-specific']['data']['compat']
+except KeyError:
+raise QImgError(rc, out, err, "'compat' expected but not found")
return info
diff --git a/tests/qemuimgTests.py b/tests/qemuimgTests.py
index 6075f3b..77f75a7 100644
--- a/tests/qemuimgTests.py
+++ b/tests/qemuimgTests.py
@@ -79,13 +79,16 @@
leaf_path = os.path.join(tmpdir, 'leaf.img')
size = 1048576
leaf_fmt = qemuimg.FORMAT.QCOW2
-qemuimg.create(base_path, size=size, format=qemuimg.FORMAT.RAW)
-qemuimg.create(leaf_path, format=leaf_fmt, backing=base_path)
+with MonkeyPatchScope([(qemuimg, 'config', CONFIG)]):
+qemuimg.create(base_path, size=size, format=qemuimg.FORMAT.RAW)
+qemuimg.create(leaf_path, format=leaf_fmt, backing=base_path)
+
info = qemuimg.info(leaf_path)
self.assertEqual(leaf_fmt, info['format'])
self.assertEqual(size, info['virtualsize'])
self.assertEqual(self.CLUSTER_SIZE, info['clustersize'])
self.assertEqual(base_path, info['backingfile'])
+self.assertEqual('0.10', info['compat'])
def test_parse_error(self):
def call(cmd, **kw):
@@ -103,6 +106,13 @@
partial(fake_json_call, data))]):
self.assertRaises(qemuimg.QImgError, qemuimg.info, 'leaf.img')
+def test_missing_compat_for_qcow2_raises(self):
+data = self._fake_info()
+del data['format-specific']['data']['compat']
+with MonkeyPatchScope([(commands, "execCmd",
+partial(fake_json_call, data))]):
+self.assertRaises(qemuimg.QImgError, qemuimg.info, 'leaf.img')
+
@permutations((
('backing-filename', 'backingfile'),
('cluster-size', 'clustersize'),
@@ -115,6 +125,19 @@
info = qemuimg.info('unused')
self.assertNotIn(info_field, info)
+def test_compat_reported_for_qcow2_only(self):
+data = {
+"virtual-size": 1048576,
+"filename": "raw.img",
+"format": "raw",
+"actual-size": 0,
+"dirty-flag": False
+}
+with MonkeyPatchScope([(commands, "execCmd",
+partial(fake_json_call, data))]):
+info = qemuimg.info('unused')
+self.assertNotIn('compat', info)
+
class CreateTests(CommandTests):
--
To view, visit https://gerrit.ovirt.org/60980
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I91ee8ee96bdc3a230463987f857fd7e88c629b6a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Introduce supports_compat helper
Hello Nir Soffer, Amit Aviram,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60984
to review the following change.
Change subject: qemuimg: Introduce supports_compat helper
..
qemuimg: Introduce supports_compat helper
To enable checking if a qcow2 image has a supported compatibility level,
add a simple utility function to qemuimg.
Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344289
Signed-off-by: Adam Litke
Reviewed-on: https://gerrit.ovirt.org/59410
Reviewed-by: Nir Soffer
Continuous-Integration: Jenkins CI
Reviewed-by: Amit Aviram
---
M lib/vdsm/qemuimg.py
M tests/qemuimgTests.py
2 files changed, 11 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/60984/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index 7290f5d..c9d73fe 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -48,6 +48,10 @@
_QCOW2_COMPAT_SUPPORTED = ("0.10", "1.1")
+def supports_compat(compat):
+return compat in _QCOW2_COMPAT_SUPPORTED
+
+
class QImgError(Exception):
def __init__(self, ecode, stdout, stderr, message=None):
self.ecode = ecode
diff --git a/tests/qemuimgTests.py b/tests/qemuimgTests.py
index 77f75a7..ac7c0b1 100644
--- a/tests/qemuimgTests.py
+++ b/tests/qemuimgTests.py
@@ -50,6 +50,13 @@
@expandPermutations
+class GeneralTests(TestCaseBase):
+@permutations((("0.10", True), ("1.1", True), ("10.1", False)))
+def test_supports_compat(self, compat, result):
+self.assertEqual(result, qemuimg.supports_compat(compat))
+
+
+@expandPermutations
class InfoTests(TestCaseBase):
CLUSTER_SIZE = 65536
--
To view, visit https://gerrit.ovirt.org/60984
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Amit Aviram
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: tests: Use FakeStorageDomainCache in fake env
Hello Nir Soffer, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60982 to review the following change. Change subject: tests: Use FakeStorageDomainCache in fake env .. tests: Use FakeStorageDomainCache in fake env When creating fake storage environments for tests, set up a fake storage domain cache to enable code that produces storage domains to find our fake storage domain. Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/57055 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M tests/storagetestlib.py 1 file changed, 21 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/82/60982/1 diff --git a/tests/storagetestlib.py b/tests/storagetestlib.py index ec8012f..245e776 100644 --- a/tests/storagetestlib.py +++ b/tests/storagetestlib.py @@ -22,12 +22,14 @@ from testlib import make_file, namedTemporaryDir from storagefakelib import FakeLVM +from storagefakelib import FakeStorageDomainCache from monkeypatch import MonkeyPatchScope from vdsm import utils from vdsm.storage import constants as sc -from storage import sd, blockSD, fileSD, image, blockVolume +from storage import sd, blockSD, fileSD, image, blockVolume, volume +from storage import hsm from storage.sdm import volume_artifacts @@ -47,10 +49,13 @@ def fake_file_env(obj=None): with namedTemporaryDir() as tmpdir: sd_manifest = make_filesd_manifest(tmpdir) +fake_sdc = FakeStorageDomainCache() with MonkeyPatchScope([ -[sd, 'storage_repository', tmpdir] +[sd, 'storage_repository', tmpdir], +[volume, 'sdCache', fake_sdc], +[hsm, 'sdCache', fake_sdc], ]): - +fake_sdc.domains[sd_manifest.sdUUID] = FakeSD(sd_manifest) yield FakeEnv(sd_manifest) @@ -58,13 +63,17 @@ def fake_block_env(obj=None): with namedTemporaryDir() as tmpdir: lvm = FakeLVM(tmpdir) +fake_sdc = FakeStorageDomainCache() with MonkeyPatchScope([ (blockSD, 'lvm', lvm), (blockVolume, 'lvm', lvm), (volume_artifacts, 'lvm', lvm), (sd, 'storage_repository', tmpdir), +(volume, 'sdCache', fake_sdc), +(hsm, 'sdCache', fake_sdc), ]): sd_manifest = make_blocksd_manifest(tmpdir, lvm) +fake_sdc.domains[sd_manifest.sdUUID] = FakeSD(sd_manifest) yield FakeEnv(sd_manifest, lvm=lvm) @@ -74,6 +83,15 @@ yield +class FakeSD(object): +def __init__(self, sd_manifest): +self._manifest = sd_manifest + +@property +def manifest(self): +return self._manifest + + def make_sd_metadata(sduuid, version=3, dom_class=sd.DATA_DOMAIN, pools=None): md = FakeMetadata() md[sd.DMDK_SDUUID] = sduuid -- To view, visit https://gerrit.ovirt.org/60982 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d6aade8ae6942d8c8e14a92dec682f957044746 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-4.0 Gerrit-Owner: Adam Litke Gerrit-Reviewer: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: qemuimg: Keep supported qcow2 versions as a tuple
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60978
to review the following change.
Change subject: qemuimg: Keep supported qcow2 versions as a tuple
..
qemuimg: Keep supported qcow2 versions as a tuple
_QCOW2_COMPAT_SUPPORTED is a constant and as such it should be a tuple
instead of a list.
Change-Id: I488deba3ab8b33ab6617a23e2dd9eaca1427befc
Signed-off-by: Adam Litke
Reviewed-on: https://gerrit.ovirt.org/59648
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer
---
M lib/vdsm/qemuimg.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/60978/1
diff --git a/lib/vdsm/qemuimg.py b/lib/vdsm/qemuimg.py
index b2e7845..85e196f 100644
--- a/lib/vdsm/qemuimg.py
+++ b/lib/vdsm/qemuimg.py
@@ -44,7 +44,7 @@
RAW = "raw"
VMDK = "vmdk"
-_QCOW2_COMPAT_SUPPORTED = ["0.10", "1.1"]
+_QCOW2_COMPAT_SUPPORTED = ("0.10", "1.1")
__iregex = {
'format': re.compile("^file format: (?P\w+)$"),
--
To view, visit https://gerrit.ovirt.org/60978
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I488deba3ab8b33ab6617a23e2dd9eaca1427befc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Only allow compat designated by config
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60986
to review the following change.
Change subject: verify_untrusted_volume: Only allow compat designated by config
..
verify_untrusted_volume: Only allow compat designated by config
Currently each host sets which qemuimg compat level is allowed. Use
this setting also during volume verification until 0.10 and 1.1 can be
supported at the same time.
Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344289
Signed-off-by: Adam Litke
Reviewed-on: https://gerrit.ovirt.org/60113
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer
---
M tests/storage_hsm_test.py
M vdsm/storage/hsm.py
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/60986/1
diff --git a/tests/storage_hsm_test.py b/tests/storage_hsm_test.py
index 53a3b56..e9e0448 100644
--- a/tests/storage_hsm_test.py
+++ b/tests/storage_hsm_test.py
@@ -22,6 +22,7 @@
from contextlib import contextmanager
from monkeypatch import MonkeyPatchScope
+from testlib import make_config
from testlib import VdsmTestCase
from testlib import permutations, expandPermutations
from storagetestlib import fake_file_env
@@ -83,6 +84,23 @@
h.verify_untrusted_volume, 'sp',
vol.sdUUID, vol.imgUUID, vol.volUUID)
+@permutations((
+('0.10', '1.1'),
+('1.1', '0.10'),
+))
+def test_disabled_compat_raises(self, qemu_compat, hsm_compat):
+with self.fake_volume(sc.COW_FORMAT) as vol:
+create_conf = make_config([('irs', 'qcow2_compat', qemu_compat)])
+check_conf = make_config([('irs', 'qcow2_compat', hsm_compat)])
+with MonkeyPatchScope([(qemuimg, 'config', create_conf),
+ (hsm, 'config', check_conf)]):
+qemuimg.create(vol.volumePath, size=self.SIZE,
+ format=qemuimg.FORMAT.QCOW2)
+h = FakeHSM()
+self.assertRaises(se.ImageVerificationError,
+ h.verify_untrusted_volume, 'sp',
+ vol.sdUUID, vol.imgUUID, vol.volUUID)
+
def test_compat_not_checked_for_raw(self):
with self.fake_volume(sc.RAW_FORMAT) as vol:
info = {"format": qemuimg.FORMAT.RAW, "compat": "BAD"}
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index adaed34..f5251cc 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1516,6 +1516,14 @@
raise se.ImageVerificationError(
"qcow2 compat %r is not supported" % qemu_compat)
+# Although we can handle both 0.1 and 1.1 compat qcow2 files, we
+# currently limit support to one or the other via the vdsm config.
+# Once both are supported concurrently this check can be removed.
+required_compat = config.get('irs', 'qcow2_compat')
+if qemu_compat != required_compat:
+raise se.ImageVerificationError(
+"qcow2 compat %r not supported by this host" % qemu_compat)
+
def validateImageMove(self, srcDom, dstDom, imgUUID):
"""
Determines if the image move is legal.
--
To view, visit https://gerrit.ovirt.org/60986
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I86da01d885c3f265761fa323aea8b50524c0fcbe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[ovirt-4.0]: verify_untrusted_volume: Check compatibility version
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/60985
to review the following change.
Change subject: verify_untrusted_volume: Check compatibility version
..
verify_untrusted_volume: Check compatibility version
When importing a volume using imaged, QCOW2 volumes with an unsupported
compatibility version should be rejected.
Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1344289
Signed-off-by: Adam Litke
Reviewed-on: https://gerrit.ovirt.org/59411
Reviewed-by: Nir Soffer
Continuous-Integration: Jenkins CI
---
M tests/storage_hsm_test.py
M vdsm/storage/hsm.py
2 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/60985/1
diff --git a/tests/storage_hsm_test.py b/tests/storage_hsm_test.py
index e2c565b..53a3b56 100644
--- a/tests/storage_hsm_test.py
+++ b/tests/storage_hsm_test.py
@@ -21,6 +21,7 @@
import uuid
from contextlib import contextmanager
+from monkeypatch import MonkeyPatchScope
from testlib import VdsmTestCase
from testlib import permutations, expandPermutations
from storagetestlib import fake_file_env
@@ -73,6 +74,23 @@
h.verify_untrusted_volume,
'sp', vol.sdUUID, vol.imgUUID, vol.volUUID)
+def test_unsupported_compat(self):
+with self.fake_volume(sc.COW_FORMAT) as vol:
+info = {"format": qemuimg.FORMAT.QCOW2, "compat": "BAD"}
+with MonkeyPatchScope([(qemuimg, 'info', lambda unused: info)]):
+h = FakeHSM()
+self.assertRaises(se.ImageVerificationError,
+ h.verify_untrusted_volume, 'sp',
+ vol.sdUUID, vol.imgUUID, vol.volUUID)
+
+def test_compat_not_checked_for_raw(self):
+with self.fake_volume(sc.RAW_FORMAT) as vol:
+info = {"format": qemuimg.FORMAT.RAW, "compat": "BAD"}
+with MonkeyPatchScope([(qemuimg, 'info', lambda unused: info)]):
+h = FakeHSM()
+self.assertNotRaises(h.verify_untrusted_volume, 'sp',
+ vol.sdUUID, vol.imgUUID, vol.volUUID)
+
@contextmanager
def fake_volume(self, vol_fmt):
with fake_file_env() as env:
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index c9b2216..adaed34 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -1508,6 +1508,14 @@
"allowed for an untrusted volume." %
qemu_info["backingfile"])
+if qemu_format == qemuimg.FORMAT.QCOW2:
+# Vdsm depends on qemu-img 2.3.0 or later which always reports
+# 'compat' for qcow2 volumes.
+qemu_compat = qemu_info["compat"]
+if not qemuimg.supports_compat(qemu_compat):
+raise se.ImageVerificationError(
+"qcow2 compat %r is not supported" % qemu_compat)
+
def validateImageMove(self, srcDom, dstDom, imgUUID):
"""
Determines if the image move is legal.
--
To view, visit https://gerrit.ovirt.org/60985
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Nir Soffer
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network: filter out 'veth' devices.
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices. .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: acquire external ifaces
Petr Horáček has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 19: Code-Review-1 This will be replaced by many focused patches. -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a08095e03a3167d0be4f7261b9a43c9cf92c67b Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: introduce acquire module
gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60974 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: introduce acquire module
Petr Horáček has uploaded a new change for review.
Change subject: net: introduce acquire module
..
net: introduce acquire module
This module will be used to acquire external devices, both persisted
by ifcfg and not persisted. It is needed for OVS switch (and eventually
also for iproute2 and pyroute2).
This patch also introduces PersistingStringIO which is needed for files
mocking.
Change-Id: I180cfd7d69c0ae0a24188bc3d909b9d3d7c12145
Bug-Url: https://bugzilla.redhat.com/1195208
Signed-off-by: Petr Horáček
---
M lib/vdsm/network/Makefile.am
A lib/vdsm/network/acquire.py
A tests/network/acquire_ifaces_test.py
M tests/testlib.py
M vdsm.spec.in
5 files changed, 206 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/60974/1
diff --git a/lib/vdsm/network/Makefile.am b/lib/vdsm/network/Makefile.am
index 3889776..52a5719 100644
--- a/lib/vdsm/network/Makefile.am
+++ b/lib/vdsm/network/Makefile.am
@@ -24,6 +24,7 @@
vdsmnetworkdir = $(vdsmpylibdir)/network
dist_vdsmnetwork_PYTHON = \
__init__.py \
+ acquire.py \
api.py \
errors.py \
canonicalize.py \
diff --git a/lib/vdsm/network/acquire.py b/lib/vdsm/network/acquire.py
new file mode 100644
index 000..3bd4cda
--- /dev/null
+++ b/lib/vdsm/network/acquire.py
@@ -0,0 +1,78 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+from __future__ import absolute_import
+
+import itertools
+import os
+
+import six
+
+from .configurators import ifcfg
+from .ip import address
+from .ip import dhclient
+
+
+ACQUIRED_IFCFG_SUFFIX = (
+u'\n'
+'# This device is now owned by VDSM\n'
+'ONBOOT=no\n'
+'NM_CONTROLLED=no\n'
+'# end of VDSM suffix.'
+)
+
+
+def acquire_unowned_ifaces(netinfo_nets, external_ifaces):
+"""Acquire external ifaces which are not owned by us."""
+used_ports = frozenset(itertools.chain.from_iterable(
+[attrs['ports'] for attrs in six.itervalues(netinfo_nets)]))
+for iface in external_ifaces:
+if iface not in used_ports:
+_acquire_external_iface(iface)
+
+
+def _acquire_external_iface(iface):
+is_ifcfg_controlled = os.path.isfile(ifcfg.NET_CONF_PREF + iface)
+if is_ifcfg_controlled:
+_acquire_external_ifcfg_iface(iface)
+else:
+_acquire_external_non_persistent_iface(iface)
+
+
+def _acquire_external_ifcfg_iface(iface):
+# TODO: Test that NM does not turn iface UP again.
+with open(ifcfg.NET_CONF_PREF + iface, 'r+') as f:
+lines = f.readlines()
+_comment_out_parameters(('ONBOOT', 'NM_CONTROLLED'), lines)
+f.seek(0)
+f.writelines(lines)
+f.write(ACQUIRED_IFCFG_SUFFIX)
+ifcfg.ifdown(iface)
+
+
+def _comment_out_parameters(parameters, lines):
+for i, line in enumerate(lines):
+if any([line.startswith(parameter) for parameter in parameters]):
+lines[i] = '#' + line
+
+
+def _acquire_external_non_persistent_iface(iface):
+# TODO: Tell NM to ignore this iface if it is needed.
+dhclient.kill(iface, family=4)
+dhclient.kill(iface, family=6)
+address.flush(iface)
diff --git a/tests/network/acquire_ifaces_test.py
b/tests/network/acquire_ifaces_test.py
new file mode 100644
index 000..815adb2
--- /dev/null
+++ b/tests/network/acquire_ifaces_test.py
@@ -0,0 +1,104 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+# 02110-1301 USA
+#
+# Refer to the README and COPYING files fo
Change in vdsm[master]: tests: Set vars/ssl to true in graphics tests
gerrit-hooks has posted comments on this change. Change subject: tests: Set vars/ssl to true in graphics tests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31df7639f23f9cf813d0baf1bb102920bea76736 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Add createrepo requirement to fc24 ci packages
gerrit-hooks has posted comments on this change. Change subject: Add createrepo requirement to fc24 ci packages .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60893 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f826dfb5b94e7b92bfe8ca721dfd62d7907206b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Set vars/ssl to true in graphics tests
gerrit-hooks has posted comments on this change. Change subject: tests: Set vars/ssl to true in graphics tests .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31df7639f23f9cf813d0baf1bb102920bea76736 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: Set vars/ssl to true in graphics tests
Milan Zamazal has uploaded a new change for review.
Change subject: tests: Set vars/ssl to true in graphics tests
..
tests: Set vars/ssl to true in graphics tests
In 8a7479c, support for graphics defaultMode was added and
defaultMode="secure" is now expected in test outputs. However this is
only present when vars/ssl configuration option is set to true. We must
ensure this is so by monkey patching the corresponding graphics tests.
Otherwise the configuration value from /etc/vdsm/vdsm.conf (if present)
is apparently used and the tests may fail if the value is false.
Change-Id: I31df7639f23f9cf813d0baf1bb102920bea76736
Signed-off-by: Milan Zamazal
---
M tests/deviceTests.py
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/60973/1
diff --git a/tests/deviceTests.py b/tests/deviceTests.py
index c24b119..618f8a1 100644
--- a/tests/deviceTests.py
+++ b/tests/deviceTests.py
@@ -28,7 +28,7 @@
from virt.domain_descriptor import DomainDescriptor
from monkeypatch import MonkeyPatch, MonkeyPatchScope
-from testlib import permutations, expandPermutations
+from testlib import permutations, expandPermutations, make_config
from testlib import VdsmTestCase as TestCaseBase
from testlib import XMLTestCase
import vmfakelib as fake
@@ -545,6 +545,8 @@
self.assertEqual(graphDev.port, graphConf['port'])
self.assertEqual(graphDev.tlsPort, graphConf['tlsPort'])
+@MonkeyPatch(graphics, 'config',
+ make_config([('vars', 'ssl', 'true')]))
def testLegacyGraphicsXML(self):
vmConfs = [
{'display': 'vnc', 'displayPort': '-1', 'displayNetwork':
@@ -566,6 +568,8 @@
for vmConf, xml in zip(vmConfs, self.GRAPHICS_XMLS):
self._verifyGraphicsXML(vmConf, xml, isLegacy=True)
+@MonkeyPatch(graphics, 'config',
+ make_config([('vars', 'ssl', 'true')]))
def testGraphicsDeviceXML(self):
vmConfs = [
{'devices': [{
--
To view, visit https://gerrit.ovirt.org/60973
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I31df7639f23f9cf813d0baf1bb102920bea76736
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: **WIP** tool: reconfigure containers networks
gerrit-hooks has posted comments on this change. Change subject: **WIP** tool: reconfigure containers networks .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: supervdsm: expose systemd utilities
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/56491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: virt: add optional container support
gerrit-hooks has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 38: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/53820 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f Gerrit-PatchSet: 38 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: **WIP** tool: reconfigure containers networks
gerrit-hooks has posted comments on this change. Change subject: **WIP** tool: reconfigure containers networks .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60918 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6053e283c004cd61ba7727cea22ba73a631180ba Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: network: filter out 'veth' devices.
gerrit-hooks has posted comments on this change. Change subject: network: filter out 'veth' devices. .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60821 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I859c4bc885c0afd99fdaf741706d9bd1538850e6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tests: containers: add testsuite
gerrit-hooks has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/60678 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: core: containers: add the container support module
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: core: containers: add the container support module
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fb768ea97dd719cde9bd5e57e1b7cabe4b0f0ae Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
