Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 17:

(8 comments)

https://gerrit.ovirt.org/#/c/62831/17//COMMIT_MSG
Commit Message:

PS17, Line 16: clenup
> cleanup
Done


https://gerrit.ovirt.org/#/c/62831/17/lib/vdsm/network/link/setup.py
File lib/vdsm/network/link/setup.py:

PS17, Line 46: attrs
> can we create a to-be-configured bond object here and don't touch attrs any
I don't think so, but perhaps you have a proposal for all this mess here.

First, I think I should write a good explanation for this method as it is not 
trivial at all and uses some tricks and has some limitations.
Let me know if it is more clear after this explanation:

Editing bonds requires special treatment due to the required steps to perform 
editation on a bulk of bonds.
To support scenarios of moving slaves between bonds, the following algorithm 
has been chosen: Go over all bonds twice, once to remove slaves and secondly to 
add slaves.

When we split the bond editing like that, we break a single bond transaction 
into two parts.
If we assume that the removal always succeeds, then we can do this:
- Create a Bond object to preserve initial state.
- Process bonds slaves removal, but not through the initial bond object created 
in the previous step (to preserve the initial state intact).
- Process the bonds slaves adding using step1 bond object, so if it will fail, 
it can revert to the initial state.
- For each bond in the second process, on success, save it in running config.

So the limitation we are left with is in a case of removal failure, all 
previous handled bonds will not be reverted as well (only the current failing 
one).
Perhaps they can be handled on failure using the initial bond objects, I am not 
sure.
I'm not even clear if failing on slave removal is something that can happen, 
but that is not a good argument.


Line 52: # allow a proper rollback to occur in case of failure.
Line 53: with Bond(init_bond.master) as bond:
Line 54: slaves2remove = self._slaves2remove(bond.slaves,
Line 55: 
frozenset(attrs['nics']))
Line 56: bond.del_slaves(slaves2remove)
> you need to update _config here.
This is a limitation, see response above.
If we save here and fail on adding slaves, the running config will not 
represent the correct config and we cannot even recover from a case where only 
a partial editing of a bond has occurred.
Line 57: 
Line 58: for (bond, attrs) in init_bond_pool:
Line 59: with bond:
Line 60: bond.refresh()


PS17, Line 58: (bond, attrs)
> parentheses are not needed
Done


PS17, Line 58: bond
> in the previous iteration is is called init_bond
Indeed, but just because I needed the name of the bond. The bond object used 
was still 'bond'.


Line 61: requested_slaves = frozenset(attrs['nics'])
Line 62: slaves2add = self._slaves2add(bond.slaves, 
requested_slaves)
Line 63: bond.add_slaves(slaves2add)
Line 64: 
Line 65: self._config.removeBonding(bond.master)
> we don't need to remove it if we set it.
Done
Line 66: self._config.setBonding(bond.master, attrs)
Line 67: 
Line 68: bond.up()
Line 69: _ip_flush(slaves2add)


https://gerrit.ovirt.org/#/c/62831/17/tests/network/link_setup_test.py
File tests/network/link_setup_test.py:

Line 1: #
> remove this nasty extra # please
Done
Line 2: # Copyright 2016 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


Line 85:  setup_bonds.acquired_ifaces)
Line 86: BondMock.assert_called_with(BOND1_NAME)
Line 87: 
BondMock.return_value.add_slaves.assert_called_once_with(bond_slaves)
Line 88: config_mock.removeBonding.assert_called_once_with(BOND1_NAME)
Line 89: config_mock.setBonding.assert_called_once_with(BOND1_NAME, 
bond_attrs)
> can you please add a 'explode-in-the-middle' test here? setup some bonds, d
This is a tricky as it is dependent on the Bond driver functionality of 
reverting to init state if its transaction fails. Such a test will be a bit 
more than a unit tests and a bit less than an integration test.
I think we do have it covered in the functional tests.

To summarize, if you think we should cover the messy edit logic in a unit test, 
we will need to depend on the specific bond driver, mock its file access and 
check the integration between SetupBonds and BondSysFS.
Line 90: 
Line 91: @staticmethod
Line 92: def _assert_ip_flush_called(bond_slaves, dhclient_mock, 
address_mock):
Line 93: for slave in bond_slaves:


-- 
To view, visit https://gerrit.ovirt.org/62831
To 

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 13:

(4 comments)

https://gerrit.ovirt.org/#/c/61693/13/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 136
Line 137
Line 138
Line 139
Line 140
> We need to write these tests now.
Let's save this for a follow-up patch.  This patch is about adding locking, not 
adding these tests.


Line 116: 
Line 117: with checked_locks() as checker:
Line 118: job.run()
Line 119: wait_for_job(job)
Line 120: checker.validate(self.get_lock_list(src_vol, dst_vol))
> I don't think that anyone can understand from this code what is the expecte
Good idea.  This also avoids the need for the LockChecker infrastructure.
Line 121: 
Line 122: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 123: self.assertEqual(100.0, job.progress)
Line 124: self.assertNotIn('error', job.info())


https://gerrit.ovirt.org/#/c/61693/13/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 95
Line 96
Line 97
Line 98
Line 99
> We must implement this todo to finish this milestone, you can add it in the
Will do.


Line 96: self._vol = None
Line 97: 
Line 98: # @property
Line 99: # def host_id(self):
Line 100: # return self._host_id
> Please remove if not needed.
Done
Line 101: 
Line 102: @property
Line 103: def locks(self):
Line 104: img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, self.sd_id)


-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 9: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 3: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Autodelete

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Autodelete
..


Patch Set 3:

(3 comments)

Mostly good, we have to implement state changes and make it thread safe (next 
patch?)

https://gerrit.ovirt.org/#/c/62002/3/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 120: def active(self):
Line 121: return self.status in (STATUS.PENDING, STATUS.RUNNING)
Line 122: 
Line 123: def abort(self):
Line 124: # TODO: Don't abort if not pending and not running
We should do this now
Line 125: self._status = STATUS.ABORTED
Line 126: logging.info('Job %r aborting...', self._id)
Line 127: self._abort()
Line 128: if self.autodelete:


Line 128: if self.autodelete:
Line 129: self._autodelete()
Line 130: 
Line 131: def run(self):
Line 132: # TODO: Don't run if aborted or not pending
We should do this now - you can submit this in another patch to keep this patch 
small if you like.
Line 133: self._status = STATUS.RUNNING
Line 134: try:
Line 135: self._run()
Line 136: except Exception as e:


https://gerrit.ovirt.org/#/c/62002/3/tests/jobsTests.py
File tests/jobsTests.py:

Line 277: job = AutodeleteJob(exception=error)
Line 278: jobs.add(job)
Line 279: with MonkeyPatchScope([(jobs, 'config', cfg)]):
Line 280: self.run_job(job)
Line 281: time.sleep(0.1)  # Wait for the scheduler
Fragile, use fake scheduler instead.
Line 282: self.assertRaises(jobs.NoSuchJob, jobs.get, job.id)
Line 283: 
Line 284: def test_autodelete_when_aborted(self):
Line 285: cfg = make_config([('jobs', 'autodelete_delay', '0')])


-- 
To view, visit https://gerrit.ovirt.org/62002
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4aafd2271397bd9bc4289dc1aab723398d475add
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: jobs: Move run from sdm.base.Job to jobs.Job

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: jobs: Move run from sdm.base.Job to jobs.Job
..


Patch Set 3: Code-Review+2

We have to make jobs thread safe in another patch.

-- 
To view, visit https://gerrit.ovirt.org/62001
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I194eb154d70e846b7ec5d462faa26b3aa35d2ff6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Drop support for thread-local job_id

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Drop support for thread-local job_id
..


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/62083/2/tests/storage_sdm_api_test.py
File tests/storage_sdm_api_test.py:

Line 36
Line 37
Line 38
Line 39
Line 40
What are we testing here now?


-- 
To view, visit https://gerrit.ovirt.org/62083
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4697f2d3f5e6826e0e95e03a10445c2df2abddf
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass scheduler to jobs.start

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Pass scheduler to jobs.start
..


Patch Set 2: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Pass scheduler to jobs.start

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Pass scheduler to jobs.start
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/62000/2/tests/jobsTests.py
File tests/jobsTests.py:

Line 63: class JobsTests(VdsmTestCase):
Line 64: TIMEOUT = 1
Line 65: 
Line 66: def setUp(self):
Line 67: scheduler = schedule.Scheduler()
I would not create a real scheduler, this will make it much harder to test - 
you will have to wait until the scheduled call run, so we will have slow or 
racy (or both) tests, or need to mock stuff to wait for events.

Using a fake scheduler, we can check which call where scheduled, and we can 
simulate scheduled events by calling the scheduled functions.

For this patch, passing None, or object() is just fine. If you want to test 
start or stop, fake scheduler is better, but there is not much to test anyway.
Line 68: jobs.start(scheduler)
Line 69: 
Line 70: def tearDown(self):
Line 71: jobs.stop()


-- 
To view, visit https://gerrit.ovirt.org/62000
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5004b49b992ae0f7171a0f0549465cc8782d05da
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Add start/stop interface to jobs module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Add start/stop interface to jobs module
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e67018fa45bcae9aedf74a9b4587230f6118024
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sp: Rename storage domain upgrade threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sp: Rename storage domain upgrade threads
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63529
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5410d468448cee91a245937a5012fd50d473423
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sd: Remove unused variable and evil thread

[ahino]

Ala Hino has posted comments on this change.

Change subject: sd: Remove unused variable and evil thread
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63520
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2f17e591bcd03b83a0df5b8e2a31835bcd572064
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Rename cleanup threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: resourceManager: Rename cleanup threads
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63527
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5139ff3331daba9155037dba4bab64298a64943f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: mailbox: Rename storage mailbox threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: mailbox: Rename storage mailbox threads
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife5246ea36a0646f62416f1fdcbaf617fe85bf70
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: check: Rename check event loop thread

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: check: Rename check event loop thread
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63522
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I927659479d3be888d2e38bd30c6c13e924b2745f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: task: Rename cleanup threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: task: Rename cleanup threads
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63526
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9585432fb0e290befdc37282dd1db3db7d2ba68f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: misc: Rename event threads to event/N

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: misc: Rename event threads to event/N
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63521
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I825897d5a7802d5b201aff30258acd08a2bba865
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 10:

Thanks Irit!

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: py3: misc.py compliance
..


storage: py3: misc.py compliance

now using several modules/methods via six for both py2 and py3
compliance (and replacing xrange with range)

Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Signed-off-by: Leon Goldberg 
Reviewed-on: https://gerrit.ovirt.org/63192
Reviewed-by: Irit Goihman 
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
Tested-by: Irit Goihman 
---
M lib/vdsm/storage/misc.py
1 file changed, 6 insertions(+), 5 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 13:

(4 comments)

https://gerrit.ovirt.org/#/c/61693/13/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 136
Line 137
Line 138
Line 139
Line 140
We need to write these tests now.


Line 116: 
Line 117: with checked_locks() as checker:
Line 118: job.run()
Line 119: wait_for_job(job)
Line 120: checker.validate(self.get_lock_list(src_vol, dst_vol))
I don't think that anyone can understand from this code what is the expected 
behavior of the code (e.g. what locks were taken and in which order).

I think we should use a much simpler approach - we can mock guarded.context, so 
we test only that we passed the correct locks. We already tested that 
guarded.context does the right thing with locks. this will make the test much 
simpler.

This assumes that the code is using guarded.context - theoretically someone can 
write perfect code without it, but the test will fail, but practically we want 
all code to use guarded.context for locking, so this is not a real issue.

I would test this in another test that does not do any data copying (mock 
qemu.convert?), and test only the locks passed to the context while job was 
running.
Line 121: 
Line 122: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 123: self.assertEqual(100.0, job.progress)
Line 124: self.assertNotIn('error', job.info())


https://gerrit.ovirt.org/#/c/61693/13/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 95
Line 96
Line 97
Line 98
Line 99
We must implement this todo to finish this milestone, you can add it in the 
next patch if you like.


Line 96: self._vol = None
Line 97: 
Line 98: # @property
Line 99: # def host_id(self):
Line 100: # return self._host_id
Please remove if not needed.
Line 101: 
Line 102: @property
Line 103: def locks(self):
Line 104: img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, self.sd_id)


-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: py3: misc.py compliance

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: storage: py3: misc.py compliance
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63192
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I151c627efd0836bc6ffdf1d4126f504cf378a68c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: sos: change getConnectedStoragePoolsList result key
..

sos: change getConnectedStoragePoolsList result key

patch https://gerrit.ovirt.org/#/c/63483 fixes
getConnectedStoragePoolsList result so it's needs to be updated in
sos report which uses the old wrong 'items' key.

Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Signed-off-by: Irit Goihman 
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/63557/1

diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index dd3ae91..5939d58 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -143,8 +143,8 @@
 self.addObjectAsFile(
 cli.getAllTasksStatuses(), "getAllTasksStatuses")
 
-if "items" in cli.getConnectedStoragePoolsList():
-pools_list = cli.getConnectedStoragePoolsList()["items"]
+if "poollist" in cli.getConnectedStoragePoolsList():
+pools_list = cli.getConnectedStoragePoolsList()["poollist"]
 for pool in pools_list:
 self.addObjectAsFile(
 cli.getSpmStatus(pool), "getSpmStatus " + pool)


-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: dhclient - address flush before starting and on shutdown
..


net: dhclient - address flush before starting and on shutdown

Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63088
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/ip/dhclient.py
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: dhclient kill - early exit if iface does not exists
..


net: dhclient kill - early exit if iface does not exists

There is no need to lookup for dhclient daemons for devices that do not
exists. Such a daemon cannot exist (as it has no device to listen on).

Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63087
Reviewed-by: Petr Horáček 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/ip/dhclient.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
..


Patch Set 8: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: domainMonitor.getAllHostIds() API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: domainMonitor.getAllHostIds() API
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/61997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If1d89bb114eea58387cd88d9da3c27b69d6affa3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: domainMonitor.getAllHostIds() API

[alitke]

Adam Litke has abandoned this change.

Change subject: storage: domainMonitor.getAllHostIds() API
..


Abandoned

No longer needed

-- 
To view, visit https://gerrit.ovirt.org/61997
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If1d89bb114eea58387cd88d9da3c27b69d6affa3
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to Volume Leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for guarded to Volume Leases
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c3dc65975c236545d15b8e8be62403c29c7f9f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Pass the real hostid to copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Pass the real hostid to copy_data
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/62576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I367576fca126be695d7617477f92110941620a3b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Pass the real hostid to copy_data

[alitke]

Adam Litke has submitted this change and it was merged.

Change subject: sdm: Pass the real hostid to copy_data
..


sdm: Pass the real hostid to copy_data

We have been passing the hostid as None to copy_data but the correct
value will need to be passed in order to support volume leases.  Since
we use the same hostid for all storage domains and the that hostid is
the same as the id attribute of the connected storage pool we can add a
simple helper to supply the proper hostid to sdm verbs.  This will need
to be changed if we remove storage pools or if we opt to use different
hostid values for each domain.

Change-Id: I367576fca126be695d7617477f92110941620a3b
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/62576
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M vdsm/storage/hsm.py
1 file changed, 12 insertions(+), 1 deletion(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Adam Litke: Verified
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/62576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I367576fca126be695d7617477f92110941620a3b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for guarded to ResourceManager
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[alitke]

Adam Litke has submitted this change and it was merged.

Change subject: storage: Add support for guarded to ResourceManager
..


storage: Add support for guarded to ResourceManager

Support the use of ResourceManager resources with the guarded utilities
by creating a ResourceManagerLock class that conforms to the
guarded.AbstractLock semantics.

Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/63548
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/resourceManagerTests.py
M vdsm/storage/resourceManager.py
2 files changed, 82 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 16:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[alitke]

Adam Litke has submitted this change and it was merged.

Change subject: storage: Introduce guarded utilities
..


storage: Introduce guarded utilities

Throughout the storage code we have implicit locking rules which we
follow in order to ensure that concurrent operations will not conflict
with one another.  We also require a specific locking order to prevent
deadlocks.  This code is repeated throughout the storage subsystem and
is error prone.  To alleviate this, introduce the guarded module with a
context manager that can perform the necessary locking.  At first we
will support resourceManager locks and volume leases.

The contextmanager accepts a variable number of lock lists where each
list corresponds to the locks required to protect one element of the
operation (eg.  a source volume).  Lists must contain only AbstractLock
derived objects.  All locks from all lists are aggregated and locked
according to the rules.  When exiting the context (or upon error) the
locks are released in reverse order.  If an exception was raised inside
the context, that exception will be propagated regardless of any lock
release failures that may occur.

The following rules are currently enforced:
- Locks are collected from all lists and sorted using namespace,
  name, and mode (in that order)
- Due to namespace sorting, ResourceManager locks are taken before
  volume leases
- Duplicate locks are removed (only when ns, name, and mode match)
- Locks are acquired in sorted order and released in reverse order

Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/61435
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M lib/vdsm/storage/Makefile.am
A lib/vdsm/storage/guarded.py
M tests/Makefile.am
A tests/storage_guarded_test.py
M tests/storagetestlib.py
M tests/storagetestlibTests.py
M vdsm.spec.in
7 files changed, 428 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/63089/1/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 426: nics_used += attr['nics']
Line 427: for nic in nics_used:
Line 428: utils.rmFile(IFCFG_PREFIX + nic)
Line 429: 
Line 430: self._cleanup_lease_files(set(NETSETUP) | set(BONDSETUP) | 
sb_ifaces)
> iproute2 configurator is using iface==network's toplevel device, which is N
Done
Line 431: 
Line 432: return status, msg
Line 433: 
Line 434: def _cleanup_lease_files(self, ifaces):


https://gerrit.ovirt.org/#/c/63089/8/tests/network/netfunctestlib.py
File tests/network/netfunctestlib.py:

Line 430: self._cleanup_lease_files(set(NETSETUP) | set(BONDSETUP) | 
sb_ifaces)
Line 431: 
Line 432: return status, msg
Line 433: 
Line 434: def _cleanup_lease_files(self, ifaces):
> it is the same for ifcfg bridgeless networks, isn't it?
Done
Line 435: for iface in ifaces:
Line 436: utils.rmFile(dhclient.LEASE_FILE.format('', iface))
Line 437: utils.rmFile(dhclient.LEASE_FILE.format('6', iface))
Line 438: 


-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Expose owned_device method through the configurator

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Expose owned_device method through the configurator
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63442
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1febd494c5a01ceecd894e8542c1adb3cda704a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - preserve original slaves link state.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - preserve original slaves link state.
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63446
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia98d01512322f88bf9819532afb2ea337cee7749
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - adding a transaction context.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - adding a transaction context.
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63443
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8d015ed235c3620c04131e57ad079a2ec1a0ecc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - add refresh method to update bond config

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - add refresh method to update bond config
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63445
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f36cc24833b0fc612c3af033c54c7bca4742a5a
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Add logging to the bond driver.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Add logging to the bond driver.
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I043a6232d59cd87f6b973d856df297322f4be387
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient - address flush before starting and on shutdown

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient - address flush before starting and on shutdown
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e72f2aeb9f557a4cef49200fe195e6879490dcc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: Clean lease files on setup-cleanup
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63089
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9bcf0820d1641c26566e4e5eda9badc68d2fb8c2
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: dhclient kill - early exit if iface does not exists

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: dhclient kill - early exit if iface does not exists
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ba37ce248f1daeec8e79bd192261c1840417310
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 18:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Use Linux bonds with OVS networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Use Linux bonds with OVS networks
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63119
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6aeff335949a6e2996f7c3faa524df784dff1b01
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Bond - Expose the (kernel) bond list.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Bond - Expose the (kernel) bond list.
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63234
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3ba2b9d5ec712b268cc3775682506ec83aabbdb8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: Link setup module - includes bond setup logic.
..


Patch Set 17: Code-Review-1

(8 comments)

https://gerrit.ovirt.org/#/c/62831/17//COMMIT_MSG
Commit Message:

PS17, Line 16: clenup
cleanup


https://gerrit.ovirt.org/#/c/62831/17/lib/vdsm/network/link/setup.py
File lib/vdsm/network/link/setup.py:

PS17, Line 46: attrs
can we create a to-be-configured bond object here and don't touch attrs 
anymore? it will require Bond.__init__ changes, so it won't import existing.


Line 52: # allow a proper rollback to occur in case of failure.
Line 53: with Bond(init_bond.master) as bond:
Line 54: slaves2remove = self._slaves2remove(bond.slaves,
Line 55: 
frozenset(attrs['nics']))
Line 56: bond.del_slaves(slaves2remove)
you need to update _config here.
Line 57: 
Line 58: for (bond, attrs) in init_bond_pool:
Line 59: with bond:
Line 60: bond.refresh()


PS17, Line 58: (bond, attrs)
parentheses are not needed


PS17, Line 58: bond
in the previous iteration is is called init_bond


Line 61: requested_slaves = frozenset(attrs['nics'])
Line 62: slaves2add = self._slaves2add(bond.slaves, 
requested_slaves)
Line 63: bond.add_slaves(slaves2add)
Line 64: 
Line 65: self._config.removeBonding(bond.master)
we don't need to remove it if we set it.
Line 66: self._config.setBonding(bond.master, attrs)
Line 67: 
Line 68: bond.up()
Line 69: _ip_flush(slaves2add)


https://gerrit.ovirt.org/#/c/62831/17/tests/network/link_setup_test.py
File tests/network/link_setup_test.py:

Line 1: #
remove this nasty extra # please
Line 2: # Copyright 2016 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by


Line 85:  setup_bonds.acquired_ifaces)
Line 86: BondMock.assert_called_with(BOND1_NAME)
Line 87: 
BondMock.return_value.add_slaves.assert_called_once_with(bond_slaves)
Line 88: config_mock.removeBonding.assert_called_once_with(BOND1_NAME)
Line 89: config_mock.setBonding.assert_called_once_with(BOND1_NAME, 
bond_attrs)
can you please add a 'explode-in-the-middle' test here? setup some bonds, do 
some detaches during editations and then explode when trying to attach. test if 
_config is in consistent state (and therefore we are able to roll back).
Line 90: 
Line 91: @staticmethod
Line 92: def _assert_ip_flush_called(bond_slaves, dhclient_mock, 
address_mock):
Line 93: for slave in bond_slaves:


-- 
To view, visit https://gerrit.ovirt.org/62831
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f01a401cb1b96e357bc462e528a2a547c59c24
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Start all VM related stuff after switching to post-cop...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Start all VM related stuff after switching to post-copy 
migration
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63551
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b17e58f63cbd9db09e4420871a562eaa0b3f3d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Remove backward compatibility from post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Remove backward compatibility from post-copy migration
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8ccb2883ea22450a76c3a3a478d9fc87b41d736e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Refuse to cancel post-copy migrations

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Refuse to cancel post-copy migrations
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670ab48ed3fe69582646675d8b683bcdb3cfa038
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Use a variable for self._vm in MonitorThread action ha...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Use a variable for self._vm in MonitorThread action 
handling
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63553
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e41f8b3ef27319c51e18ad2c75bbb3c61b61c76
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Fetch VM stats from the destination during post-copy m...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Fetch VM stats from the destination during post-copy 
migration
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63552
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iac3da08b0816e7a9a247969147c17b15518c7624
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Minor typo fixes in Vm.getStats docstring
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 6:

* #1354343::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check Product::#1354343::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Minor typo fixes in Vm.getStats docstring

[mzamazal]

Milan Zamazal has uploaded a new change for review.

Change subject: virt: Minor typo fixes in Vm.getStats docstring
..

virt: Minor typo fixes in Vm.getStats docstring

Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Signed-off-by: Milan Zamazal 
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/63550/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index c936987..2526051 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -1180,13 +1180,12 @@
 
 def getStats(self):
 """
-used by API.Vm.getStats
+Used by API.Vm.getStats.
 
-WARNING: this method should only gather statistics by copying data.
-Especially avoid costly and dangerous ditrect calls to the _dom
+WARNING: This method should only gather statistics by copying data.
+Especially avoid costly and dangerous direct calls to the _dom
 attribute. Use the periodic operations instead!
 """
-
 stats = {'statusTime': self._get_status_time()}
 if self.lastStatus == vmstatus.DOWN:
 stats.update(self._getDownVmStats())


-- 
To view, visit https://gerrit.ovirt.org/63550
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e07c9b237cf0af22ec8d0f7618ab655839839f2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to Volume Leases

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Add support for guarded to Volume Leases
..


Patch Set 2: Verified+1

Verified by unit tests.

-- 
To view, visit https://gerrit.ovirt.org/63549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c3dc65975c236545d15b8e8be62403c29c7f9f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Add support for guarded to ResourceManager
..


Patch Set 2: Verified+1

Verified by unit tests

-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 15: Verified+1

Verified by unit tests.

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Pass the real hostid to copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sdm: Pass the real hostid to copy_data
..


Patch Set 6: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/62576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I367576fca126be695d7617477f92110941620a3b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to Volume Leases

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add support for guarded to Volume Leases
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c3dc65975c236545d15b8e8be62403c29c7f9f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 15: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add support for guarded to ResourceManager
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to Volume Leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for guarded to Volume Leases
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c3dc65975c236545d15b8e8be62403c29c7f9f
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Add support for guarded to ResourceManager
..


Patch Set 1:

(2 comments)

Tiny cleanup possible if you like to resubmit.

https://gerrit.ovirt.org/#/c/63548/1/tests/resourceManagerTests.py
File tests/resourceManagerTests.py:

Line 743: self.assertFalse(a < b)
Line 744: self.assertFalse(b < a)
Line 745: 
Line 746: def test_acquire_release(self):
Line 747: fake_rm = FakeResourceManager()
Lets move this line below...
Line 748: 
Line 749: lock = resourceManager.ResourceManagerLock(
Line 750: 'ns_A', 'name_A', resourceManager.LockType.shared)
Line 751: lock._rm = fake_rm


Line 747: fake_rm = FakeResourceManager()
Line 748: 
Line 749: lock = resourceManager.ResourceManagerLock(
Line 750: 'ns_A', 'name_A', resourceManager.LockType.shared)
Line 751: lock._rm = fake_rm
...here:

Lock._rm = fake_rm = FakeResourceManager()
Line 752: expected = []
Line 753: lock.acquire()
Line 754: expected.append(('acquireResource',
Line 755:  (lock.ns, lock.name, lock.mode), {}))


-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 15:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add GuardedLocks checking utility

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add GuardedLocks checking utility
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2b78e6439b75cd60f99f8e756306297cfe51c0
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for guarded to ResourceManager
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Pass the real hostid to copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Pass the real hostid to copy_data
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I367576fca126be695d7617477f92110941620a3b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Introduce FakeSanlock

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tests: Introduce FakeSanlock
..


Patch Set 4: Code-Review+2

Need to check why jenkins is grumpy

-- 
To view, visit https://gerrit.ovirt.org/62265
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5701b85b02059cf6e16795a54fadfe3213e346ca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Pass the real hostid to copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Pass the real hostid to copy_data
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62576
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I367576fca126be695d7617477f92110941620a3b
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for guarded to ResourceManager
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 14:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to Volume Leases

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Add support for guarded to Volume Leases
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63549
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53c3dc65975c236545d15b8e8be62403c29c7f9f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tests: Add GuardedLocks checking utility

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: Add GuardedLocks checking utility
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62467
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a2b78e6439b75cd60f99f8e756306297cfe51c0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: sdm: Use guarded.context in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sdm: Use guarded.context in copy_data
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/61693
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5c2a9527f5e3787069e0847e1bf775a60321b306
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Add support for guarded to Volume Leases

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Add support for guarded to Volume Leases
..

storage: Add support for guarded to Volume Leases

Support the use of volume leases with the guarded utilities by creating
a VolumeLease class that conforms to the guarded.AbstractLock semantics.

Change-Id: I53c3dc65975c236545d15b8e8be62403c29c7f9f
Signed-off-by: Adam Litke 
---
M lib/vdsm/storage/constants.py
M tests/Makefile.am
A tests/storage_volume_test.py
M vdsm/storage/volume.py
4 files changed, 129 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/49/63549/1

diff --git a/lib/vdsm/storage/constants.py b/lib/vdsm/storage/constants.py
index 7705c06..4c00a5b 100644
--- a/lib/vdsm/storage/constants.py
+++ b/lib/vdsm/storage/constants.py
@@ -28,6 +28,7 @@
 IMAGE_NAMESPACE = '01_img'
 VOLUME_NAMESPACE = '02_vol'
 LVM_ACTIVATION_NAMESPACE = '03_lvm'
+VOLUME_LEASE_NAMESPACE = "04_lease"
 
 SECTOR_SIZE = 512
 VG_EXTENT_SIZE_MB = 128
diff --git a/tests/Makefile.am b/tests/Makefile.am
index eb8a25e..ae671c9 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -130,6 +130,7 @@
storage_sdm_api_test.py \
storage_sdm_copy_data_test.py \
storage_sdm_create_volume_test.py \
+   storage_volume_test.py \
storage_volume_artifacts_test.py \
storage_volume_metadata_test.py \
tasksetTests.py \
@@ -232,6 +233,7 @@
storage_sdm_api_test.py \
storage_sdm_create_volume_test.py \
storage_sdm_copy_data_test.py \
+   storage_volume_test.py \
storage_volume_artifacts_test.py \
storage_volume_metadata_test.py \
storagefakelibTests.py \
diff --git a/tests/storage_volume_test.py b/tests/storage_volume_test.py
new file mode 100644
index 000..79cae70
--- /dev/null
+++ b/tests/storage_volume_test.py
@@ -0,0 +1,94 @@
+#
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from __future__ import absolute_import
+
+from monkeypatch import MonkeyPatchScope
+from storagefakelib import FakeStorageDomainCache
+from storagetestlib import FakeSD
+from testlib import expandPermutations, permutations
+from testlib import recorded
+from testlib import VdsmTestCase
+
+from vdsm.storage import constants as sc
+
+from storage import resourceManager as rm
+from storage import sd
+from storage import volume
+
+HOST_ID = 1
+
+
+class FakeSDManifest(object):
+@recorded
+def acquireVolumeLease(self, hostId, imgUUID, volUUID):
+pass
+
+@recorded
+def releaseVolumeLease(self, imgUUID, volUUID):
+pass
+
+
+@expandPermutations
+class VolumeLeaseTest(VdsmTestCase):
+
+def test_properties(self):
+a = volume.VolumeLease(HOST_ID, 'dom', 'img', 'vol')
+self.assertEqual(sd.getNamespace(sc.VOLUME_LEASE_NAMESPACE, 'dom'),
+ a.ns)
+self.assertEqual('vol', a.name)
+self.assertEqual(rm.LockType.exclusive, a.mode)
+
+@permutations((
+(('domA', 'img', 'vol'), ('domB', 'img', 'vol')),
+(('dom', 'img', 'volA'), ('dom', 'img', 'volB')),
+))
+def test_less_than(self, a, b):
+b = volume.VolumeLease(HOST_ID, *b)
+a = volume.VolumeLease(HOST_ID, *a)
+self.assertLess(a, b)
+
+def test_equality(self):
+a = volume.VolumeLease(HOST_ID, 'dom', 'img', 'vol')
+b = volume.VolumeLease(HOST_ID, 'dom', 'img', 'vol')
+self.assertEqual(a, b)
+
+def test_equality_different_image(self):
+a = volume.VolumeLease(HOST_ID, 'dom', 'img1', 'vol')
+b = volume.VolumeLease(HOST_ID, 'dom', 'img2', 'vol')
+self.assertEqual(a, b)
+
+def test_equality_different_host_id(self):
+a = volume.VolumeLease(0, 'dom', 'img', 'vol')
+b = volume.VolumeLease(1, 'dom', 'img', 'vol')
+self.assertEqual(a, b)
+
+def test_acquire_release(self):
+sdcache = FakeStorageDomainCache()
+manifest = FakeSDManifest()
+sdcache.domains['dom'] = FakeSD(manifest)
+expected = [('acquireVolumeLease', (HOST_ID, 'img', 'vol'), {}),
+

Change in vdsm[master]: storage: Add support for guarded to ResourceManager

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Add support for guarded to ResourceManager
..

storage: Add support for guarded to ResourceManager

Support the use of ResourceManager resources with the guarded utilities
by creating a ResourceManagerLock class that conforms to the
guarded.AbstractLock semantics.

Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Signed-off-by: Adam Litke 
---
M tests/resourceManagerTests.py
M vdsm/storage/resourceManager.py
2 files changed, 82 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/63548/1

diff --git a/tests/resourceManagerTests.py b/tests/resourceManagerTests.py
index 0c980d7..bc3002c 100644
--- a/tests/resourceManagerTests.py
+++ b/tests/resourceManagerTests.py
@@ -27,6 +27,8 @@
 from resource import getrlimit, RLIMIT_NPROC
 
 import storage.resourceManager as resourceManager
+from storagefakelib import FakeResourceManager
+from testlib import expandPermutations, permutations
 from testlib import VdsmTestCase as TestCaseBase
 from testValidation import slowtest, stresstest
 
@@ -705,3 +707,53 @@
 except:
 resourceManager.ResourceManager._instance = None
 raise
+
+
+@expandPermutations
+class ResourceManagerLockTest(TestCaseBase):
+
+def test_properties(self):
+a = resourceManager.ResourceManagerLock('ns', 'name', 'mode')
+self.assertEqual('ns', a.ns)
+self.assertEqual('name', a.name)
+self.assertEqual('mode', a.mode)
+
+@permutations((
+(('nsA', 'nameA', 'mode'), ('nsB', 'nameA', 'mode')),
+(('nsA', 'nameA', 'mode'), ('nsA', 'nameB', 'mode')),
+))
+def test_less_than(self, a, b):
+b = resourceManager.ResourceManagerLock(*b)
+a = resourceManager.ResourceManagerLock(*a)
+self.assertLess(a, b)
+
+def test_equality(self):
+a = resourceManager.ResourceManagerLock('ns', 'name', 'mode')
+b = resourceManager.ResourceManagerLock('ns', 'name', 'mode')
+self.assertEqual(a, b)
+
+def test_mode_used_for_equality(self):
+a = resourceManager.ResourceManagerLock('nsA', 'nameA', 'modeA')
+b = resourceManager.ResourceManagerLock('nsA', 'nameA', 'modeB')
+self.assertNotEqual(a, b)
+
+def test_mode_ignored_for_sorting(self):
+a = resourceManager.ResourceManagerLock('nsA', 'nameA', 'modeA')
+b = resourceManager.ResourceManagerLock('nsA', 'nameA', 'modeB')
+self.assertFalse(a < b)
+self.assertFalse(b < a)
+
+def test_acquire_release(self):
+fake_rm = FakeResourceManager()
+
+lock = resourceManager.ResourceManagerLock(
+'ns_A', 'name_A', resourceManager.LockType.shared)
+lock._rm = fake_rm
+expected = []
+lock.acquire()
+expected.append(('acquireResource',
+ (lock.ns, lock.name, lock.mode), {}))
+self.assertEqual(expected, fake_rm.__calls__)
+lock.release()
+expected.append(('releaseResource', (lock.ns, lock.name), {}))
+self.assertEqual(expected, fake_rm.__calls__)
diff --git a/vdsm/storage/resourceManager.py b/vdsm/storage/resourceManager.py
index fe62e83..17ee206 100644
--- a/vdsm/storage/resourceManager.py
+++ b/vdsm/storage/resourceManager.py
@@ -31,6 +31,7 @@
 from vdsm import concurrent
 from vdsm import utils
 from vdsm.storage import exception as se
+from vdsm.storage import guarded
 from vdsm.storage import rwlock
 
 
@@ -1005,3 +1006,32 @@
 
 def __str__(self):
 return str(self.ownerobject)
+
+
+class ResourceManagerLock(guarded.AbstractLock):
+"""
+Extend AbstractLock to enable Resources to be used with guarded utilities.
+"""
+def __init__(self, ns, name, mode):
+self._ns = ns
+self._name = name
+self._mode = mode
+self._rm = ResourceManager.getInstance()
+
+@property
+def ns(self):
+return self._ns
+
+@property
+def name(self):
+return self._name
+
+@property
+def mode(self):
+return self._mode
+
+def acquire(self):
+self._rm.acquireResource(self.ns, self.name, self.mode)
+
+def release(self):
+self._rm.releaseResource(self.ns, self.name)


-- 
To view, visit https://gerrit.ovirt.org/63548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e96d1c0bfcca05fec82ea450b5bcfb992010f52
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce guarded utilities

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Introduce guarded utilities
..


Patch Set 13:

(2 comments)

Splitting the patches and will resend.

https://gerrit.ovirt.org/#/c/61435/13/tests/storage_guarded_test.py
File tests/storage_guarded_test.py:

Line 134: with guarded.context(locks):
Line 135: pass
Line 136: self.assertEqual(expected, log)
Line 137: 
Line 138: def test_release_failure(self):
> We need same test for acquire error, ensuring that we do not leave acquired
See test_acquire_failure
Line 139: log = []
Line 140: locks = [
Line 141: FakeGuardedLock('01_dom', 'dom1', 'mode', log),
Line 142: FakeGuardedLock('02_img', 'img1', 'mode', log),


Line 170: with guarded.context(locks):
Line 171: raise InjectedFailure()
Line 172: self.assertEqual(expected, log)
Line 173: 
Line 174: def test_fail_inside_context_with_release_failure(self):
> Having the same test with acquire error would be also useful.
But you can never get inside the context in the event of an acquire failure.
Line 175: log = []
Line 176: locks = [
Line 177: FakeGuardedLock('01_dom', 'dom1', 'mode', log),
Line 178: FakeGuardedLock('02_img', 'img1', 'mode', log),


-- 
To view, visit https://gerrit.ovirt.org/61435
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b0a204818d44b6205515277f4c2834cb2b7a057
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConverter.py
File vdsm/storage/imageRepository/formatConverter.py:

Line 343: log.debug("Switching the cluster lock for domain %s", 
domain.sdUUID)
Line 344: domain._clusterLock = newClusterLock
Line 345: 
Line 346: def v4DomainConverter(repoPath, hostId, domain, isMsd):
Line 347: log = logging.getLogger('Storage.v4DomainConverter')
This logger will never be released. Please use module level logger. 

In another patch, replace all the loggers in this module with module logger 
named "storage.format".
Line 348: targetVersion = 4
Line 349: 
Line 350: if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES:
Line 351: log.debug("Trying to upgrade domain %s to tag based metadata "


Line 354: __convertDomainMetadataToTags(domain, targetVersion)
Line 355: 
Line 356: else:
Line 357: log.debug("Skipping the upgrade to tag based metadata version 
%s "
Line 358:   "for the domain %s", targetVersion, domain.sdUUID)
Please use the happy path idiom:

if domain.getStorageType() not in sd.BLOCK_DOMAIN_TYPES:
log skipping domain...
return
 
log upgrading...
upgrade...
Line 359: 
Line 360: 
Line 361: _IMAGE_REPOSITORY_CONVERSION_TABLE = {
Line 362: ('0', '2'): v2DomainConverter,


-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net libvirt hook: Adjust hook to vmList report change.
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net libvirt hook: Adjust hook to vmList report change.
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net libvirt hook: Adjust hook to vmList report change.
..


net libvirt hook: Adjust hook to vmList report change.

Patch 78ea853e131da3b91b812315a0656b8f99d7fef4 has changed the output of
vmList, from the key 'items' to 'vmList', breaking the hook.

This patch adjusts the hook with the new key.

Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63542
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski 
Tested-by: Milan Zamazal 
Reviewed-by: Marcin Mirecki 
Tested-by: Marcin Mirecki 
Reviewed-by: Dan Kenigsberg 
---
M tests/network/vm_migrate_hook_test.py
M vdsm/virt/vm_migrate_hook.py
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Marcin Mirecki: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Milan Zamazal: Verified



-- 
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: upgrade: Support upgrade to v4 from v3
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: upgrade: Support upgrade to v4 from v3
..

upgrade: Support upgrade to v4 from v3

Adding support for v4 upgrade.

Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Signed-off-by: Maor Lipchuk 
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/63547/1

diff --git a/vdsm/storage/imageRepository/formatConverter.py 
b/vdsm/storage/imageRepository/formatConverter.py
index a6b12f8..4b52e1c 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -343,11 +343,26 @@
 log.debug("Switching the cluster lock for domain %s", domain.sdUUID)
 domain._clusterLock = newClusterLock
 
+def v4DomainConverter(repoPath, hostId, domain, isMsd):
+log = logging.getLogger('Storage.v4DomainConverter')
+targetVersion = 4
+
+if domain.getStorageType() in sd.BLOCK_DOMAIN_TYPES:
+log.debug("Trying to upgrade domain %s to tag based metadata "
+  "version %s", domain.sdUUID, targetVersion)
+
+__convertDomainMetadataToTags(domain, targetVersion)
+
+else:
+log.debug("Skipping the upgrade to tag based metadata version %s "
+  "for the domain %s", targetVersion, domain.sdUUID)
+
 
 _IMAGE_REPOSITORY_CONVERSION_TABLE = {
 ('0', '2'): v2DomainConverter,
 ('0', '3'): v3DomainConverter,
 ('2', '3'): v3DomainConverter,
+('3', '4'): v4DomainConverter,
 }
 
 


-- 
To view, visit https://gerrit.ovirt.org/63547
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8a66346b91e49480d391116ba8ee8b8294f53ec4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

[mmirecki]

Marcin Mirecki has posted comments on this change.

Change subject: net libvirt hook: Adjust hook to vmList report change.
..


Patch Set 1: Code-Review+1 Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: net libvirt hook: Adjust hook to vmList report change.
..


Patch Set 1: Verified+1

It fixes the problem I experienced with migrations on my setup.

-- 
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net: reconfigure bond if it is not bridged anymore

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: reconfigure bond if it is not bridged anymore
..


Patch Set 5:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63534
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5e7a38f2642b641e21603885d0f6f23af779410a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10:

The patch itself is libvirt version agnostic, it's up to 4.1 engine.

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: net libvirt hook: Adjust hook to vmList report change.
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10:

Should we add a spec dependency on a newer libvirt for this to work?

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10: Code-Review+2

raising score

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net libvirt hook: Adjust hook to vmList report change.

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net libvirt hook: Adjust hook to vmList report change.
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46925a65abc293e317b8df86bd958bf1cf27b6de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org