Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[edwardh]

Edward Haas has posted comments on this change.

Change subject: storage: prepare iscsi for IPv6 targets
..


Patch Set 11:

(3 comments)

https://gerrit.ovirt.org/#/c/65696/11/vdsm/storage/iscsi.py
File vdsm/storage/iscsi.py:

PS11, Line 59: getTargetString
How about 'portal_join'?
On another thought, are you sure this func is needed?
Looks like the func is trying to find a common usage for creating a portal, but 
it is not really common when you need to use so many branches inside.

I think you can drop it and use hosttail_join at the callers.


PS11, Line 60: if tpgt is None:
 : tpgtStr = ""
 : else:
 : tpgtStr = ",%d" % tpgt
Python using the Hungarian notation is a bit too much for me :)

anyway, this may look a bit nicer:
tag = ",%d" % tpgt if tpgt else ""

Same for iqn


PS11, Line 71: str(portal.port)),
This one does not fit the previous line?


-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 12:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 11:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 11:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 10:

* update_tracker: OK
* Set MODIFIED::bug 1382578#1382578::IGNORE, skipping for branch 'master'
* Set MODIFIED::bug 1382578bug 1382583#1382583::IGNORE, skipping for 
branch 'master'

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 9: Code-Review+2

raising scores

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: rename statsAge parameter
..


vm: rename statsAge parameter

rename `statsAge' to `stats_age'.
Now it is pep8 friendlier, and it is easier to follow the code flow:
it is now possible to follow this flow end to end using
'git grep stats_age'.

It used to be called `statsAge' in camelCase only for legacy reasons.

Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Backport-To: 4.0
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1382578
Bug-Url: https://bugzilla.redhat.com/1382583
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/65508
Reviewed-by: Martin Polednik 
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/virt/vm.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 10:

* update_tracker: OK
* Set MODIFIED::bug 1382578#1382578::IGNORE, skipping for branch 'master'
* Set MODIFIED::bug 1382578bug 1382583#1382583::IGNORE, skipping for 
branch 'master'

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


vm: reformat setUnresponsiveIfTimeout

Reformat the order of operations to make clear
on which cases we don't care about timeouts.

Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Backport-To: 4.0
Backport-To: 3.6
Bug-Url: https://bugzilla.redhat.com/1382578
Bug-Url: https://bugzilla.redhat.com/1382583
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/65504
Continuous-Integration: Jenkins CI
Reviewed-by: Martin Polednik 
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/virt/vm.py
1 file changed, 12 insertions(+), 7 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve
  Martin Polednik: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 9: Code-Review+2

raising scores

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 13: Verified+1

copied score

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 10: Verified+1

The purpose of this patch is
1. make sure VM is not misreported (actually: overzelously reported) 
unresponsive when starting up slowly or shutting down sloly
2. reduce misleading "XXX operation cannot run on ABC" messages

ot check this, I verified again that both of the above doesn't happen if a VM 
starts up or shuts down slowly. Overloading one host is racy and tricky, so I 
tried reproducing in a more controlled environment, using just one VM, but 
injecting sleep()s to ensure the right sequence or events - or just slow 
operations.

- startup: slow down domDependentInit right at the beginning. VM is still 
reported as responsive even if sleeps for 100s. No extra messages in the logs
- shutdown: started one VM, stopped Engine, killed QEMU. Did a few tries to 
catch the small race here (a Down VM doesn't report responsiveness), looks ok 
as well.
- non regression: SIGSTOP'd QEMU while Vdsm was running, VM is reported 
unresponsive after a timeout, and responsive again when QEMU is SIGCONT'd.

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: extended hosttail_join

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: extended hosttail_join
..


Patch Set 1:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/65765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2236ec963ad67e26c98a76b70341b0f1b75dceb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: extended hosttail_join

[dholler]

Dominik Holler has abandoned this change.

Change subject: network: extended hosttail_join
..


Abandoned

not needed

-- 
To view, visit https://gerrit.ovirt.org/65765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia2236ec963ad67e26c98a76b70341b0f1b75dceb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmstats: user proper way to detect host devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vmstats: user proper way to detect host devices
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic71db639b980dbdf29284c432f4acda95b402c4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 10:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: devices: properly initialize attributes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: devices: properly initialize attributes
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21ef87a9524cbfe752e6cc0f7d1d9f6139c61dfb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 13:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vmstats: user proper way to detect host devices

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: vmstats: user proper way to detect host devices
..

vmstats: user proper way to detect host devices

Lacking better ways, back in time we detected host devices
checking their name (!). Now we the code is evolved and we
have proper and safer way to do the same task, so this patch
updates the vmstats code accordingly.

Change-Id: Ic71db639b980dbdf29284c432f4acda95b402c4f
Signed-off-by: Francesco Romani 
---
M lib/vdsm/virt/vmstats.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/65771/1

diff --git a/lib/vdsm/virt/vmstats.py b/lib/vdsm/virt/vmstats.py
index 8e271cb..9b65fbd 100644
--- a/lib/vdsm/virt/vmstats.py
+++ b/lib/vdsm/virt/vmstats.py
@@ -330,7 +330,7 @@
 last_indexes = _find_bulk_stats_reverse_map(last_sample, 'net')
 
 for nic in vm.getNicDevices():
-if nic.name.startswith('hostdev'):
+if nic.is_hostdevice:
 continue
 
 # may happen if nic is a new hot-plugged one


-- 
To view, visit https://gerrit.ovirt.org/65771
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic71db639b980dbdf29284c432f4acda95b402c4f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: devices: properly initialize attributes

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: network: devices: properly initialize attributes
..

network: devices: properly initialize attributes

The `name' attribute used to be added to devices only after the
device data was refreshed from libvirt.
This can lead to AttributeErrors if a VM starts (very) slowly.
Furthermore, is good practice to initialize all the device
object attributes in __init__.

Change-Id: I21ef87a9524cbfe752e6cc0f7d1d9f6139c61dfb
Signed-off-by: Francesco Romani 
---
M vdsm/virt/vmdevices/network.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/72/65772/1

diff --git a/vdsm/virt/vmdevices/network.py b/vdsm/virt/vmdevices/network.py
index 7628f06..618c34d 100644
--- a/vdsm/virt/vmdevices/network.py
+++ b/vdsm/virt/vmdevices/network.py
@@ -48,6 +48,7 @@
 kwargs[attr] = net_api.DUMMY_BRIDGE
 super(Interface, self).__init__(conf, log, **kwargs)
 self.sndbufParam = False
+self.name = ""
 self.is_hostdevice = self.device == hwclass.HOSTDEV
 self.vlanId = self.specParams.get('vlanid')
 self._customize()


-- 
To view, visit https://gerrit.ovirt.org/65772
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I21ef87a9524cbfe752e6cc0f7d1d9f6139c61dfb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: iscsiadm parses IPv6 iSCSI addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..


Patch Set 11:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::OK
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: prepare iscsi for IPv6 targets
..


Patch Set 11:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::OK
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: RPC support for IPv6 iSCSI targets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: RPC support for IPv6 iSCSI targets
..


Patch Set 7:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::OK
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65736
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia31b045237dc2defc00181ef8a08cdaf808aa635
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[fromani]

Francesco Romani has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 11: Code-Review+1

partial review

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: net: edit nic detached from bridge but still attached to a vlan

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 2:

* update_tracker: OK
* Set MODIFIED::bug 1372798#1372798IGNORE, not all related patches are 
closed, check 65219

-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: osinfo: memoize runtime_kernel_flags

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: osinfo: memoize runtime_kernel_flags
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 3: Verified+1

Tested on both RT and non-RT kernels. The check itself is not anywhere near 
"robust", but it seems good enough for present, past and future kernels (and I 
have no idea how to make it even better without parsing kconfig).

-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: net: edit nic detached from bridge but still attached to a vlan

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


net: edit nic detached from bridge but still attached to a vlan

Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1372798
Reviewed-on: https://gerrit.ovirt.org/65231
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
(cherry picked from commit 0970a9e90bc229d1fc95210153aacf564353516d)
Reviewed-on: https://gerrit.ovirt.org/65232
Reviewed-on: https://gerrit.ovirt.org/65760
Continuous-Integration: Dan Kenigsberg 
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  Anonymous Coward #1001177: Verified
  Dan Kenigsberg: Looks good to me, approved; Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Add new api to get the IO tune policies for all vms

[akrejcir]

Andrej Krejcir has posted comments on this change.

Change subject: Add new api to get the IO tune policies for all vms
..


Patch Set 11: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63748
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16ead268367901ae85e47fb71104e23705f0e0e1
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Jenny Tokar 
Gerrit-Reviewer: Andrej Krejcir 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenny Tokar 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Phillip Bailey 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Roman Mohr 
Gerrit-Reviewer: Roy Golan 
Gerrit-Reviewer: Yanir Quinn 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: extended hosttail_join

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: extended hosttail_join
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2236ec963ad67e26c98a76b70341b0f1b75dceb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Refuse to cancel post-copy migrations

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Refuse to cancel post-copy migrations
..


Patch Set 10:

> does libvirt guarantee that post-copy migration can't be aborted? It is 
> documented behaviour or just an implementation accident, subject to change? 
> If this is a documented behaviour we should depend on it

I don't think it's a documented behavior but we may ask libvirt developers to 
document it (if is an intended guarantee).

> same for Engine. If Engine wants to do that, we should depend on it.

Engine can't decide just itself due to races and information delay.

-- 
To view, visit https://gerrit.ovirt.org/63554
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I670ab48ed3fe69582646675d8b683bcdb3cfa038
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: iscsiadm parses IPv6 iSCSI addresses

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: iscsiadm parses IPv6 iSCSI addresses
..


Patch Set 10:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::OK
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65707
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9fa8d8f5ac34753ad6d40625e64dfeee1a3c02
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: net: edit nic detached from bridge but still attached to a vlan

[gerrit2]

Anonymous Coward #1001177 has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Anonymous Coward #1001177
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: prepare iscsi for IPv6 targets
..


Patch Set 10:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::OK
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: RPC support for IPv6 iSCSI targets

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: RPC support for IPv6 iSCSI targets
..


Patch Set 6:

* Update Tracker::#1308306::OK, status: NEW
* Check Bug-Url::OK
* Check Public Bug::#1308306::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65736
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia31b045237dc2defc00181ef8a08cdaf808aa635
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: network: extended hosttail_join

[dholler]

Dominik Holler has uploaded a new change for review.

Change subject: network: extended hosttail_join
..

network: extended hosttail_join

hosttail_join adds square brackets only for literal IPv6 address, which
do not have square brackets already.

Change-Id: Ia2236ec963ad67e26c98a76b70341b0f1b75dceb
Signed-off-by: Dominik Holler 
---
M lib/vdsm/common/network/address.py
M tests/common/network_test.py
2 files changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/65765/1

diff --git a/lib/vdsm/common/network/address.py 
b/lib/vdsm/common/network/address.py
index e49463f..4e21d5cba 100644
--- a/lib/vdsm/common/network/address.py
+++ b/lib/vdsm/common/network/address.py
@@ -53,7 +53,8 @@
 
 The tail part may be a port or a path (for mount points).
 """
-if ':' in host:
+# check for literal IPv6 address
+if ':' in host and not host.startswith('['):
 host = '[' + host + ']'
 return host + ':' + tail
 
diff --git a/tests/common/network_test.py b/tests/common/network_test.py
index f586248..4bda38b 100644
--- a/tests/common/network_test.py
+++ b/tests/common/network_test.py
@@ -77,11 +77,13 @@
 # IPv6
 ("2001:db8::60fe:5bf:febc:912", "/path",
  "[2001:db8::60fe:5bf:febc:912]:/path"),
+("[2001:db8::60fe:5bf:febc:912]", "/path",
+ "[2001:db8::60fe:5bf:febc:912]:/path"),
 
 # Invalid host - concatenation still occurs
 ("ser:ver", "/path", "[ser:ver]:/path"),
-("[2001:db8::60fe:5bf:febc:912]", "/path",
- "[[2001:db8::60fe:5bf:febc:912]]:/path"),
+("/2001:db8::60fe:5bf:febc:912/", "/path",
+ "[/2001:db8::60fe:5bf:febc:912/]:/path"),
 ])
 def test_hosttail_join(self, host, tail, expected):
 self.assertEquals(expected, ipaddress.hosttail_join(host, tail))


-- 
To view, visit https://gerrit.ovirt.org/65765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia2236ec963ad67e26c98a76b70341b0f1b75dceb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: osinfo: memoize runtime_kernel_flags

[automation]

gerrit-hooks has posted comments on this change.

Change subject: osinfo: memoize runtime_kernel_flags
..


Patch Set 3:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 3:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65715/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 6497: string
> Why not to use boolean directly here. I see that we make it a string oursel
For some reason (that I think is XML RPC) we've always went with boolean 
(lowercase) encapsulated within string. Is it safe to use raw boolean now? 
Should we?


-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: lib: shorten name of libvirt event thread

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: lib: shorten name of libvirt event thread
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65501
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3dedfc52ad33f3d5f21a8154c248bb130b62ca7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report nested virtualization capabilities

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: caps: report nested virtualization capabilities
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/65717/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS3, Line 6505: string
Like in previous patch. Why not to use boolean?


-- 
To view, visit https://gerrit.ovirt.org/65717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: migration: use system thread names

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: migration: use system thread names
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/65503/3/vdsm/virt/migration.py
File vdsm/virt/migration.py:

PS3, Line 126: 7
8? 7 for the prefix + 8 for the id = 15 total.
The same for the other threads.


PS3, Line 558: migdt
Minor: `migdt' is a bit cryptic (I confused it with "destination"), how about 
`migdwn' or something else?


-- 
To view, visit https://gerrit.ovirt.org/65503
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie03f19f75cb9430cd3a267817df269df776fa6a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/65715/2/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS2, Line 6497: string
Why not to use boolean directly here. I see that we make it a string ourselves. 
Is there any reason?


-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: clientIF: rename recovery thread

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: clientIF: rename recovery thread
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I489012786f3ebd76ef7adc4607645d095cbbc1a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: net: edit nic detached from bridge but still attached to a vlan

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 1: Continuous-Integration+1

copying CI score

-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 9: Code-Review+1

(3 comments)

I suggest polishing the comment, otherwise it looks fine.

https://gerrit.ovirt.org/#/c/65590/9/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS9, Line 1275: p
Prevent


PS9, Line 1276: as monitorable the VM
the VM as monitorable


PS9, Line 1278: vm
VM


-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 12:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 9:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: net: edit nic detached from bridge but still attached to a vlan

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: net: edit nic detached from bridge but still attached to a vlan

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..


Patch Set 1:

* Update Tracker::#1372798::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1372798::OK, public bug
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0.5]: net: edit nic detached from bridge but still attached to a vlan

[phoracek]

Hello Dan Kenigsberg,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/65760

to review the following change.

Change subject: net: edit nic detached from bridge but still attached to a vlan
..

net: edit nic detached from bridge but still attached to a vlan

Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Signed-off-by: Petr Horáček 
Bug-Url: https://bugzilla.redhat.com/1372798
Reviewed-on: https://gerrit.ovirt.org/65231
Reviewed-by: Dan Kenigsberg 
Continuous-Integration: Jenkins CI
(cherry picked from commit 0970a9e90bc229d1fc95210153aacf564353516d)
Reviewed-on: https://gerrit.ovirt.org/65232
---
M lib/vdsm/network/configurators/ifcfg.py
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/65760/1

diff --git a/lib/vdsm/network/configurators/ifcfg.py 
b/lib/vdsm/network/configurators/ifcfg.py
index f49693a..f04a7f3 100644
--- a/lib/vdsm/network/configurators/ifcfg.py
+++ b/lib/vdsm/network/configurators/ifcfg.py
@@ -281,6 +281,11 @@
 if set_mtu is not None:
 ipwrapper.linkSet(nic.name, ['mtu', str(set_mtu)])
 
+# If the nic was bridged, we must remove BRIDGE parameter from its
+# ifcfg configuration file.
+if nic.bridge:
+self.configApplier.dropBridgeParameter(nic.name)
+
 def _getFilePath(self, fileType, device):
 return os.path.join(NET_CONF_DIR, '%s-%s' % (fileType, device))
 


-- 
To view, visit https://gerrit.ovirt.org/65760
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0.5
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/65590/8/tests/periodicTests.py
File tests/periodicTests.py:

PS8, Line 384: self.ready = True
> Missed this one before, I think you could just return True in isDomainReady
Better to simplify. Minor, but should be addressed, and it will.


-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report nested virtualization capabilities

[fromani]

Francesco Romani has posted comments on this change.

Change subject: caps: report nested virtualization capabilities
..


Patch Set 3: Code-Review+1

looks good to me. Please get ACK(s) from infra devs about the schema change.

-- 
To view, visit https://gerrit.ovirt.org/65717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[fromani]

Francesco Romani has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 2: Code-Review+1

(1 comment)

Looks good to me. Let's have someone from infra approving the schema change.

https://gerrit.ovirt.org/#/c/65715/2/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:

PS2, Line 261: dict
I'm fine with this, I don't think using literal syntax has any significant 
benefit.


-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[fromani]

Francesco Romani has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/65715/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS1, Line 6495:  with RT_PREEMPT enabled
> This is not really about computation of the field, but slightly-more-than-r
Fair enough, since it is description we can cheaply adjust later on.


-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: prepare iscsi for IPv6 targets

[dholler]

Dominik Holler has posted comments on this change.

Change subject: storage: prepare iscsi for IPv6 targets
..


Patch Set 9: -Verified

-- 
To view, visit https://gerrit.ovirt.org/65696
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1e1e1ffe1c5d09b7bc3767d84a99711986eaef97
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dominik Holler 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Dominik Holler 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 8: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/65590/8/tests/periodicTests.py
File tests/periodicTests.py:

PS8, Line 384: self.ready = True
Missed this one before, I think you could just return True in 
isDomainReadyForCommands unless there is any fancier hidden state change 
somewhere. Minor.


-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: osinfo: memoize runtime_kernel_flags

[automation]

gerrit-hooks has posted comments on this change.

Change subject: osinfo: memoize runtime_kernel_flags
..


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65716
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c015f0086ca66231f9f4dbe0c1f16d3fd197f31
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 2:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report nested virtualization capabilities

[automation]

gerrit-hooks has posted comments on this change.

Change subject: caps: report nested virtualization capabilities
..


Patch Set 3:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65717
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1715413ae815c67ecc67bf7789487dbc11278919
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: caps: report realtime kernel status

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: caps: report realtime kernel status
..


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/65715/1/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:

PS1, Line 6495:  with RT_PREEMPT enabled
> I wonder if you need to document those details here.
This is not really about computation of the field, but 
slightly-more-than-required explanation what the value is. The reason for the 
amount of care is to avoid any API consumer to consider the value as final 
statement on RT operation status -- it's only a little piece of the puzzle.

Why mentioning the kernel config option of just saying "realtime kernel blah 
blah"? Mostly due to RT wiki, where RT_PREEMPT google query will most likely 
return https://rt.wiki.kernel.org/index.php/RT_PREEMPT_HOWTO which is one of 
the best sources of information regarding RT up to date.


PS1, Line 6497: type
> I think you may want to use:
"True!"


https://gerrit.ovirt.org/#/c/65715/1/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:

PS1, Line 261: dict
> why dict() and not literal syntax? Just curious, I don't think this has any
I'm afraid the only reason is that it was this way since I remember the code. 
If you feel that it's improvement I can change the syntax in the patch.


-- 
To view, visit https://gerrit.ovirt.org/65715
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I016ae8a66963a973a1a2f78a9c2706af84f804d1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 11:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 8:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[fromani]

Francesco Romani has abandoned this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Abandoned

squashed into 65590

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 4:

* update_tracker: OK

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 4: Code-Review-1

After the changes made to address the race pointed out by Milan, this patche 
makes little sense on its own; will squash into 65590

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 4:

(1 comment)

Please consider the comment just as an unfortunate remark. :) Postponing rating 
for the race.

https://gerrit.ovirt.org/#/c/65727/4/tests/vmTests.py
File tests/vmTests.py:

PS4, Line 1425: # accessing private field
Sure! But I believe that saying this is equivalent to having '_' in front of 
attribute's name and the only reason for this comment is to avoid code review 
comments stating "accessing private field".

We shouldn't need those comments (that's unfortunately not saying we don't need 
them).


-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: improve periodicTests.py

[fromani]

Francesco Romani has posted comments on this change.

Change subject: tests: improve periodicTests.py
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/65753/1/tests/periodicTests.py
File tests/periodicTests.py:

PS1, Line 263: for vm_id in skip_ids:
 : self.assertNotIn(_fake_vm_id(vm_id), _Visitor.VMS)
this needs to be in 65590


-- 
To view, visit https://gerrit.ovirt.org/65753
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75b890daed01d23cfa0a36db66615a48023b96c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/65590/7/tests/periodicTests.py
File tests/periodicTests.py:

PS7, Line 269: self.assertEqual(_Visitor.VMS.get(vm_id), None)
> You're asking for apples and getting oranges: skip_ids are NOT the vm ids. 
Indeed I am. Fixing.


-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/65727/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4683: 
Line 4684: def _setUnresponsiveIfTimeout(self, stats, stats_age):
Line 4685: if self.isMigrating():
Line 4686: return
Line 4687: if not self._monitorable:
> Don't we have still a minor race here (I'm not sure, just asking)? May it h
I think such race exists, and since preventing it looks feasible, let's try to 
do so.
Line 4688: return
Line 4689: # we don't care about decimals here
Line 4690: if stats_age < config.getint('vars', 'vm_command_timeout'):
Line 4691: return


-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/65590/7/tests/periodicTests.py
File tests/periodicTests.py:

PS7, Line 269: self.assertEqual(_Visitor.VMS.get(vm_id), None)
You're asking for apples and getting oranges: skip_ids are NOT the vm ids. 

self.assertEqual(_Visitor.VMS.get(_fake_vm_id(vm_id)), None)

To compare same (semantic) objects.


-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 7: Verified+1

changes since last verification: fixed tests (now they are simpler, and works 
OK)

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: improve periodicTests.py

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: improve periodicTests.py
..


Patch Set 1:

* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, no bug url/s found
* Check Public Bug::WARN, no public bug url found
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65753
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I75b890daed01d23cfa0a36db66615a48023b96c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 9: Verified+1

rebased + commit message updated = lost score

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 9: Verified+1

fixed comment, if jenkins is happy so we are

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 9:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 9:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 10:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: introduce a `monitorable' attribute

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: introduce a `monitorable' attribute
..


Patch Set 7:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65590
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb12277a5f0fdaf680032af12fa7c104c3bd6ffb
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: improve periodicTests.py

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: tests: improve periodicTests.py
..

tests: improve periodicTests.py

document a bit better the code and make it easier to understand
the test failures.

Change-Id: I75b890daed01d23cfa0a36db66615a48023b96c0
Signed-off-by: Francesco Romani 
---
M tests/periodicTests.py
1 file changed, 18 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/53/65753/1

diff --git a/tests/periodicTests.py b/tests/periodicTests.py
index 4cc2b21..4df36d6 100644
--- a/tests/periodicTests.py
+++ b/tests/periodicTests.py
@@ -219,6 +219,9 @@
 
 @permutations(VM_IDS)
 def test_dispatch(self, failed_ids):
+"""
+check that we dispatch even if for any reason required() raises.
+"""
 for i in failed_ids:
 with self.cif.vmContainerLock:
 vm_id = _fake_vm_id(i)
@@ -257,16 +260,17 @@
 # we don't care about executor (hence the simplistic fake)
 op()
 
+for vm_id in skip_ids:
+self.assertNotIn(_fake_vm_id(vm_id), _Visitor.VMS)
+
 vms = self.cif.getVMs()
+
 expected = (
 set(vms.keys()) -
 set(_fake_vm_id(i) for i in skip_ids)
 )
 for vm_id in expected:
 self.assertEqual(_Visitor.VMS.get(vm_id), 1)
-
-for vm_id in skip_ids:
-self.assertEqual(_Visitor.VMS.get(vm_id), None)
 
 def _make_fake_vms(self):
 for i in range(VM_NUM):
@@ -391,3 +395,14 @@
 
 def updateNumaInfo(self):
 pass
+
+def __repr__(self):
+return (
+

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 4:

* Update Tracker::#1382578::IGNORE, not relevant for Red Hat classification
* Update Tracker::#1382583::IGNORE, not relevant for Red Hat classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Bug-Url::IGNORE, not relevant for 'Red Hat' classification
* Check Public Bug::#1382578::OK, public bug
* Check Public Bug::#1382583::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/65727/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4683: 
Line 4684: def _setUnresponsiveIfTimeout(self, stats, stats_age):
Line 4685: if self.isMigrating():
Line 4686: return
Line 4687: if not self._monitorable:
Don't we have still a minor race here (I'm not sure, just asking)? May it 
happen that stats_age "0" is retrieved just before stats cache is initialized 
with the given VM (in an independent creation thread?) and we reach this line 
after _monitorable is set? If yes, do we care?
Line 4688: return
Line 4689: # we don't care about decimals here
Line 4690: if stats_age < config.getint('vars', 'vm_command_timeout'):
Line 4691: return


-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: infra tests: added functional test for upgrading vdsm

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: infra tests: added functional test for upgrading vdsm
..


Patch Set 15: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/61186
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I589a73fa5285983f7d1adcdae49fc7bffb05bec4
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: add discard support for vm disks

[ishaby]

Idan Shaby has posted comments on this change.

Change subject: storage: add discard support for vm disks
..


Patch Set 1:

I am not sure that it is a good idea. If we wouldn't have the problem with WAD 
vs passDiscard, maybe we could do it, but that's not the case.

There's an entire logic in the engine's side regarding passing passDiscard for 
each disk (it's not yet on gerrit). In a nutshell, even if the disk is 
configured to pass discard in the engine, that doesn't mean that the engine 
will allow this and pass vdsm passDiscard='true'.
It depends on WAD and the underlying storage support for discard and 'discard 
zeroes the data' (that may have been changed).

Thus, making vdsm to run each vm disk with discard='unmap' by default is not 
possible.
Please see "Wipe After Delete and Pass Discard" in the feature page for more 
info.

-- 
To view, visit https://gerrit.ovirt.org/65751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I215c12260f819538e40056ec16d0b9378287ccee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpc: introduce new client

[ybronhei]

Yaniv Bronhaim has posted comments on this change.

Change subject: jsonrpc: introduce new client
..


Patch Set 10:

(3 comments)

https://gerrit.ovirt.org/#/c/64502/10/lib/vdsm/client.py
File lib/vdsm/client.py:

Line 108: ServerError will be raised if the command encountered execution error:
Line 109: 
Line 110: vdsm.client.ServerError: Vdsm request failed
Line 111: (code=4, message=Virtual machine already exists)
Line 112: 
you repeat the errors description twice (here and in the call method). I guess 
that the next update won't update both locations so better to have only one 
description
Line 113: 
Line 114: Please note that if the client isn't a context manager, it should be
Line 115: closed at the end of the run:
Line 116: 


Line 192: '''
Line 193: if args is None:
Line 194: args = {}
Line 195: if timeout is None:
Line 196: timeout = self.default_timeout
why not just have it as default values? like "def call(self, method, args={}, 
timeout=self.default_timeout): "

I didn't understand nir's comment about it. why a modification will effect next 
calls?
Line 197: req = yajsonrpc.JsonRpcRequest(method, args, 
reqId=str(uuid.uuid4()))
Line 198: try:
Line 199: responses = self._client.call(req, timeout=timeout)
Line 200: except EnvironmentError as e:


Line 224: try:
Line 225: self.close()
Line 226: except Exception:
Line 227: if t is None:
Line 228: raise
why is this type check ?


-- 
To view, visit https://gerrit.ovirt.org/64502
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idd45d7e88bf2246beaf30550b12201917f32c354
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: check stats timeout only for monitorable VMs

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: check stats timeout only for monitorable VMs
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/65727/3//COMMIT_MSG
Commit Message:

PS3, Line 21:  <= 3.6.
wrong: either one of the following

  * < 3.6
  * <= 3.5


-- 
To view, visit https://gerrit.ovirt.org/65727
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia60b98b5758adf9dddea8430db2378411372a600
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/65508/8//COMMIT_MSG
Commit Message:

PS8, Line 10: and it is easier to follow the code flow
> Slightly questionable statement. :)
well, at least you can now 'git grep' your way through the flow, end-to-end :)


-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[fromani]

Francesco Romani has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/65504/8/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS8, Line 4687: become
> When we are on it: "became"?
yes, will fix


-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: rename statsAge parameter

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: rename statsAge parameter
..


Patch Set 8: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/65508/8//COMMIT_MSG
Commit Message:

PS8, Line 10: and it is easier to follow the code flow
Slightly questionable statement. :)


-- 
To view, visit https://gerrit.ovirt.org/65508
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0b4601d0f789921c1c575f9ad19852d4ebecacc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: reformat setUnresponsiveIfTimeout

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: vm: reformat setUnresponsiveIfTimeout
..


Patch Set 8: Code-Review+1

I don't think there is really a need for this, but it doesn't hurt either. 
Agree with Milan's comment, not critical though.

-- 
To view, visit https://gerrit.ovirt.org/65504
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I53e9c284962f7ebe3987e460e4d138f2a08704dc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: ignore more errors in isDomainReadyForCommands
..


Patch Set 9: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/65131
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I89ff61e0cd3bbb977833897c250ea337c86b9f80
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: add discard support for vm disks

[ykaul]

Yaniv Kaul has posted comments on this change.

Change subject: storage: add discard support for vm disks
..


Patch Set 1:

I'm not entirely sure why not just add it by default and be done with it.
Perhaps a VDSM option to turn it off if we find issues with it.

-- 
To view, visit https://gerrit.ovirt.org/65751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I215c12260f819538e40056ec16d0b9378287ccee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Tal Nisan 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: add discard support for vm disks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: add discard support for vm disks
..


Patch Set 1:

* Update Tracker::#1241106::OK, status: NEW
* Check Bug-Url::OK
* Check Public Bug::#1241106::OK, public bug
* Check Product::IGNORE, not relevant for branch: master
* Check TM::IGNORE, not relevant for branch: master
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/65751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I215c12260f819538e40056ec16d0b9378287ccee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: add discard support for vm disks

[ishaby]

Idan Shaby has uploaded a new change for review.

Change subject: storage: add discard support for vm disks
..

storage: add discard support for vm disks

When the engine sends the field 'passDiscard' with the value 'true' as
one of the parameters of the vm's disk's drive, vdsm adds
discard='unmap' to the disk's drive.
With that, vdsm gives the vm disk the ability to support discard.

Note that vdsm can handle scenarios of sending passDiscard with the
values 'true' or 'false', alongside not sending it at all, which makes
it possible to work with old engines that don't support the feature.

For more information about the "Pass Discard" feature, please refer to
the feature page:
http://www.ovirt.org/develop/release-management/features/storage/pass-discard-from-guest-to-underlying-storage/

Change-Id: I215c12260f819538e40056ec16d0b9378287ccee
Bug-Url: https://bugzilla.redhat.com/1241106
Signed-off-by: Idan Shaby 
---
M tests/vmStorageTests.py
M vdsm/virt/vmdevices/storage.py
2 files changed, 23 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/51/65751/1

diff --git a/tests/vmStorageTests.py b/tests/vmStorageTests.py
index aa289d3..3c91544 100644
--- a/tests/vmStorageTests.py
+++ b/tests/vmStorageTests.py
@@ -98,6 +98,22 @@
 """
 self.check({}, conf, xml, is_block_device=True)
 
+def test_disk_with_pass_discard(self):
+conf = drive_config(
+serial='54-a672-23e5b495a9ea',
+passDiscard='true',
+)
+xml = """
+
+
+
+54-a672-23e5b495a9ea
+
+
+"""
+self.check({}, conf, xml, is_block_device=True)
+
 def test_disk_file(self):
 conf = drive_config(
 serial='54-a672-23e5b495a9ea',
@@ -672,6 +688,7 @@
 'readonly': 'False',
 'shared': 'none',
 'type': 'disk',
+'passDiscard': 'false',
 }
 conf.update(kw)
 return conf
@@ -685,4 +702,5 @@
 "format": format,
 "path": "/path/to/replica",
 "propagateErrors": "off",
+'passDiscard': 'false',
 }
diff --git a/vdsm/virt/vmdevices/storage.py b/vdsm/virt/vmdevices/storage.py
index 78bf00c..dcf16c0 100644
--- a/vdsm/virt/vmdevices/storage.py
+++ b/vdsm/virt/vmdevices/storage.py
@@ -62,7 +62,8 @@
  'index', 'name', 'optional', 'shared', 'truesize',
  'volumeChain', 'baseVolumeID', 'serial', 'reqsize', 'cache',
  '_blockDev', 'extSharedState', 'drv', 'sgio', 'GUID',
- 'diskReplicate', '_diskType', 'hosts', 'protocol', 'auth')
+ 'diskReplicate', '_diskType', 'hosts', 'protocol', 'auth',
+ 'passDiscard')
 VOLWM_CHUNK_SIZE = (config.getint('irs', 'volume_utilization_chunk_mb') *
 constants.MEGAB)
 VOLWM_FREE_PCT = 100 - config.getint('irs', 'volume_utilization_percent')
@@ -551,6 +552,9 @@
 elif drive['format']:
 driverAttrs['type'] = 'raw'
 
+if 'passDiscard' in drive and drive['passDiscard'] == 'true':
+driverAttrs['discard'] = 'unmap'
+
 try:
 driverAttrs['iothread'] = str(drive['specParams']['pinToIoThread'])
 except KeyError:


-- 
To view, visit https://gerrit.ovirt.org/65751
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I215c12260f819538e40056ec16d0b9378287ccee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org