Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 16: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12784/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11838/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/444/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/427/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12627/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 16: Verified+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 16: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 16: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has submitted this change and it was merged. Change subject: Signs vdsm upgraded version for special treatment if required .. Signs vdsm upgraded version for special treatment if required In ovirt-3.2 (vdsm 4.10.x) we didn't perform vdsm-tool configure call during uninstall. This cause failure on first vdsm run if configure is required. This patch signs during pre installation the upgraded package version by creating a file with the version string. During init script we read this file and determine the required operation. This patch only adds the treatment for 4.10.x which will perform vdsm-configure call. After handling the upgrade we will remove the file to avoid running the same operation on next reset. Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=935 Signed-off-by: Yaniv Bronhaim ybron...@redhat.com Reviewed-on: http://gerrit.ovirt.org/31561 Reviewed-by: mooli tayer mta...@redhat.com Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M init/vdsmd_init_common.sh.in M vdsm.spec.in 2 files changed, 21 insertions(+), 0 deletions(-) Approvals: Yaniv Bronhaim: Verified mooli tayer: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 17: Build Successful http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4055/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/41/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/68/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms_merged_test_debug/263/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/5895/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/65/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/61/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: looks smoothly :) -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Verified+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/15/vdsm.spec.in
File vdsm.spec.in:
Line 750: /usr/sbin/usermod -a -G %{cdrom_group} %{qemu_user}
Line 751:
Line 752: # We keep the previous rpm version number in a file for managing
upgrade flow
Line 753: # in vdsmd_init_script upgraded_version_check task
Line 754: if [ $1 -ge 1 ]; then
Jenkins failure:
/var/lib/vdsm/upgraded_version: No such file or directory
I suppose you need:
mkdir -p %{_localstatedir}/lib/%{vdsm_name}
?
[1]
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/425/console
16:03:04 Error in PREIN scriptlet in rpm package
vdsm-4.16.0-357.gitf27c81d.el6.x86_64
16:03:04 /var/tmp/rpm-tmp.swfkun: line 13: /var/lib/vdsm/upgraded_version: No
such file or directory
16:03:04 error: %pre(vdsm-4.16.0-357.gitf27c81d.el6.x86_64) scriptlet failed,
exit status 1
16:03:04 error: install: %pre scriptlet failed (2), skipping
vdsm-4.16.0-357.gitf27c81d.el6
Line 755: rpm -q %{vdsm_name}
%{_localstatedir}/lib/%{vdsm_name}/upgraded_version
Line 756: fi
Line 757:
Line 758: %post
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: -Code-Review -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Build Failed http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/408/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/425/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11742/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12686/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12531/ : SUCCESS -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review+2 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 15: Code-Review+1 First start might fail[1]. since this is simple and on specific upgrade scenario, consider declaring this a known issue? [1] (since ultimately systemd starts libvirt vdsm and long libvirt restart, done by tool, might cause systemd to timeout on starting vdsm) -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/12/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 204: local ret=0
Line 205: if grep -q '^vdsm-4\.10\.' ${upgraded_ver_file}; then
Line 206: # We need to treat the upgrade from 4.10.x specifically
Line 207: # by running manual configure command
Line 208: $VDSM_TOOL configure --force
My concern is this:
Actually you right .. maybe it does belong to the installation phase more than
to the startup scripts
it depends on the init service which could be configured with timeout by
default. in systemd it looks fine, but i prefer not to risk with that. what do
you think guys, moving this upgrade check to the %pre section in spec?
Line 209: ret=$?
Line 210: fi
Line 211: [ ${ret} -eq 0 ] rm -f ${upgraded_ver_file}
Line 212: fi
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 12: Jenkins failure: /var/tmp/rpm-tmp.nOd6Yu: line 13: /var/lib/vdsm/upgraded_version: No such file or directory 00:33:29 error: %pre(vdsm-4.16.0-246.git7390f0c.fc20.x86_64) scriptlet failed, exit status 1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 12:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/12/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 204: local ret=0
Line 205: if grep -q '^vdsm-4\.10\.' ${upgraded_ver_file}; then
Line 206: # We need to treat the upgrade from 4.10.x specifically
Line 207: # by running manual configure command
Line 208: $VDSM_TOOL configure --force
mooli: doing that will lead to libvirt service restart. but doing that in s
My concern is this:
vdsm-tool at init might cause:
$ service vdsmd start
long wait...
failed
[service actually starts normally]
did you see this or is it just the long wait?
If it's just the long wait I will not harass you anymore.
also take heed I see some jenkins failures.
Line 209: ret=$?
Line 210: fi
Line 211: [ ${ret} -eq 0 ] rm -f ${upgraded_ver_file}
Line 212: fi
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/7/vdsm.spec.in
File vdsm.spec.in:
Line 720: # When starting vdsm, init script will peform reconfigure
automatically
Line 721: if [ $1 -ge 1 ]; then
Line 722: if [ $(rpm -q vdsm 2 /dev/null | sed 's/^vdsm-4\.10\..*/OK/')
= OK ];
Line 723: then
Line 724: touch %{_localstatedir}/lib/%{vdsm_name}/requires_configure
quotes please
We can avoid quotes here since we assume lack of spaces in %{_localstatedir}
and %{vdsm_name} throughout the spec file.
Line 725: fi
Line 726: fi
Line 727:
Line 728: %post
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 11:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/11/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 201: task_upgraded_version_check(){
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: if cat ${upgraded_ver_file} | grep -q '^vdsm-4\.10\.'; then
cat is superfluous, grep accepts a filename as arg.
Line 206: # We need to treat the upgrade from 4.10.x specifically
Line 207: # by running manual configure command
Line 208: $VDSM_TOOL configure --force
Line 209: ret=$?
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/7/vdsm.spec.in
File vdsm.spec.in:
Line 720: # When starting vdsm, init script will peform reconfigure
automatically
Line 721: if [ $1 -ge 1 ]; then
Line 722: if [ $(rpm -q vdsm 2 /dev/null | sed 's/^vdsm-4\.10\..*/OK/')
= OK ];
Line 723: then
Line 724: touch %{_localstatedir}/lib/%{vdsm_name}/requires_configure
We can avoid quotes here since we assume lack of spaces in %{_localstatedir
not sure why assuming anything and have exceptional statements for multiple
cases, but...
Line 725: fi
Line 726: fi
Line 727:
Line 728: %post
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Dan Kenigsberg has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/7/vdsm.spec.in
File vdsm.spec.in:
Line 720: # When starting vdsm, init script will peform reconfigure
automatically
Line 721: if [ $1 -ge 1 ]; then
Line 722: if [ $(rpm -q vdsm 2 /dev/null | sed 's/^vdsm-4\.10\..*/OK/')
= OK ];
Line 723: then
Line 724: touch %{_localstatedir}/lib/%{vdsm_name}/requires_configure
not sure why assuming anything and have exceptional statements for multiple
Alon, I don't understand your ellipsis.
Quoting all macros is the noble thing to do. But it has to happen throught the
spec file, and clutter it badly.
Line 725: fi
Line 726: fi
Line 727:
Line 728: %post
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 12:
(1 comment)
please ack if acceptable and I'll verify again
http://gerrit.ovirt.org/#/c/31561/12/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 204: local ret=0
Line 205: if grep -q '^vdsm-4\.10\.' ${upgraded_ver_file}; then
Line 206: # We need to treat the upgrade from 4.10.x specifically
Line 207: # by running manual configure command
Line 208: $VDSM_TOOL configure --force
mooli: doing that will lead to libvirt service restart. but doing that in spec
will do it during the installation, which make it much less user friendly. as
the user can't expect libvirt service restart while upgrading vdsm. although
you right about the unexpected behavior and we do print to stdout that we
configure the service, so the user can understand from where the long start
duration comes from..
Line 209: ret=$?
Line 210: fi
Line 211: [ ${ret} -eq 0 ] rm -f ${upgraded_ver_file}
Line 212: fi
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 12: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11251/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/294/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12193/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/328/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12040/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/309/ : FAILURE -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/10/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: local ver=$(cat ${upgraded_ver_file})
Line 206: if echo ${ver} | grep -q '^vdsm-4\.10\.'; then
@Alon, if we will need hooks for different versions:
again... leaking version and upgrade information from spec to code and/or logic
based on version is something that should be avoided.
the communication between the components should be based on logical actions...
do this, do that.
if you think you need to do more than one action then consider the following
convention for queue:
echo @ACTION@ /var/lib/vdsm/vdsmd-pre-start-action.@DATE@
then:
for action in /var/lib/vdsm/vdsmd-pre-start-action.*; do
case $(cat action) in
configure) bla ;;
esac
rm -f ${action}
done
but notice that the daemon is a slave of a queue, the logic of what to put in
queue is up to the foreign logic, in our case the spec.
if we go one step farther... we can have the above as executable script... and
reduce logic even more.
at spec:
cat /var/lib/vdsm/vdsmd-pre-start-action.@DATE@ __EOF__
#!/bin/sh
exec vdsm-tool configure --force
__EOF__
and then at vdsmd:
for action in /var/lib/vdsm/vdsmd-pre-start-action.*; do
${action} rm -f ${action}
done
Line 207: # We need to treat the upgrade from 4.10.x specifically
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 210: ret=$?
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
mooli tayer has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/10/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: local ver=$(cat ${upgraded_ver_file})
Line 206: if echo ${ver} | grep -q '^vdsm-4\.10\.'; then
again... leaking version and upgrade information from spec to code and/or l
the second option looks nice and simple.
Maybe 2 separate commits:
1.) add mechanism (vdsmd_init_common.sh only)
2.) stuff for vdsm 4.10.x with current commit message(spec only)
Line 207: # We need to treat the upgrade from 4.10.x specifically
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 210: ret=$?
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/10/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: local ver=$(cat ${upgraded_ver_file})
Line 206: if echo ${ver} | grep -q '^vdsm-4\.10\.'; then
two commits are fine as well.
we won't make it that way to 3.5. please ack if acceptable. when I'll need to
add new case I'll get back to it. but the flow is valid and works
Line 207: # We need to treat the upgrade from 4.10.x specifically
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 210: ret=$?
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 11: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11222/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/288/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12164/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/322/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12011/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/303/ : FAILURE -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 9:
(3 comments)
http://gerrit.ovirt.org/#/c/31561/9/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 201: task_upgraded_version_check(){
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: local ver=`cat ${upgraded_ver_file}`
$(cat ...)
Line 206: if echo ${ver} | grep -q '^vdsm-4\.10\.'; then
Line 207: # We need to treat the upgrade from 4.10.x specifically
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 210:ret=$?
Line 211: fi
Line 212: [ ${ret} -eq 0 ] rm ${upgraded_ver_file}
rm -f
Line 213: fi
Line 214: }
Line 215: pre-start tasks end
Line 216:
http://gerrit.ovirt.org/#/c/31561/9/vdsm.spec.in
File vdsm.spec.in:
Line 718:
Line 719: # We keep the previous rpm version number in a file for managing
upgrade flow
Line 720: # in vdsmd_init_script upgraded_version_check task
Line 721: if [ $1 -ge 1 ]; then
Line 722: rpm -q %{vdsm_name}
%{_localstatedir}/lib/%{vdsm_name}/upgraded_version
I do not like rpm information leaks out of spec file.
I also do not like the above as upgrade sequence of a-b-c will override the
logic.
Line 723: fi
Line 724:
Line 725: %post
Line 726: %{_bindir}/vdsm-tool configure --module sanlock --force /dev/null
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/9/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: local ver=`cat ${upgraded_ver_file}`
Line 206: if echo ${ver} | grep -q '^vdsm-4\.10\.'; then
if cat ${upgraded_ver_file} | grep -q '^vdsm-4\.10\.'
Line 207: # We need to treat the upgrade from 4.10.x specifically
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 210:ret=$?
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/9/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: local ver=`cat ${upgraded_ver_file}`
Line 206: if echo ${ver} | grep -q '^vdsm-4\.10\.'; then
if cat ${upgraded_ver_file} | grep -q '^vdsm-4\.10\.'
but maybe I'll use this ver variable later on if I'll need to have another hack
around the upgrade
Line 207: # We need to treat the upgrade from 4.10.x specifically
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 210:ret=$?
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/9/vdsm.spec.in
File vdsm.spec.in:
Line 718:
Line 719: # We keep the previous rpm version number in a file for managing
upgrade flow
Line 720: # in vdsmd_init_script upgraded_version_check task
Line 721: if [ $1 -ge 1 ]; then
Line 722: rpm -q %{vdsm_name}
%{_localstatedir}/lib/%{vdsm_name}/upgraded_version
I do not like rpm information leaks out of spec file.
this is the way I found to know previous version.. any better ideas?
upgrading a-b and b-c will be fine in that case. lets say 3.2 to another 3.2
won't make any change. 3.2 to any =3.3 will run the configure during first
startup. i don't see any problem with that
Line 723: fi
Line 724:
Line 725: %post
Line 726: %{_bindir}/vdsm-tool configure --module sanlock --force /dev/null
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 10: Verified+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Alon Bar-Lev has posted comments on this change.
Change subject: Signs vdsm upgraded version for special treatment if required
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/31561/10/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Line 202: local upgraded_ver_file=@VDSMLIBDIR@/upgraded_version
Line 203: if [ -f ${upgraded_ver_file} ]; then
Line 204: local ret=0
Line 205: local ver=$(cat ${upgraded_ver_file})
Line 206: if echo ${ver} | grep -q '^vdsm-4\.10\.'; then
again...
if cat ${upgraded_ver_file} | grep -q '^vdsm-4\.10\.'; then
Line 207: # We need to treat the upgrade from 4.10.x specifically
Line 208: # by running manual configure command
Line 209: $VDSM_TOOL configure --force
Line 210: ret=$?
--
To view, visit http://gerrit.ovirt.org/31561
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: mooli tayer mta...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 10: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11218/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/287/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12160/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/321/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12007/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/302/ : FAILURE -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 8: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11211/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/285/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12153/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/319/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12000/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/300/ : FAILURE -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
oVirt Jenkins CI Server has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11213/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc20_created/286/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12155/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc19_created/320/ : FAILURE http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/12002/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-el6_created/301/ : FAILURE -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Signs vdsm upgraded version for special treatment if required
Yaniv Bronhaim has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer mta...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
