Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-28 Thread nsoffer 
Nir Soffer has abandoned this change.

Change subject: iscsiadm: Add debug level option
..


Abandoned

We are not going to implement this RFE, since this is not the best place to 
collect iscsiadm debug logs.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Lev Veyde lve...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-25 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

 I am wondering why you don't want to move step by step, I mean writing this 
 log to another file first.

Writing to separate log file means means additional code to create and maintain 
those logs, and then additional effort to cleanup and rotate old logs. And the 
resulting log is hard to correlate with vdsm log. So this would waste of effort 
for little value.

 It probably will reduce the resistance to this RFE by half and you will be 
 able to evaluate how helpful this log on the real customer environment.

I don't see any reason to waste time in this direction if the community does 
not like this RFE.

 I understand from that RFE (Lev's comment) that original problem was 
 corrupted iscsi DB, do you know how it happened in the first place?

The RFE does not mention an original problem.

The purpose of the patch is to make debugging iscsiadm issues easier by 
providing debug log messages, as requested by the RFE. Please review this patch 
in this scope.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Lev Veyde lve...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-25 Thread ewarszaw 
Eduardo has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

There is no necessity for this RFE or this way is questionable IMHO.
(As I wrote there.)

The bottom line is that cluttering the vdsm logs with this info is making vdsm 
log worse.

vdsm is not a tool for iscsi debuging.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Lev Veyde lve...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-24 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

Please ignore jenkins build failure - the build machine is broken.

See http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5100/console

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-24 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3: Verified+1

Verified that new debug level option works and we do get iscsiadm logs inside 
vdsm log.

Note that the usefulness of these logs is questionable, as one call to iscsiadm 
can generate 18KB 395 lines log, and all of this is collapsed to one line, 
replacing \n with \\n, which makes it almost unreadable.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-24 Thread ewarszaw 
Eduardo has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3: Code-Review-1


Note that the usefulness of these logs is questionable, as one call to iscsiadm 
can generate 18KB 395 lines log, and all of this is collapsed to one line, 
replacing \n with \\n, which makes it almost unreadable.


I agree with --author that dumping many times unreadable lines on the vdsm.log 
only will destroy the vdsm.log.

The whole idea of RFE https://bugzilla.redhat.com/1011075 is questionable, 
being iscsiadm errors actually logged in vdsm.log and there is no need for 
logging iscasiadm possitive flows in vdsm.logs.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-24 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

Having iscsiadm debug logs in vdsm log is better then having no logs when you 
want to debug an issue in iscsiadm. The log are available only when you enable 
them in vdsm.conf.

We can make the log more useful by improving the way the log output the command 
stderr, but this is out of the scope of this patch.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-24 Thread sgotliv 
Sergey Gotliv has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

I share Eduardo's concern about clearness of vdsm log.
Is it possible to write iscsiadm log to its own file?

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Lev Veyde lve...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-24 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

This change does not effect the clearness of vdsm log. It adds iscsi debug log 
only if you enable this feature. If you need this information, the best place 
for it is in vdsm log where you can understand the context of the command.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Lev Veyde lve...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-24 Thread sgotliv 
Sergey Gotliv has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

This change does not effect the clearness of vdsm log. It adds iscsi debug log 
only if you enable this feature. 

So it does effect once you enable it. Do you know when and why it will happen? 
Did you try to debug non iscsiadm related issue when this log is turned on?

If you need this information, the best place for it is in vdsm log where you 
can understand the context of the command.

I am wondering why you don't want to move step by step, I mean writing this log 
to another file first. It probably will reduce the resistance to this RFE by 
half and you will be able to evaluate how helpful this log on the real customer 
environment.

I understand from that RFE (Lev's comment) that original problem was corrupted 
iscsi DB, do you know how it happened in the first place?

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Lev Veyde lve...@gmail.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Sergey Gotliv sgot...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-23 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 2: Code-Review+1

Dan/Fede/Saggi - your two cents about the config location?

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-23 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3:

Rebase over new version of http://gerrit.ovirt.org/#/c/19856

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-23 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 3: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5026/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4222/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5100/ : ABORTED

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Vered Volansky vvola...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-21 Thread amureini 
Allon Mureinik has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 1:

(2 comments)


File lib/vdsm/config.py.in
Line 288: ('guests_gateway_ip', '', None),
Line 289: 
Line 290: ]),
Line 291: 
Line 292: # Section: [iscsiadm]
I wonder if this shouldn't be under [irs] like the other scsi and iscsi conf 
values
Line 293: ('iscsiadm', [
Line 294: 
Line 295: ('debug_level', '0',
Line 296: 'Print iscsiadm debugging information (0 - 8).'),



File vdsm/storage/iscsiadm.py
Line 80: cmd = [constants.EXT_ISCSIADM]
Line 81: 
Line 82: debug_level = config.get('iscsiadm', 'debug_level')
Line 83: if debug_level != '0':
Line 84: cmd.extend(('-d', debug_level))
where are stdout and stderr redirected to in this situation?
Line 85: 
Line 86: cmd.extend(args)
Line 87: 
Line 88: printCmd = None


-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-21 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 1:

(1 comment)


File lib/vdsm/config.py.in
Line 288: ('guests_gateway_ip', '', None),
Line 289: 
Line 290: ]),
Line 291: 
Line 292: # Section: [iscsiadm]
This is the a better place, old settings are in the wrong place - whatever we 
choose will be wrong :-)

I'll let others choose
Line 293: ('iscsiadm', [
Line 294: 
Line 295: ('debug_level', '0',
Line 296: 'Print iscsiadm debugging information (0 - 8).'),


-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-21 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 2:

Build Successful 

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4999/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4195/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5073/ : SUCCESS

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-21 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 1:

(1 comment)


File vdsm/storage/iscsiadm.py
Line 80: cmd = [constants.EXT_ISCSIADM]
Line 81: 
Line 82: debug_level = config.get('iscsiadm', 'debug_level')
Line 83: if debug_level != '0':
Line 84: cmd.extend(('-d', debug_level))
utils.execCmd prints stderr (where the debug info will be) for any command in 
debug log level.
Line 85: 
Line 86: cmd.extend(args)
Line 87: 
Line 88: printCmd = None


-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-21 Thread nsoffer 
Nir Soffer has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 2:

Rebase, dependent patch changed.

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-20 Thread nsoffer 
Nir Soffer has uploaded a new change for review.

Change subject: iscsiadm: Add debug level option
..

iscsiadm: Add debug level option

VDSM uses iscdiadm to perform iSCSI operations which are often
complicated to debug. This patch uses iscsiadm --debug-level option to
add debugging information to vdsm debug log messages.  The debug level
is disabled by default and can be enabled in a new iscsiadm section in
vdsm.conf.

Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Bug-Url: https://bugzilla.redhat.com/1011075
Signed-off-by: Nir Soffer nsof...@redhat.com
---
M lib/vdsm/config.py.in
M tests/iscsiadmTests.py
M vdsm/storage/iscsiadm.py
3 files changed, 31 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/38/20338/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index c0bdd53..904058d 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -288,6 +288,14 @@
 ('guests_gateway_ip', '', None),
 
 ]),
+
+# Section: [iscsiadm]
+('iscsiadm', [
+
+('debug_level', '0',
+'Print iscsiadm debugging information (0 - 8).'),
+
+]),
 ]
 
 
diff --git a/tests/iscsiadmTests.py b/tests/iscsiadmTests.py
index c623ecb..216fe5f 100644
--- a/tests/iscsiadmTests.py
+++ b/tests/iscsiadmTests.py
@@ -19,6 +19,7 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
+import ConfigParser
 from testrunner import VdsmTestCase as TestCaseBase
 
 from vdsm import constants
@@ -28,8 +29,16 @@
 import fake
 
 
+def config(debug_level):
+c = ConfigParser.ConfigParser()
+c.add_section('iscsiadm')
+c.set('iscsiadm', 'debug_level', debug_level)
+return c
+
+
 @MonkeyClass(misc, 'execCmd', fake.Callable())
 @MonkeyClass(iscsiadm, '_iscsiadmLock', fake.Scope())
+@MonkeyClass(iscsiadm, 'config', config('0'))
 class TestRunCommand(TestCaseBase):
 
 def testTakeLock(self):
@@ -62,6 +71,12 @@
 self.assertEqual(misc.execCmd.args, (cmd,))
 self.assertEqual(misc.execCmd.kw, {'sudo': True, 'printable': cmd})
 
+@MonkeyPatch(iscsiadm, 'config', config('8'))
+def testWithDebugLevel(self):
+iscsiadm._runCmd([])
+self.assertEqual(misc.execCmd.args,
+ ([constants.EXT_ISCSIADM, '-d', '8'],))
+
 
 @MonkeyClass(iscsiadm, '_runCmd', fake.Callable())
 class TestCommands(TestCaseBase):
diff --git a/vdsm/storage/iscsiadm.py b/vdsm/storage/iscsiadm.py
index cd28db8..4f960d0 100644
--- a/vdsm/storage/iscsiadm.py
+++ b/vdsm/storage/iscsiadm.py
@@ -1,6 +1,7 @@
 from threading import Lock
 import misc
 from vdsm import constants
+from vdsm.config import config
 
 # iscsiadm exit statuses
 ISCSI_ERR_SESS_EXISTS = 15
@@ -76,7 +77,13 @@
 # run as root and there is no such feature yet in supervdsm. When such
 # feature exists please change this.
 with _iscsiadmLock:
-cmd = [constants.EXT_ISCSIADM] + args
+cmd = [constants.EXT_ISCSIADM]
+
+debug_level = config.get('iscsiadm', 'debug_level')
+if debug_level != '0':
+cmd.extend(('-d', debug_level))
+
+cmd.extend(args)
 
 printCmd = None
 if hideValue:


-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: iscsiadm: Add debug level option

2013-10-20 Thread oVirt Jenkins CI Server 
oVirt Jenkins CI Server has posted comments on this change.

Change subject: iscsiadm: Add debug level option
..


Patch Set 1: Verified-1

Build Failed 

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/5059/ : ABORTED

http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4985/ : SUCCESS

http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/4175/ : FAILURE

-- 
To view, visit http://gerrit.ovirt.org/20338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe2d7a3637ea4a0b36ac7aad0890f99dfaa5854e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Eduardo ewars...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches