Change in vdsm[master]: monitor: Rename storage domain monitor threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: monitor: Rename storage domain monitor threads
..


monitor: Rename storage domain monitor threads

These threads used the default names (Thread-N), making it hard to
locate a domain monitor thread for certain domain. Now the threads are
named "monitor/short-uuid". short-uuuid is the first 8 characters of the
storage domain uuid since system thread names are limited to 15
characters.

Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Signed-off-by: Nir Soffer 
Reviewed-on: https://gerrit.ovirt.org/63524
Reviewed-by: Freddy Rolland 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Adam Litke 
---
M vdsm/storage/monitor.py
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve
  Freddy Rolland: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:

Line 252: class MonitorThread(object):
Line 253: 
Line 254: def __init__(self, sdUUID, hostId, interval, changeEvent, 
checker):
Line 255: self.thread = concurrent.thread(self._run, logger=log.name,
Line 256: name="monitor/" + sdUUID[:7])
> Yes, name is not unique. Today all threads are named (in htop and ps) "vdsm
To minimize the chance of collusion, but avoid too long thread names in vdsm 
logs, we can use:

"monitor/" + sdUUID[:18]

The name will look like this in vdsm logs:

monitor/95430c8c-bbfc-4811

And like this in system tools (15 chars limit):

monitor/95430c8

We can do the same for other short uuids in the next patches.
Line 257: self.stopEvent = threading.Event()
Line 258: self.domain = None
Line 259: self.sdUUID = sdUUID
Line 260: self.hostId = hostId


-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[alitke]

Adam Litke has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 4: Code-Review+2

Good enough explanation for me!

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:

Line 252: class MonitorThread(object):
Line 253: 
Line 254: def __init__(self, sdUUID, hostId, interval, changeEvent, 
checker):
Line 255: self.thread = concurrent.thread(self._run, logger=log.name,
Line 256: name="monitor/" + sdUUID[:7])
> It's theoretically possible to have a pair of domains with matching short u
Yes, name is not unique. Today all threads are named (in htop and ps) "vdsm", 
so having two threads named "monitor/xxxyyy" is way better.

We can use full uuid for the python thread name, and short uuid for the system 
names, but then python thread names will be too long. I assume that chance of 
same short uuid is small.
Line 257: self.stopEvent = threading.Event()
Line 258: self.domain = None
Line 259: self.sdUUID = sdUUID
Line 260: self.hostId = hostId


-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[alitke]

Adam Litke has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/63524/4/vdsm/storage/monitor.py
File vdsm/storage/monitor.py:

PS4, Line 256: sdUUID[:7]
It's theoretically possible to have a pair of domains with matching short 
uuids.  What happens then?  Can different threads have the same name?


-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[fromani]

Francesco Romani has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 4: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[frolland]

Freddy Rolland has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Idan Shaby 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitor: Rename storage domain monitor threads
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: monitor: Rename storage domain monitor threads

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: monitor: Rename storage domain monitor threads
..

monitor: Rename storage domain monitor threads

These threads used the default names (Thread-N), making it hard to
locate a domain monitor thread for certain domain. Now the threads are
named "monitor/short-uuid". short-uuuid is the first 8 characters of the
storage domain uuid since system thread names are limited to 15
characters.

Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Signed-off-by: Nir Soffer 
---
M vdsm/storage/monitor.py
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/63524/1

diff --git a/vdsm/storage/monitor.py b/vdsm/storage/monitor.py
index 607f8af..4ffa7e5 100644
--- a/vdsm/storage/monitor.py
+++ b/vdsm/storage/monitor.py
@@ -252,7 +252,8 @@
 class MonitorThread(object):
 
 def __init__(self, sdUUID, hostId, interval, changeEvent, checker):
-self.thread = concurrent.thread(self._run, logger=log.name)
+self.thread = concurrent.thread(self._run, logger=log.name,
+name="monitor/" + sdUUID[:7])
 self.stopEvent = threading.Event()
 self.domain = None
 self.sdUUID = sdUUID


-- 
To view, visit https://gerrit.ovirt.org/63524
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I86480d2205be602cbffe6c37acd63a67a4aa2c96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org