Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-12 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 11:

* #1347669::Update tracker: OK
* Set MODIFIED::bug 1347669#1347669::IGNORE, skipping for branch 'master'

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-12 Thread danken 
Dan Kenigsberg has submitted this change and it was merged.

Change subject: rng: allow urandom as virtio rng entropy source
..


rng: allow urandom as virtio rng entropy source

Libvirt previously used a whitelist to only allow random and hwrng
virtio-rng sources. As per libvirt commit
67f2b72723c242969c5282fcb9acf00cc01f2a54, this restriction is lifted
and any character device may be used. We don't exactly want to use
*any* character device, but we may allow usage of urandom. Additional
discussion in RHBZ#1074464.

The implementation hides the fact that urandom can be used.  This is
due to the fact that 4.0 (and lower) engine can't handle additional
RNG sources.

Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1347669
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/59031
Continuous-Integration: Jenkins CI
Reviewed-by: Milan Zamazal 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/host/rngsources.py
M tests/rngsources_test.py
2 files changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Martin Polednik: Verified
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-12 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10:

The patch itself is libvirt version agnostic, it's up to 4.1 engine.

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread ykaul 
Yaniv Kaul has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10:

Should we add a spec dependency on a newer libvirt for this to work?

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10: Code-Review+2

raising score

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread mzamazal 
Milan Zamazal has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 10:

* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
* Check Product::#1347669::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 9: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/59031/9/lib/vdsm/host/rngsources.py
File lib/vdsm/host/rngsources.py:

Line 33: def list_available():
Line 34: return [
Line 35: source for (source, path) in _SOURCES.items()
Line 36: if os.path.exists(path) and
Line 37: # Remove when 4.0 is not supported.
Please use 

 REQUIRE_FOR: Engine <= 4.0
Line 38: source != 'urandom'
Line 39: ]
Line 40: 
Line 41: 


-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread danken 
Dan Kenigsberg has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 9: Continuous-Integration+1

FAIL: test_ip_info (network.netinfo_test.TestNetinfo)

indeed unrelated

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 9:

Jenkins failure unrelated.

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-09-08 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 9:

* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
* Check Product::#1347669::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-18 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/host/rngsources.py:

Line 34: return [
Line 35: source for (source, path) in _SOURCES.items()
Line 36: if os.path.exists(path) and
Line 37: # Remove when 4.0 is not supported.
Line 38: source != 'urandom'
> It is misleading, although it's availability is quite closely tied to "rand
The real issue here is Engine side. So let's target the real problem: let's 
file a bug on Engine about this - and link it here in the comment. After that 
we can have this patch.
Line 39: ]
Line 40: 
Line 41: 
Line 42: def get_device(name):


-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-18 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 8: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-18 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/host/rngsources.py:

Line 34: return [
Line 35: source for (source, path) in _SOURCES.items()
Line 36: if os.path.exists(path) and
Line 37: # Remove when 4.0 is not supported.
Line 38: source != 'urandom'
> ok, but it isn't misleading to use a resource we don't list as available? T
It is misleading, although it's availability is quite closely tied to "random" 
resource. I believe we have to add it ASAP (see the heated up discussion in 
https://bugzilla.redhat.com/show_bug.cgi?id=1074464).
Line 39: ]
Line 40: 
Line 41: 
Line 42: def get_device(name):


-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-18 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/host/rngsources.py:

Line 34: return [
Line 35: source for (source, path) in _SOURCES.items()
Line 36: if os.path.exists(path) and
Line 37: # Remove when 4.0 is not supported.
Line 38: source != 'urandom'
> We gain the ability to use urandom source based on presence of random - lis
ok, but it isn't misleading to use a resource we don't list as available? The 
resources we use should be a proper subset of the resource we hava available :)

Please note that I actually want this patch, it's just that I sadly think we 
cannot have it now, because of accidental complecity/backward compatibility 
constraints.
Line 39: ]
Line 40: 
Line 41: 
Line 42: def get_device(name):


-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-18 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 8:

* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
* Check Product::#1347669::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-18 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/host/rngsources.py:

Line 34: return [
Line 35: source for (source, path) in _SOURCES.items()
Line 36: if os.path.exists(path) and
Line 37: # Remove when 4.0 is not supported.
Line 38: source != 'urandom'
> I can't help but wonder what we gain from this patch, since ovirt-4.0 compa
We gain the ability to use urandom source based on presence of random - 
list_available only exists for *reporting*, it's not checked in creation flow.
Line 39: ]
Line 40: 
Line 41: 
Line 42: def get_device(name):


-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-18 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/59031/7/lib/vdsm/host/rngsources.py
File lib/vdsm/host/rngsources.py:

Line 34: return [
Line 35: source for (source, path) in _SOURCES.items()
Line 36: if os.path.exists(path) and
Line 37: # Remove when 4.0 is not supported.
Line 38: source != 'urandom'
I can't help but wonder what we gain from this patch, since ovirt-4.0 
compatibility constraints drag us down.
If it wasn't for backward compatibility constraint this would have been a 
no-brainer +2
Line 39: ]
Line 40: 
Line 41: 
Line 42: def get_device(name):


-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-08 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7:

Rationale behind this patch (although, I'm not excited having to defend this 
mess): engine can't handle new RNG sources. To work around that, we avoid 
reporting urandom as a source (in a hacky-enough way to raise concern) while 
still allowing urandom to be passed as device source.

The source itself can be deduced from existence of 'random' source.

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7: Code-Review-1

I find the linked discussion enlightening, I'm fine with the concept and I 
liked the first versions of this patch. But on its last incarnation, I'm not 
sure it makes sense anymore :\

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 7:

* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
* Check Product::#1347669::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 6:

* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
* Check Product::#1347669::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 5: -Verified

Keeping unverified to be in sync w/ engine change.

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread jniederm 
Jakub Niedermertl has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jakub Niedermertl 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread mpolednik 
Martin Polednik has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 5: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread Jenkins CI 
Jenkins CI has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 5: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 4

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread mbetak 
Martin Betak has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 5: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 5:

* #1347669::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1347669::OK, public bug
* Check Product::#1347669::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-08-04 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-07-26 Thread fromani 
Francesco Romani has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-07-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: rng: allow urandom as virtio rng entropy source

2016-07-25 Thread automation 
gerrit-hooks has posted comments on this change.

Change subject: rng: allow urandom as virtio rng entropy source
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d46f1f3cff63e6443f5154577bd57b5ffc5f4ce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org