Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-04 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has submitted this change and it was merged.

Change subject: rpmlint: ignore only limited set of errors
..


rpmlint: ignore only limited set of errors

Currently, our rpms fail in 5 tests:

explicit-lib-dependency
no-binary
zero-length
non-readable
non-standard-dir-perm

We do not have the time to fix these failures right now, but we want to
make sure that no new failure is added in the mean while.

This patch makes rpmlint ignore the currently-broken tests, and fail
loudly if a new one pops in.

Reviewed-on: https://gerrit.ovirt.org/#/c/69444
Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Signed-off-by: Dan Kenigsberg 
---
M automation/check-patch.sh
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified



-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: rpmlint: ignore only limited set of errors
..


Patch Set 7: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: rpmlint: ignore only limited set of errors
..


Patch Set 7: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: rpmlint: ignore only limited set of errors
..


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/69444/5/automation/check-patch.sh
File automation/check-patch.sh:

Line 29: ./automation/build-artifacts.sh
Line 30: yum -y install "$EXPORT_DIR/"!(*.src).rpm
Line 31: export LC_ALL=C  # no idea why this is suddenly needed
Line 32: rpmlint "$EXPORT_DIR/"*.src.rpm
Line 33: 
tab
Line 34: # TODO: fix spec to stop ignoring the few current errors
Line 35: ! rpmlint "$EXPORT_DIR/"!(*.src).rpm | grep ': E: ' | grep -v 
explicit-lib-dependency | \
Line 36: grep -v no-binary | grep -v zero-length | \
Line 37: grep -v non-readable | grep -v non-standard-dir-perm


-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: rpmlint: ignore only limited set of errors
..


Patch Set 5: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/69444/4//COMMIT_MSG
Commit Message:

Line 16: 
Line 17: We do not have the time to fix these failures right now, but we want to
Line 18: make sure that no new failure is added in the mean while.
Line 19: 
Line 20: This patch makes rpmlint ignore the currently-broken tests, and fail
> fix link to https://gerrit.ovirt.org/#/c/69444/
I was attempting a new automatic link. it did not work :-(
I'll drop it completely.
Line 21: loudly if a new one pops in.
Line 22: 
Line 23: Reviewed-on: https://gerrit.ovirt.org/#/c/69444
Line 24: Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a


-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: rpmlint: ignore only limited set of errors
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/69444/4//COMMIT_MSG
Commit Message:

Line 11: explicit-lib-dependency
Line 12: no-binary
Line 13: zero-length
Line 14: non-readable
Line 15: non-standard-dir-perm
maybe write few words about why we accept the fail? .. if we have a reason
Line 16: 
Line 17: We should explicitly list the failing tests, to make sure that no new
Line 18: failure is added.
Line 19: 


-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-03 Thread Code Review 
From Yaniv Bronhaim :

Yaniv Bronhaim has posted comments on this change.

Change subject: rpmlint: ignore only limited set of errors
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/69444/4//COMMIT_MSG
Commit Message:

Line 16: 
Line 17: We should explicitly list the failing tests, to make sure that no new
Line 18: failure is added.
Line 19: 
Line 20: Reviewed-on: 
https://gerrit.ovirt.org/#/q/I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
fix link to https://gerrit.ovirt.org/#/c/69444/
Line 21: Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a


https://gerrit.ovirt.org/#/c/69444/4/automation/check-patch.sh
File automation/check-patch.sh:

Line 28: if git diff-tree --no-commit-id --name-only -r HEAD | egrep --quiet 
'vdsm.spec.in|Makefile.am' ; then
Line 29: ./automation/build-artifacts.sh
Line 30: yum -y install "$EXPORT_DIR/"!(*.src).rpm
Line 31: export LC_ALL=C  # no idea why this is suddenly needed
Line 32: rpmlint "$EXPORT_DIR/"*.src.rpm
I think better to add the commit msg comment to the code itself as well - "this 
is to ignore known issues and scream when new issue appears"
Line 33: ! rpmlint "$EXPORT_DIR/"!(*.src).rpm | grep ': E: ' | grep -v 
explicit-lib-dependency | \
Line 34: grep -v no-binary | grep -v zero-length | \
Line 35: grep -v non-readable | grep -v non-standard-dir-perm


-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: rpmlint: ignore only limited set of errors

2017-01-02 Thread Code Review 
From Dan Kenigsberg :

Dan Kenigsberg has posted comments on this change.

Change subject: rpmlint: ignore only limited set of errors
..


Patch Set 4: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/69444
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org