Change in vdsm[master]: untested: notify Engine when host connectivity changes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[mmucha]

Martin Mucha has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: untested: notify Engine when host connectivity changes
..


untested: notify Engine when host connectivity changes

Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/51135
Continuous-Integration: Jenkins CI
Tested-by: Martin Mucha 
Reviewed-by: Martin Mucha 
Reviewed-by: Piotr Kliczewski 
---
M vdsm/virt/periodic.py
M vdsm/virt/sampling.py
2 files changed, 5 insertions(+), 2 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Martin Mucha: Verified; Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[mmucha]

Martin Mucha has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 2:

Subscription id looks good.

-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 561: |net|host_conn|
> Isn't Engine already aware of where the event is originating?
Engine is aware from which vdsm is it. I talked to Martin and we agreed on 
no_id here.


-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[mmucha]

Martin Mucha has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 561: |net|host_conn|
> Engine is aware from which vdsm is it. I talked to Martin and we agreed on 
I just tried it with "|net|host_conn|no_id" and I can confirm, that engine 
consument even on activation. It did not receive any event (or I overlooked it 
somehow) when engine entered maintenance mode. I do not understand vdsm well 
(this is my first visit here) to tell if that's OK. If it's possible, I'd 
consider to adding ID not having to call getCapabilities on all hosts, but only 
on one which was just activated...


-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 561: |net|host_conn|
> I think that we need more descriptive subscription id. We need to know on t
Isn't Engine already aware of where the event is originating?

Vdsm is not aware of Engine's host-id for it.

And yes, we need to discuss with Engine whether we should send the data now, or 
just trigger a getCapabilities call.


-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 561: |net|host_conn|
I think that we need more descriptive subscription id. We need to know on the 
engine side which host is it.

Please see code from vm.py:

sub_id = '|virt|%s|%s' % (operation, self.id)
self.cif.notify(sub_id, **{self.id: params})

Do we want to send any additional data together with the event?


-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[fromani]

Francesco Romani has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 1:

(1 comment)

conceptually I'm fine with the idea, but it needs some polishing.

https://gerrit.ovirt.org/#/c/51135/1/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 556: else:
Line 557: diff = sample.connlog_diff(second_last)
Line 558: if diff:
Line 559: self._CONNLOG.debug('%s', diff)
Line 560: if self._cif is not None:
If you prefer, feel free to change the signature of __init__ to make cif 
required.
Line 561: self._cif.notify('|net|host_conn|')
Line 562: 
Line 563: 
Line 564: def _getLinkSpeed(dev):


-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yevgeny Zaspitsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: untested: notify Engine when host connectivity changes
..

untested: notify Engine when host connectivity changes

Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Signed-off-by: Dan Kenigsberg 
---
M vdsm/virt/periodic.py
M vdsm/virt/sampling.py
2 files changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/35/51135/1

diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py
index 31d5269..dd79f3d 100644
--- a/vdsm/virt/periodic.py
+++ b/vdsm/virt/periodic.py
@@ -103,7 +103,7 @@
 config.getint('vars', 'vm_watermark_interval')),
 
 Operation(
-sampling.HostMonitor(),
+sampling.HostMonitor(cif=cif),
 config.getint('vars', 'host_sample_stats_interval'),
 scheduler)
 
diff --git a/vdsm/virt/sampling.py b/vdsm/virt/sampling.py
index 8f02aab..ff5b791 100644
--- a/vdsm/virt/sampling.py
+++ b/vdsm/virt/sampling.py
@@ -542,9 +542,10 @@
 class HostMonitor(object):
 _CONNLOG = logging.getLogger('connectivity')
 
-def __init__(self, samples=host_samples):
+def __init__(self, samples=host_samples, cif=None):
 self._samples = samples
 self._pid = os.getpid()
+self._cif = cif
 
 def __call__(self):
 sample = HostSample(self._pid)
@@ -556,6 +557,8 @@
 diff = sample.connlog_diff(second_last)
 if diff:
 self._CONNLOG.debug('%s', diff)
+if self._cif is not None:
+self._cif.notify('|net|host_conn|')
 
 
 def _getLinkSpeed(dev):


-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: untested: notify Engine when host connectivity changes

[automation]

gerrit-hooks has posted comments on this change.

Change subject: untested: notify Engine when host connectivity changes
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/51135
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e2df34c95709a3e201e984909dcb78c97c20710
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches