Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
gerrit-hooks has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 3: * #1377069::Update tracker: OK * Set MODIFIED::bug 1377069#1377069IGNORE, not all related patches are closed, check 64099 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Dan Kenigsberg has submitted this change and it was merged. Change subject: vdsm: Do not modify warnings filter in a library .. vdsm: Do not modify warnings filter in a library vdsm.vdscli was modifying warnings filter, taking control from the application importing it. With the old code, there is no way to disable the warnings - if the application sets a warnings filter, importing vdscli will override the application filter. This warnings is highly unwanted, causing user facing warnings each time you run a vdsClient or hosted-engine command. This patch removes the wrong filter, returning control to the application using vdscli. Since warnings are hidden by default, this removes the unwanted warnings from vdsClient and hosted-engine command line tools. Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Bug-Url: https://bugzilla.redhat.com/1377069 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/64100 Continuous-Integration: Jenkins CI Reviewed-by: Simone Tiraboschi Reviewed-by: Dan Kenigsberg Reviewed-by: Yaniv Bronhaim Reviewed-by: Piotr Kliczewski --- M lib/vdsm/vdscli.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified Simone Tiraboschi: Looks good to me, but someone else must approve Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Thanks for the quick reviews. Lets merge this soon so we don't miss the next build. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Piotr Kliczewski has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Martin Sivák has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > Why is it not enough? We are talking about developers not users. Because nobody rereads a docstring for a library that has already been used for years. So deprecation warnings need to be a bit more obvious. But only to developers (so warnings should be enabled in automation), users will just get confused. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Piotr Kliczewski has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > Sure, documentation is a must, but it is not enough. Why is it not enough? We are talking about developers not users. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > What about docstring For developers? Sure, documentation is a must, but it is not enough. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Piotr Kliczewski has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > The whole point is to allow interested developers or users (or automation) What about docstring For developers? -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Simone Tiraboschi has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Code-Review+1 +1 for me, I agree to take the python way for it. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Martin Sivák has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > and if you don't you'll never see it. so for what? you can just write it to The whole point is to allow interested developers or users (or automation) to see it without bothering users, who can do nothing to solve it anyway. Nir already pointed out that it is the same approach Python itself uses. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: Yaniv, you are trying to force your warnings on other developers. We are trying to help developers using our software, not punish them or their users. We can add python warnings, we can add warnings in documentation, add release notes etc. We cannot spam people stderr or logs with unrelated warnings. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: I wonder if we don't want both the warning and a log print -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Francesco Romani has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: I'm ok with this approach, better than my https://gerrit.ovirt.org/#/c/64117/ -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > This will show warnings if you run python with warnings enabled. and if you don't you'll never see it. so for what? you can just write it to syslog -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 > I don't see any use for leaving the warning here that way. the all idea was This will show warnings if you run python with warnings enabled. See https://docs.python.org/2/using/cmdline.html#cmdoption-W -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: -Code-Review (1 comment) https://gerrit.ovirt.org/#/c/64100/2/lib/vdsm/vdscli.py File lib/vdsm/vdscli.py: Line 138 Line 139 Line 140 Line 141 Line 142 I don't see any use for leaving the warning here that way. the all idea was to make it bold to the users -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG Commit Message: Line 15: you run a vdsClient or hosted-engine command. Line 16: Line 17: This patch remove the wrong filter, returning control to the application Line 18: using vdscli. Since warnings hare hidden by default, this remove the Line 19: unwanted warnings from vdsClient and hosted-engine command line tools. > This is wrong usage of warnings, causing user facing regression in any prog this was supposed to be only in master and the idea was to remove the usages and catch them quickly - this is exactly what we have here which is good - lets replace the usages and remove the warning from 4.0 Line 20: Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Line 22: Bug-Url: https://bugzilla.redhat.com/1377069 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 1: (2 comments) Tanks for the reivew, commit message fixed in current version. https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG Commit Message: Line 13: Line 14: This warnings is highly unwanted, causing user facing warnings each time Line 15: you run a vdsClient or hosted-engine command. Line 16: Line 17: This patch remove the wrong filter, returning control to the application > s/remove/removes Done Line 18: using vdscli. Since warnings hare hidden by default, this remove the Line 19: unwanted warnings from vdsClient and hosted-engine command line tools. Line 20: Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Line 14: This warnings is highly unwanted, causing user facing warnings each time Line 15: you run a vdsClient or hosted-engine command. Line 16: Line 17: This patch remove the wrong filter, returning control to the application Line 18: using vdscli. Since warnings hare hidden by default, this remove the > s/hare/are s/remove/removes Done Line 19: unwanted warnings from vdsClient and hosted-engine command line tools. Line 20: Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Line 22: Bug-Url: https://bugzilla.redhat.com/1377069 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
gerrit-hooks has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 2: * #1377069::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1377069::OK, public bug * Check Product::#1377069::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG Commit Message: Line 15: you run a vdsClient or hosted-engine command. Line 16: Line 17: This patch remove the wrong filter, returning control to the application Line 18: using vdscli. Since warnings hare hidden by default, this remove the Line 19: unwanted warnings from vdsClient and hosted-engine command line tools. > Maintainers' conflict? Dan wanted it that way exactly. I guess this warning This is wrong usage of warnings, causing user facing regression in any program using. We should try hard to avoid such issue. Line 20: Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Line 22: Bug-Url: https://bugzilla.redhat.com/1377069 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/64100/1//COMMIT_MSG Commit Message: Line 13: Line 14: This warnings is highly unwanted, causing user facing warnings each time Line 15: you run a vdsClient or hosted-engine command. Line 16: Line 17: This patch remove the wrong filter, returning control to the application s/remove/removes Line 18: using vdscli. Since warnings hare hidden by default, this remove the Line 19: unwanted warnings from vdsClient and hosted-engine command line tools. Line 20: Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Line 14: This warnings is highly unwanted, causing user facing warnings each time Line 15: you run a vdsClient or hosted-engine command. Line 16: Line 17: This patch remove the wrong filter, returning control to the application Line 18: using vdscli. Since warnings hare hidden by default, this remove the s/hare/are s/remove/removes Line 19: unwanted warnings from vdsClient and hosted-engine command line tools. Line 20: Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Line 22: Bug-Url: https://bugzilla.redhat.com/1377069 Line 15: you run a vdsClient or hosted-engine command. Line 16: Line 17: This patch remove the wrong filter, returning control to the application Line 18: using vdscli. Since warnings hare hidden by default, this remove the Line 19: unwanted warnings from vdsClient and hosted-engine command line tools. Maintainers' conflict? Dan wanted it that way exactly. I guess this warning has a purpose and the purpose was achieved. I susgest to focus about removing the usages and with that also the warning will disappear Line 20: Line 21: Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Line 22: Bug-Url: https://bugzilla.redhat.com/1377069 -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 1: Verified+1 Tested with vdsClient and by importing vdscli. -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
gerrit-hooks has posted comments on this change. Change subject: vdsm: Do not modify warnings filter in a library .. Patch Set 1: * #1377069::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1377069::OK, public bug * Check Product::#1377069::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/64100 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
Change in vdsm[master]: vdsm: Do not modify warnings filter in a library
Nir Soffer has uploaded a new change for review.
Change subject: vdsm: Do not modify warnings filter in a library
..
vdsm: Do not modify warnings filter in a library
vdsm.vdscli was modifying warnings filter, taking control from the
application importing it. With the old code, there is no way to disable
the warnings - if the application sets a warnings filter, importing
vdscli will override the application filter.
This warnings is highly unwanted, causing user facing warnings each time
you run a vdsClient or hosted-engine command.
This patch remove the wrong filter, returning control to the application
using vdscli. Since warnings hare hidden by default, this remove the
unwanted warnings from vdsClient and hosted-engine command line tools.
Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Bug-Url: https://bugzilla.redhat.com/1377069
Signed-off-by: Nir Soffer
---
M lib/vdsm/vdscli.py
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/64100/1
diff --git a/lib/vdsm/vdscli.py b/lib/vdsm/vdscli.py
index 22e7bc8..552330c 100644
--- a/lib/vdsm/vdscli.py
+++ b/lib/vdsm/vdscli.py
@@ -136,7 +136,6 @@
server = xmlrpclib.Server('http://%s' % hostPort, transport)
return server
-warnings.simplefilter("always", category=DeprecationWarning)
warnings.warn(
"vdscli uses xmlrpc. since ovirt 3.6 xmlrpc is deprecated, please use "
"vdsm.jsonrpcvdscli", DeprecationWarning, stacklevel=2)
--
To view, visit https://gerrit.ovirt.org/64100
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c31508b3279d8ea762c4dfeffeb1348697f5f77
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
