Patch 7.1.181
Patch 7.1.181
Problem:Accessing uninitialized memory in Farsi mode. (Dominuque Pelle)
Solution: Only invoke lrF_sub() when there is something to do.
Files: src/ex_cmds.c
*** ../vim-7.1.180/src/ex_cmds.cSun Dec 9 19:37:37 2007
--- src/ex_cmds.c Mon Dec 31 17:29:25 2007
***
*** 4212,4222
sub_nlines = 0;
}
- #ifdef FEAT_FKMAP /* reverse the flow of the Farsi characters */
- if (p_altkeymap curwin-w_p_rl)
- lrF_sub(cmd);
- #endif
-
if (eap-cmdidx == CMD_tilde)
which_pat = RE_LAST;/* use last used regexp */
else
--- 4212,4217
***
*** 4252,4257
--- 4247,4256
}
else/* find the end of the regexp */
{
+ #ifdef FEAT_FKMAP /* reverse the flow of the Farsi characters */
+ if (p_altkeymap curwin-w_p_rl)
+ lrF_sub(cmd);
+ #endif
which_pat = RE_LAST;/* use last used regexp */
delimiter = *cmd++; /* remember delimiter character */
pat = cmd; /* remember start of search pat */
*** ../vim-7.1.180/src/version.cTue Jan 1 17:37:01 2008
--- src/version.c Wed Jan 2 13:57:31 2008
***
*** 668,669
--- 668,671
{ /* Add new patch number below this line */
+ /**/
+ 181,
/**/
--
Yah, well, we had to carve our electrons out of driftwood we'd
find. In the winter. Uphill. Both ways.
/// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\download, build and distribute -- http://www.A-A-P.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--~--~-~--~~~---~--~~
You received this message from the vim_dev maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
Bug in FAQ at http://vimdoc.sourceforge.net/cgi-bin/vimfaq2html3.pl
Sorry if this is the wrong place, but I could not find any better.. In http://vimdoc.sourceforge.net/cgi-bin/vimfaq2html3.pl at 32.1: -$ stty -ixon -xoff +$ stty -ixon -ixoff Richard PS: Not a real patch as I am certain that this is not the source file, anyway --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Patch 7.1.185
Patch 7.1.185
Problem:Using gR with a multi-byte encoding and typing a CR pushes
characters onto the replace stack incorrectly, resulting in BS
putting back the wrong characters. (Paul B. Mahol)
Solution: Push multi-byte characters onto the replace stack in reverse byte
order. Add replace_push_mb().
Files: src/edit.c, src/misc1.c, src/proto/edit.pro
*** ../vim-7.1.184/src/edit.c Sun Dec 9 20:25:59 2007
--- src/edit.c Tue Jan 1 17:28:07 2008
***
*** 6939,6944
--- 6939,6963
++replace_stack_nr;
}
+ #if defined(FEAT_MBYTE) || defined(PROTO)
+ /*
+ * Push a character onto the replace stack. Handles a multi-byte character in
+ * reverse byte order, so that the first byte is popped off first.
+ * Return the number of bytes done (includes composing characters).
+ */
+ int
+ replace_push_mb(p)
+ char_u *p;
+ {
+ int l = (*mb_ptr2len)(p);
+ int j;
+
+ for (j = l - 1; j = 0; --j)
+ replace_push(p[j]);
+ return l;
+ }
+ #endif
+
#if 0
/*
* call replace_push(c) with replace_offset set to the first NUL.
*** ../vim-7.1.184/src/misc1.c Wed Sep 26 22:35:06 2007
--- src/misc1.c Wed Jan 2 17:48:00 2008
***
*** 591,597
replace_push(NUL);
p = saved_line + curwin-w_cursor.col;
while (*p != NUL)
! replace_push(*p++);
saved_line[curwin-w_cursor.col] = NUL;
}
#endif
--- 592,605
replace_push(NUL);
p = saved_line + curwin-w_cursor.col;
while (*p != NUL)
! {
! #ifdef FEAT_MBYTE
! if (has_mbyte)
! p += replace_push_mb(p);
! else
! #endif
! replace_push(*p++);
! }
saved_line[curwin-w_cursor.col] = NUL;
}
#endif
***
*** 1914,1920
int charlen;
{
int c = buf[0];
- int l, j;
#endif
int newlen; /* nr of bytes inserted */
int oldlen; /* nr of bytes deleted (0 when not
replacing) */
--- 1922,1927
***
*** 2016,2028
for (i = 0; i oldlen; ++i)
{
#ifdef FEAT_MBYTE
! l = (*mb_ptr2len)(oldp + col + i) - 1;
! for (j = l; j = 0; --j)
! replace_push(oldp[col + i + j]);
! i += l;
! #else
! replace_push(oldp[col + i]);
#endif
}
}
--- 2023,2033
for (i = 0; i oldlen; ++i)
{
#ifdef FEAT_MBYTE
! if (has_mbyte)
! i += replace_push_mb(oldp + col + i) - 1;
! else
#endif
+ replace_push(oldp[col + i]);
}
}
*** ../vim-7.1.184/src/proto/edit.pro Sat May 5 20:21:34 2007
--- src/proto/edit.pro Tue Jan 1 17:21:24 2008
***
*** 32,37
--- 32,38
char_u *get_last_insert __ARGS((void));
char_u *get_last_insert_save __ARGS((void));
void replace_push __ARGS((int c));
+ int replace_push_mb __ARGS((char_u *p));
void fixthisline __ARGS((int (*get_the_indent)(void)));
void fix_indent __ARGS((void));
int in_cinkeys __ARGS((int keytyped, int when, int line_is_empty));
*** ../vim-7.1.184/src/version.cWed Jan 2 16:25:20 2008
--- src/version.c Wed Jan 2 17:45:10 2008
***
*** 668,669
--- 668,671
{ /* Add new patch number below this line */
+ /**/
+ 185,
/**/
--
Not too long ago, a keyboard was something to make music with...
/// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\download, build and distribute -- http://www.A-A-P.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--~--~-~--~~~---~--~~
You received this message from the vim_dev maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
Patch 7.1.187
Patch 7.1.187
Problem:Win32 GUI: Custom completion using system() no longer works
after patch 7.1.104. (Erik Falor)
Solution: Loop when safe_vgetc() returns K_IGNORE.
Files: src/ex_getln.c
*** ../vim-7.1.186/src/ex_getln.c Fri Dec 7 20:28:13 2007
--- src/ex_getln.c Wed Jan 2 21:42:51 2008
***
*** 335,341
quit_more = FALSE; /* reset after CTRL-D which had a more-prompt */
cursorcmd();/* set the cursor on the right spot */
! c = safe_vgetc();
if (KeyTyped)
{
some_key_typed = TRUE;
--- 335,348
quit_more = FALSE; /* reset after CTRL-D which had a more-prompt */
cursorcmd();/* set the cursor on the right spot */
!
! /* Get a character. Ignore K_IGNORE, it should not do anything, such
!* as stop completion. */
! do
! {
! c = safe_vgetc();
! } while (c == K_IGNORE);
!
if (KeyTyped)
{
some_key_typed = TRUE;
***
*** 1209,1215
goto cmdline_not_changed;
case K_IGNORE:
! goto cmdline_not_changed; /* Ignore mouse */
#ifdef FEAT_GUI_W32
/* On Win32 ignore M-F4, we get it when closing the window was
--- 1216,1223
goto cmdline_not_changed;
case K_IGNORE:
! /* Ignore mouse event or ex_window() result. */
! goto cmdline_not_changed;
#ifdef FEAT_GUI_W32
/* On Win32 ignore M-F4, we get it when closing the window was
*** ../vim-7.1.186/src/version.cWed Jan 2 21:07:32 2008
--- src/version.c Wed Jan 2 21:53:24 2008
***
*** 668,669
--- 668,671
{ /* Add new patch number below this line */
+ /**/
+ 187,
/**/
--
FATHER:Who are you?
PRINCE:I'm ... your son ...
FATHER:Not you.
LAUNCELOT: I'm ... er ... Sir Launcelot, sir.
Monty Python and the Holy Grail PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\download, build and distribute -- http://www.A-A-P.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--~--~-~--~~~---~--~~
You received this message from the vim_dev maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
Patch 7.1.188
Patch 7.1.188
Problem:When 'showmode' is off the message for changing a readonly file is
given in the second column instead of the first. (Payl B. Mahol)
Solution: Put the W10 message in the first column.
Files: src/edit.c
*** ../vim-7.1.187/src/edit.c Wed Jan 2 17:48:24 2008
--- src/edit.c Wed Jan 2 20:56:46 2008
***
*** 550,556
i = showmode();
if (!p_im did_restart_edit == 0)
! change_warning(i + 1);
#ifdef CURSOR_SHAPE
ui_cursor_shape();/* may show different cursor shape */
--- 550,556
i = showmode();
if (!p_im did_restart_edit == 0)
! change_warning(i == 0 ? 0 : i + 1);
#ifdef CURSOR_SHAPE
ui_cursor_shape();/* may show different cursor shape */
*** ../vim-7.1.187/src/version.cWed Jan 2 21:54:33 2008
--- src/version.c Wed Jan 2 22:06:19 2008
***
*** 668,669
--- 668,671
{ /* Add new patch number below this line */
+ /**/
+ 188,
/**/
--
PRINCE:He's come to rescue me, father.
LAUNCELOT: (embarrassed) Well, let's not jump to conclusions ...
Monty Python and the Holy Grail PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [EMAIL PROTECTED] -- http://www.Moolenaar.net \\\
///sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\download, build and distribute -- http://www.A-A-P.org///
\\\help me help AIDS victims -- http://ICCF-Holland.org///
--~--~-~--~~~---~--~~
You received this message from the vim_dev maillist.
For more information, visit http://www.vim.org/maillist.php
-~--~~~~--~~--~--~---
Re: Bug: Win32 guitabtooltip doesn't respect backslash-escaped special chars
Erik Falor wrote: While writing a guitabtooltip function, I discovered that the tooltips in Win32 don't properly handle backslash-escaped chars. In particular, '\n' comes out as a box, and '\t' appears to terminate the string like '\0'. The GTK gui on Linux, however, works as expected. I for one would be interested in knowing what actually is 'expected' in this circumstance. I personally think that's quite unclear and am not at all surprised there is a difference between platforms. I guess it's obvious that \n should be a newline. But should they be left justified? Or centered? Or...? If tabs are used, should they line up, given the proportional font? What width should they be? Etc.? Cheers, Ben. Send instant messages to your online friends http://au.messenger.yahoo.com --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Bug: Win32 guitabtooltip doesn't respect backslash-escaped special chars
Ben Schmidt wrote: Erik Falor wrote: While writing a guitabtooltip function, I discovered that the tooltips in Win32 don't properly handle backslash-escaped chars. In particular, '\n' comes out as a box, and '\t' appears to terminate the string like '\0'. The GTK gui on Linux, however, works as expected. I for one would be interested in knowing what actually is 'expected' in this circumstance. I personally think that's quite unclear and am not at all surprised there is a difference between platforms. I guess it's obvious that \n should be a newline. But should they be left justified? Or centered? Or...? If tabs are used, should they line up, given the proportional font? What width should they be? Etc.? Cheers, Ben. On Windows, where the OS-standard line break is \r\n, shouldn't _that_ also be used to break lines in a tooltip? And what about Mac? Best regards, Tony. -- hundred-and-one symptoms of being an internet addict: 204. You're being audited because you mailed your tax return to the IRC. --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Bug: Win32 guitabtooltip doesn't respect backslash-escaped special chars
Well, I suppose by 'works as expected' I meant that the string escapes didn't blow up :) What I think should be acceptable behavior is for the guitabtooltips to behave the same as the tooltips given by the balloon-eval feature. From debugger.txt line 103: The Balloon evaluation functions are also used to show a tooltip for the toolbar. Well, if the tooltips on the toolbar are supposed to use the same functions as ballooneval, then why not the guitab tooltips? I realize that the 'toolbar' option doesn't apply to Win32, and so the toolbar settings, including tooltips maybe don't, either. I'm sure there is a prefectly reasonable explanation for why they weren't implemented the same way on Windows. At any rate, it would be nice if the text displayed by 'guitabtooltip' was given the same treatment as 'balloonexpr' text. On 02/01/2008, Ben Schmidt [EMAIL PROTECTED] wrote: Erik Falor wrote: While writing a guitabtooltip function, I discovered that the tooltips in Win32 don't properly handle backslash-escaped chars. In particular, '\n' comes out as a box, and '\t' appears to terminate the string like '\0'. The GTK gui on Linux, however, works as expected. I for one would be interested in knowing what actually is 'expected' in this circumstance. I personally think that's quite unclear and am not at all surprised there is a difference between platforms. I guess it's obvious that \n should be a newline. But should they be left justified? Or centered? Or...? If tabs are used, should they line up, given the proportional font? What width should they be? Etc.? Cheers, Ben. Send instant messages to your online friends http://au.messenger.yahoo.com -- Registered Linux User #445632 http://counter.li.org --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Bug: Win32 guitabtooltip doesn't respect backslash-escaped special chars
On 02/01/2008, Tony Mechelynck [EMAIL PROTECTED] wrote: On Windows, where the OS-standard line break is \r\n, shouldn't _that_ also be used to break lines in a tooltip? And what about Mac? Best regards, Tony. \r\n results in two boxes. -- Registered Linux User #445632 http://counter.li.org --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
RE: Bug in FAQ at http://vimdoc.sourceforge.net/cgi-bin/vimfaq2html3.pl
Richard Hartmann wrote: http://vimdoc.sourceforge.net/cgi-bin/vimfaq2html3.pl at 32.1: -$ stty -ixon -xoff +$ stty -ixon -ixoff Three months ago Yegappan Lakshmanan asked me to put the FAQ on the Vim Tips wiki. He referred me to the txt and html versions: http://www.geocities.com/yegappan/vim_faq.txt http://vimdoc.sourceforge.net/htmldoc/vimfaq.html These are dated January 2005 and already have your correction (the document you found is dated January 2004). We started discussing moving the FAQ, but nothing has been done yet. I have just finished cleaning all imported tips from 1 to 1504, but have a few more housekeeping things to attend to. Then I am going to put the FAQ on the wiki (http://vim.wikia.com/wiki/Main_Page), and will invite comment at vim_use when ready. The intention is to split the FAQ into 37 wiki pages (one for each section), and have the community maintain the FAQ, rather than relying on one person. The disadvantage is that there won't be a single file that people can download to get the whole FAQ. John --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Bug: Win32 guitabtooltip doesn't respect backslash-escaped special chars
On 02/01/2008, ap [EMAIL PROTECTED] wrote: I think this information from 'h balloonexpr' applies. To check whether line breaks in the balloon text work use this check: if has(balloon_multiline) When they are supported \n characters will start a new line. I think there are no references in the docs, other than this one, about evaluating escape-sequences in tooltips. -ap FWIW, the Win32 build does have balloon_multiline. According to gui_w32.c, George V. Reilly was the original author of the Windows GUI code. Robert Webb later reworked much of it. However, the source file doesn't have Robert's email address. Does anybody know how to contact Mr. Webb? Have there been any other maintainers since Mr. Webb worked on it? Regards, Erik -- Registered Linux User #445632 http://counter.li.org --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
Re: Bug in FAQ at http://vimdoc.sourceforge.net/cgi-bin/vimfaq2html3.pl
Hi, On Jan 2, 2008 3:18 PM, John Beckett [EMAIL PROTECTED] wrote: Richard Hartmann wrote: http://vimdoc.sourceforge.net/cgi-bin/vimfaq2html3.pl at 32.1: -$ stty -ixon -xoff +$ stty -ixon -ixoff Three months ago Yegappan Lakshmanan asked me to put the FAQ on the Vim Tips wiki. He referred me to the txt and html versions: http://www.geocities.com/yegappan/vim_faq.txt http://vimdoc.sourceforge.net/htmldoc/vimfaq.html There used to be a cron job that periodically converted the text version of the FAQ to the HTML version and uploaded it to the Vim online site. I think that stopped working a few years ago. When I get some free time, I will upload the Vim FAQ to the new wiki site. - Yegappan These are dated January 2005 and already have your correction (the document you found is dated January 2004). We started discussing moving the FAQ, but nothing has been done yet. I have just finished cleaning all imported tips from 1 to 1504, but have a few more housekeeping things to attend to. Then I am going to put the FAQ on the wiki (http://vim.wikia.com/wiki/Main_Page), and will invite comment at vim_use when ready. The intention is to split the FAQ into 37 wiki pages (one for each section), and have the community maintain the FAQ, rather than relying on one person. The disadvantage is that there won't be a single file that people can download to get the whole FAQ. John --~--~-~--~~~---~--~~ You received this message from the vim_dev maillist. For more information, visit http://www.vim.org/maillist.php -~--~~~~--~~--~--~---
