Re: [warzone2100-dev] Proposed patches for tags/2.3.0

2010-04-24 Thread Christian Ohm
New one:
http://developer.wz2100.net/changeset/10694

Tested by pabs3, and I guess he'll include it in the Debian package if we don't
commit it.

___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev


Re: [warzone2100-dev] Proposed patches for tags/2.3.0

2010-04-23 Thread Per Inge Mathisen
A release candidate should either be dropped back into beta, or stay
in code freeze, which means nothing but build fixes, documentation
changes or translations go in. Let's maintain some self-discipline now
and ship this thing without further fixes. Then we can focus on making
2.3.1 and trunk great.

  - Per

___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev


Re: [warzone2100-dev] Proposed patches for tags/2.3.0

2010-04-23 Thread Stephen Swaney
On Fri, Apr 23, 2010 at 10:51:41AM +0200, Per Inge Mathisen wrote:
 A release candidate should either be dropped back into beta, or stay
 in code freeze, which means nothing but build fixes, documentation
 changes or translations go in. Let's maintain some self-discipline now
 and ship this thing without further fixes. Then we can focus on making
 2.3.1 and trunk great.

Yeah, what he said.  Code freeze, nothing but build fixes, doc changes
or translations.

I think all but one of us has had enough of the endless series of
betas.  It is not like this will be Last Release of WZ Ever.  The
sooner we do this one, the sooner we can do the next. Let's try to do
it right for once, just for the novelty of it.

S.
-- 
Stephen Swaney  
sswa...@centurytel.net


___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev


Re: [warzone2100-dev] Proposed patches for tags/2.3.0

2010-04-23 Thread Cyp
On Fri, Apr 23, 2010 at 1:12 PM, Stephen Swaney sswa...@centurytel.net wrote:
 On Fri, Apr 23, 2010 at 10:51:41AM +0200, Per Inge Mathisen wrote:
 A release candidate should either be dropped back into beta, or stay
 in code freeze, which means nothing but build fixes, documentation
 changes or translations go in. Let's maintain some self-discipline now
 and ship this thing without further fixes. Then we can focus on making
 2.3.1 and trunk great.

 Yeah, what he said.  Code freeze, nothing but build fixes, doc changes
 or translations.

 I think all but one of us has had enough of the endless series of
 betas.  It is not like this will be Last Release of WZ Ever.  The
 sooner we do this one, the sooner we can do the next. Let's try to do
 it right for once, just for the novelty of it.

I agree, apart from perhaps a quick newnet+qt+lua2+C++-rewrite
merge-backport, nothing should be committed to 2.3.0 other than build
fixes, doc changes, a final balance fix to make mg penetrating and
translations, and 2.3.0 should then be released as is and forgotten
about.

___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev


Re: [warzone2100-dev] Proposed patches for tags/2.3.0

2010-04-22 Thread buginator
On 4/22/10, Christian Ohm  wrote:
 On Sunday, 18 April 2010 at 13:21, buginator wrote:
   ** DO NOT COMMIT into tags/2.3.0 without ML or IRC approval ***

  Things we might possibly want to include in 2.3.0:

  http://developer.wz2100.net/changeset/10659 - fix compilation with gcc 4.5,
  only needed for debug compiles though.

  http://developer.wz2100.net/changeset/10681 - draw subtitles with shadows,
  improves readability.

  http://developer.wz2100.net/changeset/10682 - remove the allowSubtitles
  variable, which prevented the subtitle option from working.

  http://developer.wz2100.net/changeset/10683 - retry in windowed mode (could 
 be
  snipped after the first change in screen.c).

  None of those are really critical, just nice to have, but I think there's 
 very
  little risk in incuding them.


I more or less agree, however, I also have that nagging feeling back
in my head saying we shouldn't put anything else besides bug fixes at
this late stage.  I know I was for it when we first talked, but
thinking about it a bit more, makes we want to wait until 2.3.1.

If the others want these patches in 2.3.0, then I am fine with that as well.
I tested 10681, and it does make it more readable, the others, I
haven't really tested.

___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev


Re: [warzone2100-dev] Proposed patches for tags/2.3.0

2010-04-22 Thread Guangcong Luo
On Thu, Apr 22, 2010 at 10:25 PM, buginator buginato...@gmail.com wrote:
 I more or less agree, however, I also have that nagging feeling back
 in my head saying we shouldn't put anything else besides bug fixes at
 this late stage.  I know I was for it when we first talked, but
 thinking about it a bit more, makes we want to wait until 2.3.1.

Well, the patches cybersphinx posted _are_ bug fixes. I, personally,
want them in.

Also, the scoring problems should be fixed before release:
http://forums.wz2100.net/viewtopic.php?f=2t=5190

It's been reported repeatedly; I thought it was fixed by now.

-Zarel

___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev


Re: [warzone2100-dev] Proposed patches for tags/2.3.0

2010-04-22 Thread dak180
On Apr 22, 2010, at 6:17 PM, Christian Ohm wrote:

 Things we might possibly want to include in 2.3.0:

http://developer.wz2100.net/changeset/10690 - Distinguish between different 
types of .wz files

--
My Web Sites:
http://dak180.users.sourceforge.net/




smime.p7s
Description: S/MIME cryptographic signature
___
Warzone-dev mailing list
Warzone-dev@gna.org
https://mail.gna.org/listinfo/warzone-dev