[Wayland-bugs] [Bug 105974] double tap on touchpad isn't recognized as double click on ubuntu 18.04 bionic

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105974

--- Comment #6 from 1762...@trash-mail.com ---
you mean, i have to compile something in the kernel / lib?
sorry, that is way above my skills.
or are there a simple scripts and instructions i can use?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105974] double tap on touchpad isn't recognized as double click on ubuntu 18.04 bionic

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105974

Peter Hutterer  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|NOTOURBUG   |---

--- Comment #5 from Peter Hutterer  ---
huh, indeed, I misread the request, thanks. Yes, debouncing kicks in here
because the events are impossibly close together. So this is a libinput bug.


Have a look at commit 3a3fd645c4a78ff85e66327d51c4262292c5b09a, you need a
(new) LIBINPUT_MODEL_LOGITECH_K400 tag in the hwdb and its parsing, and that
flag checked in fallback_init_debounce(). Should be a fairly simple patch, any
chance you can work on it?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105974] double tap on touchpad isn't recognized as double click on ubuntu 18.04 bionic

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105974

--- Comment #4 from 1762...@trash-mail.com ---
watchinf the content of the evemu-record the only different between double-tap
on the touchpad and double-click on the mouse buttons i saw, is the timing.

double-tap is way faster than the double-click.

going back to ubuntu 18.04 daily-live is made sligktly slower double-tap on the
touchpad with the result, that some of the slower double-taps were recognized
as double-click.

is there somewhere a kind of "debouncung"-algorithm that let the double-tap
recognized as "bouncing" and is filtered out - so it is only seen as
single-click... ?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105974] double tap on touchpad isn't recognized as double click on ubuntu 18.04 bionic

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105974

Peter Hutterer  changed:

   What|Removed |Added

 Status|NEEDINFO|RESOLVED
 Resolution|--- |NOTOURBUG

--- Comment #3 from Peter Hutterer  ---
This device isn't recognised as touchpad by the kernel and just exposes a mouse
emulation interface. Which means all we see is relative motion and button
clicks, tapping is handled by the device's firmware.

The only solution there would be to switch the touchpad to actual touchpad mode
in the kernel. This requires knowing the magic sequence (if any exists), so far
we haven't been able to do that.

Either way, this is a kernel bug, once the touchpad appears like a normal
touchpad, libinput will work with it.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105974] double tap on touchpad isn't recognized as double click on ubuntu 18.04 bionic

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105974

--- Comment #2 from 1762...@trash-mail.com ---
Created attachment 138772
  --> https://bugs.freedesktop.org/attachment.cgi?id=138772=edit
evemu-record of device

here the evmu-record of the device i made under ubuntu 18.04 daily-live.

i made:
3x a double tap on the touchpad of the device (not recognized as double click),
2x a double click by mouse buttons below the touchpad of the device (recognized
as double click),
3x double tap on the touchpad again (not recognized as double click).

i tried to make as less movements as possible.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #22 from Peter Hutterer  ---
Comment on attachment 138751
  --> https://bugs.freedesktop.org/attachment.cgi?id=138751
fix duplicate flag value is evdev.h

Review of attachment 138751:
-

Pushed as dd6059aefc80cd540a133390a9068b4b890494bf, thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

Peter Hutterer  changed:

   What|Removed |Added

 Attachment #138751|0   |1
   is patch||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105974] double tap on touchpad isn't recognized as double click on ubuntu 18.04 bionic

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105974

Peter Hutterer  changed:

   What|Removed |Added

 CC||peter.hutte...@who-t.net
 Status|NEW |NEEDINFO

--- Comment #1 from Peter Hutterer  ---
Please attach an evemu-record of the device while doing a double-tap (one
that's not recognised), thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #21 from Tim Richardson  ---
Hi Peter, I confirm that I have no adverse side effects from the P50 rule
triggering the ignore non-touch events logic with the code I am using. Locally
I have gone back to exactly your udev rules including your p50 rule.

You will probably conclude to ignore my patches and re-apply the one you
reverted, so assuming that, I won't resubmit patches for this. That is, I
assume this is less work for you (and me). Thanks for your patience, I feel
that my future contributions will be much better thanks to your help. This is
the first C I have looked at in years. The barrier to entry is really low, you
have done awesome job making someone like me a contributor, even if not a very
good one just yet.


I have continued to do work on better P50 touchpad, see experimental patch. It
is dramatically better, building on the non-touch event rejection. 
One reason is the threshold for the application of part 3 of the acceleration
profile is about 250 mm/s movement, which is way too fast ... this is probably
a nominal figure, and it presumably makes sense of a lot of hardware I will
never see, yet is it terribly wrong for the P50. My changes go beyond this, I
have simplified the algorithm.

I'm really happy to have a much better laptop thanks to the past few days.
However, the big question for me is how do I submit hardware-specific changes?
There is a a separate acceleration profile and default values for the ThinkPad
X230 ... should I replicate this? It seems to me based on this experience that
we should actually expect quirks to include idiosyncratic magic values and
acceleration algorithms, but maybe the P50 is just an outlier.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 104990] XPS13 L322X touchpad laggy

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=104990

--- Comment #19 from Peter Hutterer  ---
Looks correct, thanks. Can you re-attach this as signed-off, git-formatted
patch? This way I can directly apply it and you get all the credit and glory
that comes with that ;)

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105923] The touchpad disable/enable functionality does not work by double tapping on the LED zone in the upper left corner

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105923

Peter Hutterer  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|NEEDINFO|RESOLVED

--- Comment #3 from Peter Hutterer  ---
hmm, so it comes down to: we can't merge this in libinput until we figure out
how the LED behaves. And that requires the kernel patch to be merged upstream.
Magically disabling the touchpad with no feedback to the user is not something
I want to do, I get enough angry emails already.

Also note that we've been slowly switching synaptics touchpads in the kernel to
SMBus/RMI4 where possible so that LED patch would likely have to work for that
too.

Closing this bug for now, please re-open when the kernel solution is in place.
The libinput bit isn't that hard to write.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #20 from Peter Hutterer  ---
Comment on attachment 138755
  --> https://bugs.freedesktop.org/attachment.cgi?id=138755
Patch to reapply the p50 rule & fix syntax error in existing rules

Review of attachment 138755:
-

As a general rule, please always separate logical steps within patches. Adding
a new device should not be combined with fixing another device - makes it hard
to separate the patches out for e.g. stable branches or regression testing. So
this patch would have to be two patches, one for the P50, one for the alleged
syntax error.

Alas, that 'syntax error' is intentional, these Lenovo series have an optional
suffix as well (T450, T450s, T450p, ...). They all have the same hardware, so
this rule catches all. It should arguably be a ? instead as there is only one
letter but the current rule works. The trailing : doesn't matter because all
modalias have a trailing ':'. So it doesn't quite match as you'd expect but it
does match :)

As for the P50 patch - this is the same as in bug 105022 now, right? That one
apparently made scrolling unworkable so I had to revert it upstream. Does this
patch have any effect on scrolling for you?

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

Peter Hutterer  changed:

   What|Removed |Added

 Attachment #138755|0   |1
   is patch||

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105896] Acceleration profile for trackpoint is reset upon connection of another Pointer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105896

Peter Hutterer  changed:

   What|Removed |Added

Product|Wayland |xorg
   Assignee|wayland-bugs@lists.freedesk |peter.hutte...@who-t.net
   |top.org |
 QA Contact||xorg-t...@lists.x.org
  Component|libinput|Input/libinput

--- Comment #6 from Peter Hutterer  ---
This line here indicates that it is the property that changed:

  Property 'libinput Accel Profile Enabled' changed.
  libinput Accel Profile Enabled (323):   1, 0

which means it's not a libinput bug but either a bug in the xf86-input-libinput
driver or a bug in the desktop environment. I don't know if KDE touches that
property tbh. To narrow this down, install xterm and run a plain X session
without KDE, just run xinit (note: you won't have a window manager running,
keep it that way please). Once you see the xterm, run the same watch-props
command, plug the mouse in and check the output. Same behaviour?

If so, this is a xf86-input-libinput driver bug, otherwise it's a KDE issue. Or
whatever else could possibly touch that property.

That X server wills shut down once the xterm instance exits.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105896] Acceleration profile for trackpoint is reset upon connection of another Pointer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105896

--- Comment #5 from Jacopo De Simoi  ---
On Thursday, April 5, 2018 10:04:49 PM EDT you wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=105896
> 
> Peter Hutterer  changed:
> 
>What|Removed |Added
> 
> CC||peter.hutte...@who-t.net Status|NEW
> |NEEDINFO
> 
> --- Comment #1 from Peter Hutterer  ---
> run xinput watch-props 'TPPS/2 IBM TrackPoint' please while plugging in the
> external mouse. Does the property change then?
> 
> Probabl not a libinput bug but either xf86-input-libinput or possibly GNOME
> overwriting the configuration. Please try xf86-input-libinput 0.27, it has a
> fix for erroneous property writes and that may just be the issue.
> 
> I'll also need your Xorg.log, just in case there's something interesting in
> there.
> 
> --
> You are receiving this mail because:
> You reported the bug.

Some updates: I tried connecting the mouse directly to the laptop to clean up 
the xorg log.  Unfortunately it died on me. Plugging in the usb connector now 
sends the kernel to panic.  

I will try to test with another external device.

In the meantime please let me know if the logs that I gave are sufficient or if 
you need more information

Best
 J

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105896] Acceleration profile for trackpoint is reset upon connection of another Pointer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105896

--- Comment #4 from Jacopo De Simoi  ---
Created attachment 138769
  --> https://bugs.freedesktop.org/attachment.cgi?id=138769=edit
xorg.log

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105896] Acceleration profile for trackpoint is reset upon connection of another Pointer

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105896

--- Comment #3 from Jacopo De Simoi  ---
Dear Peter, 

 I confirm that the change happens on docking the laptop. 

xinput watch-props 12
Device 'TPPS/2 IBM TrackPoint':
Device Enabled (143):   1
Coordinate Transformation Matrix (145): 1.00, 0.00, 0.00,
0.00, 1.00, 0.00, 0.00, 0.00, 1.00
libinput Natural Scrolling Enabled (311):   0
libinput Natural Scrolling Enabled Default (312):   0
libinput Scroll Methods Available (313):0, 0, 1
libinput Scroll Method Enabled (314):   0, 0, 1
libinput Scroll Method Enabled Default (315):   0, 0, 1
libinput Button Scrolling Button (316): 2
libinput Button Scrolling Button Default (317): 2
libinput Middle Emulation Enabled (318):0
libinput Middle Emulation Enabled Default (319):0
libinput Accel Speed (320): 1.00
libinput Accel Speed Default (321): 0.00
libinput Accel Profiles Available (322):1, 1
libinput Accel Profile Enabled (323):   0, 1
libinput Accel Profile Enabled Default (324):   1, 0
libinput Send Events Modes Available (327): 1, 0
libinput Send Events Mode Enabled (328):0, 0
libinput Send Events Mode Enabled Default (329):0, 0
Device Node (264):  "/dev/input/event16"
Device Product ID (263):2, 10
libinput Drag Lock Buttons (330):   
libinput Horizontal Scroll Enabled (331):   1
- Docking happens here 
Property 'libinput Natural Scrolling Enabled' changed.
libinput Natural Scrolling Enabled (311):   0
Property 'libinput Natural Scrolling Enabled' changed.
libinput Natural Scrolling Enabled (311):   0
Property 'libinput Accel Profile Enabled' changed.
libinput Accel Profile Enabled (323):   1, 0
Property 'libinput Accel Profile Enabled' changed.
libinput Accel Profile Enabled (323):   1, 0

xorg.log is attached as it is too long to fit here.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #19 from Tim Richardson  ---
(In reply to Tim Richardson from comment #17)

> 
>  if (speed_in < threshold) {
>   factor = 1;
> 
> rarely happens. 
> 
Sorry, tired. I mean the condition is nearly always true.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #18 from Tim Richardson  ---
Created attachment 138757
  --> https://bugs.freedesktop.org/attachment.cgi?id=138757=edit
experimental changes to touchpad_accel_profile

this is full of constants which probably only make sense on the P50, but it
makes a nice difference, plus it seems a bit simpler.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #17 from Tim Richardson  ---
in touchpad_accel_profile_linear the value of
const double threshold = accel_filter->threshold
is crucial.

For me, it is defaulting to 254
This speed is hardly reached; it represents very rapid motion on the P50. 

the threshold code is basically not of any practical use because the condition 

 if (speed_in < threshold) {
factor = 1;

rarely happens. 

I've attached an experimental idea which is working quite well on my P50.
the threshold now depends on filter->speed_adjustment

and the accel function is simplified

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #16 from Tim Richardson  ---
"Note that if you're using libinput debug-events or any other tools, the
context is *not* the one your X server has, it's always a new context and
changes don't go across. "

ah, that explains a lot, I was ready to sign up to a flat earth.

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

Tim Richardson  changed:

   What|Removed |Added

 Attachment #138744|0   |1
is obsolete||

--- Comment #15 from Tim Richardson  ---
Created attachment 138755
  --> https://bugs.freedesktop.org/attachment.cgi?id=138755=edit
Patch to reapply the p50 rule & fix syntax error in existing rules

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 101139] Acceleration still too fast with slow and slow-medium finger movements

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101139

--- Comment #46 from Tim Richardson  ---
sorry wrong bug report

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 101139] Acceleration still too fast with slow and slow-medium finger movements

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=101139

--- Comment #45 from Tim Richardson  ---

In 90-libinput-model-quirks.hwdb
the two current rules end with a colon
I don't know the syntax of this file, but there is no other example of this
pattern in the file

when I made a separate P50 rule, I did not use a colon at the end, and it
worked.

we do see :* at the end of a few rules. 



 libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPad??50*:
 libinput:name:SynPS/2 Synaptics TouchPad:dmi:*svnLENOVO:*:pvrThinkPad??60*:

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

[Wayland-bugs] [Bug 105963] Lenovo P50 - Slow fine touchpad movement makes it jump (bug 2)

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=105963

--- Comment #14 from Tim Richardson  ---
Created attachment 138751
  --> https://bugs.freedesktop.org/attachment.cgi?id=138751=edit
fix duplicate flag value is evdev.h

fix duplicate flag value is evdev.h

-- 
You are receiving this mail because:
You are the assignee for the bug.___
wayland-bugs mailing list
wayland-bugs@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs