[webkit-changes] [88781] trunk/LayoutTests

[tkent]

Title: [88781] trunk/LayoutTests








Revision 88781
Author tk...@chromium.org
Date 2011-06-13 23:44:09 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[Win] More rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

* platform/win/media/audio-repaint-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/media/audio-repaint-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88780 => 88781)

--- trunk/LayoutTests/ChangeLog	2011-06-14 06:31:18 UTC (rev 88780)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 06:44:09 UTC (rev 88781)
@@ -1,5 +1,12 @@
 2011-06-13  Kent Tamura  
 
+[Win] More rebaseline for r88757.
+https://bugs.webkit.org/show_bug.cgi?id=52920
+
+* platform/win/media/audio-repaint-expected.txt:
+
+2011-06-13  Kent Tamura  
+
 More Leopard and GTK rebaseline for r88757.
 https://bugs.webkit.org/show_bug.cgi?id=52920
 


Modified: trunk/LayoutTests/platform/win/media/audio-repaint-expected.txt (88780 => 88781)

--- trunk/LayoutTests/platform/win/media/audio-repaint-expected.txt	2011-06-14 06:31:18 UTC (rev 88780)
+++ trunk/LayoutTests/platform/win/media/audio-repaint-expected.txt	2011-06-14 06:44:09 UTC (rev 88781)
@@ -21,10 +21,14 @@
 RenderButton {INPUT} at (0,0) size 16x16
 RenderFlexibleBox {DIV} at (16,0) size 136x16
   RenderSlider {INPUT} at (0,0) size 136x16
-RenderBlock {DIV} at (63,4) size 10x8
+RenderFlexibleBox {DIV} at (2,0) size 132x16
+  RenderBlock {DIV} at (0,4) size 122x8
+  RenderBlock {DIV} at (122,4) size 10x8
 RenderButton {INPUT} at (152,0) size 16x16
 RenderButton {INPUT} at (168,0) size 16x16
 RenderButton {INPUT} at (184,0) size 16x16
+layer at (87,62) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
 layer at (8,42) size 200x16
   RenderBlock (relative positioned) {DIV} at (0,0) size 200x16
 layer at (8,42) size 200x16
@@ -32,10 +36,14 @@
 RenderButton {INPUT} at (0,0) size 16x16
 RenderFlexibleBox {DIV} at (16,0) size 136x16
   RenderSlider {INPUT} at (0,0) size 136x16
-RenderBlock {DIV} at (63,4) size 10x8
+RenderFlexibleBox {DIV} at (2,0) size 132x16
+  RenderBlock {DIV} at (0,4) size 122x8
+  RenderBlock {DIV} at (122,4) size 10x8
 RenderButton {INPUT} at (152,0) size 16x16
 RenderButton {INPUT} at (168,0) size 16x16
 RenderButton {INPUT} at (184,0) size 16x16
+layer at (87,46) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
 layer at (8,126) size 200x16
   RenderMedia {AUDIO} at (0,84) size 200x16
 layer at (8,126) size 200x16
@@ -45,7 +53,11 @@
 RenderButton {INPUT} at (0,0) size 16x16
 RenderFlexibleBox {DIV} at (16,0) size 136x16
   RenderSlider {INPUT} at (0,0) size 136x16
-RenderBlock {DIV} at (63,4) size 10x8
+RenderFlexibleBox {DIV} at (2,0) size 132x16
+  RenderBlock {DIV} at (0,4) size 122x8
+  RenderBlock {DIV} at (122,4) size 10x8
 RenderButton {INPUT} at (152,0) size 16x16
 RenderButton {INPUT} at (168,0) size 16x16
 RenderButton {INPUT} at (184,0) size 16x16
+layer at (87,130) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88780] trunk/Tools

[hayato]

Title: [88780] trunk/Tools








Revision 88780
Author hay...@chromium.org
Date 2011-06-13 23:31:18 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Hayato Ito  

Reviewed by Ojan Vafai.

[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
https://bugs.webkit.org/show_bug.cgi?id=59188

A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
WebKitDriver should always return an actual hash value if DRT returns that.

No tests since I'll add sample reftests to make sure mismatch reftests work later,
which should be in a separate patch.

* Scripts/webkitpy/layout_tests/port/webkit.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py




Diff

Modified: trunk/Tools/ChangeLog (88779 => 88780)

--- trunk/Tools/ChangeLog	2011-06-14 06:11:51 UTC (rev 88779)
+++ trunk/Tools/ChangeLog	2011-06-14 06:31:18 UTC (rev 88780)
@@ -1,3 +1,18 @@
+2011-06-13  Hayato Ito  
+
+Reviewed by Ojan Vafai.
+
+[NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
+https://bugs.webkit.org/show_bug.cgi?id=59188
+
+A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
+WebKitDriver should always return an actual hash value if DRT returns that.
+
+No tests since I'll add sample reftests to make sure mismatch reftests work later,
+which should be in a separate patch.
+
+* Scripts/webkitpy/layout_tests/port/webkit.py:
+
 2011-06-13  Kent Tamura  
 
 [Chromium-win] Fix two wrong assertions exposed by r88757.


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py (88779 => 88780)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2011-06-14 06:11:51 UTC (rev 88779)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/webkit.py	2011-06-14 06:31:18 UTC (rev 88780)
@@ -441,6 +441,8 @@
 if block.content and block.content_type == 'image/png':
 image = block.decoded_content
 actual_image_hash = block.content_hash
+elif block.content_hash:
+actual_image_hash = block.content_hash
 
 error_lines = self._server_process.error.splitlines()
 # FIXME: This is a hack.  It is unclear why sometimes






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88779] branches/chromium/782/Source/WebCore

[cevans]

Title: [88779] branches/chromium/782/Source/WebCore








Revision 88779
Author cev...@google.com
Date 2011-06-13 23:11:51 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 88139
BUG=84002
Review URL: http://codereview.chromium.org/7145023

Modified Paths

branches/chromium/782/Source/WebCore/platform/graphics/TextRun.h
branches/chromium/782/Source/WebCore/platform/graphics/WidthIterator.cpp
branches/chromium/782/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp
branches/chromium/782/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp




Diff

Modified: branches/chromium/782/Source/WebCore/platform/graphics/TextRun.h (88778 => 88779)

--- branches/chromium/782/Source/WebCore/platform/graphics/TextRun.h	2011-06-14 05:55:56 UTC (rev 88778)
+++ branches/chromium/782/Source/WebCore/platform/graphics/TextRun.h	2011-06-14 06:11:51 UTC (rev 88779)
@@ -78,8 +78,8 @@
 {
 }
 
-UChar operator[](int i) const { return m_characters[i]; }
-const UChar* data(int i) const { return &m_characters[i]; }
+UChar operator[](int i) const { ASSERT(i >= 0 && i < m_len); return m_characters[i]; }
+const UChar* data(int i) const { ASSERT(i >= 0 && i < m_len); return &m_characters[i]; }
 
 const UChar* characters() const { return m_characters; }
 int length() const { return m_len; }


Modified: branches/chromium/782/Source/WebCore/platform/graphics/WidthIterator.cpp (88778 => 88779)

--- branches/chromium/782/Source/WebCore/platform/graphics/WidthIterator.cpp	2011-06-14 05:55:56 UTC (rev 88778)
+++ branches/chromium/782/Source/WebCore/platform/graphics/WidthIterator.cpp	2011-06-14 06:11:51 UTC (rev 88779)
@@ -80,6 +80,9 @@
 offset = m_end;
 
 int currentCharacter = m_currentCharacter;
+if (currentCharacter >= offset)
+return;
+
 const UChar* cp = m_run.data(currentCharacter);
 
 bool rtl = m_run.rtl();


Modified: branches/chromium/782/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp (88778 => 88779)

--- branches/chromium/782/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp	2011-06-14 05:55:56 UTC (rev 88778)
+++ branches/chromium/782/Source/WebCore/platform/graphics/chromium/ComplexTextControllerLinux.cpp	2011-06-14 06:11:51 UTC (rev 88779)
@@ -367,7 +367,7 @@
 icu::UnicodeString normalizedString;
 UErrorCode error = U_ZERO_ERROR;
 
-for (int16_t i = 0; i < originalRun.length(); ++i) {
+for (int i = 0; i < originalRun.length(); ++i) {
 UChar ch = originalRun[i];
 if (::ublock_getCode(ch) == UBLOCK_COMBINING_DIACRITICAL_MARKS) {
 icu::Normalizer::normalize(icu::UnicodeString(originalRun.characters(),


Modified: branches/chromium/782/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp (88778 => 88779)

--- branches/chromium/782/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp	2011-06-14 05:55:56 UTC (rev 88778)
+++ branches/chromium/782/Source/WebCore/rendering/svg/SVGTextRunRenderingContext.cpp	2011-06-14 06:11:51 UTC (rev 88779)
@@ -114,7 +114,8 @@
 
 void walk(const TextRun& run, bool isVerticalText, const String& language, int from, int to)
 {
-ASSERT(0 <= from && from <= to && to - from <= run.length());
+if (from < 0 || to < 0 || from > to || from >= run.length() || to > run.length())
+return; 
 
 const String text = Font::normalizeSpaces(run.data(from), to - from);
 Vector chars(charactersWithArabicForm(text, run.rtl()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88777] trunk/LayoutTests

[tkent]

Title: [88777] trunk/LayoutTests








Revision 88777
Author tk...@chromium.org
Date 2011-06-13 22:42:57 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[Win] Rebaseline for r88757.
https://bugs.webkit.org/show_bug.cgi?id=52920

* platform/win/media/audio-controls-rendering-expected.txt:
* platform/win/media/controls-after-reload-expected.txt:
* platform/win/media/controls-strict-expected.txt:
* platform/win/media/controls-styling-expected.txt:
* platform/win/media/controls-without-preload-expected.txt:
* platform/win/media/media-document-audio-repaint-expected.txt:
* platform/win/media/video-controls-rendering-expected.txt:
* platform/win/media/video-display-toggle-expected.txt:
* platform/win/media/video-no-audio-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/media/audio-controls-rendering-expected.txt
trunk/LayoutTests/platform/win/media/controls-after-reload-expected.txt
trunk/LayoutTests/platform/win/media/controls-strict-expected.txt
trunk/LayoutTests/platform/win/media/controls-styling-expected.txt
trunk/LayoutTests/platform/win/media/controls-without-preload-expected.txt
trunk/LayoutTests/platform/win/media/media-document-audio-repaint-expected.txt
trunk/LayoutTests/platform/win/media/video-controls-rendering-expected.txt
trunk/LayoutTests/platform/win/media/video-display-toggle-expected.txt
trunk/LayoutTests/platform/win/media/video-no-audio-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88776 => 88777)

--- trunk/LayoutTests/ChangeLog	2011-06-14 05:34:52 UTC (rev 88776)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 05:42:57 UTC (rev 88777)
@@ -1,5 +1,20 @@
 2011-06-13  Kent Tamura  
 
+[Win] Rebaseline for r88757.
+https://bugs.webkit.org/show_bug.cgi?id=52920
+
+* platform/win/media/audio-controls-rendering-expected.txt:
+* platform/win/media/controls-after-reload-expected.txt:
+* platform/win/media/controls-strict-expected.txt:
+* platform/win/media/controls-styling-expected.txt:
+* platform/win/media/controls-without-preload-expected.txt:
+* platform/win/media/media-document-audio-repaint-expected.txt:
+* platform/win/media/video-controls-rendering-expected.txt:
+* platform/win/media/video-display-toggle-expected.txt:
+* platform/win/media/video-no-audio-expected.txt:
+
+2011-06-13  Kent Tamura  
+
 [GTK] Rebaseline for r88757.
 
 * platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:


Modified: trunk/LayoutTests/platform/win/media/audio-controls-rendering-expected.txt (88776 => 88777)

--- trunk/LayoutTests/platform/win/media/audio-controls-rendering-expected.txt	2011-06-14 05:34:52 UTC (rev 88776)
+++ trunk/LayoutTests/platform/win/media/audio-controls-rendering-expected.txt	2011-06-14 05:42:57 UTC (rev 88777)
@@ -21,10 +21,14 @@
 RenderButton {INPUT} at (0,0) size 16x16
 RenderFlexibleBox {DIV} at (16,0) size 136x16
   RenderSlider {INPUT} at (0,0) size 136x16
-RenderBlock {DIV} at (2,4) size 10x8
+RenderFlexibleBox {DIV} at (2,0) size 132x16
+  RenderBlock {DIV} at (0,4) size 122x8
+  RenderBlock {DIV} at (122,4) size 10x8
 RenderButton {INPUT} at (152,0) size 16x16
 RenderButton {INPUT} at (168,0) size 16x16
 RenderButton {INPUT} at (184,0) size 16x16
+layer at (26,46) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
 layer at (8,76) size 320x16
   RenderBlock (relative positioned) {DIV} at (0,0) size 320x16
 layer at (8,76) size 320x16
@@ -32,10 +36,14 @@
 RenderButton {INPUT} at (0,0) size 16x16
 RenderFlexibleBox {DIV} at (16,0) size 256x16
   RenderSlider {INPUT} at (0,0) size 256x16
-RenderBlock {DIV} at (2,4) size 10x8
+RenderFlexibleBox {DIV} at (2,0) size 252x16
+  RenderBlock {DIV} at (0,4) size 242x8
+  RenderBlock {DIV} at (242,4) size 10x8
 RenderButton {INPUT} at (272,0) size 16x16
 RenderButton {INPUT} at (288,0) size 16x16
 RenderButton {INPUT} at (304,0) size 16x16
+layer at (26,80) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
 layer at (8,110) size 320x100
   RenderMedia {AUDIO} at (8,110) size 320x100 [bgcolor=#FF]
 layer at (8,110) size 320x100
@@ -45,7 +53,11 @@
 RenderButton {INPUT} at (0,0) size 16x16
 RenderFlexibleBox {DIV} at (16,0) size 256x16
   RenderSlider {INPUT} at (0,0) size 256x16
-RenderBlock {DIV} at (2,4) size 10x8
+RenderFlexibleBox {DIV} at (2,0) size 252x16
+  RenderBlock {DIV} at (0,4) size 242x8
+  RenderBlock {DIV} at (242,4) size 10x8
 RenderButton {INPUT} at (272,0) size 16x16
 RenderButton {INPUT} at (288,0) size 16x16
 RenderButton {INPUT} at (304,0) size 16x16
+layer at (26,198) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) si

[webkit-changes] [88776] branches/chromium/742

[cevans]

Title: [88776] branches/chromium/742








Revision 88776
Author cev...@google.com
Date 2011-06-13 22:34:52 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145022

Modified Paths

branches/chromium/742/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
branches/chromium/742/Source/WebCore/rendering/RenderTextControl.cpp
branches/chromium/742/Source/WebCore/rendering/RenderTextControl.h


Added Paths

branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash-expected.txt
branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash.html




Diff

Copied: branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash-expected.txt (from rev 88456, trunk/LayoutTests/fast/forms/text-control-selection-crash-expected.txt) (0 => 88776)

--- branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash-expected.txt	(rev 0)
+++ branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash-expected.txt	2011-06-14 05:34:52 UTC (rev 88776)
@@ -0,0 +1 @@
+Test passes if it does not crash. 


Copied: branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash.html (from rev 88456, trunk/LayoutTests/fast/forms/text-control-selection-crash.html) (0 => 88776)

--- branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash.html	(rev 0)
+++ branches/chromium/742/LayoutTests/fast/forms/text-control-selection-crash.html	2011-06-14 05:34:52 UTC (rev 88776)
@@ -0,0 +1,14 @@
+
+
+Test passes if it does not crash.
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+A.selectionStart = 0;
+B.style.display = "none";
+B.selectionStart = 0;
+
+


Modified: branches/chromium/742/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (88775 => 88776)

--- branches/chromium/742/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-06-14 05:25:21 UTC (rev 88775)
+++ branches/chromium/742/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-06-14 05:34:52 UTC (rev 88776)
@@ -2490,7 +2490,7 @@
 int AccessibilityRenderObject::indexForVisiblePosition(const VisiblePosition& pos) const
 {
 if (isNativeTextControl())
-return toRenderTextControl(m_renderer)->indexForVisiblePosition(pos);
+return RenderTextControl::indexForVisiblePosition(toRenderTextControl(m_renderer)->innerTextElement(), pos);
 
 if (!isTextControl())
 return 0;


Modified: branches/chromium/742/Source/WebCore/rendering/RenderTextControl.cpp (88775 => 88776)

--- branches/chromium/742/Source/WebCore/rendering/RenderTextControl.cpp	2011-06-14 05:25:21 UTC (rev 88775)
+++ branches/chromium/742/Source/WebCore/rendering/RenderTextControl.cpp	2011-06-14 05:34:52 UTC (rev 88776)
@@ -205,7 +205,12 @@
 Frame* frame = this->frame();
 if (!frame)
 return 0;
-return indexForVisiblePosition(frame->selection()->start());
+
+HTMLElement* innerText = innerTextElement();
+// Do not call innerTextElement() in the function arguments as creating a VisiblePosition
+// from frame->selection->start() can blow us from underneath. Also, function ordering is
+// usually dependent on the compiler.
+return RenderTextControl::indexForVisiblePosition(innerText, frame->selection()->start());
 }
 
 int RenderTextControl::selectionEnd() const
@@ -213,7 +218,12 @@
 Frame* frame = this->frame();
 if (!frame)
 return 0;
-return indexForVisiblePosition(frame->selection()->end());
+
+HTMLElement* innerText = innerTextElement();
+// Do not call innerTextElement() in the function arguments as creating a VisiblePosition
+// from frame->selection->end() can blow us from underneath. Also, function ordering is
+// usually dependent on the compiler.
+return RenderTextControl::indexForVisiblePosition(innerText, frame->selection()->end());
 }
 
 bool RenderTextControl::hasVisibleTextArea() const
@@ -256,15 +266,15 @@
 frame->selection()->setSelection(newSelection);
 }
 
-bool RenderTextControl::isSelectableElement(Node* node) const
+bool RenderTextControl::isSelectableElement(HTMLElement* innerText, Node* node)
 {
-if (!node || !m_innerText)
+if (!node || !innerText)
 return false;
-
-if (node->rootEditableElement() == m_innerText)
+
+if (node->rootEditableElement() == innerText)
 return true;
 
-if (!m_innerText->contains(node))
+if (!innerText->contains(node))
 return false;
 
 Node* shadowAncestor = node->shadowAncestorNode();
@@ -334,14 +344,14 @@
 return VisiblePosition(Position(endContainer, endOffset, Position::PositionIsOffsetInAnchor), UPSTREAM);
 }
 
-int RenderTextControl::indexForVisiblePosition(const VisiblePosition& pos) const
+int RenderTextControl::indexForVisiblePosition(HTMLElement* innerTextElement, const VisiblePosition& pos)
 {
 Position indexPositio

[webkit-changes] [88775] trunk/Tools

[tkent]

Title: [88775] trunk/Tools








Revision 88775
Author tk...@chromium.org
Date 2011-06-13 22:25:21 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[Chromium-win] Fix two wrong assertions exposed by r88757.

* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
(WebThemeEngineDRTWin::paintTrackbar):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp




Diff

Modified: trunk/Tools/ChangeLog (88774 => 88775)

--- trunk/Tools/ChangeLog	2011-06-14 05:19:38 UTC (rev 88774)
+++ trunk/Tools/ChangeLog	2011-06-14 05:25:21 UTC (rev 88775)
@@ -1,3 +1,10 @@
+2011-06-13  Kent Tamura  
+
+[Chromium-win] Fix two wrong assertions exposed by r88757.
+
+* DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
+(WebThemeEngineDRTWin::paintTrackbar):
+
 2011-06-13  Alexey Proskuryakov  
 
 Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete


Modified: trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp (88774 => 88775)

--- trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp	2011-06-14 05:19:38 UTC (rev 88774)
+++ trunk/Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp	2011-06-14 05:25:21 UTC (rev 88775)
@@ -758,12 +758,12 @@
 }
 } else if (TKP_TRACK == part) {
 ctype = WebThemeControlDRTWin::HorizontalSliderTrackType;
-ASSERT(part == TUS_NORMAL);
+ASSERT(state == TRS_NORMAL);
 ASSERT(classicState == dfcsNormal);
 cstate = WebThemeControlDRTWin::NormalState;
 } else if (TKP_TRACKVERT == part) {
 ctype = WebThemeControlDRTWin::VerticalSliderTrackType;
-ASSERT(part == TUS_NORMAL);
+ASSERT(state == TRVS_NORMAL);
 ASSERT(classicState == dfcsNormal);
 cstate = WebThemeControlDRTWin::NormalState;
 } else






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88774] branches/chromium/782

[cevans]

Title: [88774] branches/chromium/782








Revision 88774
Author cev...@google.com
Date 2011-06-13 22:19:38 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 88456
BUG=85418
Review URL: http://codereview.chromium.org/7145021

Modified Paths

branches/chromium/782/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
branches/chromium/782/Source/WebCore/rendering/RenderTextControl.cpp
branches/chromium/782/Source/WebCore/rendering/RenderTextControl.h


Added Paths

branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash-expected.txt
branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash.html




Diff

Copied: branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash-expected.txt (from rev 88456, trunk/LayoutTests/fast/forms/text-control-selection-crash-expected.txt) (0 => 88774)

--- branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash-expected.txt	(rev 0)
+++ branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash-expected.txt	2011-06-14 05:19:38 UTC (rev 88774)
@@ -0,0 +1 @@
+Test passes if it does not crash. 


Copied: branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash.html (from rev 88456, trunk/LayoutTests/fast/forms/text-control-selection-crash.html) (0 => 88774)

--- branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash.html	(rev 0)
+++ branches/chromium/782/LayoutTests/fast/forms/text-control-selection-crash.html	2011-06-14 05:19:38 UTC (rev 88774)
@@ -0,0 +1,14 @@
+
+
+Test passes if it does not crash.
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+A.selectionStart = 0;
+B.style.display = "none";
+B.selectionStart = 0;
+
+


Modified: branches/chromium/782/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (88773 => 88774)

--- branches/chromium/782/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-06-14 05:15:25 UTC (rev 88773)
+++ branches/chromium/782/Source/WebCore/accessibility/AccessibilityRenderObject.cpp	2011-06-14 05:19:38 UTC (rev 88774)
@@ -2499,7 +2499,7 @@
 int AccessibilityRenderObject::indexForVisiblePosition(const VisiblePosition& pos) const
 {
 if (isNativeTextControl())
-return toRenderTextControl(m_renderer)->indexForVisiblePosition(pos);
+return RenderTextControl::indexForVisiblePosition(toRenderTextControl(m_renderer)->innerTextElement(), pos);
 
 if (!isTextControl())
 return 0;


Modified: branches/chromium/782/Source/WebCore/rendering/RenderTextControl.cpp (88773 => 88774)

--- branches/chromium/782/Source/WebCore/rendering/RenderTextControl.cpp	2011-06-14 05:15:25 UTC (rev 88773)
+++ branches/chromium/782/Source/WebCore/rendering/RenderTextControl.cpp	2011-06-14 05:19:38 UTC (rev 88774)
@@ -177,7 +177,12 @@
 Frame* frame = this->frame();
 if (!frame)
 return 0;
-return indexForVisiblePosition(frame->selection()->start());
+
+HTMLElement* innerText = innerTextElement();
+// Do not call innerTextElement() in the function arguments as creating a VisiblePosition
+// from frame->selection->start() can blow us from underneath. Also, function ordering is
+// usually dependent on the compiler.
+return RenderTextControl::indexForVisiblePosition(innerText, frame->selection()->start());
 }
 
 int RenderTextControl::selectionEnd() const
@@ -185,7 +190,12 @@
 Frame* frame = this->frame();
 if (!frame)
 return 0;
-return indexForVisiblePosition(frame->selection()->end());
+
+HTMLElement* innerText = innerTextElement();
+// Do not call innerTextElement() in the function arguments as creating a VisiblePosition
+// from frame->selection->end() can blow us from underneath. Also, function ordering is
+// usually dependent on the compiler.
+return RenderTextControl::indexForVisiblePosition(innerText, frame->selection()->end());
 }
 
 bool RenderTextControl::hasVisibleTextArea() const
@@ -229,15 +239,11 @@
 frame->selection()->setSelection(newSelection);
 }
 
-bool RenderTextControl::isSelectableElement(Node* node) const
+bool RenderTextControl::isSelectableElement(HTMLElement* innerText, Node* node)
 {
-if (!node)
+if (!node || !innerText)
 return false;
 
-HTMLElement* innerText = innerTextElement();
-if (!innerText)
-return false;
-
 if (node->rootEditableElement() == innerText)
 return true;
 
@@ -312,14 +318,14 @@
 return VisiblePosition(Position(endContainer, endOffset, Position::PositionIsOffsetInAnchor), UPSTREAM);
 }
 
-int RenderTextControl::indexForVisiblePosition(const VisiblePosition& pos) const
+int RenderTextControl::indexForVisiblePosition(HTMLElement* innerTextElement, const VisiblePosition& pos)
 {
 Position indexPosition = pos.deepEquivalent();
-if (!isSelectableElement(indexPosition.deprecatedNode()))
+if (!RenderTextControl::isSelectableElemen

[webkit-changes] [88773] trunk/LayoutTests

[tkent]

Title: [88773] trunk/LayoutTests








Revision 88773
Author tk...@chromium.org
Date 2011-06-13 22:15:25 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[GTK] Rebaseline for r88757.

* platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
* platform/gtk/fast/forms/slider-padding-expected.txt:
* platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
* platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
* platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
* platform/gtk/fast/layers/video-layer-expected.txt:
* platform/gtk/fast/multicol/client-rects-expected.txt:
* platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/audio-repaint-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/controls-without-preload-expected.txt:
* platform/gtk/media/media-document-audio-repaint-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-zoom-controls-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/box-shadow-override-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/input-appearance-height-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/slider-padding-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/slider-thumb-stylability-expected.txt
trunk/LayoutTests/platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt
trunk/LayoutTests/platform/gtk/fast/layers/video-layer-expected.txt
trunk/LayoutTests/platform/gtk/fast/multicol/client-rects-expected.txt
trunk/LayoutTests/platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt
trunk/LayoutTests/platform/gtk/media/audio-controls-rendering-expected.txt
trunk/LayoutTests/platform/gtk/media/audio-repaint-expected.txt
trunk/LayoutTests/platform/gtk/media/controls-strict-expected.txt
trunk/LayoutTests/platform/gtk/media/controls-styling-expected.txt
trunk/LayoutTests/platform/gtk/media/controls-without-preload-expected.txt
trunk/LayoutTests/platform/gtk/media/media-document-audio-repaint-expected.txt
trunk/LayoutTests/platform/gtk/media/video-controls-rendering-expected.txt
trunk/LayoutTests/platform/gtk/media/video-empty-source-expected.txt
trunk/LayoutTests/platform/gtk/media/video-no-audio-expected.txt
trunk/LayoutTests/platform/gtk/media/video-zoom-controls-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88772 => 88773)

--- trunk/LayoutTests/ChangeLog	2011-06-14 05:07:08 UTC (rev 88772)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 05:15:25 UTC (rev 88773)
@@ -1,3 +1,29 @@
+2011-06-13  Kent Tamura  
+
+[GTK] Rebaseline for r88757.
+
+* platform/gtk/fast/dom/HTMLInputElement/input-slider-update-expected.txt:
+* platform/gtk/fast/forms/box-shadow-override-expected.txt:
+* platform/gtk/fast/forms/input-appearance-height-expected.txt:
+* platform/gtk/fast/forms/range-thumb-height-percentage-expected.txt:
+* platform/gtk/fast/forms/slider-padding-expected.txt:
+* platform/gtk/fast/forms/slider-thumb-shared-style-expected.txt:
+* platform/gtk/fast/forms/slider-thumb-stylability-expected.txt:
+* platform/gtk/fast/forms/thumbslider-no-parent-slider-expected.txt:
+* platform/gtk/fast/layers/video-layer-expected.txt:
+* platform/gtk/fast/multicol/client-rects-expected.txt:
+* platform/gtk/fast/repaint/slider-thumb-drag-release-expected.txt:
+* platform/gtk/media/audio-controls-rendering-expected.txt:
+* platform/gtk/media/audio-repaint-expected.txt:
+* platform/gtk/media/controls-strict-expected.txt:
+* platform/gtk/media/controls-styling-expected.txt:
+* platform/gtk/media/controls-without-preload-expected.txt:
+* platform/gtk/media/media-document-audio-repaint-expected.txt:
+* platform/gtk/media/video-controls-rendering-expected.txt:
+* platform/gtk/media/video-empty-source-expected.txt:
+* platform/gtk/media/video-no-audio-expected.txt:
+* platform/gtk/media/video-zoom-controls-expected.txt:
+
 2011-06-13  

[webkit-changes] [88772] trunk/LayoutTests

[commit-queue]

Title: [88772] trunk/LayoutTests








Revision 88772
Author commit-qu...@webkit.org
Date 2011-06-13 22:07:08 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Igor Oliveira  

Reviewed by Eric Seidel.

[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
https://bugs.webkit.org/show_bug.cgi?id=62125

Rebaseline LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt after r69386 and r83871

* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88771 => 88772)

--- trunk/LayoutTests/ChangeLog	2011-06-14 05:02:58 UTC (rev 88771)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 05:07:08 UTC (rev 88772)
@@ -1,3 +1,15 @@
+2011-06-13  Igor Oliveira  
+
+Reviewed by Eric Seidel.
+
+[Qt] Rebaseline http/tests/misc/slow-loading-image-in-pattern.html after r69386 and r83871
+https://bugs.webkit.org/show_bug.cgi?id=62125
+
+
+Rebaseline LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt after r69386 and r83871
+
+* platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt:
+
 2011-06-13  Laszlo Gombos  
 
 Reviewed by Eric Seidel.


Modified: trunk/LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt (88771 => 88772)

--- trunk/LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt	2011-06-14 05:02:58 UTC (rev 88771)
+++ trunk/LayoutTests/platform/qt/http/tests/misc/slow-loading-image-in-pattern-expected.txt	2011-06-14 05:07:08 UTC (rev 88772)
@@ -1,13 +1,13 @@
 layer at (0,0) size 800x600
   RenderView at (0,0) size 800x600
-layer at (0,0) size 800x58
-  RenderBlock {HTML} at (0,0) size 800x58
-RenderBody {BODY} at (8,8) size 784x42
-  RenderText {#text} at (0,0) size 668x21
+layer at (0,0) size 800x60
+  RenderBlock {HTML} at (0,0) size 800x60
+RenderBody {BODY} at (8,8) size 784x44
+  RenderText {#text} at (0,0) size 668x22
 text run at (0,0) width 668: "This tests slow loading png images referenced from a image element inside a SVG pattern resource."
-  RenderBR {BR} at (668,0) size 0x21
-  RenderText {#text} at (0,21) size 596x21
-text run at (0,21) width 596: "You should see a 400x300 rect containing a tiled rendering of the Acid3 reference image."
+  RenderBR {BR} at (668,0) size 0x22
+  RenderText {#text} at (0,22) size 596x22
+text run at (0,22) width 596: "You should see a 400x300 rect containing a tiled rendering of the Acid3 reference image."
   RenderText {#text} at (0,0) size 0x0
   RenderText {#text} at (0,0) size 0x0
 layer at (10,50) size 406x306
@@ -15,4 +15,4 @@
 RenderSVGHiddenContainer {defs} at (0,0) size 0x0
   RenderSVGResourcePattern {pattern} [id="pattern"] [patternUnits=userSpaceOnUse] [patternContentUnits=userSpaceOnUse]
 RenderSVGImage {image} at (13,53) size 403x303
-RenderSVGPath {rect} at (13,53) size 400x300 [fill={[type=PATTERN] [id="pattern"]}] [data="" L400.00,0.00 L400.00,300.00 L0.00,300.00 L0.00,0.00"]
+RenderSVGPath {rect} at (13,53) size 400x300 [fill={[type=PATTERN] [id="pattern"]}] [x=0.00] [y=0.00] [width=400.00] [height=300.00]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88771] trunk/LayoutTests

[laszlo . 1 . gombos]

Title: [88771] trunk/LayoutTests








Revision 88771
Author laszlo.1.gom...@nokia.com
Date 2011-06-13 22:02:58 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Laszlo Gombos  

Reviewed by Eric Seidel.

[Qt] Pass prototype-inheritance-2.html LayoutTest
https://bugs.webkit.org/show_bug.cgi?id=62224

Fix the expected result and remove the test from the Skipped list.

* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/qt/Skipped


Added Paths

trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88770 => 88771)

--- trunk/LayoutTests/ChangeLog	2011-06-14 05:00:07 UTC (rev 88770)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 05:02:58 UTC (rev 88771)
@@ -1,3 +1,15 @@
+2011-06-13  Laszlo Gombos  
+
+Reviewed by Eric Seidel.
+
+[Qt] Pass prototype-inheritance-2.html LayoutTest
+https://bugs.webkit.org/show_bug.cgi?id=62224
+
+Fix the expected result and remove the test from the Skipped list.
+
+* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
+* platform/qt/Skipped:
+
 2011-06-13  Kent Tamura  
 
 [Mac] Leopard expectation files for r88757.


Modified: trunk/LayoutTests/platform/qt/Skipped (88770 => 88771)

--- trunk/LayoutTests/platform/qt/Skipped	2011-06-14 05:00:07 UTC (rev 88770)
+++ trunk/LayoutTests/platform/qt/Skipped	2011-06-14 05:02:58 UTC (rev 88771)
@@ -1240,7 +1240,6 @@
 # Final four tests before Qt buildbot is green
 # https://bugs.webkit.org/show_bug.cgi?id=27914
 fast/css/positioned-overflow-scroll.html
-fast/dom/prototype-inheritance-2.html
 # This port doesn't support detecting slow unload handlers.
 fast/dom/Window/slow-unload-handler.html
 fast/dom/Window/slow-unload-handler-only-frame-is-stopped.html


Added: trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt (0 => 88771)

--- trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/qt/fast/dom/prototype-inheritance-2-expected.txt	2011-06-14 05:02:58 UTC (rev 88771)
@@ -0,0 +1,449 @@
+Make sure prototypes are set up using the window a property came from, instead of the lexical global object.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS Array from inner.document.forms.testForm.0.ownerDocument.defaultView.console.profiles
+PASS Attr from inner.document.forms.testForm.0.attributes.0
+PASS AttrConstructor from inner.document.forms.testForm.0.attributes.0.constructor
+PASS AttrPrototype from inner.document.forms.testForm.0.attributes.0.__proto__
+PASS BarInfo from inner.document.forms.testForm.0.ownerDocument.defaultView.menubar
+PASS BarInfoPrototype from inner.document.forms.testForm.0.ownerDocument.defaultView.menubar.__proto__
+PASS CSSCharsetRule from inner.document.getElementById("dummyStyle").sheet.cssRules.0
+PASS CSSCharsetRuleConstructor from inner.document.getElementById("dummyStyle").sheet.cssRules.0.constructor
+PASS CSSCharsetRulePrototype from inner.document.getElementById("dummyStyle").sheet.cssRules.0.__proto__
+PASS CSSFontFaceRule from inner.document.getElementById("dummyStyle").sheet.cssRules.4
+PASS CSSFontFaceRuleConstructor from inner.document.getElementById("dummyStyle").sheet.cssRules.4.constructor
+PASS CSSFontFaceRulePrototype from inner.document.getElementById("dummyStyle").sheet.cssRules.4.__proto__
+PASS CSSImportRule from inner.document.getElementById("dummyStyle").sheet.cssRules.1
+PASS CSSImportRuleConstructor from inner.document.getElementById("dummyStyle").sheet.cssRules.1.constructor
+PASS CSSImportRulePrototype from inner.document.getElementById("dummyStyle").sheet.cssRules.1.__proto__
+PASS CSSMediaRule from inner.document.getElementById("dummyStyle").sheet.cssRules.3
+PASS CSSMediaRuleConstructor from inner.document.getElementById("dummyStyle").sheet.cssRules.3.constructor
+PASS CSSMediaRulePrototype from inner.document.getElementById("dummyStyle").sheet.cssRules.3.__proto__
+PASS CSSPageRule from inner.document.getElementById("dummyStyle").sheet.cssRules.2
+PASS CSSPageRuleConstructor from inner.document.getElementById("dummyStyle").sheet.cssRules.2.constructor
+PASS CSSPageRulePrototype from inner.document.getElementById("dummyStyle").sheet.cssRules.2.__proto__
+PASS CSSPrimitiveValue from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(background-clip)
+PASS CSSPrimitiveValueConstructor from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(background-clip).constructor
+PASS CSSPrimitiveValuePrototype from inner.getComputedStyle(inner.document.body).getPropertyCSSValue(background-clip).__proto__
+PASS CSSRuleList from inner.document.getElementById("dummyStyle").sheet.cssRules
+PASS CSSRuleListConstructor from inner.document.forms.tes

[webkit-changes] [88770] trunk/LayoutTests

[tkent]

Title: [88770] trunk/LayoutTests








Revision 88770
Author tk...@chromium.org
Date 2011-06-13 22:00:07 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[Mac] Leopard expectation files for r88757.

* platform/mac-leopard/media/controls-after-reload-expected.txt:
* platform/mac-leopard/media/controls-strict-expected.txt:
* platform/mac-leopard/media/controls-styling-expected.txt:
* platform/mac-leopard/media/controls-without-preload-expected.txt:
* platform/mac-leopard/media/video-controls-rendering-expected.txt:
* platform/mac-leopard/media/video-display-toggle-expected.txt:
* platform/mac-leopard/media/video-no-audio-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-leopard/media/controls-after-reload-expected.txt
trunk/LayoutTests/platform/mac-leopard/media/controls-strict-expected.txt
trunk/LayoutTests/platform/mac-leopard/media/controls-styling-expected.txt
trunk/LayoutTests/platform/mac-leopard/media/controls-without-preload-expected.txt
trunk/LayoutTests/platform/mac-leopard/media/video-controls-rendering-expected.txt
trunk/LayoutTests/platform/mac-leopard/media/video-display-toggle-expected.txt
trunk/LayoutTests/platform/mac-leopard/media/video-no-audio-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88769 => 88770)

--- trunk/LayoutTests/ChangeLog	2011-06-14 04:53:00 UTC (rev 88769)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 05:00:07 UTC (rev 88770)
@@ -1,5 +1,17 @@
 2011-06-13  Kent Tamura  
 
+[Mac] Leopard expectation files for r88757.
+
+* platform/mac-leopard/media/controls-after-reload-expected.txt:
+* platform/mac-leopard/media/controls-strict-expected.txt:
+* platform/mac-leopard/media/controls-styling-expected.txt:
+* platform/mac-leopard/media/controls-without-preload-expected.txt:
+* platform/mac-leopard/media/video-controls-rendering-expected.txt:
+* platform/mac-leopard/media/video-display-toggle-expected.txt:
+* platform/mac-leopard/media/video-no-audio-expected.txt:
+
+2011-06-13  Kent Tamura  
+
 [Mac] Rebaseline for r88757.
 
 * media/audio-repaint-expected.txt:


Modified: trunk/LayoutTests/platform/mac-leopard/media/controls-after-reload-expected.txt (88769 => 88770)

--- trunk/LayoutTests/platform/mac-leopard/media/controls-after-reload-expected.txt	2011-06-14 04:53:00 UTC (rev 88769)
+++ trunk/LayoutTests/platform/mac-leopard/media/controls-after-reload-expected.txt	2011-06-14 05:00:07 UTC (rev 88770)
@@ -18,7 +18,9 @@
 RenderButton {INPUT} at (32,4) size 16x16
 RenderFlexibleBox {DIV} at (49,5) size 246x15
   RenderSlider {INPUT} at (45,2) size 156x13
-RenderBlock {DIV} at (0,2) size 10x8
+RenderFlexibleBox {DIV} at (0,0) size 156x13
+  RenderBlock {DIV} at (0,2) size 146x8
+  RenderBlock {DIV} at (146,2) size 10x8
 RenderButton {INPUT} at (297,6) size 14x12
 layer at (57,264) size 45x11
   RenderFlexibleBox {DIV} at (0,2) size 45x11 [color=#FF]
@@ -30,3 +32,5 @@
 RenderBlock (anonymous) at (7,0) size 31x11
   RenderText {#text} at (0,0) size 31x11
 text run at (0,0) width 31: "-00:06"
+layer at (102,266) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8


Modified: trunk/LayoutTests/platform/mac-leopard/media/controls-strict-expected.txt (88769 => 88770)

--- trunk/LayoutTests/platform/mac-leopard/media/controls-strict-expected.txt	2011-06-14 04:53:00 UTC (rev 88769)
+++ trunk/LayoutTests/platform/mac-leopard/media/controls-strict-expected.txt	2011-06-14 05:00:07 UTC (rev 88770)
@@ -18,7 +18,9 @@
 RenderButton {INPUT} at (32,4) size 16x16
 RenderFlexibleBox {DIV} at (49,5) size 246x15
   RenderSlider {INPUT} at (45,2) size 156x13
-RenderBlock {DIV} at (0,2) size 10x8
+RenderFlexibleBox {DIV} at (0,0) size 156x13
+  RenderBlock {DIV} at (0,2) size 146x8
+  RenderBlock {DIV} at (146,2) size 10x8
 RenderButton {INPUT} at (297,6) size 14x12
 layer at (57,272) size 45x11
   RenderFlexibleBox {DIV} at (0,2) size 45x11 [color=#FF]
@@ -30,3 +32,5 @@
 RenderBlock (anonymous) at (7,0) size 31x11
   RenderText {#text} at (0,0) size 31x11
 text run at (0,0) width 31: "-00:06"
+layer at (102,274) size 10x8
+  RenderBlock (relative positioned) {DIV} at (0,0) size 10x8


Modified: trunk/LayoutTests/platform/mac-leopard/media/controls-styling-expected.txt (88769 => 88770)

--- trunk/LayoutTests/platform/mac-leopard/media/controls-styling-expected.txt	2011-06-14 04:53:00 UTC (rev 88769)
+++ trunk/LayoutTests/platform/mac-leopard/media/controls-styling-expected.txt	2011-06-14 05:00:07 UTC (rev 88770)
@@ -22,7 +22,9 @@
 RenderButton {INPUT} at (32,4) size 16x16
 RenderFlexibleBox {DIV} at (49,5) size 246x15
   RenderSlider {INPUT} at (45,2) size 156x13
-RenderBlock {DIV} at (0,2) size 10x8
+RenderF

[webkit-changes] [88769] trunk/LayoutTests

[tkent]

Title: [88769] trunk/LayoutTests








Revision 88769
Author tk...@chromium.org
Date 2011-06-13 21:53:00 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[Mac] Rebaseline for r88757.

* media/audio-repaint-expected.txt:
* media/media-document-audio-repaint-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/audio-repaint-expected.txt
trunk/LayoutTests/media/media-document-audio-repaint-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88768 => 88769)

--- trunk/LayoutTests/ChangeLog	2011-06-14 04:45:42 UTC (rev 88768)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 04:53:00 UTC (rev 88769)
@@ -1,3 +1,10 @@
+2011-06-13  Kent Tamura  
+
+[Mac] Rebaseline for r88757.
+
+* media/audio-repaint-expected.txt:
+* media/media-document-audio-repaint-expected.txt:
+
 2011-06-13  Ryosuke Niwa  
 
 Fix a typo in Mac WebKit2's skipped list.


Modified: trunk/LayoutTests/media/audio-repaint-expected.txt (88768 => 88769)

--- trunk/LayoutTests/media/audio-repaint-expected.txt	2011-06-14 04:45:42 UTC (rev 88768)
+++ trunk/LayoutTests/media/audio-repaint-expected.txt	2011-06-14 04:53:00 UTC (rev 88769)
@@ -26,7 +26,7 @@
   RenderBlock {DIV} at (0,2) size 116x8
   RenderBlock {DIV} at (116,2) size 10x8
 RenderButton {INPUT} at (177,6) size 14x12
-layer at (115,76) size 10x8
+layer at (114,76) size 10x8
   RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
 layer at (8,42) size 200x25
   RenderBlock (relative positioned) {DIV} at (0,0) size 200x25
@@ -40,7 +40,7 @@
   RenderBlock {DIV} at (0,2) size 116x8
   RenderBlock {DIV} at (116,2) size 10x8
 RenderButton {INPUT} at (177,6) size 14x12
-layer at (115,51) size 10x8
+layer at (114,51) size 10x8
   RenderBlock (relative positioned) {DIV} at (0,0) size 10x8
 layer at (8,144) size 200x25
   RenderMedia {AUDIO} at (0,102) size 200x25
@@ -56,5 +56,5 @@
   RenderBlock {DIV} at (0,2) size 116x8
   RenderBlock {DIV} at (116,2) size 10x8
 RenderButton {INPUT} at (177,6) size 14x12
-layer at (115,153) size 10x8
+layer at (114,153) size 10x8
   RenderBlock (relative positioned) {DIV} at (0,0) size 10x8


Modified: trunk/LayoutTests/media/media-document-audio-repaint-expected.txt (88768 => 88769)

--- trunk/LayoutTests/media/media-document-audio-repaint-expected.txt	2011-06-14 04:45:42 UTC (rev 88768)
+++ trunk/LayoutTests/media/media-document-audio-repaint-expected.txt	2011-06-14 04:53:00 UTC (rev 88769)
@@ -41,5 +41,5 @@
 RenderBlock (anonymous) at (7,0) size 31x11
   RenderText {#text} at (0,0) size 31x11
 text run at (0,0) width 31: "-00:00"
-layer at (197,149) size 10x8
+layer at (196,149) size 10x8
   RenderBlock (relative positioned) {DIV} at (0,0) size 10x8






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88768] trunk/Tools

[ap]

Title: [88768] trunk/Tools








Revision 88768
Author a...@apple.com
Date 2011-06-13 21:45:42 -0700 (Mon, 13 Jun 2011)


Log Message
Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
and commit queue happy.

* Scripts/webkitpy/common/config/committers.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/committers.py




Diff

Modified: trunk/Tools/ChangeLog (88767 => 88768)

--- trunk/Tools/ChangeLog	2011-06-14 04:34:40 UTC (rev 88767)
+++ trunk/Tools/ChangeLog	2011-06-14 04:45:42 UTC (rev 88768)
@@ -1,3 +1,10 @@
+2011-06-13  Alexey Proskuryakov  
+
+Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
+and commit queue happy.
+
+* Scripts/webkitpy/common/config/committers.py:
+
 2011-06-13  Chris Rogers  
 
 Unreviewed build fix.


Modified: trunk/Tools/Scripts/webkitpy/common/config/committers.py (88767 => 88768)

--- trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-06-14 04:34:40 UTC (rev 88767)
+++ trunk/Tools/Scripts/webkitpy/common/config/committers.py	2011-06-14 04:45:42 UTC (rev 88768)
@@ -211,7 +211,7 @@
 Committer("Marcus Voltis Bulach", "bul...@chromium.org"),
 Committer("Mario Sanchez Prada", ["msanc...@igalia.com", "ma...@webkit.org"], "msanchez"),
 Committer("Matt Delaney", "mdela...@apple.com"),
-Committer("Matt Lilek", ["web...@mattlilek.com", "pewtermo...@webkit.org"]),
+Committer("Matt Lilek", ["mli...@apple.com", "web...@mattlilek.com", "pewtermo...@webkit.org"]),
 Committer("Matt Perry", "mpcompl...@chromium.org"),
 Committer("Maxime Britto", ["maxime.bri...@gmail.com", "bri...@apple.com"]),
 Committer("Maxime Simon", ["simon.max...@gmail.com", "maxime.si...@webkit.org"], "maxime.simon"),






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88767] trunk/LayoutTests

[rniwa]

Title: [88767] trunk/LayoutTests








Revision 88767
Author rn...@webkit.org
Date 2011-06-13 21:34:40 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Fix a typo in Mac WebKit2's skipped list.

svg/custom/focus-event-handling-keyboard's extension is xhtml, not html.

* platform/mac-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (88766 => 88767)

--- trunk/LayoutTests/ChangeLog	2011-06-14 04:29:49 UTC (rev 88766)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 04:34:40 UTC (rev 88767)
@@ -1,5 +1,13 @@
 2011-06-13  Ryosuke Niwa  
 
+Fix a typo in Mac WebKit2's skipped list.
+
+svg/custom/focus-event-handling-keyboard's extension is xhtml, not html.
+
+* platform/mac-wk2/Skipped:
+
+2011-06-13  Ryosuke Niwa  
+
 Skip editing/pasteboard/smart-paste-004.html per bug 61633.
 
 * platform/win/Skipped:


Modified: trunk/LayoutTests/platform/mac-wk2/Skipped (88766 => 88767)

--- trunk/LayoutTests/platform/mac-wk2/Skipped	2011-06-14 04:29:49 UTC (rev 88766)
+++ trunk/LayoutTests/platform/mac-wk2/Skipped	2011-06-14 04:34:40 UTC (rev 88767)
@@ -1780,7 +1780,7 @@
 fast/forms/radio-group-keyboard-change-event.html
 fast/forms/focus-with-display-block.html
 fast/forms/ValidityState-valueMissing-002.html
-svg/custom/focus-event-handling-keyboard.html
+svg/custom/focus-event-handling-keyboard.xhtml
 
 # eventSender.contextClick() is unimplemented
 editing/spelling/spellcheck-input-search-crash.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88766] trunk/LayoutTests

[rniwa]

Title: [88766] trunk/LayoutTests








Revision 88766
Author rn...@webkit.org
Date 2011-06-13 21:29:49 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Skip editing/pasteboard/smart-paste-004.html per bug 61633.

* platform/win/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (88765 => 88766)

--- trunk/LayoutTests/ChangeLog	2011-06-14 04:23:35 UTC (rev 88765)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 04:29:49 UTC (rev 88766)
@@ -1,5 +1,11 @@
 2011-06-13  Ryosuke Niwa  
 
+Skip editing/pasteboard/smart-paste-004.html per bug 61633.
+
+* platform/win/Skipped:
+
+2011-06-13  Ryosuke Niwa  
+
 Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
 Windows Vista and Windows 7.
 


Modified: trunk/LayoutTests/platform/win/Skipped (88765 => 88766)

--- trunk/LayoutTests/platform/win/Skipped	2011-06-14 04:23:35 UTC (rev 88765)
+++ trunk/LayoutTests/platform/win/Skipped	2011-06-14 04:29:49 UTC (rev 88766)
@@ -1247,6 +1247,9 @@
 fast/html/details-remove-summary-5-and-click.html
 fast/html/details-remove-summary-6-and-click.html
 
+# https://bugs.webkit.org/show_bug.cgi?id=61633
+editing/pasteboard/smart-paste-004.html
+
 # https://bugs.webkit.org/show_bug.cgi?id=56496
 fast/js/array-sort-modifying-tostring.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88765] trunk/LayoutTests

[rniwa]

Title: [88765] trunk/LayoutTests








Revision 88765
Author rn...@webkit.org
Date 2011-06-13 21:23:35 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
Windows Vista and Windows 7.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88764 => 88765)

--- trunk/LayoutTests/ChangeLog	2011-06-14 04:15:14 UTC (rev 88764)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 04:23:35 UTC (rev 88765)
@@ -1,5 +1,12 @@
 2011-06-13  Ryosuke Niwa  
 
+Chromium test expectation update; svg/css/group-with-shadow.svg is passing on
+Windows Vista and Windows 7.
+
+* platform/chromium/test_expectations.txt:
+
+2011-06-13  Ryosuke Niwa  
+
 Remove failing test expectation for plugins/npruntime/browser-object-identity.html
 on Chromium since it has been fixed by r88679.
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88764 => 88765)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 04:15:14 UTC (rev 88764)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 04:23:35 UTC (rev 88765)
@@ -3617,7 +3617,7 @@
 BUGWK60115 WIN : fast/text/shadow-translucent-fill.html = IMAGE
 BUGWK60115 LEOPARD : fast/text/shadow-translucent-fill.html = IMAGE
 BUGWK60115 MAC : fast/transforms/shadows.html = IMAGE PASS
-BUGWK60115 WIN : svg/css/group-with-shadow.svg = IMAGE
+BUGWK60115 XP : svg/css/group-with-shadow.svg = IMAGE
 BUGWK60115 WIN : transitions/svg-text-shadow-transition.html = IMAGE
 BUGWK60115 WIN : svg/css/composite-shadow-text.svg = IMAGE
 BUGWK60115 WIN : svg/css/shadow-changes.svg = IMAGE






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88764] trunk/Source/WebCore

[tkent]

Title: [88764] trunk/Source/WebCore








Revision 88764
Author tk...@chromium.org
Date 2011-06-13 21:15:14 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[EFL] The second try to fix a build break.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88763 => 88764)

--- trunk/Source/WebCore/ChangeLog	2011-06-14 04:08:38 UTC (rev 88763)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 04:15:14 UTC (rev 88764)
@@ -1,5 +1,12 @@
 2011-06-13  Kent Tamura  
 
+[EFL] The second try to fix a build break.
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::paintThemePart):
+
+2011-06-13  Kent Tamura  
+
 [EFL] Fix a typo.
 
 * platform/efl/RenderThemeEfl.cpp:


Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (88763 => 88764)

--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-06-14 04:08:38 UTC (rev 88763)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-06-14 04:15:14 UTC (rev 88764)
@@ -303,7 +303,7 @@
 // treatment, move them to special functions.
 if (type == SliderVertical || type == SliderHorizontal) {
 RenderSlider* renderSlider = toRenderSlider(object);
-HTMLInputElement* input = renderSlider->toInputElement();
+HTMLInputElement* input = renderSlider->node()->toInputElement();
 Edje_Message_Float_Set* msg;
 double valueRange = input->maximum() - input->minimum();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88763] trunk/Source/WebCore

[tkent]

Title: [88763] trunk/Source/WebCore








Revision 88763
Author tk...@chromium.org
Date 2011-06-13 21:08:38 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[EFL] Fix a typo.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88762 => 88763)

--- trunk/Source/WebCore/ChangeLog	2011-06-14 04:07:30 UTC (rev 88762)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 04:08:38 UTC (rev 88763)
@@ -1,5 +1,12 @@
 2011-06-13  Kent Tamura  
 
+[EFL] Fix a typo.
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::paintThemePart):
+
+2011-06-13  Kent Tamura  
+
 [EFL] Try to fix a build break by r88757.
 
 * platform/efl/RenderThemeEfl.cpp:


Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (88762 => 88763)

--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-06-14 04:07:30 UTC (rev 88762)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-06-14 04:08:38 UTC (rev 88763)
@@ -303,7 +303,7 @@
 // treatment, move them to special functions.
 if (type == SliderVertical || type == SliderHorizontal) {
 RenderSlider* renderSlider = toRenderSlider(object);
-HTMLInputElement* inpu = renderSlider->toInputElement();
+HTMLInputElement* input = renderSlider->toInputElement();
 Edje_Message_Float_Set* msg;
 double valueRange = input->maximum() - input->minimum();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88762] trunk/Source/WebCore

[tkent]

Title: [88762] trunk/Source/WebCore








Revision 88762
Author tk...@chromium.org
Date 2011-06-13 21:07:30 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kent Tamura  

[EFL] Try to fix a build break by r88757.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::paintThemePart):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88761 => 88762)

--- trunk/Source/WebCore/ChangeLog	2011-06-14 04:05:56 UTC (rev 88761)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 04:07:30 UTC (rev 88762)
@@ -1,3 +1,10 @@
+2011-06-13  Kent Tamura  
+
+[EFL] Try to fix a build break by r88757.
+
+* platform/efl/RenderThemeEfl.cpp:
+(WebCore::RenderThemeEfl::paintThemePart):
+
 2011-06-10  Kent Tamura  
 
 Reviewed by Dimitri Glazkov.


Modified: trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp (88761 => 88762)

--- trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-06-14 04:05:56 UTC (rev 88761)
+++ trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp	2011-06-14 04:07:30 UTC (rev 88762)
@@ -31,6 +31,7 @@
 #include "Frame.h"
 #include "FrameView.h"
 #include "GraphicsContext.h"
+#include "HTMLInputElement.h"
 #include "NotImplemented.h"
 #include "Page.h"
 #include "PaintInfo.h"
@@ -302,21 +303,16 @@
 // treatment, move them to special functions.
 if (type == SliderVertical || type == SliderHorizontal) {
 RenderSlider* renderSlider = toRenderSlider(object);
+HTMLInputElement* inpu = renderSlider->toInputElement();
 Edje_Message_Float_Set* msg;
-int max, value;
+double valueRange = input->maximum() - input->minimum();
 
-if (type == SliderVertical) {
-max = rect.height() - renderSlider->thumbRect().height();
-value = renderSlider->thumbRect().y();
-} else {
-max = rect.width() - renderSlider->thumbRect().width();
-value = renderSlider->thumbRect().x();
-}
-
 msg = static_cast(alloca(sizeof(Edje_Message_Float_Set) + sizeof(float)));
-
 msg->count = 2;
-msg->val[0] = static_cast(value) / static_cast(max);
+if (valueRange > 0)
+msg->val[0] = static_cast((input->valueAsNumber() - input->minimum()) / valueRange);
+else
+msg->val[0] = 0;
 msg->val[1] = 0.1;
 edje_object_message_send(entry->o, EDJE_MESSAGE_FLOAT_SET, 0, msg);
 #if ENABLE(PROGRESS_TAG)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88761] branches/chromium/782/Source

[cevans]

Title: [88761] branches/chromium/782/Source








Revision 88761
Author cev...@google.com
Date 2011-06-13 21:05:56 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 88444
BUG=85559
Review URL: http://codereview.chromium.org/7145019

Modified Paths

branches/chromium/782/Source/_javascript_Core/_javascript_Core.exp
branches/chromium/782/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def
branches/chromium/782/Source/WebCore/inspector/InspectorValues.cpp




Diff

Modified: branches/chromium/782/Source/_javascript_Core/_javascript_Core.exp (88760 => 88761)

--- branches/chromium/782/Source/_javascript_Core/_javascript_Core.exp	2011-06-14 04:02:28 UTC (rev 88760)
+++ branches/chromium/782/Source/_javascript_Core/_javascript_Core.exp	2011-06-14 04:05:56 UTC (rev 88761)
@@ -571,7 +571,9 @@
 __ZNK3JSC9HashTable11deleteTableEv
 __ZNK3WTF12AtomicString5lowerEv
 __ZNK3WTF13DecimalNumber15toStringDecimalEPtj
+__ZNK3WTF13DecimalNumber19toStringExponentialEPtj
 __ZNK3WTF13DecimalNumber28bufferLengthForStringDecimalEv
+__ZNK3WTF13DecimalNumber32bufferLengthForStringExponentialEv
 __ZNK3WTF6String11toIntStrictEPbi
 __ZNK3WTF6String12toUIntStrictEPbi
 __ZNK3WTF6String13toInt64StrictEPbi


Modified: branches/chromium/782/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def (88760 => 88761)

--- branches/chromium/782/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-06-14 04:02:28 UTC (rev 88760)
+++ branches/chromium/782/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/_javascript_Core.def	2011-06-14 04:05:56 UTC (rev 88761)
@@ -65,6 +65,7 @@
 ?attach@Debugger@JSC@@QAEXPAVJSGlobalObject@2@@Z
 ?broadcast@ThreadCondition@WTF@@QAEXXZ
 ?bufferLengthForStringDecimal@DecimalNumber@WTF@@QBEIXZ
+?bufferLengthForStringExponential@DecimalNumber@WTF@@QBEIXZ
 ?byteCompile@Yarr@JSC@@YA?AV?$PassOwnPtr@UBytecodePattern@Yarr@JSC@@@WTF@@AAUYarrPattern@12@PAVBumpPointerAllocator@4@@Z
 ?byteSize@SourceProviderCache@JSC@@QBEIXZ
 ?calculateDSTOffset@WTF@@YANNN@Z
@@ -348,6 +349,7 @@
 ?toString@JSObject@JSC@@UBE?AVUString@2@PAVExecState@2@@Z
 ?toString@JSString@JSC@@EBE?AVUString@2@PAVExecState@2@@Z
 ?toStringDecimal@DecimalNumber@WTF@@QBEIPA_WI@Z
+?toStringExponential@DecimalNumber@WTF@@QBEIPA_WI@Z
 ?toThisObject@JSCell@JSC@@UBEPAVJSObject@2@PAVExecState@2@@Z
 ?toThisObject@JSObject@JSC@@UBEPAV12@PAVExecState@2@@Z
 ?toThisObject@JSString@JSC@@EBEPAVJSObject@2@PAVExecState@2@@Z


Modified: branches/chromium/782/Source/WebCore/inspector/InspectorValues.cpp (88760 => 88761)

--- branches/chromium/782/Source/WebCore/inspector/InspectorValues.cpp	2011-06-14 04:02:28 UTC (rev 88760)
+++ branches/chromium/782/Source/WebCore/inspector/InspectorValues.cpp	2011-06-14 04:05:56 UTC (rev 88761)
@@ -620,7 +620,18 @@
 output->append(falseString, 5);
 } else if (type() == TypeNumber) {
 NumberToStringBuffer buffer;
-unsigned length = DecimalNumber(m_doubleValue).toStringDecimal(buffer, WTF::NumberToStringBufferLength);
+DecimalNumber decimal = m_doubleValue;
+unsigned length = 0;
+if (decimal.bufferLengthForStringDecimal() > WTF::NumberToStringBufferLength) {
+// Not enough room for decimal. Use exponential format.
+if (decimal.bufferLengthForStringExponential() > WTF::NumberToStringBufferLength) {
+// Fallback for an abnormal case if it's too little even for exponential.
+output->append("NaN", 3);
+return;
+}
+length = decimal.toStringExponential(buffer, WTF::NumberToStringBufferLength);
+} else
+length = decimal.toStringDecimal(buffer, WTF::NumberToStringBufferLength);
 output->append(buffer, length);
 }
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88760] trunk/LayoutTests

[rniwa]

Title: [88760] trunk/LayoutTests








Revision 88760
Author rn...@webkit.org
Date 2011-06-13 21:02:28 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Remove failing test expectation for plugins/npruntime/browser-object-identity.html
on Chromium since it has been fixed by r88679.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88759 => 88760)

--- trunk/LayoutTests/ChangeLog	2011-06-14 03:49:44 UTC (rev 88759)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 04:02:28 UTC (rev 88760)
@@ -1,3 +1,10 @@
+2011-06-13  Ryosuke Niwa  
+
+Remove failing test expectation for plugins/npruntime/browser-object-identity.html
+on Chromium since it has been fixed by r88679.
+
+* platform/chromium/test_expectations.txt:
+
 2011-06-10  Kent Tamura  
 
 Reviewed by Dimitri Glazkov.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88759 => 88760)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 03:49:44 UTC (rev 88759)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 04:02:28 UTC (rev 88760)
@@ -772,7 +772,6 @@
 BUGCR38353 MAC LINUX: plugins/keyboard-events.html = TEXT
 BUGCR10351 MAC : plugins/mouse-events.html = FAIL
 BUGCR32864 : plugins/mouse-events-fixedpos.html = TEXT
-BUGCR35822 : plugins/npruntime/browser-object-identity.html = TEXT
 // Object.keys on an NPObject produces the wrong output.
 BUGCR21901 : plugins/npruntime/enumerate.html = TEXT
 BUGCR50787 : plugins/npruntime/plugin-scriptable-object-invoke-default.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88759] branches/chromium/782/Source/WebCore/dom/Element.cpp

[cevans]

Title: [88759] branches/chromium/782/Source/WebCore/dom/Element.cpp








Revision 88759
Author cev...@google.com
Date 2011-06-13 20:49:44 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 87827
BUG=84335
Review URL: http://codereview.chromium.org/7155001

Modified Paths

branches/chromium/782/Source/WebCore/dom/Element.cpp




Diff

Modified: branches/chromium/782/Source/WebCore/dom/Element.cpp (88758 => 88759)

--- branches/chromium/782/Source/WebCore/dom/Element.cpp	2011-06-14 03:48:29 UTC (rev 88758)
+++ branches/chromium/782/Source/WebCore/dom/Element.cpp	2011-06-14 03:49:44 UTC (rev 88759)
@@ -90,7 +90,13 @@
 
 if (!m_pushedStyleSelector)
 return;
+
+// This tells us that our pushed style selector is in a bad state,
+// so we should just bail out in that scenario.
 ASSERT(m_pushedStyleSelector == m_parent->document()->styleSelector());
+if (m_pushedStyleSelector != m_parent->document()->styleSelector())
+return;
+
 m_pushedStyleSelector->popParent(m_parent); 
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88758] branches/chromium/742/Source/WebCore/dom/Element.cpp

[cevans]

Title: [88758] branches/chromium/742/Source/WebCore/dom/Element.cpp








Revision 88758
Author cev...@google.com
Date 2011-06-13 20:48:29 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 87827
BUG=84355
Review URL: http://codereview.chromium.org/7111044

Modified Paths

branches/chromium/742/Source/WebCore/dom/Element.cpp




Diff

Modified: branches/chromium/742/Source/WebCore/dom/Element.cpp (88757 => 88758)

--- branches/chromium/742/Source/WebCore/dom/Element.cpp	2011-06-14 03:46:30 UTC (rev 88757)
+++ branches/chromium/742/Source/WebCore/dom/Element.cpp	2011-06-14 03:48:29 UTC (rev 88758)
@@ -90,7 +90,13 @@
 
 if (!m_pushedStyleSelector)
 return;
+
+// This tells us that our pushed style selector is in a bad state,
+// so we should just bail out in that scenario.
 ASSERT(m_pushedStyleSelector == m_parent->document()->styleSelector());
+if (m_pushedStyleSelector != m_parent->document()->styleSelector())
+return;
+
 m_pushedStyleSelector->popParent(m_parent); 
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88756] branches/chromium/782/Source/WebCore/platform/leveldb/ LevelDBTransaction.cpp

[cevans]

Title: [88756] branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp








Revision 88756
Author cev...@google.com
Date 2011-06-13 20:30:49 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 87911
BUG=84597
Review URL: http://codereview.chromium.org/7154001

Modified Paths

branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp




Diff

Modified: branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp (88755 => 88756)

--- branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp	2011-06-14 02:55:15 UTC (rev 88755)
+++ branches/chromium/782/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp	2011-06-14 03:30:49 UTC (rev 88756)
@@ -53,11 +53,16 @@
 TreeType::Iterator iterator;
 iterator.start_iter_least(m_tree);
 
+Vector nodes;
+
 while (*iterator) {
-delete *iterator;
+nodes.append(*iterator);
 ++iterator;
 }
 m_tree.purge();
+
+for (size_t i = 0; i < nodes.size(); ++i)
+delete(nodes[i]);
 }
 
 LevelDBTransaction::~LevelDBTransaction()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88755] trunk/Source/WebKit/chromium

[simonjam]

Title: [88755] trunk/Source/WebKit/chromium








Revision 88755
Author simon...@chromium.org
Date 2011-06-13 19:55:15 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  James Simonsen  

[Chromium] Unreviewed, rolled DEPS.

* DEPS:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/DEPS




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (88754 => 88755)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-06-14 02:27:53 UTC (rev 88754)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-06-14 02:55:15 UTC (rev 88755)
@@ -1,5 +1,11 @@
 2011-06-13  James Simonsen  
 
+[Chromium] Unreviewed, rolled DEPS.
+
+* DEPS:
+
+2011-06-13  James Simonsen  
+
 Reviewed by James Robinson.
 
 [Chromium] Implement monotonicallyIncreasingClock()


Modified: trunk/Source/WebKit/chromium/DEPS (88754 => 88755)

--- trunk/Source/WebKit/chromium/DEPS	2011-06-14 02:27:53 UTC (rev 88754)
+++ trunk/Source/WebKit/chromium/DEPS	2011-06-14 02:55:15 UTC (rev 88755)
@@ -32,7 +32,7 @@
 
 vars = {
   'chromium_svn': 'http://src.chromium.org/svn/trunk/src',
-  'chromium_rev': '88644'
+  'chromium_rev': '88950'
 }
 
 deps = {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88752] trunk/LayoutTests

[rniwa]

Title: [88752] trunk/LayoutTests








Revision 88752
Author rn...@webkit.org
Date 2011-06-13 19:15:45 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Another GTK rebaseline after r88717 because non-breaking spaces were somehow converted to
regular spaces in r88742.

* platform/gtk/editing/pasteboard/paste-xml-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88751 => 88752)

--- trunk/LayoutTests/ChangeLog	2011-06-14 02:09:44 UTC (rev 88751)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 02:15:45 UTC (rev 88752)
@@ -1,5 +1,12 @@
 2011-06-13  Ryosuke Niwa  
 
+Another GTK rebaseline after r88717 because non-breaking spaces were somehow converted to
+regular spaces in r88742.
+
+* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
+
+2011-06-13  Ryosuke Niwa  
+
 Chromium rebaselines after r88617. The test is now passing on all platforms.
 
 * platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.


Modified: trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt (88751 => 88752)

--- trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt	2011-06-14 02:09:44 UTC (rev 88751)
+++ trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt	2011-06-14 02:15:45 UTC (rev 88752)
@@ -15,6 +15,6 @@
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text > span > div > body > html > #document to 1 of #text > span > div > body > html > #document toDOMRange:range from 3 of #text > span > div > body > html > #document to 3 of #text > span > div > body > html > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-foo barbar baz
+foo barbar baz
 execCopyCommand: foo bar baz
-execPasteCommand: foo barbar baz
+execPasteCommand: foo barbar baz






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88751] trunk/Source/WebCore

[keishi]

Title: [88751] trunk/Source/WebCore








Revision 88751
Author kei...@webkit.org
Date 2011-06-13 19:09:44 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Keishi Hattori  

Sort WebCore.xcodeproj
Accomplished using sort-Xcode-project-file.

* WebCore.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj




Diff

Modified: trunk/Source/WebCore/ChangeLog (88750 => 88751)

--- trunk/Source/WebCore/ChangeLog	2011-06-14 02:08:02 UTC (rev 88750)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 02:09:44 UTC (rev 88751)
@@ -1,3 +1,10 @@
+2011-06-13  Keishi Hattori  
+
+Sort WebCore.xcodeproj
+Accomplished using sort-Xcode-project-file.
+
+* WebCore.xcodeproj/project.pbxproj:
+
 2011-06-13  James Simonsen  
 
 Reviewed by James Robinson.


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (88750 => 88751)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-06-14 02:08:02 UTC (rev 88750)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2011-06-14 02:09:44 UTC (rev 88751)
@@ -21522,6 +21522,7 @@
 514C76730CE923A1007EF3CD /* HTTPParsers.h in Headers */,
 375CD232119D43C800A2A859 /* Hyphenation.h in Headers */,
 B275356E0B053814002CE64F /* Icon.h in Headers */,
+97E4029013A696ED00913D67 /* IconController.h in Headers */,
 5126E6BC0A2E3B12005C29FA /* IconDatabase.h in Headers */,
 516953981329A3C800B92D04 /* IconDatabaseBase.h in Headers */,
 51E1ECBE0C91C90400DC255B /* IconDatabaseClient.h in Headers */,
@@ -22780,10 +22781,13 @@
 084DB59B128008CC002A6D64 /* SVGAnimatedString.h in Headers */,
 08250939128BD4D800E2ED8E /* SVGAnimatedTransformList.h in Headers */,
 085A15931289A8DD002710E3 /* SVGAnimatedTransformListPropertyTearOff.h in Headers */,
+439D334313A6911C00C20F4F /* SVGAnimatedType.h in Headers */,
+439D334413A6911C00C20F4F /* SVGAnimatedTypeAnimator.h in Headers */,
 B22279900D00BF220071B782 /* SVGAnimateElement.h in Headers */,
 B22279930D00BF220071B782 /* SVGAnimateMotionElement.h in Headers */,
 B22279950D00BF220071B782 /* SVGAnimateTransformElement.h in Headers */,
 B22279980D00BF220071B782 /* SVGAnimationElement.h in Headers */,
+439D334513A6911C00C20F4F /* SVGAnimatorFactory.h in Headers */,
 B222799C0D00BF220071B782 /* SVGCircleElement.h in Headers */,
 B222799F0D00BF220071B782 /* SVGClipPathElement.h in Headers */,
 B22279A20D00BF220071B782 /* SVGColor.h in Headers */,
@@ -23191,10 +23195,6 @@
 E1BE512E0CF6C512002EA959 /* XSLTUnicodeSort.h in Headers */,
 977E2E0F12F0FC9C00C13379 /* XSSAuditor.h in Headers */,
 FD537353137B65188DCE /* ZeroPole.h in Headers */,
-439D334313A6911C00C20F4F /* SVGAnimatedType.h in Headers */,
-439D334413A6911C00C20F4F /* SVGAnimatedTypeAnimator.h in Headers */,
-439D334513A6911C00C20F4F /* SVGAnimatorFactory.h in Headers */,
-97E4029013A696ED00913D67 /* IconController.h in Headers */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};
@@ -24398,6 +24398,7 @@
 514C76720CE923A1007EF3CD /* HTTPParsers.cpp in Sources */,
 371A67CB11C6C7DB00047B8B /* HyphenationCF.cpp in Sources */,
 375CD23B119D44EA00A2A859 /* HyphenationMac.mm in Sources */,
+97E4028F13A696ED00913D67 /* IconController.cpp in Sources */,
 5126E6BB0A2E3B12005C29FA /* IconDatabase.cpp in Sources */,
 516953971329A3C800B92D04 /* IconDatabaseBase.cpp in Sources */,
 513F14530AB634C400094DDF /* IconLoader.cpp in Sources */,
@@ -25611,6 +25612,7 @@
 65653F2D0D9727D200CA9723 /* SVGAltGlyphElement.cpp in Sources */,
 B22279760D00BF220071B782 /* SVGAngle.cpp in Sources */,
 B22279790D00BF220071B782 /* SVGAnimateColorElement.cpp in Sources */,
+4381763B13A697D4007D1187 /* SVGAnimatedLength.cpp in Sources */,
 B222798F0D00BF220071B782 /* SVGAnimateElement.cpp in Sources */,
 B22279920D00BF220071B782 /* SVGAnimateMotionElement.cpp in Sources */,
 B22279940D00BF220071B782 /* SVGAnimateTransformElement.cpp in Sources */,
@@ -25928,8 +25930,6 @@
 E1BE512D0CF6C512002EA959 /* XSLTUnicodeSort.cpp in Sources */,
 977E2E0E12F0FC9C00C13379 /* XSSAuditor.cpp in Sources */,
 FD537352137B65188DCE /* ZeroPole.cpp in Sources */,
-97E4028F13A696ED00913D67 /* IconController.cpp in Sources */,
-4381763B13A697D4007D1187 /* SVGAnimatedLength.cpp in Sources */,
 			);
 			runOnlyForDeploymentPostprocessing = 0;
 		};






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88750] branches/chromium/742

[cevans]

Title: [88750] branches/chromium/742








Revision 88750
Author cev...@google.com
Date 2011-06-13 19:08:02 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149011

Modified Paths

branches/chromium/742/Source/WebCore/css/CSSParser.cpp


Added Paths

branches/chromium/742/LayoutTests/css3/calc/regression-62276-expected.txt
branches/chromium/742/LayoutTests/css3/calc/regression-62276.html




Diff

Copied: branches/chromium/742/LayoutTests/css3/calc/regression-62276-expected.txt (from rev 88448, trunk/LayoutTests/css3/calc/regression-62276-expected.txt) (0 => 88750)

--- branches/chromium/742/LayoutTests/css3/calc/regression-62276-expected.txt	(rev 0)
+++ branches/chromium/742/LayoutTests/css3/calc/regression-62276-expected.txt	2011-06-14 02:08:02 UTC (rev 88750)
@@ -0,0 +1,3 @@
+The test passes if it does not crash
+
+


Copied: branches/chromium/742/LayoutTests/css3/calc/regression-62276.html (from rev 88448, trunk/LayoutTests/css3/calc/regression-62276.html) (0 => 88750)

--- branches/chromium/742/LayoutTests/css3/calc/regression-62276.html	(rev 0)
+++ branches/chromium/742/LayoutTests/css3/calc/regression-62276.html	2011-06-14 02:08:02 UTC (rev 88750)
@@ -0,0 +1,12 @@
+The test passes if it does not crash
+
+
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+


Modified: branches/chromium/742/Source/WebCore/css/CSSParser.cpp (88749 => 88750)

--- branches/chromium/742/Source/WebCore/css/CSSParser.cpp	2011-06-14 02:07:07 UTC (rev 88749)
+++ branches/chromium/742/Source/WebCore/css/CSSParser.cpp	2011-06-14 02:08:02 UTC (rev 88750)
@@ -5934,6 +5934,9 @@
 case FUNCTION:
 case ANYFUNCTION:
 case NOTFUNCTION:
+case CALCFUNCTION:
+case MINFUNCTION:
+case MAXFUNCTION:
 yylval->string.characters = t;
 yylval->string.length = length;
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88749] branches/chromium/782

[cevans]

Title: [88749] branches/chromium/782








Revision 88749
Author cev...@google.com
Date 2011-06-13 19:07:07 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 88448
BUG=85003
Review URL: http://codereview.chromium.org/7149010

Modified Paths

branches/chromium/782/Source/WebCore/css/CSSParser.cpp


Added Paths

branches/chromium/782/LayoutTests/css3/calc/regression-62276-expected.txt
branches/chromium/782/LayoutTests/css3/calc/regression-62276.html




Diff

Copied: branches/chromium/782/LayoutTests/css3/calc/regression-62276-expected.txt (from rev 88448, trunk/LayoutTests/css3/calc/regression-62276-expected.txt) (0 => 88749)

--- branches/chromium/782/LayoutTests/css3/calc/regression-62276-expected.txt	(rev 0)
+++ branches/chromium/782/LayoutTests/css3/calc/regression-62276-expected.txt	2011-06-14 02:07:07 UTC (rev 88749)
@@ -0,0 +1,3 @@
+The test passes if it does not crash
+
+


Copied: branches/chromium/782/LayoutTests/css3/calc/regression-62276.html (from rev 88448, trunk/LayoutTests/css3/calc/regression-62276.html) (0 => 88749)

--- branches/chromium/782/LayoutTests/css3/calc/regression-62276.html	(rev 0)
+++ branches/chromium/782/LayoutTests/css3/calc/regression-62276.html	2011-06-14 02:07:07 UTC (rev 88749)
@@ -0,0 +1,12 @@
+The test passes if it does not crash
+
+
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+


Modified: branches/chromium/782/Source/WebCore/css/CSSParser.cpp (88748 => 88749)

--- branches/chromium/782/Source/WebCore/css/CSSParser.cpp	2011-06-14 01:59:07 UTC (rev 88748)
+++ branches/chromium/782/Source/WebCore/css/CSSParser.cpp	2011-06-14 02:07:07 UTC (rev 88749)
@@ -5959,6 +5959,9 @@
 case FUNCTION:
 case ANYFUNCTION:
 case NOTFUNCTION:
+case CALCFUNCTION:
+case MINFUNCTION:
+case MAXFUNCTION:
 yylval->string.characters = t;
 yylval->string.length = length;
 break;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88748] trunk/LayoutTests

[rniwa]

Title: [88748] trunk/LayoutTests








Revision 88748
Author rn...@webkit.org
Date 2011-06-13 18:59:07 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Chromium rebaselines after r88617. The test is now passing on all platforms.

* platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.
* platform/chromium-mac/fast/repaint/selection-after-remove-expected.png: Added.
* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt


Added Paths

trunk/LayoutTests/platform/chromium-mac/fast/repaint/selection-after-remove-expected.png
trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (88747 => 88748)

--- trunk/LayoutTests/ChangeLog	2011-06-14 01:46:22 UTC (rev 88747)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 01:59:07 UTC (rev 88748)
@@ -1,3 +1,11 @@
+2011-06-13  Ryosuke Niwa  
+
+Chromium rebaselines after r88617. The test is now passing on all platforms.
+
+* platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png: Added.
+* platform/chromium-mac/fast/repaint/selection-after-remove-expected.png: Added.
+* platform/chromium/test_expectations.txt:
+
 2011-06-13  Jessie Berlin  
 
 REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88747 => 88748)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 01:46:22 UTC (rev 88747)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 01:59:07 UTC (rev 88748)
@@ -1365,7 +1365,6 @@
 BUGCR23473 MAC : fast/repaint/search-field-cancel.html = IMAGE
 BUGCR23473 MAC : fast/repaint/selected-replaced.html = IMAGE
 BUGCR23473 MAC : fast/repaint/selection-after-delete.html = IMAGE
-BUGCR23473 MAC : fast/repaint/selection-after-remove.html = IMAGE
 BUGCR23473 MAC : fast/repaint/selection-clear.html = IMAGE
 BUGCR23473 MAC : fast/repaint/selection-gap-overflow-scroll.html = IMAGE
 BUGCR23473 MAC : fast/repaint/stacked-diacritics.html = IMAGE
@@ -3479,7 +3478,6 @@
 BUGCR79917 WIN LINUX : fast/repaint/float-overflow.html = IMAGE
 BUGCR79917 WIN LINUX : fast/repaint/layer-child-outline.html = IMAGE
 BUGCR79917 WIN LINUX : fast/repaint/reflection-repaint-test.html = IMAGE
-BUGCR79917 WIN LINUX : fast/repaint/selection-after-remove.html = IMAGE
 BUGCR79917 WIN LINUX : fast/repaint/table-cell-vertical-overflow.html = IMAGE
 BUGCR79917 WIN LINUX : fast/repaint/transform-absolute-child.html = IMAGE
 BUGCR79917 WIN LINUX : fast/repaint/transform-absolute-in-positioned-container.html = IMAGE


Added: trunk/LayoutTests/platform/chromium-mac/fast/repaint/selection-after-remove-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/repaint/selection-after-remove-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/chromium-mac-leopard/fast/repaint/selection-after-remove-expected.png
___

Added: svn:mime-type




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88747] trunk/LayoutTests

[jberlin]

Title: [88747] trunk/LayoutTests








Revision 88747
Author jber...@webkit.org
Date 2011-06-13 18:46:22 -0700 (Mon, 13 Jun 2011)


Log Message
REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,
compositing/tiling/huge-layer-add-remove-child.html failing on Windows 7 Release (Tests).
https://bugs.webkit.org/show_bug.cgi?id=62566

Add/update the (failing?) expected results for Windows in order to get the bots green.

* platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
* platform/win/compositing/tiling: Added.
* platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt


Added Paths

trunk/LayoutTests/platform/win/compositing/tiling/
trunk/LayoutTests/platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88746 => 88747)

--- trunk/LayoutTests/ChangeLog	2011-06-14 01:15:27 UTC (rev 88746)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 01:46:22 UTC (rev 88747)
@@ -1,3 +1,15 @@
+2011-06-13  Jessie Berlin  
+
+REGRESSION (r88579-r88581): compositing/iframes/invisible-nested-iframe-show.html,
+compositing/tiling/huge-layer-add-remove-child.html failing on Windows 7 Release (Tests).
+https://bugs.webkit.org/show_bug.cgi?id=62566
+
+Add/update the (failing?) expected results for Windows in order to get the bots green.
+
+* platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
+* platform/win/compositing/tiling: Added.
+* platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt: Added.
+
 2011-06-13  David Levin  
 
 Reviewed by Dmitry Titov.


Modified: trunk/LayoutTests/platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt (88746 => 88747)

--- trunk/LayoutTests/platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt	2011-06-14 01:15:27 UTC (rev 88746)
+++ trunk/LayoutTests/platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt	2011-06-14 01:46:22 UTC (rev 88747)
@@ -10,6 +10,7 @@
   (position 30.00 214.00)
   (bounds 210.00 210.00)
   (drawsContent 1)
+  (transform [1.00 0.00 0.00 0.00] [0.00 1.00 0.00 0.00] [0.00 0.00 1.00 0.00] [0.00 0.00 1.00 1.00])
 )
   )
 )


Added: trunk/LayoutTests/platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt (0 => 88747)

--- trunk/LayoutTests/platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt	2011-06-14 01:46:22 UTC (rev 88747)
@@ -0,0 +1,58 @@
+The yellow box should be large enough to scroll off the bottom. At the start there should be no child. After 100ms a red box is added and after 100ms more it should be removed. This tests that we can support very large compositing layers with dynamically added and removed child compositing layers.
+
+First (no children):
+(GraphicsLayer
+  (bounds 785.00 5129.00)
+  (children 1
+(GraphicsLayer
+  (bounds 785.00 5129.00)
+  (children 1
+(GraphicsLayer
+  (position 8.00 86.00)
+  (bounds 502.00 5002.00)
+  (usingTiledLayer 1)
+  (drawsContent 1)
+)
+  )
+)
+  )
+)
+
+
+Second (child added):
+(GraphicsLayer
+  (bounds 785.00 5129.00)
+  (children 1
+(GraphicsLayer
+  (bounds 785.00 5129.00)
+  (children 1
+(GraphicsLayer
+  (position 8.00 86.00)
+  (bounds 502.00 5002.00)
+  (usingTiledLayer 1)
+  (drawsContent 1)
+)
+  )
+)
+  )
+)
+
+
+Third (child removed):
+(GraphicsLayer
+  (bounds 785.00 5129.00)
+  (children 1
+(GraphicsLayer
+  (bounds 785.00 5129.00)
+  (children 1
+(GraphicsLayer
+  (position 8.00 86.00)
+  (bounds 502.00 5002.00)
+  (usingTiledLayer 1)
+  (drawsContent 1)
+)
+  )
+)
+  )
+)
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88746] trunk/LayoutTests

[levin]

Title: [88746] trunk/LayoutTests








Revision 88746
Author le...@chromium.org
Date 2011-06-13 18:15:27 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  David Levin  

Reviewed by Dmitry Titov.

fast/workers/worker-close.html is flaky on slower machines.
https://bugs.webkit.org/show_bug.cgi?id=62609

* fast/workers/worker-close.html: Move a setTimeout to start after
the response message is received to make the ordering of messages
deterministic.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/workers/worker-close.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88745 => 88746)

--- trunk/LayoutTests/ChangeLog	2011-06-14 01:13:56 UTC (rev 88745)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 01:15:27 UTC (rev 88746)
@@ -1,3 +1,14 @@
+2011-06-13  David Levin  
+
+Reviewed by Dmitry Titov.
+
+fast/workers/worker-close.html is flaky on slower machines.
+https://bugs.webkit.org/show_bug.cgi?id=62609
+
+* fast/workers/worker-close.html: Move a setTimeout to start after
+the response message is received to make the ordering of messages
+deterministic.
+
 2011-06-13  Ryosuke Niwa  
 
 Chromium Mac test expectation updates; Removed failing test expectations from


Modified: trunk/LayoutTests/fast/workers/worker-close.html (88745 => 88746)

--- trunk/LayoutTests/fast/workers/worker-close.html	2011-06-14 01:13:56 UTC (rev 88745)
+++ trunk/LayoutTests/fast/workers/worker-close.html	2011-06-14 01:15:27 UTC (rev 88746)
@@ -41,14 +41,14 @@
 worker.postMessage("close");
 worker.postMessage("ping");
 worker._onmessage_ = function(evt) {
-if (evt.data != "pong")
+if (evt.data != "pong") {
 log("PASS: Received message posted right after close() was invoked: " + evt.data);
-else {
+timeout = setTimeout(testErrorAfterClose, 1000);
+} else {
 log("FAIL: Received a message originated from a handler in the worker after the JS fragment with close() exited" + evt.data);
 done();
 }
 };
-timeout = setTimeout(testErrorAfterClose, 1000);
 }
 
 function testErrorAfterClose()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88745] trunk/Source

[simonjam]

Title: [88745] trunk/Source








Revision 88745
Author simon...@chromium.org
Date 2011-06-13 18:13:56 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  James Simonsen  

Reviewed by James Robinson.

[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162

* platform/chromium/PlatformBridge.h:
* platform/chromium/SystemTimeChromium.cpp:
(WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.
2011-06-13  James Simonsen  

Reviewed by James Robinson.

[Chromium] Implement monotonicallyIncreasingClock()
https://bugs.webkit.org/show_bug.cgi?id=62162

* public/WebKitClient.h:
(WebKit::WebKitClient::monotonicallyIncreasingTime): Added.
* src/PlatformBridge.cpp:
(WebCore::PlatformBridge::monotonicallyIncreasingTime): Added.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/PlatformBridge.h
trunk/Source/WebCore/platform/chromium/SystemTimeChromium.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebKitClient.h
trunk/Source/WebKit/chromium/src/PlatformBridge.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88744 => 88745)

--- trunk/Source/WebCore/ChangeLog	2011-06-14 01:10:31 UTC (rev 88744)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 01:13:56 UTC (rev 88745)
@@ -1,3 +1,14 @@
+2011-06-13  James Simonsen  
+
+Reviewed by James Robinson.
+
+[Chromium] Implement monotonicallyIncreasingClock()
+https://bugs.webkit.org/show_bug.cgi?id=62162
+
+* platform/chromium/PlatformBridge.h:
+* platform/chromium/SystemTimeChromium.cpp:
+(WebCore::monotonicallyIncreasingTime): Use Chrome's implementation.
+
 2011-06-13  Steve Block  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebCore/platform/chromium/PlatformBridge.h (88744 => 88745)

--- trunk/Source/WebCore/platform/chromium/PlatformBridge.h	2011-06-14 01:10:31 UTC (rev 88744)
+++ trunk/Source/WebCore/platform/chromium/PlatformBridge.h	2011-06-14 01:13:56 UTC (rev 88745)
@@ -246,6 +246,7 @@
 
 // SystemTime -
 static double currentTime();
+static double monotonicallyIncreasingTime();
 
 // Theming 
 #if OS(WINDOWS)


Modified: trunk/Source/WebCore/platform/chromium/SystemTimeChromium.cpp (88744 => 88745)

--- trunk/Source/WebCore/platform/chromium/SystemTimeChromium.cpp	2011-06-14 01:10:31 UTC (rev 88744)
+++ trunk/Source/WebCore/platform/chromium/SystemTimeChromium.cpp	2011-06-14 01:13:56 UTC (rev 88745)
@@ -45,12 +45,7 @@
 
 double monotonicallyIncreasingTime()
 {
-static double lastTime = 0;
-double currentTimeNow = currentTime();
-if (currentTimeNow < lastTime)
-return lastTime;
-lastTime = currentTimeNow;
-return currentTimeNow;
+return PlatformBridge::monotonicallyIncreasingTime();
 }
 
 float userIdleTime()


Modified: trunk/Source/WebKit/chromium/ChangeLog (88744 => 88745)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-06-14 01:10:31 UTC (rev 88744)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-06-14 01:13:56 UTC (rev 88745)
@@ -1,3 +1,15 @@
+2011-06-13  James Simonsen  
+
+Reviewed by James Robinson.
+
+[Chromium] Implement monotonicallyIncreasingClock()
+https://bugs.webkit.org/show_bug.cgi?id=62162
+
+* public/WebKitClient.h:
+(WebKit::WebKitClient::monotonicallyIncreasingTime): Added.
+* src/PlatformBridge.cpp:
+(WebCore::PlatformBridge::monotonicallyIncreasingTime): Added.
+
 2011-06-13  Jian Li  
 
 Reviewed by David Levin.


Modified: trunk/Source/WebKit/chromium/public/WebKitClient.h (88744 => 88745)

--- trunk/Source/WebKit/chromium/public/WebKitClient.h	2011-06-14 01:10:31 UTC (rev 88744)
+++ trunk/Source/WebKit/chromium/public/WebKitClient.h	2011-06-14 01:13:56 UTC (rev 88745)
@@ -266,6 +266,11 @@
 // Wall clock time in seconds since the epoch.
 virtual double currentTime() { return 0; }
 
+// Monotonically increasing time in seconds from an arbitrary fixed point in the past.
+// This function is expected to return at least millisecond-precision values. For this reason,
+// it is recommended that the fixed point be no further in the past than the epoch.
+virtual double monotonicallyIncreasingTime() { return 0; }
+
 virtual void cryptographicallyRandomValues(unsigned char* buffer, size_t length)
 {
 // WebKit clients must implement this funcion if they use cryptographic randomness.


Modified: trunk/Source/WebKit/chromium/src/PlatformBridge.cpp (88744 => 88745)

--- trunk/Source/WebKit/chromium/src/PlatformBridge.cpp	2011-06-14 01:10:31 UTC (rev 88744)
+++ trunk/Source/WebKit/chromium/src/PlatformBridge.cpp	2011-06-14 01:13:56 UTC (rev 88745)
@@ -701,6 +701,11 @@
 return webKitClient()->curr

[webkit-changes] [88744] trunk/LayoutTests

[rniwa]

Title: [88744] trunk/LayoutTests








Revision 88744
Author rn...@webkit.org
Date 2011-06-13 18:10:31 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Chromium Mac test expectation updates; Removed failing test expectations from
various tests because they seem to be passing now.

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88743 => 88744)

--- trunk/LayoutTests/ChangeLog	2011-06-14 01:00:39 UTC (rev 88743)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 01:10:31 UTC (rev 88744)
@@ -1,5 +1,12 @@
 2011-06-13  Ryosuke Niwa  
 
+Chromium Mac test expectation updates; Removed failing test expectations from
+various tests because they seem to be passing now.
+
+* platform/chromium/test_expectations.txt:
+
+2011-06-13  Ryosuke Niwa  
+
 Skip test added by r88578 on GTK per bug 62585.
 
 * platform/gtk/Skipped:


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88743 => 88744)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 01:00:39 UTC (rev 88743)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-14 01:10:31 UTC (rev 88744)
@@ -3529,7 +3529,7 @@
 BUGCR79917 WIN LINUX : tables/mozilla_expected_failures/marvin/backgr_position-table-row.html = IMAGE
 BUGCR79917 WIN LINUX : transforms/svg-vs-css.xhtml = IMAGE
 
-BUGWK58924 MAC : plugins/mouse-click-iframe-to-plugin.html = TIMEOUT
+BUGWK58924 MAC : plugins/mouse-click-iframe-to-plugin.html = TIMEOUT PASS
 
 BUGWK60099 DEBUG : fast/dom/Attr/access-after-element-destruction.html = CRASH PASS
 BUGWK60096 DEBUG : fast/css/last-child-pseudo-class.html = TEXT PASS
@@ -3762,7 +3762,7 @@
 
 BUGCR47036 DEBUG : html5lib/runner.html = PASS TIMEOUT
 
-BUGCR82419 : svg/custom/fill-opacity-update.svg = IMAGE
+BUGCR82419 WIN LINUX : svg/custom/fill-opacity-update.svg = IMAGE
 
 // New pixel tests added for bug 58999. These will fail on windows and linux until bug
 // 60342 is fixed and the 58999 fix enabled for skia.
@@ -3923,12 +3923,12 @@
 // After r87526, these all have extra scrollbars where the platform/mac expectations do not.
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-absolute-size-2.xhtml = IMAGE+TEXT IMAGE
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-absolute-size.xhtml = IMAGE+TEXT IMAGE
-BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml = IMAGE+TEXT
+BUGWK61664 WIN LINUX LEOPARD : svg/zoom/page/zoom-svg-through-object-with-huge-size.xhtml = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-override-size.html = IMAGE+TEXT
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-text.xhtml = IMAGE+TEXT
 BUGWK61664 LINUX : svg/zoom/page/relative-sized-document-scrollbars.svg = IMAGE
 BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-percentage-size.xhtml = PASS IMAGE+TEXT IMAGE
-BUGWK61664 : svg/zoom/page/zoom-svg-through-object-with-auto-size.html = IMAGE+TEXT
+BUGWK61664 WIN LINUX LEOPARD : svg/zoom/page/zoom-svg-through-object-with-auto-size.html = IMAGE+TEXT
 
 BUGCR84317 DEBUG : svg/wicd/test-scalable-background-image1.xhtml = CRASH
 
@@ -3948,9 +3948,6 @@
 BUGWK59782 WIN LINUX DEBUG : svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html = TIMEOUT
 BUGWK59782 WIN LINUX DEBUG : svg/filters/feDropShadow.svg = TIMEOUT
 
-// Register protocol handler doesn't seem to be enabled on Mac.
-BUGCR84161 MAC : fast/dom/register-protocol-handler.html = TEXT
-
 BUGWK61936 : fast/filesystem/filesystem-no-callback-null-ptr-crash.html = CRASH PASS
 BUGABARTH LINUX : svg/text/scaling-font-with-geometric-precision.html = IMAGE PASS
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88743] branches/chromium/782/Source/WebKit/chromium

[jianli]

Title: [88743] branches/chromium/782/Source/WebKit/chromium








Revision 88743
Author jia...@chromium.org
Date 2011-06-13 18:00:39 -0700 (Mon, 13 Jun 2011)


Log Message
Merge 88738 - [Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592

Reviewed by David Levin.

* public/WebNotification.h:
* src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.

TBR=jia...@chromium.org
BUG=84660
Review URL: http://codereview.chromium.org/7148005

Modified Paths

branches/chromium/782/Source/WebKit/chromium/public/WebNotification.h
branches/chromium/782/Source/WebKit/chromium/src/WebNotification.cpp




Diff

Modified: branches/chromium/782/Source/WebKit/chromium/public/WebNotification.h (88742 => 88743)

--- branches/chromium/782/Source/WebKit/chromium/public/WebNotification.h	2011-06-14 00:58:17 UTC (rev 88742)
+++ branches/chromium/782/Source/WebKit/chromium/public/WebNotification.h	2011-06-14 01:00:39 UTC (rev 88743)
@@ -39,6 +39,10 @@
 namespace WTF { template  class PassRefPtr; }
 #endif
 
+namespace WTF {
+class AtomicString;
+}
+
 namespace WebKit {
 
 class WebNotificationPrivate;
@@ -104,6 +108,7 @@
 
 private:
 void assign(WebNotificationPrivate*);
+void dispatchEvent(const WTF::AtomicString& type);
 WebNotificationPrivate* m_private;
 };
 


Modified: branches/chromium/782/Source/WebKit/chromium/src/WebNotification.cpp (88742 => 88743)

--- branches/chromium/782/Source/WebKit/chromium/src/WebNotification.cpp	2011-06-14 00:58:17 UTC (rev 88742)
+++ branches/chromium/782/Source/WebKit/chromium/src/WebNotification.cpp	2011-06-14 01:00:39 UTC (rev 88743)
@@ -116,29 +116,35 @@
 
 void WebNotification::dispatchDisplayEvent()
 {
-RefPtr event = Event::create("display", false, true);
-m_private->dispatchEvent(event.release());
+dispatchEvent("display");
 }
 
 void WebNotification::dispatchErrorEvent(const WebKit::WebString& /* errorMessage */)
 {
 // FIXME: errorMessage not supported by WebCore yet
-RefPtr event = Event::create(eventNames().errorEvent, false, true);
-m_private->dispatchEvent(event.release());
+dispatchEvent(eventNames().errorEvent);
 }
 
 void WebNotification::dispatchCloseEvent(bool /* byUser */)
 {
 // FIXME: byUser flag not supported by WebCore yet
-RefPtr event = Event::create(eventNames().closeEvent, false, true);
-m_private->dispatchEvent(event.release());
+dispatchEvent(eventNames().closeEvent);
 }
 
 void WebNotification::dispatchClickEvent()
 {
 // Make sure clicks on notifications are treated as user gestures.
 UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
-RefPtr event = Event::create(eventNames().clickEvent, false, true);
+dispatchEvent(eventNames().clickEvent);
+}
+
+void WebNotification::dispatchEvent(const WTF::AtomicString& type)
+{
+// Do not dispatch if the context is gone.
+if (!m_private->scriptExecutionContext())
+return;
+
+RefPtr event = Event::create(type, false, true);
 m_private->dispatchEvent(event.release());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88742] trunk/LayoutTests

[rniwa]

Title: [88742] trunk/LayoutTests








Revision 88742
Author rn...@webkit.org
Date 2011-06-13 17:58:17 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Skip test added by r88578 on GTK per bug 62585.

* platform/gtk/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (88741 => 88742)

--- trunk/LayoutTests/ChangeLog	2011-06-14 00:53:47 UTC (rev 88741)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 00:58:17 UTC (rev 88742)
@@ -1,3 +1,9 @@
+2011-06-13  Ryosuke Niwa  
+
+Skip test added by r88578 on GTK per bug 62585.
+
+* platform/gtk/Skipped:
+
 2011-06-13  Jessie Berlin  
 
 Add Windows-specific pixel and text results to account for the different design of the


Modified: trunk/LayoutTests/platform/gtk/Skipped (88741 => 88742)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-06-14 00:53:47 UTC (rev 88741)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-06-14 00:58:17 UTC (rev 88742)
@@ -1541,3 +1541,7 @@
 # Failing because GTK DumpRenderTree doesn't block external network requests like the
 # willSendRequest method does for other ports (bug 62585).
 fast/workers/worker-crash-with-invalid-location-pretty-diff.html
+
+# [GTK] DumpRenderTree doesn't block external requests
+# https://bugs.webkit.org/show_bug.cgi?id=62585
+fast/workers/worker-crash-with-invalid-location.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88741] trunk/Source/WebCore

[steveblock]

Title: [88741] trunk/Source/WebCore








Revision 88741
Author stevebl...@google.com
Date 2011-06-13 17:53:47 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Steve Block  

Reviewed by Darin Adler.

Remove Android defines from WebCore/config.h
https://bugs.webkit.org/show_bug.cgi?id=62602

No new tests, build cleanup only.

* config.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/config.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (88740 => 88741)

--- trunk/Source/WebCore/ChangeLog	2011-06-14 00:42:09 UTC (rev 88740)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 00:53:47 UTC (rev 88741)
@@ -1,3 +1,14 @@
+2011-06-13  Steve Block  
+
+Reviewed by Darin Adler.
+
+Remove Android defines from WebCore/config.h
+https://bugs.webkit.org/show_bug.cgi?id=62602
+
+No new tests, build cleanup only.
+
+* config.h:
+
 2011-06-13  Adam Barth  
 
 Reviewed by David Levin.


Modified: trunk/Source/WebCore/config.h (88740 => 88741)

--- trunk/Source/WebCore/config.h	2011-06-14 00:42:09 UTC (rev 88740)
+++ trunk/Source/WebCore/config.h	2011-06-14 00:53:47 UTC (rev 88741)
@@ -109,41 +109,6 @@
 
 #endif /* OS(WINDOWS) */
 
-#if PLATFORM(ANDROID)
-// Android uses a single set of include directories when building WebKit and
-// _javascript_Core. Since WebCore/ is included before _javascript_Core/, Android
-// includes _javascript_Core/config.h explicitly here to make sure it gets picked
-// up.
-#include <_javascript_Core/config.h>
-
-#define WEBCORE_NAVIGATOR_VENDOR "Google Inc."
-// This must be defined before we include FastMalloc.h, below.
-#define USE_SYSTEM_MALLOC 1
-#define LOG_DISABLED 1
-#include 
-// Central place to set which optional features Android uses.
-#define ENABLE_CHANNEL_MESSAGING 1
-#define ENABLE_DOM_STORAGE 1
-#undef ENABLE_FTPDIR  // Enabled by default in Platform.h
-#define ENABLE_FTPDIR 0
-#ifndef ENABLE_SVG
-#define ENABLE_SVG 0
-#endif
-#define ENABLE_VIDEO 1
-#define ENABLE_WORKERS 1
-#define ENABLE_XBL 0
-#define ENABLE_XHTMLMP 0
-#define ENABLE_XPATH 0
-#define ENABLE_XSLT 0
-#define ENABLE_ARCHIVE 0
-#define ENABLE_OFFLINE_WEB_APPLICATIONS 1
-#undef ENABLE_GEOLOCATION  // Disabled by default in Platform.h
-#define ENABLE_GEOLOCATION 1
-#undef ENABLE_INSPECTOR  // Enabled by default in Platform.h
-#define ENABLE_INSPECTOR 0
-#define ENABLE_EVENT_SOURCE 0
-#endif /* PLATFORM(ANDROID) */
-
 #ifdef __cplusplus
 
 // These undefs match up with defines in WebCorePrefix.h for Mac OS X.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88740] trunk/Source/WebCore

[abarth]

Title: [88740] trunk/Source/WebCore








Revision 88740
Author aba...@webkit.org
Date 2011-06-13 17:42:09 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Adam Barth  

Reviewed by David Levin.

Remove redundant "true" parameter to scheduleLocationChange
https://bugs.webkit.org/show_bug.cgi?id=62612

This parameter defaults to true anyway.

* loader/appcache/ApplicationCacheGroup.cpp:
(WebCore::ApplicationCacheGroup::selectCache):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88739 => 88740)

--- trunk/Source/WebCore/ChangeLog	2011-06-14 00:39:53 UTC (rev 88739)
+++ trunk/Source/WebCore/ChangeLog	2011-06-14 00:42:09 UTC (rev 88740)
@@ -1,3 +1,15 @@
+2011-06-13  Adam Barth  
+
+Reviewed by David Levin.
+
+Remove redundant "true" parameter to scheduleLocationChange
+https://bugs.webkit.org/show_bug.cgi?id=62612
+
+This parameter defaults to true anyway.
+
+* loader/appcache/ApplicationCacheGroup.cpp:
+(WebCore::ApplicationCacheGroup::selectCache):
+
 2011-06-13  Kentaro Hara  
 
 Reviewed by Alexey Proskuryakov.


Modified: trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp (88739 => 88740)

--- trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp	2011-06-14 00:39:53 UTC (rev 88739)
+++ trunk/Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp	2011-06-14 00:42:09 UTC (rev 88740)
@@ -178,7 +178,7 @@
 // Restart the current navigation from the top of the navigation algorithm, undoing any changes that were made
 // as part of the initial load.
 // The navigation will not result in the same resource being loaded, because "foreign" entries are never picked during navigation.
-frame->navigationScheduler()->scheduleLocationChange(frame->document()->securityOrigin(), documentLoader->url(), frame->loader()->referrer(), true);
+frame->navigationScheduler()->scheduleLocationChange(frame->document()->securityOrigin(), documentLoader->url(), frame->loader()->referrer());
 }
 
 return;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88739] trunk/LayoutTests

[jberlin]

Title: [88739] trunk/LayoutTests








Revision 88739
Author jber...@webkit.org
Date 2011-06-13 17:39:53 -0700 (Mon, 13 Jun 2011)


Log Message
Add Windows-specific pixel and text results to account for the different design of the
ying-yang character on Windows (and of course to get the bots green).

* platform/win/svg/hixie/intrinsic: Added.
* platform/win/svg/hixie/intrinsic/003-expected.png: Added.
* platform/win/svg/hixie/intrinsic/003-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/win/svg/hixie/intrinsic/
trunk/LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.png
trunk/LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88738 => 88739)

--- trunk/LayoutTests/ChangeLog	2011-06-14 00:38:36 UTC (rev 88738)
+++ trunk/LayoutTests/ChangeLog	2011-06-14 00:39:53 UTC (rev 88739)
@@ -1,3 +1,12 @@
+2011-06-13  Jessie Berlin  
+
+Add Windows-specific pixel and text results to account for the different design of the
+ying-yang character on Windows (and of course to get the bots green).
+
+* platform/win/svg/hixie/intrinsic: Added.
+* platform/win/svg/hixie/intrinsic/003-expected.png: Added.
+* platform/win/svg/hixie/intrinsic/003-expected.txt: Added.
+
 2011-06-13  Kentaro Hara  
 
 Reviewed by Alexey Proskuryakov.


Added: trunk/LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.txt (0 => 88739)

--- trunk/LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/win/svg/hixie/intrinsic/003-expected.txt	2011-06-14 00:39:53 UTC (rev 88739)
@@ -0,0 +1,15 @@
+layer at (0,0) size 800x600
+  RenderView at (0,0) size 800x600
+layer at (0,0) size 800x266
+  RenderBlock {HTML} at (0,0) size 800x266 [color=#80] [bgcolor=#FF]
+RenderBody {BODY} at (8,16) size 784x234
+  RenderBlock {DIV} at (0,0) size 100x200
+RenderBlock {P} at (0,0) size 100x200
+  RenderEmbeddedObject {OBJECT} at (0,0) size 200x200
+layer at (0,0) size 100x200
+  RenderView at (0,0) size 100x200
+layer at (0,0) size 100x200
+  RenderSVGRoot {svg} at (0,0) size 0x0
+  RenderBlock {P} at (0,216) size 784x18
+RenderText {#text} at (0,0) size 424x18
+  text run at (0,0) width 424: "There should be a complete unbroken yin-yang symbol (\x{262F}) above."






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88738] trunk/Source/WebKit/chromium

[jianli]

Title: [88738] trunk/Source/WebKit/chromium








Revision 88738
Author jia...@chromium.org
Date 2011-06-13 17:38:36 -0700 (Mon, 13 Jun 2011)


Log Message
[Chromium] WebNotification should check if ScriptExecutionContext is gone
before dispatching events.
https://bugs.webkit.org/show_bug.cgi?id=62592

Reviewed by David Levin.

* public/WebNotification.h:
* src/WebNotification.cpp:
(WebKit::WebNotification::dispatchDisplayEvent):
(WebKit::WebNotification::dispatchErrorEvent):
(WebKit::WebNotification::dispatchCloseEvent):
(WebKit::WebNotification::dispatchClickEvent):
(WebKit::WebNotification::dispatchEvent): Added a helper method to check
the context and dispatch an event.

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebNotification.h
trunk/Source/WebKit/chromium/src/WebNotification.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (88737 => 88738)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-06-14 00:22:50 UTC (rev 88737)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-06-14 00:38:36 UTC (rev 88738)
@@ -1,3 +1,20 @@
+2011-06-13  Jian Li  
+
+Reviewed by David Levin.
+
+[Chromium] WebNotification should check if ScriptExecutionContext is gone
+before dispatching events.
+https://bugs.webkit.org/show_bug.cgi?id=62592
+
+* public/WebNotification.h:
+* src/WebNotification.cpp:
+(WebKit::WebNotification::dispatchDisplayEvent):
+(WebKit::WebNotification::dispatchErrorEvent):
+(WebKit::WebNotification::dispatchCloseEvent):
+(WebKit::WebNotification::dispatchClickEvent):
+(WebKit::WebNotification::dispatchEvent): Added a helper method to check
+the context and dispatch an event.
+
 2011-06-13  Dmitry Lomov  
 
 Reviewed by Adam Barth.


Modified: trunk/Source/WebKit/chromium/public/WebNotification.h (88737 => 88738)

--- trunk/Source/WebKit/chromium/public/WebNotification.h	2011-06-14 00:22:50 UTC (rev 88737)
+++ trunk/Source/WebKit/chromium/public/WebNotification.h	2011-06-14 00:38:36 UTC (rev 88738)
@@ -39,6 +39,10 @@
 namespace WTF { template  class PassRefPtr; }
 #endif
 
+namespace WTF {
+class AtomicString;
+}
+
 namespace WebKit {
 
 class WebNotificationPrivate;
@@ -104,6 +108,7 @@
 
 private:
 void assign(WebNotificationPrivate*);
+void dispatchEvent(const WTF::AtomicString& type);
 WebNotificationPrivate* m_private;
 };
 


Modified: trunk/Source/WebKit/chromium/src/WebNotification.cpp (88737 => 88738)

--- trunk/Source/WebKit/chromium/src/WebNotification.cpp	2011-06-14 00:22:50 UTC (rev 88737)
+++ trunk/Source/WebKit/chromium/src/WebNotification.cpp	2011-06-14 00:38:36 UTC (rev 88738)
@@ -116,29 +116,35 @@
 
 void WebNotification::dispatchDisplayEvent()
 {
-RefPtr event = Event::create("display", false, true);
-m_private->dispatchEvent(event.release());
+dispatchEvent("display");
 }
 
 void WebNotification::dispatchErrorEvent(const WebKit::WebString& /* errorMessage */)
 {
 // FIXME: errorMessage not supported by WebCore yet
-RefPtr event = Event::create(eventNames().errorEvent, false, true);
-m_private->dispatchEvent(event.release());
+dispatchEvent(eventNames().errorEvent);
 }
 
 void WebNotification::dispatchCloseEvent(bool /* byUser */)
 {
 // FIXME: byUser flag not supported by WebCore yet
-RefPtr event = Event::create(eventNames().closeEvent, false, true);
-m_private->dispatchEvent(event.release());
+dispatchEvent(eventNames().closeEvent);
 }
 
 void WebNotification::dispatchClickEvent()
 {
 // Make sure clicks on notifications are treated as user gestures.
 UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture);
-RefPtr event = Event::create(eventNames().clickEvent, false, true);
+dispatchEvent(eventNames().clickEvent);
+}
+
+void WebNotification::dispatchEvent(const WTF::AtomicString& type)
+{
+// Do not dispatch if the context is gone.
+if (!m_private->scriptExecutionContext())
+return;
+
+RefPtr event = Event::create(type, false, true);
 m_private->dispatchEvent(event.release());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88737] trunk

[dominicc]

Title: [88737] trunk








Revision 88737
Author domin...@chromium.org
Date 2011-06-13 17:22:50 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Kentaro Hara  

Reviewed by Alexey Proskuryakov.

Add a new test for checking rounding error in printing codes
https://bugs.webkit.org/show_bug.cgi?id=61256

Add a new test (printing/page-count-with-one-word.html). This test
checks if only one page is printed for an HTML page with one word for
various paper sizes around A4 portrait size, i.e. [530px, 560px) for
width and [730px, 760px) for height.

* printing/page-count-with-one-word-expected.txt: Added.
* printing/page-count-with-one-word.html: Added.
2011-06-13  Kentaro Hara  

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
PrintContext::computePageRects() and PrintContext::begin()
use resizePageRectsKeepingRatio() to expand/shrink a page.

Test: printing/page-count-with-one-word.html

* WebCore.exp.in:
* page/Frame.cpp:
(WebCore::Frame::resizePageRectsKeepingRatio):
* page/Frame.h:
* page/PrintContext.cpp:
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::begin):
2011-06-13  Kentaro Hara  

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]
and [WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]
use resizePageRectsKeepingRatio() to expand/shrink a page.

Test: printing/page-count-with-one-word.html

* WebView/WebHTMLView.mm:
(-[WebHTMLView _web_setPrintingModeRecursive]):
(-[WebHTMLView _web_clearPrintingModeRecursive]):
(-[WebHTMLView _web_setPrintingModeRecursiveAndAdjustViewSize]):
(-[WebHTMLView _beginPrintModeWithMinimumPageWidth:height:maximumShrinkRatio:]):
(-[WebHTMLView _beginPrintModeWithPageWidth:height:shrinkToFit:]):
(-[WebHTMLView _endPrintMode]):
(-[WebHTMLView _beginScreenPaginationModeWithPageSize:shrinkToFit:]):
(-[WebHTMLView _endScreenPaginationMode]):
(-[WebHTMLView layoutToMinimumPageWidth:height:maximumShrinkRatio:adjustingViewSize:]):
(-[WebHTMLView layout]):
(-[WebHTMLView _setPrinting:minimumPageLogicalWidth:logicalHeight:maximumShrinkRatio:adjustViewSize:paginateScreenContent:]):
(-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]):
(-[WebHTMLView setPageWidthForPrinting:]):
2011-06-13  Kentaro Hara  

Reviewed by Alexey Proskuryakov.

Add resizePageRectsKeepingRatio(), which expands/shrinks a page, keeping the ratio of the original page
https://bugs.webkit.org/show_bug.cgi?id=61256

In order to prevent rounding error caused by expanding/shrinking a page
using different calculation here and there, I added a common calculation
method, resizePageRectsKeepingRatio(), which expands/shrinks a page,
keeping the ratio of width and height of the original page.
WebFrame::setInPrintingMode() uses resizePageRectsKeepingRatio() to
expand/shrink a page.

Test: printing/page-count-with-one-word.html

* WebFrame.cpp:
(WebFrame::setPrinting):
(WebFrame::setInPrintingMode):
* WebFrame.h:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/Frame.h
trunk/Source/WebCore/page/PrintContext.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebFrame.cpp
trunk/Source/WebKit/win/WebFrame.h


Added Paths

trunk/LayoutTests/printing/page-count-with-one-word-expected.txt
trunk/LayoutTests/printing/page-count-with-one-word.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88736 => 88737)

--- trunk/LayoutTests/ChangeLog	2011-06-14 00:11:11 UTC (rev 88736)
+++ trunk/LayoutTests/ChangeLog	

[webkit-changes] [88736] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

[mrobinson]

Title: [88736] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk








Revision 88736
Author mrobin...@webkit.org
Date 2011-06-13 17:11:11 -0700 (Mon, 13 Jun 2011)


Log Message
Merging r88734

Modified Paths

releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk.types
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkithittestresult.cpp
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkiticondatabase.cpp
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebsettings.cpp
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/webkit/webkitwebview.cpp




Diff

Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog (88735 => 88736)

--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog	2011-06-14 00:10:23 UTC (rev 88735)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog	2011-06-14 00:11:11 UTC (rev 88736)
@@ -1,5 +1,23 @@
 2011-06-13  Martin Robinson  
 
+Reviewed by Gustavo Noronha Silva.
+
+Update gtkdoc files and inline documentation to reduce gtkdoc errors
+and ensure complete documentation output.
+
+* docs/webkitgtk-sections.txt: Add missing sections to the list and remove
+unneeded sections.
+* docs/webkitgtk.types: Update the types list.
+* webkit/webkithittestresult.cpp: Fix inline documentation errors.
+(webkit_hit_test_result_class_init): Ditto.
+* webkit/webkiticondatabase.cpp: Ditto.
+* webkit/webkitwebsettings.cpp: Ditto.
+(webkit_web_settings_class_init): Ditto.
+* webkit/webkitwebview.cpp: Ditto.
+(webkit_web_view_class_init): Ditto.
+
+2011-06-13  Martin Robinson  
+
 Reviewed by Xan Lopez.
 
 Update the list of ignored GTK+ header files for the documentation


Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt (88735 => 88736)

--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt	2011-06-14 00:10:23 UTC (rev 88735)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt	2011-06-14 00:11:11 UTC (rev 88736)
@@ -1,8 +1,8 @@
 
 webkitwebsettings
 WebKitWebSettings
-WebKitEditingBehavior
 WebKitWebSettings
+WebKitEditingBehavior
 webkit_web_settings_copy
 webkit_web_settings_new
 webkit_web_settings_get_user_agent
@@ -14,10 +14,8 @@
 WEBKIT_IS_WEB_SETTINGS_CLASS
 WEBKIT_WEB_SETTINGS_GET_CLASS
 
-webkit_web_settings_get_type
-WebKitWebSettingsPrivate
-WebKitWebSettings
 WebKitWebSettingsClass
+webkit_web_settings_get_type
 
 
 
@@ -51,7 +49,6 @@
 
 WebKitWebBackForwardListPrivate
 webkit_web_back_forward_list_get_type
-WebKitWebBackForwardList
 WebKitWebBackForwardListClass
 
 
@@ -78,7 +75,6 @@
 
 webkit_web_history_item_get_type
 WebKitWebHistoryItemPrivate
-WebKitWebHistoryItem
 WebKitWebHistoryItemClass
 
 
@@ -120,7 +116,6 @@
 
 WebKitWebFramePrivate
 webkit_web_frame_get_type
-WebKitWebFrame
 WebKitWebFrameClass
 
 
@@ -153,7 +148,6 @@
 WEBKIT_TYPE_DOWNLOAD
 
 webkit_download_get_type
-WebKitDownload
 WebKitDownloadClass
 WebKitDownloadPrivate
 
@@ -178,7 +172,6 @@
 WEBKIT_IS_SECURITY_ORIGIN_CLASS
 WEBKIT_TYPE_SECURITY_ORIGIN
 
-WebKitSecurityOrigin
 WebKitSecurityOriginClass
 WebKitSecurityOriginPrivate
 
@@ -196,9 +189,7 @@
 WEBKIT_IS_HIT_TEST_RESULT_CLASS
 WEBKIT_TYPE_HIT_TEST_RESULT
 
-WebKitHitTestResult
 WebKitHitTestResultClass
-WebKitHitTestResultContext
 WebKitHitTestResultPrivate
 webkit_hit_test_result_get_type
 
@@ -225,7 +216,6 @@
 WEBKIT_WEB_DATA_SOURCE_CLASS
 WEBKIT_WEB_DATA_SOURCE_GET_CLASS
 
-WebKitWebDataSource
 WebKitWebDataSourceClass
 WebKitWebDataSourcePrivate
 webkit_web_data_source_new_with_request
@@ -251,7 +241,6 @@
 WEBKIT_WEB_DATABASE_CLASS
 WEBKIT_WEB_DATABASE_GET_CLASS
 
-WebKitWebDatabase
 WebKitWebDatabaseClass
 WebKitWebDatabasePrivate
 webkit_web_database_get_type
@@ -270,7 +259,6 @@
 WEBKIT_TYPE_SOUP_AUTH_DIALOG
 
 webkit_soup_auth_dialog_get_type
-WebKitSoupAuthDialog
 WebKitSoupAuthDialogClass
 
 
@@ -293,7 +281,6 @@
 
 webkit_web_inspector_get_type
 WebKitWebInspectorPrivate
-WebKitWebInspector
 WebKitWebInspectorClass
 
 
@@ -318,7 +305,6 @@
 WEBKIT_WEB_NAVIGATION_ACTION_CLASS
 WEBKIT_WEB_NAVIGATION_ACTION_GET_CLASS
 
-WebKitWebNavigationAction
 WebKitWebNavigationActionClass
 WebKitWebNavigationActionPrivate
 
@@ -339,7 +325,6 @@
 WEBKIT_WEB_POLICY_DECISION_CLASS
 WEBKIT_WEB_POLICY_DECISION_GET_CLASS
 
-WebKitWebPolicyDecision
 WebKitWebPolicyDecisionClass
 WebKitWebPolicyDecisionPrivate
 
@@ -359,7 +344,6 @@
 WEBKIT_GEOLOCATION_POLICY_DECISION_CLASS
 WEBKIT_GEOLOCATION_POLICY_DECISION_GET_CLASS
 
-WebKitGeolocationPolicyDecision
 WebKitGeolocationPolicyDecisionClass
 WebKitGeolocationPolicyDecisionPrivate
 
@@ -382,7 +366,6 @@
 
 webkit_network_request_get_type
 WebKitNetworkRequestPrivate
-WebKitNetworkRequest
 WebKitNetworkRequestClass
 
 
@@ -404,7 +38

[webkit-changes] [88735] trunk/Source/WebKit2

[andersca]

Title: [88735] trunk/Source/WebKit2








Revision 88735
Author ander...@apple.com
Date 2011-06-13 17:10:23 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Anders Carlsson  

Reviewed by Sam Weinig.

Crash when trying to use Netflix Watch Instantly with Silverlight 3
https://bugs.webkit.org/show_bug.cgi?id=62611


* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
Get the plug-in version string instead of the version number.

(WebKit::PluginVersion::isValid):
(WebKit::PluginVersion::PluginVersion):
(WebKit::PluginVersion::parse):
(WebKit::PluginVersion::isLessThan):
Add a new PluginVersion class that represents a plug-in version. The idea is
that this class be made cross platform.

(WebKit::NetscapePluginModule::determineQuirks):
Add the ReturnsNonRetainedScriptableNPObject quirk for versions of Silverlight less than 4.

* Shared/Plugins/PluginQuirks.h:
Add the ReturnsNonRetainedScriptableNPObject quirk.

* UIProcess/Plugins/PluginInfoStore.h:
Use a version string. Eventually this should hold the PluginVersion class we added.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginScriptableNPObject):
If the plug-in has the ReturnsNonRetainedScriptableNPObject quirk, do an extra retain.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm
trunk/Source/WebKit2/Shared/Plugins/PluginQuirks.h
trunk/Source/WebKit2/UIProcess/Plugins/PluginInfoStore.h
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88734 => 88735)

--- trunk/Source/WebKit2/ChangeLog	2011-06-14 00:09:47 UTC (rev 88734)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-14 00:10:23 UTC (rev 88735)
@@ -1,3 +1,35 @@
+2011-06-13  Anders Carlsson  
+
+Reviewed by Sam Weinig.
+
+Crash when trying to use Netflix Watch Instantly with Silverlight 3
+https://bugs.webkit.org/show_bug.cgi?id=62611
+
+
+* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
+(WebKit::NetscapePluginModule::getPluginInfo):
+Get the plug-in version string instead of the version number.
+
+(WebKit::PluginVersion::isValid):
+(WebKit::PluginVersion::PluginVersion):
+(WebKit::PluginVersion::parse):
+(WebKit::PluginVersion::isLessThan):
+Add a new PluginVersion class that represents a plug-in version. The idea is
+that this class be made cross platform.
+
+(WebKit::NetscapePluginModule::determineQuirks):
+Add the ReturnsNonRetainedScriptableNPObject quirk for versions of Silverlight less than 4.
+
+* Shared/Plugins/PluginQuirks.h:
+Add the ReturnsNonRetainedScriptableNPObject quirk.
+
+* UIProcess/Plugins/PluginInfoStore.h:
+Use a version string. Eventually this should hold the PluginVersion class we added.
+
+* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+(WebKit::NetscapePlugin::pluginScriptableNPObject):
+If the plug-in has the ReturnsNonRetainedScriptableNPObject quirk, do an extra retain.
+
 2011-06-13  Ryuan Choi  
 
 Reviewed by Kenneth Rohde Christiansen.


Modified: trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm (88734 => 88735)

--- trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm	2011-06-14 00:09:47 UTC (rev 88734)
+++ trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm	2011-06-14 00:10:23 UTC (rev 88735)
@@ -364,7 +364,10 @@
 
 plugin.path = pluginPath;
 plugin.bundleIdentifier = CFBundleGetIdentifier(bundle.get());
-plugin.versionNumber = CFBundleGetVersionNumber(bundle.get());
+if (CFTypeRef versionTypeRef = CFBundleGetValueForInfoDictionaryKey(bundle.get(), kCFBundleVersionKey)) {
+if (CFGetTypeID(versionTypeRef) == CFStringGetTypeID())
+plugin.versionString = static_cast(versionTypeRef);
+}
 
 // Check that there's valid info for this plug-in.
 if (!getPluginInfoFromPropertyLists(bundle.get(), plugin) &&
@@ -398,11 +401,52 @@
 void (*createPluginMIMETypesPreferences)(void) = reinterpret_cast(CFBundleGetFunctionPointerForName(bundle.get(), CFSTR("BP_CreatePluginMIMETypesPreferences")));
 if (!createPluginMIMETypesPreferences)
 return false;
-
+
 createPluginMIMETypesPreferences();
 return true;
 }
 
+// FIXME: This doesn't need to be platform-specific.
+class PluginVersion {
+public:
+static PluginVersion parse(const String& versionString);
+
+bool isLessThan(unsigned componentA) const;
+bool isValid() const { return !m_versionComponents.isEmpty(); }
+
+private:
+PluginVersion()
+{
+}
+
+Vector m_versionCompon

[webkit-changes] [88734] trunk/Source/WebKit/gtk

[mrobinson]

Title: [88734] trunk/Source/WebKit/gtk








Revision 88734
Author mrobin...@webkit.org
Date 2011-06-13 17:09:47 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Martin Robinson  

Reviewed by Gustavo Noronha Silva.

Update gtkdoc files and inline documentation to reduce gtkdoc errors
and ensure complete documentation output.

* docs/webkitgtk-sections.txt: Add missing sections to the list and remove
unneeded sections.
* docs/webkitgtk.types: Update the types list.
* webkit/webkithittestresult.cpp: Fix inline documentation errors.
(webkit_hit_test_result_class_init): Ditto.
* webkit/webkiticondatabase.cpp: Ditto.
* webkit/webkitwebsettings.cpp: Ditto.
(webkit_web_settings_class_init): Ditto.
* webkit/webkitwebview.cpp: Ditto.
(webkit_web_view_class_init): Ditto.

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt
trunk/Source/WebKit/gtk/docs/webkitgtk.types
trunk/Source/WebKit/gtk/webkit/webkithittestresult.cpp
trunk/Source/WebKit/gtk/webkit/webkiticondatabase.cpp
trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp
trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (88733 => 88734)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-06-13 23:51:21 UTC (rev 88733)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-06-14 00:09:47 UTC (rev 88734)
@@ -1,5 +1,23 @@
 2011-06-13  Martin Robinson  
 
+Reviewed by Gustavo Noronha Silva.
+
+Update gtkdoc files and inline documentation to reduce gtkdoc errors
+and ensure complete documentation output.
+
+* docs/webkitgtk-sections.txt: Add missing sections to the list and remove
+unneeded sections.
+* docs/webkitgtk.types: Update the types list.
+* webkit/webkithittestresult.cpp: Fix inline documentation errors.
+(webkit_hit_test_result_class_init): Ditto.
+* webkit/webkiticondatabase.cpp: Ditto.
+* webkit/webkitwebsettings.cpp: Ditto.
+(webkit_web_settings_class_init): Ditto.
+* webkit/webkitwebview.cpp: Ditto.
+(webkit_web_view_class_init): Ditto.
+
+2011-06-13  Martin Robinson  
+
 Reviewed by Xan Lopez.
 
 Update the list of ignored GTK+ header files for the documentation


Modified: trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt (88733 => 88734)

--- trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt	2011-06-13 23:51:21 UTC (rev 88733)
+++ trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt	2011-06-14 00:09:47 UTC (rev 88734)
@@ -1,8 +1,8 @@
 
 webkitwebsettings
 WebKitWebSettings
-WebKitEditingBehavior
 WebKitWebSettings
+WebKitEditingBehavior
 webkit_web_settings_copy
 webkit_web_settings_new
 webkit_web_settings_get_user_agent
@@ -14,10 +14,8 @@
 WEBKIT_IS_WEB_SETTINGS_CLASS
 WEBKIT_WEB_SETTINGS_GET_CLASS
 
-webkit_web_settings_get_type
-WebKitWebSettingsPrivate
-WebKitWebSettings
 WebKitWebSettingsClass
+webkit_web_settings_get_type
 
 
 
@@ -51,7 +49,6 @@
 
 WebKitWebBackForwardListPrivate
 webkit_web_back_forward_list_get_type
-WebKitWebBackForwardList
 WebKitWebBackForwardListClass
 
 
@@ -78,7 +75,6 @@
 
 webkit_web_history_item_get_type
 WebKitWebHistoryItemPrivate
-WebKitWebHistoryItem
 WebKitWebHistoryItemClass
 
 
@@ -120,7 +116,6 @@
 
 WebKitWebFramePrivate
 webkit_web_frame_get_type
-WebKitWebFrame
 WebKitWebFrameClass
 
 
@@ -153,7 +148,6 @@
 WEBKIT_TYPE_DOWNLOAD
 
 webkit_download_get_type
-WebKitDownload
 WebKitDownloadClass
 WebKitDownloadPrivate
 
@@ -178,7 +172,6 @@
 WEBKIT_IS_SECURITY_ORIGIN_CLASS
 WEBKIT_TYPE_SECURITY_ORIGIN
 
-WebKitSecurityOrigin
 WebKitSecurityOriginClass
 WebKitSecurityOriginPrivate
 
@@ -196,9 +189,7 @@
 WEBKIT_IS_HIT_TEST_RESULT_CLASS
 WEBKIT_TYPE_HIT_TEST_RESULT
 
-WebKitHitTestResult
 WebKitHitTestResultClass
-WebKitHitTestResultContext
 WebKitHitTestResultPrivate
 webkit_hit_test_result_get_type
 
@@ -225,7 +216,6 @@
 WEBKIT_WEB_DATA_SOURCE_CLASS
 WEBKIT_WEB_DATA_SOURCE_GET_CLASS
 
-WebKitWebDataSource
 WebKitWebDataSourceClass
 WebKitWebDataSourcePrivate
 webkit_web_data_source_new_with_request
@@ -251,7 +241,6 @@
 WEBKIT_WEB_DATABASE_CLASS
 WEBKIT_WEB_DATABASE_GET_CLASS
 
-WebKitWebDatabase
 WebKitWebDatabaseClass
 WebKitWebDatabasePrivate
 webkit_web_database_get_type
@@ -270,7 +259,6 @@
 WEBKIT_TYPE_SOUP_AUTH_DIALOG
 
 webkit_soup_auth_dialog_get_type
-WebKitSoupAuthDialog
 WebKitSoupAuthDialogClass
 
 
@@ -293,7 +281,6 @@
 
 webkit_web_inspector_get_type
 WebKitWebInspectorPrivate
-WebKitWebInspector
 WebKitWebInspectorClass
 
 
@@ -318,7 +305,6 @@
 WEBKIT_WEB_NAVIGATION_ACTION_CLASS
 WEBKIT_WEB_NAVIGATION_ACTION_GET_CLASS
 
-WebKitWebNavigationAction
 WebKitWebNavigationActionClass
 WebKitWebNavigationActionPrivate
 
@@ -339,7 +325,6 @@
 WEBKIT_WEB_POLICY_DECISION_CLASS
 WEBKIT_WEB_POLICY_DECISION_GET_CLASS
 
-WebKitWebPolicyDecision
 WebKitWebPolicyDecisionClass
 WebKitWebPolicyDecisionPrivate

[webkit-changes] [88733] trunk/LayoutTests

[rniwa]

Title: [88733] trunk/LayoutTests








Revision 88733
Author rn...@webkit.org
Date 2011-06-13 16:51:21 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Mac, GTK, and Qt rebaselines after r88717.

* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
* platform/mac/editing/pasteboard/paste-xml-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt
trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt
trunk/LayoutTests/platform/qt/editing/pasteboard/paste-xml-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88732 => 88733)

--- trunk/LayoutTests/ChangeLog	2011-06-13 23:49:02 UTC (rev 88732)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 23:51:21 UTC (rev 88733)
@@ -1,3 +1,10 @@
+2011-06-13  Ryosuke Niwa  
+
+Mac, GTK, and Qt rebaselines after r88717.
+
+* platform/gtk/editing/pasteboard/paste-xml-expected.txt:
+* platform/mac/editing/pasteboard/paste-xml-expected.txt:
+
 2011-06-13  Jeffrey Pfau  
 
 Reviewed by Darin Adler.


Modified: trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt (88732 => 88733)

--- trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt	2011-06-13 23:49:02 UTC (rev 88732)
+++ trunk/LayoutTests/platform/gtk/editing/pasteboard/paste-xml-expected.txt	2011-06-13 23:51:21 UTC (rev 88733)
@@ -15,18 +15,6 @@
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text > span > div > body > html > #document to 1 of #text > span > div > body > html > #document toDOMRange:range from 3 of #text > span > div > body > html > #document to 3 of #text > span > div > body > html > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x72
-  RenderBlock {html} at (0,0) size 800x72
-RenderBody {body} at (8,8) size 784x56
-  RenderBlock {div} at (0,0) size 784x56 [border: (2px solid #FF)]
-RenderInline {span} at (0,0) size 140x28
-  RenderText {#text} at (14,14) size 69x28
-text run at (14,14) width 69: "foo bar"
-  RenderText {#text} at (83,14) size 31x28
-text run at (83,14) width 31: "bar"
-  RenderText {#text} at (114,14) size 40x28
-text run at (114,14) width 40: " baz"
-RenderText {#text} at (0,0) size 0x0
-caret: position 3 of child 1 {#text} of child 1 {span} of child 1 {div} of body
+foo barbar baz
+execCopyCommand: foo bar baz
+execPasteCommand: foo barbar baz


Modified: trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt (88732 => 88733)

--- trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt	2011-06-13 23:49:02 UTC (rev 88732)
+++ trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.txt	2011-06-13 23:51:21 UTC (rev 88733)
@@ -14,14 +14,6 @@
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > span > div > body > html > #document to 10 of #text > span > div > body > html > #document toDOMRange:range from 10 of #text > span > div > body > html > #document to 10 of #text > span > div > body > html > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x72
-  RenderBlock {html} at (0,0) size 800x72
-RenderBody {body} at (8,8) size 784x56
-  RenderBlock {div} at (0,0) size 784x56 [border: (2px solid #FF)]
-RenderInline {span} at (0,0) size 140x28
-  RenderText {#text} at (14,14) size 140x28
-text run at (14,14) width 140: "foo barbar baz"
-RenderText {#text} at (0,0) size 0x0
-caret: position 10 of child 0 {#text} of child 1 {span} of child 1 {div} of body
+foo barbar baz
+execCopyCommand: foo bar baz
+execPasteCommand: foo barbar baz


Modified: trunk/LayoutTests/platform/qt/editing/pasteboard/paste-xml-expected.txt (88732 => 88733)

--- trunk/LayoutTests/platform/qt/editing/pasteboard/paste-xml-expected.txt	2011-06-13 23:49:02 UTC (rev 88732)
+++ trunk/LayoutTests/platform/qt/editing/pasteboard/paste-xml-expected.txt	2011-06-13 23:51:21 UTC (rev 88733)
@@ -13,14 +13,6 @@
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > span > div > body > html > #document to 7 of #text > span > div > body > html > #document toDOMRange:range from 10 of #text > span > div > body > html > #document to 10 of #text > span > div > body > html > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelectio

[webkit-changes] [88732] trunk/Tools

[crogers]

Title: [88732] trunk/Tools








Revision 88732
Author crog...@google.com
Date 2011-06-13 16:49:02 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Chris Rogers  

Unreviewed build fix.

Build fix to chromium DRT until we can rebaseline some tests
https://bugs.webkit.org/show_bug.cgi?id=62608

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp




Diff

Modified: trunk/Tools/ChangeLog (88731 => 88732)

--- trunk/Tools/ChangeLog	2011-06-13 23:28:23 UTC (rev 88731)
+++ trunk/Tools/ChangeLog	2011-06-13 23:49:02 UTC (rev 88732)
@@ -1,5 +1,15 @@
 2011-06-13  Chris Rogers  
 
+Unreviewed build fix.
+
+Build fix to chromium DRT until we can rebaseline some tests
+https://bugs.webkit.org/show_bug.cgi?id=62608
+
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::TestShell):
+
+2011-06-13  Chris Rogers  
+
 Reviewed by Dirk Pranke.
 
 Add Web Audio support to chromium DRT


Modified: trunk/Tools/DumpRenderTree/chromium/TestShell.cpp (88731 => 88732)

--- trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2011-06-13 23:28:23 UTC (rev 88731)
+++ trunk/Tools/DumpRenderTree/chromium/TestShell.cpp	2011-06-13 23:49:02 UTC (rev 88732)
@@ -115,7 +115,6 @@
 WebRuntimeFeatures::enableIndexedDatabase(true);
 WebRuntimeFeatures::enableFileSystem(true);
 WebRuntimeFeatures::enableJavaScriptI18NAPI(true);
-WebRuntimeFeatures::enableWebAudio(true);
 
 m_webPermissions = adoptPtr(new WebPermissions());
 m_accessibilityController = adoptPtr(new AccessibilityController(this));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88731] trunk/Source/WebCore

[abarth]

Title: [88731] trunk/Source/WebCore








Revision 88731
Author aba...@webkit.org
Date 2011-06-13 16:28:23 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Adam Barth  

Reviewed by Darin Adler.

anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
https://bugs.webkit.org/show_bug.cgi?id=62601

Previously, our user-gesture state was per-frame.  Code needed to check
the "global" user gesture state called anyPageIsProcessingUserGesture()
to iterate through all the frames and look for one that was processing
a user gesture.  Since we changed the user gesture state to be static,
iterating over every frame in existence isn't needed.

This patch also cleans up a couple other user-gesture callsites I saw
while I was in this code.  Code should just call
ScriptController::processingUserGesture directly instead of
trampolining through other functions.

* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeScript):
* bindings/generic/BindingSecurity.h:
(WebCoreallowPopUp):
* bindings/js/JSDOMBinding.cpp:
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::setLocation):
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptController.h:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/ScriptController.cpp:
* bindings/v8/ScriptController.h:
(WebCore::ScriptController::setProcessingTimerCallback):
* bindings/v8/V8Utilities.cpp:
* bindings/v8/V8Utilities.h:
* bindings/v8/specialization/V8BindingState.cpp:
* bindings/v8/specialization/V8BindingState.h:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitFromJavaScript):
(WebCore::HTMLFormElement::submit):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::setLocation):
(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/ScriptControllerBase.cpp
trunk/Source/WebCore/bindings/generic/BindingSecurity.h
trunk/Source/WebCore/bindings/js/JSDOMBinding.cpp
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSDocumentCustom.cpp
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/bindings/js/ScriptController.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/v8/ScriptController.cpp
trunk/Source/WebCore/bindings/v8/ScriptController.h
trunk/Source/WebCore/bindings/v8/V8Utilities.cpp
trunk/Source/WebCore/bindings/v8/V8Utilities.h
trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.cpp
trunk/Source/WebCore/bindings/v8/specialization/V8BindingState.h
trunk/Source/WebCore/html/HTMLFormElement.cpp
trunk/Source/WebCore/page/DOMWindow.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88730 => 88731)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 23:20:47 UTC (rev 88730)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 23:28:23 UTC (rev 88731)
@@ -1,3 +1,48 @@
+2011-06-13  Adam Barth  
+
+Reviewed by Darin Adler.
+
+anyPageIsProcessingUserGesture is not longer needed because user gesture state is static
+https://bugs.webkit.org/show_bug.cgi?id=62601
+
+Previously, our user-gesture state was per-frame.  Code needed to check
+the "global" user gesture state called anyPageIsProcessingUserGesture()
+to iterate through all the frames and look for one that was processing
+a user gesture.  Since we changed the user gesture state to be static,
+iterating over every frame in existence isn't needed.
+
+This patch also cleans up a couple other user-gesture callsites I saw
+while I was in this code.  Code should just call
+ScriptController::processingUserGesture directly instead of
+trampolining through other functions.
+
+* bindings/ScriptControllerBase.cpp:
+(WebCore::ScriptController::executeScript):
+* bindings/generic/BindingSecurity.h:
+(WebCoreallowPopUp):
+* bindings/js/JSDOMBinding.cpp:
+* bindings/js/JSDOMBinding.h:
+* bindings/js/JSDocumentCustom.cpp:
+(WebCore::JSDocument::setLocation):
+* bindings/js/ScriptController.cpp:
+* bindings/js/ScriptController.h:
+* bindings/scripts/CodeGeneratorJS.pm:
+* bindings/scripts/CodeGeneratorV8.pm:
+* bindings/v8/ScriptController.cpp:
+* bindings/v8/ScriptController.h:
+(WebCore::ScriptController::setProcessingTimerCallback):
+* bindings/v8/V8Utilities.cpp:
+* bindings/v8/V8Utilities.h:
+* bindings/v8/specialization/V8BindingSta

[webkit-changes] [88730] trunk

[commit-queue]

Title: [88730] trunk








Revision 88730
Author commit-qu...@webkit.org
Date 2011-06-13 16:20:47 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Jeffrey Pfau  

Reviewed by Darin Adler.

Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900

Added a test that tries to remove the children of munder, mover and munderover elements.

* mathml/munderover-remove-children-expected.txt: Added.
* mathml/munderover-remove-children.html: Added.
2011-06-13  Jeffrey Pfau  

Reviewed by Darin Adler.

Crash in WebCore::RenderMathMLUnderOver::layout()
https://bugs.webkit.org/show_bug.cgi?id=57900

Add more null checks so that removing children in MathML elements does not cause crashes.
Note that this only half fixes the third repro in the Bugzilla bug, as another bug will
still crash that repro.

Test: mathml/munderover-remove-children.html

* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::stretchToHeight):
* rendering/mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::nonOperatorHeight):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/mathml/RenderMathMLSubSup.cpp
trunk/Source/WebCore/rendering/mathml/RenderMathMLUnderOver.cpp


Added Paths

trunk/LayoutTests/mathml/munderover-remove-children-expected.txt
trunk/LayoutTests/mathml/munderover-remove-children.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88729 => 88730)

--- trunk/LayoutTests/ChangeLog	2011-06-13 23:06:56 UTC (rev 88729)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 23:20:47 UTC (rev 88730)
@@ -1,3 +1,15 @@
+2011-06-13  Jeffrey Pfau  
+
+Reviewed by Darin Adler.
+
+Crash in WebCore::RenderMathMLUnderOver::layout()
+https://bugs.webkit.org/show_bug.cgi?id=57900
+
+Added a test that tries to remove the children of munder, mover and munderover elements.
+
+* mathml/munderover-remove-children-expected.txt: Added.
+* mathml/munderover-remove-children.html: Added.
+
 2011-06-13  Wyatt Carss  
 
 Reviewed by Ryosuke Niwa.


Added: trunk/LayoutTests/mathml/munderover-remove-children-expected.txt (0 => 88730)

--- trunk/LayoutTests/mathml/munderover-remove-children-expected.txt	(rev 0)
+++ trunk/LayoutTests/mathml/munderover-remove-children-expected.txt	2011-06-13 23:20:47 UTC (rev 88730)
@@ -0,0 +1 @@
+This test passes if this page has no other text.


Added: trunk/LayoutTests/mathml/munderover-remove-children.html (0 => 88730)

--- trunk/LayoutTests/mathml/munderover-remove-children.html	(rev 0)
+++ trunk/LayoutTests/mathml/munderover-remove-children.html	2011-06-13 23:20:47 UTC (rev 88730)
@@ -0,0 +1,57 @@
+
+
+MathML munder/mover removing children test
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+
+
+
+This test passes if this page has no other text.
+
+A
+X
+
+
+B
+Y
+
+
+C
+Z
+W
+
+
+
+try {
+var elem = document.getElementById("m1");
+elem.parentNode.removeChild(elem);
+} catch(e) {document.write("Error: " + e.name + ": " + e.message + + " for " + i);}
+try {
+var elem = document.getElementById("m2");
+elem.parentNode.removeChild(elem);
+} catch(e) {document.write("Error: " + e.name + ": " + e.message + + " for " + i);}
+try {
+var elem = document.getElementById("m3");
+elem.parentNode.removeChild(elem);
+} catch(e) {document.write("Error: " + e.name + ": " + e.message + + " for " + i);}
+try {
+var elem = document.getElementById("m4");
+elem.parentNode.removeChild(elem);
+} catch(e) {document.write("Error: " + e.name + ": " + e.message + + " for " + i);}
+try {
+var elem = document.getElementById("m7");
+elem.parentNode.removeChild(elem);
+} catch(e) {document.write("Error: " + e.name + ": " + e.message + + " for " + i);}
+try {
+var elem = document.getElementById("m6");
+elem.parentNode.removeChild(elem);
+} catch(e) {document.write("Error: " + e.name + ": " + e.message + + " for " + i);}
+try {
+var elem = document.getElementById("m5");
+elem.parentNode.removeChild(elem);
+} catch(e) {document.write("Error: " + e.name + ": " + e.message + + " for " + i);}
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (88729 => 88730)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 23:06:56 UTC (rev 88729)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 23:20:47 UTC (rev 88730)
@@ -1,3 +1,22 @@
+2011-06-13  Jeffrey Pfau  
+
+Reviewed by Darin Adler.
+
+Crash in WebCore::RenderMathMLUnderOver::layout()
+https://bugs.webkit.org/show_bug.cgi?id=57900
+
+Add more null checks so that removing children in MathML elements does not cause c

[webkit-changes] [88729] trunk/Source

[commit-queue]

Title: [88729] trunk/Source








Revision 88729
Author commit-qu...@webkit.org
Date 2011-06-13 16:06:56 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Dmitry Lomov  

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.

* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):
* bindings/v8/V8Binding.cpp:
(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData):
(WebCore::V8BindingPerIsolateData::create):
(WebCore::V8BindingPerIsolateData::ensureInitialized):
(WebCore::V8BindingPerIsolateData::dispose):
(WebCore::getToStringName):
(WebCore::getToStringTemplate):
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::get):
(WebCore::V8BindingPerIsolateData::current):
(WebCore::V8BindingPerIsolateData::rawTemplateMap):
(WebCore::V8BindingPerIsolateData::templateMap):
(WebCore::V8BindingPerIsolateData::toStringName):
(WebCore::V8BindingPerIsolateData::toStringTemplate):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8Utilities.cpp:
(WebCore::V8LocalContext::V8LocalContext):
(WebCore::V8LocalContext::~V8LocalContext):
* bindings/v8/V8Utilities.h:
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
2011-06-13  Dmitry Lomov  

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=62345
Use per-isolate embedder data instead of statics for caches in bindings.
This is a prerequisite for more than one v8 isolate per process.

* tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8DOMWindowShell.cpp
trunk/Source/WebCore/bindings/v8/V8Utilities.cpp
trunk/Source/WebCore/bindings/v8/V8Utilities.h
trunk/Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/IDBBindingUtilitiesTest.cpp


Property Changed

trunk/Source/WebKit/chromium/ChangeLog




Diff

Modified: trunk/Source/WebCore/ChangeLog (88728 => 88729)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:56:57 UTC (rev 88728)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 23:06:56 UTC (rev 88729)
@@ -1,3 +1,39 @@
+2011-06-13  Dmitry Lomov  
+
+Reviewed by Adam Barth.
+
+https://bugs.webkit.org/show_bug.cgi?id=62345
+Use per-isolate embedder data instead of statics for caches in bindings.
+This is a prerequisite for more than one v8 isolate per process.
+
+* bindings/scripts/CodeGeneratorV8.pm:
+* bindings/v8/IDBBindingUtilities.cpp:
+(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
+(WebCore::injectIDBKeyIntoSerializedValue):
+* bindings/v8/V8Binding.cpp:
+(WebCore::V8BindingPerIsolateData::V8BindingPerIsolateData):
+(WebCore::V8BindingPerIsolateData::~V8BindingPerIsolateData):
+(WebCore::V8BindingPerIsolateData::create):
+(WebCore::V8BindingPerIsolateData::ensureInitialized):
+(WebCore::V8BindingPerIsolateData::dispose):
+(WebCore::getToStringName):
+(WebCore::getToStringTemplate):
+* bindings/v8/V8Binding.h:
+(WebCore::V8BindingPerIsolateData::get):
+(WebCore::V8BindingPerIsolateData::current):
+(WebCore::V8BindingPerIsolateData::rawTemplateMap):
+(WebCore::V8BindingPerIsolateData::templateMap):
+(WebCore::V8BindingPerIsolateData::toStringName):
+(WebCore::V8BindingPerIsolateData::toStringTemplate):
+* bindings/v8/V8DOMWindowShell.cpp:
+(WebCore::V8DOMWindowShell::initContextIfNeeded):
+* bindings/v8/V8Utilities.cpp:
+(WebCore::V8LocalContext::V8LocalContext):
+(WebCore::V8LocalContext::~V8LocalContext):
+* bindings/v8/V8Utilities.h:
+* bindings/v8/WorkerContextExecutionProxy.cpp:
+(WebCore::WorkerContextExecutionProxy::initV8IfNeeded):
+
 2011-06-13  Caio Marcelo de Oliveira Filho  
 
 Reviewed by Adam Barth.


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm (88728 => 88729)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm	2011-06-13 22:56:57 UTC (rev 88728)
+++ trunk

[webkit-changes] [88728] trunk/Source/WebKit/chromium

[commit-queue]

Title: [88728] trunk/Source/WebKit/chromium








Revision 88728
Author commit-qu...@webkit.org
Date 2011-06-13 15:56:57 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Lei Zhang  

Reviewed by Darin Fisher.

[Chromium] Add a WebSetting to control printing backgrounds
https://bugs.webkit.org/show_bug.cgi?id=62423

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setShouldPrintBackgrounds):
* src/WebSettingsImpl.h:

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebSettings.h
trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp
trunk/Source/WebKit/chromium/src/WebSettingsImpl.h




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (88727 => 88728)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-06-13 22:53:05 UTC (rev 88727)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-06-13 22:56:57 UTC (rev 88728)
@@ -1,3 +1,15 @@
+2011-06-13  Lei Zhang  
+
+Reviewed by Darin Fisher.
+
+[Chromium] Add a WebSetting to control printing backgrounds
+https://bugs.webkit.org/show_bug.cgi?id=62423
+
+* public/WebSettings.h:
+* src/WebSettingsImpl.cpp:
+(WebKit::WebSettingsImpl::setShouldPrintBackgrounds):
+* src/WebSettingsImpl.h:
+
 2011-06-13  Dominic Mazzoni  
 
 Reviewed by Dimitri Glazkov.


Modified: trunk/Source/WebKit/chromium/public/WebSettings.h (88727 => 88728)

--- trunk/Source/WebKit/chromium/public/WebSettings.h	2011-06-13 22:53:05 UTC (rev 88727)
+++ trunk/Source/WebKit/chromium/public/WebSettings.h	2011-06-13 22:56:57 UTC (rev 88728)
@@ -123,6 +123,7 @@
 virtual void setFullScreenEnabled(bool) = 0;
 virtual void setAllowDisplayOfInsecureContent(bool) = 0;
 virtual void setAllowRunningOfInsecureContent(bool) = 0;
+virtual void setShouldPrintBackgrounds(bool) = 0;
 
 protected:
 ~WebSettings() { }


Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp (88727 => 88728)

--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2011-06-13 22:53:05 UTC (rev 88727)
+++ trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp	2011-06-13 22:56:57 UTC (rev 88728)
@@ -417,4 +417,9 @@
 m_settings->setAllowRunningOfInsecureContent(enabled);
 }
 
+void WebSettingsImpl::setShouldPrintBackgrounds(bool enabled)
+{
+m_settings->setShouldPrintBackgrounds(enabled);
+}
+
 } // namespace WebKit


Modified: trunk/Source/WebKit/chromium/src/WebSettingsImpl.h (88727 => 88728)

--- trunk/Source/WebKit/chromium/src/WebSettingsImpl.h	2011-06-13 22:53:05 UTC (rev 88727)
+++ trunk/Source/WebKit/chromium/src/WebSettingsImpl.h	2011-06-13 22:56:57 UTC (rev 88728)
@@ -116,6 +116,7 @@
 virtual void setFullScreenEnabled(bool);
 virtual void setAllowDisplayOfInsecureContent(bool);
 virtual void setAllowRunningOfInsecureContent(bool);
+virtual void setShouldPrintBackgrounds(bool);
 
 private:
 WebCore::Settings* m_settings;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88727] trunk/Source/WebCore

[caio . oliveira]

Title: [88727] trunk/Source/WebCore








Revision 88727
Author caio.olive...@openbossa.org
Date 2011-06-13 15:53:05 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Caio Marcelo de Oliveira Filho  

Reviewed by Adam Barth.

Simplify logic in ProgressTracker::progressCompleted()
https://bugs.webkit.org/show_bug.cgi?id=62598

Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
always true, otherwise we would entered in the first part of the conditional.

* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressCompleted):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/ProgressTracker.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88726 => 88727)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:50:53 UTC (rev 88726)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 22:53:05 UTC (rev 88727)
@@ -1,3 +1,16 @@
+2011-06-13  Caio Marcelo de Oliveira Filho  
+
+Reviewed by Adam Barth.
+
+Simplify logic in ProgressTracker::progressCompleted()
+https://bugs.webkit.org/show_bug.cgi?id=62598
+
+Testing for "m_numProgressTrackedFrames != 0" is unnecessary because it is
+always true, otherwise we would entered in the first part of the conditional.
+
+* loader/ProgressTracker.cpp:
+(WebCore::ProgressTracker::progressCompleted):
+
 2011-06-13  Dimitri Glazkov  
 
 Unreviewed, rolling out r88704.


Modified: trunk/Source/WebCore/loader/ProgressTracker.cpp (88726 => 88727)

--- trunk/Source/WebCore/loader/ProgressTracker.cpp	2011-06-13 22:50:53 UTC (rev 88726)
+++ trunk/Source/WebCore/loader/ProgressTracker.cpp	2011-06-13 22:53:05 UTC (rev 88727)
@@ -129,8 +129,7 @@
 frame->loader()->client()->willChangeEstimatedProgress();
 
 m_numProgressTrackedFrames--;
-if (m_numProgressTrackedFrames == 0 ||
-(frame == m_originatingProgressFrame && m_numProgressTrackedFrames != 0))
+if (!m_numProgressTrackedFrames || m_originatingProgressFrame == frame)
 finalProgressComplete();
 
 frame->loader()->client()->didChangeEstimatedProgress();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88726] trunk/Tools

[crogers]

Title: [88726] trunk/Tools








Revision 88726
Author crog...@google.com
Date 2011-06-13 15:50:53 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Chris Rogers  

Reviewed by Dirk Pranke.

Add Web Audio support to chromium DRT
https://bugs.webkit.org/show_bug.cgi?id=62306

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::reset):
(LayoutTestController::setEncodedAudioData):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController::encodedAudioData):
(LayoutTestController::shouldDumpAsAudio):
(LayoutTestController::setShouldDumpAsAudio):
* DumpRenderTree/chromium/TestEventPrinter.cpp:
(DRTPrinter::handleAudioHeader):
(TestShellPrinter::handleAudioHeader):
* DumpRenderTree/chromium/TestEventPrinter.h:
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):
(TestShell::dump):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp
trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h
trunk/Tools/DumpRenderTree/chromium/TestEventPrinter.cpp
trunk/Tools/DumpRenderTree/chromium/TestEventPrinter.h
trunk/Tools/DumpRenderTree/chromium/TestShell.cpp




Diff

Modified: trunk/Tools/ChangeLog (88725 => 88726)

--- trunk/Tools/ChangeLog	2011-06-13 22:47:37 UTC (rev 88725)
+++ trunk/Tools/ChangeLog	2011-06-13 22:50:53 UTC (rev 88726)
@@ -1,3 +1,26 @@
+2011-06-13  Chris Rogers  
+
+Reviewed by Dirk Pranke.
+
+Add Web Audio support to chromium DRT
+https://bugs.webkit.org/show_bug.cgi?id=62306
+
+* DumpRenderTree/chromium/LayoutTestController.cpp:
+(LayoutTestController::LayoutTestController):
+(LayoutTestController::reset):
+(LayoutTestController::setEncodedAudioData):
+* DumpRenderTree/chromium/LayoutTestController.h:
+(LayoutTestController::encodedAudioData):
+(LayoutTestController::shouldDumpAsAudio):
+(LayoutTestController::setShouldDumpAsAudio):
+* DumpRenderTree/chromium/TestEventPrinter.cpp:
+(DRTPrinter::handleAudioHeader):
+(TestShellPrinter::handleAudioHeader):
+* DumpRenderTree/chromium/TestEventPrinter.h:
+* DumpRenderTree/chromium/TestShell.cpp:
+(TestShell::TestShell):
+(TestShell::dump):
+
 2011-06-13  Jaehun Lim  
 
 Reviewed by Eric Seidel.


Modified: trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp (88725 => 88726)

--- trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp	2011-06-13 22:47:37 UTC (rev 88725)
+++ trunk/Tools/DumpRenderTree/chromium/LayoutTestController.cpp	2011-06-13 22:50:53 UTC (rev 88726)
@@ -156,6 +156,7 @@
 bindMethod("setDeferMainResourceDataLoad", &LayoutTestController::setDeferMainResourceDataLoad);
 bindMethod("setDomainRelaxationForbiddenForURLScheme", &LayoutTestController::setDomainRelaxationForbiddenForURLScheme);
 bindMethod("setEditingBehavior", &LayoutTestController::setEditingBehavior);
+bindMethod("setEncodedAudioData", &LayoutTestController::setEncodedAudioData);
 bindMethod("setGeolocationPermission", &LayoutTestController::setGeolocationPermission);
 bindMethod("setIconDatabaseEnabled", &LayoutTestController::setIconDatabaseEnabled);
 bindMethod("setJavaScriptCanAccessClipboard", &LayoutTestController::setJavaScriptCanAccessClipboard);
@@ -573,6 +574,7 @@
 m_shell->webView()->removeAllUserContent();
 }
 m_dumpAsText = false;
+m_dumpAsAudio = false;
 m_dumpEditingCallbacks = false;
 m_dumpFrameLoadCallbacks = false;
 m_dumpUserGestureInFrameLoadCallbacks = false;
@@ -1922,3 +1924,13 @@
 
 m_shell->webView()->setTextDirection(direction);
 }
+
+void LayoutTestController::setEncodedAudioData(const CppArgumentList& arguments, CppVariant* result)
+{
+result->setNull();
+if (arguments.size() < 1 || !arguments[0].isString())
+return;
+
+m_encodedAudioData = arguments[0].toString();
+setShouldDumpAsAudio(true);
+}


Modified: trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h (88725 => 88726)

--- trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h	2011-06-13 22:47:37 UTC (rev 88725)
+++ trunk/Tools/DumpRenderTree/chromium/LayoutTestController.h	2011-06-13 22:50:53 UTC (rev 88726)
@@ -249,6 +249,10 @@
 void setDeferMainResourceDataLoad(const CppArgumentList&, CppVariant*);
 void setEditingBehavior(const CppArgumentList&, CppVariant*);
 
+// Deals with Web Audio base64 encoded WAVE file data.
+void setEncodedAudioData(const CppArgumentList&, CppVariant*);
+const std::string& encodedAudioData() const { return m_encodedAudioData; } 
+
 // The following are only stubs.
 // FIXME: Implement any of these that are needed to pass the layout tests.
 void dumpAsWebArchive(const CppArgumentList&, C

[webkit-changes] [88725] trunk/Source/WebKit/efl

[commit-queue]

Title: [88725] trunk/Source/WebKit/efl








Revision 88725
Author commit-qu...@webkit.org
Date 2011-06-13 15:47:37 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Michal Pakula vel Rutka  

Reviewed by Eric Seidel.

[EFL] Input method hints not updated while clicking non-input field editable area
https://bugs.webkit.org/show_bug.cgi?id=62539

This fixes a minor bug when input method hints are not updated while focus is
changed from editable area with input tags to other which are does not have input
tag i.e. textarea.

* ewk/ewk_view.cpp:
(ewk_view_input_method_state_set):

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_view.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (88724 => 88725)

--- trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:46:21 UTC (rev 88724)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:47:37 UTC (rev 88725)
@@ -1,3 +1,17 @@
+2011-06-13  Michal Pakula vel Rutka  
+
+Reviewed by Eric Seidel.
+
+[EFL] Input method hints not updated while clicking non-input field editable area
+https://bugs.webkit.org/show_bug.cgi?id=62539
+
+This fixes a minor bug when input method hints are not updated while focus is 
+changed from editable area with input tags to other which are does not have input 
+tag i.e. textarea.
+
+* ewk/ewk_view.cpp:
+(ewk_view_input_method_state_set):
+
 2011-06-13  Jaehun Lim  
 
 Reviewed by Eric Seidel.


Modified: trunk/Source/WebKit/efl/ewk/ewk_view.cpp (88724 => 88725)

--- trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-06-13 22:46:21 UTC (rev 88724)
+++ trunk/Source/WebKit/efl/ewk/ewk_view.cpp	2011-06-13 22:47:37 UTC (rev 88725)
@@ -3441,6 +3441,7 @@
 EWK_VIEW_PRIV_GET(sd, priv);
 WebCore::Frame* focusedFrame = priv->page->focusController()->focusedOrMainFrame();
 
+priv->imh = 0;
 if (focusedFrame
 && focusedFrame->document()
 && focusedFrame->document()->focusedNode()
@@ -3449,7 +3450,6 @@
 
 inputElement = static_cast(focusedFrame->document()->focusedNode());
 if (inputElement) {
-priv->imh = 0;
 // for password fields, active == false
 if (!active) {
 active = inputElement->isPasswordField();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88724] trunk/Source/JavaScriptCore

[oliver]

Title: [88724] trunk/Source/_javascript_Core








Revision 88724
Author oli...@apple.com
Date 2011-06-13 15:46:21 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Oliver Hunt  

Reviewed by Gavin Barraclough.

Fix llocp and lvalp names in the lexer to something more meaningful
https://bugs.webkit.org/show_bug.cgi?id=62605

A simple rename

* parser/Lexer.cpp:
(JSC::Lexer::parseIdentifier):
(JSC::Lexer::parseString):
(JSC::Lexer::lex):
* parser/Lexer.h:
(JSC::Lexer::lexExpectIdentifier):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/Lexer.cpp
trunk/Source/_javascript_Core/parser/Lexer.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (88723 => 88724)

--- trunk/Source/_javascript_Core/ChangeLog	2011-06-13 22:45:23 UTC (rev 88723)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-06-13 22:46:21 UTC (rev 88724)
@@ -2,6 +2,22 @@
 
 Reviewed by Gavin Barraclough.
 
+Fix llocp and lvalp names in the lexer to something more meaningful
+https://bugs.webkit.org/show_bug.cgi?id=62605
+
+A simple rename
+
+* parser/Lexer.cpp:
+(JSC::Lexer::parseIdentifier):
+(JSC::Lexer::parseString):
+(JSC::Lexer::lex):
+* parser/Lexer.h:
+(JSC::Lexer::lexExpectIdentifier):
+
+2011-06-13  Oliver Hunt  
+
+Reviewed by Gavin Barraclough.
+
 Make it possible to inline the common case of identifier lexing
 https://bugs.webkit.org/show_bug.cgi?id=62600
 


Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (88723 => 88724)

--- trunk/Source/_javascript_Core/parser/Lexer.cpp	2011-06-13 22:45:23 UTC (rev 88723)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp	2011-06-13 22:46:21 UTC (rev 88724)
@@ -405,13 +405,13 @@
 record16(UChar(static_cast(c)));
 }
 
-template  ALWAYS_INLINE JSTokenType Lexer::parseIdentifier(JSTokenData* lvalp, unsigned lexType)
+template  ALWAYS_INLINE JSTokenType Lexer::parseIdentifier(JSTokenData* tokenData, unsigned lexType)
 {
 const ptrdiff_t remaining = m_codeEnd - m_code;
 if ((remaining >= maxTokenLength) && !(lexType & IgnoreReservedWords)) {
-JSTokenType keyword = parseKeyword(lvalp);
+JSTokenType keyword = parseKeyword(tokenData);
 if (keyword != IDENT) {
-ASSERT((!shouldCreateIdentifier) || lvalp->ident);
+ASSERT((!shouldCreateIdentifier) || tokenData->ident);
 return keyword;
 }
 }
@@ -457,9 +457,9 @@
 }
 
 ident = makeIdentifier(identifierStart, identifierLength);
-lvalp->ident = ident;
+tokenData->ident = ident;
 } else
-lvalp->ident = 0;
+tokenData->ident = 0;
 
 m_delimited = false;
 
@@ -478,7 +478,7 @@
 return IDENT;
 }
 
-template  ALWAYS_INLINE bool Lexer::parseString(JSTokenData* lvalp, bool strictMode)
+template  ALWAYS_INLINE bool Lexer::parseString(JSTokenData* tokenData, bool strictMode)
 {
 int stringQuoteCharacter = m_current;
 shift();
@@ -574,9 +574,9 @@
 if (currentCharacter() != stringStart && shouldBuildStrings)
 m_buffer16.append(stringStart, currentCharacter() - stringStart);
 if (shouldBuildStrings)
-lvalp->ident = makeIdentifier(m_buffer16.data(), m_buffer16.size());
+tokenData->ident = makeIdentifier(m_buffer16.data(), m_buffer16.size());
 else
-lvalp->ident = 0;
+tokenData->ident = 0;
 
 m_buffer16.resize(0);
 return true;
@@ -752,7 +752,7 @@
 return code < m_codeEnd && *code == ':';
 }
 
-JSTokenType Lexer::lex(JSTokenData* lvalp, JSTokenInfo* llocp, unsigned lexType, bool strictMode)
+JSTokenType Lexer::lex(JSTokenData* tokenData, JSTokenInfo* tokenInfo, unsigned lexType, bool strictMode)
 {
 ASSERT(!m_error);
 ASSERT(m_buffer8.isEmpty());
@@ -1007,12 +1007,12 @@
 token = SEMICOLON;
 break;
 case CharacterOpenBrace:
-lvalp->intValue = currentOffset();
+tokenData->intValue = currentOffset();
 shift();
 token = OPENBRACE;
 break;
 case CharacterCloseBrace:
-lvalp->intValue = currentOffset();
+tokenData->intValue = currentOffset();
 m_delimited = true;
 shift();
 token = CLOSEBRACE;
@@ -1027,12 +1027,12 @@
 case CharacterZero:
 shift();
 if ((m_current | 0x20) == 'x' && isASCIIHexDigit(peek(1))) {
-parseHex(lvalp->doubleValue);
+parseHex(tokenData->doubleValue);
 token = NUMBER;
 } else {
 record8('0');
 if (isASCIIOctalDigit(m_current)) {
-if (parseOctal(lvalp->doubleValue)) {
+if (parseOctal(tokenData->doubleValue)) {
 if (strictMode)
 goto returnError;
 token = NUMBER;
@@ -1042,7 +1042,7 @@
 // Fall through into Cha

[webkit-changes] [88723] trunk/Source/WebKit/efl

[commit-queue]

Title: [88723] trunk/Source/WebKit/efl








Revision 88723
Author commit-qu...@webkit.org
Date 2011-06-13 15:45:23 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Jaehun Lim  

Reviewed by Eric Seidel.

[EFL] Supports to execute "redo" command.
https://bugs.webkit.org/show_bug.cgi?id=62536

Implements basic functions for "redo" command.

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::registerCommandForUndo):
(WebCore::EditorClientEfl::registerCommandForRedo):
(WebCore::EditorClientEfl::clearUndoRedoOperations):
(WebCore::EditorClientEfl::canRedo):
(WebCore::EditorClientEfl::redo):
* WebCoreSupport/EditorClientEfl.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp
trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (88722 => 88723)

--- trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:44:59 UTC (rev 88722)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:45:23 UTC (rev 88723)
@@ -1,3 +1,20 @@
+2011-06-13  Jaehun Lim  
+
+Reviewed by Eric Seidel.
+
+[EFL] Supports to execute "redo" command.
+https://bugs.webkit.org/show_bug.cgi?id=62536
+
+Implements basic functions for "redo" command.
+
+* WebCoreSupport/EditorClientEfl.cpp:
+(WebCore::EditorClientEfl::registerCommandForUndo):
+(WebCore::EditorClientEfl::registerCommandForRedo):
+(WebCore::EditorClientEfl::clearUndoRedoOperations):
+(WebCore::EditorClientEfl::canRedo):
+(WebCore::EditorClientEfl::redo):
+* WebCoreSupport/EditorClientEfl.h:
+
 2011-06-13  Grzegorz Czajkowski  
 
 Reviewed by Eric Seidel.


Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp (88722 => 88723)

--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp	2011-06-13 22:44:59 UTC (rev 88722)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp	2011-06-13 22:45:23 UTC (rev 88723)
@@ -147,17 +147,19 @@
 
 void EditorClientEfl::registerCommandForUndo(WTF::PassRefPtr command)
 {
+redoStack.clear();
 undoStack.append(command);
 }
 
-void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtr)
+void EditorClientEfl::registerCommandForRedo(WTF::PassRefPtr command)
 {
-notImplemented();
+redoStack.append(command);
 }
 
 void EditorClientEfl::clearUndoRedoOperations()
 {
 undoStack.clear();
+redoStack.clear();
 }
 
 bool EditorClientEfl::canCopyCut(Frame*, bool defaultValue) const
@@ -177,8 +179,7 @@
 
 bool EditorClientEfl::canRedo() const
 {
-notImplemented();
-return false;
+return !redoStack.isEmpty();
 }
 
 void EditorClientEfl::undo()
@@ -190,7 +191,9 @@
 
 void EditorClientEfl::redo()
 {
-notImplemented();
+RefPtr command(*(--redoStack.end()));
+redoStack.remove(--redoStack.end());
+command->reapply();
 }
 
 bool EditorClientEfl::shouldInsertNode(Node*, Range*, EditorInsertAction)


Modified: trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h (88722 => 88723)

--- trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h	2011-06-13 22:44:59 UTC (rev 88722)
+++ trunk/Source/WebKit/efl/WebCoreSupport/EditorClientEfl.h	2011-06-13 22:45:23 UTC (rev 88723)
@@ -47,6 +47,7 @@
 class EditorClientEfl : public EditorClient, public TextCheckerClient {
 protected:
 WTF::Deque > undoStack;
+WTF::Deque > redoStack;
 
 public:
 EditorClientEfl(Evas_Object *view);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88722] trunk/Source/WebKit2

[commit-queue]

Title: [88722] trunk/Source/WebKit2








Revision 88722
Author commit-qu...@webkit.org
Date 2011-06-13 15:44:59 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryuan Choi  

Reviewed by Kenneth Rohde Christiansen.

[EFL][WK2] Add dummy files at below of WebProcess.
https://bugs.webkit.org/show_bug.cgi?id=62445

Add Efl related directory and files in WebKit2/WebProcess/.

* WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Added.
(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
* WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
(WebKit::InjectedBundle::load):
(WebKit::InjectedBundle::activateMacFontAscentHack):
* WebProcess/WebPage/efl/WebInspectorEfl.cpp: Added.
(WebKit::WebInspector::localizedStringsURL):
* WebProcess/WebPage/efl/WebPageEfl.cpp: Added.
(WebKit::WebPage::platformInitialize):
(WebKit::WebPage::platformPreferencesDidChange):
(WebKit::scroll):
(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
(WebKit::WebPage::platformHasLocalDataForURL):
(WebKit::WebPage::cachedResponseMIMETypeForURL):
(WebKit::WebPage::platformCanHandleRequest):
(WebKit::WebPage::cachedSuggestedFilenameForURL):
(WebKit::WebPage::cachedResponseDataForURL):
* WebProcess/efl/WebProcessEfl.cpp: Added.
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::WebProcess::platformInitializeWebProcess):
(WebKit::WebProcess::platformTerminate):
* WebProcess/efl/WebProcessMainEfl.cpp: Added.
(WebKit::WebProcessMainEfl):
* WebProcess/efl/WebProcessMainEfl.h: Added.
* efl/MainEfl.cpp: Added.
(main):

Modified Paths

trunk/Source/WebKit2/ChangeLog


Added Paths

trunk/Source/WebKit2/WebProcess/Cookies/efl/
trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/efl/
trunk/Source/WebKit2/WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/efl/
trunk/Source/WebKit2/WebProcess/WebPage/efl/WebInspectorEfl.cpp
trunk/Source/WebKit2/WebProcess/WebPage/efl/WebPageEfl.cpp
trunk/Source/WebKit2/WebProcess/efl/
trunk/Source/WebKit2/WebProcess/efl/WebProcessEfl.cpp
trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp
trunk/Source/WebKit2/WebProcess/efl/WebProcessMainEfl.h
trunk/Source/WebKit2/efl/
trunk/Source/WebKit2/efl/MainEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88721 => 88722)

--- trunk/Source/WebKit2/ChangeLog	2011-06-13 22:39:32 UTC (rev 88721)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-13 22:44:59 UTC (rev 88722)
@@ -1,3 +1,41 @@
+2011-06-13  Ryuan Choi  
+
+Reviewed by Kenneth Rohde Christiansen.
+
+[EFL][WK2] Add dummy files at below of WebProcess.
+https://bugs.webkit.org/show_bug.cgi?id=62445
+
+Add Efl related directory and files in WebKit2/WebProcess/.
+
+* WebProcess/Cookies/efl/WebCookieManagerEfl.cpp: Added.
+(WebKit::WebCookieManager::platformSetHTTPCookieAcceptPolicy):
+(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy):
+* WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
+(WebKit::InjectedBundle::load):
+(WebKit::InjectedBundle::activateMacFontAscentHack):
+* WebProcess/WebPage/efl/WebInspectorEfl.cpp: Added.
+(WebKit::WebInspector::localizedStringsURL):
+* WebProcess/WebPage/efl/WebPageEfl.cpp: Added.
+(WebKit::WebPage::platformInitialize):
+(WebKit::WebPage::platformPreferencesDidChange):
+(WebKit::scroll):
+(WebKit::WebPage::performDefaultBehaviorForKeyEvent):
+(WebKit::WebPage::platformHasLocalDataForURL):
+(WebKit::WebPage::cachedResponseMIMETypeForURL):
+(WebKit::WebPage::platformCanHandleRequest):
+(WebKit::WebPage::cachedSuggestedFilenameForURL):
+(WebKit::WebPage::cachedResponseDataForURL):
+* WebProcess/efl/WebProcessEfl.cpp: Added.
+(WebKit::WebProcess::platformSetCacheModel):
+(WebKit::WebProcess::platformClearResourceCaches):
+(WebKit::WebProcess::platformInitializeWebProcess):
+(WebKit::WebProcess::platformTerminate):
+* WebProcess/efl/WebProcessMainEfl.cpp: Added.
+(WebKit::WebProcessMainEfl):
+* WebProcess/efl/WebProcessMainEfl.h: Added.
+* efl/MainEfl.cpp: Added.
+(main):
+
 2011-06-13  Eunmi Lee  
 
 Reviewed by Eric Seidel.


Added: trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp (0 => 88722)

--- trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp	(rev 0)
+++ trunk/Source/WebKit2/WebProcess/Cookies/efl/WebCookieManagerEfl.cpp	2011-06-13 22:44:59 UTC (rev 88

[webkit-changes] [88721] trunk/Source/WebCore

[dglazkov]

Title: [88721] trunk/Source/WebCore








Revision 88721
Author dglaz...@chromium.org
Date 2011-06-13 15:39:32 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Dimitri Glazkov  

Unreviewed, rolling out r88704.
http://trac.webkit.org/changeset/88704
https://bugs.webkit.org/show_bug.cgi?id=62466

Caused layout test failures on Chromium Mac.

* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::declareAndWriteDragImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88720 => 88721)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:39:28 UTC (rev 88720)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 22:39:32 UTC (rev 88721)
@@ -1,3 +1,14 @@
+2011-06-13  Dimitri Glazkov  
+
+Unreviewed, rolling out r88704.
+http://trac.webkit.org/changeset/88704
+https://bugs.webkit.org/show_bug.cgi?id=62466
+
+Caused layout test failures on Chromium Mac.
+
+* platform/chromium/ClipboardChromium.cpp:
+(WebCore::ClipboardChromium::declareAndWriteDragImage):
+
 2011-06-13   Morgan Winer  
 
 Reviewed by Enrica Casucci.


Modified: trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp (88720 => 88721)

--- trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp	2011-06-13 22:39:28 UTC (rev 88720)
+++ trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp	2011-06-13 22:39:32 UTC (rev 88721)
@@ -264,11 +264,8 @@
 if (fullURL.isEmpty())
 return;
 
-#if !defined(OS_MACOSX)
-// Put img tag on the clipboard referencing the image. We don't do this on Mac to match Safari
-// behavior and to ensure that an image dragged to Mail.app is properly attached.
+// Put img tag on the clipboard referencing the image
 m_dataObject->setData(mimeTypeTextHTML, imageToMarkup(fullURL, element));
-#endif
 }
 
 void ClipboardChromium::writeURL(const KURL& url, const String& title, Frame*)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88719] trunk/Source/JavaScriptCore

[oliver]

Title: [88719] trunk/Source/_javascript_Core








Revision 88719
Author oli...@apple.com
Date 2011-06-13 15:38:22 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Oliver Hunt  

Reviewed by Gavin Barraclough.

Make it possible to inline the common case of identifier lexing
https://bugs.webkit.org/show_bug.cgi?id=62600

Add a lexing function that expects to lex an "normal" alpha numeric
identifier (that ignores keywords) so it's possible to inline the
common parsing cases.  This comes out as a reasonable parsing speed
boost.

* parser/JSParser.cpp:
(JSC::JSParser::nextExpectIdentifier):
(JSC::JSParser::parseProperty):
(JSC::JSParser::parseMemberExpression):
* parser/Lexer.cpp:
* parser/Lexer.h:
(JSC::Lexer::makeIdentifier):
(JSC::Lexer::lexExpectIdentifier):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/parser/JSParser.cpp
trunk/Source/_javascript_Core/parser/Lexer.cpp
trunk/Source/_javascript_Core/parser/Lexer.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (88718 => 88719)

--- trunk/Source/_javascript_Core/ChangeLog	2011-06-13 22:38:03 UTC (rev 88718)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-06-13 22:38:22 UTC (rev 88719)
@@ -1,3 +1,24 @@
+2011-06-13  Oliver Hunt  
+
+Reviewed by Gavin Barraclough.
+
+Make it possible to inline the common case of identifier lexing
+https://bugs.webkit.org/show_bug.cgi?id=62600
+
+Add a lexing function that expects to lex an "normal" alpha numeric
+identifier (that ignores keywords) so it's possible to inline the
+common parsing cases.  This comes out as a reasonable parsing speed
+boost.
+
+* parser/JSParser.cpp:
+(JSC::JSParser::nextExpectIdentifier):
+(JSC::JSParser::parseProperty):
+(JSC::JSParser::parseMemberExpression):
+* parser/Lexer.cpp:
+* parser/Lexer.h:
+(JSC::Lexer::makeIdentifier):
+(JSC::Lexer::lexExpectIdentifier):
+
 2011-06-13  Xan Lopez  
 
 Reviewed by Martin Robinson.


Modified: trunk/Source/_javascript_Core/parser/JSParser.cpp (88718 => 88719)

--- trunk/Source/_javascript_Core/parser/JSParser.cpp	2011-06-13 22:38:03 UTC (rev 88718)
+++ trunk/Source/_javascript_Core/parser/JSParser.cpp	2011-06-13 22:38:22 UTC (rev 88719)
@@ -107,6 +107,14 @@
 m_token.m_type = m_lexer->lex(&m_token.m_data, &m_token.m_info, lexType, strictMode());
 }
 
+ALWAYS_INLINE void nextExpectIdentifier(unsigned lexType = 0)
+{
+m_lastLine = m_token.m_info.line;
+m_lastTokenEnd = m_token.m_info.endOffset;
+m_lexer->setLastLineNumber(m_lastLine);
+m_token.m_type = m_lexer->lexExpectIdentifier(&m_token.m_data, &m_token.m_info, lexType, strictMode());
+}
+
 ALWAYS_INLINE bool nextTokenIsColon()
 {
 return m_lexer->nextTokenIsColon();
@@ -1707,9 +1715,9 @@
 case STRING: {
 const Identifier* ident = m_token.m_data.ident;
 if (complete || (wasIdent && (*ident == m_globalData->propertyNames->get || *ident == m_globalData->propertyNames->set)))
-next(Lexer::IgnoreReservedWords);
+nextExpectIdentifier(Lexer::IgnoreReservedWords);
 else
-next(Lexer::IgnoreReservedWords | TreeBuilder::DontBuildKeywords);
+nextExpectIdentifier(Lexer::IgnoreReservedWords | TreeBuilder::DontBuildKeywords);
 
 if (match(COLON)) {
 next();
@@ -2038,7 +2046,7 @@
 case DOT: {
 m_nonTrivialExpressionCount++;
 int expressionEnd = lastTokenEnd();
-next(Lexer::IgnoreReservedWords | TreeBuilder::DontBuildKeywords);
+nextExpectIdentifier(Lexer::IgnoreReservedWords | TreeBuilder::DontBuildKeywords);
 matchOrFail(IDENT);
 base = context.createDotAccess(base, m_token.m_data.ident, expressionStart, expressionEnd, tokenEnd());
 next();


Modified: trunk/Source/_javascript_Core/parser/Lexer.cpp (88718 => 88719)

--- trunk/Source/_javascript_Core/parser/Lexer.cpp	2011-06-13 22:38:03 UTC (rev 88718)
+++ trunk/Source/_javascript_Core/parser/Lexer.cpp	2011-06-13 22:38:22 UTC (rev 88719)
@@ -331,11 +331,6 @@
 ++m_lineNumber;
 }
 
-ALWAYS_INLINE const Identifier* Lexer::makeIdentifier(const UChar* characters, size_t length)
-{
-return &m_arena->makeIdentifier(m_globalData, characters, length);
-}
-
 ALWAYS_INLINE bool Lexer::lastTokenWasRestrKeyword() const
 {
 return m_lastToken == CONTINUE || m_lastToken == BREAK || m_lastToken == RETURN || m_lastToken == THROW;


Modified: trunk/Source/_javascript_Core/parser/Lexer.h (88718 => 88719)

--- trunk/Source/_javascript_Core/parser/Lexer.h	2011-06-13 22:38:03 UTC (rev 88718)
+++ trunk/Source/_javascript_Core/parser/Lexer.h	2011-06-13 22:38:22 UTC (rev 88719)
@@ -88,7 +88,9 @@
 }
 
 So

[webkit-changes] [88718] trunk/Source/WebCore

[enrica]

Title: [88718] trunk/Source/WebCore








Revision 88718
Author enr...@apple.com
Date 2011-06-13 15:38:03 -0700 (Mon, 13 Jun 2011)


Log Message
Frame::visiblePositionForPoint returns null position if the point is over an imagemap.
https://bugs.webkit.org/show_bug.cgi?id=62562


Patch by Morgan Winer  on 2011-06-13
Reviewed by Enrica Casucci.

The innerNode() of an imageMap is an area, and doesn't have a renderer and
therefore can't report a position.
Every result's innerNonSharedNode() should be the same as the innerNode(),
except for imageMaps, which will have the actual image as its innerNonSharedNode(),
and will therefore have a renderer and can report a position.

There are no layout tests for this, since it can be tested only at API level.

* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint): Changing innerNode() to innerNonSharedNode().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Frame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88717 => 88718)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:37:16 UTC (rev 88717)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 22:38:03 UTC (rev 88718)
@@ -1,3 +1,22 @@
+2011-06-13   Morgan Winer  
+
+Reviewed by Enrica Casucci.
+
+Frame::visiblePositionForPoint returns null position if the point is over an imagemap.
+https://bugs.webkit.org/show_bug.cgi?id=62562
+
+
+The innerNode() of an imageMap is an area, and doesn't have a renderer and
+therefore can't report a position.
+Every result's innerNonSharedNode() should be the same as the innerNode(),
+except for imageMaps, which will have the actual image as its innerNonSharedNode(),
+and will therefore have a renderer and can report a position.
+
+There are no layout tests for this, since it can be tested only at API level.
+
+* page/Frame.cpp:
+(WebCore::Frame::visiblePositionForPoint): Changing innerNode() to innerNonSharedNode().
+
 2011-06-13  Lucas De Marchi  
 
 Reviewed by Eric Seidel.


Modified: trunk/Source/WebCore/page/Frame.cpp (88717 => 88718)

--- trunk/Source/WebCore/page/Frame.cpp	2011-06-13 22:37:16 UTC (rev 88717)
+++ trunk/Source/WebCore/page/Frame.cpp	2011-06-13 22:38:03 UTC (rev 88718)
@@ -858,7 +858,7 @@
 VisiblePosition Frame::visiblePositionForPoint(const IntPoint& framePoint)
 {
 HitTestResult result = eventHandler()->hitTestResultAtPoint(framePoint, true);
-Node* node = result.innerNode();
+Node* node = result.innerNonSharedNode();
 if (!node)
 return VisiblePosition();
 RenderObject* renderer = node->renderer();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88717] trunk/LayoutTests

[commit-queue]

Title: [88717] trunk/LayoutTests








Revision 88717
Author commit-qu...@webkit.org
Date 2011-06-13 15:37:16 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Wyatt Carss  

Reviewed by Ryosuke Niwa.

dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
https://bugs.webkit.org/show_bug.cgi?id=58159

Converted to dump the key part of page as text. The platform-dependent files are
copied from the previous setup of this test, as mac appears to do something different
in its delegate info -- 'insertText' instead of 'insertNode', and some differences
in how it counts indices. Note that chromium-mac works the same as chromium-win, but
would hit mac first. GTK appears to pass for now; if tests fail we'll reorganize these
a bit accordingly.

* editing/pasteboard/paste-xml.xhtml:
* platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium-win/editing/pasteboard/paste-xml-expected.png: Removed.
* platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac/editing/pasteboard/paste-xml-expected.png: Removed.
* platform/mac/editing/pasteboard/paste-xml-expected.txt:
* platform/win/editing/pasteboard/paste-xml-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/paste-xml.xhtml
trunk/LayoutTests/platform/chromium/test_expectations.txt
trunk/LayoutTests/platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-xml-expected.txt
trunk/LayoutTests/platform/win/editing/pasteboard/paste-xml-expected.txt


Removed Paths

trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/paste-xml-expected.png
trunk/LayoutTests/platform/chromium-win/editing/pasteboard/paste-xml-expected.png
trunk/LayoutTests/platform/mac/editing/pasteboard/paste-xml-expected.png




Diff

Modified: trunk/LayoutTests/ChangeLog (88716 => 88717)

--- trunk/LayoutTests/ChangeLog	2011-06-13 22:36:45 UTC (rev 88716)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 22:37:16 UTC (rev 88717)
@@ -1,3 +1,27 @@
+2011-06-13  Wyatt Carss  
+
+Reviewed by Ryosuke Niwa.
+
+dump-as-markup conversion: editing/pasteboard/paste-xml.xhtml
+https://bugs.webkit.org/show_bug.cgi?id=58159
+
+Converted to dump the key part of page as text. The platform-dependent files are
+copied from the previous setup of this test, as mac appears to do something different
+in its delegate info -- 'insertText' instead of 'insertNode', and some differences
+in how it counts indices. Note that chromium-mac works the same as chromium-win, but
+would hit mac first. GTK appears to pass for now; if tests fail we'll reorganize these
+a bit accordingly.
+
+* editing/pasteboard/paste-xml.xhtml:
+* platform/chromium-linux/editing/pasteboard/paste-xml-expected.png: Removed.
+* platform/chromium-mac/editing/pasteboard/paste-xml-expected.txt:
+* platform/chromium-win/editing/pasteboard/paste-xml-expected.png: Removed.
+* platform/chromium-win/editing/pasteboard/paste-xml-expected.txt:
+* platform/chromium/test_expectations.txt:
+* platform/mac/editing/pasteboard/paste-xml-expected.png: Removed.
+* platform/mac/editing/pasteboard/paste-xml-expected.txt:
+* platform/win/editing/pasteboard/paste-xml-expected.txt:
+
 2011-06-13  Mark Pilgrim  
 
 Reviewed by Eric Seidel.


Modified: trunk/LayoutTests/editing/pasteboard/paste-xml.xhtml (88716 => 88717)

--- trunk/LayoutTests/editing/pasteboard/paste-xml.xhtml	2011-06-13 22:36:45 UTC (rev 88716)
+++ trunk/LayoutTests/editing/pasteboard/paste-xml.xhtml	2011-06-13 22:37:16 UTC (rev 88717)
@@ -37,7 +37,7 @@
 
 
 
-runEditingTest();
+runDumpAsTextEditingTest(true);
 
 
 


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88716 => 88717)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 22:36:45 UTC (rev 88716)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 22:37:16 UTC (rev 88717)
@@ -3214,7 +3214,6 @@
 BUGCR780807 : http/tests/misc/webtiming-origins.html = PASS TEXT
 
 BUGCR78835 : plugins/npp-set-window-called-during-destruction.html = CRASH
-BUGWK58158 : editing/pasteboard/paste-xml.xhtml = PASS TEXT
 BUGCR78988 LINUX : svg/zoom/text/absolute-sized-document-no-scrollbars.svg = CRASH PASS
 BUGCR78996 DEBUG : fast/css/first-of-type-pseudo-class.html = PASS TEXT
 // http://trac.webkit.org/changeset/83411/ merged some frame tests into one.


Deleted: trunk/LayoutTests/platform/chromium-linux/editing/pasteboard/paste-xml-expected.png

(Binary files differ)


Modified: trunk/Layou

[webkit-changes] [88716] trunk

[commit-queue]

Title: [88716] trunk








Revision 88716
Author commit-qu...@webkit.org
Date 2011-06-13 15:36:45 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Lucas De Marchi  

Reviewed by Eric Seidel.

[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277

Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.

* Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE
2011-06-13  Lucas De Marchi  

Reviewed by Eric Seidel.

[CMAKE] Conditionally generate DerivedSources
https://bugs.webkit.org/show_bug.cgi?id=62277

Speedup build by not generating DerivedSources of features that are
disabled. This was already been done for some features like ENABLE_SVG
and now it's extended the following features: ENABLE_DATABASE,
ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
ENABLE_DATA_TRANSFER_ITEMS.

No change in functionality so no new tests.

* CMakeLists.txt: move .idl files to be conditionally generated.

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/cmakeconfig.h.cmake




Diff

Modified: trunk/ChangeLog (88715 => 88716)

--- trunk/ChangeLog	2011-06-13 22:32:47 UTC (rev 88715)
+++ trunk/ChangeLog	2011-06-13 22:36:45 UTC (rev 88716)
@@ -1,3 +1,19 @@
+2011-06-13  Lucas De Marchi  
+
+Reviewed by Eric Seidel.
+
+[CMAKE] Conditionally generate DerivedSources
+https://bugs.webkit.org/show_bug.cgi?id=62277
+
+Speedup build by not generating DerivedSources of features that are
+disabled. This was already been done for some features like ENABLE_SVG
+and now it's extended the following features: ENABLE_DATABASE,
+ENABLE_INDEXED_DATABASE, ENABLE_DOM_STORAGE, ENABLE_XPATH,
+ENABLE_OFFLINE_WEB_APPLICATIONS, ENABLE_WEB_SOCKETS,
+ENABLE_DATA_TRANSFER_ITEMS.
+
+* Source/cmakeconfig.h.cmake: add definition for INDEXED_DATABASE
+
 2011-06-10  Lucas De Marchi  
 
 Reviewed by Kenneth Rohde Christiansen.


Modified: trunk/Source/WebCore/CMakeLists.txt (88715 => 88716)

--- trunk/Source/WebCore/CMakeLists.txt	2011-06-13 22:32:47 UTC (rev 88715)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-06-13 22:36:45 UTC (rev 88716)
@@ -137,7 +137,6 @@
 dom/Comment.idl
 dom/CompositionEvent.idl
 dom/CustomEvent.idl
-dom/DataTransferItem.idl
 dom/DataTransferItems.idl
 dom/DeviceMotionEvent.idl
 dom/DeviceOrientationEvent.idl
@@ -176,7 +175,6 @@
 dom/ProgressEvent.idl
 dom/RangeException.idl
 dom/Range.idl
-dom/StringCallback.idl
 dom/TextEvent.idl
 dom/Text.idl
 dom/TouchEvent.idl
@@ -316,8 +314,6 @@
 inspector/ScriptProfile.idl
 inspector/ScriptProfileNode.idl
 
-loader/appcache/DOMApplicationCache.idl
-
 page/BarInfo.idl
 page/Console.idl
 page/Coordinates.idl
@@ -353,34 +349,6 @@
 plugins/DOMPlugin.idl
 plugins/DOMPluginArray.idl
 
-storage/Database.idl
-storage/DatabaseCallback.idl
-storage/DatabaseSync.idl
-storage/IDBAny.idl
-storage/IDBCursor.idl
-storage/IDBDatabaseError.idl
-storage/IDBDatabaseException.idl
-storage/IDBDatabase.idl
-storage/IDBFactory.idl
-storage/IDBIndex.idl
-storage/IDBKey.idl
-storage/IDBKeyRange.idl
-storage/IDBObjectStore.idl
-storage/IDBRequest.idl
-storage/IDBTransaction.idl
-storage/SQLError.idl
-storage/SQLException.idl
-storage/SQLResultSet.idl
-storage/SQLResultSetRowList.idl
-storage/SQLStatementCallback.idl
-storage/SQLStatementErrorCallback.idl
-storage/SQLTransaction.idl
-storage/SQLTransactionCallback.idl
-storage/SQLTransactionErrorCallback.idl
-storage/SQLTransactionSync.idl
-storage/SQLTransactionSyncCallback.idl
-storage/Storage.idl
-storage/StorageEvent.idl
 storage/StorageInfo.idl
 storage/StorageInfoErrorCallback.idl
 storage/StorageInfoQuotaCallback.idl
@@ -407,9 +375,6 @@
 webaudio/LowPass2FilterNode.idl
 webaudio/RealtimeAnalyserNode.idl
 
-websockets/CloseEvent.idl
-websockets/WebSocket.idl
-
 workers/AbstractWorker.idl
 workers/DedicatedWorkerContext.idl
 workers/SharedWorker.idl
@@ -424,11 +389,6 @@
 xml/XMLHttpRequestProgressEvent.idl
 xml/XMLHttpRequestUpload.idl
 xml/XMLSerializer.idl
-xml/XPathEvaluator.idl
-xml/XPathException.idl
-xml/XPathExpression.idl
-xml/XPathNSResolver.idl
-xml/XPathResult.idl
 xml/XSLTProcesso

[webkit-changes] [88715] trunk/LayoutTests

[commit-queue]

Title: [88715] trunk/LayoutTests








Revision 88715
Author commit-qu...@webkit.org
Date 2011-06-13 15:32:47 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Mark Pilgrim  

Reviewed by Eric Seidel.

IndexedDB test: Infinity as key
https://bugs.webkit.org/show_bug.cgi?id=62285

* storage/indexeddb/key-type-infinity-expected.txt: Added.
* storage/indexeddb/key-type-infinity.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/storage/indexeddb/key-type-infinity-expected.txt
trunk/LayoutTests/storage/indexeddb/key-type-infinity.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88714 => 88715)

--- trunk/LayoutTests/ChangeLog	2011-06-13 22:30:02 UTC (rev 88714)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 22:32:47 UTC (rev 88715)
@@ -2,6 +2,16 @@
 
 Reviewed by Eric Seidel.
 
+IndexedDB test: Infinity as key
+https://bugs.webkit.org/show_bug.cgi?id=62285
+
+* storage/indexeddb/key-type-infinity-expected.txt: Added.
+* storage/indexeddb/key-type-infinity.html: Added.
+
+2011-06-13  Mark Pilgrim  
+
+Reviewed by Eric Seidel.
+
 IndexedDB test: odd database names
 https://bugs.webkit.org/show_bug.cgi?id=62322
 


Added: trunk/LayoutTests/storage/indexeddb/key-type-infinity-expected.txt (0 => 88715)

--- trunk/LayoutTests/storage/indexeddb/key-type-infinity-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/key-type-infinity-expected.txt	2011-06-13 22:32:47 UTC (rev 88715)
@@ -0,0 +1,26 @@
+Test IndexedDB key types
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
+PASS indexedDB == null is false
+IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;
+PASS IDBDatabaseException == null is false
+IDBCursor = window.IDBCursor || window.webkitIDBCursor;
+PASS IDBCursor == null is false
+IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
+PASS IDBKeyRange == null is false
+indexedDB.open(name, description)
+db = event.target.result
+request = db.setVersion('1')
+Deleted all object stores.
+db.createObjectStore('foo');
+test key as infinity
+request = objectStore.add([], Infinity);
+test key as negative infinity
+request = objectStore.add([], -Infinity);
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/storage/indexeddb/key-type-infinity.html (0 => 88715)

--- trunk/LayoutTests/storage/indexeddb/key-type-infinity.html	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/key-type-infinity.html	2011-06-13 22:32:47 UTC (rev 88715)
@@ -0,0 +1,75 @@
+
+
+
+
+
+
+
+
+
+description("Test IndexedDB key types");
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+function test()
+{
+indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;");
+shouldBeFalse("indexedDB == null");
+IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;");
+shouldBeFalse("IDBDatabaseException == null");
+IDBCursor = evalAndLog("IDBCursor = window.IDBCursor || window.webkitIDBCursor;");
+shouldBeFalse("IDBCursor == null");
+IDBKeyRange = evalAndLog("IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;");
+shouldBeFalse("IDBKeyRange == null");
+
+name = window.location.pathname;
+description = "My Test Database";
+request = evalAndLog("indexedDB.open(name, description)");
+request._onsuccess_ = openSuccess;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function openSuccess()
+{
+db = evalAndLog("db = event.target.result");
+
+request = evalAndLog("request = db.setVersion('1')");
+request._onsuccess_ = testGroup1;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function testGroup1()
+{
+deleteAllObjectStores(db);
+
+objectStore = evalAndLog("db.createObjectStore('foo');");
+debug("test key as infinity");
+request = evalAndLog("request = objectStore.add([], Infinity);");
+request._onsuccess_ = testGroup2;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function testGroup2()
+{
+debug("test key as negative infinity");
+request = evalAndLog("request = objectStore.add([], -Infinity);");
+request._onsuccess_ = testGroup3;
+request._onerror_ = unexpectedErrorCallback;
+}
+
+function testGroup3()
+{
+done();
+}
+
+var successfullyParsed = true;
+
+test();
+
+
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88714] trunk/Tools

[commit-queue]

Title: [88714] trunk/Tools








Revision 88714
Author commit-qu...@webkit.org
Date 2011-06-13 15:30:02 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Jaehun Lim  

Reviewed by Eric Seidel.

[EFL] Add load error handler to EWebLauncher
https://bugs.webkit.org/show_bug.cgi?id=62347

Add a handler function of "load,error" to EWebLauncher.
EWebLauncher now displays a simple error page on load errors.

* EWebLauncher/main.c:
(on_load_error):
(browserCreate):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/EWebLauncher/main.c




Diff

Modified: trunk/Tools/ChangeLog (88713 => 88714)

--- trunk/Tools/ChangeLog	2011-06-13 22:29:50 UTC (rev 88713)
+++ trunk/Tools/ChangeLog	2011-06-13 22:30:02 UTC (rev 88714)
@@ -1,3 +1,17 @@
+2011-06-13  Jaehun Lim  
+
+Reviewed by Eric Seidel.
+
+[EFL] Add load error handler to EWebLauncher
+https://bugs.webkit.org/show_bug.cgi?id=62347
+
+Add a handler function of "load,error" to EWebLauncher.
+EWebLauncher now displays a simple error page on load errors.
+
+* EWebLauncher/main.c:
+(on_load_error):
+(browserCreate):
+
 2011-06-13  Martin Robinson  
 
 Reviewed by Eric Seidel.


Modified: trunk/Tools/EWebLauncher/main.c (88713 => 88714)

--- trunk/Tools/EWebLauncher/main.c	2011-06-13 22:29:50 UTC (rev 88713)
+++ trunk/Tools/EWebLauncher/main.c	2011-06-13 22:30:02 UTC (rev 88714)
@@ -314,6 +314,16 @@
 }
 
 static void
+on_load_error(void *user_data, Evas_Object *webview, void *event_info)
+{
+const Ewk_Frame_Load_Error *err = (const Ewk_Frame_Load_Error *)event_info;
+char message[1024];
+snprintf(message, 1024, "ERROR!Code: %dDomain: %sDescription: %sURL: %s",
+ err->code, err->domain, err->description, err->failing_url);
+ewk_frame_contents_set(err->frame, message, 0, "text/html", "UTF-8", err->failing_url);
+}
+
+static void
 on_toolbars_visible_set(void* user_data, Evas_Object* webview, void* event_info)
 {
 Eina_Bool *visible = (Eina_Bool *)event_info;
@@ -711,6 +721,7 @@
 evas_object_smart_callback_add(app->browser, "title,changed", on_title_changed, app);
 evas_object_smart_callback_add(app->browser, "load,progress", on_progress, app);
 evas_object_smart_callback_add(app->browser, "load,finished", on_load_finished, app);
+evas_object_smart_callback_add(app->browser, "load,error", on_load_error, app);
 evas_object_smart_callback_add(app->browser, "viewport,changed", on_viewport_changed, app);
 
 evas_object_smart_callback_add(app->browser, "toolbars,visible,set", on_toolbars_visible_set, app);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88713] trunk/LayoutTests

[commit-queue]

Title: [88713] trunk/LayoutTests








Revision 88713
Author commit-qu...@webkit.org
Date 2011-06-13 15:29:50 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Mark Pilgrim  

Reviewed by Eric Seidel.

IndexedDB test: odd database names
https://bugs.webkit.org/show_bug.cgi?id=62322

* storage/indexeddb/database-odd-names-expected.txt: Added.
* storage/indexeddb/database-odd-names.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/storage/indexeddb/database-odd-names-expected.txt
trunk/LayoutTests/storage/indexeddb/database-odd-names.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88712 => 88713)

--- trunk/LayoutTests/ChangeLog	2011-06-13 22:25:34 UTC (rev 88712)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 22:29:50 UTC (rev 88713)
@@ -1,3 +1,13 @@
+2011-06-13  Mark Pilgrim  
+
+Reviewed by Eric Seidel.
+
+IndexedDB test: odd database names
+https://bugs.webkit.org/show_bug.cgi?id=62322
+
+* storage/indexeddb/database-odd-names-expected.txt: Added.
+* storage/indexeddb/database-odd-names.html: Added.
+
 2011-06-13  Martin Robinson  
 
 Reviewed by Eric Seidel.


Added: trunk/LayoutTests/storage/indexeddb/database-odd-names-expected.txt (0 => 88713)

--- trunk/LayoutTests/storage/indexeddb/database-odd-names-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/database-odd-names-expected.txt	2011-06-13 22:29:50 UTC (rev 88713)
@@ -0,0 +1,29 @@
+Test IndexedDB odd value datatypes
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
+PASS indexedDB == null is false
+IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;
+PASS IDBDatabaseException == null is false
+IDBCursor = window.IDBCursor || window.webkitIDBCursor;
+PASS IDBCursor == null is false
+IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
+PASS IDBKeyRange == null is false
+opening a database named null
+indexedDB.open(testData[nextToOpen].name, testData[nextToOpen].description)
+opening a database named faihu
+indexedDB.open(testData[nextToOpen].name, testData[nextToOpen].description)
+opening a database named unpaired surrogate
+indexedDB.open(testData[nextToOpen].name, testData[nextToOpen].description)
+opening a database named fffe
+indexedDB.open(testData[nextToOpen].name, testData[nextToOpen].description)
+opening a database named 
+indexedDB.open(testData[nextToOpen].name, testData[nextToOpen].description)
+opening a database named line separator
+indexedDB.open(testData[nextToOpen].name, testData[nextToOpen].description)
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/storage/indexeddb/database-odd-names.html (0 => 88713)

--- trunk/LayoutTests/storage/indexeddb/database-odd-names.html	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/database-odd-names.html	2011-06-13 22:29:50 UTC (rev 88713)
@@ -0,0 +1,54 @@
+
+
+
+
+
+
+
+
+
+description("Test IndexedDB odd value datatypes");
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+function test()
+{
+indexedDB = evalAndLog("indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;");
+shouldBeFalse("indexedDB == null");
+IDBDatabaseException = evalAndLog("IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;");
+shouldBeFalse("IDBDatabaseException == null");
+IDBCursor = evalAndLog("IDBCursor = window.IDBCursor || window.webkitIDBCursor;");
+shouldBeFalse("IDBCursor == null");
+IDBKeyRange = evalAndLog("IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;");
+shouldBeFalse("IDBKeyRange == null");
+
+testData = [{ description: 'null',   name: '\u' },
+{ description: 'faihu',  name: '\ud800\udf46' },
+{ description: 'unpaired surrogate', name: '\ud800' },
+{ description: 'fffe',   name: '\ufffe' },
+{ description: '',   name: '\u' },
+{ description: 'line separator', name: '\u2028' }
+];
+nextToOpen = 0;
+openNextDatabase();
+}
+
+function openNextDatabase()
+{
+debug("opening a database named " + testData[nextToOpen].description);
+request = evalAndLog("indexedDB.open(testData[nextToOpen].name, testData[nextToOpen].description)");
+request._onerror_ = unexpectedErrorCallback;
+request._onsuccess_ = ++nextToOpen < testData.length ? openNextDatabase : done;
+}
+
+var successfullyParsed = true;
+
+test();
+
+
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88712] trunk

[commit-queue]

Title: [88712] trunk








Revision 88712
Author commit-qu...@webkit.org
Date 2011-06-13 15:25:34 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Martin Robinson  

Reviewed by Eric Seidel.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove adjustCursorEvent from platform-specific test expectation for Chromium Linux,
since the TestPlugin no longer prints this event.

* platform/chromium-linux/plugins/mouse-events-expected.txt: Remove adjustCursorEvent output.
2011-06-13  Martin Robinson  

Reviewed by Eric Seidel.

[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
https://bugs.webkit.org/show_bug.cgi?id=62385

Remove duplicate TestNetscapePlugIn implementation. Having two copies
of this code makes keeping it in sync much more difficult. The files are
almost identical and this change ports the X11 changes to main.cpp.

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(NPP_New): Do not set the plugin as windowless always. Doing this breaks
some results on Qt and this seems to be unnecessary for the moment.
(keyEventToChar): Added this helper which converts a X11 keycode into a char.
(handleEventX11): Use the handler to properly convert the keycode. Do not print
adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
it should not be in the results.
(NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
XP_UNIX block is first by guarding against using a null instance.
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
the XP_UNIX define for Linux.
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
* GNUmakefile.am: Update source list.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium-linux/plugins/mouse-events-expected.txt
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/main.cpp
trunk/Tools/DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro
trunk/Tools/GNUmakefile.am


Removed Paths

trunk/Tools/DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (88711 => 88712)

--- trunk/LayoutTests/ChangeLog	2011-06-13 22:23:20 UTC (rev 88711)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 22:25:34 UTC (rev 88712)
@@ -1,3 +1,15 @@
+2011-06-13  Martin Robinson  
+
+Reviewed by Eric Seidel.
+
+[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
+https://bugs.webkit.org/show_bug.cgi?id=62385
+
+Remove adjustCursorEvent from platform-specific test expectation for Chromium Linux,
+since the TestPlugin no longer prints this event.
+
+* platform/chromium-linux/plugins/mouse-events-expected.txt: Remove adjustCursorEvent output.
+
 2011-06-13  Nate Chapin  
 
 Reviewed by Adam Barth.


Modified: trunk/LayoutTests/platform/chromium-linux/plugins/mouse-events-expected.txt (88711 => 88712)

--- trunk/LayoutTests/platform/chromium-linux/plugins/mouse-events-expected.txt	2011-06-13 22:23:20 UTC (rev 88711)
+++ trunk/LayoutTests/platform/chromium-linux/plugins/mouse-events-expected.txt	2011-06-13 22:25:34 UTC (rev 88712)
@@ -1,12 +1,7 @@
-CONSOLE MESSAGE: line 17: PLUGIN: adjustCursorEvent
-CONSOLE MESSAGE: line 17: PLUGIN: adjustCursorEvent
 CONSOLE MESSAGE: line 18: PLUGIN: getFocusEvent
 CONSOLE MESSAGE: line 18: PLUGIN: mouseDown at (12, 12)
 CONSOLE MESSAGE: line 19: PLUGIN: mouseUp at (12, 12)
-CONSOLE MESSAGE: line 20: PLUGIN: adjustCursorEvent
 CONSOLE MESSAGE: line 21: PLUGIN: mouseDown at (22, 22)
-CONSOLE MESSAGE: line 23: PLUGIN: adjustCursorEvent
 CONSOLE MESSAGE: line 23: PLUGIN: mouseUp at (32, 22)
-CONSOLE MESSAGE: line 24: PLUGIN: adjustCursorEvent
 
 Test for bug 11517: Flash clicks/interactivity not working properly.


Modified: trunk/Tools/ChangeLog (88711 => 88712)

--- trunk/Tools/ChangeLog	2011-06-13 22:23:20 UTC (rev 88711)
+++ trunk/Tools/ChangeLog	2011-06-13 22:25:34 UTC (rev 88712)
@@ -1,3 +1,28 @@
+2011-06-13  Martin Robinson  
+
+Reviewed by Eric Seidel.
+
+[GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
+https://bugs.webkit.org/show_bug.cgi?id=62385
+
+Remove duplicate TestNetscapePlugIn implementation. Having two copies
+of this code makes keeping it in sync much more difficult. The files are
+almost identical and this change ports the X11 changes to main.cpp.
+
+* DumpRenderTree/TestNetscapePlugIn/main.cpp:
+(NPP_New): Do not set the plugin as windowless always. Doing this breaks
+some results on Qt and this seems to be unnecessary for the moment.
+(keyEventToChar): Added this helper which converts a X11 keycode into a char.
+(han

[webkit-changes] [88711] trunk/Source/WebCore

[commit-queue]

Title: [88711] trunk/Source/WebCore








Revision 88711
Author commit-qu...@webkit.org
Date 2011-06-13 15:23:20 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Leandro Pereira  

Reviewed by Eric Seidel.

[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
without plugin support
https://bugs.webkit.org/show_bug.cgi?id=62394

No behaviour changes, so no new tests.

* CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and
Plugin{Package,View}None.cpp and move them to CMakeListWinCE and
CMakeListsEfl, respectively.
* CMakeListsEfl.txt:
* CMakeListsWinCE.txt:

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/CMakeListsEfl.txt
trunk/Source/WebCore/CMakeListsWinCE.txt
trunk/Source/WebCore/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (88710 => 88711)

--- trunk/Source/WebCore/CMakeLists.txt	2011-06-13 22:22:48 UTC (rev 88710)
+++ trunk/Source/WebCore/CMakeLists.txt	2011-06-13 22:23:20 UTC (rev 88711)
@@ -1501,15 +1501,8 @@
 LIST(APPEND WebCore_SOURCES
 plugins/PluginDebug.cpp
 plugins/PluginStream.cpp
-plugins/PluginPackage.cpp
-plugins/PluginView.cpp
 plugins/npapi.cpp
 )
-ELSE ()
-LIST(APPEND WebCore_SOURCES
-plugins/PluginPackageNone.cpp
-plugins/PluginViewNone.cpp
-)
 ENDIF ()
 
 IF (ENABLE_NOTIFICATIONS)


Modified: trunk/Source/WebCore/CMakeListsEfl.txt (88710 => 88711)

--- trunk/Source/WebCore/CMakeListsEfl.txt	2011-06-13 22:22:48 UTC (rev 88710)
+++ trunk/Source/WebCore/CMakeListsEfl.txt	2011-06-13 22:23:20 UTC (rev 88711)
@@ -75,6 +75,8 @@
   platform/posix/FileSystemPOSIX.cpp
   platform/text/efl/TextBreakIteratorInternalICUEfl.cpp
   plugins/PluginDataNone.cpp
+  plugins/PluginPackageNone.cpp
+  plugins/PluginViewNone.cpp
 )
 
 LIST(APPEND WebCore_USER_AGENT_STYLE_SHEETS


Modified: trunk/Source/WebCore/CMakeListsWinCE.txt (88710 => 88711)

--- trunk/Source/WebCore/CMakeListsWinCE.txt	2011-06-13 22:22:48 UTC (rev 88710)
+++ trunk/Source/WebCore/CMakeListsWinCE.txt	2011-06-13 22:23:20 UTC (rev 88711)
@@ -135,9 +135,13 @@
 plugins/win/PluginMessageThrottlerWin.cpp
 plugins/win/PluginPackageWin.cpp
 plugins/win/PluginViewWin.cpp
+plugins/PluginPackage.cpp
+plugins/PluginView.cpp
 )
 ELSE ()
 LIST(APPEND WebCore_SOURCES
 plugins/PluginPackage.cpp
+plugins/PluginPackageNone.cpp
+plugins/PluginViewNone.cpp
 )
 ENDIF ()


Modified: trunk/Source/WebCore/ChangeLog (88710 => 88711)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:22:48 UTC (rev 88710)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 22:23:20 UTC (rev 88711)
@@ -1,3 +1,19 @@
+2011-06-13  Leandro Pereira  
+
+Reviewed by Eric Seidel.
+
+[CMake] Allow building with ENABLE_NETSCAPE_PLUGIN_API on platforms
+without plugin support
+https://bugs.webkit.org/show_bug.cgi?id=62394
+
+No behaviour changes, so no new tests.
+
+* CMakeLists.txt: Remove references to Plugin{Package,View}.cpp and
+Plugin{Package,View}None.cpp and move them to CMakeListWinCE and
+CMakeListsEfl, respectively.
+* CMakeListsEfl.txt:
+* CMakeListsWinCE.txt:
+
 2011-06-13  Andrey Kosyakov  
 
 Reviewed by Eric Seidel.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88710] trunk/Source/WebKit/efl

[commit-queue]

Title: [88710] trunk/Source/WebKit/efl








Revision 88710
Author commit-qu...@webkit.org
Date 2011-06-13 15:22:48 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Grzegorz Czajkowski  

Reviewed by Eric Seidel.

[EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
https://bugs.webkit.org/show_bug.cgi?id=62365

These functions do not exist in any public headers and
they are not used internally.
Moreover ewk_view has the same functionality added
https://bugs.webkit.org/show_bug.cgi?id=60435

* ewk/ewk_frame.cpp:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_frame.cpp




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (88709 => 88710)

--- trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:22:16 UTC (rev 88709)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-06-13 22:22:48 UTC (rev 88710)
@@ -1,3 +1,17 @@
+2011-06-13  Grzegorz Czajkowski  
+
+Reviewed by Eric Seidel.
+
+[EFL] Remove ewk_frame_select_* functions from ewk_frame.cpp
+https://bugs.webkit.org/show_bug.cgi?id=62365
+
+These functions do not exist in any public headers and
+they are not used internally.
+Moreover ewk_view has the same functionality added
+https://bugs.webkit.org/show_bug.cgi?id=60435
+
+* ewk/ewk_frame.cpp:
+
 2011-06-13  Raphael Kubo da Costa  
 
 Reviewed by Kenneth Rohde Christiansen.


Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (88709 => 88710)

--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-06-13 22:22:16 UTC (rev 88709)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp	2011-06-13 22:22:48 UTC (rev 88710)
@@ -657,84 +657,7 @@
 return strdup(s.data());
 }
 
-static inline Eina_Bool _ewk_frame_editor_command(Ewk_Frame_Smart_Data* sd, const char* command)
-{
-return sd->frame->editor()->command(WTF::String::fromUTF8(command)).execute();
-}
-
 /**
- * Unselects whatever was selected.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_none(Evas_Object* o)
-{
-EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-return _ewk_frame_editor_command(sd, "Unselect");
-}
-
-/**
- * Selects everything.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_all(Evas_Object* o)
-{
-EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-return _ewk_frame_editor_command(sd, "SelectAll");
-}
-
-/**
- * Selects the current paragrah.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_paragraph(Evas_Object* o)
-{
-EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-return _ewk_frame_editor_command(sd, "SelectParagraph");
-}
-
-/**
- * Selects the current sentence.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_sentence(Evas_Object* o)
-{
-EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-return _ewk_frame_editor_command(sd, "SelectSentence");
-}
-
-/**
- * Selects the current line.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_line(Evas_Object* o)
-{
-EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-return _ewk_frame_editor_command(sd, "SelectLine");
-}
-
-/**
- * Selects the current word.
- *
- * @return @c EINA_TRUE if operation was executed, @c EINA_FALSE otherwise.
- */
-Eina_Bool ewk_frame_select_word(Evas_Object* o)
-{
-EWK_FRAME_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
-EINA_SAFETY_ON_NULL_RETURN_VAL(sd->frame, EINA_FALSE);
-return _ewk_frame_editor_command(sd, "SelectWord");
-}
-
-/**
  * Search the given text string in document.
  *
  * @param o frame object where to search text.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88708] trunk/LayoutTests

[commit-queue]

Title: [88708] trunk/LayoutTests








Revision 88708
Author commit-qu...@webkit.org
Date 2011-06-13 15:17:57 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Mark Pilgrim  

Reviewed by Eric Seidel.

IndexedDB test: readonly properties
https://bugs.webkit.org/show_bug.cgi?id=62392

* storage/indexeddb/readonly-expected.txt: Added.
* storage/indexeddb/readonly.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/storage/indexeddb/readonly-expected.txt
trunk/LayoutTests/storage/indexeddb/readonly.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88707 => 88708)

--- trunk/LayoutTests/ChangeLog	2011-06-13 22:16:15 UTC (rev 88707)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 22:17:57 UTC (rev 88708)
@@ -1,3 +1,13 @@
+2011-06-13  Mark Pilgrim  
+
+Reviewed by Eric Seidel.
+
+IndexedDB test: readonly properties
+https://bugs.webkit.org/show_bug.cgi?id=62392
+
+* storage/indexeddb/readonly-expected.txt: Added.
+* storage/indexeddb/readonly.html: Added.
+
 2011-06-13  Annie Sullivan  
 
 Reviewed by Dimitri Glazkov.


Added: trunk/LayoutTests/storage/indexeddb/readonly-expected.txt (0 => 88708)

--- trunk/LayoutTests/storage/indexeddb/readonly-expected.txt	(rev 0)
+++ trunk/LayoutTests/storage/indexeddb/readonly-expected.txt	2011-06-13 22:17:57 UTC (rev 88708)
@@ -0,0 +1,93 @@
+Test IndexedDB readonly properties
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+indexedDB = window.indexedDB || window.webkitIndexedDB || window.mozIndexedDB;
+PASS indexedDB == null is false
+IDBDatabaseException = window.IDBDatabaseException || window.webkitIDBDatabaseException;
+PASS IDBDatabaseException == null is false
+IDBCursor = window.IDBCursor || window.webkitIDBCursor;
+PASS IDBCursor == null is false
+IDBKeyRange = window.IDBKeyRange || window.webkitIDBKeyRange;
+PASS IDBKeyRange == null is false
+indexedDB.open(name, description)
+trying to set readonly property request.result
+request.result = Infinity
+PASS request.result is still [object IDBDatabase]
+trying to set readonly property request.errorCode
+request.errorCode = 666
+PASS request.errorCode is still 0
+trying to set readonly property request.source
+request.source = this
+PASS request.source is still [object IDBFactory]
+trying to set readonly property request.transaction
+request.transaction = this
+PASS request.transaction is still null
+trying to set readonly property request.readyState
+request.readyState = 666
+PASS request.readyState is still 2
+db = event.target.result
+trying to set readonly property db.name
+db.name = 'bar'
+PASS db.name is still foo
+request = db.setVersion('1')
+transaction = event.target.result;
+trying to set readonly property transaction.mode
+transaction.mode = 666
+PASS transaction.mode is still 2
+trying to set readonly property transaction.db
+transaction.db = this
+PASS transaction.db is still [object IDBDatabase]
+Deleted all object stores.
+objectStore = db.createObjectStore('foo');
+trying to set readonly property objectStore.name
+objectStore.name = 'bar'
+PASS objectStore.name is still foo
+trying to set readonly property objectStore.keyPath
+objectStore.keyPath = 'bar'
+PASS objectStore.keyPath is still null
+result = objectStore.add({}, 'first');
+result = objectStore.openCursor();
+cursor = event.target.result;
+trying to set readonly property cursor.source
+cursor.source = this
+PASS cursor.source is still [object IDBObjectStore]
+trying to set readonly property cursor.direction
+cursor.direction = 666
+PASS cursor.direction is still 0
+trying to set readonly property cursor.key
+cursor.key = Infinity
+PASS cursor.key is still first
+trying to set readonly property cursor.primaryKey
+cursor.primaryKey = Infinity
+PASS cursor.primaryKey is still first
+index = objectStore.createIndex('first', 'first');
+trying to set readonly property index.name
+index.name = 'bar'
+PASS index.name is still first
+trying to set readonly property index.objectStore
+index.objectStore = this
+PASS index.objectStore is still [object IDBObjectStore]
+trying to set readonly property index.keyPath
+index.keyPath = 'bar'
+PASS index.keyPath is still first
+trying to set readonly property index.unique
+index.unique = true
+PASS index.unique is still false
+trying to set readonly property keyRange.lower
+keyRange.lower = Infinity
+PASS keyRange.lower is still first
+trying to set readonly property keyRange.upper
+keyRange.upper = Infinity
+PASS keyRange.upper is still first
+trying to set readonly property keyRange.lowerOpen
+keyRange.lowerOpen = true
+PASS keyRange.lowerOpen is still false
+trying to set readonly property keyRange.upperOpen
+keyRange.upperOpen = true
+PASS keyRange.upperOpen is still false
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/storage/indexeddb/readonly.html (0 => 88708)

--- trunk/LayoutTests

[webkit-changes] [88707] trunk/Source/WebKit2

[commit-queue]

Title: [88707] trunk/Source/WebKit2








Revision 88707
Author commit-qu...@webkit.org
Date 2011-06-13 15:16:15 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Eunmi Lee  

Reviewed by Eric Seidel.

[EFL][WK2] Add initial WebInspectorEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62524

* UIProcess/efl/WebInspectorEfl.cpp: Added.
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformOpen):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):

Modified Paths

trunk/Source/WebKit2/ChangeLog


Added Paths

trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88706 => 88707)

--- trunk/Source/WebKit2/ChangeLog	2011-06-13 22:14:48 UTC (rev 88706)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-13 22:16:15 UTC (rev 88707)
@@ -2,6 +2,24 @@
 
 Reviewed by Eric Seidel.
 
+[EFL][WK2] Add initial WebInspectorEfl.cpp for webkit2 efl port
+https://bugs.webkit.org/show_bug.cgi?id=62524
+
+* UIProcess/efl/WebInspectorEfl.cpp: Added.
+(WebKit::WebInspectorProxy::platformCreateInspectorPage):
+(WebKit::WebInspectorProxy::platformOpen):
+(WebKit::WebInspectorProxy::platformDidClose):
+(WebKit::WebInspectorProxy::platformBringToFront):
+(WebKit::WebInspectorProxy::platformInspectedURLChanged):
+(WebKit::WebInspectorProxy::inspectorPageURL):
+(WebKit::WebInspectorProxy::platformAttach):
+(WebKit::WebInspectorProxy::platformDetach):
+(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
+
+2011-06-13  Eunmi Lee  
+
+Reviewed by Eric Seidel.
+
 [EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
 https://bugs.webkit.org/show_bug.cgi?id=62438
 


Added: trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp (0 => 88707)

--- trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/efl/WebInspectorEfl.cpp	2011-06-13 22:16:15 UTC (rev 88707)
@@ -0,0 +1,85 @@
+/*
+ * Copyright (C) 2011 Samsung Electronics
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "WebInspectorProxy.h"
+
+#if ENABLE(INSPECTOR)
+
+#include 
+#include 
+
+namespace WebKit {
+
+WebPageProxy* WebInspectorProxy::platformCreateInspectorPage()
+{
+notImplemented();
+return 0;
+}
+
+void WebInspectorProxy::platformOpen()
+{
+notImplemented();
+}
+
+void WebInspectorProxy::platformDidClose()
+{
+notImplemented();
+}
+
+void WebInspectorProxy::platformBringToFront()
+{
+notImplemented();
+}
+
+void WebInspectorProxy::platformInspectedURLChanged(const String&)
+{
+notImplemented();
+}
+
+String WebInspectorProxy::inspectorPageURL() const
+{
+notImplemented();
+return String();
+}
+
+void WebInspectorProxy::platformAttach()
+{
+notImplemented();
+}
+
+void WebInspectorProxy::platformDetach()
+{
+notImplemented();
+}
+
+void WebInspectorProxy::platformSetAttachedWindowHeight(unsigned)
+{
+notImplemented();
+}
+
+} // namespace WebKit
+
+#endif // ENABLE(INSPECTOR)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-ch

[webkit-changes] [88706] trunk/Source/WebKit2

[commit-queue]

Title: [88706] trunk/Source/WebKit2








Revision 88706
Author commit-qu...@webkit.org
Date 2011-06-13 15:14:48 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Eunmi Lee  

Reviewed by Eric Seidel.

[EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62438

* UIProcess/efl/TextCheckerEfl.cpp: Added.
(WebKit::TextChecker::state):
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::checkGrammarOfString):
(WebKit::TextChecker::spellingUIIsShowing):
(WebKit::TextChecker::toggleSpellingUIIsShowing):
(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):

Modified Paths

trunk/Source/WebKit2/ChangeLog


Added Paths

trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88705 => 88706)

--- trunk/Source/WebKit2/ChangeLog	2011-06-13 22:09:46 UTC (rev 88705)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-13 22:14:48 UTC (rev 88706)
@@ -1,3 +1,27 @@
+2011-06-13  Eunmi Lee  
+
+Reviewed by Eric Seidel.
+
+[EFL][WK2] Add initial TextCheckerEfl.cpp for webkit2 efl port
+https://bugs.webkit.org/show_bug.cgi?id=62438
+
+* UIProcess/efl/TextCheckerEfl.cpp: Added.
+(WebKit::TextChecker::state):
+(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
+(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
+(WebKit::TextChecker::setGrammarCheckingEnabled):
+(WebKit::TextChecker::uniqueSpellDocumentTag):
+(WebKit::TextChecker::closeSpellDocumentWithTag):
+(WebKit::TextChecker::checkSpellingOfString):
+(WebKit::TextChecker::checkGrammarOfString):
+(WebKit::TextChecker::spellingUIIsShowing):
+(WebKit::TextChecker::toggleSpellingUIIsShowing):
+(WebKit::TextChecker::updateSpellingUIWithMisspelledWord):
+(WebKit::TextChecker::updateSpellingUIWithGrammarString):
+(WebKit::TextChecker::getGuessesForWord):
+(WebKit::TextChecker::learnWord):
+(WebKit::TextChecker::ignoreWord):
+
 2011-06-13  Sangyong Park  
 
 Reviewed by Eric Seidel.


Added: trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp (0 => 88706)

--- trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/efl/TextCheckerEfl.cpp	2011-06-13 22:14:48 UTC (rev 88706)
@@ -0,0 +1,117 @@
+/*
+ * Copyright (C) 2011 Samsung Electronics
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "TextChecker.h"
+
+#include "TextCheckerState.h"
+#include 
+
+using namespace WebCore;
+
+namespace WebKit {
+
+static TextCheckerState textCheckerState;
+
+const TextCheckerState& TextChecker::state()
+{
+notImplemented();
+return textCheckerState;
+}
+
+bool TextChecker::isContinuousSpellCheckingAllowed()
+{
+notImplemented();
+return false;
+}
+
+void TextChecker::setContinuousSpellCheckingEnabled(bool)
+{
+notImplemented();
+}
+
+void TextChecker::setGrammarCheckingEnabled(bool)
+{
+notImplemented();
+}
+
+int64_t TextChecker::uniqueSpellDocumentTag(WebPageProxy*)
+{
+n

[webkit-changes] [88705] trunk/Source/WebCore

[caseq]

Title: [88705] trunk/Source/WebCore








Revision 88705
Author ca...@chromium.org
Date 2011-06-13 15:09:46 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Andrey Kosyakov  

Reviewed by Eric Seidel.

Web Inspector: [refactoring] remove dead code from NetworkPanel
https://bugs.webkit.org/show_bug.cgi?id=62481

* inspector/front-end/NetworkPanel.js:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/NetworkPanel.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (88704 => 88705)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:06:18 UTC (rev 88704)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 22:09:46 UTC (rev 88705)
@@ -1,3 +1,12 @@
+2011-06-13  Andrey Kosyakov  
+
+Reviewed by Eric Seidel.
+
+Web Inspector: [refactoring] remove dead code from NetworkPanel
+https://bugs.webkit.org/show_bug.cgi?id=62481
+
+* inspector/front-end/NetworkPanel.js:
+
 2011-06-13  Daniel Cheng  
 
 Reviewed by Eric Seidel.


Modified: trunk/Source/WebCore/inspector/front-end/NetworkPanel.js (88704 => 88705)

--- trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-06-13 22:06:18 UTC (rev 88704)
+++ trunk/Source/WebCore/inspector/front-end/NetworkPanel.js	2011-06-13 22:09:46 UTC (rev 88705)
@@ -108,11 +108,6 @@
 return [this._largerResourcesButton.element, this._preserveLogToggle.element, this._clearButton.element, this._filterBarElement];
 },
 
-isCategoryVisible: function(categoryName)
-{
-return true;
-},
-
 elementsToRestoreScrollPositionsFor: function()
 {
 return [this.containerElement, this._dataGrid.scrollContainer];
@@ -648,30 +643,6 @@
 this._popoverHelper.hidePopup();
 },
 
-get searchableViews()
-{
-var views = [];
-return views;
-},
-
-searchMatchFound: function(view, matches)
-{
-this._resourceGridNode(view.resource).searchMatches = matches;
-},
-
-searchCanceled: function(startingNewSearch)
-{
-WebInspector.Panel.prototype.searchCanceled.call(this, startingNewSearch);
-
-if (startingNewSearch || !this._resources)
-return;
-},
-
-performSearch: function(query)
-{
-WebInspector.Panel.prototype.performSearch.call(this, query);
-},
-
 refresh: function()
 {
 this._needsRefresh = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88704] trunk/Source/WebCore

[dcheng]

Title: [88704] trunk/Source/WebCore








Revision 88704
Author dch...@chromium.org
Date 2011-06-13 15:06:18 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Daniel Cheng  

Reviewed by Eric Seidel.

[chromium] Dragging images to Mail.app results in broken attachments
https://bugs.webkit.org/show_bug.cgi?id=62466

No new tests.

* platform/chromium/ClipboardChromium.cpp:
(WebCore::ClipboardChromium::declareAndWriteDragImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88703 => 88704)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 22:00:13 UTC (rev 88703)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 22:06:18 UTC (rev 88704)
@@ -1,3 +1,15 @@
+2011-06-13  Daniel Cheng  
+
+Reviewed by Eric Seidel.
+
+[chromium] Dragging images to Mail.app results in broken attachments
+https://bugs.webkit.org/show_bug.cgi?id=62466
+
+No new tests.
+
+* platform/chromium/ClipboardChromium.cpp:
+(WebCore::ClipboardChromium::declareAndWriteDragImage):
+
 2011-06-13  Adrienne Walker  
 
 Reviewed by Simon Fraser.


Modified: trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp (88703 => 88704)

--- trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp	2011-06-13 22:00:13 UTC (rev 88703)
+++ trunk/Source/WebCore/platform/chromium/ClipboardChromium.cpp	2011-06-13 22:06:18 UTC (rev 88704)
@@ -264,8 +264,11 @@
 if (fullURL.isEmpty())
 return;
 
-// Put img tag on the clipboard referencing the image
+#if !defined(OS_MACOSX)
+// Put img tag on the clipboard referencing the image. We don't do this on Mac to match Safari
+// behavior and to ensure that an image dragged to Mail.app is properly attached.
 m_dataObject->setData(mimeTypeTextHTML, imageToMarkup(fullURL, element));
+#endif
 }
 
 void ClipboardChromium::writeURL(const KURL& url, const String& title, Frame*)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88703] trunk/Source/WebKit/chromium

[commit-queue]

Title: [88703] trunk/Source/WebKit/chromium








Revision 88703
Author commit-qu...@webkit.org
Date 2011-06-13 15:00:13 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Dominic Mazzoni  

Reviewed by Dimitri Glazkov.

Add accessors for selectionStart and selectionEnd.
https://bugs.webkit.org/show_bug.cgi?id=62596

* public/WebAccessibilityObject.h:
* src/WebAccessibilityObject.cpp:
(WebKit::WebAccessibilityObject::selectionEnd):
(WebKit::WebAccessibilityObject::selectionStart):

Modified Paths

trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/public/WebAccessibilityObject.h
trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp




Diff

Modified: trunk/Source/WebKit/chromium/ChangeLog (88702 => 88703)

--- trunk/Source/WebKit/chromium/ChangeLog	2011-06-13 21:58:20 UTC (rev 88702)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-06-13 22:00:13 UTC (rev 88703)
@@ -1,3 +1,15 @@
+2011-06-13  Dominic Mazzoni  
+
+Reviewed by Dimitri Glazkov.
+
+Add accessors for selectionStart and selectionEnd.
+https://bugs.webkit.org/show_bug.cgi?id=62596
+
+* public/WebAccessibilityObject.h:
+* src/WebAccessibilityObject.cpp:
+(WebKit::WebAccessibilityObject::selectionEnd):
+(WebKit::WebAccessibilityObject::selectionStart):
+
 2011-06-13  Adam Barth  
 
 Reviewed by Nate Chapin.


Modified: trunk/Source/WebKit/chromium/public/WebAccessibilityObject.h (88702 => 88703)

--- trunk/Source/WebKit/chromium/public/WebAccessibilityObject.h	2011-06-13 21:58:20 UTC (rev 88702)
+++ trunk/Source/WebKit/chromium/public/WebAccessibilityObject.h	2011-06-13 22:00:13 UTC (rev 88703)
@@ -110,6 +110,8 @@
 WEBKIT_API WebString keyboardShortcut() const;
 WEBKIT_API bool performDefaultAction() const;
 WEBKIT_API WebAccessibilityRole roleValue() const;
+WEBKIT_API unsigned selectionEnd() const;
+WEBKIT_API unsigned selectionStart() const;
 WEBKIT_API void setFocused(bool) const;
 WEBKIT_API WebString stringValue() const;
 WEBKIT_API WebString title() const;


Modified: trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp (88702 => 88703)

--- trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp	2011-06-13 21:58:20 UTC (rev 88702)
+++ trunk/Source/WebKit/chromium/src/WebAccessibilityObject.cpp	2011-06-13 22:00:13 UTC (rev 88703)
@@ -446,6 +446,24 @@
 return static_cast(m_private->roleValue());
 }
 
+unsigned WebAccessibilityObject::selectionEnd() const
+{
+if (!m_private)
+return 0;
+
+m_private->updateBackingStore();
+return m_private->selectedTextRange().start + m_private->selectedTextRange().length;
+}
+
+unsigned WebAccessibilityObject::selectionStart() const
+{
+if (!m_private)
+return 0;
+
+m_private->updateBackingStore();
+return m_private->selectedTextRange().start;
+}
+
 void WebAccessibilityObject::setFocused(bool on) const
 {
 if (m_private)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88702] trunk/Source/WebKit2

[commit-queue]

Title: [88702] trunk/Source/WebKit2








Revision 88702
Author commit-qu...@webkit.org
Date 2011-06-13 14:58:20 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Sangyong Park  

Reviewed by Eric Seidel.

implement to handle wheel event of plugin on x11
https://bugs.webkit.org/show_bug.cgi?id=62522

Implement platformHandleWheelEvent() in NetscapePluginX11.cpp
for to handle wheel event on plugins

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::setCommonMouseEventFields): add template argument to support WebWheelEvent
(WebKit::setXButtonEventFieldsByWebWheelEvent): initialize XButtonEvent by WebWheelEvent
(WebKit::NetscapePlugin::platformHandleWheelEvent): handle wheel event on plugin

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88701 => 88702)

--- trunk/Source/WebKit2/ChangeLog	2011-06-13 21:51:43 UTC (rev 88701)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-13 21:58:20 UTC (rev 88702)
@@ -1,3 +1,18 @@
+2011-06-13  Sangyong Park  
+
+Reviewed by Eric Seidel.
+
+implement to handle wheel event of plugin on x11
+https://bugs.webkit.org/show_bug.cgi?id=62522
+
+Implement platformHandleWheelEvent() in NetscapePluginX11.cpp
+for to handle wheel event on plugins
+
+* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
+(WebKit::setCommonMouseEventFields): add template argument to support WebWheelEvent
+(WebKit::setXButtonEventFieldsByWebWheelEvent): initialize XButtonEvent by WebWheelEvent
+(WebKit::NetscapePlugin::platformHandleWheelEvent): handle wheel event on plugin
+
 2011-06-13  Eunmi Lee  
 
 Reviewed by Eric Seidel.


Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp (88701 => 88702)

--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2011-06-13 21:51:43 UTC (rev 88701)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp	2011-06-13 21:58:20 UTC (rev 88702)
@@ -326,8 +326,8 @@
 return xModifiers;
 }
 
-template 
-static inline void setCommonMouseEventFields(XEventType& xEvent, const WebMouseEvent& webEvent, const WebCore::IntPoint& pluginLocation)
+template 
+static inline void setCommonMouseEventFields(XEventType& xEvent, const WebEventType& webEvent, const WebCore::IntPoint& pluginLocation)
 {
 xEvent.root = rootWindowID();
 xEvent.subwindow = 0;
@@ -366,6 +366,26 @@
 }
 }
 
+static inline void setXButtonEventFieldsByWebWheelEvent(XEvent& xEvent, const WebWheelEvent& webEvent, const WebCore::IntPoint& pluginLocation)
+{
+XButtonEvent& xButton = xEvent.xbutton;
+setCommonMouseEventFields(xButton, webEvent, pluginLocation);
+
+xButton.type = ButtonPress;
+FloatSize ticks = webEvent.wheelTicks();
+if (ticks.height()) {
+if (ticks.height() > 0)
+xButton.button = 4; // up
+else
+xButton.button = 5; // down
+} else {
+if (ticks.width() > 0)
+xButton.button = 6; // left
+else
+xButton.button = 7; // right
+}
+}
+
 static inline void setXCrossingEventFields(XEvent& xEvent, const WebMouseEvent& webEvent, const WebCore::IntPoint& pluginLocation, int type)
 {
 XCrossingEvent& xCrossing = xEvent.xcrossing;
@@ -405,10 +425,16 @@
 const int kFocusInType = 9;
 const int kFocusOutType = 10;
 
-bool NetscapePlugin::platformHandleWheelEvent(const WebWheelEvent&)
+bool NetscapePlugin::platformHandleWheelEvent(const WebWheelEvent& event)
 {
-notImplemented();
-return false;
+if (m_isWindowed)
+return false;
+
+XEvent xEvent;
+initializeXEvent(xEvent);
+setXButtonEventFieldsByWebWheelEvent(xEvent, event, m_frameRect.location());
+
+return NPP_HandleEvent(&xEvent);
 }
 
 void NetscapePlugin::platformSetFocus(bool)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88701] trunk/Source/WebKit2

[commit-queue]

Title: [88701] trunk/Source/WebKit2








Revision 88701
Author commit-qu...@webkit.org
Date 2011-06-13 14:51:43 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Eunmi Lee  

Reviewed by Eric Seidel.

[EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
https://bugs.webkit.org/show_bug.cgi?id=62523

* UIProcess/efl/WebContextEfl.cpp: Added.
(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformInitializeWebProcess):
(WebKit::WebContext::platformInvalidateContext):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultIconDatabasePath):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Modified Paths

trunk/Source/WebKit2/ChangeLog


Added Paths

trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88700 => 88701)

--- trunk/Source/WebKit2/ChangeLog	2011-06-13 21:44:48 UTC (rev 88700)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-13 21:51:43 UTC (rev 88701)
@@ -1,3 +1,18 @@
+2011-06-13  Eunmi Lee  
+
+Reviewed by Eric Seidel.
+
+[EFL][WK2] Add initial WebContextEfl.cpp for webkit2 efl port
+https://bugs.webkit.org/show_bug.cgi?id=62523
+
+* UIProcess/efl/WebContextEfl.cpp: Added.
+(WebKit::WebContext::applicationCacheDirectory):
+(WebKit::WebContext::platformInitializeWebProcess):
+(WebKit::WebContext::platformInvalidateContext):
+(WebKit::WebContext::platformDefaultDatabaseDirectory):
+(WebKit::WebContext::platformDefaultIconDatabasePath):
+(WebKit::WebContext::platformDefaultLocalStorageDirectory):
+
 2011-06-13  Noam Rosenthal  
 
 Unreviewed fix - removed parts of r88659 that were committed by mistake.


Added: trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp (0 => 88701)

--- trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp	(rev 0)
+++ trunk/Source/WebKit2/UIProcess/efl/WebContextEfl.cpp	2011-06-13 21:51:43 UTC (rev 88701)
@@ -0,0 +1,67 @@
+/*
+ * Copyright (C) 2011 Samsung Electronics
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *notice, this list of conditions and the following disclaimer in the
+ *documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS AS IS''
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
+ * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
+ * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
+ * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
+ * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
+ * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
+ * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
+ * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
+ * THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "WebContext.h"
+
+#include 
+#include 
+
+namespace WebKit {
+
+String WebContext::applicationCacheDirectory()
+{
+return WebCore::cacheStorage().cacheDirectory();
+}
+
+void WebContext::platformInitializeWebProcess(WebProcessCreationParameters&)
+{
+notImplemented();
+}
+
+void WebContext::platformInvalidateContext()
+{
+notImplemented();
+}
+
+String WebContext::platformDefaultDatabaseDirectory() const
+{
+notImplemented();
+return "";
+}
+
+String WebContext::platformDefaultIconDatabasePath() const
+{
+notImplemented();
+return "";
+}
+
+String WebContext::platformDefaultLocalStorageDirectory() const
+{
+notImplemented();
+return "";
+}
+
+} // namespace WebKit






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88700] trunk/Source/WebKit/efl

[commit-queue]

Title: [88700] trunk/Source/WebKit/efl








Revision 88700
Author commit-qu...@webkit.org
Date 2011-06-13 14:44:48 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Raphael Kubo da Costa  

Reviewed by Kenneth Rohde Christiansen.

[efl] Disable tiled backing store debug messages by default.
https://bugs.webkit.org/show_bug.cgi?id=61745

These messages pollute the output and are only useful to people
working on TBS itself. It makes more sense to have them disabled by
default.

* ewk/ewk_tiled_backing_store.h:

Modified Paths

trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h




Diff

Modified: trunk/Source/WebKit/efl/ChangeLog (88699 => 88700)

--- trunk/Source/WebKit/efl/ChangeLog	2011-06-13 21:36:59 UTC (rev 88699)
+++ trunk/Source/WebKit/efl/ChangeLog	2011-06-13 21:44:48 UTC (rev 88700)
@@ -1,3 +1,16 @@
+2011-06-13  Raphael Kubo da Costa  
+
+Reviewed by Kenneth Rohde Christiansen.
+
+[efl] Disable tiled backing store debug messages by default.
+https://bugs.webkit.org/show_bug.cgi?id=61745
+
+These messages pollute the output and are only useful to people
+working on TBS itself. It makes more sense to have them disabled by
+default.
+
+* ewk/ewk_tiled_backing_store.h:
+
 2011-06-13  KwangHyuk Kim  
 
 Reviewed by Kenneth Rohde Christiansen.


Modified: trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h (88699 => 88700)

--- trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h	2011-06-13 21:36:59 UTC (rev 88699)
+++ trunk/Source/WebKit/efl/ewk/ewk_tiled_backing_store.h	2011-06-13 21:44:48 UTC (rev 88700)
@@ -31,7 +31,7 @@
  * try "kill -USR1 $PID" to get instantaneous debug
  * try "kill -USR2 $PID" to get instantaneous debug and force flush of cache
  */
-#define DEBUG_MEM_LEAKS 1
+#undef DEBUG_MEM_LEAKS
 
 #define TILE_W (256)
 #define TILE_H (256)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88698] trunk

[enne]

Title: [88698] trunk








Revision 88698
Author e...@google.com
Date 2011-06-13 14:33:13 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Adrienne Walker  

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

* compositing/layer-creation/overlap-child-layer-expected.png: Added.
* compositing/layer-creation/overlap-child-layer-expected.txt: Added.
* compositing/layer-creation/overlap-child-layer.html: Added.
2011-06-13  Adrienne Walker  

Reviewed by Simon Fraser.

Overlap test needs to consider children of composited layers
https://bugs.webkit.org/show_bug.cgi?id=62465

Any child layer with a compositing ancestor will be put into a
composited layer even though they themselves don't need compositing.
As layer bounds aren't hierarchical, these layer bounds themselves
need to be put into the overlap map because the composited layer
itself is not sufficient.

Test: compositing/layer-creation/overlap-animated-layer.html

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp


Added Paths

trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.png
trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt
trunk/LayoutTests/compositing/layer-creation/overlap-child-layer.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88697 => 88698)

--- trunk/LayoutTests/ChangeLog	2011-06-13 21:29:25 UTC (rev 88697)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 21:33:13 UTC (rev 88698)
@@ -1,3 +1,14 @@
+2011-06-13  Adrienne Walker  
+
+Reviewed by Simon Fraser.
+
+Overlap test needs to consider children of composited layers
+https://bugs.webkit.org/show_bug.cgi?id=62465
+
+* compositing/layer-creation/overlap-child-layer-expected.png: Added.
+* compositing/layer-creation/overlap-child-layer-expected.txt: Added.
+* compositing/layer-creation/overlap-child-layer.html: Added.
+
 2011-06-13  Dimitri Glazkov  
 
 [Chromium] Correctly classify the test as failing.


Added: trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.png

(Binary files differ)

Property changes on: trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.png
___

Added: svn:mime-type

Added: trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt (0 => 88698)

--- trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt	(rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt	2011-06-13 21:33:13 UTC (rev 88698)
@@ -0,0 +1,20 @@
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (children 2
+(GraphicsLayer
+  (anchor 1.56 0.00)
+  (bounds 256.00 256.00)
+  (drawsContent 1)
+)
+(GraphicsLayer
+  (bounds 300.00 300.00)
+  (drawsContent 1)
+)
+  )
+)
+  )
+)
+
Property changes on: trunk/LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/compositing/layer-creation/overlap-child-layer.html (0 => 88698)

--- trunk/LayoutTests/compositing/layer-creation/overlap-child-layer.html	(rev 0)
+++ trunk/LayoutTests/compositing/layer-creation/overlap-child-layer.html	2011-06-13 21:33:13 UTC (rev 88698)
@@ -0,0 +1,67 @@
+
+
+
+#container {
+position: absolute;
+top: 0px;
+left: 400px;
+-webkit-transform: translateZ(0);
+}
+
+#red {
+position: absolute;
+top: 0px;
+left: -400px;
+height: 256px;
+width: 256px;
+background-color: red;
+}
+
+#green {
+position: absolute;
+left: 0px;
+top: 0px;
+width: 300px;
+height: 300px;
+background-color: green;
+}
+
+#layertree {
+position: absolute;
+left: 1px;
+top: 0px;
+}
+
+body {
+overflow: hidden;
+}
+
+
+
+
+if (window.layoutTestController) {
+layoutTestController.dumpAsText(true);
+layoutTestController.waitUntilDone();
+}
+
+window.addEventListener('load', function() {
+if (window.layoutTestController) {
+document.getElementById("layertree").innerText = layoutTestController.layerTreeAsText();
+layoutTestController.notifyDone();
+}
+}, false);
+
+
+
+
+
+
+

[webkit-changes] [88697] trunk/LayoutTests

[dglazkov]

Title: [88697] trunk/LayoutTests








Revision 88697
Author dglaz...@chromium.org
Date 2011-06-13 14:29:25 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Dimitri Glazkov  

[Chromium] Correctly classify the test as failing.

* platform/chromium/test_expectations.txt: It's failing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88696 => 88697)

--- trunk/LayoutTests/ChangeLog	2011-06-13 21:23:29 UTC (rev 88696)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 21:29:25 UTC (rev 88697)
@@ -1,5 +1,11 @@
 2011-06-13  Dimitri Glazkov  
 
+[Chromium] Correctly classify the test as failing.
+
+* platform/chromium/test_expectations.txt: It's failing.
+
+2011-06-13  Dimitri Glazkov  
+
 [Chromium] Record more flakiness...
 
 * platform/chromium/test_expectations.txt: Added expectation of flakiness.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88696 => 88697)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 21:23:29 UTC (rev 88696)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 21:29:25 UTC (rev 88697)
@@ -771,7 +771,7 @@
 // WIN started failing during webkit roll 62670 -> 62844.
 BUGCR38353 MAC LINUX: plugins/keyboard-events.html = TEXT
 BUGCR10351 MAC : plugins/mouse-events.html = FAIL
-BUGCR32864 MAC LINUX : plugins/mouse-events-fixedpos.html = TEXT
+BUGCR32864 : plugins/mouse-events-fixedpos.html = TEXT
 BUGCR35822 : plugins/npruntime/browser-object-identity.html = TEXT
 // Object.keys on an NPObject produces the wrong output.
 BUGCR21901 : plugins/npruntime/enumerate.html = TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88696] trunk/Source/WebCore

[xan]

Title: [88696] trunk/Source/WebCore








Revision 88696
Author x...@webkit.org
Date 2011-06-13 14:23:29 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Xan Lopez  

Unreviewed build fix.

Touch this to try to fix the build...

* platform/gtk/WidgetGtk.cpp:
(WebCore::Widget::~Widget):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88695 => 88696)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 21:22:05 UTC (rev 88695)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 21:23:29 UTC (rev 88696)
@@ -1,5 +1,14 @@
 2011-06-13  Xan Lopez  
 
+Unreviewed build fix.
+
+Touch this to try to fix the build...
+
+* platform/gtk/WidgetGtk.cpp:
+(WebCore::Widget::~Widget):
+
+2011-06-13  Xan Lopez  
+
 Try to fix GTK+ build.
 
 * GNUmakefile.list.am: remove CredentialStorage.cpp


Modified: trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp (88695 => 88696)

--- trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp	2011-06-13 21:22:05 UTC (rev 88695)
+++ trunk/Source/WebCore/platform/gtk/WidgetGtk.cpp	2011-06-13 21:23:29 UTC (rev 88696)
@@ -52,6 +52,7 @@
 Widget::~Widget()
 {
 ASSERT(!parent());
+
 releasePlatformWidget();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88695] trunk/LayoutTests

[dglazkov]

Title: [88695] trunk/LayoutTests








Revision 88695
Author dglaz...@chromium.org
Date 2011-06-13 14:22:05 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Dimitri Glazkov  

[Chromium] Record more flakiness...

* platform/chromium/test_expectations.txt: Added expectation of flakiness.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88694 => 88695)

--- trunk/LayoutTests/ChangeLog	2011-06-13 21:20:00 UTC (rev 88694)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 21:22:05 UTC (rev 88695)
@@ -1,3 +1,9 @@
+2011-06-13  Dimitri Glazkov  
+
+[Chromium] Record more flakiness...
+
+* platform/chromium/test_expectations.txt: Added expectation of flakiness.
+
 2011-06-13  Jessie Berlin  
 
 [Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88694 => 88695)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 21:20:00 UTC (rev 88694)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 21:22:05 UTC (rev 88695)
@@ -2498,7 +2498,7 @@
 
 // See also https://webkit.org/b/49045
 BUGCR61978 : svg/animations/animate-path-nested-transforms.html = CRASH PASS TEXT
-BUGCR61978 : svg/animations/animate-text-nested-transforms.html = PASS TEXT
+BUGCR61978 : svg/animations/animate-text-nested-transforms.html = CRASH PASS TEXT
 
 // New test; was added in http://trac.webkit.org/changeset/68520
 WONTFIX SKIP WIN BUGWK46735 : platform/win/plugins/window-geometry-initialized-before-set-window.html = TEXT CRASH






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88694] trunk/LayoutTests

[jberlin]

Title: [88694] trunk/LayoutTests








Revision 88694
Author jber...@webkit.org
Date 2011-06-13 14:20:00 -0700 (Mon, 13 Jun 2011)


Log Message
[Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu
items.
https://bugs.webkit.org/show_bug.cgi?id=62597

Add editing/pasteboard/copy-standalone-image-crash.htm to the Windows skipped list, since
it depends on getting a list of the context menu items.

* platform/win/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (88693 => 88694)

--- trunk/LayoutTests/ChangeLog	2011-06-13 21:14:49 UTC (rev 88693)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 21:20:00 UTC (rev 88694)
@@ -1,3 +1,14 @@
+2011-06-13  Jessie Berlin  
+
+[Windows Tests] EventSender.contextClick() needs to return a JS array of the context menu
+items.
+https://bugs.webkit.org/show_bug.cgi?id=62597
+
+Add editing/pasteboard/copy-standalone-image-crash.htm to the Windows skipped list, since
+it depends on getting a list of the context menu items.
+
+* platform/win/Skipped:
+
 2011-06-13  Ryosuke Niwa  
 
 Windows rebaseline after r62565. The failure is tracked by the bug 62565.


Modified: trunk/LayoutTests/platform/win/Skipped (88693 => 88694)

--- trunk/LayoutTests/platform/win/Skipped	2011-06-13 21:14:49 UTC (rev 88693)
+++ trunk/LayoutTests/platform/win/Skipped	2011-06-13 21:20:00 UTC (rev 88694)
@@ -975,6 +975,10 @@
 # https://bugs.webkit.org/show_bug.cgi?id=39104
 editing/spelling/context-menu-suggestions.html
 
+# eventSender.contextClick() needs to return a JS array of the context menu items.
+# https://bugs.webkit.org/show_bug.cgi?id=62597
+editing/pasteboard/copy-standalone-image-crash.html
+
 # https://webkit.org/b/32021 - DRT's textInputController is unimplemented on Windows
 editing/input/ime-composition-clearpreedit.html
 editing/input/setting-input-value-cancel-ime-composition.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88693] trunk/Source/WebCore

[xan]

Title: [88693] trunk/Source/WebCore








Revision 88693
Author x...@webkit.org
Date 2011-06-13 14:14:49 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Xan Lopez  

Try to fix GTK+ build.

* GNUmakefile.list.am: remove CredentialStorage.cpp

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (88692 => 88693)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 21:10:35 UTC (rev 88692)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 21:14:49 UTC (rev 88693)
@@ -1,3 +1,9 @@
+2011-06-13  Xan Lopez  
+
+Try to fix GTK+ build.
+
+* GNUmakefile.list.am: remove CredentialStorage.cpp
+
 2011-06-13  Stephen White  
 
 Reviewed by James Robinson.


Modified: trunk/Source/WebCore/GNUmakefile.list.am (88692 => 88693)

--- trunk/Source/WebCore/GNUmakefile.list.am	2011-06-13 21:10:35 UTC (rev 88692)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2011-06-13 21:14:49 UTC (rev 88693)
@@ -2593,7 +2593,6 @@
 	Source/WebCore/platform/network/CookieStorage.h \
 	Source/WebCore/platform/network/Credential.cpp \
 	Source/WebCore/platform/network/Credential.h \
-	Source/WebCore/platform/network/CredentialStorage.cpp \
 	Source/WebCore/platform/network/CredentialStorage.h \
 	Source/WebCore/platform/network/DNS.h \
 	Source/WebCore/platform/network/FormDataBuilder.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88692] trunk/Source/WebCore

[senorblanco]

Title: [88692] trunk/Source/WebCore








Revision 88692
Author senorbla...@chromium.org
Date 2011-06-13 14:10:35 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Stephen White  

Reviewed by James Robinson.

Improve GPU canvas startup time on the SkiaGPU path.
https://bugs.webkit.org/show_bug.cgi?id=62594

Fixed by skipping creation of shaders used only by the legacy path.

Covered by existing canvas tests.

* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3D::create):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88691 => 88692)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 21:08:34 UTC (rev 88691)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 21:10:35 UTC (rev 88692)
@@ -1,3 +1,17 @@
+2011-06-13  Stephen White  
+
+Reviewed by James Robinson.
+
+Improve GPU canvas startup time on the SkiaGPU path.
+https://bugs.webkit.org/show_bug.cgi?id=62594
+
+Fixed by skipping creation of shaders used only by the legacy path.
+
+Covered by existing canvas tests.
+
+* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
+(WebCore::SharedGraphicsContext3D::create):
+
 2011-06-13  Michael Saboff  
 
 Reviewed by Oliver Hunt.


Modified: trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp (88691 => 88692)

--- trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp	2011-06-13 21:08:34 UTC (rev 88691)
+++ trunk/Source/WebCore/platform/graphics/gpu/SharedGraphicsContext3D.cpp	2011-06-13 21:10:35 UTC (rev 88692)
@@ -71,6 +71,8 @@
 RefPtr context = GraphicsContext3D::create(attr, hostWindow);
 if (!context)
 return 0;
+if (flags & UseSkiaGPU)
+return adoptRef(new SharedGraphicsContext3D(context.release(), PassOwnPtr(), PassOwnPtr(), PassOwnPtr(), PassOwnArrayPtr >(), flags));
 OwnPtr solidFillShader = SolidFillShader::create(context.get());
 if (!solidFillShader)
 return 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88691] trunk/Source/WebCore

[msaboff]

Title: [88691] trunk/Source/WebCore








Revision 88691
Author msab...@apple.com
Date 2011-06-13 14:08:34 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Michael Saboff  

Reviewed by Oliver Hunt.

Additional FontCache::FontCachePurgePreventer instances needed
https://bugs.webkit.org/show_bug.cgi?id=62498

Added some needed and speculative FontCachePurgePreventer objects.
Built and ran Safari with debug version of webkit that purges all
purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
to find system fallback fonts access via code paths that aren't
protected with FontCachePurgePreventer objects.  Also examined
platform specific code that calls either Font::drawText() or
Canvas::drawText().  For those methods that may be called from currently
unprotected paths, added FontCachePurgePreventer objects.

No new functionality so no new tests.

* inspector/DOMNodeHighlighter.cpp:
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::drawHudContents):
* platform/mac/DragImageMac.mm:
(WebCore::widthWithFont):
(WebCore::drawAtPoint):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp
trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp
trunk/Source/WebCore/platform/mac/DragImageMac.mm
trunk/Source/WebCore/rendering/RenderMenuList.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88690 => 88691)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 20:59:26 UTC (rev 88690)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 21:08:34 UTC (rev 88691)
@@ -1,3 +1,32 @@
+2011-06-13  Michael Saboff  
+
+Reviewed by Oliver Hunt.
+
+Additional FontCache::FontCachePurgePreventer instances needed
+https://bugs.webkit.org/show_bug.cgi?id=62498
+
+Added some needed and speculative FontCachePurgePreventer objects.
+Built and ran Safari with debug version of webkit that purges all
+purgeable fonts in FontCache::purgeInactiveFontDataIfNeeded in order
+to find system fallback fonts access via code paths that aren't
+protected with FontCachePurgePreventer objects.  Also examined
+platform specific code that calls either Font::drawText() or
+Canvas::drawText().  For those methods that may be called from currently
+unprotected paths, added FontCachePurgePreventer objects.
+
+No new functionality so no new tests.
+
+* inspector/DOMNodeHighlighter.cpp:
+* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
+(PlatformCALayerWinInternal::displayCallback):
+* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
+(WebCore::CCHeadsUpDisplay::drawHudContents):
+* platform/mac/DragImageMac.mm:
+(WebCore::widthWithFont):
+(WebCore::drawAtPoint):
+* rendering/RenderMenuList.cpp:
+(WebCore::RenderMenuList::updateOptionsWidth):
+
 2011-06-13  Ryosuke Niwa  
 
 Reviewed by Dan Bernstein.


Modified: trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp (88690 => 88691)

--- trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-06-13 20:59:26 UTC (rev 88690)
+++ trunk/Source/WebCore/inspector/DOMNodeHighlighter.cpp	2011-06-13 21:08:34 UTC (rev 88691)
@@ -32,6 +32,7 @@
 #if ENABLE(INSPECTOR)
 
 #include "Element.h"
+#include "FontCache.h"
 #include "Frame.h"
 #include "FrameView.h"
 #include "GraphicsContext.h"
@@ -139,6 +140,7 @@
 static const Color tooltipBackgroundColor(255, 255, 194, 255);
 static const Color tooltipBorderColor(Color::black);
 static const Color tooltipFontColor(Color::black);
+FontCachePurgePreventer fontCachePurgePreventer;
 
 Element* element = static_cast(node);
 bool isXHTML = element->document()->isXHTMLDocument();


Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp (88690 => 88691)

--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp	2011-06-13 20:59:26 UTC (rev 88690)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCALayerWinInternal.cpp	2011-06-13 21:08:34 UTC (rev 88691)
@@ -30,6 +30,7 @@
 #include "PlatformCALayerWinInternal.h"
 
 #include "Font.h"
+#include "FontCache.h"
 #include "PlatformCALayer.h"
 #include "TextRun.h"
 #include 
@@ -93,6 +94,8 @@
 #endif
 
 if (owner()->owner()->platformCALayerShowRepaintCounter()) {
+FontCachePurgePreventer fontCachePurgePreventer;
+
 String text = String::number(owner()->owner()->platformCALayerIncrementRepaintCount());
 
   

[webkit-changes] [88690] trunk/LayoutTests

[rniwa]

Title: [88690] trunk/LayoutTests








Revision 88690
Author rn...@webkit.org
Date 2011-06-13 13:59:26 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Windows rebaseline after r62565. The failure is tracked by the bug 62565.

* platform/win/fast/harness/results-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/fast/harness/results-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88689 => 88690)

--- trunk/LayoutTests/ChangeLog	2011-06-13 20:58:02 UTC (rev 88689)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 20:59:26 UTC (rev 88690)
@@ -1,3 +1,9 @@
+2011-06-13  Ryosuke Niwa  
+
+Windows rebaseline after r62565. The failure is tracked by the bug 62565.
+
+* platform/win/fast/harness/results-expected.txt:
+
 2011-06-13  David Levin  
 
 Test fix for Windows.


Modified: trunk/LayoutTests/platform/win/fast/harness/results-expected.txt (88689 => 88690)

--- trunk/LayoutTests/platform/win/fast/harness/results-expected.txt	2011-06-13 20:58:02 UTC (rev 88689)
+++ trunk/LayoutTests/platform/win/fast/harness/results-expected.txt	2011-06-13 20:59:26 UTC (rev 88690)
@@ -126,21 +126,21 @@
 TEST-29: PASS
 TEST-29: PASS
 TEST-30: PASS
+TEST-30: FAIL
+TEST-30: FAIL
+TEST-30: FAIL
+TEST-30: FAIL
 TEST-30: PASS
+TEST-30: FAIL
 TEST-30: PASS
 TEST-30: PASS
 TEST-30: PASS
 TEST-30: PASS
+TEST-30: FAIL
+TEST-30: FAIL
+TEST-30: FAIL
+TEST-30: FAIL
 TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
-TEST-30: PASS
 TEST-31: PASS
 TEST-31: PASS
 TEST-31: PASS






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88689] trunk/Source/WebKit2

[noam . rosenthal]

Title: [88689] trunk/Source/WebKit2








Revision 88689
Author noam.rosent...@nokia.com
Date 2011-06-13 13:58:02 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Noam Rosenthal  

Unreviewed fix - removed parts of r88659 that were committed by mistake.

The patch accidentally included parts that weren't supposed to be there, namely the whole
code was duplicated. This patch rectifies that and brings it to the original reviewed code.

* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
* WebProcess/WebCoreSupport/WebGraphicsLayer.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88688 => 88689)

--- trunk/Source/WebKit2/ChangeLog	2011-06-13 20:56:20 UTC (rev 88688)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-13 20:58:02 UTC (rev 88689)
@@ -1,3 +1,13 @@
+2011-06-13  Noam Rosenthal  
+
+Unreviewed fix - removed parts of r88659 that were committed by mistake.
+
+The patch accidentally included parts that weren't supposed to be there, namely the whole
+code was duplicated. This patch rectifies that and brings it to the original reviewed code.
+
+* WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:
+* WebProcess/WebCoreSupport/WebGraphicsLayer.h:
+
 2011-06-13  Anders Carlsson  
 
 Reviewed by Dan Bernstein.


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp (88688 => 88689)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp	2011-06-13 20:56:20 UTC (rev 88688)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp	2011-06-13 20:58:02 UTC (rev 88689)
@@ -511,515 +511,3 @@
 
 }
 #endif
-/*
- Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
-
- This library is free software; you can redistribute it and/or
- modify it under the terms of the GNU Library General Public
- License as published by the Free Software Foundation; either
- version 2 of the License, or (at your option) any later version.
-
- This library is distributed in the hope that it will be useful,
- but WITHOUT ANY WARRANTY; without even the implied warranty of
- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- Library General Public License for more details.
-
- You should have received a copy of the GNU Library General Public License
- along with this library; see the file COPYING.LIB.  If not, write to
- the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
- Boston, MA 02110-1301, USA.
- */
-
-#include "config.h"
-
-#if USE(ACCELERATED_COMPOSITING)
-
-#include "WebGraphicsLayer.h"
-
-#include "Animation.h"
-#include "BackingStore.h"
-#include "DrawingAreaMessages.h"
-#include "DrawingAreaProxyMessages.h"
-#include "Frame.h"
-#include "FrameView.h"
-#include "GraphicsContext.h"
-#include "GraphicsLayer.h"
-#include "Page.h"
-#include "WebPage.h"
-#include "text/CString.h"
-#include 
-#include 
-
-using namespace WebKit;
-
-namespace WebCore {
-
-static HashMap& layerByIDMap()
-{
-static HashMap globalMap;
-return globalMap;
-}
-
-static const float gTileDimension = 1024.0;
-
-WebGraphicsLayer* WebGraphicsLayer::layerByID(WebKit::WebLayerID id)
-{
-HashMap& table = layerByIDMap();
-HashMap::iterator it = table.find(id);
-if (it == table.end())
-return 0;
-return it->second;
-}
-
-static Vector& deletedLayerIDs()
-{
-static Vector layers;
-return layers;
-}
-
-static WebLayerID toWebLayerID(GraphicsLayer* layer)
-{
-return layer ? toWebGraphicsLayer(layer)->id() : 0;
-}
-
-void WebGraphicsLayer::notifyChange()
-{
-m_modified = true;
-if (client())
-client()->notifySyncRequired(this);
-}
-
-WebGraphicsLayer::WebGraphicsLayer(GraphicsLayerClient* client)
-: GraphicsLayer(client)
-, m_needsDisplay(false)
-, m_modified(false)
-, m_contentNeedsDisplay(false)
-, m_hasPendingAnimations(false)
-, m_contentScale(1.f)
-{
-static WebLayerID sID = 1000;
-m_layerInfo.id = ++sID;
-layerByIDMap().add(id(), this);
-}
-
-WebGraphicsLayer::~WebGraphicsLayer()
-{
-layerByIDMap().remove(id());
-deletedLayerIDs().append(id());
-}
-
-bool WebGraphicsLayer::setChildren(const Vector& children)
-{
-bool ok = GraphicsLayer::setChildren(children);
-if (ok)
-notifyChange();
-return ok;
-}
-
-void WebGraphicsLayer::addChild(GraphicsLayer* layer)
-{
-GraphicsLayer::addChild(layer);
-notifyChange();
-}
-
-void WebGraphicsLayer::addChildAtIndex(GraphicsLayer* layer, int index)
-{
-GraphicsLayer::addChildAtIndex(layer, index);
-notifyChange();
-}
-
-void WebGraphicsLayer::addChildAbove(GraphicsLayer* layer, GraphicsLayer* sibling)
-{
-GraphicsLayer::addChildAbove(layer, sibling);
-notifyChange();
-}
-
-void WebGraphicsLayer::addChildBelow(GraphicsLayer* l

[webkit-changes] [88688] trunk/LayoutTests

[levin]

Title: [88688] trunk/LayoutTests








Revision 88688
Author le...@chromium.org
Date 2011-06-13 13:56:20 -0700 (Mon, 13 Jun 2011)


Log Message
Test fix for Windows.

[Windows] Web Worker test causes script error on Windows platform alone.
https://bugs.webkit.org/show_bug.cgi?id=62595

* platform/win/Skipped: Skipped the test with the problem.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (88687 => 88688)

--- trunk/LayoutTests/ChangeLog	2011-06-13 20:52:02 UTC (rev 88687)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 20:56:20 UTC (rev 88688)
@@ -1,3 +1,12 @@
+2011-06-13  David Levin  
+
+Test fix for Windows.
+
+[Windows] Web Worker test causes script error on Windows platform alone.
+https://bugs.webkit.org/show_bug.cgi?id=62595
+
+* platform/win/Skipped: Skipped the test with the problem.
+
 2011-06-13  Jessie Berlin  
 
 plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.


Modified: trunk/LayoutTests/platform/win/Skipped (88687 => 88688)

--- trunk/LayoutTests/platform/win/Skipped	2011-06-13 20:52:02 UTC (rev 88687)
+++ trunk/LayoutTests/platform/win/Skipped	2011-06-13 20:56:20 UTC (rev 88688)
@@ -1328,3 +1328,6 @@
 http/tests/security/webgl-remote-read-remote-image-allowed.html
 http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
 http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
+
+# Causes a SyntaxError (http://webkit.org/b/62595).
+fast/workers/worker-crash-with-invalid-location.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88687] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

[mrobinson]

Title: [88687] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk








Revision 88687
Author mrobin...@webkit.org
Date 2011-06-13 13:52:02 -0700 (Mon, 13 Jun 2011)


Log Message
Merging r88683

Modified Paths

releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/GNUmakefile.am




Diff

Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog (88686 => 88687)

--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog	2011-06-13 20:49:39 UTC (rev 88686)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog	2011-06-13 20:52:02 UTC (rev 88687)
@@ -1,5 +1,14 @@
 2011-06-13  Martin Robinson  
 
+Reviewed by Xan Lopez.
+
+Update the list of ignored GTK+ header files for the documentation
+generation.
+
+* docs/GNUmakefile.am: Update ignored header list.
+
+2011-06-13  Martin Robinson  
+
 Reviewed by Gustavo Noronha Silva.
 
 [GTK] gtkdoc run produces many warnings about missing declarations


Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/GNUmakefile.am (88686 => 88687)

--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/GNUmakefile.am	2011-06-13 20:49:39 UTC (rev 88686)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/GNUmakefile.am	2011-06-13 20:52:02 UTC (rev 88687)
@@ -47,7 +47,28 @@
 
 # Header files to ignore when scanning.
 # e.g. IGNORE_HFILES=gtkdebug.h gtkintl.h
-IGNORE_HFILES=webkitprivate.h
+IGNORE_HFILES = \
+   webkitdownloadprivate.h \
+   webkitgeolocationpolicydecisionprivate.h \
+   webkitglobalsprivate.h \
+   webkithittestresultprivate.h \
+   webkitnetworkrequestprivate.h \
+   webkitnetworkresponseprivate.h \
+   webkitsecurityoriginprivate.h \
+   webkitviewportattributesprivate.h \
+   webkitwebbackforwardlistprivate.h \
+   webkitwebdatasourceprivate.h \
+   webkitwebframeprivate.h \
+   webkitwebhistoryitemprivate.h \
+   webkitwebinspectorprivate.h \
+   webkitwebnavigationactionprivate.h \
+   webkitwebplugindatabaseprivate.h \
+   webkitwebpluginprivate.h \
+   webkitwebpolicydecisionprivate.h \
+   webkitwebresourceprivate.h \
+   webkitwebsettingsprivate.h \
+   webkitwebviewprivate.h \
+   webkitwebwindowfeaturesprivate.h
 
 # Images to copy into HTML directory.
 # e.g. HTML_IMAGES=$(top_srcdir)/gtk/stock-icons/stock_about_24.png






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88686] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk

[mrobinson]

Title: [88686] releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk








Revision 88686
Author mrobin...@webkit.org
Date 2011-06-13 13:49:39 -0700 (Mon, 13 Jun 2011)


Log Message
Merging r87766

Modified Paths

releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog
releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt




Diff

Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog (88685 => 88686)

--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog	2011-06-13 20:46:24 UTC (rev 88685)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/ChangeLog	2011-06-13 20:49:39 UTC (rev 88686)
@@ -1,3 +1,13 @@
+2011-06-13  Martin Robinson  
+
+Reviewed by Gustavo Noronha Silva.
+
+[GTK] gtkdoc run produces many warnings about missing declarations
+https://bugs.webkit.org/show_bug.cgi?id=61797
+
+* docs/webkitgtk-sections.txt: Remove inexistent symbols from this file
+to reduce the number of gtkdoc warnings.
+
 2011-06-04  Martin Robinson  
 
 Reviewed by Xan Lopez


Modified: releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt (88685 => 88686)

--- releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt	2011-06-13 20:46:24 UTC (rev 88685)
+++ releases/WebKitGTK/webkit-1.4/Source/WebKit/gtk/docs/webkitgtk-sections.txt	2011-06-13 20:49:39 UTC (rev 88686)
@@ -118,7 +118,6 @@
 WEBKIT_IS_WEB_FRAME_CLASS
 WEBKIT_WEB_FRAME_GET_CLASS
 
-WEBKIT_WEB_FRAME_GET_PRIVATE
 WebKitWebFramePrivate
 webkit_web_frame_get_type
 WebKitWebFrame
@@ -132,7 +131,6 @@
 WebKitDownload
 WebKitDownload
 webkit_download_cancel
-webkit_download_error_get_type
 webkit_download_get_current_size
 webkit_download_get_destination_uri
 webkit_download_get_elapsed_time
@@ -146,7 +144,6 @@
 webkit_download_new
 webkit_download_set_destination_uri
 webkit_download_start
-webkit_download_status_get_type
 
 WEBKIT_DOWNLOAD
 WEBKIT_DOWNLOAD_CLASS
@@ -154,8 +151,6 @@
 WEBKIT_IS_DOWNLOAD
 WEBKIT_IS_DOWNLOAD_CLASS
 WEBKIT_TYPE_DOWNLOAD
-WEBKIT_TYPE_DOWNLOAD_ERROR
-WEBKIT_TYPE_DOWNLOAD_STATUS
 
 webkit_download_get_type
 WebKitDownload
@@ -315,12 +310,10 @@
 webkit_web_navigation_action_get_type
 webkit_web_navigation_action_set_original_uri
 webkit_web_navigation_action_set_reason
-webkit_web_navigation_reason_get_type
 
 WEBKIT_IS_WEB_NAVIGATION_ACTION
 WEBKIT_IS_WEB_NAVIGATION_ACTION_CLASS
 WEBKIT_TYPE_WEB_NAVIGATION_ACTION
-WEBKIT_TYPE_WEB_NAVIGATION_REASON
 WEBKIT_WEB_NAVIGATION_ACTION
 WEBKIT_WEB_NAVIGATION_ACTION_CLASS
 WEBKIT_WEB_NAVIGATION_ACTION_GET_CLASS
@@ -488,7 +481,6 @@
 webkit_web_view_set_view_source_mode
 webkit_web_view_set_zoom_level
 webkit_web_view_stop_loading
-webkit_web_view_target_info_get_type
 webkit_web_view_undo
 webkit_web_view_unmark_text_matches
 webkit_web_view_zoom_in
@@ -502,7 +494,6 @@
 WEBKIT_IS_WEB_VIEW_CLASS
 WEBKIT_WEB_VIEW_GET_CLASS
 
-webkit_web_view_set_window_features
 webkit_web_view_get_type
 WebKitWebViewPrivate
 WebKitWebView
@@ -533,7 +524,6 @@
 
 webkit
 Global functions
-webkit_init
 webkit_get_default_session
 webkit_get_default_web_database_quota
 webkit_get_web_database_directory_path
@@ -545,7 +535,6 @@
 WebKitCacheModel
 webkit_get_cache_model
 webkit_set_cache_model
-
 
 
 
@@ -638,36 +627,11 @@
 
 
 
-soup-cache
-WebKitSoupCache
-webkit_soup_cache_new
-webkit_soup_cache_flush
-webkit_soup_cache_clear
-webkit_soup_cache_dump
-webkit_soup_cache_load
-webkit_soup_cache_set_max_size
-webkit_soup_cache_get_max_size
-
-WEBKIT_IS_SOUP_CACHE
-WEBKIT_IS_SOUP_CACHE_CLASS
-WEBKIT_TYPE_SOUP_CACHE
-WEBKIT_SOUP_CACHE
-WEBKIT_SOUP_CACHE_CLASS
-WEBKIT_SOUP_CACHE_GET_CLASS
-
-webkit_soup_cache_get_type
-WebKitSoupCachePrivate
-WebKitSoupCache
-WebKitSoupCacheClass
-
-
-
 webkitprivate
 getViewFromFrame
 kit
 WEBKIT_PARAM_READABLE
 WEBKIT_PARAM_READWRITE
-webkit_web_frame_init_with_web_view
 webkit_web_history_item_new_with_core_item
 webkit_web_inspector_set_inspector_client
 webkit_web_inspector_set_web_view
@@ -690,14 +654,11 @@
 
 webkitdefines
 WEBKIT_API
-webkit_navigation_response_get_type
 WEBKIT_OBSOLETE_API
 WEBKIT_CHECK_VERSION
 WEBKIT_MAJOR_VERSION
 WEBKIT_MICRO_VERSION
 WEBKIT_MINOR_VERSION
-WEBKIT_TYPE_NAVIGATION_RESPONSE
-WEBKIT_TYPE_WEB_VIEW_TARGET_INFO
 webkit_check_version
 webkit_major_version
 webkit_micro_version






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88685] trunk/Source/WebCore

[rniwa]

Title: [88685] trunk/Source/WebCore








Revision 88685
Author rn...@webkit.org
Date 2011-06-13 13:46:24 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Ryosuke Niwa  

Reviewed by Dan Bernstein.

REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
https://bugs.webkit.org/show_bug.cgi?id=62544

Fixed the crash by adding null pointer checks.

No new tests since there's no way to open dictionary panel.

* dom/Position.cpp:
(WebCore::Position::parentAnchoredEquivalent):
* editing/VisiblePosition.cpp:
(WebCore::makeRange):
* page/Frame.cpp:
(WebCore::Frame::rangeForPoint):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Position.cpp
trunk/Source/WebCore/editing/VisiblePosition.cpp
trunk/Source/WebCore/page/Frame.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (88684 => 88685)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 20:41:39 UTC (rev 88684)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 20:46:24 UTC (rev 88685)
@@ -1,3 +1,21 @@
+2011-06-13  Ryosuke Niwa  
+
+Reviewed by Dan Bernstein.
+
+REGRESSION (r81518): Crash in makeRange() when invoking the dictionary panel over a file input
+https://bugs.webkit.org/show_bug.cgi?id=62544
+
+Fixed the crash by adding null pointer checks.
+
+No new tests since there's no way to open dictionary panel.
+
+* dom/Position.cpp:
+(WebCore::Position::parentAnchoredEquivalent):
+* editing/VisiblePosition.cpp:
+(WebCore::makeRange):
+* page/Frame.cpp:
+(WebCore::Frame::rangeForPoint):
+
 2011-06-13  Adam Barth  
 
 Reviewed by Nate Chapin.


Modified: trunk/Source/WebCore/dom/Position.cpp (88684 => 88685)

--- trunk/Source/WebCore/dom/Position.cpp	2011-06-13 20:41:39 UTC (rev 88684)
+++ trunk/Source/WebCore/dom/Position.cpp	2011-06-13 20:46:24 UTC (rev 88685)
@@ -174,7 +174,8 @@
 return firstPositionInOrBeforeNode(m_anchorNode.get());
 }
 if (!m_anchorNode->offsetInCharacters() && (m_anchorType == PositionIsAfterAnchor || static_cast(m_offset) == m_anchorNode->childNodeCount())
-&& (editingIgnoresContent(m_anchorNode.get()) || isTableElement(m_anchorNode.get( {
+&& (editingIgnoresContent(m_anchorNode.get()) || isTableElement(m_anchorNode.get()))
+&& containerNode()) {
 return positionInParentAfterNode(m_anchorNode.get());
 }
 


Modified: trunk/Source/WebCore/editing/VisiblePosition.cpp (88684 => 88685)

--- trunk/Source/WebCore/editing/VisiblePosition.cpp	2011-06-13 20:41:39 UTC (rev 88684)
+++ trunk/Source/WebCore/editing/VisiblePosition.cpp	2011-06-13 20:46:24 UTC (rev 88685)
@@ -632,6 +632,9 @@
 
 Position s = start.deepEquivalent().parentAnchoredEquivalent();
 Position e = end.deepEquivalent().parentAnchoredEquivalent();
+if (s.isNull() || e.isNull())
+return 0;
+
 return Range::create(s.containerNode()->document(), s.containerNode(), s.offsetInContainerNode(), e.containerNode(), e.offsetInContainerNode());
 }
 


Modified: trunk/Source/WebCore/page/Frame.cpp (88684 => 88685)

--- trunk/Source/WebCore/page/Frame.cpp	2011-06-13 20:41:39 UTC (rev 88684)
+++ trunk/Source/WebCore/page/Frame.cpp	2011-06-13 20:46:24 UTC (rev 88685)
@@ -898,8 +898,7 @@
 }
 
 VisiblePosition next = position.next();
-if (next.isNotNull()) {
-RefPtr nextCharacterRange = makeRange(position, next);
+if (RefPtr nextCharacterRange = makeRange(position, next)) {
 IntRect rect = editor()->firstRectForRange(nextCharacterRange.get());
 if (rect.contains(framePoint))
 return nextCharacterRange.release();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88684] trunk/LayoutTests

[jberlin]

Title: [88684] trunk/LayoutTests








Revision 88684
Author jber...@webkit.org
Date 2011-06-13 13:41:39 -0700 (Mon, 13 Jun 2011)


Log Message
plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
https://bugs.webkit.org/show_bug.cgi?id=33973

Update the Windows-specific results to reflect that the mouseUp and mouseDown events are
getting fired on the plugin, but not the getFocusEvent in order to get the bots green.

* platform/win/plugins/mouse-events-expected.txt:
* platform/win/plugins/mouse-events-fixedpos-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/plugins/mouse-events-expected.txt
trunk/LayoutTests/platform/win/plugins/mouse-events-fixedpos-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88683 => 88684)

--- trunk/LayoutTests/ChangeLog	2011-06-13 20:39:05 UTC (rev 88683)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 20:41:39 UTC (rev 88684)
@@ -1,3 +1,14 @@
+2011-06-13  Jessie Berlin  
+
+plugins/mouse-events and plugins/mouse-events-fixedpos don't fire events on the plugin.
+https://bugs.webkit.org/show_bug.cgi?id=33973
+
+Update the Windows-specific results to reflect that the mouseUp and mouseDown events are
+getting fired on the plugin, but not the getFocusEvent in order to get the bots green.
+
+* platform/win/plugins/mouse-events-expected.txt:
+* platform/win/plugins/mouse-events-fixedpos-expected.txt:
+
 2011-06-13  Nate Chapin  
 
 Reviewed by Darin Fisher.


Modified: trunk/LayoutTests/platform/win/plugins/mouse-events-expected.txt (88683 => 88684)

--- trunk/LayoutTests/platform/win/plugins/mouse-events-expected.txt	2011-06-13 20:39:05 UTC (rev 88683)
+++ trunk/LayoutTests/platform/win/plugins/mouse-events-expected.txt	2011-06-13 20:41:39 UTC (rev 88684)
@@ -1,2 +1,6 @@
+CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (20, 20)
+CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (20, 20)
+CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (30, 30)
+CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (40, 30)
 
 Test for bug 11517: Flash clicks/interactivity not working properly.


Modified: trunk/LayoutTests/platform/win/plugins/mouse-events-fixedpos-expected.txt (88683 => 88684)

--- trunk/LayoutTests/platform/win/plugins/mouse-events-fixedpos-expected.txt	2011-06-13 20:39:05 UTC (rev 88683)
+++ trunk/LayoutTests/platform/win/plugins/mouse-events-fixedpos-expected.txt	2011-06-13 20:41:39 UTC (rev 88684)
@@ -1,2 +1,6 @@
+CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (90, 90)
+CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (90, 90)
+CONSOLE MESSAGE: line 0: PLUGIN: mouseDown at (100, 100)
+CONSOLE MESSAGE: line 0: PLUGIN: mouseUp at (110, 100)
 
 Tests for widget positions being correctly updated after scrolling. rdar://problem/7559069






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88683] trunk/Source/WebKit/gtk

[mrobinson]

Title: [88683] trunk/Source/WebKit/gtk








Revision 88683
Author mrobin...@webkit.org
Date 2011-06-13 13:39:05 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Martin Robinson  

Reviewed by Xan Lopez.

Update the list of ignored GTK+ header files for the documentation
generation.

* docs/GNUmakefile.am: Update ignored header list.

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/docs/GNUmakefile.am




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (88682 => 88683)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-06-13 20:36:03 UTC (rev 88682)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-06-13 20:39:05 UTC (rev 88683)
@@ -1,3 +1,12 @@
+2011-06-13  Martin Robinson  
+
+Reviewed by Xan Lopez.
+
+Update the list of ignored GTK+ header files for the documentation
+generation.
+
+* docs/GNUmakefile.am: Update ignored header list.
+
 2011-06-13  Xan Lopez  
 
 Reviewed by Martin Robinson.


Modified: trunk/Source/WebKit/gtk/docs/GNUmakefile.am (88682 => 88683)

--- trunk/Source/WebKit/gtk/docs/GNUmakefile.am	2011-06-13 20:36:03 UTC (rev 88682)
+++ trunk/Source/WebKit/gtk/docs/GNUmakefile.am	2011-06-13 20:39:05 UTC (rev 88683)
@@ -47,7 +47,28 @@
 
 # Header files to ignore when scanning.
 # e.g. IGNORE_HFILES=gtkdebug.h gtkintl.h
-IGNORE_HFILES=webkitprivate.h
+IGNORE_HFILES = \
+   webkitdownloadprivate.h \
+   webkitgeolocationpolicydecisionprivate.h \
+   webkitglobalsprivate.h \
+   webkithittestresultprivate.h \
+   webkitnetworkrequestprivate.h \
+   webkitnetworkresponseprivate.h \
+   webkitsecurityoriginprivate.h \
+   webkitviewportattributesprivate.h \
+   webkitwebbackforwardlistprivate.h \
+   webkitwebdatasourceprivate.h \
+   webkitwebframeprivate.h \
+   webkitwebhistoryitemprivate.h \
+   webkitwebinspectorprivate.h \
+   webkitwebnavigationactionprivate.h \
+   webkitwebplugindatabaseprivate.h \
+   webkitwebpluginprivate.h \
+   webkitwebpolicydecisionprivate.h \
+   webkitwebresourceprivate.h \
+   webkitwebsettingsprivate.h \
+   webkitwebviewprivate.h \
+   webkitwebwindowfeaturesprivate.h
 
 # Images to copy into HTML directory.
 # e.g. HTML_IMAGES=$(top_srcdir)/gtk/stock-icons/stock_about_24.png






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88681] trunk/Source/WebKit/gtk

[xan]

Title: [88681] trunk/Source/WebKit/gtk








Revision 88681
Author x...@webkit.org
Date 2011-06-13 13:25:41 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Xan Lopez  

Reviewed by Martin Robinson.

Update NEWS for 1.5.1 release.

* NEWS: update.

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/NEWS




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (88680 => 88681)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-06-13 20:20:05 UTC (rev 88680)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-06-13 20:25:41 UTC (rev 88681)
@@ -2,6 +2,14 @@
 
 Reviewed by Martin Robinson.
 
+Update NEWS for 1.5.1 release.
+
+* NEWS: update.
+
+2011-06-13  Xan Lopez  
+
+Reviewed by Martin Robinson.
+
 Distcheck fixes.
 
 * GNUmakefile.am:


Modified: trunk/Source/WebKit/gtk/NEWS (88680 => 88681)

--- trunk/Source/WebKit/gtk/NEWS	2011-06-13 20:20:05 UTC (rev 88680)
+++ trunk/Source/WebKit/gtk/NEWS	2011-06-13 20:25:41 UTC (rev 88681)
@@ -1,3 +1,18 @@
+
+WebKitGTK+ 1.5.1
+
+
+What's new in WebKitGTK+ 1.5.1?
+
+  - The JSC library is now available independently. It's called
+"libjavascriptcoregtk", and it comes with its own pkg-config file.
+  - New spellchecking APIs, useful to implement spellchecking features
+in the UAs.
+  - New DOM methods to check if editable areas have been modified by
+the user (webkit_dom_html_{input,text_area}_is_edited).
+  - Lots of improvements in the WebKit2GTK+ port.
+  - Lots of bugfixes.
+
 =
 WebKitGTK+ 1.3.13
 =






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88680] trunk/Tools

[dpranke]

Title: [88680] trunk/Tools








Revision 88680
Author dpra...@chromium.org
Date 2011-06-13 13:20:05 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Sheriff Bot  

Unreviewed, rolling out r88671.
http://trac.webkit.org/changeset/88671
https://bugs.webkit.org/show_bug.cgi?id=62591

"didn't work" (Requested by dpranke on #webkit).

* Scripts/new-run-webkit-httpd:
* Scripts/webkitpy/layout_tests/port/apache_http_server.py:
* Scripts/webkitpy/layout_tests/port/http_server.py:
* Scripts/webkitpy/layout_tests/port/http_server_base.py:
* Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
* Scripts/webkitpy/layout_tests/port/websocket_server.py:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/new-run-webkit-httpd
trunk/Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py
trunk/Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py


Removed Paths

trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py




Diff

Modified: trunk/Tools/ChangeLog (88679 => 88680)

--- trunk/Tools/ChangeLog	2011-06-13 20:19:07 UTC (rev 88679)
+++ trunk/Tools/ChangeLog	2011-06-13 20:20:05 UTC (rev 88680)
@@ -1,3 +1,19 @@
+2011-06-13  Sheriff Bot  
+
+Unreviewed, rolling out r88671.
+http://trac.webkit.org/changeset/88671
+https://bugs.webkit.org/show_bug.cgi?id=62591
+
+"didn't work" (Requested by dpranke on #webkit).
+
+* Scripts/new-run-webkit-httpd:
+* Scripts/webkitpy/layout_tests/port/apache_http_server.py:
+* Scripts/webkitpy/layout_tests/port/http_server.py:
+* Scripts/webkitpy/layout_tests/port/http_server_base.py:
+* Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
+* Scripts/webkitpy/layout_tests/port/port_testcase.py:
+* Scripts/webkitpy/layout_tests/port/websocket_server.py:
+
 2011-06-13  Nate Chapin  
 
 Reviewed by Darin Fisher.


Modified: trunk/Tools/Scripts/new-run-webkit-httpd (88679 => 88680)

--- trunk/Tools/Scripts/new-run-webkit-httpd	2011-06-13 20:19:07 UTC (rev 88679)
+++ trunk/Tools/Scripts/new-run-webkit-httpd	2011-06-13 20:20:05 UTC (rev 88680)
@@ -70,13 +70,9 @@
 if options.server == 'start':
 httpd.start()
 else:
-# FIXME: We use _shut_down_http_server() instead of stop_http_server()
-# because stop() only works if start() was called previously in the
-# same process. _shut_down() is too coarse and may kill unrelated 
-# web servers, so this is a hack. We should change the interface so we
-# can rely on pid files or something.
-port_obj._shut_down_http_server(None)
+httpd.stop(force=True)
 
+
 def main():
 option_parser = optparse.OptionParser()
 option_parser.add_option('-k', '--server',


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py (88679 => 88680)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py	2011-06-13 20:19:07 UTC (rev 88679)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py	2011-06-13 20:20:05 UTC (rev 88680)
@@ -227,9 +227,7 @@
 """Stops the apache http server."""
 _log.debug("Shutting down any running http servers")
 httpd_pid = None
-if self._httpd_proc:
-httpd_pid = self._httpd_proc.pid
-elif os.path.exists(self._pid_file):
+if os.path.exists(self._pid_file):
 httpd_pid = int(open(self._pid_file).readline())
-if httpd_pid:
-self._executive.kill_process(httpd_pid)
+# FIXME: We shouldn't be calling a protected method of _port_obj!
+self._port_obj._shut_down_http_server(httpd_pid)


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server.py (88679 => 88680)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server.py	2011-06-13 20:19:07 UTC (rev 88679)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/http_server.py	2011-06-13 20:20:05 UTC (rev 88680)
@@ -226,14 +226,14 @@
 # TODO(deanm): Find a nicer way to shutdown cleanly.  Our log files are
 # probably not being flushed, etc... why doesn't our python have os.kill ?
 
-def stop(self):
-if not self.is_running():
+def stop(self, force=False):
+if not force and not self.is_running():
 return
 
 httpd_pid = None
 if self._process:
 httpd_pid = self._process.pid
-self._executive.kill_process(httpd_pid)
+self._port_obj._shut_down_http_server(httpd_pid)
 
 if self._process:
 # wait() is not t

[webkit-changes] [88679] trunk

[japhet]

Title: [88679] trunk








Revision 88679
Author jap...@chromium.org
Date 2011-06-13 13:19:07 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Nate Chapin  

Reviewed by Darin Fisher.

Test for https://bugs.webkit.org/show_bug.cgi?id=61482,
mostly written by Kelly Norton (knor...@google.com).

* plugins/npruntime/embed-property-equality-expected.txt: Added.
* plugins/npruntime/embed-property-equality.html: Added.
2011-06-13  Nate Chapin  

Reviewed by Darin Fisher.

[V8] Cache V8NPObjects so that we don't create multiple
NPObjects for the same v8::Object.
https://bugs.webkit.org/show_bug.cgi?id=61482

Test: plugins/npruntime/embed-property-equality.html

* bindings/v8/NPV8Object.cpp:
(WebCore::freeV8NPObject):
(WebCore::npCreateV8ScriptObject):
2011-06-13  Nate Chapin  

Reviewed by Darin Fisher.

New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.

* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/NPV8Object.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp


Added Paths

trunk/LayoutTests/plugins/npruntime/embed-property-equality-expected.txt
trunk/LayoutTests/plugins/npruntime/embed-property-equality.html




Diff

Modified: trunk/LayoutTests/ChangeLog (88678 => 88679)

--- trunk/LayoutTests/ChangeLog	2011-06-13 20:16:20 UTC (rev 88678)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 20:19:07 UTC (rev 88679)
@@ -1,3 +1,13 @@
+2011-06-13  Nate Chapin  
+
+Reviewed by Darin Fisher.
+
+Test for https://bugs.webkit.org/show_bug.cgi?id=61482,
+mostly written by Kelly Norton (knor...@google.com).
+
+* plugins/npruntime/embed-property-equality-expected.txt: Added.
+* plugins/npruntime/embed-property-equality.html: Added.
+
 2011-06-13  Julien Chaffraix  
 
 Reviewed by Alexey Proskuryakov.


Added: trunk/LayoutTests/plugins/npruntime/embed-property-equality-expected.txt (0 => 88679)

--- trunk/LayoutTests/plugins/npruntime/embed-property-equality-expected.txt	(rev 0)
+++ trunk/LayoutTests/plugins/npruntime/embed-property-equality-expected.txt	2011-06-13 20:19:07 UTC (rev 88679)
@@ -0,0 +1,4 @@
+Test equality of plugin object properties.
+
+
+Send two references of a _javascript_ object to the plugin for identity comparison in C++ PASS


Added: trunk/LayoutTests/plugins/npruntime/embed-property-equality.html (0 => 88679)

--- trunk/LayoutTests/plugins/npruntime/embed-property-equality.html	(rev 0)
+++ trunk/LayoutTests/plugins/npruntime/embed-property-equality.html	2011-06-13 20:19:07 UTC (rev 88679)
@@ -0,0 +1,18 @@
+
+Test equality of plugin object properties.
+
+
+
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+window._onload_ = function() {
+var plugin = document.getElementById('plugin');
+var div = document.createElement('div');
+div.textContent = "Send two references of a _javascript_ object to the plugin for identity comparison in C++ " 
++ (plugin.objectsAreSame(document, document) ? "PASS" : "FAIL");
+document.body.appendChild(div);
+}
+
+


Modified: trunk/Source/WebCore/ChangeLog (88678 => 88679)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 20:16:20 UTC (rev 88678)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 20:19:07 UTC (rev 88679)
@@ -1,3 +1,17 @@
+2011-06-13  Nate Chapin  
+
+Reviewed by Darin Fisher.
+
+[V8] Cache V8NPObjects so that we don't create multiple
+NPObjects for the same v8::Object.
+https://bugs.webkit.org/show_bug.cgi?id=61482
+
+Test: plugins/npruntime/embed-property-equality.html
+
+* bindings/v8/NPV8Object.cpp:
+(WebCore::freeV8NPObject):
+(WebCore::npCreateV8ScriptObject):
+
 2011-06-13  Xan Lopez  
 
 Reviewed by Martin Robinson.


Modified: trunk/Source/WebCore/bindings/v8/NPV8Object.cpp (88678 => 88679)

--- trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2011-06-13 20:16:20 UTC (rev 88678)
+++ trunk/Source/WebCore/bindings/v8/NPV8Object.cpp	2011-06-13 20:19:07 UTC (rev 88679)
@@ -61,6 +61,14 @@
 return &typeInfo;
 }
 
+typedef HashMap V8NPObjectMap;
+
+static V8NPObjectMap* staticV8NPObjectMap()
+{
+DEFINE_STATIC_LOCAL(V8NPObjectMap, v8npObjectMap, ());
+return &v8npObjectMap;
+}
+
 // FIXME: Comments on why use malloc and free.
 static NPObject* allocV8NPObject(NPP, NPClass*)
 {
@@ -70,6 +78,14 @@
 static void freeV8NPObject(NPObject* npObject)
 {
 V8NPObject* v8NpObject = reinterpret_cast(npObject);
+if (int v8ObjectHash = v8NpObject->v8Object->GetIdentityHash()) {
+ASSERT(staticV8NPObjectMap()->contains(v8ObjectHash));
+staticV8NPObjectMap()->remove(v8ObjectHash);
+} else {
+ASSERT(!v8::C

[webkit-changes] [88678] trunk/LayoutTests

[jchaffraix]

Title: [88678] trunk/LayoutTests








Revision 88678
Author jchaffr...@webkit.org
Date 2011-06-13 13:16:20 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Julien Chaffraix  

Reviewed by Alexey Proskuryakov.

chrome.dll!WebCore::Node::createRendererIfNeeded ReadAV@NULL (7079875ef32458c5c891a311715b683f)
https://bugs.webkit.org/show_bug.cgi?id=49316

The bug got fixed, thus just landing the test case. Including another test case from
http://code.google.com/p/chromium/issues/detail?id=61562
which should have the same root cause.

* fast/html/crash-style-first-letter-expected.txt: Added.
* fast/html/crash-style-first-letter.html: Added.
* svg/custom/svg-use-style-float-crash-expected.txt: Added.
* svg/custom/svg-use-style-float-crash.svg: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/fast/html/crash-style-first-letter-expected.txt
trunk/LayoutTests/fast/html/crash-style-first-letter.html
trunk/LayoutTests/svg/custom/svg-use-style-float-crash-expected.txt
trunk/LayoutTests/svg/custom/svg-use-style-float-crash.svg




Diff

Modified: trunk/LayoutTests/ChangeLog (88677 => 88678)

--- trunk/LayoutTests/ChangeLog	2011-06-13 20:07:53 UTC (rev 88677)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 20:16:20 UTC (rev 88678)
@@ -1,3 +1,19 @@
+2011-06-13  Julien Chaffraix  
+
+Reviewed by Alexey Proskuryakov.
+
+chrome.dll!WebCore::Node::createRendererIfNeeded ReadAV@NULL (7079875ef32458c5c891a311715b683f)
+https://bugs.webkit.org/show_bug.cgi?id=49316
+
+The bug got fixed, thus just landing the test case. Including another test case from
+http://code.google.com/p/chromium/issues/detail?id=61562
+which should have the same root cause.
+
+* fast/html/crash-style-first-letter-expected.txt: Added.
+* fast/html/crash-style-first-letter.html: Added.
+* svg/custom/svg-use-style-float-crash-expected.txt: Added.
+* svg/custom/svg-use-style-float-crash.svg: Added.
+
 2011-06-13  James Robinson  
 
 [chromium] Fix up a boo-boo in GPU test expectations


Added: trunk/LayoutTests/fast/html/crash-style-first-letter-expected.txt (0 => 88678)

--- trunk/LayoutTests/fast/html/crash-style-first-letter-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/html/crash-style-first-letter-expected.txt	2011-06-13 20:16:20 UTC (rev 88678)
@@ -0,0 +1,3 @@
+Test for https://bugs.webkit.org/show_bug.cgi?id=49316: The test PASSED if it did not crash.
+
+


Added: trunk/LayoutTests/fast/html/crash-style-first-letter.html (0 => 88678)

--- trunk/LayoutTests/fast/html/crash-style-first-letter.html	(rev 0)
+++ trunk/LayoutTests/fast/html/crash-style-first-letter.html	2011-06-13 20:16:20 UTC (rev 88678)
@@ -0,0 +1 @@
+Test for https://bugs.webkit.org/show_bug.cgi?id=49316: The test PASSED if it did not crash.if (window.layoutTestController) layoutTestController.dumpAsText();

[webkit-changes] [88677] trunk/Source/WebKit2

[andersca]

Title: [88677] trunk/Source/WebKit2








Revision 88677
Author ander...@apple.com
Date 2011-06-13 13:07:53 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  Anders Carlsson  

Reviewed by Dan Bernstein.

BankID plug-in isn't instantiated correctly
https://bugs.webkit.org/show_bug.cgi?id=62588


* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
The BankID plug-in uses the QuickDraw drawing model but doesn't draw anything so we can
use the half-baked QuickDraw support.

* WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::defaultSyncMessageTimeout):
Don't use a sync message timeout for the BankID plug-in since it sends synchronous Apple Events
and we don't want the plug-in to die while it's waiting for a reply.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm
trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (88676 => 88677)

--- trunk/Source/WebKit2/ChangeLog	2011-06-13 20:03:06 UTC (rev 88676)
+++ trunk/Source/WebKit2/ChangeLog	2011-06-13 20:07:53 UTC (rev 88677)
@@ -1,3 +1,21 @@
+2011-06-13  Anders Carlsson  
+
+Reviewed by Dan Bernstein.
+
+BankID plug-in isn't instantiated correctly
+https://bugs.webkit.org/show_bug.cgi?id=62588
+
+
+* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
+(WebKit::NetscapePluginModule::determineQuirks):
+The BankID plug-in uses the QuickDraw drawing model but doesn't draw anything so we can
+use the half-baked QuickDraw support.
+
+* WebProcess/Plugins/PluginProcessConnection.cpp:
+(WebKit::defaultSyncMessageTimeout):
+Don't use a sync message timeout for the BankID plug-in since it sends synchronous Apple Events
+and we don't want the plug-in to die while it's waiting for a reply.
+
 2011-06-13  Chris Fleizach  
 
 Reviewed by Darin Adler.


Modified: trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm (88676 => 88677)

--- trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm	2011-06-13 20:03:06 UTC (rev 88676)
+++ trunk/Source/WebKit2/Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm	2011-06-13 20:07:53 UTC (rev 88677)
@@ -441,6 +441,12 @@
 // so we'll allow it to be instantiated even though we don't support QuickDraw.
 m_pluginQuirks.add(PluginQuirks::AllowHalfBakedQuickDrawSupport);
 }
+
+if (plugin.bundleIdentifier == "com.jattesaker.macid2.NPPlugin") {
+// The BankID plug-in uses QuickDraw but doesn't paint or receive events
+// so we'll allow it to be instantiated even though we don't support QuickDraw.
+m_pluginQuirks.add(PluginQuirks::AllowHalfBakedQuickDrawSupport);
+}
 #endif
 }
 


Modified: trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp (88676 => 88677)

--- trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp	2011-06-13 20:03:06 UTC (rev 88676)
+++ trunk/Source/WebKit2/WebProcess/Plugins/PluginProcessConnection.cpp	2011-06-13 20:07:53 UTC (rev 88677)
@@ -58,7 +58,12 @@
 // This way we could check if the plug-in process is actually hung or not.
 if (pathGetFileName(pluginPath) == "SharePointBrowserPlugin.plugin")
 return CoreIPC::Connection::NoTimeout;
-
+
+// We don't want a message timeout for the BankID plug-in since it can spin a nested
+// run loop when it's waiting for a reply to an AppleEvent.
+if (pathGetFileName(pluginPath) == "PersonalPlugin.bundle")
+return CoreIPC::Connection::NoTimeout;
+
 return syncMessageTimeout;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88676] trunk/LayoutTests

[jamesr]

Title: [88676] trunk/LayoutTests








Revision 88676
Author jam...@google.com
Date 2011-06-13 13:03:06 -0700 (Mon, 13 Jun 2011)


Log Message
2011-06-13  James Robinson  

[chromium] Fix up a boo-boo in GPU test expectations

* platform/chromium/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (88675 => 88676)

--- trunk/LayoutTests/ChangeLog	2011-06-13 20:01:30 UTC (rev 88675)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 20:03:06 UTC (rev 88676)
@@ -1,3 +1,9 @@
+2011-06-13  James Robinson  
+
+[chromium] Fix up a boo-boo in GPU test expectations
+
+* platform/chromium/test_expectations.txt:
+
 2011-06-13  David Levin  
 
 Test run fix.


Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (88675 => 88676)

--- trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 20:01:30 UTC (rev 88675)
+++ trunk/LayoutTests/platform/chromium/test_expectations.txt	2011-06-13 20:03:06 UTC (rev 88676)
@@ -3540,7 +3540,6 @@
 
 BUGWK60102 LINUX DEBUG GPU : compositing/geometry/fixed-in-composited.html = IMAGE
 BUGWK60102 MAC GPU : compositing/geometry/video-fixed-scrolling.html = IMAGE
-BUGWK60102 LINUX DEBUG GPU : compositing/geometry/video-fixed-scrolling.html = IMAGE
 BUGWK60102 LINUX GPU : compositing/masks/masked-ancestor.html = IMAGE
 BUGWK60102 LINUX DEBUG GPU : compositing/masks/simple-composited-mask.html = IMAGE
 // Commented because of BUGCR81605






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88675] trunk/LayoutTests

[levin]

Title: [88675] trunk/LayoutTests








Revision 88675
Author le...@chromium.org
Date 2011-06-13 13:01:30 -0700 (Mon, 13 Jun 2011)


Log Message
Test run fix.

[GTK] DumpRenderTree doesn't block external requests.
https://bugs.webkit.org/show_bug.cgi?id=62585

* platform/gtk/Skipped: Skipping a test which depends on this.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (88674 => 88675)

--- trunk/LayoutTests/ChangeLog	2011-06-13 19:47:09 UTC (rev 88674)
+++ trunk/LayoutTests/ChangeLog	2011-06-13 20:01:30 UTC (rev 88675)
@@ -1,3 +1,12 @@
+2011-06-13  David Levin  
+
+Test run fix.
+
+[GTK] DumpRenderTree doesn't block external requests.
+https://bugs.webkit.org/show_bug.cgi?id=62585
+
+* platform/gtk/Skipped: Skipping a test which depends on this.
+
 2011-06-13  Robert Hogan  
 
 Unreviewed, cleanup r87611. 


Modified: trunk/LayoutTests/platform/gtk/Skipped (88674 => 88675)

--- trunk/LayoutTests/platform/gtk/Skipped	2011-06-13 19:47:09 UTC (rev 88674)
+++ trunk/LayoutTests/platform/gtk/Skipped	2011-06-13 20:01:30 UTC (rev 88675)
@@ -1537,3 +1537,7 @@
 http/tests/security/webgl-remote-read-remote-image-allowed.html
 http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
 http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html
+
+# Failing because GTK DumpRenderTree doesn't block external network requests like the
+# willSendRequest method does for other ports (bug 62585).
+fast/workers/worker-crash-with-invalid-location-pretty-diff.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [88674] trunk/Source

[xan]

Title: [88674] trunk/Source








Revision 88674
Author x...@webkit.org
Date 2011-06-13 12:47:09 -0700 (Mon, 13 Jun 2011)


Log Message
Source/WebCore:

2011-06-13  Xan Lopez  

Reviewed by Martin Robinson.

Distcheck fixes.

* GNUmakefile.am:
* GNUmakefile.list.am:

Source/WebKit/gtk:

2011-06-13  Xan Lopez  

Reviewed by Martin Robinson.

Distcheck fixes.

* GNUmakefile.am:

Source/_javascript_Core:

2011-06-13  Xan Lopez  

Reviewed by Martin Robinson.

Distcheck fixes.

* GNUmakefile.am:
* GNUmakefile.list.am:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/GNUmakefile.am
trunk/Source/_javascript_Core/GNUmakefile.list.am
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (88673 => 88674)

--- trunk/Source/_javascript_Core/ChangeLog	2011-06-13 19:37:49 UTC (rev 88673)
+++ trunk/Source/_javascript_Core/ChangeLog	2011-06-13 19:47:09 UTC (rev 88674)
@@ -1,3 +1,12 @@
+2011-06-13  Xan Lopez  
+
+Reviewed by Martin Robinson.
+
+Distcheck fixes.
+
+* GNUmakefile.am:
+* GNUmakefile.list.am:
+
 2011-06-13  Oliver Hunt  
 
 Reviewed by Simon Fraser.


Modified: trunk/Source/_javascript_Core/GNUmakefile.am (88673 => 88674)

--- trunk/Source/_javascript_Core/GNUmakefile.am	2011-06-13 19:37:49 UTC (rev 88673)
+++ trunk/Source/_javascript_Core/GNUmakefile.am	2011-06-13 19:47:09 UTC (rev 88674)
@@ -145,6 +145,7 @@
 	Source/_javascript_Core/create_regex_tables \
 	Source/_javascript_Core/icu/LICENSE \
 	Source/_javascript_Core/icu/README \
+	Source/_javascript_Core/KeywordLookupGenerator.py \
 	Source/_javascript_Core/parser/Keywords.table \
 	Source/_javascript_Core/THANKS
 


Modified: trunk/Source/_javascript_Core/GNUmakefile.list.am (88673 => 88674)

--- trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-06-13 19:37:49 UTC (rev 88673)
+++ trunk/Source/_javascript_Core/GNUmakefile.list.am	2011-06-13 19:47:09 UTC (rev 88674)
@@ -98,6 +98,29 @@
 	Source/_javascript_Core/bytecompiler/LabelScope.h \
 	Source/_javascript_Core/bytecompiler/NodesCodegen.cpp \
 	Source/_javascript_Core/bytecompiler/RegisterID.h \
+	Source/_javascript_Core/dfg/DFGAliasTracker.h \
+	Source/_javascript_Core/dfg/DFGByteCodeParser.cpp \
+	Source/_javascript_Core/dfg/DFGByteCodeParser.h \
+	Source/_javascript_Core/dfg/DFGFPRInfo.h \
+	Source/_javascript_Core/dfg/DFGGenerationInfo.h \
+	Source/_javascript_Core/dfg/DFGGPRInfo.h \
+	Source/_javascript_Core/dfg/DFGGraph.cpp \
+	Source/_javascript_Core/dfg/DFGGraph.h \
+	Source/_javascript_Core/dfg/DFGJITCodeGenerator.cpp \
+	Source/_javascript_Core/dfg/DFGJITCodeGenerator.h \
+	Source/_javascript_Core/dfg/DFGJITCompiler.cpp \
+	Source/_javascript_Core/dfg/DFGJITCompiler.h \
+	Source/_javascript_Core/dfg/DFGNode.h \
+	Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.cpp \
+	Source/_javascript_Core/dfg/DFGNonSpeculativeJIT.h \
+	Source/_javascript_Core/dfg/DFGOperations.cpp \
+	Source/_javascript_Core/dfg/DFGOperations.h \
+	Source/_javascript_Core/dfg/DFGRegisterBank.h \
+	Source/_javascript_Core/dfg/DFGRepatch.cpp \
+	Source/_javascript_Core/dfg/DFGRepatch.h \
+	Source/_javascript_Core/dfg/DFGScoreBoard.h \
+	Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp \
+	Source/_javascript_Core/dfg/DFGSpeculativeJIT.h \
 	Source/_javascript_Core/heap/ConservativeRoots.cpp \
 	Source/_javascript_Core/heap/ConservativeRoots.h \
 	Source/_javascript_Core/heap/Handle.h \
@@ -413,6 +436,7 @@
 	Source/_javascript_Core/runtime/WeakGCMap.h \
 	Source/_javascript_Core/runtime/WeakRandom.h \
 	Source/_javascript_Core/runtime/WriteBarrier.h \
+	Source/_javascript_Core/wtf/Alignment.h \
 	Source/_javascript_Core/wtf/AlwaysInline.h \
 	Source/_javascript_Core/wtf/ASCIICType.h \
 	Source/_javascript_Core/wtf/Assertions.cpp \


Modified: trunk/Source/WebCore/ChangeLog (88673 => 88674)

--- trunk/Source/WebCore/ChangeLog	2011-06-13 19:37:49 UTC (rev 88673)
+++ trunk/Source/WebCore/ChangeLog	2011-06-13 19:47:09 UTC (rev 88674)
@@ -1,3 +1,12 @@
+2011-06-13  Xan Lopez  
+
+Reviewed by Martin Robinson.
+
+Distcheck fixes.
+
+* GNUmakefile.am:
+* GNUmakefile.list.am:
+
 2011-06-13  Dirk Schulze  
 
 Reviewed build fix of mac.


Modified: trunk/Source/WebCore/GNUmakefile.am (88673 => 88674)

--- trunk/Source/WebCore/GNUmakefile.am	2011-06-13 19:37:49 UTC (rev 88673)
+++ trunk/Source/WebCore/GNUmakefile.am	2011-06-13 19:47:09 UTC (rev 88674)
@@ -793,7 +793,7 @@
 	Source/WebCore/bindings/scripts/IDLStructure.pm \
 	Source/WebCore/bindings/scripts/InFilesParser.pm \
 	Source/WebCore/bindings/scripts/generate-bindings.pl \
-	Source/WebCore/bindings/scripts/preprocessor.pm
+	Source/WebCore/bindings/scripts/preprocessor.pm \
 	Source/WebCore