[webkit-changes] [110029] trunk/Source/WebCore
Title: [110029] trunk/Source/WebCore Revision 110029 Author commit-qu...@webkit.org Date 2012-03-07 00:09:15 -0800 (Wed, 07 Mar 2012) Log Message [Forms] The legend element should not be a form-associated element. https://bugs.webkit.org/show_bug.cgi?id=80239 Patch by Yoshifumi Inoue yo...@chromium.org on 2012-03-07 Reviewed by Kent Tamura. This patch changes base class of HTMLLegendElement to HTMLElement from HTMLFormControlElement for saving memory space and iteration time of extra legend elements in HTMLFormElement::m_formAssociatedElements and matching the HTML5 specification for ease of maintenance. Changes of TextIterator is lead by usage of isFormControlElement. This changes will be replaced with more meaningful predicate as part of https://bugs.webkit.org/show_bug.cgi?id=80381 No new tests are required. No behavior changes. * editing/TextIterator.cpp: (WebCore::TextIterator::advance): Check HTMLLegendElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute. * html/HTMLLegendElement.cpp: (WebCore::HTMLLegendElement::HTMLLegendElement): Remove form parameter. (WebCore::HTMLLegendElement::create): Remove form parameter. (WebCore::HTMLLegendElement::associatedControl): Stop checking legend element, because HTMLLegendElement is no longer HTMLFormControlElement. (WebCore::HTMLLegendElement::supportFocus): Removed. It called HTMLElement::supportFocus. (WebCore::HTMLLegendElement::formControlType): Remove implementation of virtual method declared in HTMLFormControlElement. * html/HTMLLegendElement.h: (HTMLLegendElement): Change base class to HTMLElement. * html/HTMLTagNames.in: Remove constructorNeedsFormElement for not passing form parameter in HTMLElementFactory. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/editing/TextIterator.cpp trunk/Source/WebCore/html/HTMLLegendElement.cpp trunk/Source/WebCore/html/HTMLLegendElement.h trunk/Source/WebCore/html/HTMLTagNames.in Diff Modified: trunk/Source/WebCore/ChangeLog (110028 => 110029) --- trunk/Source/WebCore/ChangeLog 2012-03-07 07:54:34 UTC (rev 110028) +++ trunk/Source/WebCore/ChangeLog 2012-03-07 08:09:15 UTC (rev 110029) @@ -1,3 +1,33 @@ +2012-03-07 Yoshifumi Inoue yo...@chromium.org + +[Forms] The legend element should not be a form-associated element. +https://bugs.webkit.org/show_bug.cgi?id=80239 + +Reviewed by Kent Tamura. + +This patch changes base class of HTMLLegendElement to HTMLElement from +HTMLFormControlElement for saving memory space and iteration time of +extra legend elements in HTMLFormElement::m_formAssociatedElements +and matching the HTML5 specification for ease of maintenance. + +Changes of TextIterator is lead by usage of isFormControlElement. This +changes will be replaced with more meaningful predicate as part of +https://bugs.webkit.org/show_bug.cgi?id=80381 + +No new tests are required. No behavior changes. + +* editing/TextIterator.cpp: +(WebCore::TextIterator::advance): Check HTMLLegendElement in addition to isFormControlElement. This change is for text dump in LayoutTests implemented by document.innerText attribute. +* html/HTMLLegendElement.cpp: +(WebCore::HTMLLegendElement::HTMLLegendElement): Remove form parameter. +(WebCore::HTMLLegendElement::create): Remove form parameter. +(WebCore::HTMLLegendElement::associatedControl): Stop checking legend element, because HTMLLegendElement is no longer HTMLFormControlElement. +(WebCore::HTMLLegendElement::supportFocus): Removed. It called HTMLElement::supportFocus. +(WebCore::HTMLLegendElement::formControlType): Remove implementation of virtual method declared in HTMLFormControlElement. +* html/HTMLLegendElement.h: +(HTMLLegendElement): Change base class to HTMLElement. +* html/HTMLTagNames.in: Remove constructorNeedsFormElement for not passing form parameter in HTMLElementFactory. + 2012-03-06 Raphael Kubo da Costa k...@profusion.mobi [CMake] Make the removal of transitive library dependencies work with CMake 2.8.7. Modified: trunk/Source/WebCore/editing/TextIterator.cpp (110028 => 110029) --- trunk/Source/WebCore/editing/TextIterator.cpp 2012-03-07 07:54:34 UTC (rev 110028) +++ trunk/Source/WebCore/editing/TextIterator.cpp 2012-03-07 08:09:15 UTC (rev 110029) @@ -394,7 +394,8 @@ m_handledNode = handleTextNode(); else if (renderer (renderer-isImage() || renderer-isWidget() || (renderer-node() renderer-node()-isElementNode() - static_castElement*(renderer-node())-isFormControlElement( + (static_castElement*(renderer-node())-isFormControlElement() + || static_castElement*(renderer-node())-hasTagName(legendTag)
[webkit-changes] [110030] releases/WebKitGTK/webkit-1.8
Title: [110030] releases/WebKitGTK/webkit-1.8 Revision 110030 Author mrobin...@webkit.org Date 2012-03-07 00:13:26 -0800 (Wed, 07 Mar 2012) Log Message Update the NEWS and version for the 1.7.91 release. Reviewed by Gustavo Noronha Silva. .: * configure.ac: Update. Source/WebKit/gtk: * NEWS: Update. Modified Paths releases/WebKitGTK/webkit-1.8/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS releases/WebKitGTK/webkit-1.8/configure.ac Diff Modified: releases/WebKitGTK/webkit-1.8/ChangeLog (110029 => 110030) --- releases/WebKitGTK/webkit-1.8/ChangeLog 2012-03-07 08:09:15 UTC (rev 110029) +++ releases/WebKitGTK/webkit-1.8/ChangeLog 2012-03-07 08:13:26 UTC (rev 110030) @@ -1,3 +1,11 @@ +2012-03-07 Martin Robinson mrobin...@igalia.com + +Update the NEWS and version for the 1.7.91 release. + +Reviewed by Gustavo Noronha Silva. + +* configure.ac: Update. + 2012-03-06 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r109760. Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog (110029 => 110030) --- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-03-07 08:09:15 UTC (rev 110029) +++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/ChangeLog 2012-03-07 08:13:26 UTC (rev 110030) @@ -1,3 +1,11 @@ +2012-03-07 Martin Robinson mrobin...@igalia.com + +Update the NEWS and version for the 1.7.91 release. + +Reviewed by Gustavo Noronha Silva. + +* NEWS: Update. + 2012-03-06 Martin Robinson mrobin...@igalia.com Fix a compilation warning encountered during the GTK+ build. Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS (110029 => 110030) --- releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS 2012-03-07 08:09:15 UTC (rev 110029) +++ releases/WebKitGTK/webkit-1.8/Source/WebKit/gtk/NEWS 2012-03-07 08:13:26 UTC (rev 110030) @@ -1,4 +1,16 @@ = +WebKitGTK+ 1.7.91 += + +What's new in WebKitGTK+ 1.7.91? + + - Properly advertise flac support for the audio tag. + - Fix a WebProcess segmentation fault related to clipboard handling. + - Add a Find API for WebKit2. + - Add zoom-text-only setting to WebKit2 GTK+ API. + - Miscellaneous build fixes. + += WebKitGTK+ 1.7.90 = Modified: releases/WebKitGTK/webkit-1.8/configure.ac (110029 => 110030) --- releases/WebKitGTK/webkit-1.8/configure.ac 2012-03-07 08:09:15 UTC (rev 110029) +++ releases/WebKitGTK/webkit-1.8/configure.ac 2012-03-07 08:13:26 UTC (rev 110030) @@ -2,7 +2,7 @@ m4_define([webkit_major_version], [1]) m4_define([webkit_minor_version], [7]) -m4_define([webkit_micro_version], [90]) +m4_define([webkit_micro_version], [91]) # This is the version we'll be using as part of our User-Agent string # e.g., AppleWebKit/$(webkit_user_agent_version) ... @@ -35,7 +35,7 @@ dnl # Libtool library version, not to confuse with API version dnl # see http://www.gnu.org/software/libtool/manual/html_node/Libtool-versioning.html -LIBWEBKITGTK_VERSION=12:1:12 +LIBWEBKITGTK_VERSION=12:2:12 AC_SUBST([LIBWEBKITGTK_VERSION]) AM_INIT_AUTOMAKE([foreign subdir-objects dist-xz no-dist-gzip tar-ustar]) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110031] trunk/LayoutTests
Title: [110031] trunk/LayoutTests Revision 110031 Author u...@chromium.org Date 2012-03-07 00:17:26 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed, update chromium test expectations * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110030 => 110031) --- trunk/LayoutTests/ChangeLog 2012-03-07 08:13:26 UTC (rev 110030) +++ trunk/LayoutTests/ChangeLog 2012-03-07 08:17:26 UTC (rev 110031) @@ -1,3 +1,9 @@ +2012-03-07 Fumitoshi Ukai u...@chromium.org + +Unreviewed, update chromium test expectations + +* platform/chromium/test_expectations.txt: + 2012-03-06 Grzegorz Czajkowski g.czajkow...@samsung.com [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110030 => 110031) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 08:13:26 UTC (rev 110030) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 08:17:26 UTC (rev 110031) @@ -4164,3 +4164,6 @@ BUGWK80481 MAC : canvas/philip/tests/2d.text.draw.fontface.repeat.html = CRASH PASS BUGWK80481 MAC : canvas/philip/tests/2d.text.draw.space.basic.html = CRASH PASS BUGWK80481 MAC : http/tests/css/font-face-src-loading.html = CRASH PASS + +// worker-multi-startup.html is flaky on win +BUGWK80498 WIN : fast/workers/worker-multi-startup.html = CRASH PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110035] trunk
Title: [110035] trunk
Revision 110035
Author commit-qu...@webkit.org
Date 2012-03-07 01:24:07 -0800 (Wed, 07 Mar 2012)
Log Message
[EFL] Build warning: Fix warn_unused_result warnings.
https://bugs.webkit.org/show_bug.cgi?id=79194
Patch by Byungwoo Lee bw80@samsung.com on 2012-03-07
Reviewed by Filip Pizlo.
Fixed build warning which is getting generated when not using return
value of a fuction, especially declared with warn_unused_result
attribute.
Source/WebCore:
* platform/efl/SharedBufferEfl.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):
Tools:
* DumpRenderTree/efl/ImageDiff.cpp:
(printImage):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110034 => 110035)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 09:04:58 UTC (rev 110034)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 09:24:07 UTC (rev 110035)
@@ -1,3 +1,17 @@
+2012-03-07 Byungwoo Lee bw80@samsung.com
+
+[EFL] Build warning: Fix warn_unused_result warnings.
+https://bugs.webkit.org/show_bug.cgi?id=79194
+
+Reviewed by Filip Pizlo.
+
+Fixed build warning which is getting generated when not using return
+value of a fuction, especially declared with warn_unused_result
+attribute.
+
+* platform/efl/SharedBufferEfl.cpp:
+(WebCore::SharedBuffer::createWithContentsOfFile):
+
2012-03-07 Kent Tamura tk...@chromium.org
Cleanup of RenderTextControl::adjustControlHeightBasedOnLineHeight()
Modified: trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp (110034 => 110035)
--- trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp 2012-03-07 09:04:58 UTC (rev 110034)
+++ trunk/Source/WebCore/platform/efl/SharedBufferEfl.cpp 2012-03-07 09:24:07 UTC (rev 110035)
@@ -61,10 +61,10 @@
return 0;
}
-fread(result-m_buffer.data(), 1, fileStat.st_size, file);
+const size_t bytesRead = fread(result-m_buffer.data(), 1, fileStat.st_size, file);
fclose(file);
-return result.release();
+return bytesRead == static_castunsigned(fileStat.st_size) ? result.release() : 0;
}
} // namespace WebCore
Modified: trunk/Tools/ChangeLog (110034 => 110035)
--- trunk/Tools/ChangeLog 2012-03-07 09:04:58 UTC (rev 110034)
+++ trunk/Tools/ChangeLog 2012-03-07 09:24:07 UTC (rev 110035)
@@ -1,3 +1,17 @@
+2012-03-07 Byungwoo Lee bw80@samsung.com
+
+[EFL] Build warning: Fix warn_unused_result warnings.
+https://bugs.webkit.org/show_bug.cgi?id=79194
+
+Reviewed by Filip Pizlo.
+
+Fixed build warning which is getting generated when not using return
+value of a fuction, especially declared with warn_unused_result
+attribute.
+
+* DumpRenderTree/efl/ImageDiff.cpp:
+(printImage):
+
2012-03-07 Kangil Han kangil@samsung.com
[DRT] Remove PlainTextController implementations.
Modified: trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp (110034 => 110035)
--- trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2012-03-07 09:04:58 UTC (rev 110034)
+++ trunk/Tools/DumpRenderTree/efl/ImageDiff.cpp 2012-03-07 09:24:07 UTC (rev 110035)
@@ -209,8 +209,15 @@
unsigned char buffer[2048];
ssize_t bytesRead;
-while ((bytesRead = read(tempImageFd, buffer, sizeof(buffer))) 0)
-write(1, buffer, bytesRead);
+while ((bytesRead = read(tempImageFd, buffer, sizeof(buffer))) 0) {
+ssize_t bytesWritten = 0;
+ssize_t count;
+do {
+if ((count = write(1, buffer + bytesWritten, bytesRead - bytesWritten)) = 0)
+break;
+bytesWritten += count;
+} while (bytesWritten bytesRead);
+}
}
}
close(tempImageFd);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110036] trunk/LayoutTests
Title: [110036] trunk/LayoutTests Revision 110036 Author u...@chromium.org Date 2012-03-07 01:31:54 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed, update chromium test expectations * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110035 => 110036) --- trunk/LayoutTests/ChangeLog 2012-03-07 09:24:07 UTC (rev 110035) +++ trunk/LayoutTests/ChangeLog 2012-03-07 09:31:54 UTC (rev 110036) @@ -1,3 +1,9 @@ +2012-03-07 Fumitoshi Ukai u...@chromium.org + +Unreviewed, update chromium test expectations + +* platform/chromium/test_expectations.txt: + 2012-03-07 Kangil Han kangil@samsung.com [DRT] Remove PlainTextController implementations. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110035 => 110036) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 09:24:07 UTC (rev 110035) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 09:31:54 UTC (rev 110036) @@ -2765,7 +2765,7 @@ BUGCR77574 LINUX : fast/writing-mode/fallback-orientation.html = IMAGE // Regression in r82056. -BUGWK57302 LEOPARD : fast/ruby/base-shorter-than-text.html = IMAGE IMAGE+TEXT +BUGWK56519 LEOPARD SNOWLEOPARD : fast/ruby/base-shorter-than-text.html = IMAGE IMAGE+TEXT BUGWK57302 LEOPARD : fast/text/international/text-combine-image-test.html = IMAGE IMAGE+TEXT // New test added in r82152 and test expectation updated in r82189. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110037] trunk
Title: [110037] trunk Revision 110037 Author ba...@chromium.org Date 2012-03-07 01:39:56 -0800 (Wed, 07 Mar 2012) Log Message [WebSocket] Should raise SYNTAX_ERR when message contains unpaired surrogates https://bugs.webkit.org/show_bug.cgi?id=80103 Reviewed by Kent Tamura. Source/WebCore: Add UTF8 validation checks for WebSocket message and close reason. Tests: http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html * Modules/websockets/WebSocket.cpp: (WebCore::WebSocket::send): Raise SYNTAX_ERR if the message is invalid. (WebCore::WebSocket::close):Raise SYNTAX_ERR if the reason is invalid. * Modules/websockets/WebSocketChannel.cpp: (WebCore::WebSocketChannel::send): Check whether message is a valid UTF8 string. LayoutTests: Added tests for unpaired surrogates check for WebSocket message and close reason. Updated two expectations for close() tests because further error message is added. * http/tests/websocket/tests/hybi/close-expected.txt: Updated. * http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Added. * http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Added. * http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Added. * http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Added. * http/tests/websocket/tests/hybi/workers/close-expected.txt: Updated. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/websocket/tests/hybi/close-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/workers/close-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/websockets/WebSocket.cpp trunk/Source/WebCore/Modules/websockets/WebSocketChannel.cpp Added Paths trunk/LayoutTests/http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html trunk/LayoutTests/http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt trunk/LayoutTests/http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html Diff Modified: trunk/LayoutTests/ChangeLog (110036 => 110037) --- trunk/LayoutTests/ChangeLog 2012-03-07 09:31:54 UTC (rev 110036) +++ trunk/LayoutTests/ChangeLog 2012-03-07 09:39:56 UTC (rev 110037) @@ -1,3 +1,20 @@ +2012-03-07 Kenichi Ishibashi ba...@chromium.org + +[WebSocket] Should raise SYNTAX_ERR when message contains unpaired surrogates +https://bugs.webkit.org/show_bug.cgi?id=80103 + +Reviewed by Kent Tamura. + +Added tests for unpaired surrogates check for WebSocket message and close reason. +Updated two expectations for close() tests because further error message is added. + +* http/tests/websocket/tests/hybi/close-expected.txt: Updated. +* http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt: Added. +* http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason.html: Added. +* http/tests/websocket/tests/hybi/unpaired-surrogates-in-message-expected.txt: Added. +* http/tests/websocket/tests/hybi/unpaired-surrogates-in-message.html: Added. +* http/tests/websocket/tests/hybi/workers/close-expected.txt: Updated. + 2012-03-07 Fumitoshi Ukai u...@chromium.org Unreviewed, update chromium test expectations Modified: trunk/LayoutTests/http/tests/websocket/tests/hybi/close-expected.txt (110036 => 110037) --- trunk/LayoutTests/http/tests/websocket/tests/hybi/close-expected.txt 2012-03-07 09:31:54 UTC (rev 110036) +++ trunk/LayoutTests/http/tests/websocket/tests/hybi/close-expected.txt 2012-03-07 09:39:56 UTC (rev 110037) @@ -1,4 +1,6 @@ CONSOLE MESSAGE: WebSocket is closed before the connection is established. +CONSOLE MESSAGE: WebSocket close message is too long. +CONSOLE MESSAGE: WebSocket close message is too long. CONSOLE MESSAGE: WebSocket is closed before the connection is established. Verify WebSocket::close behaviors. Added: trunk/LayoutTests/http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt (0 => 110037) --- trunk/LayoutTests/http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/websocket/tests/hybi/unpaired-surrogates-in-close-reason-expected.txt 2012-03-07 09:39:56 UTC (rev 110037) @@ -0,0 +1,11 @@ +CONSOLE MESSAGE: WebSocket close message contains invalid character(s). +Checks whether SYNTAX_ERR is thrown when attemping to close the connection with unpaired surrogates. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + +Connected. +PASS SYNTAX_ERR was thrown. +PASS successfullyParsed is true + +TEST COMPLETE + Property changes on:
[webkit-changes] [110038] trunk
Title: [110038] trunk
Revision 110038
Author mr...@apple.com
Date 2012-03-07 02:11:47 -0800 (Wed, 07 Mar 2012)
Log Message
Teach make to build WTF.
.:
* Source/Makefile:
Source/WTF:
* Makefile: Added.
Modified Paths
trunk/ChangeLog
trunk/Source/Makefile
trunk/Source/WTF/ChangeLog
Added Paths
trunk/Source/WTF/Makefile
Diff
Modified: trunk/ChangeLog (110037 => 110038)
--- trunk/ChangeLog 2012-03-07 09:39:56 UTC (rev 110037)
+++ trunk/ChangeLog 2012-03-07 10:11:47 UTC (rev 110038)
@@ -1,3 +1,9 @@
+2012-03-07 Mark Rowe mr...@apple.com
+
+Teach make to build WTF.
+
+* Source/Makefile:
+
2012-03-06 Raphael Kubo da Costa k...@profusion.mobi
[CMake] Make the removal of transitive library dependencies work with CMake 2.8.7.
Modified: trunk/Source/Makefile (110037 => 110038)
--- trunk/Source/Makefile 2012-03-07 09:39:56 UTC (rev 110037)
+++ trunk/Source/Makefile 2012-03-07 10:11:47 UTC (rev 110038)
@@ -1,4 +1,4 @@
-MODULES = _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2
+MODULES = WTF _javascript_Core ThirdParty/ANGLE WebCore WebKit WebKit2
all:
@for dir in $(MODULES); do ${MAKE} $@ -C $$dir; exit_status=$$?; \
Modified: trunk/Source/WTF/ChangeLog (110037 => 110038)
--- trunk/Source/WTF/ChangeLog 2012-03-07 09:39:56 UTC (rev 110037)
+++ trunk/Source/WTF/ChangeLog 2012-03-07 10:11:47 UTC (rev 110038)
@@ -1,3 +1,9 @@
+2012-03-07 Mark Rowe mr...@apple.com
+
+Teach make to build WTF.
+
+* Makefile: Added.
+
2012-02-11 Filip Pizlo fpi...@apple.com
It should be possible to send all JSC debug logging to a file
Added: trunk/Source/WTF/Makefile (0 => 110038)
--- trunk/Source/WTF/Makefile (rev 0)
+++ trunk/Source/WTF/Makefile 2012-03-07 10:11:47 UTC (rev 110038)
@@ -0,0 +1 @@
+include ../Makefile.shared
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110039] trunk/Source/JavaScriptCore
Title: [110039] trunk/Source/_javascript_Core
Revision 110039
Author wi...@igalia.com
Date 2012-03-07 02:18:43 -0800 (Wed, 07 Mar 2012)
Log Message
Parser: Inline ScopeNodeData into ScopeNode
https://bugs.webkit.org/show_bug.cgi?id=79776
Reviewed by Geoffrey Garen.
It used to be that some ScopeNode members were kept in a separate
structure because sometimes they wouldn't be needed, and
allocating a ParserArena was expensive. This patch makes
ParserArena lazily allocate its IdentifierArena, allowing the
members to be included directly, which is simpler and easier to
reason about.
* parser/ParserArena.cpp:
(JSC::ParserArena::ParserArena):
(JSC::ParserArena::reset):
(JSC::ParserArena::isEmpty):
* parser/ParserArena.h:
(JSC::ParserArena::identifierArena): Lazily allocate the
IdentifierArena.
* parser/Nodes.cpp:
(JSC::ScopeNode::ScopeNode):
(JSC::ScopeNode::singleStatement):
(JSC::ProgramNode::create):
(JSC::EvalNode::create):
(JSC::FunctionBodyNode::create):
* parser/Nodes.h:
(JSC::ScopeNode::destroyData):
(JSC::ScopeNode::needsActivationForMoreThanVariables):
(JSC::ScopeNode::needsActivation):
(JSC::ScopeNode::hasCapturedVariables):
(JSC::ScopeNode::capturedVariableCount):
(JSC::ScopeNode::captures):
(JSC::ScopeNode::varStack):
(JSC::ScopeNode::functionStack):
(JSC::ScopeNode::neededConstants):
(ScopeNode):
* bytecompiler/NodesCodegen.cpp:
(JSC::ScopeNode::emitStatementsBytecode): Inline ScopeNodeData
into ScopeNode. Adapt accessors.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp
trunk/Source/_javascript_Core/parser/Nodes.cpp
trunk/Source/_javascript_Core/parser/Nodes.h
trunk/Source/_javascript_Core/parser/ParserArena.cpp
trunk/Source/_javascript_Core/parser/ParserArena.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (110038 => 110039)
--- trunk/Source/_javascript_Core/ChangeLog 2012-03-07 10:11:47 UTC (rev 110038)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-03-07 10:18:43 UTC (rev 110039)
@@ -1,3 +1,46 @@
+2012-03-07 Andy Wingo wi...@igalia.com
+
+Parser: Inline ScopeNodeData into ScopeNode
+https://bugs.webkit.org/show_bug.cgi?id=79776
+
+Reviewed by Geoffrey Garen.
+
+It used to be that some ScopeNode members were kept in a separate
+structure because sometimes they wouldn't be needed, and
+allocating a ParserArena was expensive. This patch makes
+ParserArena lazily allocate its IdentifierArena, allowing the
+members to be included directly, which is simpler and easier to
+reason about.
+
+* parser/ParserArena.cpp:
+(JSC::ParserArena::ParserArena):
+(JSC::ParserArena::reset):
+(JSC::ParserArena::isEmpty):
+* parser/ParserArena.h:
+(JSC::ParserArena::identifierArena): Lazily allocate the
+IdentifierArena.
+
+* parser/Nodes.cpp:
+(JSC::ScopeNode::ScopeNode):
+(JSC::ScopeNode::singleStatement):
+(JSC::ProgramNode::create):
+(JSC::EvalNode::create):
+(JSC::FunctionBodyNode::create):
+* parser/Nodes.h:
+(JSC::ScopeNode::destroyData):
+(JSC::ScopeNode::needsActivationForMoreThanVariables):
+(JSC::ScopeNode::needsActivation):
+(JSC::ScopeNode::hasCapturedVariables):
+(JSC::ScopeNode::capturedVariableCount):
+(JSC::ScopeNode::captures):
+(JSC::ScopeNode::varStack):
+(JSC::ScopeNode::functionStack):
+(JSC::ScopeNode::neededConstants):
+(ScopeNode):
+* bytecompiler/NodesCodegen.cpp:
+(JSC::ScopeNode::emitStatementsBytecode): Inline ScopeNodeData
+into ScopeNode. Adapt accessors.
+
2012-03-06 Eric Seidel e...@webkit.org
Make WTF public headers use fully-qualified include paths and remove ForwardingHeaders/wtf
Modified: trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp (110038 => 110039)
--- trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2012-03-07 10:11:47 UTC (rev 110038)
+++ trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp 2012-03-07 10:18:43 UTC (rev 110039)
@@ -2017,8 +2017,8 @@
inline void ScopeNode::emitStatementsBytecode(BytecodeGenerator generator, RegisterID* dst)
{
-if (m_data-m_statements)
-m_data-m_statements-emitBytecode(generator, dst);
+if (m_statements)
+m_statements-emitBytecode(generator, dst);
}
// -- ProgramNode -
Modified: trunk/Source/_javascript_Core/parser/Nodes.cpp (110038 => 110039)
--- trunk/Source/_javascript_Core/parser/Nodes.cpp 2012-03-07 10:11:47 UTC (rev 110038)
+++ trunk/Source/_javascript_Core/parser/Nodes.cpp 2012-03-07 10:18:43 UTC (rev 110039)
@@ -73,41 +73,36 @@
return size == 1 ? m_statements[0] : 0;
}
-// -ScopeNodeData ---
-
-ScopeNodeData::ScopeNodeData(ParserArena arena,
[webkit-changes] [110040] trunk/Source/WebCore
Title: [110040] trunk/Source/WebCore Revision 110040 Author commit-qu...@webkit.org Date 2012-03-07 02:33:01 -0800 (Wed, 07 Mar 2012) Log Message [BlackBerry] Upstream Texture and TextureCache https://bugs.webkit.org/show_bug.cgi?id=80121 Patch by Robin Cao robin@torchmobile.com.cn on 2012-03-07 Reviewed by Rob Buis. Initial upstream, no new tests. * platform/graphics/blackberry/Texture.cpp: Added. (WebCore): (WebCore::copyImageData): (WebCore::Texture::Texture): (WebCore::Texture::~Texture): (WebCore::Texture::updateContents): (WebCore::Texture::setContentsToColor): (WebCore::Texture::protect): * platform/graphics/blackberry/Texture.h: Added. (WebCore): (Texture): (WebCore::Texture::create): (WebCore::Texture::textureId): (WebCore::Texture::isDirty): (WebCore::Texture::hasTexture): (WebCore::Texture::isColor): (WebCore::Texture::isOpaque): (WebCore::Texture::isProtected): (WebCore::Texture::protect): (WebCore::Texture::unprotect): (WebCore::Texture::size): (WebCore::Texture::width): (WebCore::Texture::height): (WebCore::Texture::bytesPerPixel): (WebCore::Texture::setTextureId): * platform/graphics/blackberry/TextureCacheCompositingThread.cpp: Added. (WebCore): (TextureProtector): (WebCore::TextureProtector::TextureProtector): (WebCore::TextureProtector::~TextureProtector): (WebCore::TextureCacheCompositingThread::TextureCacheCompositingThread): (WebCore::TextureCacheCompositingThread::allocateTextureId): (WebCore::TextureCacheCompositingThread::freeTextureId): (WebCore::TextureCacheCompositingThread::collectGarbage): (WebCore::TextureCacheCompositingThread::textureResized): (WebCore::TextureCacheCompositingThread::textureDestroyed): (WebCore::TextureCacheCompositingThread::install): (WebCore::TextureCacheCompositingThread::evict): (WebCore::TextureCacheCompositingThread::textureAccessed): (WebCore::textureCacheCompositingThread): (WebCore::TextureCacheCompositingThread::prune): (WebCore::TextureCacheCompositingThread::clear): (WebCore::TextureCacheCompositingThread::setMemoryUsage): (WebCore::TextureCacheCompositingThread::textureForTiledContents): (WebCore::TextureCacheCompositingThread::textureForColor): (WebCore::TextureCacheCompositingThread::updateContents): (WebCore::TextureCacheCompositingThread::key): * platform/graphics/blackberry/TextureCacheCompositingThread.h: Added. (WebCore): (TextureCacheCompositingThread): (WebCore::TextureCacheCompositingThread::createTexture): (WebCore::TextureCacheCompositingThread::memoryUsage): (WebCore::TextureCacheCompositingThread::memoryLimit): (WebCore::TextureCacheCompositingThread::setMemoryLimit): (WebCore::TextureCacheCompositingThread::prune): (WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture): (ZombieTexture): (WebCore::TextureCacheCompositingThread::incMemoryUsage): (WebCore::TextureCacheCompositingThread::decMemoryUsage): (WebCore::TextureCacheCompositingThread::ColorHash::hash): (WebCore::TextureCacheCompositingThread::ColorHash::equal): (ColorHash): (ColorHashTraits): (WebCore::TextureCacheCompositingThread::ColorHashTraits::constructDeletedValue): (WebCore::TextureCacheCompositingThread::ColorHashTraits::isDeletedValue): Modified Paths trunk/Source/WebCore/ChangeLog Added Paths trunk/Source/WebCore/platform/graphics/blackberry/Texture.cpp trunk/Source/WebCore/platform/graphics/blackberry/Texture.h trunk/Source/WebCore/platform/graphics/blackberry/TextureCacheCompositingThread.cpp trunk/Source/WebCore/platform/graphics/blackberry/TextureCacheCompositingThread.h Diff Modified: trunk/Source/WebCore/ChangeLog (110039 => 110040) --- trunk/Source/WebCore/ChangeLog 2012-03-07 10:18:43 UTC (rev 110039) +++ trunk/Source/WebCore/ChangeLog 2012-03-07 10:33:01 UTC (rev 110040) @@ -1,3 +1,78 @@ +2012-03-07 Robin Cao robin@torchmobile.com.cn + +[BlackBerry] Upstream Texture and TextureCache +https://bugs.webkit.org/show_bug.cgi?id=80121 + +Reviewed by Rob Buis. + +Initial upstream, no new tests. + +* platform/graphics/blackberry/Texture.cpp: Added. +(WebCore): +(WebCore::copyImageData): +(WebCore::Texture::Texture): +(WebCore::Texture::~Texture): +(WebCore::Texture::updateContents): +(WebCore::Texture::setContentsToColor): +(WebCore::Texture::protect): +* platform/graphics/blackberry/Texture.h: Added. +(WebCore): +(Texture): +(WebCore::Texture::create): +(WebCore::Texture::textureId): +(WebCore::Texture::isDirty): +(WebCore::Texture::hasTexture): +(WebCore::Texture::isColor): +(WebCore::Texture::isOpaque): +(WebCore::Texture::isProtected): +(WebCore::Texture::protect): +(WebCore::Texture::unprotect): +(WebCore::Texture::size): +(WebCore::Texture::width): +(WebCore::Texture::height): +(WebCore::Texture::bytesPerPixel): +(WebCore::Texture::setTextureId): +*
[webkit-changes] [110041] trunk/LayoutTests
Title: [110041] trunk/LayoutTests Revision 110041 Author joc...@chromium.org Date 2012-03-07 02:39:56 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed, add editing/execCommand baselines for chromium-mac-lion * platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4580583-1-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4580583-2-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4641880-1-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4641880-2-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4747450-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4916402-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/4916541-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4916541-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/4924441-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4924441-expected.png. * platform/chromium-mac/editing/execCommand/4580583-1-expected.png: * platform/chromium-mac/editing/execCommand/4580583-2-expected.png: * platform/chromium-mac/editing/execCommand/4641880-1-expected.png: * platform/chromium-mac/editing/execCommand/4641880-2-expected.png: * platform/chromium-mac/editing/execCommand/4747450-expected.png: * platform/chromium-mac/editing/execCommand/4916402-expected.png: * platform/chromium-mac/editing/execCommand/4916541-expected.png: * platform/chromium-mac/editing/execCommand/4924441-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4580583-1-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4580583-2-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4641880-1-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4641880-2-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4747450-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4916402-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4916541-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/4924441-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4916541-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/4924441-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (110040 => 110041) --- trunk/LayoutTests/ChangeLog 2012-03-07 10:33:01 UTC (rev 110040) +++ trunk/LayoutTests/ChangeLog 2012-03-07 10:39:56 UTC (rev 110041) @@ -1,3 +1,24 @@ +2012-03-07 Jochen Eisinger joc...@chromium.org + +Unreviewed, add editing/execCommand baselines for chromium-mac-lion + +* platform/chromium-mac-snowleopard/editing/execCommand/4580583-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4580583-1-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/4580583-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4580583-2-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/4641880-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4641880-1-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/4641880-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4641880-2-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/4747450-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4747450-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/4916402-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/4916402-expected.png. +*
[webkit-changes] [110042] trunk/Source/WebCore
Title: [110042] trunk/Source/WebCore Revision 110042 Author mr...@apple.com Date 2012-03-07 02:47:22 -0800 (Wed, 07 Mar 2012) Log Message Fix DerivedSources.make to not assume that WTF and WebCore build in to the same build directory. We can't assume that wtf/Platform.h can be found inside BUILT_PRODUCTS_DIR as that won't be the case if WTF and WebCore are building in to different build directories. We should instead look for wtf/Platform.h in the header search path. Unreviewed due to being a build fix. * DerivedSources.make: Set up the header search path, and invoke the compiler in such a manner that it looks for wtf/Platform.h in that search path. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.make Diff Modified: trunk/Source/WebCore/ChangeLog (110041 => 110042) --- trunk/Source/WebCore/ChangeLog 2012-03-07 10:39:56 UTC (rev 110041) +++ trunk/Source/WebCore/ChangeLog 2012-03-07 10:47:22 UTC (rev 110042) @@ -1,3 +1,16 @@ +2012-03-07 Mark Rowe mr...@apple.com + +Fix DerivedSources.make to not assume that WTF and WebCore build in to the same build directory. + +We can't assume that wtf/Platform.h can be found inside BUILT_PRODUCTS_DIR as +that won't be the case if WTF and WebCore are building in to different build +directories. We should instead look for wtf/Platform.h in the header search path. + +Unreviewed due to being a build fix. + +* DerivedSources.make: Set up the header search path, and invoke the compiler in +such a manner that it looks for wtf/Platform.h in that search path. + 2012-03-07 Robin Cao robin@torchmobile.com.cn [BlackBerry] Upstream Texture and TextureCache Modified: trunk/Source/WebCore/DerivedSources.make (110041 => 110042) --- trunk/Source/WebCore/DerivedSources.make 2012-03-07 10:39:56 UTC (rev 110041) +++ trunk/Source/WebCore/DerivedSources.make 2012-03-07 10:47:22 UTC (rev 110042) @@ -638,16 +638,15 @@ ifeq ($(OS),MACOS) FRAMEWORK_FLAGS = $(shell echo $(BUILT_PRODUCTS_DIR) $(FRAMEWORK_SEARCH_PATHS) | perl -e 'print -F . join( -F , split( , ));') +HEADER_FLAGS = $(shell echo $(BUILT_PRODUCTS_DIR) $(HEADER_SEARCH_PATHS) | perl -e 'print -I . join( -I, split( , ));') -WTF_HEADERS_INCLUDE_PATH=$(BUILT_PRODUCTS_DIR)/usr/local/include - -ifeq ($(shell $(CC) -E -P -dM $(FRAMEWORK_FLAGS) -I$(WTF_HEADERS_INCLUDE_PATH) $(WTF_HEADERS_INCLUDE_PATH)/wtf/Platform.h | grep ENABLE_DASHBOARD_SUPPORT | cut -d' ' -f3), 1) +ifeq ($(shell $(CC) -x c++ -E -P -dM $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include wtf/Platform.h /dev/null | grep ENABLE_DASHBOARD_SUPPORT | cut -d' ' -f3), 1) ENABLE_DASHBOARD_SUPPORT = 1 else ENABLE_DASHBOARD_SUPPORT = 0 endif -ifeq ($(shell $(CC) -E -P -dM $(FRAMEWORK_FLAGS) -I$(WTF_HEADERS_INCLUDE_PATH) $(WTF_HEADERS_INCLUDE_PATH)/wtf/Platform.h | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1) +ifeq ($(shell $(CC) -x c++ -E -P -dM $(FRAMEWORK_FLAGS) $(HEADER_FLAGS) -include wtf/Platform.h /dev/null | grep ENABLE_ORIENTATION_EVENTS | cut -d' ' -f3), 1) ENABLE_ORIENTATION_EVENTS = 1 else ENABLE_ORIENTATION_EVENTS = 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110043] trunk
Title: [110043] trunk
Revision 110043
Author podivi...@chromium.org
Date 2012-03-07 02:50:51 -0800 (Wed, 07 Mar 2012)
Log Message
Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
https://bugs.webkit.org/show_bug.cgi?id=80412
Reviewed by Vsevolod Vlasov.
Source/WebCore:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/ScriptMapping.js:
(WebInspector.ScriptMappingImpl):
(WebInspector.ScriptMappingImpl.prototype.rawLocationToUILocation):
(WebInspector.ScriptMappingImpl.prototype.createLiveLocation):
(WebInspector.ScriptMappingImpl.prototype.uiSourceCodeList):
(WebInspector.ScriptMappingImpl.prototype._handleUISourceCodeListChanged):
(WebInspector.ScriptMappingImpl.prototype._uiSourceCodeListChanged):
(WebInspector.ScriptMappingImpl.prototype._bindScriptToRawSourceCode):
(WebInspector.ScriptMappingImpl.prototype.setFormatSource):
(WebInspector.ScriptMappingImpl.prototype.forceUpdateSourceMapping):
(WebInspector.ScriptMappingImpl.prototype.reset):
LayoutTests:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/callstack-placards-discarded.html:
* inspector/debugger/linkifier.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html
trunk/LayoutTests/inspector/debugger/linkifier.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/BreakpointManager.js
trunk/Source/WebCore/inspector/front-end/DebuggerPresentationModel.js
trunk/Source/WebCore/inspector/front-end/ScriptMapping.js
Diff
Modified: trunk/LayoutTests/ChangeLog (110042 => 110043)
--- trunk/LayoutTests/ChangeLog 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/LayoutTests/ChangeLog 2012-03-07 10:50:51 UTC (rev 110043)
@@ -1,3 +1,14 @@
+2012-03-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
+https://bugs.webkit.org/show_bug.cgi?id=80412
+
+Reviewed by Vsevolod Vlasov.
+
+* inspector/debugger/breakpoint-manager.html:
+* inspector/debugger/callstack-placards-discarded.html:
+* inspector/debugger/linkifier.html:
+
2012-03-07 Jochen Eisinger joc...@chromium.org
Unreviewed, add editing/execCommand baselines for chromium-mac-lion
Modified: trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html (110042 => 110043)
--- trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/LayoutTests/inspector/debugger/callstack-placards-discarded.html 2012-03-07 10:50:51 UTC (rev 110043)
@@ -21,7 +21,7 @@
InspectorTest.addResult(Received DebuggerPaused event.);
var callFrame = event.data.callFrames[0];
InspectorTest.addResult(Function name: + callFrame._callFrame.functionName);
-var rawSourceCode = WebInspector.debuggerPresentationModel._rawSourceCodeForScriptId[callFrame._callFrame.location.scriptId];
+var rawSourceCode = WebInspector.debuggerPresentationModel._scriptMapping._rawSourceCodeForScriptId[callFrame._callFrame.location.scriptId];
var listeners = rawSourceCode._listeners[WebInspector.RawSourceCode.Events.UISourceCodeListChanged];
InspectorTest.addResult(Listeners length: + listeners.length);
if (previousListenerLength !== undefined listeners.length !== previousListenerLength)
Modified: trunk/LayoutTests/inspector/debugger/linkifier.html (110042 => 110043)
--- trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/LayoutTests/inspector/debugger/linkifier.html 2012-03-07 10:50:51 UTC (rev 110043)
@@ -34,7 +34,7 @@
function debuggerTest()
{
linkifier = WebInspector.debuggerPresentationModel.createLinkifier();
-rawSourceCode = WebInspector.debuggerPresentationModel._rawSourceCodeForURL[WebInspector.inspectedPageURL];
+rawSourceCode = WebInspector.debuggerPresentationModel._scriptMapping._rawSourceCodeForURL[WebInspector.inspectedPageURL];
var count1 = listenersCount(rawSourceCode);
link = linkifier.linkifyLocation(WebInspector.inspectedPageURL, 20, 0, dummy-class);
Modified: trunk/Source/WebCore/ChangeLog (110042 => 110043)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 10:47:22 UTC (rev 110042)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 10:50:51 UTC (rev 110043)
@@ -1,3 +1,25 @@
+2012-03-06 Pavel Podivilov podivi...@chromium.org
+
+Web Inspector: extract source mapping logic from DebuggerPresentationModel to ScriptMappingImpl.
+https://bugs.webkit.org/show_bug.cgi?id=80412
+
+Reviewed by Vsevolod Vlasov.
+
+* WebCore.gypi:
+* WebCore.vcproj/WebCore.vcproj:
+* inspector/compile-front-end.sh:
+*
[webkit-changes] [110044] trunk/Source/JavaScriptCore
Title: [110044] trunk/Source/_javascript_Core
Revision 110044
Author hausm...@webkit.org
Date 2012-03-07 03:30:29 -0800 (Wed, 07 Mar 2012)
Log Message
ARM build fix.
Reviewed by Zoltan Herczeg.
Implement three-argument branch(Add,Sub)32.
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::branchSub32):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (110043 => 110044)
--- trunk/Source/_javascript_Core/ChangeLog 2012-03-07 10:50:51 UTC (rev 110043)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-03-07 11:30:29 UTC (rev 110044)
@@ -1,3 +1,18 @@
+2012-03-07 Simon Hausmann simon.hausm...@nokia.com
+
+ARM build fix.
+
+Reviewed by Zoltan Herczeg.
+
+Implement three-argument branch(Add,Sub)32.
+
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::add32):
+(MacroAssemblerARM):
+(JSC::MacroAssemblerARM::sub32):
+(JSC::MacroAssemblerARM::branchAdd32):
+(JSC::MacroAssemblerARM::branchSub32):
+
2012-03-07 Andy Wingo wi...@igalia.com
Parser: Inline ScopeNodeData into ScopeNode
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (110043 => 110044)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-03-07 10:50:51 UTC (rev 110043)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h 2012-03-07 11:30:29 UTC (rev 110044)
@@ -108,6 +108,11 @@
add32(ARMRegisters::S1, dest);
}
+void add32(RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+m_assembler.adds_r(dest, src, m_assembler.getImm(imm.m_value, ARMRegisters::S0));
+}
+
void and32(RegisterID src, RegisterID dest)
{
m_assembler.ands_r(dest, dest, src);
@@ -236,6 +241,11 @@
sub32(ARMRegisters::S1, dest);
}
+void sub32(RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+m_assembler.subs_r(dest, src, m_assembler.getImm(imm.m_value, ARMRegisters::S0));
+}
+
void xor32(RegisterID src, RegisterID dest)
{
m_assembler.eors_r(dest, dest, src);
@@ -554,6 +564,13 @@
return Jump(m_assembler.jmp(ARMCondition(cond)));
}
+Jump branchAdd32(ResultCondition cond, RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+add32(src, imm, dest);
+return Jump(m_assembler.jmp(ARMCondition(cond)));
+}
+
void mull32(RegisterID src1, RegisterID src2, RegisterID dest)
{
if (src1 == dest) {
@@ -603,6 +620,13 @@
return Jump(m_assembler.jmp(ARMCondition(cond)));
}
+Jump branchSub32(ResultCondition cond, RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
+sub32(src, imm, dest);
+return Jump(m_assembler.jmp(ARMCondition(cond)));
+}
+
Jump branchNeg32(ResultCondition cond, RegisterID srcDest)
{
ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110046] trunk/Source/WebKit2
Title: [110046] trunk/Source/WebKit2 Revision 110046 Author abe...@webkit.org Date 2012-03-07 04:04:01 -0800 (Wed, 07 Mar 2012) Log Message [WK2] Make it possible to build without geolocation support https://bugs.webkit.org/show_bug.cgi?id=80426 Reviewed by Simon Hausmann. Add missing guards. * UIProcess/GeolocationPermissionRequestManagerProxy.cpp: (WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision): * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::close): (WebKit::WebPageProxy::processDidCrash): * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::WebPage): (WebKit): * WebProcess/WebPage/WebPage.h: (WebPage): * WebProcess/WebPage/WebPage.messages.in: Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp trunk/Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in Diff Modified: trunk/Source/WebKit2/ChangeLog (110045 => 110046) --- trunk/Source/WebKit2/ChangeLog 2012-03-07 11:54:19 UTC (rev 110045) +++ trunk/Source/WebKit2/ChangeLog 2012-03-07 12:04:01 UTC (rev 110046) @@ -1,3 +1,25 @@ +2012-03-07 Andras Becsi andras.be...@nokia.com + +[WK2] Make it possible to build without geolocation support +https://bugs.webkit.org/show_bug.cgi?id=80426 + +Reviewed by Simon Hausmann. + +Add missing guards. + +* UIProcess/GeolocationPermissionRequestManagerProxy.cpp: +(WebKit::GeolocationPermissionRequestManagerProxy::didReceiveGeolocationPermissionDecision): +* UIProcess/WebPageProxy.cpp: +(WebKit::WebPageProxy::close): +(WebKit::WebPageProxy::processDidCrash): +* WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp: +* WebProcess/WebPage/WebPage.cpp: +(WebKit::WebPage::WebPage): +(WebKit): +* WebProcess/WebPage/WebPage.h: +(WebPage): +* WebProcess/WebPage/WebPage.messages.in: + 2012-03-06 Raphael Kubo da Costa k...@profusion.mobi [CMake] Make the removal of transitive library dependencies work with CMake 2.8.7. Modified: trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp (110045 => 110046) --- trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp 2012-03-07 11:54:19 UTC (rev 110045) +++ trunk/Source/WebKit2/UIProcess/GeolocationPermissionRequestManagerProxy.cpp 2012-03-07 12:04:01 UTC (rev 110046) @@ -63,7 +63,10 @@ if (it == m_pendingRequests.end()) return; +#if ENABLE(GEOLOCATION) m_page-process()-send(Messages::WebPage::DidReceiveGeolocationPermissionDecision(geolocationID, allowed), m_page-pageID()); +#endif + m_pendingRequests.remove(it); } Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (110045 => 110046) --- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-03-07 11:54:19 UTC (rev 110045) +++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp 2012-03-07 12:04:01 UTC (rev 110046) @@ -374,7 +374,10 @@ m_openPanelResultListener = 0; } +#if ENABLE(GEOLOCATION) m_geolocationPermissionRequestManager.invalidateRequests(); +#endif + m_notificationPermissionRequestManager.invalidateRequests(); m_toolTip = String(); @@ -3248,7 +3251,10 @@ m_openPanelResultListener = nullptr; } +#if ENABLE(GEOLOCATION) m_geolocationPermissionRequestManager.invalidateRequests(); +#endif + m_notificationPermissionRequestManager.invalidateRequests(); m_toolTip = String(); Modified: trunk/Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp (110045 => 110046) --- trunk/Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp 2012-03-07 11:54:19 UTC (rev 110045) +++ trunk/Source/WebKit2/WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp 2012-03-07 12:04:01 UTC (rev 110046) @@ -26,6 +26,8 @@ #include config.h #include GeolocationPermissionRequestManager.h +#if ENABLE(GEOLOCATION) + #include WebCoreArgumentCoders.h #include WebFrame.h #include WebPage.h @@ -89,3 +91,5 @@ } } // namespace WebKit + +#endif // ENABLE(GEOLOCATION) Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp (110045 => 110046) --- trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-03-07 11:54:19 UTC (rev 110045) +++ trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp 2012-03-07 12:04:01 UTC (rev 110046) @@ -199,7 +199,9 @@ #if PLATFORM(QT) , m_tapHighlightController(this) #endif +#if ENABLE(GEOLOCATION) , m_geolocationPermissionRequestManager(this) +#endif , m_pageID(pageID) ,
[webkit-changes] [110049] trunk/LayoutTests
Title: [110049] trunk/LayoutTests Revision 110049 Author joc...@chromium.org Date 2012-03-07 05:32:58 -0800 (Wed, 07 Mar 2012) Log Message Unreviewd, more editing/execCommand baselines for chromium-mac-lion * platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5080333-1-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5080333-2-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5136770-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5138441-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5142012-1-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/5142012-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5142012-2-expected.png. * platform/chromium-mac-snowleopard/editing/execCommand/5190926-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5190926-expected.png. * platform/chromium-mac/editing/execCommand/5080333-1-expected.png: * platform/chromium-mac/editing/execCommand/5080333-2-expected.png: * platform/chromium-mac/editing/execCommand/5136770-expected.png: * platform/chromium-mac/editing/execCommand/5138441-expected.png: * platform/chromium-mac/editing/execCommand/5142012-1-expected.png: * platform/chromium-mac/editing/execCommand/5142012-2-expected.png: * platform/chromium-mac/editing/execCommand/5190926-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-mac/editing/execCommand/5080333-1-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/5080333-2-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/5136770-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/5138441-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/5142012-1-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/5142012-2-expected.png trunk/LayoutTests/platform/chromium-mac/editing/execCommand/5190926-expected.png Added Paths trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/5142012-2-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/editing/execCommand/5190926-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (110048 => 110049) --- trunk/LayoutTests/ChangeLog 2012-03-07 13:30:47 UTC (rev 110048) +++ trunk/LayoutTests/ChangeLog 2012-03-07 13:32:58 UTC (rev 110049) @@ -1,3 +1,22 @@ +2012-03-07 Jochen Eisinger joc...@chromium.org + +Unreviewd, more editing/execCommand baselines for chromium-mac-lion + +* platform/chromium-mac-snowleopard/editing/execCommand/5080333-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5080333-1-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/5080333-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5080333-2-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/5136770-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5136770-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/5138441-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5138441-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/5142012-1-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5142012-1-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/5142012-2-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5142012-2-expected.png. +* platform/chromium-mac-snowleopard/editing/execCommand/5190926-expected.png: Copied from LayoutTests/platform/chromium-mac/editing/execCommand/5190926-expected.png. +* platform/chromium-mac/editing/execCommand/5080333-1-expected.png: +* platform/chromium-mac/editing/execCommand/5080333-2-expected.png: +* platform/chromium-mac/editing/execCommand/5136770-expected.png: +*
[webkit-changes] [110050] trunk
Title: [110050] trunk
Revision 110050
Author hausm...@webkit.org
Date 2012-03-07 05:53:28 -0800 (Wed, 07 Mar 2012)
Log Message
[Qt] Fix compilation without QtQuick1 https://bugs.webkit.org/show_bug.cgi?id=80503
Reviewed by Tor Arne Vestbø.
.:
* Source/tests.pri: Compile qml1 tests only with Qt 4 for the moment.
Source/WebKit/qt:
Compile and enable the QtQuick1/QML1 plugin and webview
only if we're using Qt 4 at the moment. QQuick1 clashes
with QQuick2 right now because both declare QDeclarativeEngine
and friends as classes.
* declarative/plugin.cpp:
(WebKitQmlPlugin::registerTypes):
* declarative/public.pri:
* tests/tests.pri:
Tools:
Introduce HAVE_QQUICK1 as feature and added haveQtModule
as convenience function.
* qmake/mkspecs/features/features.prf:
* qmake/mkspecs/features/functions.prf:
Modified Paths
trunk/ChangeLog
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit/qt/declarative/plugin.cpp
trunk/Source/WebKit/qt/declarative/public.pri
trunk/Source/WebKit/qt/tests/tests.pri
trunk/Source/tests.pri
trunk/Tools/ChangeLog
trunk/Tools/qmake/mkspecs/features/features.prf
trunk/Tools/qmake/mkspecs/features/functions.prf
Diff
Modified: trunk/ChangeLog (110049 => 110050)
--- trunk/ChangeLog 2012-03-07 13:32:58 UTC (rev 110049)
+++ trunk/ChangeLog 2012-03-07 13:53:28 UTC (rev 110050)
@@ -1,3 +1,12 @@
+2012-03-07 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Fix compilation without QtQuick1
+https://bugs.webkit.org/show_bug.cgi?id=80503
+
+Reviewed by Tor Arne Vestbø.
+
+* Source/tests.pri: Compile qml1 tests only with Qt 4 for the moment.
+
2012-03-07 Mark Rowe mr...@apple.com
Teach make to build WTF.
Modified: trunk/Source/WebKit/qt/ChangeLog (110049 => 110050)
--- trunk/Source/WebKit/qt/ChangeLog 2012-03-07 13:32:58 UTC (rev 110049)
+++ trunk/Source/WebKit/qt/ChangeLog 2012-03-07 13:53:28 UTC (rev 110050)
@@ -1,3 +1,20 @@
+2012-03-07 Simon Hausmann simon.hausm...@nokia.com
+
+[Qt] Fix compilation without QtQuick1
+https://bugs.webkit.org/show_bug.cgi?id=80503
+
+Reviewed by Tor Arne Vestbø.
+
+Compile and enable the QtQuick1/QML1 plugin and webview
+only if we're using Qt 4 at the moment. QQuick1 clashes
+with QQuick2 right now because both declare QDeclarativeEngine
+and friends as classes.
+
+* declarative/plugin.cpp:
+(WebKitQmlPlugin::registerTypes):
+* declarative/public.pri:
+* tests/tests.pri:
+
2012-03-07 Kangil Han kangil@samsung.com
[DRT] Remove PlainTextController implementations.
Modified: trunk/Source/WebKit/qt/declarative/plugin.cpp (110049 => 110050)
--- trunk/Source/WebKit/qt/declarative/plugin.cpp 2012-03-07 13:32:58 UTC (rev 110049)
+++ trunk/Source/WebKit/qt/declarative/plugin.cpp 2012-03-07 13:53:28 UTC (rev 110050)
@@ -17,7 +17,9 @@
Boston, MA 02110-1301, USA.
*/
+#if defined(HAVE_QQUICK1)
#include qdeclarativewebview_p.h
+#endif
#include QtDeclarative/qdeclarative.h
#include QtDeclarative/qdeclarativeextensionplugin.h
@@ -49,6 +51,7 @@
virtual void registerTypes(const char* uri)
{
Q_ASSERT(QLatin1String(uri) == QLatin1String(QtWebKit));
+#if defined(HAVE_QQUICK1)
qmlRegisterTypeQDeclarativeWebSettings();
qmlRegisterTypeQDeclarativeWebView(uri, 1, 0, WebView);
#ifdef Q_REVISION
@@ -56,6 +59,7 @@
qmlRegisterRevisionQDeclarativeWebView, 0(QtWebKit, 1, 0);
qmlRegisterRevisionQDeclarativeWebView, 1(QtWebKit, 1, 1);
#endif
+#endif
#if defined(HAVE_WEBKIT2)
qmlRegisterTypeQQuickWebView(uri, 3, 0, WebView);
Modified: trunk/Source/WebKit/qt/declarative/public.pri (110049 => 110050)
--- trunk/Source/WebKit/qt/declarative/public.pri 2012-03-07 13:32:58 UTC (rev 110049)
+++ trunk/Source/WebKit/qt/declarative/public.pri 2012-03-07 13:53:28 UTC (rev 110050)
@@ -27,8 +27,13 @@
CONFIG += qtwebkit qtwebkit-private
QT += declarative
-haveQt(5): QT += widgets quick quick1
+haveQt(5): QT += widgets quick
+contains(DEFINES, HAVE_QQUICK1=1) {
+SOURCES += qdeclarativewebview.cpp
+HEADERS += qdeclarativewebview_p.h
+}
+
DESTDIR = $${ROOT_BUILD_DIR}/imports/$${TARGET.module_name}
CONFIG += rpath
@@ -40,8 +45,7 @@
../../../_javascript_Core/runtime \
../../../_javascript_Core/wtf
-SOURCES += qdeclarativewebview.cpp plugin.cpp
-HEADERS += qdeclarativewebview_p.h
+SOURCES += plugin.cpp
!no_webkit2: {
DEFINES += HAVE_WEBKIT2
Modified: trunk/Source/WebKit/qt/tests/tests.pri (110049 => 110050)
--- trunk/Source/WebKit/qt/tests/tests.pri 2012-03-07 13:32:58 UTC (rev 110049)
+++ trunk/Source/WebKit/qt/tests/tests.pri 2012-03-07 13:53:28 UTC (rev 110050)
@@ -21,11 +21,7 @@
CONFIG += qtwebkit
-haveQt(5) {
-QT += declarative quick1
-} else {
-contains(QT_CONFIG, declarative): QT += declarative
-}
+haveQt(4): haveQtModule(declarative): QT += declarative
# This define is used by some tests to
[webkit-changes] [110051] trunk/LayoutTests
Title: [110051] trunk/LayoutTests Revision 110051 Author senorbla...@chromium.org Date 2012-03-07 06:05:27 -0800 (Wed, 07 Mar 2012) Log Message [chromium] Mark rtl-scrollbar.html as flaky. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110050 => 110051) --- trunk/LayoutTests/ChangeLog 2012-03-07 13:53:28 UTC (rev 110050) +++ trunk/LayoutTests/ChangeLog 2012-03-07 14:05:27 UTC (rev 110051) @@ -1,3 +1,11 @@ +2012-03-07 Stephen White senorbla...@chromium.org + +[chromium] Mark rtl-scrollbar.html as flaky. + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2012-03-07 Jochen Eisinger joc...@chromium.org Unreviewd, more editing/execCommand baselines for chromium-mac-lion Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110050 => 110051) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 13:53:28 UTC (rev 110050) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 14:05:27 UTC (rev 110051) @@ -4167,3 +4167,6 @@ // worker-multi-startup.html is flaky on win BUGWK80498 WIN : fast/workers/worker-multi-startup.html = CRASH PASS + +// flaky +BUGSENORBLANCO : platform/chromium/fast/events/rtl-scrollbar.html = TEXT PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110052] trunk
Title: [110052] trunk Revision 110052 Author commit-qu...@webkit.org Date 2012-03-07 06:07:47 -0800 (Wed, 07 Mar 2012) Log Message Source/WebCore: HTMLTrackElement.idl doesn't have default attribute. https://bugs.webkit.org/show_bug.cgi?id=80116 Patch by Arun Patole bmf...@motorola.com on 2012-03-07 Reviewed by Kentaro Hara. Renamed isDefault to 'default' so that in JS, it will be track.default instead of track.isDefault. * html/HTMLTrackElement.idl: LayoutTests: HTMLTrackElement.idl doesn't have default attribute. https://bugs.webkit.org/show_bug.cgi?id=80116 Patch by Arun Patole bmf...@motorola.com on 2012-03-07 Reviewed by Kentaro Hara. Make sure 'default' IDL attribute reflects the content attribute of the same name. * media/track/track-default-attribute-expected.txt: * media/track/track-default-attribute.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/media/track/track-default-attribute-expected.txt trunk/LayoutTests/media/track/track-default-attribute.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLTrackElement.idl Diff Modified: trunk/LayoutTests/ChangeLog (110051 => 110052) --- trunk/LayoutTests/ChangeLog 2012-03-07 14:05:27 UTC (rev 110051) +++ trunk/LayoutTests/ChangeLog 2012-03-07 14:07:47 UTC (rev 110052) @@ -1,3 +1,14 @@ +2012-03-07 Arun Patole bmf...@motorola.com + +HTMLTrackElement.idl doesn't have default attribute. +https://bugs.webkit.org/show_bug.cgi?id=80116 + +Reviewed by Kentaro Hara. + +Make sure 'default' IDL attribute reflects the content attribute of the same name. +* media/track/track-default-attribute-expected.txt: +* media/track/track-default-attribute.html: + 2012-03-07 Stephen White senorbla...@chromium.org [chromium] Mark rtl-scrollbar.html as flaky. Modified: trunk/LayoutTests/media/track/track-default-attribute-expected.txt (110051 => 110052) --- trunk/LayoutTests/media/track/track-default-attribute-expected.txt 2012-03-07 14:05:27 UTC (rev 110051) +++ trunk/LayoutTests/media/track/track-default-attribute-expected.txt 2012-03-07 14:07:47 UTC (rev 110052) @@ -3,6 +3,7 @@ EVENT(load) EXPECTED (event.target.readyState == '2') OK EXPECTED (event.target.id == 'default') OK +EXPECTED (event.target.default == 'true') OK END OF TEST Modified: trunk/LayoutTests/media/track/track-default-attribute.html (110051 => 110052) --- trunk/LayoutTests/media/track/track-default-attribute.html 2012-03-07 14:05:27 UTC (rev 110051) +++ trunk/LayoutTests/media/track/track-default-attribute.html 2012-03-07 14:07:47 UTC (rev 110052) @@ -12,6 +12,7 @@ consoleWrite(EVENT(load)); testExpected(event.target.readyState, HTMLTrackElement.LOADED); testExpected(event.target.id, default); +testExpected(event.target.default, true); consoleWrite(); // End the test after a brief pause so we allow other tracks to load if they will. Modified: trunk/Source/WebCore/ChangeLog (110051 => 110052) --- trunk/Source/WebCore/ChangeLog 2012-03-07 14:05:27 UTC (rev 110051) +++ trunk/Source/WebCore/ChangeLog 2012-03-07 14:07:47 UTC (rev 110052) @@ -1,3 +1,13 @@ +2012-03-07 Arun Patole bmf...@motorola.com + +HTMLTrackElement.idl doesn't have default attribute. +https://bugs.webkit.org/show_bug.cgi?id=80116 + +Reviewed by Kentaro Hara. + +Renamed isDefault to 'default' so that in JS, it will be track.default instead of track.isDefault. +* html/HTMLTrackElement.idl: + 2012-03-07 Zoltan Horvath zol...@webkit.org [Qt] Add qmake config tests for JPEG and PNG library Modified: trunk/Source/WebCore/html/HTMLTrackElement.idl (110051 => 110052) --- trunk/Source/WebCore/html/HTMLTrackElement.idl 2012-03-07 14:05:27 UTC (rev 110051) +++ trunk/Source/WebCore/html/HTMLTrackElement.idl 2012-03-07 14:07:47 UTC (rev 110052) @@ -32,7 +32,7 @@ attribute DOMString kind; attribute DOMString srclang; attribute DOMString label; -attribute [Reflect=default] boolean isDefault; +attribute [Reflect] boolean default; const unsigned short NONE = 0; const unsigned short LOADING = 1; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110053] trunk/LayoutTests
Title: [110053] trunk/LayoutTests Revision 110053 Author senorbla...@chromium.org Date 2012-03-07 07:16:01 -0800 (Wed, 07 Mar 2012) Log Message [chromium] Marking file-writer-events.html as flaky-crashing on Win. Unreviewed gardening. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110052 => 110053) --- trunk/LayoutTests/ChangeLog 2012-03-07 14:07:47 UTC (rev 110052) +++ trunk/LayoutTests/ChangeLog 2012-03-07 15:16:01 UTC (rev 110053) @@ -1,3 +1,11 @@ +2012-03-07 Stephen White senorbla...@chromium.org + +[chromium] Marking file-writer-events.html as flaky-crashing on Win. + +Unreviewed gardening. + +* platform/chromium/test_expectations.txt: + 2012-03-07 Arun Patole bmf...@motorola.com HTMLTrackElement.idl doesn't have default attribute. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110052 => 110053) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 14:07:47 UTC (rev 110052) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 15:16:01 UTC (rev 110053) @@ -207,7 +207,7 @@ BUGWK74459 SKIP : fast/workers/worker-messageport.html = CRASH BUGWK74459 SKIP : fast/workers/worker-multi-port.html = CRASH -BUGCR108798 LINUX : fast/filesystem/workers/file-writer-events.html = CRASH PASS +BUGCR108798 LINUX WIN : fast/filesystem/workers/file-writer-events.html = CRASH PASS // Page Cache - based tests. Chromium disables page cache because the WebKit page cache keeps previously // loaded pages alive in memory to be able to quickly substitute them when user clicks History buttons. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110054] trunk/Tools
Title: [110054] trunk/Tools
Revision 110054
Author hausm...@webkit.org
Date 2012-03-07 07:46:58 -0800 (Wed, 07 Mar 2012)
Log Message
[Qt] Windows build fix.
Reviewed by Tor Arne Vestbø.
Pass the -j parameter only to make, not nmake.
* Scripts/webkitdirs.pm:
(buildQMakeProjects):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (110053 => 110054)
--- trunk/Tools/ChangeLog 2012-03-07 15:16:01 UTC (rev 110053)
+++ trunk/Tools/ChangeLog 2012-03-07 15:46:58 UTC (rev 110054)
@@ -1,5 +1,16 @@
2012-03-07 Simon Hausmann simon.hausm...@nokia.com
+[Qt] Windows build fix.
+
+Reviewed by Tor Arne Vestbø.
+
+Pass the -j parameter only to make, not nmake.
+
+* Scripts/webkitdirs.pm:
+(buildQMakeProjects):
+
+2012-03-07 Simon Hausmann simon.hausm...@nokia.com
+
[Qt] Fix compilation without QtQuick1
https://bugs.webkit.org/show_bug.cgi?id=80503
Modified: trunk/Tools/Scripts/webkitdirs.pm (110053 => 110054)
--- trunk/Tools/Scripts/webkitdirs.pm 2012-03-07 15:16:01 UTC (rev 110053)
+++ trunk/Tools/Scripts/webkitdirs.pm 2012-03-07 15:46:58 UTC (rev 110054)
@@ -2065,6 +2065,7 @@
my @buildArgs = ();
+my $make = qtMakeCommand($qmakebin);
my $makeargs = ;
my $installHeaders;
my $installLibs;
@@ -2086,7 +2087,7 @@
}
# Automatically determine the number of CPUs for make only if this make argument haven't already been specified.
-if ($makeargs !~ /-j\s*\d+/i (!defined $ENV{MAKEFLAGS} || ($ENV{MAKEFLAGS} !~ /-j\s*\d+/i ))) {
+if ($make eq make $makeargs !~ /-j\s*\d+/i (!defined $ENV{MAKEFLAGS} || ($ENV{MAKEFLAGS} !~ /-j\s*\d+/i ))) {
$makeargs .= -j . numberOfCPUs();
}
@@ -2098,7 +2099,6 @@
$qmakecommand = QMAKEPATH=$qmakepath $qmakebin;
}
-my $make = qtMakeCommand($qmakebin);
my $config = configuration();
push @buildArgs, INSTALL_HEADERS= . $installHeaders if defined($installHeaders);
push @buildArgs, INSTALL_LIBS= . $installLibs if defined($installLibs);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110055] trunk/Source/WebCore
Title: [110055] trunk/Source/WebCore Revision 110055 Author commit-qu...@webkit.org Date 2012-03-07 08:29:37 -0800 (Wed, 07 Mar 2012) Log Message [Forms] Introduce LabelableElement to share labels attribute implementation https://bugs.webkit.org/show_bug.cgi?id=80392 Patch by Yoshifumi Inoue yo...@chromium.org on 2012-03-07 Reviewed by Kent Tamura. This patch introduces new class LabelableElement as base class of HTMLFormControlElement for sharing implementation of labels attribute among form-associate elements, meter element, and progress element. This patch allows us to change base class of HTMLMeterElement and HTMLProgressElement dervied from HTMLFormControlElement to HTMLElement for remove them from HTMLFormElement::m_associatedFormElements where we don't need to put meter and progress elements(bug 80381.) This patch also changes implementation of isLabelable using virtual method rather than sequence of hasTagName for execution speed and better readability. No new tests are required. No behavior changes. * CMakeLists.txt: Add LabelableElement.cpp and .h * GNUmakefile.list.am: Add LabelableElement.cpp and .h * Target.pri: Add LabelableElement.cpp and .h * WebCore.gypi: Add LabelableElement.cpp and .h * WebCore.vcproj/WebCore.vcproj: Add LabelableElement.cpp and .h * WebCore.xcodeproj/project.pbxproj: Add LabelableElement.cpp and .h * html/HTMLButtonElement.h: Implement isLabelable. * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElement::HTMLFormControlElement): Change direct base class. * html/HTMLFormControlElement.h: (HTMLFormControlElement): Change direct base class. * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::isLabelable): Removed to use virtual method instead of hasTagName. (WebCore): * html/HTMLInputElement.h: Declaration of isLabelable. * html/HTMLKeygenElement.h: Implement isLabelable. * html/HTMLMeterElement.h: Implement isLabelable. * html/HTMLProgressElement.h: Implement isLabelable. * html/HTMLSelectElement.h: Implement isLabelable. * html/HTMLTextAreaElement.h: Implement isLabelable. * html/LabelableElement.cpp: Added. (WebCore): (WebCore::LabelableElement::LabelableElement): (WebCore::LabelableElement::~LabelableElement): (WebCore::LabelableElement::labels): Moved from HTMLFormControlElement. * html/LabelableElement.h: Added. (WebCore): (LabelableElement): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/html/HTMLButtonElement.h trunk/Source/WebCore/html/HTMLFormControlElement.cpp trunk/Source/WebCore/html/HTMLFormControlElement.h trunk/Source/WebCore/html/HTMLInputElement.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/HTMLKeygenElement.h trunk/Source/WebCore/html/HTMLMeterElement.h trunk/Source/WebCore/html/HTMLProgressElement.h trunk/Source/WebCore/html/HTMLSelectElement.h trunk/Source/WebCore/html/HTMLTextAreaElement.h Added Paths trunk/Source/WebCore/html/LabelableElement.cpp trunk/Source/WebCore/html/LabelableElement.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (110054 => 110055) --- trunk/Source/WebCore/CMakeLists.txt 2012-03-07 15:46:58 UTC (rev 110054) +++ trunk/Source/WebCore/CMakeLists.txt 2012-03-07 16:29:37 UTC (rev 110055) @@ -829,6 +829,7 @@ html/ImageDocument.cpp html/ImageInputType.cpp html/InputType.cpp +html/LabelableElement.cpp html/LabelsNodeList.cpp html/LinkRelAttribute.cpp html/MediaController.cpp Modified: trunk/Source/WebCore/ChangeLog (110054 => 110055) --- trunk/Source/WebCore/ChangeLog 2012-03-07 15:46:58 UTC (rev 110054) +++ trunk/Source/WebCore/ChangeLog 2012-03-07 16:29:37 UTC (rev 110055) @@ -1,3 +1,55 @@ +2012-03-07 Yoshifumi Inoue yo...@chromium.org + +[Forms] Introduce LabelableElement to share labels attribute implementation +https://bugs.webkit.org/show_bug.cgi?id=80392 + +Reviewed by Kent Tamura. + +This patch introduces new class LabelableElement as base class of +HTMLFormControlElement for sharing implementation of labels +attribute among form-associate elements, meter element, and +progress element. + +This patch allows us to change base class of HTMLMeterElement and +HTMLProgressElement dervied from HTMLFormControlElement to +HTMLElement for remove them from HTMLFormElement::m_associatedFormElements +where we don't need to put meter and progress elements(bug 80381.) + +This patch also changes implementation of isLabelable using virtual +method rather than sequence of hasTagName for execution speed and +better readability. + +No new tests are required. No behavior changes. + +* CMakeLists.txt: Add LabelableElement.cpp and .h +
[webkit-changes] [110056] trunk/Source
Title: [110056] trunk/Source
Revision 110056
Author commit-qu...@webkit.org
Date 2012-03-07 08:35:28 -0800 (Wed, 07 Mar 2012)
Log Message
[Chromium] Remove use_skia option from GYP
https://bugs.webkit.org/show_bug.cgi?id=75811
Patch by Elliot Poger epo...@google.com on 2012-03-07
Reviewed by Tony Chang.
Source/WebCore:
* WebCore.gyp/WebCore.gyp:
Source/WebKit/chromium:
* WebKit.gyp:
* WebKit.gypi:
* features.gypi:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.gyp/WebCore.gyp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/WebKit.gyp
trunk/Source/WebKit/chromium/WebKit.gypi
trunk/Source/WebKit/chromium/features.gypi
Diff
Modified: trunk/Source/WebCore/ChangeLog (110055 => 110056)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 16:29:37 UTC (rev 110055)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 16:35:28 UTC (rev 110056)
@@ -1,3 +1,12 @@
+2012-03-07 Elliot Poger epo...@google.com
+
+[Chromium] Remove use_skia option from GYP
+https://bugs.webkit.org/show_bug.cgi?id=75811
+
+Reviewed by Tony Chang.
+
+* WebCore.gyp/WebCore.gyp:
+
2012-03-07 Yoshifumi Inoue yo...@chromium.org
[Forms] Introduce LabelableElement to share labels attribute implementation
Modified: trunk/Source/WebCore/WebCore.gyp/WebCore.gyp (110055 => 110056)
--- trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-03-07 16:29:37 UTC (rev 110055)
+++ trunk/Source/WebCore/WebCore.gyp/WebCore.gyp 2012-03-07 16:35:28 UTC (rev 110056)
@@ -193,18 +193,6 @@
'@(webcore_svg_bindings_idl_files)',
],
}],
- ['OS==mac and use_skia==0', {
-'webcore_include_dirs+': [
- # platform/graphics/cg and cocoa need to come before
- # platform/graphics/chromium so that the Mac build picks up the
- # version of ImageBufferData.h in the cg directory and
- # FontPlatformData.h in the cocoa directory. The + prepends this
- # directory to the list.
- # FIXME: This shouldn't need to be prepended.
- '../platform/graphics/cocoa',
- '../platform/graphics/cg',
-],
- }],
['OS==mac', {
'webcore_include_dirs': [
# FIXME: Eliminate dependency on platform/mac and related
@@ -214,17 +202,13 @@
# platform/graphics/cg may need to stick around, though.
'../platform/audio/mac',
'../platform/cocoa',
+ '../platform/graphics/cg',
+ '../platform/graphics/cocoa',
'../platform/graphics/mac',
'../platform/mac',
'../platform/text/mac',
],
}],
- ['OS==mac and use_skia==1', {
-'webcore_include_dirs': [
- '../platform/graphics/cocoa',
- '../platform/graphics/cg',
-],
- }],
['OS==win', {
'webcore_include_dirs': [
'../page/win',
@@ -1518,15 +1502,6 @@
['include', 'platform/graphics/opentype/OpenTypeSanitizer\\.cpp$'],
],
}],
-['OS==mac and use_skia==0', {
- 'sources/': [
-# The Mac build is PLATFORM_CG too. platform/graphics/cg is the
-# only place that CG files we want to build are located, and not
-# all of them even have a CG suffix, so just add them by a
-# regexp matching their directory.
-['include', 'platform/graphics/cg/[^/]*(?!Win)?\\.(cpp|mm?)$'],
- ],
-}],
['OS==mac', {
# Necessary for Mac .mm stuff.
'include_dirs': [
@@ -1623,30 +1598,8 @@
['exclude', 'platform/graphics/FontPlatformData\\.cpp$'],
],
}],
-['OS==mac and use_skia==0', {
+['OS==mac', {
'sources/': [
-# Cherry-pick some files that can't be included by broader regexps.
-# Some of these are used instead of Chromium platform files, see
-# the specific exclusions in the exclude list below.
-['include', 'platform/graphics/mac/GraphicsContextMac\\.mm$'],
-
-# Chromium Mac does not use skia.
-['exclude', 'platform/graphics/skia/[^/]*Skia\\.(cpp|h)$'],
-
-# The Mac currently uses ImageChromiumMac.mm from
-# platform/graphics/chromium, included by regex above, instead.
-['exclude', 'platform/graphics/chromium/ImageChromium\\.cpp$'],
-
-# ImageDecoderSkia is not used on mac. ImageDecoderCG is used instead.
-['exclude', 'platform/image-decoders/skia/ImageDecoderSkia\\.cpp$'],
-['include', 'platform/image-decoders/cg/ImageDecoderCG\\.cpp$'],
-
-# Again, Skia is not used on Mac.
-['exclude', 'platform/chromium/DragImageChromiumSkia\\.cpp$'],
- ],
-}],
-['OS==mac and use_skia==1', {
- 'sources/': [
['include', 'platform/graphics/cg/FloatPointCG\\.cpp$'],
[webkit-changes] [110057] trunk/Source/WebCore
Title: [110057] trunk/Source/WebCore
Revision 110057
Author gav...@chromium.org
Date 2012-03-07 08:52:17 -0800 (Wed, 07 Mar 2012)
Log Message
Add Histograms for reporting on PageCache reject reasons
https://bugs.webkit.org/show_bug.cgi?id=80187
Enhance the PageCache debug mode so that it uses Histograms to
report on causes of failure. Turn on the debug printing path
even in non-debug Chromium builds, so these histograms will
update.
Reviewed by Brady Eidson.
No new tests, does not change behaviour.
* history/PageCache.cpp:
(WebCore):
(WebCore::logCanCacheFrameDecision):
(WebCore::logCanCachePageDecision):
(WebCore::PageCache::canCache):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/PageCache.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110056 => 110057)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 16:35:28 UTC (rev 110056)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 16:52:17 UTC (rev 110057)
@@ -1,3 +1,23 @@
+2012-03-07 Gavin Peters gav...@chromium.org
+
+Add Histograms for reporting on PageCache reject reasons
+https://bugs.webkit.org/show_bug.cgi?id=80187
+
+Enhance the PageCache debug mode so that it uses Histograms to
+report on causes of failure. Turn on the debug printing path
+even in non-debug Chromium builds, so these histograms will
+update.
+
+Reviewed by Brady Eidson.
+
+No new tests, does not change behaviour.
+
+* history/PageCache.cpp:
+(WebCore):
+(WebCore::logCanCacheFrameDecision):
+(WebCore::logCanCachePageDecision):
+(WebCore::PageCache::canCache):
+
2012-03-07 Elliot Poger epo...@google.com
[Chromium] Remove use_skia option from GYP
Modified: trunk/Source/WebCore/history/PageCache.cpp (110056 => 110057)
--- trunk/Source/WebCore/history/PageCache.cpp 2012-03-07 16:35:28 UTC (rev 110056)
+++ trunk/Source/WebCore/history/PageCache.cpp 2012-03-07 16:52:17 UTC (rev 110057)
@@ -40,6 +40,7 @@
#include FrameLoader.h
#include FrameLoaderClient.h
#include FrameLoaderStateMachine.h
+#include HistogramSupport.h
#include HistoryItem.h
#include Logging.h
#include Page.h
@@ -56,12 +57,36 @@
static const double autoreleaseInterval = 3;
-#ifndef NDEBUG
+#if PLATFORM(CHROMIUM) || !defined(NDEBUG)
#define PCLOG(...) LOG(PageCache, %*s%s, indentLevel*4, , makeString(__VA_ARGS__).utf8().data())
-static bool logCanCacheFrameDecision(Frame* frame, int indentLevel)
+// Used in histograms, please only add at the end, and do not remove elements (renaming e.g. to FooEnumUnused1 is fine).
+// This is because statistics may be gathered from histograms between versions over time, and re-using values causes collisions.
+enum ReasonFrameCannotBeInPageCache {
+NoDocumentLoader = 0,
+MainDocumentError,
+IsErrorPage,
+HasPlugins,
+IsHttpsAndCacheControlled,
+HasUnloadListener,
+HasDatabaseHandles,
+HasSharedWorkers,
+NoHistoryItem,
+QuickRedirectComing,
+IsLoadingInAPISense,
+IsStopping,
+CanSuspendActiveDOMObjects,
+DocumentLoaderUsesApplicationCache,
+ClientDeniesCaching,
+NumberOfReasonsFramesCannotBeInPageCache,
+};
+
+static unsigned logCanCacheFrameDecision(Frame* frame, int indentLevel)
{
+#ifdef NDEBUG
+UNUSED_PARAM(indentLevel);
+#endif
// Only bother logging for frames that have actually loaded and have content.
if (frame-loader()-stateMachine()-creatingInitialEmptyDocument())
return false;
@@ -75,87 +100,110 @@
PCLOG( Determining if frame can be cached navigating from (, currentURL.string(), ) to (, newURL.string(), ):);
else
PCLOG( Determining if subframe with URL (, currentURL.string(), ) can be cached:);
+
+unsigned rejectReasons = 0;
-bool cannotCache = false;
-
if (!frame-loader()-documentLoader()) {
PCLOG( -There is no DocumentLoader object);
-cannotCache = true;
+rejectReasons |= 1 NoDocumentLoader;
} else {
if (!frame-loader()-documentLoader()-mainDocumentError().isNull()) {
PCLOG( -Main document has an error);
-cannotCache = true;
+rejectReasons |= 1 MainDocumentError;
}
if (frame-loader()-documentLoader()-substituteData().isValid() frame-loader()-documentLoader()-substituteData().failingURL().isEmpty()) {
PCLOG( -Frame is an error page);
-cannotCache = true;
+rejectReasons |= 1 IsErrorPage;
}
if (frame-loader()-subframeLoader()-containsPlugins() !frame-page()-settings()-pageCacheSupportsPlugins()) {
PCLOG( -Frame contains plugins);
-cannotCache = true;
+rejectReasons |= 1 HasPlugins;
}
if (frame-document()-url().protocolIs(https)
(frame-loader()-documentLoader()-response().cacheControlContainsNoCache()
||
[webkit-changes] [110058] trunk/Tools
Title: [110058] trunk/Tools
Revision 110058
Author commit-qu...@webkit.org
Date 2012-03-07 08:56:24 -0800 (Wed, 07 Mar 2012)
Log Message
[Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
https://bugs.webkit.org/show_bug.cgi?id=80425
Patch by Dinu Jacob dinu.ja...@nokia.com on 2012-03-07
Reviewed by Simon Hausmann.
Set startScreenPos in mock touch point
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(MiniBrowserApplication::notify):
* MiniBrowser/qt/MiniBrowserApplication.h:
(MiniBrowserApplication):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp
trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h
Diff
Modified: trunk/Tools/ChangeLog (110057 => 110058)
--- trunk/Tools/ChangeLog 2012-03-07 16:52:17 UTC (rev 110057)
+++ trunk/Tools/ChangeLog 2012-03-07 16:56:24 UTC (rev 110058)
@@ -1,3 +1,17 @@
+2012-03-07 Dinu Jacob dinu.ja...@nokia.com
+
+[Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
+https://bugs.webkit.org/show_bug.cgi?id=80425
+
+Reviewed by Simon Hausmann.
+
+Set startScreenPos in mock touch point
+
+* MiniBrowser/qt/MiniBrowserApplication.cpp:
+(MiniBrowserApplication::notify):
+* MiniBrowser/qt/MiniBrowserApplication.h:
+(MiniBrowserApplication):
+
2012-03-07 Simon Hausmann simon.hausm...@nokia.com
[Qt] Windows build fix.
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (110057 => 110058)
--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-03-07 16:52:17 UTC (rev 110057)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-03-07 16:56:24 UTC (rev 110058)
@@ -159,6 +159,7 @@
} else {
touchPoint.setState(Qt::TouchPointPressed);
touchType = QEvent::TouchBegin;
+m_startScreenPos = mouseEvent-screenPos();
}
break;
case QEvent::MouseMove:
@@ -192,6 +193,9 @@
Q_ASSERT_X(false, multi-touch mocking, unhandled event type);
}
+// Set the screen pos as the scene pos as canvas translates the touch events.
+touchPoint.setStartScenePos(m_startScreenPos);
+
// Update current touch-point
m_touchPoints.insert(touchPoint.id(), touchPoint);
Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h (110057 => 110058)
--- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h 2012-03-07 16:52:17 UTC (rev 110057)
+++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.h 2012-03-07 16:56:24 UTC (rev 110058)
@@ -111,6 +111,7 @@
QPointF m_lastPos;
QPointF m_lastScreenPos;
+QPointF m_startScreenPos;
QHashint, QTouchEvent::TouchPoint m_touchPoints;
QSetint m_heldTouchPoints;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110059] trunk/Tools
Title: [110059] trunk/Tools
Revision 110059
Author ph...@webkit.org
Date 2012-03-07 08:58:25 -0800 (Wed, 07 Mar 2012)
Log Message
[GTK] race condition in run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=80495
Reviewed by Martin Robinson.
Refactored the script to wait the a11y dbus service becomes
available before starting the tests.
* Scripts/run-gtk-tests:
(TestRunner._lookup_atspi2_binary):
(TestRunner):
(TestRunner._wait_dbus_service_and_run):
(TestRunner._wait_dbus_service_and_run.on_name_appeared):
(TestRunner._wait_dbus_service_and_run.on_name_vanished):
(TestRunner.run):
(TestRunner.run.bailout):
(TestRunner.run.run_for_real):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
Diff
Modified: trunk/Tools/ChangeLog (110058 => 110059)
--- trunk/Tools/ChangeLog 2012-03-07 16:56:24 UTC (rev 110058)
+++ trunk/Tools/ChangeLog 2012-03-07 16:58:25 UTC (rev 110059)
@@ -1,3 +1,23 @@
+2012-03-07 Philippe Normand pnorm...@igalia.com
+
+[GTK] race condition in run-gtk-tests
+https://bugs.webkit.org/show_bug.cgi?id=80495
+
+Reviewed by Martin Robinson.
+
+Refactored the script to wait the a11y dbus service becomes
+available before starting the tests.
+
+* Scripts/run-gtk-tests:
+(TestRunner._lookup_atspi2_binary):
+(TestRunner):
+(TestRunner._wait_dbus_service_and_run):
+(TestRunner._wait_dbus_service_and_run.on_name_appeared):
+(TestRunner._wait_dbus_service_and_run.on_name_vanished):
+(TestRunner.run):
+(TestRunner.run.bailout):
+(TestRunner.run.run_for_real):
+
2012-03-07 Dinu Jacob dinu.ja...@nokia.com
[Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
Modified: trunk/Tools/Scripts/run-gtk-tests (110058 => 110059)
--- trunk/Tools/Scripts/run-gtk-tests 2012-03-07 16:56:24 UTC (rev 110058)
+++ trunk/Tools/Scripts/run-gtk-tests 2012-03-07 16:58:25 UTC (rev 110059)
@@ -19,8 +19,13 @@
from webkitpy.common.system.executive import Executive
import subprocess
-import os, sys
+import os
+import sys
+import time
+from gi.repository import Gio, GLib
+TIMEOUT=180 # seconds
+
class TestRunner:
TEST_DIRS = [ unittests, WebKit2APITests ]
@@ -48,6 +53,8 @@
if not is_valid_build_directory(build_directory):
build_directory = os.path.join(top_level, 'WebKitBuild', 'Debug')
+self._a11y_registryd = None
+self._timed_out = False
self._gtk_tools_directory = os.path.join(top_level, Tools, gtk)
self._programs_path = os.path.join(build_directory, Programs)
self._tests = []
@@ -72,7 +79,7 @@
exec_prefix = self._executive.run_command([jhbuild_path ,'pkg-config', '--variable=exec_prefix', 'atspi-2']).rstrip('\r\n')
paths_to_check = [ 'libexec',
'lib/at-spi2-core',
- 'lib32/at-spi2-core'
+ 'lib32/at-spi2-core',
'lib64/at-spi2-core' ]
for path in paths_to_check:
filepath = os.path.join(exec_prefix, path, filename)
@@ -81,6 +88,35 @@
return None
+def _run_command_when_dbus_service_appears(self, service_name, handler):
+def on_name_appeared(*args):
+handler()
+
+def on_name_vanished(*args):
+pass
+
+Gio.bus_watch_name(Gio.BusType.SESSION, service_name,
+ Gio.BusNameWatcherFlags.NONE, on_name_appeared, on_name_vanished)
+
+
+def _check_if_tests_have_timed_out(self):
+if time.time() - self._start_time = TIMEOUT:
+return False
+sys.stdout.write(Tests timed out after %d seconds\n % TIMEOUT)
+sys.stdout.flush()
+self._timed_out = True
+return True
+
+def _ensure_accessibility_daemon_is_running(self, jhbuild_path):
+a11y_registryd_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi2-registryd')
+if a11y_registryd_path:
+try:
+self._a11y_registryd = Executive().popen([a11y_registryd_path], env=test_env)
+except:
+sys.stderr.write(Failed to run the accessibility registry\n)
+sys.stderr.flush()
+self._a11y_registryd = None
+
def run(self):
if not self._tests:
sys.stderr.write(ERROR: tests not found in %s.\n % (self._programs_path))
@@ -92,51 +128,54 @@
test_env[WEBKIT_INSPECTOR_PATH] = os.path.abspath(os.path.join(self._programs_path, 'resources', 'inspector'))
test_env['GSETTINGS_BACKEND'] = 'memory'
-exit_status = [0]
+failed_tests = []
def _error_handler(error):
-exit_status[0] = error.exit_code
+failed_tests.append(error.script_args[2])
jhbuild_path = os.path.join(self._gtk_tools_directory, run-with-jhbuild)
# Make sure the accessibility bus is launched.
-
[webkit-changes] [110060] trunk/Tools
Title: [110060] trunk/Tools Revision 110060 Author ph...@webkit.org Date 2012-03-07 09:11:05 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed, GTK build fix after r110059. * Scripts/run-gtk-tests: (TestRunner._check_if_tests_have_timed_out): (TestRunner.run.run_tests): (TestRunner): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (110059 => 110060) --- trunk/Tools/ChangeLog 2012-03-07 16:58:25 UTC (rev 110059) +++ trunk/Tools/ChangeLog 2012-03-07 17:11:05 UTC (rev 110060) @@ -1,5 +1,14 @@ 2012-03-07 Philippe Normand pnorm...@igalia.com +Unreviewed, GTK build fix after r110059. + +* Scripts/run-gtk-tests: +(TestRunner._check_if_tests_have_timed_out): +(TestRunner.run.run_tests): +(TestRunner): + +2012-03-07 Philippe Normand pnorm...@igalia.com + [GTK] race condition in run-gtk-tests https://bugs.webkit.org/show_bug.cgi?id=80495 Modified: trunk/Tools/Scripts/run-gtk-tests (110059 => 110060) --- trunk/Tools/Scripts/run-gtk-tests 2012-03-07 16:58:25 UTC (rev 110059) +++ trunk/Tools/Scripts/run-gtk-tests 2012-03-07 17:11:05 UTC (rev 110060) @@ -107,7 +107,7 @@ self._timed_out = True return True -def _ensure_accessibility_daemon_is_running(self, jhbuild_path): +def _ensure_accessibility_daemon_is_running(self, jhbuild_path, test_env): a11y_registryd_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi2-registryd') if a11y_registryd_path: try: @@ -148,7 +148,7 @@ self._start_time = time.time() def run_tests(): -self._ensure_accessibility_daemon_is_running(jhbuild_path) +self._ensure_accessibility_daemon_is_running(jhbuild_path, test_env) for test in self._tests: out = self._executive.run_command([jhbuild_path ,'gtester', test], env=test_env, ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110061] trunk/Source/WebCore
Title: [110061] trunk/Source/WebCore
Revision 110061
Author commit-qu...@webkit.org
Date 2012-03-07 09:15:07 -0800 (Wed, 07 Mar 2012)
Log Message
[EFL] Key press event is not processed properly.
https://bugs.webkit.org/show_bug.cgi?id=80491
Patch by ChangSeok Oh shivami...@gmail.com on 2012-03-07
Reviewed by Gustavo Noronha Silva.
This issue is related with mutation observer feature.
If enter key is pressed, then a keyboard event should be processed
and reach to the mutation observer, but it doesn't.
Some special keys like Enter, Backspace and Tab key should be processed
and change to a single character code, but EFL port hasn't handled like that.
At least we can verify this with following two tests as I know. but they require another
functionality for bug79601. I'm going to submit the patch for it after this one.
Test: fast/mutation/end-of-task-delivery.html
fast/mutation/inline-event-listener.html
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::singleCharacterString):
(WebCore):
* platform/efl/EflKeyboardUtilities.h:
(WebCore):
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp
trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h
trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110060 => 110061)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 17:11:05 UTC (rev 110060)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 17:15:07 UTC (rev 110061)
@@ -1,3 +1,30 @@
+2012-03-07 ChangSeok Oh shivami...@gmail.com
+
+[EFL] Key press event is not processed properly.
+https://bugs.webkit.org/show_bug.cgi?id=80491
+
+Reviewed by Gustavo Noronha Silva.
+
+This issue is related with mutation observer feature.
+If enter key is pressed, then a keyboard event should be processed
+and reach to the mutation observer, but it doesn't.
+Some special keys like Enter, Backspace and Tab key should be processed
+and change to a single character code, but EFL port hasn't handled like that.
+
+At least we can verify this with following two tests as I know. but they require another
+functionality for bug79601. I'm going to submit the patch for it after this one.
+
+Test: fast/mutation/end-of-task-delivery.html
+ fast/mutation/inline-event-listener.html
+
+* platform/efl/EflKeyboardUtilities.cpp:
+(WebCore::singleCharacterString):
+(WebCore):
+* platform/efl/EflKeyboardUtilities.h:
+(WebCore):
+* platform/efl/PlatformKeyboardEventEfl.cpp:
+(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
2012-03-07 Gavin Peters gav...@chromium.org
Add Histograms for reporting on PageCache reject reasons
Modified: trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp (110060 => 110061)
--- trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-03-07 17:11:05 UTC (rev 110060)
+++ trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-03-07 17:15:07 UTC (rev 110061)
@@ -177,6 +177,17 @@
return keyName;
}
+String singleCharacterString(const String keyName)
+{
+if (keyName == Return)
+return String(\r);
+if (keyName == BackSpace)
+return String(\x8);
+if (keyName == Tab)
+return String(\t);
+return keyName;
+}
+
int windowsKeyCodeForEvasKeyName(String keyName)
{
if (windowsKeyMap().isEmpty())
Modified: trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h (110060 => 110061)
--- trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h 2012-03-07 17:11:05 UTC (rev 110060)
+++ trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h 2012-03-07 17:15:07 UTC (rev 110061)
@@ -35,6 +35,7 @@
namespace WebCore {
WTF::String keyIdentifierForEvasKeyName(WTF::String);
+WTF::String singleCharacterString(const WTF::String);
int windowsKeyCodeForEvasKeyName(WTF::String);
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp (110060 => 110061)
--- trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2012-03-07 17:11:05 UTC (rev 110060)
+++ trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2012-03-07 17:15:07 UTC (rev 110061)
@@ -42,8 +42,8 @@
PlatformKeyboardEvent::PlatformKeyboardEvent(const Evas_Event_Key_Down* event)
: PlatformEvent(PlatformEvent::KeyDown, evas_key_modifier_is_set(event-modifiers, Shift), evas_key_modifier_is_set(event-modifiers, Control), evas_key_modifier_is_set(event-modifiers, Alt), evas_key_modifier_is_set(event-modifiers, Meta), currentTime())
-, m_text(String::fromUTF8(event-string))
-, m_unmodifiedText(String::fromUTF8(event-string))
+, m_text(singleCharacterString(String::fromUTF8(event-string)))
+,
[webkit-changes] [110062] trunk/Tools
Title: [110062] trunk/Tools
Revision 110062
Author ph...@webkit.org
Date 2012-03-07 09:23:43 -0800 (Wed, 07 Mar 2012)
Log Message
[GTK] remove webkitpy dependency in run-gtk-tests
https://bugs.webkit.org/show_bug.cgi?id=80500
Reviewed by Martin Robinson.
Replace Executive calls with bare subprocess calls.
* Scripts/run-gtk-tests:
(TestRunner):
(TestRunner._lookup_atspi2_binary):
(TestRunner.run):
(TestRunner.run.run_for_real):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
Diff
Modified: trunk/Tools/ChangeLog (110061 => 110062)
--- trunk/Tools/ChangeLog 2012-03-07 17:15:07 UTC (rev 110061)
+++ trunk/Tools/ChangeLog 2012-03-07 17:23:43 UTC (rev 110062)
@@ -1,5 +1,20 @@
2012-03-07 Philippe Normand pnorm...@igalia.com
+[GTK] remove webkitpy dependency in run-gtk-tests
+https://bugs.webkit.org/show_bug.cgi?id=80500
+
+Reviewed by Martin Robinson.
+
+Replace Executive calls with bare subprocess calls.
+
+* Scripts/run-gtk-tests:
+(TestRunner):
+(TestRunner._lookup_atspi2_binary):
+(TestRunner.run):
+(TestRunner.run.run_for_real):
+
+2012-03-07 Philippe Normand pnorm...@igalia.com
+
Unreviewed, GTK build fix after r110059.
* Scripts/run-gtk-tests:
Modified: trunk/Tools/Scripts/run-gtk-tests (110061 => 110062)
--- trunk/Tools/Scripts/run-gtk-tests 2012-03-07 17:15:07 UTC (rev 110061)
+++ trunk/Tools/Scripts/run-gtk-tests 2012-03-07 17:23:43 UTC (rev 110062)
@@ -17,7 +17,6 @@
# the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
# Boston, MA 02110-1301, USA.
-from webkitpy.common.system.executive import Executive
import subprocess
import os
import sys
@@ -37,7 +36,6 @@
WebKit2APITests/TestDownloads ]
def __init__(self):
-self._executive = Executive()
# FIXME: webkit-build-directory --configuration always returns
# Release because we never call set-webkit-configuration.
@@ -76,7 +74,9 @@
self._tests.append(test_path)
def _lookup_atspi2_binary(self, jhbuild_path, filename):
-exec_prefix = self._executive.run_command([jhbuild_path ,'pkg-config', '--variable=exec_prefix', 'atspi-2']).rstrip('\r\n')
+process = subprocess.Popen([jhbuild_path ,'pkg-config', '--variable=exec_prefix', 'atspi-2'], stdout=subprocess.PIPE)
+stdout = process.communicate()[0]
+exec_prefix = stdout.rstrip('\r\n')
paths_to_check = [ 'libexec',
'lib/at-spi2-core',
'lib32/at-spi2-core',
@@ -111,7 +111,7 @@
a11y_registryd_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi2-registryd')
if a11y_registryd_path:
try:
-self._a11y_registryd = Executive().popen([a11y_registryd_path], env=test_env)
+self._a11y_registryd = subprocess.Popen([a11y_registryd_path], env=test_env)
except:
sys.stderr.write(Failed to run the accessibility registry\n)
sys.stderr.flush()
@@ -129,8 +129,6 @@
test_env['GSETTINGS_BACKEND'] = 'memory'
failed_tests = []
-def _error_handler(error):
-failed_tests.append(error.script_args[2])
jhbuild_path = os.path.join(self._gtk_tools_directory, run-with-jhbuild)
@@ -138,7 +136,7 @@
a11y_bus_launcher_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi-bus-launcher')
assert(a11y_bus_launcher_path)
try:
-a11y_bus_launcher = Executive().popen([a11y_bus_launcher_path], env=test_env)
+a11y_bus_launcher = subprocess.Popen([a11y_bus_launcher_path], env=test_env)
except:
sys.stderr.write(Failed to launch the accessibility bus\n)
sys.stderr.flush()
@@ -151,10 +149,9 @@
self._ensure_accessibility_daemon_is_running(jhbuild_path, test_env)
for test in self._tests:
-out = self._executive.run_command([jhbuild_path ,'gtester', test], env=test_env,
- error_handler=_error_handler)
-sys.stdout.write(out)
-sys.stdout.flush()
+process = subprocess.Popen([jhbuild_path ,'gtester', test], env=test_env)
+if process.wait():
+failed_tests.append(test)
if self._check_if_tests_have_timed_out():
break
@@ -178,7 +175,7 @@
if __name__ == __main__:
try:
-xvfb = Executive().popen([Xvfb, :55, -screen, 0, 800x600x24, -nolisten, tcp],
+xvfb = subprocess.Popen([Xvfb, :55, -screen, 0, 800x600x24, -nolisten, tcp],
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
except:
sys.stderr.write(Failed to run Xvfb\n)
___
webkit-changes mailing list
[webkit-changes] [110063] trunk/Source/WebCore
Title: [110063] trunk/Source/WebCore
Revision 110063
Author ad...@apple.com
Date 2012-03-07 09:23:46 -0800 (Wed, 07 Mar 2012)
Log Message
REGRESSION(r96566): Cursor is I-beam upon dragging an attachment in mail
https://bugs.webkit.org/show_bug.cgi?id=80458
rdar://problem/10873195
Reviewed by Dan Bernstein.
No tests because we currently don't have any test machinery for cursors.
Make sure the shortcut to always use an iBeam cursor during selection isn't used during dragging.
Before r96566, we handled plugin cursors as a special case before calling into selectCursor, so we never hit this code path.
* page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/EventHandler.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110062 => 110063)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 17:23:43 UTC (rev 110062)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 17:23:46 UTC (rev 110063)
@@ -1,3 +1,18 @@
+2012-03-07 Adele Peterson ad...@apple.com
+
+REGRESSION(r96566): Cursor is I-beam upon dragging an attachment in mail
+https://bugs.webkit.org/show_bug.cgi?id=80458
+rdar://problem/10873195
+
+Reviewed by Dan Bernstein.
+
+No tests because we currently don't have any test machinery for cursors.
+
+Make sure the shortcut to always use an iBeam cursor during selection isn't used during dragging.
+Before r96566, we handled plugin cursors as a special case before calling into selectCursor, so we never hit this code path.
+
+* page/EventHandler.cpp: (WebCore::EventHandler::selectCursor):
+
2012-03-07 ChangSeok Oh shivami...@gmail.com
[EFL] Key press event is not processed properly.
Modified: trunk/Source/WebCore/page/EventHandler.cpp (110062 => 110063)
--- trunk/Source/WebCore/page/EventHandler.cpp 2012-03-07 17:23:43 UTC (rev 110062)
+++ trunk/Source/WebCore/page/EventHandler.cpp 2012-03-07 17:23:46 UTC (rev 110063)
@@ -1285,8 +1285,8 @@
const Cursor iBeam = horizontalText ? iBeamCursor() : verticalTextCursor();
// During selection, use an I-beam no matter what we're over.
-// If you're capturing mouse events for a particular node, don't treat this as a selection.
-if (m_mousePressed m_mouseDownMayStartSelect m_frame-selection()-isCaretOrRange() !m_capturingMouseEventsNode)
+// If a drag may be starting or we're capturing mouse events for a particular node, don't treat this as a selection.
+if (m_mousePressed m_mouseDownMayStartSelect !m_mouseDownMayStartDrag m_frame-selection()-isCaretOrRange() !m_capturingMouseEventsNode)
return iBeam;
if (renderer) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110064] trunk
Title: [110064] trunk
Revision 110064
Author ph...@webkit.org
Date 2012-03-07 09:27:15 -0800 (Wed, 07 Mar 2012)
Log Message
[GTK] media/audio-garbage-collect.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=72698
Reviewed by Xan Lopez.
Source/WebCore:
Call ::hasPendingActivity() instead of ::paused() when checking if
the audio element is still active. This is similar to what the
image element (another ActiveDOMObject implementation) does just
above. This contributes to fixing the audio-garbage-collect.html
test.
* bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
LayoutTests:
* platform/gtk/test_expectations.txt: test is no longer flaky.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (110063 => 110064)
--- trunk/LayoutTests/ChangeLog 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/LayoutTests/ChangeLog 2012-03-07 17:27:15 UTC (rev 110064)
@@ -1,3 +1,12 @@
+2012-03-07 Philippe Normand pnorm...@igalia.com
+
+[GTK] media/audio-garbage-collect.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=72698
+
+Reviewed by Xan Lopez.
+
+* platform/gtk/test_expectations.txt: test is no longer flaky.
+
2012-03-07 Stephen White senorbla...@chromium.org
[chromium] Marking file-writer-events.html as flaky-crashing on Win.
Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (110063 => 110064)
--- trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt 2012-03-07 17:27:15 UTC (rev 110064)
@@ -68,7 +68,6 @@
BUGWK80129 : fast/frames/flattening/frameset-flattening-advanced.html = PASS TEXT
BUGWK80129 : fast/frames/flattening/frameset-flattening-subframesets.html = PASS TEXT
-BUGWK72698 : media/audio-garbage-collect.html = PASS TEXT
BUGWK79760 : media/video-poster-blocked-by-willsendrequest.html = PASS TEXT
BUGWK72694 : fast/canvas/canvas-lineWidth.html = PASS TIMEOUT TEXT
Modified: trunk/Source/WebCore/ChangeLog (110063 => 110064)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 17:27:15 UTC (rev 110064)
@@ -1,3 +1,19 @@
+2012-03-07 Philippe Normand pnorm...@igalia.com
+
+[GTK] media/audio-garbage-collect.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=72698
+
+Reviewed by Xan Lopez.
+
+Call ::hasPendingActivity() instead of ::paused() when checking if
+the audio element is still active. This is similar to what the
+image element (another ActiveDOMObject implementation) does just
+above. This contributes to fixing the audio-garbage-collect.html
+test.
+
+* bindings/js/JSNodeCustom.cpp:
+(WebCore::isReachableFromDOM):
+
2012-03-07 Adele Peterson ad...@apple.com
REGRESSION(r96566): Cursor is I-beam upon dragging an attachment in mail
Modified: trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp (110063 => 110064)
--- trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2012-03-07 17:23:46 UTC (rev 110063)
+++ trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp 2012-03-07 17:27:15 UTC (rev 110064)
@@ -116,7 +116,7 @@
}
#if ENABLE(VIDEO)
else if (node-hasTagName(audioTag)) {
-if (!static_castHTMLAudioElement*(node)-paused())
+if (!static_castHTMLAudioElement*(node)-hasPendingActivity())
return true;
}
#endif
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110065] trunk
Title: [110065] trunk
Revision 110065
Author m...@apple.com
Date 2012-03-07 09:38:56 -0800 (Wed, 07 Mar 2012)
Log Message
rdar://problem/10923294 REGRESSION (r100847): Entries are clipped out in Day One
https://bugs.webkit.org/show_bug.cgi?id=80494
Reviewed by Sam Weinig.
Source/WebCore:
Test: fast/dom/HTMLDocument/width-and-height.html
* html/HTMLDocument.idl: Reverted r100847 by re-enabling the width and height properties
in the _javascript_ bindings.
LayoutTests:
* fast/dom/HTMLDocument/width-and-height-expected.txt: Added.
* fast/dom/HTMLDocument/width-and-height.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLDocument.idl
Added Paths
trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt
trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height.html
Diff
Modified: trunk/LayoutTests/ChangeLog (110064 => 110065)
--- trunk/LayoutTests/ChangeLog 2012-03-07 17:27:15 UTC (rev 110064)
+++ trunk/LayoutTests/ChangeLog 2012-03-07 17:38:56 UTC (rev 110065)
@@ -1,3 +1,13 @@
+2012-03-07 Dan Bernstein m...@apple.com
+
+rdar://problem/10923294 REGRESSION (r100847): Entries are clipped out in Day One
+https://bugs.webkit.org/show_bug.cgi?id=80494
+
+Reviewed by Sam Weinig.
+
+* fast/dom/HTMLDocument/width-and-height-expected.txt: Added.
+* fast/dom/HTMLDocument/width-and-height.html: Added.
+
2012-03-07 Philippe Normand pnorm...@igalia.com
[GTK] media/audio-garbage-collect.html is flaky
Added: trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt (0 => 110065)
--- trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height-expected.txt 2012-03-07 17:38:56 UTC (rev 110065)
@@ -0,0 +1 @@
+PASS. The document.width and document.height properties are accessible from _javascript_.
Added: trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height.html (0 => 110065)
--- trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height.html (rev 0)
+++ trunk/LayoutTests/fast/dom/HTMLDocument/width-and-height.html 2012-03-07 17:38:56 UTC (rev 110065)
@@ -0,0 +1,9 @@
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+if ('width' in document 'height' in document)
+document.write(PASS. The document.width and document.height properties are accessible from _javascript_.);
+else
+document.write(FAIL. document.width or document.height are not accessible from _javascript_.);
+/script
Modified: trunk/Source/WebCore/ChangeLog (110064 => 110065)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 17:27:15 UTC (rev 110064)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 17:38:56 UTC (rev 110065)
@@ -1,3 +1,15 @@
+2012-03-07 Dan Bernstein m...@apple.com
+
+rdar://problem/10923294 REGRESSION (r100847): Entries are clipped out in Day One
+https://bugs.webkit.org/show_bug.cgi?id=80494
+
+Reviewed by Sam Weinig.
+
+Test: fast/dom/HTMLDocument/width-and-height.html
+
+* html/HTMLDocument.idl: Reverted r100847 by re-enabling the width and height properties
+in the _javascript_ bindings.
+
2012-03-07 Philippe Normand pnorm...@igalia.com
[GTK] media/audio-garbage-collect.html is flaky
Modified: trunk/Source/WebCore/html/HTMLDocument.idl (110064 => 110065)
--- trunk/Source/WebCore/html/HTMLDocument.idl 2012-03-07 17:27:15 UTC (rev 110064)
+++ trunk/Source/WebCore/html/HTMLDocument.idl 2012-03-07 17:38:56 UTC (rev 110065)
@@ -45,10 +45,8 @@
void captureEvents();
void releaseEvents();
-#if defined(LANGUAGE_OBJECTIVE_C) LANGUAGE_OBJECTIVE_C
readonly attribute long width;
readonly attribute long height;
-#endif
attribute [TreatNullAs=NullString] DOMString dir;
attribute [TreatNullAs=NullString] DOMString designMode;
readonly attribute DOMString compatMode;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110070] trunk/Source/WebCore
Title: [110070] trunk/Source/WebCore
Revision 110070
Author le...@chromium.org
Date 2012-03-07 10:59:46 -0800 (Wed, 07 Mar 2012)
Log Message
Update usage of LayoutUnits in InlineBox and InlineFlowBox
https://bugs.webkit.org/show_bug.cgi?id=80051
Reviewed by Eric Seidel.
Updating LayoutUnit vs Integer usage in InlineBox and InlineFlowBox. While the
line box tree remains floating point, margins are now subpixel, and rects from
the render tree use LayoutUnits. For more information, see the LayoutUnit wiki
page: https://trac.webkit.org/wiki/LayoutUnit
No new tests. No change in behavior.
* rendering/InlineBox.cpp:
(WebCore::InlineBox::flipForWritingMode): Changing over to LayoutUnits.
* rendering/InlineBox.h:
(InlineBox):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::getFlowSpacingLogicalWidth): Returning a LayoutUnit
instead of an integer, as it uses margin which is a LayoutUnit.
(WebCore::InlineFlowBox::placeBoxesInInlineDirection): Using a LayoutUnit for
margin.
(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Build fixes for when
LayoutUnits are subpixel.
(WebCore::InlineFlowBox::paintFillLayer): Ditto.
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::marginBorderPaddingLogicalLeft): Returning a LayoutUnit
instead of an integer since margin is a LayoutUnit.
(WebCore::InlineFlowBox::marginBorderPaddingLogicalRight): Ditto.
(InlineFlowBox):
(WebCore::InlineFlowBox::logicalLeftLayoutOverflow): Adding a static_cast that's
redundant now, but required when we switch to subpixel LayoutUnits.
(WebCore::InlineFlowBox::logicalRightLayoutOverflow): Ditto.
(WebCore::InlineFlowBox::logicalLeftVisualOverflow): Ditto.
(WebCore::InlineFlowBox::logicalRightVisualOverflow): Ditto.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/InlineBox.cpp
trunk/Source/WebCore/rendering/InlineBox.h
trunk/Source/WebCore/rendering/InlineFlowBox.cpp
trunk/Source/WebCore/rendering/InlineFlowBox.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (110069 => 110070)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 18:40:23 UTC (rev 110069)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 18:59:46 UTC (rev 110070)
@@ -1,3 +1,40 @@
+2012-03-07 Levi Weintraub le...@chromium.org
+
+Update usage of LayoutUnits in InlineBox and InlineFlowBox
+https://bugs.webkit.org/show_bug.cgi?id=80051
+
+Reviewed by Eric Seidel.
+
+Updating LayoutUnit vs Integer usage in InlineBox and InlineFlowBox. While the
+line box tree remains floating point, margins are now subpixel, and rects from
+the render tree use LayoutUnits. For more information, see the LayoutUnit wiki
+page: https://trac.webkit.org/wiki/LayoutUnit
+
+No new tests. No change in behavior.
+
+* rendering/InlineBox.cpp:
+(WebCore::InlineBox::flipForWritingMode): Changing over to LayoutUnits.
+* rendering/InlineBox.h:
+(InlineBox):
+* rendering/InlineFlowBox.cpp:
+(WebCore::InlineFlowBox::getFlowSpacingLogicalWidth): Returning a LayoutUnit
+instead of an integer, as it uses margin which is a LayoutUnit.
+(WebCore::InlineFlowBox::placeBoxesInInlineDirection): Using a LayoutUnit for
+margin.
+(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Build fixes for when
+LayoutUnits are subpixel.
+(WebCore::InlineFlowBox::paintFillLayer): Ditto.
+* rendering/InlineFlowBox.h:
+(WebCore::InlineFlowBox::marginBorderPaddingLogicalLeft): Returning a LayoutUnit
+instead of an integer since margin is a LayoutUnit.
+(WebCore::InlineFlowBox::marginBorderPaddingLogicalRight): Ditto.
+(InlineFlowBox):
+(WebCore::InlineFlowBox::logicalLeftLayoutOverflow): Adding a static_cast that's
+redundant now, but required when we switch to subpixel LayoutUnits.
+(WebCore::InlineFlowBox::logicalRightLayoutOverflow): Ditto.
+(WebCore::InlineFlowBox::logicalLeftVisualOverflow): Ditto.
+(WebCore::InlineFlowBox::logicalRightVisualOverflow): Ditto.
+
2012-03-07 Qi Zhang qi.2.zh...@nokia.com
[Qt] Unskip http/tests/websocket/tests/hixie76/long-invalid-header.html
Modified: trunk/Source/WebCore/rendering/InlineBox.cpp (110069 => 110070)
--- trunk/Source/WebCore/rendering/InlineBox.cpp 2012-03-07 18:40:23 UTC (rev 110069)
+++ trunk/Source/WebCore/rendering/InlineBox.cpp 2012-03-07 18:59:46 UTC (rev 110070)
@@ -365,14 +365,14 @@
return root()-block()-flipForWritingMode(point);
}
-void InlineBox::flipForWritingMode(IntRect rect)
+void InlineBox::flipForWritingMode(LayoutRect rect)
{
if (!renderer()-style()-isFlippedBlocksWritingMode())
return;
root()-block()-flipForWritingMode(rect);
}
-IntPoint InlineBox::flipForWritingMode(const IntPoint point)
+LayoutPoint InlineBox::flipForWritingMode(const LayoutPoint point)
{
if (!renderer()-style()-isFlippedBlocksWritingMode())
return point;
[webkit-changes] [110071] trunk/Source/WebCore
Title: [110071] trunk/Source/WebCore
Revision 110071
Author commit-qu...@webkit.org
Date 2012-03-07 11:01:34 -0800 (Wed, 07 Mar 2012)
Log Message
[BlackBerry] Fix warnings in CookieMap
https://bugs.webkit.org/show_bug.cgi?id=80512
Patch by Konrad Piascik kpias...@rim.com on 2012-03-07
Reviewed by Rob Buis.
No new tests. No behavioural changes.
* platform/blackberry/CookieMap.cpp:
(WebCore::CookieMap::addOrReplaceCookie):
(WebCore::CookieMap::removeCookie):
(WebCore::CookieMap::getAllCookies):
(WebCore::CookieMap::updateOldestCookie):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/blackberry/CookieMap.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110070 => 110071)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 18:59:46 UTC (rev 110070)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 19:01:34 UTC (rev 110071)
@@ -1,3 +1,18 @@
+2012-03-07 Konrad Piascik kpias...@rim.com
+
+[BlackBerry] Fix warnings in CookieMap
+https://bugs.webkit.org/show_bug.cgi?id=80512
+
+Reviewed by Rob Buis.
+
+No new tests. No behavioural changes.
+
+* platform/blackberry/CookieMap.cpp:
+(WebCore::CookieMap::addOrReplaceCookie):
+(WebCore::CookieMap::removeCookie):
+(WebCore::CookieMap::getAllCookies):
+(WebCore::CookieMap::updateOldestCookie):
+
2012-03-07 Levi Weintraub le...@chromium.org
Update usage of LayoutUnits in InlineBox and InlineFlowBox
Modified: trunk/Source/WebCore/platform/blackberry/CookieMap.cpp (110070 => 110071)
--- trunk/Source/WebCore/platform/blackberry/CookieMap.cpp 2012-03-07 18:59:46 UTC (rev 110070)
+++ trunk/Source/WebCore/platform/blackberry/CookieMap.cpp 2012-03-07 19:01:34 UTC (rev 110071)
@@ -59,7 +59,8 @@
CookieLog(CookieMap - Attempting to add cookie - %s, cookie-name().utf8().data());
ParsedCookie* prevCookie = 0;
-for (int i = 0; i m_cookieVector.size(); i++) {
+size_t cookieCount = m_cookieVector.size();
+for (size_t i = 0; i cookieCount; i++) {
if (m_cookieVector[i]-name() == cookie-name() m_cookieVector[i]-path() == cookie-path()) {
prevCookie = m_cookieVector[i];
m_cookieVector[i] = cookie;
@@ -101,7 +102,7 @@
ParsedCookie* CookieMap::removeCookie(const ParsedCookie* cookie)
{
size_t cookieCount = m_cookieVector.size();
-for (int position = 0; position cookieCount; ++position) {
+for (size_t position = 0; position cookieCount; ++position) {
if (m_cookieVector[position]-name() == cookie-name() m_cookieVector[position]-path() == cookie-path())
return removeCookieAtIndex(position, cookie);
}
@@ -129,7 +130,7 @@
stackOfCookies-reserveCapacity(stackOfCookies-size() + m_cookieVector.size());
-int position = 0;
+size_t position = 0;
while (position m_cookieVector.size()) {
ParsedCookie* newCookie = m_cookieVector[position];
if (newCookie-hasExpired()) {
@@ -186,7 +187,7 @@
}
m_oldestCookie = m_cookieVector[0];
-for (int i = 1; i size; ++i) {
+for (size_t i = 1; i size; ++i) {
if (m_oldestCookie-lastAccessed() m_cookieVector[i]-lastAccessed())
m_oldestCookie = m_cookieVector[i];
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110073] trunk
Title: [110073] trunk
Revision 110073
Author hb...@chromium.org
Date 2012-03-07 11:08:01 -0800 (Wed, 07 Mar 2012)
Log Message
[Chromium] Mirror the resizer image of an RTL element when WTF_USE_RTL_SCROLLBAR is 1
https://bugs.webkit.org/show_bug.cgi?id=9223
Reviewed by Tony Chang.
This change mirrors a resizer image of an RTL element horizontall as Firefox
does. This change also mirrors its dragging behavior, i.e. draging the resizer
of an RTL element to the left side increases its width. (This feature is enabled
only when WTF_USE_RTL_SCROLLBAR is 1.)
Source/WebCore:
Test: platform/chromium/scrollbars/drag-rtl-resizer.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize): Mirrored the x coordinate of mouse positions
when mirroring a resizer.
(WebCore::RenderLayer::offsetFromResizeCorner): Returned the offset from the
bottom-left corner when rendering a resizer there.
(WebCore::RenderLayer::drawPlatformResizerImage): Mirrored the resizer bitmap
horizontally when rendering a resizer to the bottom-left corner.
LayoutTests:
* platform/chromium/scrollbars: Added.
* platform/chromium/scrollbars/drag-rtl-resizer-expected.txt: Added.
* platform/chromium/scrollbars/drag-rtl-resizer.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
Added Paths
trunk/LayoutTests/platform/chromium/scrollbars/
trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer-expected.txt
trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html
Diff
Modified: trunk/LayoutTests/ChangeLog (110072 => 110073)
--- trunk/LayoutTests/ChangeLog 2012-03-07 19:05:57 UTC (rev 110072)
+++ trunk/LayoutTests/ChangeLog 2012-03-07 19:08:01 UTC (rev 110073)
@@ -1,3 +1,19 @@
+2012-03-07 Hironori Bono hb...@chromium.org
+
+[Chromium] Mirror the resizer image of an RTL element when WTF_USE_RTL_SCROLLBAR is 1
+https://bugs.webkit.org/show_bug.cgi?id=9223
+
+Reviewed by Tony Chang.
+
+This change mirrors a resizer image of an RTL element horizontall as Firefox
+does. This change also mirrors its dragging behavior, i.e. draging the resizer
+of an RTL element to the left side increases its width. (This feature is enabled
+only when WTF_USE_RTL_SCROLLBAR is 1.)
+
+* platform/chromium/scrollbars: Added.
+* platform/chromium/scrollbars/drag-rtl-resizer-expected.txt: Added.
+* platform/chromium/scrollbars/drag-rtl-resizer.html: Added.
+
2012-03-07 Julien Chaffraix jchaffr...@webkit.org
Lazily allocate overflow: hidden layers if we have overflowing content
Added: trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer-expected.txt (0 => 110073)
--- trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer-expected.txt 2012-03-07 19:08:01 UTC (rev 110073)
@@ -0,0 +1,10 @@
+Test that an RTL element renders a resizer to its bottom-left corner and dragging this resizer to the left changes its width. To test manually, dragging the resizer of the below element to left, and see this element increases its width.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS document.getElementById('overflow').offsetWidth offsetWidth is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html (0 => 110073)
--- trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html (rev 0)
+++ trunk/LayoutTests/platform/chromium/scrollbars/drag-rtl-resizer.html 2012-03-07 19:08:01 UTC (rev 110073)
@@ -0,0 +1,43 @@
+!DOCTYPE html
+html
+head
+titleBug 9223/title
+script src=""
+/head
+body dir=rtl style=margin:0px
+div id=overflow dir=rtl style=border:2px solid black; overflow:auto; width: 400px; height: 400px; resize:both;
+div style=background-color:red;height:720px/div
+div style=background-color:green;height:1600px/div
+/div
+script
+description('Test that an RTL element renders a resizer to its bottom-left corner and ' +
+'dragging this resizer to the left changes its width. ' +
+'To test manually, dragging the resizer of the below element to left, and ' +
+'see this element increases its width.');
+
+// This test must be async because it needs to wait for WebKit to finish re-layouting elements
+// after sending mouse events.
+jsTestIsAsync = true;
+
+function finished()
+{
+shouldBeTrue('document.getElementById(\'overflow\').offsetWidth offsetWidth');
+finishJSTest();
+}
+
+var offsetWidth = document.getElementById('overflow').offsetWidth;
+
+if (window.eventSender) {
+var node = document.getElementById('overflow');
+var offsetLeft = node.offsetLeft + 5;
+var offsetTop = node.offsetTop + node.offsetHeight - 5;
+
[webkit-changes] [110075] trunk/Tools
Title: [110075] trunk/Tools
Revision 110075
Author jam...@google.com
Date 2012-03-07 11:18:09 -0800 (Wed, 07 Mar 2012)
Log Message
[chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
https://bugs.webkit.org/show_bug.cgi?id=80521
Reviewed by Kenneth Russell.
Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
Covered by platform/chromium/compositing/plugins/*
* DumpRenderTree/chromium/TestWebPlugin.cpp:
(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::initialize):
(TestWebPlugin::updateGeometry):
(TestWebPlugin::initScene):
(TestWebPlugin::destroyScene):
* DumpRenderTree/chromium/TestWebPlugin.h:
(TestWebPlugin):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createPlugin):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp
trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.h
trunk/Tools/DumpRenderTree/chromium/WebViewHost.cpp
Diff
Modified: trunk/Tools/ChangeLog (110074 => 110075)
--- trunk/Tools/ChangeLog 2012-03-07 19:12:40 UTC (rev 110074)
+++ trunk/Tools/ChangeLog 2012-03-07 19:18:09 UTC (rev 110075)
@@ -1,3 +1,27 @@
+2012-03-07 James Robinson jam...@chromium.org
+
+[chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
+https://bugs.webkit.org/show_bug.cgi?id=80521
+
+Reviewed by Kenneth Russell.
+
+Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
+to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
+renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
+
+Covered by platform/chromium/compositing/plugins/*
+
+* DumpRenderTree/chromium/TestWebPlugin.cpp:
+(TestWebPlugin::TestWebPlugin):
+(TestWebPlugin::initialize):
+(TestWebPlugin::updateGeometry):
+(TestWebPlugin::initScene):
+(TestWebPlugin::destroyScene):
+* DumpRenderTree/chromium/TestWebPlugin.h:
+(TestWebPlugin):
+* DumpRenderTree/chromium/WebViewHost.cpp:
+(WebViewHost::createPlugin):
+
2012-03-07 Philippe Normand pnorm...@igalia.com
[GTK] remove webkitpy dependency in run-gtk-tests
Modified: trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp (110074 => 110075)
--- trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp 2012-03-07 19:12:40 UTC (rev 110074)
+++ trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp 2012-03-07 19:18:09 UTC (rev 110075)
@@ -32,7 +32,6 @@
#include platform/WebKitPlatformSupport.h
#include WebPluginContainer.h
#include WebPluginParams.h
-#include WebViewClient.h
#include wtf/Assertions.h
#include wtf/text/CString.h
@@ -44,15 +43,29 @@
#define GL_ONE1
#define GL_TRIANGLES 0x0004
#define GL_ONE_MINUS_SRC_ALPHA0x0303
+#define GL_DEPTH_TEST 0x0B71
#define GL_BLEND 0x0BE2
+#define GL_SCISSOR_TEST 0x0B90
+#define GL_TEXTURE_2D 0x0DE1
#define GL_FLOAT 0x1406
+#define GL_RGBA 0x1908
+#define GL_UNSIGNED_BYTE 0x1401
+#define GL_TEXTURE_MAG_FILTER 0x2800
+#define GL_TEXTURE_MIN_FILTER 0x2801
+#define GL_TEXTURE_WRAP_S 0x2802
+#define GL_TEXTURE_WRAP_T 0x2803
+#define GL_NEAREST0x2600
#define GL_COLOR_BUFFER_BIT 0x4000
+#define GL_CLAMP_TO_EDGE 0x812F
#define GL_ARRAY_BUFFER 0x8892
#define GL_STATIC_DRAW0x88E4
#define GL_FRAGMENT_SHADER0x8B30
#define GL_VERTEX_SHADER 0x8B31
#define GL_COMPILE_STATUS 0x8B81
#define GL_LINK_STATUS0x8B82
+#define GL_COLOR_ATTACHMENT0 0x8CE0
+#define GL_FRAMEBUFFER_COMPLETE 0x8CD5
+#define GL_FRAMEBUFFER0x8D40
static void premultiplyAlpha(const unsigned colorIn[3], float alpha, float colorOut[4])
{
@@ -62,11 +75,9 @@
colorOut[3] = alpha;
}
-TestWebPlugin::TestWebPlugin(WebKit::WebViewClient* webViewClient,
- WebKit::WebFrame* frame,
+TestWebPlugin::TestWebPlugin(WebKit::WebFrame* frame,
const WebKit::WebPluginParams params)
-: m_webViewClient(webViewClient)
-, m_frame(frame)
+: m_frame(frame)
, m_container(0)
, m_context(0)
{
@@ -105,7 +116,7 @@
bool TestWebPlugin::initialize(WebPluginContainer* container)
{
WebGraphicsContext3D::Attributes attrs;
-m_context = m_webViewClient-createGraphicsContext3D(attrs, false);
+m_context = webKitPlatformSupport()-createOffscreenGraphicsContext3D(attrs);
if (!m_context)
return false;
@@ -116,7 +127,7 @@
return false;
[webkit-changes] [110076] trunk/Source/WebKit/blackberry
Title: [110076] trunk/Source/WebKit/blackberry
Revision 110076
Author commit-qu...@webkit.org
Date 2012-03-07 11:23:44 -0800 (Wed, 07 Mar 2012)
Log Message
[BlackBerry] WebKit rendering problem when show/hide VKB
https://bugs.webkit.org/show_bug.cgi?id=80448
RIM PR: 141727
Patch by Jacky Jiang zhaji...@rim.com on 2012-03-07
Reviewed by Antonio Gomes.
When setting viewport size, layout happens inside
WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
outside of the code path of needsLayout so that the contents are
not rendered into the backing store. This is a regression of r108718,
switch back to do the layout inside the public API
WebPage::setDefaultLayoutSize().
We haven't upstreamed the manual tests directory yet, therefore,
the new manual test case will be upstreamed later.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (110075 => 110076)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-03-07 19:18:09 UTC (rev 110075)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-03-07 19:23:44 UTC (rev 110076)
@@ -3378,25 +3378,24 @@
void WebPagePrivate::setDefaultLayoutSize(const IntSize size)
{
-if (size == m_defaultLayoutSize)
-return;
-
IntSize screenSize = Platform::Graphics::Screen::primaryScreen()-size();
ASSERT(size.width() = screenSize.width() size.height() = screenSize.height());
m_defaultLayoutSize = size.expandedTo(minimumLayoutSize).shrunkTo(screenSize);
-
-bool needsLayout = setViewMode(viewMode());
-if (needsLayout) {
-setNeedsLayout();
-if (!isLoading())
-requestLayoutIfNeeded();
-}
}
void WebPage::setDefaultLayoutSize(int width, int height)
{
IntSize size(width, height);
+if (size == d-m_defaultLayoutSize)
+return;
+
d-setDefaultLayoutSize(size);
+bool needsLayout = d-setViewMode(d-viewMode());
+if (needsLayout) {
+d-setNeedsLayout();
+if (!d-isLoading())
+d-requestLayoutIfNeeded();
+}
}
bool WebPage::mouseEvent(const Platform::MouseEvent mouseEvent, bool* wheelDeltaAccepted)
Modified: trunk/Source/WebKit/blackberry/ChangeLog (110075 => 110076)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-03-07 19:18:09 UTC (rev 110075)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-03-07 19:23:44 UTC (rev 110076)
@@ -1,3 +1,25 @@
+2012-03-07 Jacky Jiang zhaji...@rim.com
+
+[BlackBerry] WebKit rendering problem when show/hide VKB
+https://bugs.webkit.org/show_bug.cgi?id=80448
+RIM PR: 141727
+
+Reviewed by Antonio Gomes.
+
+When setting viewport size, layout happens inside
+WebPagePrivate::setDefaultLayoutSize(), in this way, the layout is
+outside of the code path of needsLayout so that the contents are
+not rendered into the backing store. This is a regression of r108718,
+switch back to do the layout inside the public API
+WebPage::setDefaultLayoutSize().
+
+We haven't upstreamed the manual tests directory yet, therefore,
+the new manual test case will be upstreamed later.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::setDefaultLayoutSize):
+(BlackBerry::WebKit::WebPage::setDefaultLayoutSize):
+
2012-03-06 Lianghui Chen liac...@rim.com
[BlackBerry] Set correct ResourceRequest target type.
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110077] trunk/Source/WebCore
Title: [110077] trunk/Source/WebCore
Revision 110077
Author commit-qu...@webkit.org
Date 2012-03-07 11:23:52 -0800 (Wed, 07 Mar 2012)
Log Message
[EFL] Revise PlatformKeyboardEventEfl and EflKeyboardUtilities
https://bugs.webkit.org/show_bug.cgi?id=80511
Patch by ChangSeok Oh shivami...@gmail.com on 2012-03-07
Reviewed by Gustavo Noronha Silva.
Added 'const' keyword in front of argument of keyIdentifiersForEvasKeyName/windowsKeyCodeForEvasKeyName.
Since they should not be changed while processing each function.
And initialized missing member variables of PlatformKeyboardEventEfl.
No new tests, since no new feature.
* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::keyIdentifierForEvasKeyName): Added const keyword
(WebCore::windowsKeyCodeForEvasKeyName): Added const keyword
* platform/efl/EflKeyboardUtilities.h:
(WebCore):
* platform/efl/PlatformKeyboardEventEfl.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp
trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h
trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110076 => 110077)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 19:23:44 UTC (rev 110076)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 19:23:52 UTC (rev 110077)
@@ -1,3 +1,24 @@
+2012-03-07 ChangSeok Oh shivami...@gmail.com
+
+[EFL] Revise PlatformKeyboardEventEfl and EflKeyboardUtilities
+https://bugs.webkit.org/show_bug.cgi?id=80511
+
+Reviewed by Gustavo Noronha Silva.
+
+Added 'const' keyword in front of argument of keyIdentifiersForEvasKeyName/windowsKeyCodeForEvasKeyName.
+Since they should not be changed while processing each function.
+And initialized missing member variables of PlatformKeyboardEventEfl.
+
+No new tests, since no new feature.
+
+* platform/efl/EflKeyboardUtilities.cpp:
+(WebCore::keyIdentifierForEvasKeyName): Added const keyword
+(WebCore::windowsKeyCodeForEvasKeyName): Added const keyword
+* platform/efl/EflKeyboardUtilities.h:
+(WebCore):
+* platform/efl/PlatformKeyboardEventEfl.cpp:
+(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
+
2012-03-07 Hironori Bono hb...@chromium.org
[Chromium] Mirror the resizer image of an RTL element when WTF_USE_RTL_SCROLLBAR is 1
Modified: trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp (110076 => 110077)
--- trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-03-07 19:23:44 UTC (rev 110076)
+++ trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.cpp 2012-03-07 19:23:52 UTC (rev 110077)
@@ -166,7 +166,7 @@
}
}
-String keyIdentifierForEvasKeyName(String keyName)
+String keyIdentifierForEvasKeyName(const String keyName)
{
if (keyMap().isEmpty())
createKeyMap();
@@ -188,7 +188,7 @@
return keyName;
}
-int windowsKeyCodeForEvasKeyName(String keyName)
+int windowsKeyCodeForEvasKeyName(const String keyName)
{
if (windowsKeyMap().isEmpty())
createWindowsKeyMap();
Modified: trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h (110076 => 110077)
--- trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h 2012-03-07 19:23:44 UTC (rev 110076)
+++ trunk/Source/WebCore/platform/efl/EflKeyboardUtilities.h 2012-03-07 19:23:52 UTC (rev 110077)
@@ -34,9 +34,9 @@
namespace WebCore {
-WTF::String keyIdentifierForEvasKeyName(WTF::String);
+WTF::String keyIdentifierForEvasKeyName(const WTF::String);
WTF::String singleCharacterString(const WTF::String);
-int windowsKeyCodeForEvasKeyName(WTF::String);
+int windowsKeyCodeForEvasKeyName(const WTF::String);
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp (110076 => 110077)
--- trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2012-03-07 19:23:44 UTC (rev 110076)
+++ trunk/Source/WebCore/platform/efl/PlatformKeyboardEventEfl.cpp 2012-03-07 19:23:52 UTC (rev 110077)
@@ -44,27 +44,28 @@
: PlatformEvent(PlatformEvent::KeyDown, evas_key_modifier_is_set(event-modifiers, Shift), evas_key_modifier_is_set(event-modifiers, Control), evas_key_modifier_is_set(event-modifiers, Alt), evas_key_modifier_is_set(event-modifiers, Meta), currentTime())
, m_text(singleCharacterString(String::fromUTF8(event-string)))
, m_unmodifiedText(singleCharacterString(String::fromUTF8(event-string)))
+, m_keyIdentifier(keyIdentifierForEvasKeyName(String(event-key)))
+, m_windowsVirtualKeyCode(windowsKeyCodeForEvasKeyName(String(event-key)))
+, m_nativeVirtualKeyCode(0)
+, m_macCharCode(0)
+, m_autoRepeat(false)
+, m_isKeypad(false)
+, m_isSystemKey(false)
{
-String keyName = String(event-key);
-m_keyIdentifier = keyIdentifierForEvasKeyName(keyName);
-m_windowsVirtualKeyCode =
[webkit-changes] [110078] trunk/Source/WebCore
Title: [110078] trunk/Source/WebCore
Revision 110078
Author jchaffr...@webkit.org
Date 2012-03-07 11:44:28 -0800 (Wed, 07 Mar 2012)
Log Message
Unreviewed ASSERT failure fix.
https://bugs.webkit.org/show_bug.cgi?id=75568
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::styleDidChange):
Fix a bad merge of the patch, we should call updateCachedSizeForOverflowClip if we lose
our layer.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110077 => 110078)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 19:23:52 UTC (rev 110077)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 19:44:28 UTC (rev 110078)
@@ -1,3 +1,13 @@
+2012-03-07 Julien Chaffraix jchaffr...@webkit.org
+
+Unreviewed ASSERT failure fix.
+https://bugs.webkit.org/show_bug.cgi?id=75568
+
+* rendering/RenderBoxModelObject.cpp:
+(WebCore::RenderBoxModelObject::styleDidChange):
+Fix a bad merge of the patch, we should call updateCachedSizeForOverflowClip if we lose
+our layer.
+
2012-03-07 ChangSeok Oh shivami...@gmail.com
[EFL] Revise PlatformKeyboardEventEfl and EflKeyboardUtilities
Modified: trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp (110077 => 110078)
--- trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2012-03-07 19:23:52 UTC (rev 110077)
+++ trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp 2012-03-07 19:44:28 UTC (rev 110078)
@@ -391,14 +391,14 @@
setChildNeedsLayout(true);
if (s_hadTransform)
setNeedsLayoutAndPrefWidthsRecalc();
+if (hasOverflowClip())
+toRenderBox(this)-updateCachedSizeForOverflowClip();
}
if (layer()) {
layer()-styleChanged(diff, oldStyle);
if (s_hadLayer layer()-isSelfPaintingLayer() != s_layerWasSelfPainting)
setChildNeedsLayout(true);
-if (hasOverflowClip())
-toRenderBox(this)-updateCachedSizeForOverflowClip();
}
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110079] trunk/Tools
Title: [110079] trunk/Tools
Revision 110079
Author o...@chromium.org
Date 2012-03-07 11:50:16 -0800 (Wed, 07 Mar 2012)
Log Message
garden-o-matic rebaseline is broken for ports that don't have a fallback port
https://bugs.webkit.org/show_bug.cgi?id=80526
Reviewed by Adam Barth.
Passing None as the fallback port throws an error in webkit-patch rebaseline-test
since there is no None port.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.rebaseline):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py
trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (110078 => 110079)
--- trunk/Tools/ChangeLog 2012-03-07 19:44:28 UTC (rev 110078)
+++ trunk/Tools/ChangeLog 2012-03-07 19:50:16 UTC (rev 110079)
@@ -1,3 +1,18 @@
+2012-03-07 Ojan Vafai o...@chromium.org
+
+garden-o-matic rebaseline is broken for ports that don't have a fallback port
+https://bugs.webkit.org/show_bug.cgi?id=80526
+
+Reviewed by Adam Barth.
+
+Passing None as the fallback port throws an error in webkit-patch rebaseline-test
+since there is no None port.
+
+* Scripts/webkitpy/tool/servers/gardeningserver.py:
+(GardeningHTTPRequestHandler.rebaseline):
+* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
+(GardeningServerTest.test_rebaseline):
+
2012-03-07 James Robinson jam...@chromium.org
[chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py (110078 => 110079)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2012-03-07 19:44:28 UTC (rev 110078)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver.py 2012-03-07 19:50:16 UTC (rev 110079)
@@ -137,13 +137,15 @@
def rebaseline(self):
builder = self.query['builder'][0]
-test = self.query['test'][0]
-self._run_webkit_patch([
+command = [
'rebaseline-test',
builder,
-test,
-builders.fallback_port_name_for_new_port(builder),
-])
+self.query['test'][0],
+]
+fallback_port = builders.fallback_port_name_for_new_port(builder)
+if fallback_port:
+command.append(fallback_port)
+self._run_webkit_patch(command)
self._serve_text('success')
def optimizebaselines(self):
Modified: trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py (110078 => 110079)
--- trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2012-03-07 19:44:28 UTC (rev 110078)
+++ trunk/Tools/Scripts/webkitpy/tool/servers/gardeningserver_unittest.py 2012-03-07 19:50:16 UTC (rev 110079)
@@ -184,7 +184,7 @@
def test_rebaseline(self):
builders._exact_matches = {MOCK builder: {port_name: mock-port-name, specifiers: set([mock-specifier])}}
-expected_stderr = MOCK run_command: ['echo', 'rebaseline-test', 'MOCK builder', 'user-scripts/another-test.html', None], cwd=/mock-checkout\n
+expected_stderr = MOCK run_command: ['echo', 'rebaseline-test', 'MOCK builder', 'user-scripts/another-test.html'], cwd=/mock-checkout\n
expected_stdout = == Begin Response ==\nsuccess\n== End Response ==\n
self._post_to_path(/rebaseline?builder=MOCK+buildertest=user-scripts/another-test.html, expected_stderr=expected_stderr, expected_stdout=expected_stdout)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110081] trunk/LayoutTests
Title: [110081] trunk/LayoutTests Revision 110081 Author ph...@webkit.org Date 2012-03-07 12:01:58 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed, GTK rebaseline after r110072. * platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt: * platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt: * platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt: * platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt: * platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt: * platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt: * platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt: * platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt: * platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt: * platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt: * platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt: * platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt: * platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt: * platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: * platform/gtk/fast/clip/008-expected.txt: * platform/gtk/fast/clip/011-expected.txt: * platform/gtk/fast/clip/012-expected.txt: * platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt: * platform/gtk/fast/forms/input-text-double-click-expected.txt: * platform/gtk/fast/forms/input-text-drag-down-expected.txt: * platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt: * platform/gtk/fast/forms/textfield-outline-expected.txt: * platform/gtk/fast/forms/textfield-overflow-expected.txt: * platform/gtk/fast/repaint/overflow-delete-line-expected.txt: * platform/gtk/http/tests/navigation/_javascript_link-frames-expected.txt: * platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-24-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-68-expected.txt trunk/LayoutTests/platform/gtk/css3/selectors3/xml/css3-modsel-69-expected.txt trunk/LayoutTests/platform/gtk/editing/selection/select-from-textfield-outwards-expected.txt trunk/LayoutTests/platform/gtk/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt trunk/LayoutTests/platform/gtk/fast/clip/008-expected.txt trunk/LayoutTests/platform/gtk/fast/clip/011-expected.txt trunk/LayoutTests/platform/gtk/fast/clip/012-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/input-readonly-autoscroll-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/input-text-double-click-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/input-text-drag-down-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/input-text-scroll-left-on-blur-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/textfield-outline-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/textfield-overflow-expected.txt trunk/LayoutTests/platform/gtk/fast/repaint/overflow-delete-line-expected.txt trunk/LayoutTests/platform/gtk/http/tests/navigation/_javascript_link-frames-expected.txt trunk/LayoutTests/platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (110080 => 110081) --- trunk/LayoutTests/ChangeLog 2012-03-07 19:58:18 UTC (rev 110080) +++ trunk/LayoutTests/ChangeLog 2012-03-07 20:01:58 UTC (rev 110081) @@ -1,3 +1,34 @@ +2012-03-07 Philippe Normand pnorm...@igalia.com + +Unreviewed, GTK rebaseline after r110072. + +* platform/gtk/css3/selectors3/html/css3-modsel-23-expected.txt: +* platform/gtk/css3/selectors3/html/css3-modsel-24-expected.txt: +* platform/gtk/css3/selectors3/html/css3-modsel-68-expected.txt: +* platform/gtk/css3/selectors3/html/css3-modsel-69-expected.txt: +* platform/gtk/css3/selectors3/xhtml/css3-modsel-23-expected.txt: +* platform/gtk/css3/selectors3/xhtml/css3-modsel-24-expected.txt: +* platform/gtk/css3/selectors3/xhtml/css3-modsel-68-expected.txt: +* platform/gtk/css3/selectors3/xhtml/css3-modsel-69-expected.txt: +* platform/gtk/css3/selectors3/xml/css3-modsel-23-expected.txt: +*
[webkit-changes] [110082] branches/safari-534.54-branch
Title: [110082] branches/safari-534.54-branch
Revision 110082
Author lforsch...@apple.com
Date 2012-03-07 12:02:13 -0800 (Wed, 07 Mar 2012)
Log Message
Merge 109594.
Modified Paths
branches/safari-534.54-branch/LayoutTests/ChangeLog
branches/safari-534.54-branch/Source/WebCore/ChangeLog
branches/safari-534.54-branch/Source/WebCore/bindings/js/JSDOMBinding.cpp
branches/safari-534.54-branch/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp
branches/safari-534.54-branch/Source/WebCore/page/DOMWindow.idl
branches/safari-534.54-branch/Source/WebCore/platform/sql/SQLiteStatement.cpp
Added Paths
branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt
branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties.html
branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html
branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html
Diff
Modified: branches/safari-534.54-branch/LayoutTests/ChangeLog (110081 => 110082)
--- branches/safari-534.54-branch/LayoutTests/ChangeLog 2012-03-07 20:01:58 UTC (rev 110081)
+++ branches/safari-534.54-branch/LayoutTests/ChangeLog 2012-03-07 20:02:13 UTC (rev 110082)
@@ -1,3 +1,19 @@
+2012-03-07 Lucas Forschler lforsch...@apple.com
+
+Merge 109594
+
+2012-03-02 Maciej Stachowiak m...@apple.com
+
+REGRESSION(r97353): Crash when accessing location or history properties inside a navigated window
+https://bugs.webkit.org/show_bug.cgi?id=80133
+
+Reviewed by Antti Koivisto.
+
+* fast/dom/Window/navigated-window-properties-expected.txt: Added.
+* fast/dom/Window/navigated-window-properties.html: Added.
+* fast/dom/Window/resources/navigated-window-prop-subframe1.html: Added.
+* fast/dom/Window/resources/navigated-window-prop-subframe2.html: Added.
+
2011-02-13 Lucas Forschler lforsch...@apple.com
Merge 107496
Copied: branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt (from rev 109594, trunk/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt) (0 => 110082)
--- branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt (rev 0)
+++ branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties-expected.txt 2012-03-07 20:02:13 UTC (rev 110082)
@@ -0,0 +1,3 @@
+Accessing properties of a navigated window shouldn't crash
+
+
Copied: branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties.html (from rev 109594, trunk/LayoutTests/fast/dom/Window/navigated-window-properties.html) (0 => 110082)
--- branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties.html (rev 0)
+++ branches/safari-534.54-branch/LayoutTests/fast/dom/Window/navigated-window-properties.html 2012-03-07 20:02:13 UTC (rev 110082)
@@ -0,0 +1,26 @@
+!DOCTYPE html
+titleProperties of a navigated window shouldn't crash/title
+
+pAccessing properties of a navigated window shouldn't crash/p
+
+script
+if (window.layoutTestController) {
+layoutTestController.waitUntilDone();
+layoutTestController.dumpAsText();
+}
+
+
+var func;
+function testPhase1() {
+var subframe = document.getElementById(subframe);
+func = subframe.contentWindow.testFunction;
+subframe.src = ""
+}
+
+function testPhase2() {
+func();
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+/script
+iframe id=subframe src=""
Copied: branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html (from rev 109594, trunk/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html) (0 => 110082)
--- branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html (rev 0)
+++ branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe1.html 2012-03-07 20:02:13 UTC (rev 110082)
@@ -0,0 +1,9 @@
+script
+function testFunction() {
+try {
+ var s = location.href + history.length;
+} catch (e) {
+}
+}
+parent.testPhase1();
+/script
Copied: branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html (from rev 109594, trunk/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html) (0 => 110082)
--- branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html (rev 0)
+++ branches/safari-534.54-branch/LayoutTests/fast/dom/Window/resources/navigated-window-prop-subframe2.html 2012-03-07 20:02:13 UTC (rev 110082)
@@ -0,0 +1,3 @@
+script
+parent.testPhase2();
+/script
Modified:
[webkit-changes] [110083] branches/safari-534.54-branch/Source
Title: [110083] branches/safari-534.54-branch/Source Revision 110083 Author lforsch...@apple.com Date 2012-03-07 12:06:06 -0800 (Wed, 07 Mar 2012) Log Message Versioning. Modified Paths branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (110082 => 110083) --- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-03-07 20:02:13 UTC (rev 110082) +++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (110082 => 110083) --- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-03-07 20:02:13 UTC (rev 110082) +++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (110082 => 110083) --- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-03-07 20:02:13 UTC (rev 110082) +++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (110082 => 110083) --- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-03-07 20:02:13 UTC (rev 110082) +++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (110082 => 110083) --- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-03-07 20:02:13 UTC (rev 110082) +++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110084] branches/safari-534.54-branch/Source
Title: [110084] branches/safari-534.54-branch/Source Revision 110084 Author lforsch...@apple.com Date 2012-03-07 12:10:31 -0800 (Wed, 07 Mar 2012) Log Message Rollout 110083 Modified Paths branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (110083 => 110084) --- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) +++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-03-07 20:10:31 UTC (rev 110084) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 18; +TINY_VERSION = 17; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (110083 => 110084) --- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) +++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-03-07 20:10:31 UTC (rev 110084) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 18; +TINY_VERSION = 17; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (110083 => 110084) --- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) +++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-03-07 20:10:31 UTC (rev 110084) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 18; +TINY_VERSION = 17; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (110083 => 110084) --- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) +++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-03-07 20:10:31 UTC (rev 110084) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 18; +TINY_VERSION = 17; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (110083 => 110084) --- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-03-07 20:06:06 UTC (rev 110083) +++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-03-07 20:10:31 UTC (rev 110084) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 18; +TINY_VERSION = 17; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110085] trunk/Source/WebKit2
Title: [110085] trunk/Source/WebKit2
Revision 110085
Author m...@apple.com
Date 2012-03-07 12:23:37 -0800 (Wed, 07 Mar 2012)
Log Message
rdar://problem/8494396 WebKit2 lacks API for obtaining a representation of the render tree of a page, like WebRenderNode
https://bugs.webkit.org/show_bug.cgi?id=80230
Reviewed by Beth Dakin.
* CMakeLists.txt:
* GNUmakefile.am:
* Shared/API/c/WKBase.h: Added a type definition of WKRenderObjectRef.
* Shared/API/c/WKRenderObject.cpp: Added.
(WKRenderObjectGetTypeID): Added. Returns the WKRenderObject type ID.
(WKRenderObjectCopyName): Added this getter wrapper.
(WKRenderObjectGetAbsolutePosition): Ditto.
(WKRenderObjectGetFrameRect): Ditto.
(WKRenderObjectGetChildren): Ditto.
* Shared/API/c/WKRenderObject.h: Added.
* Shared/APIObject.h: Added TypeRenderObject to the APIObject::Type enum.
* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode): Added WebRenderObject encoding.
(WebKit::UserMessageDecoder::baseDecode): Added WebRenderObject decoding.
* Shared/WebRenderObject.cpp: Added.
(WebKit::WebRenderObject::create): Added. Creates a WebRenderObject for the page’s main
frame content renderer.
(WebKit::WebRenderObject::WebRenderObject): Added. Constructs a WebRenderObject with the
name, metrics and children of the given RenderObject, following the rules used in WebKit1
WebRenderNode. In particular, a RenderWidget representing a frame gets the frame’s content
renderer as a child.
* Shared/WebRenderObject.h: Added.
(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::children):
(WebKit::WebRenderObject::name):
(WebKit::WebRenderObject::absolutePosition):
(WebKit::WebRenderObject::frameRect):
(WebKit::WebRenderObject::WebRenderObject):
* Target.pri:
* UIProcess/API/C/WKAPICast.h: Added a mapping between WKRenderObjectRef and WebRenderObject.
* WebKit2.xcodeproj/project.pbxproj: Added WebRenderObject.{cpp,h} and WKRenderObject.{cpp.h}.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyRenderTree): Added this bundle API for getting the render tree.
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
* win/WebKit2.vcproj:
Modified Paths
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/Source/WebKit2/Shared/API/c/WKBase.h
trunk/Source/WebKit2/Shared/APIObject.h
trunk/Source/WebKit2/Shared/UserMessageCoders.h
trunk/Source/WebKit2/Target.pri
trunk/Source/WebKit2/UIProcess/API/C/WKAPICast.h
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h
trunk/Source/WebKit2/win/WebKit2.vcproj
Added Paths
trunk/Source/WebKit2/Shared/API/c/WKRenderObject.cpp
trunk/Source/WebKit2/Shared/API/c/WKRenderObject.h
trunk/Source/WebKit2/Shared/WebRenderObject.cpp
trunk/Source/WebKit2/Shared/WebRenderObject.h
Diff
Modified: trunk/Source/WebKit2/CMakeLists.txt (110084 => 110085)
--- trunk/Source/WebKit2/CMakeLists.txt 2012-03-07 20:10:31 UTC (rev 110084)
+++ trunk/Source/WebKit2/CMakeLists.txt 2012-03-07 20:23:37 UTC (rev 110085)
@@ -155,6 +155,7 @@
Shared/WebPopupItem.cpp
Shared/WebPreferencesStore.cpp
Shared/WebProcessCreationParameters.cpp
+Shared/WebRenderObject.cpp
Shared/WebTouchEvent.cpp
Shared/WebURLRequest.cpp
Shared/WebURLResponse.cpp
@@ -173,6 +174,7 @@
Shared/API/c/WKMutableArray.cpp
Shared/API/c/WKMutableDictionary.cpp
Shared/API/c/WKNumber.cpp
+Shared/API/c/WKRenderObject.cpp
Shared/API/c/WKSecurityOrigin.cpp
Shared/API/c/WKSerializedScriptValue.cpp
Shared/API/c/WKString.cpp
Modified: trunk/Source/WebKit2/ChangeLog (110084 => 110085)
--- trunk/Source/WebKit2/ChangeLog 2012-03-07 20:10:31 UTC (rev 110084)
+++ trunk/Source/WebKit2/ChangeLog 2012-03-07 20:23:37 UTC (rev 110085)
@@ -1,3 +1,57 @@
+2012-03-07 Dan Bernstein m...@apple.com
+
+rdar://problem/8494396 WebKit2 lacks API for obtaining a representation of the render tree of a page, like WebRenderNode
+https://bugs.webkit.org/show_bug.cgi?id=80230
+
+Reviewed by Beth Dakin.
+
+* CMakeLists.txt:
+* GNUmakefile.am:
+
+* Shared/API/c/WKBase.h: Added a type definition of WKRenderObjectRef.
+
+* Shared/API/c/WKRenderObject.cpp: Added.
+(WKRenderObjectGetTypeID): Added. Returns the WKRenderObject type ID.
+(WKRenderObjectCopyName): Added this getter wrapper.
+(WKRenderObjectGetAbsolutePosition): Ditto.
+(WKRenderObjectGetFrameRect): Ditto.
+(WKRenderObjectGetChildren): Ditto.
+
+* Shared/API/c/WKRenderObject.h: Added.
+
+* Shared/APIObject.h: Added TypeRenderObject to the APIObject::Type enum.
+* Shared/UserMessageCoders.h:
+(WebKit::UserMessageEncoder::baseEncode): Added WebRenderObject encoding.
+(WebKit::UserMessageDecoder::baseDecode): Added
[webkit-changes] [110086] trunk/Source/WebCore
Title: [110086] trunk/Source/WebCore
Revision 110086
Author caio.olive...@openbossa.org
Date 2012-03-07 12:37:32 -0800 (Wed, 07 Mar 2012)
Log Message
Implement removeAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
https://bugs.webkit.org/show_bug.cgi?id=80522
Reviewed by Andreas Kling.
DOM methods exposed in Element and NamedNodeMap are now implemented in terms of
ElementAttributeData. A helper function takeAttribute() was added to increase
code sharing. Also removed some unneeded methods.
* dom/Element.cpp:
(WebCore::Element::removeAttribute): Use ElementAttributeData function directly.
(WebCore::Element::removeAttributeNode): Get the index manually and use new
takeAttribute() directly.
* dom/Element.h:
(Element): Remove unused removeAttribute(unsigned index).
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::takeAttribute): Like removeAttribute() but
returns a reference to old Attr.
(WebCore):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::removeNamedItem): Avoid looking up the property twice by
getting the index directly from the name, instead of going through the qualified name.
* dom/NamedNodeMap.h: Remove now unused internal methods for removing attributes.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.cpp
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/ElementAttributeData.cpp
trunk/Source/WebCore/dom/ElementAttributeData.h
trunk/Source/WebCore/dom/NamedNodeMap.cpp
trunk/Source/WebCore/dom/NamedNodeMap.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (110085 => 110086)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 20:23:37 UTC (rev 110085)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 20:37:32 UTC (rev 110086)
@@ -1,3 +1,31 @@
+2012-03-07 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
+
+Implement removeAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
+https://bugs.webkit.org/show_bug.cgi?id=80522
+
+Reviewed by Andreas Kling.
+
+DOM methods exposed in Element and NamedNodeMap are now implemented in terms of
+ElementAttributeData. A helper function takeAttribute() was added to increase
+code sharing. Also removed some unneeded methods.
+
+* dom/Element.cpp:
+(WebCore::Element::removeAttribute): Use ElementAttributeData function directly.
+(WebCore::Element::removeAttributeNode): Get the index manually and use new
+takeAttribute() directly.
+* dom/Element.h:
+(Element): Remove unused removeAttribute(unsigned index).
+* dom/ElementAttributeData.cpp:
+(WebCore::ElementAttributeData::takeAttribute): Like removeAttribute() but
+returns a reference to old Attr.
+(WebCore):
+* dom/ElementAttributeData.h:
+(ElementAttributeData):
+* dom/NamedNodeMap.cpp:
+(WebCore::NamedNodeMap::removeNamedItem): Avoid looking up the property twice by
+getting the index directly from the name, instead of going through the qualified name.
+* dom/NamedNodeMap.h: Remove now unused internal methods for removing attributes.
+
2012-03-07 Alexey Proskuryakov a...@apple.com
Merge AsyncFileStream with FileStreamProxy
Modified: trunk/Source/WebCore/dom/Element.cpp (110085 => 110086)
--- trunk/Source/WebCore/dom/Element.cpp 2012-03-07 20:23:37 UTC (rev 110085)
+++ trunk/Source/WebCore/dom/Element.cpp 2012-03-07 20:37:32 UTC (rev 110086)
@@ -186,10 +186,9 @@
void Element::removeAttribute(const QualifiedName name)
{
-if (!m_attributeMap)
+if (!attributeData())
return;
-
-m_attributeMap-removeAttribute(name);
+attributeData()-removeAttribute(name, this);
}
void Element::setBooleanAttribute(const QualifiedName name, bool value)
@@ -1417,11 +1416,17 @@
ASSERT(document() == attr-document());
-NamedNodeMap* attrs = updatedAttributes();
-if (!attrs)
+ElementAttributeData* attributeData = updatedAttributeData();
+if (!attributeData)
return 0;
-return static_pointer_castAttr(attrs-removeNamedItem(attr-qualifiedName(), ec));
+size_t index = attributeData-getAttributeItemIndex(attr-qualifiedName());
+if (index == notFound) {
+ec = NOT_FOUND_ERR;
+return 0;
+}
+
+return attributeData-takeAttribute(index, this);
}
void Element::setAttributeNS(const AtomicString namespaceURI, const AtomicString qualifiedName, const AtomicString value, ExceptionCode ec, FragmentScriptingPermission scriptingPermission)
Modified: trunk/Source/WebCore/dom/Element.h (110085 => 110086)
--- trunk/Source/WebCore/dom/Element.h 2012-03-07 20:23:37 UTC (rev 110085)
+++ trunk/Source/WebCore/dom/Element.h 2012-03-07 20:37:32 UTC (rev 110086)
@@ -160,7 +160,6 @@
size_t attributeCount() const;
Attribute* attributeItem(unsigned index) const;
Attribute*
[webkit-changes] [110087] trunk/LayoutTests
Title: [110087] trunk/LayoutTests Revision 110087 Author senorbla...@chromium.org Date 2012-03-07 12:44:49 -0800 (Wed, 07 Mar 2012) Log Message [Chromium] Unreviewed gardening. Adding some more test suppressions post r110072. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110086 => 110087) --- trunk/LayoutTests/ChangeLog 2012-03-07 20:37:32 UTC (rev 110086) +++ trunk/LayoutTests/ChangeLog 2012-03-07 20:44:49 UTC (rev 110087) @@ -1,3 +1,11 @@ +2012-03-07 Stephen White senorbla...@chromium.org + +[Chromium] Unreviewed gardening. + +Adding some more test suppressions post r110072. + +* platform/chromium/test_expectations.txt: + 2012-03-07 Philippe Normand pnorm...@igalia.com Unreviewed, GTK rebaseline after r110072. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110086 => 110087) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 20:37:32 UTC (rev 110086) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 20:44:49 UTC (rev 110087) @@ -3833,7 +3833,7 @@ // Those tests have other entries in our expectations filed and may not totally covers BUGWK75568 RELEASE : animations/combo-transform-translate+scale.html = TEXT BUGWK75568 LINUX DEBUG : animations/combo-transform-translate+scale.html = TEXT -BUGWK75568 WIN LINUX : editing/spelling/inline_spelling_markers.html = TEXT +BUGWK75568 : editing/spelling/inline_spelling_markers.html = TEXT BUGWK75568 WIN LINUX : fast/forms/form-element-geometry.html = TEXT BUGWK75568 WIN LINUX : fast/forms/input-value.html = TEXT BUGWK75568 WIN LINUX : fast/layers/add-layer-with-nested-stacking.html = TEXT @@ -3849,6 +3849,13 @@ BUGWK75568 WIN LINUX : fast/replaced/replaced-breaking.html = TEXT BUGWK75568 WIN LINUX : fast/replaced/width100percent-searchfield.html = TEXT BUGWK75568 WIN LINUX : fast/text/textIteratorNilRenderer.html = TEXT +BUGWK75568 MAC : editing/selection/select-from-textfield-outwards.html = IMAGE+TEXT +BUGWK75568 MAC : fast/block/lineboxcontain/block-glyphs-replaced.html = TEXT +BUGWK75568 MAC : fast/block/lineboxcontain/glyphs.html = TEXT +BUGWK75568 MAC : fast/clip/011.html = TEXT +BUGWK75568 MAC : fast/clip/012.html = TEXT +BUGWK75568 WIN MAC : fast/forms/input-text-double-click.html = TEXT +BUGWK75568 : http/tests/navigation/_javascript_link-frames.html = TEXT // Those tests need a text baseline after lazily allocating layers. // The change should only be layer removal. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110089] trunk/Source
Title: [110089] trunk/Source
Revision 110089
Author benja...@webkit.org
Date 2012-03-07 12:57:29 -0800 (Wed, 07 Mar 2012)
Log Message
[Mac] Update the configuration files for iOS
https://bugs.webkit.org/show_bug.cgi?id=80435
Patch by Benjamin Poulain bpoul...@apple.com on 2012-03-06
Reviewed by David Kilzer.
Source/WebCore:
* Configurations/WebCore.xcconfig:
Source/WebKit/mac:
* Configurations/WebKit.xcconfig:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/WebCore.xcconfig
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/Configurations/WebKit.xcconfig
Diff
Modified: trunk/Source/WebCore/ChangeLog (110088 => 110089)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 20:46:11 UTC (rev 110088)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 20:57:29 UTC (rev 110089)
@@ -1,3 +1,12 @@
+2012-03-06 Benjamin Poulain bpoul...@apple.com
+
+[Mac] Update the configuration files for iOS
+https://bugs.webkit.org/show_bug.cgi?id=80435
+
+Reviewed by David Kilzer.
+
+* Configurations/WebCore.xcconfig:
+
2012-03-07 Dana Jansens dan...@chromium.org
[chromium] Cull occluded tiles during paint
Modified: trunk/Source/WebCore/Configurations/WebCore.xcconfig (110088 => 110089)
--- trunk/Source/WebCore/Configurations/WebCore.xcconfig 2012-03-07 20:46:11 UTC (rev 110088)
+++ trunk/Source/WebCore/Configurations/WebCore.xcconfig 2012-03-07 20:57:29 UTC (rev 110089)
@@ -26,10 +26,11 @@
EXPORTED_SYMBOLS_FILE = $(EXPORTED_SYMBOLS_FILE_$(CURRENT_ARCH));
EXPORTED_SYMBOLS_FILE_ = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.exp;
-EXPORTED_SYMBOLS_FILE_armv5 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.exp;
-EXPORTED_SYMBOLS_FILE_armv6 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.exp;
-EXPORTED_SYMBOLS_FILE_armv7 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.exp;
-EXPORTED_SYMBOLS_FILE_i386 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.exp;
+EXPORTED_SYMBOLS_FILE_armv6 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.armv6.exp;
+EXPORTED_SYMBOLS_FILE_armv7 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.armv7.exp;
+EXPORTED_SYMBOLS_FILE_i386 = $(EXPORTED_SYMBOLS_FILE_i386_$(REAL_PLATFORM_NAME));
+EXPORTED_SYMBOLS_FILE_i386_iphonesimulator = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.i386.exp;
+EXPORTED_SYMBOLS_FILE_i386_macosx = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.exp;
EXPORTED_SYMBOLS_FILE_ppc = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.exp;
EXPORTED_SYMBOLS_FILE_ppc64 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.exp;
EXPORTED_SYMBOLS_FILE_x86_64 = $(BUILT_PRODUCTS_DIR)/DerivedSources/WebCore/WebCore.LP64.exp;
@@ -49,8 +50,15 @@
HEADER_SEARCH_PATHS = ForwardingHeaders icu /usr/include/libxslt /usr/include/libxml2 $(SQLITE3_HEADER_SEARCH_PATHS) ${BUILT_PRODUCTS_DIR}/DerivedSources/WebCore ${BUILT_PRODUCTS_DIR}/usr/local/include $(HEADER_SEARCH_PATHS);
INFOPLIST_FILE = Info.plist;
INSTALL_PATH = $(INSTALL_PATH_$(REAL_PLATFORM_NAME));
+INSTALL_PATH_iphoneos = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+INSTALL_PATH_iphonesimulator = $(INDIGO_INSTALL_PATH_PREFIX)$(INSTALL_PATH_ACTUAL);
INSTALL_PATH_macosx = $(WEBCORE_FRAMEWORKS_DIR);
-DYLIB_INSTALL_NAME_BASE = $(NORMAL_WEBCORE_FRAMEWORKS_DIR);
+INSTALL_PATH_ACTUAL = $(INSTALL_PATH_ACTUAL_$(REAL_PLATFORM_NAME));
+INSTALL_PATH_ACTUAL_iphonesimulator = $(INSTALL_PATH_iphoneos);
+DYLIB_INSTALL_NAME_BASE = $(DYLIB_INSTALL_NAME_BASE_$(REAL_PLATFORM_NAME));
+DYLIB_INSTALL_NAME_BASE_macosx = $(NORMAL_WEBCORE_FRAMEWORKS_DIR);
+DYLIB_INSTALL_NAME_BASE_iphoneos = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+DYLIB_INSTALL_NAME_BASE_iphonesimulator = $(SDKROOT)$(DYLIB_INSTALL_NAME_BASE_iphoneos);
INSTALLHDRS_COPY_PHASE = YES;
INSTALLHDRS_SCRIPT_PHASE = YES;
PRODUCT_NAME = WebCore;
@@ -77,7 +85,7 @@
WEBCORE_FRAMEWORKS_DIR_macosx_USE_STAGING_INSTALL_PATH_YES = $(SYSTEM_LIBRARY_DIR)/StagedFrameworks/Safari;
NORMAL_PRODUCTION_FRAMEWORKS_DIR = $(NORMAL_PRODUCTION_FRAMEWORKS_DIR_$(REAL_PLATFORM_NAME));
-NORMAL_PRODUCTION_FRAMEWORKS_DIR_iphoneos = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
+NORMAL_PRODUCTION_FRAMEWORKS_DIR_iphoneos = $(SDKROOT)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
NORMAL_PRODUCTION_FRAMEWORKS_DIR_iphonesimulator = $(NORMAL_PRODUCTION_FRAMEWORKS_DIR_iphoneos);
NORMAL_PRODUCTION_FRAMEWORKS_DIR_macosx = $(NEXT_ROOT)$(SYSTEM_LIBRARY_DIR)/Frameworks;
Modified: trunk/Source/WebKit/mac/ChangeLog (110088 => 110089)
--- trunk/Source/WebKit/mac/ChangeLog 2012-03-07 20:46:11 UTC (rev 110088)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-03-07 20:57:29 UTC (rev 110089)
@@ -1,3 +1,12 @@
+2012-03-06 Benjamin Poulain bpoul...@apple.com
+
+[Mac] Update the configuration files for iOS
+https://bugs.webkit.org/show_bug.cgi?id=80435
+
+Reviewed by David Kilzer.
+
+* Configurations/WebKit.xcconfig:
+
2012-03-06
[webkit-changes] [110091] trunk/Source/WebCore
Title: [110091] trunk/Source/WebCore
Revision 110091
Author commit-qu...@webkit.org
Date 2012-03-07 13:02:44 -0800 (Wed, 07 Mar 2012)
Log Message
RenderImage ignores its percent width/height when setContainerSizeForRenderer
https://bugs.webkit.org/show_bug.cgi?id=80431
Patch by Yong Li y...@rim.com on 2012-03-07
Reviewed by George Staikos.
Not only respect fixed width/height explicitly specified in img element, but also
respect percent width/height when determining container size for images.
No new tests because there is no functional change but only internal buffer sizes.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::computeReplacedLogicalWidth):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderImage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110090 => 110091)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 20:57:51 UTC (rev 110090)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 21:02:44 UTC (rev 110091)
@@ -1,3 +1,18 @@
+2012-03-07 Yong Li y...@rim.com
+
+RenderImage ignores its percent width/height when setContainerSizeForRenderer
+https://bugs.webkit.org/show_bug.cgi?id=80431
+
+Reviewed by George Staikos.
+
+Not only respect fixed width/height explicitly specified in img element, but also
+respect percent width/height when determining container size for images.
+
+No new tests because there is no functional change but only internal buffer sizes.
+
+* rendering/RenderImage.cpp:
+(WebCore::RenderImage::computeReplacedLogicalWidth):
+
2012-03-06 Benjamin Poulain bpoul...@apple.com
[Mac] Update the configuration files for iOS
Modified: trunk/Source/WebCore/rendering/RenderImage.cpp (110090 => 110091)
--- trunk/Source/WebCore/rendering/RenderImage.cpp 2012-03-07 20:57:51 UTC (rev 110090)
+++ trunk/Source/WebCore/rendering/RenderImage.cpp 2012-03-07 21:02:44 UTC (rev 110091)
@@ -504,8 +504,8 @@
LayoutUnit RenderImage::computeReplacedLogicalWidth(bool includeMaxWidth) const
{
-// If we've got an explicit width/height assigned, propagate it to the image resource.
-if (style()-logicalWidth().isFixed() style()-logicalHeight().isFixed()) {
+// If we've got an explicit width/height assigned, propagate it to the image resource.
+if (style()-logicalWidth().isSpecified() style()-logicalHeight().isSpecified()) {
LayoutUnit width = RenderReplaced::computeReplacedLogicalWidth(includeMaxWidth);
m_imageResource-setContainerSizeForRenderer(IntSize(width, computeReplacedLogicalHeight()));
return width;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110092] trunk/LayoutTests
Title: [110092] trunk/LayoutTests Revision 110092 Author ph...@webkit.org Date 2012-03-07 13:13:17 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed, skip a test failing on GTK after r110072. * platform/gtk/Skipped: fast/events/autoscroll-in-textfield.html now fails. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (110091 => 110092) --- trunk/LayoutTests/ChangeLog 2012-03-07 21:02:44 UTC (rev 110091) +++ trunk/LayoutTests/ChangeLog 2012-03-07 21:13:17 UTC (rev 110092) @@ -1,3 +1,10 @@ +2012-03-07 Philippe Normand pnorm...@igalia.com + +Unreviewed, skip a test failing on GTK after r110072. + +* platform/gtk/Skipped: fast/events/autoscroll-in-textfield.html +now fails. + 2012-03-07 Julien Chaffraix jchaffr...@webkit.org Unreviewed rebaseline after r110072. Modified: trunk/LayoutTests/platform/gtk/Skipped (110091 => 110092) --- trunk/LayoutTests/platform/gtk/Skipped 2012-03-07 21:02:44 UTC (rev 110091) +++ trunk/LayoutTests/platform/gtk/Skipped 2012-03-07 21:13:17 UTC (rev 110092) @@ -1587,3 +1587,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=80158 plugins/netscape-plugin-page-cache-works.html + +# https://bugs.webkit.org/show_bug.cgi?id=80534 +fast/events/autoscroll-in-textfield.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110093] trunk/Source
Title: [110093] trunk/Source
Revision 110093
Author commit-qu...@webkit.org
Date 2012-03-07 13:13:24 -0800 (Wed, 07 Mar 2012)
Log Message
Get ScrollAnimatorNone to handle the stop and reverse cases.
https://bugs.webkit.org/show_bug.cgi?id=80455
Patch by Scott Byer scottb...@chromium.org on 2012-03-07
Reviewed by James Robinson.
Source/WebCore:
Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollStopInMiddle and
ScrollAnimatorNoneTest.ReverseInMiddle.
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
Source/WebKit/chromium:
* tests/ScrollAnimatorNoneTest.cpp:
(ScrollAnimatorNoneTest::updateDataFromParameters):
(TEST_F):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110092 => 110093)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 21:13:17 UTC (rev 110092)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 21:13:24 UTC (rev 110093)
@@ -1,3 +1,16 @@
+2012-03-07 Scott Byer scottb...@chromium.org
+
+Get ScrollAnimatorNone to handle the stop and reverse cases.
+https://bugs.webkit.org/show_bug.cgi?id=80455
+
+Reviewed by James Robinson.
+
+Chromium webkit_unit_tests ScrollAnimatorNoneTest.ScrollStopInMiddle and
+ScrollAnimatorNoneTest.ReverseInMiddle.
+
+* platform/ScrollAnimatorNone.cpp:
+(WebCore::ScrollAnimatorNone::PerAxisData::updateDataFromParameters):
+
2012-03-07 Yong Li y...@rim.com
RenderImage ignores its percent width/height when setContainerSizeForRenderer
Modified: trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp (110092 => 110093)
--- trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp 2012-03-07 21:13:17 UTC (rev 110092)
+++ trunk/Source/WebCore/platform/ScrollAnimatorNone.cpp 2012-03-07 21:13:24 UTC (rev 110093)
@@ -235,9 +235,12 @@
bool ScrollAnimatorNone::PerAxisData::updateDataFromParameters(float step, float multiplier, float scrollableSize, double currentTime, Parameters* parameters)
{
-if (!m_startTime)
+float delta = step * multiplier;
+if (!m_startTime || !delta || (delta 0) != (m_desiredPosition - *m_currentPosition 0)) {
m_desiredPosition = *m_currentPosition;
-float newPosition = m_desiredPosition + (step * multiplier);
+m_startTime = 0;
+}
+float newPosition = m_desiredPosition + delta;
if (newPosition 0 || newPosition scrollableSize)
newPosition = max(min(newPosition, scrollableSize), 0.0f);
Modified: trunk/Source/WebKit/chromium/ChangeLog (110092 => 110093)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-07 21:13:17 UTC (rev 110092)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-07 21:13:24 UTC (rev 110093)
@@ -1,3 +1,14 @@
+2012-03-07 Scott Byer scottb...@chromium.org
+
+Get ScrollAnimatorNone to handle the stop and reverse cases.
+https://bugs.webkit.org/show_bug.cgi?id=80455
+
+Reviewed by James Robinson.
+
+* tests/ScrollAnimatorNoneTest.cpp:
+(ScrollAnimatorNoneTest::updateDataFromParameters):
+(TEST_F):
+
2012-03-07 Dana Jansens dan...@chromium.org
[chromium] Cull occluded tiles during paint
Modified: trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp (110092 => 110093)
--- trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp 2012-03-07 21:13:17 UTC (rev 110092)
+++ trunk/Source/WebKit/chromium/tests/ScrollAnimatorNoneTest.cpp 2012-03-07 21:13:24 UTC (rev 110093)
@@ -231,7 +231,8 @@
bool ScrollAnimatorNoneTest::updateDataFromParameters(float step, float multiplier, float scrollableSize, double currentTime, ScrollAnimatorNone::Parameters* parameters)
{
-m_scrollingDown = (step * multiplier 0);
+if (step * multiplier)
+m_scrollingDown = (step * multiplier 0);
double oldVelocity = m_data-m_currentVelocity;
double oldDesiredVelocity = m_data-m_desiredVelocity;
@@ -249,16 +250,18 @@
double sustainTimeLeft = max(0., timeLeft - releaseTimeLeft - attackTimeLeft);
// If we're getting near the finish, the desired velocity can decrease since the time left gets increased.
-double allowedVelocityDecreaseFactor = 0.99 * oldTimeLeft / timeLeft;
-allowedVelocityDecreaseFactor *= allowedVelocityDecreaseFactor;
-if (m_scrollingDown)
-EXPECT_LE(oldDesiredVelocity * allowedVelocityDecreaseFactor, m_data-m_desiredVelocity);
-else
-EXPECT_GE(oldDesiredVelocity * allowedVelocityDecreaseFactor, m_data-m_desiredVelocity);
+if (step * multiplier) {
+double allowedVelocityDecreaseFactor = 0.99 * oldTimeLeft / timeLeft;
+allowedVelocityDecreaseFactor *= allowedVelocityDecreaseFactor;
+if (m_scrollingDown)
+EXPECT_LE(oldDesiredVelocity * allowedVelocityDecreaseFactor,
[webkit-changes] [110094] trunk/LayoutTests
Title: [110094] trunk/LayoutTests Revision 110094 Author senorbla...@chromium.org Date 2012-03-07 13:14:20 -0800 (Wed, 07 Mar 2012) Log Message [chromium] Unreviewed gardening. More post-r110072 mopup. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110093 => 110094) --- trunk/LayoutTests/ChangeLog 2012-03-07 21:13:24 UTC (rev 110093) +++ trunk/LayoutTests/ChangeLog 2012-03-07 21:14:20 UTC (rev 110094) @@ -1,3 +1,11 @@ +2012-03-07 Stephen White senorbla...@chromium.org + +[chromium] Unreviewed gardening. + +More post-r110072 mopup. + +* platform/chromium/test_expectations.txt: + 2012-03-07 Philippe Normand pnorm...@igalia.com Unreviewed, skip a test failing on GTK after r110072. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110093 => 110094) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 21:13:24 UTC (rev 110093) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 21:14:20 UTC (rev 110094) @@ -1683,7 +1683,6 @@ BUGCR11251 LINUX WIN : fast/forms/textarea-metrics.html = FAIL // Regresssions from WebKit Merge 43114:43242 that just need to be re-baselined. -BUGCR11483 LINUX : fast/forms/input-text-double-click.html = FAIL BUGCR11483 LINUX : svg/text/foreignObject-repaint.xml = FAIL // WebKit 45017:45086 @@ -3985,6 +3984,7 @@ BUGWK75568 : tables/mozilla/bugs/bug2479-2.html = TEXT BUGWK75568 : tables/mozilla/bugs/bug2479-3.html = TEXT BUGWK75568 : tables/mozilla/bugs/bug2479-4.html = TEXT +BUGWK75568 : tables/mozilla_expected_failures/bugs/bug2479-5.html = TEXT BUGWK75568 : tables/mozilla/bugs/bug28928.html = TEXT BUGWK75568 : tables/mozilla/bugs/bug4382.html = TEXT BUGWK75568 : tables/mozilla/bugs/bug44505.html = TEXT @@ -4012,5 +4012,8 @@ BUGWK75568 : fast/table/spanOverlapRepaint.html = TEXT BUGWK75568 : fast/table/text-field-baseline.html = TEXT BUGWK75568 : tables/mozilla/bugs/bug1188.html = TEXT +BUGWK75568 : fast/forms/input-text-double-click.html = TEXT +BUGWK75568 : http/tests/navigation/_javascript_link-frames.html = TEXT +BUGWK80531 : fast/repaint/search-field-cancel.html = TEXT IMAGE+TEXT BUGWK80531 : fast/forms/textfield-overflow.html = IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110095] trunk
Title: [110095] trunk
Revision 110095
Author eric.carl...@apple.com
Date 2012-03-07 13:26:03 -0800 (Wed, 07 Mar 2012)
Log Message
Html5 video element Useragent string is Quicktime
https://bugs.webkit.org/show_bug.cgi?id=46241
Reviewed by Daniel Bates.
Source/WebCore:
Test: http/tests/media/video-useragent.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerUserAgent): Return the UA string for the current source.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::userAgent): New, return the client's mediaPlayerUserAgent.
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerUserAgent):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): Tell AVFoundation to set
the UA header.
LayoutTests:
* http/tests/media/resources/serve-video.php: Added.
* http/tests/media/resources/video-check-useragent.php: Added.
* http/tests/media/resources/video-referer-check-referer.php: Split media loading logic
out into serve-video.php.
* http/tests/media/video-useragent-expected.txt: Added.
* http/tests/media/video-useragent.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/media/resources/video-referer-check-referer.php
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm
Added Paths
trunk/LayoutTests/http/tests/media/resources/serve-video.php
trunk/LayoutTests/http/tests/media/resources/video-check-useragent.php
trunk/LayoutTests/http/tests/media/video-useragent-expected.txt
trunk/LayoutTests/http/tests/media/video-useragent.html
Diff
Modified: trunk/LayoutTests/ChangeLog (110094 => 110095)
--- trunk/LayoutTests/ChangeLog 2012-03-07 21:14:20 UTC (rev 110094)
+++ trunk/LayoutTests/ChangeLog 2012-03-07 21:26:03 UTC (rev 110095)
@@ -1,3 +1,17 @@
+2012-03-07 Eric Carlson eric.carl...@apple.com
+
+Html5 video element Useragent string is Quicktime
+https://bugs.webkit.org/show_bug.cgi?id=46241
+
+Reviewed by Daniel Bates.
+
+* http/tests/media/resources/serve-video.php: Added.
+* http/tests/media/resources/video-check-useragent.php: Added.
+* http/tests/media/resources/video-referer-check-referer.php: Split media loading logic
+out into serve-video.php.
+* http/tests/media/video-useragent-expected.txt: Added.
+* http/tests/media/video-useragent.html: Added.
+
2012-03-07 Stephen White senorbla...@chromium.org
[chromium] Unreviewed gardening.
Added: trunk/LayoutTests/http/tests/media/resources/serve-video.php (0 => 110095)
--- trunk/LayoutTests/http/tests/media/resources/serve-video.php (rev 0)
+++ trunk/LayoutTests/http/tests/media/resources/serve-video.php 2012-03-07 21:26:03 UTC (rev 110095)
@@ -0,0 +1,46 @@
+?php
+
+$fileName = $_GET[name];
+$type = $_GET[type];
+
+$fileSize = filesize($fileName);
+$start = 0;
+$end = $fileSize - 1;
+$contentRange = $_SERVER[HTTP_RANGE];
+if (isset($contentRange)) {
+$range = explode(-, substr($contentRange, strlen(bytes=)));
+$start = intval($range[0]);
+if (!empty($range[1]))
+$end = intval($range[1]);
+$httpStatus = HTTP/1.1 206 Partial Content;
+} else
+$httpStatus = 200 OK;
+
+header(Status: . $httpStatus);
+header(Last-Modified: . gmdate(D, d M Y H:i:s) . GMT);
+header(Pragma: no-cache);
+header(Etag: . '' . $fileSize . - . filemtime($fileName) . '');
+header(Content-Type: . $type);
+header(Accept-Ranges: bytes);
+header(Content-Length: . ($end - $start) + 1);
+if ($contentRange)
+ header(Content-Range: bytes . $start . - . $end . / . $fileSize);
+header(Connection: close);
+
+$chunkSize = 1024 * 256;
+$offset = $start;
+
+$fn = fopen($fileName, rb);
+fseek($fn, $offset, 0);
+
+while (!feof($fn) $offset = $end connection_status() == 0) {
+$readSize = min($chunkSize, ($end - $offset) + 1);
+$buffer = fread($fn, $readSize);
+print($buffer);
+flush();
+$offset += $chunkSize;
+}
+fclose($fn);
+
+exit;
+?
Added: trunk/LayoutTests/http/tests/media/resources/video-check-useragent.php (0 => 110095)
--- trunk/LayoutTests/http/tests/media/resources/video-check-useragent.php (rev 0)
+++ trunk/LayoutTests/http/tests/media/resources/video-check-useragent.php 2012-03-07 21:26:03 UTC (rev 110095)
@@ -0,0 +1,16 @@
+?php
+
+$ua = $_SERVER[HTTP_USER_AGENT];
+
+if (!isset($ua) || stripos($ua, WebKit/) === false || stripos($ua, (KHTML, like Gecko))
[webkit-changes] [110097] trunk/Tools
Title: [110097] trunk/Tools
Revision 110097
Author o...@chromium.org
Date 2012-03-07 13:42:29 -0800 (Wed, 07 Mar 2012)
Log Message
Automatically move to the next test after rebaseline in the results view
https://bugs.webkit.org/show_bug.cgi?id=80527
Reviewed by Dimitri Glazkov.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js (110096 => 110097)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-03-07 21:32:34 UTC (rev 110096)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js 2012-03-07 21:42:29 UTC (rev 110097)
@@ -87,6 +87,7 @@
onRebaseline: function()
{
rebaselineWithStatusUpdates(this._failureInfoList());
+this._view.nextTest();
},
onUpdateExpectations: function()
{
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js (110096 => 110097)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-03-07 21:32:34 UTC (rev 110096)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js 2012-03-07 21:42:29 UTC (rev 110097)
@@ -339,6 +339,14 @@
{
return this._testSelector.previousResult();
},
+nextTest: function()
+{
+return this._testSelector.nextTest();
+},
+previousTest: function()
+{
+return this._testSelector.previousTest();
+},
firstResult: function()
{
this._testSelector.firstResult()
Modified: trunk/Tools/ChangeLog (110096 => 110097)
--- trunk/Tools/ChangeLog 2012-03-07 21:32:34 UTC (rev 110096)
+++ trunk/Tools/ChangeLog 2012-03-07 21:42:29 UTC (rev 110097)
@@ -1,5 +1,15 @@
2012-03-07 Ojan Vafai o...@chromium.org
+Automatically move to the next test after rebaseline in the results view
+https://bugs.webkit.org/show_bug.cgi?id=80527
+
+Reviewed by Dimitri Glazkov.
+
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
+* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
+
+2012-03-07 Ojan Vafai o...@chromium.org
+
garden-o-matic rebaseline is broken for ports that don't have a fallback port
https://bugs.webkit.org/show_bug.cgi?id=80526
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110098] trunk/Source/WebKit2
Title: [110098] trunk/Source/WebKit2
Revision 110098
Author commit-qu...@webkit.org
Date 2012-03-07 13:43:37 -0800 (Wed, 07 Mar 2012)
Log Message
[Qt] Authentication dialog does not work
https://bugs.webkit.org/show_bug.cgi?id=79738
Patch by Dinu Jacob dinu.ja...@nokia.com on 2012-03-07
Reviewed by Simon Hausmann.
QQuickWebView should accept touch events only if there is
no active dialog.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::QQuickWebViewPrivate):
(QQuickWebViewPrivate::runJavaScriptAlert):
(QQuickWebViewPrivate::runJavaScriptConfirm):
(QQuickWebViewPrivate::runJavaScriptPrompt):
(QQuickWebViewPrivate::handleAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
(QQuickWebViewPrivate::handleCertificateVerificationRequest):
(QQuickWebView::touchEvent):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (110097 => 110098)
--- trunk/Source/WebKit2/ChangeLog 2012-03-07 21:42:29 UTC (rev 110097)
+++ trunk/Source/WebKit2/ChangeLog 2012-03-07 21:43:37 UTC (rev 110098)
@@ -1,3 +1,25 @@
+2012-03-07 Dinu Jacob dinu.ja...@nokia.com
+
+[Qt] Authentication dialog does not work
+https://bugs.webkit.org/show_bug.cgi?id=79738
+
+Reviewed by Simon Hausmann.
+
+QQuickWebView should accept touch events only if there is
+no active dialog.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::QQuickWebViewPrivate):
+(QQuickWebViewPrivate::runJavaScriptAlert):
+(QQuickWebViewPrivate::runJavaScriptConfirm):
+(QQuickWebViewPrivate::runJavaScriptPrompt):
+(QQuickWebViewPrivate::handleAuthenticationRequiredRequest):
+(QQuickWebViewPrivate::handleProxyAuthenticationRequiredRequest):
+(QQuickWebViewPrivate::handleCertificateVerificationRequest):
+(QQuickWebView::touchEvent):
+* UIProcess/API/qt/qquickwebview_p_p.h:
+(QQuickWebViewPrivate):
+
2012-03-07 Dan Bernstein m...@apple.com
rdar://problem/8494396 WebKit2 lacks API for obtaining a representation of the render tree of a page, like WebRenderNode
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (110097 => 110098)
--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-03-07 21:42:29 UTC (rev 110097)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp 2012-03-07 21:43:37 UTC (rev 110098)
@@ -81,6 +81,7 @@
, m_navigatorQtObjectEnabled(false)
, m_renderToOffscreenBuffer(false)
, m_loadStartedSignalSent(false)
+, m_dialogRunnerActive(false)
{
viewport-setFlags(QQuickItem::ItemClipsChildrenToShape);
QObject::connect(viewport, SIGNAL(visibleChanged()), viewport, SLOT(_q_onVisibleChanged()));
@@ -267,7 +268,10 @@
setViewInAttachedProperties(dialogRunner.dialog());
disableMouseEvents();
+m_dialogRunnerActive = true;
+
dialogRunner.exec();
+m_dialogRunnerActive = false;
enableMouseEvents();
}
@@ -283,7 +287,10 @@
setViewInAttachedProperties(dialogRunner.dialog());
disableMouseEvents();
+m_dialogRunnerActive = true;
+
dialogRunner.exec();
+m_dialogRunnerActive = false;
enableMouseEvents();
return dialogRunner.wasAccepted();
@@ -305,7 +312,10 @@
setViewInAttachedProperties(dialogRunner.dialog());
disableMouseEvents();
+m_dialogRunnerActive = true;
+
dialogRunner.exec();
+m_dialogRunnerActive = false;
enableMouseEvents();
ok = dialogRunner.wasAccepted();
@@ -325,7 +335,10 @@
setViewInAttachedProperties(dialogRunner.dialog());
disableMouseEvents();
+m_dialogRunnerActive = true;
+
dialogRunner.exec();
+m_dialogRunnerActive = false;
enableMouseEvents();
username = dialogRunner.username();
@@ -344,7 +357,10 @@
setViewInAttachedProperties(dialogRunner.dialog());
disableMouseEvents();
+m_dialogRunnerActive = true;
+
dialogRunner.exec();
+m_dialogRunnerActive = false;
enableMouseEvents();
username = dialogRunner.username();
@@ -364,7 +380,10 @@
setViewInAttachedProperties(dialogRunner.dialog());
disableMouseEvents();
+m_dialogRunnerActive = true;
+
dialogRunner.exec();
+m_dialogRunnerActive = false;
enableMouseEvents();
return dialogRunner.wasAccepted();
@@ -1343,6 +1362,11 @@
void QQuickWebView::touchEvent(QTouchEvent* event)
{
Q_D(QQuickWebView);
+if (d-m_dialogRunnerActive) {
+event-ignore();
+return;
+}
+
forceActiveFocus();
d-pageView-eventHandler()-handleTouchEvent(event);
}
Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview_p_p.h (110097 => 110098)
---
[webkit-changes] [110099] trunk/Source/WebCore
Title: [110099] trunk/Source/WebCore Revision 110099 Author commit-qu...@webkit.org Date 2012-03-07 13:57:15 -0800 (Wed, 07 Mar 2012) Log Message [chromium] Update GYP files to reflect file deletes/renames https://bugs.webkit.org/show_bug.cgi?id=80525 Patch by Ryan Sleevi rsle...@chromium.org on 2012-03-07 Reviewed by Ryosuke Niwa. No change in functionality, so no tests. * WebCore.gypi: Updated AppleMac private headers due to r109877 Updated platform/qt references due to r109542 Updated platform/mac references due to r109147 Updated platform/mac references due to r108956 Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.gypi Diff Modified: trunk/Source/WebCore/ChangeLog (110098 => 110099) --- trunk/Source/WebCore/ChangeLog 2012-03-07 21:43:37 UTC (rev 110098) +++ trunk/Source/WebCore/ChangeLog 2012-03-07 21:57:15 UTC (rev 110099) @@ -1,3 +1,18 @@ +2012-03-07 Ryan Sleevi rsle...@chromium.org + +[chromium] Update GYP files to reflect file deletes/renames +https://bugs.webkit.org/show_bug.cgi?id=80525 + +Reviewed by Ryosuke Niwa. + +No change in functionality, so no tests. + +* WebCore.gypi: +Updated AppleMac private headers due to r109877 +Updated platform/qt references due to r109542 +Updated platform/mac references due to r109147 +Updated platform/mac references due to r108956 + 2012-03-07 Eric Carlson eric.carl...@apple.com Html5 video element Useragent string is Quicktime Modified: trunk/Source/WebCore/WebCore.gypi (110098 => 110099) --- trunk/Source/WebCore/WebCore.gypi 2012-03-07 21:43:37 UTC (rev 110098) +++ trunk/Source/WebCore/WebCore.gypi 2012-03-07 21:57:15 UTC (rev 110099) @@ -193,6 +193,21 @@ 'loader/icon/IconDatabaseBase.h', 'loader/icon/IconDatabaseClient.h', 'loader/mac/LoaderNSURLExtras.h', +'Modules/webdatabase/AbstractDatabase.h', +'Modules/webdatabase/Database.h', +'Modules/webdatabase/DatabaseDetails.h', +'Modules/webdatabase/DatabaseTracker.h', +'Modules/webdatabase/DatabaseTrackerClient.h', +'Modules/webdatabase/SQLError.h', +'Modules/webdatabase/SQLResultSet.h', +'Modules/webdatabase/SQLResultSetRowList.h', +'Modules/webdatabase/SQLStatementCallback.h', +'Modules/webdatabase/SQLStatementErrorCallback.h', +'Modules/webdatabase/SQLTransaction.h', +'Modules/webdatabase/SQLTransactionCallback.h', +'Modules/webdatabase/SQLTransactionErrorCallback.h', +'Modules/webdatabase/StorageTracker.h', +'Modules/webdatabase/StorageTrackerClient.h', 'notifications/NotificationContents.h', 'notifications/NotificationController.h', 'notifications/NotificationPresenter.h', @@ -550,22 +565,6 @@ 'rendering/style/StyleTransformData.h', 'rendering/style/StyleVisualData.h', 'rendering/svg/SVGResourcesCache.h', -'storage/AbstractDatabase.h', -'storage/Database.h', -'storage/DatabaseDetails.h', -'storage/DatabaseTracker.h', -'storage/DatabaseTrackerClient.h', -'storage/SQLError.h', -'storage/SQLResultSet.h', -'storage/SQLResultSetRowList.h', -'storage/SQLStatement.h', -'storage/SQLStatementCallback.h', -'storage/SQLStatementErrorCallback.h', -'storage/SQLTransaction.h', -'storage/SQLTransactionCallback.h', -'storage/SQLTransactionErrorCallback.h', -'storage/StorageTracker.h', -'storage/StorageTrackerClient.h', 'workers/WorkerRunLoop.h', 'workers/WorkerThread.h', ], @@ -4012,12 +4011,11 @@ 'platform/mac/Language.mm', 'platform/mac/LocalCurrentGraphicsContext.h', 'platform/mac/LocalCurrentGraphicsContext.mm', -'platform/mac/LocalizedStringsMac.mm', +'platform/mac/LocalizedStringsMac.cpp', 'platform/mac/LoggingMac.mm', 'platform/mac/MIMETypeRegistryMac.mm', 'platform/mac/NSScrollerImpDetails.h', 'platform/mac/NSScrollerImpDetails.mm', -'platform/mac/PasteboardHelper.h', 'platform/mac/PasteboardMac.mm', 'platform/mac/PlatformClockCA.cpp', 'platform/mac/PlatformScreenMac.mm', @@ -4224,14 +4222,11 @@ 'platform/qt/PlatformTouchEventQt.cpp', 'platform/qt/PlatformTouchPointQt.cpp', 'platform/qt/QWebPageClient.h', -'platform/qt/QtStyleOptionWebComboBox.h', 'platform/qt/RenderThemeQt.cpp', 'platform/qt/RenderThemeQt.h', 'platform/qt/ScreenQt.cpp', 'platform/qt/ScrollViewQt.cpp', -
[webkit-changes] [110100] trunk/Source/WebCore
Title: [110100] trunk/Source/WebCore
Revision 110100
Author nd...@chromium.org
Date 2012-03-07 13:59:37 -0800 (Wed, 07 Mar 2012)
Log Message
[chromium] Remove unused wasRecreate variable
https://bugs.webkit.org/show_bug.cgi?id=80533
Reviewed by Adrienne Walker.
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110099 => 110100)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 21:57:15 UTC (rev 110099)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 21:59:37 UTC (rev 110100)
@@ -1,3 +1,13 @@
+2012-03-07 Nat Duca nd...@chromium.org
+
+[chromium] Remove unused wasRecreate variable
+https://bugs.webkit.org/show_bug.cgi?id=80533
+
+Reviewed by Adrienne Walker.
+
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
+(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
+
2012-03-07 Ryan Sleevi rsle...@chromium.org
[chromium] Update GYP files to reflect file deletes/renames
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp (110099 => 110100)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-07 21:57:15 UTC (rev 110099)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp 2012-03-07 21:59:37 UTC (rev 110100)
@@ -405,11 +405,9 @@
OwnPtrLayerRendererChromium layerRenderer;
layerRenderer = LayerRendererChromium::create(this, context);
-bool wasRecreate = false;
if (m_layerRenderer) {
m_layerRenderer-close();
sendDidLoseContextRecursive(m_rootLayerImpl.get());
-wasRecreate = true;
}
m_layerRenderer = layerRenderer.release();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110101] trunk/LayoutTests
Title: [110101] trunk/LayoutTests Revision 110101 Author schen...@chromium.org Date 2012-03-07 14:07:48 -0800 (Wed, 07 Mar 2012) Log Message [Chromium] Unexpected changes in SVG animated filter results https://bugs.webkit.org/show_bug.cgi?id=80517 Unreviewed Chromium test_expectations update. A test is failing in Debug builds on mac and Win. No idea why. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110100 => 110101) --- trunk/LayoutTests/ChangeLog 2012-03-07 21:59:37 UTC (rev 110100) +++ trunk/LayoutTests/ChangeLog 2012-03-07 22:07:48 UTC (rev 110101) @@ -1,3 +1,14 @@ +2012-03-07 Stephen Chenney schen...@chromium.org + +[Chromium] Unexpected changes in SVG animated filter results +https://bugs.webkit.org/show_bug.cgi?id=80517 + +Unreviewed Chromium test_expectations update. + +A test is failing in Debug builds on mac and Win. No idea why. + +* platform/chromium/test_expectations.txt: + 2012-03-07 Ojan Vafai o...@chromium.org Initial rebaselines for the Chromium Lion port. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110100 => 110101) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 21:59:37 UTC (rev 110100) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 22:07:48 UTC (rev 110101) @@ -3692,12 +3692,13 @@ // These require more investigation. There is a small change, probably two pixels, in the filter offset // when comparing the former and new results. This may be due to bad test design or may be revealing a bug // in the code. Turbulence results are very different. -BUGWK78219 : svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html = IMAGE -BUGWK78219 : svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html = IMAGE -BUGWK78219 : svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html = IMAGE -BUGWK78219 : svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html = IMAGE -BUGWK78219 : svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html = IMAGE -BUGWK78219 : svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html = IMAGE +BUGWK80517 : svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr.html = IMAGE +BUGWK80517 : svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetY-attr.html = IMAGE +BUGWK80517 : svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop.html = IMAGE +BUGWK80517 : svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html = IMAGE +BUGWK80517 : svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html = IMAGE +BUGWK80517 : svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html = IMAGE +BUGWK80517 MAC WIN DEBUG : svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html = IMAGE // Test is acting extra flakey on Mac and Win Debug BUGCR114777 MAC : compositing/culling/filter-occlusion-blur-large.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110102] trunk/LayoutTests
Title: [110102] trunk/LayoutTests Revision 110102 Author schen...@chromium.org Date 2012-03-07 14:17:28 -0800 (Wed, 07 Mar 2012) Log Message [Chromium] Unexpected changes in SVG animated results https://bugs.webkit.org/show_bug.cgi?id=80517 Unreviewed chromium test expectations. Linux debug is failing too. Very odd. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110101 => 110102) --- trunk/LayoutTests/ChangeLog 2012-03-07 22:07:48 UTC (rev 110101) +++ trunk/LayoutTests/ChangeLog 2012-03-07 22:17:28 UTC (rev 110102) @@ -1,5 +1,16 @@ 2012-03-07 Stephen Chenney schen...@chromium.org +[Chromium] Unexpected changes in SVG animated results +https://bugs.webkit.org/show_bug.cgi?id=80517 + +Unreviewed chromium test expectations. + +Linux debug is failing too. Very odd. + +* platform/chromium/test_expectations.txt: + +2012-03-07 Stephen Chenney schen...@chromium.org + [Chromium] Unexpected changes in SVG animated filter results https://bugs.webkit.org/show_bug.cgi?id=80517 Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110101 => 110102) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 22:07:48 UTC (rev 110101) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 22:17:28 UTC (rev 110102) @@ -3698,7 +3698,7 @@ BUGWK80517 : svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetY-prop.html = IMAGE BUGWK80517 : svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr.html = IMAGE BUGWK80517 : svg/dynamic-updates/SVGFETurbulenceElement-svgdom-baseFrequency-prop.html = IMAGE -BUGWK80517 MAC WIN DEBUG : svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html = IMAGE +BUGWK80517 DEBUG : svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html = IMAGE PASS // Test is acting extra flakey on Mac and Win Debug BUGCR114777 MAC : compositing/culling/filter-occlusion-blur-large.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110103] branches/subpixellayout/Source/WebCore
Title: [110103] branches/subpixellayout/Source/WebCore
Revision 110103
Author e...@chromium.org
Date 2012-03-07 14:21:14 -0800 (Wed, 07 Mar 2012)
Log Message
Change scrollWidth/Height to ints and get rid of pixelSnapped version on subpixel branch.
Modified Paths
branches/subpixellayout/Source/WebCore/dom/Document.cpp
branches/subpixellayout/Source/WebCore/html/TextFieldInputType.cpp
branches/subpixellayout/Source/WebCore/platform/ScrollView.h
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderLayer.h
branches/subpixellayout/Source/WebCore/rendering/RenderListBox.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderScrollbar.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderScrollbar.h
branches/subpixellayout/Source/WebCore/rendering/RenderScrollbarTheme.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderTreeAsText.cpp
Diff
Modified: branches/subpixellayout/Source/WebCore/dom/Document.cpp (110102 => 110103)
--- branches/subpixellayout/Source/WebCore/dom/Document.cpp 2012-03-07 22:17:28 UTC (rev 110102)
+++ branches/subpixellayout/Source/WebCore/dom/Document.cpp 2012-03-07 22:21:14 UTC (rev 110103)
@@ -1245,9 +1245,9 @@
return 0;
float zoomFactor = frame-pageZoomFactor();
-LayoutPoint point = LayoutPoint(x * zoomFactor + frameView-scrollX(), y * zoomFactor + frameView-scrollY());
+IntPoint point = roundedIntPoint(FloatPoint(x * zoomFactor + frameView-scrollX(), y * zoomFactor + frameView-scrollY()));
-if (!frameView-visibleContentRect().contains(roundedIntPoint(point)))
+if (!frameView-visibleContentRect().contains(point))
return 0;
HitTestRequest request(HitTestRequest::ReadOnly | HitTestRequest::Active);
Modified: branches/subpixellayout/Source/WebCore/html/TextFieldInputType.cpp (110102 => 110103)
--- branches/subpixellayout/Source/WebCore/html/TextFieldInputType.cpp 2012-03-07 22:17:28 UTC (rev 110102)
+++ branches/subpixellayout/Source/WebCore/html/TextFieldInputType.cpp 2012-03-07 22:21:14 UTC (rev 110103)
@@ -173,7 +173,7 @@
if (event-type() == eventNames().blurEvent) {
if (RenderBox* innerTextRenderer = innerTextElement()-renderBox()) {
if (RenderLayer* innerLayer = innerTextRenderer-layer())
-innerLayer-scrollToOffset(!renderTextControl-style()-isLeftToRightDirection() ? innerLayer-scrollWidth().toInt() : 0, 0, RenderLayer::ScrollOffsetClamped);
+innerLayer-scrollToOffset(!renderTextControl-style()-isLeftToRightDirection() ? innerLayer-scrollWidth() : 0, 0, RenderLayer::ScrollOffsetClamped);
}
renderTextControl-capsLockStateMayHaveChanged();
Modified: branches/subpixellayout/Source/WebCore/platform/ScrollView.h (110102 => 110103)
--- branches/subpixellayout/Source/WebCore/platform/ScrollView.h 2012-03-07 22:17:28 UTC (rev 110102)
+++ branches/subpixellayout/Source/WebCore/platform/ScrollView.h 2012-03-07 22:21:14 UTC (rev 110103)
@@ -27,7 +27,7 @@
#ifndef ScrollView_h
#define ScrollView_h
-#include LayoutTypes.h
+#include IntRect.h
#include Scrollbar.h
#include ScrollableArea.h
#include ScrollTypes.h
@@ -170,7 +170,7 @@
IntPoint maximumScrollPosition() const; // The maximum position we can be scrolled to.
IntPoint minimumScrollPosition() const; // The minimum position we can be scrolled to.
// Adjust the passed in scroll position to keep it between the minimum and maximum positions.
-IntPoint adjustScrollPositionWithinRange(const IntPoint) const;
+IntPoint adjustScrollPositionWithinRange(const IntPoint) const;
int scrollX() const { return scrollPosition().x(); }
int scrollY() const { return scrollPosition().y(); }
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp (110102 => 110103)
--- branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp 2012-03-07 22:17:28 UTC (rev 110102)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderLayer.cpp 2012-03-07 22:21:14 UTC (rev 110103)
@@ -1387,7 +1387,7 @@
scrollByRecursively(adjustedScrollDelta(xDelta), adjustedScrollDelta(yDelta), ScrollOffsetClamped);
}
-void RenderLayer::scrollByRecursively(LayoutUnit xDelta, LayoutUnit yDelta, ScrollOffsetClamping clamp)
+void RenderLayer::scrollByRecursively(int xDelta, int yDelta, ScrollOffsetClamping clamp)
{
if (!xDelta !yDelta)
return;
@@ -1397,13 +1397,13 @@
restrictedByLineClamp = !renderer()-parent()-style()-lineClamp().isNone();
if (renderer()-hasOverflowClip() !restrictedByLineClamp) {
-LayoutUnit newOffsetX = scrollXOffset() + xDelta;
-LayoutUnit newOffsetY = scrollYOffset() + yDelta;
+int newOffsetX = scrollXOffset() + xDelta;
+int newOffsetY = scrollYOffset() + yDelta;
scrollToOffset(newOffsetX, newOffsetY, clamp);
// If this layer can't do the scroll we ask the
[webkit-changes] [110104] trunk/Source
Title: [110104] trunk/Source
Revision 110104
Author jsb...@chromium.org
Date 2012-03-07 14:29:49 -0800 (Wed, 07 Mar 2012)
Log Message
[Chromium] IndexedDB: V8LocalContext creation in IDBKey extraction/injection is slow
https://bugs.webkit.org/show_bug.cgi?id=80358
Source/WebCore:
Cache a re-usable context (per isolate) for cases like IDB's key/SSV extraction/injection,
where no user script is run. This yields a 3x-4x performance improvement in basic IDB
operations.
Reviewed by Tony Chang.
No new tests - no behavior changes.
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
(WebCore::injectIDBKeyIntoSerializedValue):
* bindings/v8/V8Binding.h:
(WebCore::V8BindingPerIsolateData::auxiliaryContext):
(V8BindingPerIsolateData):
* bindings/v8/V8Utilities.cpp:
(WebCore::V8AuxiliaryContext::V8AuxiliaryContext):
(WebCore::V8AuxiliaryContext::~V8AuxiliaryContext):
(WebCore::V8AuxiliaryContext::auxiliaryContext):
* bindings/v8/V8Utilities.h:
(V8AuxiliaryContext):
Source/WebKit/chromium:
Reviewed by Tony Chang.
* tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp
trunk/Source/WebCore/bindings/v8/V8Binding.h
trunk/Source/WebCore/bindings/v8/V8Utilities.cpp
trunk/Source/WebCore/bindings/v8/V8Utilities.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/tests/IDBBindingUtilitiesTest.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110103 => 110104)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 22:21:14 UTC (rev 110103)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 22:29:49 UTC (rev 110104)
@@ -1,3 +1,29 @@
+2012-03-07 Joshua Bell jsb...@chromium.org
+
+[Chromium] IndexedDB: V8LocalContext creation in IDBKey extraction/injection is slow
+https://bugs.webkit.org/show_bug.cgi?id=80358
+
+Cache a re-usable context (per isolate) for cases like IDB's key/SSV extraction/injection,
+where no user script is run. This yields a 3x-4x performance improvement in basic IDB
+operations.
+
+Reviewed by Tony Chang.
+
+No new tests - no behavior changes.
+
+* bindings/v8/IDBBindingUtilities.cpp:
+(WebCore::createIDBKeyFromSerializedValueAndKeyPath):
+(WebCore::injectIDBKeyIntoSerializedValue):
+* bindings/v8/V8Binding.h:
+(WebCore::V8BindingPerIsolateData::auxiliaryContext):
+(V8BindingPerIsolateData):
+* bindings/v8/V8Utilities.cpp:
+(WebCore::V8AuxiliaryContext::V8AuxiliaryContext):
+(WebCore::V8AuxiliaryContext::~V8AuxiliaryContext):
+(WebCore::V8AuxiliaryContext::auxiliaryContext):
+* bindings/v8/V8Utilities.h:
+(V8AuxiliaryContext):
+
2012-03-07 Nat Duca nd...@chromium.org
[chromium] Remove unused wasRecreate variable
Modified: trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp (110103 => 110104)
--- trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp 2012-03-07 22:21:14 UTC (rev 110103)
+++ trunk/Source/WebCore/bindings/v8/IDBBindingUtilities.cpp 2012-03-07 22:29:49 UTC (rev 110104)
@@ -151,7 +151,7 @@
PassRefPtrIDBKey createIDBKeyFromSerializedValueAndKeyPath(PassRefPtrSerializedScriptValue value, const VectorString keyPath)
{
IDB_TRACE(createIDBKeyFromSerializedValueAndKeyPath);
-V8LocalContext localContext;
+V8AuxiliaryContext context;
v8::Handlev8::Value v8Value(value-deserialize());
v8::Handlev8::Value v8Key(getNthValueOnKeyPath(v8Value, keyPath, keyPath.size()));
if (v8Key.IsEmpty())
@@ -162,7 +162,7 @@
PassRefPtrSerializedScriptValue injectIDBKeyIntoSerializedValue(PassRefPtrIDBKey key, PassRefPtrSerializedScriptValue value, const VectorString keyPath)
{
IDB_TRACE(injectIDBKeyIntoSerializedValue);
-V8LocalContext localContext;
+V8AuxiliaryContext context;
if (!keyPath.size())
return 0;
Modified: trunk/Source/WebCore/bindings/v8/V8Binding.h (110103 => 110104)
--- trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-03-07 22:21:14 UTC (rev 110103)
+++ trunk/Source/WebCore/bindings/v8/V8Binding.h 2012-03-07 22:29:49 UTC (rev 110104)
@@ -129,6 +129,7 @@
DOMDataList allStores() { return m_domDataList; }
V8HiddenPropertyName* hiddenPropertyName() { return m_hiddenPropertyName; }
+v8::Persistentv8::Context auxiliaryContext() { return m_auxiliaryContext; }
void registerDOMDataStore(DOMDataStore* domDataStore)
{
@@ -169,6 +170,7 @@
DOMDataStore* m_domDataStore;
V8HiddenPropertyName m_hiddenPropertyName;
+v8::Persistentv8::Context m_auxiliaryContext;
bool m_constructorMode;
friend class ConstructorMode;
Modified: trunk/Source/WebCore/bindings/v8/V8Utilities.cpp (110103 => 110104)
--- trunk/Source/WebCore/bindings/v8/V8Utilities.cpp 2012-03-07 22:21:14 UTC (rev 110103)
+++
[webkit-changes] [110105] trunk/LayoutTests
Title: [110105] trunk/LayoutTests Revision 110105 Author senorbla...@chromium.org Date 2012-03-07 14:36:43 -0800 (Wed, 07 Mar 2012) Log Message [chromium] Unreviewed gardening. More post-r110072 mopup (mac remix). * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110104 => 110105) --- trunk/LayoutTests/ChangeLog 2012-03-07 22:29:49 UTC (rev 110104) +++ trunk/LayoutTests/ChangeLog 2012-03-07 22:36:43 UTC (rev 110105) @@ -1,3 +1,11 @@ +2012-03-07 Stephen White senorbla...@chromium.org + +[chromium] Unreviewed gardening. + +More post-r110072 mopup (mac remix). + +* platform/chromium/test_expectations.txt: + 2012-03-07 Stephen Chenney schen...@chromium.org [Chromium] Unexpected changes in SVG animated results Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110104 => 110105) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 22:29:49 UTC (rev 110104) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 22:36:43 UTC (rev 110105) @@ -1359,9 +1359,6 @@ BUGCR23496 MAC : fast/forms/input-value.html = IMAGE+TEXT BUGCR23496 MAC : fast/inline/positionedLifetime.html = IMAGE BUGCR23496 MAC : fast/parser/bad-xml-slash.html = IMAGE -BUGCR23496 MAC : fast/replaced/replaced-breaking.html = IMAGE -BUGCR23496 MAC DEBUG : fast/text/textIteratorNilRenderer.html = IMAGE -BUGCR23496 SLOW MAC RELEASE : fast/text/textIteratorNilRenderer.html = IMAGE BUGCR23496 MAC : fast/text/whitespace/normal-after-nowrap-breaking.html = IMAGE BUGCR23496 MAC : tables/mozilla_expected_failures/core/captions1.html = IMAGE+TEXT BUGCR23496 MAC : tables/mozilla_expected_failures/core/captions2.html = IMAGE+TEXT @@ -1390,10 +1387,8 @@ BUGCR23488 MAC : platform/chromium/virtual/gpu/fast/canvas/canvas-incremental-repaint-2.html = IMAGE BUGCR23488 LEOPARD : fast/frames/content-opacity-1.html = IMAGE BUGCR23488 LEOPARD : fast/frames/content-opacity-2.html = IMAGE -BUGCR23488 MAC : fast/layers/add-layer-with-nested-stacking.html = IMAGE BUGCR23488 MAC : fast/layers/inline-dirty-z-order-lists.html = IMAGE BUGCR23488 MAC : fast/layers/layer-content-visibility-change.html = IMAGE -BUGCR23488 MAC : fast/layers/remove-layer-with-nested-stacking.html = IMAGE BUGCR23488 LEOPARD : fast/lists/ol-start-parsing.html = IMAGE BUGCR23488 LEOPARD : fast/multicol/positioned-with-constrained-height.html = IMAGE BUGCR23488 MAC : tables/mozilla_expected_failures/bugs/bug178855.xml = IMAGE @@ -1457,7 +1452,6 @@ BUGCR23473 MAC : fast/repaint/inline-block-resize.html = IMAGE BUGCR23473 MAC : fast/repaint/inline-color-change.html = IMAGE BUGCR23473 MAC : fast/repaint/inline-overflow.html = IMAGE -BUGCR23473 MAC : fast/repaint/inline-relative-positioned.html = IMAGE BUGCR23473 MAC : fast/repaint/intermediate-layout-position-clip.html = IMAGE BUGCR23473 MAC : fast/repaint/intermediate-layout-position.html = IMAGE BUGCR23473 MAC : fast/repaint/invisible-objects.html = IMAGE @@ -1468,30 +1462,23 @@ BUGCR23473 MAC : fast/repaint/layout-state-relative.html = IMAGE BUGCR23473 MAC : fast/repaint/line-in-scrolled-clipped-block.html = IMAGE BUGCR23473 MAC : fast/repaint/line-overflow.html = IMAGE -BUGCR23473 MAC : fast/repaint/lines-with-layout-delta.html = IMAGE BUGCR23473 MAC : fast/repaint/list-marker-2.html = IMAGE BUGCR23473 MAC : fast/repaint/make-children-non-inline.html = IMAGE BUGCR23473 MAC : fast/repaint/outline-child-repaint.html = IMAGE BUGCR23473 MAC : fast/repaint/outline-inset.html = IMAGE BUGCR23473 MAC : fast/repaint/outline-repaint-glitch.html = IMAGE BUGCR23473 MAC : fast/repaint/outline-shrinking.html = IMAGE -BUGCR23473 MAC : fast/repaint/overflow-clip-subtree-layout.html = IMAGE -BUGCR23473 MAC : fast/repaint/overflow-delete-line.html = IMAGE BUGCR23473 MAC : fast/repaint/overflow-into-content.html = IMAGE BUGCR23473 MAC : fast/repaint/overflow-outline-repaint.html = IMAGE BUGCR23473 MAC : fast/repaint/overflow-scroll-delete.html = IMAGE BUGCR23473 MAC : fast/repaint/reflection-redraw.html = IMAGE BUGCR23473 MAC : fast/repaint/reflection-repaint-test.html = IMAGE BUGCR23473 MAC : fast/repaint/rel-positioned-inline-with-overflow.html = IMAGE -BUGCR23473 MAC : fast/repaint/repaint-resized-overflow.html = IMAGE BUGCR23473 MAC : fast/repaint/selection-after-delete.html = IMAGE BUGCR23473 MAC : fast/repaint/selection-clear.html = IMAGE BUGCR23473 MAC : fast/repaint/selection-gap-overflow-scroll.html = IMAGE BUGCR23473 MAC : fast/repaint/stacked-diacritics.html = IMAGE BUGCR23473 MAC : fast/repaint/static-to-positioned.html = IMAGE -BUGCR23473 MAC : fast/repaint/subtree-layoutstate-transform.html = IMAGE -BUGCR23473 MAC : fast/repaint/subtree-root-clip-2.html = IMAGE -BUGCR23473 MAC : fast/repaint/subtree-root-clip.html = IMAGE BUGCR23473 MAC :
[webkit-changes] [110106] trunk/Source/WebCore
Title: [110106] trunk/Source/WebCore Revision 110106 Author hara...@chromium.org Date 2012-03-07 14:36:54 -0800 (Wed, 07 Mar 2012) Log Message [V8][Performance] Optimize Element.firstElementChild, Element.lastElementChild, Element.previousElementSibling, Element.nextElementSibling, Node.parentElement https://bugs.webkit.org/show_bug.cgi?id=80506 Reviewed by Adam Barth. This patch improves the performance of Element.firstElementChild by 5.8 times, Element.lastElementChild by 6.2 times, Element.previousElementSibling by 7.1 times, Element.nextElementSibling by 7.1 times, and Node.parentElement by 6.7 times. Previously, while toV8(Node*) caches a wrapper object on a node object (i.e. node-wrapper(), node-setWrapper()), toV8(Element*) does not cache a wrapper object. This patch removes toV8(Element*), so that DOM attribute getters that return Element* use toV8(Node*). This change makes these DOM attribute getters cache the wrapper object on a node object. This optimization is already implemented in _javascript_Core. Performance tests: https://bugs.webkit.org/attachment.cgi?id=130594 The test results in my local Mac environment are as follows: AppleWebKit/_javascript_Core: div.firstElementChild : 1162ms div.lastElementChild : 1016ms div.previousElementSibling : 918ms div.nextElementSibling : 900ms div.parentElement : 901ms Chromium/V8 (without this patch): div.firstElementChild : 9515ms div.lastElementChild : 9449ms div.previousElementSibling : 9254ms div.nextElementSibling : 9315ms div.parentElement : 9380ms Chromium/V8 (with this patch): div.firstElementChild : 1628ms div.lastElementChild : 1527ms div.previousElementSibling : 1310ms div.nextElementSibling : 1310ms div.parentElement : 1410ms No tests. No change in behavior. * dom/Element.idl: Removed toV8(Element*) * bindings/v8/custom/V8NodeCustom.cpp: Ditto. (WebCore::toV8Slow): * bindings/scripts/CodeGeneratorV8.pm: Ditto. (GenerateHeader): * bindings/v8/custom/V8ElementCustom.cpp: Removed. * Target.pri: Removed V8ElementCustom.cpp. * UseV8.cmake: Ditto. * WebCore.gypi: Ditto. Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Target.pri trunk/Source/WebCore/UseV8.cmake trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/v8/custom/V8NodeCustom.cpp trunk/Source/WebCore/dom/Element.idl Removed Paths trunk/Source/WebCore/bindings/v8/custom/V8ElementCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (110105 => 110106) --- trunk/Source/WebCore/ChangeLog 2012-03-07 22:36:43 UTC (rev 110105) +++ trunk/Source/WebCore/ChangeLog 2012-03-07 22:36:54 UTC (rev 110106) @@ -1,3 +1,62 @@ +2012-03-07 Kentaro Hara hara...@chromium.org + +[V8][Performance] Optimize Element.firstElementChild, Element.lastElementChild, +Element.previousElementSibling, Element.nextElementSibling, Node.parentElement +https://bugs.webkit.org/show_bug.cgi?id=80506 + +Reviewed by Adam Barth. + +This patch improves the performance of Element.firstElementChild by 5.8 times, +Element.lastElementChild by 6.2 times, Element.previousElementSibling by 7.1 times, +Element.nextElementSibling by 7.1 times, and Node.parentElement by 6.7 times. + +Previously, while toV8(Node*) caches a wrapper object on a node object +(i.e. node-wrapper(), node-setWrapper()), toV8(Element*) does not +cache a wrapper object. + +This patch removes toV8(Element*), so that DOM attribute getters that return +Element* use toV8(Node*). This change makes these DOM attribute getters +cache the wrapper object on a node object. This optimization is already +implemented in _javascript_Core. + +Performance tests: https://bugs.webkit.org/attachment.cgi?id=130594 + +The test results in my local Mac environment are as follows: + +AppleWebKit/_javascript_Core: +div.firstElementChild : 1162ms +div.lastElementChild : 1016ms +div.previousElementSibling : 918ms +div.nextElementSibling : 900ms +div.parentElement : 901ms + +Chromium/V8 (without this patch): +div.firstElementChild : 9515ms +div.lastElementChild : 9449ms +div.previousElementSibling : 9254ms +div.nextElementSibling : 9315ms +div.parentElement : 9380ms + +Chromium/V8 (with this patch): +div.firstElementChild : 1628ms +div.lastElementChild : 1527ms +div.previousElementSibling : 1310ms +div.nextElementSibling : 1310ms +div.parentElement : 1410ms + +No tests. No change in behavior. + +* dom/Element.idl: Removed toV8(Element*) +* bindings/v8/custom/V8NodeCustom.cpp: Ditto. +(WebCore::toV8Slow): +* bindings/scripts/CodeGeneratorV8.pm: Ditto. +(GenerateHeader): + +* bindings/v8/custom/V8ElementCustom.cpp: Removed. +* Target.pri: Removed
[webkit-changes] [110107] tags/Safari-534.54.16/safari-534.54-branch/
Title: [110107] tags/Safari-534.54.16/safari-534.54-branch/ Revision 110107 Author lforsch...@apple.com Date 2012-03-07 14:42:40 -0800 (Wed, 07 Mar 2012) Log Message New tag. Added Paths tags/Safari-534.54.16/safari-534.54-branch/ Diff Property changes: tags/Safari-534.54.16/safari-534.54-branch Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110108] tags/Safari-534.54.17/
Title: [110108] tags/Safari-534.54.17/ Revision 110108 Author lforsch...@apple.com Date 2012-03-07 14:42:46 -0800 (Wed, 07 Mar 2012) Log Message New tag. Added Paths tags/Safari-534.54.17/ Diff Property changes: tags/Safari-534.54.17 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110109] tags/Safari-534.54.16/safari-534.54-branch/
Title: [110109] tags/Safari-534.54.16/safari-534.54-branch/ Revision 110109 Author lforsch...@apple.com Date 2012-03-07 14:44:10 -0800 (Wed, 07 Mar 2012) Log Message Removed Paths tags/Safari-534.54.16/safari-534.54-branch/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110110] branches/safari-534.54-branch/Source
Title: [110110] branches/safari-534.54-branch/Source Revision 110110 Author lforsch...@apple.com Date 2012-03-07 14:46:30 -0800 (Wed, 07 Mar 2012) Log Message Versioning. Modified Paths branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig (110109 => 110110) --- branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-03-07 22:44:10 UTC (rev 110109) +++ branches/safari-534.54-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2012-03-07 22:46:30 UTC (rev 110110) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig (110109 => 110110) --- branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-03-07 22:44:10 UTC (rev 110109) +++ branches/safari-534.54-branch/Source/_javascript_Glue/Configurations/Version.xcconfig 2012-03-07 22:46:30 UTC (rev 110110) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig (110109 => 110110) --- branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-03-07 22:44:10 UTC (rev 110109) +++ branches/safari-534.54-branch/Source/WebCore/Configurations/Version.xcconfig 2012-03-07 22:46:30 UTC (rev 110110) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig (110109 => 110110) --- branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-03-07 22:44:10 UTC (rev 110109) +++ branches/safari-534.54-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2012-03-07 22:46:30 UTC (rev 110110) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig (110109 => 110110) --- branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-03-07 22:44:10 UTC (rev 110109) +++ branches/safari-534.54-branch/Source/WebKit2/Configurations/Version.xcconfig 2012-03-07 22:46:30 UTC (rev 110110) @@ -23,7 +23,7 @@ MAJOR_VERSION = 534; MINOR_VERSION = 54; -TINY_VERSION = 17; +TINY_VERSION = 18; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110111] branches/chromium/963/Source/WebCore/xml/XMLErrors.cpp
Title: [110111] branches/chromium/963/Source/WebCore/xml/XMLErrors.cpp Revision 110111 Author k...@chromium.org Date 2012-03-07 14:55:20 -0800 (Wed, 07 Mar 2012) Log Message Fix XML error handling. Modified Paths branches/chromium/963/Source/WebCore/xml/XMLErrors.cpp Diff Modified: branches/chromium/963/Source/WebCore/xml/XMLErrors.cpp (110110 => 110111) --- branches/chromium/963/Source/WebCore/xml/XMLErrors.cpp 2012-03-07 22:46:30 UTC (rev 110110) +++ branches/chromium/963/Source/WebCore/xml/XMLErrors.cpp 2012-03-07 22:55:20 UTC (rev 110111) @@ -33,6 +33,7 @@ #include Element.h #include Frame.h #include HTMLNames.h +#include ScopedEventQueue.h #include Text.h #include wtf/text/WTFString.h @@ -115,6 +116,8 @@ // the normal content (the DOM tree is created manually and includes line/col info regarding // where the errors are located) +EventQueueScope scope; + // Create elements for display ExceptionCode ec = 0; RefPtrElement documentElement = m_document-documentElement(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110113] trunk/Tools
Title: [110113] trunk/Tools Revision 110113 Author commit-qu...@webkit.org Date 2012-03-07 15:01:49 -0800 (Wed, 07 Mar 2012) Log Message [Qt][WK2] MiniBrowser on desktop does not react to click events https://bugs.webkit.org/show_bug.cgi?id=80314 Patch by Hugo Parente Lima hugo.l...@openbossa.org on 2012-03-07 Reviewed by Kenneth Rohde Christiansen. Do not enable touch mocking on desktop mode. * MiniBrowser/qt/MiniBrowserApplication.cpp: (MiniBrowserApplication::handleUserOptions): Modified Paths trunk/Tools/ChangeLog trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp Diff Modified: trunk/Tools/ChangeLog (110112 => 110113) --- trunk/Tools/ChangeLog 2012-03-07 23:01:20 UTC (rev 110112) +++ trunk/Tools/ChangeLog 2012-03-07 23:01:49 UTC (rev 110113) @@ -1,3 +1,15 @@ +2012-03-07 Hugo Parente Lima hugo.l...@openbossa.org + +[Qt][WK2] MiniBrowser on desktop does not react to click events +https://bugs.webkit.org/show_bug.cgi?id=80314 + +Reviewed by Kenneth Rohde Christiansen. + +Do not enable touch mocking on desktop mode. + +* MiniBrowser/qt/MiniBrowserApplication.cpp: +(MiniBrowserApplication::handleUserOptions): + 2012-03-07 Ojan Vafai o...@chromium.org Automatically move to the next test after rebaseline in the results view Modified: trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp (110112 => 110113) --- trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-03-07 23:01:20 UTC (rev 110112) +++ trunk/Tools/MiniBrowser/qt/MiniBrowserApplication.cpp 2012-03-07 23:01:49 UTC (rev 110113) @@ -279,6 +279,9 @@ } const bool useDesktopBehavior = takeOptionFlag(args, --desktop); +if (useDesktopBehavior) +windowOptions()-setTouchMockingEnabled(false); + QQuickWebViewExperimental::setFlickableViewportEnabled(!useDesktopBehavior); if (!useDesktopBehavior) qputenv(QT_WEBKIT_USE_MOBILE_THEME, QByteArray(1)); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110114] trunk/Source
Title: [110114] trunk/Source
Revision 110114
Author aba...@webkit.org
Date 2012-03-07 15:13:27 -0800 (Wed, 07 Mar 2012)
Log Message
Remove #define private public from WebCache.cpp
https://bugs.webkit.org/show_bug.cgi?id=80520
Reviewed by Eric Seidel.
Source/WebCore:
Add some accessors for state used by WebCache.cpp.
* loader/cache/MemoryCache.h:
(WebCore::MemoryCache::minDeadCapacity):
(WebCore::MemoryCache::maxDeadCapacity):
(WebCore::MemoryCache::capacity):
(WebCore::MemoryCache::liveSize):
(WebCore::MemoryCache::deadSize):
(MemoryCache):
Source/WebKit/chromium:
This patch removes a hack we added long ago when Chromium used a forked
copy of WebKit and editing WebCore caused merge pain. Now that we're
on trunk, we can unwind this hack.
* src/WebCache.cpp:
(WebKit::WebCache::getUsageStats):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/MemoryCache.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebCache.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110113 => 110114)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 23:01:49 UTC (rev 110113)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 23:13:27 UTC (rev 110114)
@@ -1,3 +1,20 @@
+2012-03-07 Adam Barth aba...@webkit.org
+
+Remove #define private public from WebCache.cpp
+https://bugs.webkit.org/show_bug.cgi?id=80520
+
+Reviewed by Eric Seidel.
+
+Add some accessors for state used by WebCache.cpp.
+
+* loader/cache/MemoryCache.h:
+(WebCore::MemoryCache::minDeadCapacity):
+(WebCore::MemoryCache::maxDeadCapacity):
+(WebCore::MemoryCache::capacity):
+(WebCore::MemoryCache::liveSize):
+(WebCore::MemoryCache::deadSize):
+(MemoryCache):
+
2012-03-07 Kentaro Hara hara...@chromium.org
[V8][Performance] Optimize Element.firstElementChild, Element.lastElementChild,
Modified: trunk/Source/WebCore/loader/cache/MemoryCache.h (110113 => 110114)
--- trunk/Source/WebCore/loader/cache/MemoryCache.h 2012-03-07 23:01:49 UTC (rev 110113)
+++ trunk/Source/WebCore/loader/cache/MemoryCache.h 2012-03-07 23:13:27 UTC (rev 110114)
@@ -162,6 +162,12 @@
void removeResourcesWithOrigin(SecurityOrigin*);
void getOriginsWithCache(SecurityOriginSet origins);
+unsigned minDeadCapacity() const { return m_minDeadCapacity; }
+unsigned maxDeadCapacity() const { return m_maxDeadCapacity; }
+unsigned capacity() const { return m_capacity; }
+unsigned liveSize() const { return m_liveSize; }
+unsigned deadSize() const { return m_deadSize; }
+
private:
MemoryCache();
~MemoryCache(); // Not implemented to make sure nobody accidentally calls delete -- WebCore does not delete singletons.
Modified: trunk/Source/WebKit/chromium/ChangeLog (110113 => 110114)
--- trunk/Source/WebKit/chromium/ChangeLog 2012-03-07 23:01:49 UTC (rev 110113)
+++ trunk/Source/WebKit/chromium/ChangeLog 2012-03-07 23:13:27 UTC (rev 110114)
@@ -1,3 +1,17 @@
+2012-03-07 Adam Barth aba...@webkit.org
+
+Remove #define private public from WebCache.cpp
+https://bugs.webkit.org/show_bug.cgi?id=80520
+
+Reviewed by Eric Seidel.
+
+This patch removes a hack we added long ago when Chromium used a forked
+copy of WebKit and editing WebCore caused merge pain. Now that we're
+on trunk, we can unwind this hack.
+
+* src/WebCache.cpp:
+(WebKit::WebCache::getUsageStats):
+
2012-03-07 Joshua Bell jsb...@chromium.org
[Chromium] IndexedDB: V8LocalContext creation in IDBKey extraction/injection is slow
Modified: trunk/Source/WebKit/chromium/src/WebCache.cpp (110113 => 110114)
--- trunk/Source/WebKit/chromium/src/WebCache.cpp 2012-03-07 23:01:49 UTC (rev 110113)
+++ trunk/Source/WebKit/chromium/src/WebCache.cpp 2012-03-07 23:13:27 UTC (rev 110114)
@@ -31,14 +31,9 @@
#include config.h
#include WebCache.h
-// Instead of providing accessors, we make all members of MemoryCache public.
-// This will make it easier to track WebCore changes to the MemoryCache class.
-// FIXME: We should introduce public getters on the MemoryCache class.
-#define private public
#include MemoryCache.h
-#undef private
-using namespace WebCore;
+using WebCore::MemoryCache;
namespace WebKit {
@@ -83,11 +78,11 @@
MemoryCache* cache = WebCore::memoryCache();
if (cache) {
-result-minDeadCapacity = cache-m_minDeadCapacity;
-result-maxDeadCapacity = cache-m_maxDeadCapacity;
-result-capacity = cache-m_capacity;
-result-liveSize = cache-m_liveSize;
-result-deadSize = cache-m_deadSize;
+result-minDeadCapacity = cache-minDeadCapacity();
+result-maxDeadCapacity = cache-maxDeadCapacity();
+result-capacity = cache-capacity();
+result-liveSize = cache-liveSize();
+result-deadSize = cache-deadSize();
} else
memset(result, 0, sizeof(UsageStats));
}
[webkit-changes] [110115] trunk/Tools
Title: [110115] trunk/Tools
Revision 110115
Author commit-qu...@webkit.org
Date 2012-03-07 15:21:02 -0800 (Wed, 07 Mar 2012)
Log Message
[NRWT] Fix --platform=qt-5.0 --new-baseline combo
https://bugs.webkit.org/show_bug.cgi?id=72489
Patch by Rafael Brandao rafael.l...@openbossa.org on 2012-03-07
Reviewed by Dirk Pranke.
NRWT: The default platform name for Qt combined with --webkit-test-runner is now
qt-5.0-wk2 instead of qt-linux and that name is now prefered for tests.
--platform will override the platform name and then we'll use it.
ORWT: We check for qt version and use platform name qt-4.8 if the version is lower
than 5.0.0, and then we choose between qt-5.0-wk1 and qt-5.0-wk2. --platform will
override it in the end.
* Scripts/old-run-webkit-tests:
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort):
(QtPort.determine_full_port_name):
(QtPort.baseline_search_path):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/old-run-webkit-tests
trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py
Diff
Modified: trunk/Tools/ChangeLog (110114 => 110115)
--- trunk/Tools/ChangeLog 2012-03-07 23:13:27 UTC (rev 110114)
+++ trunk/Tools/ChangeLog 2012-03-07 23:21:02 UTC (rev 110115)
@@ -1,3 +1,24 @@
+2012-03-07 Rafael Brandao rafael.l...@openbossa.org
+
+[NRWT] Fix --platform=qt-5.0 --new-baseline combo
+https://bugs.webkit.org/show_bug.cgi?id=72489
+
+Reviewed by Dirk Pranke.
+
+NRWT: The default platform name for Qt combined with --webkit-test-runner is now
+qt-5.0-wk2 instead of qt-linux and that name is now prefered for tests.
+--platform will override the platform name and then we'll use it.
+
+ORWT: We check for qt version and use platform name qt-4.8 if the version is lower
+than 5.0.0, and then we choose between qt-5.0-wk1 and qt-5.0-wk2. --platform will
+override it in the end.
+
+* Scripts/old-run-webkit-tests:
+* Scripts/webkitpy/layout_tests/port/qt.py:
+(QtPort):
+(QtPort.determine_full_port_name):
+(QtPort.baseline_search_path):
+
2012-03-07 Hugo Parente Lima hugo.l...@openbossa.org
[Qt][WK2] MiniBrowser on desktop does not react to click events
Modified: trunk/Tools/Scripts/old-run-webkit-tests (110114 => 110115)
--- trunk/Tools/Scripts/old-run-webkit-tests 2012-03-07 23:13:27 UTC (rev 110114)
+++ trunk/Tools/Scripts/old-run-webkit-tests 2012-03-07 23:21:02 UTC (rev 110115)
@@ -232,7 +232,11 @@
$platform = mac;
}
} elsif (isQt()) {
-$platform = qt;
+if (getQtVersion() lt 5.0) {
+$platform = qt-4.8;
+} else {
+$platform = qt-5.0-wk1;
+}
} elsif (isGtk()) {
$platform = gtk;
} elsif (isWx()) {
@@ -328,6 +332,23 @@
setConfiguration();
+if ($useWebKitTestRunner) {
+if (isAppleMacWebKit()) {
+$realPlatform = $platform;
+$platform = mac-wk2;
+} elsif (isAppleWinWebKit()) {
+$stripEditingCallbacks = 0 unless defined $stripEditingCallbacks;
+$realPlatform = $platform;
+$platform = win-wk2;
+} elsif (isQt()) {
+$realPlatform = $platform;
+$platform = qt-5.0-wk2;
+} elsif (isGtk()) {
+$realPlatform = $platform;
+$platform = gtk-wk2;
+}
+}
+
my $getOptionsResult = GetOptions(
'add-platform-exceptions' = \$addPlatformExceptions,
'additional-platform-directory=s' = \@additionalPlatformDirectories,
@@ -382,23 +403,6 @@
exit 1;
}
-if ($useWebKitTestRunner) {
-if (isAppleMacWebKit()) {
-$realPlatform = $platform;
-$platform = mac-wk2;
-} elsif (isAppleWinWebKit()) {
-$stripEditingCallbacks = 0 unless defined $stripEditingCallbacks;
-$realPlatform = $platform;
-$platform = win-wk2;
-} elsif (isQt()) {
-$realPlatform = $platform;
-$platform = qt-5.0-wk2;
-} elsif (isGtk()) {
-$realPlatform = $platform;
-$platform = gtk-wk2;
-}
-}
-
$timeoutSeconds *= 10 if $guardMalloc;
$stripEditingCallbacks = isCygwin() unless defined $stripEditingCallbacks;
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (110114 => 110115)
--- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-03-07 23:13:27 UTC (rev 110114)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-03-07 23:21:02 UTC (rev 110115)
@@ -47,6 +47,7 @@
ALL_VERSIONS = ['linux', 'win', 'mac']
port_name = qt
+@classmethod
def _wk2_port_name(self):
return qt-5.0-wk2
@@ -57,6 +58,8 @@
def determine_full_port_name(cls, host, options, port_name):
if port_name and port_name != cls.port_name:
return port_name
+if hasattr(options, 'webkit_test_runner') and getattr(options, 'webkit_test_runner'):
+return cls._wk2_port_name()
return port_name + '-' + host.platform.os_name
# sys_platform exists only for unit testing.
@@ -108,8 +111,6 @@
def
[webkit-changes] [110116] trunk/Source/WebKit/mac
Title: [110116] trunk/Source/WebKit/mac
Revision 110116
Author commit-qu...@webkit.org
Date 2012-03-07 15:31:02 -0800 (Wed, 07 Mar 2012)
Log Message
http://webkit.org/b/80510 Web Inspector crash (iCab)
Patch by Joseph Pecoraro pecor...@apple.com on 2012-03-07
Reviewed by Timothy Hatcher.
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::didResizeMainFrame):
Modified Paths
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (110115 => 110116)
--- trunk/Source/WebKit/mac/ChangeLog 2012-03-07 23:21:02 UTC (rev 110115)
+++ trunk/Source/WebKit/mac/ChangeLog 2012-03-07 23:31:02 UTC (rev 110116)
@@ -1,3 +1,12 @@
+2012-03-07 Joseph Pecoraro pecor...@apple.com
+
+http://webkit.org/b/80510 Web Inspector crash (iCab)
+
+Reviewed by Timothy Hatcher.
+
+* WebCoreSupport/WebInspectorClient.mm:
+(WebInspectorClient::didResizeMainFrame):
+
2012-03-06 Benjamin Poulain bpoul...@apple.com
[Mac] Update the configuration files for iOS
Modified: trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm (110115 => 110116)
--- trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2012-03-07 23:21:02 UTC (rev 110115)
+++ trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm 2012-03-07 23:31:02 UTC (rev 110116)
@@ -113,7 +113,8 @@
void WebInspectorClient::didResizeMainFrame(Frame*)
{
-m_frontendClient-setDockingUnavailable(!m_frontendClient-canAttachWindow());
+if (m_frontendClient)
+m_frontendClient-setDockingUnavailable(!m_frontendClient-canAttachWindow());
}
void WebInspectorClient::highlight()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110117] trunk/LayoutTests
Title: [110117] trunk/LayoutTests Revision 110117 Author senorbla...@chromium.org Date 2012-03-07 15:34:28 -0800 (Wed, 07 Mar 2012) Log Message [Chromium] Unreviewed gardening. Another attempt to green up the Mac canaries. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110116 => 110117) --- trunk/LayoutTests/ChangeLog 2012-03-07 23:31:02 UTC (rev 110116) +++ trunk/LayoutTests/ChangeLog 2012-03-07 23:34:28 UTC (rev 110117) @@ -1,3 +1,11 @@ +2012-03-07 Stephen White senorbla...@chromium.org + +[Chromium] Unreviewed gardening. + +Another attempt to green up the Mac canaries. + +* platform/chromium/test_expectations.txt: + 2012-03-07 Ojan Vafai o...@chromium.org Another round of straightforward Chromium Lion rebaselines. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110116 => 110117) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 23:31:02 UTC (rev 110116) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-07 23:34:28 UTC (rev 110117) @@ -1479,7 +1479,6 @@ BUGCR23473 MAC : fast/repaint/selection-gap-overflow-scroll.html = IMAGE BUGCR23473 MAC : fast/repaint/stacked-diacritics.html = IMAGE BUGCR23473 MAC : fast/repaint/static-to-positioned.html = IMAGE -BUGCR23473 MAC : fast/repaint/subtree-root-skipped.html = IMAGE BUGCR23473 MAC : fast/repaint/table-cell-move.html = IMAGE BUGCR23473 MAC : fast/repaint/table-cell-overflow.html = IMAGE BUGCR23473 MAC : fast/repaint/table-col-background.html = IMAGE @@ -3630,7 +3629,8 @@ BUGWK77397 : plugins/crash-restoring-plugin-page-from-page-cache.html = TIMEOUT TEXT // Started failing at WK r106383 or r106384. -BUGWK77494 MAC : fast/replaced/width100percent-searchfield.html = IMAGE +// FIXME_JCHAFFRAIX: Restore to just IMAGE after WK75568 text rebaselines land +// BUGWK77494 MAC : fast/replaced/width100percent-searchfield.html = IMAGE // Started crashing at WK r106422. BUGWK77508 SKIP : platform/mac/fast/events/non-roman-key-code.html = FAIL @@ -3860,8 +3860,8 @@ // FIXME: keep SLOW here // BUGWK75568 SLOW MAC RELEASE : fast/text/textIteratorNilRenderer.html = PASS BUGWK75568 SLOW MAC RELEASE : fast/text/textIteratorNilRenderer.html = IMAGE+TEXT -BUGWK75568 MAC : fast/clip/008.html = IMAGE+TEXT -BUGWK75568 MAC : fast/replaced/width100percent-textfield.html = IMAGE+TEXT +BUGWK75568 MAC : fast/clip/008.html = TEXT +BUGWK75568 MAC : fast/replaced/width100percent-textfield.html = TEXT // Those tests need a text baseline after lazily allocating layers. // The change should only be layer removal. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110118] trunk/Source/WebCore
Title: [110118] trunk/Source/WebCore
Revision 110118
Author commit-qu...@webkit.org
Date 2012-03-07 15:55:39 -0800 (Wed, 07 Mar 2012)
Log Message
[chromium] Support printing WebGL content in threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=80464
Patch by James Robinson jam...@chromium.org on 2012-03-07
Reviewed by Kenneth Russell.
Do the readback on the WebGL context instead of the compositor's context since we cannot use the latter from the
main thread. Since we're on the WebGL context, we have to be careful to restore any state we change.
Tested printing manually with threaded compositing enabled.
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
* platform/graphics/chromium/WebGLLayerChromium.h:
(WebGLLayerChromium):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp
trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (110117 => 110118)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 23:34:28 UTC (rev 110117)
+++ trunk/Source/WebCore/ChangeLog 2012-03-07 23:55:39 UTC (rev 110118)
@@ -1,3 +1,20 @@
+2012-03-07 James Robinson jam...@chromium.org
+
+[chromium] Support printing WebGL content in threaded compositor
+https://bugs.webkit.org/show_bug.cgi?id=80464
+
+Reviewed by Kenneth Russell.
+
+Do the readback on the WebGL context instead of the compositor's context since we cannot use the latter from the
+main thread. Since we're on the WebGL context, we have to be careful to restore any state we change.
+
+Tested printing manually with threaded compositing enabled.
+
+* platform/graphics/chromium/WebGLLayerChromium.cpp:
+(WebCore::WebGLLayerChromium::paintRenderedResultsToCanvas):
+* platform/graphics/chromium/WebGLLayerChromium.h:
+(WebGLLayerChromium):
+
2012-03-07 Adam Barth aba...@webkit.org
Remove #define private public from WebCache.cpp
Modified: trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp (110117 => 110118)
--- trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp 2012-03-07 23:34:28 UTC (rev 110117)
+++ trunk/Source/WebCore/platform/graphics/chromium/WebGLLayerChromium.cpp 2012-03-07 23:55:39 UTC (rev 110118)
@@ -108,20 +108,26 @@
bool WebGLLayerChromium::paintRenderedResultsToCanvas(ImageBuffer* imageBuffer)
{
-if (m_textureUpdated || !layerRendererContext() || !drawsContent())
+if (m_textureUpdated || !m_drawingBuffer || !drawsContent())
return false;
IntSize framebufferSize = context()-getInternalFramebufferSize();
-ASSERT(layerRendererContext());
-// This would ideally be done in the webgl context, but that isn't possible yet.
-Platform3DObject framebuffer = layerRendererContext()-createFramebuffer();
-layerRendererContext()-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, framebuffer);
-layerRendererContext()-framebufferTexture2D(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::COLOR_ATTACHMENT0, GraphicsContext3D::TEXTURE_2D, m_textureId, 0);
+// Since we're using the same context as WebGL, we have to restore any state we change (in this case, just the framebuffer binding).
+// FIXME: The WebGLRenderingContext tracks the current framebuffer binding, it would be slightly more efficient to use this value
+// rather than querying it off of the context.
+GC3Dint previousFramebuffer = 0;
+context()-getIntegerv(GraphicsContext3D::FRAMEBUFFER_BINDING, previousFramebuffer);
-Extensions3DChromium* extensions = static_castExtensions3DChromium*(layerRendererContext()-getExtensions());
+Platform3DObject framebuffer = context()-createFramebuffer();
+context()-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, framebuffer);
+context()-framebufferTexture2D(GraphicsContext3D::FRAMEBUFFER, GraphicsContext3D::COLOR_ATTACHMENT0, GraphicsContext3D::TEXTURE_2D, m_textureId, 0);
+
+Extensions3DChromium* extensions = static_castExtensions3DChromium*(context()-getExtensions());
extensions-paintFramebufferToCanvas(framebuffer, framebufferSize.width(), framebufferSize.height(), !context()-getContextAttributes().premultipliedAlpha, imageBuffer);
-layerRendererContext()-deleteFramebuffer(framebuffer);
+context()-deleteFramebuffer(framebuffer);
+
+context()-bindFramebuffer(GraphicsContext3D::FRAMEBUFFER, previousFramebuffer);
return true;
}
@@ -173,15 +179,6 @@
return 0;
}
-GraphicsContext3D* WebGLLayerChromium::layerRendererContext()
-{
-// FIXME: In the threaded case, paintRenderedResultsToCanvas must be
-// refactored to be asynchronous. Currently this is unimplemented.
-if (!layerTreeHost() || CCProxy::hasImplThread())
-return 0;
-return layerTreeHost()-context();
}
-}
-
#endif //
[webkit-changes] [110120] trunk/Source/WebCore
Title: [110120] trunk/Source/WebCore
Revision 110120
Author e...@chromium.org
Date 2012-03-07 16:00:10 -0800 (Wed, 07 Mar 2012)
Log Message
Change remaining scroll methods to integers
https://bugs.webkit.org/show_bug.cgi?id=80539
Reviewed by Eric Seidel.
No new tests, no new functionality.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::scrollToXOffset):
(WebCore::RenderLayer::scrollToYOffset):
Change scrollTo methods to take integer x and y values as the actual
scrolling is done in increments of full pixels.
(WebCore::cornerStart):
(WebCore::RenderLayer::scrollWidth):
(WebCore::RenderLayer::scrollHeight):
Change scrollWidth/Height to return pixel snapped values and remove
pixelSnapped versions of same as all callers either used snapped the
values or used the pixelSnapped versions of these methods.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollWidth):
Change scrollWidth to return snapped client width.
* rendering/RenderListBox.h:
Change scrollSize, scrollPosition and setScrollOffset methods to use
integers in accordance with the interface defined by ScrollableArea.
* rendering/RenderTreeAsText.cpp:
(WebCore::write):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayer.cpp
trunk/Source/WebCore/rendering/RenderLayer.h
trunk/Source/WebCore/rendering/RenderListBox.cpp
trunk/Source/WebCore/rendering/RenderListBox.h
trunk/Source/WebCore/rendering/RenderTreeAsText.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110119 => 110120)
--- trunk/Source/WebCore/ChangeLog 2012-03-07 23:57:40 UTC (rev 110119)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 00:00:10 UTC (rev 110120)
@@ -1,3 +1,39 @@
+2012-03-07 Emil A Eklund e...@chromium.org
+
+Change remaining scroll methods to integers
+https://bugs.webkit.org/show_bug.cgi?id=80539
+
+Reviewed by Eric Seidel.
+
+No new tests, no new functionality.
+
+* rendering/RenderLayer.cpp:
+(WebCore::RenderLayer::scrollByRecursively):
+(WebCore::RenderLayer::scrollToOffset):
+(WebCore::RenderLayer::scrollRectToVisible):
+(WebCore::RenderLayer::scrollToXOffset):
+(WebCore::RenderLayer::scrollToYOffset):
+Change scrollTo methods to take integer x and y values as the actual
+scrolling is done in increments of full pixels.
+
+(WebCore::cornerStart):
+(WebCore::RenderLayer::scrollWidth):
+(WebCore::RenderLayer::scrollHeight):
+Change scrollWidth/Height to return pixel snapped values and remove
+pixelSnapped versions of same as all callers either used snapped the
+values or used the pixelSnapped versions of these methods.
+
+* rendering/RenderListBox.cpp:
+(WebCore::RenderListBox::scrollWidth):
+Change scrollWidth to return snapped client width.
+
+* rendering/RenderListBox.h:
+Change scrollSize, scrollPosition and setScrollOffset methods to use
+integers in accordance with the interface defined by ScrollableArea.
+
+* rendering/RenderTreeAsText.cpp:
+(WebCore::write):
+
2012-03-07 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
Implement getAttributeNode() in terms of ElementAttributeData instead of NamedNodeMap
Modified: trunk/Source/WebCore/rendering/RenderLayer.cpp (110119 => 110120)
--- trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-03-07 23:57:40 UTC (rev 110119)
+++ trunk/Source/WebCore/rendering/RenderLayer.cpp 2012-03-08 00:00:10 UTC (rev 110120)
@@ -1387,7 +1387,7 @@
scrollByRecursively(adjustedScrollDelta(xDelta), adjustedScrollDelta(yDelta), ScrollOffsetClamped);
}
-void RenderLayer::scrollByRecursively(LayoutUnit xDelta, LayoutUnit yDelta, ScrollOffsetClamping clamp)
+void RenderLayer::scrollByRecursively(int xDelta, int yDelta, ScrollOffsetClamping clamp)
{
if (!xDelta !yDelta)
return;
@@ -1397,13 +1397,13 @@
restrictedByLineClamp = !renderer()-parent()-style()-lineClamp().isNone();
if (renderer()-hasOverflowClip() !restrictedByLineClamp) {
-LayoutUnit newOffsetX = scrollXOffset() + xDelta;
-LayoutUnit newOffsetY = scrollYOffset() + yDelta;
+int newOffsetX = scrollXOffset() + xDelta;
+int newOffsetY = scrollYOffset() + yDelta;
scrollToOffset(newOffsetX, newOffsetY, clamp);
// If this layer can't do the scroll we ask the next layer up that can scroll to try
-LayoutUnit leftToScrollX = newOffsetX - scrollXOffset();
-LayoutUnit leftToScrollY = newOffsetY - scrollYOffset();
+int leftToScrollX = newOffsetX - scrollXOffset();
+int leftToScrollY = newOffsetY - scrollYOffset();
if ((leftToScrollX || leftToScrollY) renderer()-parent()) {
if (RenderLayer*
[webkit-changes] [110124] trunk/LayoutTests
Title: [110124] trunk/LayoutTests Revision 110124 Author senorbla...@chromium.org Date 2012-03-07 17:45:45 -0800 (Wed, 07 Mar 2012) Log Message [chromium] Unreviewed gardening. (Leopard, you will be the death of me.) * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110123 => 110124) --- trunk/LayoutTests/ChangeLog 2012-03-08 01:22:40 UTC (rev 110123) +++ trunk/LayoutTests/ChangeLog 2012-03-08 01:45:45 UTC (rev 110124) @@ -1,3 +1,11 @@ +2012-03-07 Stephen White senorbla...@chromium.org + +[chromium] Unreviewed gardening. + +(Leopard, you will be the death of me.) + +* platform/chromium/test_expectations.txt: + 2012-03-07 Ojan Vafai o...@chromium.org Yet another around of straightforward Chromium Lion rebaselines. Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110123 => 110124) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-08 01:22:40 UTC (rev 110123) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-08 01:45:45 UTC (rev 110124) @@ -3866,7 +3866,7 @@ // Those tests need a text baseline after lazily allocating layers. // The change should only be layer removal. BUGWK75568 : compositing/geometry/object-clip-rects-assertion.html = TEXT -BUGWK75568 : compositing/overflow/ancestor-overflow.html = TEXT +BUGWK75568 : compositing/overflow/ancestor-overflow.html = TEXT IMAGE+TEXT BUGWK75568 : editing/inserting/before-after-input-element.html = TEXT BUGWK75568 : editing/pasteboard/4806874.html = TEXT BUGWK75568 : editing/pasteboard/drop-text-without-selection.html = TEXT @@ -4026,3 +4026,7 @@ BUGWK80531 : fast/repaint/search-field-cancel.html = TEXT IMAGE+TEXT BUGWK80531 : fast/forms/textfield-overflow.html = IMAGE+TEXT + +BUG_SENORBLANCO LEOPARD : css2.1/t1202-counter-04-b.html = TEXT +BUG_SENORBLANCO LEOPARD : css2.1/t1202-counters-04-b.html = TEXT +BUG_SENORBLANCO LEOPARD : editing/pasteboard/paste-table-cells.html = IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110125] branches/subpixellayout/Source/WebCore/rendering
Title: [110125] branches/subpixellayout/Source/WebCore/rendering
Revision 110125
Author e...@chromium.org
Date 2012-03-07 17:47:36 -0800 (Wed, 07 Mar 2012)
Log Message
Change first/lastLineBoxBaseline to LayoutUnits to be consistent with baseline on branch.
Modified Paths
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h
branches/subpixellayout/Source/WebCore/rendering/RenderBox.h
branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderTable.h
branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.cpp
branches/subpixellayout/Source/WebCore/rendering/RenderTableSection.h
Diff
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp (110124 => 110125)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp 2012-03-08 01:45:45 UTC (rev 110124)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.cpp 2012-03-08 01:47:36 UTC (rev 110125)
@@ -5823,9 +5823,9 @@
bool ignoreBaseline = (layer() (layer()-marquee() || (direction == HorizontalLine ? (layer()-verticalScrollbar() || layer()-scrollYOffset() != 0)
: (layer()-horizontalScrollbar() || layer()-scrollXOffset() != 0 || (isWritingModeRoot() !isRubyRun());
-int baselinePos = ignoreBaseline ? -1 : lastLineBoxBaseline();
+LayoutUnit baselinePos = ignoreBaseline ? static_castLayoutUnit(-1) : lastLineBoxBaseline();
-int bottomOfContent = direction == HorizontalLine ? borderTop() + paddingTop() + contentHeight() : borderRight() + paddingRight() + contentWidth();
+LayoutUnit bottomOfContent = direction == HorizontalLine ? borderTop() + paddingTop() + contentHeight() : borderRight() + paddingRight() + contentWidth();
if (baselinePos != -1 baselinePos = bottomOfContent)
return direction == HorizontalLine ? marginTop() + baselinePos : marginRight() + baselinePos;
@@ -5836,7 +5836,7 @@
return fontMetrics.ascent(baselineType) + (lineHeight(firstLine, direction, linePositionMode) - fontMetrics.height()) / 2;
}
-int RenderBlock::firstLineBoxBaseline() const
+LayoutUnit RenderBlock::firstLineBoxBaseline() const
{
if (!isBlockFlow() || (isWritingModeRoot() !isRubyRun()))
return -1;
@@ -5860,7 +5860,7 @@
return -1;
}
-int RenderBlock::lastLineBoxBaseline() const
+LayoutUnit RenderBlock::lastLineBoxBaseline() const
{
if (!isBlockFlow() || (isWritingModeRoot() !isRubyRun()))
return -1;
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h (110124 => 110125)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h 2012-03-08 01:45:45 UTC (rev 110124)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBlock.h 2012-03-08 01:47:36 UTC (rev 110125)
@@ -439,8 +439,8 @@
virtual void computePreferredLogicalWidths();
-virtual int firstLineBoxBaseline() const;
-virtual int lastLineBoxBaseline() const;
+virtual LayoutUnit firstLineBoxBaseline() const;
+virtual LayoutUnit lastLineBoxBaseline() const;
virtual void updateHitTestResult(HitTestResult, const LayoutPoint);
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderBox.h (110124 => 110125)
--- branches/subpixellayout/Source/WebCore/rendering/RenderBox.h 2012-03-08 01:45:45 UTC (rev 110124)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderBox.h 2012-03-08 01:47:36 UTC (rev 110125)
@@ -407,8 +407,8 @@
RenderLayer* enclosingFloatPaintingLayer() const;
-virtual int firstLineBoxBaseline() const { return -1; }
-virtual int lastLineBoxBaseline() const { return -1; }
+virtual LayoutUnit firstLineBoxBaseline() const { return -1; }
+virtual LayoutUnit lastLineBoxBaseline() const { return -1; }
bool shrinkToAvoidFloats() const;
virtual bool avoidsFloats() const;
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp (110124 => 110125)
--- branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp 2012-03-08 01:45:45 UTC (rev 110124)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderTable.cpp 2012-03-08 01:47:36 UTC (rev 110125)
@@ -1207,7 +1207,7 @@
{
}
-int RenderTable::firstLineBoxBaseline() const
+LayoutUnit RenderTable::firstLineBoxBaseline() const
{
if (isWritingModeRoot())
return -1;
Modified: branches/subpixellayout/Source/WebCore/rendering/RenderTable.h (110124 => 110125)
--- branches/subpixellayout/Source/WebCore/rendering/RenderTable.h 2012-03-08 01:45:45 UTC (rev 110124)
+++ branches/subpixellayout/Source/WebCore/rendering/RenderTable.h 2012-03-08 01:47:36 UTC (rev 110125)
@@ -231,7 +231,7 @@
virtual void computePreferredLogicalWidths();
virtual bool nodeAtPoint(const HitTestRequest, HitTestResult, const LayoutPoint pointInContainer, const LayoutPoint
[webkit-changes] [110126] trunk
Title: [110126] trunk Revision 110126 Author mikelawt...@chromium.org Date 2012-03-07 18:12:26 -0800 (Wed, 07 Mar 2012) Log Message CSS3 calc: mixed absolute/percentages work for width, height, margin and padding https://bugs.webkit.org/show_bug.cgi?id=79621 Reviewed by Andreas Kling. Source/WebCore: ApplyPropertyLength in CSSStyleApplyPropery now handles mixed absolute/percentage length expressions. All property handlers using this template now work with mixed expressions. This patch adds a new _expression_ evaluator in CalculationValue.cpp. This is because Length.[cpp|h] (in platform) cannot refer to CSSCalculationValue.[cpp|h] (in css) due to layering restrictions. Lengths can be copied, and so the expressions are stored in a hashmap, and only their ids are copied along with Length. The expressions are RefCounted, and will get cleaned up when the last referring Length is destructed. * WebCore.exp.in: * css/CSSCalculationValue.cpp: (WebCore::CSSCalcPrimitiveValue::toCalcValue): (CSSCalcPrimitiveValue): (WebCore::CSSCalcBinaryOperation::toCalcValue): (CSSCalcBinaryOperation): * css/CSSCalculationValue.h: (WebCore): (CSSCalcExpressionNode): (CSSCalcValue): (WebCore::CSSCalcValue::toCalcValue): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyLength::applyValue): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::collectMatchingRulesForList): * css/CSSStyleSelector.h: (CSSStyleSelector): * platform/CalculationValue.cpp: (WebCore::CalcExpressionBinaryOperation::evaluate): (WebCore): (WebCore::CalculationValue::create): (WebCore::CalculationValue::evaluate): * platform/CalculationValue.h: (CalcExpressionNode): (WebCore::CalcExpressionNode::~CalcExpressionNode): (WebCore): (CalculationValue): (WebCore::CalculationValue::CalculationValue): (CalcExpressionNumber): (WebCore::CalcExpressionNumber::CalcExpressionNumber): (WebCore::CalcExpressionNumber::evaluate): (CalcExpressionLength): (WebCore::CalcExpressionLength::CalcExpressionLength): (WebCore::CalcExpressionLength::evaluate): (CalcExpressionBinaryOperation): (WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation): * platform/Length.cpp: (WebCore): (WebCore::Length::~Length): (CalculationValueHandleMap): (WebCore::CalculationValueHandleMap::CalculationValueHandleMap): (WebCore::CalculationValueHandleMap::insert): (WebCore::CalculationValueHandleMap::remove): (WebCore::CalculationValueHandleMap::get): (WebCore::calcHandles): (WebCore::Length::Length): (WebCore::Length::calculationValue): (WebCore::Length::calculatedValue): (WebCore::Length::calculatedMinValue): (WebCore::Length::calculatedFloatValue): (WebCore::Length::incrementCalculatedRef): (WebCore::Length::decrementCalculatedRef): (WebCore::Length::nonNanCalculatedValue): * platform/Length.h: (Length): (WebCore::Length::Length): (WebCore::Length::operator=): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative): (WebCore::Length::isPercent): (WebCore::Length::isSpecified): (WebCore::Length::isCalculated): (WebCore::Length::initFromLength): (WebCore::Length::calculationHandle): LayoutTests: * css3/calc/margin-expected.txt: * css3/calc/padding-expected.txt: * css3/calc/simple-calcs-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/calc/margin-expected.txt trunk/LayoutTests/css3/calc/padding-expected.txt trunk/LayoutTests/css3/calc/simple-calcs-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/css/CSSCalculationValue.cpp trunk/Source/WebCore/css/CSSCalculationValue.h trunk/Source/WebCore/css/CSSPrimitiveValue.cpp trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/css/CSSStyleSelector.h trunk/Source/WebCore/platform/CalculationValue.cpp trunk/Source/WebCore/platform/CalculationValue.h trunk/Source/WebCore/platform/Length.cpp trunk/Source/WebCore/platform/Length.h Diff Modified: trunk/LayoutTests/ChangeLog (110125 => 110126) --- trunk/LayoutTests/ChangeLog 2012-03-08 01:47:36 UTC (rev 110125) +++ trunk/LayoutTests/ChangeLog 2012-03-08 02:12:26 UTC (rev 110126) @@ -1,3 +1,14 @@ +2012-03-07 Mike Lawther mikelawt...@chromium.org + +CSS3 calc: mixed absolute/percentages work for width, height, margin and padding +https://bugs.webkit.org/show_bug.cgi?id=79621 + +Reviewed by Andreas Kling. + +* css3/calc/margin-expected.txt: +* css3/calc/padding-expected.txt: +* css3/calc/simple-calcs-expected.txt: + 2012-03-07 Stephen White senorbla...@chromium.org [chromium] Unreviewed gardening. Modified: trunk/LayoutTests/css3/calc/margin-expected.txt (110125 => 110126) ---
[webkit-changes] [110127] trunk/Source/JavaScriptCore
Title: [110127] trunk/Source/_javascript_Core
Revision 110127
Author mhahnenb...@apple.com
Date 2012-03-07 18:14:38 -0800 (Wed, 07 Mar 2012)
Log Message
Refactor recompileAllJSFunctions() to be less expensive
https://bugs.webkit.org/show_bug.cgi?id=80330
Reviewed by Geoffrey Garen.
This change is performance neutral on the JS benchmarks we track. It's mostly to improve page
load performance, which currently does at least a couple full GCs per navigation.
* heap/Heap.cpp:
(JSC::Heap::discardAllCompiledCode): Rename recompileAllJSFunctions to discardAllCompiledCode
because the function doesn't actually recompile anything (and never did); it simply throws code
away for it to be recompiled later if we determine we should do so.
(JSC):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::addFunctionExecutable): Adds a newly created FunctionExecutable to the Heap's list.
(JSC::Heap::removeFunctionExecutable): Removes the specified FunctionExecutable from the Heap's list.
* heap/Heap.h:
(JSC):
(Heap):
* runtime/Executable.cpp: Added next and prev fields to FunctionExecutables so that they can
be used in DoublyLinkedLists.
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::finalize): Removes the FunctionExecutable from the Heap's list.
* runtime/Executable.h:
(FunctionExecutable):
(JSC::FunctionExecutable::create): Adds the FunctionExecutable to the Heap's list.
* runtime/JSGlobalData.cpp: Remove recompileAllJSFunctions, as it's the Heap's job to own and manage
the list of FunctionExecutables.
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Use the new discardAllCompiledCode.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/runtime/Executable.cpp
trunk/Source/_javascript_Core/runtime/Executable.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (110126 => 110127)
--- trunk/Source/_javascript_Core/ChangeLog 2012-03-08 02:12:26 UTC (rev 110126)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-03-08 02:14:38 UTC (rev 110127)
@@ -1,3 +1,38 @@
+2012-03-07 Mark Hahnenberg mhahnenb...@apple.com
+
+Refactor recompileAllJSFunctions() to be less expensive
+https://bugs.webkit.org/show_bug.cgi?id=80330
+
+Reviewed by Geoffrey Garen.
+
+This change is performance neutral on the JS benchmarks we track. It's mostly to improve page
+load performance, which currently does at least a couple full GCs per navigation.
+
+* heap/Heap.cpp:
+(JSC::Heap::discardAllCompiledCode): Rename recompileAllJSFunctions to discardAllCompiledCode
+because the function doesn't actually recompile anything (and never did); it simply throws code
+away for it to be recompiled later if we determine we should do so.
+(JSC):
+(JSC::Heap::collectAllGarbage):
+(JSC::Heap::addFunctionExecutable): Adds a newly created FunctionExecutable to the Heap's list.
+(JSC::Heap::removeFunctionExecutable): Removes the specified FunctionExecutable from the Heap's list.
+* heap/Heap.h:
+(JSC):
+(Heap):
+* runtime/Executable.cpp: Added next and prev fields to FunctionExecutables so that they can
+be used in DoublyLinkedLists.
+(JSC::FunctionExecutable::FunctionExecutable):
+(JSC::FunctionExecutable::finalize): Removes the FunctionExecutable from the Heap's list.
+* runtime/Executable.h:
+(FunctionExecutable):
+(JSC::FunctionExecutable::create): Adds the FunctionExecutable to the Heap's list.
+* runtime/JSGlobalData.cpp: Remove recompileAllJSFunctions, as it's the Heap's job to own and manage
+the list of FunctionExecutables.
+* runtime/JSGlobalData.h:
+(JSGlobalData):
+* runtime/JSGlobalObject.cpp:
+(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope): Use the new discardAllCompiledCode.
+
2012-03-06 Oliver Hunt oli...@apple.com
Further harden 64-bit JIT
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (110126 => 110127)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2012-03-08 02:12:26 UTC (rev 110126)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2012-03-08 02:14:38 UTC (rev 110127)
@@ -764,12 +764,22 @@
return m_objectSpace.forEachCellRecordType();
}
+void Heap::discardAllCompiledCode()
+{
+// If _javascript_ is running, it's not safe to recompile, since we'll end
+// up throwing away code that is live on the stack.
+ASSERT(!m_globalData-dynamicGlobalObject);
+
+for (FunctionExecutable* current = m_functions.head(); current; current = current-next())
+
[webkit-changes] [110128] trunk/Source/WebCore
Title: [110128] trunk/Source/WebCore
Revision 110128
Author caio.olive...@openbossa.org
Date 2012-03-07 18:22:05 -0800 (Wed, 07 Mar 2012)
Log Message
Make Node::dumpStatistics() work again
https://bugs.webkit.org/show_bug.cgi?id=80327
Reviewed by Ryosuke Niwa.
Update the code in dumpStatistics() to the latest attribute storage changes. Also
move the DUMP_NODE_STATISTICS define here from the Node.cpp, since its also used
by Document.h.
* dom/Node.cpp:
(WebCore::Node::dumpStatistics): Use more self-describing variable names.
* dom/Node.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Node.cpp
trunk/Source/WebCore/dom/Node.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (110127 => 110128)
--- trunk/Source/WebCore/ChangeLog 2012-03-08 02:14:38 UTC (rev 110127)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 02:22:05 UTC (rev 110128)
@@ -1,3 +1,18 @@
+2012-03-05 Caio Marcelo de Oliveira Filho caio.olive...@openbossa.org
+
+Make Node::dumpStatistics() work again
+https://bugs.webkit.org/show_bug.cgi?id=80327
+
+Reviewed by Ryosuke Niwa.
+
+Update the code in dumpStatistics() to the latest attribute storage changes. Also
+move the DUMP_NODE_STATISTICS define here from the Node.cpp, since its also used
+by Document.h.
+
+* dom/Node.cpp:
+(WebCore::Node::dumpStatistics): Use more self-describing variable names.
+* dom/Node.h:
+
2012-03-07 Mike Lawther mikelawt...@chromium.org
CSS3 calc: mixed absolute/percentages work for width, height, margin and padding
Modified: trunk/Source/WebCore/dom/Node.cpp (110127 => 110128)
--- trunk/Source/WebCore/dom/Node.cpp 2012-03-08 02:14:38 UTC (rev 110127)
+++ trunk/Source/WebCore/dom/Node.cpp 2012-03-08 02:22:05 UTC (rev 110128)
@@ -120,8 +120,6 @@
#include HTMLPropertiesCollection.h
#endif
-#define DUMP_NODE_STATISTICS 0
-
using namespace std;
namespace WebCore {
@@ -161,7 +159,8 @@
size_t attributes = 0;
size_t attributesWithAttr = 0;
-size_t attrMaps = 0;
+size_t elementsWithAttributeStorage = 0;
+size_t elementsWithNamedNodeMap = 0;
for (HashSetNode*::iterator it = liveNodeSet.begin(); it != liveNodeSet.end(); ++it) {
Node* node = *it;
@@ -179,12 +178,13 @@
if (!result.second)
result.first-second++;
-// AttributeMap stats
-if (NamedNodeMap* attrMap = element-attributes(true)) {
-attributes += attrMap-length();
-++attrMaps;
-for (unsigned i = 0; i attrMap-length(); ++i) {
-Attribute* attr = attrMap-attributeItem(i);
+if (ElementAttributeData* attributeData = element-attributeData()) {
+attributes += attributeData-length();
+++elementsWithAttributeStorage;
+// FIXME: This will change once attribute storage goes out of NamedNodeMap.
+++elementsWithNamedNodeMap;
+for (unsigned i = 0; i attributeData-length(); ++i) {
+Attribute* attr = attributeData-attributeItem(i);
if (attr-attr())
++attributesWithAttr;
}
@@ -248,7 +248,7 @@
printf(Number of Nodes: %d\n\n, liveNodeSet.size());
printf(Number of Nodes with RareData: %zu\n\n, nodesWithRareData);
-printf(NodeType distrubution:\n);
+printf(NodeType distribution:\n);
printf( Number of Element nodes: %zu\n, elementNodes);
printf( Number of Attribute nodes: %zu\n, attrNodes);
printf( Number of Text nodes: %zu\n, textNodes);
@@ -268,10 +268,11 @@
for (HashMapString, size_t::iterator it = perTagCount.begin(); it != perTagCount.end(); ++it)
printf( Number of %s tags: %zu\n, it-first.utf8().data(), it-second);
-printf(Attribute Maps:\n);
+printf(Attributes:\n);
printf( Number of Attributes (non-Node and Node): %zu [%zu]\n, attributes, sizeof(Attribute));
printf( Number of Attributes with an Attr: %zu\n, attributesWithAttr);
-printf( Number of NamedNodeMaps: %zu [%zu]\n, attrMaps, sizeof(NamedNodeMap));
+printf( Number of Elements with attribute storage: %zu [%zu]\n, elementsWithAttributeStorage, sizeof(ElementAttributeData));
+printf( Number of Elements with NamedNodeMap: %zu [%zu]\n, elementsWithNamedNodeMap, sizeof(NamedNodeMap));
#endif
}
Modified: trunk/Source/WebCore/dom/Node.h (110127 => 110128)
--- trunk/Source/WebCore/dom/Node.h 2012-03-08 02:14:38 UTC (rev 110127)
+++ trunk/Source/WebCore/dom/Node.h 2012-03-08 02:22:05 UTC (rev 110128)
@@ -44,6 +44,9 @@
}
#endif
+// This needs to be here because Document.h also depends on it.
+#define DUMP_NODE_STATISTICS 0
+
namespace WebCore {
class Attribute;
___
webkit-changes mailing list
[webkit-changes] [110130] trunk
Title: [110130] trunk
Revision 110130
Author tk...@chromium.org
Date 2012-03-07 19:02:40 -0800 (Wed, 07 Mar 2012)
Log Message
Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
https://bugs.webkit.org/show_bug.cgi?id=80493
Reviewed by Hajime Morita.
Source/WebCore:
preferredContentWidth() added border+padding widths of the search result
button, search cancel button, and speech input button. It makes no sense
to make the intrinsic width wider by only their border+padding width,
not their content width.
The default borders and paddings of these buttons are 0 in all
platforms, and adding border or padding to these elements by page
authors made unreasonable behavior. So we had better remove this
code.
Tests: fast/forms/search/intrinsic-search-width-with-decoration-border-padding.html
fast/speech/intrinsic-input-width-with-speech-border-padding.html
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
Remove the meaningless code.
* rendering/RenderTextControlSingleLine.h:
(RenderTextControlSingleLine): Remove speechButtonElement(). It's unnecessary.
Source/WebKit/chromium:
* src/WebInputElement.cpp:
RenderTextControlSingleLine::speechButtonElement() is removed. The
following functions get it from HTMLInputElement.
(WebKit::WebInputElement::getSpeechInputState):
(WebKit::WebInputElement::startSpeechInput):
(WebKit::WebInputElement::stopSpeechInput):
LayoutTests:
Add tests to confirm that borders and paddings for decoration elements
don't affect intrinsic width of input elements.
* fast/forms/search/intrinsic-search-width-with-decoration-border-padding-expected.txt: Added.
* fast/forms/search/intrinsic-search-width-with-decoration-border-padding.html: Added.
* fast/speech/intrinsic-input-width-with-speech-border-padding-expected.txt: Added.
* fast/speech/intrinsic-input-width-with-speech-border-padding.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.h
trunk/Source/WebKit/chromium/ChangeLog
trunk/Source/WebKit/chromium/src/WebInputElement.cpp
Added Paths
trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding-expected.txt
trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding.html
trunk/LayoutTests/fast/speech/intrinsic-input-width-with-speech-border-padding-expected.txt
trunk/LayoutTests/fast/speech/intrinsic-input-width-with-speech-border-padding.html
Diff
Modified: trunk/LayoutTests/ChangeLog (110129 => 110130)
--- trunk/LayoutTests/ChangeLog 2012-03-08 02:50:39 UTC (rev 110129)
+++ trunk/LayoutTests/ChangeLog 2012-03-08 03:02:40 UTC (rev 110130)
@@ -1,3 +1,18 @@
+2012-03-07 Kent Tamura tk...@chromium.org
+
+Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth()
+https://bugs.webkit.org/show_bug.cgi?id=80493
+
+Reviewed by Hajime Morita.
+
+Add tests to confirm that borders and paddings for decoration elements
+don't affect intrinsic width of input elements.
+
+* fast/forms/search/intrinsic-search-width-with-decoration-border-padding-expected.txt: Added.
+* fast/forms/search/intrinsic-search-width-with-decoration-border-padding.html: Added.
+* fast/speech/intrinsic-input-width-with-speech-border-padding-expected.txt: Added.
+* fast/speech/intrinsic-input-width-with-speech-border-padding.html: Added.
+
2012-03-07 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r110126.
Added: trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding-expected.txt (0 => 110130)
--- trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding-expected.txt 2012-03-08 03:02:40 UTC (rev 110130)
@@ -0,0 +1,5 @@
+PASS document.getElementById(search1).offsetWidth is document.getElementById(search2).offsetWidth
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding.html (0 => 110130)
--- trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding.html (rev 0)
+++ trunk/LayoutTests/fast/forms/search/intrinsic-search-width-with-decoration-border-padding.html 2012-03-08 03:02:40 UTC (rev 110130)
@@ -0,0 +1,22 @@
+!DOCTYPE html
+style
+#search1::-webkit-search-cancel-button {
+border: 10px solid lime;
+padding: 10px;
+}
+#search1::-webkit-search-decoration {
+border: 10px solid lime;
+padding: 10px;
+}
+/style
+body
+script src=""
+
+input type=search id=search1
+input type=search id=search2
+script
[webkit-changes] [110131] trunk/Source/WebCore
Title: [110131] trunk/Source/WebCore Revision 110131 Author micha...@google.com Date 2012-03-07 19:07:44 -0800 (Wed, 07 Mar 2012) Log Message [Chromium] Don't be so CRASH() happy in the bindings layer. https://bugs.webkit.org/show_bug.cgi?id=75111 - change the v8 bindings generated code to check for the 'worker is terminating' condition prior to committing a suicidal CRASH() - fixup custom v8 bindings accordingly - simplify bindings/generic/ActiveDOMCallback, there is no need for it to support destruction on a different thread Reviewed by David Levin. No new tests, existing tests apply. * bindings/generic/ActiveDOMCallback.cpp: Simplified in general. (WebCore): (WebCore::ActiveDOMCallback::ActiveDOMCallback): (WebCore::ActiveDOMCallback::~ActiveDOMCallback): (WebCore::ActiveDOMCallback::canInvokeCallback): (WebCore::ActiveDOMCallback::isScriptControllerTerminating): New method to avoid CRASH()ing in exceptional conditions in v8 bindings. * bindings/generic/ActiveDOMCallback.h: Derive from ContextDestructionObserver. * bindings/js/WorkerScriptController.cpp: (WebCore::WorkerScriptController::scheduleExecutionTermination): Use a mutex to provide a memory barrier. (WebCore::WorkerScriptController::isExecutionTerminating): New supporting method to avoid CRASH()ing in exceptional conditions. * bindings/js/WorkerScriptController.h: (WorkerScriptController): * bindings/scripts/CodeGeneratorV8.pm: Generates v8 bindding code that uses isScriptControllerTerminating to avoid CRASH()ing. (GenerateCallbackImplementation): * bindings/scripts/test/V8/V8TestCallback.cpp: Fixup expected outputs of the modified CodeGeneratorV8.pm script. (WebCore::V8TestCallback::callbackWithClass1Param): (WebCore::V8TestCallback::callbackWithClass2Param): (WebCore::V8TestCallback::callbackWithStringList): * bindings/v8/WorkerScriptController.cpp: (WebCore::WorkerScriptController::WorkerScriptController): Initialize a new data member. (WebCore::WorkerScriptController::scheduleExecutionTermination): Use a mutex to provide a memory barrier. (WebCore::WorkerScriptController::isExecutionTerminating): New supporting method to avoid CRASH()ing in exceptional conditions. * bindings/v8/WorkerScriptController.h: Add a pair of new data members, bool + mutex. (WorkerScriptController): * bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp: (WebCore::V8SQLStatementErrorCallback::handleEvent): * bindings/v8/custom/V8MutationCallbackCustom.cpp: (WebCore::V8MutationCallback::handleEvent): * dom/ScriptExecutionContext.cpp: (WebCore::ScriptExecutionContext::ScriptExecutionContext): Initilaize data members. (WebCore::ScriptExecutionContext::stopActiveDOMObjects): Set m_activeDOMObjectsAreStopped. * dom/ScriptExecutionContext.h: Add m_activeDOMObjectsAreStopped data member. (WebCore::ScriptExecutionContext::activeDOMObjectsAreStopped): Simple getter. (ScriptExecutionContext): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.cpp trunk/Source/WebCore/bindings/generic/ActiveDOMCallback.h trunk/Source/WebCore/bindings/js/WorkerScriptController.cpp trunk/Source/WebCore/bindings/js/WorkerScriptController.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm trunk/Source/WebCore/bindings/scripts/test/V8/V8TestCallback.cpp trunk/Source/WebCore/bindings/v8/WorkerScriptController.cpp trunk/Source/WebCore/bindings/v8/WorkerScriptController.h trunk/Source/WebCore/bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp trunk/Source/WebCore/bindings/v8/custom/V8MutationCallbackCustom.cpp trunk/Source/WebCore/dom/ScriptExecutionContext.cpp trunk/Source/WebCore/dom/ScriptExecutionContext.h Diff Modified: trunk/Source/WebCore/ChangeLog (110130 => 110131) --- trunk/Source/WebCore/ChangeLog 2012-03-08 03:02:40 UTC (rev 110130) +++ trunk/Source/WebCore/ChangeLog 2012-03-08 03:07:44 UTC (rev 110131) @@ -1,3 +1,52 @@ +2012-03-07 Michael Nordman micha...@google.com + +[Chromium] Don't be so CRASH() happy in the bindings layer. +https://bugs.webkit.org/show_bug.cgi?id=75111 +- change the v8 bindings generated code to check for the 'worker is terminating' + condition prior to committing a suicidal CRASH() +- fixup custom v8 bindings accordingly +- simplify bindings/generic/ActiveDOMCallback, there is no need for it to support + destruction on a different thread + +Reviewed by David Levin. + +No new tests, existing tests apply. + +* bindings/generic/ActiveDOMCallback.cpp: Simplified in general. +(WebCore): +(WebCore::ActiveDOMCallback::ActiveDOMCallback): +(WebCore::ActiveDOMCallback::~ActiveDOMCallback): +(WebCore::ActiveDOMCallback::canInvokeCallback): +(WebCore::ActiveDOMCallback::isScriptControllerTerminating): New method to avoid CRASH()ing in exceptional conditions in v8 bindings. +* bindings/generic/ActiveDOMCallback.h: Derive from ContextDestructionObserver. +
[webkit-changes] [110133] trunk
Title: [110133] trunk Revision 110133 Author jber...@webkit.org Date 2012-03-07 19:10:08 -0800 (Wed, 07 Mar 2012) Log Message Clean Windows build fails after r110033 https://bugs.webkit.org/show_bug.cgi?id=80553 Rubber-stamped by Jon Honeycutt and Eric Seidel. Source/_javascript_Core: * _javascript_Core.vcproj/_javascript_Core/copy-files.cmd: Place the implementation files next to their header files in the wtf/text subdirectory. Use echo -F to tell xcopy that these are files (since there is apparently no flag). * _javascript_Core.vcproj/jsc/jsc.vcproj: Update the path to those implementation files. * _javascript_Core.vcproj/testRegExp/testRegExp.vcproj: Ditto. Source/ThirdParty: * gtest/msvc/gtest-md.vcproj: Add the new _javascript_Core include directory to the include path. Source/WebCore: * WebCore.vcproj/WebCore.vcproj: Update the expected location of the copied JSC WTF string implementation files. Tools: Add the new _javascript_Core include directory to some more vsprops files. * DumpRenderTree/win/ImageDiffCommon.vsprops: * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd trunk/Source/_javascript_Core/_javascript_Core.vcproj/jsc/jsc.vcproj trunk/Source/_javascript_Core/_javascript_Core.vcproj/testRegExp/testRegExp.vcproj trunk/Source/ThirdParty/ChangeLog trunk/Source/ThirdParty/gtest/msvc/gtest-md.vcproj trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/win/ImageDiffCommon.vsprops trunk/Tools/WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops trunk/Tools/WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops Diff Modified: trunk/Source/_javascript_Core/ChangeLog (110132 => 110133) --- trunk/Source/_javascript_Core/ChangeLog 2012-03-08 03:08:36 UTC (rev 110132) +++ trunk/Source/_javascript_Core/ChangeLog 2012-03-08 03:10:08 UTC (rev 110133) @@ -1,3 +1,18 @@ +2012-03-07 Jessie Berlin jber...@apple.com + +Clean Windows build fails after r110033 +https://bugs.webkit.org/show_bug.cgi?id=80553 + +Rubber-stamped by Jon Honeycutt and Eric Seidel. + +* _javascript_Core.vcproj/_javascript_Core/copy-files.cmd: +Place the implementation files next to their header files in the wtf/text subdirectory. +Use echo -F to tell xcopy that these are files (since there is apparently no flag). +* _javascript_Core.vcproj/jsc/jsc.vcproj: +Update the path to those implementation files. +* _javascript_Core.vcproj/testRegExp/testRegExp.vcproj: +Ditto. + 2012-03-07 Yuqiang Xian yuqiang.x...@intel.com Eliminate redundant Phis in DFG Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd (110132 => 110133) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd 2012-03-08 03:08:36 UTC (rev 110132) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/_javascript_Core/copy-files.cmd 2012-03-08 03:10:08 UTC (rev 110133) @@ -77,7 +77,7 @@ wtf\text\StringImpl.cpp wtf\text\WTFString.cpp ) do ( -xcopy /y /d ..\..\%%f %PrivateHeadersDirectory% NUL +echo F | xcopy /y /d ..\..\%%f %PrivateHeadersDirectory%\%%f NUL ) goto :EOF Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/jsc/jsc.vcproj (110132 => 110133) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/jsc/jsc.vcproj 2012-03-08 03:08:36 UTC (rev 110132) +++ trunk/Source/_javascript_Core/_javascript_Core.vcproj/jsc/jsc.vcproj 2012-03-08 03:10:08 UTC (rev 110133) @@ -448,7 +448,7 @@ /References Files File - RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\AtomicString.cpp + RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\wtf\text\AtomicString.cpp /File File @@ -456,15 +456,15 @@ /File File - RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\StringBuilder.cpp + RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\wtf\text\StringBuilder.cpp /File File - RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\StringImpl.cpp + RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\wtf\text\StringImpl.cpp /File File - RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\WTFString.cpp + RelativePath=$(ConfigurationBuildDir)\include\private\_javascript_Core\wtf\text\WTFString.cpp /File /Files Modified: trunk/Source/_javascript_Core/_javascript_Core.vcproj/testRegExp/testRegExp.vcproj (110132 => 110133) --- trunk/Source/_javascript_Core/_javascript_Core.vcproj/testRegExp/testRegExp.vcproj 2012-03-08 03:08:36 UTC (rev 110132)
[webkit-changes] [110134] trunk/Source/JavaScriptCore
Title: [110134] trunk/Source/_javascript_Core Revision 110134 Author commit-qu...@webkit.org Date 2012-03-07 19:15:00 -0800 (Wed, 07 Mar 2012) Log Message The end atom of the marked block considered to filter invalid cells https://bugs.webkit.org/show_bug.cgi?id=79191 Patch by Hojong Han hojong@samsung.com on 2012-03-07 Reviewed by Geoffrey Garen. Register file could have stale pointers beyond the end atom of marked block. Those pointers can weasel out of filtering in-middle-of-cell pointer. * heap/MarkedBlock.h: (JSC::MarkedBlock::isLiveCell): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/heap/MarkedBlock.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (110133 => 110134) --- trunk/Source/_javascript_Core/ChangeLog 2012-03-08 03:10:08 UTC (rev 110133) +++ trunk/Source/_javascript_Core/ChangeLog 2012-03-08 03:15:00 UTC (rev 110134) @@ -1,3 +1,16 @@ +2012-03-07 Hojong Han hojong@samsung.com + +The end atom of the marked block considered to filter invalid cells +https://bugs.webkit.org/show_bug.cgi?id=79191 + +Reviewed by Geoffrey Garen. + +Register file could have stale pointers beyond the end atom of marked block. +Those pointers can weasel out of filtering in-middle-of-cell pointer. + +* heap/MarkedBlock.h: +(JSC::MarkedBlock::isLiveCell): + 2012-03-07 Jessie Berlin jber...@apple.com Clean Windows build fails after r110033 Modified: trunk/Source/_javascript_Core/heap/MarkedBlock.h (110133 => 110134) --- trunk/Source/_javascript_Core/heap/MarkedBlock.h 2012-03-08 03:10:08 UTC (rev 110133) +++ trunk/Source/_javascript_Core/heap/MarkedBlock.h 2012-03-08 03:15:00 UTC (rev 110134) @@ -321,6 +321,8 @@ return false; if ((atomNumber - firstAtom) % m_atomsPerCell) // Filters pointers into cell middles. return false; +if (atomNumber = m_endAtom) // Filters pointers into invalid cells out of the range. +return false; return isLive(static_castconst JSCell*(p)); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110137] trunk/Source/WebCore
Title: [110137] trunk/Source/WebCore Revision 110137 Author hara...@chromium.org Date 2012-03-07 20:02:26 -0800 (Wed, 07 Mar 2012) Log Message [V8][Performance] Optimize V8 bindings for HTMLElement.classList, Element.dataset and Node.attributes https://bugs.webkit.org/show_bug.cgi?id=80376 Reviewed by Adam Barth. This patch improves the performance of HTMLElement.classList, Element.dataset and Node.attributes by 6.4 times, 7.1 times and 10.9 times, respectively. Previously, a 'hiddenReferenceName' string was allocated on v8::Handle and created every time the DOM attribute is accessed, in spite of the fact that the 'hiddenReferenceName' string is static. This patch moves the 'hiddenReferenceName' string to v8::Persistent and makes it static. Also, this patch removes 'if (!elementValue.IsEmpty() elementValue-IsObject())', since if 'element' exists, it is guaranteed that 'elementValue' is not empty and is an Object. Performance tests: https://bugs.webkit.org/attachment.cgi?id=130283 AppleWebKit/_javascript_Core: div.classList : 382ms div.classList.foo = 123 : 335ms div.dataset : 403ms div.dataset.foo = 123 : 5250ms div.attributes : 183ms Chromium/V8 (without this patch): div.classList : 9140ms div.classList.foo = 123 : 9086ms div.dataset : 9930ms div.dataset.foo = 123 : 49698ms div.attributes : 13489ms Chromium/V8 (with this patch): div.classList : 1435ms div.classList.foo = 123 : 1470ms div.dataset : 1400ms div.dataset.foo = 123 : 30396ms div.attributes : 1242ms No tests. No change in behavior. * bindings/v8/custom/V8DOMStringMapCustom.cpp: Modified as described above. (WebCore::toV8): * bindings/v8/custom/V8DOMTokenListCustom.cpp: Ditto. (WebCore::toV8): * bindings/v8/custom/V8NamedNodeMapCustom.cpp: Ditto. (WebCore::toV8): * bindings/v8/V8HiddenPropertyName.cpp: Defined a hidden property name string statically to optimize the macro. (WebCore): (WebCore::V8HiddenPropertyName::hiddenReferenceName): * bindings/v8/V8HiddenPropertyName.h: Modified to switch two prefixes WebCore::HiddenProperty:: and WebCore::HiddenReference::, depending on whether a given name represents a hidden property or a hidden reference. (WebCore): (V8HiddenPropertyName): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.cpp trunk/Source/WebCore/bindings/v8/V8HiddenPropertyName.h trunk/Source/WebCore/bindings/v8/custom/V8DOMStringMapCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8DOMTokenListCustom.cpp trunk/Source/WebCore/bindings/v8/custom/V8NamedNodeMapCustom.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (110136 => 110137) --- trunk/Source/WebCore/ChangeLog 2012-03-08 03:33:17 UTC (rev 110136) +++ trunk/Source/WebCore/ChangeLog 2012-03-08 04:02:26 UTC (rev 110137) @@ -1,3 +1,65 @@ +2012-03-07 Kentaro Hara hara...@chromium.org + +[V8][Performance] Optimize V8 bindings for HTMLElement.classList, +Element.dataset and Node.attributes +https://bugs.webkit.org/show_bug.cgi?id=80376 + +Reviewed by Adam Barth. + +This patch improves the performance of HTMLElement.classList, Element.dataset +and Node.attributes by 6.4 times, 7.1 times and 10.9 times, respectively. + +Previously, a 'hiddenReferenceName' string was allocated on v8::Handle and +created every time the DOM attribute is accessed, in spite of the fact that +the 'hiddenReferenceName' string is static. + +This patch moves the 'hiddenReferenceName' string to v8::Persistent and makes it static. +Also, this patch removes 'if (!elementValue.IsEmpty() elementValue-IsObject())', +since if 'element' exists, it is guaranteed that 'elementValue' is not empty +and is an Object. + +Performance tests: https://bugs.webkit.org/attachment.cgi?id=130283 + +AppleWebKit/_javascript_Core: +div.classList : 382ms +div.classList.foo = 123 : 335ms +div.dataset : 403ms +div.dataset.foo = 123 : 5250ms +div.attributes : 183ms + +Chromium/V8 (without this patch): +div.classList : 9140ms +div.classList.foo = 123 : 9086ms +div.dataset : 9930ms +div.dataset.foo = 123 : 49698ms +div.attributes : 13489ms + +Chromium/V8 (with this patch): +div.classList : 1435ms +div.classList.foo = 123 : 1470ms +div.dataset : 1400ms +div.dataset.foo = 123 : 30396ms +div.attributes : 1242ms + +No tests. No change in behavior. + +* bindings/v8/custom/V8DOMStringMapCustom.cpp: Modified as described above. +(WebCore::toV8): +* bindings/v8/custom/V8DOMTokenListCustom.cpp: Ditto. +(WebCore::toV8): +* bindings/v8/custom/V8NamedNodeMapCustom.cpp: Ditto. +(WebCore::toV8): + +* bindings/v8/V8HiddenPropertyName.cpp: Defined a hidden property name string statically +to optimize the macro. +(WebCore): +
[webkit-changes] [110138] trunk/Source/JavaScriptCore
Title: [110138] trunk/Source/_javascript_Core
Revision 110138
Author commit-qu...@webkit.org
Date 2012-03-07 20:04:40 -0800 (Wed, 07 Mar 2012)
Log Message
Unreviewed, rolling out r110127.
http://trac.webkit.org/changeset/110127
https://bugs.webkit.org/show_bug.cgi?id=80562
compile failed on AppleWin (Requested by ukai on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-03-07
* heap/Heap.cpp:
(JSC::Heap::collectAllGarbage):
* heap/Heap.h:
(JSC):
(Heap):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::finalize):
* runtime/Executable.h:
(FunctionExecutable):
(JSC::FunctionExecutable::create):
* runtime/JSGlobalData.cpp:
(WTF):
(Recompiler):
(WTF::Recompiler::operator()):
(JSC::JSGlobalData::recompileAllJSFunctions):
(JSC):
* runtime/JSGlobalData.h:
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/runtime/Executable.cpp
trunk/Source/_javascript_Core/runtime/Executable.h
trunk/Source/_javascript_Core/runtime/JSGlobalData.cpp
trunk/Source/_javascript_Core/runtime/JSGlobalData.h
trunk/Source/_javascript_Core/runtime/JSGlobalObject.cpp
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (110137 => 110138)
--- trunk/Source/_javascript_Core/ChangeLog 2012-03-08 04:02:26 UTC (rev 110137)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-03-08 04:04:40 UTC (rev 110138)
@@ -1,3 +1,33 @@
+2012-03-07 Sheriff Bot webkit.review@gmail.com
+
+Unreviewed, rolling out r110127.
+http://trac.webkit.org/changeset/110127
+https://bugs.webkit.org/show_bug.cgi?id=80562
+
+compile failed on AppleWin (Requested by ukai on #webkit).
+
+* heap/Heap.cpp:
+(JSC::Heap::collectAllGarbage):
+* heap/Heap.h:
+(JSC):
+(Heap):
+* runtime/Executable.cpp:
+(JSC::FunctionExecutable::FunctionExecutable):
+(JSC::FunctionExecutable::finalize):
+* runtime/Executable.h:
+(FunctionExecutable):
+(JSC::FunctionExecutable::create):
+* runtime/JSGlobalData.cpp:
+(WTF):
+(Recompiler):
+(WTF::Recompiler::operator()):
+(JSC::JSGlobalData::recompileAllJSFunctions):
+(JSC):
+* runtime/JSGlobalData.h:
+(JSGlobalData):
+* runtime/JSGlobalObject.cpp:
+(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):
+
2012-03-07 Hojong Han hojong@samsung.com
The end atom of the marked block considered to filter invalid cells
Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (110137 => 110138)
--- trunk/Source/_javascript_Core/heap/Heap.cpp 2012-03-08 04:02:26 UTC (rev 110137)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp 2012-03-08 04:04:40 UTC (rev 110138)
@@ -764,22 +764,12 @@
return m_objectSpace.forEachCellRecordType();
}
-void Heap::discardAllCompiledCode()
-{
-// If _javascript_ is running, it's not safe to recompile, since we'll end
-// up throwing away code that is live on the stack.
-ASSERT(!m_globalData-dynamicGlobalObject);
-
-for (FunctionExecutable* current = m_functions.head(); current; current = current-next())
-current-discardCode();
-}
-
void Heap::collectAllGarbage()
{
if (!m_isSafeToCollect)
return;
if (!m_globalData-dynamicGlobalObject)
-discardAllCompiledCode();
+m_globalData-recompileAllJSFunctions();
collect(DoSweep);
}
@@ -934,14 +924,4 @@
finalizer(weak.get());
}
-void Heap::addFunctionExecutable(FunctionExecutable* executable)
-{
-m_functions.append(executable);
-}
-
-void Heap::removeFunctionExecutable(FunctionExecutable* executable)
-{
-m_functions.remove(executable);
-}
-
} // namespace JSC
Modified: trunk/Source/_javascript_Core/heap/Heap.h (110137 => 110138)
--- trunk/Source/_javascript_Core/heap/Heap.h 2012-03-08 04:02:26 UTC (rev 110137)
+++ trunk/Source/_javascript_Core/heap/Heap.h 2012-03-08 04:04:40 UTC (rev 110138)
@@ -42,7 +42,6 @@
class CopiedSpace;
class CodeBlock;
-class FunctionExecutable;
class GCActivityCallback;
class GlobalCodeBlock;
class Heap;
@@ -106,8 +105,6 @@
typedef void (*Finalizer)(JSCell*);
JS_EXPORT_PRIVATE void addFinalizer(JSCell*, Finalizer);
-void addFunctionExecutable(FunctionExecutable*);
-void removeFunctionExecutable(FunctionExecutable*);
void notifyIsSafeToCollect() { m_isSafeToCollect = true; }
JS_EXPORT_PRIVATE void collectAllGarbage();
@@ -143,8 +140,6 @@
double lastGCLength() { return m_lastGCLength; }
-void discardAllCompiledCode();
-
private:
friend class CodeBlock;
friend class LLIntOffsetsExtractor;
@@ -244,8 +239,6 @@
[webkit-changes] [110139] trunk/Source/WebCore
Title: [110139] trunk/Source/WebCore
Revision 110139
Author aba...@webkit.org
Date 2012-03-07 20:08:41 -0800 (Wed, 07 Mar 2012)
Log Message
ContainerNode::willRemove uses a weak iteration pattern
https://bugs.webkit.org/show_bug.cgi?id=80530
Reviewed by Ryosuke Niwa.
This patch moves ContainerNode::willRemove to using a better iteration
pattern in which we collect all the nodes we're planning to iterate
into a vector and then iterate over them.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::willRemove):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110138 => 110139)
--- trunk/Source/WebCore/ChangeLog 2012-03-08 04:04:40 UTC (rev 110138)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 04:08:41 UTC (rev 110139)
@@ -1,3 +1,17 @@
+2012-03-07 Adam Barth aba...@webkit.org
+
+ContainerNode::willRemove uses a weak iteration pattern
+https://bugs.webkit.org/show_bug.cgi?id=80530
+
+Reviewed by Ryosuke Niwa.
+
+This patch moves ContainerNode::willRemove to using a better iteration
+pattern in which we collect all the nodes we're planning to iterate
+into a vector and then iterate over them.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::willRemove):
+
2012-03-07 Kentaro Hara hara...@chromium.org
[V8][Performance] Optimize V8 bindings for HTMLElement.classList,
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (110138 => 110139)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-03-08 04:04:40 UTC (rev 110138)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-03-08 04:08:41 UTC (rev 110139)
@@ -371,11 +371,14 @@
{
RefPtrNode protect(this);
-for (RefPtrNode child = firstChild(); child; child = child-nextSibling()) {
-if (child-parentNode() != this) // Check for child being removed from subtree while removing.
-break;
-child-willRemove();
+NodeVector children;
+collectNodes(this, children);
+for (size_t i = 0; i children.size(); ++i) {
+if (children[i]-parentNode() != this) // Check for child being removed from subtree while removing.
+continue;
+children[i]-willRemove();
}
+
Node::willRemove();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110140] branches/chromium/963/Source/WebCore/dom/ContainerNode.cpp
Title: [110140] branches/chromium/963/Source/WebCore/dom/ContainerNode.cpp
Revision 110140
Author infe...@chromium.org
Date 2012-03-07 20:16:56 -0800 (Wed, 07 Mar 2012)
Log Message
Merge 110139 - ContainerNode::willRemove uses a weak iteration pattern
https://bugs.webkit.org/show_bug.cgi?id=80530
Reviewed by Ryosuke Niwa.
This patch moves ContainerNode::willRemove to using a better iteration
pattern in which we collect all the nodes we're planning to iterate
into a vector and then iterate over them.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::willRemove):
TBR=aba...@webkit.org
Review URL: https://chromiumcodereview.appspot.com/9641008
Modified Paths
branches/chromium/963/Source/WebCore/dom/ContainerNode.cpp
Diff
Modified: branches/chromium/963/Source/WebCore/dom/ContainerNode.cpp (110139 => 110140)
--- branches/chromium/963/Source/WebCore/dom/ContainerNode.cpp 2012-03-08 04:08:41 UTC (rev 110139)
+++ branches/chromium/963/Source/WebCore/dom/ContainerNode.cpp 2012-03-08 04:16:56 UTC (rev 110140)
@@ -386,11 +386,14 @@
{
RefPtrNode protect(this);
-for (RefPtrNode child = firstChild(); child; child = child-nextSibling()) {
-if (child-parentNode() != this) // Check for child being removed from subtree while removing.
-break;
-child-willRemove();
+NodeVector children;
+collectNodes(this, children);
+for (size_t i = 0; i children.size(); ++i) {
+if (children[i]-parentNode() != this) // Check for child being removed from subtree while removing.
+continue;
+children[i]-willRemove();
}
+
Node::willRemove();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110141] trunk/LayoutTests
Title: [110141] trunk/LayoutTests Revision 110141 Author u...@chromium.org Date 2012-03-07 20:21:56 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed. update chromium test expecation. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110140 => 110141) --- trunk/LayoutTests/ChangeLog 2012-03-08 04:16:56 UTC (rev 110140) +++ trunk/LayoutTests/ChangeLog 2012-03-08 04:21:56 UTC (rev 110141) @@ -1,3 +1,9 @@ +2012-03-07 Fumitoshi Ukai u...@chromium.org + +Unreviewed. update chromium test expecation. + +* platform/chromium/test_expectations.txt: + 2012-03-07 Kent Tamura tk...@chromium.org Remove meaningless code in RenderTextControlSingleLine::preferredContentWidth() Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110140 => 110141) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-08 04:16:56 UTC (rev 110140) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-08 04:21:56 UTC (rev 110141) @@ -4030,3 +4030,5 @@ BUG_SENORBLANCO LEOPARD : css2.1/t1202-counter-04-b.html = TEXT BUG_SENORBLANCO LEOPARD : css2.1/t1202-counters-04-b.html = TEXT BUG_SENORBLANCO LEOPARD : editing/pasteboard/paste-table-cells.html = IMAGE + +BUGWK80563 : css3/filters/effect-combined-hw.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110142] trunk
Title: [110142] trunk Revision 110142 Author rn...@webkit.org Date 2012-03-07 20:27:19 -0800 (Wed, 07 Mar 2012) Log Message Turn Runs class into a proper model to implement incremental JSON update https://bugs.webkit.org/show_bug.cgi?id=80364 Reviewed by Hajime Morita. Move Runs from json_generators.py to models.py and turn it into a proper Model. Now most JSON responses are held by Runs objects instead of PersistentCache. Added some tests around update_or_insert and json_by_ids to test PersistentCache-like behavior but there should be no user-visible behavioral differences. * Websites/webkit-perf.appspot.com/controller.py: (RunsUpdateHandler.post): (CachedRunsHandler.get): (RunsChartHandler.post): * Websites/webkit-perf.appspot.com/json_generators.py: (ManifestJSONGenerator.value): * Websites/webkit-perf.appspot.com/json_generators_unittest.py: (ManifestJSONGeneratorTest.test_value_two_tests): * Websites/webkit-perf.appspot.com/models.py: (Test): (Runs): (Runs._generate_runs): (Runs._entry_from_build_and_result): (Runs._key_name): (Runs.update_or_insert): (Runs.json_by_ids): (Runs.to_json): (Runs.chart_params): * Websites/webkit-perf.appspot.com/models_unittest.py: (RunsTest): (RunsTest.setUp): (RunsTest._create_results): (RunsTest.test_generate_runs): (RunsTest.test_update_or_insert): (RunsTest.test_json_by_ids): (RunsTest.test_to_json_without_results): (RunsTest.test_to_json_with_results): (RunsTest._assert_entry): (RunsTest.test_run_from_build_and_result): (RunsTest.test_run_from_build_and_result.create_build): (RunsTest.test_chart_params_with_value): (RunsTest.test_chart_params_with_value.split_as_int): Modified Paths trunk/ChangeLog trunk/Websites/webkit-perf.appspot.com/controller.py trunk/Websites/webkit-perf.appspot.com/json_generators.py trunk/Websites/webkit-perf.appspot.com/json_generators_unittest.py trunk/Websites/webkit-perf.appspot.com/models.py trunk/Websites/webkit-perf.appspot.com/models_unittest.py Diff Modified: trunk/ChangeLog (110141 => 110142) --- trunk/ChangeLog 2012-03-08 04:21:56 UTC (rev 110141) +++ trunk/ChangeLog 2012-03-08 04:27:19 UTC (rev 110142) @@ -1,3 +1,49 @@ +2012-03-05 Ryosuke Niwa rn...@webkit.org + +Turn Runs class into a proper model to implement incremental JSON update +https://bugs.webkit.org/show_bug.cgi?id=80364 + +Reviewed by Hajime Morita. + +Move Runs from json_generators.py to models.py and turn it into a proper Model. + +Now most JSON responses are held by Runs objects instead of PersistentCache. +Added some tests around update_or_insert and json_by_ids to test PersistentCache-like +behavior but there should be no user-visible behavioral differences. + +* Websites/webkit-perf.appspot.com/controller.py: +(RunsUpdateHandler.post): +(CachedRunsHandler.get): +(RunsChartHandler.post): +* Websites/webkit-perf.appspot.com/json_generators.py: +(ManifestJSONGenerator.value): +* Websites/webkit-perf.appspot.com/json_generators_unittest.py: +(ManifestJSONGeneratorTest.test_value_two_tests): +* Websites/webkit-perf.appspot.com/models.py: +(Test): +(Runs): +(Runs._generate_runs): +(Runs._entry_from_build_and_result): +(Runs._key_name): +(Runs.update_or_insert): +(Runs.json_by_ids): +(Runs.to_json): +(Runs.chart_params): +* Websites/webkit-perf.appspot.com/models_unittest.py: +(RunsTest): +(RunsTest.setUp): +(RunsTest._create_results): +(RunsTest.test_generate_runs): +(RunsTest.test_update_or_insert): +(RunsTest.test_json_by_ids): +(RunsTest.test_to_json_without_results): +(RunsTest.test_to_json_with_results): +(RunsTest._assert_entry): +(RunsTest.test_run_from_build_and_result): +(RunsTest.test_run_from_build_and_result.create_build): +(RunsTest.test_chart_params_with_value): +(RunsTest.test_chart_params_with_value.split_as_int): + 2012-03-07 Simon Hausmann simon.hausm...@nokia.com [Qt] Fix compilation without QtQuick1 Modified: trunk/Websites/webkit-perf.appspot.com/controller.py (110141 => 110142) --- trunk/Websites/webkit-perf.appspot.com/controller.py 2012-03-08 04:21:56 UTC (rev 110141) +++ trunk/Websites/webkit-perf.appspot.com/controller.py 2012-03-08 04:27:19 UTC (rev 110142) @@ -34,12 +34,12 @@ from json_generators import DashboardJSONGenerator from json_generators import ManifestJSONGenerator -from json_generators import Runs from models import Branch from models import DashboardImage +from models import PersistentCache from models import Platform +from models import Runs from models import Test -from models import PersistentCache from models import model_from_numeric_id @@ -116,7 +116,7 @@ assert platform assert test -PersistentCache.set_cache(Test.cache_key(test_id,
[webkit-changes] [110143] trunk/LayoutTests
Title: [110143] trunk/LayoutTests Revision 110143 Author u...@chromium.org Date 2012-03-07 20:37:30 -0800 (Wed, 07 Mar 2012) Log Message Unreviewed. update chromium test expectations. * platform/chromium/test_expectations.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/test_expectations.txt Diff Modified: trunk/LayoutTests/ChangeLog (110142 => 110143) --- trunk/LayoutTests/ChangeLog 2012-03-08 04:27:19 UTC (rev 110142) +++ trunk/LayoutTests/ChangeLog 2012-03-08 04:37:30 UTC (rev 110143) @@ -1,5 +1,11 @@ 2012-03-07 Fumitoshi Ukai u...@chromium.org +Unreviewed. update chromium test expectations. + +* platform/chromium/test_expectations.txt: + +2012-03-07 Fumitoshi Ukai u...@chromium.org + Unreviewed. update chromium test expecation. * platform/chromium/test_expectations.txt: Modified: trunk/LayoutTests/platform/chromium/test_expectations.txt (110142 => 110143) --- trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-08 04:27:19 UTC (rev 110142) +++ trunk/LayoutTests/platform/chromium/test_expectations.txt 2012-03-08 04:37:30 UTC (rev 110143) @@ -3688,10 +3688,8 @@ BUGWK80517 DEBUG : svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html = IMAGE PASS // Test is acting extra flakey on Mac and Win Debug -BUGCR114777 MAC : compositing/culling/filter-occlusion-blur-large.html = PASS IMAGE -BUGCR114777 MAC : compositing/culling/filter-occlusion-blur.html = PASS IMAGE -BUGCR114777 WIN DEBUG : compositing/culling/filter-occlusion-blur-large.html = PASS IMAGE -BUGCR114777 WIN DEBUG : compositing/culling/filter-occlusion-blur.html = PASS IMAGE +BUGCR114777 : compositing/culling/filter-occlusion-blur-large.html = PASS IMAGE +BUGCR114777 : compositing/culling/filter-occlusion-blur.html = PASS IMAGE // Needs rebaseline BUGWK78878 : media/audio-repaint.html = IMAGE @@ -4032,3 +4030,5 @@ BUG_SENORBLANCO LEOPARD : editing/pasteboard/paste-table-cells.html = IMAGE BUGWK80563 : css3/filters/effect-combined-hw.html = PASS IMAGE +BUGWK80563 : css3/filters/effect-hue-rotate-hw.html = PASS IMAGE +BUGWK80563 : css3/filters/effect-opacity-hw.html = PASS IMAGE ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110144] trunk/Source/WebCore
Title: [110144] trunk/Source/WebCore
Revision 110144
Author mikelawt...@chromium.org
Date 2012-03-07 20:49:11 -0800 (Wed, 07 Mar 2012)
Log Message
use DEFINE_STATIC_LOCAL on Lengths to avoid exit time destructors
https://bugs.webkit.org/show_bug.cgi?id=80561
Reviewed by Eric Seidel.
This is in preparation for http://wkb.ug/79621 where a destructor is added to Length.
No new tests as this is not a behaviour change.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110143 => 110144)
--- trunk/Source/WebCore/ChangeLog 2012-03-08 04:37:30 UTC (rev 110143)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 04:49:11 UTC (rev 110144)
@@ -1,3 +1,17 @@
+2012-03-07 Mike Lawther mikelawt...@chromium.org
+
+use DEFINE_STATIC_LOCAL on Lengths to avoid exit time destructors
+https://bugs.webkit.org/show_bug.cgi?id=80561
+
+Reviewed by Eric Seidel.
+
+This is in preparation for http://wkb.ug/79621 where a destructor is added to Length.
+
+No new tests as this is not a behaviour change.
+
+* css/CSSStyleApplyProperty.cpp:
+(WebCore::ApplyPropertyPageSize::getPageSizeFromName):
+
2012-03-07 Adam Barth aba...@webkit.org
ContainerNode::willRemove uses a weak iteration pattern
Modified: trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp (110143 => 110144)
--- trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-03-08 04:37:30 UTC (rev 110143)
+++ trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp 2012-03-08 04:49:11 UTC (rev 110144)
@@ -1216,14 +1216,22 @@
static Length inchLength(double inch) { return CSSPrimitiveValue::create(inch, CSSPrimitiveValue::CSS_IN)-computeLengthLength(0, 0); }
static bool getPageSizeFromName(CSSPrimitiveValue* pageSizeName, CSSPrimitiveValue* pageOrientation, Length width, Length height)
{
-static const Length a5Width = mmLength(148), a5Height = mmLength(210);
-static const Length a4Width = mmLength(210), a4Height = mmLength(297);
-static const Length a3Width = mmLength(297), a3Height = mmLength(420);
-static const Length b5Width = mmLength(176), b5Height = mmLength(250);
-static const Length b4Width = mmLength(250), b4Height = mmLength(353);
-static const Length letterWidth = inchLength(8.5), letterHeight = inchLength(11);
-static const Length legalWidth = inchLength(8.5), legalHeight = inchLength(14);
-static const Length ledgerWidth = inchLength(11), ledgerHeight = inchLength(17);
+DEFINE_STATIC_LOCAL(Length, a5Width, (mmLength(148)));
+DEFINE_STATIC_LOCAL(Length, a5Height, (mmLength(210)));
+DEFINE_STATIC_LOCAL(Length, a4Width, (mmLength(210)));
+DEFINE_STATIC_LOCAL(Length, a4Height, (mmLength(297)));
+DEFINE_STATIC_LOCAL(Length, a3Width, (mmLength(297)));
+DEFINE_STATIC_LOCAL(Length, a3Height, (mmLength(420)));
+DEFINE_STATIC_LOCAL(Length, b5Width, (mmLength(176)));
+DEFINE_STATIC_LOCAL(Length, b5Height, (mmLength(250)));
+DEFINE_STATIC_LOCAL(Length, b4Width, (mmLength(250)));
+DEFINE_STATIC_LOCAL(Length, b4Height, (mmLength(353)));
+DEFINE_STATIC_LOCAL(Length, letterWidth, (inchLength(8.5)));
+DEFINE_STATIC_LOCAL(Length, letterHeight, (inchLength(11)));
+DEFINE_STATIC_LOCAL(Length, legalWidth, (inchLength(8.5)));
+DEFINE_STATIC_LOCAL(Length, legalHeight, (inchLength(14)));
+DEFINE_STATIC_LOCAL(Length, ledgerWidth, (inchLength(11)));
+DEFINE_STATIC_LOCAL(Length, ledgerHeight, (inchLength(17)));
if (!pageSizeName)
return false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110145] trunk/Source/WebCore
Title: [110145] trunk/Source/WebCore
Revision 110145
Author tk...@chromium.org
Date 2012-03-07 21:31:25 -0800 (Wed, 07 Mar 2012)
Log Message
Do not refer to resutlsButtonElement and cancelButtonElement to compute paddings of search popups
https://bugs.webkit.org/show_bug.cgi?id=80564
Reviewed by Hajime Morita.
We'd like to reduce dependency of resultsButtonElement and
cancelButtonElement from RenderTextControlSingleLine.
No behavior change.
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
Use the left position of innerBlockElement, instead of the width of resultsButtonElement.
They are equivalent.
(WebCore::RenderTextControlSingleLine::clientPaddingRight):
Use the container width - right position of innerBlockElement,
instead of the width of the cancelButtonElement. They are
equivalent.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110144 => 110145)
--- trunk/Source/WebCore/ChangeLog 2012-03-08 04:49:11 UTC (rev 110144)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 05:31:25 UTC (rev 110145)
@@ -1,3 +1,24 @@
+2012-03-07 Kent Tamura tk...@chromium.org
+
+Do not refer to resutlsButtonElement and cancelButtonElement to compute paddings of search popups
+https://bugs.webkit.org/show_bug.cgi?id=80564
+
+Reviewed by Hajime Morita.
+
+We'd like to reduce dependency of resultsButtonElement and
+cancelButtonElement from RenderTextControlSingleLine.
+
+No behavior change.
+
+* rendering/RenderTextControlSingleLine.cpp:
+(WebCore::RenderTextControlSingleLine::clientPaddingLeft):
+Use the left position of innerBlockElement, instead of the width of resultsButtonElement.
+They are equivalent.
+(WebCore::RenderTextControlSingleLine::clientPaddingRight):
+Use the container width - right position of innerBlockElement,
+instead of the width of the cancelButtonElement. They are
+equivalent.
+
2012-03-07 Mike Lawther mikelawt...@chromium.org
use DEFINE_STATIC_LOCAL on Lengths to avoid exit time destructors
Modified: trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp (110144 => 110145)
--- trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2012-03-08 04:49:11 UTC (rev 110144)
+++ trunk/Source/WebCore/rendering/RenderTextControlSingleLine.cpp 2012-03-08 05:31:25 UTC (rev 110145)
@@ -613,22 +613,18 @@
LayoutUnit RenderTextControlSingleLine::clientPaddingLeft() const
{
LayoutUnit padding = paddingLeft();
-
-HTMLElement* resultsButton = resultsButtonElement();
-if (RenderBox* resultsRenderer = resultsButton ? resultsButton-renderBox() : 0)
-padding += resultsRenderer-width() + resultsRenderer-marginLeft() + resultsRenderer-paddingLeft() + resultsRenderer-marginRight() + resultsRenderer-paddingRight();
-
+if (RenderBox* box = innerBlockElement() ? innerBlockElement()-renderBox() : 0)
+padding += box-x();
return padding;
}
LayoutUnit RenderTextControlSingleLine::clientPaddingRight() const
{
LayoutUnit padding = paddingRight();
-
-HTMLElement* cancelButton = cancelButtonElement();
-if (RenderBox* cancelRenderer = cancelButton ? cancelButton-renderBox() : 0)
-padding += cancelRenderer-width() + cancelRenderer-marginLeft() + cancelRenderer-paddingLeft() + cancelRenderer-marginRight() + cancelRenderer-paddingRight();
-
+if (RenderBox* containerBox = containerElement() ? containerElement()-renderBox() : 0) {
+if (RenderBox* innerBlockBox = innerBlockElement() ? innerBlockElement()-renderBox() : 0)
+padding += containerBox-width() - (innerBlockBox-x() + innerBlockBox-width());
+}
return padding;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110146] releases/WebKitGTK/webkit-1.8/Source/WebKit2
Title: [110146] releases/WebKitGTK/webkit-1.8/Source/WebKit2
Revision 110146
Author mrobin...@webkit.org
Date 2012-03-07 22:06:16 -0800 (Wed, 07 Mar 2012)
Log Message
Merging r109881
Modified Paths
releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog
releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp
releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp
releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp
releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.h
Diff
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog (110145 => 110146)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog 2012-03-08 05:31:25 UTC (rev 110145)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit2/ChangeLog 2012-03-08 06:06:16 UTC (rev 110146)
@@ -1,3 +1,16 @@
+2012-03-07 Carlos Garcia Campos cgar...@igalia.com
+
+[GTK] Fix several documentation issues in WebKit2 GTK+ API
+https://bugs.webkit.org/show_bug.cgi?id=80281
+
+Reviewed by Martin Robinson.
+
+* UIProcess/API/gtk/WebKitFindController.cpp:
+* UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
+(webkit_navigation_policy_decision_class_init):
+* UIProcess/API/gtk/WebKitPrintOperation.cpp:
+* UIProcess/API/gtk/WebKitWebView.h:
+
2012-03-05 Mario Sanchez Prada msanc...@igalia.com
[GTK] Add GMainLoop and GMainContext to be handled by GRefPtr
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp (110145 => 110146)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp 2012-03-08 05:31:25 UTC (rev 110145)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp 2012-03-08 06:06:16 UTC (rev 110146)
@@ -380,13 +380,13 @@
*
* To look for the next or previous occurrences of the same text
* with the same find options use webkit_find_controller_search_next()
- * and/or webkit_find_options_previous(). The
+ * and/or webkit_find_controller_search_previous(). The
* #WebKitFindController will use the same text and options for the
* following searches unless they are modified by another call to this
* method.
*
* Note that if the number of matches is higher than @max_match_count
- * then WebKitFindController::found-text will report G_MAXUINT matches
+ * then #WebKitFindController::found-text will report %G_MAXUINT matches
* instead of the actual number.
*
* Callers should call webkit_find_controller_search_finish() to
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp (110145 => 110146)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp 2012-03-08 05:31:25 UTC (rev 110145)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp 2012-03-08 06:06:16 UTC (rev 110146)
@@ -38,7 +38,7 @@
* @See_also: #WebKitPolicyDecision, #WebKitWebView
*
* WebKitNavigationPolicyDecision represents a policy decision for events associated with
- * navigations. If the value of WebKitNavigationPolicyDecision:mouse-button is not 0, then
+ * navigations. If the value of #WebKitNavigationPolicyDecision:mouse-button is not 0, then
* the navigation was triggered by a mouse event.
*/
@@ -143,7 +143,7 @@
*
* If the navigation associated with this policy decision was originally
* triggered by a mouse event, this property contains a bitmask of various
- * GdkModifierType values describing the modifiers used for that click.
+ * #GdkModifierType values describing the modifiers used for that click.
* If the navigation was not triggered by a mouse event or no modifiers
* were active, the value of this property will be zero.
*/
@@ -248,7 +248,7 @@
*
* Gets the value of the #WebKitNavigationPolicyDecision:frame-name property.
*
- * Returns: The name of the new frame this navigation action targets or %NULL
+ * Returns: The name of the new frame this navigation action targets or %NULL
*/
const char* webkit_navigation_policy_decision_get_frame_name(WebKitNavigationPolicyDecision* decision)
{
Modified: releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp (110145 => 110146)
--- releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp 2012-03-08 05:31:25 UTC (rev 110145)
+++ releases/WebKitGTK/webkit-1.8/Source/WebKit2/UIProcess/API/gtk/WebKitPrintOperation.cpp 2012-03-08 06:06:16 UTC (rev 110146)
@@ -367,7 +367,7 @@
* the user. This method returns when the print dialog is closed.
* If the print dialog is cancelled %WEBKIT_PRINT_OPERATION_RESPONSE_CANCEL
* is returned. If the user clicks on the print button, %WEBKIT_PRINT_OPERATION_RESPONSE_PRINT
-
[webkit-changes] [110147] trunk/Source/JavaScriptCore
Title: [110147] trunk/Source/_javascript_Core
Revision 110147
Author commit-qu...@webkit.org
Date 2012-03-07 22:15:01 -0800 (Wed, 07 Mar 2012)
Log Message
[Qt] Fix the MIPS/SH4 build after r109834
https://bugs.webkit.org/show_bug.cgi?id=80492
Patch by Chao-yng Fu f...@mips.com on 2012-03-07
Reviewed by Oliver Hunt.
Implement three-argument branch(Add,Sub)32.
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::add32):
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::sub32):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchSub32):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (110146 => 110147)
--- trunk/Source/_javascript_Core/ChangeLog 2012-03-08 06:06:16 UTC (rev 110146)
+++ trunk/Source/_javascript_Core/ChangeLog 2012-03-08 06:15:01 UTC (rev 110147)
@@ -1,3 +1,19 @@
+2012-03-07 Chao-yng Fu f...@mips.com
+
+[Qt] Fix the MIPS/SH4 build after r109834
+https://bugs.webkit.org/show_bug.cgi?id=80492
+
+Reviewed by Oliver Hunt.
+
+Implement three-argument branch(Add,Sub)32.
+
+* assembler/MacroAssemblerMIPS.h:
+(JSC::MacroAssemblerMIPS::add32):
+(MacroAssemblerMIPS):
+(JSC::MacroAssemblerMIPS::sub32):
+(JSC::MacroAssemblerMIPS::branchAdd32):
+(JSC::MacroAssemblerMIPS::branchSub32):
+
2012-03-07 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r110127.
Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h (110146 => 110147)
--- trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h 2012-03-08 06:06:16 UTC (rev 110146)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerMIPS.h 2012-03-08 06:15:01 UTC (rev 110147)
@@ -132,6 +132,11 @@
}
}
+void add32(RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+add32(imm, src, dest);
+}
+
void add32(TrustedImm32 imm, Address address)
{
if (address.offset = -32768 address.offset = 32767
@@ -368,6 +373,24 @@
}
}
+void sub32(RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+if (!imm.m_isPointer imm.m_value = -32767 imm.m_value = 32768
+ !m_fixedWidth) {
+/*
+ addiu dest, src, imm
+*/
+m_assembler.addiu(dest, src, -imm.m_value);
+} else {
+/*
+ liimmTemp, imm
+ subu dest, src, immTemp
+*/
+move(imm, immTempRegister);
+m_assembler.subu(dest, src, immTempRegister);
+}
+}
+
void sub32(TrustedImm32 imm, Address address)
{
if (address.offset = -32768 address.offset = 32767
@@ -1203,6 +1226,13 @@
return branchAdd32(cond, immTempRegister, dest);
}
+Jump branchAdd32(ResultCondition cond, RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+move(imm, immTempRegister);
+move(src, dest);
+return branchAdd32(cond, immTempRegister, dest);
+}
+
Jump branchMul32(ResultCondition cond, RegisterID src, RegisterID dest)
{
ASSERT((cond == Overflow) || (cond == Signed) || (cond == Zero) || (cond == NonZero));
@@ -1308,6 +1338,13 @@
return branchSub32(cond, immTempRegister, dest);
}
+Jump branchSub32(ResultCondition cond, RegisterID src, TrustedImm32 imm, RegisterID dest)
+{
+move(imm, immTempRegister);
+move(src, dest);
+return branchSub32(cond, immTempRegister, dest);
+}
+
Jump branchOr32(ResultCondition cond, RegisterID src, RegisterID dest)
{
ASSERT((cond == Signed) || (cond == Zero) || (cond == NonZero));
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110148] trunk
Title: [110148] trunk Revision 110148 Author mikelawt...@chromium.org Date 2012-03-07 22:48:35 -0800 (Wed, 07 Mar 2012) Log Message CSS3 calc: mixed absolute/percentages work for width, height, margin and padding https://bugs.webkit.org/show_bug.cgi?id=79621 Reviewed by Andreas Kling. Source/WebCore: ApplyPropertyLength in CSSStyleApplyPropery now handles mixed absolute/percentage length expressions. All property handlers using this template now work with mixed expressions. This patch adds a new _expression_ evaluator in CalculationValue.cpp. This is because Length.[cpp|h] (in platform) cannot refer to CSSCalculationValue.[cpp|h] (in css) due to layering restrictions. Lengths can be copied, and so the expressions are stored in a hashmap, and only their ids are copied along with Length. The expressions are RefCounted, and will get cleaned up when the last referring Length is destructed. * WebCore.exp.in: * css/CSSCalculationValue.cpp: (WebCore::CSSCalcPrimitiveValue::toCalcValue): (CSSCalcPrimitiveValue): (WebCore::CSSCalcBinaryOperation::toCalcValue): (CSSCalcBinaryOperation): * css/CSSCalculationValue.h: (WebCore): (CSSCalcExpressionNode): (CSSCalcValue): (WebCore::CSSCalcValue::toCalcValue): * css/CSSPrimitiveValue.cpp: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): * css/CSSStyleApplyProperty.cpp: (WebCore::ApplyPropertyLength::applyValue): * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::collectMatchingRulesForList): * css/CSSStyleSelector.h: (CSSStyleSelector): * platform/CalculationValue.cpp: (WebCore::CalcExpressionBinaryOperation::evaluate): (WebCore): (WebCore::CalculationValue::create): (WebCore::CalculationValue::evaluate): * platform/CalculationValue.h: (CalcExpressionNode): (WebCore::CalcExpressionNode::~CalcExpressionNode): (WebCore): (CalculationValue): (WebCore::CalculationValue::CalculationValue): (CalcExpressionNumber): (WebCore::CalcExpressionNumber::CalcExpressionNumber): (WebCore::CalcExpressionNumber::evaluate): (CalcExpressionLength): (WebCore::CalcExpressionLength::CalcExpressionLength): (WebCore::CalcExpressionLength::evaluate): (CalcExpressionBinaryOperation): (WebCore::CalcExpressionBinaryOperation::CalcExpressionBinaryOperation): * platform/Length.cpp: (WebCore): (WebCore::Length::~Length): (CalculationValueHandleMap): (WebCore::CalculationValueHandleMap::CalculationValueHandleMap): (WebCore::CalculationValueHandleMap::insert): (WebCore::CalculationValueHandleMap::remove): (WebCore::CalculationValueHandleMap::get): (WebCore::calcHandles): (WebCore::Length::Length): (WebCore::Length::calculationValue): (WebCore::Length::calculatedValue): (WebCore::Length::calculatedMinValue): (WebCore::Length::calculatedFloatValue): (WebCore::Length::incrementCalculatedRef): (WebCore::Length::decrementCalculatedRef): (WebCore::Length::nonNanCalculatedValue): * platform/Length.h: (Length): (WebCore::Length::Length): (WebCore::Length::operator=): (WebCore::Length::operator*=): (WebCore::Length::value): (WebCore::Length::setValue): (WebCore::Length::calcValue): (WebCore::Length::calcMinValue): (WebCore::Length::calcFloatValue): (WebCore::Length::isZero): (WebCore::Length::isPositive): (WebCore::Length::isNegative): (WebCore::Length::isPercent): (WebCore::Length::isSpecified): (WebCore::Length::isCalculated): (WebCore::Length::initFromLength): (WebCore::Length::calculationHandle): LayoutTests: * css3/calc/margin-expected.txt: * css3/calc/padding-expected.txt: * css3/calc/simple-calcs-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/css3/calc/margin-expected.txt trunk/LayoutTests/css3/calc/padding-expected.txt trunk/LayoutTests/css3/calc/simple-calcs-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/WebCore.exp.in trunk/Source/WebCore/css/CSSCalculationValue.cpp trunk/Source/WebCore/css/CSSCalculationValue.h trunk/Source/WebCore/css/CSSPrimitiveValue.cpp trunk/Source/WebCore/css/CSSStyleApplyProperty.cpp trunk/Source/WebCore/css/CSSStyleSelector.cpp trunk/Source/WebCore/css/CSSStyleSelector.h trunk/Source/WebCore/platform/CalculationValue.cpp trunk/Source/WebCore/platform/CalculationValue.h trunk/Source/WebCore/platform/Length.cpp trunk/Source/WebCore/platform/Length.h Diff Modified: trunk/LayoutTests/ChangeLog (110147 => 110148) --- trunk/LayoutTests/ChangeLog 2012-03-08 06:15:01 UTC (rev 110147) +++ trunk/LayoutTests/ChangeLog 2012-03-08 06:48:35 UTC (rev 110148) @@ -1,3 +1,14 @@ +2012-03-07 Mike Lawther mikelawt...@chromium.org + +CSS3 calc: mixed absolute/percentages work for width, height, margin and padding +https://bugs.webkit.org/show_bug.cgi?id=79621 + +Reviewed by Andreas Kling. + +* css3/calc/margin-expected.txt: +* css3/calc/padding-expected.txt: +* css3/calc/simple-calcs-expected.txt: + 2012-03-07 Fumitoshi Ukai u...@chromium.org Unreviewed. update chromium test expectations. Modified: trunk/LayoutTests/css3/calc/margin-expected.txt (110147 =>
[webkit-changes] [110149] trunk/Source
Title: [110149] trunk/Source
Revision 110149
Author fisch...@chromium.org
Date 2012-03-07 22:55:36 -0800 (Wed, 07 Mar 2012)
Log Message
[Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
https://bugs.webkit.org/show_bug.cgi?id=80565
Reviewed by James Robinson.
This gets triggered by the video HW decode+render path when threaded compositor is enabled
(https://chromiumcodereview.appspot.com/9639005/)
No new tests.
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::context):
Modified Paths
trunk/Source/Platform/chromium/public/WebLayerTreeView.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h
Diff
Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (110148 => 110149)
--- trunk/Source/Platform/chromium/public/WebLayerTreeView.h 2012-03-08 06:48:35 UTC (rev 110148)
+++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h 2012-03-08 06:55:36 UTC (rev 110149)
@@ -155,14 +155,13 @@
// This can have a significant performance impact and should be used with care.
WEBKIT_EXPORT void finishAllRendering();
-
-// Debugging / dangerous -
-
// Returns the context being used for rendering this view. In threaded compositing mode, it is
-// not safe to use this context at all on the main thread.
-// FIXME: Remove this API as soon as possible, it's very bug-prone in threaded mode.
+// not safe to use this context for anything on the main thread, other than passing the pointer to
+// the compositor thread.
WEBKIT_EXPORT WebGraphicsContext3D* context();
+// Debugging / dangerous -
+
// Simulates a lost context. For testing only.
WEBKIT_EXPORT void loseCompositorContext(int numTimes);
Modified: trunk/Source/WebCore/ChangeLog (110148 => 110149)
--- trunk/Source/WebCore/ChangeLog 2012-03-08 06:48:35 UTC (rev 110148)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 06:55:36 UTC (rev 110149)
@@ -1,3 +1,18 @@
+2012-03-07 Ami Fischman fisch...@chromium.org
+
+[Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
+https://bugs.webkit.org/show_bug.cgi?id=80565
+
+Reviewed by James Robinson.
+
+This gets triggered by the video HW decode+render path when threaded compositor is enabled
+(https://chromiumcodereview.appspot.com/9639005/)
+
+No new tests.
+
+* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
+(WebCore::CCLayerTreeHost::context):
+
2012-03-07 Mike Lawther mikelawt...@chromium.org
CSS3 calc: mixed absolute/percentages work for width, height, margin and padding
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp (110148 => 110149)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-03-08 06:48:35 UTC (rev 110148)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp 2012-03-08 06:55:36 UTC (rev 110149)
@@ -249,7 +249,6 @@
// Temporary hack until WebViewImpl context creation gets simplified
GraphicsContext3D* CCLayerTreeHost::context()
{
-ASSERT(!CCProxy::hasImplThread());
return m_proxy-context();
}
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h (110148 => 110149)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2012-03-08 06:48:35 UTC (rev 110148)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h 2012-03-08 06:55:36 UTC (rev 110149)
@@ -153,6 +153,8 @@
// Only used when compositing on the main thread.
void composite();
+// NOTE: The returned value can only be used to make GL calls or make the
+// context current on the thread the compositor is running on!
GraphicsContext3D* context();
// Composites and attempts to read back the result into the provided
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
[webkit-changes] [110150] trunk/Source/WebCore
Title: [110150] trunk/Source/WebCore
Revision 110150
Author aba...@webkit.org
Date 2012-03-07 23:34:44 -0800 (Wed, 07 Mar 2012)
Log Message
ContainerNode::insertedIntoDocument and removedFromDocument use weak iteration patterns
https://bugs.webkit.org/show_bug.cgi?id=80569
Reviewed by Ryosuke Niwa.
This patch moves ContainerNode::insertedIntoDocument and
removedFromDocument to using a better iteration pattern in which we
collect all the nodes we're planning to iterate into a vector and then
iterate over them.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertedIntoDocument):
(WebCore::ContainerNode::removedFromDocument):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/ContainerNode.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (110149 => 110150)
--- trunk/Source/WebCore/ChangeLog 2012-03-08 06:55:36 UTC (rev 110149)
+++ trunk/Source/WebCore/ChangeLog 2012-03-08 07:34:44 UTC (rev 110150)
@@ -1,3 +1,19 @@
+2012-03-07 Adam Barth aba...@webkit.org
+
+ContainerNode::insertedIntoDocument and removedFromDocument use weak iteration patterns
+https://bugs.webkit.org/show_bug.cgi?id=80569
+
+Reviewed by Ryosuke Niwa.
+
+This patch moves ContainerNode::insertedIntoDocument and
+removedFromDocument to using a better iteration pattern in which we
+collect all the nodes we're planning to iterate into a vector and then
+iterate over them.
+
+* dom/ContainerNode.cpp:
+(WebCore::ContainerNode::insertedIntoDocument):
+(WebCore::ContainerNode::removedFromDocument):
+
2012-03-07 Ami Fischman fisch...@chromium.org
[Chromium] Allow CCLayerTreeHost::context() to be called even with the threaded compositor enabled.
Modified: trunk/Source/WebCore/dom/ContainerNode.cpp (110149 => 110150)
--- trunk/Source/WebCore/dom/ContainerNode.cpp 2012-03-08 06:55:36 UTC (rev 110149)
+++ trunk/Source/WebCore/dom/ContainerNode.cpp 2012-03-08 07:34:44 UTC (rev 110150)
@@ -785,13 +785,17 @@
Node::insertedIntoDocument();
insertedIntoTree(false);
-for (RefPtrNode child = m_firstChild; child; child = child-nextSibling()) {
-// Guard against mutation during re-parenting.
-if (!inDocument()) // Check for self being removed from document while reparenting.
+NodeVector children;
+collectNodes(this, children);
+for (size_t i = 0; i children.size(); ++i) {
+// If we have been removed from the document during this loop, then
+// we don't want to tell the rest of our children that they've been
+// inserted into the document because they haven't.
+if (!inDocument())
break;
-if (child-parentNode() != this) // Check for child being removed from subtree while reparenting.
-break;
-child-insertedIntoDocument();
+if (children[i]-parentNode() != this)
+continue;
+children[i]-insertedIntoDocument();
}
}
@@ -802,8 +806,19 @@
document()-setCSSTarget(0);
clearInDocument();
removedFromTree(false);
-for (Node* child = m_firstChild; child; child = child-nextSibling())
-child-removedFromDocument();
+
+NodeVector children;
+collectNodes(this, children);
+for (size_t i = 0; i children.size(); ++i) {
+// If we have been added to the document during this loop, then we
+// don't want to tell the rest of our children that they've been
+// removed from the document because they haven't.
+if (inDocument())
+break;
+if (children[i]-parentNode() != this)
+continue;
+children[i]-removedFromDocument();
+}
}
void ContainerNode::insertedIntoTree(bool deep)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
