date:20141210

[webkit-changes] [177135] trunk

2014-12-10 Thread cdumez

Title: [177135] trunk








Revision 177135
Author cdu...@apple.com
Date 2014-12-10 23:41:13 -0800 (Wed, 10 Dec 2014)


Log Message
http://omfgdogs.info/ only animates when you resize the window
https://bugs.webkit.org/show_bug.cgi?id=139435


Reviewed by Simon Fraser.

Source/WebCore:

After r163928, we would fail to animate a gif if:
- it is used as a background image of a 0-height html element
- it is used as a background image of a 0-height body element whose
  background is delegated to the root (because the root has no
  background).

This is because in such cases, shouldRepaintForImageAnimation()
should use the background rect instead of the renderer's overflow
rect to determine if the image is inside the viewport. Both cases
are addressed in this patch.

Tests: fast/images/animated-gif-body-delegated-background-image.html
   fast/images/animated-gif-body-outside-viewport.html
   fast/images/animated-gif-html-background-image.html

* rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):
* testing/Internals.cpp:
(WebCore::Internals::hasPausedImageAnimations):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

Add layout tests to make sure a gif image is still animated if:
- It is used as a background image of a 0-height html element
- It is used as a background image of a 0-height body element that
  is delegated to the root (because the root has no background)

Also add a layout test to make sure we still stop the gif animation
if it is used as background image of a body that is outside the
viewport.

* fast/images/animated-gif-body-delegated-background-image-expected.txt: Added.
* fast/images/animated-gif-body-delegated-background-image.html: Added.
* fast/images/animated-gif-body-outside-viewport-expected.txt: Added.
* fast/images/animated-gif-body-outside-viewport.html: Added.
* fast/images/animated-gif-html-background-image-expected.txt: Added.
* fast/images/animated-gif-html-background-image.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl


Added Paths

trunk/LayoutTests/fast/images/animated-gif-body-delegated-background-image-expected.txt
trunk/LayoutTests/fast/images/animated-gif-body-delegated-background-image.html
trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport-expected.txt
trunk/LayoutTests/fast/images/animated-gif-body-outside-viewport.html
trunk/LayoutTests/fast/images/animated-gif-html-background-image-expected.txt
trunk/LayoutTests/fast/images/animated-gif-html-background-image.html




Diff

Modified: trunk/LayoutTests/ChangeLog (177134 => 177135)

--- trunk/LayoutTests/ChangeLog	2014-12-11 07:37:20 UTC (rev 177134)
+++ trunk/LayoutTests/ChangeLog	2014-12-11 07:41:13 UTC (rev 177135)
@@ -1,3 +1,27 @@
+2014-12-10  Chris Dumez  
+
+http://omfgdogs.info/ only animates when you resize the window
+https://bugs.webkit.org/show_bug.cgi?id=139435
+
+
+Reviewed by Simon Fraser.
+
+Add layout tests to make sure a gif image is still animated if:
+- It is used as a background image of a 0-height html element
+- It is used as a background image of a 0-height body element that
+  is delegated to the root (because the root has no background)
+
+Also add a layout test to make sure we still stop the gif animation
+if it is used as background image of a body that is outside the
+viewport.
+
+* fast/images/animated-gif-body-delegated-background-image-expected.txt: Added.
+* fast/images/animated-gif-body-delegated-background-image.html: Added.
+* fast/images/animated-gif-body-outside-viewport-expected.txt: Added.
+* fast/images/animated-gif-body-outside-viewport.html: Added.
+* fast/images/animated-gif-html-background-image-expected.txt: Added.
+* fast/images/animated-gif-html-background-image.html: Added.
+
 2014-12-10  Zalan Bujtas  
 
 Continuously repainting large parts of Huffington Post.


Added: trunk/LayoutTests/fast/images/animated-gif-body-delegated-background-image-expected.txt (0 => 177135)

--- trunk/LayoutTests/fast/images/animated-gif-body-delegated-background-image-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/images/animated-gif-body-delegated-background-image-expected.txt	2014-12-11 07:41:13 UTC (rev 177135)
@@ -0,0 +1,11 @@
+Make sure the background image of the body element is animated if the body has 0 height and the background is delegated to the root
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS bodyHeight is "0px"
+PASS isBackgroundAnimated is true
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/images/animated-gif-body-delegated-background-image.html (0 => 177

[webkit-changes] [177134] trunk/Source/WebCore

2014-12-10 Thread timothy_horton

Title: [177134] trunk/Source/WebCore








Revision 177134
Author timothy_hor...@apple.com
Date 2014-12-10 23:37:20 -0800 (Wed, 10 Dec 2014)


Log Message
Fix the build.

* html/canvas/WebGLDrawBuffers.cpp:
Yosemite is 101000, not 10100.
Also, __MAC_OS_X_VERSION_MIN_REQUIRED is only defined for PLATFORM(MAC).

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177133 => 177134)

--- trunk/Source/WebCore/ChangeLog	2014-12-11 07:22:57 UTC (rev 177133)
+++ trunk/Source/WebCore/ChangeLog	2014-12-11 07:37:20 UTC (rev 177134)
@@ -1,3 +1,11 @@
+2014-12-10  Timothy Horton  
+
+Fix the build.
+
+* html/canvas/WebGLDrawBuffers.cpp:
+Yosemite is 101000, not 10100.
+Also, __MAC_OS_X_VERSION_MIN_REQUIRED is only defined for PLATFORM(MAC).
+
 2014-12-10  Zalan Bujtas  
 
 Continuously repainting large parts of Huffington Post.


Modified: trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp (177133 => 177134)

--- trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp	2014-12-11 07:22:57 UTC (rev 177133)
+++ trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp	2014-12-11 07:37:20 UTC (rev 177134)
@@ -46,7 +46,7 @@
 return WebGLExtension::WebGLDrawBuffersName;
 }
 
-#if OS(DARWIN) && __MAC_OS_X_VERSION_MIN_REQUIRED < 10100
+#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 101000)
 
 bool WebGLDrawBuffers::supported(WebGLRenderingContext*)
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177133] trunk/Tools

2014-12-10 Thread lforschler

Title: [177133] trunk/Tools








Revision 177133
Author lforsch...@apple.com
Date 2014-12-10 23:22:57 -0800 (Wed, 10 Dec 2014)


Log Message
Update Apple owned build slaves.

Rubber-stamped by Dana Burkart.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (177132 => 177133)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2014-12-11 06:32:58 UTC (rev 177132)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2014-12-11 07:22:57 UTC (rev 177133)
@@ -5,33 +5,33 @@
 { "name": "apple-mac-122",  "platform": "mac-mountainlion" },
 { "name": "apple-mac-123",  "platform": "mac-mountainlion" },
 { "name": "apple-mac-127",  "platform": "mac-mountainlion" },
-{ "name": "apple-mini-201", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-202", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-203", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-204", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-205", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-206", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-207", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-208", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-209", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-210", "platform": "mac-mountainlion" },
-{ "name": "apple-mini-218", "platform": "mac-mountainlion" },
+{ "name": "bot139", "platform": "mac-mountainlion" },
+{ "name": "bot141", "platform": "mac-mountainlion" },
+{ "name": "bot142", "platform": "mac-mountainlion" },
+{ "name": "bot145", "platform": "mac-mountainlion" },
+{ "name": "bot148", "platform": "mac-mountainlion" },
+{ "name": "bot150", "platform": "mac-mountainlion" },
+{ "name": "bot155", "platform": "mac-mountainlion" },
+{ "name": "bot156", "platform": "mac-mountainlion" },
+{ "name": "bot157", "platform": "mac-mountainlion" },
+{ "name": "bot158", "platform": "mac-mountainlion" },
+{ "name": "bot159", "platform": "mac-mountainlion" },
 
 { "name": "apple-mac-114",  "platform": "mac-mavericks" },
 { "name": "apple-mac-124",  "platform": "mac-mavericks" },
 { "name": "apple-mac-125",  "platform": "mac-mavericks" },
 { "name": "apple-mac-126",  "platform": "mac-mavericks" },
-{ "name": "apple-mini-129", "platform": "mac-mavericks" },
-{ "name": "apple-mini-130", "platform": "mac-mavericks" },
-{ "name": "apple-mini-137", "platform": "mac-mavericks" },
+{ "name": "bot101", "platform": "mac-mavericks" },
+{ "name": "bot102", "platform": "mac-mavericks" },
 { "name": "bot104", "platform": "mac-mavericks" },
-{ "name": "bot102", "platform": "mac-mavericks" },
-{ "name": "bot101", "platform": "mac-mavericks" },
-{ "name": "apple-mini-179", "platform": "mac-mavericks" },
-{ "name": "apple-mini-180", "platform": "mac-mavericks" },
-{ "name": "apple-mini-211", "platform": "mac-mavericks" },
-{ "name": "apple-mini-212", "platform": "mac-mavericks" },
-{ "name": "apple-mini-213", "platform": "mac-mavericks" },
+{ "name": "bot105", "platform": "mac-mavericks" },
+{ "name": "bot108", "platform": "mac-mavericks" },
+{ "name": "bot135", "platform": "mac-mavericks" },
+{ "name": "bot136", "platform": "mac-mavericks" },
+{ "name": "bot143", "platform": "mac-mavericks" },
+{ "name": "bot144", "platform": "mac-mavericks" },
+{ "name": "bot151", "platform": "mac-mavericks" },
+{ "name": "bot152", "platform": "mac-mavericks" },
 
 { "name": "apple-bot-133", "platform": "mac-yosemite" },
 { "name": "apple-bot-134", "platform": "mac-yosemite" },
@@ -73,60 +73,60 @@
 
 "builders":   [ { "name": "Apple MountainLion (Leaks)", "type": "TestLeaks", "builddir": "mountainlion-leaks",
   "platform": "mac-mountainlion", "configuration":

[webkit-changes] [177132] trunk/Source/WebKit/mac

2014-12-10 Thread timothy_horton

Title: [177132] trunk/Source/WebKit/mac








Revision 177132
Author timothy_hor...@apple.com
Date 2014-12-10 22:32:58 -0800 (Wed, 10 Dec 2014)


Log Message
Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=139529


Reviewed by Beth Dakin.

* WebView/WebActionMenuController.mm:
(-[WebActionMenuController _copySelection:]):
(-[WebActionMenuController _paste:]):
Use the copy: and paste: methods on WebView so that we traverse subviews
when trying to respond, otherwise these actions don't work in subframes.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (177131 => 177132)

--- trunk/Source/WebKit/mac/ChangeLog	2014-12-11 06:24:01 UTC (rev 177131)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-12-11 06:32:58 UTC (rev 177132)
@@ -1,3 +1,17 @@
+2014-12-10  Timothy Horton  
+
+Copy and paste action menu items don't work on the Mozilla Midas demo in WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=139529
+
+
+Reviewed by Beth Dakin.
+
+* WebView/WebActionMenuController.mm:
+(-[WebActionMenuController _copySelection:]):
+(-[WebActionMenuController _paste:]):
+Use the copy: and paste: methods on WebView so that we traverse subviews
+when trying to respond, otherwise these actions don't work in subframes.
+
 2014-12-10  Beth Dakin  
 
 WK1: Add initial support for immediate actions


Modified: trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm (177131 => 177132)

--- trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm	2014-12-11 06:24:01 UTC (rev 177131)
+++ trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm	2014-12-11 06:32:58 UTC (rev 177132)
@@ -589,7 +589,7 @@
 
 - (void)_copySelection:(id)sender
 {
-[_webView _executeCoreCommandByName:@"copy" value:nil];
+[_webView copy:self];
 }
 
 - (void)_lookupText:(id)sender
@@ -604,7 +604,7 @@
 
 - (void)_paste:(id)sender
 {
-[_webView _executeCoreCommandByName:@"paste" value:nil];
+[_webView paste:self];
 }
 
 - (void)_selectLookupText






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177131] trunk/Source/WebKit

2014-12-10 Thread bdakin

Title: [177131] trunk/Source/WebKit








Revision 177131
Author bda...@apple.com
Date 2014-12-10 22:24:01 -0800 (Wed, 10 Dec 2014)


Log Message
WK1: Add initial support for immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139522

Reviewed by Dan Bernstein.

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

This basic implementation of the controller will use the delegate methods to 
perform and cache a HitTest when relevant. Future patches will patch 
_updateImmediateActionItem to use the HitTestResult to determine if there is any 
immediate action that should be taken.
* WebView/WebImmediateActionController.h: Added.
* WebView/WebImmediateActionController.mm: Added.
(-[WebImmediateActionController webViewClosed]):
(-[WebImmediateActionController _clearImmediateActionState]):
(-[WebImmediateActionController performHitTestAtPoint:]):
(-[WebImmediateActionController immediateActionRecognizerWillPrepare:]):
(-[WebImmediateActionController immediateActionRecognizerWillBeginAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCancelAnimation:]):
(-[WebImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):
(-[WebImmediateActionController _updateImmediateActionItem]):

New enum for immediate action types.
* WebView/WebUIDelegatePrivate.h:

Create an NSImmediateActionGestureRecognizer if possible and a controller.
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView _close]):
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebUIDelegatePrivate.h
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/mac/WebView/WebViewData.h
trunk/Source/WebKit/mac/WebView/WebViewData.mm


Added Paths

trunk/Source/WebKit/mac/WebView/WebImmediateActionController.h
trunk/Source/WebKit/mac/WebView/WebImmediateActionController.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (177130 => 177131)

--- trunk/Source/WebKit/ChangeLog	2014-12-11 05:31:04 UTC (rev 177130)
+++ trunk/Source/WebKit/ChangeLog	2014-12-11 06:24:01 UTC (rev 177131)
@@ -1,3 +1,12 @@
+2014-12-10  Beth Dakin  
+
+WK1: Add initial support for immediate actions
+https://bugs.webkit.org/show_bug.cgi?id=139522
+
+Reviewed by Dan Bernstein.
+
+* WebKit.xcodeproj/project.pbxproj:
+
 2014-12-10  Anders Carlsson  
 
 Add session storage handling to StorageNamespaceProvider


Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (177130 => 177131)

--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-12-11 05:31:04 UTC (rev 177130)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj	2014-12-11 06:24:01 UTC (rev 177131)
@@ -161,6 +161,8 @@
 		9304B3000B02341500F7850D /* WebIconDatabaseInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 9304B2FF0B02341500F7850D /* WebIconDatabaseInternal.h */; };
 		931633EB0AEDFF930062B92D /* WebFrameLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = 931633EA0AEDFF930062B92D /* WebFrameLoaderClient.h */; };
 		931633EF0AEDFFAE0062B92D /* WebFrameLoaderClient.mm in Sources */ = {isa = PBXBuildFile; fileRef = 931633EE0AEDFFAE0062B92D /* WebFrameLoaderClient.mm */; };
+		9321D5921A391DC3008052BE /* WebImmediateActionController.h in Headers */ = {isa = PBXBuildFile; fileRef = 9321D5911A391DB8008052BE /* WebImmediateActionController.h */; };
+		9321D5941A391DF9008052BE /* WebImmediateActionController.mm in Sources */ = {isa = PBXBuildFile; fileRef = 9321D5931A391DF9008052BE /* WebImmediateActionController.mm */; };
 		934C11670D8710BB00C32ABD /* WebDynamicScrollBarsViewInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 934C11660D8710BB00C32ABD /* WebDynamicScrollBarsViewInternal.h */; };
 		934C4A910F01406C009372C0 /* WebNSObjectExtras.mm in Sources */ = {isa = PBXBuildFile; fileRef = 934C4A900F01406C009372C0 /* WebNSObjectExtras.mm */; };
 		934C4AA00F0141F7009372C0 /* WebResourceInternal.h in Headers */ = {isa = PBXBuildFile; fileRef = 934C4A9F0F0141F7009372C0 /* WebResourceInternal.h */; };
@@ -692,6 +694,8 @@
 		931633EA0AEDFF930062B92D /* WebFrameLoaderClient.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebFrameLoaderClient.h; sourceTree = ""; };
 		931633EE0AEDFFAE0062B92D /* WebFrameLoaderClient.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WebFrameLoaderClient.mm; sourceTree = ""; };
 		93185DB506679F42005D5E7E /* WebHTMLViewInternal.h */ = {isa = PBXFileReference; fileEncoding = 4; indentWidth = 4; lastKnownFileType = sourcecode.c.h; path = WebHTMLViewInternal.h; sourceTree = ""; tabWidth = 8; usesTabs = 0; };
+		9321D5911A391DB8008052BE /* WebImmediateActionController.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c

[webkit-changes] [177129] trunk/Tools

2014-12-10 Thread dbates

Title: [177129] trunk/Tools








Revision 177129
Author dba...@webkit.org
Date 2014-12-10 19:54:28 -0800 (Wed, 10 Dec 2014)


Log Message
[iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
timeout instead of test failure
https://bugs.webkit.org/show_bug.cgi?id=139525

Reviewed by Zalan Bujtas.

Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
output.

Following , DumpRenderTree.app waits
for the WebThread to spin its run loop before dumping its output. A test that
calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
because run-webkit-tests may terminate a DumpRenderTree.app process when it
exceeds its process time limit (defaults to 35ms) regardless of whether such
a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.

* Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_timeout_ms):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/ios.py




Diff

Modified: trunk/Tools/ChangeLog (177128 => 177129)

--- trunk/Tools/ChangeLog	2014-12-11 03:29:29 UTC (rev 177128)
+++ trunk/Tools/ChangeLog	2014-12-11 03:54:28 UTC (rev 177129)
@@ -1,3 +1,27 @@
+2014-12-10  Daniel Bates  
+
+[iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
+timeout instead of test failure
+https://bugs.webkit.org/show_bug.cgi?id=139525
+
+Reviewed by Zalan Bujtas.
+
+Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
+run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
+output.
+
+Following , DumpRenderTree.app waits
+for the WebThread to spin its run loop before dumping its output. A test that
+calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
+before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
+by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
+because run-webkit-tests may terminate a DumpRenderTree.app process when it
+exceeds its process time limit (defaults to 35ms) regardless of whether such
+a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
+
+* Scripts/webkitpy/port/ios.py:
+(IOSSimulatorPort.default_timeout_ms):
+
 2014-12-09  Gustavo Noronha Silva  
 
 [GTK][WK2] Add HTML5 Notifications support


Modified: trunk/Tools/Scripts/webkitpy/port/ios.py (177128 => 177129)

--- trunk/Tools/Scripts/webkitpy/port/ios.py	2014-12-11 03:29:29 UTC (rev 177128)
+++ trunk/Tools/Scripts/webkitpy/port/ios.py	2014-12-11 03:54:28 UTC (rev 177129)
@@ -82,6 +82,11 @@
 def default_timeout_ms(self):
 if self.get_option('guard_malloc'):
 return 350 * 1000
+if not self.get_option('webkit_test_runner'):
+# DumpRenderTree.app waits for the WebThread to run before dumping its output.  In practice
+# it seems sufficient to wait up to 80ms to ensure that the WebThread ran and hence output
+# for the test is dumped.
+return 80 * 1000
 return super(IOSSimulatorPort, self).default_timeout_ms()
 
 def supports_per_test_timeout(self):






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177128] trunk

2014-12-10 Thread zalan

Title: [177128] trunk








Revision 177128
Author za...@apple.com
Date 2014-12-10 19:29:29 -0800 (Wed, 10 Dec 2014)


Log Message
Continuously repainting large parts of Huffington Post.
https://bugs.webkit.org/show_bug.cgi?id=139468

Reviewed by Antti Koivisto.

This patch eliminates redundant repaint requests for inlines when neither the parent
block flow nor any of the inline children are dirty.
Previously,
1. simple line layout always recalculated inline content positions regardless of whether
the content needed relayout at all; as a result, it always triggered full repaint.
2. inline tree layout ignored the needslayout flag on the last line and treated it dirty
(unless it broke cleanly (foo)).
This was an ancient workaround for an editing/insert use case, but it seems not to be the case anymore.

Source/WebCore:

Tests: fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html
   fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html

* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutInlineChildren):
(WebCore::RenderBlockFlow::layoutSimpleLines): Check if we need to trigger layout at all.
* rendering/RenderBlockFlow.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::determineStartPosition): Remove the last line dirty hack. If it
happens to introduce regression, we should fix it at the caller site to make the line dirty.

LayoutTests:

* fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt: Added.
* fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html: Added.
* fast/repaint/implicitly-positioned-block-repaint-simple-line-layout-expected.txt: Added.
* fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html: Added.
* platform/mac/fast/line-grid/line-align-right-edges-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/line-grid/line-align-right-edges-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockFlow.cpp
trunk/Source/WebCore/rendering/RenderBlockFlow.h
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt
trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html
trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-simple-line-layout-expected.txt
trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html




Diff

Modified: trunk/LayoutTests/ChangeLog (177127 => 177128)

--- trunk/LayoutTests/ChangeLog	2014-12-11 03:04:58 UTC (rev 177127)
+++ trunk/LayoutTests/ChangeLog	2014-12-11 03:29:29 UTC (rev 177128)
@@ -1,3 +1,25 @@
+2014-12-10  Zalan Bujtas  
+
+Continuously repainting large parts of Huffington Post.
+https://bugs.webkit.org/show_bug.cgi?id=139468
+
+Reviewed by Antti Koivisto.
+
+This patch eliminates redundant repaint requests for inlines when neither the parent
+block flow nor any of the inline children are dirty.
+Previously,
+1. simple line layout always recalculated inline content positions regardless of whether
+the content needed relayout at all; as a result, it always triggered full repaint.
+2. inline tree layout ignored the needslayout flag on the last line and treated it dirty
+(unless it broke cleanly (foo)).
+This was an ancient workaround for an editing/insert use case, but it seems not to be the case anymore.
+
+* fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt: Added.
+* fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html: Added.
+* fast/repaint/implicitly-positioned-block-repaint-simple-line-layout-expected.txt: Added.
+* fast/repaint/implicitly-positioned-block-repaint-simple-line-layout.html: Added.
+* platform/mac/fast/line-grid/line-align-right-edges-expected.txt:
+
 2014-12-10  Alexey Proskuryakov  
 
 Remove expectations that were incorrectly landed in http://trac.webkit.org/changeset/176778


Added: trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt (0 => 177128)

--- trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-complex-line-layout-expected.txt	2014-12-11 03:29:29 UTC (rev 177128)
@@ -0,0 +1,7 @@
+PASS window.internals.repaintRectsAsText().indexOf('8 541 180 18') is -1
+PASS successfullyParsed is true
+
+TEST COMPLETE
+this is scrolling and should be repainted.
+this should not be repainting
+


Added: trunk/LayoutTests/fast/repaint/implicitly-positioned-block-repaint-complex-line-layout.html (0 => 177128)

--- trunk/LayoutTests/fast/repaint/implicitly-positioned-bloc

[webkit-changes] [177127] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json

2014-12-10 Thread lforschler

Title: [177127] trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json








Revision 177127
Author lforsch...@apple.com
Date 2014-12-10 19:04:58 -0800 (Wed, 10 Dec 2014)


Log Message
Update Apple bot list.

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (177126 => 177127)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2014-12-11 02:35:06 UTC (rev 177126)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2014-12-11 03:04:58 UTC (rev 177127)
@@ -24,9 +24,9 @@
 { "name": "apple-mini-129", "platform": "mac-mavericks" },
 { "name": "apple-mini-130", "platform": "mac-mavericks" },
 { "name": "apple-mini-137", "platform": "mac-mavericks" },
-{ "name": "apple-mini-138", "platform": "mac-mavericks" },
-{ "name": "apple-mini-142", "platform": "mac-mavericks" },
-{ "name": "apple-mini-178", "platform": "mac-mavericks" },
+{ "name": "bot104", "platform": "mac-mavericks" },
+{ "name": "bot102", "platform": "mac-mavericks" },
+{ "name": "bot101", "platform": "mac-mavericks" },
 { "name": "apple-mini-179", "platform": "mac-mavericks" },
 { "name": "apple-mini-180", "platform": "mac-mavericks" },
 { "name": "apple-mini-211", "platform": "mac-mavericks" },
@@ -114,15 +114,15 @@
 { "name": "Apple Mavericks Debug (Build)", "type": "Build", "builddir": "mavericks-debug",
   "platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
   "triggers": ["mavericks-debug-tests-wk1", "mavericks-debug-tests-wk2"],
-  "slavenames": ["apple-mini-178", "apple-mini-179"]
+  "slavenames": ["bot101", "apple-mini-179"]
 },
 { "name": "Apple Mavericks Debug WK1 (Tests)", "type": "Test", "builddir": "mavericks-debug-tests-wk1",
   "platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
-  "slavenames": ["apple-mini-137", "apple-mini-138"]
+  "slavenames": ["apple-mini-137", "bot104"]
 },
 { "name": "Apple Mavericks Debug WK2 (Tests)", "type": "TestWebKit2", "builddir": "mavericks-debug-tests-wk2",
   "platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],
-  "slavenames": ["apple-mini-142", "apple-mini-211"]
+  "slavenames": ["bot142", "apple-mini-211"]
 },
 { "name": "Apple Mavericks LLINT CLoop (BuildAndTest)", "type": "BuildAndTestLLINTCLoop", "builddir": "mavericks-cloop-debug",
   "platform": "mac-mavericks", "configuration": "debug", "architectures": ["x86_64"],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177126] trunk/Source/WebCore

2014-12-10 Thread andersca

Title: [177126] trunk/Source/WebCore








Revision 177126
Author ander...@apple.com
Date 2014-12-10 18:35:06 -0800 (Wed, 10 Dec 2014)


Log Message
Add an empty storage namespace provider
https://bugs.webkit.org/show_bug.cgi?id=139520

Reviewed by Tim Horton.

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/EmptyClients.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177125 => 177126)

--- trunk/Source/WebCore/ChangeLog	2014-12-11 02:33:57 UTC (rev 177125)
+++ trunk/Source/WebCore/ChangeLog	2014-12-11 02:35:06 UTC (rev 177126)
@@ -1,3 +1,13 @@
+2014-12-10  Anders Carlsson  
+
+Add an empty storage namespace provider
+https://bugs.webkit.org/show_bug.cgi?id=139520
+
+Reviewed by Tim Horton.
+
+* loader/EmptyClients.cpp:
+(WebCore::fillWithEmptyClients):
+
 2014-12-10  Beth Dakin  
 
 Speculative build fix.


Modified: trunk/Source/WebCore/loader/EmptyClients.cpp (177125 => 177126)

--- trunk/Source/WebCore/loader/EmptyClients.cpp	2014-12-11 02:33:57 UTC (rev 177125)
+++ trunk/Source/WebCore/loader/EmptyClients.cpp	2014-12-11 02:35:06 UTC (rev 177126)
@@ -36,6 +36,9 @@
 #include "FrameNetworkingContext.h"
 #include "HTMLFormElement.h"
 #include "PageConfiguration.h"
+#include "StorageArea.h"
+#include "StorageNamespace.h"
+#include "StorageNamespaceProvider.h"
 #include 
 
 #if ENABLE(INPUT_TYPE_COLOR)
@@ -44,6 +47,46 @@
 
 namespace WebCore {
 
+class EmptyStorageNamespaceProvider final : public StorageNamespaceProvider {
+struct EmptyStorageArea : public StorageArea {
+virtual unsigned length() override { return 0; }
+virtual String key(unsigned) override { return String(); }
+virtual String item(const String&) override { return String(); }
+virtual void setItem(Frame*, const String&, const String&, bool&) override { }
+virtual void removeItem(Frame*, const String&) override { }
+virtual void clear(Frame*) override { }
+virtual bool contains(const String&) override { return false; }
+virtual bool canAccessStorage(Frame*) override { return false; }
+virtual StorageType storageType() const override { return LocalStorage; }
+virtual size_t memoryBytesUsedByCache() override { return 0; }
+};
+
+struct EmptyStorageNamespace final : public StorageNamespace {
+virtual PassRefPtr storageArea(PassRefPtr) override { return adoptRef(new EmptyStorageArea); }
+virtual PassRefPtr copy(Page*) override { return adoptRef(new EmptyStorageNamespace); }
+virtual void close() override { }
+virtual void clearOriginForDeletion(SecurityOrigin*) override { }
+virtual void clearAllOriginsForDeletion() override { }
+virtual void sync() override { }
+virtual void closeIdleLocalStorageDatabases() override { }
+};
+
+virtual RefPtr createSessionStorageNamespace(Page&, unsigned) override
+{
+return adoptRef(new EmptyStorageNamespace);
+}
+
+virtual RefPtr createLocalStorageNamespace(unsigned) override
+{
+return adoptRef(new EmptyStorageNamespace);
+}
+
+virtual RefPtr createTransientLocalStorageNamespace(SecurityOrigin&, unsigned) override
+{
+return adoptRef(new EmptyStorageNamespace);
+}
+};
+
 class EmptyVisitedLinkStore : public VisitedLinkStore {
 virtual bool isLinkVisited(Page&, LinkHash, const URL&, const AtomicString&) override { return false; }
 virtual void addVisitedLink(Page&, LinkHash) override { }
@@ -79,6 +122,7 @@
 static NeverDestroyed dummyDiagnosticLoggingClient;
 pageConfiguration.diagnosticLoggingClient = &dummyDiagnosticLoggingClient.get();
 
+pageConfiguration.storageNamespaceProvider = adoptRef(new EmptyStorageNamespaceProvider);
 pageConfiguration.visitedLinkStore = adoptRef(new EmptyVisitedLinkStore);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177124] trunk/Source/WebCore

2014-12-10 Thread bdakin

Title: [177124] trunk/Source/WebCore








Revision 177124
Author bda...@apple.com
Date 2014-12-10 18:30:46 -0800 (Wed, 10 Dec 2014)


Log Message
Speculative build fix.

* platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (177123 => 177124)

--- trunk/Source/WebCore/ChangeLog	2014-12-11 02:11:08 UTC (rev 177123)
+++ trunk/Source/WebCore/ChangeLog	2014-12-11 02:30:46 UTC (rev 177124)
@@ -1,5 +1,11 @@
 2014-12-10  Beth Dakin  
 
+Speculative build fix.
+
+* platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
+
+2014-12-10  Beth Dakin  
+
 WK2: Add initial support for immediate actions
 https://bugs.webkit.org/show_bug.cgi?id=139511
 


Modified: trunk/Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h (177123 => 177124)

--- trunk/Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h	2014-12-11 02:11:08 UTC (rev 177123)
+++ trunk/Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h	2014-12-11 02:30:46 UTC (rev 177124)
@@ -23,6 +23,10 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
 
+#if  __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
+
+#import 
+
 #if __has_include()
 
 #import 
@@ -32,4 +36,6 @@
 @interface NSImmediateActionGestureRecognizer : NSGestureRecognizer
 @end
 
-#endif
+#endif // __has_include()
+
+#endif // __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177122] trunk/LayoutTests

2014-12-10 Thread ap

Title: [177122] trunk/LayoutTests








Revision 177122
Author a...@apple.com
Date 2014-12-10 17:59:00 -0800 (Wed, 10 Dec 2014)


Log Message
Remove expectations that were incorrectly landed in http://trac.webkit.org/changeset/176778

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (177121 => 177122)

--- trunk/LayoutTests/ChangeLog	2014-12-11 01:54:46 UTC (rev 177121)
+++ trunk/LayoutTests/ChangeLog	2014-12-11 01:59:00 UTC (rev 177122)
@@ -1,5 +1,11 @@
 2014-12-10  Alexey Proskuryakov  
 
+Remove expectations that were incorrectly landed in http://trac.webkit.org/changeset/176778
+
+* platform/mac/TestExpectations:
+
+2014-12-10  Alexey Proskuryakov  
+
 Fix a typo in the rpevious commit.
 
 * platform/mac-wk1/TestExpectations:


Modified: trunk/LayoutTests/platform/mac/TestExpectations (177121 => 177122)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-12-11 01:54:46 UTC (rev 177121)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-12-11 01:59:00 UTC (rev 177122)
@@ -485,6 +485,7 @@
 
 # Unexpected WebGL Conformance tests that need to be fixed
 # These tests pass when run through webgl-conformance-tests.html but not when just opened via a browser (or via run-webkit-tests)
+webgl/1.0.2/conformance/context/context-creation-and-destruction.html [ Failure Timeout ]
 webgl/1.0.2/conformance/rendering/multisample-corruption.html [ Pass Failure Timeout ]
 http/tests/webgl/1.0.2/origin-clean-conformance.html [ Skip ]
 
@@ -499,34 +500,6 @@
 [ MountainLion ] webgl/1.0.2/conformance/ogles/GL/operators/operators_009_to_016.html [ Pass Failure ]
 [ MountainLion ] webgl/1.0.2/conformance/textures/texture-size.html [ Failure ]
 
-# 
-webgl/1.0.2/conformance/attribs/gl-enable-vertex-attrib.html [ Skip ]
-webgl/1.0.2/conformance/attribs/gl-disabled-vertex-attrib.html [ Skip ]
-webgl/1.0.2/conformance/attribs/gl-vertexattribpointer.html [ Skip ]
-webgl/1.0.2/conformance/attribs/gl-vertex-attrib.html [ Skip ]
-webgl/1.0.2/conformance/attribs/gl-vertex-attrib-render.html [ Skip ]
-webgl/1.0.2/conformance/attribs/gl-vertex-attrib-zero-issues.html [ Skip ]
-webgl/1.0.2/conformance/attribs/gl-vertexattribpointer-offsets.html [ Skip ]
-webgl/1.0.2/conformance/canvas/buffer-offscreen-test.html [ Skip ]
-webgl/1.0.2/conformance/canvas/canvas-test.html [ Skip ]
-webgl/1.0.2/conformance/canvas/buffer-preserve-test.html [ Skip ]
-webgl/1.0.2/conformance/canvas/canvas-zero-size.html [ Skip ]
-webgl/1.0.2/conformance/canvas/drawingbuffer-hd-dpi-test.html [ Skip ]
-webgl/1.0.2/conformance/context/constants.html [ Skip ]
-webgl/1.0.2/conformance/context/context-creation-and-destruction.html [ Skip ]
-webgl/1.0.2/conformance/context/context-attributes-alpha-depth-stencil-antialias.html [ Skip ]
-webgl/1.0.2/conformance/context/context-attribute-preserve-drawing-buffer.html [ Skip ]
-webgl/1.0.2/conformance/context/context-lost-restored.html [ Skip ]
-webgl/1.0.2/conformance/buffers/index-validation-large-buffer.html [ Skip ]
-webgl/1.0.2/conformance/buffers/index-validation-with-resized-buffer.html [ Skip ]
-webgl/1.0.2/conformance/buffers/index-validation-crash-with-buffer-sub-data.html [ Skip ]
-webgl/1.0.2/conformance/buffers/buffer-data-array-buffer.html [ Skip ]
-webgl/1.0.2/conformance/buffers/index-validation-verifies-too-many-indices.html [ Skip ]
-webgl/1.0.2/conformance/buffers/element-array-buffer-delete-recreate.html [ Skip ]
-webgl/1.0.2/conformance/buffers/index-validation.html [ Skip ]
-webgl/1.0.2/conformance/buffers/index-validation-copies-indices.html [ Skip ]
-webgl/1.0.2/conformance/buffers/buffer-bind-test.html [ Skip ]
-
 # Skip 1.0.3 tests for now, to be unskipped when we get closer to conformance
 webgl/1.0.3
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177121] trunk/LayoutTests

2014-12-10 Thread ap

Title: [177121] trunk/LayoutTests








Revision 177121
Author a...@apple.com
Date 2014-12-10 17:54:46 -0800 (Wed, 10 Dec 2014)


Log Message
Fix a typo in the rpevious commit.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (177120 => 177121)

--- trunk/LayoutTests/ChangeLog	2014-12-11 01:51:38 UTC (rev 177120)
+++ trunk/LayoutTests/ChangeLog	2014-12-11 01:54:46 UTC (rev 177121)
@@ -1,5 +1,11 @@
 2014-12-10  Alexey Proskuryakov  
 
+Fix a typo in the rpevious commit.
+
+* platform/mac-wk1/TestExpectations:
+
+2014-12-10  Alexey Proskuryakov  
+
 Fix lint warnings on Mac TestExpectations.
 
 * platform/mac-wk1/TestExpectations:


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (177120 => 177121)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2014-12-11 01:51:38 UTC (rev 177120)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2014-12-11 01:54:46 UTC (rev 177121)
@@ -14,7 +14,7 @@
 webkit.org/b/118269 compositing/geometry/fixed-position-flipped-writing-mode.html
 
 # Before Yosemite, the test did not actually test compositing vs. non-compositing on WebKit1, so it passed accidentally.
-webkit.org/b/132421 [ Mavericks+ ] fast/multicol/fixed-stack.html [ ImageOnlyFailure ]
+webkit.org/b/132421 [ Yosemite+ ] fast/multicol/fixed-stack.html [ ImageOnlyFailure ]
 
 webkit.org/b/104104 fast/overflow/scrollbar-click-retains-focus.html [ Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177120] trunk/LayoutTests

2014-12-10 Thread ap

Title: [177120] trunk/LayoutTests








Revision 177120
Author a...@apple.com
Date 2014-12-10 17:51:38 -0800 (Wed, 10 Dec 2014)


Log Message
Fix lint warnings on Mac TestExpectations.

* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (177119 => 177120)

--- trunk/LayoutTests/ChangeLog	2014-12-11 01:31:52 UTC (rev 177119)
+++ trunk/LayoutTests/ChangeLog	2014-12-11 01:51:38 UTC (rev 177120)
@@ -1,5 +1,13 @@
 2014-12-10  Alexey Proskuryakov  
 
+Fix lint warnings on Mac TestExpectations.
+
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+* platform/mac/TestExpectations:
+
+2014-12-10  Alexey Proskuryakov  
+
 Mark more tests that fail on EWS bots with ATI graphics.
 
 * platform/mac/TestExpectations:


Modified: trunk/LayoutTests/platform/mac/TestExpectations (177119 => 177120)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-12-11 01:31:52 UTC (rev 177119)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-12-11 01:51:38 UTC (rev 177120)
@@ -485,8 +485,6 @@
 
 # Unexpected WebGL Conformance tests that need to be fixed
 # These tests pass when run through webgl-conformance-tests.html but not when just opened via a browser (or via run-webkit-tests)
-webgl/1.0.2/conformance/context/context-creation-and-destruction.html [ Failure Timeout ]
-webgl/1.0.2/conformance/ogles/GL/operators/operators_009_to_016.html [ Pass Failure ]
 webgl/1.0.2/conformance/rendering/multisample-corruption.html [ Pass Failure Timeout ]
 http/tests/webgl/1.0.2/origin-clean-conformance.html [ Skip ]
 
@@ -498,7 +496,7 @@
 [ MountainLion ] webgl/1.0.2/conformance/glsl/variables/gl-pointcoord.html [ Failure ]
 [ MountainLion ] webgl/1.0.2/conformance/limits/gl-max-texture-dimensions.html [ Failure ]
 [ MountainLion ] webgl/1.0.2/conformance/ogles/GL/control_flow/control_flow_009_to_010.html [ Crash Pass Failure ]
-[ MountainLion ] webgl/1.0.2/conformance/ogles/GL/operators/operators_009_to_016.html [ Failure ]
+[ MountainLion ] webgl/1.0.2/conformance/ogles/GL/operators/operators_009_to_016.html [ Pass Failure ]
 [ MountainLion ] webgl/1.0.2/conformance/textures/texture-size.html [ Failure ]
 
 # 
@@ -757,9 +755,7 @@
 # Resource Timing is not enable yet, skip it.
 webkit.org/b/61138 http/tests/w3c/webperf/submission/Intel/resource-timing [ Skip ]
 
-# Flacky on Mountain Lion Release, fails everywhere else.
-fast/css/sticky/sticky-top-zoomed.html [ ImageOnlyFailure ]
-webkit.org/b/107356 [ MountainLion Release ] fast/css/sticky/sticky-top-zoomed.html [ Pass ImageOnlyFailure ]
+webkit.org/b/107356 fast/css/sticky/sticky-top-zoomed.html [ ImageOnlyFailure ]
 
 # Overflowing LayoutUnits cause RenderGeometryMap assertions
 webkit.org/b/67434 [ Debug ] fast/overflow/overflow-height-float-not-removed-crash.html [ Skip ]
@@ -886,10 +882,8 @@
 
 webkit.org/b/123250 plugins/destroy-during-npp-new-object-with-fallback-content.html [ Pass Failure ]
 
-webkit.org/b/123369 svg/css/parent-shadow-offscreen.svg [ Pass ImageOnlyFailure ]
-webkit.org/b/123369 [ MountainLion ] svg/css/parent-shadow-offscreen.svg [ Pass ]
-webkit.org/b/123369 svg/css/root-shadow-offscreen.svg [ Pass ImageOnlyFailure ]
-webkit.org/b/123369 [ MountainLion ] svg/css/root-shadow-offscreen.svg [ Pass ]
+webkit.org/b/123369 [ Mavericks+ ] svg/css/parent-shadow-offscreen.svg [ Pass ImageOnlyFailure ]
+webkit.org/b/123369 [ Mavericks+ ] svg/css/root-shadow-offscreen.svg [ Pass ImageOnlyFailure ]
 
 # webkit.org/b/100846, webkit.org/b/136715
 inspector-protocol/debugger
@@ -1117,7 +,6 @@
 
 # Mountain Lion and earlier do not support Encrypted Media Extensions.
 Bug(jernoble) [ MountainLion ] media/encrypted-media/ [ WontFix ]
-Bug(jernoble) [ MountainLion ] fast/events/constructors/media-key-event-constructor.html [ WontFix ]
 ## --- End media tests failing on Mountain Lion and earlier ---
 
 ## --- Start media tests failing on Mavericks and earlier ---
@@ -1140,7 +1133,6 @@
 webkit.org/b/90725 media/media-blocked-by-beforeload.html [ Pass Failure ]
 webkit.org/b/112492 media/track/track-language-preference.html [ Pass Failure Timeout ]
 webkit.org/b/112492 media/track/track-prefer-captions.html [ Pass Failure Timeout ]
-webkit.org/b/112533 media/auto-play-in-sandbox-with-allow-scripts.html [ Pass Failure ]
 webkit.org/b/112659 media/video-playing-and-pause.html [ Pass Failure ]
 webkit.org/b/114744 media/video-layer-crash.html [ Pass Failure Timeout ]
 webkit.org/b/115048 media/media-element-play-after-eos.html [ Pass Failure ]
@@ -1167,7 +1159,8 @@
 webkit.org/b/133686 media/track/w3c/interfaces/TextTrackCue/pauseOnExit.html [ Pass Failure ]
 webkit.org/b/133686 media/track/w3c/interfaces/Te

[webkit-changes] [177119] trunk/Source/WebKit

2014-12-10 Thread andersca

Title: [177119] trunk/Source/WebKit








Revision 177119
Author ander...@apple.com
Date 2014-12-10 17:31:52 -0800 (Wed, 10 Dec 2014)


Log Message
Use the new storage namespace provider in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=139425

Reviewed by Tim Horton.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Set the storage namespace provider from the web page group.

Source/WebKit/win:

* WebView.cpp:
(localStorageDatabasePath):
Helper from getting the local storage database path given a WebPreferences instance.

(WebView::initWithFrame):
Create a storage namespace provider.

Modified Paths

trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj
trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp




Diff

Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj (177118 => 177119)

--- trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj	2014-12-11 01:18:14 UTC (rev 177118)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKit.vcxproj	2014-12-11 01:31:52 UTC (rev 177119)
@@ -419,6 +419,7 @@
 
   
   
+
 
 
 
@@ -498,7 +499,6 @@
 
 
 
-
 
 
 


Modified: trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props (177118 => 177119)

--- trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props	2014-12-11 01:18:14 UTC (rev 177118)
+++ trunk/Source/WebKit/WebKit.vcxproj/WebKit/WebKitCommon.props	2014-12-11 01:31:52 UTC (rev 177119)
@@ -5,7 +5,7 @@
   
   
 
-  $(ProjectDir);$(ProjectDir)\..\..\win;$(ProjectDir)\..\..\win\WebCoreSupport;$(ConfigurationBuildDir)\include\WebKit;$(ConfigurationBuildDir)\Include;$(ConfigurationBuildDir)\Include\private;$(ConfigurationBuildDir)\Include\WebCore;$(ConfigurationBuildDir)\Include\WebCore\ForwardingHeaders;$(ConfigurationBuildDir)\Include\_javascript_Core;$(ConfigurationBuildDir)\Include\private\_javascript_Core;$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\WebKit\DerivedSources;$(WebKit_Libraries)\Include;$(WebKit_Libraries)\Include\private;$(WebKit_Libraries)\Include\WebCore;$(WebKit_Libraries)\Include\WebCore\ForwardingHeaders;$(WebKit_Libraries)\Include\_javascript_Core;$(WebKit_Libraries)\Include\private\_javascript_Core;$(IntDir)include;%(AdditionalIncludeDirectories)
+  $(ProjectDir);$(ProjectDir)\..\..\win;$(ProjectDir)\..\..\win\WebCoreSupport;$(ProjectDir)\..\..\Storage;$(ConfigurationBuildDir)\include\WebKit;$(ConfigurationBuildDir)\Include;$(ConfigurationBuildDir)\Include\private;$(ConfigurationBuildDir)\Include\WebCore;$(ConfigurationBuildDir)\Include\WebCore\ForwardingHeaders;$(ConfigurationBuildDir)\Include\_javascript_Core;$(ConfigurationBuildDir)\Include\private\_javascript_Core;$(ConfigurationBuildDir)\obj$(PlatformArchitecture)\WebKit\DerivedSources;$(WebKit_Libraries)\Include;$(WebKit_Libraries)\Include\private;$(WebKit_Libraries)\Include\WebCore;$(WebKit_Libraries)\Include\WebCore\ForwardingHeaders;$(WebKit_Libraries)\Include\_javascript_Core;$(WebKit_Libraries)\Include\private\_javascript_Core;$(IntDir)include;%(AdditionalIncludeDirectories)
   WEBKIT_EXPORTS;FRAMEWORK_NAME=WebKit;%(PreprocessorDefinitions)
   Use
   WebKitPrefix.h


Modified: trunk/Source/WebKit/mac/ChangeLog (177118 => 177119)

--- trunk/Source/WebKit/mac/ChangeLog	2014-12-11 01:18:14 UTC (rev 177118)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-12-11 01:31:52 UTC (rev 177119)
@@ -1,3 +1,15 @@
+2014-12-08  Anders Carlsson  
+
+Use the new storage namespace provider in WebKit1
+https://bugs.webkit.org/show_bug.cgi?id=139425
+
+Reviewed by Tim Horton.
+
+* WebView/WebView.mm:
+(-[WebView _commonInitializationWithFrameName:groupName:]):
+(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
+Set the storage namespace provider from the web page group.
+
 2014-12-10  Timothy Horton  
 
 Should have copy and paste items in all text menus


Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (177118 => 177119)

--- trunk/Source/WebKit/mac/WebView/WebView.mm	2014-12-11 01:18:14 UTC (rev 177118)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2014-12-11 01:31:52 UTC (rev 177119)
@@ -954,6 +954,7 @@
 pageConfiguration.alternativeTextClient = new WebAlternativeTextClient(self);
 pageConfiguration.loaderClientForMainFrame = new WebFrameLoaderClient;
 pageConfiguration.progressTrackerClient = new WebProgressTrackerClient(self);
+pageConfiguration.storageNamespaceProvider = &_private->group->storageNamespaceProvider();
 pageConfiguration.userContentController = &_private->group->userContentController();
 pageConfiguration.visitedLinkStore = &_private->group->visitedLinkStore();
 _private->page = ne

[webkit-changes] [177118] trunk/Source/WebKit2

2014-12-10 Thread andersca

Title: [177118] trunk/Source/WebKit2








Revision 177118
Author ander...@apple.com
Date 2014-12-10 17:18:14 -0800 (Wed, 10 Dec 2014)


Log Message
Switch WebKit2 over to using the storage namespace provider
https://bugs.webkit.org/show_bug.cgi?id=139509

Reviewed by Tim Horton.

* WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::~StorageNamespaceImpl):
(WebKit::localStorageNamespaceMap): Deleted.
Get rid of the storage namespace map - we have a map inside WebStorageNamespaceProvider now.

* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createStorageStrategy):
(WebKit::WebPlatformStrategies::populatePluginCache): Deleted.
(WebKit::WebPlatformStrategies::localStorageNamespace): Deleted.
(WebKit::WebPlatformStrategies::transientLocalStorageNamespace): Deleted.
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
Get rid of the storage strategy.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Set a storage namespace provider.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (177117 => 177118)

--- trunk/Source/WebKit2/ChangeLog	2014-12-11 01:14:08 UTC (rev 177117)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-11 01:18:14 UTC (rev 177118)
@@ -1,3 +1,28 @@
+2014-12-10  Anders Carlsson  
+
+Switch WebKit2 over to using the storage namespace provider
+https://bugs.webkit.org/show_bug.cgi?id=139509
+
+Reviewed by Tim Horton.
+
+* WebProcess/Storage/StorageNamespaceImpl.cpp:
+(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
+(WebKit::StorageNamespaceImpl::~StorageNamespaceImpl):
+(WebKit::localStorageNamespaceMap): Deleted.
+Get rid of the storage namespace map - we have a map inside WebStorageNamespaceProvider now.
+
+* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
+(WebKit::WebPlatformStrategies::createStorageStrategy):
+(WebKit::WebPlatformStrategies::populatePluginCache): Deleted.
+(WebKit::WebPlatformStrategies::localStorageNamespace): Deleted.
+(WebKit::WebPlatformStrategies::transientLocalStorageNamespace): Deleted.
+* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
+Get rid of the storage strategy.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::WebPage):
+Set a storage namespace provider.
+
 2014-12-10  Beth Dakin  
 
  Follow-up build fix.


Modified: trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp (177117 => 177118)

--- trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp	2014-12-11 01:14:08 UTC (rev 177117)
+++ trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp	2014-12-11 01:18:14 UTC (rev 177118)
@@ -41,14 +41,6 @@
 
 namespace WebKit {
 
-typedef HashMap LocalStorageNamespaceMap;
-
-static LocalStorageNamespaceMap& localStorageNamespaceMap()
-{
-static NeverDestroyed localStorageNamespaceMap;
-return localStorageNamespaceMap;
-}
-
 RefPtr StorageNamespaceImpl::createSessionStorageNamespace(uint64_t identifier, unsigned quotaInBytes)
 {
 return adoptRef(new StorageNamespaceImpl(SessionStorage, identifier, nullptr, quotaInBytes));
@@ -56,14 +48,7 @@
 
 RefPtr StorageNamespaceImpl::createLocalStorageNamespace(uint64_t identifier, unsigned quotaInBytes)
 {
-LocalStorageNamespaceMap::AddResult result = localStorageNamespaceMap().add(identifier, nullptr);
-if (!result.isNewEntry)
-return result.iterator->value;
-
-RefPtr localStorageNamespace = adoptRef(new StorageNamespaceImpl(LocalStorage, identifier, nullptr, quotaInBytes));
-
-result.iterator->value = localStorageNamespace.get();
-return localStorageNamespace.release();
+return adoptRef(new StorageNamespaceImpl(LocalStorage, identifier, nullptr, quotaInBytes));
 }
 
 RefPtr StorageNamespaceImpl::createTransientLocalStorageNamespace(uint64_t identifier, WebCore::SecurityOrigin& topLevelOrigin, uint64_t quotaInBytes)
@@ -94,10 +79,6 @@
 
 StorageNamespaceImpl::~StorageNamespaceImpl()
 {
-if (m_storageType == LocalStorage) {
-ASSERT(localStorageNamespaceMap().contains(m_storageNamespaceID));
-localStorageNamespaceMap().remove(m_storageNamespaceID);
-}
 }
 
 PassRefPtr StorageNamespaceImpl::storageArea(PassRefPtr securityOrigin)


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp (177117 => 177118)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2014-12-11 01:14:08 UTC (rev 177117)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp	2014-

[webkit-changes] [177117] tags/Safari-600.1.4.13.1/

2014-12-10 Thread bshafiei

Title: [177117] tags/Safari-600.1.4.13.1/








Revision 177117
Author bshaf...@apple.com
Date 2014-12-10 17:14:08 -0800 (Wed, 10 Dec 2014)


Log Message
New tag.

Added Paths

tags/Safari-600.1.4.13.1/




Diff

Property changes: tags/Safari-600.1.4.13.1



Added: svn:ignore
depcomp
compile
config.guess
GNUmakefile.in
config.sub
ltmain.sh
aconfig.h.in
autom4te.cache
missing
aclocal.m4
install-sh
autotoolsconfig.h.in
INSTALL
README
gtk-doc.make
out
Makefile.chromium
WebKitSupportLibrary.zip
WebKitBuild

Added: svn:mergeinfo




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177116] trunk/Source/WebKit2

2014-12-10 Thread bdakin

Title: [177116] trunk/Source/WebKit2








Revision 177116
Author bda...@apple.com
Date 2014-12-10 17:10:48 -0800 (Wed, 10 Dec 2014)


Log Message
 Follow-up build fix.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (177115 => 177116)

--- trunk/Source/WebKit2/ChangeLog	2014-12-11 01:10:02 UTC (rev 177115)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-11 01:10:48 UTC (rev 177116)
@@ -1,3 +1,10 @@
+2014-12-10  Beth Dakin  
+
+ Follow-up build fix.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView initWithFrame:context:configuration:webView:]):
+
 2014-12-09  Jon Honeycutt  
 
 Null dereference performing a "TapAndAHalf" gesture in Google search field


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (177115 => 177116)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-12-11 01:10:02 UTC (rev 177115)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-12-11 01:10:48 UTC (rev 177116)
@@ -3623,7 +3623,7 @@
 }
 
 if (Class gestureClass = NSClassFromString(@"NSImmediateActionGestureRecognizer")) {
-RetainPtr recognizer = adoptNS([[gestureClass alloc] initWithTarget:nil action:NULL]);
+RetainPtr recognizer = adoptNS([(NSImmediateActionGestureRecognizer *)[gestureClass alloc] initWithTarget:nil action:NULL]);
 _data->_immediateActionController = adoptNS([[WKImmediateActionController alloc] initWithPage:*_data->_page view:self]);
 [recognizer setDelegate:_data->_immediateActionController.get()];
 [self addGestureRecognizer:recognizer.get()];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177115] trunk

2014-12-10 Thread jhoneycutt

Title: [177115] trunk








Revision 177115
Author jhoneyc...@apple.com
Date 2014-12-10 17:10:02 -0800 (Wed, 10 Dec 2014)


Log Message
Null dereference performing a "TapAndAHalf" gesture in Google search field




Reviewed by Darin Adler.

.:

* ManualTests/ios/tap-and-a-half-gesture-in-empty-text-field.html: Added.

Source/WebKit2:

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWithGesture):
Add a null check in the case that there is no word range for the
current position.

Modified Paths

trunk/ChangeLog
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm


Added Paths

trunk/ManualTests/ios/tap-and-a-half-gesture-in-empty-text-field.html




Diff

Modified: trunk/ChangeLog (177114 => 177115)

--- trunk/ChangeLog	2014-12-11 01:05:32 UTC (rev 177114)
+++ trunk/ChangeLog	2014-12-11 01:10:02 UTC (rev 177115)
@@ -1,3 +1,14 @@
+2014-12-10  Jon Honeycutt  
+
+Null dereference performing a "TapAndAHalf" gesture in Google search field
+
+
+
+
+Reviewed by Darin Adler.
+
+* ManualTests/ios/tap-and-a-half-gesture-in-empty-text-field.html: Added.
+
 2014-12-10  Dean Jackson  
 
 Blur filter performance test doesn't provide results


Added: trunk/ManualTests/ios/tap-and-a-half-gesture-in-empty-text-field.html (0 => 177115)

--- trunk/ManualTests/ios/tap-and-a-half-gesture-in-empty-text-field.html	(rev 0)
+++ trunk/ManualTests/ios/tap-and-a-half-gesture-in-empty-text-field.html	2014-12-11 01:10:02 UTC (rev 177115)
@@ -0,0 +1,6 @@
+This tests that performing a tap and a half gesture in a text field with no nearby text does not crash.
+WebKit bug #
+
+
\ No newline at end of file


Modified: trunk/Source/WebKit2/ChangeLog (177114 => 177115)

--- trunk/Source/WebKit2/ChangeLog	2014-12-11 01:05:32 UTC (rev 177114)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-11 01:10:02 UTC (rev 177115)
@@ -1,3 +1,17 @@
+2014-12-09  Jon Honeycutt  
+
+Null dereference performing a "TapAndAHalf" gesture in Google search field
+
+
+
+
+Reviewed by Darin Adler.
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::selectWithGesture):
+Add a null check in the case that there is no word range for the
+current position.
+
 2014-12-10  Beth Dakin  
 
 Speculative build fix.


Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (177114 => 177115)

--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-12-11 01:05:32 UTC (rev 177114)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm	2014-12-11 01:10:02 UTC (rev 177115)
@@ -889,7 +889,7 @@
 switch (wkGestureState) {
 case GestureRecognizerState::Began:
 range = wordRangeFromPosition(position);
-m_currentWordRange = Range::create(*frame.document(), range->startPosition(), range->endPosition());
+m_currentWordRange = range ? Range::create(*frame.document(), range->startPosition(), range->endPosition()) : nullptr;
 break;
 case GestureRecognizerState::Changed:
 if (!m_currentWordRange)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177114] trunk/Source/WebKit2

2014-12-10 Thread bdakin

Title: [177114] trunk/Source/WebKit2








Revision 177114
Author bda...@apple.com
Date 2014-12-10 17:05:32 -0800 (Wed, 10 Dec 2014)


Log Message
Speculative build fix.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:context:configuration:webView:]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (177113 => 177114)

--- trunk/Source/WebKit2/ChangeLog	2014-12-11 00:14:21 UTC (rev 177113)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-11 01:05:32 UTC (rev 177114)
@@ -1,5 +1,12 @@
 2014-12-10  Beth Dakin  
 
+Speculative build fix.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView initWithFrame:context:configuration:webView:]):
+
+2014-12-10  Beth Dakin  
+
 WK2: Add initial support for immediate actions
 https://bugs.webkit.org/show_bug.cgi?id=139511
 


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (177113 => 177114)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-12-11 00:14:21 UTC (rev 177113)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-12-11 01:05:32 UTC (rev 177114)
@@ -3622,8 +3622,8 @@
 self.actionMenu.autoenablesItems = NO;
 }
 
-if (NSClassFromString(@"NSImmediateActionGestureRecognizer")) {
-RetainPtr recognizer = adoptNS([[NSImmediateActionGestureRecognizer alloc] initWithTarget:nil action:NULL]);
+if (Class gestureClass = NSClassFromString(@"NSImmediateActionGestureRecognizer")) {
+RetainPtr recognizer = adoptNS([[gestureClass alloc] initWithTarget:nil action:NULL]);
 _data->_immediateActionController = adoptNS([[WKImmediateActionController alloc] initWithPage:*_data->_page view:self]);
 [recognizer setDelegate:_data->_immediateActionController.get()];
 [self addGestureRecognizer:recognizer.get()];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177113] trunk/Source

2014-12-10 Thread bdakin

Title: [177113] trunk/Source








Revision 177113
Author bda...@apple.com
Date 2014-12-10 16:14:21 -0800 (Wed, 10 Dec 2014)


Log Message
WK2: Add initial support for immediate actions
https://bugs.webkit.org/show_bug.cgi?id=139511

Reviewed by Tim Horton.

Source/WebCore:

SPI needed for immediate actions.
* WebCore.xcodeproj/project.pbxproj:
* platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h: Added.

Source/WebKit2:

New enum to track immediate action types as we add them.
* Shared/API/c/WKImmediateActionTypes.h: Added.

Create an NSImmediateActionGestureRecognizer if possible and a controller.
* UIProcess/API/mac/WKView.mm:
(-[WKView dealloc]):
(-[WKView initWithFrame:context:configuration:webView:]):
(-[WKView _didPerformActionMenuHitTest:userData:]):

This basic implementation of the controller will use the delegate methods to 
perform an ActionMenuHitTest when relevant. Future patches will patch 
_updateImmediateActionItem to use the hit test result to determine if there is any 
immediate action that should be taken.
* UIProcess/mac/WKImmediateActionController.h: Added.
* UIProcess/mac/WKImmediateActionController.mm: Added.
(-[WKImmediateActionController willDestroyView:]):
(-[WKImmediateActionController _clearImmediateActionState]):
(-[WKImmediateActionController didPerformActionMenuHitTest:userData:]):

Does much of the work done in Action Menu’s prepareForMenu.
(-[WKImmediateActionController immediateActionRecognizerWillPrepare:]):

Does much of the work done in Action Menu’s menuNeedsUpdate.
(-[WKImmediateActionController immediateActionRecognizerWillBeginAnimation:]):

Does much of the work done in Action Menu’s didCloseMenu.
(-[WKImmediateActionController immediateActionRecognizerDidCancelAnimation:]):

Does much of the work done in Action Menu’s willOpenMenu.
(-[WKImmediateActionController immediateActionRecognizerDidCompleteAnimation:]):

To be filled in.
(-[WKImmediateActionController _updateImmediateActionItem]):
* WebKit2.xcodeproj/project.pbxproj:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj


Added Paths

trunk/Source/WebCore/platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h
trunk/Source/WebKit2/Shared/API/c/WKImmediateActionTypes.h
trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.h
trunk/Source/WebKit2/UIProcess/mac/WKImmediateActionController.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (177112 => 177113)

--- trunk/Source/WebCore/ChangeLog	2014-12-10 23:55:37 UTC (rev 177112)
+++ trunk/Source/WebCore/ChangeLog	2014-12-11 00:14:21 UTC (rev 177113)
@@ -1,3 +1,14 @@
+2014-12-10  Beth Dakin  
+
+WK2: Add initial support for immediate actions
+https://bugs.webkit.org/show_bug.cgi?id=139511
+
+Reviewed by Tim Horton.
+
+SPI needed for immediate actions.
+* WebCore.xcodeproj/project.pbxproj:
+* platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h: Added.
+
 2014-12-10  Martin Hock  
 
 [iOS] Add setting to ignore viewport scaling constraints


Modified: trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj (177112 => 177113)

--- trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-12-10 23:55:37 UTC (rev 177112)
+++ trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj	2014-12-11 00:14:21 UTC (rev 177113)
@@ -3163,6 +3163,7 @@
 		931CBD10161A44E900E4C874 /* ScrollingStateTree.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 931CBD0A161A44E900E4C874 /* ScrollingStateTree.cpp */; };
 		931CBD11161A44E900E4C874 /* ScrollingStateTree.h in Headers */ = {isa = PBXBuildFile; fileRef = 931CBD0B161A44E900E4C874 /* ScrollingStateTree.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		931D72F615FE695300C4C07E /* LayoutMilestones.h in Headers */ = {isa = PBXBuildFile; fileRef = 931D72F515FE695300C4C07E /* LayoutMilestones.h */; settings = {ATTRIBUTES = (Private, ); }; };
+		9321D5901A390704008052BE /* NSImmediateActionGestureRecognizerSPI.h in Headers */ = {isa = PBXBuildFile; fileRef = 9321D58F1A3906FA008052BE /* NSImmediateActionGestureRecognizerSPI.h */; settings = {ATTRIBUTES = (Private, ); }; };
 		9326DC0C09DAD5D600AFC847 /* CharsetData.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 656581AC09D14EE6000E61D7 /* CharsetData.cpp */; };
 		9327A94209968D1A0068A546 /* HTMLOptionsCollection.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 9327A94109968D1A0068A546 /* HTMLOptionsCollection.cpp */; };
 		932871C00B20DEB70049035A /* PlatformMenuDescription.h in Headers */ = {isa = PBXBuildFile; fileRef = 932871BF0B20DEB70049035A /* PlatformMenuDescription.h */; settings = {ATTRIBUTES = (Private, ); }; };
@@ -10339,6 +10340,7 @@
 		931CBD0A161A44E900E4C874 /* ScrollingStateTree.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ScrollingStateTree.cpp; s

[webkit-changes] [177112] trunk/LayoutTests

2014-12-10 Thread ap

Title: [177112] trunk/LayoutTests








Revision 177112
Author a...@apple.com
Date 2014-12-10 15:55:37 -0800 (Wed, 10 Dec 2014)


Log Message
Mark more tests that fail on EWS bots with ATI graphics.

* platform/mac/TestExpectations:

* platform/mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
* platform/mac/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
These were expecting failure, but the tests pass on regular bots.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations


Removed Paths

trunk/LayoutTests/platform/mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt
trunk/LayoutTests/platform/mac/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (177111 => 177112)

--- trunk/LayoutTests/ChangeLog	2014-12-10 23:48:41 UTC (rev 177111)
+++ trunk/LayoutTests/ChangeLog	2014-12-10 23:55:37 UTC (rev 177112)
@@ -1,5 +1,15 @@
 2014-12-10  Alexey Proskuryakov  
 
+Mark more tests that fail on EWS bots with ATI graphics.
+
+* platform/mac/TestExpectations:
+
+* platform/mac/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Removed.
+* platform/mac/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
+These were expecting failure, but the tests pass on regular bots.
+
+2014-12-10  Alexey Proskuryakov  
+
 Rename layoutTestController to testRunner in TestExpectations.
 
 * platform/gtk/TestExpectations:


Modified: trunk/LayoutTests/platform/mac/TestExpectations (177111 => 177112)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-12-10 23:48:41 UTC (rev 177111)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-12-10 23:55:37 UTC (rev 177112)
@@ -328,13 +328,6 @@
 
 webkit.org/b/81410 scrollbars/scrollbar-middleclick-nopaste.html
 
-# These canvas tests are flaky (fail on bots, not locally, or vice versa)
-webkit.org/b/81599 fast/canvas/canvas-createPattern-fillRect-shadow.html [ Pass Failure ]
-webkit.org/b/81599 fast/canvas/canvas-draw-canvas-on-canvas-shadow.html [ Pass Failure ]
-webkit.org/b/81599 fast/canvas/canvas-fillRect-gradient-shadow.html [ Pass Failure ]
-webkit.org/b/81599 fast/canvas/set-colors.html [ Pass Failure ]
-webkit.org/b/81599 canvas/philip/tests/2d.path.arc.scale.1.html [ Pass Failure ]
-
 webkit.org/b/81618 fast/workers/storage/use-same-database-in-page-and-workers.html [ Pass Failure ]
 
 # Has failed since its introduction in r105826. Skipped everywhere but chromium.
@@ -873,8 +866,6 @@
 
 webkit.org/b/117427 compositing/reflections/load-video-in-reflection.html [ Pass Failure Crash Timeout ]
 
-webkit.org/b/137589 compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.html [ Pass ImageOnlyFailure ]
-
 # Resizing windows appears broken in both DRT and WTR, making the test fail or time out flakily.
 webkit.org/b/96642 loader/go-back-to-different-window-size.html [ Pass Failure Timeout ]
 
@@ -1447,3 +1438,25 @@
 [ MountainLion ] compositing/hidpi-nested-compositing-layers-with-subpixel-accumulation.html [ Pass ImageOnlyFailure ]
 [ MountainLion ] compositing/hidpi-non-simple-compositing-layer-with-fractional-size-and-background.html [ Pass ImageOnlyFailure ]
 [ MountainLion ] fast/layers/hidpi-transform-on-child-content-is-mispositioned.html [ Pass ImageOnlyFailure ]
+# Probably the same issue as above, but noticed earlier
+webkit.org/b/137589 compositing/hidpi-compositing-vs-non-compositing-check-on-testing-framework.html [ Pass ImageOnlyFailure ]
+
+# More tests that pass on all regression test bots, but flakily fail on 10.8 EWS, possibly also on ATI graphics only.
+[ MountainLion ] fast/borders/hidpi-border-radius-outer-border-goes-rectangle.html [ Pass ImageOnlyFailure ]
+[ MountainLion ] fast/canvas/canvas-fillRect-shadow.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/canvas-scale-fillRect-shadow.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/canvas-scale-shadowBlur.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/canvas-shadow.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/canvas-transforms-fillRect-shadow.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/webgl/array-bounds-clamping.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgb565.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas-rgba5551.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-canvas.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-rgb565.html [ Pass Failure ]
+[ MountainLion ] fast/canvas/webgl/tex-image-and-sub-image-2d-with-svg-image.html [ Pass Failure ]
+webkit.org/b/81599 [ MountainLion ] canvas/philip/tests/2d.path.arc.scale.1.html [ Pass Failu

[webkit-changes] [177111] trunk/Source

2014-12-10 Thread timothy_horton

Title: [177111] trunk/Source








Revision 177111
Author timothy_hor...@apple.com
Date 2014-12-10 15:48:41 -0800 (Wed, 10 Dec 2014)


Log Message
Should have copy and paste items in all text menus
https://bugs.webkit.org/show_bug.cgi?id=139510


Reviewed by Beth Dakin.

* UIProcess/mac/WKActionMenuController.mm:
(-[WKActionMenuController _defaultMenuItemsForText]):
Add a disabled paste menu item into the read-only text menu.

(-[WKActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
Add a disabled copy menu item into the editable whitespace text menu.

* WebView/WebActionMenuController.mm:
(-[WebActionMenuController _defaultMenuItemsForText]):
Add a disabled paste menu item into the read-only text menu.

(-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
Add a disabled copy menu item into the editable whitespace text menu.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (177110 => 177111)

--- trunk/Source/WebKit/mac/ChangeLog	2014-12-10 23:42:51 UTC (rev 177110)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-12-10 23:48:41 UTC (rev 177111)
@@ -1,3 +1,18 @@
+2014-12-10  Timothy Horton  
+
+Should have copy and paste items in all text menus
+https://bugs.webkit.org/show_bug.cgi?id=139510
+
+
+Reviewed by Beth Dakin.
+
+* WebView/WebActionMenuController.mm:
+(-[WebActionMenuController _defaultMenuItemsForText]):
+Add a disabled paste menu item into the read-only text menu.
+
+(-[WebActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
+Add a disabled copy menu item into the editable whitespace text menu.
+
 2014-12-10  Anders Carlsson  
 
 Add WebStorageNamespaceProvider::closeLocalStorage


Modified: trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm (177110 => 177111)

--- trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm	2014-12-10 23:42:51 UTC (rev 177110)
+++ trunk/Source/WebKit/mac/WebView/WebActionMenuController.mm	2014-12-10 23:48:41 UTC (rev 177111)
@@ -477,8 +477,10 @@
 {
 RetainPtr copyTextItem = [self _createActionMenuItemForTag:WebActionMenuItemTagCopyText];
 RetainPtr lookupTextItem = [self _createActionMenuItemForTag:WebActionMenuItemTagLookupText];
+RetainPtr pasteItem = [self _createActionMenuItemForTag:WebActionMenuItemTagPaste];
+[pasteItem setEnabled:NO];
 
-return @[ copyTextItem.get(), lookupTextItem.get() ];
+return @[ copyTextItem.get(), lookupTextItem.get(), pasteItem.get() ];
 }
 
 - (NSArray *)_defaultMenuItemsForEditableText
@@ -685,9 +687,11 @@
 
 - (NSArray *)_defaultMenuItemsForWhitespaceInEditableArea
 {
+RetainPtr copyTextItem = [self _createActionMenuItemForTag:WebActionMenuItemTagCopyText];
 RetainPtr pasteItem = [self _createActionMenuItemForTag:WebActionMenuItemTagPaste];
+[copyTextItem setEnabled:NO];
 
-return @[ [NSMenuItem separatorItem], [NSMenuItem separatorItem], pasteItem.get() ];
+return @[ copyTextItem.get(), [NSMenuItem separatorItem], pasteItem.get() ];
 }
 
 #pragma mark NSSharingServicePickerDelegate implementation


Modified: trunk/Source/WebKit2/ChangeLog (177110 => 177111)

--- trunk/Source/WebKit2/ChangeLog	2014-12-10 23:42:51 UTC (rev 177110)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-10 23:48:41 UTC (rev 177111)
@@ -1,3 +1,18 @@
+2014-12-10  Timothy Horton  
+
+Should have copy and paste items in all text menus
+https://bugs.webkit.org/show_bug.cgi?id=139510
+
+
+Reviewed by Beth Dakin.
+
+* UIProcess/mac/WKActionMenuController.mm:
+(-[WKActionMenuController _defaultMenuItemsForText]):
+Add a disabled paste menu item into the read-only text menu.
+
+(-[WKActionMenuController _defaultMenuItemsForWhitespaceInEditableArea]):
+Add a disabled copy menu item into the editable whitespace text menu.
+
 2014-12-10  Martin Hock  
 
 [iOS] Add setting to ignore viewport scaling constraints


Modified: trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm (177110 => 177111)

--- trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm	2014-12-10 23:42:51 UTC (rev 177110)
+++ trunk/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm	2014-12-10 23:48:41 UTC (rev 177111)
@@ -778,8 +778,10 @@
 {
 RetainPtr copyTextItem = [self _createActionMenuItemForTag:kWKContextActionItemTagCopyText];
 RetainPtr lookupTextItem = [self _createActionMenuItemForTag:kWKContextActionItemTagLookupText];
+RetainPtr pasteItem = [self _createActionMenuItemForTag:kWKContextActionItemTagPaste];
+[pasteItem setEnabled:NO];
 
-return @[ copyTextItem.get(), lookupTextItem.get() ];
+return @[ copyTextItem.get(), lookupTextItem.get(), pasteItem.get() ];
 }
 
 - (NSArray *)_defaultMenuIt

[webkit-changes] [177110] trunk/Source

2014-12-10 Thread mhock

Title: [177110] trunk/Source








Revision 177110
Author mh...@apple.com
Date 2014-12-10 15:42:51 -0800 (Wed, 10 Dec 2014)


Log Message
[iOS] Add setting to ignore viewport scaling constraints
https://bugs.webkit.org/show_bug.cgi?id=139466


Reviewed by Benjamin Poulain.

Source/WebCore:

* WebCore.exp.in:
* page/Settings.in: Add setting to ignore viewport scaling constraints.
* page/ViewportConfiguration.cpp: Ignore viewport scaling constraints based on preference.
(WebCore::ViewportConfiguration::initialScale):
(WebCore::ViewportConfiguration::minimumScale):
(WebCore::ViewportConfiguration::allowsUserScaling):
* page/ViewportConfiguration.h:
(WebCore::ViewportConfiguration::setIgnoreScalingConstraints):
(WebCore::ViewportConfiguration::allowsUserScaling): Moved to cpp.

Source/WebKit2:

* Shared/WebPreferencesDefinitions.h: Add ignoreViewportScalingConstraints preference.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetIgnoreViewportScalingConstraints):
(WKPreferencesGetIgnoreViewportScalingConstraints):
* UIProcess/API/C/WKPreferencesRef.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/page/Settings.in
trunk/Source/WebCore/page/ViewportConfiguration.cpp
trunk/Source/WebCore/page/ViewportConfiguration.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebPreferencesDefinitions.h
trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRef.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177109 => 177110)

--- trunk/Source/WebCore/ChangeLog	2014-12-10 23:35:26 UTC (rev 177109)
+++ trunk/Source/WebCore/ChangeLog	2014-12-10 23:42:51 UTC (rev 177110)
@@ -1,3 +1,21 @@
+2014-12-10  Martin Hock  
+
+[iOS] Add setting to ignore viewport scaling constraints
+https://bugs.webkit.org/show_bug.cgi?id=139466
+
+
+Reviewed by Benjamin Poulain.
+
+* WebCore.exp.in:
+* page/Settings.in: Add setting to ignore viewport scaling constraints.
+* page/ViewportConfiguration.cpp: Ignore viewport scaling constraints based on preference.
+(WebCore::ViewportConfiguration::initialScale):
+(WebCore::ViewportConfiguration::minimumScale):
+(WebCore::ViewportConfiguration::allowsUserScaling):
+* page/ViewportConfiguration.h:
+(WebCore::ViewportConfiguration::setIgnoreScalingConstraints):
+(WebCore::ViewportConfiguration::allowsUserScaling): Moved to cpp.
+
 2014-12-10  Andreas Kling  
 
 Speculative fix for assertion "frame().view() == this"


Modified: trunk/Source/WebCore/WebCore.exp.in (177109 => 177110)

--- trunk/Source/WebCore/WebCore.exp.in	2014-12-10 23:35:26 UTC (rev 177109)
+++ trunk/Source/WebCore/WebCore.exp.in	2014-12-10 23:42:51 UTC (rev 177110)
@@ -1908,6 +1908,7 @@
 __ZNK7WebCore21ViewportConfiguration10layoutSizeEv
 __ZNK7WebCore21ViewportConfiguration12initialScaleEv
 __ZNK7WebCore21ViewportConfiguration12minimumScaleEv
+__ZNK7WebCore21ViewportConfiguration17allowsUserScalingEv
 __ZNK7WebCore22WheelEventDeltaTracker30dominantScrollGestureDirectionEv
 __ZNK7WebCore23ApplicationCacheStorage11maximumSizeEv
 __ZNK7WebCore23AuthenticationChallenge20authenticationClientEv


Modified: trunk/Source/WebCore/page/Settings.in (177109 => 177110)

--- trunk/Source/WebCore/page/Settings.in	2014-12-10 23:35:26 UTC (rev 177109)
+++ trunk/Source/WebCore/page/Settings.in	2014-12-10 23:42:51 UTC (rev 177110)
@@ -236,3 +236,5 @@
 longMousePressEnabled initial=false
 
 serviceControlsEnabled initial=false, conditional=SERVICE_CONTROLS
+
+ignoreViewportScalingConstraints initial=false
\ No newline at end of file


Modified: trunk/Source/WebCore/page/ViewportConfiguration.cpp (177109 => 177110)

--- trunk/Source/WebCore/page/ViewportConfiguration.cpp	2014-12-10 23:35:26 UTC (rev 177109)
+++ trunk/Source/WebCore/page/ViewportConfiguration.cpp	2014-12-10 23:42:51 UTC (rev 177110)
@@ -46,6 +46,7 @@
 
 ViewportConfiguration::ViewportConfiguration()
 : m_minimumLayoutSize(1024, 768)
+, m_ignoreScalingConstraints(false)
 {
 // Setup a reasonable default configuration to avoid computing infinite scale/sizes.
 // Those are the original iPhone configuration.
@@ -102,7 +103,7 @@
 
 // If the document has specified its own initial scale, use it regardless.
 // This is guaranteed to be sanity checked already, so no need for MIN/MAX.
-if (m_configuration.initialScaleIsSet)
+if (m_configuration.initialScaleIsSet && !m_ignoreScalingConstraints)
 return m_configuration.initialScale;
 
 // If not, it is up to us to determine the initial scale.
@@ -117,13 +118,13 @@
 double height = m_contentSize.height() > 0 ? m_contentSize.height() : layoutHeight();
 if (height > 0 && height * initialScale < minimumLayoutSize.height())
 initialScale = m

[webkit-changes] [177109] branches/safari-600.3-branch/Source

2014-12-10 Thread matthew_hanson

Title: [177109] branches/safari-600.3-branch/Source








Revision 177109
Author matthew_han...@apple.com
Date 2014-12-10 15:35:26 -0800 (Wed, 10 Dec 2014)


Log Message
Merged r176999. rdar://problems/19149219

Modified Paths

branches/safari-600.3-branch/Source/WebCore/ChangeLog
branches/safari-600.3-branch/Source/WebCore/WebCore.exp.in
branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.cpp
branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.h
branches/safari-600.3-branch/Source/WebKit/mac/ChangeLog
branches/safari-600.3-branch/Source/WebKit/mac/WebView/WebActionMenuController.mm
branches/safari-600.3-branch/Source/WebKit/mac/WebView/WebView.mm
branches/safari-600.3-branch/Source/WebKit2/ChangeLog
branches/safari-600.3-branch/Source/WebKit2/Shared/WebHitTestResult.cpp
branches/safari-600.3-branch/Source/WebKit2/Shared/WebHitTestResult.h
branches/safari-600.3-branch/Source/WebKit2/UIProcess/API/mac/WKView.mm
branches/safari-600.3-branch/Source/WebKit2/UIProcess/mac/WKActionMenuController.mm




Diff

Modified: branches/safari-600.3-branch/Source/WebCore/ChangeLog (177108 => 177109)

--- branches/safari-600.3-branch/Source/WebCore/ChangeLog	2014-12-10 23:31:09 UTC (rev 177108)
+++ branches/safari-600.3-branch/Source/WebCore/ChangeLog	2014-12-10 23:35:26 UTC (rev 177109)
@@ -1,3 +1,21 @@
+2014-12-10  Matthew Hanson  
+
+Merge r176999. rdar://problem/19149219
+
+2014-12-08  Beth Dakin  
+
+Copy and Lookup menu items should be disabled when something is not copyable
+https://bugs.webkit.org/show_bug.cgi?id=139423
+
+Reviewed by Tim Horton.
+
+New function allowCopy() indicates whether the HitTestResult would allow itself to 
+be copied onto the pasteboard.
+* WebCore.exp.in:
+* rendering/HitTestResult.cpp:
+(WebCore::HitTestResult::allowsCopy):
+* rendering/HitTestResult.h:
+
 2014-10-29  Chris Dumez  
 
 Crash in CachedRawResource::canReuse() when reloading http://dnd.wizards.com/dungeons-and-dragons/story


Modified: branches/safari-600.3-branch/Source/WebCore/WebCore.exp.in (177108 => 177109)

--- branches/safari-600.3-branch/Source/WebCore/WebCore.exp.in	2014-12-10 23:31:09 UTC (rev 177108)
+++ branches/safari-600.3-branch/Source/WebCore/WebCore.exp.in	2014-12-10 23:35:26 UTC (rev 177109)
@@ -1665,6 +1665,7 @@
 __ZNK7WebCore13GraphicsLayer26backingStoreMemoryEstimateEv
 __ZNK7WebCore13HTTPHeaderMap3getENS_14HTTPHeaderNameE
 __ZNK7WebCore13HTTPHeaderMap3getERKN3WTF6StringE
+__ZNK7WebCore13HitTestResult10allowsCopyEv
 __ZNK7WebCore13HitTestResult10isLiveLinkEv
 __ZNK7WebCore13HitTestResult10isSelectedEv
 __ZNK7WebCore13HitTestResult11targetFrameEv


Modified: branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.cpp (177108 => 177109)

--- branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.cpp	2014-12-10 23:31:09 UTC (rev 177108)
+++ branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.cpp	2014-12-10 23:35:26 UTC (rev 177109)
@@ -544,6 +544,21 @@
 return !wordRange->text().isEmpty();
 }
 
+bool HitTestResult::allowsCopy() const
+{
+Node* node = innerNode();
+if (!node)
+return false;
+
+RenderObject* renderer = node->renderer();
+if (!renderer)
+return false;
+
+bool isUserSelectNone = renderer->style().userSelect() == SELECT_NONE;
+bool isPasswordField = isHTMLInputElement(node) && toHTMLInputElement(node)->isPasswordField();
+return !isPasswordField && !isUserSelectNone;
+}
+
 URL HitTestResult::absoluteLinkURL() const
 {
 if (m_innerURLElement)


Modified: branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.h (177108 => 177109)

--- branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.h	2014-12-10 23:31:09 UTC (rev 177108)
+++ branches/safari-600.3-branch/Source/WebCore/rendering/HitTestResult.h	2014-12-10 23:35:26 UTC (rev 177109)
@@ -126,6 +126,7 @@
 void toggleMediaMuteState() const;
 bool isDownloadableMedia() const;
 bool isOverTextInsideFormControlElement() const;
+bool allowsCopy() const;
 
 // Returns true if it is rect-based hit test and needs to continue until the rect is fully
 // enclosed by the boundaries of a node.


Modified: branches/safari-600.3-branch/Source/WebKit/mac/ChangeLog (177108 => 177109)

--- branches/safari-600.3-branch/Source/WebKit/mac/ChangeLog	2014-12-10 23:31:09 UTC (rev 177108)
+++ branches/safari-600.3-branch/Source/WebKit/mac/ChangeLog	2014-12-10 23:35:26 UTC (rev 177109)
@@ -1,3 +1,22 @@
+2014-12-10  Matthew Hanson  
+
+Merge r176999. rdar://problem/19149219
+
+2014-12-08  Beth Dakin  
+
+Copy and Lookup menu items should be disabled when something is not copyable
+https://bugs.webkit.org/show_bug.cgi?id=139423
+
+Reviewed by Tim Horton.
+
+Disable both lookup and copy when a HitTestResult does not

[webkit-changes] [177108] trunk/Source/WebInspectorUI

2014-12-10 Thread joepeck

Title: [177108] trunk/Source/WebInspectorUI








Revision 177108
Author joep...@webkit.org
Date 2014-12-10 15:31:09 -0800 (Wed, 10 Dec 2014)


Log Message
Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
https://bugs.webkit.org/show_bug.cgi?id=139307

Reviewed by Darin Adler.

* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (177107 => 177108)

--- trunk/Source/WebInspectorUI/ChangeLog	2014-12-10 23:19:41 UTC (rev 177107)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-12-10 23:31:09 UTC (rev 177108)
@@ -1,3 +1,13 @@
+2014-12-08  Joseph Pecoraro  
+
+Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported
+https://bugs.webkit.org/show_bug.cgi?id=139307
+
+Reviewed by Darin Adler.
+
+* UserInterface/Views/DOMTreeContentView.js:
+(WebInspector.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
+
 2014-12-05  Joseph Pecoraro  
 
 Web Inspector: Uncaught Exceptions when attempting to show Content Flow


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (177107 => 177108)

--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js	2014-12-10 23:19:41 UTC (rev 177107)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js	2014-12-10 23:31:09 UTC (rev 177108)
@@ -446,6 +446,7 @@
 // in a different way than just using the navigation bar button.
 PageAgent.getCompositingBordersVisible(function(error, compositingBordersVisible) {
 button.activated = error ? false : compositingBordersVisible;
+button.enabled = error !== "unsupported";
 });
 },
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177107] trunk/Source/WebCore

2014-12-10 Thread akling

Title: [177107] trunk/Source/WebCore








Revision 177107
Author akl...@apple.com
Date 2014-12-10 15:19:41 -0800 (Wed, 10 Dec 2014)


Log Message
Speculative fix for assertion "frame().view() == this"


Rubber-stamped by Anders Carlsson.

I have not reproduced this issue, but we can safely ignore animation
notifications for cached pages.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::newImageAnimationFrameAvailable):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177106 => 177107)

--- trunk/Source/WebCore/ChangeLog	2014-12-10 23:16:22 UTC (rev 177106)
+++ trunk/Source/WebCore/ChangeLog	2014-12-10 23:19:41 UTC (rev 177107)
@@ -1,3 +1,16 @@
+2014-12-10  Andreas Kling  
+
+Speculative fix for assertion "frame().view() == this"
+
+
+Rubber-stamped by Anders Carlsson.
+
+I have not reproduced this issue, but we can safely ignore animation
+notifications for cached pages.
+
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::newImageAnimationFrameAvailable):
+
 2014-12-10  Anders Carlsson  
 
 Add session storage handling to StorageNamespaceProvider


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (177106 => 177107)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2014-12-10 23:16:22 UTC (rev 177106)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2014-12-10 23:19:41 UTC (rev 177107)
@@ -1362,6 +1362,8 @@
 
 void RenderElement::newImageAnimationFrameAvailable(CachedImage& image)
 {
+if (document().inPageCache())
+return;
 auto& frameView = view().frameView();
 auto visibleRect = frameView.windowToContents(frameView.windowClipRect());
 if (!shouldRepaintForImageAnimation(*this, visibleRect)) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177106] trunk/Source/WebKit2

2014-12-10 Thread timothy_horton

Title: [177106] trunk/Source/WebKit2








Revision 177106
Author timothy_hor...@apple.com
Date 2014-12-10 15:16:22 -0800 (Wed, 10 Dec 2014)


Log Message
Fix the build.

* UIProcess/API/mac/WKView.mm:
(-[WKView _targetWindowForMovePreparation]):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (177105 => 177106)

--- trunk/Source/WebKit2/ChangeLog	2014-12-10 23:07:50 UTC (rev 177105)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-10 23:16:22 UTC (rev 177106)
@@ -1,5 +1,12 @@
 2014-12-10  Timothy Horton  
 
+Fix the build.
+
+* UIProcess/API/mac/WKView.mm:
+(-[WKView _targetWindowForMovePreparation]):
+
+2014-12-10  Timothy Horton  
+
 Provide SPI to asynchronously move a WKView into a window and know when it has painted
 https://bugs.webkit.org/show_bug.cgi?id=139460
 


Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (177105 => 177106)

--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-12-10 23:07:50 UTC (rev 177105)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm	2014-12-10 23:16:22 UTC (rev 177106)
@@ -3452,6 +3452,11 @@
 [[super inputContext] discardMarkedText]; // Inform the input method that we won't have an inline input area despite having been asked to.
 }
 
+- (NSWindow *)_targetWindowForMovePreparation
+{
+return _data->_targetWindowForMovePreparation;
+}
+
 #if ENABLE(FULLSCREEN_API)
 - (BOOL)_hasFullScreenWindowController
 {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177105] trunk/LayoutTests

2014-12-10 Thread ap

Title: [177105] trunk/LayoutTests








Revision 177105
Author a...@apple.com
Date 2014-12-10 15:07:50 -0800 (Wed, 10 Dec 2014)


Log Message
Rename layoutTestController to testRunner in TestExpectations.

* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win-xp/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations
trunk/LayoutTests/platform/win/TestExpectations
trunk/LayoutTests/platform/win-xp/TestExpectations
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/LayoutTests/platform/wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (177104 => 177105)

--- trunk/LayoutTests/ChangeLog	2014-12-10 23:00:13 UTC (rev 177104)
+++ trunk/LayoutTests/ChangeLog	2014-12-10 23:07:50 UTC (rev 177105)
@@ -1,5 +1,16 @@
 2014-12-10  Alexey Proskuryakov  
 
+Rename layoutTestController to testRunner in TestExpectations.
+
+* platform/gtk/TestExpectations:
+* platform/mac/TestExpectations:
+* platform/win-xp/TestExpectations:
+* platform/win/TestExpectations:
+* platform/wincairo/TestExpectations:
+* platform/wk2/TestExpectations:
+
+2014-12-10  Alexey Proskuryakov  
+
 media/video-controls-no-scripting.html is flaky
 https://bugs.webkit.org/show_bug.cgi?id=137368
 


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (177104 => 177105)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2014-12-10 23:00:13 UTC (rev 177104)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2014-12-10 23:07:50 UTC (rev 177105)
@@ -1296,7 +1296,7 @@
 webkit.org/b/63706 editing/pasteboard/cleanup-on-move.html [ Failure ]
 webkit.org/b/63706 editing/pasteboard/drag-list-item.html [ Failure ]
 
-# WebKit2 needs layoutTestController.setEditingBehaviour and other issues.
+# WebKit2 needs testRunner.setEditingBehaviour and other issues.
 webkit.org/b/40601 editing/selection/5354455-1.html [ Failure ]
 Bug(GTK) editing/selection/extend-after-mouse-selection.html [ Failure ]
 
@@ -1550,7 +1550,7 @@
 
 Bug(GTK) fast/history/go-back-to-iframe-with-plugin.html [ Timeout Pass ]
 
-# Looks like a bug in the LayoutTestController global history support due to missing API.
+# Looks like a bug in the testRunner global history support due to missing API.
 Bug(GTK) fast/history/window-open.html [ Failure ]
 
 # All of these IDN encoding tests seem to fail.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (177104 => 177105)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-12-10 23:00:13 UTC (rev 177104)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-12-10 23:07:50 UTC (rev 177105)
@@ -75,10 +75,10 @@
 fast/media/media-query-list-05.html [ Failure ]
 fast/media/media-query-list-06.html [ Failure ]
 
-# Needs layoutTestController.enableAutoResizeMode()
+# Needs testRunner.enableAutoResizeMode()
 fast/autoresize
 
-# Uses layoutTestController.titleTextDirection, which is Chromium-only
+# Uses testRunner.titleTextDirection, which is Chromium-only
 webkit.org/b/58845 fast/dom/title-directionality-removeChild.html
 webkit.org/b/58845 fast/dom/title-directionality.html
 


Modified: trunk/LayoutTests/platform/win/TestExpectations (177104 => 177105)

--- trunk/LayoutTests/platform/win/TestExpectations	2014-12-10 23:00:13 UTC (rev 177104)
+++ trunk/LayoutTests/platform/win/TestExpectations	2014-12-10 23:07:50 UTC (rev 177105)
@@ -716,7 +716,7 @@
 http/tests/xmlhttprequest/upload-progress-events.html
 http/tests/xmlhttprequest/upload-onprogress-event.html
 
-# LayoutTestController::setAutomaticLinkDetectionEnabled isn't implemented
+# testRunner::setAutomaticLinkDetectionEnabled isn't implemented
 editing/inserting/typing-space-to-trigger-smart-link.html
 editing/inserting/smart-link-when-caret-is-moved-before-URL.html
 
@@ -834,7 +834,7 @@
 # webkit.org/b/25220 media/video-document-types.html [ WontFix ]
 
 webkit.org/b/25792 fast/encoding/percent-escaping.html [ Pass Timeout ]
-# Bug 26481: Implement layoutTestController.dispatchPendingLoadRequests 
+# Bug 26481: Implement testRunner.dispatchPendingLoadRequests 
 http/tests/loading/deleted-host-in-resource-load-delegate-callback.html
 
 #  http/tests/cache/subresource-expiration.html fails intermittently
@@ -1010,7 +1010,7 @@
 fast/media/media-query-list-06.html [ Failure ]
 #fast/media/media-query-list-07.html
 
-# Needs layoutTestController.enableAutoResizeMode()
+# Needs testRunner.enableAutoResizeMode()
 fast/autoresize
 
 # Need to add functionality to DumpRenderTree to handle scrollbar policy changes
@@ -1088,7 +1088,7 @@
 http/tests/misc/link-rel-prefetch-and-subresource.html
 http/tests/misc/prefetch-purpose.html
 
-# LayoutTestController::pageProperty is not implemented for WIN yet.
+# testRunner::pageProperty is not implemented for WIN yet.

[webkit-changes] [177104] trunk/Source/WebKit2

2014-12-10 Thread timothy_horton

Title: [177104] trunk/Source/WebKit2








Revision 177104
Author timothy_hor...@apple.com
Date 2014-12-10 15:00:13 -0800 (Wed, 10 Dec 2014)


Log Message
Provide SPI to asynchronously move a WKView into a window and know when it has painted
https://bugs.webkit.org/show_bug.cgi?id=139460


Reviewed by Anders Carlsson.

* UIProcess/API/Cocoa/WKViewPrivate.h:
Add _prepareForMoveToWindow:withCompletionHandler:, which internally
goes through the motions of being parented in that window and calls
the completion handler once painting is done and the view is ready
to be displayed (upon which we expect the view to actually move into the window).

* UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
If we currently have a _targetWindowForMovePreparation (and are
pretending to be in that window), avoid performing viewWillMoveToWindow:
for a different window.

(-[WKView viewDidMoveToWindow]):
(-[WKView doWindowDidChangeScreen]):
(-[WKView _intrinsicDeviceScaleFactor]):
(-[WKView _colorSpace]):
(-[WKView _targetWindowForMovePreparation]):
If we have a _targetWindowForMovePreparation, use its properties instead
of self.window's.

(-[WKView _prepareForMoveToWindow:withCompletionHandler:]):
Simulate a move into the target window, but defer sending the view state update.
Then, send the view state update after registering the completion handler.

* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Rename m_viewStateChangeWantsReply to m_viewStateChangeWantsSynchronousReply.

(WebKit::WebPageProxy::installViewStateChangeCompletionHandler):
Added. Allow installing a block that will be called the next time
we get a didUpdateViewState back from the WebProcess after pushing the
current view state changes.

(WebKit::WebPageProxy::viewStateDidChange):
Adapt to the aforementioned rename.

(WebKit::WebPageProxy::dispatchViewStateChange):
Adapt to the aforementioned rename.
Send the view state change callback IDs along with SetViewState.

(WebKit::WebPageProxy::updateViewState):
Adapt to the aforementioned rename.

* UIProcess/WebPageProxy.h:
* UIProcess/mac/PageClientImpl.h:
* UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::activeWindow):
(WebKit::PageClientImpl::isViewWindowActive):
(WebKit::PageClientImpl::isViewVisible):
(WebKit::PageClientImpl::isViewVisibleOrOccluded):
(WebKit::PageClientImpl::isViewInWindow):
(WebKit::PageClientImpl::viewLayerHostingMode):
If we have a _targetWindowForMovePreparation, use its properties instead
of the WKView's window's.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::viewStateDidChange):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setViewState):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::viewStateDidChange):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::viewStateDidChange):
Push the callback IDs to the WebProcess, and accumulate them in TiledCoreAnimationDrawingArea.

(WebKit::TiledCoreAnimationDrawingArea::didUpdateViewStateTimerFired):
Call all of the callbacks after one runloop cycle, just like DidUpdateViewState.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h
trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm
trunk/Source/WebKit2/UIProcess/API/mac/WKViewInternal.h
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit2/UIProcess/WebPageProxy.h
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.h
trunk/Source/WebKit2/UIProcess/mac/PageClientImpl.mm
trunk/Source/WebKit2/WebProcess/WebPage/DrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.h
trunk/Source/WebKit2/WebProcess/WebPage/WebPage.messages.in
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h
trunk/Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (177103 => 177104)

--- trunk/Source/WebKit2/ChangeLog	2014-12-10 22:50:28 UTC (rev 177103)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-10 23:00:13 UTC (rev 177104)
@@ -1,3 +1,85 @@
+2014-12-10  Timothy Horton  
+
+Provide SPI to asynchronously move a WKView into a window and know when it has painted
+https://bugs.webkit.org/show_bug.cgi?id=139460
+
+
+Reviewed by Anders Carlsson.
+
+* UIProcess/API/Cocoa/WKViewPrivate.h:
+Add _prepareForMoveToWindow:withCompletionHandler:, which internally
+goes through the motions of being parented in that window

[webkit-changes] [177103] trunk/LayoutTests

2014-12-10 Thread ap

Title: [177103] trunk/LayoutTests








Revision 177103
Author a...@apple.com
Date 2014-12-10 14:50:28 -0800 (Wed, 10 Dec 2014)


Log Message
media/video-controls-no-scripting.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=137368

* platform/mac/TestExpectations: Update expectations to expect flakiness on all
OS X versions.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (177102 => 177103)

--- trunk/LayoutTests/ChangeLog	2014-12-10 22:48:07 UTC (rev 177102)
+++ trunk/LayoutTests/ChangeLog	2014-12-10 22:50:28 UTC (rev 177103)
@@ -1,3 +1,11 @@
+2014-12-10  Alexey Proskuryakov  
+
+media/video-controls-no-scripting.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=137368
+
+* platform/mac/TestExpectations: Update expectations to expect flakiness on all
+OS X versions.
+
 2014-12-10  Ryosuke Niwa  
 
 REGRESSION(r164329): Input fields are not honoring the maxlength attribute


Modified: trunk/LayoutTests/platform/mac/TestExpectations (177102 => 177103)

--- trunk/LayoutTests/platform/mac/TestExpectations	2014-12-10 22:48:07 UTC (rev 177102)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2014-12-10 22:50:28 UTC (rev 177103)
@@ -1132,8 +1132,10 @@
 ## --- Start media tests failing on Mavericks and earlier ---
 # HTTP Auth in Media is not supported in Mavericks and Mountain Lion
 webkit.org/b/40382 [ Mavericks MountainLion ] http/tests/media/video-auth.html [ WontFix ]
-webkit.org/b/137368 [ Mavericks ] media/video-controls-no-scripting.html [ Pass Failure ]
 
+# HTML sandboxing produces two or three messages flakily.
+webkit.org/b/137368 media/video-controls-no-scripting.html [ Pass Failure ]
+
 # Mavericks and prior do not support Media Source.
 [ MountainLion Mavericks ] media/media-source [ WontFix ]
 [ MountainLion Mavericks ] http/tests/media/media-source/ [ WontFix ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177102] trunk/Source

2014-12-10 Thread andersca

Title: [177102] trunk/Source








Revision 177102
Author ander...@apple.com
Date 2014-12-10 14:48:07 -0800 (Wed, 10 Dec 2014)


Log Message
Add session storage handling to StorageNamespaceProvider
https://bugs.webkit.org/show_bug.cgi?id=139507

Reviewed by Tim Horton.

Source/WebCore:

* page/Page.cpp:
(WebCore::Page::sessionStorage):
* storage/StorageNamespaceProvider.h:

Source/WebKit:

* Storage/WebStorageNamespaceProvider.cpp:
(WebStorageNamespaceProvider::createSessionStorageNamespace):
* Storage/WebStorageNamespaceProvider.h:

Source/WebKit2:

* WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::createSessionStorageNamespace):
* WebProcess/Storage/StorageNamespaceImpl.h:
* WebProcess/Storage/WebStorageNamespaceProvider.cpp:
(WebKit::WebStorageNamespaceProvider::createSessionStorageNamespace):
* WebProcess/Storage/WebStorageNamespaceProvider.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/Page.cpp
trunk/Source/WebCore/storage/StorageNamespaceProvider.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Storage/WebStorageNamespaceProvider.cpp
trunk/Source/WebKit/Storage/WebStorageNamespaceProvider.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.cpp
trunk/Source/WebKit2/WebProcess/Storage/StorageNamespaceImpl.h
trunk/Source/WebKit2/WebProcess/Storage/WebStorageNamespaceProvider.cpp
trunk/Source/WebKit2/WebProcess/Storage/WebStorageNamespaceProvider.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (177101 => 177102)

--- trunk/Source/WebCore/ChangeLog	2014-12-10 22:33:15 UTC (rev 177101)
+++ trunk/Source/WebCore/ChangeLog	2014-12-10 22:48:07 UTC (rev 177102)
@@ -1,3 +1,14 @@
+2014-12-10  Anders Carlsson  
+
+Add session storage handling to StorageNamespaceProvider
+https://bugs.webkit.org/show_bug.cgi?id=139507
+
+Reviewed by Tim Horton.
+
+* page/Page.cpp:
+(WebCore::Page::sessionStorage):
+* storage/StorageNamespaceProvider.h:
+
 2014-12-10  Roger Fong  
 
 Unreviewed. Follow-up patch to r177099.


Modified: trunk/Source/WebCore/page/Page.cpp (177101 => 177102)

--- trunk/Source/WebCore/page/Page.cpp	2014-12-10 22:33:15 UTC (rev 177101)
+++ trunk/Source/WebCore/page/Page.cpp	2014-12-10 22:48:07 UTC (rev 177102)
@@ -1090,8 +1090,12 @@
 
 StorageNamespace* Page::sessionStorage(bool optionalCreate)
 {
-if (!m_sessionStorage && optionalCreate)
-m_sessionStorage = StorageNamespace::sessionStorageNamespace(this);
+if (!m_sessionStorage && optionalCreate) {
+if (m_storageNamespaceProvider)
+m_sessionStorage = m_storageNamespaceProvider->createSessionStorageNamespace(*this, m_settings->sessionStorageQuota());
+else
+m_sessionStorage = StorageNamespace::sessionStorageNamespace(this);
+}
 
 return m_sessionStorage.get();
 }


Modified: trunk/Source/WebCore/storage/StorageNamespaceProvider.h (177101 => 177102)

--- trunk/Source/WebCore/storage/StorageNamespaceProvider.h	2014-12-10 22:33:15 UTC (rev 177101)
+++ trunk/Source/WebCore/storage/StorageNamespaceProvider.h	2014-12-10 22:48:07 UTC (rev 177102)
@@ -43,6 +43,7 @@
 StorageNamespaceProvider();
 virtual ~StorageNamespaceProvider();
 
+virtual RefPtr createSessionStorageNamespace(Page&, unsigned quota) = 0;
 StorageNamespace& localStorageNamespace();
 StorageNamespace& transientLocalStorageNamespace(SecurityOrigin&);
 


Modified: trunk/Source/WebKit/ChangeLog (177101 => 177102)

--- trunk/Source/WebKit/ChangeLog	2014-12-10 22:33:15 UTC (rev 177101)
+++ trunk/Source/WebKit/ChangeLog	2014-12-10 22:48:07 UTC (rev 177102)
@@ -1,5 +1,16 @@
 2014-12-10  Anders Carlsson  
 
+Add session storage handling to StorageNamespaceProvider
+https://bugs.webkit.org/show_bug.cgi?id=139507
+
+Reviewed by Tim Horton.
+
+* Storage/WebStorageNamespaceProvider.cpp:
+(WebStorageNamespaceProvider::createSessionStorageNamespace):
+* Storage/WebStorageNamespaceProvider.h:
+
+2014-12-10  Anders Carlsson  
+
 Add WebStorageNamespaceProvider::closeLocalStorage
 https://bugs.webkit.org/show_bug.cgi?id=139502
 


Modified: trunk/Source/WebKit/Storage/WebStorageNamespaceProvider.cpp (177101 => 177102)

--- trunk/Source/WebKit/Storage/WebStorageNamespaceProvider.cpp	2014-12-10 22:33:15 UTC (rev 177101)
+++ trunk/Source/WebKit/Storage/WebStorageNamespaceProvider.cpp	2014-12-10 22:48:07 UTC (rev 177102)
@@ -62,6 +62,11 @@
 }
 }
 
+RefPtr WebStorageNamespaceProvider::createSessionStorageNamespace(Page&, unsigned quota)
+{
+return StorageNamespaceImpl::createSessionStorageNamespace(quota);
+}
+
 RefPtr WebStorageNamespaceProvider::createLocalStorageNamespace(unsigned quota)
 {
 return StorageNamespaceImpl::getOrCreateLocalStorageNamespace(m_localStorageDatabasePath, quota);


Modified: trunk/Source/WebKit/Storage/WebStorageNamespaceProvider.h (177101 => 177102)

--- trunk/Source/We

[webkit-changes] [177101] trunk/Source/WebCore

2014-12-10 Thread roger_fong

Title: [177101] trunk/Source/WebCore








Revision 177101
Author roger_f...@apple.com
Date 2014-12-10 14:33:15 -0800 (Wed, 10 Dec 2014)


Log Message
Unreviewed. Follow-up patch to r177099.
https://bugs.webkit.org/show_bug.cgi?id=133634

Enable GL_EXT_draw_buffers on iOS as well.
* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177100 => 177101)

--- trunk/Source/WebCore/ChangeLog	2014-12-10 22:31:52 UTC (rev 177100)
+++ trunk/Source/WebCore/ChangeLog	2014-12-10 22:33:15 UTC (rev 177101)
@@ -1,5 +1,15 @@
 2014-12-10  Roger Fong  
 
+Unreviewed. Follow-up patch to r177099.
+https://bugs.webkit.org/show_bug.cgi?id=133634
+
+
+Enable GL_EXT_draw_buffers on iOS as well.
+* platform/graphics/opengl/Extensions3DOpenGL.cpp:
+(WebCore::Extensions3DOpenGL::supportsExtension):
+
+2014-12-10  Roger Fong  
+
 Implement Multiple Render Targets as WebGL 1 extension.
 https://bugs.webkit.org/show_bug.cgi?id=133634.
 


Modified: trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp (177100 => 177101)

--- trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-12-10 22:31:52 UTC (rev 177100)
+++ trunk/Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp	2014-12-10 22:33:15 UTC (rev 177101)
@@ -211,7 +211,9 @@
 return m_availableExtensions.contains("GL_EXT_texture_filter_anisotropic");
 
 if (name == "GL_EXT_draw_buffers") {
-#if PLATFORM(MAC) || PLATFORM(GTK)
+#if PLATFORM(IOS)
+return m_availableExtensions.contains(name);
+#elif PLATFORM(MAC) || PLATFORM(GTK)
 return m_availableExtensions.contains("GL_ARB_draw_buffers");
 #else
 // FIXME: implement support for other platforms.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177100] trunk/Source/WebKit2

2014-12-10 Thread andersca

Title: [177100] trunk/Source/WebKit2








Revision 177100
Author ander...@apple.com
Date 2014-12-10 14:31:52 -0800 (Wed, 10 Dec 2014)


Log Message
Implement the rest of the transient local storage namespace code
https://bugs.webkit.org/show_bug.cgi?id=139505

Reviewed by Tim Horton.

* UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::TransientLocalStorageNamespace::create):
(WebKit::StorageManager::TransientLocalStorageNamespace::~TransientLocalStorageNamespace):
(WebKit::StorageManager::TransientLocalStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::TransientLocalStorageNamespace::clearStorageAreasMatchingOrigin):
(WebKit::StorageManager::TransientLocalStorageNamespace::clearAllStorageAreas):
(WebKit::StorageManager::TransientLocalStorageNamespace::TransientLocalStorageNamespace):
Introduce a new TransientLocalStorageNamespace that's just a glorified SecurityOrigin -> StorageArea HashMap.

(WebKit::StorageManager::StorageArea::create):
Change the return type to RefPtr.

(WebKit::StorageManager::deleteEntriesForOrigin):
(WebKit::StorageManager::deleteAllEntries):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
Use lambdas instead of bind. Delete the transient local storage as well.

(WebKit::StorageManager::createTransientLocalStorageMap):
Get a transient local storage namespace and ask it for a storage area.

(WebKit::StorageManager::getOrCreateTransientLocalStorageNamespace):
Look up the namespace from the map and create one if it doesn't exist.

(WebKit::StorageManager::deleteEntriesForOriginInternal): Deleted.
(WebKit::StorageManager::deleteAllEntriesInternal): Deleted.

* UIProcess/Storage/StorageManager.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp
trunk/Source/WebKit2/UIProcess/Storage/StorageManager.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (177099 => 177100)

--- trunk/Source/WebKit2/ChangeLog	2014-12-10 22:12:35 UTC (rev 177099)
+++ trunk/Source/WebKit2/ChangeLog	2014-12-10 22:31:52 UTC (rev 177100)
@@ -1,5 +1,40 @@
 2014-12-10  Anders Carlsson  
 
+Implement the rest of the transient local storage namespace code
+https://bugs.webkit.org/show_bug.cgi?id=139505
+
+Reviewed by Tim Horton.
+
+* UIProcess/Storage/StorageManager.cpp:
+(WebKit::StorageManager::TransientLocalStorageNamespace::create):
+(WebKit::StorageManager::TransientLocalStorageNamespace::~TransientLocalStorageNamespace):
+(WebKit::StorageManager::TransientLocalStorageNamespace::getOrCreateStorageArea):
+(WebKit::StorageManager::TransientLocalStorageNamespace::clearStorageAreasMatchingOrigin):
+(WebKit::StorageManager::TransientLocalStorageNamespace::clearAllStorageAreas):
+(WebKit::StorageManager::TransientLocalStorageNamespace::TransientLocalStorageNamespace):
+Introduce a new TransientLocalStorageNamespace that's just a glorified SecurityOrigin -> StorageArea HashMap.
+
+(WebKit::StorageManager::StorageArea::create):
+Change the return type to RefPtr.
+
+(WebKit::StorageManager::deleteEntriesForOrigin):
+(WebKit::StorageManager::deleteAllEntries):
+(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
+Use lambdas instead of bind. Delete the transient local storage as well.
+
+(WebKit::StorageManager::createTransientLocalStorageMap):
+Get a transient local storage namespace and ask it for a storage area.
+
+(WebKit::StorageManager::getOrCreateTransientLocalStorageNamespace):
+Look up the namespace from the map and create one if it doesn't exist.
+
+(WebKit::StorageManager::deleteEntriesForOriginInternal): Deleted.
+(WebKit::StorageManager::deleteAllEntriesInternal): Deleted.
+
+* UIProcess/Storage/StorageManager.h:
+
+2014-12-10  Anders Carlsson  
+
 Begin fixing transient local storage handling
 https://bugs.webkit.org/show_bug.cgi?id=139503
 


Modified: trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp (177099 => 177100)

--- trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp	2014-12-10 22:12:35 UTC (rev 177099)
+++ trunk/Source/WebKit2/UIProcess/Storage/StorageManager.cpp	2014-12-10 22:31:52 UTC (rev 177100)
@@ -46,7 +46,7 @@
 
 class StorageManager::StorageArea : public ThreadSafeRefCounted {
 public:
-static PassRefPtr create(LocalStorageNamespace*, PassRefPtr, unsigned quotaInBytes);
+static RefPtr create(LocalStorageNamespace*, PassRefPtr, unsigned quotaInBytes);
 ~StorageArea();
 
 SecurityOrigin* securityOrigin() const { return m_securityOrigin.get(); }
@@ -106,7 +106,55 @@
 HashMap, StorageArea*> m_storageAreaMap;
 };
 
-PassRefPtr StorageManager::StorageArea::create(LocalStorageNamespace* localStorageNamespace, PassRefPtr securityOrigin, unsigned quotaInBytes)
+class StorageManager::TransientLocalStorageNamespace : public ThreadSafeRefCounted

[webkit-changes] [177099] trunk/Source/WebCore

2014-12-10 Thread roger_fong

Title: [177099] trunk/Source/WebCore








Revision 177099
Author roger_f...@apple.com
Date 2014-12-10 14:12:35 -0800 (Wed, 10 Dec 2014)


Log Message
Implement Multiple Render Targets as WebGL 1 extension.
https://bugs.webkit.org/show_bug.cgi?id=133634.

Reviewed by Brent Fulgham.
Tested by:
webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
Enable the implementation now that an underlying driver bug has been resolved.
Do not enable for desktop platforms older that OS X 10.10.
* html/canvas/WebGLDrawBuffers.cpp:
(WebCore::WebGLDrawBuffers::supported):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (177098 => 177099)

--- trunk/Source/WebCore/ChangeLog	2014-12-10 22:10:23 UTC (rev 177098)
+++ trunk/Source/WebCore/ChangeLog	2014-12-10 22:12:35 UTC (rev 177099)
@@ -1,3 +1,19 @@
+2014-12-10  Roger Fong  
+
+Implement Multiple Render Targets as WebGL 1 extension.
+https://bugs.webkit.org/show_bug.cgi?id=133634.
+
+
+Reviewed by Brent Fulgham.
+
+Tested by:
+webgl/1.0.3/conformance/extensions/webgl-draw-buffers.html
+
+Enable the implementation now that an underlying driver bug has been resolved.
+Do not enable for desktop platforms older that OS X 10.10.
+* html/canvas/WebGLDrawBuffers.cpp:
+(WebCore::WebGLDrawBuffers::supported):
+
 2014-12-10  Ryosuke Niwa  
 
 REGRESSION(r164329): Input fields are not honoring the maxlength attribute


Modified: trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp (177098 => 177099)

--- trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp	2014-12-10 22:10:23 UTC (rev 177098)
+++ trunk/Source/WebCore/html/canvas/WebGLDrawBuffers.cpp	2014-12-10 22:12:35 UTC (rev 177099)
@@ -46,11 +46,10 @@
 return WebGLExtension::WebGLDrawBuffersName;
 }
 
-#if OS(DARWIN)
+#if OS(DARWIN) && __MAC_OS_X_VERSION_MIN_REQUIRED < 10100
 
 bool WebGLDrawBuffers::supported(WebGLRenderingContext*)
 {
-// https://bugs.webkit.org/show_bug.cgi?id=112486
 return false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [177098] trunk

2014-12-10 Thread rniwa

Title: [177098] trunk








Revision 177098
Author rn...@webkit.org
Date 2014-12-10 14:10:23 -0800 (Wed, 10 Dec 2014)


Log Message
REGRESSION(r164329): Input fields are not honoring the maxlength attribute
https://bugs.webkit.org/show_bug.cgi?id=139447

Reviewed by Benjamin Poulain.

Source/WebCore:

The bug was caused by String::substring being called with the selection's end offset
in the second argument instead of the selection's length in handleBeforeTextInsertedEvent.

Fixed the bug by passing the right second argument to String::substring.

Test: fast/forms/input-maxlength-inserting-in-middle.html

* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):

LayoutTests:

Added regression tests.

* fast/forms/input-maxlength-inserting-in-middle-expected.txt: Added.
* fast/forms/input-maxlength-inserting-in-middle.html: Added.
* fast/forms/input-maxlength-paste-clusters-in-middle-expected.txt: Added.
* fast/forms/input-maxlength-paste-clusters-in-middle.html: Added.
* fast/forms/input-maxlength-paste-in-middle-expected.txt: Added.
* fast/forms/input-maxlength-paste-in-middle.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/TextFieldInputType.cpp


Added Paths

trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle-expected.txt
trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle.html
trunk/LayoutTests/fast/forms/input-maxlength-paste-clusters-in-middle-expected.txt
trunk/LayoutTests/fast/forms/input-maxlength-paste-clusters-in-middle.html
trunk/LayoutTests/fast/forms/input-maxlength-paste-in-middle-expected.txt
trunk/LayoutTests/fast/forms/input-maxlength-paste-in-middle.html




Diff

Modified: trunk/LayoutTests/ChangeLog (177097 => 177098)

--- trunk/LayoutTests/ChangeLog	2014-12-10 21:51:20 UTC (rev 177097)
+++ trunk/LayoutTests/ChangeLog	2014-12-10 22:10:23 UTC (rev 177098)
@@ -1,3 +1,19 @@
+2014-12-10  Ryosuke Niwa  
+
+REGRESSION(r164329): Input fields are not honoring the maxlength attribute
+https://bugs.webkit.org/show_bug.cgi?id=139447
+
+Reviewed by Benjamin Poulain.
+
+Added regression tests.
+
+* fast/forms/input-maxlength-inserting-in-middle-expected.txt: Added.
+* fast/forms/input-maxlength-inserting-in-middle.html: Added.
+* fast/forms/input-maxlength-paste-clusters-in-middle-expected.txt: Added.
+* fast/forms/input-maxlength-paste-clusters-in-middle.html: Added.
+* fast/forms/input-maxlength-paste-in-middle-expected.txt: Added.
+* fast/forms/input-maxlength-paste-in-middle.html: Added.
+
 2014-12-10  Antti Koivisto  
 
 Crash when creating CSSCalcBinaryOperation


Added: trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle-expected.txt (0 => 177098)

--- trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle-expected.txt	2014-12-10 22:10:23 UTC (rev 177098)
@@ -0,0 +1,12 @@
+This test attempts to insert a character in the middle of a text field with maxlength.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS input.value is "abc"
+PASS input.getAttribute("maxlength") is "3"
+PASS input.value is "abc"
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle.html (0 => 177098)

--- trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle.html	(rev 0)
+++ trunk/LayoutTests/fast/forms/input-maxlength-inserting-in-middle.html	2014-12-10 22:10:23 UTC (rev 177098)
@@ -0,0 +1,31 @@
+
+
+
+
+