[webkit-changes] [188172] trunk/Tools
Title: [188172] trunk/Tools
Revision 188172
Author commit-qu...@webkit.org
Date 2015-08-07 16:10:59 -0700 (Fri, 07 Aug 2015)
Log Message
Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
https://bugs.webkit.org/show_bug.cgi?id=147667
Patch by Jason Marcell jmarc...@apple.com on 2015-08-07
Reviewed by Daniel Bates.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
other than openSource and internal.
(BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
(Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
(Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
(sortedPlatforms): Deleted.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
(buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
(sortedPlatforms): Deleted.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
(sortDictionariesByOrder): Added. Takes an array of dictionaries that have an order property
and sorts them by this property returning the new sorted array.
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (188171 => 188172)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-08-07 23:07:22 UTC (rev 188171)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2015-08-07 23:10:59 UTC (rev 188172)
@@ -268,14 +268,14 @@
compareIterations: function(a, b)
{
-var result = b.revision[Dashboard.Repository.OpenSource.name] - a.revision[Dashboard.Repository.OpenSource.name];
-if (result)
-return result;
+var sortedRepositories = Dashboard.sortedRepositories;
+for (var i = 0; i sortedRepositories.length; ++i) {
+var repositoryName = sortedRepositories[i].name;
+var result = b.revision[repositoryName] - a.revision[repositoryName];
+if (result)
+return result;
+}
-result = b.revision[Dashboard.Repository.Internal.name] - a.revision[Dashboard.Repository.Internal.name];
-if (result)
-return result;
-
// A loaded iteration may not have revision numbers if it failed early, before svn steps finished.
result = b.loaded - a.loaded;
if (result)
@@ -286,14 +286,14 @@
compareIterationsByRevisions: function(a, b)
{
-var result = b.revision[Dashboard.Repository.OpenSource.name] - a.revision[Dashboard.Repository.OpenSource.name];
-if (result)
-return result;
+var sortedRepositories = Dashboard.sortedRepositories;
+for (var i = 0; i sortedRepositories.length; ++i) {
+var repositoryName = sortedRepositories[i].name;
+var result = b.revision[repositoryName] - a.revision[repositoryName];
+if (result)
+return result;
+}
-result = b.revision[Dashboard.Repository.Internal.name] - a.revision[Dashboard.Repository.Internal.name];
-if (result)
-return result;
-
return 0;
},
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js (188171 => 188172)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js 2015-08-07 23:07:22 UTC (rev 188171)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js 2015-08-07 23:10:59 UTC (rev 188172)
@@ -39,5 +39,17 @@
Repository: {
OpenSource: { name: openSource, order: 0 },
Internal: { name: internal, order: 1 },
-}
+},
+get sortedPlatforms()
+{
+if (!this._sortedPlatforms)
+this._sortedPlatforms = sortDictionariesByOrder(Dashboard.Platform);
+return this._sortedPlatforms;
+},
+get
[webkit-changes] [188173] trunk/Source/WebInspectorUI
Title: [188173] trunk/Source/WebInspectorUI
Revision 188173
Author nvasil...@apple.com
Date 2015-08-07 16:25:38 -0700 (Fri, 07 Aug 2015)
Log Message
Web Inspector: Simplify OS-specific CSS class names
https://bugs.webkit.org/show_bug.cgi?id=147794
Replace body:not(.el-capitan) with .legacy-mac.
Replace body.el-capitan with .latest-mac.
Reviewed by Timothy Hatcher.
* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
* UserInterface/Views/Toolbar.css:
(body.legacy-mac .toolbar .dashboard-container):
(body.legacy-mac .toolbar .search-bar input[type=search]):
(body.legacy-mac .toolbar .search-bar input[type=search]:focus):
(body.legacy-mac .toolbar .item.button:active):
(body.window-inactive.legacy-mac .toolbar .dashboard-container):
(body.latest-mac .toolbar .dashboard-container):
(body.latest-mac .toolbar .search-bar input[type=search]):
(body.latest-mac .toolbar .search-bar input[type=search]:focus):
(@media (-webkit-min-device-pixel-ratio: 2)):
(body.latest-mac .toolbar .item.button:active):
(body.latest-mac.window-inactive .toolbar .dashboard-container):
(body:not(.el-capitan) .toolbar .dashboard-container): Deleted.
(body:not(.el-capitan) .toolbar .search-bar input[type=search]): Deleted.
(body:not(.el-capitan) .toolbar .search-bar input[type=search]:focus): Deleted.
(body:not(.el-capitan) .toolbar .item.button:active): Deleted.
(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container): Deleted.
(body.el-capitan .toolbar .dashboard-container): Deleted.
(body.el-capitan .toolbar .search-bar input[type=search]): Deleted.
(body.el-capitan .toolbar .search-bar input[type=search]:focus): Deleted.
(body.el-capitan .toolbar .item.button:active): Deleted.
(body.el-capitan.window-inactive .toolbar .dashboard-container): Deleted.
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Base/Main.js
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188172 => 188173)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-07 23:10:59 UTC (rev 188172)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-07 23:25:38 UTC (rev 188173)
@@ -1,3 +1,38 @@
+2015-08-07 Nikita Vasilyev nvasil...@apple.com
+
+Web Inspector: Simplify OS-specific CSS class names
+https://bugs.webkit.org/show_bug.cgi?id=147794
+
+Replace body:not(.el-capitan) with .legacy-mac.
+Replace body.el-capitan with .latest-mac.
+
+Reviewed by Timothy Hatcher.
+
+* UserInterface/Base/Main.js:
+(WebInspector.contentLoaded):
+* UserInterface/Views/Toolbar.css:
+(body.legacy-mac .toolbar .dashboard-container):
+(body.legacy-mac .toolbar .search-bar input[type=search]):
+(body.legacy-mac .toolbar .search-bar input[type=search]:focus):
+(body.legacy-mac .toolbar .item.button:active):
+(body.window-inactive.legacy-mac .toolbar .dashboard-container):
+(body.latest-mac .toolbar .dashboard-container):
+(body.latest-mac .toolbar .search-bar input[type=search]):
+(body.latest-mac .toolbar .search-bar input[type=search]:focus):
+(@media (-webkit-min-device-pixel-ratio: 2)):
+(body.latest-mac .toolbar .item.button:active):
+(body.latest-mac.window-inactive .toolbar .dashboard-container):
+(body:not(.el-capitan) .toolbar .dashboard-container): Deleted.
+(body:not(.el-capitan) .toolbar .search-bar input[type=search]): Deleted.
+(body:not(.el-capitan) .toolbar .search-bar input[type=search]:focus): Deleted.
+(body:not(.el-capitan) .toolbar .item.button:active): Deleted.
+(body.window-inactive:not(.el-capitan) .toolbar .dashboard-container): Deleted.
+(body.el-capitan .toolbar .dashboard-container): Deleted.
+(body.el-capitan .toolbar .search-bar input[type=search]): Deleted.
+(body.el-capitan .toolbar .search-bar input[type=search]:focus): Deleted.
+(body.el-capitan .toolbar .item.button:active): Deleted.
+(body.el-capitan.window-inactive .toolbar .dashboard-container): Deleted.
+
2015-08-07 Devin Rousso drou...@apple.com
Web Inspector: Option+Up/Down arrow keys should increment/decrement numbers in HTML and SVG attributes
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (188172 => 188173)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-08-07 23:10:59 UTC (rev 188172)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-08-07 23:25:38 UTC (rev 188173)
@@ -190,9 +190,14 @@
document.body.classList.add(WebInspector.Platform.name + -platform);
if (WebInspector.Platform.isNightlyBuild)
document.body.classList.add(nightly-build);
-if (WebInspector.Platform.version.name)
-document.body.classList.add(WebInspector.Platform.version.name);
+if (WebInspector.Platform.name === mac) {
+if
[webkit-changes] [188174] trunk/LayoutTests
Title: [188174] trunk/LayoutTests Revision 188174 Author mmaxfi...@apple.com Date 2015-08-07 16:31:36 -0700 (Fri, 07 Aug 2015) Log Message [Mac] Test gardening Unreviewed. * platform/mac/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (188173 => 188174) --- trunk/LayoutTests/ChangeLog 2015-08-07 23:25:38 UTC (rev 188173) +++ trunk/LayoutTests/ChangeLog 2015-08-07 23:31:36 UTC (rev 188174) @@ -1,5 +1,13 @@ 2015-08-07 Myles C. Maxfield mmaxfi...@apple.com +[Mac] Test gardening + +Unreviewed. + +* platform/mac/TestExpectations: + +2015-08-07 Myles C. Maxfield mmaxfi...@apple.com + [OS X] Font fallback is not language-sensitive https://bugs.webkit.org/show_bug.cgi?id=147390 Modified: trunk/LayoutTests/platform/mac/TestExpectations (188173 => 188174) --- trunk/LayoutTests/platform/mac/TestExpectations 2015-08-07 23:25:38 UTC (rev 188173) +++ trunk/LayoutTests/platform/mac/TestExpectations 2015-08-07 23:31:36 UTC (rev 188174) @@ -1312,4 +1312,4 @@ webkit.org/b/147763 [ Yosemite ] accessibility/mac/loaded-notification.html [ Skip ] # Language-specific font fallback is disabled on certain versions of OS X -webkit.org/b/147390 fast/text/fallback-language-han.html [ Failure ] +webkit.org/b/147390 [ Mavericks Yosemite ElCapitan ] fast/text/fallback-language-han.html [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188175] trunk/Source/WebCore
Title: [188175] trunk/Source/WebCore Revision 188175 Author ander...@apple.com Date 2015-08-07 16:39:53 -0700 (Fri, 07 Aug 2015) Log Message Being moving away from using SQLTransactionStateMachine in SQLTransactionBackend https://bugs.webkit.org/show_bug.cgi?id=147798 Reviewed by Geoffrey Garen. This is the first step towards getting rid of the state machine so we can ultimately merge SQLTransactionBackend into SQLTransaction. Instead of having the state machine run our functions, just run them ourselves where we can. For states that need to be handled in the frontend, call SQLTransaction::requestTransitToState explicitly. * Modules/webdatabase/SQLTransactionBackend.cpp: (WebCore::SQLTransactionBackend::stateFunctionFor): (WebCore::SQLTransactionBackend::lockAcquired): (WebCore::SQLTransactionBackend::openTransactionAndPreflight): (WebCore::SQLTransactionBackend::runStatements): (WebCore::SQLTransactionBackend::runCurrentStatement): (WebCore::SQLTransactionBackend::handleCurrentStatementError): (WebCore::SQLTransactionBackend::handleTransactionError): (WebCore::SQLTransactionBackend::postflightAndCommit): (WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState): Deleted. (WebCore::SQLTransactionBackend::nextStateForCurrentStatementError): Deleted. (WebCore::SQLTransactionBackend::nextStateForTransactionError): Deleted. (WebCore::SQLTransactionBackend::sendToFrontendState): Deleted. * Modules/webdatabase/SQLTransactionBackend.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.h Diff Modified: trunk/Source/WebCore/ChangeLog (188174 => 188175) --- trunk/Source/WebCore/ChangeLog 2015-08-07 23:31:36 UTC (rev 188174) +++ trunk/Source/WebCore/ChangeLog 2015-08-07 23:39:53 UTC (rev 188175) @@ -1,3 +1,31 @@ +2015-08-07 Anders Carlsson ander...@apple.com + +Being moving away from using SQLTransactionStateMachine in SQLTransactionBackend +https://bugs.webkit.org/show_bug.cgi?id=147798 + +Reviewed by Geoffrey Garen. + +This is the first step towards getting rid of the state machine so we can ultimately merge SQLTransactionBackend +into SQLTransaction. + +Instead of having the state machine run our functions, just run them ourselves where we can. For states that need +to be handled in the frontend, call SQLTransaction::requestTransitToState explicitly. + +* Modules/webdatabase/SQLTransactionBackend.cpp: +(WebCore::SQLTransactionBackend::stateFunctionFor): +(WebCore::SQLTransactionBackend::lockAcquired): +(WebCore::SQLTransactionBackend::openTransactionAndPreflight): +(WebCore::SQLTransactionBackend::runStatements): +(WebCore::SQLTransactionBackend::runCurrentStatement): +(WebCore::SQLTransactionBackend::handleCurrentStatementError): +(WebCore::SQLTransactionBackend::handleTransactionError): +(WebCore::SQLTransactionBackend::postflightAndCommit): +(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState): Deleted. +(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError): Deleted. +(WebCore::SQLTransactionBackend::nextStateForTransactionError): Deleted. +(WebCore::SQLTransactionBackend::sendToFrontendState): Deleted. +* Modules/webdatabase/SQLTransactionBackend.h: + 2015-08-07 Filip Pizlo fpi...@apple.com Lightweight locks should be adaptive Modified: trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp (188174 => 188175) --- trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp 2015-08-07 23:31:36 UTC (rev 188174) +++ trunk/Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp 2015-08-07 23:39:53 UTC (rev 188175) @@ -447,14 +447,14 @@ SQLTransactionBackend::acquireLock, // 2. SQLTransactionBackend::openTransactionAndPreflight, // 3. SQLTransactionBackend::runStatements, // 4. -SQLTransactionBackend::postflightAndCommit, // 5. +SQLTransactionBackend::unreachableState,// 5. postflightAndCommit SQLTransactionBackend::cleanupAndTerminate, // 6. SQLTransactionBackend::cleanupAfterTransactionErrorCallback, // 7. -SQLTransactionBackend::sendToFrontendState, // 8. deliverTransactionCallback -SQLTransactionBackend::sendToFrontendState, // 9. deliverTransactionErrorCallback -SQLTransactionBackend::sendToFrontendState, // 10. deliverStatementCallback -SQLTransactionBackend::sendToFrontendState, // 11. deliverQuotaIncreaseCallback -SQLTransactionBackend::sendToFrontendState // 12. deliverSuccessCallback +SQLTransactionBackend::unreachableState,// 8. deliverTransactionCallback +
[webkit-changes] [188176] trunk
Title: [188176] trunk
Revision 188176
Author achristen...@apple.com
Date 2015-08-07 16:42:07 -0700 (Fri, 07 Aug 2015)
Log Message
Build more testing binaries with CMake on Windows
https://bugs.webkit.org/show_bug.cgi?id=147799
Reviewed by Brent Fulgham.
Source/_javascript_Core:
* shell/PlatformWin.cmake: Added.
Build jsc.dll and jsc.exe to find Apple Application Support or WinCairo dlls before using them.
Source/WebCore:
* CMakeLists.txt:
MockCDM.cpp needs to be part of WebCoreTestSupport, not WebCore.
* PlatformWin.cmake:
Added files needed for AppleWin port.
Source/WebKit/win:
* WebKitDLL.cpp:
(loadResourceIntoBuffer):
AppleWin doesn't like exporting a function without a separate declaration.
Tools:
* DumpRenderTree/CMakeLists.txt:
Build TestNetscapePlugin.
* DumpRenderTree/PlatformWin.cmake:
Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
* DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
* DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
* DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
* DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
* DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
* DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
* DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
* DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformWin.cmake
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebKitDLL.cpp
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/CMakeLists.txt
trunk/Tools/DumpRenderTree/PlatformWin.cmake
Added Paths
trunk/Source/_javascript_Core/shell/PlatformWin.cmake
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h
Removed Paths
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (188175 => 188176)
--- trunk/Source/_javascript_Core/ChangeLog 2015-08-07 23:39:53 UTC (rev 188175)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-08-07 23:42:07 UTC (rev 188176)
@@ -1,3 +1,13 @@
+2015-08-07 Alex Christensen achristen...@webkit.org
+
+Build more testing binaries with CMake on Windows
+https://bugs.webkit.org/show_bug.cgi?id=147799
+
+Reviewed by Brent Fulgham.
+
+* shell/PlatformWin.cmake: Added.
+Build jsc.dll and jsc.exe to find Apple Application Support or WinCairo dlls before using them.
+
2015-08-07 Filip Pizlo fpi...@apple.com
Lightweight locks should be adaptive
Added: trunk/Source/_javascript_Core/shell/PlatformWin.cmake (0 => 188176)
--- trunk/Source/_javascript_Core/shell/PlatformWin.cmake (rev 0)
+++ trunk/Source/_javascript_Core/shell/PlatformWin.cmake 2015-08-07 23:42:07 UTC (rev 188176)
@@ -0,0 +1,9 @@
+include_directories(./ ${_javascript_Core_INCLUDE_DIRECTORIES})
+add_library(jscdll SHARED ${JSC_SOURCES})
+target_link_libraries(jscdll ${JSC_LIBRARIES})
+set_target_properties(jscdll PROPERTIES FOLDER _javascript_Core)
+set_target_properties(jscdll PROPERTIES OUTPUT_NAME jsc)
+
+set(JSC_SOURCES ${TOOLS_DIR}/win/DLLLauncher/DLLLauncherMain.cpp)
+set(JSC_LIBRARIES shlwapi)
+add_definitions(-DUSE_CONSOLE_ENTRY_POINT)
Modified: trunk/Source/WebCore/CMakeLists.txt (188175 => 188176)
--- trunk/Source/WebCore/CMakeLists.txt 2015-08-07 23:39:53 UTC (rev 188175)
+++ trunk/Source/WebCore/CMakeLists.txt 2015-08-07 23:42:07 UTC (rev 188176)
@@ -2869,7 +2869,8 @@
Modules/encryptedmedia/MediaKeys.cpp
html/MediaKeyEvent.cpp
-
+)
+list(APPEND WebCoreTestSupport_SOURCES
testing/MockCDM.cpp
)
list(APPEND WebCore_IDL_FILES
@@ -3274,7 +3275,7 @@
testing/TypeConversions.idl
)
-set(WebCoreTestSupport_SOURCES
+list(APPEND WebCoreTestSupport_SOURCES
platform/mock/PlatformSpeechSynthesizerMock.cpp
platform/mock/mediasource/MockBox.cpp
Modified: trunk/Source/WebCore/ChangeLog (188175 =>
[webkit-changes] [188177] trunk/Tools
Title: [188177] trunk/Tools
Revision 188177
Author achristen...@apple.com
Date 2015-08-07 17:09:18 -0700 (Fri, 07 Aug 2015)
Log Message
[GTK] Speculative build fix after r188157.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):
Update parameter list.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp
Diff
Modified: trunk/Tools/ChangeLog (188176 => 188177)
--- trunk/Tools/ChangeLog 2015-08-07 23:42:07 UTC (rev 188176)
+++ trunk/Tools/ChangeLog 2015-08-08 00:09:18 UTC (rev 188177)
@@ -1,5 +1,13 @@
2015-08-07 Alex Christensen achristen...@webkit.org
+[GTK] Speculative build fix after r188157.
+
+* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+(WTR::PlatformWebView::PlatformWebView):
+Update parameter list.
+
+2015-08-07 Alex Christensen achristen...@webkit.org
+
Build more testing binaries with CMake on Windows
https://bugs.webkit.org/show_bug.cgi?id=147799
Modified: trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp (188176 => 188177)
--- trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp 2015-08-07 23:42:07 UTC (rev 188176)
+++ trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp 2015-08-08 00:09:18 UTC (rev 188177)
@@ -35,7 +35,7 @@
namespace WTR {
-PlatformWebView::PlatformWebView(WKContextRef context, WKPageGroupRef pageGroup, WKPageRef relatedPage, WKDictionaryRef options)
+PlatformWebView::PlatformWebView(WKContextRef context, WKPageGroupRef pageGroup, WKPageRef relatedPage, const ViewOptions options)
: m_view(WKViewCreate(context, pageGroup, relatedPage))
, m_window(gtk_window_new(GTK_WINDOW_POPUP))
, m_windowIsKey(true)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188178] trunk/Tools
Title: [188178] trunk/Tools
Revision 188178
Author achristen...@apple.com
Date 2015-08-07 17:14:59 -0700 (Fri, 07 Aug 2015)
Log Message
[EFL, GTK] Build fix after r188176.
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt
Diff
Modified: trunk/Tools/ChangeLog (188177 => 188178)
--- trunk/Tools/ChangeLog 2015-08-08 00:09:18 UTC (rev 188177)
+++ trunk/Tools/ChangeLog 2015-08-08 00:14:59 UTC (rev 188178)
@@ -1,5 +1,12 @@
2015-08-07 Alex Christensen achristen...@webkit.org
+[EFL, GTK] Build fix after r188176.
+
+* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
+I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
+
+2015-08-07 Alex Christensen achristen...@webkit.org
+
[GTK] Speculative build fix after r188157.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
Modified: trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt (188177 => 188178)
--- trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt 2015-08-08 00:09:18 UTC (rev 188177)
+++ trunk/Tools/DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt 2015-08-08 00:14:59 UTC (rev 188178)
@@ -32,7 +32,7 @@
set(WebKitTestNetscapePlugin_INCLUDE_DIRECTORIES
${WEBKIT_TESTNETSCAPEPLUGIN_DIR}
-${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/unix/ForwardingHeaders
+${WEBKIT_TESTNETSCAPEPLUGIN_DIR}/ForwardingHeaders
${WEBCORE_DIR}
${WTF_DIR}
)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188179] trunk/Tools
Title: [188179] trunk/Tools
Revision 188179
Author achristen...@apple.com
Date 2015-08-07 17:21:26 -0700 (Fri, 07 Aug 2015)
Log Message
[GTK] Another build fix after r188157.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::viewSupportsOptions):
Name all the things correctly!
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp
Diff
Modified: trunk/Tools/ChangeLog (188178 => 188179)
--- trunk/Tools/ChangeLog 2015-08-08 00:14:59 UTC (rev 188178)
+++ trunk/Tools/ChangeLog 2015-08-08 00:21:26 UTC (rev 188179)
@@ -1,5 +1,13 @@
2015-08-07 Alex Christensen achristen...@webkit.org
+[GTK] Another build fix after r188157.
+
+* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+(WTR::PlatformWebView::viewSupportsOptions):
+Name all the things correctly!
+
+2015-08-07 Alex Christensen achristen...@webkit.org
+
[EFL, GTK] Build fix after r188176.
* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
Modified: trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp (188178 => 188179)
--- trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp 2015-08-08 00:14:59 UTC (rev 188178)
+++ trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp 2015-08-08 00:21:26 UTC (rev 188179)
@@ -141,7 +141,7 @@
{
}
-bool PlatformWebView::viewSupportsOptions(const TestOptions) const
+bool PlatformWebView::viewSupportsOptions(const ViewOptions) const
{
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188180] tags/Safari-601.1.46.5/
Title: [188180] tags/Safari-601.1.46.5/ Revision 188180 Author bshaf...@apple.com Date 2015-08-07 17:48:39 -0700 (Fri, 07 Aug 2015) Log Message New tag. Added Paths tags/Safari-601.1.46.5/ Diff Property changes: tags/Safari-601.1.46.5 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188181] branches/safari-601.1.46-branch/Source
Title: [188181] branches/safari-601.1.46-branch/Source Revision 188181 Author bshaf...@apple.com Date 2015-08-07 18:13:48 -0700 (Fri, 07 Aug 2015) Log Message Versioning. Modified Paths branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig (188180 => 188181) --- branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-08 00:48:39 UTC (rev 188180) +++ branches/safari-601.1.46-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-08 01:13:48 UTC (rev 188181) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig (188180 => 188181) --- branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-08 00:48:39 UTC (rev 188180) +++ branches/safari-601.1.46-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-08 01:13:48 UTC (rev 188181) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (188180 => 188181) --- branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-08 00:48:39 UTC (rev 188180) +++ branches/safari-601.1.46-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-08 01:13:48 UTC (rev 188181) @@ -1,7 +1,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig (188180 => 188181) --- branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-08 00:48:39 UTC (rev 188180) +++ branches/safari-601.1.46-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-08 01:13:48 UTC (rev 188181) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); Modified: branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig (188180 => 188181) --- branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-08 00:48:39 UTC (rev 188180) +++ branches/safari-601.1.46-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-08 01:13:48 UTC (rev 188181) @@ -24,7 +24,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; TINY_VERSION = 46; -MICRO_VERSION = 5; +MICRO_VERSION = 6; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188182] trunk
Title: [188182] trunk
Revision 188182
Author jcr...@apple.com
Date 2015-08-07 19:14:43 -0700 (Fri, 07 Aug 2015)
Log Message
REGRESSION(r184722) AX: WebKit video playback toolbar removed from DOM; no longer accessible to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=145684
Reviewed by Dean Jackson.
Source/WebCore:
Updated Apple Video controls to add an invisible but focusable button that allows VoiceOver
users (and when unblocked, keyboard users) to re-display the video controls.
Test: media/video-controls-show-on-kb-or-ax-event.html
* English.lproj/mediaControlsLocalizedStrings.js:
* Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-show-controls):
(video::-webkit-media-show-controls):
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleShowControlsClick):
(Controller.prototype.handleWrapperMouseMove):
(Controller.prototype.updateForShowingControls):
(Controller.prototype.showControls):
(Controller.prototype.hideControls):
(Controller.prototype.setNeedsUpdateForDisplayedWidth):
* Modules/mediacontrols/mediaControlsiOS.css:
(audio::-webkit-media-show-controls):
(video::-webkit-media-show-controls):
LayoutTests:
* http/tests/contentextensions/text-track-blocked-expected.txt: Minor update to test case expectation.
* media/video-controls-show-on-kb-or-ax-event-expected.txt: Added.
* media/video-controls-show-on-kb-or-ax-event.html: New test validates video controls can be displayed without the need for a mouse.
* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Minor update to test case expectation.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt
trunk/LayoutTests/platform/mac/media/track/track-cue-rendering-horizontal-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/mediaControlsLocalizedStrings.js
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js
trunk/Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css
Added Paths
trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt
trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html
Diff
Modified: trunk/LayoutTests/ChangeLog (188181 => 188182)
--- trunk/LayoutTests/ChangeLog 2015-08-08 01:13:48 UTC (rev 188181)
+++ trunk/LayoutTests/ChangeLog 2015-08-08 02:14:43 UTC (rev 188182)
@@ -1,3 +1,15 @@
+2015-08-07 James Craig jcr...@apple.com
+
+REGRESSION(r184722) AX: WebKit video playback toolbar removed from DOM; no longer accessible to VoiceOver
+https://bugs.webkit.org/show_bug.cgi?id=145684
+
+Reviewed by Dean Jackson.
+
+* http/tests/contentextensions/text-track-blocked-expected.txt: Minor update to test case expectation.
+* media/video-controls-show-on-kb-or-ax-event-expected.txt: Added.
+* media/video-controls-show-on-kb-or-ax-event.html: New test validates video controls can be displayed without the need for a mouse.
+* platform/mac/media/track/track-cue-rendering-horizontal-expected.txt: Minor update to test case expectation.
+
2015-08-07 Myles C. Maxfield mmaxfi...@apple.com
[Mac] Test gardening
Modified: trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt (188181 => 188182)
--- trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-08 01:13:48 UTC (rev 188181)
+++ trunk/LayoutTests/http/tests/contentextensions/text-track-blocked-expected.txt 2015-08-08 02:14:43 UTC (rev 188182)
@@ -14,3 +14,5 @@
RenderVideo {VIDEO} at (0,18) size 320x240
layer at (8,26) size 320x240
RenderFlexibleBox {DIV} at (0,0) size 320x240
+layer at (8,256) size 320x10
+ RenderButton {BUTTON} at (0,230) size 320x10 [bgcolor=#C0C0C0] [border: (2px outset #C0C0C0)]
Added: trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt (0 => 188182)
--- trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt (rev 0)
+++ trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event-expected.txt 2015-08-08 02:14:43 UTC (rev 188182)
@@ -0,0 +1,6 @@
+This tests that, after the video controls fade out, they can be shown when VoiceOver or a keyboard user clicks the hidden Show Controls button.
+
+PASS
+
+
+
Added: trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html (0 => 188182)
--- trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html (rev 0)
+++ trunk/LayoutTests/media/video-controls-show-on-kb-or-ax-event.html 2015-08-08 02:14:43 UTC (rev 188182)
@@ -0,0 +1,42 @@
+body
+p
+This tests that, after the video controls fade out, they can be shown when VoiceOver or a keyboard user clicks the hidden Show Controls button.
+/p
+p id=result
+FAIL: Test
[webkit-changes] [188183] trunk/Source/WebCore
Title: [188183] trunk/Source/WebCore Revision 188183 Author za...@apple.com Date 2015-08-07 20:06:52 -0700 (Fri, 07 Aug 2015) Log Message Move painting functions from RenderObject to RenderElement. https://bugs.webkit.org/show_bug.cgi?id=147764 Reviewed by Simon Fraser. Ideally they should live in RenderBoxModelObject, but the current SVG architecture makes is difficult to move them there. No change in functionality. * platform/graphics/FloatRect.h: (WebCore::FloatRect::FloatRect): * rendering/RenderBoxModelObject.cpp: (WebCore::RenderBoxModelObject::paintOneBorderSide): * rendering/RenderElement.cpp: (WebCore::RenderElement::drawLineForBoxSide): (WebCore::RenderElement::paintFocusRing): (WebCore::RenderElement::paintOutline): * rendering/RenderElement.h: * rendering/RenderInline.cpp: (WebCore::RenderInline::paintOutline): (WebCore::RenderInline::paintOutlineForLine): * rendering/RenderMultiColumnSet.cpp: (WebCore::RenderMultiColumnSet::paintColumnRules): * rendering/RenderObject.cpp: (WebCore::RenderObject::drawLineForBoxSide): Deleted. (WebCore::RenderObject::paintFocusRing): Deleted. (WebCore::RenderObject::paintOutline): Deleted. * rendering/RenderObject.h: * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::paintCollapsedBorders): * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::paintRowGroupBorder): * rendering/RenderTheme.h: (WebCore::RenderTheme::paintMenuListButtonDecorations): * rendering/RenderThemeIOS.h: * rendering/RenderThemeIOS.mm: (WebCore::RenderThemeIOS::paintMenuListButtonDecorations): * rendering/RenderThemeMac.h: * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::paintMenuListButtonDecorations): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/efl/RenderThemeEfl.cpp trunk/Source/WebCore/platform/efl/RenderThemeEfl.h trunk/Source/WebCore/platform/graphics/FloatRect.h trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp trunk/Source/WebCore/rendering/RenderElement.cpp trunk/Source/WebCore/rendering/RenderElement.h trunk/Source/WebCore/rendering/RenderInline.cpp trunk/Source/WebCore/rendering/RenderMultiColumnSet.cpp trunk/Source/WebCore/rendering/RenderObject.cpp trunk/Source/WebCore/rendering/RenderObject.h trunk/Source/WebCore/rendering/RenderTableCell.cpp trunk/Source/WebCore/rendering/RenderTableSection.cpp trunk/Source/WebCore/rendering/RenderTheme.h trunk/Source/WebCore/rendering/RenderThemeGtk.cpp trunk/Source/WebCore/rendering/RenderThemeGtk.h trunk/Source/WebCore/rendering/RenderThemeIOS.h trunk/Source/WebCore/rendering/RenderThemeIOS.mm trunk/Source/WebCore/rendering/RenderThemeMac.h trunk/Source/WebCore/rendering/RenderThemeMac.mm trunk/Source/WebCore/rendering/RenderThemeWin.cpp trunk/Source/WebCore/rendering/RenderThemeWin.h Diff Modified: trunk/Source/WebCore/ChangeLog (188182 => 188183) --- trunk/Source/WebCore/ChangeLog 2015-08-08 02:14:43 UTC (rev 188182) +++ trunk/Source/WebCore/ChangeLog 2015-08-08 03:06:52 UTC (rev 188183) @@ -1,3 +1,47 @@ +2015-08-07 Zalan Bujtas za...@apple.com + +Move painting functions from RenderObject to RenderElement. +https://bugs.webkit.org/show_bug.cgi?id=147764 + +Reviewed by Simon Fraser. + +Ideally they should live in RenderBoxModelObject, but the current SVG architecture makes is difficult +to move them there. + +No change in functionality. + +* platform/graphics/FloatRect.h: +(WebCore::FloatRect::FloatRect): +* rendering/RenderBoxModelObject.cpp: +(WebCore::RenderBoxModelObject::paintOneBorderSide): +* rendering/RenderElement.cpp: +(WebCore::RenderElement::drawLineForBoxSide): +(WebCore::RenderElement::paintFocusRing): +(WebCore::RenderElement::paintOutline): +* rendering/RenderElement.h: +* rendering/RenderInline.cpp: +(WebCore::RenderInline::paintOutline): +(WebCore::RenderInline::paintOutlineForLine): +* rendering/RenderMultiColumnSet.cpp: +(WebCore::RenderMultiColumnSet::paintColumnRules): +* rendering/RenderObject.cpp: +(WebCore::RenderObject::drawLineForBoxSide): Deleted. +(WebCore::RenderObject::paintFocusRing): Deleted. +(WebCore::RenderObject::paintOutline): Deleted. +* rendering/RenderObject.h: +* rendering/RenderTableCell.cpp: +(WebCore::RenderTableCell::paintCollapsedBorders): +* rendering/RenderTableSection.cpp: +(WebCore::RenderTableSection::paintRowGroupBorder): +* rendering/RenderTheme.h: +(WebCore::RenderTheme::paintMenuListButtonDecorations): +* rendering/RenderThemeIOS.h: +* rendering/RenderThemeIOS.mm: +(WebCore::RenderThemeIOS::paintMenuListButtonDecorations): +* rendering/RenderThemeMac.h: +* rendering/RenderThemeMac.mm: +(WebCore::RenderThemeMac::paintMenuListButtonDecorations): + 2015-08-07 James Craig jcr...@apple.com
[webkit-changes] [188184] trunk/Source/WebInspectorUI
Title: [188184] trunk/Source/WebInspectorUI
Revision 188184
Author drou...@apple.com
Date 2015-08-07 20:45:21 -0700 (Fri, 07 Aug 2015)
Log Message
Web Inspector: Don't include zero-width space into a copied text from the console
https://bugs.webkit.org/show_bug.cgi?id=147767
Reviewed by Timothy Hatcher.
Now removes work break characters in generated _javascript_ text when copying
to the clipboard. Also replaced var with let in the modified functions.
* UserInterface/Views/ConsoleCommandView.js:
(WebInspector.ConsoleCommandView.prototype.toClipboardString):
(WebInspector.ConsoleCommandView):
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype.toClipboardString):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js
trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188183 => 188184)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-08 03:06:52 UTC (rev 188183)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-08 03:45:21 UTC (rev 188184)
@@ -1,3 +1,19 @@
+2015-08-07 Devin Rousso drou...@apple.com
+
+Web Inspector: Don't include zero-width space into a copied text from the console
+https://bugs.webkit.org/show_bug.cgi?id=147767
+
+Reviewed by Timothy Hatcher.
+
+Now removes work break characters in generated _javascript_ text when copying
+to the clipboard. Also replaced var with let in the modified functions.
+
+* UserInterface/Views/ConsoleCommandView.js:
+(WebInspector.ConsoleCommandView.prototype.toClipboardString):
+(WebInspector.ConsoleCommandView):
+* UserInterface/Views/ConsoleMessageView.js:
+(WebInspector.ConsoleMessageView.prototype.toClipboardString):
+
2015-08-07 Nikita Vasilyev nvasil...@apple.com
Web Inspector: Simplify OS-specific CSS class names
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js (188183 => 188184)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js 2015-08-08 03:06:52 UTC (rev 188183)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleCommandView.js 2015-08-08 03:45:21 UTC (rev 188184)
@@ -64,6 +64,6 @@
toClipboardString(isPrefixOptional)
{
-return (isPrefixOptional ? : ) + this._commandText;
+return (isPrefixOptional ? : ) + this._commandText.removeWordBreakCharacters();
}
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js (188183 => 188184)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-08-08 03:06:52 UTC (rev 188183)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ConsoleMessageView.js 2015-08-08 03:45:21 UTC (rev 188184)
@@ -185,12 +185,14 @@
toClipboardString(isPrefixOptional)
{
-var clipboardString = this._messageTextElement.innerText;
+let clipboardString = this._messageTextElement.innerText.removeWordBreakCharacters();
+if (this._message.savedResultIndex)
+clipboardString = clipboardString.replace(/\s*=\s*(\$\d+)$/, = $1);
if (this._message.type === WebInspector.ConsoleMessage.MessageType.Trace)
clipboardString = console.trace();
-var hasStackTrace = this._shouldShowStackTrace();
+let hasStackTrace = this._shouldShowStackTrace();
if (hasStackTrace) {
this._message.stackTrace.callFrames.forEach(function(frame) {
clipboardString += \n\t + (frame.functionName || WebInspector.UIString((anonymous function)));
@@ -198,10 +200,10 @@
clipboardString += ( + WebInspector.displayNameForURL(frame.url) + , line + frame.lineNumber + );
});
} else {
-var repeatString = this.repeatCount 1 ? x + this.repeatCount : ;
-var urlLine = ;
+let repeatString = this.repeatCount 1 ? x + this.repeatCount : ;
+let urlLine = ;
if (this._message.url) {
-var components = [WebInspector.displayNameForURL(this._message.url), line + this._message.line];
+let components = [WebInspector.displayNameForURL(this._message.url), line + this._message.line];
if (repeatString)
components.push(repeatString);
urlLine = ( + components.join(, ) + );
@@ -209,7 +211,7 @@
urlLine = ( + repeatString + );
if (urlLine) {
-var lines = clipboardString.split(\n);
+let lines = clipboardString.split(\n);
lines[0] += urlLine;
clipboardString = lines.join(\n);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188185] trunk/Source/WebCore
Title: [188185] trunk/Source/WebCore Revision 188185 Author mmaxfi...@apple.com Date 2015-08-07 20:54:44 -0700 (Fri, 07 Aug 2015) Log Message [OS X] Remove dead code from FontCache::createFontPlatformData() https://bugs.webkit.org/show_bug.cgi?id=147804 Reviewed by Zalan Bujtas. CTFontCreateForCSS() always returns the best font. No new tests because there is no behavior change. * platform/graphics/mac/FontCacheMac.mm: (WebCore::fontWithFamily): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm Diff Modified: trunk/Source/WebCore/ChangeLog (188184 => 188185) --- trunk/Source/WebCore/ChangeLog 2015-08-08 03:45:21 UTC (rev 188184) +++ trunk/Source/WebCore/ChangeLog 2015-08-08 03:54:44 UTC (rev 188185) @@ -1,3 +1,17 @@ +2015-08-07 Myles C. Maxfield mmaxfi...@apple.com + +[OS X] Remove dead code from FontCache::createFontPlatformData() +https://bugs.webkit.org/show_bug.cgi?id=147804 + +Reviewed by Zalan Bujtas. + +CTFontCreateForCSS() always returns the best font. + +No new tests because there is no behavior change. + +* platform/graphics/mac/FontCacheMac.mm: +(WebCore::fontWithFamily): + 2015-08-07 Zalan Bujtas za...@apple.com Move painting functions from RenderObject to RenderElement. Modified: trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm (188184 => 188185) --- trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm 2015-08-08 03:45:21 UTC (rev 188184) +++ trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm 2015-08-08 03:54:44 UTC (rev 188185) @@ -380,8 +380,6 @@ font = [NSFont fontWithName:chosenFullName size:size]; -#endif - if (!font) return nil; @@ -412,6 +410,8 @@ font = fontWithoutSyntheticTraits; } +#endif + return font; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188186] trunk/LayoutTests
Title: [188186] trunk/LayoutTests
Revision 188186
Author mmaxfi...@apple.com
Date 2015-08-07 21:08:16 -0700 (Fri, 07 Aug 2015)
Log Message
[El Capitan] Test Gardening
Unreviewed.
* platform/mac/css3/font-feature-settings-preinstalled-fonts-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/mac/css3/font-feature-settings-preinstalled-fonts-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (188185 => 188186)
--- trunk/LayoutTests/ChangeLog 2015-08-08 03:54:44 UTC (rev 188185)
+++ trunk/LayoutTests/ChangeLog 2015-08-08 04:08:16 UTC (rev 188186)
@@ -1,3 +1,11 @@
+2015-08-07 Myles C. Maxfield mmaxfi...@apple.com
+
+[El Capitan] Test Gardening
+
+Unreviewed.
+
+* platform/mac/css3/font-feature-settings-preinstalled-fonts-expected.txt: Added.
+
2015-08-07 James Craig jcr...@apple.com
REGRESSION(r184722) AX: WebKit video playback toolbar removed from DOM; no longer accessible to VoiceOver
Added: trunk/LayoutTests/platform/mac/css3/font-feature-settings-preinstalled-fonts-expected.txt (0 => 188186)
--- trunk/LayoutTests/platform/mac/css3/font-feature-settings-preinstalled-fonts-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/mac/css3/font-feature-settings-preinstalled-fonts-expected.txt 2015-08-08 04:08:16 UTC (rev 188186)
@@ -0,0 +1,1376 @@
+layer at (0,0) size 785x10402
+ RenderView at (0,0) size 785x600
+layer at (0,0) size 785x10402
+ RenderBlock {HTML} at (0,0) size 785x10402
+RenderBody {BODY} at (8,16) size 769x10378
+ RenderBlock {P} at (0,0) size 769x18
+RenderText {#text} at (0,0) size 517x18
+ text run at (0,0) width 517: This test dumps render tree information for text styled with font-feature-settings.
+ RenderBlock {DIV} at (0,34) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,70) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,106) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,142) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,178) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,214) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,250) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,286) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,322) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,358) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,394) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,430) size 769x36
+RenderText {#text} at (0,0) size 711x36
+ text run at (0,0) width 711: Lucky affluent actor asks to feast on giant 10.34\ cheese-filled quiche in
+ text run at (0,18) width 58: fjord.
+ RenderBlock {DIV} at (0,466) size 769x36
+RenderText {#text} at
[webkit-changes] [188187] trunk/Source
Title: [188187] trunk/Source Revision 188187 Author gyuyoung@webkit.org Date 2015-08-07 22:39:06 -0700 (Fri, 07 Aug 2015) Log Message Reduce uses of PassRefPtr in bindings https://bugs.webkit.org/show_bug.cgi?id=147781 Reviewed by Chris Dumez. Use RefPtr when function can return null or an instance. If not, Ref is used. Source/_javascript_Core: * runtime/JSGenericTypedArrayView.h: (JSC::toNativeTypedView): Source/WebCore: * bindings/gobject/GObjectNodeFilterCondition.h: * bindings/gobject/GObjectXPathNSResolver.h: * bindings/gobject/WebKitDOMNodeFilter.cpp: (WebKit::core): * bindings/gobject/WebKitDOMNodeFilterPrivate.h: * bindings/gobject/WebKitDOMXPathNSResolver.cpp: (WebKit::core): * bindings/gobject/WebKitDOMXPathNSResolverPrivate.h: * bindings/js/CallbackFunction.h: (WebCore::createFunctionOnlyCallback): * bindings/js/Dictionary.h: (WebCore::Dictionary::getEventListener): * bindings/js/IDBBindingUtilities.cpp: (WebCore::createIDBKeyFromValue): (WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath): (WebCore::createIDBKeyFromScriptValueAndKeyPath): (WebCore::scriptValueToIDBKey): * bindings/js/IDBBindingUtilities.h: * bindings/js/JSDOMBinding.h: (WebCore::toInt8Array): (WebCore::toInt16Array): (WebCore::toInt32Array): (WebCore::toUint8Array): (WebCore::toUint8ClampedArray): (WebCore::toUint16Array): (WebCore::toUint32Array): (WebCore::toFloat32Array): (WebCore::toFloat64Array): * bindings/js/JSDOMStringListCustom.cpp: (WebCore::JSDOMStringList::toWrapped): * bindings/js/JSDeviceMotionEventCustom.cpp: (WebCore::readAccelerationArgument): (WebCore::readRotationRateArgument): * bindings/js/JSErrorHandler.h: (WebCore::createJSErrorHandler): * bindings/js/JSGeolocationCustom.cpp: (WebCore::createPositionOptions): * bindings/js/JSNodeCustom.cpp: * bindings/js/JSNodeFilterCustom.cpp: (WebCore::JSNodeFilter::toWrapped): * bindings/js/ScriptController.cpp: (WebCore::ScriptController::createWorld): (WebCore::ScriptController::createRootObject): (WebCore::ScriptController::createScriptInstanceForWidget): * bindings/js/ScriptController.h: * bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget): * bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::create): * bindings/js/SerializedScriptValue.h: * bindings/objc/DOMUIKitExtensions.mm: (-[DOMNode rangeOfContainingParagraph]): * bindings/objc/ObjCNodeFilterCondition.h: * bindings/scripts/CodeGeneratorJS.pm: (GenerateHeader): Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayView.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/gobject/GObjectNodeFilterCondition.h trunk/Source/WebCore/bindings/gobject/GObjectXPathNSResolver.h trunk/Source/WebCore/bindings/gobject/WebKitDOMNodeFilter.cpp trunk/Source/WebCore/bindings/gobject/WebKitDOMNodeFilterPrivate.h trunk/Source/WebCore/bindings/gobject/WebKitDOMXPathNSResolver.cpp trunk/Source/WebCore/bindings/gobject/WebKitDOMXPathNSResolverPrivate.h trunk/Source/WebCore/bindings/js/CallbackFunction.h trunk/Source/WebCore/bindings/js/Dictionary.h trunk/Source/WebCore/bindings/js/IDBBindingUtilities.cpp trunk/Source/WebCore/bindings/js/IDBBindingUtilities.h trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/js/JSDOMStringListCustom.cpp trunk/Source/WebCore/bindings/js/JSDeviceMotionEventCustom.cpp trunk/Source/WebCore/bindings/js/JSErrorHandler.h trunk/Source/WebCore/bindings/js/JSGeolocationCustom.cpp trunk/Source/WebCore/bindings/js/JSNodeCustom.cpp trunk/Source/WebCore/bindings/js/JSNodeFilterCustom.cpp trunk/Source/WebCore/bindings/js/ScriptController.cpp trunk/Source/WebCore/bindings/js/ScriptController.h trunk/Source/WebCore/bindings/js/ScriptControllerMac.mm trunk/Source/WebCore/bindings/js/SerializedScriptValue.cpp trunk/Source/WebCore/bindings/js/SerializedScriptValue.h trunk/Source/WebCore/bindings/objc/DOMUIKitExtensions.mm trunk/Source/WebCore/bindings/objc/ObjCNodeFilterCondition.h trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm Diff Modified: trunk/Source/_javascript_Core/ChangeLog (188186 => 188187) --- trunk/Source/_javascript_Core/ChangeLog 2015-08-08 04:08:16 UTC (rev 188186) +++ trunk/Source/_javascript_Core/ChangeLog 2015-08-08 05:39:06 UTC (rev 188187) @@ -1,3 +1,15 @@ +2015-08-07 Gyuyoung Kim gyuyoung@webkit.org + +Reduce uses of PassRefPtr in bindings +https://bugs.webkit.org/show_bug.cgi?id=147781 + +Reviewed by Chris Dumez. + +Use RefPtr when function can return null or an instance. If not, Ref is used. + +* runtime/JSGenericTypedArrayView.h: +(JSC::toNativeTypedView): + 2015-08-07 Alex Christensen achristen...@webkit.org Build more testing binaries with CMake on Windows Modified: trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayView.h (188186 => 188187) --- trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayView.h
[webkit-changes] [188188] trunk/Source/WebInspectorUI
Title: [188188] trunk/Source/WebInspectorUI Revision 188188 Author drou...@apple.com Date 2015-08-07 22:39:26 -0700 (Fri, 07 Aug 2015) Log Message Web Inspector: Decrease the padding of each rule in the Rules sidebar to allow more content to show https://bugs.webkit.org/show_bug.cgi?id=147360 Reviewed by Timothy Hatcher. Generally tightened the padding around each section in the rules panel, as well as the content inside each section. Also moved the new rule button to be next to the filter bar. * UserInterface/Views/CSSStyleDeclarationSection.css: (.style-declaration-section): (.style-declaration-section.last-in-group): (.style-declaration-section.last-in-group + .style-declaration-section): Deleted. * UserInterface/Views/CSSStyleDeclarationTextEditor.css: (.css-style-text-editor): * UserInterface/Views/CSSStyleDetailsSidebarPanel.css: (.sidebar .panel.details.css-style .content .pseudo-classes): (.sidebar .panel.details.css-style .content + .options-container): (.sidebar .panel.details.css-style .content:not(.supports-new-rule, .has-filter-bar) + .options-container): (.sidebar .panel.details.css-style .content + .options-container .new-rule): (.sidebar .panel.details.css-style .content + .options-container .filter-bar): (.sidebar .panel.details.css-style .content:not(.has-filter-bar) + .options-container .filter-bar): (.sidebar .panel.details.css-style .content.has-filter-bar + .filter-bar): Deleted. (.sidebar .panel.details.css-style .content:not(.has-filter-bar) + .filter-bar): Deleted. * UserInterface/Views/CSSStyleDetailsSidebarPanel.js: (WebInspector.CSSStyleDetailsSidebarPanel): (WebInspector.CSSStyleDetailsSidebarPanel.prototype._switchPanels): (WebInspector.CSSStyleDetailsSidebarPanel.prototype._newRuleButtonClicked): * UserInterface/Views/RulesStyleDetailsPanel.css: (.sidebar .panel.details.css-style .rules .label): * UserInterface/Views/RulesStyleDetailsPanel.js: (WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel): (WebInspector.RulesStyleDetailsPanel.prototype.newRuleButtonClicked): (WebInspector.RulesStyleDetailsPanel.prototype.refresh.addNewRuleButton): Deleted. (WebInspector.RulesStyleDetailsPanel.prototype.refresh): Deleted. (WebInspector.RulesStyleDetailsPanel.prototype._newRuleClicked): Deleted. Modified Paths trunk/Source/WebInspectorUI/ChangeLog trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationSection.css trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDeclarationTextEditor.css trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.css trunk/Source/WebInspectorUI/UserInterface/Views/CSSStyleDetailsSidebarPanel.js trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.css trunk/Source/WebInspectorUI/UserInterface/Views/RulesStyleDetailsPanel.js Diff Modified: trunk/Source/WebInspectorUI/ChangeLog (188187 => 188188) --- trunk/Source/WebInspectorUI/ChangeLog 2015-08-08 05:39:06 UTC (rev 188187) +++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-08 05:39:26 UTC (rev 188188) @@ -1,5 +1,43 @@ 2015-08-07 Devin Rousso drou...@apple.com +Web Inspector: Decrease the padding of each rule in the Rules sidebar to allow more content to show +https://bugs.webkit.org/show_bug.cgi?id=147360 + +Reviewed by Timothy Hatcher. + +Generally tightened the padding around each section in the rules panel, as well as the +content inside each section. Also moved the new rule button to be next to the filter bar. + +* UserInterface/Views/CSSStyleDeclarationSection.css: +(.style-declaration-section): +(.style-declaration-section.last-in-group): +(.style-declaration-section.last-in-group + .style-declaration-section): Deleted. +* UserInterface/Views/CSSStyleDeclarationTextEditor.css: +(.css-style-text-editor): +* UserInterface/Views/CSSStyleDetailsSidebarPanel.css: +(.sidebar .panel.details.css-style .content .pseudo-classes): +(.sidebar .panel.details.css-style .content + .options-container): +(.sidebar .panel.details.css-style .content:not(.supports-new-rule, .has-filter-bar) + .options-container): +(.sidebar .panel.details.css-style .content + .options-container .new-rule): +(.sidebar .panel.details.css-style .content + .options-container .filter-bar): +(.sidebar .panel.details.css-style .content:not(.has-filter-bar) + .options-container .filter-bar): +(.sidebar .panel.details.css-style .content.has-filter-bar + .filter-bar): Deleted. +(.sidebar .panel.details.css-style .content:not(.has-filter-bar) + .filter-bar): Deleted. +* UserInterface/Views/CSSStyleDetailsSidebarPanel.js: +(WebInspector.CSSStyleDetailsSidebarPanel): +(WebInspector.CSSStyleDetailsSidebarPanel.prototype._switchPanels): +(WebInspector.CSSStyleDetailsSidebarPanel.prototype._newRuleButtonClicked): +
[webkit-changes] [188152] branches/safari-601.1.46-branch/Source/WebKit2
Title: [188152] branches/safari-601.1.46-branch/Source/WebKit2 Revision 188152 Author lforsch...@apple.com Date 2015-08-07 13:14:32 -0700 (Fri, 07 Aug 2015) Log Message Merged r188058. rdar://problem/22128839 Modified Paths branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188151 => 188152) --- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:13:06 UTC (rev 188151) +++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:14:32 UTC (rev 188152) @@ -1,5 +1,18 @@ 2015-08-07 Lucas Forschler lforsch...@apple.com +Merge r188058 + +2015-08-06 Enrica Casucci enr...@apple.com + +Build fix for iOS after http://trac.webkit.org/changeset/188053. + +Unreviewed. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView _registerPreview]): + +2015-08-07 Lucas Forschler lforsch...@apple.com + Merge r188053 2015-08-06 Enrica Casucci enr...@apple.com Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188151 => 188152) --- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:13:06 UTC (rev 188151) +++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:14:32 UTC (rev 188152) @@ -220,6 +220,10 @@ @end @protocol UISelectionInteractionAssistant; +@interface UIPreviewItemController (StagingToRemove) +@property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer; +@end + #endif @interface WKFormInputSession : NSObject _WKFormInputSession @@ -3221,7 +3225,8 @@ _previewItemController = adoptNS([[UIPreviewItemController alloc] initWithView:self]); [_previewItemController setDelegate:self]; _previewGestureRecognizer = _previewItemController.get().presentationGestureRecognizer; -_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer; +if ([_previewItemController respondsToSelector:@selector(presentationSecondaryGestureRecognizer)]) +_previewSecondaryGestureRecognizer = _previewItemController.get().presentationSecondaryGestureRecognizer; } - (void)_unregisterPreview ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188151] branches/safari-601.1.46-branch/Source/WebKit2
Title: [188151] branches/safari-601.1.46-branch/Source/WebKit2
Revision 188151
Author lforsch...@apple.com
Date 2015-08-07 13:13:06 -0700 (Fri, 07 Aug 2015)
Log Message
Merged r188053. rdar://problem/22128839
Modified Paths
branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h
branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188150 => 188151)
--- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:10:42 UTC (rev 188150)
+++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:13:06 UTC (rev 188151)
@@ -1,3 +1,27 @@
+2015-08-07 Lucas Forschler lforsch...@apple.com
+
+Merge r188053
+
+2015-08-06 Enrica Casucci enr...@apple.com
+
+Allow long press to cancel link preview.
+https://bugs.webkit.org/show_bug.cgi?id=147743
+rdar://problem/22128839
+
+Reviewed by Tim Horton.
+
+We should be able to show the context menu at the beginnig of link preview.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _removeDefaultGestureRecognizers]):
+(-[WKContentView _addDefaultGestureRecognizers]):
+(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
+(-[WKContentView _longPressRecognized:]):
+(-[WKContentView _singleTapRecognized:]):
+(-[WKContentView _registerPreview]):
+(-[WKContentView _unregisterPreview]):
+
2015-08-06 Babak Shafiei bshaf...@apple.com
Roll out r188053.
Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h (188150 => 188151)
--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h 2015-08-07 20:10:42 UTC (rev 188150)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h 2015-08-07 20:13:06 UTC (rev 188151)
@@ -121,6 +121,7 @@
RetainPtrWKFormInputSession _formInputSession;
RetainPtrWKFileUploadPanel _fileUploadPanel;
RetainPtrUIGestureRecognizer _previewGestureRecognizer;
+RetainPtrUIGestureRecognizer _previewSecondaryGestureRecognizer;
#if HAVE(LINK_PREVIEW)
RetainPtrUIPreviewItemController _previewItemController;
#endif
Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188150 => 188151)
--- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:10:42 UTC (rev 188150)
+++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:13:06 UTC (rev 188151)
@@ -416,7 +416,6 @@
[self removeGestureRecognizer:_touchEventGestureRecognizer.get()];
[self removeGestureRecognizer:_singleTapGestureRecognizer.get()];
[self removeGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
-[self removeGestureRecognizer:_longPressGestureRecognizer.get()];
[self removeGestureRecognizer:_doubleTapGestureRecognizer.get()];
[self removeGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
}
@@ -426,7 +425,6 @@
[self addGestureRecognizer:_touchEventGestureRecognizer.get()];
[self addGestureRecognizer:_singleTapGestureRecognizer.get()];
[self addGestureRecognizer:_highlightLongPressGestureRecognizer.get()];
-[self addGestureRecognizer:_longPressGestureRecognizer.get()];
[self addGestureRecognizer:_doubleTapGestureRecognizer.get()];
[self addGestureRecognizer:_twoFingerDoubleTapGestureRecognizer.get()];
}
@@ -876,6 +874,9 @@
if (isSamePair(gestureRecognizer, otherGestureRecognizer, _singleTapGestureRecognizer.get(), _textSelectionAssistant.get().singleTapGesture))
return YES;
+if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewSecondaryGestureRecognizer.get()))
+return YES;
+
if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _previewGestureRecognizer.get()))
return YES;
@@ -1076,21 +1077,25 @@
{
ASSERT(gestureRecognizer == _longPressGestureRecognizer);
-#if HAVE(LINK_PREVIEW)
-if ([_previewItemController interactionInProgress])
-return;
-#endif
-
_lastInteractionLocation = gestureRecognizer.startPoint;
-if ([gestureRecognizer state] == UIGestureRecognizerStateBegan) {
+switch ([gestureRecognizer state]) {
+case UIGestureRecognizerStateBegan:
+{
SEL action = "" _actionForLongPress];
if (action) {
[self performSelector:action];
[self _cancelLongPressGestureRecognizer];
-[UIApp
[webkit-changes] [188156] branches/safari-601.1.46-branch/Source/WebKit2
Title: [188156] branches/safari-601.1.46-branch/Source/WebKit2 Revision 188156 Author lforsch...@apple.com Date 2015-08-07 13:19:20 -0700 (Fri, 07 Aug 2015) Log Message Merged r188115. rdar://problem/22181735 Modified Paths branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp Diff Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188155 => 188156) --- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:17:49 UTC (rev 188155) +++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:19:20 UTC (rev 188156) @@ -1,5 +1,23 @@ 2015-08-07 Lucas Forschler lforsch...@apple.com +Merge r188115 + +2015-08-06 Beth Dakin bda...@apple.com + +TextIndicator can have stale contentImage data and crash +https://bugs.webkit.org/show_bug.cgi?id=147770 +-and corresponding- +rdar://problem/22181735 + +Reviewed by Tim Horton. + +If there is no contentImage or contentImageWithHighlight, set them to +nullptr. +* Shared/WebCoreArgumentCoders.cpp: +(IPC::ArgumentCoderTextIndicatorData::decode): + +2015-08-07 Lucas Forschler lforsch...@apple.com + Merge r188112 2015-08-06 Dan Bernstein m...@apple.com Modified: branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp (188155 => 188156) --- branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp 2015-08-07 20:17:49 UTC (rev 188155) +++ branches/safari-601.1.46-branch/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp 2015-08-07 20:19:20 UTC (rev 188156) @@ -2169,12 +2169,16 @@ bool hasImage; if (!decoder.decode(hasImage)) return false; +if (!hasImage) +textIndicatorData.contentImage = nullptr; if (hasImage !decodeImage(decoder, textIndicatorData.contentImage)) return false; bool hasImageWithHighlight; if (!decoder.decode(hasImageWithHighlight)) return false; +if (!hasImageWithHighlight) +textIndicatorData.contentImageWithHighlight = nullptr; if (hasImageWithHighlight !decodeImage(decoder, textIndicatorData.contentImageWithHighlight)) return false; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188166] trunk/Source/WebCore
Title: [188166] trunk/Source/WebCore
Revision 188166
Author za...@apple.com
Date 2015-08-07 14:44:56 -0700 (Fri, 07 Aug 2015)
Log Message
RenderTheme::volumeSliderOffsetFromMuteButton should take const RenderBox.
https://bugs.webkit.org/show_bug.cgi?id=147731
Reviewed by Simon Fraser.
No change in functionality.
* rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaVolumeSliderContainer::layout):
* rendering/RenderMediaControls.cpp:
(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Deleted.
* rendering/RenderMediaControls.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
* rendering/RenderTheme.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderMediaControlElements.cpp
trunk/Source/WebCore/rendering/RenderMediaControls.cpp
trunk/Source/WebCore/rendering/RenderMediaControls.h
trunk/Source/WebCore/rendering/RenderTheme.cpp
trunk/Source/WebCore/rendering/RenderTheme.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (188165 => 188166)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 21:37:40 UTC (rev 188165)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 21:44:56 UTC (rev 188166)
@@ -1,5 +1,23 @@
2015-08-07 Zalan Bujtas za...@apple.com
+RenderTheme::volumeSliderOffsetFromMuteButton should take const RenderBox.
+https://bugs.webkit.org/show_bug.cgi?id=147731
+
+Reviewed by Simon Fraser.
+
+No change in functionality.
+
+* rendering/RenderMediaControlElements.cpp:
+(WebCore::RenderMediaVolumeSliderContainer::layout):
+* rendering/RenderMediaControls.cpp:
+(WebCore::RenderMediaControls::volumeSliderOffsetFromMuteButton): Deleted.
+* rendering/RenderMediaControls.h:
+* rendering/RenderTheme.cpp:
+(WebCore::RenderTheme::volumeSliderOffsetFromMuteButton):
+* rendering/RenderTheme.h:
+
+2015-08-07 Zalan Bujtas za...@apple.com
+
Replace RenderObject::isRooted() logic with isDescendantOf().
https://bugs.webkit.org/show_bug.cgi?id=147788
Modified: trunk/Source/WebCore/rendering/RenderMediaControlElements.cpp (188165 => 188166)
--- trunk/Source/WebCore/rendering/RenderMediaControlElements.cpp 2015-08-07 21:37:40 UTC (rev 188165)
+++ trunk/Source/WebCore/rendering/RenderMediaControlElements.cpp 2015-08-07 21:44:56 UTC (rev 188166)
@@ -54,7 +54,7 @@
// If the slider would be rendered outside the page, it should be moved below the controls.
if (UNLIKELY(absoluteOffsetTop 0))
-setY(buttonBox.offsetTop() + theme().volumeSliderOffsetFromMuteButton(buttonBox, pixelSnappedSize()).y());
+setY(buttonBox.offsetTop() + theme().volumeSliderOffsetFromMuteButton(buttonBox, pixelSnappedSize()).y());
}
//
Modified: trunk/Source/WebCore/rendering/RenderMediaControls.cpp (188165 => 188166)
--- trunk/Source/WebCore/rendering/RenderMediaControls.cpp 2015-08-07 21:37:40 UTC (rev 188165)
+++ trunk/Source/WebCore/rendering/RenderMediaControls.cpp 2015-08-07 21:44:56 UTC (rev 188166)
@@ -220,19 +220,6 @@
#endif
-IntPoint RenderMediaControls::volumeSliderOffsetFromMuteButton(RenderBox* muteButtonBox, const IntSize size)
-{
-static const int xOffset = -4;
-static const int yOffset = 5;
-
-float zoomLevel = muteButtonBox-style().effectiveZoom();
-int y = yOffset * zoomLevel + muteButtonBox-pixelSnappedOffsetHeight() - size.height();
-FloatPoint absPoint = muteButtonBox-localToAbsolute(FloatPoint(muteButtonBox-pixelSnappedOffsetLeft(), y), IsFixed | UseTransforms);
-if (absPoint.y() 0)
-y = muteButtonBox-pixelSnappedSize().height();
-return IntPoint(xOffset * zoomLevel, y);
}
-}
-
#endif
Modified: trunk/Source/WebCore/rendering/RenderMediaControls.h (188165 => 188166)
--- trunk/Source/WebCore/rendering/RenderMediaControls.h 2015-08-07 21:37:40 UTC (rev 188165)
+++ trunk/Source/WebCore/rendering/RenderMediaControls.h 2015-08-07 21:44:56 UTC (rev 188166)
@@ -48,7 +48,6 @@
static bool paintMediaControlsPart(MediaControlElementType, const RenderObject, const PaintInfo, const IntRect);
static void adjustMediaSliderThumbSize(RenderStyle);
#endif
-static IntPoint volumeSliderOffsetFromMuteButton(RenderBox*, const IntSize);
};
} // namespace WebCore
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (188165 => 188166)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-08-07 21:37:40 UTC (rev 188165)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2015-08-07 21:44:56 UTC (rev 188166)
@@ -552,12 +552,12 @@
return formatMediaControlsTime(currentTime - duration);
}
-IntPoint RenderTheme::volumeSliderOffsetFromMuteButton(RenderBox* muteButtonBox, const IntSize size) const
+IntPoint RenderTheme::volumeSliderOffsetFromMuteButton(const RenderBox muteButtonBox, const IntSize size) const
{
int y = -size.height();
-FloatPoint absPoint =
[webkit-changes] [188168] trunk/Source/WebCore
Title: [188168] trunk/Source/WebCore
Revision 188168
Author mmaxfi...@apple.com
Date 2015-08-07 14:55:17 -0700 (Fri, 07 Aug 2015)
Log Message
Post-review comments on r188146
https://bugs.webkit.org/show_bug.cgi?id=147793
Reviewed by Daniel Bates.
No new tests because there is no behavior change.
* platform/graphics/FontCache.h:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::appendTrueTypeFeature):
(WebCore::appendOpenTypeFeature):
(WebCore::applyFontFeatureSettings):
* platform/graphics/ios/FontCacheIOS.mm:
(WebCore::FontCache::getSystemFontFallbackForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::fontWithFamily):
(WebCore::FontCache::systemFallbackForCharacters):
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm
trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm
trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp
trunk/Source/WebCore/rendering/RenderThemeIOS.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (188167 => 188168)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 21:49:42 UTC (rev 188167)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 21:55:17 UTC (rev 188168)
@@ -1,5 +1,30 @@
2015-08-07 Myles C. Maxfield mmaxfi...@apple.com
+Post-review comments on r188146
+https://bugs.webkit.org/show_bug.cgi?id=147793
+
+Reviewed by Daniel Bates.
+
+No new tests because there is no behavior change.
+
+* platform/graphics/FontCache.h:
+* platform/graphics/cocoa/FontCacheCoreText.cpp:
+(WebCore::appendTrueTypeFeature):
+(WebCore::appendOpenTypeFeature):
+(WebCore::applyFontFeatureSettings):
+* platform/graphics/ios/FontCacheIOS.mm:
+(WebCore::FontCache::getSystemFontFallbackForCharacters):
+(WebCore::FontCache::createFontPlatformData):
+* platform/graphics/mac/FontCacheMac.mm:
+(WebCore::fontWithFamily):
+(WebCore::FontCache::systemFallbackForCharacters):
+* platform/graphics/mac/FontCustomPlatformData.cpp:
+(WebCore::FontCustomPlatformData::fontPlatformData):
+* rendering/RenderThemeIOS.mm:
+(WebCore::RenderThemeIOS::updateCachedSystemFontDescription):
+
+2015-08-07 Myles C. Maxfield mmaxfi...@apple.com
+
[Cocoa] Font fallback is not language-sensitive
https://bugs.webkit.org/show_bug.cgi?id=147390
Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (188167 => 188168)
--- trunk/Source/WebCore/platform/graphics/FontCache.h 2015-08-07 21:49:42 UTC (rev 188167)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h 2015-08-07 21:55:17 UTC (rev 188168)
@@ -215,7 +215,7 @@
};
#if PLATFORM(COCOA)
-RetainPtrCTFontRef applyFontFeatureSettings(CTFontRef, const FontFeatureSettings);
+RetainPtrCTFontRef applyFontFeatureSettings(CTFontRef, const FontFeatureSettings*);
#endif
#if !PLATFORM(MAC)
Modified: trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp (188167 => 188168)
--- trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2015-08-07 21:49:42 UTC (rev 188167)
+++ trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp 2015-08-07 21:55:17 UTC (rev 188168)
@@ -28,11 +28,9 @@
namespace WebCore {
-static inline void appendTrueTypeFeature(CFMutableArrayRef features, const FontFeature feature)
+static inline void appendTrueTypeFeature(CFMutableArrayRef, const FontFeature)
{
-// FIXME: We should map OpenType feature strings to the TrueType feature type identifiers listed in CoreText/SFNTLayoutTypes.h
-UNUSED_PARAM(features);
-UNUSED_PARAM(feature);
+// FIXME: We should map OpenType feature strings to the TrueType feature type identifiers listed in CoreText/SFNTLayoutTypes.h.
}
static inline void appendOpenTypeFeature(CFMutableArrayRef features, const FontFeature feature)
@@ -41,9 +39,9 @@
RetainPtrCFStringRef featureKey = feature.tag().string().createCFString();
int rawFeatureValue = feature.value();
RetainPtrCFNumberRef featureValue = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberIntType, rawFeatureValue));
-CFStringRef featureDictionaryKeys[] = {kCTFontOpenTypeFeatureTag, kCTFontOpenTypeFeatureValue};
-CFTypeRef featureDictionaryValues[] = {featureKey.get(), featureValue.get()};
-RetainPtrCFDictionaryRef featureDictionary = adoptCF(CFDictionaryCreate(kCFAllocatorDefault, (const void**)featureDictionaryKeys, featureDictionaryValues, 2, kCFTypeDictionaryKeyCallBacks, kCFTypeDictionaryValueCallBacks));
+CFStringRef featureDictionaryKeys[] = {
[webkit-changes] [188163] trunk/Source/WebCore
Title: [188163] trunk/Source/WebCore
Revision 188163
Author za...@apple.com
Date 2015-08-07 14:25:34 -0700 (Fri, 07 Aug 2015)
Log Message
Subtree layout code should use RenderElement.
https://bugs.webkit.org/show_bug.cgi?id=147694
Reviewed by Simon Fraser.
Subtree layout will never begin at a RenderText, so tighten up
the code to operate on RenderElements instead of RenderObjects.
(This patch is based on webkit.org/b/126878)
No change in functionality.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willLayout):
* page/FrameView.cpp:
(WebCore::FrameView::FrameView): Deleted.
(WebCore::FrameView::layoutRoot): Deleted.
* page/FrameView.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
* rendering/RenderElement.cpp:
(WebCore::RenderElement::clearLayoutRootIfNeeded):
(WebCore::RenderElement::willBeDestroyed):
* rendering/RenderElement.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::clearLayoutRootIfNeeded): Deleted.
(WebCore::RenderObject::willBeDestroyed): Deleted.
* rendering/RenderObject.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/page/FrameView.h
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (188162 => 188163)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 21:12:47 UTC (rev 188162)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 21:25:34 UTC (rev 188163)
@@ -1,3 +1,33 @@
+2015-08-07 Zalan Bujtas za...@apple.com
+
+Subtree layout code should use RenderElement.
+https://bugs.webkit.org/show_bug.cgi?id=147694
+
+Reviewed by Simon Fraser.
+
+Subtree layout will never begin at a RenderText, so tighten up
+the code to operate on RenderElements instead of RenderObjects.
+(This patch is based on webkit.org/b/126878)
+
+No change in functionality.
+
+* inspector/InspectorTimelineAgent.cpp:
+(WebCore::InspectorTimelineAgent::willLayout):
+* page/FrameView.cpp:
+(WebCore::FrameView::FrameView): Deleted.
+(WebCore::FrameView::layoutRoot): Deleted.
+* page/FrameView.h:
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::computeLogicalWidthInRegion):
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::clearLayoutRootIfNeeded):
+(WebCore::RenderElement::willBeDestroyed):
+* rendering/RenderElement.h:
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::clearLayoutRootIfNeeded): Deleted.
+(WebCore::RenderObject::willBeDestroyed): Deleted.
+* rendering/RenderObject.h:
+
2015-08-07 Wenson Hsieh wenson_hs...@apple.com
Temporarily allow programmatic input assistance for adding Gmail account
Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (188162 => 188163)
--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-08-07 21:12:47 UTC (rev 188162)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-08-07 21:25:34 UTC (rev 188163)
@@ -349,7 +349,7 @@
void InspectorTimelineAgent::willLayout(Frame frame)
{
-RenderObject* root = frame.view()-layoutRoot();
+auto* root = frame.view()-layoutRoot();
bool partialLayout = !!root;
if (!partialLayout)
Modified: trunk/Source/WebCore/page/FrameView.cpp (188162 => 188163)
--- trunk/Source/WebCore/page/FrameView.cpp 2015-08-07 21:12:47 UTC (rev 188162)
+++ trunk/Source/WebCore/page/FrameView.cpp 2015-08-07 21:25:34 UTC (rev 188163)
@@ -164,7 +164,6 @@
: m_frame(frame)
, m_canHaveScrollbars(true)
, m_layoutTimer(*this, FrameView::layoutTimerFired)
-, m_layoutRoot(nullptr)
, m_layoutPhase(OutsideLayout)
, m_inSynchronousPostLayout(false)
, m_postLayoutTasksTimer(*this, FrameView::performPostLayoutTasks)
@@ -1129,11 +1128,6 @@
renderView-setIsInWindow(isInWindow);
}
-RenderObject* FrameView::layoutRoot(bool onlyDuringLayout) const
-{
-return onlyDuringLayout layoutPending() ? nullptr : m_layoutRoot;
-}
-
inline void FrameView::forceLayoutParentViewIfNeeded()
{
RenderWidget* ownerRenderer = frame().ownerRenderer();
Modified: trunk/Source/WebCore/page/FrameView.h (188162 => 188163)
--- trunk/Source/WebCore/page/FrameView.h 2015-08-07 21:12:47 UTC (rev 188162)
+++ trunk/Source/WebCore/page/FrameView.h 2015-08-07 21:25:34 UTC (rev 188163)
@@ -117,7 +117,7 @@
bool isInLayout() const { return m_layoutPhase == InLayout; }
WEBCORE_EXPORT bool inPaintableState() { return m_layoutPhase != InLayout m_layoutPhase != InViewSizeAdjust m_layoutPhase != InPostLayout; }
-RenderObject* layoutRoot(bool _onlyDuringLayout_ =
[webkit-changes] [188164] trunk/Source/WebCore
Title: [188164] trunk/Source/WebCore
Revision 188164
Author za...@apple.com
Date 2015-08-07 14:30:35 -0700 (Fri, 07 Aug 2015)
Log Message
Replace RenderObject::isRooted() logic with isDescendantOf().
https://bugs.webkit.org/show_bug.cgi?id=147788
Reviewed by Simon Fraser.
And some related cleanups.
No change in functionality.
* page/FrameView.cpp:
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::extendedBackgroundRectForPainting):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::paintRootBoxFillLayers):
* rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::isDescendantOf):
(WebCore::scheduleRelayoutForSubtree):
(WebCore::RenderObject::repaint):
(WebCore::RenderObject::repaintRectangle):
(WebCore::RenderObject::repaintSlowRepaintObject):
(WebCore::RenderObject::isRooted):
* rendering/RenderObject.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::unextendedBackgroundRect):
(WebCore::RenderView::backgroundRect):
* rendering/RenderView.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/FrameView.cpp
trunk/Source/WebCore/rendering/RenderBox.cpp
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderObject.cpp
trunk/Source/WebCore/rendering/RenderObject.h
trunk/Source/WebCore/rendering/RenderView.cpp
trunk/Source/WebCore/rendering/RenderView.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (188163 => 188164)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 21:25:34 UTC (rev 188163)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 21:30:35 UTC (rev 188164)
@@ -1,5 +1,36 @@
2015-08-07 Zalan Bujtas za...@apple.com
+Replace RenderObject::isRooted() logic with isDescendantOf().
+https://bugs.webkit.org/show_bug.cgi?id=147788
+
+Reviewed by Simon Fraser.
+
+And some related cleanups.
+
+No change in functionality.
+
+* page/FrameView.cpp:
+(WebCore::FrameView::scheduleRelayoutOfSubtree):
+(WebCore::FrameView::extendedBackgroundRectForPainting):
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::paintRootBoxFillLayers):
+* rendering/RenderElement.cpp:
+(WebCore::shouldRepaintForImageAnimation):
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::isDescendantOf):
+(WebCore::scheduleRelayoutForSubtree):
+(WebCore::RenderObject::repaint):
+(WebCore::RenderObject::repaintRectangle):
+(WebCore::RenderObject::repaintSlowRepaintObject):
+(WebCore::RenderObject::isRooted):
+* rendering/RenderObject.h:
+* rendering/RenderView.cpp:
+(WebCore::RenderView::unextendedBackgroundRect):
+(WebCore::RenderView::backgroundRect):
+* rendering/RenderView.h:
+
+2015-08-07 Zalan Bujtas za...@apple.com
+
Subtree layout code should use RenderElement.
https://bugs.webkit.org/show_bug.cgi?id=147694
Modified: trunk/Source/WebCore/page/FrameView.cpp (188163 => 188164)
--- trunk/Source/WebCore/page/FrameView.cpp 2015-08-07 21:25:34 UTC (rev 188163)
+++ trunk/Source/WebCore/page/FrameView.cpp 2015-08-07 21:30:35 UTC (rev 188164)
@@ -2581,7 +2581,7 @@
void FrameView::scheduleRelayoutOfSubtree(RenderElement newRelayoutRoot)
{
ASSERT(renderView());
-RenderView renderView = *this-renderView();
+const RenderView renderView = *this-renderView();
// Try to catch unnecessary work during render tree teardown.
ASSERT(!renderView.documentBeingDestroyed());
@@ -2879,7 +2879,7 @@
if (!renderView)
return IntRect();
-LayoutRect extendedRect = renderView-unextendedBackgroundRect(renderView);
+LayoutRect extendedRect = renderView-unextendedBackgroundRect();
if (!tiledBacking-hasMargins())
return snappedIntRect(extendedRect);
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (188163 => 188164)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2015-08-07 21:25:34 UTC (rev 188163)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2015-08-07 21:30:35 UTC (rev 188164)
@@ -1249,7 +1249,7 @@
const FillLayer* bgLayer = rootBackgroundRenderer.style().backgroundLayers();
Color bgColor = rootBackgroundRenderer.style().visitedDependentColor(CSSPropertyBackgroundColor);
-paintFillLayers(paintInfo, bgColor, bgLayer, view().backgroundRect(this), BackgroundBleedNone, CompositeSourceOver, rootBackgroundRenderer);
+paintFillLayers(paintInfo, bgColor, bgLayer, view().backgroundRect(), BackgroundBleedNone, CompositeSourceOver, rootBackgroundRenderer);
}
BackgroundBleedAvoidance RenderBox::determineBackgroundBleedAvoidance(GraphicsContext* context) const
Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (188163 => 188164)
--- trunk/Source/WebCore/rendering/RenderElement.cpp 2015-08-07 21:25:34 UTC (rev 188163)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp 2015-08-07 21:30:35 UTC
[webkit-changes] [188165] branches/safari-601.1.46-branch/Source/WebCore
Title: [188165] branches/safari-601.1.46-branch/Source/WebCore
Revision 188165
Author bshaf...@apple.com
Date 2015-08-07 14:37:40 -0700 (Fri, 07 Aug 2015)
Log Message
Merged r188150. rdar://problem/22123707
Modified Paths
branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.cpp
branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.h
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedRawResource.cpp
branches/safari-601.1.46-branch/Source/WebCore/loader/cache/CachedRawResourceClient.h
Diff
Modified: branches/safari-601.1.46-branch/Source/WebCore/ChangeLog (188164 => 188165)
--- branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-08-07 21:30:35 UTC (rev 188164)
+++ branches/safari-601.1.46-branch/Source/WebCore/ChangeLog 2015-08-07 21:37:40 UTC (rev 188165)
@@ -1,3 +1,35 @@
+2015-08-07 Babak Shafiei bshaf...@apple.com
+
+Merge r188150.
+
+2015-08-07 Andy Estes aes...@apple.com
+
+Crash when following a Google search link to Twitter with Limit Adult Content enabled
+https://bugs.webkit.org/show_bug.cgi?id=147651
+
+Reviewed by Brady Eidson.
+
+When a loaded CachedRawResource gets a new client, it synthesizes the callbacks that the new client would have
+received while the resource was loading. Unlike a real network load, it synthesizes these callbacks in a single
+run loop iteration. When DocumentLoader receives a redirect, and finds substitute data in the app cache for the
+redirect URL, it schedules a timer that removes DocumentLoader as a client of the CachedRawResource then
+synthesizes its own set of CachedRawResourceClient callbacks. But since CachedRawResource has already delivered
+client callbacks before the app cache timer fires, DocumentLoader unexpectedly ends up getting two sets of
+client callbacks and badness ensues.
+
+The fix is to let CachedRawResource detect if a redirect will trigger the client to load substitute data. If so,
+stop delivering client callbacks.
+
+Layout test to follow.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::syntheticRedirectReceived): If there is valid substitute data, do not continue.
+* loader/DocumentLoader.h:
+* loader/cache/CachedRawResource.cpp: Returned early if syntheticRedirectReceived() said not to continue.
+(WebCore::CachedRawResource::didAddClient):
+* loader/cache/CachedRawResourceClient.h:
+(WebCore::CachedRawResourceClient::syntheticRedirectReceived):
+
2015-08-06 Babak Shafiei bshaf...@apple.com
Merge r188062.
Modified: branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.cpp (188164 => 188165)
--- branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.cpp 2015-08-07 21:30:35 UTC (rev 188164)
+++ branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.cpp 2015-08-07 21:37:40 UTC (rev 188165)
@@ -489,6 +489,14 @@
willSendRequest(request, redirectResponse);
}
+void DocumentLoader::syntheticRedirectReceived(CachedResource* resource, ResourceRequest request, const ResourceResponse redirectResponse, bool shouldContinue)
+{
+redirectReceived(resource, request, redirectResponse);
+
+// If we will soon remove our reference to the CachedRawResource in favor of a SubstituteData load, we don't want to continue receiving synthetic CachedRawResource callbacks.
+shouldContinue = !m_substituteData.isValid();
+}
+
void DocumentLoader::willSendRequest(ResourceRequest newRequest, const ResourceResponse redirectResponse)
{
// Note that there are no asserts here as there are for the other callbacks. This is due to the
Modified: branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.h (188164 => 188165)
--- branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.h 2015-08-07 21:30:35 UTC (rev 188164)
+++ branches/safari-601.1.46-branch/Source/WebCore/loader/DocumentLoader.h 2015-08-07 21:37:40 UTC (rev 188165)
@@ -306,6 +306,7 @@
void finishedLoading(double finishTime);
void mainReceivedError(const ResourceError);
WEBCORE_EXPORT virtual void redirectReceived(CachedResource*, ResourceRequest, const ResourceResponse) override;
+WEBCORE_EXPORT virtual void syntheticRedirectReceived(CachedResource*, ResourceRequest, const ResourceResponse, bool /* shouldContinue */) override;
WEBCORE_EXPORT virtual void responseReceived(CachedResource*, const ResourceResponse) override;
WEBCORE_EXPORT virtual void dataReceived(CachedResource*, const char* data, int length) override;
WEBCORE_EXPORT virtual void notifyFinished(CachedResource*) override;
Modified:
[webkit-changes] [188167] trunk
Title: [188167] trunk Revision 188167 Author mmaxfi...@apple.com Date 2015-08-07 14:49:42 -0700 (Fri, 07 Aug 2015) Log Message Source/WebCore: [Cocoa] Font fallback is not language-sensitive https://bugs.webkit.org/show_bug.cgi?id=147390 Reviewed by Dean Jackson. We need to make our font fallback code sensitive to locale. This patch rolls r187729 back in. However, only particular versions of iOS and OS X are performant enough to enable this language-sensitivity. This patch also applies to iOS. Test: fast/text/fallback-language-han.html * platform/graphics/mac/FontCacheMac.mm: (WebCore::lookupCTFont): (WebCore::FontCache::systemFallbackForCharacters): * platform/graphics/mac/FontCacheIOS.mm: (WebCore::FontCache::systemFallbackForCharacters): LayoutTests: [OS X] Font fallback is not language-sensitive https://bugs.webkit.org/show_bug.cgi?id=147390 Reviewed by Dean Jackson. This test is expected to fail most places. * fast/text/fallback-language-han-expected.html: Added. * fast/text/fallback-language-han.html: Added. * platform/efl/TestExpectations: * platform/gtk/TestExpectations: * platform/win/TestExpectations: * platform/mac/TestExpectations: * platform/iOS/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/ios-simulator/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/win/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/ios/FontCacheIOS.mm trunk/Source/WebCore/platform/graphics/mac/FontCacheMac.mm Added Paths trunk/LayoutTests/fast/text/fallback-language-han-expected.html trunk/LayoutTests/fast/text/fallback-language-han.html Diff Modified: trunk/LayoutTests/ChangeLog (188166 => 188167) --- trunk/LayoutTests/ChangeLog 2015-08-07 21:44:56 UTC (rev 188166) +++ trunk/LayoutTests/ChangeLog 2015-08-07 21:49:42 UTC (rev 188167) @@ -1,3 +1,20 @@ +2015-08-07 Myles C. Maxfield mmaxfi...@apple.com + +[OS X] Font fallback is not language-sensitive +https://bugs.webkit.org/show_bug.cgi?id=147390 + +Reviewed by Dean Jackson. + +This test is expected to fail most places. + +* fast/text/fallback-language-han-expected.html: Added. +* fast/text/fallback-language-han.html: Added. +* platform/efl/TestExpectations: +* platform/gtk/TestExpectations: +* platform/win/TestExpectations: +* platform/mac/TestExpectations: +* platform/iOS/TestExpectations: + 2015-08-07 Simon Fraser simon.fra...@apple.com Move platform/mac/fast/scrolling/ tests into fast/scrolling/latching/ Added: trunk/LayoutTests/fast/text/fallback-language-han-expected.html (0 => 188167) --- trunk/LayoutTests/fast/text/fallback-language-han-expected.html (rev 0) +++ trunk/LayoutTests/fast/text/fallback-language-han-expected.html 2015-08-07 21:49:42 UTC (rev 188167) @@ -0,0 +1,17 @@ +!DOCTYPE html +html +head +meta charset=utf-8 +/head +body +This test makes sure that the lang attribute is properly consulted when using fallback fonts. The first character +is shown with a lang which represents Simplified Chinese, and the second character is shown with a lang which +represents Traditional Chinese. The character is one which is drawn differently in the two languages, so the +two characters should look different. This tests against a hardcoded font selection which should be the result of +FontCache::systemFallbackForCharacters(). +div style=font: 200px Times; +span lang=zh-Hans style=font-family: STSongti-SC-Regular;#x9ad4;/span +span lang=zh-Hant style=font-family: STSongti-TC-Regular;#x9ad4;/span +/div +/body +/html Added: trunk/LayoutTests/fast/text/fallback-language-han.html (0 => 188167) --- trunk/LayoutTests/fast/text/fallback-language-han.html (rev 0) +++ trunk/LayoutTests/fast/text/fallback-language-han.html 2015-08-07 21:49:42 UTC (rev 188167) @@ -0,0 +1,16 @@ +!DOCTYPE html +html +head +/head +body +This test makes sure that the lang attribute is properly consulted when using fallback fonts. The first character +is shown with a lang which represents Simplified Chinese, and the second character is shown with a lang which +represents Traditional Chinese. The character is one which is drawn differently in the two languages, so the +two characters should look different. This tests against a hardcoded font selection which should be the result of +FontCache::systemFallbackForCharacters(). +div style=font: 200px Times; +span lang=zh-Hans#x9ad4;/span +span lang=zh-Hant#x9ad4;/span +/div +/body +/html Modified: trunk/LayoutTests/platform/efl/TestExpectations (188166 => 188167) --- trunk/LayoutTests/platform/efl/TestExpectations 2015-08-07 21:44:56 UTC (rev 188166) +++ trunk/LayoutTests/platform/efl/TestExpectations 2015-08-07 21:49:42 UTC (rev 188167) @@ -2250,3
[webkit-changes] [188150] trunk/Source/WebCore
Title: [188150] trunk/Source/WebCore
Revision 188150
Author aes...@apple.com
Date 2015-08-07 13:10:42 -0700 (Fri, 07 Aug 2015)
Log Message
Crash when following a Google search link to Twitter with Limit Adult Content enabled
https://bugs.webkit.org/show_bug.cgi?id=147651
Reviewed by Brady Eidson.
When a loaded CachedRawResource gets a new client, it synthesizes the callbacks that the new client would have
received while the resource was loading. Unlike a real network load, it synthesizes these callbacks in a single
run loop iteration. When DocumentLoader receives a redirect, and finds substitute data in the app cache for the
redirect URL, it schedules a timer that removes DocumentLoader as a client of the CachedRawResource then
synthesizes its own set of CachedRawResourceClient callbacks. But since CachedRawResource has already delivered
client callbacks before the app cache timer fires, DocumentLoader unexpectedly ends up getting two sets of
client callbacks and badness ensues.
The fix is to let CachedRawResource detect if a redirect will trigger the client to load substitute data. If so,
stop delivering client callbacks.
Layout test to follow.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::syntheticRedirectReceived): If there is valid substitute data, do not continue.
* loader/DocumentLoader.h:
* loader/cache/CachedRawResource.cpp: Returned early if syntheticRedirectReceived() said not to continue.
(WebCore::CachedRawResource::didAddClient):
* loader/cache/CachedRawResourceClient.h:
(WebCore::CachedRawResourceClient::syntheticRedirectReceived):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebCore/loader/cache/CachedRawResource.cpp
trunk/Source/WebCore/loader/cache/CachedRawResourceClient.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (188149 => 188150)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 20:06:24 UTC (rev 188149)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 20:10:42 UTC (rev 188150)
@@ -1,3 +1,31 @@
+2015-08-07 Andy Estes aes...@apple.com
+
+Crash when following a Google search link to Twitter with Limit Adult Content enabled
+https://bugs.webkit.org/show_bug.cgi?id=147651
+
+Reviewed by Brady Eidson.
+
+When a loaded CachedRawResource gets a new client, it synthesizes the callbacks that the new client would have
+received while the resource was loading. Unlike a real network load, it synthesizes these callbacks in a single
+run loop iteration. When DocumentLoader receives a redirect, and finds substitute data in the app cache for the
+redirect URL, it schedules a timer that removes DocumentLoader as a client of the CachedRawResource then
+synthesizes its own set of CachedRawResourceClient callbacks. But since CachedRawResource has already delivered
+client callbacks before the app cache timer fires, DocumentLoader unexpectedly ends up getting two sets of
+client callbacks and badness ensues.
+
+The fix is to let CachedRawResource detect if a redirect will trigger the client to load substitute data. If so,
+stop delivering client callbacks.
+
+Layout test to follow.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::syntheticRedirectReceived): If there is valid substitute data, do not continue.
+* loader/DocumentLoader.h:
+* loader/cache/CachedRawResource.cpp: Returned early if syntheticRedirectReceived() said not to continue.
+(WebCore::CachedRawResource::didAddClient):
+* loader/cache/CachedRawResourceClient.h:
+(WebCore::CachedRawResourceClient::syntheticRedirectReceived):
+
2015-08-06 Dean Jackson d...@apple.com
Shadows don't draw on fillText when using a gradient fill
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (188149 => 188150)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-08-07 20:06:24 UTC (rev 188149)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-08-07 20:10:42 UTC (rev 188150)
@@ -489,6 +489,14 @@
willSendRequest(request, redirectResponse);
}
+void DocumentLoader::syntheticRedirectReceived(CachedResource* resource, ResourceRequest request, const ResourceResponse redirectResponse, bool shouldContinue)
+{
+redirectReceived(resource, request, redirectResponse);
+
+// If we will soon remove our reference to the CachedRawResource in favor of a SubstituteData load, we don't want to continue receiving synthetic CachedRawResource callbacks.
+shouldContinue = !m_substituteData.isValid();
+}
+
void DocumentLoader::willSendRequest(ResourceRequest newRequest, const ResourceResponse redirectResponse)
{
// Note that there are no asserts here as there are for the other callbacks. This is due to the
Modified: trunk/Source/WebCore/loader/DocumentLoader.h (188149 => 188150)
---
[webkit-changes] [188161] trunk/Tools
Title: [188161] trunk/Tools
Revision 188161
Author ander...@apple.com
Date 2015-08-07 14:12:16 -0700 (Fri, 07 Aug 2015)
Log Message
Fix a tyop.
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::viewSupportsOptions):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm
Diff
Modified: trunk/Tools/ChangeLog (188160 => 188161)
--- trunk/Tools/ChangeLog 2015-08-07 21:07:55 UTC (rev 188160)
+++ trunk/Tools/ChangeLog 2015-08-07 21:12:16 UTC (rev 188161)
@@ -1,3 +1,10 @@
+2015-08-07 Anders Carlsson ander...@apple.com
+
+Fix a tyop.
+
+* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+(WTR::PlatformWebView::viewSupportsOptions):
+
2015-08-07 Alexey Proskuryakov a...@apple.com
Update AppEngine app version numbers to the latest commit.
Modified: trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm (188160 => 188161)
--- trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm 2015-08-07 21:07:55 UTC (rev 188160)
+++ trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm 2015-08-07 21:12:16 UTC (rev 188161)
@@ -225,7 +225,7 @@
return 0; // FIXME for iOS?
}
-bool PlatformWebView::viewSupportsOptions(cost ViewOptions options) const
+bool PlatformWebView::viewSupportsOptions(const ViewOptions options) const
{
if (m_options.useTiledDrawing != options.useTiledDrawing)
return false;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188169] trunk
Title: [188169] trunk Revision 188169 Author fpi...@apple.com Date 2015-08-07 15:38:59 -0700 (Fri, 07 Aug 2015) Log Message Lightweight locks should be adaptive https://bugs.webkit.org/show_bug.cgi?id=147545 Reviewed by Geoffrey Garen. Source/_javascript_Core: * dfg/DFGCommon.cpp: (JSC::DFG::startCrashing): * heap/CopiedBlock.h: (JSC::CopiedBlock::workListLock): * heap/CopiedBlockInlines.h: (JSC::CopiedBlock::shouldReportLiveBytes): (JSC::CopiedBlock::reportLiveBytes): * heap/CopiedSpace.cpp: (JSC::CopiedSpace::doneFillingBlock): * heap/CopiedSpace.h: (JSC::CopiedSpace::CopiedGeneration::CopiedGeneration): * heap/CopiedSpaceInlines.h: (JSC::CopiedSpace::recycleEvacuatedBlock): * heap/GCThreadSharedData.cpp: (JSC::GCThreadSharedData::didStartCopying): * heap/GCThreadSharedData.h: (JSC::GCThreadSharedData::getNextBlocksToCopy): * heap/ListableHandler.h: (JSC::ListableHandler::List::addThreadSafe): (JSC::ListableHandler::List::addNotThreadSafe): * heap/MachineStackMarker.cpp: (JSC::MachineThreads::tryCopyOtherThreadStacks): * heap/SlotVisitorInlines.h: (JSC::SlotVisitor::copyLater): * parser/SourceProvider.cpp: (JSC::SourceProvider::~SourceProvider): (JSC::SourceProvider::getID): * profiler/ProfilerDatabase.cpp: (JSC::Profiler::Database::addDatabaseToAtExit): (JSC::Profiler::Database::removeDatabaseFromAtExit): (JSC::Profiler::Database::removeFirstAtExitDatabase): * runtime/TypeProfilerLog.h: Source/WebCore: * bindings/objc/WebScriptObject.mm: (WebCore::getJSWrapper): (WebCore::addJSWrapper): (WebCore::removeJSWrapper): (WebCore::removeJSWrapperIfRetainCountOne): * platform/audio/mac/CARingBuffer.cpp: (WebCore::CARingBuffer::setCurrentFrameBounds): (WebCore::CARingBuffer::getCurrentFrameBounds): * platform/audio/mac/CARingBuffer.h: * platform/ios/wak/WAKWindow.mm: (-[WAKWindow setExposedScrollViewRect:]): (-[WAKWindow exposedScrollViewRect]): Source/WebKit2: * WebProcess/WebPage/EventDispatcher.cpp: (WebKit::EventDispatcher::clearQueuedTouchEventsForPage): (WebKit::EventDispatcher::getQueuedTouchEventsForPage): (WebKit::EventDispatcher::touchEvent): (WebKit::EventDispatcher::dispatchTouchEvents): * WebProcess/WebPage/EventDispatcher.h: * WebProcess/WebPage/ViewUpdateDispatcher.cpp: (WebKit::ViewUpdateDispatcher::visibleContentRectUpdate): (WebKit::ViewUpdateDispatcher::dispatchVisibleContentRectUpdate): * WebProcess/WebPage/ViewUpdateDispatcher.h: Source/WTF: A common idiom in WebKit is to use spinlocks. We use them because the lock acquisition overhead is lower than system locks and because they take dramatically less space than system locks. The speed and space advantages of spinlocks can be astonishing: an uncontended spinlock acquire is up to 10x faster and under microcontention - short critical section with two or more threads taking turns - spinlocks are up to 100x faster. Spinlocks take only 1 byte or 4 bytes depending on the flavor, while system locks take 64 bytes or more. Clearly, WebKit should continue to avoid system locks - they are just far too slow and far too big. But there is a problem with this idiom. System lock implementations will sleep a thread when it attempts to acquire a lock that is held, while spinlocks will cause the thread to burn CPU. In WebKit spinlocks, the thread will repeatedly call sched_yield(). This is awesome for microcontention, but awful when the lock will not be released for a while. In fact, when critical sections take tens of microseconds or more, the CPU time cost of our spinlocks is almost 100x more than the CPU time cost of a system lock. This case doesn't arise too frequently in our current uses of spinlocks, but that's probably because right now there are places where we make a conscious decision to use system locks - even though they use more memory and are slower - because we don't want to waste CPU cycles when a thread has to wait a while to acquire the lock. The solution is to just implement a modern adaptive mutex in WTF. Luckily, this isn't a new concept. This patch implements a mutex that is reminiscent of the kinds of low-overhead locks that JVMs use. The actual implementation here is inspired by some of the ideas from [1]. The idea is simple: the fast path is an inlined CAS to immediately acquire a lock that isn't held, the slow path tries some number of spins to acquire the lock, and if that fails, the thread is put on a queue and put to sleep. The queue is made up of statically allocated thread nodes and the lock itself is a tagged pointer: either it is just bits telling us the complete lock state (not held or held) or it is a pointer to the head of a queue of threads waiting to acquire the lock. This approach gives WTF::Lock three different levels of adaptation: an inlined fast path if the lock is not contended, a short burst of spinning for microcontention, and a full-blown queue for critical sections that are held for a long time. On a locking microbenchmark, this new Lock exhibits the following performance characteristics:
[webkit-changes] [188170] tags/Safari-601.1.48/
Title: [188170] tags/Safari-601.1.48/ Revision 188170 Author bshaf...@apple.com Date 2015-08-07 16:04:41 -0700 (Fri, 07 Aug 2015) Log Message New tag. Added Paths tags/Safari-601.1.48/ Diff Property changes: tags/Safari-601.1.48 Added: svn:ignore depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh autotoolsconfig.h.in INSTALL README gtk-doc.make out Makefile.chromium WebKitSupportLibrary.zip WebKitBuild Added: svn:mergeinfo ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188171] branches/safari-601.1-branch/Source
Title: [188171] branches/safari-601.1-branch/Source Revision 188171 Author bshaf...@apple.com Date 2015-08-07 16:07:22 -0700 (Fri, 07 Aug 2015) Log Message Versioning. Modified Paths branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig Diff Modified: branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (188170 => 188171) --- branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-07 23:04:41 UTC (rev 188170) +++ branches/safari-601.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2015-08-07 23:07:22 UTC (rev 188171) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 48; +TINY_VERSION = 49; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig (188170 => 188171) --- branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-07 23:04:41 UTC (rev 188170) +++ branches/safari-601.1-branch/Source/WebCore/Configurations/Version.xcconfig 2015-08-07 23:07:22 UTC (rev 188171) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 48; +TINY_VERSION = 49; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (188170 => 188171) --- branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-07 23:04:41 UTC (rev 188170) +++ branches/safari-601.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2015-08-07 23:07:22 UTC (rev 188171) @@ -1,6 +1,6 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 48; +TINY_VERSION = 49; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig (188170 => 188171) --- branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-07 23:04:41 UTC (rev 188170) +++ branches/safari-601.1-branch/Source/WebKit/mac/Configurations/Version.xcconfig 2015-08-07 23:07:22 UTC (rev 188171) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 48; +TINY_VERSION = 49; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); Modified: branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig (188170 => 188171) --- branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-07 23:04:41 UTC (rev 188170) +++ branches/safari-601.1-branch/Source/WebKit2/Configurations/Version.xcconfig 2015-08-07 23:07:22 UTC (rev 188171) @@ -23,7 +23,7 @@ MAJOR_VERSION = 601; MINOR_VERSION = 1; -TINY_VERSION = 48; +TINY_VERSION = 49; MICRO_VERSION = 0; NANO_VERSION = 0; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188117] trunk/Source/WTF
Title: [188117] trunk/Source/WTF
Revision 188117
Author fpi...@apple.com
Date 2015-08-06 23:17:25 -0700 (Thu, 06 Aug 2015)
Log Message
Unreviewed, work around assertions in Windows's std::atomic.
* wtf/Atomics.h:
(WTF::Atomic::compareExchangeWeak):
(WTF::Atomic::compareExchangeStrong):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h
Diff
Modified: trunk/Source/WTF/ChangeLog (188116 => 188117)
--- trunk/Source/WTF/ChangeLog 2015-08-07 05:15:11 UTC (rev 188116)
+++ trunk/Source/WTF/ChangeLog 2015-08-07 06:17:25 UTC (rev 188117)
@@ -1,3 +1,11 @@
+2015-08-06 Filip Pizlo fpi...@apple.com
+
+Unreviewed, work around assertions in Windows's std::atomic.
+
+* wtf/Atomics.h:
+(WTF::Atomic::compareExchangeWeak):
+(WTF::Atomic::compareExchangeStrong):
+
2015-08-05 Filip Pizlo fpi...@apple.com
Lightweight locks should be adaptive
Modified: trunk/Source/WTF/wtf/Atomics.h (188116 => 188117)
--- trunk/Source/WTF/wtf/Atomics.h 2015-08-07 05:15:11 UTC (rev 188116)
+++ trunk/Source/WTF/wtf/Atomics.h 2015-08-07 06:17:25 UTC (rev 188117)
@@ -91,12 +91,21 @@
bool compareExchangeWeak(T expected, T desired, std::memory_order order = std::memory_order_seq_cst)
{
+#if OS(WINDOWS)
+// Windows makes strange assertions about the argument to compare_exchange_weak, and anyway,
+// Windows is X86 so seq_cst is cheap.
+order = std::memory_order_seq_cst;
+#endif
T expectedOrActual = expected;
return value.compare_exchange_weak(expectedOrActual, desired, order);
}
bool compareExchangeStrong(T expected, T desired, std::memory_order order = std::memory_order_seq_cst)
{
+#if OS(WINDOWS)
+// See above.
+order = std::memory_order_seq_cst;
+#endif
T expectedOrActual = expected;
return value.compare_exchange_strong(expectedOrActual, desired, order);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188120] trunk
Title: [188120] trunk
Revision 188120
Author commit-qu...@webkit.org
Date 2015-08-07 01:32:21 -0700 (Fri, 07 Aug 2015)
Log Message
AX: Bug 147737 is causing test failures in Mavericks WK1
https://bugs.webkit.org/show_bug.cgi?id=147763
Source/WebCore:
Restrict change made in 147737 to ElCapitan+ because it is causing tests
to fail in Mavericks.
Patch by Doug Russell d_russ...@apple.com on 2015-08-07
Reviewed by Chris Fleizach.
Fixes failing tests.
* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
LayoutTests:
Patch by Doug Russell d_russ...@apple.com on 2015-08-07
Reviewed by Chris Fleizach.
* platform/mac/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (188119 => 188120)
--- trunk/LayoutTests/ChangeLog 2015-08-07 08:15:13 UTC (rev 188119)
+++ trunk/LayoutTests/ChangeLog 2015-08-07 08:32:21 UTC (rev 188120)
@@ -1,3 +1,12 @@
+2015-08-07 Doug Russell d_russ...@apple.com
+
+AX: Bug 147737 is causing test failures in Mavericks WK1
+https://bugs.webkit.org/show_bug.cgi?id=147763
+
+Reviewed by Chris Fleizach.
+
+* platform/mac/TestExpectations:
+
2015-08-06 Yusuke Suzuki utatane@gmail.com
Introduce get_by_id like IC into get_by_val when the given name is String or Symbol
Modified: trunk/LayoutTests/platform/mac/TestExpectations (188119 => 188120)
--- trunk/LayoutTests/platform/mac/TestExpectations 2015-08-07 08:15:13 UTC (rev 188119)
+++ trunk/LayoutTests/platform/mac/TestExpectations 2015-08-07 08:32:21 UTC (rev 188120)
@@ -1306,3 +1306,6 @@
# WK1-only timeout.
webkit.org/b/147683 platform/mac/fast/scrolling/scroll-div-with-nested-nonscrollable-iframe.html [ Skip ]
+
+webkit.org/b/147763 [ Mavericks ] accessibility/mac/loaded-notification.html [ Skip ]
+webkit.org/b/147763 [ Yosemite ] accessibility/mac/loaded-notification.html [ Skip ]
Modified: trunk/Source/WebCore/ChangeLog (188119 => 188120)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 08:15:13 UTC (rev 188119)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 08:32:21 UTC (rev 188120)
@@ -1,3 +1,18 @@
+2015-08-07 Doug Russell d_russ...@apple.com
+
+AX: Bug 147737 is causing test failures in Mavericks WK1
+https://bugs.webkit.org/show_bug.cgi?id=147763
+
+Restrict change made in 147737 to ElCapitan+ because it is causing tests
+to fail in Mavericks.
+
+Reviewed by Chris Fleizach.
+
+Fixes failing tests.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::setEnhancedUserInterfaceAccessibility):
+
2015-08-07 Xabier Rodriguez Calvar calva...@igalia.com
Create [CustomBinding] extended IDL attribute
Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (188119 => 188120)
--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2015-08-07 08:15:13 UTC (rev 188119)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp 2015-08-07 08:32:21 UTC (rev 188120)
@@ -129,8 +129,12 @@
void AXObjectCache::setEnhancedUserInterfaceAccessibility(bool flag)
{
gAccessibilityEnhancedUserInterfaceEnabled = flag;
+#if PLATFORM(MAC)
+#if __MAC_OS_X_VERSION_MIN_REQUIRED = 101100
if (flag)
enableAccessibility();
+#endif
+#endif
}
AXObjectCache::AXObjectCache(Document document)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188119] trunk/Source/WebCore
Title: [188119] trunk/Source/WebCore
Revision 188119
Author calva...@igalia.com
Date 2015-08-07 01:15:13 -0700 (Fri, 07 Aug 2015)
Log Message
Create [CustomBinding] extended IDL attribute
https://bugs.webkit.org/show_bug.cgi?id=146593
Reviewed by Geoffrey Garen.
Added the [CustomBinding] IDL extended attribute. The idea is that when using this attribute, bindings generate
only the signature of the JS functions and we have to implement all the access in the Custom.cpp files, meaning
accessing the implementations at our wish.
Added customBindingMethod, customBindingMethodWithArgs to the generator tests.
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipFunction): Skipped [CustomBinding] methods.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Consider CustomBinding as ForwardDeclareInHeader.
(GenerateImplementation): Avoid printing both header and implementation of the function.
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipFunction): Skipped [CustomBinding] methods.
* bindings/scripts/IDLAttributes.txt: Added [CustomBinding] IDL extended attribute.
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/TestObj.idl: Added customBindingMethod, customBindingMethodWithArgs and their
expectations.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.h
trunk/Source/WebCore/bindings/scripts/test/TestObj.idl
Diff
Modified: trunk/Source/WebCore/ChangeLog (188118 => 188119)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 08:15:13 UTC (rev 188119)
@@ -1,3 +1,28 @@
+2015-08-07 Xabier Rodriguez Calvar calva...@igalia.com
+
+Create [CustomBinding] extended IDL attribute
+https://bugs.webkit.org/show_bug.cgi?id=146593
+
+Reviewed by Geoffrey Garen.
+
+Added the [CustomBinding] IDL extended attribute. The idea is that when using this attribute, bindings generate
+only the signature of the JS functions and we have to implement all the access in the Custom.cpp files, meaning
+accessing the implementations at our wish.
+
+Added customBindingMethod, customBindingMethodWithArgs to the generator tests.
+
+* bindings/scripts/CodeGeneratorGObject.pm:
+(SkipFunction): Skipped [CustomBinding] methods.
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader): Consider CustomBinding as ForwardDeclareInHeader.
+(GenerateImplementation): Avoid printing both header and implementation of the function.
+* bindings/scripts/CodeGeneratorObjC.pm:
+(SkipFunction): Skipped [CustomBinding] methods.
+* bindings/scripts/IDLAttributes.txt: Added [CustomBinding] IDL extended attribute.
+* bindings/scripts/test/JS/JSTestObj.cpp:
+* bindings/scripts/test/TestObj.idl: Added customBindingMethod, customBindingMethodWithArgs and their
+expectations.
+
2015-08-06 Zan Dobersek zdober...@igalia.com
Source/WebCore/crypto code should pass std::function objects through rvalue references
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm (188118 => 188119)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm 2015-08-07 08:15:13 UTC (rev 188119)
@@ -283,7 +283,7 @@
my $functionName = webkit_dom_ . $decamelize . _ . $prefix . decamelize($function-signature-name);
my $functionReturnType = $prefix eq set_ ? void : $function-signature-type;
-my $isCustomFunction = $function-signature-extendedAttributes-{Custom};
+my $isCustomFunction = $function-signature-extendedAttributes-{Custom} || $function-signature-extendedAttributes-{CustomBinding};
my $callWith = $function-signature-extendedAttributes-{CallWith};
my $isUnsupportedCallWith = $codeGenerator-ExtendedAttributeContains($callWith, ScriptArguments) || $codeGenerator-ExtendedAttributeContains($callWith, CallStack);
Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (188118 => 188119)
--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-08-07 06:48:27 UTC (rev 188118)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm 2015-08-07 08:15:13 UTC (rev 188119)
@@ -1092,7 +1092,7 @@
foreach my $function (@{$interface-functions}) {
$numCustomFunctions++ if HasCustomMethod($function-signature-extendedAttributes);
-if ($function-signature-extendedAttributes-{ForwardDeclareInHeader}) {
+if ($function-signature-extendedAttributes-{ForwardDeclareInHeader} or
[webkit-changes] [188118] trunk/Source/WebCore
Title: [188118] trunk/Source/WebCore Revision 188118 Author zandober...@gmail.com Date 2015-08-06 23:48:27 -0700 (Thu, 06 Aug 2015) Log Message Source/WebCore/crypto code should pass std::function objects through rvalue references https://bugs.webkit.org/show_bug.cgi?id=147332 Reviewed by Anders Carlsson. Pass the std::function callbacks through CryptoAlgorithm methods via rvlaue references. This avoids generation of unnecessary move and copy constructors for std::function objects that are being handled. * crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::encrypt): (WebCore::CryptoAlgorithm::decrypt): (WebCore::CryptoAlgorithm::sign): (WebCore::CryptoAlgorithm::verify): (WebCore::CryptoAlgorithm::digest): (WebCore::CryptoAlgorithm::generateKey): (WebCore::CryptoAlgorithm::deriveKey): (WebCore::CryptoAlgorithm::deriveBits): (WebCore::CryptoAlgorithm::importKey): (WebCore::CryptoAlgorithm::encryptForWrapKey): (WebCore::CryptoAlgorithm::decryptForUnwrapKey): * crypto/CryptoAlgorithm.h: * crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: (WebCore::CryptoAlgorithmAES_CBC::encrypt): (WebCore::CryptoAlgorithmAES_CBC::decrypt): (WebCore::CryptoAlgorithmAES_CBC::generateKey): (WebCore::CryptoAlgorithmAES_CBC::importKey): * crypto/algorithms/CryptoAlgorithmAES_CBC.h: * crypto/algorithms/CryptoAlgorithmAES_KW.cpp: (WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey): (WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey): (WebCore::CryptoAlgorithmAES_KW::generateKey): (WebCore::CryptoAlgorithmAES_KW::importKey): * crypto/algorithms/CryptoAlgorithmAES_KW.h: * crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::sign): (WebCore::CryptoAlgorithmHMAC::verify): (WebCore::CryptoAlgorithmHMAC::generateKey): (WebCore::CryptoAlgorithmHMAC::importKey): * crypto/algorithms/CryptoAlgorithmHMAC.h: * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::encrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::decrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::generateKey): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::importKey): * crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h: * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::generateKey): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::importKey): * crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h: * crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::encrypt): (WebCore::CryptoAlgorithmRSA_OAEP::decrypt): (WebCore::CryptoAlgorithmRSA_OAEP::generateKey): (WebCore::CryptoAlgorithmRSA_OAEP::importKey): * crypto/algorithms/CryptoAlgorithmRSA_OAEP.h: * crypto/algorithms/CryptoAlgorithmSHA1.cpp: (WebCore::CryptoAlgorithmSHA1::digest): * crypto/algorithms/CryptoAlgorithmSHA1.h: * crypto/algorithms/CryptoAlgorithmSHA224.cpp: (WebCore::CryptoAlgorithmSHA224::digest): * crypto/algorithms/CryptoAlgorithmSHA224.h: * crypto/algorithms/CryptoAlgorithmSHA256.cpp: (WebCore::CryptoAlgorithmSHA256::digest): * crypto/algorithms/CryptoAlgorithmSHA256.h: * crypto/algorithms/CryptoAlgorithmSHA384.cpp: (WebCore::CryptoAlgorithmSHA384::digest): * crypto/algorithms/CryptoAlgorithmSHA384.h: * crypto/algorithms/CryptoAlgorithmSHA512.cpp: (WebCore::CryptoAlgorithmSHA512::digest): * crypto/algorithms/CryptoAlgorithmSHA512.h: * crypto/gnutls/CryptoAlgorithmAES_CBCGnuTLS.cpp: (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt): (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt): * crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp: (WebCore::CryptoAlgorithmAES_KW::platformEncrypt): (WebCore::CryptoAlgorithmAES_KW::platformDecrypt): * crypto/gnutls/CryptoAlgorithmHMACGnuTLS.cpp: (WebCore::CryptoAlgorithmHMAC::platformSign): (WebCore::CryptoAlgorithmHMAC::platformVerify): * crypto/gnutls/CryptoAlgorithmRSAES_PKCS1_v1_5GnuTLS.cpp: (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt): (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt): * crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp: (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign): (WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify): * crypto/gnutls/CryptoAlgorithmRSA_OAEPGnuTLS.cpp: (WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt): (WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt): * crypto/mac/CryptoAlgorithmAES_CBCMac.cpp: (WebCore::transformAES_CBC): (WebCore::CryptoAlgorithmAES_CBC::platformEncrypt): (WebCore::CryptoAlgorithmAES_CBC::platformDecrypt): * crypto/mac/CryptoAlgorithmAES_KWMac.cpp: (WebCore::CryptoAlgorithmAES_KW::platformEncrypt): (WebCore::CryptoAlgorithmAES_KW::platformDecrypt): * crypto/mac/CryptoAlgorithmHMACMac.cpp: (WebCore::CryptoAlgorithmHMAC::platformSign): (WebCore::CryptoAlgorithmHMAC::platformVerify): * crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp: (WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
[webkit-changes] [188121] trunk
Title: [188121] trunk Revision 188121 Author carlo...@webkit.org Date 2015-08-07 02:51:20 -0700 (Fri, 07 Aug 2015) Log Message [GStreamer] Do not automatically show PackageKit codec installation notifications https://bugs.webkit.org/show_bug.cgi?id=135973 Reviewed by Philippe Normand. Source/WebCore: Add description parameter to requestInstallMissingPlugins() that will be used by the API layer. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::requestInstallMissingPlugins): * html/HTMLMediaElement.h: * page/ChromeClient.h: * platform/graphics/MediaPlayer.h: (WebCore::MediaPlayerClient::requestInstallMissingPlugins): * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Source/WebKit2: Add InstallMissingMediaPluginsPermissionRequest to ask the API layer whether to allow or deny the installation of missing media plugins. And add a GTK+ implementation based on current permission request API. Replace the PageClientImpl::createGstInstallPluginsContext() with decicePolicyForInstallMissingMediaPluginsPermissionRequest() that passes the InstallMissingMediaPluginsPermissionRequest object to the API layer. The allow method receives the GstInstallPluginsContext now, so that it can be created by the API implementation. * PlatformEfl.cmake: * PlatformGTK.cmake: * UIProcess/API/gtk/PageClientImpl.cpp: (WebKit::PageClientImpl::decicePolicyForInstallMissingMediaPluginsPermissionRequest): * UIProcess/API/gtk/PageClientImpl.h: * UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: Added. (createGstInstallPluginsContext): (webkitInstallMissingMediaPluginsPermissionRequestAllow): (webkitInstallMissingMediaPluginsPermissionRequestDeny): (webkit_permission_request_interface_init): (webkitInstallMissingMediaPluginsPermissionRequestDispose): (webkit_install_missing_media_plugins_permission_request_class_init): (webkitInstallMissingMediaPluginsPermissionRequestCreate): (webkit_install_missing_media_plugins_permission_request_get_description): * UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.h: Added. * UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequestPrivate.h: Added. * UIProcess/API/gtk/WebKitWebView.cpp: (webkitWebViewRequestInstallMissingMediaPlugins): * UIProcess/API/gtk/WebKitWebViewPrivate.h: * UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: * UIProcess/API/gtk/docs/webkit2gtk-4.0.types: * UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: * UIProcess/API/gtk/webkit2.h: * UIProcess/PageClient.h: * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/efl/WebViewEfl.h: * UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.cpp: Copied from Source/WebKit2/UIProcess/gstreamer/WebPageProxyGStreamer.cpp. (WebKit::InstallMissingMediaPluginsPermissionRequest::InstallMissingMediaPluginsPermissionRequest): (WebKit::InstallMissingMediaPluginsPermissionRequest::~InstallMissingMediaPluginsPermissionRequest): (WebKit::InstallMissingMediaPluginsPermissionRequest::allow): (WebKit::InstallMissingMediaPluginsPermissionRequest::deny): (WebKit::InstallMissingMediaPluginsPermissionRequest::didEndRequestInstallMissingMediaPlugins): * UIProcess/gstreamer/InstallMissingMediaPluginsPermissionRequest.h: Copied from Source/WebKit2/WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp. (WebKit::InstallMissingMediaPluginsPermissionRequest::create): (WebKit::InstallMissingMediaPluginsPermissionRequest::page): (WebKit::InstallMissingMediaPluginsPermissionRequest::details): (WebKit::InstallMissingMediaPluginsPermissionRequest::description): * UIProcess/gstreamer/WebPageProxyGStreamer.cpp: (WebKit::WebPageProxy::requestInstallMissingMediaPlugins): * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::requestInstallMissingMediaPlugins): * WebProcess/WebCoreSupport/WebChromeClient.h: * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/gstreamer/WebPageGStreamer.cpp: (WebKit::WebPage::requestInstallMissingMediaPlugins): Tools: Handle the missing media plugins installation permission request in MiniBrowser and add a test case for the new API. * MiniBrowser/gtk/BrowserWindow.c: (webViewDecidePermissionRequest): * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: (permissionRequestCallback): (testInstallMissingPluginsPermissionRequest): (beforeAll): * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: (methodCallCallback): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/html/HTMLMediaElement.cpp trunk/Source/WebCore/html/HTMLMediaElement.h trunk/Source/WebCore/page/ChromeClient.h trunk/Source/WebCore/platform/graphics/MediaPlayer.h trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/PlatformEfl.cmake trunk/Source/WebKit2/PlatformGTK.cmake trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
[webkit-changes] [188122] trunk/Tools
Title: [188122] trunk/Tools Revision 188122 Author carlo...@webkit.org Date 2015-08-07 03:27:27 -0700 (Fri, 07 Aug 2015) Log Message [GTK] run-gtk-tests should not stop when a google test case fails https://bugs.webkit.org/show_bug.cgi?id=147778 Reviewed by Philippe Normand. For glib based tests we run the test runner with the -k option, but for google tests we are aborting as soon as we find a failure. * Scripts/run-gtk-tests: (TestRunner._run_google_test_suite): Use a global return code that is set to 1 when any test has failed. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (188121 => 188122) --- trunk/Tools/ChangeLog 2015-08-07 09:51:20 UTC (rev 188121) +++ trunk/Tools/ChangeLog 2015-08-07 10:27:27 UTC (rev 188122) @@ -1,5 +1,19 @@ 2015-08-07 Carlos Garcia Campos cgar...@igalia.com +[GTK] run-gtk-tests should not stop when a google test case fails +https://bugs.webkit.org/show_bug.cgi?id=147778 + +Reviewed by Philippe Normand. + +For glib based tests we run the test runner with the -k option, +but for google tests we are aborting as soon as we find a failure. + +* Scripts/run-gtk-tests: +(TestRunner._run_google_test_suite): Use a global return code that +is set to 1 when any test has failed. + +2015-08-07 Carlos Garcia Campos cgar...@igalia.com + [GStreamer] Do not automatically show PackageKit codec installation notifications https://bugs.webkit.org/show_bug.cgi?id=135973 Modified: trunk/Tools/Scripts/run-gtk-tests (188121 => 188122) --- trunk/Tools/Scripts/run-gtk-tests 2015-08-07 09:51:20 UTC (rev 188121) +++ trunk/Tools/Scripts/run-gtk-tests 2015-08-07 10:27:27 UTC (rev 188122) @@ -343,11 +343,11 @@ return self._run_test_command(test_command, self._options.timeout) def _run_google_test_suite(self, test_program): +retcode = 0 for subtest in self._get_tests_from_google_test_suite(test_program): -retcode = self._run_google_test(test_program, subtest) -if retcode: -return retcode -return 0 +if self._run_google_test(test_program, subtest): +retcode = 1 +return retcode def _run_test(self, test_program): basedir = os.path.basename(os.path.dirname(test_program)) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188124] trunk/Source/WebKit2
Title: [188124] trunk/Source/WebKit2 Revision 188124 Author carlo...@webkit.org Date 2015-08-07 04:17:24 -0700 (Fri, 07 Aug 2015) Log Message Unreviewed. Fix GTK+ compile warning also introduced in r188121. * UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: (webkit_install_missing_media_plugins_permission_request_get_description): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (188123 => 188124) --- trunk/Source/WebKit2/ChangeLog 2015-08-07 10:51:16 UTC (rev 188123) +++ trunk/Source/WebKit2/ChangeLog 2015-08-07 11:17:24 UTC (rev 188124) @@ -1,5 +1,12 @@ 2015-08-07 Carlos Garcia Campos cgar...@igalia.com +Unreviewed. Fix GTK+ compile warning also introduced in r188121. + +* UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: +(webkit_install_missing_media_plugins_permission_request_get_description): + +2015-08-07 Carlos Garcia Campos cgar...@igalia.com + Unreviewed. Fix GTK+ debug build after r188121. * UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp (188123 => 188124) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp 2015-08-07 10:51:16 UTC (rev 188123) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp 2015-08-07 11:17:24 UTC (rev 188124) @@ -160,7 +160,7 @@ const auto description = request-priv-request-description(); ASSERT(!description.isEmpty()); -request-priv-description = request-priv-request-description().utf8(); +request-priv-description = description.utf8(); #endif return request-priv-description.data(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188123] trunk/Source/WebKit2
Title: [188123] trunk/Source/WebKit2 Revision 188123 Author carlo...@webkit.org Date 2015-08-07 03:51:16 -0700 (Fri, 07 Aug 2015) Log Message Unreviewed. Fix GTK+ debug build after r188121. * UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: (webkit_install_missing_media_plugins_permission_request_get_description): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp Diff Modified: trunk/Source/WebKit2/ChangeLog (188122 => 188123) --- trunk/Source/WebKit2/ChangeLog 2015-08-07 10:27:27 UTC (rev 188122) +++ trunk/Source/WebKit2/ChangeLog 2015-08-07 10:51:16 UTC (rev 188123) @@ -1,5 +1,12 @@ 2015-08-07 Carlos Garcia Campos cgar...@igalia.com +Unreviewed. Fix GTK+ debug build after r188121. + +* UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp: +(webkit_install_missing_media_plugins_permission_request_get_description): + +2015-08-07 Carlos Garcia Campos cgar...@igalia.com + [GStreamer] Do not automatically show PackageKit codec installation notifications https://bugs.webkit.org/show_bug.cgi?id=135973 Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp (188122 => 188123) --- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp 2015-08-07 10:27:27 UTC (rev 188122) +++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitInstallMissingMediaPluginsPermissionRequest.cpp 2015-08-07 10:51:16 UTC (rev 188123) @@ -159,7 +159,7 @@ return request-priv-description.data(); const auto description = request-priv-request-description(); -ASSERT(!details.isEmpty()); +ASSERT(!description.isEmpty()); request-priv-description = request-priv-request-description().utf8(); #endif return request-priv-description.data(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188125] trunk/Tools
Title: [188125] trunk/Tools Revision 188125 Author carlo...@webkit.org Date 2015-08-07 08:28:01 -0700 (Fri, 07 Aug 2015) Log Message [GTK] WTF unit tests are timing out in the bots https://bugs.webkit.org/show_bug.cgi?id=14 Reviewed by Filip Pizlo. Add a way to mark google unit tests as slow and add WTF_Lock.ContentedShortSection to the list. In case of slow test we use the double of the given timeout for that particular test. * Scripts/run-gtk-tests: (TestRunner): (TestRunner._run_google_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-gtk-tests Diff Modified: trunk/Tools/ChangeLog (188124 => 188125) --- trunk/Tools/ChangeLog 2015-08-07 11:17:24 UTC (rev 188124) +++ trunk/Tools/ChangeLog 2015-08-07 15:28:01 UTC (rev 188125) @@ -1,5 +1,20 @@ 2015-08-07 Carlos Garcia Campos cgar...@igalia.com +[GTK] WTF unit tests are timing out in the bots +https://bugs.webkit.org/show_bug.cgi?id=14 + +Reviewed by Filip Pizlo. + +Add a way to mark google unit tests as slow and add +WTF_Lock.ContentedShortSection to the list. In case of slow test +we use the double of the given timeout for that particular test. + +* Scripts/run-gtk-tests: +(TestRunner): +(TestRunner._run_google_test): + +2015-08-07 Carlos Garcia Campos cgar...@igalia.com + [GTK] run-gtk-tests should not stop when a google test case fails https://bugs.webkit.org/show_bug.cgi?id=147778 Modified: trunk/Tools/Scripts/run-gtk-tests (188124 => 188125) --- trunk/Tools/Scripts/run-gtk-tests 2015-08-07 11:17:24 UTC (rev 188124) +++ trunk/Tools/Scripts/run-gtk-tests 2015-08-07 15:28:01 UTC (rev 188125) @@ -80,6 +80,10 @@ SkippedTest(WebKit2/TestWebKit2, WebKit2.GeolocationTransitionToLowAccuracy, Test causes crash on the next test, 125068), ] +SLOW = [ +WTF_Lock.ContentedShortSection, +] + def __init__(self, options, tests=[]): self._options = options @@ -340,7 +344,10 @@ def _run_google_test(self, test_program, subtest): test_command = [test_program, '--gtest_filter=%s' % (subtest)] -return self._run_test_command(test_command, self._options.timeout) +timeout = self._options.timeout +if subtest in TestRunner.SLOW: +timeout *= 2 +return self._run_test_command(test_command, timeout) def _run_google_test_suite(self, test_program): retcode = 0 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188126] trunk/Source
Title: [188126] trunk/Source Revision 188126 Author beid...@apple.com Date 2015-08-07 09:04:49 -0700 (Fri, 07 Aug 2015) Log Message Move concrete KeyedDecoder/Encoder implementations to WebCore. https://bugs.webkit.org/show_bug.cgi?id=147757. Rubberstamped by Andy Estes. Source/WebCore: * PlatformEfl.cmake: * PlatformGTK.cmake: * WebCore.xcodeproj/project.pbxproj: * platform/KeyedCoding.h: (WebCore::KeyedDecoder::KeyedDecoder): Static constructor to be implemented per-platform. (WebCore::KeyedEncoder::KeyedEncoder): Ditto. * platform/cf/KeyedDecoderCF.cpp: Renamed from Source/WebKit2/Shared/cf/KeyedDecoder.cpp. (WebCore::KeyedDecoder::decoder): (WebCore::KeyedDecoderCF::KeyedDecoderCF): (WebCore::KeyedDecoderCF::~KeyedDecoderCF): (WebCore::KeyedDecoderCF::decodeBytes): (WebCore::KeyedDecoderCF::decodeBool): (WebCore::KeyedDecoderCF::decodeUInt32): (WebCore::KeyedDecoderCF::decodeInt32): (WebCore::KeyedDecoderCF::decodeInt64): (WebCore::KeyedDecoderCF::decodeFloat): (WebCore::KeyedDecoderCF::decodeDouble): (WebCore::KeyedDecoderCF::decodeString): (WebCore::KeyedDecoderCF::beginObject): (WebCore::KeyedDecoderCF::endObject): (WebCore::KeyedDecoderCF::beginArray): (WebCore::KeyedDecoderCF::beginArrayElement): (WebCore::KeyedDecoderCF::endArrayElement): (WebCore::KeyedDecoderCF::endArray): * platform/cf/KeyedDecoderCF.h: Renamed from Source/WebKit2/Shared/cf/KeyedDecoder.h. * platform/cf/KeyedEncoderCF.cpp: Renamed from Source/WebKit2/Shared/cf/KeyedEncoder.cpp. (WebCore::KeyedEncoder::encoder): (WebCore::createDictionary): (WebCore::KeyedEncoderCF::KeyedEncoderCF): (WebCore::KeyedEncoderCF::~KeyedEncoderCF): (WebCore::KeyedEncoderCF::encodeBytes): (WebCore::KeyedEncoderCF::encodeBool): (WebCore::KeyedEncoderCF::encodeUInt32): (WebCore::KeyedEncoderCF::encodeInt32): (WebCore::KeyedEncoderCF::encodeInt64): (WebCore::KeyedEncoderCF::encodeFloat): (WebCore::KeyedEncoderCF::encodeDouble): (WebCore::KeyedEncoderCF::encodeString): (WebCore::KeyedEncoderCF::beginObject): (WebCore::KeyedEncoderCF::endObject): (WebCore::KeyedEncoderCF::beginArray): (WebCore::KeyedEncoderCF::beginArrayElement): (WebCore::KeyedEncoderCF::endArrayElement): (WebCore::KeyedEncoderCF::endArray): (WebCore::KeyedEncoderCF::finishEncoding): * platform/cf/KeyedEncoderCF.h: Renamed from Source/WebKit2/Shared/cf/KeyedEncoder.h. * platform/glib/KeyedDecoderGlib.cpp: Renamed from Source/WebKit2/Shared/glib/KeyedDecoder.cpp. (WebCore::KeyedDecoder::decoder): (WebCore::KeyedDecoderGlib::KeyedDecoderGlib): (WebCore::KeyedDecoderGlib::~KeyedDecoderGlib): (WebCore::KeyedDecoderGlib::dictionaryFromGVariant): (WebCore::KeyedDecoderGlib::decodeBytes): (WebCore::KeyedDecoderGlib::decodeSimpleValue): (WebCore::KeyedDecoderGlib::decodeBool): (WebCore::KeyedDecoderGlib::decodeUInt32): (WebCore::KeyedDecoderGlib::decodeInt32): (WebCore::KeyedDecoderGlib::decodeInt64): (WebCore::KeyedDecoderGlib::decodeFloat): (WebCore::KeyedDecoderGlib::decodeDouble): (WebCore::KeyedDecoderGlib::decodeString): (WebCore::KeyedDecoderGlib::beginObject): (WebCore::KeyedDecoderGlib::endObject): (WebCore::KeyedDecoderGlib::beginArray): (WebCore::KeyedDecoderGlib::beginArrayElement): (WebCore::KeyedDecoderGlib::endArrayElement): (WebCore::KeyedDecoderGlib::endArray): * platform/glib/KeyedDecoderGlib.h: Renamed from Source/WebKit2/Shared/glib/KeyedDecoder.h. * platform/glib/KeyedEncoderGlib.cpp: Renamed from Source/WebKit2/Shared/glib/KeyedEncoder.cpp. (WebCore::KeyedEncoder::encoder): (WebCore::KeyedEncoderGlib::KeyedEncoderGlib): (WebCore::KeyedEncoderGlib::~KeyedEncoderGlib): (WebCore::KeyedEncoderGlib::encodeBytes): (WebCore::KeyedEncoderGlib::encodeBool): (WebCore::KeyedEncoderGlib::encodeUInt32): (WebCore::KeyedEncoderGlib::encodeInt32): (WebCore::KeyedEncoderGlib::encodeInt64): (WebCore::KeyedEncoderGlib::encodeFloat): (WebCore::KeyedEncoderGlib::encodeDouble): (WebCore::KeyedEncoderGlib::encodeString): (WebCore::KeyedEncoderGlib::beginObject): (WebCore::KeyedEncoderGlib::endObject): (WebCore::KeyedEncoderGlib::beginArray): (WebCore::KeyedEncoderGlib::beginArrayElement): (WebCore::KeyedEncoderGlib::endArrayElement): (WebCore::KeyedEncoderGlib::endArray): (WebCore::KeyedEncoderGlib::finishEncoding): * platform/glib/KeyedEncoderGlib.h: Renamed from Source/WebKit2/Shared/glib/KeyedEncoder.h. Source/WebKit2: * DatabaseProcess/IndexedDB/IDBSerialization.cpp: (WebKit::serializeIDBKeyPath): (WebKit::deserializeIDBKeyPath): (WebKit::serializeIDBKeyData): (WebKit::deserializeIDBKeyData): * PlatformEfl.cmake: * PlatformGTK.cmake: * WebKit2.xcodeproj/project.pbxproj: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/PlatformGTK.cmake trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/platform/KeyedCoding.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/DatabaseProcess/IndexedDB/IDBSerialization.cpp trunk/Source/WebKit2/PlatformEfl.cmake trunk/Source/WebKit2/PlatformGTK.cmake
[webkit-changes] [188128] trunk/Tools
Title: [188128] trunk/Tools
Revision 188128
Author rn...@webkit.org
Date 2015-08-07 09:36:57 -0700 (Fri, 07 Aug 2015)
Log Message
twisted_http_server.py should support --port
https://bugs.webkit.org/show_bug.cgi?id=147771
Reviewed by Chris Dumez.
Added the option. This makes the script more useful on its own.
* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
Diff
Modified: trunk/Tools/ChangeLog (188127 => 188128)
--- trunk/Tools/ChangeLog 2015-08-07 16:35:43 UTC (rev 188127)
+++ trunk/Tools/ChangeLog 2015-08-07 16:36:57 UTC (rev 188128)
@@ -1,3 +1,14 @@
+2015-08-07 Ryosuke Niwa rn...@webkit.org
+
+twisted_http_server.py should support --port
+https://bugs.webkit.org/show_bug.cgi?id=147771
+
+Reviewed by Chris Dumez.
+
+Added the option. This makes the script more useful on its own.
+
+* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
+
2015-08-07 Carlos Garcia Campos cgar...@igalia.com
[GTK] WTF unit tests are timing out in the bots
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py (188127 => 188128)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py 2015-08-07 16:35:43 UTC (rev 188127)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py 2015-08-07 16:36:57 UTC (rev 188128)
@@ -36,10 +36,11 @@
if __name__ == '__main__':
parser = argparse.ArgumentParser(description='python twisted_http_server.py web_root')
parser.add_argument('web_root')
+parser.add_argument('--port', type=int, default=0)
args = parser.parse_args()
web_root = static.File(args.web_root)
serverControl = ServerControl()
web_root.putChild('shutdown', serverControl)
web_root.putChild('report', serverControl)
-reactor.listenTCP(0, server.Site(web_root))
+reactor.listenTCP(args.port, server.Site(web_root))
reactor.run()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188127] trunk
Title: [188127] trunk Revision 188127 Author calva...@igalia.com Date 2015-08-07 09:35:43 -0700 (Fri, 07 Aug 2015) Log Message [Streams API] Create CountQueuingStrategy object as per spec https://bugs.webkit.org/show_bug.cgi?id=146594 Reviewed by Geoffrey Garen. Source/WebCore: CountQueuingStrategy is a class part of the Streams API that can be found at https://streams.spec.whatwg.org/#cqs-class. We had it as js at the tests but the spec says we have to provide it natively. The class is implemented in this patch by creating its corresponding IDL with the size method using the [CustomBinding] attribute, that does not create any bindings against the object allowing us full control to do what the spec requires (just returning 1 without any cast check). The constructor sets the highWaterMark property taking it from the argument. Covered by current tests (LayoutTests/streams/reference-implementation/count-queuing-strategy.html and LayoutTests/streams/reference-implementation/brand-checks.html). * CMakeLists.txt: * DerivedSources.cpp: * DerivedSources.make: * PlatformMac.cmake: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSBindingsAllInOne.cpp: Build infrastructure. * Modules/streams/CountQueuingStrategy.h: Added. (WebCore::CountQueuingStrategy::~CountQueuingStrategy): Created empty. (WebCore::CountQueuingStrategy::size): Returns 1. * Modules/streams/CountQueuingStrategy.idl: Added. * bindings/js/JSCountQueuingStrategyCustom.cpp: Added. (WebCore::jsCountQueuingStrategyPrototypeFunctionSize): Calls WebCore::CountQueuingStrategy::size. (WebCore::constructJSCountQueuingStrategy): Constructs the strategy, copies the highWaterMark from the argument and returns it. * bindings/js/JSDOMBinding.h: (WebCore::getPropertyFromObject): Moved from ReadableJSStream.cpp. (WebCore::setPropertyToObject): Added to create a property into an object. * bindings/js/ReadableJSStream.cpp: (WebCore::getPropertyFromObject): Deleted. LayoutTests: * js/dom/global-constructors-attributes-expected.txt: * platform/efl/js/dom/global-constructors-attributes-expected.txt: * platform/gtk/js/dom/global-constructors-attributes-expected.txt: * platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt: * platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt: * platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt: * platform/mac/js/dom/global-constructors-attributes-expected.txt: * platform/win/js/dom/global-constructors-attributes-expected.txt: Updated expectations with CountQueuingStrategy constructor. * streams/reference-implementation/brand-checks.html: * streams/reference-implementation/count-queuing-strategy.html: Removed reference to count-queuing-strategy.js. * streams/reference-implementation/resources/count-queuing-strategy.js: Removed. (CountQueuingStrategy): Deleted. (CountQueuingStrategy.prototype.size): Deleted. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/efl/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/gtk/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/platform/win/js/dom/global-constructors-attributes-expected.txt trunk/LayoutTests/streams/reference-implementation/brand-checks.html trunk/LayoutTests/streams/reference-implementation/count-queuing-strategy.html trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/DerivedSources.cpp trunk/Source/WebCore/DerivedSources.make trunk/Source/WebCore/PlatformMac.cmake trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj trunk/Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp trunk/Source/WebCore/bindings/js/JSDOMBinding.h trunk/Source/WebCore/bindings/js/ReadableJSStream.cpp Added Paths trunk/Source/WebCore/Modules/streams/CountQueuingStrategy.h trunk/Source/WebCore/Modules/streams/CountQueuingStrategy.idl trunk/Source/WebCore/bindings/js/JSCountQueuingStrategyCustom.cpp Removed Paths trunk/LayoutTests/streams/reference-implementation/resources/count-queuing-strategy.js Diff Modified: trunk/LayoutTests/ChangeLog (188126 => 188127) --- trunk/LayoutTests/ChangeLog 2015-08-07 16:04:49 UTC (rev 188126) +++ trunk/LayoutTests/ChangeLog 2015-08-07 16:35:43 UTC (rev 188127) @@ -1,3 +1,25 @@ +2015-08-07 Xabier Rodriguez Calvar calva...@igalia.com + +[Streams API] Create
[webkit-changes] [188137] trunk/Source/WebCore
Title: [188137] trunk/Source/WebCore Revision 188137 Author dba...@webkit.org Date 2015-08-07 10:47:28 -0700 (Fri, 07 Aug 2015) Log Message Attempt to fix the Windows build after http://trac.webkit.org/changeset/188130 (https://bugs.webkit.org/show_bug.cgi?id=147775) Include header FontDescription.h. * platform/graphics/win/FontCustomPlatformData.cpp: * platform/graphics/win/FontCustomPlatformDataCairo.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (188136 => 188137) --- trunk/Source/WebCore/ChangeLog 2015-08-07 17:41:22 UTC (rev 188136) +++ trunk/Source/WebCore/ChangeLog 2015-08-07 17:47:28 UTC (rev 188137) @@ -1,3 +1,13 @@ +2015-08-07 Daniel Bates daba...@apple.com + +Attempt to fix the Windows build after http://trac.webkit.org/changeset/188130 +(https://bugs.webkit.org/show_bug.cgi?id=147775) + +Include header FontDescription.h. + +* platform/graphics/win/FontCustomPlatformData.cpp: +* platform/graphics/win/FontCustomPlatformDataCairo.cpp: + 2015-08-07 Myles C. Maxfield mmaxfi...@apple.com Allow FontCustomPlatformData to consult with FontDescription Modified: trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp (188136 => 188137) --- trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp 2015-08-07 17:41:22 UTC (rev 188136) +++ trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp 2015-08-07 17:47:28 UTC (rev 188137) @@ -21,6 +21,7 @@ #include config.h #include FontCustomPlatformData.h +#include FontDescription.h #include FontPlatformData.h #include OpenTypeUtilities.h #include SharedBuffer.h Modified: trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp (188136 => 188137) --- trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp 2015-08-07 17:41:22 UTC (rev 188136) +++ trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp 2015-08-07 17:47:28 UTC (rev 188137) @@ -21,9 +21,10 @@ #include config.h #include FontCustomPlatformData.h +#include FontDescription.h +#include FontPlatformData.h #include OpenTypeUtilities.h #include SharedBuffer.h -#include FontPlatformData.h #include cairo-win32.h #include wtf/RetainPtr.h ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188129] trunk/Tools
Title: [188129] trunk/Tools
Revision 188129
Author rn...@webkit.org
Date 2015-08-07 10:04:31 -0700 (Fri, 07 Aug 2015)
Log Message
Use a specific version of Speedometer in run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=147769
Reviewed by Chris Dumez.
Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
* Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan
Diff
Modified: trunk/Tools/ChangeLog (188128 => 188129)
--- trunk/Tools/ChangeLog 2015-08-07 16:36:57 UTC (rev 188128)
+++ trunk/Tools/ChangeLog 2015-08-07 17:04:31 UTC (rev 188129)
@@ -1,5 +1,16 @@
2015-08-07 Ryosuke Niwa rn...@webkit.org
+Use a specific version of Speedometer in run-benchmark
+https://bugs.webkit.org/show_bug.cgi?id=147769
+
+Reviewed by Chris Dumez.
+
+Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
+
+* Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
+
+2015-08-07 Ryosuke Niwa rn...@webkit.org
+
twisted_http_server.py should support --port
https://bugs.webkit.org/show_bug.cgi?id=147771
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan (188128 => 188129)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan 2015-08-07 16:36:57 UTC (rev 188128)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan 2015-08-07 17:04:31 UTC (rev 188129)
@@ -1,7 +1,7 @@
{
timeout: 300,
count: 5,
-local_copy: ../../../../PerformanceTests/Speedometer,
+svn_source: https://svn.webkit.org/repository/webkit/trunk/PerformanceTests/Speedometer/@r183695,
benchmark_patch: data/patches/Speedometer.patch,
entry_point: Full.html,
output_file: speedometer.result
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188136] trunk/Source/JavaScriptCore
Title: [188136] trunk/Source/_javascript_Core Revision 188136 Author saambara...@gmail.com Date 2015-08-07 10:41:22 -0700 (Fri, 07 Aug 2015) Log Message Interpreter::unwind shouldn't be responsible for assigning the correct scope. https://bugs.webkit.org/show_bug.cgi?id=147666 Reviewed by Geoffrey Garen. If we make the bytecode generator know about every local scope it creates, and if we give each local scope a unique register, the bytecode generator has all the information it needs to assign the correct scope to a catch handler. Because the bytecode generator knows this information, it's a better separation of responsibilties for it to set up the proper scope instead of relying on the exception handling runtime to find the scope. * bytecode/BytecodeList.json: * bytecode/BytecodeUseDef.h: (JSC::computeUsesForBytecodeOffset): * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): (JSC::CodeBlock::CodeBlock): * bytecode/HandlerInfo.h: (JSC::UnlinkedHandlerInfo::UnlinkedHandlerInfo): (JSC::HandlerInfo::initialize): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::pushLexicalScopeInternal): (JSC::BytecodeGenerator::emitGetScope): (JSC::BytecodeGenerator::emitPushWithScope): (JSC::BytecodeGenerator::emitGetParentScope): (JSC::BytecodeGenerator::emitPopScope): (JSC::BytecodeGenerator::emitPopWithScope): (JSC::BytecodeGenerator::allocateAndEmitScope): (JSC::BytecodeGenerator::emitComplexPopScopes): (JSC::BytecodeGenerator::pushTry): (JSC::BytecodeGenerator::popTryAndEmitCatch): (JSC::BytecodeGenerator::localScopeDepth): (JSC::BytecodeGenerator::calculateTargetScopeDepthForExceptionHandler): Deleted. * bytecompiler/BytecodeGenerator.h: * bytecompiler/NodesCodegen.cpp: (JSC::WithNode::emitBytecode): * interpreter/Interpreter.cpp: (JSC::Interpreter::unwind): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_push_with_scope): (JSC::JIT::compileOpStrictEq): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_push_with_scope): (JSC::JIT::emit_op_to_number): * jit/JITOperations.cpp: * jit/JITOperations.h: * llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): * llint/LLIntSlowPaths.h: * llint/LowLevelInterpreter.asm: * runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL): * runtime/CommonSlowPaths.h: * runtime/JSScope.cpp: (JSC::JSScope::objectAtScope): (JSC::isUnscopable): (JSC::JSScope::depth): Deleted. * runtime/JSScope.h: Modified Paths trunk/Source/_javascript_Core/ChangeLog trunk/Source/_javascript_Core/bytecode/BytecodeList.json trunk/Source/_javascript_Core/bytecode/BytecodeUseDef.h trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp trunk/Source/_javascript_Core/bytecode/HandlerInfo.h trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.cpp trunk/Source/_javascript_Core/bytecompiler/BytecodeGenerator.h trunk/Source/_javascript_Core/bytecompiler/NodesCodegen.cpp trunk/Source/_javascript_Core/interpreter/Interpreter.cpp trunk/Source/_javascript_Core/jit/JITOpcodes.cpp trunk/Source/_javascript_Core/jit/JITOpcodes32_64.cpp trunk/Source/_javascript_Core/jit/JITOperations.cpp trunk/Source/_javascript_Core/jit/JITOperations.h trunk/Source/_javascript_Core/llint/LLIntSlowPaths.cpp trunk/Source/_javascript_Core/llint/LLIntSlowPaths.h trunk/Source/_javascript_Core/llint/LowLevelInterpreter.asm trunk/Source/_javascript_Core/runtime/CommonSlowPaths.cpp trunk/Source/_javascript_Core/runtime/CommonSlowPaths.h trunk/Source/_javascript_Core/runtime/JSScope.cpp trunk/Source/_javascript_Core/runtime/JSScope.h Diff Modified: trunk/Source/_javascript_Core/ChangeLog (188135 => 188136) --- trunk/Source/_javascript_Core/ChangeLog 2015-08-07 17:31:27 UTC (rev 188135) +++ trunk/Source/_javascript_Core/ChangeLog 2015-08-07 17:41:22 UTC (rev 188136) @@ -1,3 +1,67 @@ +2015-08-07 Saam barati saambara...@gmail.com + +Interpreter::unwind shouldn't be responsible for assigning the correct scope. +https://bugs.webkit.org/show_bug.cgi?id=147666 + +Reviewed by Geoffrey Garen. + +If we make the bytecode generator know about every local scope it +creates, and if we give each local scope a unique register, the +bytecode generator has all the information it needs to assign +the correct scope to a catch handler. Because the bytecode generator +knows this information, it's a better separation of responsibilties +for it to set up the proper scope instead of relying on the exception +handling runtime to find the scope. + +* bytecode/BytecodeList.json: +* bytecode/BytecodeUseDef.h: +(JSC::computeUsesForBytecodeOffset): +* bytecode/CodeBlock.cpp: +(JSC::CodeBlock::dumpBytecode): +(JSC::CodeBlock::CodeBlock): +* bytecode/HandlerInfo.h: +(JSC::UnlinkedHandlerInfo::UnlinkedHandlerInfo): +(JSC::HandlerInfo::initialize): +* bytecompiler/BytecodeGenerator.cpp: +(JSC::BytecodeGenerator::generate): +
[webkit-changes] [188139] trunk/Tools
Title: [188139] trunk/Tools Revision 188139 Author joep...@webkit.org Date 2015-08-07 11:11:28 -0700 (Fri, 07 Aug 2015) Log Message Running tests for a long time results in some tests running very slowly (throttling) https://bugs.webkit.org/show_bug.cgi?id=147718 Reviewed by Chris Dumez. Follow-up, make DumpRenderTree consistent with WebKitTestRunner. Although COCOA ports default this setting to be disabled in WebKit1, we should make both test harnesses disable the setting for consistency. * DumpRenderTree/mac/DumpRenderTree.mm: (resetWebPreferencesToConsistentValues): Modified Paths trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm Diff Modified: trunk/Tools/ChangeLog (188138 => 188139) --- trunk/Tools/ChangeLog 2015-08-07 17:58:45 UTC (rev 188138) +++ trunk/Tools/ChangeLog 2015-08-07 18:11:28 UTC (rev 188139) @@ -1,3 +1,17 @@ +2015-08-07 Joseph Pecoraro pecor...@apple.com + +Running tests for a long time results in some tests running very slowly (throttling) +https://bugs.webkit.org/show_bug.cgi?id=147718 + +Reviewed by Chris Dumez. + +Follow-up, make DumpRenderTree consistent with WebKitTestRunner. +Although COCOA ports default this setting to be disabled in WebKit1, +we should make both test harnesses disable the setting for consistency. + +* DumpRenderTree/mac/DumpRenderTree.mm: +(resetWebPreferencesToConsistentValues): + 2015-08-07 Ryosuke Niwa rn...@webkit.org Use a specific version of Speedometer in run-benchmark Modified: trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm (188138 => 188139) --- trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-08-07 17:58:45 UTC (rev 188138) +++ trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm 2015-08-07 18:11:28 UTC (rev 188139) @@ -978,6 +978,9 @@ [preferences setMediaSourceEnabled:YES]; #endif +[preferences setHiddenPageDOMTimerThrottlingEnabled:NO]; +[preferences setHiddenPageCSSAnimationSuspensionEnabled:NO]; + [WebPreferences _clearNetworkLoaderSession]; [WebPreferences _setCurrentNetworkLoaderSessionCookieAcceptPolicy:NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain]; } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188133] trunk/LayoutTests
Title: [188133] trunk/LayoutTests Revision 188133 Author simon.fra...@apple.com Date 2015-08-07 10:30:19 -0700 (Fri, 07 Aug 2015) Log Message Move platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html into http/tests/loading/ * http/tests/loading/multiple-prioritization-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt. * http/tests/loading/multiple-prioritization.html: Renamed from LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/http/tests/loading/multiple-prioritization-expected.txt trunk/LayoutTests/http/tests/loading/multiple-prioritization.html Removed Paths trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html Diff Modified: trunk/LayoutTests/ChangeLog (188132 => 188133) --- trunk/LayoutTests/ChangeLog 2015-08-07 17:30:16 UTC (rev 188132) +++ trunk/LayoutTests/ChangeLog 2015-08-07 17:30:19 UTC (rev 188133) @@ -1,3 +1,10 @@ +2015-08-07 Simon Fraser simon.fra...@apple.com + +Move platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html into http/tests/loading/ + +* http/tests/loading/multiple-prioritization-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt. +* http/tests/loading/multiple-prioritization.html: Renamed from LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html. + 2015-08-06 Simon Fraser simon.fra...@apple.com Move ios-sim-deprecated/fast/dom/ tests into fast/dom Copied: trunk/LayoutTests/http/tests/loading/multiple-prioritization-expected.txt (from rev 188132, trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt) (0 => 188133) --- trunk/LayoutTests/http/tests/loading/multiple-prioritization-expected.txt (rev 0) +++ trunk/LayoutTests/http/tests/loading/multiple-prioritization-expected.txt 2015-08-07 17:30:19 UTC (rev 188133) @@ -0,0 +1,6 @@ +main frame - didStartProvisionalLoadForFrame +main frame - didCommitLoadForFrame +main frame - didFinishDocumentLoadForFrame +main frame - didHandleOnloadEventsForFrame +main frame - didFinishLoadForFrame +If you see this text, the test has passed. Copied: trunk/LayoutTests/http/tests/loading/multiple-prioritization.html (from rev 188132, trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html) (0 => 188133) --- trunk/LayoutTests/http/tests/loading/multiple-prioritization.html (rev 0) +++ trunk/LayoutTests/http/tests/loading/multiple-prioritization.html 2015-08-07 17:30:19 UTC (rev 188133) @@ -0,0 +1,13 @@ +html +head +link rel=stylesheet type=text/css media=screen and (min-device-width: 768px) and (max-device-width: 1024px) href="" / +link rel=stylesheet type=text/css media=screen and (max-device-width: 480px) href="" / +script +if (window.testRunner) +testRunner.dumpAsText(); +/script +/head +body id=article +If you see this text, the test has passed. +/body +/html Deleted: trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt (188132 => 188133) --- trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt 2015-08-07 17:30:16 UTC (rev 188132) +++ trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization-expected.txt 2015-08-07 17:30:19 UTC (rev 188133) @@ -1,6 +0,0 @@ -main frame - didStartProvisionalLoadForFrame -main frame - didCommitLoadForFrame -main frame - didFinishDocumentLoadForFrame -main frame - didHandleOnloadEventsForFrame -main frame - didFinishLoadForFrame -If you see this text, the test has passed. Deleted: trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html (188132 => 188133) --- trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html 2015-08-07 17:30:16 UTC (rev 188132) +++ trunk/LayoutTests/platform/ios-sim-deprecated/http/tests/loading/multiple-prioritization.html 2015-08-07 17:30:19 UTC (rev 188133) @@ -1,13 +0,0 @@ -html -head -link rel=stylesheet type=text/css media=screen and (min-device-width: 768px) and (max-device-width: 1024px) href="" / -link rel=stylesheet type=text/css media=screen and (max-device-width: 480px) href="" / -script -if (window.testRunner) -testRunner.dumpAsText(); -/script -/head -body id=article -If you see this text, the test has passed. -/body -/html ___ webkit-changes mailing list
[webkit-changes] [188144] trunk
Title: [188144] trunk Revision 188144 Author cdu...@apple.com Date 2015-08-07 11:51:00 -0700 (Fri, 07 Aug 2015) Log Message Source/_javascript_Core: Interpreter::unwind shouldn't be responsible for assigning the correct scope. https://bugs.webkit.org/show_bug.cgi?id=147666 Patch by Saam barati saambara...@gmail.com on 2015-08-07 Reviewed by Geoffrey Garen. If we make the bytecode generator know about every local scope it creates, and if we give each local scope a unique register, the bytecode generator has all the information it needs to assign the correct scope to a catch handler. Because the bytecode generator knows this information, it's a better separation of responsibilties for it to set up the proper scope instead of relying on the exception handling runtime to find the scope. * bytecode/BytecodeList.json: * bytecode/BytecodeUseDef.h: (JSC::computeUsesForBytecodeOffset): * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dumpBytecode): (JSC::CodeBlock::CodeBlock): * bytecode/HandlerInfo.h: (JSC::UnlinkedHandlerInfo::UnlinkedHandlerInfo): (JSC::HandlerInfo::initialize): * bytecompiler/BytecodeGenerator.cpp: (JSC::BytecodeGenerator::generate): (JSC::BytecodeGenerator::pushLexicalScopeInternal): (JSC::BytecodeGenerator::emitGetScope): (JSC::BytecodeGenerator::emitPushWithScope): (JSC::BytecodeGenerator::emitGetParentScope): (JSC::BytecodeGenerator::emitPopScope): (JSC::BytecodeGenerator::emitPopWithScope): (JSC::BytecodeGenerator::allocateAndEmitScope): (JSC::BytecodeGenerator::emitComplexPopScopes): (JSC::BytecodeGenerator::pushTry): (JSC::BytecodeGenerator::popTryAndEmitCatch): (JSC::BytecodeGenerator::localScopeDepth): (JSC::BytecodeGenerator::calculateTargetScopeDepthForExceptionHandler): Deleted. * bytecompiler/BytecodeGenerator.h: * bytecompiler/NodesCodegen.cpp: (JSC::WithNode::emitBytecode): * interpreter/Interpreter.cpp: (JSC::Interpreter::unwind): * jit/JITOpcodes.cpp: (JSC::JIT::emit_op_push_with_scope): (JSC::JIT::compileOpStrictEq): * jit/JITOpcodes32_64.cpp: (JSC::JIT::emit_op_push_with_scope): (JSC::JIT::emit_op_to_number): * jit/JITOperations.cpp: * jit/JITOperations.h: * llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): * llint/LLIntSlowPaths.h: * llint/LowLevelInterpreter.asm: * runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL): * runtime/CommonSlowPaths.h: * runtime/JSScope.cpp: (JSC::JSScope::objectAtScope): (JSC::isUnscopable): (JSC::JSScope::depth): Deleted. * runtime/JSScope.h: Source/WebCore: Fix WinCairo build after r188130. Patch by Alex Christensen achristen...@webkit.org on 2015-08-07 * platform/graphics/win/FontCustomPlatformDataCairo.cpp: (WebCore::FontCustomPlatformData::~FontCustomPlatformData): (WebCore::FontCustomPlatformData::fontPlatformData): I forgot the parameter name. Source/WebKit2: Move concrete KeyedDecoder/Encoder implementations to WebCore. https://bugs.webkit.org/show_bug.cgi?id=147757. Patch by Brady Eidson beid...@apple.com on 2015-08-07 Rubberstamped by Andy Estes. * DatabaseProcess/IndexedDB/IDBSerialization.cpp: (WebKit::serializeIDBKeyPath): (WebKit::deserializeIDBKeyPath): (WebKit::serializeIDBKeyData): (WebKit::deserializeIDBKeyData): * PlatformEfl.cmake: * PlatformGTK.cmake: * WebKit2.xcodeproj/project.pbxproj: Source/WTF: Unreviewed, roll out http://trac.webkit.org/changeset/187972. Patch by Filip Pizlo fpi...@apple.com on 2015-08-05 * wtf/Atomics.cpp: (WTF::getSwapLock): (WTF::atomicStep): * wtf/MessageQueue.h: (WTF::MessageQueue::infiniteTime): (WTF::MessageQueueDataType::append): (WTF::MessageQueueDataType::appendAndKill): (WTF::MessageQueueDataType::appendAndCheckEmpty): (WTF::MessageQueueDataType::prepend): (WTF::MessageQueueDataType::removeIf): (WTF::MessageQueueDataType::isEmpty): (WTF::MessageQueueDataType::kill): (WTF::MessageQueueDataType::killed): * wtf/ParallelJobsGeneric.cpp: (WTF::ParallelEnvironment::ThreadPrivate::execute): (WTF::ParallelEnvironment::ThreadPrivate::waitForFinish): (WTF::ParallelEnvironment::ThreadPrivate::workerThread): * wtf/ParallelJobsGeneric.h: * wtf/RunLoop.cpp: (WTF::RunLoop::performWork): (WTF::RunLoop::dispatch): * wtf/RunLoop.h: * wtf/ThreadSpecificWin.cpp: (WTF::destructorsList): (WTF::destructorsMutex): (WTF::threadSpecificKeyCreate): (WTF::threadSpecificKeyDelete): (WTF::ThreadSpecificThreadExit): * wtf/Threading.cpp: (WTF::threadEntryPoint): (WTF::createThread): * wtf/ThreadingPrimitives.h: * wtf/ThreadingPthreads.cpp: (WTF::threadMapMutex): (WTF::initializeThreading): (WTF::identifierByPthreadHandle): (WTF::establishIdentifierForPthreadHandle): (WTF::changeThreadPriority): (WTF::waitForThreadCompletion): (WTF::detachThread): (WTF::threadDidExit): (WTF::currentThread): (WTF::Mutex::Mutex): (WTF::Mutex::~Mutex): (WTF::Mutex::lock): (WTF::Mutex::tryLock): (WTF::Mutex::unlock): (WTF::ThreadCondition::~ThreadCondition): (WTF::ThreadCondition::wait): (WTF::ThreadCondition::timedWait): (WTF::DeprecatedMutex::DeprecatedMutex): Deleted. (WTF::DeprecatedMutex::~DeprecatedMutex):
[webkit-changes] [188134] trunk/LayoutTests
Title: [188134] trunk/LayoutTests Revision 188134 Author simon.fra...@apple.com Date 2015-08-07 10:30:21 -0700 (Fri, 07 Aug 2015) Log Message ios-sim-deprecated/iphone/fast/events/touch/ already existed in fast/events/touch, so remove them. * platform/ios-sim-deprecated/iphone/fast/events/touch/document-create-touch-list-ios-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/document-create-touch-list-ios.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/gesture-event-basic-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/gesture-event-basic.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/input-touch-target-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/input-touch-target.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/inserted-fragment-touch-target-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/inserted-fragment-touch-target.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/moved-touch-target-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/moved-touch-target.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/multi-touch-some-without-handlers-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/multi-touch-some-without-handlers.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/ontouchstart-active-selector-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/ontouchstart-active-selector.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/removed-fragment-touch-target-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/removed-fragment-touch-target.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/removed-touch-target-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/removed-touch-target.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/TEMPLATE.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/document-create-touch-list-ios.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/input-touch-target.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/multi-touch-some-without-handlers.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/text-node-touch-target.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/textarea-touch-target.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/touch-event-frames.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/touch-event-pageXY.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/script-tests/zoomed-touch-event-pageXY.js: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/text-node-touch-target-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/text-node-touch-target.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/textarea-touch-target-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/textarea-touch-target.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-frames-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-frames.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-pageXY-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/touch-event-pageXY.html: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/zoomed-touch-event-pageXY-expected.txt: Removed. * platform/ios-sim-deprecated/iphone/fast/events/touch/zoomed-touch-event-pageXY.html: Removed. Modified Paths trunk/LayoutTests/ChangeLog Removed Paths trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/document-create-touch-list-ios-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/document-create-touch-list-ios.html trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/gesture-event-basic-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/gesture-event-basic.html trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/input-touch-target-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/input-touch-target.html trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/inserted-fragment-touch-target-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/inserted-fragment-touch-target.html trunk/LayoutTests/platform/ios-sim-deprecated/iphone/fast/events/touch/moved-touch-target-expected.txt
[webkit-changes] [188132] trunk/LayoutTests
Title: [188132] trunk/LayoutTests Revision 188132 Author simon.fra...@apple.com Date 2015-08-07 10:30:16 -0700 (Fri, 07 Aug 2015) Log Message Move ios-sim-deprecated/fast/dom/ tests into fast/dom * TestExpectations: * fast/dom/Range/expand-word-with-apostrophe-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe-expected.txt. * fast/dom/Range/expand-word-with-apostrophe.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe.html. * fast/dom/Window/no-window-resize-on-document-size-change-expected.txt: Added. * fast/dom/Window/no-window-resize-on-document-size-change.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Window/no-window-resize-on-document-size-change.html. * fast/dom/adopt-attribute-crash-expected.txt: * fast/dom/navigator-iOS-userAgent-expected.txt: Added. * fast/dom/navigator-iOS-userAgent.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/navigator-iOS-userAgent.html. * fast/dom/timer-fire-after-page-pause-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause-expected.txt. * fast/dom/timer-fire-after-page-pause.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause.html. * platform/ios-sim-deprecated/fast/dom/Window/no-window-resize-on-document-size-change-expected.txt: Removed. * platform/ios-sim-deprecated/fast/dom/navigator-iOS-userAgent-expected.txt: Removed. * platform/ios-simulator-wk1/TestExpectations: * platform/ios-simulator/TestExpectations: * platform/ios-simulator/fast/dom/navigator-iOS-userAgent-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/fast/dom/adopt-attribute-crash-expected.txt trunk/LayoutTests/platform/ios-simulator/TestExpectations trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations Added Paths trunk/LayoutTests/fast/dom/Range/expand-word-with-apostrophe-expected.txt trunk/LayoutTests/fast/dom/Range/expand-word-with-apostrophe.html trunk/LayoutTests/fast/dom/Window/no-window-resize-on-document-size-change-expected.txt trunk/LayoutTests/fast/dom/Window/no-window-resize-on-document-size-change.html trunk/LayoutTests/fast/dom/navigator-iOS-userAgent-expected.txt trunk/LayoutTests/fast/dom/navigator-iOS-userAgent.html trunk/LayoutTests/fast/dom/timer-fire-after-page-pause-expected.txt trunk/LayoutTests/fast/dom/timer-fire-after-page-pause.html trunk/LayoutTests/platform/ios-simulator/fast/dom/navigator-iOS-userAgent-expected.txt Removed Paths trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe.html trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/Window/no-window-resize-on-document-size-change-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/Window/no-window-resize-on-document-size-change.html trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/navigator-iOS-userAgent-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/navigator-iOS-userAgent.html trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause-expected.txt trunk/LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause.html Diff Modified: trunk/LayoutTests/ChangeLog (188131 => 188132) --- trunk/LayoutTests/ChangeLog 2015-08-07 17:30:11 UTC (rev 188131) +++ trunk/LayoutTests/ChangeLog 2015-08-07 17:30:16 UTC (rev 188132) @@ -1,5 +1,25 @@ 2015-08-06 Simon Fraser simon.fra...@apple.com +Move ios-sim-deprecated/fast/dom/ tests into fast/dom + +* TestExpectations: +* fast/dom/Range/expand-word-with-apostrophe-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe-expected.txt. +* fast/dom/Range/expand-word-with-apostrophe.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Range/expand-word-with-apostrophe.html. +* fast/dom/Window/no-window-resize-on-document-size-change-expected.txt: Added. +* fast/dom/Window/no-window-resize-on-document-size-change.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/Window/no-window-resize-on-document-size-change.html. +* fast/dom/adopt-attribute-crash-expected.txt: +* fast/dom/navigator-iOS-userAgent-expected.txt: Added. +* fast/dom/navigator-iOS-userAgent.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/navigator-iOS-userAgent.html. +* fast/dom/timer-fire-after-page-pause-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause-expected.txt. +* fast/dom/timer-fire-after-page-pause.html: Renamed from LayoutTests/platform/ios-sim-deprecated/fast/dom/timer-fire-after-page-pause.html. +
[webkit-changes] [188131] trunk/LayoutTests
Title: [188131] trunk/LayoutTests
Revision 188131
Author simon.fra...@apple.com
Date 2015-08-07 10:30:11 -0700 (Fri, 07 Aug 2015)
Log Message
Move two ios-sim-deprecated/animations/ tests into animations.
* animations/resources/anim.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/resources/anim.html.
* animations/restart-after-scroll-expected.txt: Copied from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt.
* animations/restart-after-scroll-nested-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt.
* animations/restart-after-scroll-nested.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested.html.
* animations/restart-after-scroll.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll.html.
* platform/ios-sim-deprecated/animations/restart-after-scroll-expected.txt: Removed.
* platform/ios-simulator-wk1/TestExpectations:
* platform/ios-simulator-wk2/TestExpectations:
* platform/ios-simulator/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk1/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations
Added Paths
trunk/LayoutTests/animations/resources/anim.html
trunk/LayoutTests/animations/restart-after-scroll-expected.txt
trunk/LayoutTests/animations/restart-after-scroll-nested-expected.txt
trunk/LayoutTests/animations/restart-after-scroll-nested.html
trunk/LayoutTests/animations/restart-after-scroll.html
Removed Paths
trunk/LayoutTests/platform/ios-sim-deprecated/animations/resources/anim.html
trunk/LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-expected.txt
trunk/LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt
trunk/LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested.html
trunk/LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll.html
Diff
Modified: trunk/LayoutTests/ChangeLog (188130 => 188131)
--- trunk/LayoutTests/ChangeLog 2015-08-07 17:06:26 UTC (rev 188130)
+++ trunk/LayoutTests/ChangeLog 2015-08-07 17:30:11 UTC (rev 188131)
@@ -1,3 +1,17 @@
+2015-08-06 Simon Fraser simon.fra...@apple.com
+
+Move two ios-sim-deprecated/animations/ tests into animations.
+
+* animations/resources/anim.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/resources/anim.html.
+* animations/restart-after-scroll-expected.txt: Copied from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt.
+* animations/restart-after-scroll-nested-expected.txt: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt.
+* animations/restart-after-scroll-nested.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested.html.
+* animations/restart-after-scroll.html: Renamed from LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll.html.
+* platform/ios-sim-deprecated/animations/restart-after-scroll-expected.txt: Removed.
+* platform/ios-simulator-wk1/TestExpectations:
+* platform/ios-simulator-wk2/TestExpectations:
+* platform/ios-simulator/TestExpectations:
+
2015-08-07 Xabier Rodriguez Calvar calva...@igalia.com
[Streams API] Create CountQueuingStrategy object as per spec
Copied: trunk/LayoutTests/animations/resources/anim.html (from rev 188130, trunk/LayoutTests/platform/ios-sim-deprecated/animations/resources/anim.html) (0 => 188131)
--- trunk/LayoutTests/animations/resources/anim.html (rev 0)
+++ trunk/LayoutTests/animations/resources/anim.html 2015-08-07 17:30:11 UTC (rev 188131)
@@ -0,0 +1,34 @@
+style
+@-webkit-keyframes bounce {
+from {
+-webkit-transform: translate3d(0,0,0);
+}
+to {
+-webkit-transform: translate3d(200px,0,0);
+}
+}
+
+#animator {
+position: relative;
+top: 0px;
+width: 100px;
+height: 100px;
+background-color: blue;
+-webkit-animation-name: bounce;
+-webkit-animation-duration: 80ms;
+-webkit-animation-iteration-count: infinite;
+}
+/style
+script
+function sawIterationInChild() {
+// Tell our parent that we animated.
+window.parent.sawIteration();
+}
+
+function startTest() {
+var animator = document.getElementById(animator);
+animator.addEventListener(webkitAnimationIteration, sawIterationInChild, false);
+}
+window.addEventListener(load, startTest, false);
+/script
+div id=animator/div
Copied: trunk/LayoutTests/animations/restart-after-scroll-expected.txt (from rev 188130, trunk/LayoutTests/platform/ios-sim-deprecated/animations/restart-after-scroll-nested-expected.txt) (0
[webkit-changes] [188140] trunk/Source/WebCore
Title: [188140] trunk/Source/WebCore
Revision 188140
Author achristen...@apple.com
Date 2015-08-07 11:22:59 -0700 (Fri, 07 Aug 2015)
Log Message
Fix WinCairo build after r188130.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
Update fontPlatformData parameters.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (188139 => 188140)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 18:11:28 UTC (rev 188139)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 18:22:59 UTC (rev 188140)
@@ -1,3 +1,12 @@
+2015-08-07 Alex Christensen achristen...@webkit.org
+
+Fix WinCairo build after r188130.
+
+* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
+(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
+(WebCore::FontCustomPlatformData::fontPlatformData):
+Update fontPlatformData parameters.
+
2015-08-07 Daniel Bates daba...@apple.com
Attempt to fix the Windows build after http://trac.webkit.org/changeset/188130
Modified: trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp (188139 => 188140)
--- trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp 2015-08-07 18:11:28 UTC (rev 188139)
+++ trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp 2015-08-07 18:22:59 UTC (rev 188140)
@@ -39,8 +39,11 @@
RemoveFontMemResourceEx(m_fontReference);
}
-FontPlatformData FontCustomPlatformData::fontPlatformData(int size, bool bold, bool italic, FontOrientation, FontWidthVariant, FontRenderingMode renderingMode)
+FontPlatformData FontCustomPlatformData::fontPlatformData(const FontDescription, bool bold, bool italic)
{
+int size = fontDescription.computedPixelSize();
+FontRenderingMode renderingMode = fontDescription.renderingMode();
+
LOGFONT logFont;
memset(logFont, 0, sizeof(LOGFONT));
wcsncpy(logFont.lfFaceName, m_name.charactersWithNullTermination().data(), LF_FACESIZE - 1);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188145] trunk/Source/WebCore
Title: [188145] trunk/Source/WebCore
Revision 188145
Author commit-qu...@webkit.org
Date 2015-08-07 12:08:06 -0700 (Fri, 07 Aug 2015)
Log Message
Unreviewed, rolling out r187907.
https://bugs.webkit.org/show_bug.cgi?id=147789
taking a different approach to the fix (Requested by estes on
#webkit).
Reverted changeset:
Crash when following a Google search link to Twitter with
Limit Adult Content enabled.
https://bugs.webkit.org/show_bug.cgi?id=147651
http://trac.webkit.org/changeset/187907
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (188144 => 188145)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 18:51:00 UTC (rev 188144)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 19:08:06 UTC (rev 188145)
@@ -1,3 +1,18 @@
+2015-08-07 Commit Queue commit-qu...@webkit.org
+
+Unreviewed, rolling out r187907.
+https://bugs.webkit.org/show_bug.cgi?id=147789
+
+taking a different approach to the fix (Requested by estes on
+#webkit).
+
+Reverted changeset:
+
+Crash when following a Google search link to Twitter with
+Limit Adult Content enabled.
+https://bugs.webkit.org/show_bug.cgi?id=147651
+http://trac.webkit.org/changeset/187907
+
2015-08-07 Alex Christensen achristen...@webkit.org
Fix WinCairo build after r188130.
Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (188144 => 188145)
--- trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-08-07 18:51:00 UTC (rev 188144)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp 2015-08-07 19:08:06 UTC (rev 188145)
@@ -77,10 +77,6 @@
#include ContentFilter.h
#endif
-#if HAVE(PARENTAL_CONTROLS)
-#include ParentalControlsContentFilter.h
-#endif
-
namespace WebCore {
static void cancelAll(const ResourceLoaderMap loaders)
@@ -553,19 +549,7 @@
if (!redirectResponse.isNull()) {
// We checked application cache for initial URL, now we need to check it for redirected one.
ASSERT(!m_substituteData.isValid());
-
-bool shouldTryApplicationCache = true;
-
-#if HAVE(PARENTAL_CONTROLS)
-// There are poor interactions between the ApplicationCache and parental controls (rdar://problem/22123707)
-// so, for now, don't use the AppCache for redirects if parental controls are enabled.
-if (ParentalControlsContentFilter::enabled())
-shouldTryApplicationCache = false;
-#endif
-
-if (shouldTryApplicationCache)
-m_applicationCacheHost-maybeLoadMainResourceForRedirect(newRequest, m_substituteData);
-
+m_applicationCacheHost-maybeLoadMainResourceForRedirect(newRequest, m_substituteData);
if (m_substituteData.isValid()) {
RELEASE_ASSERT(m_mainResource);
ResourceLoader* loader = m_mainResource-loader();
@@ -1435,18 +1419,8 @@
if (!m_frame || m_request.isNull())
return;
-bool shouldTryApplicationCache = true;
+m_applicationCacheHost-maybeLoadMainResource(m_request, m_substituteData);
-#if HAVE(PARENTAL_CONTROLS)
-// There are poor interactions between the ApplicationCache and parental controls (rdar://problem/22123707)
-// so, for now, don't use the AppCache for redirects if parental controls are enabled.
-if (ParentalControlsContentFilter::enabled())
-shouldTryApplicationCache = false;
-#endif
-
-if (shouldTryApplicationCache)
-m_applicationCacheHost-maybeLoadMainResource(m_request, m_substituteData);
-
if (m_substituteData.isValid()) {
m_identifierForLoadWithoutResourceLoader = m_frame-page()-progress().createUniqueIdentifier();
frameLoader()-notifier().assignIdentifierToInitialRequest(m_identifierForLoadWithoutResourceLoader, this, m_request);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188138] trunk/Source/WebInspectorUI
Title: [188138] trunk/Source/WebInspectorUI
Revision 188138
Author drou...@apple.com
Date 2015-08-07 10:58:45 -0700 (Fri, 07 Aug 2015)
Log Message
Web Inspector: Option+Up/Down arrow keys should increment/decrement numbers in HTML and SVG attributes
https://bugs.webkit.org/show_bug.cgi?id=147317
Reviewed by Timothy Hatcher.
If the value under the cursor in an HTML element attribute is a number, pressing alt and
up/down will increment/decrement the number value and apply that change to the element.
* UserInterface/Views/BoxModelDetailsSectionRow.js:
(WebInspector.BoxModelDetailsSectionRow.prototype._alteredFloatNumber):
(WebInspector.BoxModelDetailsSectionRow.prototype._handleKeyDown):
* UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._startEditingAttribute):
(WebInspector.DOMTreeElement.prototype._attributeEditingCommitted):
(WebInspector.DOMTreeElement.prototype._attributeNumberEditingCommitted):
* UserInterface/Views/EditingSupport.js:
(WebInspector.EditingConfig.prototype.setNumberCommitHandler):
(WebInspector.startEditing.defaultFinishHandler):
(WebInspector.startEditing.handleEditingResult):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js
trunk/Source/WebInspectorUI/UserInterface/Views/EditingSupport.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (188137 => 188138)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-08-07 17:47:28 UTC (rev 188137)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-08-07 17:58:45 UTC (rev 188138)
@@ -1,3 +1,25 @@
+2015-08-07 Devin Rousso drou...@apple.com
+
+Web Inspector: Option+Up/Down arrow keys should increment/decrement numbers in HTML and SVG attributes
+https://bugs.webkit.org/show_bug.cgi?id=147317
+
+Reviewed by Timothy Hatcher.
+
+If the value under the cursor in an HTML element attribute is a number, pressing alt and
+up/down will increment/decrement the number value and apply that change to the element.
+
+* UserInterface/Views/BoxModelDetailsSectionRow.js:
+(WebInspector.BoxModelDetailsSectionRow.prototype._alteredFloatNumber):
+(WebInspector.BoxModelDetailsSectionRow.prototype._handleKeyDown):
+* UserInterface/Views/DOMTreeElement.js:
+(WebInspector.DOMTreeElement.prototype._startEditingAttribute):
+(WebInspector.DOMTreeElement.prototype._attributeEditingCommitted):
+(WebInspector.DOMTreeElement.prototype._attributeNumberEditingCommitted):
+* UserInterface/Views/EditingSupport.js:
+(WebInspector.EditingConfig.prototype.setNumberCommitHandler):
+(WebInspector.startEditing.defaultFinishHandler):
+(WebInspector.startEditing.handleEditingResult):
+
2015-08-05 Devin Rousso drou...@apple.com
Web Inspector: Move the Metrics style sidebar panel into Computed
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js (188137 => 188138)
--- trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2015-08-07 17:47:28 UTC (rev 188137)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/BoxModelDetailsSectionRow.js 2015-08-07 17:58:45 UTC (rev 188138)
@@ -292,7 +292,7 @@
// Make the new number and constrain it to a precision of 6, this matches numbers the engine returns.
// Use the Number constructor to forget the fixed precision, so 1.10 will print as 1.1.
var result = Number((number + changeAmount).toFixed(6));
-if (!String(result).match(WebInspector.BoxModelDetailsSectionRow.CSSNumberRegex))
+if (!String(result).match(WebInspector.EditingSupport.NumberRegex))
return null;
return result;
@@ -314,10 +314,10 @@
return;
var originalValue = element.textContent;
-var wordRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, WebInspector.BoxModelDetailsSectionRow.StyleValueDelimiters, element);
+var wordRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, WebInspector.EditingSupport.StyleValueDelimiters, element);
var wordString = wordRange.toString();
-var matches = /(.*?)(-?(?:\d+(?:\.\d+)?|\.\d+))(.*)/.exec(wordString);
+var matches = WebInspector.EditingSupport.NumberRegex.exec(wordString);
var replacementString;
if (matches matches.length) {
var prefix = matches[1];
@@ -439,6 +439,3 @@
this._applyUserInput(element, userInput, previousContent, context, true);
}
};
-
-WebInspector.BoxModelDetailsSectionRow.StyleValueDelimiters = \xA0\t\n\':;,/();
-WebInspector.BoxModelDetailsSectionRow.CSSNumberRegex = /^(-?(?:\d+(?:\.\d+)?|\.\d+))$/;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js (188137 => 188138)
---
[webkit-changes] [188130] trunk/Source/WebCore
Title: [188130] trunk/Source/WebCore Revision 188130 Author mmaxfi...@apple.com Date 2015-08-07 10:06:26 -0700 (Fri, 07 Aug 2015) Log Message Allow FontCustomPlatformData to consult with FontDescription https://bugs.webkit.org/show_bug.cgi?id=147775 Reviewed by Zalan Bujtas. In order to implement font-feature-settings, web fonts need to be able to consult with the set of active font features. Rather than add yet another argument to all the functions in this flow, this patch passes around a reference to the FontDescription itself instead of copies of constituent members of it. No new tests because there is no behavior change. * css/CSSFontFaceSource.cpp: (WebCore::CSSFontFaceSource::font): * loader/cache/CachedFont.cpp: (WebCore::CachedFont::createFont): (WebCore::CachedFont::platformDataFromCustomData): * loader/cache/CachedFont.h: * loader/cache/CachedSVGFont.cpp: (WebCore::CachedSVGFont::platformDataFromCustomData): * loader/cache/CachedSVGFont.h: * platform/graphics/cairo/FontCustomPlatformData.h: * platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): * platform/graphics/freetype/FontPlatformData.h: * platform/graphics/freetype/FontPlatformDataFreeType.cpp: (WebCore::FontPlatformData::FontPlatformData): * platform/graphics/freetype/SimpleFontDataFreeType.cpp: (WebCore::Font::platformCreateScaledFont): * platform/graphics/mac/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): * platform/graphics/mac/FontCustomPlatformData.h: * platform/graphics/win/FontCustomPlatformData.cpp: (WebCore::FontCustomPlatformData::fontPlatformData): * platform/graphics/win/FontCustomPlatformData.h: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/css/CSSFontFaceSource.cpp trunk/Source/WebCore/loader/cache/CachedFont.cpp trunk/Source/WebCore/loader/cache/CachedFont.h trunk/Source/WebCore/loader/cache/CachedSVGFont.cpp trunk/Source/WebCore/loader/cache/CachedSVGFont.h trunk/Source/WebCore/platform/graphics/cairo/FontCustomPlatformData.h trunk/Source/WebCore/platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp trunk/Source/WebCore/platform/graphics/freetype/FontPlatformData.h trunk/Source/WebCore/platform/graphics/freetype/FontPlatformDataFreeType.cpp trunk/Source/WebCore/platform/graphics/freetype/SimpleFontDataFreeType.cpp trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.cpp trunk/Source/WebCore/platform/graphics/mac/FontCustomPlatformData.h trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.cpp trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformData.h Diff Modified: trunk/Source/WebCore/ChangeLog (188129 => 188130) --- trunk/Source/WebCore/ChangeLog 2015-08-07 17:04:31 UTC (rev 188129) +++ trunk/Source/WebCore/ChangeLog 2015-08-07 17:06:26 UTC (rev 188130) @@ -1,3 +1,42 @@ +2015-08-07 Myles C. Maxfield mmaxfi...@apple.com + +Allow FontCustomPlatformData to consult with FontDescription +https://bugs.webkit.org/show_bug.cgi?id=147775 + +Reviewed by Zalan Bujtas. + +In order to implement font-feature-settings, web fonts need to be +able to consult with the set of active font features. Rather than +add yet another argument to all the functions in this flow, this +patch passes around a reference to the FontDescription itself instead +of copies of constituent members of it. + +No new tests because there is no behavior change. + +* css/CSSFontFaceSource.cpp: +(WebCore::CSSFontFaceSource::font): +* loader/cache/CachedFont.cpp: +(WebCore::CachedFont::createFont): +(WebCore::CachedFont::platformDataFromCustomData): +* loader/cache/CachedFont.h: +* loader/cache/CachedSVGFont.cpp: +(WebCore::CachedSVGFont::platformDataFromCustomData): +* loader/cache/CachedSVGFont.h: +* platform/graphics/cairo/FontCustomPlatformData.h: +* platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp: +(WebCore::FontCustomPlatformData::fontPlatformData): +* platform/graphics/freetype/FontPlatformData.h: +* platform/graphics/freetype/FontPlatformDataFreeType.cpp: +(WebCore::FontPlatformData::FontPlatformData): +* platform/graphics/freetype/SimpleFontDataFreeType.cpp: +(WebCore::Font::platformCreateScaledFont): +* platform/graphics/mac/FontCustomPlatformData.cpp: +(WebCore::FontCustomPlatformData::fontPlatformData): +* platform/graphics/mac/FontCustomPlatformData.h: +* platform/graphics/win/FontCustomPlatformData.cpp: +(WebCore::FontCustomPlatformData::fontPlatformData): +* platform/graphics/win/FontCustomPlatformData.h: + 2015-08-07 Xabier Rodriguez Calvar calva...@igalia.com [Streams API] Create CountQueuingStrategy object as per spec Modified: trunk/Source/WebCore/css/CSSFontFaceSource.cpp (188129 =>
[webkit-changes] [188141] trunk/Source/WebCore
Title: [188141] trunk/Source/WebCore
Revision 188141
Author achristen...@apple.com
Date 2015-08-07 11:27:16 -0700 (Fri, 07 Aug 2015)
Log Message
Fix WinCairo build after r188130.
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
I forgot the parameter name.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (188140 => 188141)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 18:22:59 UTC (rev 188140)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 18:27:16 UTC (rev 188141)
@@ -5,6 +5,15 @@
* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
+I forgot the parameter name.
+
+2015-08-07 Alex Christensen achristen...@webkit.org
+
+Fix WinCairo build after r188130.
+
+* platform/graphics/win/FontCustomPlatformDataCairo.cpp:
+(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
+(WebCore::FontCustomPlatformData::fontPlatformData):
Update fontPlatformData parameters.
2015-08-07 Daniel Bates daba...@apple.com
Modified: trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp (188140 => 188141)
--- trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp 2015-08-07 18:22:59 UTC (rev 188140)
+++ trunk/Source/WebCore/platform/graphics/win/FontCustomPlatformDataCairo.cpp 2015-08-07 18:27:16 UTC (rev 188141)
@@ -39,7 +39,7 @@
RemoveFontMemResourceEx(m_fontReference);
}
-FontPlatformData FontCustomPlatformData::fontPlatformData(const FontDescription, bool bold, bool italic)
+FontPlatformData FontCustomPlatformData::fontPlatformData(const FontDescription fontDescription, bool bold, bool italic)
{
int size = fontDescription.computedPixelSize();
FontRenderingMode renderingMode = fontDescription.renderingMode();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188154] branches/safari-601.1.46-branch/Source/WebKit2
Title: [188154] branches/safari-601.1.46-branch/Source/WebKit2 Revision 188154 Author lforsch...@apple.com Date 2015-08-07 13:16:45 -0700 (Fri, 07 Aug 2015) Log Message Merged r188111. rdar://problem/22128839 Modified Paths branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188153 => 188154) --- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:15:38 UTC (rev 188153) +++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:16:45 UTC (rev 188154) @@ -1,5 +1,15 @@ 2015-08-07 Lucas Forschler lforsch...@apple.com +Merge r188111 + +2015-08-06 Dan Bernstein m...@apple.com + +Fixed the non-HAVE(LINK_PREVIEW) build. + +* UIProcess/ios/WKContentViewInteraction.mm: + +2015-08-07 Lucas Forschler lforsch...@apple.com + Merge r188109 2015-08-06 Enrica Casucci enr...@apple.com Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188153 => 188154) --- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:15:38 UTC (rev 188153) +++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:16:45 UTC (rev 188154) @@ -220,8 +220,10 @@ @end @protocol UISelectionInteractionAssistant; +#if HAVE(LINK_PREVIEW) @interface UIPreviewItemController (StagingToRemove) @property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer; +#endif @end #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188153] branches/safari-601.1.46-branch/Source/WebKit2
Title: [188153] branches/safari-601.1.46-branch/Source/WebKit2 Revision 188153 Author lforsch...@apple.com Date 2015-08-07 13:15:38 -0700 (Fri, 07 Aug 2015) Log Message Merged r188109. rdar://problem/22128839 Modified Paths branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188152 => 188153) --- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:14:32 UTC (rev 188152) +++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:15:38 UTC (rev 188153) @@ -1,5 +1,20 @@ 2015-08-07 Lucas Forschler lforsch...@apple.com +Merge r188109 + +2015-08-06 Enrica Casucci enr...@apple.com + +Cleanup action sheet only when long press is canceled (non ended). +https://bugs.webkit.org/show_bug.cgi?id=147766 +rdar://problem/22181842 + +Reviewed by Tim Horton. + +* UIProcess/ios/WKContentViewInteraction.mm: +(-[WKContentView _longPressRecognized:]): + +2015-08-07 Lucas Forschler lforsch...@apple.com + Merge r188058 2015-08-06 Enrica Casucci enr...@apple.com Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188152 => 188153) --- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:14:32 UTC (rev 188152) +++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:15:38 UTC (rev 188153) @@ -1094,7 +1094,6 @@ } break; case UIGestureRecognizerStateCancelled: -case UIGestureRecognizerStateEnded: [_actionSheetAssistant cleanupSheet]; break; default: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188157] trunk/Tools
Title: [188157] trunk/Tools
Revision 188157
Author ander...@apple.com
Date 2015-08-07 13:35:24 -0700 (Fri, 07 Aug 2015)
Log Message
Simplify WKTR's view options
https://bugs.webkit.org/show_bug.cgi?id=147791
Reviewed by Sam Weinig.
Instead of using a WKDictionaryRef, just use a struct for the options.
* WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::options):
(WTR::PlatformWebView::viewSupportsOptions): Deleted.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::ensureViewSupportsOptions):
(WTR::TestController::updateLayoutTypeForTest):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/ViewOptions.h: Added.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformConfigureViewForTest):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/PlatformWebView.h
trunk/Tools/WebKitTestRunner/TestController.cpp
trunk/Tools/WebKitTestRunner/TestController.h
trunk/Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj
trunk/Tools/WebKitTestRunner/efl/PlatformWebViewEfl.cpp
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp
trunk/Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm
trunk/Tools/WebKitTestRunner/mac/PlatformWebViewMac.mm
trunk/Tools/WebKitTestRunner/mac/TestControllerMac.mm
Added Paths
trunk/Tools/WebKitTestRunner/ViewOptions.h
Diff
Modified: trunk/Tools/ChangeLog (188156 => 188157)
--- trunk/Tools/ChangeLog 2015-08-07 20:19:20 UTC (rev 188156)
+++ trunk/Tools/ChangeLog 2015-08-07 20:35:24 UTC (rev 188157)
@@ -1,3 +1,36 @@
+2015-08-07 Anders Carlsson ander...@apple.com
+
+Simplify WKTR's view options
+https://bugs.webkit.org/show_bug.cgi?id=147791
+
+Reviewed by Sam Weinig.
+
+Instead of using a WKDictionaryRef, just use a struct for the options.
+
+* WebKitTestRunner/PlatformWebView.h:
+(WTR::PlatformWebView::options):
+(WTR::PlatformWebView::viewSupportsOptions): Deleted.
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::initialize):
+(WTR::TestController::createWebViewWithOptions):
+(WTR::TestController::ensureViewSupportsOptions):
+(WTR::TestController::updateLayoutTypeForTest):
+* WebKitTestRunner/TestController.h:
+* WebKitTestRunner/ViewOptions.h: Added.
+* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
+* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
+(WTR::PlatformWebView::PlatformWebView):
+(WTR::PlatformWebView::viewSupportsOptions):
+* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+(WTR::PlatformWebView::viewSupportsOptions):
+* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
+(WTR::PlatformWebView::viewSupportsOptions):
+* WebKitTestRunner/mac/PlatformWebViewMac.mm:
+(WTR::PlatformWebView::PlatformWebView):
+(WTR::PlatformWebView::viewSupportsOptions):
+* WebKitTestRunner/mac/TestControllerMac.mm:
+(WTR::TestController::platformConfigureViewForTest):
+
2015-08-07 Joseph Pecoraro pecor...@apple.com
Running tests for a long time results in some tests running very slowly (throttling)
Modified: trunk/Tools/WebKitTestRunner/PlatformWebView.h (188156 => 188157)
--- trunk/Tools/WebKitTestRunner/PlatformWebView.h 2015-08-07 20:19:20 UTC (rev 188156)
+++ trunk/Tools/WebKitTestRunner/PlatformWebView.h 2015-08-07 20:35:24 UTC (rev 188157)
@@ -26,6 +26,7 @@
#ifndef PlatformWebView_h
#define PlatformWebView_h
+#include ViewOptions.h
#include WebKit/WKRetainPtr.h
#if defined(__APPLE__) __APPLE__
@@ -51,7 +52,7 @@
class PlatformWebView {
public:
-PlatformWebView(WKContextRef, WKPageGroupRef, WKPageRef relatedPage, WKDictionaryRef options = 0);
+PlatformWebView(WKContextRef, WKPageGroupRef, WKPageRef relatedPage, const ViewOptions);
~PlatformWebView();
WKPageRef page();
@@ -74,14 +75,10 @@
void setWindowIsKey(bool isKey) { m_windowIsKey = isKey; }
bool windowIsKey() const { return m_windowIsKey; }
-#if PLATFORM(COCOA) || PLATFORM(EFL)
-bool viewSupportsOptions(WKDictionaryRef) const;
-#else
-bool viewSupportsOptions(WKDictionaryRef) const { return true; }
-#endif
+bool viewSupportsOptions(const ViewOptions) const;
WKRetainPtrWKImageRef windowSnapshotImage();
-WKDictionaryRef options() const { return
[webkit-changes] [188159] trunk/LayoutTests
Title: [188159] trunk/LayoutTests Revision 188159 Author simon.fra...@apple.com Date 2015-08-07 14:07:40 -0700 (Fri, 07 Aug 2015) Log Message Move platform/mac/fast/forms/ tests to fast/forms/ * TestExpectations: * fast/forms/attributed-strings-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/attributed-strings-expected.txt. * fast/forms/attributed-strings.html: Renamed from LayoutTests/platform/mac/fast/forms/attributed-strings.html. * fast/forms/focus-option-control-on-page-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/focus-option-control-on-page-expected.txt. * fast/forms/focus-option-control-on-page.html: Renamed from LayoutTests/platform/mac/fast/forms/focus-option-control-on-page.html. * fast/forms/indeterminate-progress-inline-height-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height-expected.txt. * fast/forms/indeterminate-progress-inline-height.html: Renamed from LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height.html. * fast/forms/input-appearance-spinbutton-expected.png: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-expected.png. * fast/forms/input-appearance-spinbutton-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt. * fast/forms/input-appearance-spinbutton-size-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-size-expected.txt. * fast/forms/input-appearance-spinbutton-size.html: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-size.html. * fast/forms/input-appearance-spinbutton-up-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt. * fast/forms/input-appearance-spinbutton-up.html: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton-up.html. * fast/forms/input-appearance-spinbutton.html: Renamed from LayoutTests/platform/mac/fast/forms/input-appearance-spinbutton.html. * fast/forms/input-number-click-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/input-number-click-expected.txt. * fast/forms/input-number-click.html: Renamed from LayoutTests/platform/mac/fast/forms/input-number-click.html. * fast/forms/listbox-scrollbar-hit-test-expected.txt: Renamed from LayoutTests/platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt. * fast/forms/listbox-scrollbar-hit-test.html: Renamed from LayoutTests/platform/mac/fast/forms/listbox-scrollbar-hit-test.html. * fast/forms/script-tests/focus-option-control-on-page.js: Renamed from LayoutTests/platform/mac/fast/forms/script-tests/focus-option-control-on-page.js. * platform/mac-wk1/TestExpectations: * platform/mac-wk2/TestExpectations: * platform/mac/TestExpectations: * platform/mac/fast/forms/input-appearance-spinbutton-up-expected.png: Removed. * platform/wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/mac/TestExpectations trunk/LayoutTests/platform/mac-wk1/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations trunk/LayoutTests/platform/wk2/TestExpectations Added Paths trunk/LayoutTests/fast/forms/attributed-strings-expected.txt trunk/LayoutTests/fast/forms/attributed-strings.html trunk/LayoutTests/fast/forms/focus-option-control-on-page-expected.txt trunk/LayoutTests/fast/forms/focus-option-control-on-page.html trunk/LayoutTests/fast/forms/indeterminate-progress-inline-height-expected.txt trunk/LayoutTests/fast/forms/indeterminate-progress-inline-height.html trunk/LayoutTests/fast/forms/input-appearance-spinbutton-expected.png trunk/LayoutTests/fast/forms/input-appearance-spinbutton-expected.txt trunk/LayoutTests/fast/forms/input-appearance-spinbutton-size-expected.txt trunk/LayoutTests/fast/forms/input-appearance-spinbutton-size.html trunk/LayoutTests/fast/forms/input-appearance-spinbutton-up-expected.txt trunk/LayoutTests/fast/forms/input-appearance-spinbutton-up.html trunk/LayoutTests/fast/forms/input-appearance-spinbutton.html trunk/LayoutTests/fast/forms/input-number-click-expected.txt trunk/LayoutTests/fast/forms/input-number-click.html trunk/LayoutTests/fast/forms/listbox-scrollbar-hit-test-expected.txt trunk/LayoutTests/fast/forms/listbox-scrollbar-hit-test.html trunk/LayoutTests/fast/forms/script-tests/ trunk/LayoutTests/fast/forms/script-tests/focus-option-control-on-page.js Removed Paths trunk/LayoutTests/platform/mac/fast/forms/attributed-strings-expected.txt trunk/LayoutTests/platform/mac/fast/forms/attributed-strings.html trunk/LayoutTests/platform/mac/fast/forms/focus-option-control-on-page-expected.txt trunk/LayoutTests/platform/mac/fast/forms/focus-option-control-on-page.html trunk/LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height-expected.txt trunk/LayoutTests/platform/mac/fast/forms/indeterminate-progress-inline-height.html
[webkit-changes] [188148] trunk
Title: [188148] trunk
Revision 188148
Author d...@apple.com
Date 2015-08-07 12:40:45 -0700 (Fri, 07 Aug 2015)
Log Message
Shadows don't draw on fillText when using a gradient fill
https://bugs.webkit.org/show_bug.cgi?id=147758
rdar://problem/20860912
Reviewed by Myles Maxfield.
Source/WebCore:
Since we use a mask to render a pattern or gradient
into text, any shadow was being clipped out. Change
this to draw the shadow before the mask + fill operation,
using a technique similar to text-shadow.
Test: fast/canvas/gradient-text-with-shadow.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawTextInternal): Get the current shadow
style, paint the text with a transformed shadow offset so that we only
see the shadow and not the text, then combine with the existing pattern/gradient
fill.
LayoutTests:
New test that exercises shadows on gradient fills. This really
should be a ref test, but there is a very small rendering difference
caused by masking, so instead it uses JS to look for pixels of
the correct color.
* fast/canvas/gradient-text-with-shadow-expected.txt: Added.
* fast/canvas/gradient-text-with-shadow.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp
Added Paths
trunk/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt
trunk/LayoutTests/fast/canvas/gradient-text-with-shadow.html
Diff
Modified: trunk/LayoutTests/ChangeLog (188147 => 188148)
--- trunk/LayoutTests/ChangeLog 2015-08-07 19:34:13 UTC (rev 188147)
+++ trunk/LayoutTests/ChangeLog 2015-08-07 19:40:45 UTC (rev 188148)
@@ -1,3 +1,19 @@
+2015-08-06 Dean Jackson d...@apple.com
+
+Shadows don't draw on fillText when using a gradient fill
+https://bugs.webkit.org/show_bug.cgi?id=147758
+rdar://problem/20860912
+
+Reviewed by Myles Maxfield.
+
+New test that exercises shadows on gradient fills. This really
+should be a ref test, but there is a very small rendering difference
+caused by masking, so instead it uses JS to look for pixels of
+the correct color.
+
+* fast/canvas/gradient-text-with-shadow-expected.txt: Added.
+* fast/canvas/gradient-text-with-shadow.html: Added.
+
2015-08-07 Myles C. Maxfield mmaxfi...@apple.com
Implement font-feature-settings
Added: trunk/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt (0 => 188148)
--- trunk/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt 2015-08-07 19:40:45 UTC (rev 188148)
@@ -0,0 +1 @@
+PASSED
Property changes on: trunk/LayoutTests/fast/canvas/gradient-text-with-shadow-expected.txt
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Added: trunk/LayoutTests/fast/canvas/gradient-text-with-shadow.html (0 => 188148)
--- trunk/LayoutTests/fast/canvas/gradient-text-with-shadow.html (rev 0)
+++ trunk/LayoutTests/fast/canvas/gradient-text-with-shadow.html 2015-08-07 19:40:45 UTC (rev 188148)
@@ -0,0 +1,43 @@
+script
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+function runTest() {
+
+var canvas = document.querySelector(canvas);
+var context = canvas.getContext('2d');
+
+context.shadowOffsetX = 0;
+context.shadowOffsetY = 10;
+context.shadowBlur = 0;
+context.shadowColor = rgb(255, 0, 0);
+
+context.font = 80px sans-serif;
+
+var gradient = context.createLinearGradient(0, 0, 0, 100);
+gradient.addColorStop(0, blue);
+gradient.addColorStop(1, blue);
+
+context.fillStyle = gradient;
+context.fillText(hello, 10, 95);
+
+// If we correctly drew the shadow, there will be some
+// red pixels along the bottom line of the canvas.
+
+var buffer = context.getImageData(0, canvas.height - 1, canvas.width, 1);
+var passed = false;
+for (var i = 0; i canvas.width; ++i) {
+if (buffer.data[i * 4] 0) {
+passed = true;
+break;
+}
+}
+document.querySelector(p).textContent = passed ? PASSED : FAILED;
+}
+
+window.addEventListener(load, runTest, false);
+
+/script
+canvas width=200 height=100/canvas
+p/p
\ No newline at end of file
Property changes on: trunk/LayoutTests/fast/canvas/gradient-text-with-shadow.html
___
Added: svn:mime-type
Added: svn:keywords
Added: svn:eol-style
Modified: trunk/Source/WebCore/ChangeLog (188147 => 188148)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 19:34:13 UTC (rev 188147)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 19:40:45 UTC (rev 188148)
@@ -1,3 +1,24 @@
+2015-08-06 Dean Jackson d...@apple.com
+
+Shadows don't draw on fillText when using a gradient fill
+
[webkit-changes] [188149] branches/jsc-tailcall/Source/JavaScriptCore
Title: [188149] branches/jsc-tailcall/Source/_javascript_Core
Revision 188149
Author msab...@apple.com
Date 2015-08-07 13:06:24 -0700 (Fri, 07 Aug 2015)
Log Message
Unreviewed. Rollout r188072 as there are crashes with release builds.
The combination of r188071 and r188072 does not properly restore all registers for
all exceptions. Rolling out to make the branch functional again.
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter64.asm:
Modified Paths
branches/jsc-tailcall/Source/_javascript_Core/ChangeLog
branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm
branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter64.asm
Diff
Modified: branches/jsc-tailcall/Source/_javascript_Core/ChangeLog (188148 => 188149)
--- branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-08-07 19:40:45 UTC (rev 188148)
+++ branches/jsc-tailcall/Source/_javascript_Core/ChangeLog 2015-08-07 20:06:24 UTC (rev 188149)
@@ -1,3 +1,13 @@
+2015-08-07 Michael Saboff msab...@apple.com
+
+Unreviewed. Rollout r188072 as there are crashes with release builds.
+
+The combination of r188071 and r188072 does not properly restore all registers for
+all exceptions. Rolling out to make the branch functional again.
+
+* llint/LowLevelInterpreter.asm:
+* llint/LowLevelInterpreter64.asm:
+
2015-08-06 Michael Saboff msab...@apple.com
jsc-tailcall: Stop saving and restoring all callee saves on vmEntry / exit for platforms with per function callee saves handling
Modified: branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm (188148 => 188149)
--- branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2015-08-07 19:40:45 UTC (rev 188148)
+++ branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter.asm 2015-08-07 20:06:24 UTC (rev 188149)
@@ -397,15 +397,18 @@
end
end
-# ARM64 and the X86 64 bit platforms properly save and restore callee saves in each function.
-if C_LOOP or ARM64 or X86_64 or X86_64_WIN
+if C_LOOP
const CalleeSaveRegisterCount = 0
elsif ARM or ARMv7_TRADITIONAL or ARMv7
const CalleeSaveRegisterCount = 7
-elsif SH4 or MIPS
+elsif ARM64
+const CalleeSaveRegisterCount = 10
+elsif SH4 or X86_64 or MIPS
const CalleeSaveRegisterCount = 5
elsif X86 or X86_WIN
const CalleeSaveRegisterCount = 3
+elsif X86_64_WIN
+const CalleeSaveRegisterCount = 7
end
const CalleeRegisterSaveSize = CalleeSaveRegisterCount * PtrSize
@@ -415,11 +418,17 @@
const VMEntryTotalFrameSize = (CalleeRegisterSaveSize + sizeof VMEntryRecord + StackAlignment - 1) ~StackAlignmentMask
macro pushCalleeSaves()
-if C_LOOP or ARM64 or X86_64 or X86_64_WIN
+if C_LOOP
elsif ARM or ARMv7_TRADITIONAL
emit push {r4-r10}
elsif ARMv7
emit push {r4-r6, r8-r11}
+elsif ARM64
+emit stp x20, x19, [sp, #-16]!
+emit stp x22, x21, [sp, #-16]!
+emit stp x24, x23, [sp, #-16]!
+emit stp x26, x25, [sp, #-16]!
+emit stp x28, x27, [sp, #-16]!
elsif MIPS
emit addiu $sp, $sp, -20
emit sw $20, 16($sp)
@@ -441,15 +450,35 @@
emit push esi
emit push edi
emit push ebx
+elsif X86_64
+emit push %r12
+emit push %r13
+emit push %r14
+emit push %r15
+emit push %rbx
+elsif X86_64_WIN
+emit push r12
+emit push r13
+emit push r14
+emit push r15
+emit push rbx
+emit push rdi
+emit push rsi
end
end
macro popCalleeSaves()
-if C_LOOP or ARM64 or X86_64 or X86_64_WIN
+if C_LOOP
elsif ARM or ARMv7_TRADITIONAL
emit pop {r4-r10}
elsif ARMv7
emit pop {r4-r6, r8-r11}
+elsif ARM64
+emit ldp x28, x27, [sp], #16
+emit ldp x26, x25, [sp], #16
+emit ldp x24, x23, [sp], #16
+emit ldp x22, x21, [sp], #16
+emit ldp x20, x19, [sp], #16
elsif MIPS
emit lw $16, 0($sp)
emit lw $17, 4($sp)
@@ -471,6 +500,20 @@
emit pop ebx
emit pop edi
emit pop esi
+elsif X86_64
+emit pop %rbx
+emit pop %r15
+emit pop %r14
+emit pop %r13
+emit pop %r12
+elsif X86_64_WIN
+emit pop rsi
+emit pop rdi
+emit pop rbx
+emit pop r15
+emit pop r14
+emit pop r13
+emit pop r12
end
end
@@ -516,9 +559,10 @@
storep csr3, -16[cfr]
storep csr0, -24[cfr]
elsif X86_64_WIN
-storep csr6, -8[cfr]
-storep csr5, -16[cfr]
-storep csr0, -24[cfr]
+storep t4, -8[cfr]
+storep csr6, -16[cfr]
+storep csr5, -24[cfr]
+storep csr0, -32[cfr]
end
end
Modified: branches/jsc-tailcall/Source/_javascript_Core/llint/LowLevelInterpreter64.asm (188148 => 188149)
---
[webkit-changes] [188158] trunk/Tools
Title: [188158] trunk/Tools Revision 188158 Author a...@apple.com Date 2015-08-07 13:45:52 -0700 (Fri, 07 Aug 2015) Log Message Update AppEngine app version numbers to the latest commit. * QueueStatusServer/app.yaml: * TestResultServer/app.yaml: Modified Paths trunk/Tools/ChangeLog trunk/Tools/QueueStatusServer/app.yaml trunk/Tools/TestResultServer/app.yaml Diff Modified: trunk/Tools/ChangeLog (188157 => 188158) --- trunk/Tools/ChangeLog 2015-08-07 20:35:24 UTC (rev 188157) +++ trunk/Tools/ChangeLog 2015-08-07 20:45:52 UTC (rev 188158) @@ -1,3 +1,10 @@ +2015-08-07 Alexey Proskuryakov a...@apple.com + +Update AppEngine app version numbers to the latest commit. + +* QueueStatusServer/app.yaml: +* TestResultServer/app.yaml: + 2015-08-07 Anders Carlsson ander...@apple.com Simplify WKTR's view options Modified: trunk/Tools/QueueStatusServer/app.yaml (188157 => 188158) --- trunk/Tools/QueueStatusServer/app.yaml 2015-08-07 20:35:24 UTC (rev 188157) +++ trunk/Tools/QueueStatusServer/app.yaml 2015-08-07 20:45:52 UTC (rev 188158) @@ -1,5 +1,5 @@ application: webkit-queues -version: 178455 # SVN revision of last major change +version: 187975 # SVN revision of last major change runtime: python27 threadsafe: false api_version: 1 Modified: trunk/Tools/TestResultServer/app.yaml (188157 => 188158) --- trunk/Tools/TestResultServer/app.yaml 2015-08-07 20:35:24 UTC (rev 188157) +++ trunk/Tools/TestResultServer/app.yaml 2015-08-07 20:45:52 UTC (rev 188158) @@ -1,5 +1,5 @@ application: webkit-test-results -version: 182606 +version: 187975 runtime: python27 threadsafe: false api_version: 1 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188155] branches/safari-601.1.46-branch/Source/WebKit2
Title: [188155] branches/safari-601.1.46-branch/Source/WebKit2 Revision 188155 Author lforsch...@apple.com Date 2015-08-07 13:17:49 -0700 (Fri, 07 Aug 2015) Log Message Merged r188112. rdar://problem/22128839 Modified Paths branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm Diff Modified: branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog (188154 => 188155) --- branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:16:45 UTC (rev 188154) +++ branches/safari-601.1.46-branch/Source/WebKit2/ChangeLog 2015-08-07 20:17:49 UTC (rev 188155) @@ -1,5 +1,15 @@ 2015-08-07 Lucas Forschler lforsch...@apple.com +Merge r188112 + +2015-08-06 Dan Bernstein m...@apple.com + +Fixed all the builds after trying to fix the non-HAVE(LINK_PREVIEW) build. + +* UIProcess/ios/WKContentViewInteraction.mm: + +2015-08-07 Lucas Forschler lforsch...@apple.com + Merge r188111 2015-08-06 Dan Bernstein m...@apple.com Modified: branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188154 => 188155) --- branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:16:45 UTC (rev 188154) +++ branches/safari-601.1.46-branch/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 20:17:49 UTC (rev 188155) @@ -223,8 +223,8 @@ #if HAVE(LINK_PREVIEW) @interface UIPreviewItemController (StagingToRemove) @property (strong, nonatomic, readonly) UIGestureRecognizer *presentationSecondaryGestureRecognizer; +@end #endif -@end #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [188162] trunk/Source
Title: [188162] trunk/Source
Revision 188162
Author wenson_hs...@apple.com
Date 2015-08-07 14:12:47 -0700 (Fri, 07 Aug 2015)
Log Message
Temporarily allow programmatic input assistance for adding Gmail account
https://bugs.webkit.org/show_bug.cgi?id=147792
Reviewed by Enrica Casucci.
rdar://problem/22126518
Temporary fix for keyboard input sliding out and immediately back in upon user interaction
in the Gmail 2-factor authentication page.
Source/WebCore:
* platform/RuntimeApplicationChecksIOS.h:
* platform/RuntimeApplicationChecksIOS.mm:
(WebCore::applicationIsGmailAddAccountOnIOS): Added bundle ID for Gmail settings.
Source/WebKit2:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]): Early
return no longer triggers due to lack of user interaction when adding a new Gmail account
through Settings.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.h
trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (188161 => 188162)
--- trunk/Source/WebCore/ChangeLog 2015-08-07 21:12:16 UTC (rev 188161)
+++ trunk/Source/WebCore/ChangeLog 2015-08-07 21:12:47 UTC (rev 188162)
@@ -1,3 +1,18 @@
+2015-08-07 Wenson Hsieh wenson_hs...@apple.com
+
+Temporarily allow programmatic input assistance for adding Gmail account
+https://bugs.webkit.org/show_bug.cgi?id=147792
+
+Reviewed by Enrica Casucci.
+rdar://problem/22126518
+
+Temporary fix for keyboard input sliding out and immediately back in upon user interaction
+in the Gmail 2-factor authentication page.
+
+* platform/RuntimeApplicationChecksIOS.h:
+* platform/RuntimeApplicationChecksIOS.mm:
+(WebCore::applicationIsGmailAddAccountOnIOS): Added bundle ID for Gmail settings.
+
2015-08-07 Andy Estes aes...@apple.com
Crash when following a Google search link to Twitter with Limit Adult Content enabled
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.h (188161 => 188162)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.h 2015-08-07 21:12:16 UTC (rev 188161)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.h 2015-08-07 21:12:47 UTC (rev 188162)
@@ -43,6 +43,7 @@
WEBCORE_EXPORT bool applicationIsTheEconomistOnIPhone();
bool applicationIsWebProcess();
bool applicationIsIBooksOnIOS();
+WEBCORE_EXPORT bool applicationIsGmailAddAccountOnIOS();
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.mm (188161 => 188162)
--- trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.mm 2015-08-07 21:12:16 UTC (rev 188161)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecksIOS.mm 2015-08-07 21:12:47 UTC (rev 188162)
@@ -122,6 +122,12 @@
return isIBooksOnIOS;
}
+bool applicationIsGmailAddAccountOnIOS()
+{
+static const bool isGmailAddAccountOnIOS = [[[NSBundle mainBundle] bundleIdentifier] isEqualToString:@com.apple.social.SLGoogleAuth.SLGoogleAuthService];
+return isGmailAddAccountOnIOS;
+}
+
} // namespace WebCore
#endif // PLATFORM(IOS)
Modified: trunk/Source/WebKit2/ChangeLog (188161 => 188162)
--- trunk/Source/WebKit2/ChangeLog 2015-08-07 21:12:16 UTC (rev 188161)
+++ trunk/Source/WebKit2/ChangeLog 2015-08-07 21:12:47 UTC (rev 188162)
@@ -1,3 +1,19 @@
+2015-08-07 Wenson Hsieh wenson_hs...@apple.com
+
+Temporarily allow programmatic input assistance for adding Gmail account
+https://bugs.webkit.org/show_bug.cgi?id=147792
+
+Reviewed by Enrica Casucci.
+rdar://problem/22126518
+
+Temporary fix for keyboard input sliding out and immediately back in upon user interaction
+in the Gmail 2-factor authentication page.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]): Early
+return no longer triggers due to lack of user interaction when adding a new Gmail account
+through Settings.
+
2015-08-07 Brady Eidson beid...@apple.com
Move concrete KeyedDecoder/Encoder implementations to WebCore.
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (188161 => 188162)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 21:12:16 UTC (rev 188161)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-08-07 21:12:47 UTC (rev 188162)
@@ -64,6 +64,7 @@
#import WebCore/Pasteboard.h
#import WebCore/Path.h
#import WebCore/PathUtilities.h
+#import WebCore/RuntimeApplicationChecksIOS.h
#import WebCore/Scrollbar.h
#import WebCore/SoftLinking.h
#import WebCore/TextIndicator.h
@@ -3018,7 +3019,9 @@
- (void)_startAssistingNode:(const
