date:20151106

[webkit-changes] [192122] trunk/Source/WebCore

2015-11-06 Thread cdumez

Title: [192122] trunk/Source/WebCore








Revision 192122
Author cdu...@apple.com
Date 2015-11-06 15:58:09 -0800 (Fri, 06 Nov 2015)


Log Message
Remove unused HTMLFormControlsCollection::namedItem()
https://bugs.webkit.org/show_bug.cgi?id=150975

Reviewed by Andreas Kling.

Remove unused HTMLFormControlsCollection::namedItem().
JSHTMLFormControlsCollection::namedItem() calls namedItems() on the
implementation object, not namedItem() because it returns a
RadioNodeList when there are several matches.

* html/HTMLFormControlsCollection.cpp:
(WebCore::firstNamedItem): Deleted.
(WebCore::HTMLFormControlsCollection::namedItem): Deleted.
* html/HTMLFormControlsCollection.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp
trunk/Source/WebCore/html/HTMLFormControlsCollection.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (192121 => 192122)

--- trunk/Source/WebCore/ChangeLog	2015-11-06 23:34:31 UTC (rev 192121)
+++ trunk/Source/WebCore/ChangeLog	2015-11-06 23:58:09 UTC (rev 192122)
@@ -1,3 +1,20 @@
+2015-11-06  Chris Dumez  
+
+Remove unused HTMLFormControlsCollection::namedItem()
+https://bugs.webkit.org/show_bug.cgi?id=150975
+
+Reviewed by Andreas Kling.
+
+Remove unused HTMLFormControlsCollection::namedItem().
+JSHTMLFormControlsCollection::namedItem() calls namedItems() on the
+implementation object, not namedItem() because it returns a
+RadioNodeList when there are several matches.
+
+* html/HTMLFormControlsCollection.cpp:
+(WebCore::firstNamedItem): Deleted.
+(WebCore::HTMLFormControlsCollection::namedItem): Deleted.
+* html/HTMLFormControlsCollection.h:
+
 2015-11-06  Myles C. Maxfield  
 
 REGRESSION(r182286): Tatechuyoko following ruby is drawn too far to the right


Modified: trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp (192121 => 192122)

--- trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp	2015-11-06 23:34:31 UTC (rev 192121)
+++ trunk/Source/WebCore/html/HTMLFormControlsCollection.cpp	2015-11-06 23:58:09 UTC (rev 192122)
@@ -98,41 +98,6 @@
 return nullptr;
 }
 
-static HTMLElement* firstNamedItem(const Vector& elementsArray,
-const Vector* imageElementsArray, const QualifiedName& attrName, const String& name)
-{
-ASSERT(attrName == idAttr || attrName == nameAttr);
-
-for (auto& entry : elementsArray) {
-HTMLElement& element = entry->asHTMLElement();
-if (entry->isEnumeratable() && element.fastGetAttribute(attrName) == name)
-return 
-}
-
-if (!imageElementsArray)
-return 0;
-
-for (auto& element : *imageElementsArray) {
-if (element->fastGetAttribute(attrName) == name)
-return element;
-}
-
-return nullptr;
-}
-
-HTMLElement* HTMLFormControlsCollection::namedItem(const AtomicString& name) const
-{
-// http://msdn.microsoft.com/workshop/author/dhtml/reference/methods/nameditem.asp
-// This method first searches for an object with a matching id
-// attribute. If a match is not found, the method then searches for an
-// object with a matching name attribute, but only on those elements
-// that are allowed a name attribute.
-auto* imageElements = is(ownerNode()) ? nullptr : ();
-if (HTMLElement* item = firstNamedItem(formControlElements(), imageElements, idAttr, name))
-return item;
-return firstNamedItem(formControlElements(), imageElements, nameAttr, name);
-}
-
 void HTMLFormControlsCollection::updateNamedElementCache() const
 {
 if (hasNamedElementCache())


Modified: trunk/Source/WebCore/html/HTMLFormControlsCollection.h (192121 => 192122)

--- trunk/Source/WebCore/html/HTMLFormControlsCollection.h	2015-11-06 23:34:31 UTC (rev 192121)
+++ trunk/Source/WebCore/html/HTMLFormControlsCollection.h	2015-11-06 23:58:09 UTC (rev 192122)
@@ -47,7 +47,6 @@
 private:
 explicit HTMLFormControlsCollection(ContainerNode&);
 
-virtual HTMLElement* namedItem(const AtomicString& name) const override;
 virtual void invalidateCache(Document&) override;
 virtual void updateNamedElementCache() const override;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [192120] trunk

2015-11-06 Thread mmaxfield

Title: [192120] trunk








Revision 192120
Author mmaxfi...@apple.com
Date 2015-11-06 15:20:12 -0800 (Fri, 06 Nov 2015)


Log Message
REGRESSION(r182286): Tatechuyoko following ruby is drawn too far to the right
https://bugs.webkit.org/show_bug.cgi?id=150923

Reviewed by Zalan Bujtas.

Source/WebCore:

Ever since r182286, expansion opportunities in justified ruby were moved to their neighboring
elements (thereby forbidding trailing nor leading expansions inside ruby). However, when the
neighboring element is tatechuyoko, we will erroneously honor the expansion opportunity inside
the tatechuyoko, thereby moving it horizontally.

Tatechuyoko should never have expansion opportunities inside it.

Test: fast/text/ruby-justify-tatechuyoko.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::expansionBehaviorForInlineTextBox):

LayoutTests:

* fast/text/ruby-justify-tatechuyoko-expected.html: Added.
* fast/text/ruby-justify-tatechuyoko.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp


Added Paths

trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko-expected.html
trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192119 => 192120)

--- trunk/LayoutTests/ChangeLog	2015-11-06 20:58:17 UTC (rev 192119)
+++ trunk/LayoutTests/ChangeLog	2015-11-06 23:20:12 UTC (rev 192120)
@@ -1,3 +1,13 @@
+2015-11-06  Myles C. Maxfield  
+
+REGRESSION(r182286): Tatechuyoko following ruby is drawn too far to the right
+https://bugs.webkit.org/show_bug.cgi?id=150923
+
+Reviewed by Zalan Bujtas.
+
+* fast/text/ruby-justify-tatechuyoko-expected.html: Added.
+* fast/text/ruby-justify-tatechuyoko.html: Added.
+
 2015-11-06  Ryan Haddad  
 
 Marking fast/canvas/webgl/oes-texture-half-float-linear.html as flaky on mac


Added: trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko-expected.html (0 => 192120)

--- trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko-expected.html	2015-11-06 23:20:12 UTC (rev 192120)
@@ -0,0 +1,10 @@
+
+
+
+
+
+
+This test makes sure that tatechuyoko which directly follows ruby is properly left-aligned.
+この文章99は斜下付サンプルです。
+
+
Property changes on: trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko-expected.html
___


Added: svn:executable

Added: trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko.html (0 => 192120)

--- trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko.html	(rev 0)
+++ trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko.html	2015-11-06 23:20:12 UTC (rev 192120)
@@ -0,0 +1,10 @@
+
+
+
+
+
+
+This test makes sure that tatechuyoko which directly follows ruby is properly left-aligned.
+この文章ルビ99は斜下付サンプルです。
+
+
Property changes on: trunk/LayoutTests/fast/text/ruby-justify-tatechuyoko.html
___


Added: svn:executable

Modified: trunk/Source/WebCore/ChangeLog (192119 => 192120)

--- trunk/Source/WebCore/ChangeLog	2015-11-06 20:58:17 UTC (rev 192119)
+++ trunk/Source/WebCore/ChangeLog	2015-11-06 23:20:12 UTC (rev 192120)
@@ -1,3 +1,22 @@
+2015-11-06  Myles C. Maxfield  
+
+REGRESSION(r182286): Tatechuyoko following ruby is drawn too far to the right
+https://bugs.webkit.org/show_bug.cgi?id=150923
+
+Reviewed by Zalan Bujtas.
+
+Ever since r182286, expansion opportunities in justified ruby were moved to their neighboring
+elements (thereby forbidding trailing nor leading expansions inside ruby). However, when the
+neighboring element is tatechuyoko, we will erroneously honor the expansion opportunity inside
+the tatechuyoko, thereby moving it horizontally.
+
+Tatechuyoko should never have expansion opportunities inside it.
+
+Test: fast/text/ruby-justify-tatechuyoko.html
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::expansionBehaviorForInlineTextBox):
+
 2015-11-06  Mario Sanchez Prada  
 
 Layout Test accessibility/win/linked-elements.html is crashing on win debug


Modified: trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp (192119 => 192120)

--- trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2015-11-06 20:58:17 UTC (rev 192119)
+++ trunk/Source/WebCore/rendering/RenderBlockLineLayout.cpp	2015-11-06 23:20:12 UTC (rev 192120)
@@ -717,12 +717,15 @@
 
 static inline ExpansionBehavior expansionBehaviorForInlineTextBox(RenderBlockFlow& block, InlineTextBox& textBox, BidiRun* previousRun, BidiRun* nextRun, ETextAlign textAlign, bool isAfterExpansion)
 {
+// Tatechuyoko is modeled as the Object Replacement Character (U+FFFC), which can never

[webkit-changes] [192123] trunk/Source

2015-11-06 Thread beidson

Title: [192123] trunk/Source








Revision 192123
Author beid...@apple.com
Date 2015-11-06 17:12:55 -0800 (Fri, 06 Nov 2015)


Log Message
Modern IDB: Make the result data for a "get" request be an IDBGetResult.
https://bugs.webkit.org/show_bug.cgi?id=150985

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Refactor, no change in behavior).

* Modules/indexeddb/IDBGetResult.h:
(WebCore::IDBGetResult::IDBGetResult):
(WebCore::IDBGetResult::dataFromBuffer):
(WebCore::IDBGetResult::isolatedCopy):

* Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::didGetRecordOnServer):

* Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:
(WebCore::GetOperation::perform):

* Modules/indexeddb/server/IDBBackingStore.h:

* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:

* Modules/indexeddb/server/MemoryIndex.cpp:
(WebCore::IDBServer::MemoryIndex::valueForKeyRange):
* Modules/indexeddb/server/MemoryIndex.h:

* Modules/indexeddb/server/MemoryObjectStore.cpp:
(WebCore::IDBServer::MemoryObjectStore::indexValueForKeyRange):
* Modules/indexeddb/server/MemoryObjectStore.h:

* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::storeCallback):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performGetIndexRecord):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformGetRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performGetResultCallback):
(WebCore::IDBServer::UniqueIDBDatabase::performValueDataCallback): Deleted.
* Modules/indexeddb/server/UniqueIDBDatabase.h:

* Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::getRecord):

* Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::IDBResultData):
(WebCore::IDBResultData::getRecordSuccess):
(WebCore::IDBResultData::getResult):
* Modules/indexeddb/shared/IDBResultData.h:
(WebCore::IDBResultData::resultData): Deleted.

Source/WebKit2:

* Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder::encode):
(IPC::ArgumentCoder::decode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBGetResult.h
trunk/Source/WebCore/Modules/indexeddb/client/IDBTransactionImpl.cpp
trunk/Source/WebCore/Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp
trunk/Source/WebCore/Modules/indexeddb/server/IDBBackingStore.h
trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.cpp
trunk/Source/WebCore/Modules/indexeddb/server/MemoryIDBBackingStore.h
trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndex.cpp
trunk/Source/WebCore/Modules/indexeddb/server/MemoryIndex.h
trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.cpp
trunk/Source/WebCore/Modules/indexeddb/server/MemoryObjectStore.h
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabase.h
trunk/Source/WebCore/Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.cpp
trunk/Source/WebCore/Modules/indexeddb/shared/IDBResultData.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/WebCoreArgumentCoders.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (192122 => 192123)

--- trunk/Source/WebCore/ChangeLog	2015-11-06 23:58:09 UTC (rev 192122)
+++ trunk/Source/WebCore/ChangeLog	2015-11-07 01:12:55 UTC (rev 192123)
@@ -1,3 +1,56 @@
+2015-11-06  Brady Eidson  
+
+Modern IDB: Make the result data for a "get" request be an IDBGetResult.
+https://bugs.webkit.org/show_bug.cgi?id=150985
+
+Reviewed by Alex Christensen.
+
+No new tests (Refactor, no change in behavior).
+
+* Modules/indexeddb/IDBGetResult.h:
+(WebCore::IDBGetResult::IDBGetResult):
+(WebCore::IDBGetResult::dataFromBuffer):
+(WebCore::IDBGetResult::isolatedCopy):
+
+* Modules/indexeddb/client/IDBTransactionImpl.cpp:
+(WebCore::IDBClient::IDBTransaction::didGetRecordOnServer):
+
+* Modules/indexeddb/legacy/IDBTransactionBackendOperations.cpp:
+(WebCore::GetOperation::perform):
+
+* Modules/indexeddb/server/IDBBackingStore.h:
+
+* Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
+(WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
+* Modules/indexeddb/server/MemoryIDBBackingStore.h:
+
+* Modules/indexeddb/server/MemoryIndex.cpp:
+(WebCore::IDBServer::MemoryIndex::valueForKeyRange):
+* Modules/indexeddb/server/MemoryIndex.h:
+
+* Modules/indexeddb/server/MemoryObjectStore.cpp:
+(WebCore::IDBServer::MemoryObjectStore::indexValueForKeyRange):
+* Modules/indexeddb/server/MemoryObjectStore.h:
+
+

[webkit-changes] [192124] trunk

2015-11-06 Thread wenson_hsieh

Title: [192124] trunk








Revision 192124
Author wenson_hs...@apple.com
Date 2015-11-06 18:32:13 -0800 (Fri, 06 Nov 2015)


Log Message
Scrolling iframe inside scrollable div does not work with trackpad
https://bugs.webkit.org/show_bug.cgi?id=150168


Reviewed by Brent Fulgham.

Source/WebCore:

When scrolling in an iframe nested under an overflow scrolling region, EventHandler::platformPrepareForWheelEvents
fails to compute the correct scrollableArea, using the overflow div's scrollable area instead of the iframe's view.
This causes the latching algorithm to bail out of handling the wheel event. To avoid this, we special-case the
decision to compute the scrollableArea from the scrollableContainer if we are attempting to scroll in an iframe.

Test: fast/scrolling/latching/scroll-iframe-in-overflow.html

* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::platformPrepareForWheelEvents):

LayoutTests:

Tests that an iframe nested under an overflow scrolling div can be scrolled.

* fast/scrolling/latching/scroll-iframe-in-overflow-expected.txt: Added.
* fast/scrolling/latching/scroll-iframe-in-overflow.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/mac/EventHandlerMac.mm


Added Paths

trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow-expected.txt
trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow.html




Diff

Modified: trunk/LayoutTests/ChangeLog (192123 => 192124)

--- trunk/LayoutTests/ChangeLog	2015-11-07 01:12:55 UTC (rev 192123)
+++ trunk/LayoutTests/ChangeLog	2015-11-07 02:32:13 UTC (rev 192124)
@@ -1,3 +1,16 @@
+2015-11-06  Wenson Hsieh  
+
+Scrolling iframe inside scrollable div does not work with trackpad
+https://bugs.webkit.org/show_bug.cgi?id=150168
+
+
+Reviewed by Brent Fulgham.
+
+Tests that an iframe nested under an overflow scrolling div can be scrolled.
+
+* fast/scrolling/latching/scroll-iframe-in-overflow-expected.txt: Added.
+* fast/scrolling/latching/scroll-iframe-in-overflow.html: Added.
+
 2015-11-06  Myles C. Maxfield  
 
 REGRESSION(r182286): Tatechuyoko following ruby is drawn too far to the right


Added: trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow-expected.txt (0 => 192124)

--- trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow-expected.txt	2015-11-07 02:32:13 UTC (rev 192124)
@@ -0,0 +1,2 @@
+PASS The iframe scrolled but the wrapper did not.
+


Added: trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow.html (0 => 192124)

--- trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow.html	(rev 0)
+++ trunk/LayoutTests/fast/scrolling/latching/scroll-iframe-in-overflow.html	2015-11-07 02:32:13 UTC (rev 192124)
@@ -0,0 +1,78 @@
+
+
+
+#wrapper {
+height: 400px;
+width: 600px;
+overflow: scroll;
+background-color: #EEE;
+}
+
+iframe {
+background-color: #CCC;
+width: 400px;
+height: 100px;
+margin-bottom: 1000px;
+}
+
+body {
+margin: 0;
+}
+
+