[webkit-changes] [207584] trunk

2016-10-19 Thread jer . noble 
Title: [207584] trunk








Revision 207584
Author jer.no...@apple.com
Date 2016-10-19 20:10:12 -0700 (Wed, 19 Oct 2016)


Log Message
REGRESSION (r206025): All YouTube videos play with black bars on all four sides
https://bugs.webkit.org/show_bug.cgi?id=163308

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-resize.html

After r206025, we do not fire resize events when the size change notification happens equal-
to-or-before the current time, which can happen at the very beginning of a stream. Take care
of this case by checking that the target time isn't actually in the past inside of
sizeWillChangeAtTime(), and also always skip the boundary time observer when there was no
previous size (such as after a flush due to a seek).

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sizeWillChangeAtTime):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setNaturalSize):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::flushAndEnqueueNonDisplayingSamples):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):

LayoutTests:

* media/media-source/media-source-resize-expected.txt: Added.
* media/media-source/media-source-resize.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm


Added Paths

trunk/LayoutTests/media/media-source/media-source-resize-expected.txt
trunk/LayoutTests/media/media-source/media-source-resize.html




Diff

Modified: trunk/LayoutTests/ChangeLog (207583 => 207584)

--- trunk/LayoutTests/ChangeLog	2016-10-20 02:33:19 UTC (rev 207583)
+++ trunk/LayoutTests/ChangeLog	2016-10-20 03:10:12 UTC (rev 207584)
@@ -1,3 +1,13 @@
+2016-10-19  Jer Noble  
+
+REGRESSION (r206025): All YouTube videos play with black bars on all four sides
+https://bugs.webkit.org/show_bug.cgi?id=163308
+
+Reviewed by Darin Adler.
+
+* media/media-source/media-source-resize-expected.txt: Added.
+* media/media-source/media-source-resize.html: Added.
+
 2016-10-19  Nan Wang  
 
 AX: [Mac] Mark element AXAPI should comform to specs


Added: trunk/LayoutTests/media/media-source/media-source-resize-expected.txt (0 => 207584)

--- trunk/LayoutTests/media/media-source/media-source-resize-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-resize-expected.txt	2016-10-20 03:10:12 UTC (rev 207584)
@@ -0,0 +1,15 @@
+This tests the ability of the SourceBuffer to reset the parser after an abort(). A SourceBuffer in this state should be able to accept a new initialization segment or a new media segment.
+
+RUN(video.src = ""
+EVENT(sourceopen)
+RUN(source.duration = loader.duration())
+RUN(sourceBuffer = source.addSourceBuffer(loader.type()))
+RUN(sourceBuffer.appendBuffer(loader.initSegment()))
+EVENT(update)
+Append a media segment.
+RUN(sourceBuffer.appendBuffer(loader.mediaSegment(0)))
+EVENT(resize)
+EXPECTED (video.videoWidth == '640') OK
+EXPECTED (video.videoHeight == '480') OK
+END OF TEST
+


Added: trunk/LayoutTests/media/media-source/media-source-resize.html (0 => 207584)

--- trunk/LayoutTests/media/media-source/media-source-resize.html	(rev 0)
+++ trunk/LayoutTests/media/media-source/media-source-resize.html	2016-10-20 03:10:12 UTC (rev 207584)
@@ -0,0 +1,58 @@
+
+
+
+media-source-abort-resets-parser
+
+var loader;
+var source;
+var sourceBuffer;
+
+function runTest() {
+findMediaElement();
+
+loader = new MediaSourceLoader('content/test-fragmented-manifest.json');
+loader._onload_ = mediaDataLoaded;
+loader._onerror_ = mediaDataLoadingFailed;
+}
+
+function mediaDataLoadingFailed() {
+failTest('Media data loading failed');
+}
+
+function mediaDataLoaded() {
+source = new MediaSource();
+waitForEvent('sourceopen', sourceOpen, false, false, source);
+waitForEventAndFail('error');
+run('video.src = ""
+}
+
+function sourceOpen() {
+run('source.duration = loader.duration()');
+run('sourceBuffer = source.addSourceBuffer(loader.type())');
+waitForEventOn(sourceBuffer, 'update', sourceInitialized, false, true);
+run('sourceBuffer.appendBuffer(loader.initSegment())');
+}
+
+function sourceInitialized() {
+waitForEventOnce('resize', resize);
+consoleWrite('Append a

[webkit-changes] [207583] trunk

2016-10-19 Thread n_wang 
Title: [207583] trunk








Revision 207583
Author n_w...@apple.com
Date 2016-10-19 19:33:19 -0700 (Wed, 19 Oct 2016)


Log Message
AX: [Mac] Mark element AXAPI should comform to specs
https://bugs.webkit.org/show_bug.cgi?id=163707

Reviewed by Chris Fleizach.

Source/WebCore:

Created a new role for mark elements on Mac and exposed the role
description.

Changes are covered in modified test expectaions.

* English.lproj/Localizable.strings:
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
* accessibility/mac/AccessibilityObjectMac.mm:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper roleDescription]):
* platform/LocalizedStrings.cpp:
(WebCore::AXMarkText):
* platform/LocalizedStrings.h:

LayoutTests:

Added the modified roles-computedRoleString-expected.txt in mac platform so
that the exposed mark element won't affect other platform.

* platform/mac/accessibility/roles-computedRoleString-expected.txt: Added.
* platform/mac/accessibility/roles-exposed-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/Localizable.strings
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
trunk/Source/WebCore/accessibility/mac/AccessibilityObjectMac.mm
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
trunk/Source/WebCore/platform/LocalizedStrings.cpp
trunk/Source/WebCore/platform/LocalizedStrings.h


Added Paths

trunk/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (207582 => 207583)

--- trunk/LayoutTests/ChangeLog	2016-10-20 00:47:39 UTC (rev 207582)
+++ trunk/LayoutTests/ChangeLog	2016-10-20 02:33:19 UTC (rev 207583)
@@ -1,3 +1,16 @@
+2016-10-19  Nan Wang  
+
+AX: [Mac] Mark element AXAPI should comform to specs
+https://bugs.webkit.org/show_bug.cgi?id=163707
+
+Reviewed by Chris Fleizach.
+
+Added the modified roles-computedRoleString-expected.txt in mac platform so 
+that the exposed mark element won't affect other platform.
+
+* platform/mac/accessibility/roles-computedRoleString-expected.txt: Added.
+* platform/mac/accessibility/roles-exposed-expected.txt:
+
 2016-10-19  Myles C. Maxfield  
 
 CSS font-variation-settings does not handle uppercase axis names in variable fonts


Added: trunk/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt (0 => 207583)

--- trunk/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt	2016-10-20 02:33:19 UTC (rev 207583)
@@ -0,0 +1,184 @@
+This tests that native elements and ARIA overrides result in the same ARIA computed role, regardless of platform.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS: a[href] -> link. 
+PASS: article -> article. 
+PASS: aside -> complementary. 
+PASS: button -> button. 
+PASS: dfn -> definition. 
+PASS: dl -> . 
+PASS: footer -> . 
+PASS: form -> form. 
+PASS: header -> banner. 
+PASS: h1 -> heading. 
+PASS: h2 -> heading. 
+PASS: h3 -> heading. 
+PASS: h4 -> heading. 
+PASS: h5 -> heading. 
+PASS: h5 -> heading. 
+PASS: hr -> separator. 
+PASS: img[alt='X'] -> img. 
+PASS: input[type='button'] -> button. 
+PASS: input[type='checkbox'] -> checkbox. 
+PASS: input[type='date'] -> . 
+PASS: input[type='datetime'] -> . 
+PASS: input[type='datetime-local'] -> . 
+PASS: input[type='email'] -> . 
+PASS: input[type='file'] -> button. 
+PASS: input[type='image'] -> button. 
+PASS: input[type='month'] -> . 
+PASS: input[type='number'] -> . 
+PASS: input[type='password'] -> . 
+PASS: input[type='radio'] -> radio. 
+PASS: input[type='range'] -> slider. 
+PASS: input[type='reset'] -> button. 
+PASS: input[type='search'] -> searchbox. 
+PASS: input[type='submit'] -> button. 
+PASS: input[type='tel'] -> . 
+PASS: input[type='text'] -> . 
+PASS: input[type='time'] -> . 
+PASS: input[type='url'] -> . 
+PASS: input[type='week'] -> . 
+PASS: ins -> . 
+PASS: mark -> . 
+PASS: math -> math. 
+PASS: meter -> progressbar. 
+PASS: nav -> navigation. 
+PASS: ol -> list. 
+PASS: li -> listitem. 
+PASS: p -> . 
+PASS: pre -> group. 
+PASS: progress -> progressbar. 
+PASS: samp -> . 
+PASS:

[webkit-changes] [207582] trunk

2016-10-19 Thread commit-queue 
Title: [207582] trunk








Revision 207582
Author commit-qu...@webkit.org
Date 2016-10-19 17:47:39 -0700 (Wed, 19 Oct 2016)


Log Message
Re-enable URLParser for non-Safari Cocoa apps after r207321
https://bugs.webkit.org/show_bug.cgi?id=163690

Patch by Alex Christensen  on 2016-10-19
Reviewed by Darin Adler.

Source/WebCore:

I disabled the URLParser for non-Safari applications in r207305
to give me time to make URLParser more compatible, which I did in r207321

Updated some API tests which will be investigated in
https://bugs.webkit.org/show_bug.cgi?id=163127

* platform/URLParser.cpp:
(WebCore::URLParser::setEnabled):
(WebCore::URLParser::enabled):
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::setURLParserEnabled): Deleted.
* testing/js/WebCoreTestSupport.h:

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(DumpRenderTreeMain):
* TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
(-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
* TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
(TestWebKitAPI::TEST):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/URLParser.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp
trunk/Source/WebCore/testing/js/WebCoreTestSupport.h
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/mac/DumpRenderTree.mm
trunk/Tools/TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm
trunk/Tools/TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (207581 => 207582)

--- trunk/Source/WebCore/ChangeLog	2016-10-20 00:39:09 UTC (rev 207581)
+++ trunk/Source/WebCore/ChangeLog	2016-10-20 00:47:39 UTC (rev 207582)
@@ -1,3 +1,23 @@
+2016-10-19  Alex Christensen  
+
+Re-enable URLParser for non-Safari Cocoa apps after r207321
+https://bugs.webkit.org/show_bug.cgi?id=163690
+
+Reviewed by Darin Adler.
+
+I disabled the URLParser for non-Safari applications in r207305
+to give me time to make URLParser more compatible, which I did in r207321
+
+Updated some API tests which will be investigated in 
+https://bugs.webkit.org/show_bug.cgi?id=163127
+
+* platform/URLParser.cpp:
+(WebCore::URLParser::setEnabled):
+(WebCore::URLParser::enabled):
+* testing/js/WebCoreTestSupport.cpp:
+(WebCoreTestSupport::setURLParserEnabled): Deleted.
+* testing/js/WebCoreTestSupport.h:
+
 2016-10-19  Myles C. Maxfield  
 
 CSS font-variation-settings does not handle uppercase axis names in variable fonts


Modified: trunk/Source/WebCore/platform/URLParser.cpp (207581 => 207582)

--- trunk/Source/WebCore/platform/URLParser.cpp	2016-10-20 00:39:09 UTC (rev 207581)
+++ trunk/Source/WebCore/platform/URLParser.cpp	2016-10-20 00:47:39 UTC (rev 207582)
@@ -2843,31 +2843,16 @@
 // It should be able to be deduced from m_isValid and m_string.length() to save memory.
 }
 
-enum class URLParserEnabled {
-Undetermined,
-Yes,
-No
-};
+static bool urlParserEnabled = true;
 
-static URLParserEnabled urlParserEnabled = URLParserEnabled::Undetermined;
-
 void URLParser::setEnabled(bool enabled)
 {
-urlParserEnabled = enabled ? URLParserEnabled::Yes : URLParserEnabled::No;
+urlParserEnabled = enabled;
 }
 
 bool URLParser::enabled()
 {
-if (urlParserEnabled == URLParserEnabled::Undetermined) {
-#if PLATFORM(MAC)
-urlParserEnabled = MacApplication::isSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
-#elif PLATFORM(IOS)
-urlParserEnabled = IOSApplication::isMobileSafari() ? URLParserEnabled::Yes : URLParserEnabled::No;
-#else
-urlParserEnabled = URLParserEnabled::Yes;
-#endif
-}
-return urlParserEnabled == URLParserEnabled::Yes;
+return urlParserEnabled;
 }
 
 } // namespace WebCore


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp (207581 => 207582)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-20 00:39:09 UTC (rev 207581)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.cpp	2016-10-20 00:47:39 UTC (rev 207582)
@@ -121,11 +121,6 @@
 InternalSettings::setAllowsAnySSLCertificate(allowAnySSLCertificate);
 }
 
-void setURLParserEnabled(bool enabled)
-{
-URLParser::setEnabled(enabled);
-}
-
 void installMockGamepadProvider()
 {
 #if ENABLE(GAMEPAD)


Modified: trunk/Source/WebCore/testing/js/WebCoreTestSupport.h (207581 => 207582)

--- trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-20 00:39:09 UTC (rev 207581)
+++ trunk/Source/WebCore/testing/js/WebCoreTestSupport.h	2016-10-20 00:47:39 UTC (rev 207582)
@@ -56,7 +56,6 @@
 void setLogChannelToAccumulate(const WTF::String& name) TEST_SUPPORT_EXPORT;
 void initializeLogChannelsIfNecessary()

[webkit-changes] [207581] trunk

2016-10-19 Thread mmaxfield 
Title: [207581] trunk








Revision 207581
Author mmaxfi...@apple.com
Date 2016-10-19 17:39:09 -0700 (Wed, 19 Oct 2016)


Log Message
CSS font-variation-settings does not handle uppercase axis names in variable fonts
https://bugs.webkit.org/show_bug.cgi?id=163546

Reviewed by Dean Jackson.

Source/WebCore:

Remove the extra toASCIILower() call.

Test: fast/text/variations/case-axis-names.html

* css/parser/CSSParser.cpp:
(WebCore::CSSParser::parseFontVariationTag):

LayoutTests:

* fast/text/variations/case-axis-names-expected.html: Added.
* fast/text/variations/case-axis-names.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSParser.cpp


Added Paths

trunk/LayoutTests/fast/text/variations/case-axis-names-expected.html
trunk/LayoutTests/fast/text/variations/case-axis-names.html




Diff

Modified: trunk/LayoutTests/ChangeLog (207580 => 207581)

--- trunk/LayoutTests/ChangeLog	2016-10-20 00:31:56 UTC (rev 207580)
+++ trunk/LayoutTests/ChangeLog	2016-10-20 00:39:09 UTC (rev 207581)
@@ -1,3 +1,13 @@
+2016-10-19  Myles C. Maxfield  
+
+CSS font-variation-settings does not handle uppercase axis names in variable fonts
+https://bugs.webkit.org/show_bug.cgi?id=163546
+
+Reviewed by Dean Jackson.
+
+* fast/text/variations/case-axis-names-expected.html: Added.
+* fast/text/variations/case-axis-names.html: Added.
+
 2016-10-19  Joone Hur  
 
 Add a plain space instead of  between text nodes


Added: trunk/LayoutTests/fast/text/variations/case-axis-names-expected.html (0 => 207581)

--- trunk/LayoutTests/fast/text/variations/case-axis-names-expected.html	(rev 0)
+++ trunk/LayoutTests/fast/text/variations/case-axis-names-expected.html	2016-10-20 00:39:09 UTC (rev 207581)
@@ -0,0 +1,9 @@
+
+
+
+
+
+This test passes if capitalized and lowercased axis names are distinct.
+Hello
+
+
\ No newline at end of file


Added: trunk/LayoutTests/fast/text/variations/case-axis-names.html (0 => 207581)

--- trunk/LayoutTests/fast/text/variations/case-axis-names.html	(rev 0)
+++ trunk/LayoutTests/fast/text/variations/case-axis-names.html	2016-10-20 00:39:09 UTC (rev 207581)
@@ -0,0 +1,9 @@
+
+
+
+
+
+This test passes if capitalized and lowercased axis names are distinct.
+Hello
+
+
\ No newline at end of file


Modified: trunk/Source/WebCore/ChangeLog (207580 => 207581)

--- trunk/Source/WebCore/ChangeLog	2016-10-20 00:31:56 UTC (rev 207580)
+++ trunk/Source/WebCore/ChangeLog	2016-10-20 00:39:09 UTC (rev 207581)
@@ -1,3 +1,17 @@
+2016-10-19  Myles C. Maxfield  
+
+CSS font-variation-settings does not handle uppercase axis names in variable fonts
+https://bugs.webkit.org/show_bug.cgi?id=163546
+
+Reviewed by Dean Jackson.
+
+Remove the extra toASCIILower() call.
+
+Test: fast/text/variations/case-axis-names.html
+
+* css/parser/CSSParser.cpp:
+(WebCore::CSSParser::parseFontVariationTag):
+
 2016-10-19  Anders Carlsson  
 
 Remove m_redirectURLs from HistoryItem


Modified: trunk/Source/WebCore/css/parser/CSSParser.cpp (207580 => 207581)

--- trunk/Source/WebCore/css/parser/CSSParser.cpp	2016-10-20 00:31:56 UTC (rev 207580)
+++ trunk/Source/WebCore/css/parser/CSSParser.cpp	2016-10-20 00:39:09 UTC (rev 207581)
@@ -10593,7 +10593,7 @@
 UChar character = value->string[i];
 if (character < 0x20 || character > 0x7E)
 return false;
-tag[i] = toASCIILower(character);
+tag[i] = character;
 }
 
 value = m_valueList->next();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207580] trunk/Source/WebCore

2016-10-19 Thread andersca 
Title: [207580] trunk/Source/WebCore








Revision 207580
Author ander...@apple.com
Date 2016-10-19 17:31:56 -0700 (Wed, 19 Oct 2016)


Log Message
Remove m_redirectURLs from HistoryItem
https://bugs.webkit.org/show_bug.cgi?id=163704

Reviewed by Dan Bernstein.

* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::reset):
* history/HistoryItem.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/history/HistoryItem.cpp
trunk/Source/WebCore/history/HistoryItem.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (207579 => 207580)

--- trunk/Source/WebCore/ChangeLog	2016-10-19 23:55:30 UTC (rev 207579)
+++ trunk/Source/WebCore/ChangeLog	2016-10-20 00:31:56 UTC (rev 207580)
@@ -1,3 +1,15 @@
+2016-10-19  Anders Carlsson  
+
+Remove m_redirectURLs from HistoryItem
+https://bugs.webkit.org/show_bug.cgi?id=163704
+
+Reviewed by Dan Bernstein.
+
+* history/HistoryItem.cpp:
+(WebCore::HistoryItem::HistoryItem):
+(WebCore::HistoryItem::reset):
+* history/HistoryItem.h:
+
 2016-10-19  Joone Hur  
 
 Add a plain space instead of  between text nodes


Modified: trunk/Source/WebCore/history/HistoryItem.cpp (207579 => 207580)

--- trunk/Source/WebCore/history/HistoryItem.cpp	2016-10-19 23:55:30 UTC (rev 207579)
+++ trunk/Source/WebCore/history/HistoryItem.cpp	2016-10-20 00:31:56 UTC (rev 207580)
@@ -129,9 +129,6 @@
 m_children.reserveInitialCapacity(size);
 for (unsigned i = 0; i < size; ++i)
 m_children.uncheckedAppend(item.m_children[i]->copy());
-
-if (item.m_redirectURLs)
-m_redirectURLs = std::make_unique(*item.m_redirectURLs);
 }
 
 Ref HistoryItem::copy() const
@@ -153,8 +150,6 @@
 m_lastVisitWasFailure = false;
 m_isTargetItem = false;
 
-m_redirectURLs = nullptr;
-
 m_itemSequenceNumber = generateSequenceNumber();
 
 m_stateObject = nullptr;


Modified: trunk/Source/WebCore/history/HistoryItem.h (207579 => 207580)

--- trunk/Source/WebCore/history/HistoryItem.h	2016-10-19 23:55:30 UTC (rev 207579)
+++ trunk/Source/WebCore/history/HistoryItem.h	2016-10-20 00:31:56 UTC (rev 207580)
@@ -227,8 +227,6 @@
 bool m_isTargetItem;
 bool m_wasRestoredFromSession { false };
 
-std::unique_ptr m_redirectURLs;
-
 // If two HistoryItems have the same item sequence number, then they are
 // clones of one another.  Traversing history from one such HistoryItem to
 // another is a no-op.  HistoryItem clones are created for parent and






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207579] trunk/Source/WebKit2

2016-10-19 Thread cdumez 
Title: [207579] trunk/Source/WebKit2








Revision 207579
Author cdu...@apple.com
Date 2016-10-19 16:55:30 -0700 (Wed, 19 Oct 2016)


Log Message
[WK2] Expose suggested filename via WKBundleHitTestResult API
https://bugs.webkit.org/show_bug.cgi?id=163693


Reviewed by Anders Carlsson.

Expose suggested filename via WKBundleHitTestResult API. The implementation
currently relies on the 'download' attribute on anchor / area elements
that we recently started supporting.

* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
(WKBundleHitTestResultCopyLinkSuggestedFilename):
* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
(WebKit::InjectedBundleHitTestResult::create):
(WebKit::InjectedBundleHitTestResult::mediaType):
(WebKit::InjectedBundleHitTestResult::linkSuggestedFilename):
(WebKit::InjectedBundleHitTestResult::imageRect):
* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp
trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.h




Diff

Modified: trunk/Source/WebKit2/ChangeLog (207578 => 207579)

--- trunk/Source/WebKit2/ChangeLog	2016-10-19 23:49:43 UTC (rev 207578)
+++ trunk/Source/WebKit2/ChangeLog	2016-10-19 23:55:30 UTC (rev 207579)
@@ -1,3 +1,25 @@
+2016-10-19  Chris Dumez  
+
+[WK2] Expose suggested filename via WKBundleHitTestResult API
+https://bugs.webkit.org/show_bug.cgi?id=163693
+
+
+Reviewed by Anders Carlsson.
+
+Expose suggested filename via WKBundleHitTestResult API. The implementation
+currently relies on the 'download' attribute on anchor / area elements
+that we recently started supporting.
+
+* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:
+(WKBundleHitTestResultCopyLinkSuggestedFilename):
+* WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
+* WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
+(WebKit::InjectedBundleHitTestResult::create):
+(WebKit::InjectedBundleHitTestResult::mediaType):
+(WebKit::InjectedBundleHitTestResult::linkSuggestedFilename):
+(WebKit::InjectedBundleHitTestResult::imageRect):
+* WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
+
 2016-10-19  Ryan Haddad  
 
 Unreviewed, rolling out r207557.


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp (207578 => 207579)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp	2016-10-19 23:49:43 UTC (rev 207578)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp	2016-10-19 23:55:30 UTC (rev 207579)
@@ -120,3 +120,8 @@
 {
 return toCopiedAPI(toImpl(hitTestResultRef)->linkTitle());
 }
+
+WKStringRef WKBundleHitTestResultCopyLinkSuggestedFilename(WKBundleHitTestResultRef hitTestResultRef)
+{
+return toCopiedAPI(toImpl(hitTestResultRef)->linkSuggestedFilename());
+}


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h (207578 => 207579)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h	2016-10-19 23:49:43 UTC (rev 207578)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h	2016-10-19 23:55:30 UTC (rev 207579)
@@ -62,6 +62,7 @@
 
 WK_EXPORT WKStringRef WKBundleHitTestResultCopyLinkLabel(WKBundleHitTestResultRef hitTestResult);
 WK_EXPORT WKStringRef WKBundleHitTestResultCopyLinkTitle(WKBundleHitTestResultRef hitTestResult);
+WK_EXPORT WKStringRef WKBundleHitTestResultCopyLinkSuggestedFilename(WKBundleHitTestResultRef hitTestResult);
 
 #ifdef __cplusplus
 }


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp (207578 => 207579)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp	2016-10-19 23:49:43 UTC (rev 207578)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp	2016-10-19 23:55:30 UTC (rev 207579)
@@ -34,6 +34,8 @@
 #include 
 #include 
 #include 
+#include 
+#include 
 #include 
 #include 
 
@@ -41,7 +43,7 @@
 
 namespace WebKit {
 
-Ref InjectedBundleHitTestResult::create(const WebCore::HitTestResult& hitTestResult)
+Ref InjectedBundleHitTestResult::create(const HitTestResult& hitTestResult)
 {
 return adoptRef(*new InjectedBundleHitTestResult(hitTestResult));
 }
@@ -118,7 +120,7 @@
 #if !ENABLE(VIDEO)
 return BundleHitTestResultMediaTypeNone;
 #else
-WebCore::Node* node = m_hitTestResult.innerNonSharedNode();
+Node* node = m_hitTestResult.innerNonSharedNode();
 if (!is(*node))
 return

[webkit-changes] [207577] trunk/Source/WTF

2016-10-19 Thread fpizlo 
Title: [207577] trunk/Source/WTF








Revision 207577
Author fpi...@apple.com
Date 2016-10-19 16:37:20 -0700 (Wed, 19 Oct 2016)


Log Message
REGRESSION (r207480): 3 Dromaeo tests failing
https://bugs.webkit.org/show_bug.cgi?id=163633

Reviewed by Mark Lam.

It's a ParkingLot bug: if we timeout and get unparked at the same time, then the unparking
thread will clear our address eventually - but not immediately. This causes a nasty
assertion failure. The tricky thing is that when we detect this, we need to wait until that
unparking thread does the deed. Otherwise, they will still do it at some later time.

Alternatively, we could use some kind of versioning to detect this - increment the version
when you park, so that unparking threads will know if they are time travelers. That seems
more yucky.

I don't think it matters too much what we do here, so long as it's simple and correct, since
this requires a race that is rare enough that it didn't happen once in my testing, and I was
pretty thorough. For example, it didn't happen once in 15 runs of JetStream. The race is
rare because it requires the timeout to happen right as someone else is unparking. Since
it's so rare, its probably OK that the unparked thread waits just a tiny moment until the
unparking thread is done.

* wtf/ParkingLot.cpp:
(WTF::ParkingLot::parkConditionallyImpl):
(WTF::ParkingLot::unparkOneImpl):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ParkingLot.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (207576 => 207577)

--- trunk/Source/WTF/ChangeLog	2016-10-19 23:34:45 UTC (rev 207576)
+++ trunk/Source/WTF/ChangeLog	2016-10-19 23:37:20 UTC (rev 207577)
@@ -1,5 +1,32 @@
 2016-10-19  Filip Pizlo  
 
+REGRESSION (r207480): 3 Dromaeo tests failing
+https://bugs.webkit.org/show_bug.cgi?id=163633
+
+Reviewed by Mark Lam.
+
+It's a ParkingLot bug: if we timeout and get unparked at the same time, then the unparking
+thread will clear our address eventually - but not immediately. This causes a nasty
+assertion failure. The tricky thing is that when we detect this, we need to wait until that
+unparking thread does the deed. Otherwise, they will still do it at some later time.
+
+Alternatively, we could use some kind of versioning to detect this - increment the version
+when you park, so that unparking threads will know if they are time travelers. That seems
+more yucky.
+
+I don't think it matters too much what we do here, so long as it's simple and correct, since
+this requires a race that is rare enough that it didn't happen once in my testing, and I was
+pretty thorough. For example, it didn't happen once in 15 runs of JetStream. The race is
+rare because it requires the timeout to happen right as someone else is unparking. Since
+it's so rare, its probably OK that the unparked thread waits just a tiny moment until the
+unparking thread is done.
+
+* wtf/ParkingLot.cpp:
+(WTF::ParkingLot::parkConditionallyImpl):
+(WTF::ParkingLot::unparkOneImpl):
+
+2016-10-19  Filip Pizlo  
+
 Baseline JIT should use AutomaticThread
 https://bugs.webkit.org/show_bug.cgi?id=163686
 


Modified: trunk/Source/WTF/wtf/ParkingLot.cpp (207576 => 207577)

--- trunk/Source/WTF/wtf/ParkingLot.cpp	2016-10-19 23:34:45 UTC (rev 207576)
+++ trunk/Source/WTF/wtf/ParkingLot.cpp	2016-10-19 23:37:20 UTC (rev 207577)
@@ -640,10 +640,14 @@
 
 // Make sure that no matter what, me->address is null after this point.
 {
-std::lock_guard locker(me->parkingLock);
+std::unique_lock locker(me->parkingLock);
 if (!didDequeue) {
-// If we were unparked then our address would have been reset by the unparker.
-RELEASE_ASSERT(!me->address);
+// If we did not dequeue ourselves, then someone else did. They will set our address to
+// null. We don't want to proceed until they do this, because otherwise, they may set
+// our address to null in some distant future when we're already trying to wait for
+// other things.
+while (me->address)
+me->parkingCondition.wait(locker);
 }
 me->address = nullptr;
 }
@@ -735,6 +739,7 @@
 std::unique_lock locker(threadData->parkingLock);
 threadData->address = nullptr;
 }
+// At this point, the threadData may die. Good thing we have a RefPtr<> on it.
 threadData->parkingCondition.notify_one();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207576] trunk/Source/JavaScriptCore

2016-10-19 Thread jfbastien 
Title: [207576] trunk/Source/_javascript_Core








Revision 207576
Author jfbast...@apple.com
Date 2016-10-19 16:34:45 -0700 (Wed, 19 Oct 2016)


Log Message
create_hash_table: allow empty tables

The Windows build was broken by because I added empty tables and Windows insists that empty tables are horrible. Put in dummy entries in that case.

create_hash_table: allow empty tables
https://bugs.webkit.org/show_bug.cgi?id=163701

Reviewed by Keith Miller.

* create_hash_table:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/create_hash_table




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (207575 => 207576)

--- trunk/Source/_javascript_Core/ChangeLog	2016-10-19 23:31:14 UTC (rev 207575)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-10-19 23:34:45 UTC (rev 207576)
@@ -1,5 +1,18 @@
 2016-10-19  JF Bastien  
 
+create_hash_table: allow empty tables
+
+The Windows build was broken by because I added empty tables and Windows insists that empty tables are horrible. Put in dummy entries in that case.
+
+create_hash_table: allow empty tables
+https://bugs.webkit.org/show_bug.cgi?id=163701
+
+Reviewed by Keith Miller.
+
+* create_hash_table:
+
+2016-10-19  JF Bastien  
+
 _javascript_ WebAssembly API: baby steps
 
  - Expand WebAssembly constructors into their own files. This requires a lot of


Modified: trunk/Source/_javascript_Core/create_hash_table (207575 => 207576)

--- trunk/Source/_javascript_Core/create_hash_table	2016-10-19 23:31:14 UTC (rev 207575)
+++ trunk/Source/_javascript_Core/create_hash_table	2016-10-19 23:34:45 UTC (rev 207576)
@@ -270,19 +270,31 @@
 print "\n";
 print "namespace JSC {\n";
 print "\n";
-print "static const struct CompactHashIndex ${nameIndex}\[$compactSize\] = {\n";
-for (my $i = 0; $i < $compactSize; $i++) {
-my $T = -1;
-if (defined($table[$i])) { $T = $table[$i]; }
-my $L = -1;
-if (defined($links[$i])) { $L = $links[$i]; }
-print "{ $T, $L },\n";
+if ($compactSize != 0) {
+print "static const struct CompactHashIndex ${nameIndex}\[$compactSize\] = {\n";
+for (my $i = 0; $i < $compactSize; $i++) {
+my $T = -1;
+if (defined($table[$i])) { $T = $table[$i]; }
+my $L = -1;
+if (defined($links[$i])) { $L = $links[$i]; }
+print "{ $T, $L },\n";
+}
+} else {
+# MSVC dislikes empty arrays.
+print "static const struct CompactHashIndex ${nameIndex}\[1\] = {\n";
+print "{ 0, 0 }\n";
 }
 print "};\n";
 print "\n";
 
 my $packedSize = scalar @keys;
-print "static const struct HashTableValue ${nameEntries}\[$packedSize\] = {\n";
+if ($packedSize != 0) {
+print "static const struct HashTableValue ${nameEntries}\[$packedSize\] = {\n";
+} else {
+# MSVC dislikes empty arrays.
+print "static const struct HashTableValue ${nameEntries}\[1\] = {\n";
+print "{ nullptr, 0, NoIntrinsic, { 0, 0 } }\n";
+}
 my $i = 0;
 foreach my $key (@keys) {
 my $firstValue = "";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207575] trunk

2016-10-19 Thread weinig 
Title: [207575] trunk








Revision 207575
Author wei...@apple.com
Date 2016-10-19 16:31:14 -0700 (Wed, 19 Oct 2016)


Log Message
Add support for sequences and dictionaries in unions
https://bugs.webkit.org/show_bug.cgi?id=163695

Reviewed by Chris Dumez.

Source/WebCore:

Tests:
 - Updated js/dom/webidl-type-mapping.html

* bindings/generic/IDLTypes.h:
Add additional helper predicates and fix formatting.

* bindings/js/JSDOMBinding.h:
Export hasIteratorMethod for use in testing.

* bindings/js/JSDOMConvert.h:
- Change return type of Converter to T, from Optional.
- Add support for unions conversion step 12 (parts 1-3).

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateDefaultValue):
Support complex default value computations for unions using the convert infrastructure.

(GenerateParametersCheck):
(GenerateConstructorDefinition):
Remove incorrect .value() calls now that Converter returns T.

* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
Update bindings test results.

* testing/TypeConversions.h:
(WebCore::TypeConversions::setTypeConversionsDictionary):
(WebCore::TypeConversions::typeConversionsDictionaryLongValue):
(WebCore::TypeConversions::typeConversionsDictionaryStringValue):
(WebCore::TypeConversions::typeConversionsDictionarySequenceValue):
(WebCore::TypeConversions::typeConversionsDictionaryUnionType):
* testing/TypeConversions.idl:
Add some complex types to allow testing IDL conversions from tests.

LayoutTests:

* js/dom/webidl-type-mapping-expected.txt:
* js/dom/webidl-type-mapping.html:
Add tests for more complex conversions.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt
trunk/LayoutTests/js/dom/webidl-type-mapping.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/generic/IDLTypes.h
trunk/Source/WebCore/bindings/js/JSDOMBinding.h
trunk/Source/WebCore/bindings/js/JSDOMConvert.h
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestEventConstructor.cpp
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/testing/TypeConversions.h
trunk/Source/WebCore/testing/TypeConversions.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (207574 => 207575)

--- trunk/LayoutTests/ChangeLog	2016-10-19 23:01:22 UTC (rev 207574)
+++ trunk/LayoutTests/ChangeLog	2016-10-19 23:31:14 UTC (rev 207575)
@@ -1,3 +1,14 @@
+2016-10-19  Sam Weinig  
+
+Add support for sequences and dictionaries in unions
+https://bugs.webkit.org/show_bug.cgi?id=163695
+
+Reviewed by Chris Dumez.
+
+* js/dom/webidl-type-mapping-expected.txt:
+* js/dom/webidl-type-mapping.html:
+Add tests for more complex conversions.
+
 2016-10-19  Ryan Haddad  
 
 Marking platform/mac-wk2/plugins/muted-state.html as failing.


Modified: trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt (207574 => 207575)

--- trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt	2016-10-19 23:01:22 UTC (rev 207574)
+++ trunk/LayoutTests/js/dom/webidl-type-mapping-expected.txt	2016-10-19 23:31:14 UTC (rev 207575)
@@ -1059,6 +1059,24 @@
 converter.testString = undefined
 PASS converter.testUSVString is "undefined"
 PASS converter.testString is "undefined"
+converter.setTypeConversionsDictionary({ longValue: 1 })
+PASS converter.typeConversionsDictionaryLongValue is 1
+converter.setTypeConversionsDictionary({ stringValue: 'hello' })
+PASS converter.typeConversionsDictionaryStringValue is 'hello'
+converter.setTypeConversionsDictionary({ sequenceValue: ['hi', 'there'] })
+PASS converter.typeConversionsDictionarySequenceValue is ['hi', 'there']
+converter.setTypeConversionsDictionary({ unionValue: document })
+PASS converter.typeConversionsDictionaryUnionType is 'node'
+converter.setTypeConversionsDictionary({ unionValue: ['a', 'sequence'] })
+PASS converter.typeConversionsDictionaryUnionType is 'sequence'
+converter.setTypeConversionsDictionary({ unionValue: { longValue: 1 } })
+PASS converter.typeConversionsDictionaryUnionType is 'dictionary'
+converter.setTypeConversionsDictionary({ unionValue: null })
+PASS converter.typeConversionsDictionaryUnionType is 'dictionary'
+converter.setTypeConversionsDictionary({ unionValue: undefined })
+PASS converter.typeConversionsDictionaryUnionType is 'dictionary'
+converter.setTypeConversionsDictionary({ })
+PASS converter.typeConversionsDictionaryUnionType is 'dictionary'
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/js/dom/webidl-type-mapping.html (207574 => 207575)

--- trunk/LayoutTests/js/dom/webidl-type-mapping.html	2016-10-19 23:01:22 UTC (rev 207574)
+++ trunk/LayoutTests/js/dom/webidl-type-mapping.html	2016-10-19 23:31:14 UTC (rev 207575)
@@ -586,5 +586,25 @@
 shouldBeEqualToString("converter.testString", value);
 });

[webkit-changes] [207574] trunk/LayoutTests

2016-10-19 Thread ryanhaddad 
Title: [207574] trunk/LayoutTests








Revision 207574
Author ryanhad...@apple.com
Date 2016-10-19 16:01:22 -0700 (Wed, 19 Oct 2016)


Log Message
Marking platform/mac-wk2/plugins/muted-state.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=163702

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (207573 => 207574)

--- trunk/LayoutTests/ChangeLog	2016-10-19 22:28:02 UTC (rev 207573)
+++ trunk/LayoutTests/ChangeLog	2016-10-19 23:01:22 UTC (rev 207574)
@@ -1,3 +1,12 @@
+2016-10-19  Ryan Haddad  
+
+Marking platform/mac-wk2/plugins/muted-state.html as failing.
+https://bugs.webkit.org/show_bug.cgi?id=163702
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2016-10-19  Dean Jackson  
 
 Import W3C CSS Shapes tests


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (207573 => 207574)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-10-19 22:28:02 UTC (rev 207573)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-10-19 23:01:22 UTC (rev 207574)
@@ -579,3 +579,5 @@
 webkit.org/b/161653 [ Debug ] storage/indexeddb/key-generator.html [ Pass Timeout ]
 
 webkit.org/b/163453 [ Sierra Release ] http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade-cors.https.html [ Pass Timeout ]
+
+webkit.org/b/163702 platform/mac-wk2/plugins/muted-state.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [207571] trunk

2016-10-19 Thread rniwa 
Title: [207571] trunk








Revision 207571
Author rn...@webkit.org
Date 2016-10-19 15:06:47 -0700 (Wed, 19 Oct 2016)


Log Message
Annotate more DOM and HTML IDLs with CEReactions
https://bugs.webkit.org/show_bug.cgi?id=163653

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaselined the tests now that more test cases are passing.

* web-platform-tests/custom-elements/attribute-changed-callback-expected.txt:
* web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt:
* web-platform-tests/custom-elements/reactions/Document-expected.txt:
* web-platform-tests/custom-elements/reactions/Element-expected.txt:
* web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt:
* web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt:
* web-platform-tests/custom-elements/reactions/Selection-expected.txt:

Source/WebCore:

Added CEReactions to more IDL files.

Test: fast/custom-elements/reactions-for-webkit-extensions.html

* bindings/js/JSDOMStringMapCustom.cpp:
(WebCore::JSDOMStringMap::deleteProperty): Instantiate CustomElementReactionStack, which is equivalent to
adding CEReactions in IDL.
(WebCore::JSDOMStringMap::putDelegate): Ditto.
* dom/Document.idl:
* dom/Element.idl:
* html/HTMLElement.idl:
* page/DOMSelection.idl:

LayoutTests:

Added a regression test to make sure webkitdropzone IDL attribute on HTMLElement
honors CEReactions semantics using the web-platform-tests' infrastructure I added.

* fast/custom-elements/reactions-for-webkit-extensions-expected.txt: Added.
* fast/custom-elements/reactions-for-webkit-extensions.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/attribute-changed-callback-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/DOMStringMap-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Document-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Element-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/ElementContentEditable-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/HTMLElement-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/custom-elements/reactions/Selection-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/js/JSDOMStringMapCustom.cpp
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/Element.idl
trunk/Source/WebCore/html/HTMLElement.idl
trunk/Source/WebCore/page/DOMSelection.idl


Added Paths

trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt
trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html




Diff

Modified: trunk/LayoutTests/ChangeLog (207570 => 207571)

--- trunk/LayoutTests/ChangeLog	2016-10-19 21:34:07 UTC (rev 207570)
+++ trunk/LayoutTests/ChangeLog	2016-10-19 22:06:47 UTC (rev 207571)
@@ -1,3 +1,16 @@
+2016-10-19  Ryosuke Niwa  
+
+Annotate more DOM and HTML IDLs with CEReactions
+https://bugs.webkit.org/show_bug.cgi?id=163653
+
+Reviewed by Darin Adler.
+
+Added a regression test to make sure webkitdropzone IDL attribute on HTMLElement
+honors CEReactions semantics using the web-platform-tests' infrastructure I added.
+
+* fast/custom-elements/reactions-for-webkit-extensions-expected.txt: Added.
+* fast/custom-elements/reactions-for-webkit-extensions.html: Added.
+
 2016-10-19  Ryan Haddad  
 
 Unreviewed, rolling out r207557.


Added: trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt (0 => 207571)

--- trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions-expected.txt	2016-10-19 22:06:47 UTC (rev 207571)
@@ -0,0 +1,4 @@
+
+PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when adding webkitdropzone content attribute 
+PASS dropzone on HTMLElement must enqueue an attributeChanged reaction when replacing an existing attribute 
+


Added: trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html (0 => 207571)

--- trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html	(rev 0)
+++ trunk/LayoutTests/fast/custom-elements/reactions-for-webkit-extensions.html	2016-10-19 22:06:47 UTC (rev 207571)
@@ -0,0 +1,21 @@
+
+
+
+Custom Elements: CEReactions on Attr interface
+
+
+
+
+

+