[webkit-changes] [213356] trunk/Source/JavaScriptCore

[commit-queue]

Title: [213356] trunk/Source/_javascript_Core








Revision 213356
Author commit-qu...@webkit.org
Date 2017-03-02 22:49:54 -0800 (Thu, 02 Mar 2017)


Log Message
Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
https://bugs.webkit.org/show_bug.cgi?id=169074

Patch by Carlos Garcia Campos  on 2017-03-02
Reviewed by Joseph Pecoraro.

They are not actually cocoa specific.

* inspector/remote/RemoteInspector.cpp:
(Inspector::RemoteInspector::updateTargetListing):
* inspector/remote/RemoteInspector.h:
* inspector/remote/cocoa/RemoteInspectorCocoa.mm:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp
trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h
trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213355 => 213356)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-03 06:35:25 UTC (rev 213355)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-03 06:49:54 UTC (rev 213356)
@@ -1,3 +1,17 @@
+2017-03-02  Carlos Garcia Campos  
+
+Remote Inspector: Move updateTargetListing() methods to RemoteInspector.cpp
+https://bugs.webkit.org/show_bug.cgi?id=169074
+
+Reviewed by Joseph Pecoraro.
+
+They are not actually cocoa specific.
+
+* inspector/remote/RemoteInspector.cpp:
+(Inspector::RemoteInspector::updateTargetListing):
+* inspector/remote/RemoteInspector.h:
+* inspector/remote/cocoa/RemoteInspectorCocoa.mm:
+
 2017-03-02  Mark Lam  
 
 Add WebKit2 hooks to notify the VM that the user has requested a debugger break.


Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp (213355 => 213356)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp	2017-03-03 06:35:25 UTC (rev 213355)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.cpp	2017-03-03 06:49:54 UTC (rev 213356)
@@ -207,6 +207,26 @@
 return nullptr;
 }
 
+void RemoteInspector::updateTargetListing(unsigned targetIdentifier)
+{
+auto target = m_targetMap.get(targetIdentifier);
+if (!target)
+return;
+
+updateTargetListing(*target);
+}
+
+void RemoteInspector::updateTargetListing(const RemoteControllableTarget& target)
+{
+auto targetListing = listingForTarget(target);
+if (!targetListing)
+return;
+
+m_targetListingMap.set(target.targetIdentifier(), targetListing);
+
+pushListingsSoon();
+}
+
 void RemoteInspector::updateHasActiveDebugSession()
 {
 bool hasActiveDebuggerSession = !m_targetConnectionMap.isEmpty();


Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h (213355 => 213356)

--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2017-03-03 06:35:25 UTC (rev 213355)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.h	2017-03-03 06:49:54 UTC (rev 213356)
@@ -94,9 +94,9 @@
 RetainPtr parentProcessAuditData() const { return m_parentProcessAuditData; }
 void setParentProcessInformation(pid_t, RetainPtr auditData);
 void setParentProcessInfomationIsDelayed();
+#endif
 
 void updateTargetListing(unsigned targetIdentifier);
-#endif
 
 private:
 RemoteInspector();


Modified: trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm (213355 => 213356)

--- trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm	2017-03-03 06:35:25 UTC (rev 213355)
+++ trunk/Source/_javascript_Core/inspector/remote/cocoa/RemoteInspectorCocoa.mm	2017-03-03 06:49:54 UTC (rev 213356)
@@ -445,28 +445,6 @@
 });
 }
 
-#pragma mark - Update Listing with lock
-
-void RemoteInspector::updateTargetListing(unsigned targetIdentifier)
-{
-auto target = m_targetMap.get(targetIdentifier);
-if (!target)
-return;
-
-updateTargetListing(*target);
-}
-
-void RemoteInspector::updateTargetListing(const RemoteControllableTarget& target)
-{
-RetainPtr targetListing = listingForTarget(target);
-if (!targetListing)
-return;
-
-m_targetListingMap.set(target.targetIdentifier(), targetListing);
-
-pushListingsSoon();
-}
-
 #pragma mark - Received XPC Messages
 
 void RemoteInspector::receivedSetupMessage(NSDictionary *userInfo)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213354] trunk/Source/WebKit2

[commit-queue]

Title: [213354] trunk/Source/WebKit2








Revision 213354
Author commit-qu...@webkit.org
Date 2017-03-02 22:10:27 -0800 (Thu, 02 Mar 2017)


Log Message
[Mac] Set the NSURLSessionTask priority to match the request's priority
https://bugs.webkit.org/show_bug.cgi?id=169115


Patch by Joseph Pecoraro  on 2017-03-02
Reviewed by Alex Christensen.

* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::toNSURLSessionTaskPriority):
(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
Set the priority on the task based on the ResourceRequest's priority.
This is used for HTTP/2 request prioritization.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm




Diff

Modified: trunk/Source/WebKit2/ChangeLog (213353 => 213354)

--- trunk/Source/WebKit2/ChangeLog	2017-03-03 05:53:34 UTC (rev 213353)
+++ trunk/Source/WebKit2/ChangeLog	2017-03-03 06:10:27 UTC (rev 213354)
@@ -1,3 +1,17 @@
+2017-03-02  Joseph Pecoraro  
+
+[Mac] Set the NSURLSessionTask priority to match the request's priority
+https://bugs.webkit.org/show_bug.cgi?id=169115
+
+
+Reviewed by Alex Christensen.
+
+* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
+(WebKit::toNSURLSessionTaskPriority):
+(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
+Set the priority on the task based on the ResourceRequest's priority.
+This is used for HTTP/2 request prioritization.
+
 2017-03-02  Mark Lam  
 
 Add WebKit2 hooks to notify the VM that the user has requested a debugger break.


Modified: trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm (213353 => 213354)

--- trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2017-03-03 05:53:34 UTC (rev 213353)
+++ trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm	2017-03-03 06:10:27 UTC (rev 213354)
@@ -46,6 +46,7 @@
 #import 
 
 namespace WebKit {
+
 #if USE(CREDENTIAL_STORAGE_WITH_NETWORK_SESSION)
 static void applyBasicAuthorizationHeader(WebCore::ResourceRequest& request, const WebCore::Credential& credential)
 {
@@ -54,6 +55,25 @@
 }
 #endif
 
+static float toNSURLSessionTaskPriority(WebCore::ResourceLoadPriority priority)
+{
+switch (priority) {
+case WebCore::ResourceLoadPriority::VeryLow:
+return 0;
+case WebCore::ResourceLoadPriority::Low:
+return 0.25;
+case WebCore::ResourceLoadPriority::Medium:
+return 0.5;
+case WebCore::ResourceLoadPriority::High:
+return 0.75;
+case WebCore::ResourceLoadPriority::VeryHigh:
+return 1;
+}
+
+ASSERT_NOT_REACHED();
+return NSURLSessionTaskPriorityDefault;
+}
+
 NetworkDataTaskCocoa::NetworkDataTaskCocoa(NetworkSession& session, NetworkDataTaskClient& client, const WebCore::ResourceRequest& requestWithCredentials, WebCore::StoredCredentials storedCredentials, WebCore::ContentSniffingPolicy shouldContentSniff, bool shouldClearReferrerOnHTTPSToHTTPRedirect)
 : NetworkDataTask(session, client, requestWithCredentials, storedCredentials, shouldClearReferrerOnHTTPSToHTTPRedirect)
 {
@@ -107,6 +127,9 @@
 if (!storagePartition.isEmpty())
 m_task.get()._storagePartitionIdentifier = storagePartition;
 #endif
+
+if (WebCore::ResourceRequest::resourcePrioritiesEnabled())
+m_task.get().priority = toNSURLSessionTaskPriority(request.priority());
 }
 
 NetworkDataTaskCocoa::~NetworkDataTaskCocoa()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213353] trunk

[mattbaker]

Title: [213353] trunk








Revision 213353
Author mattba...@apple.com
Date 2017-03-02 21:53:34 -0800 (Thu, 02 Mar 2017)


Log Message
Web Inspector: Should be able to push nodes in an iframe subtree to the frontend
https://bugs.webkit.org/show_bug.cgi?id=169086

Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: inspector/dom/push-node-by-path-to-frontend.html

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeForPath):
During top-down document traversal, descend into content document nodes
when visiting an HTMLFrameOwnerElement.

Source/WebInspectorUI:

* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype._selectedNodeDidChange):
Use the URL of the main frame instead of the content frame URL.

LayoutTests:

Added test coverage for DOMTreeManager.prototype.pushNodeByPathToFrontend,
which now supports pushing iframe document nodes (#document) and their descendants.

* inspector/dom/push-node-by-path-to-frontend-expected.txt: Added.
* inspector/dom/push-node-by-path-to-frontend.html: Added.
* inspector/dom/resources/frameset-frame.html: Added.
* inspector/dom/resources/frameset-iframe.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js


Added Paths

trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend-expected.txt
trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend.html
trunk/LayoutTests/inspector/dom/resources/frameset-frame.html
trunk/LayoutTests/inspector/dom/resources/frameset-iframe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (213352 => 213353)

--- trunk/LayoutTests/ChangeLog	2017-03-03 05:40:00 UTC (rev 213352)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 05:53:34 UTC (rev 213353)
@@ -1,3 +1,18 @@
+2017-03-02  Matt Baker  
+
+Web Inspector: Should be able to push nodes in an iframe subtree to the frontend
+https://bugs.webkit.org/show_bug.cgi?id=169086
+
+Reviewed by Joseph Pecoraro.
+
+Added test coverage for DOMTreeManager.prototype.pushNodeByPathToFrontend,
+which now supports pushing iframe document nodes (#document) and their descendants.
+
+* inspector/dom/push-node-by-path-to-frontend-expected.txt: Added.
+* inspector/dom/push-node-by-path-to-frontend.html: Added.
+* inspector/dom/resources/frameset-frame.html: Added.
+* inspector/dom/resources/frameset-iframe.html: Added.
+
 2017-03-02  Antoine Quint  
 
 LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout


Added: trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend-expected.txt (0 => 213353)

--- trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend-expected.txt	(rev 0)
+++ trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend-expected.txt	2017-03-03 05:53:34 UTC (rev 213353)
@@ -0,0 +1,17 @@
+Test for DOM.pushNodeByPathToFrontend.
+
+  
+
+== Running test suite: DOM.pushNodeByPathToFrontend
+-- Running test case: InlineFrameDocumentNode
+Push node with path: 1,HTML,1,BODY,1,IFRAME,0,#document
+PASS: Pushed node has correct path.
+
+-- Running test case: InlineFrameDOMNode
+Push node with path: 1,HTML,1,BODY,2,IFRAME,0,#document,0,HTML,1,BODY,0,DIV
+PASS: Pushed node has correct path.
+
+-- Running test case: InlineFrameFramesetDOMNode
+Push node with path: 1,HTML,1,BODY,3,IFRAME,0,#document,0,HTML,1,FRAMESET,0,FRAME,0,#document,0,HTML,1,BODY,0,P
+PASS: Pushed node has correct path.
+


Added: trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend.html (0 => 213353)

--- trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend.html	(rev 0)
+++ trunk/LayoutTests/inspector/dom/push-node-by-path-to-frontend.html	2017-03-03 05:53:34 UTC (rev 213353)
@@ -0,0 +1,57 @@
+
+
+
+
+function test()
+{
+let suite = InspectorTest.createAsyncSuite("DOM.pushNodeByPathToFrontend");
+
+function addTestCase({name, description, path}) {
+suite.addTestCase({
+name, description,
+test(resolve, reject) {
+InspectorTest.log("Push node with path: " + path);
+WebInspector.domTreeManager.pushNodeByPathToFrontend(path, (nodeIdentifier) => {
+if (!nodeIdentifier) {
+reject();
+return;
+}
+
+let node = WebInspector.domTreeManager.nodeForId(nodeIdentifier);
+InspectorTest.expectEqual(node.path(), path, "Pushed node has correct path.");
+resolve();
+});
+}
+});
+}
+
+addTestCase({
+name: "InlineFrameDocumentNode",
+description: "Check that a child frame 

[webkit-changes] [213352] trunk/Source

[jmarcell]

Title: [213352] trunk/Source








Revision 213352
Author jmarc...@apple.com
Date 2017-03-02 21:40:00 -0800 (Thu, 02 Mar 2017)


Log Message
Versioning.

Modified Paths

trunk/Source/_javascript_Core/Configurations/Version.xcconfig
trunk/Source/WebCore/Configurations/Version.xcconfig
trunk/Source/WebCore/PAL/Configurations/Version.xcconfig
trunk/Source/WebInspectorUI/Configurations/Version.xcconfig
trunk/Source/WebKit/mac/Configurations/Version.xcconfig
trunk/Source/WebKit2/Configurations/Version.xcconfig




Diff

Modified: trunk/Source/_javascript_Core/Configurations/Version.xcconfig (213351 => 213352)

--- trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2017-03-03 05:33:00 UTC (rev 213351)
+++ trunk/Source/_javascript_Core/Configurations/Version.xcconfig	2017-03-03 05:40:00 UTC (rev 213352)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/Configurations/Version.xcconfig (213351 => 213352)

--- trunk/Source/WebCore/Configurations/Version.xcconfig	2017-03-03 05:33:00 UTC (rev 213351)
+++ trunk/Source/WebCore/Configurations/Version.xcconfig	2017-03-03 05:40:00 UTC (rev 213352)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebCore/PAL/Configurations/Version.xcconfig (213351 => 213352)

--- trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-03-03 05:33:00 UTC (rev 213351)
+++ trunk/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-03-03 05:40:00 UTC (rev 213352)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebInspectorUI/Configurations/Version.xcconfig (213351 => 213352)

--- trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-03-03 05:33:00 UTC (rev 213351)
+++ trunk/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-03-03 05:40:00 UTC (rev 213352)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit/mac/Configurations/Version.xcconfig (213351 => 213352)

--- trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2017-03-03 05:33:00 UTC (rev 213351)
+++ trunk/Source/WebKit/mac/Configurations/Version.xcconfig	2017-03-03 05:40:00 UTC (rev 213352)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: trunk/Source/WebKit2/Configurations/Version.xcconfig (213351 => 213352)

--- trunk/Source/WebKit2/Configurations/Version.xcconfig	2017-03-03 05:33:00 UTC (rev 213351)
+++ trunk/Source/WebKit2/Configurations/Version.xcconfig	2017-03-03 05:40:00 UTC (rev 213352)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 8;
+TINY_VERSION = 9;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213351] trunk/LayoutTests

[commit-queue]

Title: [213351] trunk/LayoutTests








Revision 213351
Author commit-qu...@webkit.org
Date 2017-03-02 21:33:00 -0800 (Thu, 02 Mar 2017)


Log Message
LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=169109


Patch by Antoine Quint  on 2017-03-02
Reviewed by Simon Fraser.

Ensure the tracks button is sized before pressing it to make the track panel appear.

* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt
trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html




Diff

Modified: trunk/LayoutTests/ChangeLog (213350 => 213351)

--- trunk/LayoutTests/ChangeLog	2017-03-03 05:22:28 UTC (rev 213350)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 05:33:00 UTC (rev 213351)
@@ -1,5 +1,18 @@
 2017-03-02  Antoine Quint  
 
+LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=169109
+
+
+Reviewed by Simon Fraser.
+
+Ensure the tracks button is sized before pressing it to make the track panel appear.
+
+* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt:
+* media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
+
+2017-03-02  Antoine Quint  
+
 Remove references to tests that no longer exist and remove a duplicate test.
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt (213350 => 213351)

--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt	2017-03-03 05:22:28 UTC (rev 213350)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel-expected.txt	2017-03-03 05:33:00 UTC (rev 213351)
@@ -7,6 +7,8 @@
 media.audioTracks[1].enabled = false
 media.audioTracks[2].enabled = false
 
+PASS shadowRoot.lastChild.querySelector('button.tracks').getBoundingClientRect().width became different from 0
+
 Clicking on the tracks button
 Clicking on second audio track in tracks panel
 


Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html (213350 => 213351)

--- trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html	2017-03-03 05:22:28 UTC (rev 213350)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html	2017-03-03 05:33:00 UTC (rev 213351)
@@ -19,7 +19,11 @@
 dumpAudioTracksEnabledState();
 
 media.audioTracks.addEventListener("change", audioTracksDidChange);
-clickOnTracksButton(clickOnSecondAudioTrack);
+
+debug("");
+shouldBecomeDifferent("shadowRoot.lastChild.querySelector('button.tracks').getBoundingClientRect().width", "0", () => {
+clickOnTracksButton(clickOnSecondAudioTrack);
+});
 });
 
 function clickOnTracksButton(continuation)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213350] trunk/Source/WebCore

[ryanhaddad]

Title: [213350] trunk/Source/WebCore








Revision 213350
Author ryanhad...@apple.com
Date 2017-03-02 21:22:28 -0800 (Thu, 02 Mar 2017)


Log Message
Unreviewed, rolling out r213274.

This change caused flakiness with LayoutTest memory/memory-
pressure-simulation.html

Reverted changeset:

"Don't keep dead resources in MemoryCache while under memory
pressure."
https://bugs.webkit.org/show_bug.cgi?id=169070
http://trac.webkit.org/changeset/213274

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResource.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (213349 => 213350)

--- trunk/Source/WebCore/ChangeLog	2017-03-03 05:21:51 UTC (rev 213349)
+++ trunk/Source/WebCore/ChangeLog	2017-03-03 05:22:28 UTC (rev 213350)
@@ -1,3 +1,17 @@
+2017-03-02  Ryan Haddad  
+
+Unreviewed, rolling out r213274.
+
+This change caused flakiness with LayoutTest memory/memory-
+pressure-simulation.html
+
+Reverted changeset:
+
+"Don't keep dead resources in MemoryCache while under memory
+pressure."
+https://bugs.webkit.org/show_bug.cgi?id=169070
+http://trac.webkit.org/changeset/213274
+
 2017-03-02  Jiewen Tan  
 
 WebCrypto API support for AES-GCM


Modified: trunk/Source/WebCore/loader/cache/CachedResource.cpp (213349 => 213350)

--- trunk/Source/WebCore/loader/cache/CachedResource.cpp	2017-03-03 05:21:51 UTC (rev 213349)
+++ trunk/Source/WebCore/loader/cache/CachedResource.cpp	2017-03-03 05:22:28 UTC (rev 213350)
@@ -549,12 +549,6 @@
 bool CachedResource::deleteIfPossible()
 {
 if (canDelete()) {
-if (inCache() && MemoryPressureHandler::singleton().isUnderMemoryPressure()) {
-MemoryCache::singleton().remove(*this);
-// MemoryCache::remove() will call back into deleteIfPossible() and succeed.
-// FIXME: This would be less incomprehensible if CachedResource were ref-counted.
-return true;
-}
 if (!inCache()) {
 InspectorInstrumentation::willDestroyCachedResource(*this);
 delete this;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213349] trunk/LayoutTests

[graouts]

Title: [213349] trunk/LayoutTests








Revision 213349
Author grao...@webkit.org
Date 2017-03-02 21:21:51 -0800 (Thu, 02 Mar 2017)


Log Message
Remove references to tests that no longer exist and remove a duplicate test.

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213348 => 213349)

--- trunk/LayoutTests/ChangeLog	2017-03-03 04:47:31 UTC (rev 213348)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 05:21:51 UTC (rev 213349)
@@ -1,5 +1,13 @@
 2017-03-02  Antoine Quint  
 
+Remove references to tests that no longer exist and remove a duplicate test.
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
+2017-03-02  Antoine Quint  
+
 [ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=168668
 


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (213348 => 213349)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-03-03 04:47:31 UTC (rev 213348)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-03-03 05:21:51 UTC (rev 213349)
@@ -630,7 +630,6 @@
 css3/filters/effect-sepia-hw.html [ Failure ]
 css3/filters/effect-sepia.html [ Failure ]
 css3/filters/regions-expanding.html [ Failure ]
-css3/flexbox/auto-margins.html [ ImageOnlyFailure ]
 css3/flexbox/button.html [ Failure ]
 css3/flexbox/flexitem.html [ Failure ]
 css3/images/cross-fade-background-size.html [ Failure ]
@@ -2806,7 +2805,6 @@
 media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html [ Skip ]
 media/modern-media-controls/scrubber-support/scrubber-support-click.html [ Skip ]
 media/modern-media-controls/media-documents/click-on-video-should-not-pause.html [ Skip ]
-media/modern-media-controls/media-documents/click-on-video-should-not-pause.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-click-on-video-background-should-pause-fullscreen.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-click-on-video-background-to-dismiss-tracks-panel-should-not-toggle-playback.html [ Skip ]
@@ -2841,12 +2839,8 @@
 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-buttons-styles.html [ Skip ]
 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact-controls-bar-styles.html [ Skip ]
 media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-compact.html [ Skip ]
-media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-reduced-padding.html [ Skip ]
-media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-tight-padding.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-compact.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-reduced-padding.html [ Skip ]
 media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
-media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html [ Skip ]
 
 # Form validation popover does not obey minimum font size setting on iOS but Dynamic Type instead.
 fast/forms/validation-message-minimum-font-size.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213348] trunk/LayoutTests

[commit-queue]

Title: [213348] trunk/LayoutTests








Revision 213348
Author commit-qu...@webkit.org
Date 2017-03-02 20:47:31 -0800 (Thu, 02 Mar 2017)


Log Message
[ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=168668


Patch by Antoine Quint  on 2017-03-02
Reviewed by Simon Fraser.

This test would sometime fail for the first assertion because we may need more than just metadata
to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
fullscreen button and then force it to error to disable it.

* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt
trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213347 => 213348)

--- trunk/LayoutTests/ChangeLog	2017-03-03 04:31:04 UTC (rev 213347)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 04:47:31 UTC (rev 213348)
@@ -1,5 +1,22 @@
 2017-03-02  Antoine Quint  
 
+[ios-simulator Debug WK2] LayoutTest media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=168668
+
+
+Reviewed by Simon Fraser.
+
+This test would sometime fail for the first assertion because we may need more than just metadata
+to determine that we can be in a state where the fullscreen button becomes enabled (see the logic
+in FullscreenSupport). So we now use an asynchronous assertion to determine we've enabled the
+fullscreen button and then force it to error to disable it.
+
+* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
+* media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
+* platform/ios-simulator/TestExpectations:
+
+2017-03-02  Antoine Quint  
+
 [iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
 https://bugs.webkit.org/show_bug.cgi?id=168343
 


Modified: trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt (213347 => 213348)

--- trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt	2017-03-03 04:31:04 UTC (rev 213347)
+++ trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt	2017-03-03 04:47:31 UTC (rev 213348)
@@ -3,7 +3,10 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS mediaController.controls.fullscreenButton.enabled is true
+Once media loads and we have tracks in the video, the fullscreen button should become enabled
+PASS mediaController.controls.fullscreenButton.enabled became true
+
+We now set the media source to be the empty string to force an error, which should disable the fullscreen button
 PASS mediaController.controls.fullscreenButton.enabled is false
 
 PASS successfullyParsed is true


Modified: trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html (213347 => 213348)

--- trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html	2017-03-03 04:31:04 UTC (rev 213347)
+++ trunk/LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html	2017-03-03 04:47:31 UTC (rev 213348)
@@ -27,19 +27,20 @@
 const media = document.querySelector("video");
 const mediaController = createControls(container, media, null);
 
-media.addEventListener("loadedmetadata", () => {
-shouldBeTrue("mediaController.controls.fullscreenButton.enabled");
+debug("Once media loads and we have tracks in the video, the fullscreen button should become enabled");
+shouldBecomeEqual("mediaController.controls.fullscreenButton.enabled", "true", () => {
+media.addEventListener("error", () => {
+shouldBeFalse("mediaController.controls.fullscreenButton.enabled");
+debug("");
+container.remove();
+media.remove();
+finishJSTest();
+});
+debug("");
+debug("We now set the media source to be the empty string to force an error, which should disable the fullscreen button");
 media.src = ""
 });
 
-media.addEventListener("error", 

[webkit-changes] [213347] tags/Safari-604.1.8.0.1/

[lforschler]

Title: [213347] tags/Safari-604.1.8.0.1/








Revision 213347
Author lforsch...@apple.com
Date 2017-03-02 20:31:04 -0800 (Thu, 02 Mar 2017)


Log Message
Tag Safari-604.1.8.0.1

Added Paths

tags/Safari-604.1.8.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213346] trunk/LayoutTests

[commit-queue]

Title: [213346] trunk/LayoutTests








Revision 213346
Author commit-qu...@webkit.org
Date 2017-03-02 20:27:42 -0800 (Thu, 02 Mar 2017)


Log Message
[iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168343


Patch by Antoine Quint  on 2017-03-02
Reviewed by Simon Fraser.

Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.

* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213345 => 213346)

--- trunk/LayoutTests/ChangeLog	2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 04:27:42 UTC (rev 213346)
@@ -1,3 +1,17 @@
+2017-03-02  Antoine Quint  
+
+[iOS Release WK2] LayoutTest media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html is a flaky timeout
+https://bugs.webkit.org/show_bug.cgi?id=168343
+
+
+Reviewed by Simon Fraser.
+
+Use an asynchronous assertion to ensure we have valid metrics before pressing the skip back button.
+
+* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt:
+* media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html:
+* platform/ios-simulator/TestExpectations:
+
 2017-03-02  Jiewen Tan  
 
 WebCrypto API support for AES-GCM


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt (213345 => 213346)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt	2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button-expected.txt	2017-03-03 04:27:42 UTC (rev 213346)
@@ -3,6 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
+PASS window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width became different from 0
 PASS window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded') is false
 PASS successfullyParsed is true
 


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html (213345 => 213346)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html	2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-ios-do-not-hide-controls-when-tapping-button.html	2017-03-03 04:27:42 UTC (rev 213346)
@@ -12,10 +12,12 @@
 const media = document.querySelector("video");
 
 media.addEventListener("play", event => {
-pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
-window.requestAnimationFrame(() => {
-shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
-finishJSTest();
+shouldBecomeDifferent("window.internals.shadowRoot(media).querySelector('button.skip-back').getBoundingClientRect().width", "0", () => {
+pressOnElement(window.internals.shadowRoot(media).querySelector("button.skip-back"), () => {
+window.requestAnimationFrame(() => {
+shouldBeFalse("window.internals.shadowRoot(media).querySelector('.controls-bar').classList.contains('faded')");
+finishJSTest();
+});
 });
 });
 });


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (213345 => 213346)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-03-03 04:24:14 UTC (rev 213345)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2017-03-03 04:27:42 UTC (rev 213346)
@@ -2848,8 +2848,6 @@
 media/modern-media-controls/media-controller/media-controller-tight-padding.html [ Skip ]
 

[webkit-changes] [213344] trunk

[aestes]

Title: [213344] trunk








Revision 213344
Author aes...@apple.com
Date 2017-03-02 20:12:15 -0800 (Thu, 02 Mar 2017)


Log Message
Add support for canvas.toBlob
https://bugs.webkit.org/show_bug.cgi?id=148878


Reviewed by Tim Horton.

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:

Source/WebCore:

These tests now pass:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png.html

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/BlobCallback.cpp: Added.
(WebCore::BlobCallback::scheduleCallback):
* fileapi/BlobCallback.h: Added.
(WebCore::BlobCallback::~BlobCallback):
* fileapi/BlobCallback.idl: Added.
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::toBlob):
* html/HTMLCanvasElement.h:
* html/HTMLCanvasElement.idl:
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::writeFunction):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::data):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
(WebCore::ImageBuffer::toCGImage):
(WebCore::cgImage):
(WebCore::dataURL):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
* platform/graphics/win/ImageBufferDirect2D.cpp:
(WebCore::ImageBuffer::toData):

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/DerivedSources.make
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/html/HTMLCanvasElement.cpp
trunk/Source/WebCore/html/HTMLCanvasElement.h
trunk/Source/WebCore/html/HTMLCanvasElement.idl
trunk/Source/WebCore/platform/graphics/ImageBuffer.h
trunk/Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp
trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp
trunk/Source/WebCore/platform/graphics/gtk/ImageBufferGtk.cpp
trunk/Source/WebCore/platform/graphics/win/ImageBufferDirect2D.cpp


Added Paths

trunk/Source/WebCore/fileapi/BlobCallback.cpp
trunk/Source/WebCore/fileapi/BlobCallback.h
trunk/Source/WebCore/fileapi/BlobCallback.idl




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (213343 => 213344)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-03 03:59:01 UTC (rev 213343)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2017-03-03 04:12:15 UTC (rev 213344)
@@ -1,3 +1,14 @@
+2017-03-02  Andy Estes  
+
+Add support for canvas.toBlob
+https://bugs.webkit.org/show_bug.cgi?id=148878
+
+
+Reviewed by Tim Horton.
+
+* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
+* web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:
+
 2017-03-02  Ryan Haddad  
 
 Unreviewed, rolling out r213301.


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt (213343 => 213344)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt	2017-03-03 03:59:01 UTC (rev 213343)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt	2017-03-03 04:12:15 UTC (rev 213344)
@@ -1,5 +1,3 @@
 
-FAIL toBlob with image/jpeg returns a JPEG Blob canvas.toBlob is not a function. (In 'canvas.toBlob(this.step_func_done(function(data) {
-assert_equals(data.type, "image/jpeg");
-}), 'image/jpeg')', 'canvas.toBlob' is undefined)
+PASS toBlob with image/jpeg returns a JPEG Blob 
 


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt (213343 => 213344)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt	2017-03-03 03:59:01 UTC (rev 213343)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt	2017-03-03 04:12:15 UTC (rev 213344)
@@ -1,5 +1,3 @@
 
-FAIL toBlob with image/png returns a PNG Blob canvas.toBlob is not a function. (In 'canvas.toBlob(this.step_func_done(function(data) {
-

[webkit-changes] [213343] trunk/LayoutTests

[ryanhaddad]

Title: [213343] trunk/LayoutTests








Revision 213343
Author ryanhad...@apple.com
Date 2017-03-02 19:59:01 -0800 (Thu, 02 Mar 2017)


Log Message
Unreviewed, rolling out r213332.

These tests are failing on ios-simulator debug.

Reverted changeset:

"[iOS] Enable webrtc tests for debug builds"
https://bugs.webkit.org/show_bug.cgi?id=169108
http://trac.webkit.org/changeset/213332

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213342 => 213343)

--- trunk/LayoutTests/ChangeLog	2017-03-03 03:28:32 UTC (rev 213342)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 03:59:01 UTC (rev 213343)
@@ -1,3 +1,15 @@
+2017-03-02  Ryan Haddad  
+
+Unreviewed, rolling out r213332.
+
+These tests are failing on ios-simulator debug.
+
+Reverted changeset:
+
+"[iOS] Enable webrtc tests for debug builds"
+https://bugs.webkit.org/show_bug.cgi?id=169108
+http://trac.webkit.org/changeset/213332
+
 2017-03-02  Antoine Quint  
 
 LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure


Modified: trunk/LayoutTests/TestExpectations (213342 => 213343)

--- trunk/LayoutTests/TestExpectations	2017-03-03 03:28:32 UTC (rev 213342)
+++ trunk/LayoutTests/TestExpectations	2017-03-03 03:59:01 UTC (rev 213343)
@@ -692,7 +692,7 @@
 # GTK enables some of this tests on their TestExpectations file.
 [ Release ] webrtc [ Skip ]
 
-[ Debug ] webrtc/audio-peer-connection-webaudio.html [ Failure ]
+webrtc/audio-peer-connection-webaudio.html [ Failure ]
 fast/mediastream/getUserMedia-webaudio.html [ Skip ]
 fast/mediastream/RTCPeerConnection-AddRemoveStream.html [ Skip ]
 fast/mediastream/RTCPeerConnection-closed-state.html [ Skip ]


Modified: trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations (213342 => 213343)

--- trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2017-03-03 03:28:32 UTC (rev 213342)
+++ trunk/LayoutTests/platform/ios-simulator-wk2/TestExpectations	2017-03-03 03:59:01 UTC (rev 213343)
@@ -1917,7 +1917,7 @@
 webkit.org/b/166025 http/tests/fetch/fetching-same-resource-with-diffferent-options.html [ Pass Failure ]
 
 imported/w3c/web-platform-tests/webrtc [ Skip ]
-[ Release ] webrtc [ Skip ]
+webrtc [ Skip ]
 
 # Skipped because there is no key to show the context menu
 fast/events/context-activated-by-key-event.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213342] trunk/LayoutTests

[commit-queue]

Title: [213342] trunk/LayoutTests








Revision 213342
Author commit-qu...@webkit.org
Date 2017-03-02 19:28:32 -0800 (Thu, 02 Mar 2017)


Log Message
LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=167396

Patch by Antoine Quint  on 2017-03-02
Reviewed by Simon Fraser.

Since timing is hard to test accurately, simplify the test to only check that we're transitioning
from one state to another and use the asynchronous, polling-based assertions to check that we will
be transitioning between those two states (visible and faded).

* media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt:
* media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213341 => 213342)

--- trunk/LayoutTests/ChangeLog	2017-03-03 03:17:35 UTC (rev 213341)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 03:28:32 UTC (rev 213342)
@@ -1,5 +1,20 @@
 2017-03-02  Antoine Quint  
 
+LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=167396
+
+Reviewed by Simon Fraser.
+
+Since timing is hard to test accurately, simplify the test to only check that we're transitioning
+from one state to another and use the asynchronous, polling-based assertions to check that we will
+be transitioning between those two states (visible and faded).
+
+* media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt:
+* media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
+* platform/mac/TestExpectations:
+
+2017-03-02  Antoine Quint  
+
 LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=167348
 


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt (213341 => 213342)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt	2017-03-03 03:17:35 UTC (rev 213341)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter-expected.txt	2017-03-03 03:28:32 UTC (rev 213342)
@@ -3,18 +3,20 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Video started playing, controls bar is visible by default.
-PASS controlsBar.classList.contains('faded') is false
+PASS !!shadowRoot.querySelector('.controls-bar') became true
 
-Auto-hide timer has elapsed, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
+Video started playing, controls bar should become visible by default.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
 
-Mouse moved over the media, controls bar should be visible.
-PASS controlsBar.classList.contains('faded') is false
+Controls bar should fade when the auto-hide timer has elapsed.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
 
-Auto-hide timer has elapsed, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
+Mouse moved over the media, controls bar should become visible.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
 
+Controls bar should fade when the auto-hide timer has elapsed.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
+
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html (213341 => 213342)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html	2017-03-03 03:17:35 UTC (rev 213341)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html	2017-03-03 03:28:32 UTC (rev 213342)
@@ -1,7 +1,7 @@
 
 

[webkit-changes] [213341] trunk

[mmaxfield]

Title: [213341] trunk








Revision 213341
Author mmaxfi...@apple.com
Date 2017-03-02 19:17:35 -0800 (Thu, 02 Mar 2017)


Log Message
Migrate font-stretch to use fixed-point values
https://bugs.webkit.org/show_bug.cgi?id=169107

Reviewed by Dean Jackson.

Source/WebCore:

There are a few benefits of using fixed-point values:
- Not all of the entropy of a float is necessary for font selection. In particular, values are
expected to stay between around -1000 to 1000, and only need to have a few fractional bits.
Therefore, the values can be represented by 16-bit fixed point numbers, which includes one sign
bit and two fractional bits. This is smaller than the 32-bit floating point numbers we were
using, which means FontDescription can be slimmed down. This becomes even more important when
the rest of the variation font properties are implemented, since those will use these fixed-
point values too.
- Fixed point values have a larger distance between adjacent representable values, which means
there are more collisions, which means our cache hit rates are higher.

No new tests because there is no behavior change.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::fontStretchFromStyle):
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertFontStretch):
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::FontDescriptionKey):
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::stretch):
(WebCore::FontDescription::setStretch):
(WebCore::FontCascadeDescription::initialStretch):
* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::defaultFontSelectionValues):
(WebCore::preparePlatformFont):
(WebCore::FontDatabase::InstalledFont::InstalledFont):
(WebCore::FontDatabase::InstalledFontFamily::expand):
(WebCore::FontDatabase::capabilitiesForFontDescriptor):
(WebCore::FontDatabase::stretchThreshold):
(WebCore::FontDatabase::italicThreshold):
(WebCore::FontDatabase::weightThreshold):
(WebCore::findClosestStretch):
(WebCore::filterStretch):
(WebCore::findClosestStyle):
(WebCore::filterStyle):
(WebCore::findClosestWeight):
(WebCore::filterWeight):
(WebCore::computeTargetWeight):
(WebCore::findClosestFont):
(WebCore::platformFontLookupWithFamily):
(WebCore::fontWithFamily):
(WebCore::defaultVariationValues): Deleted.
(WebCore::FontDatabase::Range::Range): Deleted.
(WebCore::FontDatabase::Range::isValid): Deleted.
(WebCore::FontDatabase::Range::expand): Deleted.
(WebCore::FontDatabase::Range::includes): Deleted.
(): Deleted.
* platform/text/TextFlags.h:
(WebCore::FontSelectionValue::FontSelectionValue):
(WebCore::FontSelectionValue::operator float):
(WebCore::FontSelectionValue::operator+):
(WebCore::FontSelectionValue::operator-):
(WebCore::FontSelectionValue::operator*):
(WebCore::FontSelectionValue::operator/):
(WebCore::FontSelectionValue::operator==):
(WebCore::FontSelectionValue::operator!=):
(WebCore::FontSelectionValue::operator<):
(WebCore::FontSelectionValue::operator<=):
(WebCore::FontSelectionValue::operator>):
(WebCore::FontSelectionValue::operator>=):
(WebCore::FontSelectionValue::rawValue):
(WebCore::FontSelectionRange::isValid):
(WebCore::FontSelectionRange::expand):
(WebCore::FontSelectionRange::includes):
(WebCore::FontSelectionCapabilities::expand):

Tools:

Update to new types.

* TestWebKitAPI/Tests/WebCore/FontCache.cpp:
(TestWebKitAPI::createPlatformFont):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/StyleBuilderConverter.h
trunk/Source/WebCore/platform/graphics/FontCache.h
trunk/Source/WebCore/platform/graphics/FontDescription.h
trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp
trunk/Source/WebCore/platform/text/TextFlags.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/FontCache.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (213340 => 213341)

--- trunk/Source/WebCore/ChangeLog	2017-03-03 02:45:28 UTC (rev 213340)
+++ trunk/Source/WebCore/ChangeLog	2017-03-03 03:17:35 UTC (rev 213341)
@@ -1,3 +1,77 @@
+2017-03-02  Myles C. Maxfield  
+
+Migrate font-stretch to use fixed-point values
+https://bugs.webkit.org/show_bug.cgi?id=169107
+
+Reviewed by Dean Jackson.
+
+There are a few benefits of using fixed-point values:
+- Not all of the entropy of a float is necessary for font selection. In particular, values are
+expected to stay between around -1000 to 1000, and only need to have a few fractional bits.
+Therefore, the values can be represented by 16-bit fixed point numbers, which includes one sign
+bit and two fractional bits. This is smaller than the 32-bit floating point numbers we were
+using, which means FontDescription can be slimmed down. This becomes even more important when
+the rest of the variation font properties are implemented, since those will use these fixed-
+point values too.
+- Fixed point values have 

[webkit-changes] [213340] trunk/LayoutTests

[commit-queue]

Title: [213340] trunk/LayoutTests








Revision 213340
Author commit-qu...@webkit.org
Date 2017-03-02 18:45:28 -0800 (Thu, 02 Mar 2017)


Log Message
LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=167348


Patch by Antoine Quint  on 2017-03-02
Reviewed by Tim Horton.

Since timing is hard to test accurately, simplify the test to only check that we're transitioning
from one state to another and use the asynchronous, polling-based assertions to check that we will
be transitioning between those two states (visible and faded).

* media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt:
* media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213339 => 213340)

--- trunk/LayoutTests/ChangeLog	2017-03-03 02:45:25 UTC (rev 213339)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 02:45:28 UTC (rev 213340)
@@ -1,5 +1,21 @@
 2017-03-02  Antoine Quint  
 
+LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=167348
+
+
+Reviewed by Tim Horton.
+
+Since timing is hard to test accurately, simplify the test to only check that we're transitioning
+from one state to another and use the asynchronous, polling-based assertions to check that we will
+be transitioning between those two states (visible and faded).
+
+* media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt:
+* media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
+* platform/mac/TestExpectations:
+
+2017-03-02  Antoine Quint  
+
 LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky
 https://bugs.webkit.org/show_bug.cgi?id=167263
 


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt (213339 => 213340)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt	2017-03-03 02:45:25 UTC (rev 213339)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave-expected.txt	2017-03-03 02:45:28 UTC (rev 213340)
@@ -3,18 +3,20 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Video started playing, controls bar is visible by default.
-PASS controlsBar.classList.contains('faded') is false
+PASS !!shadowRoot.querySelector('.controls-bar') became true
 
-Auto-hide timer has elapsed, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
+Video started playing, controls bar should become visible by default.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
 
-Mouse moved over the media, controls bar should be visible.
-PASS controlsBar.classList.contains('faded') is false
+Controls bar should become faded when the auto-hide timer elapses.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
 
-Mouse moved out of the media, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
+Mouse moved over the media, controls bar should become visible again.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
 
+Mouse moved out of the media, controls bar should become faded.
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
+
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html (213339 => 213340)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html	2017-03-03 02:45:25 UTC (rev 213339)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html	2017-03-03 02:45:28 UTC (rev 213340)
@@ -1,7 +1,7 @@
 
 

[webkit-changes] [213339] trunk/Source/WebKit/mac

[megan_gardner]

Title: [213339] trunk/Source/WebKit/mac








Revision 213339
Author megan_gard...@apple.com
Date 2017-03-02 18:45:25 -0800 (Thu, 02 Mar 2017)


Log Message
Fix 32-bit
https://bugs.webkit.org/show_bug.cgi?id=169114

Reviewed by Alex Christensen.

* WebView/WebView.mm:

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (213338 => 213339)

--- trunk/Source/WebKit/mac/ChangeLog	2017-03-03 02:42:52 UTC (rev 213338)
+++ trunk/Source/WebKit/mac/ChangeLog	2017-03-03 02:45:25 UTC (rev 213339)
@@ -1,5 +1,14 @@
 2017-03-02  Megan Gardner  
 
+Fix 32-bit
+https://bugs.webkit.org/show_bug.cgi?id=169114
+
+Reviewed by Alex Christensen.
+
+* WebView/WebView.mm:
+
+2017-03-02  Megan Gardner  
+
 More guard fixing
 https://bugs.webkit.org/show_bug.cgi?id=169112
 


Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (213338 => 213339)

--- trunk/Source/WebKit/mac/WebView/WebView.mm	2017-03-03 02:42:52 UTC (rev 213338)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2017-03-03 02:45:25 UTC (rev 213339)
@@ -675,7 +675,7 @@
 }
 
 @end
-#else
+#elif !PLATFORM(MAC)
 @implementation WebUITextIndicatorData
 @end
 #endif // ENABLE(DATA_INTERACTION)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [213338] trunk/Source

[mark . lam]

Title: [213338] trunk/Source








Revision 213338
Author mark@apple.com
Date 2017-03-02 18:42:52 -0800 (Thu, 02 Mar 2017)


Log Message
Add WebKit2 hooks to notify the VM that the user has requested a debugger break.
https://bugs.webkit.org/show_bug.cgi?id=169089

Reviewed by Tim Horton and Joseph Pecoraro.

Source/_javascript_Core:

* runtime/VM.cpp:
(JSC::VM::handleTraps):
* runtime/VM.h:
(JSC::VM::notifyNeedDebuggerBreak):

Source/WebKit2:

* CMakeLists.txt:
* DerivedSources.make:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::connect):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp: Added.
(WebKit::WebInspectorInterruptDispatcher::create):
(WebKit::WebInspectorInterruptDispatcher::WebInspectorInterruptDispatcher):
(WebKit::WebInspectorInterruptDispatcher::~WebInspectorInterruptDispatcher):
(WebKit::WebInspectorInterruptDispatcher::initializeConnection):
(WebKit::WebInspectorInterruptDispatcher::notifyNeedDebuggerBreak):
* WebProcess/WebPage/WebInspectorInterruptDispatcher.h: Added.
* WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in: Added.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeConnection):
* WebProcess/WebProcess.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/VM.cpp
trunk/Source/_javascript_Core/runtime/VM.h
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/DerivedSources.make
trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp
trunk/Source/WebKit2/WebKit2.xcodeproj/project.pbxproj
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/WebProcess.h


Added Paths

trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp
trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.h
trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (213337 => 213338)

--- trunk/Source/_javascript_Core/ChangeLog	2017-03-03 02:05:32 UTC (rev 213337)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-03-03 02:42:52 UTC (rev 213338)
@@ -1,3 +1,15 @@
+2017-03-02  Mark Lam  
+
+Add WebKit2 hooks to notify the VM that the user has requested a debugger break.
+https://bugs.webkit.org/show_bug.cgi?id=169089
+
+Reviewed by Tim Horton and Joseph Pecoraro.
+
+* runtime/VM.cpp:
+(JSC::VM::handleTraps):
+* runtime/VM.h:
+(JSC::VM::notifyNeedDebuggerBreak):
+
 2017-03-02  Michael Saboff  
 
 Add JSC identity when code signing to allow debugging on iOS


Modified: trunk/Source/_javascript_Core/runtime/VM.cpp (213337 => 213338)

--- trunk/Source/_javascript_Core/runtime/VM.cpp	2017-03-03 02:05:32 UTC (rev 213337)
+++ trunk/Source/_javascript_Core/runtime/VM.cpp	2017-03-03 02:42:52 UTC (rev 213338)
@@ -957,7 +957,9 @@
 auto trapEventType = m_traps.takeTopPriorityTrap(mask);
 switch (trapEventType) {
 case VMTraps::NeedDebuggerBreak:
-RELEASE_ASSERT_NOT_REACHED();
+if (Options::alwaysCheckTraps())
+dataLog("VM ", RawPointer(this), " on pid ", getCurrentProcessID(), " received NeedDebuggerBreak trap\n");
+return;
 
 case VMTraps::NeedWatchdogCheck:
 ASSERT(m_watchdog);


Modified: trunk/Source/_javascript_Core/runtime/VM.h (213337 => 213338)

--- trunk/Source/_javascript_Core/runtime/VM.h	2017-03-03 02:05:32 UTC (rev 213337)
+++ trunk/Source/_javascript_Core/runtime/VM.h	2017-03-03 02:42:52 UTC (rev 213338)
@@ -676,6 +676,7 @@
 bool needTrapHandling(VMTraps::Mask mask = VMTraps::Mask::allEventTypes()) { return m_traps.needTrapHandling(mask); }
 void* needTrapHandlingAddress() { return m_traps.needTrapHandlingAddress(); }
 
+void notifyNeedDebuggerBreak() { m_traps.fireTrap(VMTraps::NeedDebuggerBreak); }
 void notifyNeedTermination() { m_traps.fireTrap(VMTraps::NeedTermination); }
 void notifyNeedWatchdogCheck() { m_traps.fireTrap(VMTraps::NeedWatchdogCheck); }
 


Modified: trunk/Source/WebKit2/CMakeLists.txt (213337 => 213338)

--- trunk/Source/WebKit2/CMakeLists.txt	2017-03-03 02:05:32 UTC (rev 213337)
+++ trunk/Source/WebKit2/CMakeLists.txt	2017-03-03 02:42:52 UTC (rev 213338)
@@ -572,6 +572,7 @@
 WebProcess/WebPage/WebDocumentLoader.cpp
 WebProcess/WebPage/WebFrame.cpp
 WebProcess/WebPage/WebInspector.cpp
+WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp
 WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp
 WebProcess/WebPage/WebInspectorUI.cpp
 WebProcess/WebPage/WebOpenPanelResultListener.cpp
@@ -679,6 +680,7 @@
 WebProcess/WebPage/RemoteWebInspectorUI.messages.in
 WebProcess/WebPage/VisitedLinkTableController.messages.in
 WebProcess/WebPage/WebInspector.messages.in
+

[webkit-changes] [213337] trunk/LayoutTests

[commit-queue]

Title: [213337] trunk/LayoutTests








Revision 213337
Author commit-qu...@webkit.org
Date 2017-03-02 18:05:32 -0800 (Thu, 02 Mar 2017)


Log Message
LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=167263


Patch by Antoine Quint  on 2017-03-02
Reviewed by Myles C. Maxfield.

Since timing is hard to test accurately, simplify the test to only check that we're transitioning
from one state to another and use the asynchronous, polling-based assertions to check that we will
be transitioning between those two states (visible and faded).

* media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt:
* media/modern-media-controls/media-controller/media-controller-auto-hide.html:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (213336 => 213337)

--- trunk/LayoutTests/ChangeLog	2017-03-03 01:55:26 UTC (rev 213336)
+++ trunk/LayoutTests/ChangeLog	2017-03-03 02:05:32 UTC (rev 213337)
@@ -1,3 +1,19 @@
+2017-03-02  Antoine Quint  
+
+LayoutTest media/modern-media-controls/media-controller/media-controller-auto-hide.html is flaky
+https://bugs.webkit.org/show_bug.cgi?id=167263
+
+
+Reviewed by Myles C. Maxfield.
+
+Since timing is hard to test accurately, simplify the test to only check that we're transitioning
+from one state to another and use the asynchronous, polling-based assertions to check that we will
+be transitioning between those two states (visible and faded).
+
+* media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt:
+* media/modern-media-controls/media-controller/media-controller-auto-hide.html:
+* platform/mac/TestExpectations:
+
 2017-03-02  Carlos Alberto Lopez Perez  
 
 [GTK] Update expectation for WebRTC tests.


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt (213336 => 213337)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt	2017-03-03 01:55:26 UTC (rev 213336)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide-expected.txt	2017-03-03 02:05:32 UTC (rev 213337)
@@ -3,15 +3,10 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-Video started playing, controls bar is visible by default.
-PASS controlsBar.classList.contains('faded') is false
+PASS !!shadowRoot.querySelector('.controls-bar') became true
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became false
+PASS shadowRoot.querySelector('.controls-bar').classList.contains('faded') became true
 
-Auto-hide timer has been going for 200ms, controls bar should still be visible.
-PASS controlsBar.classList.contains('faded') is false
-
-Auto-hide timer has elapsed, controls bar should be faded.
-PASS controlsBar.classList.contains('faded') is true
-
 PASS successfullyParsed is true
 
 TEST COMPLETE


Modified: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html (213336 => 213337)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html	2017-03-03 01:55:26 UTC (rev 213336)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-auto-hide.html	2017-03-03 02:05:32 UTC (rev 213337)
@@ -1,7 +1,7 @@
 
  
-
+