date:20170807

[webkit-changes] [220388] trunk/Source/WebDriver

2017-08-07 Thread carlosgc

Title: [220388] trunk/Source/WebDriver








Revision 220388
Author carlo...@webkit.org
Date 2017-08-07 23:43:25 -0700 (Mon, 07 Aug 2017)


Log Message
WebDriver: implement unhandled prompt behavior
https://bugs.webkit.org/show_bug.cgi?id=175184

Reviewed by Brian Burg.

Handle user prompts before running some of the commands according to the specification.

* Capabilities.h: Add UnhandledPromptBehavior capability.
* CommandResult.cpp:
(WebDriver::CommandResult::httpStatusCode const): Add UnexpectedAlertOpen error.
(WebDriver::CommandResult::errorString const): Ditto.
* CommandResult.h:
(WebDriver::CommandResult::setAdditonalErrorData): New method to set an additional data object that will be sent
as part of the result error message.
(WebDriver::CommandResult::additionalErrorData const): Return the additional data object.
* Session.cpp:
(WebDriver::Session::handleUserPrompts): Check if there's an active _javascript_ dialog and deal with it depeding
on the unhandled prompt behavior.
(WebDriver::Session::reportUnexpectedAlertOpen): Generate an error message with UnexpectedAlertOpen error and
including the alert text as additional error data.
(WebDriver::Session::go): Handle user prompts before running the command.
(WebDriver::Session::getCurrentURL): Ditto.
(WebDriver::Session::back): Ditto.
(WebDriver::Session::forward): Ditto.
(WebDriver::Session::refresh): Ditto.
(WebDriver::Session::getTitle): Ditto.
(WebDriver::Session::closeWindow): Ditto.
(WebDriver::Session::switchToFrame): Ditto.
(WebDriver::Session::switchToParentFrame): Ditto.
(WebDriver::Session::isElementSelected): Ditto.
(WebDriver::Session::getElementText): Ditto.
(WebDriver::Session::getElementTagName): Ditto.
(WebDriver::Session::getElementRect): Ditto.
(WebDriver::Session::isElementEnabled): Ditto.
(WebDriver::Session::isElementDisplayed): Ditto.
(WebDriver::Session::getElementAttribute): Ditto.
(WebDriver::Session::elementSendKeys): Ditto.
(WebDriver::Session::elementSubmit): Ditto.
(WebDriver::Session::executeScript): Ditto.
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::sendResponse const): Send data object as part of the result error message if present.
(WebDriver::deserializeUnhandledPromptBehavior):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::newSession):

Modified Paths

trunk/Source/WebDriver/Capabilities.h
trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/CommandResult.cpp
trunk/Source/WebDriver/CommandResult.h
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebDriver/Session.h
trunk/Source/WebDriver/WebDriverService.cpp




Diff

Modified: trunk/Source/WebDriver/Capabilities.h (220387 => 220388)

--- trunk/Source/WebDriver/Capabilities.h	2017-08-08 06:25:23 UTC (rev 220387)
+++ trunk/Source/WebDriver/Capabilities.h	2017-08-08 06:43:25 UTC (rev 220388)
@@ -44,6 +44,12 @@
 Eager
 };
 
+enum class UnhandledPromptBehavior {
+Dismiss,
+Accept,
+Ignore
+};
+
 struct Capabilities {
 std::optional browserName;
 std::optional browserVersion;
@@ -51,6 +57,7 @@
 std::optional acceptInsecureCerts;
 std::optional timeouts;
 std::optional pageLoadStrategy;
+std::optional unhandledPromptBehavior;
 #if PLATFORM(GTK)
 std::optional browserBinary;
 std::optional> browserArguments;


Modified: trunk/Source/WebDriver/ChangeLog (220387 => 220388)

--- trunk/Source/WebDriver/ChangeLog	2017-08-08 06:25:23 UTC (rev 220387)
+++ trunk/Source/WebDriver/ChangeLog	2017-08-08 06:43:25 UTC (rev 220388)
@@ -1,5 +1,54 @@
 2017-08-07  Carlos Garcia Campos  
 
+WebDriver: implement unhandled prompt behavior
+https://bugs.webkit.org/show_bug.cgi?id=175184
+
+Reviewed by Brian Burg.
+
+Handle user prompts before running some of the commands according to the specification.
+
+* Capabilities.h: Add UnhandledPromptBehavior capability.
+* CommandResult.cpp:
+(WebDriver::CommandResult::httpStatusCode const): Add UnexpectedAlertOpen error.
+(WebDriver::CommandResult::errorString const): Ditto.
+* CommandResult.h:
+(WebDriver::CommandResult::setAdditonalErrorData): New method to set an additional data object that will be sent
+as part of the result error message.
+(WebDriver::CommandResult::additionalErrorData const): Return the additional data object.
+* Session.cpp:
+(WebDriver::Session::handleUserPrompts): Check if there's an active _javascript_ dialog and deal with it depeding
+on the unhandled prompt behavior.
+(WebDriver::Session::reportUnexpectedAlertOpen): Generate an error message with UnexpectedAlertOpen error and
+including the alert text as additional error data.
+(WebDriver::Session::go): Handle user prompts before running the command.
+(WebDriver::Session::getCurrentURL): Ditto.
+(WebDriver::Session::back): Ditto.
+(WebD

[webkit-changes] [220387] trunk/Source

2017-08-07 Thread carlosgc

Title: [220387] trunk/Source








Revision 220387
Author carlo...@webkit.org
Date 2017-08-07 23:25:23 -0700 (Mon, 07 Aug 2017)


Log Message
[GTK] Implement _javascript_ dialog methods of API::AutomationSessionClient
https://bugs.webkit.org/show_bug.cgi?id=175259

Reviewed by Michael Catanzaro.

Source/WebCore/platform/gtk/po:

* POTFILES.in: Add WebKitScriptDialogGtk.cpp.

Source/WebKit:

Move the default implementation of WebKitScriptDialog from WebKitWebView platform specific files to their own
files. Implement all _javascript_ dialog methods of API::AutomationSessionClient in WebKitAutomationSession. For
now it only works when the user doesn't override WebKitWebView::script-dialog signal and default implementation
is used.

* PlatformGTK.cmake: Add new files to compilation.
* PlatformWPE.cmake: Ditto.
* UIProcess/API/glib/WebKitAutomationSession.cpp:
(webkitAutomationSessionCreate): Pass the WebKitWebContext to the constructor and keep a pointer to it in session.
* UIProcess/API/glib/WebKitAutomationSessionPrivate.h:
* UIProcess/API/glib/WebKitScriptDialogPrivate.h:
* UIProcess/API/glib/WebKitWebContext.cpp:
* UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewRunJavaScriptAlert): Set the currently script dialog for the scope of the function.
(webkitWebViewRunJavaScriptConfirm): Ditto.
(webkitWebViewRunJavaScriptPrompt): Ditto.
(webkitWebViewRunJavaScriptBeforeUnloadConfirm): Ditto.
(webkitWebViewIsShowingScriptDialog): Ask current dialog if there's one.
(webkitWebViewGetCurrentScriptDialogMessage): Ditto.
(webkitWebViewSetCurrentScriptDialogUserInput): Ditto.
(webkitWebViewAcceptCurrentScriptDialog): Ditto.
(webkitWebViewDismissCurrentScriptDialog): Ditto.
* UIProcess/API/glib/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/WebKitScriptDialogGtk.cpp: Added.
(webkitWebViewCreateJavaScriptDialog): Moved from WebKitWebViewGtk.cpp.
(webkitScriptDialogRun): Run the dialog, this code is moved from WebKitWebViewGtk.cpp.
(webkitScriptDialogIsRunning): Return true if the script dialog has a native dialog running.
(webkitScriptDialogAccept): Send Ok or Close response to the native dialog depending on the dialog type.
(webkitScriptDialogDismiss): Send Close response to the native dialog.
(webkitScriptDialogSetUserInput): Set the given text on the prompt dialog entry.
* UIProcess/API/gtk/WebKitWebViewGtk.cpp:
(webkitWebViewScriptDialog): Simply call webkitScriptDialogRun() now.
* UIProcess/API/wpe/WebKitScriptDialogWPE.cpp: Copied from Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h.
(webkitScriptDialogRun):
(webkitScriptDialogIsRunning):
(webkitScriptDialogAccept):
(webkitScriptDialogDismiss):
(webkitScriptDialogSetUserInput):

Modified Paths

trunk/Source/WebCore/platform/gtk/po/ChangeLog
trunk/Source/WebCore/platform/gtk/po/POTFILES.in
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Source/WebKit/UIProcess/API/glib/WebKitAutomationSession.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h
trunk/Source/WebKit/UIProcess/API/glib/WebKitScriptDialogPrivate.h
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
trunk/Source/WebKit/UIProcess/API/glib/WebKitWebViewPrivate.h
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp


Added Paths

trunk/Source/WebKit/UIProcess/API/gtk/WebKitScriptDialogGtk.cpp
trunk/Source/WebKit/UIProcess/API/wpe/WebKitScriptDialogWPE.cpp




Diff

Modified: trunk/Source/WebCore/platform/gtk/po/ChangeLog (220386 => 220387)

--- trunk/Source/WebCore/platform/gtk/po/ChangeLog	2017-08-08 06:22:02 UTC (rev 220386)
+++ trunk/Source/WebCore/platform/gtk/po/ChangeLog	2017-08-08 06:25:23 UTC (rev 220387)
@@ -1,3 +1,12 @@
+2017-08-07  Carlos Garcia Campos  
+
+[GTK] Implement _javascript_ dialog methods of API::AutomationSessionClient
+https://bugs.webkit.org/show_bug.cgi?id=175259
+
+Reviewed by Michael Catanzaro.
+
+* POTFILES.in: Add WebKitScriptDialogGtk.cpp.
+
 2017-07-13  Matthew Hanson  
 
 Fix the cMake builds (GTK and WPE.)


Modified: trunk/Source/WebCore/platform/gtk/po/POTFILES.in (220386 => 220387)

--- trunk/Source/WebCore/platform/gtk/po/POTFILES.in	2017-08-08 06:22:02 UTC (rev 220386)
+++ trunk/Source/WebCore/platform/gtk/po/POTFILES.in	2017-08-08 06:25:23 UTC (rev 220387)
@@ -30,6 +30,7 @@
 ../../../WebKit/UIProcess/API/gtk/WebKitColorChooserRequest.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitPrintCustomWidget.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitPrintOperation.cpp
+../../../WebKit/UIProcess/API/gtk/WebKitScriptDialogGtk.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitWebInspector.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
 ../../../WebKit/UIProcess/API/gtk/WebKitWebViewGtk.cpp


Modified: trunk/Source/WebKit/ChangeLog (220386 => 220387)

--- trunk/Source/WebKit/ChangeLog	2017-08-08 06:22:02 UTC (rev 220386)
+++ trunk/Source/WebKit/ChangeLog	201

[webkit-changes] [220386] trunk/Source/WebDriver

2017-08-07 Thread carlosgc

Title: [220386] trunk/Source/WebDriver








Revision 220386
Author carlo...@webkit.org
Date 2017-08-07 23:22:02 -0700 (Mon, 07 Aug 2017)


Log Message
WebDriver: implement user prompt commands
https://bugs.webkit.org/show_bug.cgi?id=174614

Reviewed by Brian Burg.

* CommandResult.cpp:
(WebDriver::CommandResult::CommandResult): Handle NoJavaScriptDialog protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add NoSuchAlert.
(WebDriver::CommandResult::errorString const): Ditto.
* CommandResult.h:
* Session.cpp:
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
* Session.h:
* WebDriverService.cpp:
(WebDriver::WebDriverService::dismissAlert):
(WebDriver::WebDriverService::acceptAlert):
(WebDriver::WebDriverService::getAlertText):
(WebDriver::WebDriverService::sendAlertText):
* WebDriverService.h:

Modified Paths

trunk/Source/WebDriver/ChangeLog
trunk/Source/WebDriver/CommandResult.cpp
trunk/Source/WebDriver/CommandResult.h
trunk/Source/WebDriver/Session.cpp
trunk/Source/WebDriver/Session.h
trunk/Source/WebDriver/WebDriverService.cpp
trunk/Source/WebDriver/WebDriverService.h




Diff

Modified: trunk/Source/WebDriver/ChangeLog (220385 => 220386)

--- trunk/Source/WebDriver/ChangeLog	2017-08-08 05:48:26 UTC (rev 220385)
+++ trunk/Source/WebDriver/ChangeLog	2017-08-08 06:22:02 UTC (rev 220386)
@@ -1,3 +1,28 @@
+2017-08-07  Carlos Garcia Campos  
+
+WebDriver: implement user prompt commands
+https://bugs.webkit.org/show_bug.cgi?id=174614
+
+Reviewed by Brian Burg.
+
+* CommandResult.cpp:
+(WebDriver::CommandResult::CommandResult): Handle NoJavaScriptDialog protocol error.
+(WebDriver::CommandResult::httpStatusCode const): Add NoSuchAlert.
+(WebDriver::CommandResult::errorString const): Ditto.
+* CommandResult.h:
+* Session.cpp:
+(WebDriver::Session::dismissAlert):
+(WebDriver::Session::acceptAlert):
+(WebDriver::Session::getAlertText):
+(WebDriver::Session::sendAlertText):
+* Session.h:
+* WebDriverService.cpp:
+(WebDriver::WebDriverService::dismissAlert):
+(WebDriver::WebDriverService::acceptAlert):
+(WebDriver::WebDriverService::getAlertText):
+(WebDriver::WebDriverService::sendAlertText):
+* WebDriverService.h:
+
 2017-08-05  Carlos Garcia Campos  
 
 [GTK][WPE] Add API to provide browser information required by automation


Modified: trunk/Source/WebDriver/CommandResult.cpp (220385 => 220386)

--- trunk/Source/WebDriver/CommandResult.cpp	2017-08-08 05:48:26 UTC (rev 220385)
+++ trunk/Source/WebDriver/CommandResult.cpp	2017-08-08 06:22:02 UTC (rev 220386)
@@ -102,6 +102,8 @@
 m_errorCode = ErrorCode::InvalidSelector;
 else if (errorName == "Timeout")
 m_errorCode = ErrorCode::Timeout;
+else if (errorName == "NoJavaScriptDialog")
+m_errorCode = ErrorCode::NoSuchAlert;
 
 break;
 }
@@ -127,6 +129,7 @@
 case ErrorCode::InvalidArgument:
 case ErrorCode::InvalidElementState:
 case ErrorCode::InvalidSelector:
+case ErrorCode::NoSuchAlert:
 case ErrorCode::NoSuchElement:
 case ErrorCode::NoSuchFrame:
 case ErrorCode::NoSuchWindow:
@@ -168,6 +171,8 @@
 return ASCIILiteral("invalid session id");
 case ErrorCode::_javascript_Error:
 return ASCIILiteral("_javascript_ error");
+case ErrorCode::NoSuchAlert:
+return ASCIILiteral("no such alert");
 case ErrorCode::NoSuchElement:
 return ASCIILiteral("no such element");
 case ErrorCode::NoSuchFrame:


Modified: trunk/Source/WebDriver/CommandResult.h (220385 => 220386)

--- trunk/Source/WebDriver/CommandResult.h	2017-08-08 05:48:26 UTC (rev 220385)
+++ trunk/Source/WebDriver/CommandResult.h	2017-08-08 06:22:02 UTC (rev 220386)
@@ -46,6 +46,7 @@
 InvalidSelector,
 InvalidSessionID,
 _javascript_Error,
+NoSuchAlert,
 NoSuchElement,
 NoSuchFrame,
 NoSuchWindow,


Modified: trunk/Source/WebDriver/Session.cpp (220385 => 220386)

--- trunk/Source/WebDriver/Session.cpp	2017-08-08 05:48:26 UTC (rev 220385)
+++ trunk/Source/WebDriver/Session.cpp	2017-08-08 06:22:02 UTC (rev 220386)
@@ -1463,4 +1463,82 @@
 });
 }
 
+void Session::dismissAlert(Function&& completionHandler)
+{
+if (!m_toplevelBrowsingContext) {
+completionHandler(CommandResult::fail(CommandResult::ErrorCode::NoSuchWindow));
+return;
+}
+
+RefPtr parameters = InspectorObject::create();
+parameters->setString(ASCIILiteral("browsingContextHandle"), m_toplevelBrowsingContext.value());
+m_host->sendCommandToBackend(ASCIILiteral("dismissCurrentJavaScriptDialog"), WTFMove(parameters), [this, protectedThis = makeRef(*this), completionHandler = WTFMove(completionHandler)](SessionHost::CommandResponse&& response) {
+if (

[webkit-changes] [220385] branches/safari-604.1.38.1-branch/Source/WebCore

2017-08-07 Thread jmarcell

Title: [220385] branches/safari-604.1.38.1-branch/Source/WebCore








Revision 220385
Author jmarc...@apple.com
Date 2017-08-07 22:48:26 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220333. rdar://problem/33601173

Modified Paths

branches/safari-604.1.38.1-branch/Source/WebCore/ChangeLog
branches/safari-604.1.38.1-branch/Source/WebCore/rendering/RenderView.cpp




Diff

Modified: branches/safari-604.1.38.1-branch/Source/WebCore/ChangeLog (220384 => 220385)

--- branches/safari-604.1.38.1-branch/Source/WebCore/ChangeLog	2017-08-08 03:20:19 UTC (rev 220384)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/ChangeLog	2017-08-08 05:48:26 UTC (rev 220385)
@@ -1,5 +1,29 @@
 2017-08-07  Jason Marcell  
 
+Cherry-pick r220333. rdar://problem/33601173
+
+2017-08-07  Antti Koivisto  
+
+REGRESSION (r219121): Airmail 3 prints header part only.
+https://bugs.webkit.org/show_bug.cgi?id=175258
+
+
+Reviewed by Andreas Kling.
+
+When a WK1 WebViw is printed via AppKit view hierarchy it won't explictly set the page width
+but uses the existing width. r219121 assumes that all printing code paths set the page width.
+
+No test, there appears to be no good way to test AppKit printing behaviors without adding complicated
+new testing infrastructure.
+
+* rendering/RenderView.cpp:
+(WebCore::RenderView::layout):
+
+If we are in printing layout and don't have page width set yet then use the current view width.
+This matches the behavior prior r219121.
+
+2017-08-07  Jason Marcell  
+
 Cherry-pick r220248. rdar://problem/33754446
 
 2017-08-03  Jeremy Jones  


Modified: branches/safari-604.1.38.1-branch/Source/WebCore/rendering/RenderView.cpp (220384 => 220385)

--- branches/safari-604.1.38.1-branch/Source/WebCore/rendering/RenderView.cpp	2017-08-08 03:20:19 UTC (rev 220384)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/rendering/RenderView.cpp	2017-08-08 05:48:26 UTC (rev 220385)
@@ -341,7 +341,8 @@
 m_pageLogicalSize = { };
 
 if (shouldUsePrintingLayout()) {
-ASSERT(m_pageLogicalSize);
+if (!m_pageLogicalSize)
+m_pageLogicalSize = LayoutSize(logicalWidth(), 0);
 m_minPreferredLogicalWidth = m_pageLogicalSize->width();
 m_maxPreferredLogicalWidth = m_minPreferredLogicalWidth;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220384] trunk/PerformanceTests

2017-08-07 Thread msaboff

Title: [220384] trunk/PerformanceTests








Revision 220384
Author msab...@apple.com
Date 2017-08-07 20:20:19 -0700 (Mon, 07 Aug 2017)


Log Message
Use more accurate Russian keywords for RexBench/FlightPlanner Unicode mode
https://bugs.webkit.org/show_bug.cgi?id=175298

Reviewed by Saam Barati.

With the help of Alexey Proskuryakov updated the Russian keywords.

* RexBench/FlightPlanner/use_unicode.js:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/RexBench/FlightPlanner/use_unicode.js




Diff

Modified: trunk/PerformanceTests/ChangeLog (220383 => 220384)

--- trunk/PerformanceTests/ChangeLog	2017-08-08 02:52:10 UTC (rev 220383)
+++ trunk/PerformanceTests/ChangeLog	2017-08-08 03:20:19 UTC (rev 220384)
@@ -1,3 +1,14 @@
+2017-08-07  Michael Saboff  
+
+Use more accurate Russian keywords for RexBench/FlightPlanner Unicode mode
+https://bugs.webkit.org/show_bug.cgi?id=175298
+
+Reviewed by Saam Barati.
+
+With the help of Alexey Proskuryakov updated the Russian keywords.
+
+* RexBench/FlightPlanner/use_unicode.js:
+
 2017-08-07  Mathias Bynens  
 
 Speedometer: Update to modern production Ember version


Modified: trunk/PerformanceTests/RexBench/FlightPlanner/use_unicode.js (220383 => 220384)

--- trunk/PerformanceTests/RexBench/FlightPlanner/use_unicode.js	2017-08-08 02:52:10 UTC (rev 220383)
+++ trunk/PerformanceTests/RexBench/FlightPlanner/use_unicode.js	2017-08-08 03:20:19 UTC (rev 220384)
@@ -60,11 +60,11 @@
 UnicodeStrings.table = {
 "START": "\u{041d}\u{0410}\u{0427}\u{0410}\u{0422}\u{042c}", // НАЧАТЬ
 "TIMING": "\u{0425}\u{0420}\u{041e}\u{041d}\u{041e}\u{041c}\u{0415}\u{0422}\u{0420}\u{0410}\u{0416}", // ХРОНОМЕТРАЖ
-"TAXI": "\u{0422}\u{0410}\u{041a}\u{0421}\u{0418}", // ТАКСИ
-"RUNUP": "\u{0412}\u{0417}\u{0411}\u{0415}\u{0416}\u{0410}\u{0422}\u{042c}", // ВЗБЕЖАТЬ
-"TAKEOFF": "\u{0412}\u{0417}\u{041b}\u{0415}\u{0422}\u{0415}\u{0422}\u{042c}", // ВЗЛЕТЕТЬ
-"CLIMB": "\u{0412}\u{041e}\u{0417}\u{041d}\u{0415}\u{0421}\u{0422}\u{0418}\u{0421}\u{042c}", // ВОЗНЕСТИСЬ
-"PATTERN": "\u{041f}\u{0410}\u{0422}\u{0422}\u{0415}\u{0420}\u{041d}", // ПАТТЕРН
+"TAXI": "\u{0420}\u{0423}\u{041b}\u{0415}\u{041d}\u{0418}\u{0415}", // РУЛЕНИЕ
+"RUNUP": "\u{0414}\u{0412}\u{0418}\u{0413}\u{0410}\u{0422}\u{0415}\u{041b}\u{042c}-\u{041d}\u{0410}\u{041a}\u{0410}\u{0422}\u{0410}", // ДВИГАТЕЛЬ НАКАТА
+"TAKEOFF": "\u{0412}\u{0417}\u{041b}\u{0415}\u{0422}", // ВЗЛЕТ
+"CLIMB": "\u{041f}\u{041e}\u{0414}\u{041d}\u{042f}\u{0422}\u{042c}\u{0421}\u{042f}", // ПОДНЯТЬСЯ
+"PATTERN": "\u{041a}\u{0420}\u{0423}\u{0413}", // КРУГ
 "LEFT": "\u{041b}\u{0415}\u{0412}\u{042b}\u{0419}", // ЛЕВЫЙ
 "RIGHT": "\u{041f}\u{0420}\u{0410}\u{0412}\u{042b}\u{0419}" // ПРАВЫЙ
 };






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220381] trunk/Source/WebCore

2017-08-07 Thread simon . fraser

Title: [220381] trunk/Source/WebCore








Revision 220381
Author simon.fra...@apple.com
Date 2017-08-07 19:52:06 -0700 (Mon, 07 Aug 2017)


Log Message
Re-order the tests in RenderLayerCompositor::requiresCompositingLayer() for performance
https://bugs.webkit.org/show_bug.cgi?id=175306

Reviewed by Tim Horton.

Re-order the tests for compositing reasons so that reasons more likely to happen are higher in the list.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (220380 => 220381)

--- trunk/Source/WebCore/ChangeLog	2017-08-08 02:52:05 UTC (rev 220380)
+++ trunk/Source/WebCore/ChangeLog	2017-08-08 02:52:06 UTC (rev 220381)
@@ -1,5 +1,18 @@
 2017-08-07  Simon Fraser  
 
+Re-order the tests in RenderLayerCompositor::requiresCompositingLayer() for performance
+https://bugs.webkit.org/show_bug.cgi?id=175306
+
+Reviewed by Tim Horton.
+
+Re-order the tests for compositing reasons so that reasons more likely to happen are higher in the list.
+
+* rendering/RenderLayerCompositor.cpp:
+(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
+(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):
+
+2017-08-07  Simon Fraser  
+
 Avoid a hash lookup in FilterInfo::remove()
 https://bugs.webkit.org/show_bug.cgi?id=175301
 


Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (220380 => 220381)

--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2017-08-08 02:52:05 UTC (rev 220380)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2017-08-08 02:52:06 UTC (rev 220381)
@@ -2173,16 +2173,16 @@
 
 // The root layer always has a compositing layer, but it may not have backing.
 return requiresCompositingForTransform(renderer)
-|| requiresCompositingForVideo(renderer)
+|| requiresCompositingForAnimation(renderer)
+|| clipsCompositingDescendants(*renderer.layer())
+|| requiresCompositingForPosition(renderer, *renderer.layer(), viewportConstrainedNotCompositedReason)
 || requiresCompositingForCanvas(renderer)
-|| requiresCompositingForPlugin(renderer)
-|| requiresCompositingForFrame(renderer)
-|| requiresCompositingForBackfaceVisibility(renderer)
-|| clipsCompositingDescendants(*renderer.layer())
-|| requiresCompositingForAnimation(renderer)
 || requiresCompositingForFilters(renderer)
 || requiresCompositingForWillChange(renderer)
-|| requiresCompositingForPosition(renderer, *renderer.layer(), viewportConstrainedNotCompositedReason)
+|| requiresCompositingForBackfaceVisibility(renderer)
+|| requiresCompositingForVideo(renderer)
+|| requiresCompositingForFrame(renderer)
+|| requiresCompositingForPlugin(renderer)
 #if PLATFORM(IOS)
 || requiresCompositingForScrolling(*renderer.layer())
 #endif
@@ -2217,15 +2217,15 @@
 
 if (layer.isRootLayer()
 || layer.transform() // note: excludes perspective and transformStyle3D.
-|| requiresCompositingForVideo(renderer)
+|| requiresCompositingForAnimation(renderer)
+|| requiresCompositingForPosition(renderer, layer)
 || requiresCompositingForCanvas(renderer)
-|| requiresCompositingForPlugin(renderer)
-|| requiresCompositingForFrame(renderer)
-|| requiresCompositingForBackfaceVisibility(renderer)
-|| requiresCompositingForAnimation(renderer)
 || requiresCompositingForFilters(renderer)
 || requiresCompositingForWillChange(renderer)
-|| requiresCompositingForPosition(renderer, layer)
+|| requiresCompositingForBackfaceVisibility(renderer)
+|| requiresCompositingForVideo(renderer)
+|| requiresCompositingForFrame(renderer)
+|| requiresCompositingForPlugin(renderer)
 || requiresCompositingForOverflowScrolling(layer)
 || renderer.isTransparent()
 || renderer.hasMask()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220382] trunk/Source/WebCore

2017-08-07 Thread simon . fraser

Title: [220382] trunk/Source/WebCore








Revision 220382
Author simon.fra...@apple.com
Date 2017-08-07 19:52:08 -0700 (Mon, 07 Aug 2017)


Log Message
Add a fast path for rotate() and rotateZ() transform parsing
https://bugs.webkit.org/show_bug.cgi?id=175308

Reviewed by Zalan Bujtas.

Fast paths only existed for translate-related functions, matrix3d() and scale3d(). Add
rotate() and rotateX(), which gives a small boost to one of the MotionMark tests.

* css/parser/CSSParserFastPaths.cpp:
(WebCore::parseSimpleAngle):
(WebCore::parseTransformAngleArgument):
(WebCore::parseSimpleTransformValue):
(WebCore::transformCanLikelyUseFastPath):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (220381 => 220382)

--- trunk/Source/WebCore/ChangeLog	2017-08-08 02:52:06 UTC (rev 220381)
+++ trunk/Source/WebCore/ChangeLog	2017-08-08 02:52:08 UTC (rev 220382)
@@ -1,5 +1,21 @@
 2017-08-07  Simon Fraser  
 
+Add a fast path for rotate() and rotateZ() transform parsing
+https://bugs.webkit.org/show_bug.cgi?id=175308
+
+Reviewed by Zalan Bujtas.
+
+Fast paths only existed for translate-related functions, matrix3d() and scale3d(). Add
+rotate() and rotateX(), which gives a small boost to one of the MotionMark tests.
+
+* css/parser/CSSParserFastPaths.cpp:
+(WebCore::parseSimpleAngle):
+(WebCore::parseTransformAngleArgument):
+(WebCore::parseSimpleTransformValue):
+(WebCore::transformCanLikelyUseFastPath):
+
+2017-08-07  Simon Fraser  
+
 Re-order the tests in RenderLayerCompositor::requiresCompositingLayer() for performance
 https://bugs.webkit.org/show_bug.cgi?id=175306
 


Modified: trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp (220381 => 220382)

--- trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2017-08-08 02:52:06 UTC (rev 220381)
+++ trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp	2017-08-08 02:52:08 UTC (rev 220382)
@@ -115,6 +115,32 @@
 return true;
 }
 
+template 
+static inline bool parseSimpleAngle(const CharacterType* characters, unsigned length, CSSPrimitiveValue::UnitType& unit, double& number)
+{
+// Just support deg and rad for now.
+if (length < 4)
+return false;
+
+if ((characters[length - 3] | 0x20) == 'd' && (characters[length - 2] | 0x20) == 'e' && (characters[length - 1] | 0x20) == 'g') {
+length -= 3;
+unit = CSSPrimitiveValue::UnitType::CSS_DEG;
+} else if ((characters[length - 3] | 0x20) == 'r' && (characters[length - 2] | 0x20) == 'a' && (characters[length - 1] | 0x20) == 'd') {
+length -= 3;
+unit = CSSPrimitiveValue::UnitType::CSS_RAD;
+} else
+return false;
+
+// We rely on charactersToDouble for validation as well. The function
+// will set "ok" to "false" if the entire passed-in character range does
+// not represent a double.
+bool ok;
+number = charactersToDouble(characters, length, &ok);
+if (!ok)
+return false;
+return true;
+}
+
 static RefPtr parseSimpleLengthValue(CSSPropertyID propertyId, const String& string, CSSParserMode cssParserMode)
 {
 ASSERT(!string.isEmpty());
@@ -1050,6 +1076,27 @@
 }
 
 template 
+static bool parseTransformAngleArgument(CharType*& pos, CharType* end, CSSFunctionValue* transformValue)
+{
+size_t delimiter = WTF::find(pos, end - pos, ')');
+if (delimiter == notFound)
+return false;
+
+unsigned argumentLength = static_cast(delimiter);
+CSSPrimitiveValue::UnitType unit = CSSPrimitiveValue::UnitType::CSS_NUMBER;
+double number;
+if (!parseSimpleAngle(pos, argumentLength, unit, number))
+return false;
+if (!number && unit == CSSPrimitiveValue::CSS_NUMBER)
+unit = CSSPrimitiveValue::UnitType::CSS_DEG;
+
+transformValue->append(CSSPrimitiveValue::create(number, unit));
+pos += argumentLength + 1;
+
+return true;
+}
+
+template 
 static bool parseTransformNumberArguments(CharType*& pos, CharType* end, unsigned expectedCount, CSSFunctionValue* transformValue)
 {
 while (expectedCount) {
@@ -1105,9 +1152,9 @@
 transformType = CSSValueTranslate3d;
 expectedArgumentCount = 3;
 argumentStart = 12;
-} else {
+} else
 return nullptr;
-}
+
 pos += argumentStart;
 RefPtr transformValue = CSSFunctionValue::create(transformType);
 if (!parseTransformTranslateArguments(pos, end, expectedArgumentCount, transformValue.get()))
@@ -1150,6 +1197,32 @@
 return transformValue;
 }
 
+const bool isRotate = toASCIILower(pos[0]) == 'r'
+&& toASCIILower(pos[1]) == 'o'
+&& toASCIILower(pos[2]) == 't'
+&& toASCIILower(pos[3]) == 'a'
+&& toASCIILower(pos[4]) == 't'
+&& toASCIILower(pos[5]) == 'e';
+
+if (isRotate) {
+CSSValueID transf

[webkit-changes] [220380] trunk/Source/WebCore

2017-08-07 Thread simon . fraser

Title: [220380] trunk/Source/WebCore








Revision 220380
Author simon.fra...@apple.com
Date 2017-08-07 19:52:05 -0700 (Mon, 07 Aug 2017)


Log Message
Avoid a hash lookup in FilterInfo::remove()
https://bugs.webkit.org/show_bug.cgi?id=175301

Reviewed by Sam Weinig.

FilterInfo::remove() always called map().remove(&layer)), even when layer.m_hasFilterInfo
was false (and even asserted that layer.m_hasFilterInfo == map().contains(&layer)).

So we can early return if layer.m_hasFilterInfo is false.

* rendering/RenderLayerFilterInfo.cpp:
(WebCore::RenderLayer::FilterInfo::getIfExists):
(WebCore::RenderLayer::FilterInfo::remove):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (220379 => 220380)

--- trunk/Source/WebCore/ChangeLog	2017-08-08 02:46:11 UTC (rev 220379)
+++ trunk/Source/WebCore/ChangeLog	2017-08-08 02:52:05 UTC (rev 220380)
@@ -1,5 +1,21 @@
 2017-08-07  Simon Fraser  
 
+Avoid a hash lookup in FilterInfo::remove()
+https://bugs.webkit.org/show_bug.cgi?id=175301
+
+Reviewed by Sam Weinig.
+
+FilterInfo::remove() always called map().remove(&layer)), even when layer.m_hasFilterInfo
+was false (and even asserted that layer.m_hasFilterInfo == map().contains(&layer)).
+
+So we can early return if layer.m_hasFilterInfo is false.
+
+* rendering/RenderLayerFilterInfo.cpp:
+(WebCore::RenderLayer::FilterInfo::getIfExists):
+(WebCore::RenderLayer::FilterInfo::remove):
+
+2017-08-07  Simon Fraser  
+
 Make TransformOperation::type() non-virtual
 https://bugs.webkit.org/show_bug.cgi?id=175297
 


Modified: trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp (220379 => 220380)

--- trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp	2017-08-08 02:46:11 UTC (rev 220379)
+++ trunk/Source/WebCore/rendering/RenderLayerFilterInfo.cpp	2017-08-08 02:52:05 UTC (rev 220380)
@@ -49,7 +49,7 @@
 {
 ASSERT(layer.m_hasFilterInfo == map().contains(&layer));
 
-return layer.m_hasFilterInfo ? map().get(&layer) : 0;
+return layer.m_hasFilterInfo ? map().get(&layer) : nullptr;
 }
 
 RenderLayer::FilterInfo& RenderLayer::FilterInfo::get(RenderLayer& layer)
@@ -67,9 +67,11 @@
 void RenderLayer::FilterInfo::remove(RenderLayer& layer)
 {
 ASSERT(layer.m_hasFilterInfo == map().contains(&layer));
+if (!layer.m_hasFilterInfo)
+return;
 
-if (map().remove(&layer))
-layer.m_hasFilterInfo = false;
+map().remove(&layer);
+layer.m_hasFilterInfo = false;
 }
 
 RenderLayer::FilterInfo::FilterInfo(RenderLayer& layer)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220383] trunk/Source/WebCore

2017-08-07 Thread simon . fraser

Title: [220383] trunk/Source/WebCore








Revision 220383
Author simon.fra...@apple.com
Date 2017-08-07 19:52:10 -0700 (Mon, 07 Aug 2017)


Log Message
RenderStyle:diff() was inadvertently doing deep compares of StyleRareNonInheritedData etc
https://bugs.webkit.org/show_bug.cgi?id=175304

Reviewed by Tim Horton.

r210758 changed DataRef::get() from returning a pointer to a reference. This caused all the places
in RenderStyle::diff() and related functions, where we intended to do a quick pointer comparison,
to doing deep compares via operator!=. This made the code slightly slower.

Fix by exposing ptr() on DataRef and using it wherever we wish to do pointer comparison.

* rendering/style/DataRef.h:
(WebCore::DataRef::ptr const):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::inheritedDataShared const):
(WebCore::RenderStyle::changeAffectsVisualOverflow const):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::changeRequiresRecompositeLayer const):
(WebCore::RenderStyle::listStyleImage const): Expand the function onto multiple lines.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/style/DataRef.h
trunk/Source/WebCore/rendering/style/RenderStyle.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (220382 => 220383)

--- trunk/Source/WebCore/ChangeLog	2017-08-08 02:52:08 UTC (rev 220382)
+++ trunk/Source/WebCore/ChangeLog	2017-08-08 02:52:10 UTC (rev 220383)
@@ -1,5 +1,27 @@
 2017-08-07  Simon Fraser  
 
+RenderStyle:diff() was inadvertently doing deep compares of StyleRareNonInheritedData etc
+https://bugs.webkit.org/show_bug.cgi?id=175304
+
+Reviewed by Tim Horton.
+
+r210758 changed DataRef::get() from returning a pointer to a reference. This caused all the places
+in RenderStyle::diff() and related functions, where we intended to do a quick pointer comparison,
+to doing deep compares via operator!=. This made the code slightly slower.
+
+Fix by exposing ptr() on DataRef and using it wherever we wish to do pointer comparison.
+
+* rendering/style/DataRef.h:
+(WebCore::DataRef::ptr const):
+* rendering/style/RenderStyle.cpp:
+(WebCore::RenderStyle::inheritedDataShared const):
+(WebCore::RenderStyle::changeAffectsVisualOverflow const):
+(WebCore::RenderStyle::changeRequiresLayout const):
+(WebCore::RenderStyle::changeRequiresRecompositeLayer const):
+(WebCore::RenderStyle::listStyleImage const): Expand the function onto multiple lines.
+
+2017-08-07  Simon Fraser  
+
 Add a fast path for rotate() and rotateZ() transform parsing
 https://bugs.webkit.org/show_bug.cgi?id=175308
 


Modified: trunk/Source/WebCore/rendering/style/DataRef.h (220382 => 220383)

--- trunk/Source/WebCore/rendering/style/DataRef.h	2017-08-08 02:52:08 UTC (rev 220382)
+++ trunk/Source/WebCore/rendering/style/DataRef.h	2017-08-08 02:52:10 UTC (rev 220383)
@@ -55,6 +55,11 @@
 return m_data;
 }
 
+const T* ptr() const
+{
+return m_data.ptr();
+}
+
 const T& get() const
 {
 return m_data;


Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (220382 => 220383)

--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2017-08-08 02:52:08 UTC (rev 220382)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp	2017-08-08 02:52:10 UTC (rev 220383)
@@ -452,9 +452,9 @@
 {
 // This is a fast check that only looks if the data structures are shared.
 return m_inheritedFlags == other->m_inheritedFlags
-&& m_inheritedData.get() == other->m_inheritedData.get()
-&& m_svgStyle.get() == other->m_svgStyle.get()
-&& m_rareInheritedData.get() == other->m_rareInheritedData.get();
+&& m_inheritedData.ptr() == other->m_inheritedData.ptr()
+&& m_svgStyle.ptr() == other->m_svgStyle.ptr()
+&& m_rareInheritedData.ptr() == other->m_rareInheritedData.ptr();
 }
 
 static bool positionChangeIsMovementOnly(const LengthBox& a, const LengthBox& b, const Length& width)
@@ -486,11 +486,11 @@
 
 inline bool RenderStyle::changeAffectsVisualOverflow(const RenderStyle& other) const
 {
-if (m_rareNonInheritedData.get() != other.m_rareNonInheritedData.get()
+if (m_rareNonInheritedData.ptr() != other.m_rareNonInheritedData.ptr()
 && !arePointingToEqualData(m_rareNonInheritedData->boxShadow, other.m_rareNonInheritedData->boxShadow))
 return true;
 
-if (m_rareInheritedData.get() != other.m_rareInheritedData.get()
+if (m_rareInheritedData.ptr() != other.m_rareInheritedData.ptr()
 && !arePointingToEqualData(m_rareInheritedData->textShadow, other.m_rareInheritedData->textShadow))
 return true;
 
@@ -536,7 +536,7 @@
 if (changeAffectsVisualOverflow(other))
 return true;
 
-if (m_rareNonInheritedData.get() != other.m_rareNonInheritedData.get()) {
+if (m_rareNonInheritedData.ptr() != other.m_rareNonIn

[webkit-changes] [220378] trunk/Source/WebCore

2017-08-07 Thread simon . fraser

Title: [220378] trunk/Source/WebCore








Revision 220378
Author simon.fra...@apple.com
Date 2017-08-07 19:46:06 -0700 (Mon, 07 Aug 2017)


Log Message
Inline ~Color and Color::isExtended()
https://bugs.webkit.org/show_bug.cgi?id=175293

Reviewed by Zalan Bujtas.

The Color destructor and Color::isExtended() show up on profiles, so inline them.
Before r207265 the destructor was inlined.

Also make sure that LengthSize::operator== is inlined, which it was not (according
to profiles).

* platform/LengthSize.h:
(WebCore::operator==):
* platform/graphics/Color.cpp:
(WebCore::Color::~Color): Deleted.
(WebCore::Color::isExtended const): Deleted.
* platform/graphics/Color.h:
(WebCore::Color::~Color):
(WebCore::Color::isExtended const):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/LengthSize.h
trunk/Source/WebCore/platform/graphics/Color.cpp
trunk/Source/WebCore/platform/graphics/Color.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (220377 => 220378)

--- trunk/Source/WebCore/ChangeLog	2017-08-08 02:29:42 UTC (rev 220377)
+++ trunk/Source/WebCore/ChangeLog	2017-08-08 02:46:06 UTC (rev 220378)
@@ -1,3 +1,25 @@
+2017-08-07  Simon Fraser  
+
+Inline ~Color and Color::isExtended()
+https://bugs.webkit.org/show_bug.cgi?id=175293
+
+Reviewed by Zalan Bujtas.
+
+The Color destructor and Color::isExtended() show up on profiles, so inline them.
+Before r207265 the destructor was inlined.
+
+Also make sure that LengthSize::operator== is inlined, which it was not (according
+to profiles).
+
+* platform/LengthSize.h:
+(WebCore::operator==):
+* platform/graphics/Color.cpp:
+(WebCore::Color::~Color): Deleted.
+(WebCore::Color::isExtended const): Deleted.
+* platform/graphics/Color.h:
+(WebCore::Color::~Color):
+(WebCore::Color::isExtended const):
+
 2017-08-04  Brent Fulgham  
 
 Implement the HTML5 same-origin restriction specification


Modified: trunk/Source/WebCore/platform/LengthSize.h (220377 => 220378)

--- trunk/Source/WebCore/platform/LengthSize.h	2017-08-08 02:29:42 UTC (rev 220377)
+++ trunk/Source/WebCore/platform/LengthSize.h	2017-08-08 02:46:06 UTC (rev 220378)
@@ -28,7 +28,7 @@
 Length height;
 };
 
-inline bool operator==(const LengthSize& a, const LengthSize& b)
+ALWAYS_INLINE bool operator==(const LengthSize& a, const LengthSize& b)
 {
 return a.width == b.width && a.height == b.height;
 }


Modified: trunk/Source/WebCore/platform/graphics/Color.cpp (220377 => 220378)

--- trunk/Source/WebCore/platform/graphics/Color.cpp	2017-08-08 02:29:42 UTC (rev 220377)
+++ trunk/Source/WebCore/platform/graphics/Color.cpp	2017-08-08 02:46:06 UTC (rev 220378)
@@ -307,12 +307,6 @@
 ASSERT(isExtended());
 }
 
-Color::~Color()
-{
-if (isExtended())
-m_colorData.extendedColor->deref();
-}
-
 Color& Color::operator=(const Color& other)
 {
 if (*this == other)
@@ -665,11 +659,6 @@
 m_colorData.rgbaAndFlags |= validRGBAColor;
 }
 
-bool Color::isExtended() const
-{
-return !(m_colorData.rgbaAndFlags & invalidRGBAColor);
-}
-
 ExtendedColor& Color::asExtended() const
 {
 ASSERT(isExtended());


Modified: trunk/Source/WebCore/platform/graphics/Color.h (220377 => 220378)

--- trunk/Source/WebCore/platform/graphics/Color.h	2017-08-08 02:29:42 UTC (rev 220377)
+++ trunk/Source/WebCore/platform/graphics/Color.h	2017-08-08 02:46:06 UTC (rev 220378)
@@ -173,7 +173,11 @@
 WEBCORE_EXPORT Color(const Color&);
 WEBCORE_EXPORT Color(Color&&);
 
-WEBCORE_EXPORT ~Color();
+~Color()
+{
+if (isExtended())
+m_colorData.extendedColor->deref();
+}
 
 static Color createUnchecked(int r, int g, int b)
 {
@@ -274,7 +278,10 @@
 static const RGBA32 compositionFill = 0xFFE1DD55;
 #endif
 
-WEBCORE_EXPORT bool isExtended() const;
+bool isExtended() const
+{
+return !(m_colorData.rgbaAndFlags & invalidRGBAColor);
+}
 WEBCORE_EXPORT ExtendedColor& asExtended() const;
 
 WEBCORE_EXPORT Color& operator=(const Color&);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220379] trunk/Source/WebCore

2017-08-07 Thread simon . fraser

Title: [220379] trunk/Source/WebCore








Revision 220379
Author simon.fra...@apple.com
Date 2017-08-07 19:46:11 -0700 (Mon, 07 Aug 2017)


Log Message
Make TransformOperation::type() non-virtual
https://bugs.webkit.org/show_bug.cgi?id=175297

Reviewed by Sam Weinig.

Store the OperationType in the base class so that type() and isSameType() can
be non-virtual.

Small perf win on some benchmarks.

* platform/graphics/transforms/IdentityTransformOperation.h:
* platform/graphics/transforms/Matrix3DTransformOperation.h:
* platform/graphics/transforms/MatrixTransformOperation.h:
* platform/graphics/transforms/PerspectiveTransformOperation.h:
* platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::blend):
* platform/graphics/transforms/RotateTransformOperation.h:
* platform/graphics/transforms/ScaleTransformOperation.cpp:
(WebCore::ScaleTransformOperation::blend):
* platform/graphics/transforms/ScaleTransformOperation.h:
* platform/graphics/transforms/SkewTransformOperation.cpp:
(WebCore::SkewTransformOperation::blend):
* platform/graphics/transforms/SkewTransformOperation.h:
* platform/graphics/transforms/TransformOperation.h:
(WebCore::TransformOperation::TransformOperation):
(WebCore::TransformOperation::type const):
(WebCore::TransformOperation::isSameType const):
* platform/graphics/transforms/TranslateTransformOperation.cpp:
(WebCore::TranslateTransformOperation::blend):
* platform/graphics/transforms/TranslateTransformOperation.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/Matrix3DTransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/MatrixTransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/PerspectiveTransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.cpp
trunk/Source/WebCore/platform/graphics/transforms/RotateTransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp
trunk/Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/SkewTransformOperation.cpp
trunk/Source/WebCore/platform/graphics/transforms/SkewTransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/TransformOperation.h
trunk/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.cpp
trunk/Source/WebCore/platform/graphics/transforms/TranslateTransformOperation.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (220378 => 220379)

--- trunk/Source/WebCore/ChangeLog	2017-08-08 02:46:06 UTC (rev 220378)
+++ trunk/Source/WebCore/ChangeLog	2017-08-08 02:46:11 UTC (rev 220379)
@@ -1,5 +1,38 @@
 2017-08-07  Simon Fraser  
 
+Make TransformOperation::type() non-virtual
+https://bugs.webkit.org/show_bug.cgi?id=175297
+
+Reviewed by Sam Weinig.
+
+Store the OperationType in the base class so that type() and isSameType() can
+be non-virtual.
+
+Small perf win on some benchmarks.
+
+* platform/graphics/transforms/IdentityTransformOperation.h:
+* platform/graphics/transforms/Matrix3DTransformOperation.h:
+* platform/graphics/transforms/MatrixTransformOperation.h:
+* platform/graphics/transforms/PerspectiveTransformOperation.h:
+* platform/graphics/transforms/RotateTransformOperation.cpp:
+(WebCore::RotateTransformOperation::blend):
+* platform/graphics/transforms/RotateTransformOperation.h:
+* platform/graphics/transforms/ScaleTransformOperation.cpp:
+(WebCore::ScaleTransformOperation::blend):
+* platform/graphics/transforms/ScaleTransformOperation.h:
+* platform/graphics/transforms/SkewTransformOperation.cpp:
+(WebCore::SkewTransformOperation::blend):
+* platform/graphics/transforms/SkewTransformOperation.h:
+* platform/graphics/transforms/TransformOperation.h:
+(WebCore::TransformOperation::TransformOperation):
+(WebCore::TransformOperation::type const):
+(WebCore::TransformOperation::isSameType const):
+* platform/graphics/transforms/TranslateTransformOperation.cpp:
+(WebCore::TranslateTransformOperation::blend):
+* platform/graphics/transforms/TranslateTransformOperation.h:
+
+2017-08-07  Simon Fraser  
+
 Inline ~Color and Color::isExtended()
 https://bugs.webkit.org/show_bug.cgi?id=175293
 


Modified: trunk/Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h (220378 => 220379)

--- trunk/Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h	2017-08-08 02:46:06 UTC (rev 220378)
+++ trunk/Source/WebCore/platform/graphics/transforms/IdentityTransformOperation.h	2017-08-08 02:46:11 UTC (rev 220379)
@@ -2,7 +2,7 @@
  * Copyright (C) 2000 Lars Knoll (kn...@kde.org)
  *   (C) 2000 Antti Koivisto (k

[webkit-changes] [220377] trunk

2017-08-07 Thread commit-queue

Title: [220377] trunk








Revision 220377
Author commit-qu...@webkit.org
Date 2017-08-07 19:29:42 -0700 (Mon, 07 Aug 2017)


Log Message
GetOwnProperty of TypedArray indexed fields is wrongly configurable
https://bugs.webkit.org/show_bug.cgi?id=175307

Patch by Robin Morisset  on 2017-08-07
Reviewed by Saam Barati.

JSTests:

* stress/typedarray-getownproperty-not-configurable.js: Added.
(assert):
(foo):

Source/_javascript_Core:

```
let a = new Uint8Array(10);
let b = Object.getOwnPropertyDescriptor(a, 0);
assert(b.configurable === false);
```
should not fail: by section 9.4.5.1 (https://tc39.github.io/ecma262/#sec-integer-indexed-exotic-objects-getownproperty-p)
that applies to integer indexed exotic objects, and section 22.2.7 (https://tc39.github.io/ecma262/#sec-properties-of-typedarray-instances)
that says that typed arrays are integer indexed exotic objects.

* runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView::getOwnPropertySlotByIndex):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h


Added Paths

trunk/JSTests/stress/typedarray-getownproperty-not-configurable.js




Diff

Modified: trunk/JSTests/ChangeLog (220376 => 220377)

--- trunk/JSTests/ChangeLog	2017-08-08 02:28:25 UTC (rev 220376)
+++ trunk/JSTests/ChangeLog	2017-08-08 02:29:42 UTC (rev 220377)
@@ -1,3 +1,14 @@
+2017-08-07  Robin Morisset  
+
+GetOwnProperty of TypedArray indexed fields is wrongly configurable
+https://bugs.webkit.org/show_bug.cgi?id=175307
+
+Reviewed by Saam Barati.
+
+* stress/typedarray-getownproperty-not-configurable.js: Added.
+(assert):
+(foo):
+
 2017-08-06  Yusuke Suzuki  
 
 Promise resolve and reject function should have length = 1


Added: trunk/JSTests/stress/typedarray-getownproperty-not-configurable.js (0 => 220377)

--- trunk/JSTests/stress/typedarray-getownproperty-not-configurable.js	(rev 0)
+++ trunk/JSTests/stress/typedarray-getownproperty-not-configurable.js	2017-08-08 02:29:42 UTC (rev 220377)
@@ -0,0 +1,20 @@
+typedArrays = [Int8Array, Uint8Array, Uint8ClampedArray, Int16Array, Uint16Array, Int32Array, Uint32Array, Float32Array, Float64Array];
+
+function assert(cond) {
+if (!cond)
+throw new Error("bad assertion!");
+}
+
+function foo() {
+for (constructor of typedArrays) {
+let a = new constructor(10);
+let b = Object.getOwnPropertyDescriptor(a, 0);
+assert(b.value === 0);
+assert(b.writable === false);
+assert(b.enumerable === true);
+assert(b.configurable === false);
+}
+}
+
+for (let i = 0; i < 100; i++)
+foo();


Modified: trunk/Source/_javascript_Core/ChangeLog (220376 => 220377)

--- trunk/Source/_javascript_Core/ChangeLog	2017-08-08 02:28:25 UTC (rev 220376)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-08 02:29:42 UTC (rev 220377)
@@ -1,3 +1,22 @@
+2017-08-07  Robin Morisset  
+
+GetOwnProperty of TypedArray indexed fields is wrongly configurable
+https://bugs.webkit.org/show_bug.cgi?id=175307
+
+Reviewed by Saam Barati.
+
+```
+let a = new Uint8Array(10);
+let b = Object.getOwnPropertyDescriptor(a, 0);
+assert(b.configurable === false);
+```
+should not fail: by section 9.4.5.1 (https://tc39.github.io/ecma262/#sec-integer-indexed-exotic-objects-getownproperty-p) 
+that applies to integer indexed exotic objects, and section 22.2.7 (https://tc39.github.io/ecma262/#sec-properties-of-typedarray-instances)
+that says that typed arrays are integer indexed exotic objects.
+
+* runtime/JSGenericTypedArrayViewInlines.h:
+(JSC::JSGenericTypedArrayView::getOwnPropertySlotByIndex):
+
 2017-08-07  Filip Pizlo  
 
 Baseline JIT should do caging


Modified: trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h (220376 => 220377)

--- trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h	2017-08-08 02:28:25 UTC (rev 220376)
+++ trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewInlines.h	2017-08-08 02:29:42 UTC (rev 220377)
@@ -458,7 +458,7 @@
 if (!thisObject->canGetIndexQuickly(propertyName))
 return false;
 
-slot.setValue(thisObject, None, thisObject->getIndexQuickly(propertyName));
+slot.setValue(thisObject, DontDelete, thisObject->getIndexQuickly(propertyName));
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220376] trunk

2017-08-07 Thread bfulgham

Title: [220376] trunk








Revision 220376
Author bfulg...@apple.com
Date 2017-08-07 19:28:25 -0700 (Mon, 07 Aug 2017)


Log Message
Source/WebCore:
Implement the HTML5 same-origin restriction specification
https://bugs.webkit.org/show_bug.cgi?id=175226


Reviewed by Chris Dumez.

Follow the algorithms defined in the HTML5 specification for relaxing
the same-origin restriction. We were missing a few steps related to
checking for public suffix and presence of a browsing context.

Tested by new TestWebKitAPI tests.

* dom/Document.cpp:
(WebCore::Document::domainIsRegisterable): Added helper function.
(WebCore::Document::setDomain):

Tools:
Prevent domain from being set to a TLD
https://bugs.webkit.org/show_bug.cgi?id=175226


Reviewed by Chris Dumez.

Extend the public suffix tests to include cases used by the
Public Domain 'Public Suffix List'.

* TestWebKitAPI/Tests/mac/PublicSuffix.cpp: 
(TestWebKitAPI::TEST):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/dom/Document.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/mac/PublicSuffix.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (220375 => 220376)

--- trunk/Source/WebCore/ChangeLog	2017-08-08 01:05:06 UTC (rev 220375)
+++ trunk/Source/WebCore/ChangeLog	2017-08-08 02:28:25 UTC (rev 220376)
@@ -1,3 +1,21 @@
+2017-08-04  Brent Fulgham  
+
+Implement the HTML5 same-origin restriction specification
+https://bugs.webkit.org/show_bug.cgi?id=175226
+
+
+Reviewed by Chris Dumez.
+
+Follow the algorithms defined in the HTML5 specification for relaxing
+the same-origin restriction. We were missing a few steps related to
+checking for public suffix and presence of a browsing context.
+
+Tested by new TestWebKitAPI tests.
+
+* dom/Document.cpp:
+(WebCore::Document::domainIsRegisterable): Added helper function.
+(WebCore::Document::setDomain):
+
 2017-08-07  Devin Rousso  
 
 Web Inspector: Preview Canvas path when viewing a recording


Modified: trunk/Source/WebCore/dom/Document.cpp (220375 => 220376)

--- trunk/Source/WebCore/dom/Document.cpp	2017-08-08 01:05:06 UTC (rev 220375)
+++ trunk/Source/WebCore/dom/Document.cpp	2017-08-08 02:28:25 UTC (rev 220376)
@@ -140,6 +140,7 @@
 #include "PointerLockController.h"
 #include "PopStateEvent.h"
 #include "ProcessingInstruction.h"
+#include "PublicSuffix.h"
 #include "RealtimeMediaSourceCenter.h"
 #include "RenderChildIterator.h"
 #include "RenderLayerCompositor.h"
@@ -4438,45 +4439,64 @@
 return securityOrigin().domain();
 }
 
-ExceptionOr Document::setDomain(const String& newDomain)
+bool Document::domainIsRegisterable(const String& newDomain) const
 {
-if (SchemeRegistry::isDomainRelaxationForbiddenForURLScheme(securityOrigin().protocol()))
-return Exception { SecurityError };
+if (newDomain.isEmpty())
+return false;
 
-// Both NS and IE specify that changing the domain is only allowed when
-// the new domain is a suffix of the old domain.
+const String& effectiveDomain = domain();
 
-// FIXME: We should add logging indicating why a domain was not allowed.
-
-String oldDomain = domain();
-
-// If the new domain is the same as the old domain, still call
-// securityOrigin().setDomainForDOM. This will change the
+// If the new domain is the same as the old domain, return true so that
+// we still call securityOrigin().setDomainForDOM. This will change the
 // security check behavior. For example, if a page loaded on port 8000
 // assigns its current domain using document.domain, the page will
 // allow other pages loaded on different ports in the same domain that
 // have also assigned to access this page.
-if (equalIgnoringASCIICase(oldDomain, newDomain)) {
-securityOrigin().setDomainFromDOM(newDomain);
-return { };
-}
+if (equalIgnoringASCIICase(effectiveDomain, newDomain))
+return true;
 
 // e.g. newDomain = webkit.org (10) and domain() = www.webkit.org (14)
-unsigned oldLength = oldDomain.length();
+unsigned oldLength = effectiveDomain.length();
 unsigned newLength = newDomain.length();
 if (newLength >= oldLength)
-return Exception { SecurityError };
+return false;
 
 auto ipAddressSetting = settings().treatIPAddressAsDomain() ? OriginAccessEntry::TreatIPAddressAsDomain : OriginAccessEntry::TreatIPAddressAsIPAddress;
 OriginAccessEntry accessEntry { securityOrigin().protocol(), newDomain, OriginAccessEntry::AllowSubdomains, ipAddressSetting };
 if (!accessEntry.matchesOrigin(securityOrigin()))
-return Exception { SecurityError };
+return false;
 
-if (oldDomain[oldLength - newLength - 1] != '.')
+if (effectiveDomain[oldLength - newLength - 1] != '.')
+return false;
+if (StringView { effectiveDomain }.substring(oldLength - newLength) != newDomain)
+

[webkit-changes] [220375] trunk/LayoutTests

2017-08-07 Thread jlewis3

Title: [220375] trunk/LayoutTests








Revision 220375
Author jlew...@apple.com
Date 2017-08-07 18:05:06 -0700 (Mon, 07 Aug 2017)


Log Message
Marked media/modern-media-controls/fullscreen-support/fullscreen-support-press.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173946

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (220374 => 220375)

--- trunk/LayoutTests/ChangeLog	2017-08-08 00:53:47 UTC (rev 220374)
+++ trunk/LayoutTests/ChangeLog	2017-08-08 01:05:06 UTC (rev 220375)
@@ -1,5 +1,14 @@
 2017-08-07  Matt Lewis  
 
+Marked media/modern-media-controls/fullscreen-support/fullscreen-support-press.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=173946
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2017-08-07  Matt Lewis  
+
 Rebaselined js/dom/global-constructors-attributes.html on El Capitan.
 https://bugs.webkit.org/show_bug.cgi?id=175201
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (220374 => 220375)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-08-08 00:53:47 UTC (rev 220374)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2017-08-08 01:05:06 UTC (rev 220375)
@@ -737,3 +737,5 @@
 
 webkit.org/b/172148 tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html [ Pass Failure ]
 
+webkit.org/b/173946 [ Debug ]media/modern-media-controls/fullscreen-support/fullscreen-support-press.html [ Pass Failure ]
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220372] trunk/Tools

2017-08-07 Thread commit-queue

Title: [220372] trunk/Tools








Revision 220372
Author commit-qu...@webkit.org
Date 2017-08-07 17:25:21 -0700 (Mon, 07 Aug 2017)


Log Message
[XCode] webkit-patch should run sort-Xcode-project-file
https://bugs.webkit.org/show_bug.cgi?id=174036


Patch by Stephan Szabo  on 2017-08-07
Reviewed by Simon Fraser.

* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/tool/commands/download.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/upload.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/steps/__init__.py:
* Scripts/webkitpy/tool/steps/options.py:
* Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/ports.py
trunk/Tools/Scripts/webkitpy/tool/commands/download.py
trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py
trunk/Tools/Scripts/webkitpy/tool/commands/upload.py
trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py
trunk/Tools/Scripts/webkitpy/tool/steps/__init__.py
trunk/Tools/Scripts/webkitpy/tool/steps/options.py


Added Paths

trunk/Tools/Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py




Diff

Modified: trunk/Tools/ChangeLog (220371 => 220372)

--- trunk/Tools/ChangeLog	2017-08-07 23:56:32 UTC (rev 220371)
+++ trunk/Tools/ChangeLog	2017-08-08 00:25:21 UTC (rev 220372)
@@ -1,3 +1,20 @@
+2017-08-07  Stephan Szabo  
+
+[XCode] webkit-patch should run sort-Xcode-project-file
+https://bugs.webkit.org/show_bug.cgi?id=174036
+
+
+Reviewed by Simon Fraser.
+
+* Scripts/webkitpy/common/config/ports.py:
+* Scripts/webkitpy/tool/commands/download.py:
+* Scripts/webkitpy/tool/commands/download_unittest.py:
+* Scripts/webkitpy/tool/commands/upload.py:
+* Scripts/webkitpy/tool/commands/upload_unittest.py:
+* Scripts/webkitpy/tool/steps/__init__.py:
+* Scripts/webkitpy/tool/steps/options.py:
+* Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
+
 2017-08-07  Devin Rousso  
 
 Web Inspector: Preview Canvas path when viewing a recording


Modified: trunk/Tools/Scripts/webkitpy/common/config/ports.py (220371 => 220372)

--- trunk/Tools/Scripts/webkitpy/common/config/ports.py	2017-08-07 23:56:32 UTC (rev 220371)
+++ trunk/Tools/Scripts/webkitpy/common/config/ports.py	2017-08-08 00:25:21 UTC (rev 220372)
@@ -134,7 +134,10 @@
 command = self.script_shell_command("run-api-tests")
 return self._append_build_style_flag(command, build_style)
 
+def run_sort_xcode_project_file_command(self):
+return self.script_shell_command("sort-Xcode-project-file")
 
+
 class IOSPort(DeprecatedPort):
 port_flag_name = "ios-device"
 


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download.py (220371 => 220372)

--- trunk/Tools/Scripts/webkitpy/tool/commands/download.py	2017-08-07 23:56:32 UTC (rev 220371)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download.py	2017-08-08 00:25:21 UTC (rev 220372)
@@ -127,6 +127,7 @@
 name = "land-cowhand"
 help_text = "Prepares a ChangeLog and lands the current working directory diff."
 steps = [
+steps.SortXcodeProjectFiles,
 steps.PrepareChangeLog,
 steps.EditChangeLog,
 steps.CheckStyle,


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (220371 => 220372)

--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py	2017-08-07 23:56:32 UTC (rev 220371)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py	2017-08-08 00:25:21 UTC (rev 220372)
@@ -90,6 +90,7 @@
 options.architecture = 'MOCK ARCH'
 options.iterate_on_new_tests = 0
 options.group = None
+options.sort_xcode_project = False
 return options
 
 def test_build(self):


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/upload.py (220371 => 220372)

--- trunk/Tools/Scripts/webkitpy/tool/commands/upload.py	2017-08-07 23:56:32 UTC (rev 220371)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/upload.py	2017-08-08 00:25:21 UTC (rev 220372)
@@ -257,6 +257,7 @@
 steps = [
 steps.PromptForBugOrTitle,
 steps.CreateBug,
+steps.SortXcodeProjectFiles,
 steps.PrepareChangeLog,
 ]
 
@@ -275,6 +276,7 @@
 steps.CheckStyle,
 steps.PromptForBugOrTitle,
 steps.CreateBug,
+steps.SortXcodeProjectFiles,
 steps.PrepareChangeLog,
 steps.EditChangeLog,
 steps.ConfirmDiff,


Modified: trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py (220371 => 220372)

--- trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py	2017-08-07 23:56:32 UTC (rev 220371)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/upload_unittest.py	2017-08-08 00:25:21 UTC (rev 220372)
@@ -103,11 +103,15 @@
 self.assert_execute_outputs(LandSafely(), [5], expected_logs=expected_logs)
 
 de

[webkit-changes] [220371] trunk/LayoutTests

2017-08-07 Thread jlewis3

Title: [220371] trunk/LayoutTests








Revision 220371
Author jlew...@apple.com
Date 2017-08-07 16:56:32 -0700 (Mon, 07 Aug 2017)


Log Message
Changed expectations for webrtc/video-rotation.html.
https://bugs.webkit.org/show_bug.cgi?id=175305

Unreviewed test gardening.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (220370 => 220371)

--- trunk/LayoutTests/ChangeLog	2017-08-07 23:55:36 UTC (rev 220370)
+++ trunk/LayoutTests/ChangeLog	2017-08-07 23:56:32 UTC (rev 220371)
@@ -1,3 +1,12 @@
+2017-08-07  Matt Lewis  
+
+Changed expectations for webrtc/video-rotation.html.
+https://bugs.webkit.org/show_bug.cgi?id=175305
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
 2017-08-07  Devin Rousso  
 
 Web Inspector: Preview Canvas path when viewing a recording


Modified: trunk/LayoutTests/TestExpectations (220370 => 220371)

--- trunk/LayoutTests/TestExpectations	2017-08-07 23:55:36 UTC (rev 220370)
+++ trunk/LayoutTests/TestExpectations	2017-08-07 23:56:32 UTC (rev 220371)
@@ -779,7 +779,7 @@
 webrtc/video-replace-track.html [ Pass Failure ]
 webrtc/video-getParameters.html [ Failure ]
 webkit.org/b/170178 webrtc/video-replace-track-to-null.html [ Pass Failure ]
-webrtc/video-rotation.html [ Pass Failure ]
+webkit.org/b/175305 webrtc/video-rotation.html [ Failure Timeout ]
 webkit.org/b/170704 webrtc/video-mute.html [ Failure ]
 webkit.org/b/170701 webrtc/datachannel/bufferedAmountLowThreshold-default.html [ Pass Failure ]
 webkit.org/b/173486 webrtc/video-replace-muted-track.html [ Pass Failure Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220369] trunk/Tools

2017-08-07 Thread commit-queue

Title: [220369] trunk/Tools








Revision 220369
Author commit-qu...@webkit.org
Date 2017-08-07 16:33:32 -0700 (Mon, 07 Aug 2017)


Log Message
Sorted EWS Queues on Patch page
https://bugs.webkit.org/show_bug.cgi?id=173667

Patch by obinna obike  on 2017-08-07
Reviewed by Aakash Jain.

* QueueStatusServer/handlers/patch.py:
(Patch.get): Sorted queue_status.
* QueueStatusServer/templates/patch.html:
Changed queue_status.items to queue_status because it's a list.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/QueueStatusServer/handlers/patch.py
trunk/Tools/QueueStatusServer/templates/patch.html




Diff

Modified: trunk/Tools/ChangeLog (220368 => 220369)

--- trunk/Tools/ChangeLog	2017-08-07 23:30:15 UTC (rev 220368)
+++ trunk/Tools/ChangeLog	2017-08-07 23:33:32 UTC (rev 220369)
@@ -1,3 +1,15 @@
+2017-08-07  obinna obike  
+
+Sorted EWS Queues on Patch page
+https://bugs.webkit.org/show_bug.cgi?id=173667
+
+Reviewed by Aakash Jain.
+
+* QueueStatusServer/handlers/patch.py:
+(Patch.get): Sorted queue_status.
+* QueueStatusServer/templates/patch.html:
+Changed queue_status.items to queue_status because it's a list.
+
 2017-08-07  Yoshiaki Jitsukawa  
 
 check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.


Modified: trunk/Tools/QueueStatusServer/handlers/patch.py (220368 => 220369)

--- trunk/Tools/QueueStatusServer/handlers/patch.py	2017-08-07 23:30:15 UTC (rev 220368)
+++ trunk/Tools/QueueStatusServer/handlers/patch.py	2017-08-07 23:33:32 UTC (rev 220369)
@@ -44,7 +44,7 @@
 per_queue_statuses = queue_status.get(status.queue_name, [])
 per_queue_statuses.append(status)
 queue_status[status.queue_name] = per_queue_statuses
-
+queue_status = sorted(queue_status.items())
 template_values = {
 "attachment_id" : attachment_id,
 "bug_id" : bug_id,


Modified: trunk/Tools/QueueStatusServer/templates/patch.html (220368 => 220369)

--- trunk/Tools/QueueStatusServer/templates/patch.html	2017-08-07 23:30:15 UTC (rev 220368)
+++ trunk/Tools/QueueStatusServer/templates/patch.html	2017-08-07 23:33:32 UTC (rev 220369)
@@ -7,7 +7,7 @@
 
 
   Patch {{ attachment_id|force_escape|webkit_attachment_id|safe }} (Bug {{ bug_id|force_escape|webkit_bug_id|safe }})
-{% for queue_name, statuses in queue_status.items %}
+{% for queue_name, statuses in queue_status %}
 
   {{ queue_name }}
   {% for status in statuses %}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220368] trunk/Source

2017-08-07 Thread fpizlo

Title: [220368] trunk/Source








Revision 220368
Author fpi...@apple.com
Date 2017-08-07 16:30:15 -0700 (Mon, 07 Aug 2017)


Log Message
Baseline JIT should do caging
https://bugs.webkit.org/show_bug.cgi?id=175037

Reviewed by Mark Lam.
Source/bmalloc:


This centralizes the notion of permanently enabling the primitive gigacage, which we only do in jsc
and WebProcess.

This saves the baseline JIT from emitting some code. Otherwise it would always have to emit enabled
checks on each typed array access.

* bmalloc/Gigacage.cpp:
(Gigacage::primitiveGigacageDisabled):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
* bmalloc/Gigacage.h:
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

Source/_javascript_Core:


Adds a AssemblyHelpers::cage and cageConditionally. Uses it in the baseline JIT.

Also modifies FTL caging to be more defensive when caging is disabled.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):
* jsc.cpp:
(jscmain):
(primitiveGigacageDisabled): Deleted.

Source/WebKit:


Use a better API to disable disabling the primitive gigacage.

* WebProcess/WebProcess.cpp:
(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::primitiveGigacageDisabled): Deleted.

Source/WTF:


* wtf/Gigacage.h:
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/bytecode/AccessCase.cpp
trunk/Source/_javascript_Core/bytecode/InlineAccess.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h
trunk/Source/_javascript_Core/jit/JITPropertyAccess.cpp
trunk/Source/_javascript_Core/jsc.cpp
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Gigacage.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebProcess.cpp
trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Gigacage.cpp
trunk/Source/bmalloc/bmalloc/Gigacage.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (220367 => 220368)

--- trunk/Source/_javascript_Core/ChangeLog	2017-08-07 23:25:27 UTC (rev 220367)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-07 23:30:15 UTC (rev 220368)
@@ -1,3 +1,35 @@
+2017-08-07  Filip Pizlo  
+
+Baseline JIT should do caging
+https://bugs.webkit.org/show_bug.cgi?id=175037
+
+Reviewed by Mark Lam.
+
+Adds a AssemblyHelpers::cage and cageConditionally. Uses it in the baseline JIT.
+
+Also modifies FTL caging to be more defensive when caging is disabled.
+
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::caged):
+* jit/AssemblyHelpers.h:
+(JSC::AssemblyHelpers::cage):
+(JSC::AssemblyHelpers::cageConditionally):
+* jit/JITPropertyAccess.cpp:
+(JSC::JIT::emitDoubleLoad):
+(JSC::JIT::emitContiguousLoad):
+(JSC::JIT::emitArrayStorageLoad):
+(JSC::JIT::emitGenericContiguousPutByVal):
+(JSC::JIT::emitArrayStoragePutByVal):
+(JSC::JIT::emit_op_get_from_scope):
+(JSC::JIT::emit_op_put_to_scope):
+(JSC::JIT::emitIntTypedArrayGetByVal):
+(JSC::JIT::emitFloatTypedArrayGetByVal):
+(JSC::JIT::emitIntTypedArrayPutByVal):
+(JSC::JIT::emitFloatTypedArrayPutByVal):
+* jsc.cpp:
+(jscmain):
+(primitiveGigacageDisabled): Deleted.
+
 2017-08-06  Filip Pizlo  
 
 Primitive auxiliaries and JSValue auxiliaries should have separate gigacages


Modified: trunk/Source/_javascript_Core/bytecode/AccessCase.cpp (220367 => 220368)

--- trunk/Source/_javascript_Core/bytecode/AccessCase.cpp	2017-08-07 23:25:27 UTC (rev 220367)
+++ trunk/Source/_javascript_Core/bytecode/AccessCase.cpp	2017-08-07 23:30:15 UTC (rev 220368)
@@ -527,6 +527,8 @@
 jit.loadPtr(
 CCallHelpers::Address(baseForAccessGPR, JSObject::butterflyOffset()),
 loadedValueGPR);
+// FIXME: Do caging!
+// https://bugs.webkit.org/show_bug.cgi?id=175295
 storageGPR = loadedValueGPR;
 }
 
@@ -877,6 +879,8 @@
 // already had out-of-line property s

[webkit-changes] [220367] trunk/Tools

2017-08-07 Thread commit-queue

Title: [220367] trunk/Tools








Revision 220367
Author commit-qu...@webkit.org
Date 2017-08-07 16:25:27 -0700 (Mon, 07 Aug 2017)


Log Message
check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
https://bugs.webkit.org/show_bug.cgi?id=175286

Patch by Yoshiaki Jitsukawa  on 2017-08-07
Reviewed by Myles C. Maxfield.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_braces.NS_ERROR_ENUM):
(WebKitStyleTest.test_braces):
(WebKitStyleTest.test_braces.NS_OPTIONS):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py
trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (220366 => 220367)

--- trunk/Tools/ChangeLog	2017-08-07 23:22:11 UTC (rev 220366)
+++ trunk/Tools/ChangeLog	2017-08-07 23:25:27 UTC (rev 220367)
@@ -1,3 +1,17 @@
+2017-08-07  Yoshiaki Jitsukawa  
+
+check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
+https://bugs.webkit.org/show_bug.cgi?id=175286
+
+Reviewed by Myles C. Maxfield.
+
+* Scripts/webkitpy/style/checkers/cpp.py:
+(check_braces):
+* Scripts/webkitpy/style/checkers/cpp_unittest.py:
+(WebKitStyleTest.test_braces.NS_ERROR_ENUM):
+(WebKitStyleTest.test_braces):
+(WebKitStyleTest.test_braces.NS_OPTIONS):
+
 2017-08-07  Brian Burg  
 
 Remove CANVAS_PATH compilation guard


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (220366 => 220367)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2017-08-07 23:22:11 UTC (rev 220366)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py	2017-08-07 23:25:27 UTC (rev 220367)
@@ -2431,7 +2431,7 @@
 # and '- (' and '+ (' for Objective-C methods.
 previous_line = get_previous_non_blank_line(clean_lines, line_number)[0]
 if ((not search(r'[;:}{)=]\s*$|\)\s*((const|override|const override|final|const final)\s*)?(->\s*\S+)?\s*$', previous_line)
- or search(r'\b(if|for|while|switch|else|NS_ENUM)\b', previous_line)
+ or search(r'\b(if|for|while|switch|else|NS_ENUM|NS_ERROR_ENUM|NS_OPTIONS)\b', previous_line)
  or regex_for_lambdas_and_blocks(previous_line, line_number, file_state, error))
 and previous_line.find('#') < 0
 and previous_line.find('- (') != 0
@@ -2440,7 +2440,7 @@
   'This { should be at the end of the previous line')
 elif (search(r'\)\s*(((const|override|final)\s*)*\s*)?{\s*$', line)
   and line.count('(') == line.count(')')
-  and not search(r'(\s*(if|for|while|switch|NS_ENUM|@synchronized)|} @catch)\b', line)
+  and not search(r'(\s*(if|for|while|switch|NS_ENUM|NS_ERROR_ENUM|NS_OPTIONS|@synchronized)|} @catch)\b', line)
   and not regex_for_lambdas_and_blocks(line, line_number, file_state, error)
   and line.find("](") < 0
   and not match(r'\s+[A-Z_][A-Z_0-9]+\b', line)):


Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (220366 => 220367)

--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2017-08-07 23:22:11 UTC (rev 220366)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	2017-08-07 23:25:27 UTC (rev 220367)
@@ -4504,6 +4504,30 @@
 '1\n'
 '};', '')
 self.assert_multi_line_lint(
+'typedef NS_ERROR_ENUM(NSInteger, type)\n'
+'{\n'
+'0,\n'
+'1\n'
+'};',
+'This { should be at the end of the previous line  [whitespace/braces] [4]')
+self.assert_multi_line_lint(
+'typedef NS_ERROR_ENUM(NSInteger, type) {\n'
+'0,\n'
+'1\n'
+'};', '')
+self.assert_multi_line_lint(
+'typedef NS_OPTIONS(NSInteger, type)\n'
+'{\n'
+'0,\n'
+'1\n'
+'};',
+'This { should be at the end of the previous line  [whitespace/braces] [4]')
+self.assert_multi_line_lint(
+'typedef NS_OPTIONS(NSInteger, type) {\n'
+'0,\n'
+'1\n'
+'};', '')
+self.assert_multi_line_lint(
 'enum class CPP11EnumClass\n'
 '{\n'
 'Value1,\n'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220366] trunk/Source/WebCore

2017-08-07 Thread cdumez

Title: [220366] trunk/Source/WebCore








Revision 220366
Author cdu...@apple.com
Date 2017-08-07 16:22:11 -0700 (Mon, 07 Aug 2017)


Log Message
Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest
https://bugs.webkit.org/show_bug.cgi?id=175280

Reviewed by Youenn Fablet.

Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest. FetchBody
for data extraction is really the only thing we need at the moment.
The new code also properly sets the CORS mode, which will be needed for Bug 175264.

* Modules/beacon/NavigatorBeacon.cpp:
(WebCore::NavigatorBeacon::sendBeacon):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (220365 => 220366)

--- trunk/Source/WebCore/ChangeLog	2017-08-07 23:18:31 UTC (rev 220365)
+++ trunk/Source/WebCore/ChangeLog	2017-08-07 23:22:11 UTC (rev 220366)
@@ -1,3 +1,17 @@
+2017-08-07  Chris Dumez  
+
+Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest
+https://bugs.webkit.org/show_bug.cgi?id=175280
+
+Reviewed by Youenn Fablet.
+
+Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest. FetchBody
+for data extraction is really the only thing we need at the moment.
+The new code also properly sets the CORS mode, which will be needed for Bug 175264.
+
+* Modules/beacon/NavigatorBeacon.cpp:
+(WebCore::NavigatorBeacon::sendBeacon):
+
 2017-08-07  Michael Catanzaro  
 
 -Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue


Modified: trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp (220365 => 220366)

--- trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp	2017-08-07 23:18:31 UTC (rev 220365)
+++ trunk/Source/WebCore/Modules/beacon/NavigatorBeacon.cpp	2017-08-07 23:22:11 UTC (rev 220366)
@@ -28,10 +28,10 @@
 
 #include "CachedResourceLoader.h"
 #include "Document.h"
-#include "FetchRequest.h"
+#include "FetchBody.h"
+#include "HTTPParsers.h"
 #include "Navigator.h"
 #include "URL.h"
-#include 
 
 namespace WebCore {
 
@@ -55,21 +55,25 @@
 return true;
 }
 
-FetchRequestInit init;
-init.method = ASCIILiteral("POST");
-init.body = WTFMove(body);
-init.credentials = FetchOptions::Credentials::Include;
-init.cache = FetchOptions::Cache::NoCache;
-init.redirect = FetchOptions::Redirect::Follow;
-init.keepalive = true;
-init.window = JSC::jsNull();
+ResourceRequest request(parsedUrl);
+request.setHTTPMethod(ASCIILiteral("POST"));
 
-auto fetchRequestResult = FetchRequest::create(document, parsedUrl.string(), WTFMove(init));
-if (fetchRequestResult.hasException())
-return fetchRequestResult.releaseException();
-
-auto fetchRequest = fetchRequestResult.releaseReturnValue();
-document.cachedResourceLoader().requestBeaconResource({ fetchRequest->internalRequest(), fetchRequest->fetchOptions() });
+FetchOptions options;
+options.credentials = FetchOptions::Credentials::Include;
+options.cache = FetchOptions::Cache::NoCache;
+options.keepAlive = true;
+if (body) {
+options.mode = FetchOptions::Mode::Cors;
+String mimeType;
+auto fetchBody = FetchBody::extract(document, WTFMove(body.value()), mimeType);
+request.setHTTPBody(fetchBody.bodyForInternalRequest(document));
+if (!mimeType.isEmpty()) {
+request.setHTTPContentType(mimeType);
+if (isCrossOriginSafeRequestHeader(HTTPHeaderName::ContentType, mimeType))
+options.mode = FetchOptions::Mode::NoCors;
+}
+}
+document.cachedResourceLoader().requestBeaconResource({ WTFMove(request), options });
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220365] branches/safari-604.1.38.0-branch/Source

2017-08-07 Thread jmarcell

Title: [220365] branches/safari-604.1.38.0-branch/Source








Revision 220365
Author jmarc...@apple.com
Date 2017-08-07 16:18:31 -0700 (Mon, 07 Aug 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (220364 => 220365)

--- branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
+++ branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 23:18:31 UTC (rev 220365)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (220364 => 220365)

--- branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
+++ branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 23:18:31 UTC (rev 220365)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig (220364 => 220365)

--- branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
+++ branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 23:18:31 UTC (rev 220365)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (220364 => 220365)

--- branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
+++ branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 23:18:31 UTC (rev 220365)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (220364 => 220365)

--- branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
+++ branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 23:18:31 UTC (rev 220365)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-604.1.38.0-branch/Source/WebKit/Configurations/Version.xcconfig (220364 => 220365)

--- branches/safari-604.1.38.0-branch/Source/WebKit/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
+++ branches/safari-604.1.38.0-branch/Source/WebKit/Configurations/Version.xcconfig	2017-08-07 23:18:31 UTC (rev 220365)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/saf

[webkit-changes] [220364] branches/safari-604.1.38.1-branch/Source

2017-08-07 Thread jmarcell

Title: [220364] branches/safari-604.1.38.1-branch/Source








Revision 220364
Author jmarc...@apple.com
Date 2017-08-07 16:16:51 -0700 (Mon, 07 Aug 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (220363 => 220364)

--- branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 23:12:36 UTC (rev 220363)
+++ branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (220363 => 220364)

--- branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 23:12:36 UTC (rev 220363)
+++ branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig (220363 => 220364)

--- branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 23:12:36 UTC (rev 220363)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (220363 => 220364)

--- branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 23:12:36 UTC (rev 220363)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (220363 => 220364)

--- branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 23:12:36 UTC (rev 220363)
+++ branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.


Modified: branches/safari-604.1.38.1-branch/Source/WebKit/Configurations/Version.xcconfig (220363 => 220364)

--- branches/safari-604.1.38.1-branch/Source/WebKit/Configurations/Version.xcconfig	2017-08-07 23:12:36 UTC (rev 220363)
+++ branches/safari-604.1.38.1-branch/Source/WebKit/Configurations/Version.xcconfig	2017-08-07 23:16:51 UTC (rev 220364)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/saf

[webkit-changes] [220363] tags/Safari-604.1.38.0.1/

2017-08-07 Thread jmarcell

Title: [220363] tags/Safari-604.1.38.0.1/








Revision 220363
Author jmarc...@apple.com
Date 2017-08-07 16:12:36 -0700 (Mon, 07 Aug 2017)


Log Message
Tag Safari-604.1.38.0.1.

Added Paths

tags/Safari-604.1.38.0.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220362] tags/Safari-604.1.38.1.1/

2017-08-07 Thread jmarcell

Title: [220362] tags/Safari-604.1.38.1.1/








Revision 220362
Author jmarc...@apple.com
Date 2017-08-07 16:10:29 -0700 (Mon, 07 Aug 2017)


Log Message
Tag Safari-604.1.38.1.1.

Added Paths

tags/Safari-604.1.38.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220361] trunk/PerformanceTests

2017-08-07 Thread msaboff

Title: [220361] trunk/PerformanceTests








Revision 220361
Author msab...@apple.com
Date 2017-08-07 15:43:24 -0700 (Mon, 07 Aug 2017)


Log Message
REGRESSION(r220307): Perf bot failure trying to run RexBench tests
https://bugs.webkit.org/show_bug.cgi?id=175289

Reviewed by Filip Pizlo.

Add RexBench to the list of benchmarks we skip on the perf bots.

* Skipped:

Modified Paths

trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/Skipped




Diff

Modified: trunk/PerformanceTests/ChangeLog (220360 => 220361)

--- trunk/PerformanceTests/ChangeLog	2017-08-07 22:31:32 UTC (rev 220360)
+++ trunk/PerformanceTests/ChangeLog	2017-08-07 22:43:24 UTC (rev 220361)
@@ -1,3 +1,14 @@
+2017-08-07  Michael Saboff  
+
+REGRESSION(r220307): Perf bot failure trying to run RexBench tests
+https://bugs.webkit.org/show_bug.cgi?id=175289
+
+Reviewed by Filip Pizlo.
+
+Add RexBench to the list of benchmarks we skip on the perf bots.
+
+* Skipped:
+
 2017-08-04  Michael Saboff  
 
 Create a new _javascript_ RegExp benchmark


Modified: trunk/PerformanceTests/Skipped (220360 => 220361)

--- trunk/PerformanceTests/Skipped	2017-08-07 22:31:32 UTC (rev 220360)
+++ trunk/PerformanceTests/Skipped	2017-08-07 22:43:24 UTC (rev 220361)
@@ -97,6 +97,7 @@
 MotionMark
 JSBench
 ARES-6
+RexBench
 
 # Used for iOS testing
 Animation/css-animation.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220360] trunk/Websites/webkit.org

2017-08-07 Thread jond

Title: [220360] trunk/Websites/webkit.org








Revision 220360
Author j...@apple.com
Date 2017-08-07 15:31:32 -0700 (Mon, 07 Aug 2017)


Log Message
Fixed superscript rendering for blog posts
https://bugs.webkit.org/show_bug.cgi?id=175285

Reviewed by Filip Pizlo.

* wp-content/themes/webkit/style.css:
(sup): Added.

Modified Paths

trunk/Websites/webkit.org/ChangeLog
trunk/Websites/webkit.org/wp-content/themes/webkit/style.css




Diff

Modified: trunk/Websites/webkit.org/ChangeLog (220359 => 220360)

--- trunk/Websites/webkit.org/ChangeLog	2017-08-07 22:26:53 UTC (rev 220359)
+++ trunk/Websites/webkit.org/ChangeLog	2017-08-07 22:31:32 UTC (rev 220360)
@@ -1,3 +1,13 @@
+2017-08-07  Jon Davis  
+
+Fixed superscript rendering for blog posts
+https://bugs.webkit.org/show_bug.cgi?id=175285
+
+Reviewed by Filip Pizlo.
+
+* wp-content/themes/webkit/style.css:
+(sup): Added.
+
 2017-08-06  James Craig  
 
 Update prefers-reduced-motion demos to link back to blog post


Modified: trunk/Websites/webkit.org/wp-content/themes/webkit/style.css (220359 => 220360)

--- trunk/Websites/webkit.org/wp-content/themes/webkit/style.css	2017-08-07 22:26:53 UTC (rev 220359)
+++ trunk/Websites/webkit.org/wp-content/themes/webkit/style.css	2017-08-07 22:31:32 UTC (rev 220360)
@@ -94,6 +94,11 @@
 em {
 font-weight: 200;
 }
+sup {
+vertical-align: super;
+font-size: smaller;
+line-height: 1;
+}
 code {
 font-family: Menlo, monospace;
 background: #f2f2f2;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220359] branches/safari-604.1.38.1-branch/Source

2017-08-07 Thread matthew_hanson

Title: [220359] branches/safari-604.1.38.1-branch/Source








Revision 220359
Author matthew_han...@apple.com
Date 2017-08-07 15:26:53 -0700 (Mon, 07 Aug 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (220358 => 220359)

--- branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 22:24:30 UTC (rev 220358)
+++ branches/safari-604.1.38.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 22:26:53 UTC (rev 220359)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 39;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+TINY_VERSION = 38;
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (220358 => 220359)

--- branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 22:24:30 UTC (rev 220358)
+++ branches/safari-604.1.38.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 22:26:53 UTC (rev 220359)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 39;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+TINY_VERSION = 38;
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig (220358 => 220359)

--- branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 22:24:30 UTC (rev 220358)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 22:26:53 UTC (rev 220359)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 39;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+TINY_VERSION = 38;
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (220358 => 220359)

--- branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 22:24:30 UTC (rev 220358)
+++ branches/safari-604.1.38.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 22:26:53 UTC (rev 220359)
@@ -23,10 +23,10 @@
 
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 39;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+TINY_VERSION = 38;
+MICRO_VERSION = 1;
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (220358 => 220359)

--- branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 22:24:30 UTC (rev 220358)
+++ branches/safari-604.1.38.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 22:26:53 UTC (rev 220359)
@@ -1,9 +1,9 @@
 MAJOR_VERSION = 604;
 MINOR_VERSION = 1;
-TINY_VERSION = 39;
-MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+TINY_VERSION = 38;
+MICRO_VERSION = 1;
+NANO_VERSION

[webkit-changes] [220358] branches/safari-604.1.38.1-branch/

2017-08-07 Thread matthew_hanson

Title: [220358] branches/safari-604.1.38.1-branch/








Revision 220358
Author matthew_han...@apple.com
Date 2017-08-07 15:24:30 -0700 (Mon, 07 Aug 2017)


Log Message
New branch.

Added Paths

branches/safari-604.1.38.1-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220357] branches/safari-604.1.38.0-branch/Source/WebKit

2017-08-07 Thread matthew_hanson

Title: [220357] branches/safari-604.1.38.0-branch/Source/WebKit








Revision 220357
Author matthew_han...@apple.com
Date 2017-08-07 15:22:37 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220273. rdar://problem/33732757

Modified Paths

branches/safari-604.1.38.0-branch/Source/WebKit/ChangeLog
branches/safari-604.1.38.0-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp




Diff

Modified: branches/safari-604.1.38.0-branch/Source/WebKit/ChangeLog (220356 => 220357)

--- branches/safari-604.1.38.0-branch/Source/WebKit/ChangeLog	2017-08-07 22:20:49 UTC (rev 220356)
+++ branches/safari-604.1.38.0-branch/Source/WebKit/ChangeLog	2017-08-07 22:22:37 UTC (rev 220357)
@@ -1,3 +1,21 @@
+2017-08-07  Jason Marcell  
+
+Cherry-pick r220273. rdar://problem/33732757
+
+2017-08-04  Andreas Kling  
+
+NetworkLoad should always invoke its redirect completion handler
+https://bugs.webkit.org/show_bug.cgi?id=175179
+
+
+Reviewed by Chris Dumez.
+
+Make sure the redirect completion handler is always invoked,
+just like we already did for the response completion handler.
+
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::~NetworkLoad):
+
 2017-08-04  Jason Marcell  
 
 Revert r219896. rdar://problem/33711000


Modified: branches/safari-604.1.38.0-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp (220356 => 220357)

--- branches/safari-604.1.38.0-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2017-08-07 22:20:49 UTC (rev 220356)
+++ branches/safari-604.1.38.0-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2017-08-07 22:22:37 UTC (rev 220357)
@@ -135,6 +135,8 @@
 #if USE(NETWORK_SESSION)
 if (m_responseCompletionHandler)
 m_responseCompletionHandler(PolicyIgnore);
+if (m_redirectCompletionHandler)
+m_redirectCompletionHandler({ });
 #if USE(PROTECTION_SPACE_AUTH_CALLBACK)
 if (m_challengeCompletionHandler)
 m_challengeCompletionHandler(AuthenticationChallengeDisposition::Cancel, { });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220356] branches/safari-604.1.38.0-branch/Source

2017-08-07 Thread matthew_hanson

Title: [220356] branches/safari-604.1.38.0-branch/Source








Revision 220356
Author matthew_han...@apple.com
Date 2017-08-07 15:20:49 -0700 (Mon, 07 Aug 2017)


Log Message
Versioning.

Modified Paths

branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-604.1.38.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (220355 => 220356)

--- branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 22:09:49 UTC (rev 220355)
+++ branches/safari-604.1.38.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2017-08-07 22:20:49 UTC (rev 220356)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (220355 => 220356)

--- branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 22:09:49 UTC (rev 220355)
+++ branches/safari-604.1.38.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2017-08-07 22:20:49 UTC (rev 220356)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig (220355 => 220356)

--- branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 22:09:49 UTC (rev 220355)
+++ branches/safari-604.1.38.0-branch/Source/WebCore/Configurations/Version.xcconfig	2017-08-07 22:20:49 UTC (rev 220356)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (220355 => 220356)

--- branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 22:09:49 UTC (rev 220355)
+++ branches/safari-604.1.38.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2017-08-07 22:20:49 UTC (rev 220356)
@@ -25,8 +25,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (220355 => 220356)

--- branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 22:09:49 UTC (rev 220355)
+++ branches/safari-604.1.38.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2017-08-07 22:20:49 UTC (rev 220356)
@@ -2,8 +2,8 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 38;
 MICRO_VERSION = 0;
-NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+NANO_VERSION = 1;
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The system version prefix is based on the current system version.
 SYSTEM_VERSION_PREFIX[sdk=iphone*] = 8;


Modified: branches/safari-604.1.38.0-branch/Source/WebKit/Configurations/Version.xcconfig (220355 => 2203

[webkit-changes] [220355] branches/safari-604.1.38.0-branch/

2017-08-07 Thread matthew_hanson

Title: [220355] branches/safari-604.1.38.0-branch/








Revision 220355
Author matthew_han...@apple.com
Date 2017-08-07 15:09:49 -0700 (Mon, 07 Aug 2017)


Log Message
New branch.

Added Paths

branches/safari-604.1.38.0-branch/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220354] trunk/Source/WebCore

2017-08-07 Thread mcatanzaro

Title: [220354] trunk/Source/WebCore








Revision 220354
Author mcatanz...@igalia.com
Date 2017-08-07 15:01:26 -0700 (Mon, 07 Aug 2017)


Log Message
-Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue
https://bugs.webkit.org/show_bug.cgi?id=174469


Reviewed by Simon Fraser.

Add a RELEASE_ASSERT_NOT_REACHED to silence this warning.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (220353 => 220354)

--- trunk/Source/WebCore/ChangeLog	2017-08-07 21:53:20 UTC (rev 220353)
+++ trunk/Source/WebCore/ChangeLog	2017-08-07 22:01:26 UTC (rev 220354)
@@ -1,3 +1,16 @@
+2017-08-07  Michael Catanzaro  
+
+-Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue
+https://bugs.webkit.org/show_bug.cgi?id=174469
+
+
+Reviewed by Simon Fraser.
+
+Add a RELEASE_ASSERT_NOT_REACHED to silence this warning.
+
+* css/CSSComputedStyleDeclaration.cpp:
+(WebCore::ComputedStyleExtractor::propertyValue):
+
 2017-08-06  Filip Pizlo  
 
 Primitive auxiliaries and JSValue auxiliaries should have separate gigacages


Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (220353 => 220354)

--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2017-08-07 21:53:20 UTC (rev 220353)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2017-08-07 22:01:26 UTC (rev 220354)
@@ -3341,6 +3341,7 @@
 list->append(cssValuePool.createValue(style->textEmphasisMark()));
 return WTFMove(list);
 }
+RELEASE_ASSERT_NOT_REACHED();
 case CSSPropertyTextIndent: {
 // If CSS3_TEXT is disabled or text-indent has only one value( | ),
 // getPropertyCSSValue() returns CSSValue.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220353] trunk/Source/WTF

2017-08-07 Thread fpizlo

Title: [220353] trunk/Source/WTF








Revision 220353
Author fpi...@apple.com
Date 2017-08-07 14:53:20 -0700 (Mon, 07 Aug 2017)


Log Message
Unreviewed, try to fix Windows build.

* wtf/Gigacage.cpp:
* wtf/Gigacage.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Gigacage.cpp
trunk/Source/WTF/wtf/Gigacage.h




Diff

Modified: trunk/Source/WTF/ChangeLog (220352 => 220353)

--- trunk/Source/WTF/ChangeLog	2017-08-07 21:31:49 UTC (rev 220352)
+++ trunk/Source/WTF/ChangeLog	2017-08-07 21:53:20 UTC (rev 220353)
@@ -1,3 +1,10 @@
+2017-08-07  Filip Pizlo  
+
+Unreviewed, try to fix Windows build.
+
+* wtf/Gigacage.cpp:
+* wtf/Gigacage.h:
+
 2017-08-06  Filip Pizlo  
 
 Primitive auxiliaries and JSValue auxiliaries should have separate gigacages


Modified: trunk/Source/WTF/wtf/Gigacage.cpp (220352 => 220353)

--- trunk/Source/WTF/wtf/Gigacage.cpp	2017-08-07 21:31:49 UTC (rev 220352)
+++ trunk/Source/WTF/wtf/Gigacage.cpp	2017-08-07 21:53:20 UTC (rev 220353)
@@ -33,7 +33,7 @@
 #if defined(USE_SYSTEM_MALLOC) && USE_SYSTEM_MALLOC
 
 extern "C" {
-void* const g_gigacageBasePtr;
+void* g_gigacageBasePtr;
 }
 
 namespace Gigacage {


Modified: trunk/Source/WTF/wtf/Gigacage.h (220352 => 220353)

--- trunk/Source/WTF/wtf/Gigacage.h	2017-08-07 21:31:49 UTC (rev 220352)
+++ trunk/Source/WTF/wtf/Gigacage.h	2017-08-07 21:53:20 UTC (rev 220353)
@@ -32,7 +32,7 @@
 #define GIGACAGE_ENABLED 0
 
 extern "C" {
-extern WTF_EXPORTDATA void* const g_gigacageBasePtr;
+extern WTF_EXPORTDATA void* g_gigacageBasePtr;
 }
 
 namespace Gigacage {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220351] trunk/Source/WebCore

2017-08-07 Thread commit-queue

Title: [220351] trunk/Source/WebCore








Revision 220351
Author commit-qu...@webkit.org
Date 2017-08-07 13:58:50 -0700 (Mon, 07 Aug 2017)


Log Message
[Curl] Add abstraction layer of cookie jar implementation for Curl port
https://bugs.webkit.org/show_bug.cgi?id=174943

Patch by Basuke Suzuki  on 2017-08-07
Reviewed by Brent Fulgham.

* platform/network/curl/CookieJarCurl.cpp:
(WebCore::CookieJarCurlFileSystem::setCookiesFromDOM):
(WebCore::CookieJarCurlFileSystem::cookiesForDOM):
(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue):
(WebCore::CookieJarCurlFileSystem::cookiesEnabled):
(WebCore::CookieJarCurlFileSystem::getRawCookies):
(WebCore::CookieJarCurlFileSystem::deleteCookie):
(WebCore::CookieJarCurlFileSystem::getHostnamesWithCookies):
(WebCore::CookieJarCurlFileSystem::deleteCookiesForHostnames):
(WebCore::CookieJarCurlFileSystem::deleteAllCookies):
(WebCore::CookieJarCurlFileSystem::deleteAllCookiesModifiedSince):
(WebCore::cookiesForDOM):
(WebCore::setCookiesFromDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteAllCookies):
(WebCore::deleteAllCookiesModifiedSince):
* platform/network/curl/CookieJarCurl.h: Added.
* platform/network/curl/CurlContext.cpp:
* platform/network/curl/CurlContext.h:
(WebCore::CurlContext::cookieJar):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp
trunk/Source/WebCore/platform/network/curl/CurlContext.cpp
trunk/Source/WebCore/platform/network/curl/CurlContext.h


Added Paths

trunk/Source/WebCore/platform/network/curl/CookieJarCurl.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (220350 => 220351)

--- trunk/Source/WebCore/ChangeLog	2017-08-07 20:30:24 UTC (rev 220350)
+++ trunk/Source/WebCore/ChangeLog	2017-08-07 20:58:50 UTC (rev 220351)
@@ -1,3 +1,36 @@
+2017-08-07  Basuke Suzuki  
+
+[Curl] Add abstraction layer of cookie jar implementation for Curl port
+https://bugs.webkit.org/show_bug.cgi?id=174943
+
+Reviewed by Brent Fulgham.
+
+* platform/network/curl/CookieJarCurl.cpp:
+(WebCore::CookieJarCurlFileSystem::setCookiesFromDOM):
+(WebCore::CookieJarCurlFileSystem::cookiesForDOM):
+(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue):
+(WebCore::CookieJarCurlFileSystem::cookiesEnabled):
+(WebCore::CookieJarCurlFileSystem::getRawCookies):
+(WebCore::CookieJarCurlFileSystem::deleteCookie):
+(WebCore::CookieJarCurlFileSystem::getHostnamesWithCookies):
+(WebCore::CookieJarCurlFileSystem::deleteCookiesForHostnames):
+(WebCore::CookieJarCurlFileSystem::deleteAllCookies):
+(WebCore::CookieJarCurlFileSystem::deleteAllCookiesModifiedSince):
+(WebCore::cookiesForDOM):
+(WebCore::setCookiesFromDOM):
+(WebCore::cookieRequestHeaderFieldValue):
+(WebCore::cookiesEnabled):
+(WebCore::getRawCookies):
+(WebCore::deleteCookie):
+(WebCore::getHostnamesWithCookies):
+(WebCore::deleteCookiesForHostnames):
+(WebCore::deleteAllCookies):
+(WebCore::deleteAllCookiesModifiedSince):
+* platform/network/curl/CookieJarCurl.h: Added.
+* platform/network/curl/CurlContext.cpp:
+* platform/network/curl/CurlContext.h:
+(WebCore::CurlContext::cookieJar):
+
 2017-08-07  Brady Eidson  
 
 Implement most of ServiceWorkerContainer::addRegistration.


Modified: trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp (220350 => 220351)

--- trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp	2017-08-07 20:30:24 UTC (rev 220350)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarCurl.cpp	2017-08-07 20:58:50 UTC (rev 220351)
@@ -17,10 +17,9 @@
  */
 
 #include "config.h"
-#include "PlatformCookieJar.h"
+#include "CookieJarCurl.h"
 
 #if USE(CURL)
-
 #include "Cookie.h"
 #include "CurlContext.h"
 #include "NotImplemented.h"
@@ -240,7 +239,7 @@
 return cookieStr.toString();
 }
 
-void setCookiesFromDOM(const NetworkStorageSession&, const URL&, const URL& url, const String& value)
+void CookieJarCurlFileSystem::setCookiesFromDOM(const NetworkStorageSession&, const URL& firstParty, const URL& url, const String& value)
 {
 CurlHandle curlHandle;
 
@@ -288,22 +287,22 @@
 return cookies;
 }
 
-String cookiesForDOM(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
+String CookieJarCurlFileSystem::cookiesForDOM(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
 {
 return cookiesForSession(session, firstParty, url, false);
 }
 
-String cookieRequestHeaderFieldValue(const NetworkStorageSession& session, const URL& firstParty, const URL& url)
+String CookieJarCurlFileSystem::cookieRequestHeaderFieldValue(const NetworkStorageSession& session, const

[webkit-changes] [220350] trunk/LayoutTests

2017-08-07 Thread ryanhaddad

Title: [220350] trunk/LayoutTests








Revision 220350
Author ryanhad...@apple.com
Date 2017-08-07 13:30:24 -0700 (Mon, 07 Aug 2017)


Log Message
Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=175102

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (220349 => 220350)

--- trunk/LayoutTests/ChangeLog	2017-08-07 18:58:06 UTC (rev 220349)
+++ trunk/LayoutTests/ChangeLog	2017-08-07 20:30:24 UTC (rev 220350)
@@ -1,5 +1,14 @@
 2017-08-07  Ryan Haddad  
 
+Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html on El Capitan.
+https://bugs.webkit.org/show_bug.cgi?id=175102
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2017-08-07  Ryan Haddad  
+
 Marking imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name.html as failing on iOS.
 https://bugs.webkit.org/show_bug.cgi?id=175273
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (220349 => 220350)

--- trunk/LayoutTests/platform/mac/TestExpectations	2017-08-07 18:58:06 UTC (rev 220349)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2017-08-07 20:30:24 UTC (rev 220350)
@@ -1625,3 +1625,5 @@
 
 webkit.org/b/174682 media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Pass Failure ]
 
+webkit.org/b/175102 [ ElCapitan ] workers/wasm-hashset-many.html [ Skip ]
+webkit.org/b/175102 [ ElCapitan ] workers/wasm-hashset-many-2.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220349] branches/safari-604.1-branch/Source/WebCore

2017-08-07 Thread matthew_hanson

Title: [220349] branches/safari-604.1-branch/Source/WebCore








Revision 220349
Author matthew_han...@apple.com
Date 2017-08-07 11:58:06 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220248. rdar://problem/33754446

Modified Paths

branches/safari-604.1-branch/Source/WebCore/ChangeLog
branches/safari-604.1-branch/Source/WebCore/platform/mac/WebVideoFullscreenController.mm




Diff

Modified: branches/safari-604.1-branch/Source/WebCore/ChangeLog (220348 => 220349)

--- branches/safari-604.1-branch/Source/WebCore/ChangeLog	2017-08-07 18:55:59 UTC (rev 220348)
+++ branches/safari-604.1-branch/Source/WebCore/ChangeLog	2017-08-07 18:58:06 UTC (rev 220349)
@@ -1,5 +1,29 @@
 2017-08-07  Jason Marcell  
 
+Cherry-pick r220248. rdar://problem/33754446
+
+2017-08-03  Jeremy Jones  
+
+Improve WebKitLegacy video fullscreen animation begin and end rects.
+https://bugs.webkit.org/show_bug.cgi?id=175152
+rdar://problem/32840576
+
+Reviewed by Eric Carlson.
+
+No new tests, becuase this change has no effect on the DOM.
+
+This change uses different rects for fullscreen animation to prevent the animation
+from failing, and to improve the aesthetics of the animation.
+
+* platform/mac/WebVideoFullscreenController.mm:
+(frameExpandedToRatioOfFrame):
+(-[WebVideoFullscreenController enterFullscreen:]):
+(-[WebVideoFullscreenController exitFullscreen]):
+(-[WebVideoFullscreenWindow animateFromRect:toRect:withSubAnimation:controllerAction:]):
+(constrainFrameToRatioOfFrame): Deleted.
+
+2017-08-07  Jason Marcell  
+
 Cherry-pick r220247. rdar://problem/33754440
 
 2017-08-03  Jer Noble  


Modified: branches/safari-604.1-branch/Source/WebCore/platform/mac/WebVideoFullscreenController.mm (220348 => 220349)

--- branches/safari-604.1-branch/Source/WebCore/platform/mac/WebVideoFullscreenController.mm	2017-08-07 18:55:59 UTC (rev 220348)
+++ branches/safari-604.1-branch/Source/WebCore/platform/mac/WebVideoFullscreenController.mm	2017-08-07 18:58:06 UTC (rev 220349)
@@ -233,22 +233,24 @@
 // MARK: -
 // MARK: Exposed Interface
 
-static void constrainFrameToRatioOfFrame(NSRect *frameToConstrain, const NSRect *frame)
+static NSRect frameExpandedToRatioOfFrame(NSRect frameToExpand, NSRect frame)
 {
 // Keep a constrained aspect ratio for the destination window
-CGFloat originalRatio = frame->size.width / frame->size.height;
-CGFloat newRatio = frameToConstrain->size.width / frameToConstrain->size.height;
+NSRect result = frameToExpand;
+CGFloat newRatio = frame.size.width / frame.size.height;
+CGFloat originalRatio = frameToExpand.size.width / frameToExpand.size.height;
 if (newRatio > originalRatio) {
-CGFloat newWidth = originalRatio * frameToConstrain->size.height;
-CGFloat diff = frameToConstrain->size.width - newWidth;
-frameToConstrain->size.width = newWidth;
-frameToConstrain->origin.x += diff / 2;
+CGFloat newWidth = newRatio * frameToExpand.size.height;
+CGFloat diff = newWidth - frameToExpand.size.width;
+result.size.width = newWidth;
+result.origin.x -= diff / 2;
 } else {
-CGFloat newHeight = frameToConstrain->size.width / originalRatio;
-CGFloat diff = frameToConstrain->size.height - newHeight;
-frameToConstrain->size.height = newHeight;
-frameToConstrain->origin.y += diff / 2;
-}
+CGFloat newHeight = frameToExpand.size.width / newRatio;
+CGFloat diff = newHeight - frameToExpand.size.height;
+result.size.height = newHeight;
+result.origin.y -= diff / 2;
+}
+return result;
 }
 
 static NSWindow *createBackgroundFullscreenWindow(NSRect frame, int level)
@@ -277,9 +279,8 @@
 if (!screen)
 screen = [NSScreen mainScreen];
 
-NSRect frame = [self videoElementRect];
 NSRect endFrame = [screen frame];
-constrainFrameToRatioOfFrame(&endFrame, &frame);
+NSRect frame = frameExpandedToRatioOfFrame([self videoElementRect], endFrame);
 
 // Create a black window if needed
 if (!_backgroundFullscreenWindow)
@@ -316,8 +317,11 @@
 // If our owner releases us we could crash if this is not the case.
 // Balanced in windowDidExitFullscreen
 [self retain];
-
-[[self fullscreenWindow] animateFromRect:[[self window] frame] toRect:endFrame withSubAnimation:_fadeAnimation controllerAction:@selector(windowDidExitFullscreen)];
+
+NSRect startFrame = [[self window] frame];
+endFrame = frameExpandedToRatioOfFrame(endFrame, startFrame);
+
+[[self fullscreenWindow] animateFromRect:startFrame toRect:endFrame withSubAnimation:_fadeAnimation controllerAction:@selector(windowDidExitFullscreen)];
 }
 
 - (void)applicationDidChangeScreenParameters:(NSNotification*)notification
@@ -504,7 +508,7 @@
 if (!wasAnimating) {

[webkit-changes] [220348] branches/safari-604.1-branch/Source/WebKit

2017-08-07 Thread matthew_hanson

Title: [220348] branches/safari-604.1-branch/Source/WebKit








Revision 220348
Author matthew_han...@apple.com
Date 2017-08-07 11:55:59 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220273. rdar://problem/33732754

Modified Paths

branches/safari-604.1-branch/Source/WebKit/ChangeLog
branches/safari-604.1-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp




Diff

Modified: branches/safari-604.1-branch/Source/WebKit/ChangeLog (220347 => 220348)

--- branches/safari-604.1-branch/Source/WebKit/ChangeLog	2017-08-07 18:55:56 UTC (rev 220347)
+++ branches/safari-604.1-branch/Source/WebKit/ChangeLog	2017-08-07 18:55:59 UTC (rev 220348)
@@ -1,3 +1,21 @@
+2017-08-07  Jason Marcell  
+
+Cherry-pick r220273. rdar://problem/33732754
+
+2017-08-04  Andreas Kling  
+
+NetworkLoad should always invoke its redirect completion handler
+https://bugs.webkit.org/show_bug.cgi?id=175179
+
+
+Reviewed by Chris Dumez.
+
+Make sure the redirect completion handler is always invoked,
+just like we already did for the response completion handler.
+
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::~NetworkLoad):
+
 2017-08-04  Jason Marcell  
 
 Revert r219896. rdar://problem/33711000


Modified: branches/safari-604.1-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp (220347 => 220348)

--- branches/safari-604.1-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2017-08-07 18:55:56 UTC (rev 220347)
+++ branches/safari-604.1-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2017-08-07 18:55:59 UTC (rev 220348)
@@ -135,6 +135,8 @@
 #if USE(NETWORK_SESSION)
 if (m_responseCompletionHandler)
 m_responseCompletionHandler(PolicyIgnore);
+if (m_redirectCompletionHandler)
+m_redirectCompletionHandler({ });
 #if USE(PROTECTION_SPACE_AUTH_CALLBACK)
 if (m_challengeCompletionHandler)
 m_challengeCompletionHandler(AuthenticationChallengeDisposition::Cancel, { });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220347] branches/safari-604.1-branch/Source/WebCore

2017-08-07 Thread matthew_hanson

Title: [220347] branches/safari-604.1-branch/Source/WebCore








Revision 220347
Author matthew_han...@apple.com
Date 2017-08-07 11:55:56 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220247. rdar://problem/33754440

Modified Paths

branches/safari-604.1-branch/Source/WebCore/ChangeLog
branches/safari-604.1-branch/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp
branches/safari-604.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm
branches/safari-604.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm




Diff

Modified: branches/safari-604.1-branch/Source/WebCore/ChangeLog (220346 => 220347)

--- branches/safari-604.1-branch/Source/WebCore/ChangeLog	2017-08-07 18:42:34 UTC (rev 220346)
+++ branches/safari-604.1-branch/Source/WebCore/ChangeLog	2017-08-07 18:55:56 UTC (rev 220347)
@@ -1,3 +1,28 @@
+2017-08-07  Jason Marcell  
+
+Cherry-pick r220247. rdar://problem/33754440
+
+2017-08-03  Jer Noble  
+
+[EME][Mac] SecureStop left on disk in Private Browsing mode.
+https://bugs.webkit.org/show_bug.cgi?id=175162
+
+Reviewed by Eric Carlson.
+
+Return an empty string from mediaKeysStorageDirectory() when the page indicates that storage should
+be ephemeral(). Previously, an empty string in this case would be treated as an error. Instead, treat
+an empty string as valid, and do not try to store or retrieve session information to disk in that case.
+
+* Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:
+(WebCore::WebKitMediaKeySession::mediaKeysStorageDirectory const):
+* platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
+(WebCore::CDMSessionAVContentKeySession::releaseKeys):
+(WebCore::CDMSessionAVContentKeySession::update):
+(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
+(WebCore::CDMSessionAVContentKeySession::contentKeySession):
+* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
+(WebCore::CDMSessionMediaSourceAVFObjC::storagePath const):
+
 2017-08-04  Jason Marcell  
 
 Revert r219896. rdar://problem/33711000


Modified: branches/safari-604.1-branch/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp (220346 => 220347)

--- branches/safari-604.1-branch/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp	2017-08-07 18:42:34 UTC (rev 220346)
+++ branches/safari-604.1-branch/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp	2017-08-07 18:55:56 UTC (rev 220347)
@@ -32,6 +32,7 @@
 #include "EventNames.h"
 #include "ExceptionCode.h"
 #include "FileSystem.h"
+#include "Page.h"
 #include "SecurityOriginData.h"
 #include "Settings.h"
 #include "WebKitMediaKeyError.h"
@@ -223,6 +224,10 @@
 if (!document)
 return emptyString();
 
+auto* page = document->page();
+if (!page || page->usesEphemeralSession())
+return emptyString();
+
 auto storageDirectory = document->settings().mediaKeysStorageDirectory();
 if (storageDirectory.isEmpty())
 return emptyString();


Modified: branches/safari-604.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm (220346 => 220347)

--- branches/safari-604.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm	2017-08-07 18:42:34 UTC (rev 220346)
+++ branches/safari-604.1-branch/Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm	2017-08-07 18:55:56 UTC (rev 220347)
@@ -45,8 +45,12 @@
 SOFT_LINK_CLASS(AVFoundation, AVStreamDataParser);
 SOFT_LINK_CLASS_OPTIONAL(AVFoundation, AVContentKeySession);
 SOFT_LINK_CONSTANT_MAY_FAIL(AVFoundation, AVContentKeyRequestProtocolVersionsKey, NSString *)
+SOFT_LINK_CONSTANT_MAY_FAIL(AVFoundation, AVContentKeySystemFairPlayStreaming, NSString *)
 
+typedef NSString *AVContentKeySystem;
+
 @interface AVContentKeySession : NSObject
++ (instancetype)contentKeySessionWithKeySystem:(AVContentKeySystem)keySystem;
 - (instancetype)initWithStorageDirectoryAtURL:(NSURL *)storageURL;
 @property (assign) id delegate;
 - (void)addStreamDataParser:(AVStreamDataParser *)streamDataParser;
@@ -191,8 +195,12 @@
 if (![getAVContentKeySessionClass() respondsToSelector:@selector(pendingExpiredSessionReportsWithAppIdentifier:storageDirectoryAtURL:)])
 return;
 
+auto storagePath = this->storagePath();
+if (storagePath.isEmpty())
+return;
+
 RetainPtr certificateData = adoptNS([[NSData alloc] initWithBytes:m_certificate->data() length:m_certificate->length()]);
-NSArray* expiredSessions = [getAVContentKeySessionClass() pendingExpiredSessionReportsWithAppIdentifier:certificateData.get() storageDirectoryAtURL:[NSURL fileURLWithPat

[webkit-changes] [220346] trunk/Source/JavaScriptCore

2017-08-07 Thread commit-queue

Title: [220346] trunk/Source/_javascript_Core








Revision 220346
Author commit-qu...@webkit.org
Date 2017-08-07 11:42:34 -0700 (Mon, 07 Aug 2017)


Log Message
Unreviewed, rolling out r220144.
https://bugs.webkit.org/show_bug.cgi?id=175276

"It did not actually speed things up in the way I expected"
(Requested by saamyjoon on #webkit).

Reverted changeset:

"On memory-constrained iOS devices, reduce the rate at which
the JS heap grows before a GC to try to keep more memory
available for the system"
https://bugs.webkit.org/show_bug.cgi?id=175041
http://trac.webkit.org/changeset/220144

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/runtime/Options.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (220345 => 220346)

--- trunk/Source/_javascript_Core/ChangeLog	2017-08-07 18:25:13 UTC (rev 220345)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-07 18:42:34 UTC (rev 220346)
@@ -1,3 +1,19 @@
+2017-08-07  Commit Queue  
+
+Unreviewed, rolling out r220144.
+https://bugs.webkit.org/show_bug.cgi?id=175276
+
+"It did not actually speed things up in the way I expected"
+(Requested by saamyjoon on #webkit).
+
+Reverted changeset:
+
+"On memory-constrained iOS devices, reduce the rate at which
+the JS heap grows before a GC to try to keep more memory
+available for the system"
+https://bugs.webkit.org/show_bug.cgi?id=175041
+http://trac.webkit.org/changeset/220144
+
 2017-08-07  Ryan Haddad  
 
 Unreviewed, rolling out r220299.


Modified: trunk/Source/_javascript_Core/heap/Heap.cpp (220345 => 220346)

--- trunk/Source/_javascript_Core/heap/Heap.cpp	2017-08-07 18:25:13 UTC (rev 220345)
+++ trunk/Source/_javascript_Core/heap/Heap.cpp	2017-08-07 18:42:34 UTC (rev 220346)
@@ -71,7 +71,6 @@
 #include 
 #if PLATFORM(IOS)
 #include 
-#include 
 #endif
 #include 
 #include 
@@ -117,39 +116,9 @@
 return Options::smallHeapSize();
 }
 
-#if PLATFORM(IOS)
-static bool useAggressiveGCTrigger()
-{
-static bool useAggressiveGCTrigger;
-static std::once_flag once;
-std::call_once(once, [] {
-useAggressiveGCTrigger = false;
-
-if (Options::forceAggressiveGCTrigger()) {
-useAggressiveGCTrigger = true;
-return;
-}
-
-uint64_t memSizeInBytes;
-size_t sizeofMemSize = sizeof(memSizeInBytes);
-if (sysctlbyname("hw.memsize", &memSizeInBytes, &sizeofMemSize, nullptr, 0))
-return;
-useAggressiveGCTrigger = memSizeInBytes <= 1 * GB;
-});
-
-return useAggressiveGCTrigger;
-}
-#endif
-
 size_t proportionalHeapSize(size_t heapSize, size_t ramSize)
 {
 #if PLATFORM(IOS)
-if (useAggressiveGCTrigger()) {
-double memoryUsed = bmalloc::api::percentAvailableMemoryInUse();
-double result = ((1 - memoryUsed) / Options::aggressiveGCTriggerScalingValue()) + 1;
-return heapSize * std::max(std::min(result, Options::aggressiveGCTriggerMaxMultiplier()), Options::aggressiveGCTriggerMinMultiplier());
-}
-
 size_t memoryFootprint = bmalloc::api::memoryFootprint();
 if (memoryFootprint < ramSize * Options::smallHeapRAMFraction())
 return Options::smallHeapGrowthFactor() * heapSize;


Modified: trunk/Source/_javascript_Core/runtime/Options.h (220345 => 220346)

--- trunk/Source/_javascript_Core/runtime/Options.h	2017-08-07 18:25:13 UTC (rev 220345)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2017-08-07 18:42:34 UTC (rev 220346)
@@ -210,10 +210,6 @@
 v(double, mediumHeapRAMFraction, 0.5, Normal, nullptr) \
 v(double, mediumHeapGrowthFactor, 1.5, Normal, nullptr) \
 v(double, largeHeapGrowthFactor, 1.24, Normal, nullptr) \
-v(bool, forceAggressiveGCTrigger, false, Normal, "If true, on iOS, we will use a different formula for proportionalHeapSize().") \
-v(double, aggressiveGCTriggerMinMultiplier, 1.07, Normal, "This is the minimum we must grow by for proportionalHeapSize() when doing aggressive triggering.") \
-v(double, aggressiveGCTriggerMaxMultiplier, 2.0, Normal,  "This is the maximum we can grow by for proportionalHeapSize() when doing aggressive triggering.") \
-v(double, aggressiveGCTriggerScalingValue, 3.5, Normal, "This scales the above formula. A larger number is more aggressive in limiting heap growth. A smaller number is more permissive in allowing heap growth.") \
 v(double, criticalGCMemoryThreshold, 0.80, Normal, "percent memory in use the GC considers critical.  The collector is much more aggressive above this threshold") \
 v(double, minimumMutatorUtilization, 0, Normal, nullptr) \
 v(double, maximumMutatorUtilization, 0.7, Normal, nullptr) \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220345] trunk/LayoutTests

2017-08-07 Thread ryanhaddad

Title: [220345] trunk/LayoutTests








Revision 220345
Author ryanhad...@apple.com
Date 2017-08-07 11:25:13 -0700 (Mon, 07 Aug 2017)


Log Message
Marking imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name.html as failing on iOS.
https://bugs.webkit.org/show_bug.cgi?id=175273

Unreviewed test gardening.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (220344 => 220345)

--- trunk/LayoutTests/ChangeLog	2017-08-07 18:22:05 UTC (rev 220344)
+++ trunk/LayoutTests/ChangeLog	2017-08-07 18:25:13 UTC (rev 220345)
@@ -1,5 +1,14 @@
 2017-08-07  Ryan Haddad  
 
+Marking imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name.html as failing on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=175273
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+
+2017-08-07  Ryan Haddad  
+
 Rebaseline js/dom/global-constructors-attributes.html.
 
 Unreviewed test gardening.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (220344 => 220345)

--- trunk/LayoutTests/platform/ios/TestExpectations	2017-08-07 18:22:05 UTC (rev 220344)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2017-08-07 18:25:13 UTC (rev 220345)
@@ -2868,3 +2868,4 @@
 
 webkit.org/b/174120 http/tests/loading/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html [ Skip ]
 
+webkit.org/b/175273 imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220344] trunk

2017-08-07 Thread beidson

Title: [220344] trunk








Revision 220344
Author beid...@apple.com
Date 2017-08-07 11:22:05 -0700 (Mon, 07 Aug 2017)


Log Message
Implement most of ServiceWorkerContainer::addRegistration.
https://bugs.webkit.org/show_bug.cgi?id=175237

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

* web-platform-tests/FileAPI/historical.https-expected.txt:
* web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
* web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
* web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
* web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-_javascript_-agent-formalism/canblock-serviceworker.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
* web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
* web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
* web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
* web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
* web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

No new tests (Covered by changes to existing tests).

There's still so much supporting infrastructure to add with these early patches
that I'm still moving them in baby steps for now, hence not implementing
register() all in one shot.

Things will start moving very quickly once we no longer need to add lots of new
primitives in each change.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:

* page/DOMWindow.cpp:
(WebCore::DOMWindow::navigator const):

* page/Navigator.cpp:
(WebCore::Navigator::Navigator): Make the constructor take a ScriptExecutionContext for
  creation of objects where its import (e.g. ServiceWorkerContainer).
* page/Navi

[webkit-changes] [220343] trunk/LayoutTests

2017-08-07 Thread ryanhaddad

Title: [220343] trunk/LayoutTests








Revision 220343
Author ryanhad...@apple.com
Date 2017-08-07 10:06:58 -0700 (Mon, 07 Aug 2017)


Log Message
Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
* platform/mac/js/dom/global-constructors-attributes-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt
trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (220342 => 220343)

--- trunk/LayoutTests/ChangeLog	2017-08-07 16:44:12 UTC (rev 220342)
+++ trunk/LayoutTests/ChangeLog	2017-08-07 17:06:58 UTC (rev 220343)
@@ -1,5 +1,14 @@
 2017-08-07  Ryan Haddad  
 
+Rebaseline js/dom/global-constructors-attributes.html.
+
+Unreviewed test gardening.
+
+* platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
+* platform/mac/js/dom/global-constructors-attributes-expected.txt:
+
+2017-08-07  Ryan Haddad  
+
 Unreviewed, rolling out r220299.
 
 This change caused LayoutTest inspector/dom-debugger/dom-


Modified: trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt (220342 => 220343)

--- trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt	2017-08-07 16:44:12 UTC (rev 220342)
+++ trunk/LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt	2017-08-07 17:06:58 UTC (rev 220343)
@@ -228,6 +228,16 @@
 PASS Object.getOwnPropertyDescriptor(global, 'CSSValueList').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSSValueList').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'CSSValueList').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'Cache').value is Cache
+PASS Object.getOwnPropertyDescriptor(global, 'Cache').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Cache').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'Cache').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'Cache').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'CacheStorage').value is CacheStorage
+PASS Object.getOwnPropertyDescriptor(global, 'CacheStorage').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'CacheStorage').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'CacheStorage').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'CacheStorage').configurable is true
 PASS Object.getOwnPropertyDescriptor(global, 'CanvasCaptureMediaStreamTrack').value is CanvasCaptureMediaStreamTrack
 PASS Object.getOwnPropertyDescriptor(global, 'CanvasCaptureMediaStreamTrack').hasOwnProperty('get') is false
 PASS Object.getOwnPropertyDescriptor(global, 'CanvasCaptureMediaStreamTrack').hasOwnProperty('set') is false


Modified: trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt (220342 => 220343)

--- trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt	2017-08-07 16:44:12 UTC (rev 220342)
+++ trunk/LayoutTests/platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt	2017-08-07 17:06:58 UTC (rev 220343)
@@ -2103,6 +2103,21 @@
 PASS Object.getOwnPropertyDescriptor(global, 'Selection').hasOwnProperty('set') is false
 PASS Object.getOwnPropertyDescriptor(global, 'Selection').enumerable is false
 PASS Object.getOwnPropertyDescriptor(global, 'Selection').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorker').value is ServiceWorker
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorker').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorker').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorker').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorker').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerContainer').value is ServiceWorkerContainer
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerContainer').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerContainer').hasOwnProperty('set') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerContainer').enumerable is false
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerContainer').configurable is true
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerRegistration').value is ServiceWorkerRegistration
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerRegistration').hasOwnProperty('get') is false
+PASS Object.getOwnPropertyDescriptor(global, 'ServiceWorkerRegistration').hasOwnProperty('set') is false
+PASS Object.getO

[webkit-changes] [220342] trunk

2017-08-07 Thread ryanhaddad

Title: [220342] trunk








Revision 220342
Author ryanhad...@apple.com
Date 2017-08-07 09:44:12 -0700 (Mon, 07 Aug 2017)


Log Message
Unreviewed, rolling out r220299.

This change caused LayoutTest inspector/dom-debugger/dom-
breakpoints.html to fail.

Reverted changeset:

"Web Inspector: capture async stack trace when workers/main
context posts a message"
https://bugs.webkit.org/show_bug.cgi?id=167084
http://trac.webkit.org/changeset/220299

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/debugger/async-stack-trace-expected.txt
trunk/LayoutTests/inspector/debugger/async-stack-trace.html
trunk/LayoutTests/inspector/dom-debugger/dom-breakpoints.html
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/agents/InspectorDebuggerAgent.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorInstrumentation.cpp
trunk/Source/WebCore/inspector/InspectorInstrumentation.h
trunk/Source/WebCore/inspector/PageDebuggerAgent.cpp
trunk/Source/WebCore/inspector/PageDebuggerAgent.h
trunk/Source/WebCore/page/DOMWindow.cpp


Removed Paths

trunk/LayoutTests/inspector/debugger/resources/postMessage-echo.html




Diff

Modified: trunk/LayoutTests/ChangeLog (220341 => 220342)

--- trunk/LayoutTests/ChangeLog	2017-08-07 16:42:41 UTC (rev 220341)
+++ trunk/LayoutTests/ChangeLog	2017-08-07 16:44:12 UTC (rev 220342)
@@ -1,3 +1,17 @@
+2017-08-07  Ryan Haddad  
+
+Unreviewed, rolling out r220299.
+
+This change caused LayoutTest inspector/dom-debugger/dom-
+breakpoints.html to fail.
+
+Reverted changeset:
+
+"Web Inspector: capture async stack trace when workers/main
+context posts a message"
+https://bugs.webkit.org/show_bug.cgi?id=167084
+http://trac.webkit.org/changeset/220299
+
 2017-08-07  Ms2ger  
 
 Remove obsolete failure expectations for wpt browsers tests.


Modified: trunk/LayoutTests/inspector/debugger/async-stack-trace-expected.txt (220341 => 220342)

--- trunk/LayoutTests/inspector/debugger/async-stack-trace-expected.txt	2017-08-07 16:42:41 UTC (rev 220341)
+++ trunk/LayoutTests/inspector/debugger/async-stack-trace-expected.txt	2017-08-07 16:44:12 UTC (rev 220342)
@@ -1,9 +1,6 @@
-CONSOLE MESSAGE: line 55: Unable to post message to http://example.com. Recipient has origin .
-
 Tests for async stack traces.
 
 
-
 == Running test suite: AsyncStackTrace
 -- Running test case: CheckAsyncStackTrace.RequestAnimationFrame
 PAUSE #1
@@ -79,21 +76,6 @@
 4: --- addEventListener ---
 5: [F] testAddEventListener
 6: [P] Global Code
-
--- Running test case: CheckAsyncStackTrace.PostMessage
-PAUSE #1
-CALL STACK:
-0: [F] pauseThenFinishTest
-1: [F] postMessageFired
-ASYNC CALL STACK:
-2: --- postMessage ---
-3: [F] messageReceived
-4: --- postMessage ---
-5: [F] testPostMessage
-6: [P] Global Code
-
--- Running test case: ShouldNotPauseForFailedPostMessage
-PASS: Should not pause for failed post message.
 -- Running test setup.
 Save DebuggerManager.asyncStackTraceDepth
 


Modified: trunk/LayoutTests/inspector/debugger/async-stack-trace.html (220341 => 220342)

--- trunk/LayoutTests/inspector/debugger/async-stack-trace.html	2017-08-07 16:42:41 UTC (rev 220341)
+++ trunk/LayoutTests/inspector/debugger/async-stack-trace.html	2017-08-07 16:44:12 UTC (rev 220342)
@@ -50,23 +50,6 @@
 document.body.click();
 }
 
-function testPostMessage(targetOrigin = "*") {
-let childFrame = document.getElementById("postMessageTestFrame");
-childFrame.contentWindow.postMessage("", targetOrigin);
-
-window.addEventListener("message", function postMessageFired() {
-window.removeEventListener("message", postMessageFired);
-pauseThenFinishTest();
-});
-}
-
-function testFailPostMessage() {
-testPostMessage("http://example.com");
-setTimeout(() => {
-TestPage.dispatchEventToFrontend("AfterTestFunction");
-}, 0);
-}
-
 function recursiveCallThenTest(testFunction, depth) {
 if (depth) {
 recursiveCallThenTest(testFunction, depth - 1);
@@ -96,17 +79,16 @@
 name: `CheckAsyncStackTrace.${name}`,
 test(resolve, reject) {
 let pauseCount = 0;
-function debuggerPaused() {
+function handlePaused() {
 InspectorTest.log(`PAUSE #${++pauseCount}`);
 logActiveStackTrace();
 WI.debuggerManager.resume();
 }
 
-WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.Paused, debuggerPaused);
+WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.Paused, handlePaused);
 
-InspectorTest.awaitEvent("AfterTestFunction")
-.then(() => {
-WI.debuggerManager.removeEventListener(WI.DebuggerManager.Event.Paused, debuggerPaused);
+InspectorTest.singleFireEventListener("AfterTestFunction", () => {
+WI.debu

[webkit-changes] [220341] branches/safari-604-branch/Source/WebKit

2017-08-07 Thread matthew_hanson

Title: [220341] branches/safari-604-branch/Source/WebKit








Revision 220341
Author matthew_han...@apple.com
Date 2017-08-07 09:42:41 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220273. rdar://problem/33732762

Modified Paths

branches/safari-604-branch/Source/WebKit/ChangeLog
branches/safari-604-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp




Diff

Modified: branches/safari-604-branch/Source/WebKit/ChangeLog (220340 => 220341)

--- branches/safari-604-branch/Source/WebKit/ChangeLog	2017-08-07 16:42:38 UTC (rev 220340)
+++ branches/safari-604-branch/Source/WebKit/ChangeLog	2017-08-07 16:42:41 UTC (rev 220341)
@@ -1,5 +1,23 @@
 2017-08-07  Jason Marcell  
 
+Cherry-pick r220273. rdar://problem/33732762
+
+2017-08-04  Andreas Kling  
+
+NetworkLoad should always invoke its redirect completion handler
+https://bugs.webkit.org/show_bug.cgi?id=175179
+
+
+Reviewed by Chris Dumez.
+
+Make sure the redirect completion handler is always invoked,
+just like we already did for the response completion handler.
+
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::~NetworkLoad):
+
+2017-08-07  Jason Marcell  
+
 Cherry-pick r220185. rdar://problem/33713534
 
 2017-08-02  Chris Dumez  


Modified: branches/safari-604-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp (220340 => 220341)

--- branches/safari-604-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2017-08-07 16:42:38 UTC (rev 220340)
+++ branches/safari-604-branch/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2017-08-07 16:42:41 UTC (rev 220341)
@@ -135,6 +135,8 @@
 #if USE(NETWORK_SESSION)
 if (m_responseCompletionHandler)
 m_responseCompletionHandler(PolicyIgnore);
+if (m_redirectCompletionHandler)
+m_redirectCompletionHandler({ });
 #if USE(PROTECTION_SPACE_AUTH_CALLBACK)
 if (m_challengeCompletionHandler)
 m_challengeCompletionHandler(AuthenticationChallengeDisposition::Cancel, { });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220340] branches/safari-604-branch

2017-08-07 Thread matthew_hanson

Title: [220340] branches/safari-604-branch








Revision 220340
Author matthew_han...@apple.com
Date 2017-08-07 09:42:38 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220185. rdar://problem/33713534

Modified Paths

branches/safari-604-branch/LayoutTests/ChangeLog
branches/safari-604-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-redirect-expected.txt
branches/safari-604-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-redirect.html
branches/safari-604-branch/Source/WebKit/ChangeLog
branches/safari-604-branch/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
branches/safari-604-branch/Source/WebKit/NetworkProcess/NetworkResourceLoader.h




Diff

Modified: branches/safari-604-branch/LayoutTests/ChangeLog (220339 => 220340)

--- branches/safari-604-branch/LayoutTests/ChangeLog	2017-08-07 16:42:35 UTC (rev 220339)
+++ branches/safari-604-branch/LayoutTests/ChangeLog	2017-08-07 16:42:38 UTC (rev 220340)
@@ -1,5 +1,23 @@
 2017-08-07  Jason Marcell  
 
+Cherry-pick r220185. rdar://problem/33713534
+
+2017-08-02  Chris Dumez  
+
+NetworkResourceLoader::setDefersLoading() may cause start() to be called multiple times
+https://bugs.webkit.org/show_bug.cgi?id=175109
+
+
+Reviewed by Brady Eidson.
+
+Extend test coverage to cover cacheable redirects to a resource that needs
+revalidation, similarly to the case in the radar.
+
+* http/tests/cache/disk-cache/disk-cache-redirect-expected.txt:
+* http/tests/cache/disk-cache/disk-cache-redirect.html:
+
+2017-08-07  Jason Marcell  
+
 Cherry-pick r220163. rdar://problem/33711032
 
 2017-08-02  Andy Estes  


Modified: branches/safari-604-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-redirect-expected.txt (220339 => 220340)

--- branches/safari-604-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-redirect-expected.txt	2017-08-07 16:42:35 UTC (rev 220339)
+++ branches/safari-604-branch/LayoutTests/http/tests/cache/disk-cache/disk-cache-redirect-expected.txt	2017-08-07 16:42:38 UTC (rev 220340)
@@ -3,7 +3,7 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-running 12 tests
+running 24 tests
 
 Testing loads from disk cache
 response headers: {"Status":"301","Location":"unique-cacheable"}
@@ -18,6 +18,18 @@
 response headers: {"Status":"307","Location":"unique-cacheable"}
 response source: Network
 
+response headers: {"Status":"301","Location":"/cache/resources/compass-no-cache.jpg"}
+response source: Disk cache after validation
+
+response headers: {"Status":"302","Location":"/cache/resources/compass-no-cache.jpg"}
+response source: Network
+
+response headers: {"Status":"303","Location":"/cache/resources/compass-no-cache.jpg"}
+response source: Network
+
+response headers: {"Status":"307","Location":"/cache/resources/compass-no-cache.jpg"}
+response source: Network
+
 response headers: {"Status":"301","Location":"unique-cacheable","Cache-control":"max-age=0"}
 response source: Network
 
@@ -30,6 +42,18 @@
 response headers: {"Status":"307","Location":"unique-cacheable","Cache-control":"max-age=0"}
 response source: Network
 
+response headers: {"Status":"301","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=0"}
+response source: Network
+
+response headers: {"Status":"302","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=0"}
+response source: Network
+
+response headers: {"Status":"303","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=0"}
+response source: Network
+
+response headers: {"Status":"307","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=0"}
+response source: Network
+
 response headers: {"Status":"301","Location":"unique-cacheable","Cache-control":"max-age=100"}
 response source: Disk cache
 
@@ -42,6 +66,18 @@
 response headers: {"Status":"307","Location":"unique-cacheable","Cache-control":"max-age=100"}
 response source: Disk cache
 
+response headers: {"Status":"301","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=100"}
+response source: Disk cache after validation
+
+response headers: {"Status":"302","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=100"}
+response source: Disk cache after validation
+
+response headers: {"Status":"303","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=100"}
+response source: Disk cache after validation
+
+response headers: {"Status":"307","Location":"/cache/resources/compass-no-cache.jpg","Cache-control":"max-age=100"}
+response source: Disk cache after validation
+
 Testing loads through memory cache (XHR behavior)
 response headers: {"Status":"301","Location":"unique-cacheable"}
 response source: Memory cache
@@ -55,6 +91,18 @@
 response headers: {"Status":"307","Location":"unique-cacheable"}

[webkit-changes] [220338] branches/safari-604-branch/Source/WebCore

2017-08-07 Thread matthew_hanson

Title: [220338] branches/safari-604-branch/Source/WebCore








Revision 220338
Author matthew_han...@apple.com
Date 2017-08-07 09:42:30 -0700 (Mon, 07 Aug 2017)


Log Message
Cherry-pick r220153. rdar://problem/33711047

Modified Paths

branches/safari-604-branch/Source/WebCore/ChangeLog
branches/safari-604-branch/Source/WebCore/Modules/mediasource/SourceBuffer.cpp




Diff

Modified: branches/safari-604-branch/Source/WebCore/ChangeLog (220337 => 220338)

--- branches/safari-604-branch/Source/WebCore/ChangeLog	2017-08-07 16:32:24 UTC (rev 220337)
+++ branches/safari-604-branch/Source/WebCore/ChangeLog	2017-08-07 16:42:30 UTC (rev 220338)
@@ -1,3 +1,19 @@
+2017-08-07  Jason Marcell  
+
+Cherry-pick r220153. rdar://problem/33711047
+
+2017-08-02  Jer Noble  
+
+[MSE] Removing samples when presentation order does not match decode order can cause bad behavior.
+https://bugs.webkit.org/show_bug.cgi?id=175091
+
+Reviewed by Eric Carlson.
+
+Address follow-up comments to r219519.
+
+* Modules/mediasource/SourceBuffer.cpp:
+(WebCore::SourceBuffer::removeCodedFrames):
+
 2017-08-02  Jason Marcell  
 
 Cherry-pick r220112. rdar://problem/33692164


Modified: branches/safari-604-branch/Source/WebCore/Modules/mediasource/SourceBuffer.cpp (220337 => 220338)

--- branches/safari-604-branch/Source/WebCore/Modules/mediasource/SourceBuffer.cpp	2017-08-07 16:32:24 UTC (rev 220337)
+++ branches/safari-604-branch/Source/WebCore/Modules/mediasource/SourceBuffer.cpp	2017-08-07 16:42:30 UTC (rev 220338)
@@ -770,7 +770,7 @@
 
 auto removePresentationStart = trackBuffer.samples.presentationOrder().findSampleContainingOrAfterPresentationTime(start);
 auto removePresentationEnd = trackBuffer.samples.presentationOrder().findSampleStartingAfterPresentationTime(end);
-if (start == end)
+if (removePresentationStart == removePresentationEnd)
 continue;
 
 // 3.3 Remove all media data, from this track buffer, that contain starting timestamps greater than or equal to






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220337] trunk/Source/WebCore

2017-08-07 Thread bburg

Title: [220337] trunk/Source/WebCore








Revision 220337
Author bb...@apple.com
Date 2017-08-07 09:32:24 -0700 (Mon, 07 Aug 2017)


Log Message
Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=175190

Reviewed by Sam Weinig.

This runtime enabled flag is not used by anything. It was added
for V8 in .

* Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::setIsAvailable): Deleted.
(WebCore::WebSocket::isAvailable): Deleted.
* Modules/websockets/WebSocket.h:
* Modules/websockets/WebSocket.idl:
* page/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::webSocketEnabled const): Deleted.
* page/RuntimeEnabledFeatures.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocket.cpp
trunk/Source/WebCore/Modules/websockets/WebSocket.h
trunk/Source/WebCore/Modules/websockets/WebSocket.idl
trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp
trunk/Source/WebCore/page/RuntimeEnabledFeatures.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (220336 => 220337)

--- trunk/Source/WebCore/ChangeLog	2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/ChangeLog	2017-08-07 16:32:24 UTC (rev 220337)
@@ -1,5 +1,24 @@
 2017-08-07  Brian Burg  
 
+Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
+https://bugs.webkit.org/show_bug.cgi?id=175190
+
+Reviewed by Sam Weinig.
+
+This runtime enabled flag is not used by anything. It was added
+for V8 in .
+
+* Modules/websockets/WebSocket.cpp:
+(WebCore::WebSocket::setIsAvailable): Deleted.
+(WebCore::WebSocket::isAvailable): Deleted.
+* Modules/websockets/WebSocket.h:
+* Modules/websockets/WebSocket.idl:
+* page/RuntimeEnabledFeatures.cpp:
+(WebCore::RuntimeEnabledFeatures::webSocketEnabled const): Deleted.
+* page/RuntimeEnabledFeatures.h:
+
+2017-08-07  Brian Burg  
+
 Remove CANVAS_PATH compilation guard
 https://bugs.webkit.org/show_bug.cgi?id=175207
 


Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.cpp (220336 => 220337)

--- trunk/Source/WebCore/Modules/websockets/WebSocket.cpp	2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.cpp	2017-08-07 16:32:24 UTC (rev 220337)
@@ -126,18 +126,6 @@
 return a + b;
 }
 
-static bool webSocketsAvailable = true;
-
-void WebSocket::setIsAvailable(bool available)
-{
-webSocketsAvailable = available;
-}
-
-bool WebSocket::isAvailable()
-{
-return webSocketsAvailable;
-}
-
 const char* WebSocket::subprotocolSeparator()
 {
 return ", ";


Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.h (220336 => 220337)

--- trunk/Source/WebCore/Modules/websockets/WebSocket.h	2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.h	2017-08-07 16:32:24 UTC (rev 220337)
@@ -52,9 +52,6 @@
 
 class WebSocket final : public RefCounted, public EventTargetWithInlineData, public ActiveDOMObject, private WebSocketChannelClient {
 public:
-static void setIsAvailable(bool);
-static bool isAvailable();
-
 static const char* subprotocolSeparator();
 
 static ExceptionOr> create(ScriptExecutionContext&, const String& url);


Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.idl (220336 => 220337)

--- trunk/Source/WebCore/Modules/websockets/WebSocket.idl	2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.idl	2017-08-07 16:32:24 UTC (rev 220337)
@@ -35,7 +35,6 @@
 Constructor(USVString url, DOMString protocol),
 ConstructorMayThrowException,
 ConstructorCallWith=ScriptExecutionContext,
-EnabledAtRuntime=WebSocket,
 Exposed=(Window,Worker),
 ] interface WebSocket : EventTarget {
 readonly attribute USVString URL; // Lowercased .url is the one in the spec, but leaving .URL for compatibility reasons.


Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp (220336 => 220337)

--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp	2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.cpp	2017-08-07 16:32:24 UTC (rev 220337)
@@ -33,7 +33,6 @@
 #include "RuntimeEnabledFeatures.h"
 
 #include "MediaPlayer.h"
-#include "WebSocket.h"
 #include 
 
 namespace WebCore {
@@ -59,9 +58,4 @@
 }
 #endif
 
-bool RuntimeEnabledFeatures::webSocketEnabled() const
-{
-return WebSocket::isAvailable();
-}
-
 } // namespace WebCore


Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (220336 => 220337)

--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2017-08-07 16:29:53 UTC (rev 220336)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2017-08-07 16:32:24 UTC (rev 220337)
@@ -207,8 +207,6 @@
 bool audioEnabled() const;
 #endif
 
-bool webSocketEnabled() const;
-
 WEBCORE_EXPORT static RuntimeEnabledFeatures& sharedFeatures();
 
 private:






__

[webkit-changes] [220336] trunk

2017-08-07 Thread bburg

Title: [220336] trunk








Revision 220336
Author bb...@apple.com
Date 2017-08-07 09:29:53 -0700 (Mon, 07 Aug 2017)


Log Message
Remove CANVAS_PATH compilation guard
https://bugs.webkit.org/show_bug.cgi?id=175207

Reviewed by Sam Weinig.

.:

* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsWin.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmake/tools/vsprops/FeatureDefines.props:
* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* html/canvas/DOMPath.h:
* html/canvas/DOMPath.idl:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

Modified Paths

trunk/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/FeatureDefines.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
trunk/Source/WebCore/html/canvas/DOMPath.h
trunk/Source/WebCore/html/canvas/DOMPath.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/FeatureDefines.xcconfig
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsMac.cmake
trunk/Source/cmake/OptionsWin.cmake
trunk/Source/cmake/WebKitFeatures.cmake
trunk/Source/cmake/tools/vsprops/FeatureDefines.props
trunk/Source/cmake/tools/vsprops/FeatureDefinesCairo.props
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitperl/FeatureList.pm
trunk/Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig




Diff

Modified: trunk/ChangeLog (220335 => 220336)

--- trunk/ChangeLog	2017-08-07 16:22:23 UTC (rev 220335)
+++ trunk/ChangeLog	2017-08-07 16:29:53 UTC (rev 220336)
@@ -1,3 +1,17 @@
+2017-08-07  Brian Burg  
+
+Remove CANVAS_PATH compilation guard
+https://bugs.webkit.org/show_bug.cgi?id=175207
+
+Reviewed by Sam Weinig.
+
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsMac.cmake:
+* Source/cmake/OptionsWin.cmake:
+* Source/cmake/WebKitFeatures.cmake:
+* Source/cmake/tools/vsprops/FeatureDefines.props:
+* Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
+
 2017-08-03  Brian Burg  
 
 Remove ENABLE(WEB_SOCKET) guards


Modified: trunk/Source/_javascript_Core/ChangeLog (220335 => 220336)

--- trunk/Source/_javascript_Core/ChangeLog	2017-08-07 16:22:23 UTC (rev 220335)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-07 16:29:53 UTC (rev 220336)
@@ -1,3 +1,12 @@
+2017-08-07  Brian Burg  
+
+Remove CANVAS_PATH compilation guard
+https://bugs.webkit.org/show_bug.cgi?id=175207
+
+Reviewed by Sam Weinig.
+
+* Configurations/FeatureDefines.xcconfig:
+
 2017-08-07  Keith Miller  
 
 REGRESSION: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js failing on JSC Debug bots


Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (220335 => 220336)

--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-08-07 16:22:23 UTC (rev 220335)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2017-08-07 16:29:53 UTC (rev 220336)
@@ -67,7 +67,6 @@
 ENABLE_ATTACHMENT_ELEMENT = ENABLE_ATTACHMENT_ELEMENT;
 ENABLE_AVF_CAPTIONS = ENABLE_AVF_CAPTIONS;
 ENABLE_CACHE_PARTITIONING = ENABLE_CACHE_PARTITIONING;
-ENABLE_CANVAS_PATH = ENABLE_CANVAS_PATH;
 ENABLE_CANVAS_PROXY = ;
 ENABLE_CHANNEL_MESSAGING = ENABLE_CHANNEL_MESSAGING;
 ENABLE_ENCRYPTED_MEDIA = ;
@@ -242,4 +241,4 @@
 ENABLE_DATA_INTERACTION[sdk=iphoneos11*] = ENABLE_DATA_INTERACTION;
 ENABLE_DATA_INTERACTION[sdk=iphonesimulator11*] = ENABLE_DATA_INTERACTION;
 
-FEATURE_DEFINES = $(ENABLE_3D_TRANSFORMS) $(ENABLE_ACCELERATED_2D_CANVAS) $(ENABLE_ACCELERATED_OVERFLOW_SCROLLING) $(ENABLE_APPLE_PAY) $(ENABLE_APPLE_PAY_SESSION_V3) $(ENABLE_ATTACHMENT_ELEMENT) $(ENABLE_AVF_CAPTIONS) $(ENABLE_CACHE_PARTITIONING) $(ENABLE_CANVAS_PATH) $(ENABLE_CANVAS_PROXY) $(ENABLE_CHANNEL_MESSAGING) $(ENABLE_CONTENT_FILTERING) $(ENABLE_CSS_ANIMATIONS_LEVEL_2) $(ENABLE_CSS_BOX_DECORATION_BREAK) $(ENABLE_CSS_COMPOSITING) $(ENABLE_CSS_DEVICE_ADAPTATION) $(ENABLE_CSS_IMAGE_ORIENTATION) $(ENABLE_CSS_IMAGE_RESOLUTION) $(ENABLE_CSS_REGIONS) $(ENABLE_CSS_SCROLL_SNAP) $(ENABLE_CSS_SELECTORS_LEVEL4) $(ENABLE_CSS_TRAILING_WORD) $(ENABLE_CSS3_TEXT) $(ENABLE_CURSOR_VISIBILITY) $(ENABLE_CUSTOM_SCHEME_HANDLER) $(ENABLE_DASHBOARD_SUPPORT) $(ENABLE_DATA_INTERACTION) $(ENA

[webkit-changes] [220335] trunk/Tools

2017-08-07 Thread pvollan

Title: [220335] trunk/Tools








Revision 220335
Author pvol...@apple.com
Date 2017-08-07 09:22:23 -0700 (Mon, 07 Aug 2017)


Log Message
[Win] Use Visual Studio 2017 if installed.
https://bugs.webkit.org/show_bug.cgi?id=175188

Reviewed by Sam Weinig.

If installed, use VS2017 to build WebKit. If not, fall back to VS2015.

* Scripts/webkitdirs.pm:
(visualStudioInstallDir):
(msBuildInstallDir):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (220334 => 220335)

--- trunk/Tools/ChangeLog	2017-08-07 15:44:14 UTC (rev 220334)
+++ trunk/Tools/ChangeLog	2017-08-07 16:22:23 UTC (rev 220335)
@@ -1,3 +1,16 @@
+2017-08-07  Per Arne Vollan  
+
+[Win] Use Visual Studio 2017 if installed.
+https://bugs.webkit.org/show_bug.cgi?id=175188
+
+Reviewed by Sam Weinig.
+
+If installed, use VS2017 to build WebKit. If not, fall back to VS2015.
+
+* Scripts/webkitdirs.pm:
+(visualStudioInstallDir):
+(msBuildInstallDir):
+
 2017-08-05  Carlos Garcia Campos  
 
 [GTK][WPE] Add API to provide browser information required by automation


Modified: trunk/Tools/Scripts/webkitdirs.pm (220334 => 220335)

--- trunk/Tools/Scripts/webkitdirs.pm	2017-08-07 15:44:14 UTC (rev 220334)
+++ trunk/Tools/Scripts/webkitdirs.pm	2017-08-07 16:22:23 UTC (rev 220335)
@@ -572,7 +572,10 @@
 $vsInstallDir = $ENV{'VSINSTALLDIR'};
 $vsInstallDir =~ s|[\\/]$||;
 } else {
-$vsInstallDir = File::Spec->catdir(programFilesPath(), "Microsoft Visual Studio 14.0");
+$vsInstallDir = File::Spec->catdir(programFilesPath(), "Microsoft Visual Studio", "2017", "Community");
+if (not -e $vsInstallDir) {
+$vsInstallDir = File::Spec->catdir(programFilesPath(), "Microsoft Visual Studio 14.0");
+}
 }
 chomp($vsInstallDir = `cygpath "$vsInstallDir"`) if isCygwin();
 
@@ -584,8 +587,10 @@
 {
 return $msBuildInstallDir if defined $msBuildInstallDir;
 
-$msBuildInstallDir = File::Spec->catdir(programFilesPath(), "MSBuild", "14.0", "Bin");
-   
+$msBuildInstallDir = File::Spec->catdir(programFilesPath(), "Microsoft Visual Studio", "2017", "Community", "MSBuild", "15.0", "Bin");
+if (not -e $msBuildInstallDir) {
+$msBuildInstallDir = File::Spec->catdir(programFilesPath(), "MSBuild", "14.0", "Bin");
+}
 chomp($msBuildInstallDir = `cygpath "$msBuildInstallDir"`) if isCygwin();
 
 print "Using MSBuild: $msBuildInstallDir\n";






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220334] trunk/Source

2017-08-07 Thread clopez

Title: [220334] trunk/Source








Revision 220334
Author clo...@igalia.com
Date 2017-08-07 08:44:14 -0700 (Mon, 07 Aug 2017)


Log Message
[WPE][CMake] Only pass pkg-config CFLAGS from (E)GL when not using libepoxy.
https://bugs.webkit.org/show_bug.cgi?id=175125

Reviewed by Michael Catanzaro.

Source/WebCore:

No change of behavior, covered by existing tests.

* CMakeLists.txt: Instead of negating 3 times the use of libepoxy
move the logic for (E)GL detection inside an else() block.

Source/WebKit:

* CMakeLists.txt: When using libepoxy avoid passing the CFLAGS from (E)GL,
and instead pass the libepoxy ones.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (220333 => 220334)

--- trunk/Source/WebCore/CMakeLists.txt	2017-08-07 13:14:18 UTC (rev 220333)
+++ trunk/Source/WebCore/CMakeLists.txt	2017-08-07 15:44:14 UTC (rev 220334)
@@ -3386,34 +3386,6 @@
 # For platforms that want to use system-provided OpenGL (ES) / EGL headers,
 # these include directories, libraries or definitions need to be
 # added before the ANGLE directories.
-if (USE_OPENGL AND NOT USE_LIBEPOXY)
-list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGL_INCLUDE_DIRS}
-)
-list(APPEND WebCore_LIBRARIES
-${OPENGL_LIBRARIES}
-)
-add_definitions(${OPENGL_DEFINITIONS})
-elseif (USE_OPENGL_ES_2 AND NOT USE_LIBEPOXY)
-list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGLES2_INCLUDE_DIRS}
-)
-list(APPEND WebCore_LIBRARIES
-${OPENGLES2_LIBRARIES}
-)
-add_definitions(${OPENGLES2_DEFINITIONS})
-endif ()
-
-if (USE_EGL AND NOT USE_LIBEPOXY)
-list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
-${EGL_INCLUDE_DIRS}
-)
-list(APPEND WebCore_LIBRARIES
-${EGL_LIBRARIES}
-)
-add_definitions(${EGL_DEFINITIONS})
-endif ()
-
 if (USE_LIBEPOXY)
 list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
 ${LIBEPOXY_INCLUDE_DIRS}
@@ -3421,6 +3393,34 @@
 list(APPEND WebCore_LIBRARIES
 ${LIBEPOXY_LIBRARIES}
 )
+else ()
+if (USE_OPENGL)
+list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGL_INCLUDE_DIRS}
+)
+list(APPEND WebCore_LIBRARIES
+${OPENGL_LIBRARIES}
+)
+add_definitions(${OPENGL_DEFINITIONS})
+elseif (USE_OPENGL_ES_2)
+list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGLES2_INCLUDE_DIRS}
+)
+list(APPEND WebCore_LIBRARIES
+${OPENGLES2_LIBRARIES}
+)
+add_definitions(${OPENGLES2_DEFINITIONS})
+endif ()
+
+if (USE_EGL)
+list(APPEND WebCore_SYSTEM_INCLUDE_DIRECTORIES
+${EGL_INCLUDE_DIRS}
+)
+list(APPEND WebCore_LIBRARIES
+${EGL_LIBRARIES}
+)
+add_definitions(${EGL_DEFINITIONS})
+endif ()
 endif ()
 
 list(APPEND WebCore_INCLUDE_DIRECTORIES


Modified: trunk/Source/WebCore/ChangeLog (220333 => 220334)

--- trunk/Source/WebCore/ChangeLog	2017-08-07 13:14:18 UTC (rev 220333)
+++ trunk/Source/WebCore/ChangeLog	2017-08-07 15:44:14 UTC (rev 220334)
@@ -1,3 +1,15 @@
+2017-08-07  Carlos Alberto Lopez Perez  
+
+[WPE][CMake] Only pass pkg-config CFLAGS from (E)GL when not using libepoxy.
+https://bugs.webkit.org/show_bug.cgi?id=175125
+
+Reviewed by Michael Catanzaro.
+
+No change of behavior, covered by existing tests.
+
+* CMakeLists.txt: Instead of negating 3 times the use of libepoxy
+move the logic for (E)GL detection inside an else() block.
+
 2017-08-07  Antti Koivisto  
 
 REGRESSION (r219121): Airmail 3 prints header part only.


Modified: trunk/Source/WebKit/CMakeLists.txt (220333 => 220334)

--- trunk/Source/WebKit/CMakeLists.txt	2017-08-07 13:14:18 UTC (rev 220333)
+++ trunk/Source/WebKit/CMakeLists.txt	2017-08-07 15:44:14 UTC (rev 220334)
@@ -702,32 +702,41 @@
 # For platforms that want to use system-provided OpenGL (ES) / EGL headers,
 # these include directories, libraries or definitions need to be
 # added before the ANGLE directories.
-if (USE_OPENGL)
+if (USE_LIBEPOXY)
 list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGL_INCLUDE_DIRS}
+${LIBEPOXY_INCLUDE_DIRS}
 )
 list(APPEND WebKit2_LIBRARIES
-${OPENGL_LIBRARIES}
+${LIBEPOXY_LIBRARIES}
 )
-add_definitions(${OPENGL_DEFINITIONS})
-elseif (USE_OPENGL_ES_2)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGLES2_INCLUDE_DIRS}
-)
-list(APPEND WebKit2_LIBR

[webkit-changes] [220333] trunk/Source/WebCore

2017-08-07 Thread antti

Title: [220333] trunk/Source/WebCore








Revision 220333
Author an...@apple.com
Date 2017-08-07 06:14:18 -0700 (Mon, 07 Aug 2017)


Log Message
REGRESSION (r219121): Airmail 3 prints header part only.
https://bugs.webkit.org/show_bug.cgi?id=175258


Reviewed by Andreas Kling.

When a WK1 WebViw is printed via AppKit view hierarchy it won't explictly set the page width
but uses the existing width. r219121 assumes that all printing code paths set the page width.

No test, there appears to be no good way to test AppKit printing behaviors without adding complicated
new testing infrastructure.

* rendering/RenderView.cpp:
(WebCore::RenderView::layout):

If we are in printing layout and don't have page width set yet then use the current view width.
This matches the behavior prior r219121.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderView.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (220332 => 220333)

--- trunk/Source/WebCore/ChangeLog	2017-08-07 13:08:32 UTC (rev 220332)
+++ trunk/Source/WebCore/ChangeLog	2017-08-07 13:14:18 UTC (rev 220333)
@@ -1,3 +1,23 @@
+2017-08-07  Antti Koivisto  
+
+REGRESSION (r219121): Airmail 3 prints header part only.
+https://bugs.webkit.org/show_bug.cgi?id=175258
+
+
+Reviewed by Andreas Kling.
+
+When a WK1 WebViw is printed via AppKit view hierarchy it won't explictly set the page width
+but uses the existing width. r219121 assumes that all printing code paths set the page width.
+
+No test, there appears to be no good way to test AppKit printing behaviors without adding complicated
+new testing infrastructure.
+
+* rendering/RenderView.cpp:
+(WebCore::RenderView::layout):
+
+If we are in printing layout and don't have page width set yet then use the current view width.
+This matches the behavior prior r219121.
+
 2017-08-05  Youenn Fablet  
 
 [Fetch API] Response should keep all ResourceResponse information


Modified: trunk/Source/WebCore/rendering/RenderView.cpp (220332 => 220333)

--- trunk/Source/WebCore/rendering/RenderView.cpp	2017-08-07 13:08:32 UTC (rev 220332)
+++ trunk/Source/WebCore/rendering/RenderView.cpp	2017-08-07 13:14:18 UTC (rev 220333)
@@ -341,7 +341,8 @@
 m_pageLogicalSize = { };
 
 if (shouldUsePrintingLayout()) {
-ASSERT(m_pageLogicalSize);
+if (!m_pageLogicalSize)
+m_pageLogicalSize = LayoutSize(logicalWidth(), 0);
 m_minPreferredLogicalWidth = m_pageLogicalSize->width();
 m_maxPreferredLogicalWidth = m_minPreferredLogicalWidth;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220332] trunk/LayoutTests

2017-08-07 Thread commit-queue

Title: [220332] trunk/LayoutTests








Revision 220332
Author commit-qu...@webkit.org
Date 2017-08-07 06:08:32 -0700 (Mon, 07 Aug 2017)


Log Message
Remove obsolete failure expectations for wpt browsers tests.
https://bugs.webkit.org/show_bug.cgi?id=175073

Unreviewed test gardening.

Patch by Ms2ger  on 2017-08-07

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (220331 => 220332)

--- trunk/LayoutTests/ChangeLog	2017-08-07 09:53:52 UTC (rev 220331)
+++ trunk/LayoutTests/ChangeLog	2017-08-07 13:08:32 UTC (rev 220332)
@@ -1,3 +1,12 @@
+2017-08-07  Ms2ger  
+
+Remove obsolete failure expectations for wpt browsers tests.
+https://bugs.webkit.org/show_bug.cgi?id=175073
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
 2017-08-05  Youenn Fablet  
 
 [Fetch API] Response should keep all ResourceResponse information


Modified: trunk/LayoutTests/TestExpectations (220331 => 220332)

--- trunk/LayoutTests/TestExpectations	2017-08-07 09:53:52 UTC (rev 220331)
+++ trunk/LayoutTests/TestExpectations	2017-08-07 13:08:32 UTC (rev 220332)
@@ -1177,12 +1177,6 @@
 
 imported/w3c/web-platform-tests/XMLHttpRequest/open-url-redirected-worker-origin.htm [ Failure Pass  ]
 imported/w3c/web-platform-tests/cssom/MediaList.html [ Failure ]
-imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/007.html [ Failure ]
-imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/001.html [ Failure ]
-imported/w3c/web-platform-tests/html/browsers/history/the-history-interface/joint_session_history/002.html [ Failure ]
-imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/reload_post_1.html [ Failure ]
-imported/w3c/web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-on-new-window.html [ Failure ]
-imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name.html [ Failure ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/event_loadedmetadata.html [ Failure ]
 imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/document-adopt-base-url.html [ ImageOnlyFailure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220331] trunk/Source/WebKit

2017-08-07 Thread clopez

Title: [220331] trunk/Source/WebKit








Revision 220331
Author clo...@igalia.com
Date 2017-08-07 02:53:52 -0700 (Mon, 07 Aug 2017)


Log Message
[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
https://bugs.webkit.org/show_bug.cgi?id=175125

Unreviewed follow-up fix after r220326.

* CMakeLists.txt: Move the block appending to WebKit2_LIBRARIES
below where the list itself is created.

Modified Paths

trunk/Source/WebKit/CMakeLists.txt
trunk/Source/WebKit/ChangeLog




Diff

Modified: trunk/Source/WebKit/CMakeLists.txt (220330 => 220331)

--- trunk/Source/WebKit/CMakeLists.txt	2017-08-07 07:03:06 UTC (rev 220330)
+++ trunk/Source/WebKit/CMakeLists.txt	2017-08-07 09:53:52 UTC (rev 220331)
@@ -90,44 +90,6 @@
 ${ICU_INCLUDE_DIRS}
 )
 
-if (ENABLE_GRAPHICS_CONTEXT_3D)
-# For platforms that want to use system-provided OpenGL (ES) / EGL headers,
-# these include directories, libraries or definitions need to be
-# added before the ANGLE directories.
-if (USE_OPENGL)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGL_INCLUDE_DIRS}
-)
-list(APPEND WebKit2_LIBRARIES
-${OPENGL_LIBRARIES}
-)
-add_definitions(${OPENGL_DEFINITIONS})
-elseif (USE_OPENGL_ES_2)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${OPENGLES2_INCLUDE_DIRS}
-)
-list(APPEND WebKit2_LIBRARIES
-${OPENGLES2_LIBRARIES}
-)
-add_definitions(${OPENGLES2_DEFINITIONS})
-endif ()
-
-if (USE_EGL)
-list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
-${EGL_INCLUDE_DIRS}
-)
-list(APPEND WebKit2_LIBRARIES
-${EGL_LIBRARIES}
-)
-add_definitions(${EGL_DEFINITIONS})
-endif ()
-
-list(APPEND WebKit2_INCLUDE_DIRECTORIES
-"${THIRDPARTY_DIR}/ANGLE"
-"${THIRDPARTY_DIR}/ANGLE/include/KHR"
-)
-endif ()
-
 set(WebKit2_SOURCES
 NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp
 
@@ -736,6 +698,44 @@
 WebKit2
 )
 
+if (ENABLE_GRAPHICS_CONTEXT_3D)
+# For platforms that want to use system-provided OpenGL (ES) / EGL headers,
+# these include directories, libraries or definitions need to be
+# added before the ANGLE directories.
+if (USE_OPENGL)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGL_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${OPENGL_LIBRARIES}
+)
+add_definitions(${OPENGL_DEFINITIONS})
+elseif (USE_OPENGL_ES_2)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${OPENGLES2_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${OPENGLES2_LIBRARIES}
+)
+add_definitions(${OPENGLES2_DEFINITIONS})
+endif ()
+
+if (USE_EGL)
+list(APPEND WebKit2_SYSTEM_INCLUDE_DIRECTORIES
+${EGL_INCLUDE_DIRS}
+)
+list(APPEND WebKit2_LIBRARIES
+${EGL_LIBRARIES}
+)
+add_definitions(${EGL_DEFINITIONS})
+endif ()
+
+list(APPEND WebKit2_INCLUDE_DIRECTORIES
+"${THIRDPARTY_DIR}/ANGLE"
+"${THIRDPARTY_DIR}/ANGLE/include/KHR"
+)
+endif ()
+
 if (WIN32 AND INTERNAL_BUILD)
 set(_javascript_Core_SCRIPTS_DIR "${CMAKE_BINARY_DIR}/../include/private/_javascript_Core/Scripts")
 else ()


Modified: trunk/Source/WebKit/ChangeLog (220330 => 220331)

--- trunk/Source/WebKit/ChangeLog	2017-08-07 07:03:06 UTC (rev 220330)
+++ trunk/Source/WebKit/ChangeLog	2017-08-07 09:53:52 UTC (rev 220331)
@@ -1,3 +1,13 @@
+2017-08-07  Carlos Alberto Lopez Perez  
+
+[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
+https://bugs.webkit.org/show_bug.cgi?id=175125
+
+Unreviewed follow-up fix after r220326.
+
+* CMakeLists.txt: Move the block appending to WebKit2_LIBRARIES
+below where the list itself is created.
+
 2017-08-05  Carlos Garcia Campos  
 
 [GTK][WPE] Add API to provide browser information required by automation






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [220330] trunk/Source/JavaScriptCore

2017-08-07 Thread keith_miller

Title: [220330] trunk/Source/_javascript_Core








Revision 220330
Author keith_mil...@apple.com
Date 2017-08-07 00:03:06 -0700 (Mon, 07 Aug 2017)


Log Message
REGRESSION: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js failing on JSC Debug bots
https://bugs.webkit.org/show_bug.cgi?id=175256

Reviewed by Saam Barati.

The check in createFromBytes just needed to check that the buffer was not null before
calling isCaged.

* runtime/ArrayBuffer.cpp:
(JSC::ArrayBuffer::createFromBytes):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (220329 => 220330)

--- trunk/Source/_javascript_Core/ChangeLog	2017-08-07 06:06:34 UTC (rev 220329)
+++ trunk/Source/_javascript_Core/ChangeLog	2017-08-07 07:03:06 UTC (rev 220330)
@@ -1,3 +1,16 @@
+2017-08-07  Keith Miller  
+
+REGRESSION: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js failing on JSC Debug bots
+https://bugs.webkit.org/show_bug.cgi?id=175256
+
+Reviewed by Saam Barati.
+
+The check in createFromBytes just needed to check that the buffer was not null before
+calling isCaged.
+
+* runtime/ArrayBuffer.cpp:
+(JSC::ArrayBuffer::createFromBytes):
+
 2017-08-05  Carlos Garcia Campos  
 
 [GTK][WPE] Add API to provide browser information required by automation


Modified: trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp (220329 => 220330)

--- trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp	2017-08-07 06:06:34 UTC (rev 220329)
+++ trunk/Source/_javascript_Core/runtime/ArrayBuffer.cpp	2017-08-07 07:03:06 UTC (rev 220330)
@@ -198,7 +198,7 @@
 // - WebAssembly. Wasm should allocate from the cage.
 Ref ArrayBuffer::createFromBytes(const void* data, unsigned byteLength, ArrayBufferDestructorFunction&& destructor)
 {
-if (!Gigacage::isCaged(data) && data && byteLength)
+if (data && byteLength && !Gigacage::isCaged(data))
 Gigacage::disableGigacage();
 
 ArrayBufferContents contents(const_cast(data), byteLength, WTFMove(destructor));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

54 matches

Mail list logo