[webkit-changes] [231130] trunk/Source

[ddkilzer]

Title: [231130] trunk/Source








Revision 231130
Author ddkil...@apple.com
Date 2018-04-27 22:53:03 -0700 (Fri, 27 Apr 2018)


Log Message
Add logging when SpringBoard enables WebThread



Reviewed by Daniel Bates.

Source/WebCore:

* platform/RuntimeApplicationChecks.h:
(WebCore::IOSApplication::isSpringBoard): Add declaration.
* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
(WebCore::IOSApplication::isSpringBoard): Add implementation.
* platform/ios/wak/WebCoreThread.mm:
(WebThreadEnable): Call RELEASE_LOG_FAULT() if this is called by
SpringBoard.

Source/WTF:

* wtf/Assertions.h:
(RELEASE_LOG_FAULT): Add macro to call os_log_fault().
* wtf/Platform.h: Drive-by fix to enable USE(OS_LOG) on
public iOS SDKs since  was
fixed in iOS 11.0.

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Assertions.h
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/RuntimeApplicationChecks.h
trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm
trunk/Source/WebCore/platform/ios/wak/WebCoreThread.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (231129 => 231130)

--- trunk/Source/WTF/ChangeLog	2018-04-28 03:32:24 UTC (rev 231129)
+++ trunk/Source/WTF/ChangeLog	2018-04-28 05:53:03 UTC (rev 231130)
@@ -1,3 +1,17 @@
+2018-04-27  David Kilzer  
+
+Add logging when SpringBoard enables WebThread
+
+
+
+Reviewed by Daniel Bates.
+
+* wtf/Assertions.h:
+(RELEASE_LOG_FAULT): Add macro to call os_log_fault().
+* wtf/Platform.h: Drive-by fix to enable USE(OS_LOG) on
+public iOS SDKs since  was
+fixed in iOS 11.0.
+
 2018-04-26  Mark Lam  
 
 Gardening: Speculative build fix for Windows.


Modified: trunk/Source/WTF/wtf/Assertions.h (231129 => 231130)

--- trunk/Source/WTF/wtf/Assertions.h	2018-04-28 03:32:24 UTC (rev 231129)
+++ trunk/Source/WTF/wtf/Assertions.h	2018-04-28 05:53:03 UTC (rev 231130)
@@ -445,6 +445,7 @@
 #if RELEASE_LOG_DISABLED
 #define RELEASE_LOG(channel, ...) ((void)0)
 #define RELEASE_LOG_ERROR(channel, ...) LOG_ERROR(__VA_ARGS__)
+#define RELEASE_LOG_FAULT(channel, ...) LOG_ERROR(__VA_ARGS__)
 
 #define RELEASE_LOG_IF(isAllowed, channel, ...) ((void)0)
 #define RELEASE_LOG_ERROR_IF(isAllowed, channel, ...) do { if (isAllowed) RELEASE_LOG_ERROR(channel, __VA_ARGS__); } while (0)
@@ -454,6 +455,7 @@
 #else
 #define RELEASE_LOG(channel, ...) os_log(LOG_CHANNEL(channel).osLogChannel, __VA_ARGS__)
 #define RELEASE_LOG_ERROR(channel, ...) os_log_error(LOG_CHANNEL(channel).osLogChannel, __VA_ARGS__)
+#define RELEASE_LOG_FAULT(channel, ...) os_log_fault(LOG_CHANNEL(channel).osLogChannel, __VA_ARGS__)
 #define RELEASE_LOG_INFO(channel, ...) os_log_info(LOG_CHANNEL(channel).osLogChannel, __VA_ARGS__)
 
 #define RELEASE_LOG_IF(isAllowed, channel, ...) do { if (isAllowed) RELEASE_LOG(  channel, __VA_ARGS__); } while (0)


Modified: trunk/Source/WTF/wtf/Platform.h (231129 => 231130)

--- trunk/Source/WTF/wtf/Platform.h	2018-04-28 03:32:24 UTC (rev 231129)
+++ trunk/Source/WTF/wtf/Platform.h	2018-04-28 05:53:03 UTC (rev 231130)
@@ -1263,8 +1263,7 @@
 #define USE_MEDIATOOLBOX 1
 #endif
 
-/* FIXME: Enable USE_OS_LOG when building with the public iOS 10 SDK once we fix . */
-#if PLATFORM(MAC) || (PLATFORM(IOS) && USE(APPLE_INTERNAL_SDK))
+#if PLATFORM(MAC) || PLATFORM(IOS)
 #define USE_OS_LOG 1
 #if USE(APPLE_INTERNAL_SDK)
 #define USE_OS_STATE 1


Modified: trunk/Source/WebCore/ChangeLog (231129 => 231130)

--- trunk/Source/WebCore/ChangeLog	2018-04-28 03:32:24 UTC (rev 231129)
+++ trunk/Source/WebCore/ChangeLog	2018-04-28 05:53:03 UTC (rev 231130)
@@ -1,3 +1,19 @@
+2018-04-27  David Kilzer  
+
+Add logging when SpringBoard enables WebThread
+
+
+
+Reviewed by Daniel Bates.
+
+* platform/RuntimeApplicationChecks.h:
+(WebCore::IOSApplication::isSpringBoard): Add declaration.
+* platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+(WebCore::IOSApplication::isSpringBoard): Add implementation.
+* platform/ios/wak/WebCoreThread.mm:
+(WebThreadEnable): Call RELEASE_LOG_FAULT() if this is called by
+SpringBoard.
+
 2018-04-27  Keith Rollin  
 
 Fix crash in DocumentLoader::startLoadingMainResource


Modified: trunk/Source/WebCore/platform/RuntimeApplicationChecks.h (231129 => 231130)

--- trunk/Source/WebCore/platform/RuntimeApplicationChecks.h	2018-04-28 03:32:24 UTC (rev 231129)
+++ trunk/Source/WebCore/platform/RuntimeApplicationChecks.h	2018-04-28 05:53:03 UTC (rev 231130)
@@ -78,6 +78,7 @@
 WEBCORE_EXPORT bool isWebBookmarksD();
 bool isDumpRenderTree();
 bool isMobileStore();
+bool isSpringBoard();
 WEBCORE_EXPORT bool isWebApp();
 WEBCORE_EXPORT bool isWebProcess();
 bool isIBooks();


Modified: trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (231129 => 231130)

--- 

[webkit-changes] [231129] trunk/Source/JavaScriptCore

[jfbastien]

Title: [231129] trunk/Source/_javascript_Core








Revision 231129
Author jfbast...@apple.com
Date 2018-04-27 20:32:24 -0700 (Fri, 27 Apr 2018)


Log Message
Make the first 64 bits of JSString look like a double JSValue
https://bugs.webkit.org/show_bug.cgi?id=185081

Reviewed by Filip Pizlo.

We can be clever about how we lay out JSString so that, were it
reinterpreted as a JSValue, it would look like a double.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::and16):
* assembler/X86Assembler.h:
(JSC::X86Assembler::andw_mr):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileMakeRope):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
* ftl/FTLOutput.h:
(JSC::FTL::Output::store32As8):
(JSC::FTL::Output::store32As16):
* runtime/JSString.h:
(JSC::JSString::JSString):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h
trunk/Source/_javascript_Core/assembler/X86Assembler.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/ftl/FTLOutput.h
trunk/Source/_javascript_Core/runtime/JSString.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (231128 => 231129)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-28 01:09:11 UTC (rev 231128)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-28 03:32:24 UTC (rev 231129)
@@ -1,3 +1,27 @@
+2018-04-27  JF Bastien  
+
+Make the first 64 bits of JSString look like a double JSValue
+https://bugs.webkit.org/show_bug.cgi?id=185081
+
+Reviewed by Filip Pizlo.
+
+We can be clever about how we lay out JSString so that, were it
+reinterpreted as a JSValue, it would look like a double.
+
+* assembler/MacroAssemblerX86Common.h:
+(JSC::MacroAssemblerX86Common::and16):
+* assembler/X86Assembler.h:
+(JSC::X86Assembler::andw_mr):
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileMakeRope):
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
+* ftl/FTLOutput.h:
+(JSC::FTL::Output::store32As8):
+(JSC::FTL::Output::store32As16):
+* runtime/JSString.h:
+(JSC::JSString::JSString):
+
 2018-04-27  Yusuke Suzuki  
 
 [JSC][ARM64][Linux] Add collectCPUFeatures using auxiliary vector


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h (231128 => 231129)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h	2018-04-28 01:09:11 UTC (rev 231128)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h	2018-04-28 03:32:24 UTC (rev 231129)
@@ -372,6 +372,12 @@
 and32(dataTempRegister, dest);
 }
 
+void and16(Address src, RegisterID dest)
+{
+load16(src, getCachedDataTempRegisterIDAndInvalidate());
+and32(dataTempRegister, dest);
+}
+
 void and64(RegisterID src1, RegisterID src2, RegisterID dest)
 {
 m_assembler.and_<64>(dest, src1, src2);


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h (231128 => 231129)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h	2018-04-28 01:09:11 UTC (rev 231128)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h	2018-04-28 03:32:24 UTC (rev 231129)
@@ -290,6 +290,16 @@
 m_assembler.andl_mr(src.offset, src.base, src.index, src.scale, dest);
 }
 
+void and16(Address src, RegisterID dest)
+{
+m_assembler.andw_mr(src.offset, src.base, dest);
+}
+
+void and16(BaseIndex src, RegisterID dest)
+{
+m_assembler.andw_mr(src.offset, src.base, src.index, src.scale, dest);
+}
+
 void and32(TrustedImm32 imm, Address address)
 {
 m_assembler.andl_im(imm.m_value, address.offset, address.base);


Modified: trunk/Source/_javascript_Core/assembler/X86Assembler.h (231128 => 231129)

--- trunk/Source/_javascript_Core/assembler/X86Assembler.h	2018-04-28 01:09:11 UTC (rev 231128)
+++ trunk/Source/_javascript_Core/assembler/X86Assembler.h	2018-04-28 03:32:24 UTC (rev 231129)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2018 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -685,6 +685,18 @@
 m_formatter.oneByteOp(OP_AND_GvEv, dst, base, index, scale, offset);
 }
 
+void andw_mr(int offset, RegisterID base, RegisterID dst)
+{
+m_formatter.prefix(PRE_OPERAND_SIZE);
+andl_mr(offset, base, dst);
+}
+
+void andw_mr(int offset, RegisterID base, RegisterID index, int scale, RegisterID dst)
+{
+

[webkit-changes] [231128] trunk/Source/WebCore

[krollin]

Title: [231128] trunk/Source/WebCore








Revision 231128
Author krol...@apple.com
Date 2018-04-27 18:09:11 -0700 (Fri, 27 Apr 2018)


Log Message
Fix crash in DocumentLoader::startLoadingMainResource
https://bugs.webkit.org/show_bug.cgi?id=185088
rdar://problem/39689263

Reviewed by Chris Dumez.

Add a "protectedThis" to address a case where a deleted "this" was
accessed in a RELEASE_LOG statement.

No new tests -- covered by existing tests, which now pass.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (231127 => 231128)

--- trunk/Source/WebCore/ChangeLog	2018-04-28 00:53:41 UTC (rev 231127)
+++ trunk/Source/WebCore/ChangeLog	2018-04-28 01:09:11 UTC (rev 231128)
@@ -1,3 +1,19 @@
+2018-04-27  Keith Rollin  
+
+Fix crash in DocumentLoader::startLoadingMainResource
+https://bugs.webkit.org/show_bug.cgi?id=185088
+rdar://problem/39689263
+
+Reviewed by Chris Dumez.
+
+Add a "protectedThis" to address a case where a deleted "this" was
+accessed in a RELEASE_LOG statement.
+
+No new tests -- covered by existing tests, which now pass.
+
+* loader/DocumentLoader.cpp:
+(WebCore::DocumentLoader::startLoadingMainResource):
+
 2018-04-27  Simon Fraser  
 
 Implement color-filter for text stroke


Modified: trunk/Source/WebCore/loader/DocumentLoader.cpp (231127 => 231128)

--- trunk/Source/WebCore/loader/DocumentLoader.cpp	2018-04-28 00:53:41 UTC (rev 231127)
+++ trunk/Source/WebCore/loader/DocumentLoader.cpp	2018-04-28 01:09:11 UTC (rev 231128)
@@ -1674,6 +1674,8 @@
 ASSERT(!m_loadingMainResource);
 m_loadingMainResource = true;
 
+Ref protectedThis(*this);
+
 if (maybeLoadEmpty()) {
 RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Returning empty document (frame = %p, main = %d)", m_frame, m_frame ? m_frame->isMainFrame() : false);
 return;
@@ -1694,7 +1696,7 @@
 ASSERT(timing().startTime());
 ASSERT(timing().fetchStart());
 
-willSendRequest(ResourceRequest(m_request), ResourceResponse(), shouldContinue, [this, protectedThis = makeRef(*this)] (ResourceRequest&& request) mutable {
+willSendRequest(ResourceRequest(m_request), ResourceResponse(), shouldContinue, [this, protectedThis = WTFMove(protectedThis)] (ResourceRequest&& request) mutable {
 m_request = request;
 
 // willSendRequest() may lead to our Frame being detached or cancelling the load via nulling the ResourceRequest.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231127] trunk/LayoutTests

[ryanhaddad]

Title: [231127] trunk/LayoutTests








Revision 231127
Author ryanhad...@apple.com
Date 2018-04-27 17:53:41 -0700 (Fri, 27 Apr 2018)


Log Message
Unreviewed test gardening for iOS and macOS.

* platform/ios-wk2/TestExpectations:
* platform/ios/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/ios-wk2/TestExpectations
trunk/LayoutTests/platform/mac-wk1/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231126 => 231127)

--- trunk/LayoutTests/ChangeLog	2018-04-28 00:52:13 UTC (rev 231126)
+++ trunk/LayoutTests/ChangeLog	2018-04-28 00:53:41 UTC (rev 231127)
@@ -1,3 +1,12 @@
+2018-04-27  Ryan Haddad  
+
+Unreviewed test gardening for iOS and macOS.
+
+* platform/ios-wk2/TestExpectations:
+* platform/ios/TestExpectations:
+* platform/mac-wk1/TestExpectations:
+* platform/mac-wk2/TestExpectations:
+
 2018-04-27  Simon Fraser  
 
 Clean up color-filter tests.


Modified: trunk/LayoutTests/platform/ios/TestExpectations (231126 => 231127)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-04-28 00:52:13 UTC (rev 231126)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-04-28 00:53:41 UTC (rev 231127)
@@ -3295,3 +3295,5 @@
 webkit.org/b/184787 http/wpt/cache-storage/cache-quota.any.html [ Pass Failure ]
 
 webkit.org/b/180260 http/wpt/resource-timing/rt-resources-per-worker.html [ Pass Failure ]
+
+webkit.org/b/185028 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-request-redirect.https.html [ Failure ]


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (231126 => 231127)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-04-28 00:52:13 UTC (rev 231126)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-04-28 00:53:41 UTC (rev 231127)
@@ -1321,7 +1321,7 @@
 
 webkit.org/b/177501 webrtc/video-mute.html [ Pass Timeout ]
 
-webkit.org/b/172397 [ Debug ] legacy-animation-engine/animations/needs-layout.html [ Pass ImageOnlyFailure ]
+webkit.org/b/172397 legacy-animation-engine/animations/needs-layout.html [ Pass ImageOnlyFailure ]
 
 webkit.org/b/179176 [ Release ] svg/wicd/test-rightsizing-a.xhtml [ Pass Failure ]
 


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (231126 => 231127)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-04-28 00:52:13 UTC (rev 231126)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2018-04-28 00:53:41 UTC (rev 231127)
@@ -546,3 +546,5 @@
 webkit.org/b/184569 [ Debug ] animations/missing-from-to.html [ Skip ]
 
 webkit.org/b/184457 media/video-aspect-ratio.html [ Pass Failure ]
+
+webkit.org/b/184458 media/remote-control-command-is-user-gesture.html [ Pass Timeout ]


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (231126 => 231127)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-28 00:52:13 UTC (rev 231126)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-28 00:53:41 UTC (rev 231127)
@@ -730,7 +730,7 @@
 
 webkit.org/b/167757 workers/bomb.html [ Pass Timeout ]
 
-webkit.org/b/172397 [ Debug ] legacy-animation-engine/animations/needs-layout.html [ Pass ImageOnlyFailure ]
+webkit.org/b/172397 legacy-animation-engine/animations/needs-layout.html [ Pass ImageOnlyFailure ]
 
 # Touch events are not available on open source bots, thus only tested on Mac.
 http/tests/resourceLoadStatistics/user-interaction-in-cross-origin-sub-frame.html [ Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231126] trunk/Source/WebKit

[timothy]

Title: [231126] trunk/Source/WebKit








Revision 231126
Author timo...@apple.com
Date 2018-04-27 17:52:13 -0700 (Fri, 27 Apr 2018)


Log Message
REGRESSION: Touch events fail to dispatch to the page in all cases.

https://bugs.webkit.org/show_bug.cgi?id=185097
rdar://problem/39731995

Reviewed by Tim Horton.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
Consult internal gesture recognizers, otherwise NO might get returned.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (231125 => 231126)

--- trunk/Source/WebKit/ChangeLog	2018-04-28 00:27:39 UTC (rev 231125)
+++ trunk/Source/WebKit/ChangeLog	2018-04-28 00:52:13 UTC (rev 231126)
@@ -1,3 +1,16 @@
+2018-04-27  Timothy Hatcher  
+
+REGRESSION: Touch events fail to dispatch to the page in all cases.
+
+https://bugs.webkit.org/show_bug.cgi?id=185097
+rdar://problem/39731995
+
+Reviewed by Tim Horton.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
+Consult internal gesture recognizers, otherwise NO might get returned.
+
 2018-04-26  Ryosuke Niwa  
 
 PSON: Triggering a navigation to an invalid URL creates a new WebContent process


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (231125 => 231126)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-04-28 00:27:39 UTC (rev 231125)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-04-28 00:52:13 UTC (rev 231126)
@@ -1334,6 +1334,11 @@
 
 - (BOOL)gestureRecognizer:(UIGestureRecognizer *)gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:(UIGestureRecognizer*)otherGestureRecognizer
 {
+#if USE(APPLE_INTERNAL_SDK)
+if ([self _internalGestureRecognizer:gestureRecognizer shouldRecognizeSimultaneouslyWithGestureRecognizer:otherGestureRecognizer])
+return YES;
+#endif
+
 if (isSamePair(gestureRecognizer, otherGestureRecognizer, _highlightLongPressGestureRecognizer.get(), _longPressGestureRecognizer.get()))
 return YES;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231123] trunk

[simon . fraser]

Title: [231123] trunk








Revision 231123
Author simon.fra...@apple.com
Date 2018-04-27 17:27:29 -0700 (Fri, 27 Apr 2018)


Log Message
Implement animation for color-filter
https://bugs.webkit.org/show_bug.cgi?id=185092
rdar://problem/39773810

Reviewed by Tim Horton.

Source/WebCore:

Implement animation of color-filter.

This requires tracking whether the color-filter function lists match for both old and new
animation code paths.

The filter-related ProperyWappers in CSSPropertyAnimation are cleaned up to use a single wrapper,
which has to pass the propertyID to the blend function so we know which "lists match" to check.
This wrapper reports that its accelerated for filter and backdrop-filter, but not color-filter.

Test: css3/color-filters/color-filter-animation.html

* animation/CSSPropertyBlendingClient.h:
* animation/KeyframeEffectReadOnly.cpp:
(WebCore::KeyframeEffectReadOnly::setBlendingKeyframes):
(WebCore::KeyframeEffectReadOnly::checkForMatchingColorFilterFunctionLists):
* animation/KeyframeEffectReadOnly.h:
* page/animation/AnimationBase.h:
* page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc):
(WebCore::PropertyWrapperFilter::PropertyWrapperFilter):
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
(WebCore::PropertyWrapperAcceleratedFilter::PropertyWrapperAcceleratedFilter): Deleted.
(WebCore::PropertyWrapperAcceleratedBackdropFilter::PropertyWrapperAcceleratedBackdropFilter): Deleted.
(WebCore::PropertyWrapperAcceleratedBackdropFilter::animationIsAccelerated const): Deleted.
(WebCore::PropertyWrapperAcceleratedBackdropFilter::blend const): Deleted.
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::reset):
(WebCore::ImplicitAnimation::checkForMatchingColorFilterFunctionLists):
* page/animation/ImplicitAnimation.h:
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::KeyframeAnimation):
(WebCore::KeyframeAnimation::checkForMatchingColorFilterFunctionLists):
* page/animation/KeyframeAnimation.h:

LayoutTests:

Fix the testing to recognize unprefixed filter, and color-filter.

Add a color-filter animation test.

* animations/resources/animation-test-helpers.js:
(getPropertyValue):
(comparePropertyValue):
* css3/color-filters/color-filter-animation-expected.txt: Added.
* css3/color-filters/color-filter-animation.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/animations/resources/animation-test-helpers.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyBlendingClient.h
trunk/Source/WebCore/animation/KeyframeEffectReadOnly.cpp
trunk/Source/WebCore/animation/KeyframeEffectReadOnly.h
trunk/Source/WebCore/page/animation/AnimationBase.h
trunk/Source/WebCore/page/animation/CSSPropertyAnimation.cpp
trunk/Source/WebCore/page/animation/ImplicitAnimation.cpp
trunk/Source/WebCore/page/animation/ImplicitAnimation.h
trunk/Source/WebCore/page/animation/KeyframeAnimation.cpp
trunk/Source/WebCore/page/animation/KeyframeAnimation.h


Added Paths

trunk/LayoutTests/css3/color-filters/color-filter-animation-expected.txt
trunk/LayoutTests/css3/color-filters/color-filter-animation.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231122 => 231123)

--- trunk/LayoutTests/ChangeLog	2018-04-28 00:21:55 UTC (rev 231122)
+++ trunk/LayoutTests/ChangeLog	2018-04-28 00:27:29 UTC (rev 231123)
@@ -1,3 +1,21 @@
+2018-04-27  Simon Fraser  
+
+Implement animation for color-filter
+https://bugs.webkit.org/show_bug.cgi?id=185092
+rdar://problem/39773810
+
+Reviewed by Tim Horton.
+
+Fix the testing to recognize unprefixed filter, and color-filter.
+
+Add a color-filter animation test.
+
+* animations/resources/animation-test-helpers.js:
+(getPropertyValue):
+(comparePropertyValue):
+* css3/color-filters/color-filter-animation-expected.txt: Added.
+* css3/color-filters/color-filter-animation.html: Added.
+
 2018-04-27  Ryan Haddad  
 
 Update TestExpectations for fast/loader/submit-form-while-parsing-2.html.


Modified: trunk/LayoutTests/animations/resources/animation-test-helpers.js (231122 => 231123)

--- trunk/LayoutTests/animations/resources/animation-test-helpers.js	2018-04-28 00:21:55 UTC (rev 231122)
+++ trunk/LayoutTests/animations/resources/animation-test-helpers.js	2018-04-28 00:27:29 UTC (rev 231123)
@@ -430,6 +430,8 @@
|| property == "listStyleImage"
|| property == "webkitMaskImage"
|| property == "webkitMaskBoxImage"
+   || property == "filter"
+   || property == "colorFilter"
|| property == "webkitFilter"
|| property == "webkitBackdropFilter"
|| property == "webkitClipPath"
@@ -469,7 +471,7 @@
 break;
 }
 }
-} else if (property == "webkitFilter" || property == 

[webkit-changes] [231125] trunk/LayoutTests

[simon . fraser]

Title: [231125] trunk/LayoutTests








Revision 231125
Author simon.fra...@apple.com
Date 2018-04-27 17:27:39 -0700 (Fri, 27 Apr 2018)


Log Message
Clean up color-filter tests.

Detab the files.

Remove calls to internals.settings.setColorFilterEnabled() which aren't needed, since
WebKitTestRunner and DumpRenderTree turn the feature on by default.

* css3/color-filters/color-filter-backgrounds-borders-expected.html:
* css3/color-filters/color-filter-backgrounds-borders.html:
* css3/color-filters/color-filter-box-shadow-expected.html:
* css3/color-filters/color-filter-box-shadow.html:
* css3/color-filters/color-filter-brightness-expected.html:
* css3/color-filters/color-filter-brightness.html:
* css3/color-filters/color-filter-color-property-expected.html:
* css3/color-filters/color-filter-color-property-list-item-expected.html:
* css3/color-filters/color-filter-color-property-list-item.html:
* css3/color-filters/color-filter-color-property.html:
* css3/color-filters/color-filter-color-text-decorations-expected.html:
* css3/color-filters/color-filter-color-text-decorations.html:
* css3/color-filters/color-filter-column-rule-expected.html:
* css3/color-filters/color-filter-column-rule.html:
* css3/color-filters/color-filter-contrast-expected.html:
* css3/color-filters/color-filter-contrast.html:
* css3/color-filters/color-filter-current-color-expected.html:
* css3/color-filters/color-filter-current-color.html:
* css3/color-filters/color-filter-filter-list-expected.html:
* css3/color-filters/color-filter-filter-list.html:
* css3/color-filters/color-filter-gradients-expected.html:
* css3/color-filters/color-filter-gradients.html:
* css3/color-filters/color-filter-grayscale-expected.html:
* css3/color-filters/color-filter-grayscale.html:
* css3/color-filters/color-filter-hue-rotate-expected.html:
* css3/color-filters/color-filter-hue-rotate.html:
* css3/color-filters/color-filter-inherits-expected.html:
* css3/color-filters/color-filter-inherits.html:
* css3/color-filters/color-filter-invert-expected.html:
* css3/color-filters/color-filter-invert.html:
* css3/color-filters/color-filter-opacity-expected.html:
* css3/color-filters/color-filter-opacity.html:
* css3/color-filters/color-filter-outline-expected.html:
* css3/color-filters/color-filter-outline.html:
* css3/color-filters/color-filter-parsing.html:
* css3/color-filters/color-filter-saturate-expected.html:
* css3/color-filters/color-filter-saturate.html:
* css3/color-filters/color-filter-sepia-expected.html:
* css3/color-filters/color-filter-sepia.html:
* css3/color-filters/color-filter-text-decoration-shadow-expected.html:
* css3/color-filters/color-filter-text-decoration-shadow.html:
* css3/color-filters/color-filter-text-emphasis-expected.html:
* css3/color-filters/color-filter-text-emphasis.html:
* css3/color-filters/color-filter-text-shadow-expected.html:
* css3/color-filters/color-filter-text-shadow.html:
* css3/color-filters/color-filter-text-stroke.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/color-filters/color-filter-backgrounds-borders-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-backgrounds-borders.html
trunk/LayoutTests/css3/color-filters/color-filter-box-shadow-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-box-shadow.html
trunk/LayoutTests/css3/color-filters/color-filter-brightness-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-brightness.html
trunk/LayoutTests/css3/color-filters/color-filter-color-property-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-color-property-list-item-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-color-property-list-item.html
trunk/LayoutTests/css3/color-filters/color-filter-color-property.html
trunk/LayoutTests/css3/color-filters/color-filter-color-text-decorations-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-color-text-decorations.html
trunk/LayoutTests/css3/color-filters/color-filter-column-rule-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-column-rule.html
trunk/LayoutTests/css3/color-filters/color-filter-contrast-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-contrast.html
trunk/LayoutTests/css3/color-filters/color-filter-current-color-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-current-color.html
trunk/LayoutTests/css3/color-filters/color-filter-filter-list-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-filter-list.html
trunk/LayoutTests/css3/color-filters/color-filter-gradients-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-gradients.html
trunk/LayoutTests/css3/color-filters/color-filter-grayscale-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-grayscale.html
trunk/LayoutTests/css3/color-filters/color-filter-hue-rotate-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-hue-rotate.html

[webkit-changes] [231124] trunk

[simon . fraser]

Title: [231124] trunk








Revision 231124
Author simon.fra...@apple.com
Date 2018-04-27 17:27:32 -0700 (Fri, 27 Apr 2018)


Log Message
Implement color-filter for text stroke
https://bugs.webkit.org/show_bug.cgi?id=185098

Reviewed by Alan Bujtas.
Source/WebCore:

Transform the text stroke color through color-filter.

Test: css3/color-filters/color-filter-text-stroke.html

* rendering/TextPaintStyle.cpp:
(WebCore::computeTextPaintStyle):

LayoutTests:

* css3/color-filters/color-filter-text-stroke-expected.html: Added.
* css3/color-filters/color-filter-text-stroke.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/TextPaintStyle.cpp


Added Paths

trunk/LayoutTests/css3/color-filters/color-filter-text-stroke-expected.html
trunk/LayoutTests/css3/color-filters/color-filter-text-stroke.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231123 => 231124)

--- trunk/LayoutTests/ChangeLog	2018-04-28 00:27:29 UTC (rev 231123)
+++ trunk/LayoutTests/ChangeLog	2018-04-28 00:27:32 UTC (rev 231124)
@@ -1,5 +1,15 @@
 2018-04-27  Simon Fraser  
 
+Implement color-filter for text stroke
+https://bugs.webkit.org/show_bug.cgi?id=185098
+
+Reviewed by Alan Bujtas.
+
+* css3/color-filters/color-filter-text-stroke-expected.html: Added.
+* css3/color-filters/color-filter-text-stroke.html: Added.
+
+2018-04-27  Simon Fraser  
+
 Implement animation for color-filter
 https://bugs.webkit.org/show_bug.cgi?id=185092
 rdar://problem/39773810


Added: trunk/LayoutTests/css3/color-filters/color-filter-text-stroke-expected.html (0 => 231124)

--- trunk/LayoutTests/css3/color-filters/color-filter-text-stroke-expected.html	(rev 0)
+++ trunk/LayoutTests/css3/color-filters/color-filter-text-stroke-expected.html	2018-04-28 00:27:32 UTC (rev 231124)
@@ -0,0 +1,19 @@
+
+
+
+CSS Test: color-filter reference
+
+.test
+{
+margin: 50px 20px;
+font: 120px Ahem;
+color: green;
+}
+
+
+
+O
+O
+
+


Added: trunk/LayoutTests/css3/color-filters/color-filter-text-stroke.html (0 => 231124)

--- trunk/LayoutTests/css3/color-filters/color-filter-text-stroke.html	(rev 0)
+++ trunk/LayoutTests/css3/color-filters/color-filter-text-stroke.html	2018-04-28 00:27:32 UTC (rev 231124)
@@ -0,0 +1,27 @@
+
+
+
+CSS Test: color-filter affects text stroke
+
+
+.test
+{
+margin: 50px 20px;
+font: 120px Ahem;
+color: rgb(255, 128, 255);
+color-filter: invert();
+}
+
+
+if (window.internals)
+internals.settings.setColorFilterEnabled(true);
+
+
+
+O
+O
+
+


Modified: trunk/Source/WebCore/ChangeLog (231123 => 231124)

--- trunk/Source/WebCore/ChangeLog	2018-04-28 00:27:29 UTC (rev 231123)
+++ trunk/Source/WebCore/ChangeLog	2018-04-28 00:27:32 UTC (rev 231124)
@@ -1,5 +1,19 @@
 2018-04-27  Simon Fraser  
 
+Implement color-filter for text stroke
+https://bugs.webkit.org/show_bug.cgi?id=185098
+
+Reviewed by Alan Bujtas.
+
+Transform the text stroke color through color-filter.
+
+Test: css3/color-filters/color-filter-text-stroke.html
+
+* rendering/TextPaintStyle.cpp:
+(WebCore::computeTextPaintStyle):
+
+2018-04-27  Simon Fraser  
+
 Implement animation for color-filter
 https://bugs.webkit.org/show_bug.cgi?id=185092
 rdar://problem/39773810


Modified: trunk/Source/WebCore/rendering/TextPaintStyle.cpp (231123 => 231124)

--- trunk/Source/WebCore/rendering/TextPaintStyle.cpp	2018-04-28 00:27:29 UTC (rev 231123)
+++ trunk/Source/WebCore/rendering/TextPaintStyle.cpp	2018-04-28 00:27:32 UTC (rev 231124)
@@ -120,7 +120,7 @@
 if (forceBackgroundToWhite)
 paintStyle.fillColor = adjustColorForVisibilityOnBackground(paintStyle.fillColor, Color::white);
 
-paintStyle.strokeColor = lineStyle.computedStrokeColor();
+paintStyle.strokeColor = lineStyle.colorByApplyingColorFilter(lineStyle.computedStrokeColor());
 
 // Make the text stroke color legible against a white background
 if (forceBackgroundToWhite)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231122] trunk/Tools

[commit-queue]

Title: [231122] trunk/Tools








Revision 231122
Author commit-qu...@webkit.org
Date 2018-04-27 17:21:55 -0700 (Fri, 27 Apr 2018)


Log Message
[WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
https://bugs.webkit.org/show_bug.cgi?id=185049

Patch by Stephan Szabo  on 2018-04-27
Reviewed by Keith Miller.

* Scripts/run-_javascript_core-tests:
(runJSCStressTests):
* Scripts/run-jsc-stress-tests:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-_javascript_core-tests
trunk/Tools/Scripts/run-jsc-stress-tests




Diff

Modified: trunk/Tools/ChangeLog (231121 => 231122)

--- trunk/Tools/ChangeLog	2018-04-28 00:07:38 UTC (rev 231121)
+++ trunk/Tools/ChangeLog	2018-04-28 00:21:55 UTC (rev 231122)
@@ -1,3 +1,14 @@
+2018-04-27  Stephan Szabo  
+
+[WinCairo] Support --no-copy for jsc tests in wincairo tests, add copying of dlls for copy case
+https://bugs.webkit.org/show_bug.cgi?id=185049
+
+Reviewed by Keith Miller.
+
+* Scripts/run-_javascript_core-tests:
+(runJSCStressTests):
+* Scripts/run-jsc-stress-tests:
+
 2018-04-26  Ryosuke Niwa  
 
 PSON: Triggering a navigation to an invalid URL creates a new WebContent process


Modified: trunk/Tools/Scripts/run-_javascript_core-tests (231121 => 231122)

--- trunk/Tools/Scripts/run-_javascript_core-tests	2018-04-28 00:07:38 UTC (rev 231121)
+++ trunk/Tools/Scripts/run-_javascript_core-tests	2018-04-28 00:21:55 UTC (rev 231122)
@@ -58,6 +58,7 @@
 my $memoryLimited;
 
 my $buildJSC = 1;
+my $copyJSC = 1;
 
 use constant {
 ENV_VAR_SAYS_DO_RUN => 4,
@@ -148,6 +149,17 @@
 }
 }
 
+if ($ENV{RUN_JAVASCRIPTCORE_TESTS_COPY}) {
+if ($ENV{RUN_JAVASCRIPTCORE_TESTS_COPY} eq "true") {
+$copyJSC = 1;
+} elsif ($ENV{RUN_JAVASCRIPTCORE_TESTS_COPY} eq "false") {
+$copyJSC = 0;
+} else {
+print "Don't recognize value for RUN_JAVASCRIPTCORE_TESTS_COPY environment variable: '"
+. $ENV{RUN_JAVASCRIPTCORE_TESTS_COPY} . "'. Should be set to 'true' or 'false'.\n";
+}
+}
+
 if ($ENV{RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS}) {
 push @extraTests, $ENV{RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS};
 }
@@ -174,6 +186,7 @@
 my $jitStressTestsDefault = $runJITStressTests ? "will run" : " will not run";
 my $quickModeDefault = $runQuickMode ? "some" : "all";
 my $failFastDefault = $failFast ? "fail fast" : "don't fail fast";
+my $copyJSCDefault = $copyJSC ? "copy" : "do not copy";
 my $filter;
 my $usage = < \$runQuickMode,
 'fail-fast!' => \$failFast,
 'force-collectContinuously!' => \$forceCollectContinuously,
+'copy!' => \$copyJSC,
 'json-output=s' => \$jsonFileName,
 'tarball!' => \$createTarball,
 'remote=s' => \$remoteHost,
@@ -437,6 +452,10 @@
 push(@jscStressDriverCmd, "--debug");
 }
 
+if (!$copyJSC) {
+push(@jscStressDriverCmd, "--no-copy");
+}
+
 if ($forceCollectContinuously) {
 push(@jscStressDriverCmd, "--force-collectContinuously");
 }


Modified: trunk/Tools/Scripts/run-jsc-stress-tests (231121 => 231122)

--- trunk/Tools/Scripts/run-jsc-stress-tests	2018-04-28 00:07:38 UTC (rev 231121)
+++ trunk/Tools/Scripts/run-jsc-stress-tests	2018-04-28 00:21:55 UTC (rev 231122)
@@ -1579,7 +1579,7 @@
 
 if $doNotMessWithVMPath
 if !$remote and !$tarball
-$testingFrameworkPath = frameworkFromJSCPath($jscPath).realpath
+$testingFrameworkPath = (frameworkFromJSCPath($jscPath) || $jscPath.dirname).realpath
 $jscPath = Pathname.new($jscPath).realpath
 else
 $testingFrameworkPath = frameworkFromJSCPath($jscPath)
@@ -1599,7 +1599,19 @@
 destination = Pathname.new(".vm")
 elsif $hostOS == "windows"
 # Make sure to copy dll along with jsc on Windows
-source = [originalJSCPath] + Dir.glob(File.dirname(originalJSCPath) + "/jscLib.dll")
+originalJSCDir = File.dirname(originalJSCPath)
+source = [originalJSCPath] + [originalJSCDir + "/jscLib.dll"]
+
+# 

[webkit-changes] [231121] trunk/LayoutTests/imported/w3c

[ryanhaddad]

Title: [231121] trunk/LayoutTests/imported/w3c








Revision 231121
Author ryanhad...@apple.com
Date 2018-04-27 17:07:38 -0700 (Fri, 27 Apr 2018)


Log Message
Rebaseline imported/w3c/web-platform-tests/url/url-setters.html after r231110.

Unreviewed test gardening..

* web-platform-tests/url/url-setters-expected.txt:

Modified Paths

trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt




Diff

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (231120 => 231121)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2018-04-28 00:02:56 UTC (rev 231120)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2018-04-28 00:07:38 UTC (rev 231121)
@@ -1,3 +1,11 @@
+2018-04-27  Ryan Haddad  
+
+Rebaseline imported/w3c/web-platform-tests/url/url-setters.html after r231110.
+
+Unreviewed test gardening..
+
+* web-platform-tests/url/url-setters-expected.txt:
+
 2018-04-27  Youenn Fablet  
 
 Use NetworkLoadChecker for XHR/fetch loads


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt (231120 => 231121)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt	2018-04-28 00:02:56 UTC (rev 231120)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/url/url-setters-expected.txt	2018-04-28 00:07:38 UTC (rev 231121)
@@ -198,12 +198,12 @@
 PASS URL: Setting .host = '@' 
 FAIL : Setting .host = '@' assert_equals: expected "sc://x/" but got "sc://@/"
 FAIL : Setting .host = '@' assert_equals: expected "sc://x/" but got "sc://@/"
-FAIL URL: Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://ss/"
-FAIL : Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://ss/"
-FAIL : Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://ss/"
-FAIL URL: Setting .host = 'ß' IDNA Nontransitional_Processing assert_equals: expected "https://xn--zca/" but got "https://ss/"
-FAIL : Setting .host = 'ß' IDNA Nontransitional_Processing assert_equals: expected "https://xn--zca/" but got "https://ss/"
-FAIL : Setting .host = 'ß' IDNA Nontransitional_Processing assert_equals: expected "https://xn--zca/" but got "https://ss/"
+FAIL URL: Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://xn--zca/"
+FAIL : Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://xn--zca/"
+FAIL : Setting .host = 'ß' assert_equals: expected "sc://%C3%9F/" but got "sc://xn--zca/"
+PASS URL: Setting .host = 'ß' IDNA Nontransitional_Processing 
+PASS : Setting .host = 'ß' IDNA Nontransitional_Processing 
+PASS : Setting .host = 'ß' IDNA Nontransitional_Processing 
 PASS URL: Setting .host = 'example.com' Cannot-be-a-base means no host 
 PASS : Setting .host = 'example.com' Cannot-be-a-base means no host 
 PASS : Setting .host = 'example.com' Cannot-be-a-base means no host 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231120] trunk/LayoutTests

[ryanhaddad]

Title: [231120] trunk/LayoutTests








Revision 231120
Author ryanhad...@apple.com
Date 2018-04-27 17:02:56 -0700 (Fri, 27 Apr 2018)


Log Message
Update TestExpectations for fast/loader/submit-form-while-parsing-2.html.
https://bugs.webkit.org/show_bug.cgi?id=184051

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231119 => 231120)

--- trunk/LayoutTests/ChangeLog	2018-04-28 00:02:54 UTC (rev 231119)
+++ trunk/LayoutTests/ChangeLog	2018-04-28 00:02:56 UTC (rev 231120)
@@ -1,5 +1,14 @@
 2018-04-27  Ryan Haddad  
 
+Update TestExpectations for fast/loader/submit-form-while-parsing-2.html.
+https://bugs.webkit.org/show_bug.cgi?id=184051
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2018-04-27  Ryan Haddad  
+
 Mark http/wpt/resource-timing/rt-resources-per-worker.html as flaky on iOS.
 https://bugs.webkit.org/show_bug.cgi?id=180260
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (231119 => 231120)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-28 00:02:54 UTC (rev 231119)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-28 00:02:56 UTC (rev 231120)
@@ -886,8 +886,6 @@
 
 webkit.org/b/184245 http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
 
-webkit.org/b/184051 fast/loader/submit-form-while-parsing-2.html [ Pass Timeout ]
-
 webkit.org/b/177380 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]
 
 webkit.org/b/184469 http/wpt/service-workers/header-filtering.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231119] trunk/LayoutTests

[ryanhaddad]

Title: [231119] trunk/LayoutTests








Revision 231119
Author ryanhad...@apple.com
Date 2018-04-27 17:02:54 -0700 (Fri, 27 Apr 2018)


Log Message
Mark http/wpt/resource-timing/rt-resources-per-worker.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=180260

Unreviewed test gardening.

* platform/ios/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (231118 => 231119)

--- trunk/LayoutTests/ChangeLog	2018-04-28 00:01:14 UTC (rev 231118)
+++ trunk/LayoutTests/ChangeLog	2018-04-28 00:02:54 UTC (rev 231119)
@@ -1,3 +1,12 @@
+2018-04-27  Ryan Haddad  
+
+Mark http/wpt/resource-timing/rt-resources-per-worker.html as flaky on iOS.
+https://bugs.webkit.org/show_bug.cgi?id=180260
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+
 2018-04-27  Nan Wang  
 
 AX: Accessibility needs to know which part of the content view is visible on iOS


Modified: trunk/LayoutTests/platform/ios/TestExpectations (231118 => 231119)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-04-28 00:01:14 UTC (rev 231118)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-04-28 00:02:54 UTC (rev 231119)
@@ -3293,3 +3293,5 @@
 webkit.org/b/183388 fast/scrolling/scroll-to-focused-element-asynchronously.html [ Pass Failure ]
 
 webkit.org/b/184787 http/wpt/cache-storage/cache-quota.any.html [ Pass Failure ]
+
+webkit.org/b/180260 http/wpt/resource-timing/rt-resources-per-worker.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231118] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [231118] trunk/Source/_javascript_Core








Revision 231118
Author utatane@gmail.com
Date 2018-04-27 17:01:14 -0700 (Fri, 27 Apr 2018)


Log Message
[JSC][ARM64][Linux] Add collectCPUFeatures using auxiliary vector
https://bugs.webkit.org/show_bug.cgi?id=185055

Reviewed by JF Bastien.

This patch is paving the way to emitting jscvt instruction if possible.
To do that, we need to determine jscvt instruction is supported in the
given CPU.

We add a function collectCPUFeatures, which is responsible to collect
CPU features if necessary. In Linux, we can use auxiliary vector to get
the information without parsing /proc/cpuinfo.

Currently, nobody calls this function. It is later called when we emit
jscvt instruction. To make it possible, we also need to add disassembler
support too.

* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssemblerARM64.cpp:
(JSC::MacroAssemblerARM64::collectCPUFeatures):
* assembler/MacroAssemblerARM64.h:
* assembler/MacroAssemblerX86Common.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86Common.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (231117 => 231118)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-27 23:46:31 UTC (rev 231117)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-28 00:01:14 UTC (rev 231118)
@@ -1,3 +1,28 @@
+2018-04-27  Yusuke Suzuki  
+
+[JSC][ARM64][Linux] Add collectCPUFeatures using auxiliary vector
+https://bugs.webkit.org/show_bug.cgi?id=185055
+
+Reviewed by JF Bastien.
+
+This patch is paving the way to emitting jscvt instruction if possible.
+To do that, we need to determine jscvt instruction is supported in the
+given CPU.
+
+We add a function collectCPUFeatures, which is responsible to collect
+CPU features if necessary. In Linux, we can use auxiliary vector to get
+the information without parsing /proc/cpuinfo.
+
+Currently, nobody calls this function. It is later called when we emit
+jscvt instruction. To make it possible, we also need to add disassembler
+support too.
+
+* assembler/AbstractMacroAssembler.h:
+* assembler/MacroAssemblerARM64.cpp:
+(JSC::MacroAssemblerARM64::collectCPUFeatures):
+* assembler/MacroAssemblerARM64.h:
+* assembler/MacroAssemblerX86Common.h:
+
 2018-04-26  Filip Pizlo  
 
 Also run foldPathConstants before mussing up SSA


Modified: trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h (231117 => 231118)

--- trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h	2018-04-27 23:46:31 UTC (rev 231117)
+++ trunk/Source/_javascript_Core/assembler/AbstractMacroAssembler.h	2018-04-28 00:01:14 UTC (rev 231118)
@@ -82,6 +82,12 @@
 template using CodePtr = MacroAssemblerCodePtr;
 template using CodeRef = MacroAssemblerCodeRef;
 
+enum class CPUIDCheckState {
+NotChecked,
+Clear,
+Set
+};
+
 class Jump;
 
 typedef typename AssemblerType::RegisterID RegisterID;


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp (231117 => 231118)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp	2018-04-27 23:46:31 UTC (rev 231117)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.cpp	2018-04-28 00:01:14 UTC (rev 231118)
@@ -31,6 +31,11 @@
 #include "ProbeContext.h"
 #include 
 
+#if OS(LINUX)
+#include 
+#include 
+#endif
+
 namespace JSC {
 
 #if ENABLE(MASM_PROBE)
@@ -526,6 +531,34 @@
 
 #endif // ENABLE(MASM_PROBE)
 
+void MacroAssemblerARM64::collectCPUFeatures()
+{
+static std::once_flag onceKey;
+std::call_once(onceKey, [] {
+#if OS(LINUX)
+// A register for describing ARM64 CPU features are only accessible in kernel mode.
+// Thus, some kernel support is necessary to collect CPU features. In Linux, the
+// kernel passes CPU feature flags in AT_HWCAP auxiliary vector which is passed
+// when the process starts. While this may pose a bit conservative information
+// (for example, the Linux kernel may add a flag for a feature after the feature
+// is shipped and implemented in some CPUs. In that case, even if the CPU has
+// that feature, the kernel does not tell it to users.), it is a stable approach.
+// https://www.kernel.org/doc/Documentation/arm64/elf_hwcaps.txt
+unsigned long hwcaps = getauxval(AT_HWCAP);
+
+#if !defined(HWCAP_JSCVT)
+#define HWCAP_JSCVT (1 << 13)
+#endif
+
+s_jscvtCheckState = (hwcaps & HWCAP_JSCVT) ? CPUIDCheckState::Set : CPUIDCheckState::Clear;
+#else
+s_jscvtCheckState = CPUIDCheckState::Clear;
+#endif
+});
+}
+

[webkit-changes] [231117] trunk/Source/WebCore

[zalan]

Title: [231117] trunk/Source/WebCore








Revision 231117
Author za...@apple.com
Date 2018-04-27 16:46:31 -0700 (Fri, 27 Apr 2018)


Log Message
[LFC] Add FormattingContext::computeWidth/computeHeight logic.
https://bugs.webkit.org/show_bug.cgi?id=185091

Reviewed by Antti Koivisto.

Inflow width and height can't really be computed without knowing the exact context.

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeWidth const):
(WebCore::Layout::FormattingContext::computeHeight const):
(WebCore::Layout::FormattingContext::computeOutOfFlowWidth const):
(WebCore::Layout::FormattingContext::computeFloatingWidth const):
(WebCore::Layout::FormattingContext::computeOutOfFlowHeight const):
(WebCore::Layout::FormattingContext::computeFloatingHeight const):
* layout/FormattingContext.h:
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeInFlowWidth const):
(WebCore::Layout::BlockFormattingContext::computeInFlowHeight const):
(WebCore::Layout::BlockFormattingContext::computeWidth const): Deleted.
(WebCore::Layout::BlockFormattingContext::computeHeight const): Deleted.
* layout/blockformatting/BlockFormattingContext.h:
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::computeInFlowWidth const):
(WebCore::Layout::InlineFormattingContext::computeInFlowHeight const):
* layout/inlineformatting/InlineFormattingContext.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/FormattingContext.cpp
trunk/Source/WebCore/layout/FormattingContext.h
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.cpp
trunk/Source/WebCore/layout/blockformatting/BlockFormattingContext.h
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
trunk/Source/WebCore/layout/inlineformatting/InlineFormattingContext.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (231116 => 231117)

--- trunk/Source/WebCore/ChangeLog	2018-04-27 23:43:30 UTC (rev 231116)
+++ trunk/Source/WebCore/ChangeLog	2018-04-27 23:46:31 UTC (rev 231117)
@@ -1,3 +1,31 @@
+2018-04-27  Zalan Bujtas  
+
+[LFC] Add FormattingContext::computeWidth/computeHeight logic.
+https://bugs.webkit.org/show_bug.cgi?id=185091
+
+Reviewed by Antti Koivisto.
+
+Inflow width and height can't really be computed without knowing the exact context. 
+
+* layout/FormattingContext.cpp:
+(WebCore::Layout::FormattingContext::computeWidth const):
+(WebCore::Layout::FormattingContext::computeHeight const):
+(WebCore::Layout::FormattingContext::computeOutOfFlowWidth const):
+(WebCore::Layout::FormattingContext::computeFloatingWidth const):
+(WebCore::Layout::FormattingContext::computeOutOfFlowHeight const):
+(WebCore::Layout::FormattingContext::computeFloatingHeight const):
+* layout/FormattingContext.h:
+* layout/blockformatting/BlockFormattingContext.cpp:
+(WebCore::Layout::BlockFormattingContext::computeInFlowWidth const):
+(WebCore::Layout::BlockFormattingContext::computeInFlowHeight const):
+(WebCore::Layout::BlockFormattingContext::computeWidth const): Deleted.
+(WebCore::Layout::BlockFormattingContext::computeHeight const): Deleted.
+* layout/blockformatting/BlockFormattingContext.h:
+* layout/inlineformatting/InlineFormattingContext.cpp:
+(WebCore::Layout::InlineFormattingContext::computeInFlowWidth const):
+(WebCore::Layout::InlineFormattingContext::computeInFlowHeight const):
+* layout/inlineformatting/InlineFormattingContext.h:
+
 2018-04-27  Chris Dumez  
 
 Use WindowProxy instead of DOMWindow in our IDL


Modified: trunk/Source/WebCore/layout/FormattingContext.cpp (231116 => 231117)

--- trunk/Source/WebCore/layout/FormattingContext.cpp	2018-04-27 23:43:30 UTC (rev 231116)
+++ trunk/Source/WebCore/layout/FormattingContext.cpp	2018-04-27 23:46:31 UTC (rev 231117)
@@ -28,6 +28,7 @@
 
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 
+#include "LayoutBox.h"
 #include 
 
 namespace WebCore {
@@ -57,14 +58,40 @@
 {
 }
 
-void FormattingContext::computeWidth(const Box&) const
+void FormattingContext::computeWidth(const Box& layoutBox) const
 {
+if (layoutBox.isOutOfFlowPositioned())
+return computeOutOfFlowWidth(layoutBox);
+if (layoutBox.isFloatingPositioned())
+return computeFloatingWidth(layoutBox);
+return computeInFlowWidth(layoutBox);
 }
 
-void FormattingContext::computeHeight(const Box&) const
+void FormattingContext::computeHeight(const Box& layoutBox) const
 {
+if (layoutBox.isOutOfFlowPositioned())
+return computeOutOfFlowHeight(layoutBox);
+if (layoutBox.isFloatingPositioned())
+return computeFloatingHeight(layoutBox);
+return computeInFlowHeight(layoutBox);
 }
 
+void FormattingContext::computeOutOfFlowWidth(const Box&) const
+{
+}
+
+void 

[webkit-changes] [231116] trunk/Source/JavaScriptCore

[fpizlo]

Title: [231116] trunk/Source/_javascript_Core








Revision 231116
Author fpi...@apple.com
Date 2018-04-27 16:43:30 -0700 (Fri, 27 Apr 2018)


Log Message
Also run foldPathConstants before mussing up SSA
https://bugs.webkit.org/show_bug.cgi?id=185069

Reviewed by Saam Barati.

This isn't needed now, but will be once I implement the phase in bug 185060.

This could be a speed-up, or a slow-down, independent of that phase. Most likely it's neutral.
Local testing seems to suggest that it's neutral. Anyway, whatever it ends up being, I want it to
be landed separately and measured separately from that phase.

It's probably nice for sanity to have this and reduceStrength run before tail duplication and
another round of reduceStrength, since that make for something that is closer to a fixpoint. But
it will increase FTL compile times. So, there's no way to guess if this change is good, bad, or
neutral. It all depends on what programs typically look like.

* b3/B3Generate.cpp:
(JSC::B3::generateToAir):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/b3/B3Generate.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (231115 => 231116)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-27 22:30:43 UTC (rev 231115)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-27 23:43:30 UTC (rev 231116)
@@ -1,3 +1,24 @@
+2018-04-26  Filip Pizlo  
+
+Also run foldPathConstants before mussing up SSA
+https://bugs.webkit.org/show_bug.cgi?id=185069
+
+Reviewed by Saam Barati.
+
+This isn't needed now, but will be once I implement the phase in bug 185060.
+
+This could be a speed-up, or a slow-down, independent of that phase. Most likely it's neutral.
+Local testing seems to suggest that it's neutral. Anyway, whatever it ends up being, I want it to
+be landed separately and measured separately from that phase.
+
+It's probably nice for sanity to have this and reduceStrength run before tail duplication and
+another round of reduceStrength, since that make for something that is closer to a fixpoint. But
+it will increase FTL compile times. So, there's no way to guess if this change is good, bad, or
+neutral. It all depends on what programs typically look like.
+
+* b3/B3Generate.cpp:
+(JSC::B3::generateToAir):
+
 2018-04-27  Ryan Haddad  
 
 Unreviewed, rolling out r231086.


Modified: trunk/Source/_javascript_Core/b3/B3Generate.cpp (231115 => 231116)

--- trunk/Source/_javascript_Core/b3/B3Generate.cpp	2018-04-27 22:30:43 UTC (rev 231115)
+++ trunk/Source/_javascript_Core/b3/B3Generate.cpp	2018-04-27 23:43:30 UTC (rev 231116)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2015-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2018 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -87,6 +87,8 @@
 hoistLoopInvariantValues(procedure);
 if (eliminateCommonSubexpressions(procedure))
 eliminateCommonSubexpressions(procedure);
+foldPathConstants(procedure);
+reduceStrength(procedure);
 inferSwitches(procedure);
 duplicateTails(procedure);
 fixSSA(procedure);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [231115] trunk

[rniwa]

Title: [231115] trunk








Revision 231115
Author rn...@webkit.org
Date 2018-04-27 15:30:43 -0700 (Fri, 27 Apr 2018)


Log Message
PSON: Triggering a navigation to an invalid URL creates a new WebContent process
https://bugs.webkit.org/show_bug.cgi?id=185066

Reviewed by Youenn Fablet.

Source/WebKit:

Don't create a new WebContent process when the target URL is invalid as well as when the source URL is invalid.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):

Tools:

Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
WebKit should not swap WebContent process in this case.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
(-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessPool.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (231114 => 231115)

--- trunk/Source/WebKit/ChangeLog	2018-04-27 22:11:00 UTC (rev 231114)
+++ trunk/Source/WebKit/ChangeLog	2018-04-27 22:30:43 UTC (rev 231115)
@@ -1,3 +1,15 @@
+2018-04-26  Ryosuke Niwa  
+
+PSON: Triggering a navigation to an invalid URL creates a new WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=185066
+
+Reviewed by Youenn Fablet.
+
+Don't create a new WebContent process when the target URL is invalid as well as when the source URL is invalid.
+
+* UIProcess/WebProcessPool.cpp:
+(WebKit::WebProcessPool::processForNavigationInternal):
+
 2018-04-27  Youenn Fablet  
 
 Use NetworkLoadChecker for XHR/fetch loads


Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (231114 => 231115)

--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2018-04-27 22:11:00 UTC (rev 231114)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp	2018-04-27 22:30:43 UTC (rev 231115)
@@ -2096,7 +2096,7 @@
 
 auto targetURL = navigation.currentRequest().url();
 auto url = "" { ParsedURLString, page.pageLoadState().url() };
-if (!url.isValid() || url.isEmpty() || url.isBlankURL() ||protocolHostAndPortAreEqual(url, targetURL))
+if (!url.isValid() || !targetURL.isValid() || url.isEmpty() || url.isBlankURL() || protocolHostAndPortAreEqual(url, targetURL))
 return page.process();
 
 if (m_configuration->alwaysKeepAndReuseSwappedProcesses()) {


Modified: trunk/Tools/ChangeLog (231114 => 231115)

--- trunk/Tools/ChangeLog	2018-04-27 22:11:00 UTC (rev 231114)
+++ trunk/Tools/ChangeLog	2018-04-27 22:30:43 UTC (rev 231115)
@@ -1,3 +1,17 @@
+2018-04-26  Ryosuke Niwa  
+
+PSON: Triggering a navigation to an invalid URL creates a new WebContent process
+https://bugs.webkit.org/show_bug.cgi?id=185066
+
+Reviewed by Youenn Fablet.
+
+Added a new test case (ProcessSwap.NavigateToInvalidURL) for navigating to an invalid URL.
+WebKit should not swap WebContent process in this case.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+(-[PSONNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
+(-[PSONUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
+
 2018-04-27  Nan Wang  
 
 AX: Accessibility needs to know which part of the content view is visible on iOS


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (231114 => 231115)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm	2018-04-27 22:11:00 UTC (rev 231114)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm	2018-04-27 22:30:43 UTC (rev 231115)
@@ -54,10 +54,12 @@
 #if WK_API_ENABLED
 
 static bool done;
+static bool failed;
 static bool didCreateWebView;
 static int numberOfDecidePolicyCalls;
 
 static RetainPtr receivedMessages = adoptNS([@[] mutableCopy]);
+bool didReceiveAlert;
 static bool receivedMessage;
 static bool serverRedirected;
 static HashSet seenPIDs;
@@ -83,6 +85,12 @@
 
 @implementation PSONNavigationDelegate
 
+- (void)webView:(WKWebView *)webView didFailProvisionalNavigation:(WKNavigation *)navigation withError:(NSError *)error
+{
+seenPIDs.add([webView _webProcessIdentifier]);
+failed = true;
+}
+
 - (void)webView:(WKWebView *)webView didFinishNavigation:(WKNavigation *)navigation
 {
 seenPIDs.add([webView _webProcessIdentifier]);
@@ -131,6 +139,12 @@
 return createdWebView.get();
 }
 
+- (void)webView:(WKWebView *)webView runJavaScriptAlertPanelWithMessage:(NSString *)message initiatedByFrame:(WKFrameInfo *)frame completionHandler:(void (^)())completionHandler
+{
+didReceiveAlert = true;
+completionHandler();
+}

[webkit-changes] [231113] trunk

[n_wang]

Title: [231113] trunk








Revision 231113
Author n_w...@apple.com
Date 2018-04-27 14:58:33 -0700 (Fri, 27 Apr 2018)


Log Message
AX: Accessibility needs to know which part of the content view is visible on iOS
https://bugs.webkit.org/show_bug.cgi?id=185085


Reviewed by Chris Fleizach.

Source/WebCore:

Exposed unobscuredContentRect() to iOS accessibility object wrapper.

Test: accessibility/ios-simulator/unobscured-content-rect.html

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityVisibleContentRect]):

Tools:

* WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::stringAttributeValue):

LayoutTests:

* accessibility/ios-simulator/unobscured-content-rect-expected.txt: Added.
* accessibility/ios-simulator/unobscured-content-rect.html: Added.
* platform/ios-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk1/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm


Added Paths

trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect-expected.txt
trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect.html




Diff

Modified: trunk/LayoutTests/ChangeLog (231112 => 231113)

--- trunk/LayoutTests/ChangeLog	2018-04-27 21:35:56 UTC (rev 231112)
+++ trunk/LayoutTests/ChangeLog	2018-04-27 21:58:33 UTC (rev 231113)
@@ -1,3 +1,15 @@
+2018-04-27  Nan Wang  
+
+AX: Accessibility needs to know which part of the content view is visible on iOS
+https://bugs.webkit.org/show_bug.cgi?id=185085
+
+
+Reviewed by Chris Fleizach.
+
+* accessibility/ios-simulator/unobscured-content-rect-expected.txt: Added.
+* accessibility/ios-simulator/unobscured-content-rect.html: Added.
+* platform/ios-wk1/TestExpectations:
+
 2018-04-27  Christopher Reid  
 
 URL::appendEncodedHostName is using the deprecated uidna_IDNToASCII function


Added: trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect-expected.txt (0 => 231113)

--- trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect-expected.txt	2018-04-27 21:58:33 UTC (rev 231113)
@@ -0,0 +1,12 @@
+test  
+This tests that unobscured content rect is exposed to accessibility.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS button.stringAttributeValue('AXVisibleContentRect') is '{0.00, 0.00, 800.00, 600.00}'
+PASS frameButton.stringAttributeValue('AXVisibleContentRect') is '{60.00, 10.00, 200.00, 200.00}'
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect.html (0 => 231113)

--- trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect.html	(rev 0)
+++ trunk/LayoutTests/accessibility/ios-simulator/unobscured-content-rect.html	2018-04-27 21:58:33 UTC (rev 231113)
@@ -0,0 +1,38 @@
+
+
+
+
+
+test
+
+
+
+