[webkit-changes] [258314] trunk/Source

[jer . noble]

Title: [258314] trunk/Source








Revision 258314
Author jer.no...@apple.com
Date 2020-03-11 21:57:31 -0700 (Wed, 11 Mar 2020)


Log Message
Adopt AVSampleBufferVideoOutput
https://bugs.webkit.org/show_bug.cgi?id=208951

Reviewed by Eric Carlson.

Source/WebCore:

Adopt AVSampleBufferVideoOutput, used for extracting decoded samples from an AVSampleBufferDisplayLayer.

Rather than use a separate decompression session when we need to, e.g., paint samples into WebGL, we will
add a AVSBVO to the AVSBDL and use it to extract CVPixelBuffers when asked.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isVideoOutputAvailable const):

Source/WebCore/PAL:

* pal/cocoa/AVFoundationSoftLink.h:
* pal/cocoa/AVFoundationSoftLink.mm:
* pal/spi/cocoa/AVFoundationSPI.h:

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h
trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.mm
trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (258313 => 258314)

--- trunk/Source/WTF/ChangeLog	2020-03-12 04:25:11 UTC (rev 258313)
+++ trunk/Source/WTF/ChangeLog	2020-03-12 04:57:31 UTC (rev 258314)
@@ -1,5 +1,14 @@
 2020-03-11  Jer Noble  
 
+Adopt AVSampleBufferVideoOutput
+https://bugs.webkit.org/show_bug.cgi?id=208951
+
+Reviewed by Eric Carlson.
+
+* wtf/PlatformHave.h:
+
+2020-03-11  Jer Noble  
+
 [EME] Issue an "encrypted" event when a new encrypted initialization segment is encountered
 https://bugs.webkit.org/show_bug.cgi?id=208923
 


Modified: trunk/Source/WTF/wtf/PlatformHave.h (258313 => 258314)

--- trunk/Source/WTF/wtf/PlatformHave.h	2020-03-12 04:25:11 UTC (rev 258313)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2020-03-12 04:57:31 UTC (rev 258314)
@@ -600,6 +600,7 @@
 
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 14)
 #define HAVE_WEBP 1
+#define HAVE_AVSAMPLEBUFFERVIDEOOUTPUT 1
 #endif
 
 #if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600)


Modified: trunk/Source/WebCore/ChangeLog (258313 => 258314)

--- trunk/Source/WebCore/ChangeLog	2020-03-12 04:25:11 UTC (rev 258313)
+++ trunk/Source/WebCore/ChangeLog	2020-03-12 04:57:31 UTC (rev 258314)
@@ -1,3 +1,22 @@
+2020-03-11  Jer Noble  
+
+Adopt AVSampleBufferVideoOutput
+https://bugs.webkit.org/show_bug.cgi?id=208951
+
+Reviewed by Eric Carlson.
+
+Adopt AVSampleBufferVideoOutput, used for extracting decoded samples from an AVSampleBufferDisplayLayer.
+
+Rather than use a separate decompression session when we need to, e.g., paint samples into WebGL, we will
+add a AVSBVO to the AVSBDL and use it to extract CVPixelBuffers when asked.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::updateLastPixelBuffer):
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::acceleratedRenderingStateChanged):
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureLayer):
+(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::isVideoOutputAvailable const):
+
 2020-03-11  Andres Gonzalez  
 
 Removed unused textElements member from AccessibilityText structure.


Modified: trunk/Source/WebCore/PAL/ChangeLog (258313 => 258314)

--- trunk/Source/WebCore/PAL/ChangeLog	2020-03-12 04:25:11 UTC (rev 258313)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-03-12 04:57:31 UTC (rev 258314)
@@ -1,5 +1,16 @@
 2020-03-11  Jer Noble  
 
+Adopt AVSampleBufferVideoOutput
+https://bugs.webkit.org/show_bug.cgi?id=208951
+
+Reviewed by Eric Carlson.
+
+* pal/cocoa/AVFoundationSoftLink.h:
+* pal/cocoa/AVFoundationSoftLink.mm:
+* pal/spi/cocoa/AVFoundationSPI.h:
+
+2020-03-11  Jer Noble  
+
 [EME] Issue an "encrypted" event when a new encrypted initialization segment is encountered
 https://bugs.webkit.org/show_bug.cgi?id=208923
 


Modified: trunk/Source/WebCore/PAL/pal/cocoa/AVFoundationSoftLink.h (258313 => 258314)

--- 

[webkit-changes] [258313] trunk/Source/WebCore

[andresg_22]

Title: [258313] trunk/Source/WebCore








Revision 258313
Author andresg...@apple.com
Date 2020-03-11 21:25:11 -0700 (Wed, 11 Mar 2020)


Log Message
Removed unused textElements member from AccessibilityText structure.
https://bugs.webkit.org/show_bug.cgi?id=208967

Reviewed by Chris Fleizach.

The textElements member of AccessibilityText is not used by any client
and its computation is causing crashes in IsolatedTree mode. So this
change removes it.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::titleElementText const):
(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityText::AccessibilityText):
* accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::initializeAttributeData):
(WebCore::AXIsolatedObject::accessibilityText const):
* accessibility/isolatedtree/AXIsolatedObject.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp
trunk/Source/WebCore/accessibility/AccessibilityObject.h
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (258312 => 258313)

--- trunk/Source/WebCore/ChangeLog	2020-03-12 04:24:58 UTC (rev 258312)
+++ trunk/Source/WebCore/ChangeLog	2020-03-12 04:25:11 UTC (rev 258313)
@@ -1,3 +1,24 @@
+2020-03-11  Andres Gonzalez  
+
+Removed unused textElements member from AccessibilityText structure.
+https://bugs.webkit.org/show_bug.cgi?id=208967
+
+Reviewed by Chris Fleizach.
+
+The textElements member of AccessibilityText is not used by any client
+and its computation is causing crashes in IsolatedTree mode. So this
+change removes it.
+
+* accessibility/AccessibilityNodeObject.cpp:
+(WebCore::AccessibilityNodeObject::titleElementText const):
+(WebCore::AccessibilityNodeObject::ariaLabeledByText const):
+* accessibility/AccessibilityObject.h:
+(WebCore::AccessibilityText::AccessibilityText):
+* accessibility/isolatedtree/AXIsolatedObject.cpp:
+(WebCore::AXIsolatedObject::initializeAttributeData):
+(WebCore::AXIsolatedObject::accessibilityText const):
+* accessibility/isolatedtree/AXIsolatedObject.h:
+
 2020-03-11  Don Olmstead  
 
 Non-unified build fixes early March 2020 edition Take 2


Modified: trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp (258312 => 258313)

--- trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp	2020-03-12 04:24:58 UTC (rev 258312)
+++ trunk/Source/WebCore/accessibility/AccessibilityNodeObject.cpp	2020-03-12 04:25:11 UTC (rev 258313)
@@ -1313,7 +1313,7 @@
 auto objectCache = axObjectCache();
 // Only use the  text if there's no ARIA override.
 if (objectCache && !innerText.isEmpty() && !ariaAccessibilityDescription())
-textOrder.append(AccessibilityText(innerText, isMeter() ? AccessibilityTextSource::Alternative : AccessibilityTextSource::LabelByElement, objectCache->getOrCreate(label)));
+textOrder.append(AccessibilityText(innerText, isMeter() ? AccessibilityTextSource::Alternative : AccessibilityTextSource::LabelByElement));
 return;
 }
 }
@@ -1320,7 +1320,7 @@
 
 AccessibilityObject* titleUIElement = this->titleUIElement();
 if (titleUIElement)
-textOrder.append(AccessibilityText(String(), AccessibilityTextSource::LabelByElement, titleUIElement));
+textOrder.append(AccessibilityText(String(), AccessibilityTextSource::LabelByElement));
 }
 
 void AccessibilityNodeObject::alternativeText(Vector& textOrder) const
@@ -1517,7 +1517,7 @@
 for (const auto& element : elements)
 axElements.append(objectCache->getOrCreate(element));
 
-textOrder.append(AccessibilityText(ariaLabeledBy, AccessibilityTextSource::Alternative, axElements));
+textOrder.append(AccessibilityText(ariaLabeledBy, AccessibilityTextSource::Alternative));
 }
 }
 


Modified: trunk/Source/WebCore/accessibility/AccessibilityObject.h (258312 => 258313)

--- trunk/Source/WebCore/accessibility/AccessibilityObject.h	2020-03-12 04:24:58 UTC (rev 258312)
+++ trunk/Source/WebCore/accessibility/AccessibilityObject.h	2020-03-12 04:25:11 UTC (rev 258313)
@@ -69,28 +69,11 @@
 struct AccessibilityText {
 String text;
 AccessibilityTextSource textSource;
-Vector> textElements;
 
 AccessibilityText(const String& t, const AccessibilityTextSource& s)
 : text(t)
 , textSource(s)
 { }
-
-AccessibilityText(const String& t, const AccessibilityTextSource& s, Vector elements)
-: text(t)
-, textSource(s)
-{
-textElements.reserveCapacity(elements.size());
-for (auto element : elements)
-

[webkit-changes] [258312] trunk/Source/WebKit

[commit-queue]

Title: [258312] trunk/Source/WebKit








Revision 258312
Author commit-qu...@webkit.org
Date 2020-03-11 21:24:58 -0700 (Wed, 11 Mar 2020)


Log Message
[GPU Process] encodeNativeImage() should pass imageSize to GraphicsContext::drawNativeImage()
https://bugs.webkit.org/show_bug.cgi?id=208936

Patch by Said Abou-Hallawa  on 2020-03-11
Reviewed by Myles C. Maxfield.

Passing an empty FloatSize makes drawNativeImage() draws nothing to
the ShareableBitmap

* Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeNativeImage):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (258311 => 258312)

--- trunk/Source/WebKit/ChangeLog	2020-03-12 04:19:58 UTC (rev 258311)
+++ trunk/Source/WebKit/ChangeLog	2020-03-12 04:24:58 UTC (rev 258312)
@@ -1,5 +1,18 @@
 2020-03-11  Said Abou-Hallawa  
 
+[GPU Process] encodeNativeImage() should pass imageSize to GraphicsContext::drawNativeImage()
+https://bugs.webkit.org/show_bug.cgi?id=208936
+
+Reviewed by Myles C. Maxfield.
+
+Passing an empty FloatSize makes drawNativeImage() draws nothing to
+the ShareableBitmap
+
+* Shared/WebCoreArgumentCoders.cpp:
+(IPC::encodeNativeImage):
+
+2020-03-11  Said Abou-Hallawa  
+
 RemoteImageBuffer::getImageData() has to clear its DisplayList after calling flushDrawingContext()
 https://bugs.webkit.org/show_bug.cgi?id=208931
 


Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp (258311 => 258312)

--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2020-03-12 04:19:58 UTC (rev 258311)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2020-03-12 04:24:58 UTC (rev 258312)
@@ -1082,7 +1082,7 @@
 if (!graphicsContext)
 return;
 
-graphicsContext->drawNativeImage(image, { }, FloatRect({ }, imageSize), FloatRect({ }, imageSize));
+graphicsContext->drawNativeImage(image, imageSize, FloatRect({ }, imageSize), FloatRect({ }, imageSize));
 
 ShareableBitmap::Handle handle;
 bitmap->createHandle(handle);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258311] trunk/Source/WebKit

[commit-queue]

Title: [258311] trunk/Source/WebKit








Revision 258311
Author commit-qu...@webkit.org
Date 2020-03-11 21:19:58 -0700 (Wed, 11 Mar 2020)


Log Message
RemoteImageBuffer::getImageData() has to clear its DisplayList after calling flushDrawingContext()
https://bugs.webkit.org/show_bug.cgi?id=208931

Patch by Said Abou-Hallawa  on 2020-03-11
Reviewed by Myles C. Maxfield.

Instead of letting every caller to flushDrawingContextAndWaitCommit() or
flushDrawingContext() be responsible of clearing the DisplayList, we can
make these functions take this responsibility.

* WebProcess/GPU/graphics/RemoteImageBuffer.h:
* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp:
(WebKit::RemoteImageBufferMessageHandler::flushDrawingContext):
(WebKit::RemoteImageBufferMessageHandler::flushDrawingContextAndWaitCommit):
* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBuffer.h
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp
trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (258310 => 258311)

--- trunk/Source/WebKit/ChangeLog	2020-03-12 03:19:09 UTC (rev 258310)
+++ trunk/Source/WebKit/ChangeLog	2020-03-12 04:19:58 UTC (rev 258311)
@@ -1,3 +1,20 @@
+2020-03-11  Said Abou-Hallawa  
+
+RemoteImageBuffer::getImageData() has to clear its DisplayList after calling flushDrawingContext()
+https://bugs.webkit.org/show_bug.cgi?id=208931
+
+Reviewed by Myles C. Maxfield.
+
+Instead of letting every caller to flushDrawingContextAndWaitCommit() or
+flushDrawingContext() be responsible of clearing the DisplayList, we can
+make these functions take this responsibility.
+
+* WebProcess/GPU/graphics/RemoteImageBuffer.h:
+* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp:
+(WebKit::RemoteImageBufferMessageHandler::flushDrawingContext):
+(WebKit::RemoteImageBufferMessageHandler::flushDrawingContextAndWaitCommit):
+* WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.h:
+
 2020-03-11  Don Olmstead  
 
 Non-unified build fixes early March 2020 edition Take 2


Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBuffer.h (258310 => 258311)

--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBuffer.h	2020-03-12 03:19:09 UTC (rev 258310)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBuffer.h	2020-03-12 04:19:58 UTC (rev 258311)
@@ -75,7 +75,7 @@
 
 RefPtr getImageData(WebCore::AlphaPremultiplication outputFormat, const WebCore::IntRect& srcRect) const override
 {
-auto& displayList = m_drawingContext.displayList();
+auto& displayList = const_cast(this)->m_drawingContext.displayList();
 const_cast(this)->RemoteImageBufferMessageHandler::flushDrawingContext(displayList);
 auto result = const_cast(this)->RemoteImageBufferMessageHandler::getImageData(outputFormat, srcRect);
 // getImageData is synchronous, which means we've already received the CommitImageBufferFlushContext message.
@@ -99,10 +99,8 @@
 void flushDrawingContext() override
 {
 auto& displayList = m_drawingContext.displayList();
-if (displayList.itemCount()) {
+if (displayList.itemCount())
 RemoteImageBufferMessageHandler::flushDrawingContextAndWaitCommit(displayList);
-displayList.clear();
-}
 }
 
 void willAppendItem(const WebCore::DisplayList::Item&) override
@@ -109,10 +107,8 @@
 {
 constexpr size_t DisplayListBatchSize = 512;
 auto& displayList = m_drawingContext.displayList();
-if (displayList.itemCount() >= DisplayListBatchSize) {
+if (displayList.itemCount() >= DisplayListBatchSize)
 RemoteImageBufferMessageHandler::flushDrawingContext(displayList);
-displayList.clear();
-}
 }
 };
 


Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp (258310 => 258311)

--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp	2020-03-12 03:19:09 UTC (rev 258310)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteImageBufferMessageHandler.cpp	2020-03-12 04:19:58 UTC (rev 258311)
@@ -70,20 +70,22 @@
 m_remoteRenderingBackend->waitForCommitImageBufferFlushContext();
 }
 
-void RemoteImageBufferMessageHandler::flushDrawingContext(const WebCore::DisplayList::DisplayList& displayList)
+void RemoteImageBufferMessageHandler::flushDrawingContext(WebCore::DisplayList::DisplayList& displayList)
 {
 if (!m_remoteRenderingBackend)
 return;
 
 m_remoteRenderingBackend->send(Messages::RemoteRenderingBackendProxy::FlushImageBufferDrawingContext(displayList, m_imageBufferIdentifier), m_remoteRenderingBackend->renderingBackendIdentifier());
+

[webkit-changes] [258308] trunk/Source/WebCore

[wenson_hsieh]

Title: [258308] trunk/Source/WebCore








Revision 258308
Author wenson_hs...@apple.com
Date 2020-03-11 19:48:36 -0700 (Wed, 11 Mar 2020)


Log Message
Large single select elements are incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=208966

Reviewed by Tim Horton.

Adjusts several size and margin values for menu lists (i.e. the default appearance of non-multiple select
elements) to reflect recent changes in macOS. Additionally, adds a workaround for ,
which causes text inside many form controls (including select buttons) to be incorrectly sized.

* platform/mac/ThemeMac.h:
* platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::systemFontSizeFor):
(WebCore::ThemeMac::controlFont const):
* rendering/RenderThemeMac.mm:

Replace calls to +[NSFont systemFontSizeForControlSize:] with `ThemeMac::systemFontSizeFor(NSControlSize size)`
in order to work around .

(WebCore::RenderThemeMac::updateCachedSystemFontDescription const):
(WebCore::RenderThemeMac::setFontFromControlSize const):
(WebCore::RenderThemeMac::controlSizeForSystemFont const):
(WebCore::RenderThemeMac::popupButtonMargins const):
(WebCore::menuListButtonSizes):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mac/ThemeMac.h
trunk/Source/WebCore/platform/mac/ThemeMac.mm
trunk/Source/WebCore/rendering/RenderThemeMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (258307 => 258308)

--- trunk/Source/WebCore/ChangeLog	2020-03-12 01:50:54 UTC (rev 258307)
+++ trunk/Source/WebCore/ChangeLog	2020-03-12 02:48:36 UTC (rev 258308)
@@ -1,3 +1,29 @@
+2020-03-11  Wenson Hsieh  
+
+Large single select elements are incorrectly sized
+https://bugs.webkit.org/show_bug.cgi?id=208966
+
+Reviewed by Tim Horton.
+
+Adjusts several size and margin values for menu lists (i.e. the default appearance of non-multiple select
+elements) to reflect recent changes in macOS. Additionally, adds a workaround for ,
+which causes text inside many form controls (including select buttons) to be incorrectly sized.
+
+* platform/mac/ThemeMac.h:
+* platform/mac/ThemeMac.mm:
+(WebCore::ThemeMac::systemFontSizeFor):
+(WebCore::ThemeMac::controlFont const):
+* rendering/RenderThemeMac.mm:
+
+Replace calls to +[NSFont systemFontSizeForControlSize:] with `ThemeMac::systemFontSizeFor(NSControlSize size)`
+in order to work around .
+
+(WebCore::RenderThemeMac::updateCachedSystemFontDescription const):
+(WebCore::RenderThemeMac::setFontFromControlSize const):
+(WebCore::RenderThemeMac::controlSizeForSystemFont const):
+(WebCore::RenderThemeMac::popupButtonMargins const):
+(WebCore::menuListButtonSizes):
+
 2020-03-11  Canhai Chen  
 
 AX: accessibilityReplaceRange:withText: doesn't post an AXValueChanged notification like when typing with kb


Modified: trunk/Source/WebCore/platform/mac/ThemeMac.h (258307 => 258308)

--- trunk/Source/WebCore/platform/mac/ThemeMac.h	2020-03-12 01:50:54 UTC (rev 258307)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.h	2020-03-12 02:48:36 UTC (rev 258308)
@@ -36,6 +36,8 @@
 #if HAVE(LARGE_CONTROL_SIZE)
 static bool supportsLargeFormControls();
 #endif
+static double systemFontSizeFor(NSControlSize);
+
 static NSView *ensuredView(ScrollView*, const ControlStates&, bool useUnparentedView = false);
 static void setFocusRingClipRect(const FloatRect&);
 static bool drawCellOrFocusRingWithViewIntoContext(NSCell *, GraphicsContext&, const FloatRect&, NSView *, bool drawButtonCell, bool drawFocusRing, bool useImageBuffer, float deviceScaleFactor);


Modified: trunk/Source/WebCore/platform/mac/ThemeMac.mm (258307 => 258308)

--- trunk/Source/WebCore/platform/mac/ThemeMac.mm	2020-03-12 01:50:54 UTC (rev 258307)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.mm	2020-03-12 02:48:36 UTC (rev 258308)
@@ -803,6 +803,19 @@
 return Theme::baselinePositionAdjustment(part);
 }
 
+double ThemeMac::systemFontSizeFor(NSControlSize size)
+{
+#if HAVE(LARGE_CONTROL_SIZE)
+if (size == NSControlSizeLarge) {
+// This is a workaround for . Once this is fixed,
+// we should remove ThemeMac::systemFontSizeFor as well as this hard-coded
+// value.
+return 15;
+}
+#endif
+return [NSFont systemFontSizeForControlSize:size];
+}
+
 Optional ThemeMac::controlFont(ControlPart part, const FontCascade& font, float zoomFactor) const
 {
 switch (part) {
@@ -810,7 +823,7 @@
 FontCascadeDescription fontDescription;
 fontDescription.setIsAbsoluteSize(true);
 
-NSFont* nsFont = [NSFont systemFontOfSize:[NSFont systemFontSizeForControlSize:controlSizeForFont(font)]];
+NSFont* nsFont = [NSFont systemFontOfSize:ThemeMac::systemFontSizeFor(controlSizeForFont(font))];
 fontDescription.setOneFamily(AtomString("-apple-system", AtomString::ConstructFromLiteral));
 fontDescription.setComputedSize([nsFont 

[webkit-changes] [258307] tags/Safari-610.1.7/

[repstein]

Title: [258307] tags/Safari-610.1.7/








Revision 258307
Author repst...@apple.com
Date 2020-03-11 18:50:54 -0700 (Wed, 11 Mar 2020)


Log Message
Tag Safari-610.1.7.

Added Paths

tags/Safari-610.1.7/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258306] branches/safari-610.1.7-branch/Source/WebKit

[repstein]

Title: [258306] branches/safari-610.1.7-branch/Source/WebKit








Revision 258306
Author repst...@apple.com
Date 2020-03-11 18:43:56 -0700 (Wed, 11 Mar 2020)


Log Message
Cherry-pick r258304. rdar://problem/60351239

[macOS] Register with accessibility when the WebContent process starts
https://bugs.webkit.org/show_bug.cgi?id=208960

Reviewed by Brent Fulgham.

When we reenabled CF prefs direct mode in , we started to register
with accessibility when we received a message to do so from the UI process. This would typically happen when the user
enabled accessibility. On macOS, this notification does not work the same way as on iOS, and it is assumed that
accessibility should always be enabled. Therefore we should go back to registering with accessibility on startup of
the WebContent process on macOS.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::unblockAccessibilityServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.7-branch/Source/WebKit/ChangeLog
branches/safari-610.1.7-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (258305 => 258306)

--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-12 01:35:26 UTC (rev 258305)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-12 01:43:56 UTC (rev 258306)
@@ -1,3 +1,43 @@
+2020-03-11  Russell Epstein  
+
+Cherry-pick r258304. rdar://problem/60351239
+
+[macOS] Register with accessibility when the WebContent process starts
+https://bugs.webkit.org/show_bug.cgi?id=208960
+
+Reviewed by Brent Fulgham.
+
+When we reenabled CF prefs direct mode in , we started to register
+with accessibility when we received a message to do so from the UI process. This would typically happen when the user
+enabled accessibility. On macOS, this notification does not work the same way as on iOS, and it is assumed that
+accessibility should always be enabled. Therefore we should go back to registering with accessibility on startup of
+the WebContent process on macOS.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::platformInitializeProcess):
+(WebKit::WebProcess::unblockAccessibilityServer):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-11  Per Arne Vollan  
+
+[macOS] Register with accessibility when the WebContent process starts
+https://bugs.webkit.org/show_bug.cgi?id=208960
+
+Reviewed by Brent Fulgham.
+
+When we reenabled CF prefs direct mode in , we started to register
+with accessibility when we received a message to do so from the UI process. This would typically happen when the user
+enabled accessibility. On macOS, this notification does not work the same way as on iOS, and it is assumed that
+accessibility should always be enabled. Therefore we should go back to registering with accessibility on startup of
+the WebContent process on macOS.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::platformInitializeProcess):
+(WebKit::WebProcess::unblockAccessibilityServer):
+
 2020-03-11  Alan Coon  
 
 Cherry-pick r258296. rdar://problem/60348995


Modified: branches/safari-610.1.7-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (258305 => 258306)

--- branches/safari-610.1.7-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-03-12 01:35:26 UTC (rev 258305)
+++ branches/safari-610.1.7-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-03-12 01:43:56 UTC (rev 258306)
@@ -582,6 +582,10 @@
 else
 m_processType = ProcessType::WebContent;
 
+#if PLATFORM(MAC)
+registerWithAccessibility();
+#endif
+
 #if USE(OS_STATE)
 registerWithStateDumper();
 #endif
@@ -1030,9 +1034,9 @@
 #if PLATFORM(IOS_FAMILY)
 bool ok = SandboxExtension::consumePermanently(handle);
 ASSERT_UNUSED(ok, ok);
-#endif
 
 registerWithAccessibility();
+#endif
 }
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258303] trunk

[commit-queue]

Title: [258303] trunk








Revision 258303
Author commit-qu...@webkit.org
Date 2020-03-11 18:22:09 -0700 (Wed, 11 Mar 2020)


Log Message
AX: accessibilityReplaceRange:withText: doesn't post an AXValueChanged notification like when typing with kb
https://bugs.webkit.org/show_bug.cgi?id=208332


Patch by Canhai Chen  on 2020-03-11
Reviewed by Chris Fleizach.

Source/WebCore:

When accessibilityReplaceRange:withText: is called to insert or replace text, there should be a
AXValueChanged notification posted with the correct user info to notify the AX client that the text value
has been changed with detailed info about the change.

Post a notification in Editor::replaceSelectionWithFragment for EditAction::Insert edit type
with replaced text and selection.

Add a new test for text replacement value change notification in editable div, text input, and textarea,
including direct text insertion and replace-and-insert.

Test: accessibility/mac/replace-text-with-range-value-change-notification.html

* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
* editing/ReplaceSelectionCommand.h:
(WebCore::ReplaceSelectionCommand::documentFragmentPlainText const):

LayoutTests:

Test text replacement value change notification in editable div, text input, and textarea,
including direct text insertion and replace-and-insert.

* accessibility/mac/replace-text-with-range-value-change-notification-expected.txt: Added.
* accessibility/mac/replace-text-with-range-value-change-notification.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.h


Added Paths

trunk/LayoutTests/accessibility/mac/replace-text-with-range-value-change-notification-expected.txt
trunk/LayoutTests/accessibility/mac/replace-text-with-range-value-change-notification.html




Diff

Modified: trunk/LayoutTests/ChangeLog (258302 => 258303)

--- trunk/LayoutTests/ChangeLog	2020-03-12 01:10:16 UTC (rev 258302)
+++ trunk/LayoutTests/ChangeLog	2020-03-12 01:22:09 UTC (rev 258303)
@@ -1,3 +1,17 @@
+2020-03-11  Canhai Chen  
+
+AX: accessibilityReplaceRange:withText: doesn't post an AXValueChanged notification like when typing with kb
+https://bugs.webkit.org/show_bug.cgi?id=208332
+
+
+Reviewed by Chris Fleizach.
+
+Test text replacement value change notification in editable div, text input, and textarea,
+including direct text insertion and replace-and-insert.
+
+* accessibility/mac/replace-text-with-range-value-change-notification-expected.txt: Added.
+* accessibility/mac/replace-text-with-range-value-change-notification.html: Added.
+
 2020-03-11  Justin Fan  
 
 [WebGL] Additional WebGL bot gardening


Added: trunk/LayoutTests/accessibility/mac/replace-text-with-range-value-change-notification-expected.txt (0 => 258303)

--- trunk/LayoutTests/accessibility/mac/replace-text-with-range-value-change-notification-expected.txt	(rev 0)
+++ trunk/LayoutTests/accessibility/mac/replace-text-with-range-value-change-notification-expected.txt	2020-03-12 01:22:09 UTC (rev 258303)
@@ -0,0 +1,46 @@
+This tests that when we are calling the replace with range API to insert or replace text, value change notifications are posted as expected with correct user info data.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS addedNotification is true
+PASS axContentEditableDiv.replaceTextInRange('Apple', 0, 0) is true
+PASS axContentEditableDiv.stringValue is 'AXValue: Apple'
+PASS axContentEditableDiv.replaceTextInRange('Pie', 0, 5) is true
+PASS axContentEditableDiv.stringValue is 'AXValue: Pie'
+PASS axText.replaceTextInRange('Banana', 0, 0) is true
+PASS axText.stringValue is 'AXValue: Banana'
+PASS axText.replaceTextInRange('Ice-cream', 0, 6) is true
+PASS axText.stringValue is 'AXValue: Ice-cream'
+PASS axTextarea.replaceTextInRange('Cat', 0, 0) is true
+PASS axTextarea.stringValue is 'AXValue: Cat'
+PASS actualChangeTypes[resultIndex] is AXTextStateChangeTypeEdit
+PASS actualChangeValues[resultIndex] is expectedValues[resultIndex]
+PASS actualEditTypes[resultIndex] is "Insert"
+PASS actualChangeTypes[resultIndex] is AXTextStateChangeTypeEdit
+PASS actualChangeValues[resultIndex][0] is expectedValues[resultIndex][0]
+PASS actualEditTypes[resultIndex][0] is "Delete"
+PASS actualChangeValues[resultIndex][1] is expectedValues[resultIndex][1]
+PASS actualEditTypes[resultIndex][1] is "Insert"
+PASS actualChangeTypes[resultIndex] is AXTextStateChangeTypeEdit
+PASS actualChangeValues[resultIndex] is expectedValues[resultIndex]
+PASS actualEditTypes[resultIndex] is "Insert"
+PASS actualChangeTypes[resultIndex] is AXTextStateChangeTypeEdit
+PASS actualChangeValues[resultIndex][0] is expectedValues[resultIndex][0]
+PASS actualEditTypes[resultIndex][0] is "Delete"
+PASS actualChangeValues[resultIndex][1] 

[webkit-changes] [258304] trunk/Source/WebKit

[pvollan]

Title: [258304] trunk/Source/WebKit








Revision 258304
Author pvol...@apple.com
Date 2020-03-11 18:22:17 -0700 (Wed, 11 Mar 2020)


Log Message
[macOS] Register with accessibility when the WebContent process starts
https://bugs.webkit.org/show_bug.cgi?id=208960

Reviewed by Brent Fulgham.

When we reenabled CF prefs direct mode in , we started to register
with accessibility when we received a message to do so from the UI process. This would typically happen when the user
enabled accessibility. On macOS, this notification does not work the same way as on iOS, and it is assumed that
accessibility should always be enabled. Therefore we should go back to registering with accessibility on startup of
the WebContent process on macOS.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeProcess):
(WebKit::WebProcess::unblockAccessibilityServer):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (258303 => 258304)

--- trunk/Source/WebKit/ChangeLog	2020-03-12 01:22:09 UTC (rev 258303)
+++ trunk/Source/WebKit/ChangeLog	2020-03-12 01:22:17 UTC (rev 258304)
@@ -1,3 +1,20 @@
+2020-03-11  Per Arne Vollan  
+
+[macOS] Register with accessibility when the WebContent process starts
+https://bugs.webkit.org/show_bug.cgi?id=208960
+
+Reviewed by Brent Fulgham.
+
+When we reenabled CF prefs direct mode in , we started to register
+with accessibility when we received a message to do so from the UI process. This would typically happen when the user
+enabled accessibility. On macOS, this notification does not work the same way as on iOS, and it is assumed that
+accessibility should always be enabled. Therefore we should go back to registering with accessibility on startup of
+the WebContent process on macOS.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::platformInitializeProcess):
+(WebKit::WebProcess::unblockAccessibilityServer):
+
 2020-03-11  Don Olmstead  
 
 [GPUP] RemoteAudioDestination classes should require ENABLE(WEB_AUDIO)


Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (258303 => 258304)

--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-03-12 01:22:09 UTC (rev 258303)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-03-12 01:22:17 UTC (rev 258304)
@@ -528,6 +528,10 @@
 else
 m_processType = ProcessType::WebContent;
 
+#if PLATFORM(MAC)
+registerWithAccessibility();
+#endif
+
 #if USE(OS_STATE)
 registerWithStateDumper();
 #endif
@@ -976,9 +980,9 @@
 #if PLATFORM(IOS_FAMILY)
 bool ok = SandboxExtension::consumePermanently(handle);
 ASSERT_UNUSED(ok, ok);
-#endif
 
 registerWithAccessibility();
+#endif
 }
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258301] branches/safari-610.1.7-branch/Source/WebCore

[repstein]

Title: [258301] branches/safari-610.1.7-branch/Source/WebCore








Revision 258301
Author repst...@apple.com
Date 2020-03-11 17:33:51 -0700 (Wed, 11 Mar 2020)


Log Message
Cherry-pick r258297. rdar://problem/60347323

AX: Isolated tree: enabling secondary thread for the wrong clients
https://bugs.webkit.org/show_bug.cgi?id=208950

Reviewed by Chris Fleizach.

Removed incorrect call to _AXUIElementUseSecondaryAXThread and wrap it
in initializeSecondaryAXThread with the appropriate checks.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::isolatedTreeFocusedObject):
(WebCore::AXObjectCache::initializeSecondaryAXThread):
(WebCore::AXObjectCache::isolatedTreeRootObject):
* accessibility/AXObjectCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.7-branch/Source/WebCore/ChangeLog
branches/safari-610.1.7-branch/Source/WebCore/accessibility/AXObjectCache.cpp
branches/safari-610.1.7-branch/Source/WebCore/accessibility/AXObjectCache.h




Diff

Modified: branches/safari-610.1.7-branch/Source/WebCore/ChangeLog (258300 => 258301)

--- branches/safari-610.1.7-branch/Source/WebCore/ChangeLog	2020-03-12 00:33:47 UTC (rev 258300)
+++ branches/safari-610.1.7-branch/Source/WebCore/ChangeLog	2020-03-12 00:33:51 UTC (rev 258301)
@@ -1,3 +1,40 @@
+2020-03-11  Alan Coon  
+
+Cherry-pick r258297. rdar://problem/60347323
+
+AX: Isolated tree: enabling secondary thread for the wrong clients
+https://bugs.webkit.org/show_bug.cgi?id=208950
+
+Reviewed by Chris Fleizach.
+
+Removed incorrect call to _AXUIElementUseSecondaryAXThread and wrap it
+in initializeSecondaryAXThread with the appropriate checks.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::isolatedTreeFocusedObject):
+(WebCore::AXObjectCache::initializeSecondaryAXThread):
+(WebCore::AXObjectCache::isolatedTreeRootObject):
+* accessibility/AXObjectCache.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258297 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-11  Andres Gonzalez  
+
+AX: Isolated tree: enabling secondary thread for the wrong clients
+https://bugs.webkit.org/show_bug.cgi?id=208950
+
+Reviewed by Chris Fleizach.
+
+Removed incorrect call to _AXUIElementUseSecondaryAXThread and wrap it
+in initializeSecondaryAXThread with the appropriate checks.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::isolatedTreeFocusedObject):
+(WebCore::AXObjectCache::initializeSecondaryAXThread):
+(WebCore::AXObjectCache::isolatedTreeRootObject):
+* accessibility/AXObjectCache.h:
+
 2020-03-10  Russell Epstein  
 
 Cherry-pick r258229. rdar://problem/60299543


Modified: branches/safari-610.1.7-branch/Source/WebCore/accessibility/AXObjectCache.cpp (258300 => 258301)

--- branches/safari-610.1.7-branch/Source/WebCore/accessibility/AXObjectCache.cpp	2020-03-12 00:33:47 UTC (rev 258300)
+++ branches/safari-610.1.7-branch/Source/WebCore/accessibility/AXObjectCache.cpp	2020-03-12 00:33:51 UTC (rev 258301)
@@ -392,11 +392,7 @@
 auto tree = AXIsolatedTree::treeForPageID(*pageID);
 if (!tree) {
 tree = generateIsolatedTree(*pageID, document);
-// Now that we have created our tree, initialize the secondary thread,
-// so future requests come in on the other thread.
-if (_AXSIsolatedTreeModeFunctionIsAvailable() && _AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread)
-_AXUIElementUseSecondaryAXThread(true);
-_AXUIElementUseSecondaryAXThread(true);
+initializeSecondaryAXThread();
 }
 
 if (tree)
@@ -749,6 +745,15 @@
 }
 
 #if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+
+void AXObjectCache::initializeSecondaryAXThread()
+{
+// Now that we have created our tree, initialize the secondary thread,
+// so future requests come in on the other thread.
+if (_AXSIsolatedTreeModeFunctionIsAvailable() && _AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread)
+_AXUIElementUseSecondaryAXThread(true);
+}
+
 AXCoreObject* AXObjectCache::isolatedTreeRootObject()
 {
 if (!m_pageID)
@@ -759,11 +764,7 @@
 tree = Accessibility::retrieveValueFromMainThread>([this] () -> RefPtr {
 return generateIsolatedTree(*m_pageID, m_document);
 });
-
-// Now that we have created our tree, initialize the secondary thread,
-// so future requests come in on the other thread.
-if (_AXSIsolatedTreeModeFunctionIsAvailable() && _AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread)
-_AXUIElementUseSecondaryAXThread(true);
+AXObjectCache::initializeSecondaryAXThread();
 }
 
 if (tree)


Modified: 

[webkit-changes] [258300] branches/safari-610.1.7-branch/Source/WebKit

[repstein]

Title: [258300] branches/safari-610.1.7-branch/Source/WebKit








Revision 258300
Author repst...@apple.com
Date 2020-03-11 17:33:47 -0700 (Wed, 11 Mar 2020)


Log Message
Cherry-pick r258296. rdar://problem/60348995

Add a parameter to allow ignoring app-bound domain categorization
https://bugs.webkit.org/show_bug.cgi?id=208949


Reviewed by Brent Fulgham.

Introduce a new parameter to ignore app-bound domain categorization
for specific WebViews.

* UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::ignoresAppBoundDomains const):
(API::PageConfiguration::setIgnoresAppBoundDomains):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.7-branch/Source/WebKit/ChangeLog
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.h
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (258299 => 258300)

--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-12 00:30:58 UTC (rev 258299)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-12 00:33:47 UTC (rev 258300)
@@ -1,5 +1,52 @@
 2020-03-11  Alan Coon  
 
+Cherry-pick r258296. rdar://problem/60348995
+
+Add a parameter to allow ignoring app-bound domain categorization
+https://bugs.webkit.org/show_bug.cgi?id=208949
+
+
+Reviewed by Brent Fulgham.
+
+Introduce a new parameter to ignore app-bound domain categorization
+for specific WebViews.
+
+* UIProcess/API/APIPageConfiguration.h:
+(API::PageConfiguration::ignoresAppBoundDomains const):
+(API::PageConfiguration::setIgnoresAppBoundDomains):
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
+(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):
+* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-11  Kate Cheney  
+
+Add a parameter to allow ignoring app-bound domain categorization
+https://bugs.webkit.org/show_bug.cgi?id=208949
+
+
+Reviewed by Brent Fulgham.
+
+Introduce a new parameter to ignore app-bound domain categorization
+for specific WebViews.
+
+* UIProcess/API/APIPageConfiguration.h:
+(API::PageConfiguration::ignoresAppBoundDomains const):
+(API::PageConfiguration::setIgnoresAppBoundDomains):
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
+(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):
+* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
+
+2020-03-11  Alan Coon  
+
 Cherry-pick r258289. rdar://problem/60341123
 
 [macOS] Crash under WebKit::WebProcessPool::platformInitialize()


Modified: branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp (258299 => 258300)

--- branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp	2020-03-12 00:30:58 UTC (rev 258299)
+++ branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp	2020-03-12 00:33:47 UTC (rev 258300)
@@ -94,6 +94,7 @@
 copy->m_webViewCategory = this->m_webViewCategory;
 
 copy->m_processDisplayName = this->m_processDisplayName;
+copy->m_ignoresAppBoundDomains = this->m_ignoresAppBoundDomains;
 
 return copy;
 }


Modified: branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.h (258299 => 258300)

--- branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.h	2020-03-12 00:30:58 UTC (rev 258299)
+++ branches/safari-610.1.7-branch/Source/WebKit/UIProcess/API/APIPageConfiguration.h	2020-03-12 00:33:47 UTC (rev 258300)
@@ -147,6 +147,9 @@
 WebKit::WebViewCategory webViewCategory() const { return m_webViewCategory; }
 void 

[webkit-changes] [258299] trunk/LayoutTests

[justin_fan]

Title: [258299] trunk/LayoutTests








Revision 258299
Author justin_...@apple.com
Date 2020-03-11 17:30:58 -0700 (Wed, 11 Mar 2020)


Log Message
[WebGL] Additional WebGL bot gardening
https://bugs.webkit.org/show_bug.cgi?id=208961

Unreviewed test gardening.

* webgl/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/webgl/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (258298 => 258299)

--- trunk/LayoutTests/ChangeLog	2020-03-11 23:58:38 UTC (rev 258298)
+++ trunk/LayoutTests/ChangeLog	2020-03-12 00:30:58 UTC (rev 258299)
@@ -1,3 +1,12 @@
+2020-03-11  Justin Fan  
+
+[WebGL] Additional WebGL bot gardening
+https://bugs.webkit.org/show_bug.cgi?id=208961
+
+Unreviewed test gardening.
+
+* webgl/TestExpectations:
+
 2020-03-11  Jiewen Tan  
 
 [WebAuthn] Formalize the Keychain schema


Modified: trunk/LayoutTests/webgl/TestExpectations (258298 => 258299)

--- trunk/LayoutTests/webgl/TestExpectations	2020-03-11 23:58:38 UTC (rev 258298)
+++ trunk/LayoutTests/webgl/TestExpectations	2020-03-12 00:30:58 UTC (rev 258299)
@@ -11,9 +11,12 @@
 
 # Flaky time outs
 webgl/2.0.0/deqp/functional/gles3/shaderoperator/angle_and_trigonometry_01.html [ Timeout Pass ]
+webgl/2.0.0/deqp/functional/gles3/vertexarrays/single_attribute.first.html [ Timeout Pass ]
 
 # DEQP flaky results
 webgl/2.0.0/deqp/functional/gles3/builtinprecision [ Pass Failure ]
+webgl/2.0.0/deqp/functional/gles3/pixelbufferobject.html [ Pass Failure ]
+webgl/2.0.0/deqp/functional/gles3/shaderbuiltinvar.html [ Pass Failure ]
 
 # DEQP crashes
 webgl/2.0.0/deqp/functional/gles3/fbomultisample.2_samples.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258298] trunk/Source/WebKit

[pvollan]

Title: [258298] trunk/Source/WebKit








Revision 258298
Author pvol...@apple.com
Date 2020-03-11 16:58:38 -0700 (Wed, 11 Mar 2020)


Log Message
Unreviewed, reverting r258294.
https://bugs.webkit.org/show_bug.cgi?id=208957

Introduced API failure (Requested by perarne on #webkit).

Reverted changeset:

"[macOS] _AXSApplicationAccessibilityEnabled should not be
called"
https://bugs.webkit.org/show_bug.cgi?id=208953
https://trac.webkit.org/changeset/258294

Patch by Commit Queue  on 2020-03-11

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (258297 => 258298)

--- trunk/Source/WebKit/ChangeLog	2020-03-11 23:56:44 UTC (rev 258297)
+++ trunk/Source/WebKit/ChangeLog	2020-03-11 23:58:38 UTC (rev 258298)
@@ -1,3 +1,17 @@
+2020-03-11  Commit Queue  
+
+Unreviewed, reverting r258294.
+https://bugs.webkit.org/show_bug.cgi?id=208957
+
+Introduced API failure (Requested by perarne on #webkit).
+
+Reverted changeset:
+
+"[macOS] _AXSApplicationAccessibilityEnabled should not be
+called"
+https://bugs.webkit.org/show_bug.cgi?id=208953
+https://trac.webkit.org/changeset/258294
+
 2020-03-11  Kate Cheney  
 
 Add a parameter to allow ignoring app-bound domain categorization


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258297 => 258298)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 23:56:44 UTC (rev 258297)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 23:58:38 UTC (rev 258298)
@@ -455,10 +455,7 @@
 }
 
 #if ENABLE(CFPREFS_DIRECT_MODE)
-#if PLATFORM(IOS_FAMILY)
-if (_AXSApplicationAccessibilityEnabled())
-#endif
-{
+if (libAccessibilityLibrary() && _AXSApplicationAccessibilityEnabled()) {
 SandboxExtension::Handle preferencesExtensionHandle;
 SandboxExtension::createHandleForMachLookup("com.apple.cfprefsd.daemon", WTF::nullopt, preferencesExtensionHandle);
 parameters.preferencesExtensionHandle = WTFMove(preferencesExtensionHandle);


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258297 => 258298)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 23:56:44 UTC (rev 258297)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 23:58:38 UTC (rev 258298)
@@ -46,6 +46,10 @@
 
 namespace WebKit {
 
+#if PLATFORM(MAC)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
+#endif
+
 static const Seconds unexpectedActivityDuration = 10_s;
 
 const HashSet& WebProcessProxy::platformPathsWithAssumedReadAccess()
@@ -210,10 +214,12 @@
 {
 if (m_hasSentMessageToUnblockAccessibilityServer)
 return;
-#if PLATFORM(IOS_FAMILY)
+#if PLATFORM(MAC)
+if (!WebKit::libAccessibilityLibrary())
+return;
+#endif
 if (!_AXSApplicationAccessibilityEnabled())
 return;
-#endif
 if (!processIdentifier())
 return;
 if (!canSendMessage())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258297] trunk/Source/WebCore

[andresg_22]

Title: [258297] trunk/Source/WebCore








Revision 258297
Author andresg...@apple.com
Date 2020-03-11 16:56:44 -0700 (Wed, 11 Mar 2020)


Log Message
AX: Isolated tree: enabling secondary thread for the wrong clients
https://bugs.webkit.org/show_bug.cgi?id=208950

Reviewed by Chris Fleizach.

Removed incorrect call to _AXUIElementUseSecondaryAXThread and wrap it
in initializeSecondaryAXThread with the appropriate checks.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::isolatedTreeFocusedObject):
(WebCore::AXObjectCache::initializeSecondaryAXThread):
(WebCore::AXObjectCache::isolatedTreeRootObject):
* accessibility/AXObjectCache.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXObjectCache.cpp
trunk/Source/WebCore/accessibility/AXObjectCache.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (258296 => 258297)

--- trunk/Source/WebCore/ChangeLog	2020-03-11 23:53:58 UTC (rev 258296)
+++ trunk/Source/WebCore/ChangeLog	2020-03-11 23:56:44 UTC (rev 258297)
@@ -1,3 +1,19 @@
+2020-03-11  Andres Gonzalez  
+
+AX: Isolated tree: enabling secondary thread for the wrong clients
+https://bugs.webkit.org/show_bug.cgi?id=208950
+
+Reviewed by Chris Fleizach.
+
+Removed incorrect call to _AXUIElementUseSecondaryAXThread and wrap it
+in initializeSecondaryAXThread with the appropriate checks.
+
+* accessibility/AXObjectCache.cpp:
+(WebCore::AXObjectCache::isolatedTreeFocusedObject):
+(WebCore::AXObjectCache::initializeSecondaryAXThread):
+(WebCore::AXObjectCache::isolatedTreeRootObject):
+* accessibility/AXObjectCache.h:
+
 2020-03-11  Jer Noble  
 
 [EME] Issue an "encrypted" event when a new encrypted initialization segment is encountered


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.cpp (258296 => 258297)

--- trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2020-03-11 23:53:58 UTC (rev 258296)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.cpp	2020-03-11 23:56:44 UTC (rev 258297)
@@ -393,11 +393,7 @@
 auto tree = AXIsolatedTree::treeForPageID(*pageID);
 if (!tree) {
 tree = generateIsolatedTree(*pageID, document);
-// Now that we have created our tree, initialize the secondary thread,
-// so future requests come in on the other thread.
-if (_AXSIsolatedTreeModeFunctionIsAvailable() && _AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread)
-_AXUIElementUseSecondaryAXThread(true);
-_AXUIElementUseSecondaryAXThread(true);
+initializeSecondaryAXThread();
 }
 
 if (tree)
@@ -750,6 +746,15 @@
 }
 
 #if ENABLE(ACCESSIBILITY_ISOLATED_TREE)
+
+void AXObjectCache::initializeSecondaryAXThread()
+{
+// Now that we have created our tree, initialize the secondary thread,
+// so future requests come in on the other thread.
+if (_AXSIsolatedTreeModeFunctionIsAvailable() && _AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread)
+_AXUIElementUseSecondaryAXThread(true);
+}
+
 AXCoreObject* AXObjectCache::isolatedTreeRootObject()
 {
 if (!m_pageID)
@@ -760,11 +765,7 @@
 tree = Accessibility::retrieveValueFromMainThread>([this] () -> RefPtr {
 return generateIsolatedTree(*m_pageID, m_document);
 });
-
-// Now that we have created our tree, initialize the secondary thread,
-// so future requests come in on the other thread.
-if (_AXSIsolatedTreeModeFunctionIsAvailable() && _AXSIsolatedTreeMode_Soft() == AXSIsolatedTreeModeSecondaryThread)
-_AXUIElementUseSecondaryAXThread(true);
+AXObjectCache::initializeSecondaryAXThread();
 }
 
 if (tree)


Modified: trunk/Source/WebCore/accessibility/AXObjectCache.h (258296 => 258297)

--- trunk/Source/WebCore/accessibility/AXObjectCache.h	2020-03-11 23:53:58 UTC (rev 258296)
+++ trunk/Source/WebCore/accessibility/AXObjectCache.h	2020-03-11 23:56:44 UTC (rev 258297)
@@ -360,6 +360,7 @@
 void setIsolatedTreeFocusedObject(Node*);
 static Ref generateIsolatedTree(PageIdentifier, Document&);
 void updateIsolatedTree(AXCoreObject*, AXNotification);
+static void initializeSecondaryAXThread();
 #endif
 
 protected:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258296] trunk/Source/WebKit

[katherine_cheney]

Title: [258296] trunk/Source/WebKit








Revision 258296
Author katherine_che...@apple.com
Date 2020-03-11 16:53:58 -0700 (Wed, 11 Mar 2020)


Log Message
Add a parameter to allow ignoring app-bound domain categorization
https://bugs.webkit.org/show_bug.cgi?id=208949


Reviewed by Brent Fulgham.

Introduce a new parameter to ignore app-bound domain categorization
for specific WebViews.

* UIProcess/API/APIPageConfiguration.h:
(API::PageConfiguration::ignoresAppBoundDomains const):
(API::PageConfiguration::setIgnoresAppBoundDomains):
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):
* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp
trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (258295 => 258296)

--- trunk/Source/WebKit/ChangeLog	2020-03-11 23:49:59 UTC (rev 258295)
+++ trunk/Source/WebKit/ChangeLog	2020-03-11 23:53:58 UTC (rev 258296)
@@ -1,3 +1,24 @@
+2020-03-11  Kate Cheney  
+
+Add a parameter to allow ignoring app-bound domain categorization
+https://bugs.webkit.org/show_bug.cgi?id=208949
+
+
+Reviewed by Brent Fulgham.
+
+Introduce a new parameter to ignore app-bound domain categorization
+for specific WebViews.
+
+* UIProcess/API/APIPageConfiguration.h:
+(API::PageConfiguration::ignoresAppBoundDomains const):
+(API::PageConfiguration::setIgnoresAppBoundDomains):
+* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+(-[WKWebViewConfiguration _ignoresAppBoundDomains]):
+(-[WKWebViewConfiguration _setIgnoresAppBoundDomains:]):
+* UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::setIsNavigatingToAppBoundDomain):
+
 2020-03-11  Per Arne Vollan  
 
 [macOS] _AXSApplicationAccessibilityEnabled should not be called


Modified: trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp (258295 => 258296)

--- trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp	2020-03-11 23:49:59 UTC (rev 258295)
+++ trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.cpp	2020-03-11 23:53:58 UTC (rev 258296)
@@ -94,6 +94,7 @@
 copy->m_webViewCategory = this->m_webViewCategory;
 
 copy->m_processDisplayName = this->m_processDisplayName;
+copy->m_ignoresAppBoundDomains = this->m_ignoresAppBoundDomains;
 
 return copy;
 }


Modified: trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h (258295 => 258296)

--- trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h	2020-03-11 23:49:59 UTC (rev 258295)
+++ trunk/Source/WebKit/UIProcess/API/APIPageConfiguration.h	2020-03-11 23:53:58 UTC (rev 258296)
@@ -147,6 +147,9 @@
 WebKit::WebViewCategory webViewCategory() const { return m_webViewCategory; }
 void setWebViewCategory(WebKit::WebViewCategory category) { m_webViewCategory = category; }
 
+bool ignoresAppBoundDomains() const { return m_ignoresAppBoundDomains; }
+void setIgnoresAppBoundDomains(bool shouldIgnore) { m_ignoresAppBoundDomains = shouldIgnore; }
+
 private:
 
 RefPtr m_processPool;
@@ -187,6 +190,7 @@
 bool m_crossOriginAccessControlCheckEnabled { true };
 WTF::String m_processDisplayName;
 WebKit::WebViewCategory m_webViewCategory { WebKit::WebViewCategory::AppBoundDomain };
+bool m_ignoresAppBoundDomains { false };
 };
 
 } // namespace API


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (258295 => 258296)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2020-03-11 23:49:59 UTC (rev 258295)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm	2020-03-11 23:53:58 UTC (rev 258296)
@@ -1210,6 +1210,16 @@
 _pageConfiguration->setWebViewCategory(toWebKitWebViewCategory(category));
 }
 
+- (BOOL)_ignoresAppBoundDomains
+{
+return _pageConfiguration->ignoresAppBoundDomains();
+}
+
+- (void)_setIgnoresAppBoundDomains:(BOOL)ignoresAppBoundDomains
+{
+_pageConfiguration->setIgnoresAppBoundDomains(ignoresAppBoundDomains);
+}
+
 - (NSString *)_processDisplayName
 {
 return _pageConfiguration->processDisplayName();


Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h (258295 => 258296)

--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h	2020-03-11 23:49:59 UTC (rev 258295)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h	2020-03-11 23:53:58 UTC (rev 258296)
@@ -122,6 

[webkit-changes] [258295] trunk/Source

[jer . noble]

Title: [258295] trunk/Source








Revision 258295
Author jer.no...@apple.com
Date 2020-03-11 16:49:59 -0700 (Wed, 11 Mar 2020)


Log Message
[EME] Issue an "encrypted" event when a new encrypted initialization segment is encountered
https://bugs.webkit.org/show_bug.cgi?id=208923

Reviewed by Eric Carlson.

Source/WebCore:

When AVStreamDataParser encounters an initialization segment indicating encrypted content, it
will issue a -streamDataParser:didProvideContentKeyRequestInitializationData:forTrackID: message
to its delegate. If the parser is already associated with an AVContentKeySession, it will instead
allow the session to handle the initialization segment and the delagete method will not be called.

When the latter situation occurs, we can detect that the -didProvideRequest callback did not
occur due to the client calling MediaKeySession.generateRequest() and therefore must have been
due to parsing an encrypted segment. In response, store the request in a list of "unexpected"
requests to be checked the next time a MediaKeySession tries to generateRequest(). Then, we will
pass the initalizationData and type to HTMLMediaElement through a new client interface, where it
will use that initializationData to issue an "encrypted" event. If the client passes that same
initializationData back into MediaKeySession, the "unexpected" request can be found, and re-used.

Drive-by fixes: Added a ton of debug logging messages to the CDMPrivate classes.

* Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::CDM):
* Modules/encryptedmedia/CDM.h:
* Modules/encryptedmedia/CDMClient.h:
* Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::create):
(WebCore::MediaKeySession::MediaKeySession):
* Modules/encryptedmedia/MediaKeySession.h:
* Modules/encryptedmedia/MediaKeySystemAccess.cpp:
(WebCore::MediaKeySystemAccess::createMediaKeys):
* Modules/encryptedmedia/MediaKeySystemAccess.h:
* Modules/encryptedmedia/MediaKeySystemAccess.idl:
* Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::MediaKeys):
(WebCore::MediaKeys::createSession):
(WebCore::MediaKeys::setServerCertificate):
(WebCore::MediaKeys::attachCDMClient):
(WebCore::MediaKeys::detachCDMClient):
(WebCore::MediaKeys::attemptToResumePlaybackOnClients):
(WebCore::MediaKeys::unrequestedInitializationDataReceived):
(WebCore::MediaKeys::nextChildIdentifier const):
* Modules/encryptedmedia/MediaKeys.h:
(WebCore::MediaKeys::create): Deleted.
(WebCore::MediaKeys::cdmInstance): Deleted.
(WebCore::MediaKeys::cdmInstance const): Deleted.
* Modules/encryptedmedia/MediaKeys.idl:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::cdmClientUnrequestedInitializationDataReceived):
* html/HTMLMediaElement.h:
* platform/encryptedmedia/CDMFactory.h:
* platform/encryptedmedia/CDMInstance.h:
(WebCore::CDMInstance::setClient):
(WebCore::CDMInstance::clearClient):
(WebCore::CDMInstance::setLogger):
* platform/encryptedmedia/CDMInstanceSession.h:
(WebCore::CDMInstanceSession::setLogger):
(WebCore::CDMInstanceSession::setClient):
* platform/encryptedmedia/CDMPrivate.h:
(WebCore::CDMPrivate::setLogger):
* platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::logChannel):
(WebCore::CDMPrivateFairPlayStreaming::setLogger):
(WebCore::CDMPrivateFairPlayStreaming::supportsConfiguration const):
* platform/graphics/avfoundation/CDMFairPlayStreaming.h:
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
* platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::logChannel):
(WebCore::initTypeForRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setLogger):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::takeUnexpectedKeyRequestForInitializationData):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setServerCertificate):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setStorageDirectory):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::setClient):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::clearClient):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRequests):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didProvidePersistableRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::requestDidSucceed):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::shouldRetryRequestForReason):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::groupSessionIdentifierChanged):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForRequest const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::setLogger):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::loadSession):

[webkit-changes] [258294] trunk/Source/WebKit

[pvollan]

Title: [258294] trunk/Source/WebKit








Revision 258294
Author pvol...@apple.com
Date 2020-03-11 16:27:19 -0700 (Wed, 11 Mar 2020)


Log Message
[macOS] _AXSApplicationAccessibilityEnabled should not be called
https://bugs.webkit.org/show_bug.cgi?id=208953

Reviewed by Brent Fulgham.

This function should only be called on iOS, not on macOS.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (258293 => 258294)

--- trunk/Source/WebKit/ChangeLog	2020-03-11 22:42:08 UTC (rev 258293)
+++ trunk/Source/WebKit/ChangeLog	2020-03-11 23:27:19 UTC (rev 258294)
@@ -1,3 +1,17 @@
+2020-03-11  Per Arne Vollan  
+
+[macOS] _AXSApplicationAccessibilityEnabled should not be called
+https://bugs.webkit.org/show_bug.cgi?id=208953
+
+Reviewed by Brent Fulgham.
+
+This function should only be called on iOS, not on macOS.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::platformInitializeWebProcess):
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
 2020-03-11  Jiewen Tan  
 
 [WebAuthn] Formalize the Keychain schema


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258293 => 258294)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 22:42:08 UTC (rev 258293)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 23:27:19 UTC (rev 258294)
@@ -455,7 +455,10 @@
 }
 
 #if ENABLE(CFPREFS_DIRECT_MODE)
-if (libAccessibilityLibrary() && _AXSApplicationAccessibilityEnabled()) {
+#if PLATFORM(IOS_FAMILY)
+if (_AXSApplicationAccessibilityEnabled())
+#endif
+{
 SandboxExtension::Handle preferencesExtensionHandle;
 SandboxExtension::createHandleForMachLookup("com.apple.cfprefsd.daemon", WTF::nullopt, preferencesExtensionHandle);
 parameters.preferencesExtensionHandle = WTFMove(preferencesExtensionHandle);


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258293 => 258294)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:42:08 UTC (rev 258293)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 23:27:19 UTC (rev 258294)
@@ -46,10 +46,6 @@
 
 namespace WebKit {
 
-#if PLATFORM(MAC)
-SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
-#endif
-
 static const Seconds unexpectedActivityDuration = 10_s;
 
 const HashSet& WebProcessProxy::platformPathsWithAssumedReadAccess()
@@ -214,12 +210,10 @@
 {
 if (m_hasSentMessageToUnblockAccessibilityServer)
 return;
-#if PLATFORM(MAC)
-if (!WebKit::libAccessibilityLibrary())
+#if PLATFORM(IOS_FAMILY)
+if (!_AXSApplicationAccessibilityEnabled())
 return;
 #endif
-if (!_AXSApplicationAccessibilityEnabled())
-return;
 if (!processIdentifier())
 return;
 if (!canSendMessage())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258291] branches/safari-610.1.7-branch/Source/WebKit

[alancoon]

Title: [258291] branches/safari-610.1.7-branch/Source/WebKit








Revision 258291
Author alanc...@apple.com
Date 2020-03-11 15:26:10 -0700 (Wed, 11 Mar 2020)


Log Message
Cherry-pick r258288. rdar://problem/60341123

[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945

Reviewed by Tim Horton.

Check that accessibility library is present before attempting to call functions in it.

No new tests, since I am not able to reproduce.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.7-branch/Source/WebKit/ChangeLog
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm




Diff

Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (258290 => 258291)

--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 22:22:12 UTC (rev 258290)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 22:26:10 UTC (rev 258291)
@@ -1,3 +1,41 @@
+2020-03-11  Alan Coon  
+
+Cherry-pick r258288. rdar://problem/60341123
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+Reviewed by Tim Horton.
+
+Check that accessibility library is present before attempting to call functions in it.
+
+No new tests, since I am not able to reproduce.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::platformInitializeWebProcess):
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+Reviewed by Tim Horton.
+
+Check that accessibility library is present before attempting to call functions in it.
+
+No new tests, since I am not able to reproduce.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::platformInitializeWebProcess):
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
 2020-03-11  Russell Epstein  
 
 Cherry-pick r258225. rdar://problem/60342513


Modified: branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258290 => 258291)

--- branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 22:22:12 UTC (rev 258290)
+++ branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 22:26:10 UTC (rev 258291)
@@ -455,7 +455,7 @@
 }
 
 #if ENABLE(CFPREFS_DIRECT_MODE)
-if (_AXSApplicationAccessibilityEnabled()) {
+if (libAccessibilityLibrary() && _AXSApplicationAccessibilityEnabled()) {
 SandboxExtension::Handle preferencesExtensionHandle;
 SandboxExtension::createHandleForMachLookup("com.apple.cfprefsd.daemon", WTF::nullopt, preferencesExtensionHandle);
 parameters.preferencesExtensionHandle = WTFMove(preferencesExtensionHandle);


Modified: branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258290 => 258291)

--- branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:22:12 UTC (rev 258290)
+++ branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:26:10 UTC (rev 258291)
@@ -44,6 +44,10 @@
 #import <_javascript_Core/RemoteInspectorConstants.h>
 #endif
 
+#if PLATFORM(COCOA)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
+#endif
+
 namespace WebKit {
 
 static const Seconds unexpectedActivityDuration = 10_s;
@@ -230,6 +234,8 @@
 {
 if (m_hasSentMessageToUnblockAccessibilityServer)
 return;
+if (!libAccessibilityLibrary())
+return;
 if (!_AXSApplicationAccessibilityEnabled())
 return;
 if (!processIdentifier())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258292] branches/safari-610.1.7-branch/Source/WebKit

[alancoon]

Title: [258292] branches/safari-610.1.7-branch/Source/WebKit








Revision 258292
Author alanc...@apple.com
Date 2020-03-11 15:26:13 -0700 (Wed, 11 Mar 2020)


Log Message
Cherry-pick r258289. rdar://problem/60341123

[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945

Unreviewed temporary compile fix.

* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.7-branch/Source/WebKit/ChangeLog
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm




Diff

Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (258291 => 258292)

--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 22:26:10 UTC (rev 258291)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 22:26:13 UTC (rev 258292)
@@ -1,5 +1,31 @@
 2020-03-11  Alan Coon  
 
+Cherry-pick r258289. rdar://problem/60341123
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+Unreviewed temporary compile fix.
+
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+Unreviewed temporary compile fix.
+
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
+2020-03-11  Alan Coon  
+
 Cherry-pick r258288. rdar://problem/60341123
 
 [macOS] Crash under WebKit::WebProcessPool::platformInitialize()


Modified: branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258291 => 258292)

--- branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:26:10 UTC (rev 258291)
+++ branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:26:13 UTC (rev 258292)
@@ -44,12 +44,12 @@
 #import <_javascript_Core/RemoteInspectorConstants.h>
 #endif
 
-#if PLATFORM(COCOA)
+namespace WebKit {
+
+#if PLATFORM(MAC)
 SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
 #endif
 
-namespace WebKit {
-
 static const Seconds unexpectedActivityDuration = 10_s;
 
 const HashSet& WebProcessProxy::platformPathsWithAssumedReadAccess()
@@ -234,8 +234,10 @@
 {
 if (m_hasSentMessageToUnblockAccessibilityServer)
 return;
-if (!libAccessibilityLibrary())
+#if PLATFORM(MAC)
+if (!WebKit::libAccessibilityLibrary())
 return;
+#endif
 if (!_AXSApplicationAccessibilityEnabled())
 return;
 if (!processIdentifier())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258290] branches/safari-610.1.7-branch/Source/WebKit

[alancoon]

Title: [258290] branches/safari-610.1.7-branch/Source/WebKit








Revision 258290
Author alanc...@apple.com
Date 2020-03-11 15:22:12 -0700 (Wed, 11 Mar 2020)


Log Message
Cherry-pick r258225. rdar://problem/60342513

File upload cancels before files can be uploaded.
https://bugs.webkit.org/show_bug.cgi?id=208846


Reviewed by Tim Horton.

With the new UIContextMenus, we needed to cancel in order for everything to be
reset correctly in WebCore. But this can only be done in the animation completion
handler, but we only want to cancel if we aren't presenting a different picker.

* UIProcess/ios/forms/WKFileUploadPanel.mm:
(-[WKFileUploadPanel contextMenuInteraction:configurationForMenuAtLocation:]):
(-[WKFileUploadPanel contextMenuInteraction:willEndForConfiguration:animator:]):
(-[WKFileUploadPanel ensureContextMenuInteraction]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.7-branch/Source/WebKit/ChangeLog
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm




Diff

Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (258289 => 258290)

--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 22:18:04 UTC (rev 258289)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 22:22:12 UTC (rev 258290)
@@ -1,3 +1,42 @@
+2020-03-11  Russell Epstein  
+
+Cherry-pick r258225. rdar://problem/60342513
+
+File upload cancels before files can be uploaded.
+https://bugs.webkit.org/show_bug.cgi?id=208846
+
+
+Reviewed by Tim Horton.
+
+With the new UIContextMenus, we needed to cancel in order for everything to be
+reset correctly in WebCore. But this can only be done in the animation completion
+handler, but we only want to cancel if we aren't presenting a different picker.
+
+* UIProcess/ios/forms/WKFileUploadPanel.mm:
+(-[WKFileUploadPanel contextMenuInteraction:configurationForMenuAtLocation:]):
+(-[WKFileUploadPanel contextMenuInteraction:willEndForConfiguration:animator:]):
+(-[WKFileUploadPanel ensureContextMenuInteraction]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-10  Megan Gardner  
+
+File upload cancels before files can be uploaded.
+https://bugs.webkit.org/show_bug.cgi?id=208846
+
+
+Reviewed by Tim Horton.
+
+With the new UIContextMenus, we needed to cancel in order for everything to be
+reset correctly in WebCore. But this can only be done in the animation completion
+handler, but we only want to cancel if we aren't presenting a different picker.
+
+* UIProcess/ios/forms/WKFileUploadPanel.mm:
+(-[WKFileUploadPanel contextMenuInteraction:configurationForMenuAtLocation:]):
+(-[WKFileUploadPanel contextMenuInteraction:willEndForConfiguration:animator:]):
+(-[WKFileUploadPanel ensureContextMenuInteraction]):
+
 2020-03-11  Alan Coon  
 
 Cherry-pick r258284. rdar://problem/60341123


Modified: branches/safari-610.1.7-branch/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (258289 => 258290)

--- branches/safari-610.1.7-branch/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm	2020-03-11 22:18:04 UTC (rev 258289)
+++ branches/safari-610.1.7-branch/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm	2020-03-11 22:22:12 UTC (rev 258290)
@@ -169,6 +169,7 @@
 RetainPtr _presentationViewController; // iPhone always. iPad for Fullscreen Camera.
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 RetainPtr _presentationPopover; // iPad for action sheet and Photo Library.
+BOOL _isPresentingSubMenu;
 ALLOW_DEPRECATED_DECLARATIONS_END
 #if USE(UICONTEXTMENU)
 RetainPtr _documentContextMenuInteraction;
@@ -436,11 +437,14 @@
 if (!strongSelf)
 return nil;
 
+self->_isPresentingSubMenu = NO;
 UIAction *browseAction = [UIAction actionWithTitle:[strongSelf _browseFilesButtonLabel] image:[UIImage systemImageNamed:@"ellipsis"] identifier:@"browse" handler:^(__kindof UIAction *action) {
+self->_isPresentingSubMenu = YES;
 [self showFilePickerMenu];
 }];
 
 UIAction *photoAction = [UIAction actionWithTitle:[strongSelf _photoLibraryButtonLabel] image:[UIImage systemImageNamed:@"rectangle.on.rectangle"] identifier:@"photo" handler:^(__kindof UIAction *action) {
+self->_isPresentingSubMenu = YES;
 [self _showPhotoPickerWithSourceType:UIImagePickerControllerSourceTypePhotoLibrary];
 }];
 
@@ -448,6 +452,7 @@
 NSString *cameraString = [strongSelf _cameraButtonLabelAllowingPhoto:allowsImageMediaType allowingVideo:allowsVideoMediaType];
 UIAction *cameraAction = 

[webkit-changes] [258289] trunk/Source/WebKit

[pvollan]

Title: [258289] trunk/Source/WebKit








Revision 258289
Author pvol...@apple.com
Date 2020-03-11 15:18:04 -0700 (Wed, 11 Mar 2020)


Log Message
[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945

Unreviewed temporary compile fix.

* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (258288 => 258289)

--- trunk/Source/WebKit/ChangeLog	2020-03-11 22:01:20 UTC (rev 258288)
+++ trunk/Source/WebKit/ChangeLog	2020-03-11 22:18:04 UTC (rev 258289)
@@ -3,6 +3,16 @@
 [macOS] Crash under WebKit::WebProcessPool::platformInitialize()
 https://bugs.webkit.org/show_bug.cgi?id=208945
 
+Unreviewed temporary compile fix.
+
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
 Reviewed by Tim Horton.
 
 Check that accessibility library is present before attempting to call functions in it.


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258288 => 258289)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:01:20 UTC (rev 258288)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:18:04 UTC (rev 258289)
@@ -44,12 +44,12 @@
 #import <_javascript_Core/RemoteInspectorConstants.h>
 #endif
 
-#if PLATFORM(COCOA)
+namespace WebKit {
+
+#if PLATFORM(MAC)
 SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
 #endif
 
-namespace WebKit {
-
 static const Seconds unexpectedActivityDuration = 10_s;
 
 const HashSet& WebProcessProxy::platformPathsWithAssumedReadAccess()
@@ -214,8 +214,10 @@
 {
 if (m_hasSentMessageToUnblockAccessibilityServer)
 return;
-if (!libAccessibilityLibrary())
+#if PLATFORM(MAC)
+if (!WebKit::libAccessibilityLibrary())
 return;
+#endif
 if (!_AXSApplicationAccessibilityEnabled())
 return;
 if (!processIdentifier())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258288] trunk/Source/WebKit

[pvollan]

Title: [258288] trunk/Source/WebKit








Revision 258288
Author pvol...@apple.com
Date 2020-03-11 15:01:20 -0700 (Wed, 11 Mar 2020)


Log Message
[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945

Reviewed by Tim Horton.

Check that accessibility library is present before attempting to call functions in it.

No new tests, since I am not able to reproduce.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (258287 => 258288)

--- trunk/Source/WebKit/ChangeLog	2020-03-11 21:57:33 UTC (rev 258287)
+++ trunk/Source/WebKit/ChangeLog	2020-03-11 22:01:20 UTC (rev 258288)
@@ -2,6 +2,22 @@
 
 [macOS] Crash under WebKit::WebProcessPool::platformInitialize()
 https://bugs.webkit.org/show_bug.cgi?id=208945
+
+Reviewed by Tim Horton.
+
+Check that accessibility library is present before attempting to call functions in it.
+
+No new tests, since I am not able to reproduce.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::platformInitializeWebProcess):
+* UIProcess/Cocoa/WebProcessProxyCocoa.mm:
+(WebKit::WebProcessProxy::unblockAccessibilityServerIfNeeded):
+
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
 
 
 Reviewed by Brent Fulgham.


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258287 => 258288)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 21:57:33 UTC (rev 258287)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 22:01:20 UTC (rev 258288)
@@ -455,7 +455,7 @@
 }
 
 #if ENABLE(CFPREFS_DIRECT_MODE)
-if (_AXSApplicationAccessibilityEnabled()) {
+if (libAccessibilityLibrary() && _AXSApplicationAccessibilityEnabled()) {
 SandboxExtension::Handle preferencesExtensionHandle;
 SandboxExtension::createHandleForMachLookup("com.apple.cfprefsd.daemon", WTF::nullopt, preferencesExtensionHandle);
 parameters.preferencesExtensionHandle = WTFMove(preferencesExtensionHandle);


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm (258287 => 258288)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 21:57:33 UTC (rev 258287)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessProxyCocoa.mm	2020-03-11 22:01:20 UTC (rev 258288)
@@ -44,6 +44,10 @@
 #import <_javascript_Core/RemoteInspectorConstants.h>
 #endif
 
+#if PLATFORM(COCOA)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
+#endif
+
 namespace WebKit {
 
 static const Seconds unexpectedActivityDuration = 10_s;
@@ -210,6 +214,8 @@
 {
 if (m_hasSentMessageToUnblockAccessibilityServer)
 return;
+if (!libAccessibilityLibrary())
+return;
 if (!_AXSApplicationAccessibilityEnabled())
 return;
 if (!processIdentifier())






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258287] trunk/Source/WebCore

[dbates]

Title: [258287] trunk/Source/WebCore








Revision 258287
Author dba...@webkit.org
Date 2020-03-11 14:57:33 -0700 (Wed, 11 Mar 2020)


Log Message
REGRESSION (r257502): HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&) should set m_isRectBased to true
https://bugs.webkit.org/show_bug.cgi?id=208947

Reviewed by Wenson Hsieh.

Partial revert of r257502. I accidentally removed initialization of m_isRectBased when refactoring
the code in HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&). Revert this to
be faithful to the code before my change.

* rendering/HitTestLocation.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/HitTestLocation.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (258286 => 258287)

--- trunk/Source/WebCore/ChangeLog	2020-03-11 21:43:04 UTC (rev 258286)
+++ trunk/Source/WebCore/ChangeLog	2020-03-11 21:57:33 UTC (rev 258287)
@@ -1,3 +1,16 @@
+2020-03-11  Daniel Bates  
+
+REGRESSION (r257502): HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&) should set m_isRectBased to true
+https://bugs.webkit.org/show_bug.cgi?id=208947
+
+Reviewed by Wenson Hsieh.
+
+Partial revert of r257502. I accidentally removed initialization of m_isRectBased when refactoring
+the code in HitTestLocation::HitTestLocation(const FloatPoint&, const FloatQuad&). Revert this to
+be faithful to the code before my change.
+
+* rendering/HitTestLocation.cpp:
+
 2020-03-11  Myles C. Maxfield  
 
 icloud.com Notes text in titles and headings is distorted


Modified: trunk/Source/WebCore/rendering/HitTestLocation.cpp (258286 => 258287)

--- trunk/Source/WebCore/rendering/HitTestLocation.cpp	2020-03-11 21:43:04 UTC (rev 258286)
+++ trunk/Source/WebCore/rendering/HitTestLocation.cpp	2020-03-11 21:57:33 UTC (rev 258287)
@@ -44,6 +44,7 @@
 , m_boundingBox { quad.enclosingBoundingBox() }
 , m_transformedPoint { point }
 , m_transformedRect { quad }
+, m_isRectBased { true }
 , m_isRectilinear { quad.isRectilinear() }
 {
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258286] trunk

[keith_miller]

Title: [258286] trunk








Revision 258286
Author keith_mil...@apple.com
Date 2020-03-11 14:43:04 -0700 (Wed, 11 Mar 2020)


Log Message
Test262-runner should always consider crashes as new failures
https://bugs.webkit.org/show_bug.cgi?id=208943

Reviewed by Yusuke Suzuki.

JSTests:

* test262/expectations.yaml:

Source/_javascript_Core:

BigInt.asUintN() / BigInt.asIntN() should not crash when called even if we have
not implemented them yet...

* runtime/BigIntConstructor.cpp:
(JSC::bigIntConstructorFuncAsUintN):
(JSC::bigIntConstructorFuncAsIntN):

Tools:

Right now the runner will consider crashes with no output as passes, which is obviously bad.
Since we should never crash on a conformance test we should consider a crash as a new failure
100% of the time.

* Scripts/test262/Runner.pm:
(processFile):
(runTest):
(processResult):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262/expectations.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/BigIntConstructor.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/test262/Runner.pm




Diff

Modified: trunk/JSTests/ChangeLog (258285 => 258286)

--- trunk/JSTests/ChangeLog	2020-03-11 21:32:13 UTC (rev 258285)
+++ trunk/JSTests/ChangeLog	2020-03-11 21:43:04 UTC (rev 258286)
@@ -1,5 +1,14 @@
 2020-03-11  Keith Miller  
 
+Test262-runner should always consider crashes as new failures
+https://bugs.webkit.org/show_bug.cgi?id=208943
+
+Reviewed by Yusuke Suzuki.
+
+* test262/expectations.yaml:
+
+2020-03-11  Keith Miller  
+
 Throws incorrectly a syntax error when declaring a top level catch variable the same as a parameter
 https://bugs.webkit.org/show_bug.cgi?id=189914
 


Modified: trunk/JSTests/test262/expectations.yaml (258285 => 258286)

--- trunk/JSTests/test262/expectations.yaml	2020-03-11 21:32:13 UTC (rev 258285)
+++ trunk/JSTests/test262/expectations.yaml	2020-03-11 21:43:04 UTC (rev 258286)
@@ -726,6 +726,66 @@
 test/built-ins/AsyncGeneratorFunction/proto-from-ctor-realm.js:
   default: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object AsyncGeneratorFunction]», «[object AsyncGeneratorFunction]») to be true'
   strict mode: 'Test262Error: newTarget.prototype is undefined Expected SameValue(«[object AsyncGeneratorFunction]», «[object AsyncGeneratorFunction]») to be true'
+test/built-ins/BigInt/asIntN/arithmetic.js:
+  default: 'Test262Error: Expected SameValue(«undefined», «0») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«undefined», «0») to be true'
+test/built-ins/BigInt/asIntN/bigint-tobigint-errors.js:
+  default: 'Test262Error: ToBigInt: no argument => undefined => TypeError Expected a TypeError to be thrown but no exception was thrown at all'
+  strict mode: 'Test262Error: ToBigInt: no argument => undefined => TypeError Expected a TypeError to be thrown but no exception was thrown at all'
+test/built-ins/BigInt/asIntN/bigint-tobigint-toprimitive.js:
+  default: 'Test262Error: ToPrimitive: @@toPrimitive takes precedence Expected SameValue(«undefined», «1») to be true'
+  strict mode: 'Test262Error: ToPrimitive: @@toPrimitive takes precedence Expected SameValue(«undefined», «1») to be true'
+test/built-ins/BigInt/asIntN/bigint-tobigint-wrapped-values.js:
+  default: 'Test262Error: ToPrimitive: unbox object with internal slot Expected SameValue(«undefined», «0») to be true'
+  strict mode: 'Test262Error: ToPrimitive: unbox object with internal slot Expected SameValue(«undefined», «0») to be true'
+test/built-ins/BigInt/asIntN/bigint-tobigint.js:
+  default: 'Test262Error: Expected SameValue(«undefined», «0») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«undefined», «0») to be true'
+test/built-ins/BigInt/asIntN/bits-toindex-errors.js:
+  default: 'Test262Error: ToIndex: throw when integerIndex < 0 Expected a RangeError to be thrown but no exception was thrown at all'
+  strict mode: 'Test262Error: ToIndex: throw when integerIndex < 0 Expected a RangeError to be thrown but no exception was thrown at all'
+test/built-ins/BigInt/asIntN/bits-toindex-toprimitive.js:
+  default: 'Test262Error: ToPrimitive: @@toPrimitive takes precedence Expected SameValue(«undefined», «-1») to be true'
+  strict mode: 'Test262Error: ToPrimitive: @@toPrimitive takes precedence Expected SameValue(«undefined», «-1») to be true'
+test/built-ins/BigInt/asIntN/bits-toindex-wrapped-values.js:
+  default: 'Test262Error: ToPrimitive: unbox object with internal slot Expected SameValue(«undefined», «0») to be true'
+  strict mode: 'Test262Error: ToPrimitive: unbox object with internal slot Expected SameValue(«undefined», «0») to be true'
+test/built-ins/BigInt/asIntN/bits-toindex.js:
+  default: 'Test262Error: Expected SameValue(«undefined», «0») to be true'
+  strict mode: 'Test262Error: Expected SameValue(«undefined», «0») to be true'
+test/built-ins/BigInt/asIntN/order-of-steps.js:
+  default: 'Test262Error: Expected SameValue(«0», 

[webkit-changes] [258285] branches/safari-610.1.7-branch/Source

[alancoon]

Title: [258285] branches/safari-610.1.7-branch/Source








Revision 258285
Author alanc...@apple.com
Date 2020-03-11 14:32:13 -0700 (Wed, 11 Mar 2020)


Log Message
Cherry-pick r258284. rdar://problem/60341123

[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945
Source/WebKit:



Reviewed by Brent Fulgham.

Check that accessibility library is present before attempting to use constants from it.

No new tests, since I am unable to reproduce.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

Source/WTF:

Reviewed by Brent Fulgham.

Add macro to optionally soft link library.

* wtf/cocoa/SoftLinking.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.7-branch/Source/WTF/ChangeLog
branches/safari-610.1.7-branch/Source/WTF/wtf/cocoa/SoftLinking.h
branches/safari-610.1.7-branch/Source/WebKit/ChangeLog
branches/safari-610.1.7-branch/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm




Diff

Modified: branches/safari-610.1.7-branch/Source/WTF/ChangeLog (258284 => 258285)

--- branches/safari-610.1.7-branch/Source/WTF/ChangeLog	2020-03-11 21:25:24 UTC (rev 258284)
+++ branches/safari-610.1.7-branch/Source/WTF/ChangeLog	2020-03-11 21:32:13 UTC (rev 258285)
@@ -1,3 +1,47 @@
+2020-03-11  Alan Coon  
+
+Cherry-pick r258284. rdar://problem/60341123
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+Source/WebKit:
+
+
+
+Reviewed by Brent Fulgham.
+
+Check that accessibility library is present before attempting to use constants from it.
+
+No new tests, since I am unable to reproduce.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::registerNotificationObservers):
+(WebKit::WebProcessPool::unregisterNotificationObservers):
+
+Source/WTF:
+
+
+Reviewed by Brent Fulgham.
+
+Add macro to optionally soft link library.
+
+* wtf/cocoa/SoftLinking.h:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+Reviewed by Brent Fulgham.
+
+Add macro to optionally soft link library.
+
+* wtf/cocoa/SoftLinking.h:
+
 2020-03-08  Brady Eidson  
 
 Remember completed subranges during incremental PDF loading.


Modified: branches/safari-610.1.7-branch/Source/WTF/wtf/cocoa/SoftLinking.h (258284 => 258285)

--- branches/safari-610.1.7-branch/Source/WTF/wtf/cocoa/SoftLinking.h	2020-03-11 21:25:24 UTC (rev 258284)
+++ branches/safari-610.1.7-branch/Source/WTF/wtf/cocoa/SoftLinking.h	2020-03-11 21:32:13 UTC (rev 258285)
@@ -42,6 +42,16 @@
 return dylib; \
 }
 
+#define SOFT_LINK_LIBRARY_OPTIONAL(lib) \
+static void* lib##Library() \
+{ \
+static void* dylib = ^{ \
+void *result = dlopen("/usr/lib/" #lib ".dylib", RTLD_NOW); \
+return result; \
+}(); \
+return dylib; \
+}
+
 #define SOFT_LINK_FRAMEWORK(framework) \
 static void* framework##Library() \
 { \


Modified: branches/safari-610.1.7-branch/Source/WebKit/ChangeLog (258284 => 258285)

--- branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 21:25:24 UTC (rev 258284)
+++ branches/safari-610.1.7-branch/Source/WebKit/ChangeLog	2020-03-11 21:32:13 UTC (rev 258285)
@@ -1,5 +1,54 @@
 2020-03-11  Alan Coon  
 
+Cherry-pick r258284. rdar://problem/60341123
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+Source/WebKit:
+
+
+
+Reviewed by Brent Fulgham.
+
+Check that accessibility library is present before attempting to use constants from it.
+
+No new tests, since I am unable to reproduce.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::registerNotificationObservers):
+(WebKit::WebProcessPool::unregisterNotificationObservers):
+
+Source/WTF:
+
+
+Reviewed by Brent Fulgham.
+
+Add macro to optionally soft link library.
+
+* wtf/cocoa/SoftLinking.h:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@258284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+
+Reviewed by Brent Fulgham.
+
+Check that 

[webkit-changes] [258284] trunk/Source

[pvollan]

Title: [258284] trunk/Source








Revision 258284
Author pvol...@apple.com
Date 2020-03-11 14:25:24 -0700 (Wed, 11 Mar 2020)


Log Message
[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
https://bugs.webkit.org/show_bug.cgi?id=208945
Source/WebKit:



Reviewed by Brent Fulgham.

Check that accessibility library is present before attempting to use constants from it.

No new tests, since I am unable to reproduce.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::registerNotificationObservers):
(WebKit::WebProcessPool::unregisterNotificationObservers):

Source/WTF:


Reviewed by Brent Fulgham.

Add macro to optionally soft link library.

* wtf/cocoa/SoftLinking.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/cocoa/SoftLinking.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (258283 => 258284)

--- trunk/Source/WTF/ChangeLog	2020-03-11 21:02:10 UTC (rev 258283)
+++ trunk/Source/WTF/ChangeLog	2020-03-11 21:25:24 UTC (rev 258284)
@@ -1,3 +1,14 @@
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+Reviewed by Brent Fulgham.
+
+Add macro to optionally soft link library.
+
+* wtf/cocoa/SoftLinking.h:
+
 2020-03-11  Alex Christensen  
 
 Enable safe browsing warnings in Mac Catalyst WebKit


Modified: trunk/Source/WTF/wtf/cocoa/SoftLinking.h (258283 => 258284)

--- trunk/Source/WTF/wtf/cocoa/SoftLinking.h	2020-03-11 21:02:10 UTC (rev 258283)
+++ trunk/Source/WTF/wtf/cocoa/SoftLinking.h	2020-03-11 21:25:24 UTC (rev 258284)
@@ -42,6 +42,16 @@
 return dylib; \
 }
 
+#define SOFT_LINK_LIBRARY_OPTIONAL(lib) \
+static void* lib##Library() \
+{ \
+static void* dylib = ^{ \
+void *result = dlopen("/usr/lib/" #lib ".dylib", RTLD_NOW); \
+return result; \
+}(); \
+return dylib; \
+}
+
 #define SOFT_LINK_FRAMEWORK(framework) \
 static void* framework##Library() \
 { \


Modified: trunk/Source/WebKit/ChangeLog (258283 => 258284)

--- trunk/Source/WebKit/ChangeLog	2020-03-11 21:02:10 UTC (rev 258283)
+++ trunk/Source/WebKit/ChangeLog	2020-03-11 21:25:24 UTC (rev 258284)
@@ -1,3 +1,19 @@
+2020-03-11  Per Arne Vollan  
+
+[macOS] Crash under WebKit::WebProcessPool::platformInitialize()
+https://bugs.webkit.org/show_bug.cgi?id=208945
+
+
+Reviewed by Brent Fulgham.
+
+Check that accessibility library is present before attempting to use constants from it.
+
+No new tests, since I am unable to reproduce.
+
+* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+(WebKit::WebProcessPool::registerNotificationObservers):
+(WebKit::WebProcessPool::unregisterNotificationObservers):
+
 2020-03-11  Alex Christensen  
 
 Enable safe browsing warnings in Mac Catalyst WebKit


Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (258283 => 258284)

--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 21:02:10 UTC (rev 258283)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2020-03-11 21:25:24 UTC (rev 258284)
@@ -118,6 +118,10 @@
 SOFT_LINK(BackBoardServices, BKSDisplayBrightnessGetCurrent, float, (), ());
 #endif
 
+#if PLATFORM(COCOA)
+SOFT_LINK_LIBRARY_OPTIONAL(libAccessibility)
+#endif
+
 #define WEBPROCESSPOOL_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - WebProcessPool::" fmt, this, ##__VA_ARGS__)
 
 namespace WebKit {
@@ -662,12 +666,14 @@
 #endif
 #endif // PLATFORM(IOS)
 #endif // !PLATFORM(IOS_FAMILY)
-m_accessibilityEnabledObserver = [[NSNotificationCenter defaultCenter] addObserverForName:(__bridge id)kAXSApplicationAccessibilityEnabledNotification object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *) {
-for (size_t i = 0; i < m_processes.size(); ++i) {
-m_processes[i]->unblockPreferenceServiceIfNeeded();
-m_processes[i]->unblockAccessibilityServerIfNeeded();
-}
-}];
+if (libAccessibilityLibrary()) {
+m_accessibilityEnabledObserver = [[NSNotificationCenter defaultCenter] addObserverForName:(__bridge id)kAXSApplicationAccessibilityEnabledNotification object:nil queue:[NSOperationQueue currentQueue] usingBlock:^(NSNotification *) {
+for (size_t i = 0; i < m_processes.size(); ++i) {
+m_processes[i]->unblockPreferenceServiceIfNeeded();
+m_processes[i]->unblockAccessibilityServerIfNeeded();
+}
+}];
+}
 }
 
 void WebProcessPool::unregisterNotificationObservers()
@@ -692,7 +698,8 @@
 #endif
 #endif // PLATFORM(IOS)
 #endif // !PLATFORM(IOS_FAMILY)
-[[NSNotificationCenter defaultCenter] removeObserver:m_accessibilityEnabledObserver.get()];
+if (m_accessibilityEnabledObserver.get())
+

[webkit-changes] [258283] trunk/Source

[achristensen]

Title: [258283] trunk/Source








Revision 258283
Author achristen...@apple.com
Date 2020-03-11 14:02:10 -0700 (Wed, 11 Mar 2020)


Log Message
Enable safe browsing warnings in Mac Catalyst WebKit
https://bugs.webkit.org/show_bug.cgi?id=208944


Reviewed by Tim Horton.

Source/WebKit:

I manually verified using the steps in the radar that it works as one would hope.

* Configurations/WebKit.xcconfig:

Source/WTF:

* wtf/PlatformHave.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformHave.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig




Diff

Modified: trunk/Source/WTF/ChangeLog (258282 => 258283)

--- trunk/Source/WTF/ChangeLog	2020-03-11 21:00:17 UTC (rev 258282)
+++ trunk/Source/WTF/ChangeLog	2020-03-11 21:02:10 UTC (rev 258283)
@@ -1,3 +1,13 @@
+2020-03-11  Alex Christensen  
+
+Enable safe browsing warnings in Mac Catalyst WebKit
+https://bugs.webkit.org/show_bug.cgi?id=208944
+
+
+Reviewed by Tim Horton.
+
+* wtf/PlatformHave.h:
+
 2020-03-09  Megan Gardner  
 
 Build Fix


Modified: trunk/Source/WTF/wtf/PlatformHave.h (258282 => 258283)

--- trunk/Source/WTF/wtf/PlatformHave.h	2020-03-11 21:00:17 UTC (rev 258282)
+++ trunk/Source/WTF/wtf/PlatformHave.h	2020-03-11 21:02:10 UTC (rev 258283)
@@ -408,7 +408,7 @@
 #define HAVE_SAFARI_SERVICES_FRAMEWORK 1
 #endif
 
-#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WATCHOS)
+#if PLATFORM(MAC) || PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(MACCATALYST)
 #define HAVE_SAFE_BROWSING 1
 #endif
 


Modified: trunk/Source/WebKit/ChangeLog (258282 => 258283)

--- trunk/Source/WebKit/ChangeLog	2020-03-11 21:00:17 UTC (rev 258282)
+++ trunk/Source/WebKit/ChangeLog	2020-03-11 21:02:10 UTC (rev 258283)
@@ -1,5 +1,17 @@
 2020-03-11  Alex Christensen  
 
+Enable safe browsing warnings in Mac Catalyst WebKit
+https://bugs.webkit.org/show_bug.cgi?id=208944
+
+
+Reviewed by Tim Horton.
+
+I manually verified using the steps in the radar that it works as one would hope.
+
+* Configurations/WebKit.xcconfig:
+
+2020-03-11  Alex Christensen  
+
 Fix the macCatalyst build after r258250
 
 * WebProcess/WebPage/Cocoa/TextCheckingControllerProxy.mm:


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (258282 => 258283)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2020-03-11 21:00:17 UTC (rev 258282)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2020-03-11 21:02:10 UTC (rev 258283)
@@ -102,6 +102,7 @@
 WK_SAFE_BROWSING_LDFLAGS_iphonesimulator[sdk=iphone*10.*] = ;
 WK_SAFE_BROWSING_LDFLAGS_watchos = -framework SafariSafeBrowsing;
 WK_SAFE_BROWSING_LDFLAGS_watchsimulator = -framework SafariSafeBrowsing;
+WK_SAFE_BROWSING_LDFLAGS_maccatalyst = -framework SafariSafeBrowsing;
 WK_SAFE_BROWSING_LDFLAGS_macosx = -weak_framework SafariSafeBrowsing;
 
 WK_SECURITY_INTERFACE_LDFLAGS = $(WK_SECURITY_INTERFACE_LDFLAGS_$(WK_PLATFORM_NAME));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [258282] trunk

[mmaxfield]

Title: [258282] trunk








Revision 258282
Author mmaxfi...@apple.com
Date 2020-03-11 14:00:17 -0700 (Wed, 11 Mar 2020)


Log Message
icloud.com Notes text in titles and headings is distorted
https://bugs.webkit.org/show_bug.cgi?id=208908


Reviewed by Zalan Bujtas.

Source/WebCore:

icloud.com Notes determines if a font has finished loading by measuring it repeatedly.
Depending on the state of the page, we may slice the text differently in different
circumstances. These slices are all supposed to sum together equivalently, but
floating point precision may cause the results to be slightly off.

WidthIterator::applyFontTransforms() was summing a large list of numbers, and then
subtracting the same large list of numbers. A more robust design would be to sum
it twice, and then subtract the two sums.

Test: fast/text/shaping-width-precision.html

* platform/graphics/WidthIterator.cpp:
(WebCore::WidthIterator::applyFontTransforms):

LayoutTests:

* fast/text/shaping-width-precision-expected.txt: Added.
* fast/text/shaping-width-precision.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/WidthIterator.cpp


Added Paths

trunk/LayoutTests/fast/text/shaping-width-precision-expected.txt
trunk/LayoutTests/fast/text/shaping-width-precision.html




Diff

Modified: trunk/LayoutTests/ChangeLog (258281 => 258282)

--- trunk/LayoutTests/ChangeLog	2020-03-11 20:47:04 UTC (rev 258281)
+++ trunk/LayoutTests/ChangeLog	2020-03-11 21:00:17 UTC (rev 258282)
@@ -1,3 +1,14 @@
+2020-03-11  Myles C. Maxfield  
+
+icloud.com Notes text in titles and headings is distorted
+https://bugs.webkit.org/show_bug.cgi?id=208908
+
+
+Reviewed by Zalan Bujtas.
+
+* fast/text/shaping-width-precision-expected.txt: Added.
+* fast/text/shaping-width-precision.html: Added.
+
 2020-03-11  Diego Pino Garcia  
 
 [WPE] Gardening, update TestExpectations


Added: trunk/LayoutTests/fast/text/shaping-width-precision-expected.txt (0 => 258282)

--- trunk/LayoutTests/fast/text/shaping-width-precision-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/text/shaping-width-precision-expected.txt	2020-03-11 21:00:17 UTC (rev 258282)
@@ -0,0 +1,10 @@
+This test makes sure that width calculations when shaping in the fast codepath have enough precision.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS beforeWidth is afterWidth
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/fast/text/shaping-width-precision.html (0 => 258282)

--- trunk/LayoutTests/fast/text/shaping-width-precision.html	(rev 0)
+++ trunk/LayoutTests/fast/text/shaping-width-precision.html	2020-03-11 21:00:17 UTC (rev 258282)
@@ -0,0 +1,41 @@
+
+
+
+
+
+
+