date:20200602

Title: [262478] trunk/Source/_javascript_Core








Revision 262478
Author mark@apple.com
Date 2020-06-02 23:25:50 -0700 (Tue, 02 Jun 2020)


Log Message
Rolling out r262475 to unbreak Windows bot.
https://bugs.webkit.org/show_bug.cgi?id=212680

Not reviewed.

* CMakeLists.txt:
* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* assembler/MacroAssemblerARM64.h:
* assembler/MacroAssemblerX86_64.h:
* assembler/testmasm.cpp:
(JSC::testCountTrailingZeros64WithoutNullCheck):
(JSC::run):
(JSC::testStore64Imm64AddressPointer): Deleted.
* dfg/DFGDoesGCCheck.cpp: Removed.
* dfg/DFGDoesGCCheck.h: Removed.
* dfg/DFGGraph.cpp:
* dfg/DFGOSRExit.cpp:
(JSC::DFG::operationCompileOSRExit):
(JSC::DFG::OSRExit::compileExit):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::operationCompileFTLOSRExit):
* heap/CompleteSubspace.cpp:
(JSC::CompleteSubspace::tryAllocateSlow):
(JSC::CompleteSubspace::reallocatePreciseAllocationNonVirtual):
* heap/CompleteSubspaceInlines.h:
(JSC::CompleteSubspace::allocateNonVirtual):
* heap/DeferGC.h:
(JSC::DeferGC::~DeferGC):
* heap/GCDeferralContextInlines.h:
(JSC::GCDeferralContext::~GCDeferralContext):
* heap/Heap.cpp:
(JSC::Heap::collectNow):
(JSC::Heap::collectAsync):
(JSC::Heap::collectSync):
(JSC::Heap::stopIfNecessarySlow):
(JSC::Heap::collectIfNecessaryOrDefer):
* heap/Heap.h:
(JSC::Heap::expectDoesGC const):
(JSC::Heap::setExpectDoesGC):
(JSC::Heap::addressOfExpectDoesGC):
(JSC::Heap::addressOfDoesGC): Deleted.
(JSC::Heap::setDoesGCExpectation): Deleted.
(JSC::Heap::verifyCanGC): Deleted.
* heap/HeapInlines.h:
(JSC::Heap::acquireAccess):
(JSC::Heap::stopIfNecessary):
* heap/LocalAllocatorInlines.h:
(JSC::LocalAllocator::allocate):
* heap/PreciseAllocation.cpp:
(JSC::PreciseAllocation::tryCreate):
(JSC::PreciseAllocation::createForLowerTier):
* runtime/JSString.h:
(JSC::jsSingleCharacterString):
(JSC::JSString::toAtomString const):
(JSC::JSString::toExistingAtomString const):
(JSC::JSString::value const):
(JSC::JSString::tryGetValue const):
(JSC::JSRopeString::unsafeView const):
(JSC::JSRopeString::viewWithUnderlyingString const):
(JSC::JSString::unsafeView const):
* runtime/RegExpMatchesArray.h:
(JSC::createRegExpMatchesArray):

Modified Paths

trunk/Source/_javascript_Core/CMakeLists.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj
trunk/Source/_javascript_Core/Sources.txt
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM64.h
trunk/Source/_javascript_Core/assembler/MacroAssemblerX86_64.h
trunk/Source/_javascript_Core/assembler/testmasm.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGOSRExit.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp
trunk/Source/_javascript_Core/ftl/FTLOSRExitCompiler.cpp
trunk/Source/_javascript_Core/heap/CompleteSubspace.cpp
trunk/Source/_javascript_Core/heap/CompleteSubspaceInlines.h
trunk/Source/_javascript_Core/heap/DeferGC.h
trunk/Source/_javascript_Core/heap/GCDeferralContextInlines.h
trunk/Source/_javascript_Core/heap/Heap.cpp
trunk/Source/_javascript_Core/heap/Heap.h
trunk/Source/_javascript_Core/heap/HeapInlines.h
trunk/Source/_javascript_Core/heap/LocalAllocatorInlines.h
trunk/Source/_javascript_Core/heap/PreciseAllocation.cpp
trunk/Source/_javascript_Core/runtime/JSString.h
trunk/Source/_javascript_Core/runtime/RegExpMatchesArray.h


Removed Paths

trunk/Source/_javascript_Core/dfg/DFGDoesGCCheck.cpp
trunk/Source/_javascript_Core/dfg/DFGDoesGCCheck.h




Diff

Modified: trunk/Source/_javascript_Core/CMakeLists.txt (262477 => 262478)

--- trunk/Source/_javascript_Core/CMakeLists.txt	2020-06-03 05:29:14 UTC (rev 262477)
+++ trunk/Source/_javascript_Core/CMakeLists.txt	2020-06-03 06:25:50 UTC (rev 262478)
@@ -564,7 +564,6 @@
 
 dfg/DFGCommon.h
 dfg/DFGCompilationMode.h
-dfg/DFGDoesGCCheck.h
 dfg/DFGMinifiedID.h
 
 domjit/DOMJITAbstractHeap.h


Modified: trunk/Source/_javascript_Core/ChangeLog (262477 => 262478)

--- trunk/Source/_javascript_Core/ChangeLog	2020-06-03 05:29:14 UTC (rev 262477)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-06-03 06:25:50 UTC (rev 262478)
@@ -1,5 +1,76 @@
 2020-06-02  Mark Lam  
 
+Rolling out r262475 to unbreak Windows bot.
+https://bugs.webkit.org/show_bug.cgi?id=212680
+
+Not reviewed.
+
+* CMakeLists.txt:
+* _javascript_Core.xcodeproj/project.pbxproj:
+* Sources.txt:
+* assembler/MacroAssemblerARM64.h:
+* assembler/MacroAssemblerX86_64.h:
+* assembler/testmasm.cpp:
+(JSC::testCountTrailingZeros64WithoutNullCheck):
+(JSC::run):
+(JSC::testStore64Imm64AddressPointer): Deleted.
+* dfg/DFGDoesGCCheck.cpp: Removed.
+* dfg/DFGDoesGCCheck.h: Remo

[webkit-changes] [262477] trunk

2020-06-02 Thread cdumez

Title: [262477] trunk








Revision 262477
Author cdu...@apple.com
Date 2020-06-02 22:29:14 -0700 (Tue, 02 Jun 2020)


Log Message
[iOS] WKProcessAssertionBackgroundTaskManager incorrectly ignores expiration notifications for daemons
https://bugs.webkit.org/show_bug.cgi?id=212619

Reviewed by Alex Christensen.

WKProcessAssertionBackgroundTaskManager was incorrectly ignoring process assertion expiration notifications
for daemons, because it was relying on visibility to make decisions. For daemons (or ViewServices), we would
not get application visibility notifications and would therefore always assume the app is visible.
As a result, _handleBackgroundTaskExpiration would think it received an outdated expiration notification for
a visible app and would simply re-take the assertion right away.

To address the issue, we now rely on a RunningBoard API that lets us know if the suspension timer has been
started or not (and how much remains on the timer). If the suspension timer is not active when get receive
the expiration notification, we know it is an outdated notification and we ignore it (release and re-take
assertion right away). This can happen if we did not have time to process the expiration notification before
suspended and thus only get it upon resuming. It can also happen if the user re-activates the app right after
the expiration notice has been sent.

* Platform/spi/ios/RunningBoardServicesSPI.h:
* UIProcess/ios/ProcessAssertionIOS.mm:
(processHasActiveRunTimeLimitation):
(-[WKProcessAssertionBackgroundTaskManager init]):
(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
(-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpiration]):
(-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpirationOnMainThread]):
(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/spi/ios/RunningBoardServicesSPI.h
trunk/Source/WebKit/UIProcess/ios/ProcessAssertionIOS.mm
trunk/WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/13/RunningBoardServices.framework/RunningBoardServices.tbd




Diff

Modified: trunk/Source/WebKit/ChangeLog (262476 => 262477)

--- trunk/Source/WebKit/ChangeLog	2020-06-03 04:54:21 UTC (rev 262476)
+++ trunk/Source/WebKit/ChangeLog	2020-06-03 05:29:14 UTC (rev 262477)
@@ -1,3 +1,32 @@
+2020-06-02  Chris Dumez  
+
+[iOS] WKProcessAssertionBackgroundTaskManager incorrectly ignores expiration notifications for daemons
+https://bugs.webkit.org/show_bug.cgi?id=212619
+
+Reviewed by Alex Christensen.
+
+WKProcessAssertionBackgroundTaskManager was incorrectly ignoring process assertion expiration notifications
+for daemons, because it was relying on visibility to make decisions. For daemons (or ViewServices), we would
+not get application visibility notifications and would therefore always assume the app is visible.
+As a result, _handleBackgroundTaskExpiration would think it received an outdated expiration notification for
+a visible app and would simply re-take the assertion right away.
+
+To address the issue, we now rely on a RunningBoard API that lets us know if the suspension timer has been
+started or not (and how much remains on the timer). If the suspension timer is not active when get receive
+the expiration notification, we know it is an outdated notification and we ignore it (release and re-take
+assertion right away). This can happen if we did not have time to process the expiration notification before
+suspended and thus only get it upon resuming. It can also happen if the user re-activates the app right after
+the expiration notice has been sent.
+
+* Platform/spi/ios/RunningBoardServicesSPI.h:
+* UIProcess/ios/ProcessAssertionIOS.mm:
+(processHasActiveRunTimeLimitation):
+(-[WKProcessAssertionBackgroundTaskManager init]):
+(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
+(-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpiration]):
+(-[WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpirationOnMainThread]):
+(-[WKProcessAssertionBackgroundTaskManager _releaseBackgroundTask]):
+
 2020-06-02  Christopher Reid  
 
 REGRESSION[r260844]: [GTK][WPE] Inspector GResource no longer updated after WebInspectorUI file updates


Modified: trunk/Source/WebKit/Platform/spi/ios/RunningBoardServicesSPI.h (262476 => 262477)

--- trunk/Source/WebKit/Platform/spi/ios/RunningBoardServicesSPI.h	2020-06-03 04:54:21 UTC (rev 262476)
+++ trunk/Source/WebKit/Platform/spi/ios/RunningBoardServicesSPI.h	2020-06-03 05:29:14 UTC (rev 262477)
@@ -29,6 +29,12 @@
 
 #import 
 
+extern const NSTimeInterval RBSProcessTimeLimitationNone;
+
+@interface RBSProcessLimitations : NSObject
+@property (nonatomic, readwrite, assign) NSTimeInterval runTime;
+@end
+
 #

[webkit-changes] [262476] trunk

Title: [262476] trunk








Revision 262476
Author simon.fra...@apple.com
Date 2020-06-02 21:54:21 -0700 (Tue, 02 Jun 2020)


Log Message
EventRegion::translate() needs to offset the wheel event regions
https://bugs.webkit.org/show_bug.cgi?id=212683

Reviewed by Zalan Bujtas.

Source/WebCore:

EventRegion::translate() failed to offset the wheel event regions, which resulted
in wrong reasons for GraphicsLayers with a non-zero offsetFromRenderer.

Test: fast/scrolling/mac/wheel-event-listener-region-layer-offset.html

* rendering/EventRegion.cpp:
(WebCore::EventRegion::translate):

LayoutTests:

* fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt: Added.
* fast/scrolling/mac/wheel-event-listener-region-layer-offset.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/EventRegion.cpp


Added Paths

trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt
trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset.html




Diff

Modified: trunk/LayoutTests/ChangeLog (262475 => 262476)

--- trunk/LayoutTests/ChangeLog	2020-06-03 04:47:30 UTC (rev 262475)
+++ trunk/LayoutTests/ChangeLog	2020-06-03 04:54:21 UTC (rev 262476)
@@ -1,3 +1,13 @@
+2020-06-02  Simon Fraser  
+
+EventRegion::translate() needs to offset the wheel event regions
+https://bugs.webkit.org/show_bug.cgi?id=212683
+
+Reviewed by Zalan Bujtas.
+
+* fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt: Added.
+* fast/scrolling/mac/wheel-event-listener-region-layer-offset.html: Added.
+
 2020-06-02  Zalan Bujtas  
 
 [iOS] fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html is a flaky failure


Modified: trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-expected.txt (262475 => 262476)

--- trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-expected.txt	2020-06-03 04:47:30 UTC (rev 262475)
+++ trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-inside-overflow-scroll-expected.txt	2020-06-03 04:54:21 UTC (rev 262476)
@@ -42,9 +42,9 @@
 (rect (-2,-2) width=204 height=204)
 (rect (0,202) width=185 height=218)
   (wheel event listener region
-(rect (22,22) width=100 height=400)
+(rect (20,20) width=100 height=400)
 (non-passive
-  (rect (22,22) width=100 height=400)
+  (rect (20,20) width=100 height=400)
 )
   )
   )


Added: trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt (0 => 262476)

--- trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset-expected.txt	2020-06-03 04:54:21 UTC (rev 262476)
@@ -0,0 +1,40 @@
+(GraphicsLayer
+  (anchor 0.00 0.00)
+  (bounds 800.00 600.00)
+  (children 1
+(GraphicsLayer
+  (bounds 800.00 600.00)
+  (contentsOpaque 1)
+  (event region
+(rect (0,0) width=800 height=600)
+  )
+  (children 1
+(GraphicsLayer
+  (offsetFromRenderer width=-94 height=-69)
+  (position 14.00 44.00)
+  (bounds 294.00 269.00)
+  (drawsContent 1)
+  (event region
+(rect (20,20) width=50 height=49)
+(rect (20,69) width=50 height=1)
+(rect (94,69) width=200 height=1)
+(rect (94,70) width=200 height=199)
+  (wheel event listener region
+(rect (20,20) width=50 height=49)
+(rect (20,69) width=50 height=1)
+(rect (94,69) width=200 height=1)
+(rect (94,70) width=200 height=199)
+(non-passive
+  (rect (20,20) width=50 height=49)
+  (rect (20,69) width=50 height=1)
+  (rect (94,69) width=200 height=1)
+  (rect (94,70) width=200 height=199)
+)
+  )
+  )
+)
+  )
+)
+  )
+)
+


Added: trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset.html (0 => 262476)

--- trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset.html	(rev 0)
+++ trunk/LayoutTests/fast/scrolling/mac/wheel-event-listener-region-layer-offset.html	2020-06-03 04:54:21 UTC (rev 262476)
@@ -0,0 +1,44 @@
+ 
+
+
+* {
+box-sizing: border-box;
+}
+
+.event {
+position: absolute;
+background-color: silver;
+width: 200px;
+height: 200px;
+border: 1px so

[webkit-changes] [262475] trunk/Source/JavaScriptCore

Title: [262475] trunk/Source/_javascript_Core








Revision 262475
Author mark@apple.com
Date 2020-06-02 21:47:30 -0700 (Tue, 02 Jun 2020)


Log Message
Enhance DoesGC verification to print more useful info when verification fails.
https://bugs.webkit.org/show_bug.cgi?id=212680

Reviewed by Yusuke Suzuki.

When DoesGC verification fails, the first step of debugging it would be to find
out what and which DFG node resulted in the failed verification.  In pre-existing
code, all we get is an assertion failure.

This patch makes it so that the verifier will dump useful info.  Here's an example:

Error: DoesGC failed @ D@34 DateGetInt32OrNaN in #DtCHMz:[0x1135bd1d0->0x1135bcab0->0x1135e5c80, DFGFunctionCall, 150 (DidTryToEnterInLoop)]
[0] frame 0x7ffee8285660 {
  name: 
  sourceURL: 
  isInlinedFrame: false
  callee: 0x1135f6820
  returnPC: 0x50ce61248ae6
  callerFrame: 0x7ffee82856f0
  rawLocationBits: 5 0x5
  codeBlock: 0x1135bd1d0 #DtCHMz:[0x1135bd1d0->0x1135bcab0->0x1135e5c80, DFGFunctionCall, 150 (DidTryToEnterInLoop)]
hasCodeOrigins: true
callSiteIndex: 5 of 13
jitCode: 0x113020200 start 0x50ce61214c60 end 0x50ce61219b00
line: 1
column: 60
  EntryFrame: 0x7ffee8285860
}
[1] frame 0x7ffee82856f0 {
  name: 
  sourceURL: date-format-xparb.js
  isInlinedFrame: false
  callee: 0x1135f65a0
  returnPC: 0x50ce61227e99
  callerFrame: 0x7ffee8285770
  rawLocationBits: 4 0x4
  codeBlock: 0x1135bd0a0 #BU6Zcd:[0x1135bd0a0->0x1135bc260->0x1135e5180, DFGFunctionCall, 112 (DidTryToEnterInLoop)]
hasCodeOrigins: true
callSiteIndex: 4 of 12
jitCode: 0x113004000 start 0x50ce61212c60 end 0x50ce61214960
line: 26
column: 22
  EntryFrame: 0x7ffee8285860
}
[2] frame 0x7ffee8285770 {
  name: 
  sourceURL: date-format-xparb.js
  isInlinedFrame: false
  callee: 0x1135f64e0
  returnPC: 0x108058eb1
  callerFrame: 0x7ffee82857e0
  rawLocationBits: 1001 0x3e9
  codeBlock: 0x1135bc130 #DAS9xe:[0x1135bc130->0x1135e5100, BaselineFunctionCall, 1149]
bc#1001 of 1149
line: 417
column: 38
  EntryFrame: 0x7ffee8285860
}
[3] frame 0x7ffee82857e0 {
  name: global code
  sourceURL: date-format-xparb.js
  isInlinedFrame: false
  callee: 0x1130f97b8
  returnPC: 0x108039043
  callerFrame: 0x0
  rawLocationBits: 23 0x17
  codeBlock: 0x1135bc000 #CukXvt:[0x1135bc000->0x1130cd768, LLIntGlobal, 81]
bc#23 of 81
line: 425
column: 3
  EntryFrame: 0x7ffee8285860
}

ASSERTION FAILED: expectDoesGC()

The error message now comes with the node index, NodeType, codeBlock which this
failure was found in, and the JS call stack that led to the failure.

Changes made:

1. Introduced a DoesGCCheck value that is used to encode some of the above data.

   Previously, we only recorded whether doesGC() returns true or false for the
   Node.  Now, we record the nodeIndex and nodeOp as well.

   Note that we also set DoesGC expectations for OSR exits.  So, DoesGCCheck
   includes Special cases for those.

2. Added store64(TrustedImm64 imm, const void* address) emitters for X86_64 and ARM64.
   Also added a test for this new emitter in testmasm.

* CMakeLists.txt:
* _javascript_Core.xcodeproj/project.pbxproj:
* Sources.txt:
* assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::store64):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::store64):
* assembler/testmasm.cpp:
(JSC::testStore64Imm64AddressPointer):
(JSC::run):
* dfg/DFGDoesGCCheck.cpp: Added.
(JSC::DFG::DoesGCCheck::verifyCanGC):
* dfg/DFGDoesGCCheck.h: Added.
(JSC::DFG::DoesGCCheck::DoesGCCheck):
(JSC::DFG::DoesGCCheck::encode):
(JSC::DFG::DoesGCCheck::set):
(JSC::DFG::DoesGCCheck::expectDoesGC):
(JSC::DFG::DoesGCCheck::special):
(JSC::DFG::DoesGCCheck::nodeIndex):
(JSC::DFG::DoesGCCheck::nodeOp):
(JSC::DFG::DoesGCCheck::isSpecial):
(JSC::DFG::DoesGCCheck::specialIndex):
(JSC::DFG::DoesGCCheck::bits):
* dfg/DFGGraph.cpp:
* dfg/DFGOSRExit.cpp:
(JSC::DFG::operationCompileOSRExit):
(JSC::DFG::OSRExit::compileExit):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::operationCompileFTLOSRExit):
* heap/CompleteSubspace.cpp:
(JSC::CompleteSubspace::tryAllocateSlow):
(JSC::CompleteSubspace::reallocatePreciseAllocationNonVirtual):
* heap/CompleteSubspaceInlines.h:
(JSC::CompleteSubspace::allocateNonVirtual):
* heap/DeferGC.h:
(JSC::DeferGC::~DeferGC):
* heap/GCDeferralContextInlines.h:
(JSC::GCDeferra

[webkit-changes] [262474] trunk/Source/ThirdParty/ANGLE

2020-06-02 Thread krollin

Title: [262474] trunk/Source/ThirdParty/ANGLE








Revision 262474
Author krol...@apple.com
Date 2020-06-02 20:59:46 -0700 (Tue, 02 Jun 2020)


Log Message
Change ANGLE's header postprocessing script to not rely on timestamps
https://bugs.webkit.org/show_bug.cgi?id=212623


Reviewed by David Kilzer.
Reviewed by Kennneth Russell.

Some WebKit builds involve multiple passes, where each pass is a
superset of the previous pass. In the cases where each pass produces
the same files, it is required that files be produced in exactly the
same way in each of those passes. A build process that relies on a
file containing a timestamp trips up that prerequisite.

adjust-angle-include-paths.sh uses such a mechanism, using a timestamp
file to determine if any exported headers need to be post-processed.
Since this violates our prerequisite, we need a different approach.
Instead of using a timestamp, always perform the post-processing, but
write the output to a temporary location. Then see if it differs from
what's in the actual final destination. If the two files diff, then
copy the one from the temporary location to the final destination.

This approach does cause more work in the area of post-processing.
However, this post-processing is actually very cheap. And avoiding the
post-processing is not actually the original goal of the timestamp.
The actual goal is to avoid touching the modification dates of the
exported headers, which would then cause a lot of downstream
rebuilding. The new approach with the temporary files also achieves
that goal.

* CMakeLists.txt:
* adjust-angle-include-paths.sh:

Modified Paths

trunk/Source/ThirdParty/ANGLE/CMakeLists.txt
trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/adjust-angle-include-paths.sh




Diff

Modified: trunk/Source/ThirdParty/ANGLE/CMakeLists.txt (262473 => 262474)

--- trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2020-06-03 03:48:52 UTC (rev 262473)
+++ trunk/Source/ThirdParty/ANGLE/CMakeLists.txt	2020-06-03 03:59:46 UTC (rev 262474)
@@ -150,17 +150,14 @@
 FLATTENED
 )
 
-add_custom_command(
-OUTPUT ${ANGLE_FRAMEWORK_HEADERS_DIR}/ANGLE/angle.timestamp
+add_custom_target(ANGLE-webgl-headers
 DEPENDS LibGLESv2EntryPointsHeaders ANGLEWebGLHeaders
 COMMAND BUILT_PRODUCTS_DIR=${ANGLE_FRAMEWORK_HEADERS_DIR}/
+DERIVED_FILE_DIR=${BUILT_PRODUCTS_DIR}
 PUBLIC_HEADERS_FOLDER_PATH=ANGLE
 ${CMAKE_CURRENT_SOURCE_DIR}/adjust-angle-include-paths.sh
 VERBATIM
 )
-add_custom_target(ANGLE-webgl-headers
-DEPENDS ${ANGLE_FRAMEWORK_HEADERS_DIR}/ANGLE/angle.timestamp
-)
 add_dependencies(ANGLEFramework ANGLE-webgl-headers)
 endif ()
 


Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (262473 => 262474)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-06-03 03:48:52 UTC (rev 262473)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-06-03 03:59:46 UTC (rev 262474)
@@ -1,3 +1,37 @@
+2020-06-02  Keith Rollin  
+
+Change ANGLE's header postprocessing script to not rely on timestamps
+https://bugs.webkit.org/show_bug.cgi?id=212623
+
+
+Reviewed by David Kilzer.
+Reviewed by Kennneth Russell.
+
+Some WebKit builds involve multiple passes, where each pass is a
+superset of the previous pass. In the cases where each pass produces
+the same files, it is required that files be produced in exactly the
+same way in each of those passes. A build process that relies on a
+file containing a timestamp trips up that prerequisite.
+
+adjust-angle-include-paths.sh uses such a mechanism, using a timestamp
+file to determine if any exported headers need to be post-processed.
+Since this violates our prerequisite, we need a different approach.
+Instead of using a timestamp, always perform the post-processing, but
+write the output to a temporary location. Then see if it differs from
+what's in the actual final destination. If the two files diff, then
+copy the one from the temporary location to the final destination.
+
+This approach does cause more work in the area of post-processing.
+However, this post-processing is actually very cheap. And avoiding the
+post-processing is not actually the original goal of the timestamp.
+The actual goal is to avoid touching the modification dates of the
+exported headers, which would then cause a lot of downstream
+rebuilding. The new approach with the temporary files also achieves
+that goal.
+
+* CMakeLists.txt:
+* adjust-angle-include-paths.sh:
+
 2020-06-02  Kenneth Russell  
 
 Revise PVRTC compressed texture validation in ANGLE backend for WebGL


Modified: trunk/Source/ThirdParty/ANGLE/adjust-angle-include-paths.sh (262473 => 262474)

--- trunk/Source/ThirdParty/ANGLE/adjust-angle-include-paths.sh	2020-06-03 03:48:52 UTC (

[webkit-changes] [262473] trunk/LayoutTests

2020-06-02 Thread zalan

Title: [262473] trunk/LayoutTests








Revision 262473
Author za...@apple.com
Date 2020-06-02 20:48:52 -0700 (Tue, 02 Jun 2020)


Log Message
[iOS] fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=212660


Reviewed by Simon Fraser.

When the device is busy and the transition gets delayed, the opacity change could miss the content observation window.
Forcing synchronous style change makes is less flaky.

* fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html




Diff

Modified: trunk/LayoutTests/ChangeLog (262472 => 262473)

--- trunk/LayoutTests/ChangeLog	2020-06-03 03:01:14 UTC (rev 262472)
+++ trunk/LayoutTests/ChangeLog	2020-06-03 03:48:52 UTC (rev 262473)
@@ -1,3 +1,16 @@
+2020-06-02  Zalan Bujtas  
+
+[iOS] fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=212660
+
+
+Reviewed by Simon Fraser.
+
+When the device is busy and the transition gets delayed, the opacity change could miss the content observation window.
+Forcing synchronous style change makes is less flaky.
+
+* fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html:
+
 2020-06-02  Simon Fraser  
 
 Followup to r262438


Modified: trunk/LayoutTests/fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html (262472 => 262473)

--- trunk/LayoutTests/fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html	2020-06-03 03:01:14 UTC (rev 262472)
+++ trunk/LayoutTests/fast/events/touch/ios/content-observation/opacity-change-happens-on-touchstart-with-transition2.html	2020-06-03 03:48:52 UTC (rev 262473)
@@ -9,7 +9,7 @@
 width: 400px;
 height: 400px;
 border: 1px solid green;
-transition: opacity 20ms ease-out 10ms;
+transition: opacity 0ms ease-out 1ms;
 }

[webkit-changes] [262472] trunk/LayoutTests

Title: [262472] trunk/LayoutTests








Revision 262472
Author simon.fra...@apple.com
Date 2020-06-02 20:01:14 -0700 (Tue, 02 Jun 2020)


Log Message
Followup to r262438

Remove scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html from TestExpectations
now that it should no longer be flaky.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262471 => 262472)

--- trunk/LayoutTests/ChangeLog	2020-06-03 02:00:15 UTC (rev 262471)
+++ trunk/LayoutTests/ChangeLog	2020-06-03 03:01:14 UTC (rev 262472)
@@ -1,3 +1,12 @@
+2020-06-02  Simon Fraser  
+
+Followup to r262438
+
+Remove scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html from TestExpectations
+now that it should no longer be flaky.
+
+* platform/mac/TestExpectations:
+
 2020-06-02  Peng Liu  
 
 Layout test failures: media/video-create-with-user-gesture.html and media/video-restricted-no-preload-auto.html


Modified: trunk/LayoutTests/platform/mac/TestExpectations (262471 => 262472)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-06-03 02:00:15 UTC (rev 262471)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-06-03 03:01:14 UTC (rev 262472)
@@ -1936,8 +1936,6 @@
 
 webkit.org/b/207160 css2.1/20110323/replaced-intrinsic-ratio-001.htm [ Pass Failure ]
 
-webkit.org/b/210351 scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html [ Pass Timeout ]
-
 webkit.org/b/182571 [ Debug ] media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html [ Pass Timeout ]
 
 # Certain versions of macOS use different text security characters.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262471] tags/Safari-610.1.15.1.2/

Title: [262471] tags/Safari-610.1.15.1.2/








Revision 262471
Author alanc...@apple.com
Date 2020-06-02 19:00:15 -0700 (Tue, 02 Jun 2020)


Log Message
Tag Safari-610.1.15.1.2.

Added Paths

tags/Safari-610.1.15.1.2/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262470] branches/safari-610.1.15.1-branch/Source

Title: [262470] branches/safari-610.1.15.1-branch/Source








Revision 262470
Author alanc...@apple.com
Date 2020-06-02 18:52:30 -0700 (Tue, 02 Jun 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.15.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.15.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.15.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.15.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.15.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.15.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.15.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.15.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.15.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (262469 => 262470)

--- branches/safari-610.1.15.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-06-03 01:50:46 UTC (rev 262469)
+++ branches/safari-610.1.15.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-06-03 01:52:30 UTC (rev 262470)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-610.1.15.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (262469 => 262470)

--- branches/safari-610.1.15.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-06-03 01:50:46 UTC (rev 262469)
+++ branches/safari-610.1.15.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-06-03 01:52:30 UTC (rev 262470)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-610.1.15.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (262469 => 262470)

--- branches/safari-610.1.15.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-06-03 01:50:46 UTC (rev 262469)
+++ branches/safari-610.1.15.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-06-03 01:52:30 UTC (rev 262470)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-610.1.15.1-branch/Source/WebCore/Configurations/Version.xcconfig (262469 => 262470)

--- branches/safari-610.1.15.1-branch/Source/WebCore/Configurations/Version.xcconfig	2020-06-03 01:50:46 UTC (rev 262469)
+++ branches/safari-610.1.15.1-branch/Source/WebCore/Configurations/Version.xcconfig	2020-06-03 01:52:30 UTC (rev 262470)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-610.1.15.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (262469 => 262470)

--- branches/safari-610.1.15.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-06-03 01:50:46 UTC (rev 262469)
+++ branches/safari-610.1.15.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-06-03 01:52:30 UTC (rev 262470)
@@ -25,7 +25,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.


Modified: branches/safari-610.1.15.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (262469 => 262470)

--- branches/safari-610.1.15.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-06-03 01:50:46 UTC (rev 262469)
+++ branches/safari-610.1.15.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-06-03 01:52:30 UTC (rev 262470)
@@ -2,7 +2,7 @@
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
 MICRO_VERSION = 1;
-NANO_VERSION = 1;
+NANO_VERSION = 2;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VE

[webkit-changes] [262469] trunk/Source/WebCore

2020-06-02 Thread wenson_hsieh

Title: [262469] trunk/Source/WebCore








Revision 262469
Author wenson_hs...@apple.com
Date 2020-06-02 18:50:46 -0700 (Tue, 02 Jun 2020)


Log Message
Add a helper method to populate a DataTransfer before dispatching a "dragstart" event
https://bugs.webkit.org/show_bug.cgi?id=212614
Work towards 

Reviewed by Tim Horton.

Add a helper method in DragController to pre-populate the StaticPasteboard-backed DataTransfer before
dispatching the "dragstart" event. There should be no change in behavior yet, since StaticPasteboard doesn't
implement methods for writing data to the pasteboard, which this new method uses.

* page/DragController.cpp:
(WebCore::DragController::prepareForDragStart const):
(WebCore::DragController::hitTestResultForDragStart const):
(WebCore::DragController::startDrag):
* page/DragController.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragStartEventOnSourceElement):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/page/DragController.h
trunk/Source/WebCore/page/EventHandler.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (262468 => 262469)

--- trunk/Source/WebCore/ChangeLog	2020-06-03 01:38:28 UTC (rev 262468)
+++ trunk/Source/WebCore/ChangeLog	2020-06-03 01:50:46 UTC (rev 262469)
@@ -1,3 +1,23 @@
+2020-06-02  Wenson Hsieh  
+
+Add a helper method to populate a DataTransfer before dispatching a "dragstart" event
+https://bugs.webkit.org/show_bug.cgi?id=212614
+Work towards 
+
+Reviewed by Tim Horton.
+
+Add a helper method in DragController to pre-populate the StaticPasteboard-backed DataTransfer before
+dispatching the "dragstart" event. There should be no change in behavior yet, since StaticPasteboard doesn't
+implement methods for writing data to the pasteboard, which this new method uses.
+
+* page/DragController.cpp:
+(WebCore::DragController::prepareForDragStart const):
+(WebCore::DragController::hitTestResultForDragStart const):
+(WebCore::DragController::startDrag):
+* page/DragController.h:
+* page/EventHandler.cpp:
+(WebCore::EventHandler::dispatchDragStartEventOnSourceElement):
+
 2020-06-02  Andres Gonzalez  
 
 AXIsolatedTree::updateNode should not call nodeForID.


Modified: trunk/Source/WebCore/page/DragController.cpp (262468 => 262469)

--- trunk/Source/WebCore/page/DragController.cpp	2020-06-03 01:38:28 UTC (rev 262468)
+++ trunk/Source/WebCore/page/DragController.cpp	2020-06-03 01:50:46 UTC (rev 262469)
@@ -899,26 +899,76 @@
 return IntPoint(xpos, ypos);
 }
 
-bool DragController::startDrag(Frame& src, const DragState& state, DragOperation srcOp, const PlatformMouseEvent& dragEvent, const IntPoint& dragOrigin, HasNonDefaultPasteboardData hasData)
+void DragController::prepareForDragStart(Frame& source, DragSourceAction action, Element& element, DataTransfer& dataTransfer, const IntPoint& dragOrigin) const
 {
-if (!src.view() || !src.contentRenderer() || !state.source)
-return false;
+#if !PLATFORM(WIN)
+Ref protector(source);
+auto hitTestResult = hitTestResultForDragStart(source, element, dragOrigin);
+if (!hitTestResult)
+return;
 
-Ref protector(src);
+auto& pasteboard = dataTransfer.pasteboard();
+auto& editor = source.editor();
+if (action == DragSourceActionSelection) {
+if (enclosingTextFormControl(source.selection().selection().start()))
+pasteboard.writePlainText(editor.selectedTextForDataTransfer(), Pasteboard::CannotSmartReplace);
+else
+editor.writeSelectionToPasteboard(pasteboard);
+return;
+}
+
+auto* image = getImage(element);
+auto imageURL = hitTestResult->absoluteImageURL();
+if ((action & DragSourceActionImage) && !imageURL.isEmpty() && image && !image->isNull()) {
+editor.writeImageToPasteboard(pasteboard, element, imageURL, { });
+return;
+}
+
+auto linkURL = hitTestResult->absoluteLinkURL();
+if ((action & DragSourceActionLink) && !linkURL.isEmpty() && source.document()->securityOrigin().canDisplay(linkURL))
+editor.copyURL(linkURL, hitTestResult->textContent().simplifyWhiteSpace(), pasteboard);
+#else
+// FIXME: Make this work on Windows by implementing Editor::writeSelectionToPasteboard and Editor::writeImageToPasteboard.
+UNUSED_PARAM(source);
+UNUSED_PARAM(action);
+UNUSED_PARAM(element);
+UNUSED_PARAM(dataTransfer);
+UNUSED_PARAM(dragOrigin);
+#endif
+}
+
+Optional DragController::hitTestResultForDragStart(Frame& source, Element& element, const IntPoint& location) const
+{
+if (!source.view() || !source.contentRenderer())
+return WTF::nullopt;
+
 constexpr OptionSet hitType { HitTestRequest::ReadOnly, HitTestRequest::Active, HitTestRequest::AllowChildFrameContent };
-HitTestResult hitTestResult = src.eventHandler().hitTestResultAtPoint(dragOrigi

[webkit-changes] [262468] trunk/LayoutTests

2020-06-02 Thread peng . liu6

Title: [262468] trunk/LayoutTests








Revision 262468
Author peng.l...@apple.com
Date 2020-06-02 18:38:28 -0700 (Tue, 02 Jun 2020)


Log Message
Layout test failures: media/video-create-with-user-gesture.html and media/video-restricted-no-preload-auto.html
https://bugs.webkit.org/show_bug.cgi?id=212666

Reviewed by Eric Carlson.

Set event handlers before set the video source.

* media/video-create-with-user-gesture.html:
* media/video-restricted-no-preload-auto-expected.txt:
* media/video-restricted-no-preload-auto.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/video-create-with-user-gesture.html
trunk/LayoutTests/media/video-restricted-no-preload-auto-expected.txt
trunk/LayoutTests/media/video-restricted-no-preload-auto.html




Diff

Modified: trunk/LayoutTests/ChangeLog (262467 => 262468)

--- trunk/LayoutTests/ChangeLog	2020-06-03 01:25:32 UTC (rev 262467)
+++ trunk/LayoutTests/ChangeLog	2020-06-03 01:38:28 UTC (rev 262468)
@@ -1,3 +1,16 @@
+2020-06-02  Peng Liu  
+
+Layout test failures: media/video-create-with-user-gesture.html and media/video-restricted-no-preload-auto.html
+https://bugs.webkit.org/show_bug.cgi?id=212666
+
+Reviewed by Eric Carlson.
+
+Set event handlers before set the video source.
+
+* media/video-create-with-user-gesture.html:
+* media/video-restricted-no-preload-auto-expected.txt:
+* media/video-restricted-no-preload-auto.html:
+
 2020-06-02  Ryan Haddad  
 
 ASSERTION FAILED: isCell() under WebCore::JSDOMConstructor seen with webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html


Modified: trunk/LayoutTests/media/video-create-with-user-gesture.html (262467 => 262468)

--- trunk/LayoutTests/media/video-create-with-user-gesture.html	2020-06-03 01:25:32 UTC (rev 262467)
+++ trunk/LayoutTests/media/video-create-with-user-gesture.html	2020-06-03 01:38:28 UTC (rev 262468)
@@ -10,10 +10,10 @@
 runWithKeyDown(() => {
 run('video = document.createElement("video")');
 });
+waitForEventAndEnd('playing');
 run('video.src = "" "content/test")');
 run('video.setAttribute("autoplay", "")');
 run('document.body.appendChild(video)');
-waitForEventAndEnd('playing');
 failTestIn(1);
 }
 


Modified: trunk/LayoutTests/media/video-restricted-no-preload-auto-expected.txt (262467 => 262468)

--- trunk/LayoutTests/media/video-restricted-no-preload-auto-expected.txt	2020-06-03 01:25:32 UTC (rev 262467)
+++ trunk/LayoutTests/media/video-restricted-no-preload-auto-expected.txt	2020-06-03 01:38:28 UTC (rev 262468)
@@ -1,8 +1,8 @@
 
 Test that "no auto-loading restriction" only allows metadata to load in spite of preload='auto'.
 
+EXPECTED (video.preload == 'auto') OK
 ** setting video.src
-EXPECTED (video.preload == 'auto') OK
 RUN(internals.setMediaElementRestrictions(video, 'AutoPreloadingNotPermitted'))
 
 EVENT(loadedmetadata)


Modified: trunk/LayoutTests/media/video-restricted-no-preload-auto.html (262467 => 262468)

--- trunk/LayoutTests/media/video-restricted-no-preload-auto.html	2020-06-03 01:25:32 UTC (rev 262467)
+++ trunk/LayoutTests/media/video-restricted-no-preload-auto.html	2020-06-03 01:38:28 UTC (rev 262468)
@@ -1,3 +1,4 @@
+

[webkit-changes] [262467] trunk/Source/JavaScriptCore

Title: [262467] trunk/Source/_javascript_Core








Revision 262467
Author mark@apple.com
Date 2020-06-02 18:25:32 -0700 (Tue, 02 Jun 2020)


Log Message
VMInspector APIs should be taking a VM* instead of a JSGlobalObject*.
https://bugs.webkit.org/show_bug.cgi?id=212676

Reviewed by Saam Barati and Robin Morisset.

This because:
1. None of the functions currently taking a JSGlobalObject* actually need the
   globalObject.  All of them need the VM.
2. The role of the VMInspector is to enable inspection of the VM.  By requiring
   that it be passed a JSGlobalObject*, we were actually preventing the VMInspector
   from being used in code that have a VM to inspect but don't have a JSGlobalObject
   to use.

The reason I'm choosing to pass VM* instead of VM& is because it makes these
functions trivial to call using lldb interactively.  The VMInspector functions
are also intentionally designed so that they can be used for this purpose.
On occasion, I may have to cast literal numbers (addresses) to VM*.  Technically,
I could cast a number to VM* and dereference it to get a VM& too.  However, at
present, lldb is often buggy and not always reliable with casts.  I would like to
lessen the chance that lldb fails on me when I'm deep in the middle of a debugging
session, and have a need to call one of these functions.

* tools/JSDollarVM.cpp:
(JSC::functionGC):
(JSC::functionEdenGC):
(JSC::functionCodeBlockForFrame):
(JSC::codeBlockFromArg):
(JSC::functionDumpCallFrame):
(JSC::functionDumpStack):
* tools/VMInspector.cpp:
(JSC::VMInspector::currentThreadOwnsJSLock):
(JSC::ensureCurrentThreadOwnsJSLock):
(JSC::VMInspector::gc):
(JSC::VMInspector::edenGC):
(JSC::VMInspector::isValidCodeBlock):
(JSC::VMInspector::codeBlockForFrame):
(JSC::VMInspector::dumpCallFrame):
(JSC::VMInspector::dumpStack):
* tools/VMInspector.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/tools/JSDollarVM.cpp
trunk/Source/_javascript_Core/tools/VMInspector.cpp
trunk/Source/_javascript_Core/tools/VMInspector.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (262466 => 262467)

--- trunk/Source/_javascript_Core/ChangeLog	2020-06-03 00:57:56 UTC (rev 262466)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-06-03 01:25:32 UTC (rev 262467)
@@ -1,3 +1,45 @@
+2020-06-02  Mark Lam  
+
+VMInspector APIs should be taking a VM* instead of a JSGlobalObject*.
+https://bugs.webkit.org/show_bug.cgi?id=212676
+
+Reviewed by Saam Barati and Robin Morisset.
+
+This because:
+1. None of the functions currently taking a JSGlobalObject* actually need the
+   globalObject.  All of them need the VM.
+2. The role of the VMInspector is to enable inspection of the VM.  By requiring
+   that it be passed a JSGlobalObject*, we were actually preventing the VMInspector
+   from being used in code that have a VM to inspect but don't have a JSGlobalObject
+   to use.
+
+The reason I'm choosing to pass VM* instead of VM& is because it makes these
+functions trivial to call using lldb interactively.  The VMInspector functions
+are also intentionally designed so that they can be used for this purpose.
+On occasion, I may have to cast literal numbers (addresses) to VM*.  Technically,
+I could cast a number to VM* and dereference it to get a VM& too.  However, at
+present, lldb is often buggy and not always reliable with casts.  I would like to
+lessen the chance that lldb fails on me when I'm deep in the middle of a debugging
+session, and have a need to call one of these functions.
+
+* tools/JSDollarVM.cpp:
+(JSC::functionGC):
+(JSC::functionEdenGC):
+(JSC::functionCodeBlockForFrame):
+(JSC::codeBlockFromArg):
+(JSC::functionDumpCallFrame):
+(JSC::functionDumpStack):
+* tools/VMInspector.cpp:
+(JSC::VMInspector::currentThreadOwnsJSLock):
+(JSC::ensureCurrentThreadOwnsJSLock):
+(JSC::VMInspector::gc):
+(JSC::VMInspector::edenGC):
+(JSC::VMInspector::isValidCodeBlock):
+(JSC::VMInspector::codeBlockForFrame):
+(JSC::VMInspector::dumpCallFrame):
+(JSC::VMInspector::dumpStack):
+* tools/VMInspector.h:
+
 2020-06-02  Keith Rollin  
 
 Revert FEATURES_DEFINES related changes


Modified: trunk/Source/_javascript_Core/tools/JSDollarVM.cpp (262466 => 262467)

--- trunk/Source/_javascript_Core/tools/JSDollarVM.cpp	2020-06-03 00:57:56 UTC (rev 262466)
+++ trunk/Source/_javascript_Core/tools/JSDollarVM.cpp	2020-06-03 01:25:32 UTC (rev 262467)
@@ -1777,7 +1777,7 @@
 static EncodedJSValue JSC_HOST_CALL functionGC(JSGlobalObject* globalObject, CallFrame*)
 {
 DollarVMAssertScope assertScope;
-VMInspector::gc(globalObject);
+VMInspector::gc(&globalObject->vm());
 return JSValue::encode(jsUndefined());
 }
 
@@ -1786,7 +1786,7 @@
 static Enco

[webkit-changes] [262466] trunk/Source/WebKit

2020-06-02 Thread chris . reid

Title: [262466] trunk/Source/WebKit








Revision 262466
Author chris.r...@sony.com
Date 2020-06-02 17:57:56 -0700 (Tue, 02 Jun 2020)


Log Message
REGRESSION[r260844]: [GTK][WPE] Inspector GResource no longer updated after WebInspectorUI file updates
https://bugs.webkit.org/show_bug.cgi?id=212583

Reviewed by Adrian Perez de Castro.

Add a cmake dependency on inspector resource stamp so the Glib
Inspector resources rebuild when the stamp is updated.

* InspectorGResources.cmake:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/InspectorGResources.cmake




Diff

Modified: trunk/Source/WebKit/ChangeLog (262465 => 262466)

--- trunk/Source/WebKit/ChangeLog	2020-06-03 00:46:58 UTC (rev 262465)
+++ trunk/Source/WebKit/ChangeLog	2020-06-03 00:57:56 UTC (rev 262466)
@@ -1,3 +1,15 @@
+2020-06-02  Christopher Reid  
+
+REGRESSION[r260844]: [GTK][WPE] Inspector GResource no longer updated after WebInspectorUI file updates
+https://bugs.webkit.org/show_bug.cgi?id=212583
+
+Reviewed by Adrian Perez de Castro.
+
+Add a cmake dependency on inspector resource stamp so the Glib
+Inspector resources rebuild when the stamp is updated.
+
+* InspectorGResources.cmake:
+
 2020-06-02  Keith Rollin  
 
 Revert FEATURES_DEFINES related changes


Modified: trunk/Source/WebKit/InspectorGResources.cmake (262465 => 262466)

--- trunk/Source/WebKit/InspectorGResources.cmake	2020-06-03 00:46:58 UTC (rev 262465)
+++ trunk/Source/WebKit/InspectorGResources.cmake	2020-06-03 00:57:56 UTC (rev 262466)
@@ -2,6 +2,7 @@
 add_custom_command(
 OUTPUT ${_derived_sources_dir}/InspectorGResourceBundle.xml
 DEPENDS WebInspectorUI
+${CMAKE_BINARY_DIR}/inspector-resources.stamp
 ${TOOLS_DIR}/glib/generate-inspector-gresource-manifest.py
 COMMAND ${PYTHON_EXECUTABLE} ${TOOLS_DIR}/glib/generate-inspector-gresource-manifest.py --input=${_derived_sources_dir}/InspectorResources --output=${_derived_sources_dir}/InspectorGResourceBundle.xml
 VERBATIM






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262465] trunk/LayoutTests

2020-06-02 Thread ryanhaddad

Title: [262465] trunk/LayoutTests








Revision 262465
Author ryanhad...@apple.com
Date 2020-06-02 17:46:58 -0700 (Tue, 02 Jun 2020)


Log Message
ASSERTION FAILED: isCell() under WebCore::JSDOMConstructor seen with webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html
https://bugs.webkit.org/show_bug.cgi?id=212650

Unreviewed test gardening.

* platform/ios/TestExpectations: Skip this test on debug since it always asserts.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262464 => 262465)

--- trunk/LayoutTests/ChangeLog	2020-06-03 00:38:49 UTC (rev 262464)
+++ trunk/LayoutTests/ChangeLog	2020-06-03 00:46:58 UTC (rev 262465)
@@ -5,6 +5,15 @@
 
 Unreviewed test gardening.
 
+* platform/ios/TestExpectations: Skip this test on debug since it always asserts.
+
+2020-06-02  Ryan Haddad  
+
+ASSERTION FAILED: isCell() under WebCore::JSDOMConstructor seen with webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html
+https://bugs.webkit.org/show_bug.cgi?id=212650
+
+Unreviewed test gardening.
+
 * platform/mac/TestExpectations: Skip this test on debug since it always asserts.
 
 2020-06-02  Jason Lawrence  


Modified: trunk/LayoutTests/platform/ios/TestExpectations (262464 => 262465)

--- trunk/LayoutTests/platform/ios/TestExpectations	2020-06-03 00:38:49 UTC (rev 262464)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2020-06-03 00:46:58 UTC (rev 262465)
@@ -3529,5 +3529,7 @@
 
 webkit.org/b/212493 imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ]
 
+webkit.org/b/212650 [ Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html [ Skip ]
+
 # This test requires an update to system decoders
 webkit.org/b/212565 imported/w3c/web-platform-tests/encoding/single-byte-decoder.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262464] trunk/LayoutTests

2020-06-02 Thread ryanhaddad

Title: [262464] trunk/LayoutTests








Revision 262464
Author ryanhad...@apple.com
Date 2020-06-02 17:38:49 -0700 (Tue, 02 Jun 2020)


Log Message
ASSERTION FAILED: isCell() under WebCore::JSDOMConstructor seen with webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html
https://bugs.webkit.org/show_bug.cgi?id=212650

Unreviewed test gardening.

* platform/mac/TestExpectations: Skip this test on debug since it always asserts.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262463 => 262464)

--- trunk/LayoutTests/ChangeLog	2020-06-02 23:59:24 UTC (rev 262463)
+++ trunk/LayoutTests/ChangeLog	2020-06-03 00:38:49 UTC (rev 262464)
@@ -1,3 +1,12 @@
+2020-06-02  Ryan Haddad  
+
+ASSERTION FAILED: isCell() under WebCore::JSDOMConstructor seen with webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html
+https://bugs.webkit.org/show_bug.cgi?id=212650
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations: Skip this test on debug since it always asserts.
+
 2020-06-02  Jason Lawrence  
 
 [ Mojave wk2 Debug ] fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html is flaky failing and flaky timing out.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (262463 => 262464)

--- trunk/LayoutTests/platform/mac/TestExpectations	2020-06-02 23:59:24 UTC (rev 262463)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2020-06-03 00:38:49 UTC (rev 262464)
@@ -1970,5 +1970,7 @@
 webkit.org/b/212594 webgl/2.0.0/conformance/canvas/buffer-offscreen-test.html [ Failure ]
 webkit.org/b/212594 webgl/1.0.3/conformance/canvas/buffer-offscreen-test.html [ Failure ]
 
+webkit.org/b/212650 [ Debug ] imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audiocontext-interface/audiocontextoptions.html [ Skip ]
+
 # This test requires an update to system decoders
 webkit.org/b/212565 [ Catalina Mojave ] imported/w3c/web-platform-tests/encoding/single-byte-decoder.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262463] trunk/Source/WebCore

2020-06-02 Thread andresg_22

Title: [262463] trunk/Source/WebCore








Revision 262463
Author andresg...@apple.com
Date 2020-06-02 16:59:24 -0700 (Tue, 02 Jun 2020)


Log Message
AXIsolatedTree::updateNode should not call nodeForID.
https://bugs.webkit.org/show_bug.cgi?id=212662

Reviewed by Chris Fleizach.

In isolated tree mode AXIsolatedTree::nodeForID should be called only
on the secondary AX thread. So removing the need to call nodeForID in
updateNode by using AXCoreObject::childrenIDs() instead of retrieving
the isolated node to access its children IDs.

* accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::updateNode):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (262462 => 262463)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 23:52:01 UTC (rev 262462)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 23:59:24 UTC (rev 262463)
@@ -1,3 +1,18 @@
+2020-06-02  Andres Gonzalez  
+
+AXIsolatedTree::updateNode should not call nodeForID.
+https://bugs.webkit.org/show_bug.cgi?id=212662
+
+Reviewed by Chris Fleizach.
+
+In isolated tree mode AXIsolatedTree::nodeForID should be called only
+on the secondary AX thread. So removing the need to call nodeForID in
+updateNode by using AXCoreObject::childrenIDs() instead of retrieving
+the isolated node to access its children IDs.
+
+* accessibility/isolatedtree/AXIsolatedTree.cpp:
+(WebCore::AXIsolatedTree::updateNode):
+
 2020-06-02  Keith Rollin  
 
 Revert FEATURES_DEFINES related changes


Modified: trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp (262462 => 262463)

--- trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp	2020-06-02 23:52:01 UTC (rev 262462)
+++ trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp	2020-06-02 23:59:24 UTC (rev 262463)
@@ -198,17 +198,16 @@
 AXTRACE("AXIsolatedTree::updateNode");
 AXLOG(&axObject);
 ASSERT(isMainThread());
+
 AXID axID = axObject.objectID();
 auto* axParent = axObject.parentObject();
 AXID parentID = axParent ? axParent->objectID() : InvalidAXID;
 
-LockHolder locker { m_changeLogLock };
-if (auto object = nodeForID(axID)) {
-ASSERT(object->objectID() == axID);
-auto newObject = AXIsolatedObject::create(axObject, m_treeID, parentID);
+auto newObject = AXIsolatedObject::create(axObject, m_treeID, parentID);
+newObject->m_childrenIDs = axObject.childrenIDs();
 
-// The new object should have the same children as the old one.
-newObject->m_childrenIDs = object->m_childrenIDs;
+{
+LockHolder locker { m_changeLogLock };
 // Remove the old object and set the new one to be updated on the AX thread.
 m_pendingNodeRemovals.append(axID);
 m_pendingAppends.append(NodeChange(newObject, axObject.wrapper()));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262461] trunk/Source

2020-06-02 Thread ryanhaddad

Title: [262461] trunk/Source








Revision 262461
Author ryanhad...@apple.com
Date 2020-06-02 16:34:11 -0700 (Tue, 02 Jun 2020)


Log Message
Unreviewed, reverting r262424.

Caused webkitpy test failure

Reverted changeset:

"Make generated C++ code use modern C++"
https://bugs.webkit.org/show_bug.cgi?id=190714
https://trac.webkit.org/changeset/262424

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator_templates.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/enum-values.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/events-with-optional-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/same-type-id-different-domain.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-array-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-enum-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result
trunk/Source/_javascript_Core/yarr/generateYarrUnicodePropertyTables.py
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/dom/make_names.pl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (262460 => 262461)

--- trunk/Source/_javascript_Core/ChangeLog	2020-06-02 23:18:03 UTC (rev 262460)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-06-02 23:34:11 UTC (rev 262461)
@@ -1,3 +1,15 @@
+2020-06-02  Ryan Haddad  
+
+Unreviewed, reverting r262424.
+
+Caused webkitpy test failure
+
+Reverted changeset:
+
+"Make generated C++ code use modern C++"
+https://bugs.webkit.org/show_bug.cgi?id=190714
+https://trac.webkit.org/changeset/262424
+
 2020-06-02  Mark Lam  
 
 Change Gigacage::Config to use storage in WebConfig::g_config instead of its own.


Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator_templates.py (262460 => 262461)

--- trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator_templates.py	2020-06-02 23:18:03 UTC (rev 262460)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator_templates.py	2020-06-02 23:34:11 UTC (rev 262461)
@@ -139,8 +139,8 @@
 RefPtr parameters;
 message->getObject("params"_s, parameters);
 
-using CallHandler = void (${domainName}BackendDispatcher::*)(long requestId, RefPtr&& message);
-using DispatchMap = HashMap;
+typedef void (${domainName}BackendDispatcher::*CallHandler)(long requestId, RefPtr&& message);
+typedef HashMap DispatchMap;
 static NeverDestroyed dispatchMap;
 if (dispatchMap.get().isEmpty()) {
 static const struct MethodTable {


Modified: trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py (262460 => 262461)

--- trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py	2020-06-02 23:18:03 UTC (rev 262460)
+++ trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py	2020-06-02 23:34:11 UTC (rev 262461)
@@ -169,7 +169,7 @@
 typedef_lines = []
 if len(declaration.description) > 0:
 typedef_lines.append('/* %s */' % declaration.description)
-typedef_lines.append('using %s = %s;' % (declaration.type_name, primitive_name))
+typedef_lines.append('typedef %s %s;' % (primitive_name, declaration.type_name))
 sections.append(self.wrap_with_guard_for_condition(declaration.condition, '\n'.join(typedef_lines)))
 
 for declaration in array_declarations:
@@ -177,7 +177,7 @@
 typedef_lines = []
 if len(declaration.description) > 0:
 typedef_lines.append('/* %s */' % declaration.description)
-typedef_lines.append('using %s = JSON::ArrayOf<%s>;' % (declaration.type_name, element_type))
+typedef_lines.append('typedef JSON::ArrayOf<%s> %s;' % (element_type, declaration.type_name))
 sections.append(self.wrap_with_guard_for_condition(declaration.condition, '\n'.join(typedef_lines)))
 
 lines = []
@@ -486,7

[webkit-changes] [262460] trunk/Source/ThirdParty/ANGLE

Title: [262460] trunk/Source/ThirdParty/ANGLE








Revision 262460
Author commit-qu...@webkit.org
Date 2020-06-02 16:18:03 -0700 (Tue, 02 Jun 2020)


Log Message
Revise PVRTC compressed texture validation in ANGLE backend for WebGL
https://bugs.webkit.org/show_bug.cgi?id=212612

Patch by Kenneth Russell  on 2020-06-02
Reviewed by Dean Jackson.

Correct the block sizes of PVRTC textures, and incorporate minimum
block sizes for width and height, as required by these formats.

* src/libANGLE/formatutils.cpp:
(gl::BuildInternalFormatInfoMap):
(gl::InternalFormat::computeCompressedImageSize const):
(gl::InternalFormat::getCompressedImageMinBlocks const):
* src/libANGLE/formatutils.h:

Modified Paths

trunk/Source/ThirdParty/ANGLE/ChangeLog
trunk/Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp
trunk/Source/ThirdParty/ANGLE/src/libANGLE/formatutils.h




Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (262459 => 262460)

--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-06-02 23:10:26 UTC (rev 262459)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2020-06-02 23:18:03 UTC (rev 262460)
@@ -1,3 +1,19 @@
+2020-06-02  Kenneth Russell  
+
+Revise PVRTC compressed texture validation in ANGLE backend for WebGL
+https://bugs.webkit.org/show_bug.cgi?id=212612
+
+Reviewed by Dean Jackson.
+
+Correct the block sizes of PVRTC textures, and incorporate minimum
+block sizes for width and height, as required by these formats.
+
+* src/libANGLE/formatutils.cpp:
+(gl::BuildInternalFormatInfoMap):
+(gl::InternalFormat::computeCompressedImageSize const):
+(gl::InternalFormat::getCompressedImageMinBlocks const):
+* src/libANGLE/formatutils.h:
+
 2020-05-29  Keith Rollin  
 
 Revert switch to XCBuild


Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp (262459 => 262460)

--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp	2020-06-02 23:10:26 UTC (rev 262459)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/formatutils.cpp	2020-06-02 23:18:03 UTC (rev 262460)
@@ -964,17 +964,17 @@
 
 // From GL_IMG_texture_compression_pvrtc
 //   | Internal format   | W | H | D | BS |CC| SRGB | Texture supported | Filterable | Texture attachment | Renderbuffer  | Blend
-AddCompressedFormat(&map, GL_COMPRESSED_RGB_PVRTC_4BPPV1_IMG,  8,  8,  1, 256,  3, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
-AddCompressedFormat(&map, GL_COMPRESSED_RGB_PVRTC_2BPPV1_IMG, 16,  8,  1, 256,  3, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
-AddCompressedFormat(&map, GL_COMPRESSED_RGBA_PVRTC_4BPPV1_IMG, 8,  8,  1, 256,  4, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
-AddCompressedFormat(&map, GL_COMPRESSED_RGBA_PVRTC_2BPPV1_IMG,16,  8,  1, 256,  4, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
+AddCompressedFormat(&map, GL_COMPRESSED_RGB_PVRTC_4BPPV1_IMG,  4,  4,  1,  64,  3, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
+AddCompressedFormat(&map, GL_COMPRESSED_RGB_PVRTC_2BPPV1_IMG,  8,  4,  1,  64,  3, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
+AddCompressedFormat(&map, GL_COMPRESSED_RGBA_PVRTC_4BPPV1_IMG, 4,  4,  1,  64,  4, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
+AddCompressedFormat(&map, GL_COMPRESSED_RGBA_PVRTC_2BPPV1_IMG, 8,  4,  1,  64,  4, false, RequireExt<&Extensions::compressedTexturePVRTC>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
 
 // From GL_EXT_pvrtc_sRGB
 //   | Internal format | W | H | D | BS |CC| SRGB | Texture supported | Filterable | Texture attachment | Renderbuffer  | Blend
-AddCompressedFormat(&map, GL_COMPRESSED_SRGB_PVRTC_2BPPV1_EXT,  16,  8,  1, 256,  3, true, RequireExt<&Extensions::compressedTexturePVRTCsRGB>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
-AddCompressedFormat(&map, GL_COMPRESSED_SRGB_PVRTC_4BPPV1_EXT,   8,  8,  1, 256,  3, true, RequireExt<&Extensions::compressedTexturePVRTCsRGB>,AlwaysSupported, NeverSupported,  NeverSupported, NeverSupported);
-AddCompressedFormat(&map, GL_COMPRESSED_SRGB_ALPHA_PVRTC_2BPPV1_EXT,16,  8,  1, 256,  4, true, RequireExt<&Extensions::compre

[webkit-changes] [262459] trunk/LayoutTests

2020-06-02 Thread lawrence . j

Title: [262459] trunk/LayoutTests








Revision 262459
Author lawrenc...@apple.com
Date 2020-06-02 16:10:26 -0700 (Tue, 02 Jun 2020)


Log Message
[ Mojave wk2 Debug ] fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html is flaky failing and flaky timing out.
https://bugs.webkit.org/show_bug.cgi?id=212667

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262458 => 262459)

--- trunk/LayoutTests/ChangeLog	2020-06-02 23:05:13 UTC (rev 262458)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 23:10:26 UTC (rev 262459)
@@ -1,5 +1,14 @@
 2020-06-02  Jason Lawrence  
 
+[ Mojave wk2 Debug ] fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html is flaky failing and flaky timing out.
+https://bugs.webkit.org/show_bug.cgi?id=212667
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2020-06-02  Jason Lawrence  
+
 [ Mac wk1 Debug ] svg/custom/textPath-insert-path.svg is flaky failing.
 https://bugs.webkit.org/show_bug.cgi?id=212665
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (262458 => 262459)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-06-02 23:05:13 UTC (rev 262458)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-06-02 23:10:26 UTC (rev 262459)
@@ -1035,4 +1035,6 @@
 
 webkit.org/b/212413 fast/mediastream/mock-media-source-webaudio.html [ Pass Timeout ]
 
-webkit.org/b/261103 [ Debug ] inspector/page/overrideSetting-ITPDebugModeEnabled.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/261103 [ Debug ] inspector/page/overrideSetting-ITPDebugModeEnabled.html [ Pass Failure ]
+
+webkit.org/b/212667 [ Mojave Debug ] fast/scrolling/mac/scrollbars/select-overlay-scrollbar-hovered.html [ Pass Failure Timeout ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262458] branches/safari-610.1.15-branch/Source/JavaScriptCore

Title: [262458] branches/safari-610.1.15-branch/Source/_javascript_Core








Revision 262458
Author alanc...@apple.com
Date 2020-06-02 16:05:13 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262389. rdar://problem/63897040

x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
https://bugs.webkit.org/show_bug.cgi?id=212603

Reviewed by Saam Barati.

The current implementation mistakenly sets the address type to that of the value
being loaded.  I encountered this issue when I was trying to do a loadb from a
global address.  Because of this bug, the emitted code was trying do a load using
%al (8 byte register) as the pointer to load from.  With this fix, it now loads
from %rax.

* offlineasm/x86.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog
branches/safari-610.1.15-branch/Source/_javascript_Core/offlineasm/x86.rb




Diff

Modified: branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog (262457 => 262458)

--- branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog	2020-06-02 22:33:46 UTC (rev 262457)
+++ branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog	2020-06-02 23:05:13 UTC (rev 262458)
@@ -1,5 +1,41 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262389. rdar://problem/63897040
+
+x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
+https://bugs.webkit.org/show_bug.cgi?id=212603
+
+Reviewed by Saam Barati.
+
+The current implementation mistakenly sets the address type to that of the value
+being loaded.  I encountered this issue when I was trying to do a loadb from a
+global address.  Because of this bug, the emitted code was trying do a load using
+%al (8 byte register) as the pointer to load from.  With this fix, it now loads
+from %rax.
+
+* offlineasm/x86.rb:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-06-01  Mark Lam  
+
+x86.rb's LabelReference.x86LoadOperand()'s address operand should be a pointer type.
+https://bugs.webkit.org/show_bug.cgi?id=212603
+
+Reviewed by Saam Barati.
+
+The current implementation mistakenly sets the address type to that of the value
+being loaded.  I encountered this issue when I was trying to do a loadb from a
+global address.  Because of this bug, the emitted code was trying do a load using
+%al (8 byte register) as the pointer to load from.  With this fix, it now loads
+from %rax.
+
+* offlineasm/x86.rb:
+
+2020-06-02  Alan Coon  
+
 Cherry-pick r262434. rdar://problem/63891520
 
 Change Gigacage::Config to use storage in WebConfig::g_config instead of its own.


Modified: branches/safari-610.1.15-branch/Source/_javascript_Core/offlineasm/x86.rb (262457 => 262458)

--- branches/safari-610.1.15-branch/Source/_javascript_Core/offlineasm/x86.rb	2020-06-02 22:33:46 UTC (rev 262457)
+++ branches/safari-610.1.15-branch/Source/_javascript_Core/offlineasm/x86.rb	2020-06-02 23:05:13 UTC (rev 262458)
@@ -1,4 +1,4 @@
-# Copyright (C) 2012-2018 Apple Inc. All rights reserved.
+# Copyright (C) 2012-2020 Apple Inc. All rights reserved.
 # Copyright (C) 2013 Digia Plc. and/or its subsidiary(-ies)
 #
 # Redistribution and use in source and binary forms, with or without
@@ -447,7 +447,7 @@
 else
 $asm.puts "lea #{dst.x86Operand(:ptr)}, #{asmLabel}"
 end
-"#{offset}(#{dst.x86Operand(kind)})"
+"#{offset}(#{dst.x86Operand(:ptr)})"
 end
 end
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262457] trunk/LayoutTests

2020-06-02 Thread lawrence . j

Title: [262457] trunk/LayoutTests








Revision 262457
Author lawrenc...@apple.com
Date 2020-06-02 15:33:46 -0700 (Tue, 02 Jun 2020)


Log Message
[ Mac wk1 Debug ] svg/custom/textPath-insert-path.svg is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=212665

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262456 => 262457)

--- trunk/LayoutTests/ChangeLog	2020-06-02 22:26:02 UTC (rev 262456)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 22:33:46 UTC (rev 262457)
@@ -1,3 +1,12 @@
+2020-06-02  Jason Lawrence  
+
+[ Mac wk1 Debug ] svg/custom/textPath-insert-path.svg is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=212665
+
+Unreviewed test gardening.
+
+* platform/mac-wk1/TestExpectations:
+
 2020-06-02  Peng Liu  
 
 Stressing webkitSetPresentationMode leads to wrong inline video dimensions


Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (262456 => 262457)

--- trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-06-02 22:26:02 UTC (rev 262456)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations	2020-06-02 22:33:46 UTC (rev 262457)
@@ -944,3 +944,5 @@
 webkit.org/b/208477 accessibility/mac/text-marker-for-index.html [ Skip ]
 
 webkit.org/b/211923 imported/w3c/web-platform-tests/fetch/api/basic/stream-safe-creation.any.html [ Pass Crash ]
+
+webkit.org/b/212665 svg/custom/textPath-insert-path.svg [ Pass ImageOnlyFailure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262456] trunk

2020-06-02 Thread peng . liu6

Title: [262456] trunk








Revision 262456
Author peng.l...@apple.com
Date 2020-06-02 15:26:02 -0700 (Tue, 02 Jun 2020)


Log Message
Stressing webkitSetPresentationMode leads to wrong inline video dimensions
https://bugs.webkit.org/show_bug.cgi?id=202425

Reviewed by Eric Carlson.

Source/WebCore:

Make the HTMLVideoElement::setFullscreenMode() robust under stress tests
by ignoring a request when the video element is not ready yet.

Manually tested.

* dom/Element.h:
(WebCore::Element::didStopBeingFullscreenElement):
Add a callback to indicate that the element has exited fullscreen.
* dom/FullscreenManager.cpp:
(WebCore::FullscreenManager::didExitFullscreen):
Call Element::didStopBeingFullscreenElement() when the element has exited fullscreen.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::enterFullscreen):
* html/HTMLMediaElement.h:

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitDisplayingFullscreen):
This function will return true when a video element is in the process to exit
fullscreen/picture-in-picture until it has completed the process. Therefore, a page
can safely request the video element to enter fullscreen/picture-in-picture when
this function returns false.

(WebCore::HTMLVideoElement::setFullscreenMode):
(WebCore::HTMLVideoElement::didBecomeFullscreenElement):
(WebCore::HTMLVideoElement::didStopBeingFullscreenElement):
(WebCore::HTMLVideoElement::didEnterFullscreen): Deleted.
(WebCore::HTMLVideoElement::didExitFullscreen): Deleted.
* html/HTMLVideoElement.h:
Add a flag m_isChangingPresentationMode. webkitSetPresentationMode() will only
change the presentation mode when the flag is false.

Source/WebKit:

* WebProcess/cocoa/VideoFullscreenManager.mm:
(WebKit::VideoFullscreenManager::didEnterFullscreen):
(WebKit::VideoFullscreenManager::didCleanupFullscreen):

Source/WebKitLegacy/mac:

Move DumpRenderTree's implementation of the mock video presentation mode from WebView
to WebChromeClient and call videoElement.didStopBeingFullscreenElement() when a video
element exits fullscreen.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::setMockVideoPresentationModeEnabled):
(WebChromeClient::enterVideoFullscreenForVideoElement):
(WebChromeClient::exitVideoFullscreenForVideoElement):
(WebChromeClient::exitVideoFullscreenToModeWithoutAnimation):
* WebView/WebView.mm:
(-[WebView _enterVideoFullscreenForVideoElement:mode:]):
(-[WebView _exitVideoFullscreen]):
(-[WebView _setMockVideoPresentationModeEnabled:]): Deleted.
* WebView/WebViewData.h:
* WebView/WebViewInternal.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
(TEST):

LayoutTests:

Enable the mock video presentation mode in WebKitTestRunner and
only request a video element to enter/exit fullscreen/picture-in-picture when
the element is ready to do so (by checking the attribute webkitDisplayingFullscreen).

* media/modern-media-controls/placard-support/placard-support-pip-expected.txt:
* media/modern-media-controls/placard-support/placard-support-pip.html:
* media/presentationmodechanged-fired-once-expected.txt:
* media/presentationmodechanged-fired-once.html:
* media/video-presentation-mode-expected.txt:
* media/video-presentation-mode.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip-expected.txt
trunk/LayoutTests/media/modern-media-controls/placard-support/placard-support-pip.html
trunk/LayoutTests/media/presentationmodechanged-fired-once-expected.txt
trunk/LayoutTests/media/presentationmodechanged-fired-once.html
trunk/LayoutTests/media/video-presentation-mode-expected.txt
trunk/LayoutTests/media/video-presentation-mode.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/FullscreenManager.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/html/HTMLMediaElement.h
trunk/Source/WebCore/html/HTMLVideoElement.cpp
trunk/Source/WebCore/html/HTMLVideoElement.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm
trunk/Source/WebKitLegacy/mac/ChangeLog
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.mm
trunk/Source/WebKitLegacy/mac/WebView/WebView.mm
trunk/Source/WebKitLegacy/mac/WebView/WebViewData.h
trunk/Source/WebKitLegacy/mac/WebView/WebViewInternal.h
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm




Diff

Modified: trunk/LayoutTests/ChangeLog (262455 => 262456)

--- trunk/LayoutTests/ChangeLog	2020-06-02 22:13:07 UTC (rev 262455)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 22:26:02 UTC (rev 262456)
@@ -1,3 +1,21 @@
+2020-06-02  Peng Liu  
+
+Stressing webkitSetPresentationMode leads to wrong inline video dimensions
+https://bugs.webkit.org/show_bug.cgi?id=202425
+
+Reviewed by Eric Carlson.
+
+

[webkit-changes] [262455] trunk/Source/WebKit

2020-06-02 Thread katherine_cheney

Title: [262455] trunk/Source/WebKit








Revision 262455
Author katherine_che...@apple.com
Date 2020-06-02 15:13:07 -0700 (Tue, 02 Jun 2020)


Log Message
Assert network process is not suspended when trying to merge new ITP data
https://bugs.webkit.org/show_bug.cgi?id=212663


Reviewed by Chris Dumez.

Add a debug assert to check if statistics are being merged into the
ITP database after prepareToSuspend() has been called. If this assert
is hit, it means the ITP database thread is not being stopped when
the process is suspended.

* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (262454 => 262455)

--- trunk/Source/WebKit/ChangeLog	2020-06-02 21:58:34 UTC (rev 262454)
+++ trunk/Source/WebKit/ChangeLog	2020-06-02 22:13:07 UTC (rev 262455)
@@ -1,3 +1,19 @@
+2020-06-02  Kate Cheney  
+
+Assert network process is not suspended when trying to merge new ITP data
+https://bugs.webkit.org/show_bug.cgi?id=212663
+
+
+Reviewed by Chris Dumez.
+
+Add a debug assert to check if statistics are being merged into the
+ITP database after prepareToSuspend() has been called. If this assert
+is hit, it means the ITP database thread is not being stopped when
+the process is suspended.
+
+* NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp:
+(WebKit::WebResourceLoadStatisticsStore::resourceLoadStatisticsUpdated):
+
 2020-06-02  Per Arne Vollan  
 
 REGRESSION(r261387): Introduced sandbox violations


Modified: trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp (262454 => 262455)

--- trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp	2020-06-02 21:58:34 UTC (rev 262454)
+++ trunk/Source/WebKit/NetworkProcess/Classifier/WebResourceLoadStatisticsStore.cpp	2020-06-02 22:13:07 UTC (rev 262455)
@@ -353,6 +353,7 @@
 if (!m_statisticsStore)
 return;
 
+ASSERT(suspendedState == State::Running);
 m_statisticsStore->mergeStatistics(WTFMove(statistics));
 
 // We can cancel any pending request to process statistics since we're doing it synchronously below.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262445] branches/safari-610.1.15-branch/Source

Title: [262445] branches/safari-610.1.15-branch/Source








Revision 262445
Author alanc...@apple.com
Date 2020-06-02 14:58:10 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262356. rdar://problem/63891520

Change JSC::Config to use storage in WTF::Config instead of its own.
https://bugs.webkit.org/show_bug.cgi?id=212575


Reviewed by Yusuke Suzuki.

Source/_javascript_Core:

Since Configs must be rounded up to CeilingOnPageSize, this will save us some
memory since the contents of both Configs do not add up to CeilingOnPageSize.

g_jscConfig is now located at g_wtfConfig.spaceForExtensions.

* runtime/JSCConfig.cpp:
(JSC::Config::disableFreezingForTesting):
(JSC::Config::enableRestrictedOptions):
(JSC::Config::permanentlyFreeze): Deleted.
* runtime/JSCConfig.h:
(JSC::Config::permanentlyFreeze):
(JSC::Config::isPermanentlyFrozen):
(): Deleted.
* runtime/Options.cpp:
(JSC::Options::setOptions):
* tools/JSDollarVM.cpp:
(JSC::functionCallWithStackSize):

Source/WTF:

* wtf/WTFConfig.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog
branches/safari-610.1.15-branch/Source/_javascript_Core/runtime/JSCConfig.cpp
branches/safari-610.1.15-branch/Source/_javascript_Core/runtime/JSCConfig.h
branches/safari-610.1.15-branch/Source/_javascript_Core/runtime/Options.cpp
branches/safari-610.1.15-branch/Source/_javascript_Core/tools/JSDollarVM.cpp
branches/safari-610.1.15-branch/Source/WTF/ChangeLog
branches/safari-610.1.15-branch/Source/WTF/wtf/WTFConfig.h




Diff

Modified: branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog (262444 => 262445)

--- branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog	2020-06-02 21:58:07 UTC (rev 262444)
+++ branches/safari-610.1.15-branch/Source/_javascript_Core/ChangeLog	2020-06-02 21:58:10 UTC (rev 262445)
@@ -1,3 +1,66 @@
+2020-06-02  Alan Coon  
+
+Cherry-pick r262356. rdar://problem/63891520
+
+Change JSC::Config to use storage in WTF::Config instead of its own.
+https://bugs.webkit.org/show_bug.cgi?id=212575
+
+
+Reviewed by Yusuke Suzuki.
+
+Source/_javascript_Core:
+
+Since Configs must be rounded up to CeilingOnPageSize, this will save us some
+memory since the contents of both Configs do not add up to CeilingOnPageSize.
+
+g_jscConfig is now located at g_wtfConfig.spaceForExtensions.
+
+* runtime/JSCConfig.cpp:
+(JSC::Config::disableFreezingForTesting):
+(JSC::Config::enableRestrictedOptions):
+(JSC::Config::permanentlyFreeze): Deleted.
+* runtime/JSCConfig.h:
+(JSC::Config::permanentlyFreeze):
+(JSC::Config::isPermanentlyFrozen):
+(): Deleted.
+* runtime/Options.cpp:
+(JSC::Options::setOptions):
+* tools/JSDollarVM.cpp:
+(JSC::functionCallWithStackSize):
+
+Source/WTF:
+
+* wtf/WTFConfig.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-05-31  Mark Lam  
+
+Change JSC::Config to use storage in WTF::Config instead of its own.
+https://bugs.webkit.org/show_bug.cgi?id=212575
+
+
+Reviewed by Yusuke Suzuki.
+
+Since Configs must be rounded up to CeilingOnPageSize, this will save us some
+memory since the contents of both Configs do not add up to CeilingOnPageSize.
+
+g_jscConfig is now located at g_wtfConfig.spaceForExtensions.
+
+* runtime/JSCConfig.cpp:
+(JSC::Config::disableFreezingForTesting):
+(JSC::Config::enableRestrictedOptions):
+(JSC::Config::permanentlyFreeze): Deleted.
+* runtime/JSCConfig.h:
+(JSC::Config::permanentlyFreeze):
+(JSC::Config::isPermanentlyFrozen):
+(): Deleted.
+* runtime/Options.cpp:
+(JSC::Options::setOptions):
+* tools/JSDollarVM.cpp:
+(JSC::functionCallWithStackSize):
+
 2020-05-23  Paulo Matos  
 
 Fix non-unified builds for x86_64


Modified: branches/safari-610.1.15-branch/Source/_javascript_Core/runtime/JSCConfig.cpp (262444 => 262445)

--- branches/safari-610.1.15-branch/Source/_javascript_Core/runtime/JSCConfig.cpp	2020-06-02 21:58:07 UTC (rev 262444)
+++ branches/safari-610.1.15-branch/Source/_javascript_Core/runtime/JSCConfig.cpp	2020-06-02 21:58:10 UTC (rev 262445)
@@ -26,61 +26,18 @@
 #include "config.h"
 #include "JSCConfig.h"
 
-#include 
-#include 
-#include 
-
-#if OS(DARWIN)
-#include 
-#elif OS(LINUX)
-#include 
-#endif
-
 namespace JSC {
 
-alignas(ConfigSizeToProtect) JS_EXPORT_PRIVATE Config g_jscConfig;
-
 void Config::disableFreezingForTesting()
 {
-RELEASE_ASSERT(!g_jscConfig.isPermanentlyFrozen);
+RELEASE_ASSERT(!g_jscCon

[webkit-changes] [262449] branches/safari-610.1.15-branch/Source/WebKit

Title: [262449] branches/safari-610.1.15-branch/Source/WebKit








Revision 262449
Author alanc...@apple.com
Date 2020-06-02 14:58:20 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262429. rdar://problem/63891546

macCatalyst: WKWebView's tint color is not propagated to Web Content process
https://bugs.webkit.org/show_bug.cgi?id=212630

Reviewed by Anders Carlsson.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/Cocoa/PageClientImplCocoa.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebKit/ChangeLog
branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.cpp
branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.h
branches/safari-610.1.15-branch/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
branches/safari-610.1.15-branch/Source/WebKit/UIProcess/PageClient.h
branches/safari-610.1.15-branch/Source/WebKit/UIProcess/WebPageProxy.cpp
branches/safari-610.1.15-branch/Source/WebKit/WebProcess/WebPage/WebPage.cpp
branches/safari-610.1.15-branch/Source/WebKit/WebProcess/WebPage/WebPage.h




Diff

Modified: branches/safari-610.1.15-branch/Source/WebKit/ChangeLog (262448 => 262449)

--- branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:17 UTC (rev 262448)
+++ branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:20 UTC (rev 262449)
@@ -1,5 +1,46 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262429. rdar://problem/63891546
+
+macCatalyst: WKWebView's tint color is not propagated to Web Content process
+https://bugs.webkit.org/show_bug.cgi?id=212630
+
+Reviewed by Anders Carlsson.
+
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode const):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* UIProcess/Cocoa/PageClientImplCocoa.h:
+* UIProcess/PageClient.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::creationParameters):
+* WebProcess/WebPage/WebPage.cpp:
+* WebProcess/WebPage/WebPage.h:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-06-02  Tim Horton  
+
+macCatalyst: WKWebView's tint color is not propagated to Web Content process
+https://bugs.webkit.org/show_bug.cgi?id=212630
+
+Reviewed by Anders Carlsson.
+
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode const):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* UIProcess/Cocoa/PageClientImplCocoa.h:
+* UIProcess/PageClient.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::creationParameters):
+* WebProcess/WebPage/WebPage.cpp:
+* WebProcess/WebPage/WebPage.h:
+
+2020-06-02  Alan Coon  
+
 Cherry-pick r262427. rdar://problem/63891546
 
 REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView


Modified: branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.cpp (262448 => 262449)

--- branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.cpp	2020-06-02 21:58:17 UTC (rev 262448)
+++ branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.cpp	2020-06-02 21:58:20 UTC (rev 262449)
@@ -113,6 +113,9 @@
 encoder << smartInsertDeleteEnabled;
 encoder << additionalSupportedImageTypes;
 #endif
+#if ENABLE(TINT_COLOR_SUPPORT)
+encoder << tintColor;
+#endif
 #if USE(WPE_RENDERER)
 encoder << hostFileDescriptor;
 #endif
@@ -353,6 +356,11 @@
 return WTF::nullopt;
 #endif
 
+#if ENABLE(TINT_COLOR_SUPPORT)
+if (!decoder.decode(parameters.tintColor))
+return WTF::nullopt;
+#endif
+
 #if USE(WPE_RENDERER)
 if (!decoder.decode(parameters.hostFileDescriptor))
 return WTF::nullopt;


Modified: branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.h (262448 => 262449)

--- branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.h	2020-06-02 21:58:17 UTC (rev 262448)
+++ branches/safari-610.1.15-branch/Source/WebKit/Shared/WebPageCreationParameters.h	2020-06-02 21:58:20 UTC (rev 262449)
@@ -174,6 +174,9 @@
 bool smartInsertDeleteEnabled;
 Vector additionalSupportedImageTypes;
 #endif
+#if ENABLE(TINT_COLOR_SUPPORT)
+WebCore::Color tintCo

[webkit-changes] [262450] branches/safari-610.1.15-branch/Source

Title: [262450] branches/safari-610.1.15-branch/Source

Revision 262450
Author alanc...@apple.com
Date 2020-06-02 14:58:25 -0700 (Tue, 02 Jun 2020)

Log Message
Cherry-pick r262434. rdar://problem/63891520

Change Gigacage::Config to use storage in WebConfig::g_config instead of its own.
https://bugs.webkit.org/show_bug.cgi?id=212585

Reviewed by Yusuke Suzuki.

Source/bmalloc:

1. Gigacage::Config now reserves and expect space to be available in an external
WebConfig::g_config buffer. Gigacage does not allocate that buffer.

2. Moved Gigacage::Config to GigacageConfig.h.
This allows WTFConfig.h to include GigacageConfig.h instead of all of Gigacage.h.

3. Moved Gigacage::Kind to GigacageKind.h.
Otherwise, Gigacage::Kind would need to move to GigacageConfig.h which is a
weird place to put it.

4. Removed freezeGigacageConfig(), unfreezeGigacageConfig(), and
permanentlyFreezeGigacageConfig().

It is no longer possible to temporarily freeze and unfreeze the Gigacage::Config
because it now share the same memory page with higher level Configs.

permanentlyFreezeGigacageConfig() is no longer needed because it is subsumed
by WTF::Config::permanentlyFreeze(), which will freeze the entire WebConfig::g_config
buffer.

One difference in behavior here is that Gigacage::Config data used to be permanently
frozen as soon as forbidDisablingPrimitiveGigacage() is called. Now, it isn't
permanently frozen until the end of the construction of the first JSC::VM instance
in the process (just like the other Config records). This still guarantees that
it is frozen before any JS script can run.

5. Previously, disablePrimitiveGigacage() works by nullifying the Primitive gigacage
base pointer. We can no longer do that because the base pointer will be frozen
on VM instantiation. Instead, if not forbidden, we now disable the Primitive
gigacage by setting a disablePrimitiveGigacageRequested bool variable that is
not frozen in the Gigacage::Config.

To check if the Primitive gigacage is enabled, the LLInt, AssemblyHelpers::cageConditionally(),
and runtime functions will check the following conditions:

g_gigacageConfig.basePtr(Primitive) &&
(disablingPrimitiveGigacageIsForbidden() || disableNotRequestedForPrimitiveGigacage())

The base pointer being null means the gigacage was never set up.

If disablingPrimitiveGigacageIsForbidden() is true, then we don't care
whether a disable request has been received.

Otherwise, the gigacage is only enabled if it has been set up, and a
disable request has not been received.

Note that the first 2 terms are frozen in the Gigacage::Config. Only the
last term is a runtime variable. If disabling is forbidden, then the
runtime variable never comes into play.

The FTL does not rely on a runtime check for whether the Primitive gigacage is
enabled or not. Instead, it relies on a watchpoint to handle this. So, it
just works, and there's no performance penalty with adding the 2 extra terms
to check.

Note also that the jsc shell and the WebProcess will forbid disabling of the
Primitive gigacage. This means the AssemblyHelpers::cageConditionally() will
also not generate the runtime checks for the 2 extra terms.

Only the LLInt and runtime functions will have to do work to check the 2 extra
terms. But because these are not in perf critical paths, this is ok.

Note that we're deliberately gating the disablePrimitiveGigacageRequested
variable check on disablingPrimitiveGigacageIsForbidden though, logically, the
isEnable check does not really depend on whether disabling is forbidden or not.
We do this because disablingPrimitiveGigacageIsForbidden is frozen in the Config,
and it is, therefore, a stronger guarantee of correctness whereas the variable
can be corrupted.

6. Replaced isDisablingPrimitiveGigacageForbidden(), canPrimitiveGigacageBeDisabled(),
and isPrimitiveGigacagePermanentlyEnabled() with disablingPrimitiveGigacageIsForbidden().

* CMakeLists.txt:
* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::forbidDisablingPrimitiveGigacage):
(Gigacage::bmalloc::freezeGigacageConfig): Deleted.
(Gigacage::bmalloc::unfreezeGigacageConfig): Deleted.
(Gigacage::bmalloc::permanentlyFreezeGigacageConfig): Deleted.
(Gigacage::bmalloc::UnfreezeGigacageConfigScope::UnfreezeGigacageConfigScope): Deleted.
(Gigacage::bmalloc::UnfreezeGigacageConfigScope::~UnfreezeGigacageConfigScope): Deleted.
(Gigacage::isDisablingPrimitiveGigacageForbidden): Deleted.
* bm

[webkit-changes] [262454] branches/safari-610.1.15-branch/Source/WebCore

Title: [262454] branches/safari-610.1.15-branch/Source/WebCore








Revision 262454
Author alanc...@apple.com
Date 2020-06-02 14:58:34 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262428. rdar://problem/63891546

UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors
https://bugs.webkit.org/show_bug.cgi?id=212631

Reviewed by Anders Carlsson.

* platform/graphics/mac/ColorMac.mm:
(WebCore::colorFromNSColor):
(WebCore::semanticColorFromNSColor):
* platform/ios/ColorIOS.mm:
(WebCore::colorFromUIColor):
This doesn't affect any code currently in WebKit, but it is very, very surprising
that these functions happily accept a null color, assert in debug, but in release
do crazy things like try to paint the null color into a small bitmap to figure out
what it really is.

Also, this matches the behavior of the Color constructors that take CGColorRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebCore/ChangeLog
branches/safari-610.1.15-branch/Source/WebCore/platform/graphics/mac/ColorMac.mm
branches/safari-610.1.15-branch/Source/WebCore/platform/ios/ColorIOS.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WebCore/ChangeLog (262453 => 262454)

--- branches/safari-610.1.15-branch/Source/WebCore/ChangeLog	2020-06-02 21:58:32 UTC (rev 262453)
+++ branches/safari-610.1.15-branch/Source/WebCore/ChangeLog	2020-06-02 21:58:34 UTC (rev 262454)
@@ -1,5 +1,47 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262428. rdar://problem/63891546
+
+UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors
+https://bugs.webkit.org/show_bug.cgi?id=212631
+
+Reviewed by Anders Carlsson.
+
+* platform/graphics/mac/ColorMac.mm:
+(WebCore::colorFromNSColor):
+(WebCore::semanticColorFromNSColor):
+* platform/ios/ColorIOS.mm:
+(WebCore::colorFromUIColor):
+This doesn't affect any code currently in WebKit, but it is very, very surprising
+that these functions happily accept a null color, assert in debug, but in release
+do crazy things like try to paint the null color into a small bitmap to figure out
+what it really is.
+
+Also, this matches the behavior of the Color constructors that take CGColorRef.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-06-02  Tim Horton  
+
+UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors
+https://bugs.webkit.org/show_bug.cgi?id=212631
+
+Reviewed by Anders Carlsson.
+
+* platform/graphics/mac/ColorMac.mm:
+(WebCore::colorFromNSColor):
+(WebCore::semanticColorFromNSColor):
+* platform/ios/ColorIOS.mm:
+(WebCore::colorFromUIColor):
+This doesn't affect any code currently in WebKit, but it is very, very surprising
+that these functions happily accept a null color, assert in debug, but in release
+do crazy things like try to paint the null color into a small bitmap to figure out
+what it really is.
+
+Also, this matches the behavior of the Color constructors that take CGColorRef.
+
+2020-06-02  Alan Coon  
+
 Cherry-pick r262398. rdar://problem/63891512
 
 TextManipulationController should put one Node in only one paragraph


Modified: branches/safari-610.1.15-branch/Source/WebCore/platform/graphics/mac/ColorMac.mm (262453 => 262454)

--- branches/safari-610.1.15-branch/Source/WebCore/platform/graphics/mac/ColorMac.mm	2020-06-02 21:58:32 UTC (rev 262453)
+++ branches/safari-610.1.15-branch/Source/WebCore/platform/graphics/mac/ColorMac.mm	2020-06-02 21:58:34 UTC (rev 262454)
@@ -92,11 +92,21 @@
 
 Color colorFromNSColor(NSColor *color)
 {
+if (!color)
+return { };
+
+// FIXME: ExtendedColor - needs to handle color spaces.
+
 return Color(makeRGBAFromNSColor(color));
 }
 
 Color semanticColorFromNSColor(NSColor *color)
 {
+if (!color)
+return { };
+
+// FIXME: ExtendedColor - needs to handle color spaces.
+
 return Color(makeRGBAFromNSColor(color), Color::Semantic);
 }
 


Modified: branches/safari-610.1.15-branch/Source/WebCore/platform/ios/ColorIOS.mm (262453 => 262454)

--- branches/safari-610.1.15-branch/Source/WebCore/platform/ios/ColorIOS.mm	2020-06-02 21:58:32 UTC (rev 262453)
+++ branches/safari-610.1.15-branch/Source/WebCore/platform/ios/ColorIOS.mm	2020-06-02 21:58:34 UTC (rev 262454)
@@ -34,6 +34,9 @@
 
 Color colorFromUIColor(UIColor *color)
 {
+if (!color)
+return { };
+
 // FIXME: Make this work for a UIColor that was created from a pattern or a DispayP3 color.
 CGFloat redComponent;
 CGFloat greenComponent;






_

[webkit-changes] [262442] branches/safari-610.1.15-branch

Title: [262442] branches/safari-610.1.15-branch








Revision 262442
Author alanc...@apple.com
Date 2020-06-02 14:58:03 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262279. rdar://problem/63891510

[Apple Pay] Buttons render with a corner radius of PKApplePayButtonDefaultCornerRadius even when explicitly specifying "border-radius: 0px"
https://bugs.webkit.org/show_bug.cgi?id=212476


Reviewed by Antti Koivisto.

Source/WebCore:

r256648 added support for customizing the corner radius of Apple Pay buttons using the
border-radius CSS property. PassKit buttons have a default corner radius of 4, but
border-radius has an initial value of 0, so to maintain web compatibility with existing
buttons we only want to customize the corner radius when a border-radius value has been
explicitly specified (otherwise, previously rounded buttons would all become squared off due
to border-radius's initial value).

r256648 checked for a non-initial border-radius by calling RenderStyle::hasBorderRadius, but
this check does not distinguish between an initial value and an explicit declaration of
"border-radius: 0px". As a result, authors are unable to create Apple Pay buttons with
square corners.

This patch adds a flag to RenderStyle::NonInheritedFlags that tracks whether any
border-radius longhand has been explicitly set (or has explicitly inherited an explicitly set
value), and uses that flag to adjust the computed border radius for Apple Pay buttons.

The addition of RenderStyle::NonInheritedFlags::hasExplicitlySetBorderRadius did not change
the size of RenderStyle.

Tests: fast/css/appearance-apple-pay-button-border-radius.html
   fast/css/getComputedStyle/computed-style-apple-pay-button.html

* css/CSSProperties.json:
* rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::adjustApplePayButtonStyle const):
(WebCore::RenderThemeCocoa::paintApplePayButton):
(WebCore::largestCornerRadius): Deleted.
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::RenderStyle):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyle::hasExplicitlySetBorderRadius const):
(WebCore::RenderStyle::setHasExplicitlySetBorderRadius):
(WebCore::RenderStyle::NonInheritedFlags::operator== const):
(WebCore::RenderStyle::NonInheritedFlags::copyNonInheritedFrom):
* style/StyleBuilderCustom.h:
(WebCore::Style::BuilderCustom::applyInheritBorderBottomLeftRadius):
(WebCore::Style::BuilderCustom::applyValueBorderBottomLeftRadius):
(WebCore::Style::BuilderCustom::applyInheritBorderBottomRightRadius):
(WebCore::Style::BuilderCustom::applyValueBorderBottomRightRadius):
(WebCore::Style::BuilderCustom::applyInheritBorderTopLeftRadius):
(WebCore::Style::BuilderCustom::applyValueBorderTopLeftRadius):
(WebCore::Style::BuilderCustom::applyInheritBorderTopRightRadius):
(WebCore::Style::BuilderCustom::applyValueBorderTopRightRadius):

LayoutTests:

* TestExpectations:
* fast/css/appearance-apple-pay-button-border-radius-expected.html: Added.
* fast/css/appearance-apple-pay-button-border-radius.html: Added.
* fast/css/appearance-apple-pay-button-expected.html:
* fast/css/appearance-apple-pay-button.html:
* fast/css/getComputedStyle/computed-style-apple-pay-button-expected.txt: Added.
* fast/css/getComputedStyle/computed-style-apple-pay-button.html: Added.
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/LayoutTests/ChangeLog
branches/safari-610.1.15-branch/LayoutTests/TestExpectations
branches/safari-610.1.15-branch/LayoutTests/fast/css/appearance-apple-pay-button-expected.html
branches/safari-610.1.15-branch/LayoutTests/fast/css/appearance-apple-pay-button.html
branches/safari-610.1.15-branch/LayoutTests/platform/mac/TestExpectations
branches/safari-610.1.15-branch/Source/WebCore/ChangeLog
branches/safari-610.1.15-branch/Source/WebCore/css/CSSProperties.json
branches/safari-610.1.15-branch/Source/WebCore/rendering/RenderThemeCocoa.mm
branches/safari-610.1.15-branch/Source/WebCore/rendering/style/RenderStyle.cpp
branches/safari-610.1.15-branch/Source/WebCore/rendering/style/RenderStyle.h
branches/safari-610.1.15-branch/Source/WebCore/style/StyleBuilderCustom.h


Added Paths

branches/safari-610.1.15-branch/LayoutTests/fast/css/appearance-apple-pay-button-border-radius-expected.html
branches/safari-610.1.15-branch/LayoutTests/fast/css/appearance-apple-pay-button-border-radius.html
branches/safari-610.1.15-branch/LayoutTests/fast/css/getComputedStyle/computed-style-apple-pay-button-expected.txt
branches/safari-610.1.15-branch/LayoutTests/fast/css/getComputedStyle/computed-style-apple-pay-button.html




Diff

Modified: branches/safari-610.1.15-branch/LayoutTests/ChangeLog (262441 => 262442)

--- branches/saf

[webkit-changes] [262446] branches/safari-610.1.15-branch/Source/WebKit

Title: [262446] branches/safari-610.1.15-branch/Source/WebKit








Revision 262446
Author alanc...@apple.com
Date 2020-06-02 14:58:12 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262396. rdar://problem/63891587

Remove unused WebContent process sandbox syscall
https://bugs.webkit.org/show_bug.cgi?id=212609


Reviewed by Per Arne Vollan.

After further testing we have determined that the syscall added in
Bug 206260 is not always enabled. Check if the Sandbox recognizes
the rule before using it.

* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebKit/ChangeLog
branches/safari-610.1.15-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb
branches/safari-610.1.15-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in




Diff

Modified: branches/safari-610.1.15-branch/Source/WebKit/ChangeLog (262445 => 262446)

--- branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:10 UTC (rev 262445)
+++ branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:12 UTC (rev 262446)
@@ -1,5 +1,40 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262396. rdar://problem/63891587
+
+Remove unused WebContent process sandbox syscall
+https://bugs.webkit.org/show_bug.cgi?id=212609
+
+
+Reviewed by Per Arne Vollan.
+
+After further testing we have determined that the syscall added in
+Bug 206260 is not always enabled. Check if the Sandbox recognizes
+the rule before using it.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+* WebProcess/com.apple.WebProcess.sb.in:
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-06-01  Brent Fulgham  
+
+Remove unused WebContent process sandbox syscall
+https://bugs.webkit.org/show_bug.cgi?id=212609
+
+
+Reviewed by Per Arne Vollan.
+
+After further testing we have determined that the syscall added in
+Bug 206260 is not always enabled. Check if the Sandbox recognizes
+the rule before using it.
+
+* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+* WebProcess/com.apple.WebProcess.sb.in:
+
+2020-06-02  Alan Coon  
+
 Cherry-pick r262280. rdar://problem/63891526
 
 Avoid unnecessary sync IPC messages when togging the callout bar for selections.


Modified: branches/safari-610.1.15-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (262445 => 262446)

--- branches/safari-610.1.15-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-06-02 21:58:10 UTC (rev 262445)
+++ branches/safari-610.1.15-branch/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb	2020-06-02 21:58:12 UTC (rev 262446)
@@ -1189,11 +1189,12 @@
 (syscall-number SYS_kqueue_workloop_ctl) ;; 
 (syscall-number SYS_psynch_rw_rdlock) ;; 
 (syscall-number SYS_faccessat) ;; 
-(syscall-number SYS_objc_bp_assist_cfg_np) ;; 
 (syscall-number SYS_shared_region_map_and_slide_2_np) ;; 
 (syscall-number SYS_ulock_wait2) ;; 
 (syscall-number SYS_fstat64_extended) ;; 
 )
+(if (defined? 'SYS_objc_bp_assist_cfg_np)
+(allow syscall-unix (syscall-number SYS_objc_bp_assist_cfg_np)))
 )
 
 (when (defined? 'mach-bootstrap)


Modified: branches/safari-610.1.15-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in (262445 => 262446)

--- branches/safari-610.1.15-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-06-02 21:58:10 UTC (rev 262445)
+++ branches/safari-610.1.15-branch/Source/WebKit/WebProcess/com.apple.WebProcess.sb.in	2020-06-02 21:58:12 UTC (rev 262446)
@@ -1087,9 +1087,13 @@
 (syscall-number SYS_faccessat) ;; 
 (syscall-number SYS_fsetxattr) ;; 
 #if __MAC_OS_X_VERSION_MIN_REQUIRED > 101500
-(syscall-number SYS_objc_bp_assist_cfg_np) ;; 
 (syscall-number SYS_ulock_wait2) ;; 
 #endif
 (syscall-number SYS_fstat64_extended) ;; 
 )
+
+#if __MAC_OS_X_VERSION_MIN_REQUIRED > 101500
+(if (defined? 'SYS_objc_bp_assist_cfg_np)
+(allow syscall-unix (syscall-number SYS_objc_bp_assist_cfg_np)))
+#endif
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262448] branches/safari-610.1.15-branch/Source/WebKit

Title: [262448] branches/safari-610.1.15-branch/Source/WebKit








Revision 262448
Author alanc...@apple.com
Date 2020-06-02 14:58:17 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262427. rdar://problem/63891546

REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
https://bugs.webkit.org/show_bug.cgi?id=212628


Reviewed by Per Arne Vollan.

Two issues with the "CFPrefs Direct Mode" mechanism caused dynamic changes to the
user accent color preference to not be respected anymore:

- the default change, when synchronized to the Web Content process, was
written into the wrong domain, because of bug 212627.

- AppKit caches the resolved accent color; the cache is invalidated when the
a CoreUI notification is posted. Since we synchronize preferences ourselves,
the ordering of the default change and notification are no longer guaranteed,
so AppKit sometimes reads and re-caches the old accent color.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::userAccentColorPreferenceKey):
(WebKit::shouldWriteToAppDomainForPreferenceKey):
(WebKit::WebProcess::notifyPreferencesChanged):
To fix the first problem, write the default into the standardUserDefaults.
This is just a workaround, we need a more general solution to this problem
for all global preferences. We know it's OK in this case, because AppKit
happens to read from standardUserDefaults.

(WebKit::dispatchSimulatedNotificationsForPreferenceChange):
To fix the second problem, re-emit the notification once we have synchronized
the preference to the Web Content process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebKit/ChangeLog
branches/safari-610.1.15-branch/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WebKit/ChangeLog (262447 => 262448)

--- branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:15 UTC (rev 262447)
+++ branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:17 UTC (rev 262448)
@@ -1,5 +1,74 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262427. rdar://problem/63891546
+
+REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=212628
+
+
+Reviewed by Per Arne Vollan.
+
+Two issues with the "CFPrefs Direct Mode" mechanism caused dynamic changes to the
+user accent color preference to not be respected anymore:
+
+- the default change, when synchronized to the Web Content process, was
+written into the wrong domain, because of bug 212627.
+
+- AppKit caches the resolved accent color; the cache is invalidated when the
+a CoreUI notification is posted. Since we synchronize preferences ourselves,
+the ordering of the default change and notification are no longer guaranteed,
+so AppKit sometimes reads and re-caches the old accent color.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::userAccentColorPreferenceKey):
+(WebKit::shouldWriteToAppDomainForPreferenceKey):
+(WebKit::WebProcess::notifyPreferencesChanged):
+To fix the first problem, write the default into the standardUserDefaults.
+This is just a workaround, we need a more general solution to this problem
+for all global preferences. We know it's OK in this case, because AppKit
+happens to read from standardUserDefaults.
+
+(WebKit::dispatchSimulatedNotificationsForPreferenceChange):
+To fix the second problem, re-emit the notification once we have synchronized
+the preference to the Web Content process.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-06-02  Tim Horton  
+
+REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=212628
+
+
+Reviewed by Per Arne Vollan.
+
+Two issues with the "CFPrefs Direct Mode" mechanism caused dynamic changes to the
+user accent color preference to not be respected anymore:
+
+- the default change, when synchronized to the Web Content process, was
+written into the wrong domain, because of bug 212627.
+
+- AppKit caches the resolved accent color; the cache is invalidated when the
+a CoreUI notification is posted. Since we synchronize preferences ourselves,
+the ordering of the default change and notification are no longer guaranteed,
+so AppKit sometimes reads and re-caches the old accent color.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::userAccentColorPreferenceKey):
+(WebKit::should

[webkit-changes] [262452] branches/safari-610.1.15-branch/Source

Title: [262452] branches/safari-610.1.15-branch/Source








Revision 262452
Author alanc...@apple.com
Date 2020-06-02 14:58:30 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262332. rdar://problem/63891529

[Cocoa] Improve logging quality for non-ephemeral sessions
https://bugs.webkit.org/show_bug.cgi?id=212551


Reviewed by David Kilzer.

Source/WebCore/PAL:

Add support for the 'nw_context_privacy_level' setting.

* pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

In Bug 209522 I switched normal mode logging to use the same privacy-protecting mode we use for ephemeral sessions.
This had the unintended consequence of removing network load data used to investigate networking issues.

This patch adopts the more fine-grained logging provided by the low-level 'nw_context_privacy_level' setting.

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID): Adopt 'nw_context_privacy_level' setting.

Source/WTF:

* wtf/PlatformHave.h: Add new feature check for CFNetwork convenience setter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WTF/ChangeLog
branches/safari-610.1.15-branch/Source/WTF/wtf/PlatformHave.h
branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog
branches/safari-610.1.15-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h
branches/safari-610.1.15-branch/Source/WebKit/ChangeLog
branches/safari-610.1.15-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WTF/ChangeLog (262451 => 262452)

--- branches/safari-610.1.15-branch/Source/WTF/ChangeLog	2020-06-02 21:58:27 UTC (rev 262451)
+++ branches/safari-610.1.15-branch/Source/WTF/ChangeLog	2020-06-02 21:58:30 UTC (rev 262452)
@@ -1,5 +1,47 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262332. rdar://problem/63891529
+
+[Cocoa] Improve logging quality for non-ephemeral sessions
+https://bugs.webkit.org/show_bug.cgi?id=212551
+
+
+Reviewed by David Kilzer.
+
+Source/WebCore/PAL:
+
+Add support for the 'nw_context_privacy_level' setting.
+
+* pal/spi/cf/CFNetworkSPI.h:
+
+Source/WebKit:
+
+In Bug 209522 I switched normal mode logging to use the same privacy-protecting mode we use for ephemeral sessions.
+This had the unintended consequence of removing network load data used to investigate networking issues.
+
+This patch adopts the more fine-grained logging provided by the low-level 'nw_context_privacy_level' setting.
+
+* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+(WebKit::configurationForSessionID): Adopt 'nw_context_privacy_level' setting.
+
+Source/WTF:
+
+* wtf/PlatformHave.h: Add new feature check for CFNetwork convenience setter.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-05-29  Brent Fulgham  
+
+[Cocoa] Improve logging quality for non-ephemeral sessions
+https://bugs.webkit.org/show_bug.cgi?id=212551
+
+
+Reviewed by David Kilzer.
+
+* wtf/PlatformHave.h: Add new feature check for CFNetwork convenience setter.
+
+2020-06-02  Alan Coon  
+
 Cherry-pick r262434. rdar://problem/63891520
 
 Change Gigacage::Config to use storage in WebConfig::g_config instead of its own.


Modified: branches/safari-610.1.15-branch/Source/WTF/wtf/PlatformHave.h (262451 => 262452)

--- branches/safari-610.1.15-branch/Source/WTF/wtf/PlatformHave.h	2020-06-02 21:58:27 UTC (rev 262451)
+++ branches/safari-610.1.15-branch/Source/WTF/wtf/PlatformHave.h	2020-06-02 21:58:30 UTC (rev 262452)
@@ -627,3 +627,7 @@
 #if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600)
 #define HAVE_DISPLAY_LAYER_BIPLANAR_SUPPORT 1
 #endif
+
+#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 14)
+#define HAVE_LOGGING_PRIVACY_LEVEL 1
+#endif


Modified: branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog (262451 => 262452)

--- branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog	2020-06-02 21:58:27 UTC (rev 262451)
+++ branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog	2020-06-02 21:58:30 UTC (rev 262452)
@@ -1,3 +1,47 @@
+2020-06-02  Alan Coon  
+
+Cherry-pick r262332. rdar://problem/63891529
+
+[Cocoa] Improve logging quality for non-ephemeral sessions
+https://bugs.webkit.org/show_bug.cgi?id=212551
+
+
+Reviewed by David Kilzer.
+
+Source/WebCore/PAL:
+
+Add support for the 'nw_context_privacy_level' setting.
+
+* pal/spi/cf/CFNetworkSPI.h:
+
+Source/WebKit:
+
+In Bug 209522 I switched normal mode logging to use the same privacy-protecting mode we use for

[webkit-changes] [262444] branches/safari-610.1.15-branch/Source/WebKitLegacy/mac

Title: [262444] branches/safari-610.1.15-branch/Source/WebKitLegacy/mac








Revision 262444
Author alanc...@apple.com
Date 2020-06-02 14:58:07 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262330. rdar://problem/63891486

REGRESSION (r260306): Compatibility issue leading to crash on macOS games



Reviewed by Brent Fulgham.

* WebView/WebView.mm:
(_WebSafeForwarder._target):
(_WebSafeForwarder._defaultTarget):
- Change __weak attribute to __unsafe_unretained to fix the
  crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/ChangeLog
branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/WebView/WebView.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/ChangeLog (262443 => 262444)

--- branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/ChangeLog	2020-06-02 21:58:05 UTC (rev 262443)
+++ branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/ChangeLog	2020-06-02 21:58:07 UTC (rev 262444)
@@ -1,3 +1,36 @@
+2020-06-02  Alan Coon  
+
+Cherry-pick r262330. rdar://problem/63891486
+
+REGRESSION (r260306): Compatibility issue leading to crash on macOS games
+
+
+
+Reviewed by Brent Fulgham.
+
+* WebView/WebView.mm:
+(_WebSafeForwarder._target):
+(_WebSafeForwarder._defaultTarget):
+- Change __weak attribute to __unsafe_unretained to fix the
+  crash.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-05-29  David Kilzer  
+
+REGRESSION (r260306): Compatibility issue leading to crash on macOS games
+
+
+
+Reviewed by Brent Fulgham.
+
+* WebView/WebView.mm:
+(_WebSafeForwarder._target):
+(_WebSafeForwarder._defaultTarget):
+- Change __weak attribute to __unsafe_unretained to fix the
+  crash.
+
 2020-05-21  Pinki Gyanchandani  
 
 Null Ptr Deref @ WebCore::ResourceResponse::platformLazyInit


Modified: branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/WebView/WebView.mm (262443 => 262444)

--- branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/WebView/WebView.mm	2020-06-02 21:58:05 UTC (rev 262443)
+++ branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/WebView/WebView.mm	2020-06-02 21:58:07 UTC (rev 262444)
@@ -564,8 +564,9 @@
 
 @interface _WebSafeForwarder : NSObject
 {
-__weak id _target;
-__weak id _defaultTarget;
+// Do not not change _target and _defaultTarget to __weak. See .
+__unsafe_unretained id _target;
+__unsafe_unretained id _defaultTarget;
 #if PLATFORM(IOS_FAMILY)
 _WebSafeAsyncForwarder *_asyncForwarder;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262447] branches/safari-610.1.15-branch

Title: [262447] branches/safari-610.1.15-branch








Revision 262447
Author alanc...@apple.com
Date 2020-06-02 14:58:15 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262398. rdar://problem/63891512

TextManipulationController should put one Node in only one paragraph
https://bugs.webkit.org/show_bug.cgi?id=212548

Reviewed by Wenson Hsieh.

Source/WebCore:

TextManipulationController mainly uses line break as delimiter to split paragraphs. In our current
implementation, if text of a Node has line break, the part before the line break is in one paragraph and the
part after the line break is in another paragraph, which means the Node is in the ranges of two paragraphs.
In this case, when TextManipulationController manipulates the first paragraph, it replaces all the Nodes in the
range of first paragraph with new Nodes. Then when it manipulates the second paragraph, if will find Node in the
range of second paragraph does not exist and fail (because the Node is removed when handling the first
paragraph.). Also, TextManipulationController currently does not preserve line breaks in text, which can be an
issue if these line breaks are visible.

This patch makes the ParagraphContentIterator iterate over Nodes instead of text, so a Node can only be in the
range of one paragraph. To do this, it makes line break and spaces around it as a special excluded token.
Here are the rules for splitting paragraphs by line break now:
1. If the special token is the first token in a Node, text in Nodes before the Node will make a paragraph.
2. If the special token is the last token in a Node, text in Nodes before the Node and in the Node will make a
paragraph.
3. If the special token in the middle of tokens in a Node, then we don't make a new paragraph until next special
token meets condition 1 or 2.

This patch also fixes the issue that Nodes out of the paragraph range can be removed due to the preorder Node
traversal, by finding and adding those Nodes back.

* editing/TextManipulationController.cpp:
(WebCore::ParagraphContentIterator::m_pastEndNode):
(WebCore::ParagraphContentIterator::advance):
(WebCore::ParagraphContentIterator::currentContent):
(WebCore::ParagraphContentIterator::atEnd const):
(WebCore::ParagraphContentIterator::advanceNode):
(WebCore::ParagraphContentIterator::advanceIteratorNodeAndUpdateText):
(WebCore::isEnclosingItemBoundaryElement):
(WebCore::TextManipulationController::parse):
(WebCore::TextManipulationController::observeParagraphs):
(WebCore::TextManipulationController::addItem):
(WebCore::TextManipulationController::getPath):
(WebCore::TextManipulationController::updateInsertions):
(WebCore::TextManipulationController::replace):
(WebCore::ParagraphContentIterator::startPosition): Deleted.
(WebCore::ParagraphContentIterator::endPosition): Deleted.
(WebCore::ParagraphContentIterator::moveCurrentNodeForward): Deleted.
(WebCore::containsOnlyHTMLSpaces): Deleted.
* editing/TextManipulationController.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebCore/ChangeLog
branches/safari-610.1.15-branch/Source/WebCore/editing/TextManipulationController.cpp
branches/safari-610.1.15-branch/Source/WebCore/editing/TextManipulationController.h
branches/safari-610.1.15-branch/Tools/ChangeLog
branches/safari-610.1.15-branch/Tools/TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WebCore/ChangeLog (262446 => 262447)

--- branches/safari-610.1.15-branch/Source/WebCore/ChangeLog	2020-06-02 21:58:12 UTC (rev 262446)
+++ branches/safari-610.1.15-branch/Source/WebCore/ChangeLog	2020-06-02 21:58:15 UTC (rev 262447)
@@ -1,5 +1,113 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262398. rdar://problem/63891512
+
+TextManipulationController should put one Node in only one paragraph
+https://bugs.webkit.org/show_bug.cgi?id=212548
+
+Reviewed by Wenson Hsieh.
+
+Source/WebCore:
+
+TextManipulationController mainly uses line break as delimiter to split paragraphs. In our current
+implementation, if text of a Node has line break, the part before the line break is in one paragraph and the
+part after the line break is in another paragraph, which means the Node is in the ranges of two paragraphs.
+In this case, when TextManipulationController manipulates the first paragraph, it replaces all the Nodes in the
+range of first paragraph with new Nodes. Then when it manipulates the second paragraph, if will find Node in the
+range of second paragraph does not exist and fail (because the Node is removed when handling the first
+paragraph.)

[webkit-changes] [262443] branches/safari-610.1.15-branch/Source/WebKit

Title: [262443] branches/safari-610.1.15-branch/Source/WebKit








Revision 262443
Author alanc...@apple.com
Date 2020-06-02 14:58:05 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262280. rdar://problem/63891526

Avoid unnecessary sync IPC messages when togging the callout bar for selections.
https://bugs.webkit.org/show_bug.cgi?id=212508

The loupe gesture only needs to be activated and evaluated if the tap is inside
an existing selectionView. We can do that test in the UIProcess without resorting to a sync IPC message.
Doing that evaluation locally will eliminate unnecessary hangs in the UIProcess.

Reviewed by Wenson Hsieh.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _pointIsInsideSelectionRect:outBoundingRect:]):
(-[WKContentView _shouldToggleSelectionCommandsAfterTapAt:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebKit/ChangeLog
branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WebKit/ChangeLog (262442 => 262443)

--- branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:03 UTC (rev 262442)
+++ branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:58:05 UTC (rev 262443)
@@ -1,5 +1,42 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262280. rdar://problem/63891526
+
+Avoid unnecessary sync IPC messages when togging the callout bar for selections.
+https://bugs.webkit.org/show_bug.cgi?id=212508
+
+The loupe gesture only needs to be activated and evaluated if the tap is inside
+an existing selectionView. We can do that test in the UIProcess without resorting to a sync IPC message.
+Doing that evaluation locally will eliminate unnecessary hangs in the UIProcess.
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _pointIsInsideSelectionRect:outBoundingRect:]):
+(-[WKContentView _shouldToggleSelectionCommandsAfterTapAt:]):
+(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-05-28  Megan Gardner  
+
+Avoid unnecessary sync IPC messages when togging the callout bar for selections.
+https://bugs.webkit.org/show_bug.cgi?id=212508
+
+The loupe gesture only needs to be activated and evaluated if the tap is inside
+an existing selectionView. We can do that test in the UIProcess without resorting to a sync IPC message.
+Doing that evaluation locally will eliminate unnecessary hangs in the UIProcess.
+
+Reviewed by Wenson Hsieh.
+
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView _pointIsInsideSelectionRect:outBoundingRect:]):
+(-[WKContentView _shouldToggleSelectionCommandsAfterTapAt:]):
+(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
+
+2020-06-02  Alan Coon  
+
 Cherry-pick r262255. rdar://problem/63891604
 
 Do not send a second sync request for positition information to the web process if we have not recieved information since the previous sync request.


Modified: branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (262442 => 262443)

--- branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-06-02 21:58:03 UTC (rev 262442)
+++ branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-06-02 21:58:05 UTC (rev 262443)
@@ -2328,12 +2328,8 @@
 return textSelectionRects;
 }
 
-- (BOOL)_shouldToggleSelectionCommandsAfterTapAt:(CGPoint)point
+- (BOOL)_pointIsInsideSelectionRect:(CGPoint)point outBoundingRect:(WebCore::FloatRect *)outBoundingRect
 {
-if (_lastSelectionDrawingInfo.selectionRects.isEmpty())
-return NO;
-
-WebCore::FloatRect selectionBoundingRect;
 BOOL pointIsInSelectionRect = NO;
 for (auto& rectInfo : _lastSelectionDrawingInfo.selectionRects) {
 auto rect = rectInfo.rect();
@@ -2341,9 +2337,19 @@
 continue;
 
 pointIsInSelectionRect |= rect.contains(WebCore::roundedIntPoint(point));
-selectionBoundingRect.unite(rect);
+if (outBoundingRect)
+outBoundingRect->unite(rect);
 }
+return pointIsInSelectionRect;
+}
 
+- (BOOL)_shouldToggleSelectionCommandsAfterTapAt:(CGPoint)point
+{
+if (_lastSelectionDrawingInfo.selectionRects.isEmpty())
+return NO;
+
+WebCore::FloatRect selectionBoundingRect;
+BOOL pointIsInSelectionRect = [self _pointIsInsideSelectionRect:point outBoundingRect:&selectionBoundingRect];
 WebCo

[webkit-changes] [262453] branches/safari-610.1.15-branch/Source/WebCore/PAL

Title: [262453] branches/safari-610.1.15-branch/Source/WebCore/PAL








Revision 262453
Author alanc...@apple.com
Date 2020-06-02 14:58:32 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262347. rdar://problem/63891529

REGRESSION (r262332): Windows build failure because  doesn't exist



Unreviewed Windows build fix.

* pal/spi/cf/CFNetworkSPI.h:
- Move  so it is not included with PLATFORM(WIN).
- Add or clean up some macro comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog
branches/safari-610.1.15-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h




Diff

Modified: branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog (262452 => 262453)

--- branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog	2020-06-02 21:58:30 UTC (rev 262452)
+++ branches/safari-610.1.15-branch/Source/WebCore/PAL/ChangeLog	2020-06-02 21:58:32 UTC (rev 262453)
@@ -1,5 +1,33 @@
 2020-06-02  Alan Coon  
 
+Cherry-pick r262347. rdar://problem/63891529
+
+REGRESSION (r262332): Windows build failure because  doesn't exist
+
+
+
+Unreviewed Windows build fix.
+
+* pal/spi/cf/CFNetworkSPI.h:
+- Move  so it is not included with PLATFORM(WIN).
+- Add or clean up some macro comments.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-05-30  David Kilzer  
+
+REGRESSION (r262332): Windows build failure because  doesn't exist
+
+
+
+Unreviewed Windows build fix.
+
+* pal/spi/cf/CFNetworkSPI.h:
+- Move  so it is not included with PLATFORM(WIN).
+- Add or clean up some macro comments.
+
+2020-06-02  Alan Coon  
+
 Cherry-pick r262332. rdar://problem/63891529
 
 [Cocoa] Improve logging quality for non-ephemeral sessions


Modified: branches/safari-610.1.15-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h (262452 => 262453)

--- branches/safari-610.1.15-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2020-06-02 21:58:30 UTC (rev 262452)
+++ branches/safari-610.1.15-branch/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h	2020-06-02 21:58:32 UTC (rev 262453)
@@ -42,7 +42,6 @@
 #include 
 #include 
 #include 
-#include 
 
 #if PLATFORM(WIN)
 
@@ -56,8 +55,9 @@
 
 WTF_EXTERN_C_END
 
-#else // PLATFORM(WIN)
+#else // !PLATFORM(WIN)
 #include 
+#include 
 #endif // PLATFORM(WIN)
 
 // FIXME: Remove the defined(__OBJC__)-guard once we fix .
@@ -78,9 +78,8 @@
 #ifndef NW_CONTEXT_HAS_PRIVACY_LEVEL_SILENT
 #define NW_CONTEXT_HAS_PRIVACY_LEVEL_SILENT1
 #endif
+#endif // HAVE(LOGGING_PRIVACY_LEVEL)
 
-#endif
-
 typedef CF_ENUM(int64_t, _TimingDataOptions)
 {
 _TimingDataOptionsEnableW3CNavigationTiming = (1 << 0)
@@ -297,7 +296,7 @@
 
 #endif // defined(__OBJC__)
 
-#endif // !PLATFORM(WIN) && !USE(APPLE_INTERNAL_SDK)
+#endif // PLATFORM(WIN) || USE(APPLE_INTERNAL_SDK)
 
 WTF_EXTERN_C_BEGIN
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262451] branches/safari-610.1.15-branch/Source/WebKit/NetworkProcess/ cocoa/NetworkSessionCocoa.mm

Title: [262451] branches/safari-610.1.15-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm








Revision 262451
Author alanc...@apple.com
Date 2020-06-02 14:58:27 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262327. rdar://problem/63891529

Use ALLOW_DEPRECATED_DECLARATIONS_BEGIN instead (thanks to mitz)

* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (262450 => 262451)

--- branches/safari-610.1.15-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2020-06-02 21:58:25 UTC (rev 262450)
+++ branches/safari-610.1.15-branch/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm	2020-06-02 21:58:27 UTC (rev 262451)
@@ -1030,7 +1030,9 @@
 configuration = [NSURLSessionConfiguration defaultSessionConfiguration];
 
 #if HAVE(ALLOWS_SENSITIVE_LOGGING)
+ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 configuration._allowsSensitiveLogging = NO;
+ALLOW_DEPRECATED_DECLARATIONS_END
 #endif
 return configuration;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262441] branches/safari-610.1.15-branch/Source/WebKit

Title: [262441] branches/safari-610.1.15-branch/Source/WebKit








Revision 262441
Author alanc...@apple.com
Date 2020-06-02 14:57:58 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262255. rdar://problem/63891604

Do not send a second sync request for positition information to the web process if we have not recieved information since the previous sync request.
https://bugs.webkit.org/show_bug.cgi?id=212289


Reviewed by Tim Horton.

If we have sent a sync requests to the web process for position information, and timed out, and have not
received a message with position information in the interim, do not send another sync request. The web
process is likely still hung, and there is no reason to hang the UIProcess again if we suspect that it
is unlikely that we will receive a reply.

* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView cleanUpInteraction]):
(-[WKContentView ensurePositionInformationIsUpToDate:]):
(-[WKContentView _positionInformationDidChange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebKit/ChangeLog
branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h
branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: branches/safari-610.1.15-branch/Source/WebKit/ChangeLog (262440 => 262441)

--- branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:57:55 UTC (rev 262440)
+++ branches/safari-610.1.15-branch/Source/WebKit/ChangeLog	2020-06-02 21:57:58 UTC (rev 262441)
@@ -1,3 +1,46 @@
+2020-06-02  Alan Coon  
+
+Cherry-pick r262255. rdar://problem/63891604
+
+Do not send a second sync request for positition information to the web process if we have not recieved information since the previous sync request.
+https://bugs.webkit.org/show_bug.cgi?id=212289
+
+
+Reviewed by Tim Horton.
+
+If we have sent a sync requests to the web process for position information, and timed out, and have not
+received a message with position information in the interim, do not send another sync request. The web
+process is likely still hung, and there is no reason to hang the UIProcess again if we suspect that it
+is unlikely that we will receive a reply.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView cleanUpInteraction]):
+(-[WKContentView ensurePositionInformationIsUpToDate:]):
+(-[WKContentView _positionInformationDidChange:]):
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-05-28  Megan Gardner  
+
+Do not send a second sync request for positition information to the web process if we have not recieved information since the previous sync request.
+https://bugs.webkit.org/show_bug.cgi?id=212289
+
+
+Reviewed by Tim Horton.
+
+If we have sent a sync requests to the web process for position information, and timed out, and have not
+received a message with position information in the interim, do not send another sync request. The web
+process is likely still hung, and there is no reason to hang the UIProcess again if we suspect that it
+is unlikely that we will receive a reply.
+
+* UIProcess/ios/WKContentViewInteraction.h:
+* UIProcess/ios/WKContentViewInteraction.mm:
+(-[WKContentView cleanUpInteraction]):
+(-[WKContentView ensurePositionInformationIsUpToDate:]):
+(-[WKContentView _positionInformationDidChange:]):
+
 2020-05-23  Charlie Turner  
 
 Error sending IPC message: Broken pipe


Modified: branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (262440 => 262441)

--- branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h	2020-06-02 21:57:55 UTC (rev 262440)
+++ branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h	2020-06-02 21:57:58 UTC (rev 262441)
@@ -359,6 +359,7 @@
 BOOL _showDebugTapHighlightsForFastClicking;
 BOOL _textInteractionDidChangeFocusedElement;
 BOOL _textInteractionIsHappening;
+bool _isWaitingOnPositionInformation;
 
 WebCore::PointerID m_commitPotentialTapPointerId;
 


Modified: branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (262440 => 262441)

--- branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-06-02 21:57:55 UTC (rev 262440)
+++ branches/safari-610.1.15-branch/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2020-06-02 21:57:58 UTC (rev 262441)
@@ -920,6 +920,7 @@
 _formInpu

[webkit-changes] [262440] branches/safari-610.1.15-branch/Source/WebCore

Title: [262440] branches/safari-610.1.15-branch/Source/WebCore








Revision 262440
Author alanc...@apple.com
Date 2020-06-02 14:57:55 -0700 (Tue, 02 Jun 2020)


Log Message
Cherry-pick r262208. rdar://problem/63891613

REGRESSION (r254541): Valid mime types can only be added to the HashSet of the supported types for encoding
https://bugs.webkit.org/show_bug.cgi?id=212427

Patch by Said Abou-Hallawa  on 2020-05-27
Reviewed by Darin Adler.

Add back a check for the mime type validity which was removed in r254541.

* platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::createMIMETypeRegistryThreadGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-610.1.15-branch/Source/WebCore/ChangeLog
branches/safari-610.1.15-branch/Source/WebCore/platform/MIMETypeRegistry.cpp




Diff

Modified: branches/safari-610.1.15-branch/Source/WebCore/ChangeLog (262439 => 262440)

--- branches/safari-610.1.15-branch/Source/WebCore/ChangeLog	2020-06-02 21:19:51 UTC (rev 262439)
+++ branches/safari-610.1.15-branch/Source/WebCore/ChangeLog	2020-06-02 21:57:55 UTC (rev 262440)
@@ -1,3 +1,32 @@
+2020-06-02  Alan Coon  
+
+Cherry-pick r262208. rdar://problem/63891613
+
+REGRESSION (r254541): Valid mime types can only be added to the HashSet of the supported types for encoding
+https://bugs.webkit.org/show_bug.cgi?id=212427
+
+Patch by Said Abou-Hallawa  on 2020-05-27
+Reviewed by Darin Adler.
+
+Add back a check for the mime type validity which was removed in r254541.
+
+* platform/MIMETypeRegistry.cpp:
+(WebCore::MIMETypeRegistry::createMIMETypeRegistryThreadGlobalData):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@262208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2020-05-27  Said Abou-Hallawa  
+
+REGRESSION (r254541): Valid mime types can only be added to the HashSet of the supported types for encoding
+https://bugs.webkit.org/show_bug.cgi?id=212427
+
+Reviewed by Darin Adler.
+
+Add back a check for the mime type validity which was removed in r254541.
+
+* platform/MIMETypeRegistry.cpp:
+(WebCore::MIMETypeRegistry::createMIMETypeRegistryThreadGlobalData):
+
 2020-05-23  Zalan Bujtas  
 
 [LFC][TFC] Non-collapsing row border should not make the table wider/taller


Modified: branches/safari-610.1.15-branch/Source/WebCore/platform/MIMETypeRegistry.cpp (262439 => 262440)

--- branches/safari-610.1.15-branch/Source/WebCore/platform/MIMETypeRegistry.cpp	2020-06-02 21:19:51 UTC (rev 262439)
+++ branches/safari-610.1.15-branch/Source/WebCore/platform/MIMETypeRegistry.cpp	2020-06-02 21:57:55 UTC (rev 262440)
@@ -456,10 +456,12 @@
 CFIndex count = CFArrayGetCount(supportedTypes.get());
 for (CFIndex i = 0; i < count; i++) {
 CFStringRef supportedType = reinterpret_cast(CFArrayGetValueAtIndex(supportedTypes.get(), i));
-if (isSupportedImageType(supportedType)) {
-String mimeType = MIMETypeForImageType(supportedType);
-supportedImageMIMETypesForEncoding.add(mimeType);
-}
+if (!isSupportedImageType(supportedType))
+continue;
+String mimeType = MIMETypeForImageType(supportedType);
+if (mimeType.isEmpty())
+continue;
+supportedImageMIMETypesForEncoding.add(mimeType);
 }
 #else
 HashSet supportedImageMIMETypesForEncoding = std::initializer_list {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262439] branches/safari-609-branch

2020-06-02 Thread repstein

Title: [262439] branches/safari-609-branch








Revision 262439
Author repst...@apple.com
Date 2020-06-02 14:19:51 -0700 (Tue, 02 Jun 2020)


Log Message
Apply patch. rdar://problem/63626670

2020-05-22  Andy Estes  

[Apple Pay] Add new ApplePayInstallmentConfiguration members
https://bugs.webkit.org/show_bug.cgi?id=212160


Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/ssl/applepay/ApplePayInstallmentItems.https.html

* DerivedSources-input.xcfilelist:
* DerivedSources-output.xcfilelist:
* DerivedSources.make:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj: Added IDLs, headers, and derived sources for
ApplePayInstallment{Item,ItemType,RetailChannel}.

* Modules/applepay/ApplePayInstallmentConfiguration.idl:
* Modules/applepay/ApplePayInstallmentConfigurationWebCore.h: Added items,
applicationMetadata, and retailChannel members. Added missing conditionals to
merchantIdentifier and referrerIdentifier.

* Modules/applepay/ApplePayInstallmentItem.h:
* Modules/applepay/ApplePayInstallmentItem.idl:
* Modules/applepay/ApplePayInstallmentItemType.h:
* Modules/applepay/ApplePayInstallmentItemType.idl:
* Modules/applepay/ApplePayInstallmentRetailChannel.h:
* Modules/applepay/ApplePayInstallmentRetailChannel.idl: Added.

* Modules/applepay/ApplePayRequestBase.cpp:
(WebCore::convertAndValidate): Changed to call PaymentInstallmentConfiguration::create,
returning an exception if present.

* Modules/applepay/PaymentInstallmentConfiguration.mm:
(WebCore::fromDecimalNumber): Allowed for a large maximum number of fractional digits to
support formatting high-precision currency and APRs (note that this formatter is only used
for test support).

(WebCore::applePayItemType):
(WebCore::platformItemType): Added to convert between PKInstallmentItemType and
ApplePayInstallmentItemType.

(WebCore::applePayRetailChannel):
(WebCore::platformRetailChannel): Added to convert between PKInstallmentRetailChannel and
ApplePayInstallmentRetailChannel.

(WebCore::makeNSArrayElement):
(WebCore::makeVectorElement): Added to convert between NSArray
and Vector.

(WebCore::createPlatformConfiguration): Added a parameter for passing in applicationMetadata
as an NSDictionary. Set properties on PKPaymentInstallmentConfiguration for new
ApplePayInstallmentConfiguration members.
(WebCore::PaymentInstallmentConfiguration::create): Added; converts the applicationMetadata
JSON string (if present) to an NSDictionary, returning a TypeError if the JSON string does
not deserialize to an NSDictionary (as PassKit requires).
(WebCore::PaymentInstallmentConfiguration::PaymentInstallmentConfiguration): Added a
parameter for passing in applicationMetadata as an NSDictionary. Made private.
(WebCore::PaymentInstallmentConfiguration::applePayInstallmentConfiguration const): Set
members on ApplePayInstallmentConfiguration for new PKPaymentInstallmentConfiguration
properties.

* Modules/applepay/PaymentInstallmentConfigurationWebCore.h:

LayoutTests:

* http/tests/ssl/applepay/ApplePayInstallmentItems.https-expected.txt:
* http/tests/ssl/applepay/ApplePayInstallmentItems.https.html: Added.
* platform/mac-wk2/TestExpectations: Skipped test on Mojave and Catalina.

Modified Paths

branches/safari-609-branch/LayoutTests/ChangeLog
branches/safari-609-branch/LayoutTests/platform/mac-wk2/TestExpectations
branches/safari-609-branch/Source/WebCore/ChangeLog
branches/safari-609-branch/Source/WebCore/Modules/applepay/ApplePayRequestBase.cpp
branches/safari-609-branch/Source/WebCore/Modules/applepay/PaymentCoordinatorClient.cpp
branches/safari-609-branch/Source/WebCore/testing/MockPaymentCoordinator.cpp
branches/safari-609-branch/Source/WebCore/testing/MockPaymentCoordinator.h
branches/safari-609-branch/Source/WebCore/testing/MockPaymentCoordinator.idl


Added Paths

branches/safari-609-branch/LayoutTests/http/tests/ssl/applepay/ApplePayInstallmentItems.https-expected.txt
branches/safari-609-branch/LayoutTests/http/tests/ssl/applepay/ApplePayInstallmentItems.https.html




Diff

Modified: branches/safari-609-branch/LayoutTests/ChangeLog (262438 => 262439)

--- branches/safari-609-branch/LayoutTests/ChangeLog	2020-06-02 20:44:06 UTC (rev 262438)
+++ branches/safari-609-branch/LayoutTests/ChangeLog	2020-06-02 21:19:51 UTC (rev 262439)
@@ -1,3 +1,19 @@
+2020-06-02  Andy Estes  
+
+Apply patch. rdar://problem/63626670
+
+2020-05-22  Andy Estes  
+
+[Apple Pay] Add new ApplePayInstallmentConfiguration members
+https://bugs.webkit.org/show_bug.cgi?id=212160
+
+
+Reviewed by Alex Christensen.
+
+* http/tests/ssl/applepay/ApplePayInstallmentItems.https-expected.txt:
+* http/tests/ssl/applepay/ApplePayInstallmentItems.https.html: Added.
+* platform/mac-wk

[webkit-changes] [262438] trunk/LayoutTests

Title: [262438] trunk/LayoutTests








Revision 262438
Author simon.fra...@apple.com
Date 2020-06-02 13:44:06 -0700 (Tue, 02 Jun 2020)


Log Message
[ macOS ] scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=210351


Reviewed by Tim Horton.

Try to deflake this test. It timed out when all the wheel events were received in the UI process
before the ViewGestureController had received a response from the web process about whether the
first event had been handled. Fix by adding a rAF() wait in the middle of sending the events.

Also register the swipe callback before starting the event sending.

* scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html




Diff

Modified: trunk/LayoutTests/ChangeLog (262437 => 262438)

--- trunk/LayoutTests/ChangeLog	2020-06-02 20:17:13 UTC (rev 262437)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 20:44:06 UTC (rev 262438)
@@ -1,3 +1,19 @@
+2020-06-02  Simon Fraser  
+
+[ macOS ] scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html is flaky timing out
+https://bugs.webkit.org/show_bug.cgi?id=210351
+
+
+Reviewed by Tim Horton.
+
+Try to deflake this test. It timed out when all the wheel events were received in the UI process
+before the ViewGestureController had received a response from the web process about whether the
+first event had been handled. Fix by adding a rAF() wait in the middle of sending the events.
+
+Also register the swipe callback before starting the event sending.
+
+* scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html:
+
 2020-06-02  Jacob Uphoff  
 
 Landing expectations for tests that were recently imported but did not have them


Modified: trunk/LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html (262437 => 262438)

--- trunk/LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html	2020-06-02 20:17:13 UTC (rev 262437)
+++ trunk/LayoutTests/scrollingcoordinator/mac/latching/horizontal-overflow-back-swipe.html	2020-06-02 20:44:06 UTC (rev 262438)
@@ -49,6 +49,7 @@
 eventSender.mouseScrollByWithWheelAndMomentumPhases(1, 0, "began", "none");
 eventSender.mouseScrollByWithWheelAndMomentumPhases(10, 0, "changed", "none");
 eventSender.mouseScrollByWithWheelAndMomentumPhases(10, 0, "changed", "none");
+await UIHelper.animationFrame();
 eventSender.mouseScrollByWithWheelAndMomentumPhases(10, 0, "changed", "none");
 eventSender.mouseScrollByWithWheelAndMomentumPhases(0, 0, "ended", "none");
 return UIHelper.waitForScrollCompletion();
@@ -86,7 +87,7 @@
 
 debug('Swipe to the left');
 
-await Promise.all([onScrollCompletion(mouseLocationX, mouseLocationY), onSwipeCallback()]);
+await Promise.all([onSwipeCallback(), onScrollCompletion(mouseLocationX, mouseLocationY)]);
 
 // Should not have received any scroll events.
 shouldBe('minXOffset', '0');






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262437] trunk/Source

Title: [262437] trunk/Source








Revision 262437
Author simon.fra...@apple.com
Date 2020-06-02 13:17:13 -0700 (Tue, 02 Jun 2020)


Log Message
Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
https://bugs.webkit.org/show_bug.cgi?id=212620

Reviewed by Tim Horton.

Surround code related to wheel event regions with ENABLE(WHEEL_EVENT_REGIONS).

Eventually we'll use this same code for touch event regions, and when we do, we
can rejigger the #ifdefs.

Source/WebCore:

* rendering/EventRegion.cpp:
(WebCore::EventRegion::operator== const):
(WebCore::EventRegion::unite):
(WebCore::EventRegion::containsEditableElementsInRect const):
(WebCore::EventRegion::dump const):
* rendering/EventRegion.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintDebugOverlays):

Source/WTF:

* wtf/PlatformEnable.h:
* wtf/PlatformEnableCocoa.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/PlatformEnable.h
trunk/Source/WTF/wtf/PlatformEnableCocoa.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/EventRegion.cpp
trunk/Source/WebCore/rendering/EventRegion.h
trunk/Source/WebCore/rendering/RenderLayerBacking.cpp




Diff

Modified: trunk/Source/WTF/ChangeLog (262436 => 262437)

--- trunk/Source/WTF/ChangeLog	2020-06-02 20:05:44 UTC (rev 262436)
+++ trunk/Source/WTF/ChangeLog	2020-06-02 20:17:13 UTC (rev 262437)
@@ -1,3 +1,18 @@
+2020-06-01  Simon Fraser  
+
+Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
+https://bugs.webkit.org/show_bug.cgi?id=212620
+
+Reviewed by Tim Horton.
+
+Surround code related to wheel event regions with ENABLE(WHEEL_EVENT_REGIONS).
+
+Eventually we'll use this same code for touch event regions, and when we do, we
+can rejigger the #ifdefs.
+
+* wtf/PlatformEnable.h:
+* wtf/PlatformEnableCocoa.h:
+
 2020-06-02  Mark Lam  
 
 Change Gigacage::Config to use storage in WebConfig::g_config instead of its own.


Modified: trunk/Source/WTF/wtf/PlatformEnable.h (262436 => 262437)

--- trunk/Source/WTF/wtf/PlatformEnable.h	2020-06-02 20:05:44 UTC (rev 262436)
+++ trunk/Source/WTF/wtf/PlatformEnable.h	2020-06-02 20:17:13 UTC (rev 262437)
@@ -490,6 +490,10 @@
 #define ENABLE_TOUCH_ACTION_REGIONS 0
 #endif
 
+#if !defined(ENABLE_WHEEL_EVENT_REGIONS)
+#define ENABLE_WHEEL_EVENT_REGIONS 0
+#endif
+
 #if !defined(ENABLE_VIDEO)
 #define ENABLE_VIDEO 0
 #endif


Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (262436 => 262437)

--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2020-06-02 20:05:44 UTC (rev 262436)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h	2020-06-02 20:17:13 UTC (rev 262437)
@@ -433,6 +433,10 @@
 #define ENABLE_TOUCH_ACTION_REGIONS 1
 #endif
 
+#if !defined(ENABLE_WHEEL_EVENT_REGIONS) && PLATFORM(MAC)
+#define ENABLE_WHEEL_EVENT_REGIONS 1
+#endif
+
 #if !defined(ENABLE_UI_SIDE_COMPOSITING)
 #define ENABLE_UI_SIDE_COMPOSITING 1
 #endif


Modified: trunk/Source/WebCore/ChangeLog (262436 => 262437)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 20:05:44 UTC (rev 262436)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 20:17:13 UTC (rev 262437)
@@ -1,3 +1,24 @@
+2020-06-01  Simon Fraser  
+
+Add ENABLE(WHEEL_EVENT_REGIONS), enabled on macOS which is the only platform that needs wheel event regions for scrolling thread hit-testing
+https://bugs.webkit.org/show_bug.cgi?id=212620
+
+Reviewed by Tim Horton.
+
+Surround code related to wheel event regions with ENABLE(WHEEL_EVENT_REGIONS).
+
+Eventually we'll use this same code for touch event regions, and when we do, we
+can rejigger the #ifdefs.
+
+* rendering/EventRegion.cpp:
+(WebCore::EventRegion::operator== const):
+(WebCore::EventRegion::unite):
+(WebCore::EventRegion::containsEditableElementsInRect const):
+(WebCore::EventRegion::dump const):
+* rendering/EventRegion.h:
+* rendering/RenderLayerBacking.cpp:
+(WebCore::RenderLayerBacking::paintDebugOverlays):
+
 2020-06-02  Andres Gonzalez  
 
 Avoid calling axBackingObject multiple times in [WebAccessibilityObjectWrapper roleDescription].


Modified: trunk/Source/WebCore/rendering/EventRegion.cpp (262436 => 262437)

--- trunk/Source/WebCore/rendering/EventRegion.cpp	2020-06-02 20:05:44 UTC (rev 262436)
+++ trunk/Source/WebCore/rendering/EventRegion.cpp	2020-06-02 20:17:13 UTC (rev 262437)
@@ -102,10 +102,14 @@
 if (m_touchActionRegions != other.m_touchActionRegions)
 return false;
 #endif
+
+#if ENABLE(WHEEL_EVENT_REGIONS)
 if (m_wheelEventListenerRegion != other.m_wheelEventListenerRegion)
 return false;
 if (m_nonPassiveWheelEventListenerRegion != other.m_nonPassiveWheelEventListenerRegion)
 return false;
+#endif
+
 #if ENABLE(EDITABLE_REGION)

[webkit-changes] [262436] branches/safari-610.1.15-branch/Source

Title: [262436] branches/safari-610.1.15-branch/Source








Revision 262436
Author alanc...@apple.com
Date 2020-06-02 13:05:44 -0700 (Tue, 02 Jun 2020)


Log Message
Versioning.

Modified Paths

branches/safari-610.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-610.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-610.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-610.1.15-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-610.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-610.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-610.1.15-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-610.1.15-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-610.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig (262435 => 262436)

--- branches/safari-610.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-06-02 20:04:00 UTC (rev 262435)
+++ branches/safari-610.1.15-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2020-06-02 20:05:44 UTC (rev 262436)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (262435 => 262436)

--- branches/safari-610.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-06-02 20:04:00 UTC (rev 262435)
+++ branches/safari-610.1.15-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2020-06-02 20:05:44 UTC (rev 262436)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (262435 => 262436)

--- branches/safari-610.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-06-02 20:04:00 UTC (rev 262435)
+++ branches/safari-610.1.15-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2020-06-02 20:05:44 UTC (rev 262436)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.15-branch/Source/WebCore/Configurations/Version.xcconfig (262435 => 262436)

--- branches/safari-610.1.15-branch/Source/WebCore/Configurations/Version.xcconfig	2020-06-02 20:04:00 UTC (rev 262435)
+++ branches/safari-610.1.15-branch/Source/WebCore/Configurations/Version.xcconfig	2020-06-02 20:05:44 UTC (rev 262436)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (262435 => 262436)

--- branches/safari-610.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-06-02 20:04:00 UTC (rev 262435)
+++ branches/safari-610.1.15-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2020-06-02 20:05:44 UTC (rev 262436)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (262435 => 262436)

--- branches/safari-610.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-06-02 20:04:00 UTC (rev 262435)
+++ branches/safari-610.1.15-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2020-06-02 20:05:44 UTC (rev 262436)
@@ -1,7 +1,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 


Modified: branches/safari-610.1.15-branch/Source/WebKit/Configurations/Version.xcconfig (262435 => 262436)

--- branches/safari-610.1.15-branch/Source/WebKit/Configurations/Version.xcconfig	2020-06-02 20:04:00 UTC (rev 262435)
+++ branches/safari-610.1.15-branch/Source/WebKit/Configurations/Version.xcconfig	2020-06-02 20:05:44 UTC (rev 262436)
@@ -24,7 +24,7 @@
 MAJOR_VERSION = 610;
 MINOR_VERSION = 1;
 TINY_VERSION = 15;
-MICRO_VERSION = 1;
+MICRO_VERSION = 2;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VER

[webkit-changes] [262435] trunk/Source

2020-06-02 Thread pvollan

Title: [262435] trunk/Source








Revision 262435
Author pvol...@apple.com
Date 2020-06-02 13:04:00 -0700 (Tue, 02 Jun 2020)


Log Message
REGRESSION(r261387): Introduced sandbox violations
https://bugs.webkit.org/show_bug.cgi?id=212634

Reviewed by Darin Adler.

Source/WebCore/PAL:

Declare Launch Services class.

* pal/spi/cocoa/LaunchServicesSPI.h:

Source/WebKit:

The change set r261387 introduced some new mach lookup sandbox violations, when attempting to close Launch Services connections that were not open.
Fix this by only attempting to close open connections, and do it while holding the extension to the database mapping service.

No new tests, since this patch is fixing benign sandbox violations.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Modified Paths

trunk/Source/WebCore/PAL/ChangeLog
trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebCore/PAL/ChangeLog (262434 => 262435)

--- trunk/Source/WebCore/PAL/ChangeLog	2020-06-02 19:43:17 UTC (rev 262434)
+++ trunk/Source/WebCore/PAL/ChangeLog	2020-06-02 20:04:00 UTC (rev 262435)
@@ -1,3 +1,14 @@
+2020-06-02  Per Arne Vollan  
+
+REGRESSION(r261387): Introduced sandbox violations
+https://bugs.webkit.org/show_bug.cgi?id=212634
+
+Reviewed by Darin Adler.
+
+Declare Launch Services class.
+
+* pal/spi/cocoa/LaunchServicesSPI.h:
+
 2020-05-31  Jer Noble  
 
 [Cocoa] Transition between encrypted and clear codecs throws error from SourceBuffer.appendBuffer()


Modified: trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h (262434 => 262435)

--- trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h	2020-06-02 19:43:17 UTC (rev 262434)
+++ trunk/Source/WebCore/PAL/pal/spi/cocoa/LaunchServicesSPI.h	2020-06-02 20:04:00 UTC (rev 262435)
@@ -86,10 +86,12 @@
 #endif // !USE(APPLE_INTERNAL_SDK)
 
 @interface _LSDService : NSObject 
-+ (NSArray *)allServiceClasses;
 + (NSXPCConnection *)XPCConnectionToService;
 @end
 
+@interface _LSDReadService : _LSDService
+@end
+
 #if PLATFORM(MAC)
 
 typedef const struct CF_BRIDGED_TYPE(id) __LSASN* LSASNRef;


Modified: trunk/Source/WebKit/ChangeLog (262434 => 262435)

--- trunk/Source/WebKit/ChangeLog	2020-06-02 19:43:17 UTC (rev 262434)
+++ trunk/Source/WebKit/ChangeLog	2020-06-02 20:04:00 UTC (rev 262435)
@@ -1,3 +1,18 @@
+2020-06-02  Per Arne Vollan  
+
+REGRESSION(r261387): Introduced sandbox violations
+https://bugs.webkit.org/show_bug.cgi?id=212634
+
+Reviewed by Darin Adler.
+
+The change set r261387 introduced some new mach lookup sandbox violations, when attempting to close Launch Services connections that were not open.
+Fix this by only attempting to close open connections, and do it while holding the extension to the database mapping service.
+
+No new tests, since this patch is fixing benign sandbox violations.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::WebProcess::platformInitializeWebProcess):
+
 2020-06-02  Youenn Fablet  
 
 Allow using web processes for service workers even though they loaded about URLs


Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (262434 => 262435)

--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-06-02 19:43:17 UTC (rev 262434)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-06-02 20:04:00 UTC (rev 262435)
@@ -176,19 +176,15 @@
 ASSERT_UNUSED(ok, ok);
 // Perform API calls which will communicate with the database mapping service, and map the database.
 auto uti = adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, CFSTR("text/html"), 0));
+
+[[objc_getClass("_LSDReadService") XPCConnectionToService] invalidate];
+
 ok = extension->revoke();
 ASSERT_UNUSED(ok, ok);
 
-auto services = [get_LSDServiceClass() allServiceClasses];
-for (Class cls in services) {
-auto connection = [cls XPCConnectionToService];
-[connection invalidate];
-}
-
-ASSERT(String(uti.get()) = String(adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, CFSTR("text/html"), 0)).get()));
+ASSERT(String(uti.get()) == String(adoptCF(UTTypeCreatePreferredIdentifierForTag(kUTTagClassMIMEType, CFSTR("text/html"), 0)).get()));
 }
 
-
 #if PLATFORM(IOS_FAMILY)
 if (parameters.runningboardExtensionHandle) {
 auto extension = SandboxExtension::create(WTFMove(*parameters.runningboardExtensionHandle));






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262434] trunk/Source

Title: [262434] trunk/Source








Revision 262434
Author mark@apple.com
Date 2020-06-02 12:43:17 -0700 (Tue, 02 Jun 2020)


Log Message
Change Gigacage::Config to use storage in WebConfig::g_config instead of its own.
https://bugs.webkit.org/show_bug.cgi?id=212585


Reviewed by Yusuke Suzuki.

Source/bmalloc:

1. Gigacage::Config now reserves and expect space to be available in an external
   WebConfig::g_config buffer.  Gigacage does not allocate that buffer.

2. Moved Gigacage::Config to GigacageConfig.h.
   This allows WTFConfig.h to include GigacageConfig.h instead of all of Gigacage.h.

3. Moved Gigacage::Kind to GigacageKind.h.
   Otherwise, Gigacage::Kind would need to move to GigacageConfig.h which is a
   weird place to put it.

4. Removed freezeGigacageConfig(), unfreezeGigacageConfig(), and
   permanentlyFreezeGigacageConfig().

   It is no longer possible to temporarily freeze and unfreeze the Gigacage::Config
   because it now share the same memory page with higher level Configs.

   permanentlyFreezeGigacageConfig() is no longer needed because it is subsumed
   by WTF::Config::permanentlyFreeze(), which will freeze the entire WebConfig::g_config
   buffer.

   One difference in behavior here is that Gigacage::Config data used to be permanently
   frozen as soon as forbidDisablingPrimitiveGigacage() is called.  Now, it isn't
   permanently frozen until the end of the construction of the first JSC::VM instance
   in the process (just like the other Config records).  This still guarantees that
   it is frozen before any JS script can run.

5. Previously, disablePrimitiveGigacage() works by nullifying the Primitive gigacage
   base pointer.  We can no longer do that because the base pointer will be frozen
   on VM instantiation.  Instead, if not forbidden, we now disable the Primitive
   gigacage by setting a disablePrimitiveGigacageRequested bool variable that is
   not frozen in the Gigacage::Config.

   To check if the Primitive gigacage is enabled, the LLInt, AssemblyHelpers::cageConditionally(),
   and runtime functions will check the following conditions:

   g_gigacageConfig.basePtr(Primitive) &&
   (disablingPrimitiveGigacageIsForbidden() || disableNotRequestedForPrimitiveGigacage())

   The base pointer being null means the gigacage was never set up.

   If disablingPrimitiveGigacageIsForbidden() is true, then we don't care
   whether a disable request has been received.

   Otherwise, the gigacage is only enabled if it has been set up, and a
   disable request has not been received.

   Note that the first 2 terms are frozen in the Gigacage::Config.  Only the
   last term is a runtime variable.  If disabling is forbidden, then the
   runtime variable never comes into play.

   The FTL does not rely on a runtime check for whether the Primitive gigacage is
   enabled or not.  Instead, it relies on a watchpoint to handle this.  So, it
   just works, and there's no performance penalty with adding the 2 extra terms
   to check.

   Note also that the jsc shell and the WebProcess will forbid disabling of the
   Primitive gigacage.  This means the AssemblyHelpers::cageConditionally() will
   also not generate the runtime checks for the 2 extra terms.

   Only the LLInt and runtime functions will have to do work to check the 2 extra
   terms.  But because these are not in perf critical paths, this is ok.

   Note that we're deliberately gating the disablePrimitiveGigacageRequested
   variable check on disablingPrimitiveGigacageIsForbidden though, logically, the
   isEnable check does not really depend on whether disabling is forbidden or not.
   We do this because disablingPrimitiveGigacageIsForbidden is frozen in the Config,
   and it is, therefore, a stronger guarantee of correctness whereas the variable
   can be corrupted.

6. Replaced isDisablingPrimitiveGigacageForbidden(), canPrimitiveGigacageBeDisabled(),
   and isPrimitiveGigacagePermanentlyEnabled() with disablingPrimitiveGigacageIsForbidden().

* CMakeLists.txt:
* bmalloc.xcodeproj/project.pbxproj:
* bmalloc/Gigacage.cpp:
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::forbidDisablingPrimitiveGigacage):
(Gigacage::bmalloc::freezeGigacageConfig): Deleted.
(Gigacage::bmalloc::unfreezeGigacageConfig): Deleted.
(Gigacage::bmalloc::permanentlyFreezeGigacageConfig): Deleted.
(Gigacage::bmalloc::UnfreezeGigacageConfigScope::UnfreezeGigacageConfigScope): Deleted.
(Gigacage::bmalloc::UnfreezeGigacageConfigScope::~UnfreezeGigacageConfigScope): Deleted.
(Gigacage::isDisablingPrimitiveGigacageForbidden): Deleted.
* bmalloc/Gigacage.h:
(Gigacage::disablingPrimitiveGigacageIsForbidden):
(Gigacage::disableNotRequestedForPrimitiveGigacage):
(Gigacage::isEnabled):
(Gigacage::basePtr):
(Gigacage::caged):
(Gigacage::forbidDisablingPrimitiveGigacage):
(): Deleted.
(Gigacage::Config::basePtr const): Deleted.
(Gigacage::Config::setBasePtr): Deleted.
(Gigacage::isPrimitiveGigac

[webkit-changes] [262433] trunk/Source/WebCore

2020-06-02 Thread andresg_22

Title: [262433] trunk/Source/WebCore








Revision 262433
Author andresg...@apple.com
Date 2020-06-02 11:43:04 -0700 (Tue, 02 Jun 2020)


Log Message
Avoid calling axBackingObject multiple times in [WebAccessibilityObjectWrapper roleDescription].
https://bugs.webkit.org/show_bug.cgi?id=212643

Reviewed by Chris Fleizach.

No new functionality.

Avoid unnecessary overhead of calling axBackingObject multiple times in
roleDescription. axBackingObject is not just a getter but involves
checking whether isolated tree mode is enabled.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (262432 => 262433)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 18:38:26 UTC (rev 262432)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 18:43:04 UTC (rev 262433)
@@ -1,3 +1,20 @@
+2020-06-02  Andres Gonzalez  
+
+Avoid calling axBackingObject multiple times in [WebAccessibilityObjectWrapper roleDescription].
+https://bugs.webkit.org/show_bug.cgi?id=212643
+
+Reviewed by Chris Fleizach.
+
+No new functionality.
+
+Avoid unnecessary overhead of calling axBackingObject multiple times in
+roleDescription. axBackingObject is not just a getter but involves
+checking whether isolated tree mode is enabled.
+
+* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+(-[WebAccessibilityObjectWrapper subrole]):
+(-[WebAccessibilityObjectWrapper roleDescription]):
+
 2020-06-02  Tetsuharu Ohzeki  
 
 Pass nullptr for the 2nd argument of FileReaderLoader 


Modified: trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm (262432 => 262433)

--- trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2020-06-02 18:38:26 UTC (rev 262432)
+++ trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm	2020-06-02 18:43:04 UTC (rev 262433)
@@ -2000,6 +2000,7 @@
 if (!backingObject)
 return nil;
 
+// FIXME: create AXCoreObject::subrolePlatformString to replace the following linear search and heuristics, similar to rolePlatformString.
 if (backingObject->isPasswordField())
 return NSAccessibilitySecureTextFieldSubrole;
 if (backingObject->isSearchField())
@@ -2210,33 +2211,35 @@
 
 - (NSString*)roleDescription
 {
-if (!self.axBackingObject)
+auto* backingObject = self.axBackingObject;
+if (!backingObject)
 return nil;
 
 ALLOW_DEPRECATED_DECLARATIONS_BEGIN
 // attachments have the AXImage role, but a different subrole
-if (self.axBackingObject->isAttachment())
+if (backingObject->isAttachment())
 return [[self attachmentView] accessibilityAttributeValue:NSAccessibilityRoleDescriptionAttribute];
 ALLOW_DEPRECATED_DECLARATIONS_END
 
-String roleDescription = self.axBackingObject->roleDescription();
+String roleDescription = backingObject->roleDescription();
 if (!roleDescription.isEmpty())
 return roleDescription;
 
-NSString *axRole = self.axBackingObject->rolePlatformString();
+NSString *axRole = backingObject->rolePlatformString();
+NSString *subrole = self.subrole;
 // Fallback to the system default role description.
 // If we get the same string back, then as a last resort, return unknown.
-NSString *defaultRoleDescription = NSAccessibilityRoleDescription(axRole, [self subrole]);
+NSString *defaultRoleDescription = NSAccessibilityRoleDescription(axRole, subrole);
 
 // On earlier Mac versions (Lion), using a non-standard subrole would result in a role description
 // being returned that looked like AXRole:AXSubrole. To make all platforms have the same role descriptions
 // we should fallback on a role description ignoring the subrole in these cases.
-if ([defaultRoleDescription isEqualToString:[NSString stringWithFormat:@"%@:%@", axRole, [self subrole]]])
+if ([defaultRoleDescription isEqualToString:[NSString stringWithFormat:@"%@:%@", axRole, subrole]])
 defaultRoleDescription = NSAccessibilityRoleDescription(axRole, nil);
-
+
 if (![defaultRoleDescription isEqualToString:axRole])
 return defaultRoleDescription;
-
+
 return NSAccessibilityRoleDescription(NSAccessibilityUnknownRole, nil);
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262432] trunk

Title: [262432] trunk








Revision 262432
Author you...@apple.com
Date 2020-06-02 11:38:26 -0700 (Tue, 02 Jun 2020)


Log Message
Allow using web processes for service workers even though they loaded about URLs
https://bugs.webkit.org/show_bug.cgi?id=212464

Reviewed by Chris Dumez.

Source/WebKit:

Before the patch, a web process that loads about:blank will not be able to run service workers.
A web process that is running service workers and is loading an about:blank page will also kill its service workers.
To prevent this, do not take into account about:blank URLs for the computation of the registrable domain of a process.

Covered by API tests.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (262431 => 262432)

--- trunk/Source/WebKit/ChangeLog	2020-06-02 18:19:18 UTC (rev 262431)
+++ trunk/Source/WebKit/ChangeLog	2020-06-02 18:38:26 UTC (rev 262432)
@@ -1,3 +1,19 @@
+2020-06-02  Youenn Fablet  
+
+Allow using web processes for service workers even though they loaded about URLs
+https://bugs.webkit.org/show_bug.cgi?id=212464
+
+Reviewed by Chris Dumez.
+
+Before the patch, a web process that loads about:blank will not be able to run service workers.
+A web process that is running service workers and is loading an about:blank page will also kill its service workers.
+To prevent this, do not take into account about:blank URLs for the computation of the registrable domain of a process.
+
+Covered by API tests.
+
+* UIProcess/WebProcessProxy.cpp:
+(WebKit::WebProcessProxy::didStartProvisionalLoadForMainFrame):
+
 2020-06-02  Tim Horton  
 
 macCatalyst: WKWebView's tint color is not propagated to Web Content process


Modified: trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp (262431 => 262432)

--- trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2020-06-02 18:19:18 UTC (rev 262431)
+++ trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp	2020-06-02 18:38:26 UTC (rev 262432)
@@ -1557,6 +1557,9 @@
 if (m_registrableDomain && m_registrableDomain->isEmpty())
 return;
 
+if (url.protocolIsAbout())
+return;
+
 auto registrableDomain = WebCore::RegistrableDomain { url };
 if (m_registrableDomain && *m_registrableDomain != registrableDomain) {
 #if ENABLE(SERVICE_WORKER)


Modified: trunk/Tools/ChangeLog (262431 => 262432)

--- trunk/Tools/ChangeLog	2020-06-02 18:19:18 UTC (rev 262431)
+++ trunk/Tools/ChangeLog	2020-06-02 18:38:26 UTC (rev 262432)
@@ -1,3 +1,12 @@
+2020-06-02  Youenn Fablet  
+
+Allow using web processes for service workers even though they loaded about URLs
+https://bugs.webkit.org/show_bug.cgi?id=212464
+
+Reviewed by Chris Dumez.
+
+* TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
+
 2020-06-02  Diego Pino Garcia  
 
 [buildbot] [GTK][WPE] Move _javascript_ related tests to own bot


Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm (262431 => 262432)

--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm	2020-06-02 18:19:18 UTC (rev 262431)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm	2020-06-02 18:38:26 UTC (rev 262432)
@@ -1576,7 +1576,7 @@
 waitUntilServiceWorkerProcessCount(processPool, 2);
 }
 
-static size_t launchServiceWorkerProcess(bool useSeparateServiceWorkerProcess)
+static size_t launchServiceWorkerProcess(bool useSeparateServiceWorkerProcess, bool loadAboutBlankBeforePage)
 {
 [WKWebsiteDataStore _allowWebsiteDataRecordsForAllOrigins];
 
@@ -1602,6 +1602,18 @@
 
 auto webView = adoptNS([[WKWebView alloc] initWithFrame:NSMakeRect(0, 0, 800, 600) configuration:configuration.get()]);
 
+auto navigationDelegate = adoptNS([[TestNavigationDelegate alloc] init]);
+[navigationDelegate setDidFinishNavigation:^(WKWebView *, WKNavigation *) {
+didFinishNavigation = true;
+}];
+[webView setNavigationDelegate:navigationDelegate.get()];
+
+if (loadAboutBlankBeforePage) {
+didFinishNavigation = false;
+[webView loadRequest: [NSURLRequest requestWithURL:[NSURL URLWithString:@"about:blank"]]];
+TestWebKitAPI::Util::run(&didFinishNavigation);
+}
+
 [webView loadRequest:server.request()];
 
 waitUntilServiceWorkerProcessCount(processPool, 1);
@@ -1610,13 +1622,22 @@
 
 TEST(ServiceWorkers, OutOfAndInProcessServiceWorker)
 {
-bool useSeparateServiceWorkerProcess = false;
-EXPECT_EQ(1u, launchServiceWorkerProcess(useSeparateServiceWorkerProcess));
+bool useSeparateServiceWorkerProcess = true;
+bool firstLoadAboutBlank = true;
 
-useSep

[webkit-changes] [262431] trunk/LayoutTests

2020-06-02 Thread jacob_uphoff

Title: [262431] trunk/LayoutTests








Revision 262431
Author jacob_uph...@apple.com
Date 2020-06-02 11:19:18 -0700 (Tue, 02 Jun 2020)


Log Message
Landing expectations for tests that were recently imported but did not have them

Unreviewed test gardening

* platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/input-text-scroll-event-when-using-arrow-keys-expected.txt: Added.
* platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-deltas-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/input-text-scroll-event-when-using-arrow-keys-expected.txt
trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-deltas-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (262430 => 262431)

--- trunk/LayoutTests/ChangeLog	2020-06-02 18:10:55 UTC (rev 262430)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 18:19:18 UTC (rev 262431)
@@ -1,3 +1,12 @@
+2020-06-02  Jacob Uphoff  
+
+Landing expectations for tests that were recently imported but did not have them
+
+Unreviewed test gardening
+
+* platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/input-text-scroll-event-when-using-arrow-keys-expected.txt: Added.
+* platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-deltas-expected.txt: Added.
+
 2020-06-02  Jason Lawrence  
 
 [ iOS wk2 ] animations/play-state-paused.html is flaky failing.


Added: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/input-text-scroll-event-when-using-arrow-keys-expected.txt (0 => 262431)

--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/input-text-scroll-event-when-using-arrow-keys-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/input-text-scroll-event-when-using-arrow-keys-expected.txt	2020-06-02 18:19:18 UTC (rev 262431)
@@ -0,0 +1,9 @@
+Moving the cursor using the arrow keys into an input element fires scroll events when text has to scroll into view. Uses arrow keys to move forward and backwards in the input element.
+
+  
+
+Harness Error (TIMEOUT), message = null
+
+TIMEOUT Scroll event fired for  element. Test timed out
+NOTRUN Scroll event fired for  element. 
+


Added: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-deltas-expected.txt (0 => 262431)

--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-deltas-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/dom/events/scrolling/overscroll-deltas-expected.txt	2020-06-02 18:19:18 UTC (rev 262431)
@@ -0,0 +1,3 @@
+
+FAIL Tests that the document gets overscroll event with right deltaX/Y attributes. promise_test: Unhandled rejection with value: "Document did not receive scrollend event."
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262430] trunk/Source/WebCore

Title: [262430] trunk/Source/WebCore








Revision 262430
Author commit-qu...@webkit.org
Date 2020-06-02 11:10:55 -0700 (Tue, 02 Jun 2020)


Log Message
Pass nullptr for the 2nd argument of FileReaderLoader
https://bugs.webkit.org/show_bug.cgi?id=212642

Patch by Tetsuharu Ohzeki  on 2020-06-02
Reviewed by Darin Adler.

Instead of passing `0`, `nullptr` is better
because `FileReaderLoader` takes a pointer.

* fileapi/FileReaderSync.cpp:
(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/FileReaderSync.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (262429 => 262430)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 17:14:48 UTC (rev 262429)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 18:10:55 UTC (rev 262430)
@@ -1,3 +1,19 @@
+2020-06-02  Tetsuharu Ohzeki  
+
+Pass nullptr for the 2nd argument of FileReaderLoader 
+https://bugs.webkit.org/show_bug.cgi?id=212642
+
+Reviewed by Darin Adler.
+
+Instead of passing `0`, `nullptr` is better
+because `FileReaderLoader` takes a pointer.
+
+* fileapi/FileReaderSync.cpp:
+(WebCore::FileReaderSync::readAsArrayBuffer):
+(WebCore::FileReaderSync::readAsBinaryString):
+(WebCore::FileReaderSync::readAsText):
+(WebCore::FileReaderSync::readAsDataURL):
+
 2020-06-02  Tim Horton  
 
 UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors


Modified: trunk/Source/WebCore/fileapi/FileReaderSync.cpp (262429 => 262430)

--- trunk/Source/WebCore/fileapi/FileReaderSync.cpp	2020-06-02 17:14:48 UTC (rev 262429)
+++ trunk/Source/WebCore/fileapi/FileReaderSync.cpp	2020-06-02 18:10:55 UTC (rev 262430)
@@ -45,7 +45,7 @@
 
 ExceptionOr> FileReaderSync::readAsArrayBuffer(ScriptExecutionContext& scriptExecutionContext, Blob& blob)
 {
-FileReaderLoader loader(FileReaderLoader::ReadAsArrayBuffer, 0);
+FileReaderLoader loader(FileReaderLoader::ReadAsArrayBuffer, nullptr);
 auto result = startLoading(scriptExecutionContext, loader, blob);
 if (result.hasException())
 return result.releaseException();
@@ -54,13 +54,13 @@
 
 ExceptionOr FileReaderSync::readAsBinaryString(ScriptExecutionContext& scriptExecutionContext, Blob& blob)
 {
-FileReaderLoader loader(FileReaderLoader::ReadAsBinaryString, 0);
+FileReaderLoader loader(FileReaderLoader::ReadAsBinaryString, nullptr);
 return startLoadingString(scriptExecutionContext, loader, blob);
 }
 
 ExceptionOr FileReaderSync::readAsText(ScriptExecutionContext& scriptExecutionContext, Blob& blob, const String& encoding)
 {
-FileReaderLoader loader(FileReaderLoader::ReadAsText, 0);
+FileReaderLoader loader(FileReaderLoader::ReadAsText, nullptr);
 loader.setEncoding(encoding);
 return startLoadingString(scriptExecutionContext, loader, blob);
 }
@@ -67,7 +67,7 @@
 
 ExceptionOr FileReaderSync::readAsDataURL(ScriptExecutionContext& scriptExecutionContext, Blob& blob)
 {
-FileReaderLoader loader(FileReaderLoader::ReadAsDataURL, 0);
+FileReaderLoader loader(FileReaderLoader::ReadAsDataURL, nullptr);
 loader.setDataType(blob.type());
 return startLoadingString(scriptExecutionContext, loader, blob);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262429] trunk/Source/WebKit

2020-06-02 Thread timothy_horton

Title: [262429] trunk/Source/WebKit








Revision 262429
Author timothy_hor...@apple.com
Date 2020-06-02 10:14:48 -0700 (Tue, 02 Jun 2020)


Log Message
macCatalyst: WKWebView's tint color is not propagated to Web Content process
https://bugs.webkit.org/show_bug.cgi?id=212630

Reviewed by Anders Carlsson.

* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode const):
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
* UIProcess/Cocoa/PageClientImplCocoa.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp
trunk/Source/WebKit/Shared/WebPageCreationParameters.h
trunk/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h
trunk/Source/WebKit/UIProcess/PageClient.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (262428 => 262429)

--- trunk/Source/WebKit/ChangeLog	2020-06-02 17:11:43 UTC (rev 262428)
+++ trunk/Source/WebKit/ChangeLog	2020-06-02 17:14:48 UTC (rev 262429)
@@ -1,5 +1,23 @@
 2020-06-02  Tim Horton  
 
+macCatalyst: WKWebView's tint color is not propagated to Web Content process
+https://bugs.webkit.org/show_bug.cgi?id=212630
+
+Reviewed by Anders Carlsson.
+
+* Shared/WebPageCreationParameters.cpp:
+(WebKit::WebPageCreationParameters::encode const):
+(WebKit::WebPageCreationParameters::decode):
+* Shared/WebPageCreationParameters.h:
+* UIProcess/Cocoa/PageClientImplCocoa.h:
+* UIProcess/PageClient.h:
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::creationParameters):
+* WebProcess/WebPage/WebPage.cpp:
+* WebProcess/WebPage/WebPage.h:
+
+2020-06-02  Tim Horton  
+
 REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
 https://bugs.webkit.org/show_bug.cgi?id=212628
 


Modified: trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp (262428 => 262429)

--- trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp	2020-06-02 17:11:43 UTC (rev 262428)
+++ trunk/Source/WebKit/Shared/WebPageCreationParameters.cpp	2020-06-02 17:14:48 UTC (rev 262429)
@@ -113,6 +113,9 @@
 encoder << smartInsertDeleteEnabled;
 encoder << additionalSupportedImageTypes;
 #endif
+#if ENABLE(TINT_COLOR_SUPPORT)
+encoder << tintColor;
+#endif
 #if USE(WPE_RENDERER)
 encoder << hostFileDescriptor;
 #endif
@@ -356,6 +359,11 @@
 return WTF::nullopt;
 #endif
 
+#if ENABLE(TINT_COLOR_SUPPORT)
+if (!decoder.decode(parameters.tintColor))
+return WTF::nullopt;
+#endif
+
 #if USE(WPE_RENDERER)
 if (!decoder.decode(parameters.hostFileDescriptor))
 return WTF::nullopt;


Modified: trunk/Source/WebKit/Shared/WebPageCreationParameters.h (262428 => 262429)

--- trunk/Source/WebKit/Shared/WebPageCreationParameters.h	2020-06-02 17:11:43 UTC (rev 262428)
+++ trunk/Source/WebKit/Shared/WebPageCreationParameters.h	2020-06-02 17:14:48 UTC (rev 262429)
@@ -174,6 +174,9 @@
 bool smartInsertDeleteEnabled;
 Vector additionalSupportedImageTypes;
 #endif
+#if ENABLE(TINT_COLOR_SUPPORT)
+WebCore::Color tintColor;
+#endif
 #if USE(WPE_RENDERER)
 IPC::Attachment hostFileDescriptor;
 #endif


Modified: trunk/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h (262428 => 262429)

--- trunk/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h	2020-06-02 17:11:43 UTC (rev 262428)
+++ trunk/Source/WebKit/UIProcess/Cocoa/PageClientImplCocoa.h	2020-06-02 17:14:48 UTC (rev 262429)
@@ -54,6 +54,10 @@
 
 bool scrollingUpdatesDisabledForTesting() final;
 
+#if ENABLE(TINT_COLOR_SUPPORT)
+WebCore::Color tintColor() final;
+#endif
+
 #if ENABLE(ATTACHMENT_ELEMENT)
 void didInsertAttachment(API::Attachment&, const String& source) final;
 void didRemoveAttachment(API::Attachment&) final;


Modified: trunk/Source/WebKit/UIProcess/PageClient.h (262428 => 262429)

--- trunk/Source/WebKit/UIProcess/PageClient.h	2020-06-02 17:11:43 UTC (rev 262428)
+++ trunk/Source/WebKit/UIProcess/PageClient.h	2020-06-02 17:14:48 UTC (rev 262429)
@@ -350,6 +350,10 @@
 virtual void didPerformDictionaryLookup(const WebCore::DictionaryPopupInfo&) = 0;
 #endif
 
+#if ENABLE(TINT_COLOR_SUPPORT)
+virtual WebCore::Color tintColor() = 0;
+#endif
+
 virtual bool effectiveAppearanceIsDark() const { return false; }
 virtual bool effectiveUserInterfaceLevelIsElevated() const { return false; }
 


Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (262428 => 262429)

--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-06-02 17:11:43 UTC (rev 262428)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp	2020-06-02

[webkit-changes] [262428] trunk/Source/WebCore

2020-06-02 Thread timothy_horton

Title: [262428] trunk/Source/WebCore








Revision 262428
Author timothy_hor...@apple.com
Date 2020-06-02 10:11:43 -0700 (Tue, 02 Jun 2020)


Log Message
UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors
https://bugs.webkit.org/show_bug.cgi?id=212631

Reviewed by Anders Carlsson.

* platform/graphics/mac/ColorMac.mm:
(WebCore::colorFromNSColor):
(WebCore::semanticColorFromNSColor):
* platform/ios/ColorIOS.mm:
(WebCore::colorFromUIColor):
This doesn't affect any code currently in WebKit, but it is very, very surprising
that these functions happily accept a null color, assert in debug, but in release
do crazy things like try to paint the null color into a small bitmap to figure out
what it really is.

Also, this matches the behavior of the Color constructors that take CGColorRef.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/mac/ColorMac.mm
trunk/Source/WebCore/platform/ios/ColorIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (262427 => 262428)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 17:09:18 UTC (rev 262427)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 17:11:43 UTC (rev 262428)
@@ -1,3 +1,22 @@
+2020-06-02  Tim Horton  
+
+UIColor and NSColor WebCore::Color factories should return invalid colors for nil input colors
+https://bugs.webkit.org/show_bug.cgi?id=212631
+
+Reviewed by Anders Carlsson.
+
+* platform/graphics/mac/ColorMac.mm:
+(WebCore::colorFromNSColor):
+(WebCore::semanticColorFromNSColor):
+* platform/ios/ColorIOS.mm:
+(WebCore::colorFromUIColor):
+This doesn't affect any code currently in WebKit, but it is very, very surprising
+that these functions happily accept a null color, assert in debug, but in release
+do crazy things like try to paint the null color into a small bitmap to figure out
+what it really is.
+
+Also, this matches the behavior of the Color constructors that take CGColorRef.
+
 2020-06-02  Rob Buis  
 
 Make generated C++ code use modern C++


Modified: trunk/Source/WebCore/platform/graphics/mac/ColorMac.mm (262427 => 262428)

--- trunk/Source/WebCore/platform/graphics/mac/ColorMac.mm	2020-06-02 17:09:18 UTC (rev 262427)
+++ trunk/Source/WebCore/platform/graphics/mac/ColorMac.mm	2020-06-02 17:11:43 UTC (rev 262428)
@@ -94,6 +94,9 @@
 
 Color colorFromNSColor(NSColor *color)
 {
+if (!color)
+return { };
+
 // FIXME: ExtendedColor - needs to handle color spaces.
 
 return makeSimpleColorFromNSColor(color);
@@ -101,6 +104,9 @@
 
 Color semanticColorFromNSColor(NSColor *color)
 {
+if (!color)
+return { };
+
 // FIXME: ExtendedColor - needs to handle color spaces.
 
 return Color(makeSimpleColorFromNSColor(color), Color::Semantic);


Modified: trunk/Source/WebCore/platform/ios/ColorIOS.mm (262427 => 262428)

--- trunk/Source/WebCore/platform/ios/ColorIOS.mm	2020-06-02 17:09:18 UTC (rev 262427)
+++ trunk/Source/WebCore/platform/ios/ColorIOS.mm	2020-06-02 17:11:43 UTC (rev 262428)
@@ -34,6 +34,9 @@
 
 Color colorFromUIColor(UIColor *color)
 {
+if (!color)
+return { };
+
 // FIXME: ExtendedColor - needs to handle color spaces.
 
 // FIXME: Make this work for a UIColor that was created from a pattern or a DispayP3 color.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262427] trunk/Source/WebKit

2020-06-02 Thread timothy_horton

Title: [262427] trunk/Source/WebKit








Revision 262427
Author timothy_hor...@apple.com
Date 2020-06-02 10:09:18 -0700 (Tue, 02 Jun 2020)


Log Message
REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
https://bugs.webkit.org/show_bug.cgi?id=212628


Reviewed by Per Arne Vollan.

Two issues with the "CFPrefs Direct Mode" mechanism caused dynamic changes to the
user accent color preference to not be respected anymore:

- the default change, when synchronized to the Web Content process, was
written into the wrong domain, because of bug 212627.

- AppKit caches the resolved accent color; the cache is invalidated when the
a CoreUI notification is posted. Since we synchronize preferences ourselves,
the ordering of the default change and notification are no longer guaranteed,
so AppKit sometimes reads and re-caches the old accent color.

* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::userAccentColorPreferenceKey):
(WebKit::shouldWriteToAppDomainForPreferenceKey):
(WebKit::WebProcess::notifyPreferencesChanged):
To fix the first problem, write the default into the standardUserDefaults.
This is just a workaround, we need a more general solution to this problem
for all global preferences. We know it's OK in this case, because AppKit
happens to read from standardUserDefaults.

(WebKit::dispatchSimulatedNotificationsForPreferenceChange):
To fix the second problem, re-emit the notification once we have synchronized
the preference to the Web Content process.

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (262426 => 262427)

--- trunk/Source/WebKit/ChangeLog	2020-06-02 17:07:41 UTC (rev 262426)
+++ trunk/Source/WebKit/ChangeLog	2020-06-02 17:09:18 UTC (rev 262427)
@@ -1,3 +1,35 @@
+2020-06-02  Tim Horton  
+
+REGRESSION (r258949): Dynamic user accent color changes are not respected by WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=212628
+
+
+Reviewed by Per Arne Vollan.
+
+Two issues with the "CFPrefs Direct Mode" mechanism caused dynamic changes to the
+user accent color preference to not be respected anymore:
+
+- the default change, when synchronized to the Web Content process, was
+written into the wrong domain, because of bug 212627.
+
+- AppKit caches the resolved accent color; the cache is invalidated when the
+a CoreUI notification is posted. Since we synchronize preferences ourselves,
+the ordering of the default change and notification are no longer guaranteed,
+so AppKit sometimes reads and re-caches the old accent color.
+
+* WebProcess/cocoa/WebProcessCocoa.mm:
+(WebKit::userAccentColorPreferenceKey):
+(WebKit::shouldWriteToAppDomainForPreferenceKey):
+(WebKit::WebProcess::notifyPreferencesChanged):
+To fix the first problem, write the default into the standardUserDefaults.
+This is just a workaround, we need a more general solution to this problem
+for all global preferences. We know it's OK in this case, because AppKit
+happens to read from standardUserDefaults.
+
+(WebKit::dispatchSimulatedNotificationsForPreferenceChange):
+To fix the second problem, re-emit the notification once we have synchronized
+the preference to the Web Content process.
+
 2020-06-02  Rob Buis  
 
 Make generated C++ code use modern C++


Modified: trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm (262426 => 262427)

--- trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-06-02 17:07:41 UTC (rev 262426)
+++ trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm	2020-06-02 17:09:18 UTC (rev 262427)
@@ -917,11 +917,52 @@
 }
 
 #if ENABLE(CFPREFS_DIRECT_MODE)
+
+#if USE(APPKIT)
+static const WTF::String& userAccentColorPreferenceKey()
+{
+static NeverDestroyed userAccentColorPreferenceKey(MAKE_STATIC_STRING_IMPL("AppleAccentColor"));
+return userAccentColorPreferenceKey;
+}
+#endif
+
+static bool shouldWriteToAppDomainForPreferenceKey(const String& key)
+{
+#if USE(APPKIT)
+return key == userAccentColorPreferenceKey();
+#else
+return false;
+#endif
+}
+
+static void dispatchSimulatedNotificationsForPreferenceChange(const String& key)
+{
+#if USE(APPKIT)
+// Ordinarily, other parts of the system ensure that this notification is posted after this default is changed.
+// However, since we synchronize defaults to the Web Content process using a mechanism not known to the rest
+// of the system, we must re-post the notification in the Web Content process after updating the default.
+if (key == userAccentColorPreferenceKey())
+[[NSNotificationCenter defaultCenter] postNotificationName:@"kCUINotificationAquaColorVariantChanged" object:nil];
+#endif
+}
+
 void WebProcess::notifyPreferencesChanged(const String& domain, const String& key, const Optio

[webkit-changes] [262426] trunk/LayoutTests

2020-06-02 Thread lawrence . j

Title: [262426] trunk/LayoutTests








Revision 262426
Author lawrenc...@apple.com
Date 2020-06-02 10:07:41 -0700 (Tue, 02 Jun 2020)


Log Message
[ iOS wk2 ] animations/play-state-paused.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=212641

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262425 => 262426)

--- trunk/LayoutTests/ChangeLog	2020-06-02 16:55:15 UTC (rev 262425)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 17:07:41 UTC (rev 262426)
@@ -1,3 +1,12 @@
+2020-06-02  Jason Lawrence  
+
+[ iOS wk2 ] animations/play-state-paused.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=212641
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
 2020-06-02  Jacob Uphoff  
 
 [ iOS debug ] REGRESSION(r262254): imported/w3c/web-platform-tests/2dcontext/fill-and-stroke-styles/canvas_colorsandstyles_createlineargradient_001.htm is a constant timeout


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (262425 => 262426)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-06-02 16:55:15 UTC (rev 262425)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-06-02 17:07:41 UTC (rev 262426)
@@ -1748,4 +1748,6 @@
 webkit.org/b/186045 [ Release ] imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ Pass Failure ]
 
 webkit.org/b/212532 http/wpt/service-workers/service-worker-crashing-while-fetching.https.html [ Pass Failure ]
-webkit.org/b/212532 http/wpt/service-workers/service-worker-different-process.https.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/212532 http/wpt/service-workers/service-worker-different-process.https.html [ Pass Failure ]
+
+webkit.org/b/212641 animations/play-state-paused.html [ Pass Failure ]
\ No newline at end of file






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262425] trunk

2020-06-02 Thread sbarati

Title: [262425] trunk








Revision 262425
Author sbar...@apple.com
Date 2020-06-02 09:55:15 -0700 (Tue, 02 Jun 2020)


Log Message
MultiDeleteByOffset should not always def
https://bugs.webkit.org/show_bug.cgi?id=212621


Reviewed by Yusuke Suzuki.

JSTests:

* stress/multi-del-by-offset-doesnt-always-def-osr-entry.js: Added.
(foo):
* stress/multi-del-by-offset-doesnt-always-def.js: Added.
(foo):
(let.p.set undefined):

Source/_javascript_Core:

Clobberize used to claim that MultiDeleteByOffset always defd a value.
That's an incorrect modeling of MultiDeleteByOffset though, since it might
have delete misses in its variant list. This would lead us to incorrectly
CSE when we shouldn't. This patch fixes this by saying MultiDeleteByOffset
only defs when all its cases write out a value (are hits).

* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGNode.cpp:
(JSC::DFG::MultiDeleteByOffsetData::allVariantsStoreEmpty const):
* dfg/DFGNode.h:
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMultiDeleteByOffset):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGClobberize.h
trunk/Source/_javascript_Core/dfg/DFGNode.cpp
trunk/Source/_javascript_Core/dfg/DFGNode.h
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp


Added Paths

trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def-osr-entry.js
trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def.js




Diff

Modified: trunk/JSTests/ChangeLog (262424 => 262425)

--- trunk/JSTests/ChangeLog	2020-06-02 16:10:54 UTC (rev 262424)
+++ trunk/JSTests/ChangeLog	2020-06-02 16:55:15 UTC (rev 262425)
@@ -1,3 +1,17 @@
+2020-06-02  Saam Barati  
+
+MultiDeleteByOffset should not always def
+https://bugs.webkit.org/show_bug.cgi?id=212621
+
+
+Reviewed by Yusuke Suzuki.
+
+* stress/multi-del-by-offset-doesnt-always-def-osr-entry.js: Added.
+(foo):
+* stress/multi-del-by-offset-doesnt-always-def.js: Added.
+(foo):
+(let.p.set undefined):
+
 2020-06-01  Yusuke Suzuki  
 
 [JSC] JSBigInt::rightTrim can miss |this| pointer and leads to incorrect GC collection


Added: trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def-osr-entry.js (0 => 262425)

--- trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def-osr-entry.js	(rev 0)
+++ trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def-osr-entry.js	2020-06-02 16:55:15 UTC (rev 262425)
@@ -0,0 +1,13 @@
+let p = { get: undefined, set: undefined, };
+
+function foo() {
+let o = {};
+for (let i = 0; i < 100; i++) {
+for (let j = 0; j < 5; j++)
+delete o.x;
+o.x;
+Object.defineProperty(o, 'x', p);
+}
+}
+
+foo()


Added: trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def.js (0 => 262425)

--- trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def.js	(rev 0)
+++ trunk/JSTests/stress/multi-del-by-offset-doesnt-always-def.js	2020-06-02 16:55:15 UTC (rev 262425)
@@ -0,0 +1,14 @@
+let p = { get: undefined, set: undefined, };
+let o1 = {};
+Object.defineProperty(o1, 'x', p);
+
+function foo(o) {
+if (!(delete o.x))
+o.x;
+}
+noInline(foo);
+
+for (let i = 0; i < 1; ++i) {
+foo(o1);
+foo({x : 42});
+}


Modified: trunk/Source/_javascript_Core/ChangeLog (262424 => 262425)

--- trunk/Source/_javascript_Core/ChangeLog	2020-06-02 16:10:54 UTC (rev 262424)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-06-02 16:55:15 UTC (rev 262425)
@@ -1,3 +1,25 @@
+2020-06-02  Saam Barati  
+
+MultiDeleteByOffset should not always def
+https://bugs.webkit.org/show_bug.cgi?id=212621
+
+
+Reviewed by Yusuke Suzuki.
+
+Clobberize used to claim that MultiDeleteByOffset always defd a value.
+That's an incorrect modeling of MultiDeleteByOffset though, since it might
+have delete misses in its variant list. This would lead us to incorrectly
+CSE when we shouldn't. This patch fixes this by saying MultiDeleteByOffset
+only defs when all its cases write out a value (are hits).
+
+* dfg/DFGClobberize.h:
+(JSC::DFG::clobberize):
+* dfg/DFGNode.cpp:
+(JSC::DFG::MultiDeleteByOffsetData::allVariantsStoreEmpty const):
+* dfg/DFGNode.h:
+* ftl/FTLLowerDFGToB3.cpp:
+(JSC::FTL::DFG::LowerDFGToB3::compileMultiDeleteByOffset):
+
 2020-06-02  Rob Buis  
 
 Make generated C++ code use modern C++


Modified: trunk/Source/_javascript_Core/dfg/DFGClobberize.h (262424 => 262425)

--- trunk/Source/_javascript_Core/dfg/DFGClobberize.h	2020-06-02 16:10:54 UTC (rev 262424)
+++ trunk/Source/_javascript_Core/dfg/DFGClobberize.h	2020-06-02 16:55:15 UTC (rev 262425)
@@ -1338,7 +1338,8 @@
 // alias analysis.
 write(NamedProperties);
 }
-def(HeapLocation(NamedPropertyLoc, heap, node->child1()), LazyNode

[webkit-changes] [262424] trunk/Source

Title: [262424] trunk/Source








Revision 262424
Author commit-qu...@webkit.org
Date 2020-06-02 09:10:54 -0700 (Tue, 02 Jun 2020)


Log Message
Make generated C++ code use modern C++
https://bugs.webkit.org/show_bug.cgi?id=190714

Patch by Rob Buis  on 2020-06-02
Reviewed by Sam Weinig.

Source/_javascript_Core:

Update inspector protocol generator and rebaseline the tests.

* inspector/scripts/codegen/cpp_generator_templates.py:
* inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
* inspector/scripts/tests/expected/enum-values.json-result:
* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
* inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
* inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
* inspector/scripts/tests/expected/type-declaration-array-type.json-result:
* inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
* inspector/scripts/tests/expected/type-declaration-object-type.json-result:
* inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
* yarr/generateYarrUnicodePropertyTables.py:

Source/WebCore:

Replace typedef usage by alias-declaration.

No new tests. No change in behavior.

* css/makeprop.pl:
* dom/make_names.pl:
(printHeaderHead):
(printInit):
(printTypeHelpersHeaderFile):
(printFactoryCppFile):
(printFactoryHeaderFile):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

Source/WebKit:

Replace typedef usage by alias-declaration.

* Scripts/webkit/messages.py:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/scripts/codegen/cpp_generator_templates.py
trunk/Source/_javascript_Core/inspector/scripts/codegen/generate_cpp_protocol_types_header.py
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-async-attribute.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/enum-values.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/events-with-optional-parameters.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/same-type-id-different-domain.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-array-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-enum-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-declaration-object-type.json-result
trunk/Source/_javascript_Core/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result
trunk/Source/_javascript_Core/yarr/generateYarrUnicodePropertyTables.py
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/makeprop.pl
trunk/Source/WebCore/dom/make_names.pl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Scripts/webkit/messages.py




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (262423 => 262424)

--- trunk/Source/_javascript_Core/ChangeLog	2020-06-02 16:05:35 UTC (rev 262423)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-06-02 16:10:54 UTC (rev 262424)
@@ -1,3 +1,27 @@
+2020-06-02  Rob Buis  
+
+Make generated C++ code use modern C++
+https://bugs.webkit.org/show_bug.cgi?id=190714
+
+Reviewed by Sam Weinig.
+
+Update inspector protocol generator and rebaseline the tests.
+
+* inspector/scripts/codegen/cpp_generator_templates.py:
+* inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
+* inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
+* inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
+* inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
+* inspector/scripts/tests/expected/enum-values.json-result:
+* inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
+* inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
+* inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
+* inspector/scripts/tests/expected/type-declaration-array-type.json-result:
+* inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
+* inspector/scripts/tests/expected/type-declaration-object-type.json-result:
+

[webkit-changes] [262423] trunk/LayoutTests

2020-06-02 Thread jacob_uphoff

Title: [262423] trunk/LayoutTests








Revision 262423
Author jacob_uph...@apple.com
Date 2020-06-02 09:05:35 -0700 (Tue, 02 Jun 2020)


Log Message
[ iOS debug ] REGRESSION(r262254): imported/w3c/web-platform-tests/2dcontext/fill-and-stroke-styles/canvas_colorsandstyles_createlineargradient_001.htm is a constant timeout
https://bugs.webkit.org/show_bug.cgi?id=212636

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262422 => 262423)

--- trunk/LayoutTests/ChangeLog	2020-06-02 15:41:03 UTC (rev 262422)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 16:05:35 UTC (rev 262423)
@@ -1,5 +1,14 @@
 2020-06-02  Jacob Uphoff  
 
+[ iOS debug ] REGRESSION(r262254): imported/w3c/web-platform-tests/2dcontext/fill-and-stroke-styles/canvas_colorsandstyles_createlineargradient_001.htm is a constant timeout
+https://bugs.webkit.org/show_bug.cgi?id=212636
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
+2020-06-02  Jacob Uphoff  
+
 Removing expectations for a test that is now passing
 https://bugs.webkit.org/show_bug.cgi?id=211920
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (262422 => 262423)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-06-02 15:41:03 UTC (rev 262422)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-06-02 16:05:35 UTC (rev 262423)
@@ -1743,6 +1743,8 @@
 
 webkit.org/b/212219 media/track/track-cue-missing.html [ Pass Failure ]
 
+webkit.org/b/212636 [ Debug ] imported/w3c/web-platform-tests/2dcontext/fill-and-stroke-styles/canvas_colorsandstyles_createlineargradient_001.htm [ Slow ]
+
 webkit.org/b/186045 [ Release ] imported/w3c/web-platform-tests/css/css-display/display-none-inline-img.html [ Pass Failure ]
 
 webkit.org/b/212532 http/wpt/service-workers/service-worker-crashing-while-fetching.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262422] trunk/Source/ThirdParty/libwebrtc

Title: [262422] trunk/Source/ThirdParty/libwebrtc








Revision 262422
Author commit-qu...@webkit.org
Date 2020-06-02 08:41:03 -0700 (Tue, 02 Jun 2020)


Log Message
Unreviewed, reverting r262290.
https://bugs.webkit.org/show_bug.cgi?id=212638

it is not yet ready (Requested by youenn on #webkit).

Reverted changeset:

"Enable VTB required low latency code path"
https://bugs.webkit.org/show_bug.cgi?id=210609
https://trac.webkit.org/changeset/262290

Modified Paths

trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h
trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm




Diff

Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (262421 => 262422)

--- trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-06-02 15:36:28 UTC (rev 262421)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog	2020-06-02 15:41:03 UTC (rev 262422)
@@ -1,3 +1,16 @@
+2020-06-02  Commit Queue  
+
+Unreviewed, reverting r262290.
+https://bugs.webkit.org/show_bug.cgi?id=212638
+
+it is not yet ready (Requested by youenn on #webkit).
+
+Reverted changeset:
+
+"Enable VTB required low latency code path"
+https://bugs.webkit.org/show_bug.cgi?id=210609
+https://trac.webkit.org/changeset/262290
+
 2020-05-29  Keith Rollin  
 
 Revert switch to XCBuild


Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h (262421 => 262422)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h	2020-06-02 15:36:28 UTC (rev 262421)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h	2020-06-02 15:41:03 UTC (rev 262422)
@@ -39,11 +39,9 @@
 #elif (defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
 #define ENABLE_VCP_ENCODER __IPHONE_OS_VERSION_MIN_REQUIRED < 14
 #define ENABLE_VCP_VTB_ENCODER __IPHONE_OS_VERSION_MIN_REQUIRED >= 13 && __IPHONE_OS_VERSION_MIN_REQUIRED < 14
-#define HAVE_VTB_REQUIREDLOWLATENCY __IPHONE_OS_VERSION_MIN_REQUIRED >= 14
 #elif (defined(TARGET_OS_MAC) && TARGET_OS_MAC)
 #define ENABLE_VCP_ENCODER __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
 #define ENABLE_VCP_VTB_ENCODER __MAC_OS_X_VERSION_MIN_REQUIRED >= 101500 && __MAC_OS_X_VERSION_MIN_REQUIRED < 101600
-#define HAVE_VTB_REQUIREDLOWLATENCY __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
 #endif
 
 #endif


Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (262421 => 262422)

--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2020-06-02 15:36:28 UTC (rev 262421)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm	2020-06-02 15:41:03 UTC (rev 262422)
@@ -45,7 +45,6 @@
 #import 
 #import 
 
-VT_EXPORT const CFStringRef kVTVideoEncoderSpecification_RequiredLowLatency;
 VT_EXPORT const CFStringRef kVTVideoEncoderSpecification_Usage;
 VT_EXPORT const CFStringRef kVTCompressionPropertyKey_Usage;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262421] trunk/Source/WebCore

Title: [262421] trunk/Source/WebCore








Revision 262421
Author commit-qu...@webkit.org
Date 2020-06-02 08:36:28 -0700 (Tue, 02 Jun 2020)


Log Message
Remove unused BlobURL::getIdentifier
https://bugs.webkit.org/show_bug.cgi?id=212635

Patch by Tetsuharu Ohzeki  on 2020-06-02
Reviewed by Youenn Fablet.

* fileapi/BlobURL.cpp:
* fileapi/BlobURL.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/fileapi/BlobURL.cpp
trunk/Source/WebCore/fileapi/BlobURL.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (262420 => 262421)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 15:08:32 UTC (rev 262420)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 15:36:28 UTC (rev 262421)
@@ -1,3 +1,13 @@
+2020-06-02  Tetsuharu Ohzeki  
+
+Remove unused BlobURL::getIdentifier
+https://bugs.webkit.org/show_bug.cgi?id=212635
+
+Reviewed by Youenn Fablet.
+
+* fileapi/BlobURL.cpp:
+* fileapi/BlobURL.h:
+
 2020-06-02  Mark Lam  
 
 Fix broken Windows build.


Modified: trunk/Source/WebCore/fileapi/BlobURL.cpp (262420 => 262421)

--- trunk/Source/WebCore/fileapi/BlobURL.cpp	2020-06-02 15:08:32 UTC (rev 262420)
+++ trunk/Source/WebCore/fileapi/BlobURL.cpp	2020-06-02 15:36:28 UTC (rev 262421)
@@ -61,14 +61,6 @@
 return url.string().substring(startIndex, endIndex - startIndex - 1);
 }
 
-String BlobURL::getIdentifier(const URL& url)
-{
-ASSERT(url.protocolIs(kBlobProtocol));
-
-unsigned startIndex = url.pathAfterLastSlash();
-return url.string().substring(startIndex);
-}
-
 URL BlobURL::createBlobURL(const String& originString)
 {
 ASSERT(!originString.isEmpty());


Modified: trunk/Source/WebCore/fileapi/BlobURL.h (262420 => 262421)

--- trunk/Source/WebCore/fileapi/BlobURL.h	2020-06-02 15:08:32 UTC (rev 262420)
+++ trunk/Source/WebCore/fileapi/BlobURL.h	2020-06-02 15:36:28 UTC (rev 262421)
@@ -50,7 +50,6 @@
 static URL createPublicURL(SecurityOrigin*);
 static URL createInternalURL();
 static String getOrigin(const URL&);
-static String getIdentifier(const URL&);
 
 private:
 static URL createBlobURL(const String& originString);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262420] trunk/LayoutTests

2020-06-02 Thread jacob_uphoff

Title: [262420] trunk/LayoutTests








Revision 262420
Author jacob_uph...@apple.com
Date 2020-06-02 08:08:32 -0700 (Tue, 02 Jun 2020)


Log Message
Removing expectations for a test that is now passing
https://bugs.webkit.org/show_bug.cgi?id=211920

Unreviewed test gardening

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262419 => 262420)

--- trunk/LayoutTests/ChangeLog	2020-06-02 14:19:29 UTC (rev 262419)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 15:08:32 UTC (rev 262420)
@@ -1,3 +1,12 @@
+2020-06-02  Jacob Uphoff  
+
+Removing expectations for a test that is now passing
+https://bugs.webkit.org/show_bug.cgi?id=211920
+
+Unreviewed test gardening
+
+* platform/ios-wk2/TestExpectations:
+
 2020-06-02  Lauro Moura  
 
 [GLIB] Update TestExpectations Sections


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (262419 => 262420)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-06-02 14:19:29 UTC (rev 262419)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2020-06-02 15:08:32 UTC (rev 262420)
@@ -1336,8 +1336,6 @@
 
 webkit.org/b/207551 http/tests/adClickAttribution/store-disabled-in-ephemeral-session.html [ Pass Timeout ]
 
-webkit.org/b/207552 http/tests/storageAccess/has-storage-access-false-by-default-ephemeral-database.html [ Pass Timeout ]
-
 webkit.org/b/190852 imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html [ Pass Failure ]
 
 webkit.org/b/209514 http/tests/cache-storage/page-cache-domcache-pending-promise.html [ Pass Timeout DumpJSConsoleLogInStdErr ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262419] trunk/LayoutTests

2020-06-02 Thread lmoura

Title: [262419] trunk/LayoutTests








Revision 262419
Author lmo...@igalia.com
Date 2020-06-02 07:19:29 -0700 (Tue, 02 Jun 2020)


Log Message
[GLIB] Update TestExpectations Sections
https://bugs.webkit.org/show_bug.cgi?id=212586

Initial conversion from the "kind of failure" to the "feature" based
approach to organizing the glib test expectations.

This is an attempt to group related expectations closer together. At
the time of this patch, some sections are only related to the top
folder at LayoutTests, like WebAnimations, but others have entries
from multiple folders, like GStreamer, WebGL. More specific features
like EncryptedMedia will likely have their own sections even though it
could be seen as a subset of GStreamer.

In doubt, there is a NEEDS TRIAGING section at the end of the file
where one can put the failure if not sure about which existing section
it should go and ask for a more detailed investigation.

Reviewed by Carlos Alberto Lopez Perez.

* platform/glib/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (262418 => 262419)

--- trunk/LayoutTests/ChangeLog	2020-06-02 14:17:03 UTC (rev 262418)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 14:19:29 UTC (rev 262419)
@@ -1,3 +1,26 @@
+2020-06-02  Lauro Moura  
+
+[GLIB] Update TestExpectations Sections
+https://bugs.webkit.org/show_bug.cgi?id=212586
+
+Initial conversion from the "kind of failure" to the "feature" based
+approach to organizing the glib test expectations.
+
+This is an attempt to group related expectations closer together. At
+the time of this patch, some sections are only related to the top
+folder at LayoutTests, like WebAnimations, but others have entries
+from multiple folders, like GStreamer, WebGL. More specific features
+like EncryptedMedia will likely have their own sections even though it
+could be seen as a subset of GStreamer.
+
+In doubt, there is a NEEDS TRIAGING section at the end of the file
+where one can put the failure if not sure about which existing section
+it should go and ask for a more detailed investigation.
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+* platform/glib/TestExpectations:
+
 2020-06-01  Sergio Villar Senin  
 
 [css-flexbox] ChildIntrinsicLogicalWidth should use fit-content, not max-content


Modified: trunk/LayoutTests/platform/glib/TestExpectations (262418 => 262419)

--- trunk/LayoutTests/platform/glib/TestExpectations	2020-06-02 14:17:03 UTC (rev 262418)
+++ trunk/LayoutTests/platform/glib/TestExpectations	2020-06-02 14:19:29 UTC (rev 262419)
@@ -9,164 +9,124 @@
 # See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 #
 # Never add any tests to this file without opening a bug on bugzilla.webkit.org.
-
-#//
-# Platform-specific directories.
-#//
-
-#//
-# End platform-specific directories.
-#//
-
-# This list is divided into several sections to make it easy for us to triage and close issues.
-# 1. TESTS THAT REQUIRE NEW RESULTS
-# Please don't add any tests to this list. Instead just ping a WebKitGTK/WPE developer
-# to generate results for you.
 #
-# 2. EXPECTED FAILURES
-# This list is divided into two parts:
-# a. Tests that we never expect to pass, because they use features we likely
-#will never implement (Mac-only features, for instance).
-# b. Missing WebCore/WebKit features that we'll want someday.
+# Currently the following sections are used, but this is not a fixed list. Some sections
+# (like WebAnimation, PageOverlay, WebGL) will mirror their top-level LayoutTests/
+# folders, but others like CSS and GStreamer may have entries from multiple folders.
 #
-# 3. TESTS CRASHING
-# Please open a bug for each test crashing with any important information.
-# These are in a separate section than failing tests, because they should be
-# priority fixes.
+# * CSS
+# * GStreamer
+# * Perf
+# * WebGL
+# * WebAnimations
+# * WPT
+# * PASSING tests
+#   * Usually to override tests skipped/failing by Mac ports.
+# * UNSUPPORTED tests
+#   * Things we do not test. (i.e. Skipped)
+# * NEEDS TRIAGING
+#   * If you are not sure where an expectation should go, put it here and ask for proper
+# triaging in the associated bug.
 #
-# 4. FLAKY TESTS
-# Tests that sometimes pass.
+# Important rules when creating new sections:
 #
-# 5. SLOW TESTS
-# These tests are assigned the SLOW modifier to prevent them timing out as they
-# otherwise pass, but take a long time to complete due to

[webkit-changes] [262418] trunk/Source/WebCore

Title: [262418] trunk/Source/WebCore








Revision 262418
Author mark@apple.com
Date 2020-06-02 07:17:03 -0700 (Tue, 02 Jun 2020)


Log Message
Fix broken Windows build.
https://bugs.webkit.org/show_bug.cgi?id=212633

Reviewed by Yusuke Suzuki.

* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::needsPreparationForDisplay):
(WebCore::HTMLCanvasElement::prepareForDisplay):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLCanvasElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (262417 => 262418)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 13:49:05 UTC (rev 262417)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 14:17:03 UTC (rev 262418)
@@ -1,3 +1,14 @@
+2020-06-02  Mark Lam  
+
+Fix broken Windows build.
+https://bugs.webkit.org/show_bug.cgi?id=212633
+
+Reviewed by Yusuke Suzuki.
+
+* html/HTMLCanvasElement.cpp:
+(WebCore::HTMLCanvasElement::needsPreparationForDisplay):
+(WebCore::HTMLCanvasElement::prepareForDisplay):
+
 2020-06-02  Youenn Fablet  
 
 Add some logging to ServiceWorkerThread to track install/activate event handling


Modified: trunk/Source/WebCore/html/HTMLCanvasElement.cpp (262417 => 262418)

--- trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2020-06-02 13:49:05 UTC (rev 262417)
+++ trunk/Source/WebCore/html/HTMLCanvasElement.cpp	2020-06-02 14:17:03 UTC (rev 262418)
@@ -1017,15 +1017,21 @@
 
 bool HTMLCanvasElement::needsPreparationForDisplay()
 {
+#if ENABLE(WEBGL)
 return is(m_context.get());
+#else
+return false;
+#endif
 }
 
 void HTMLCanvasElement::prepareForDisplay()
 {
+#if ENABLE(WEBGL)
 ASSERT(needsPreparationForDisplay());
 
 if (is(m_context.get()))
 downcast(m_context.get())->prepareForDisplay();
+#endif
 }
 
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262417] trunk/Tools

2020-06-02 Thread dpino

Title: [262417] trunk/Tools








Revision 262417
Author dp...@igalia.com
Date 2020-06-02 06:49:05 -0700 (Tue, 02 Jun 2020)


Log Message
[buildbot] [GTK][WPE] Move _javascript_ related tests to own bot
https://bugs.webkit.org/show_bug.cgi?id=212481

Reviewed by Carlos Alberto Lopez Perez.

Currently GTK and WPE tests bots run too many tests. This makes
the total running time for each build very long.

This patch moves _javascript_ related tests (jscore-test and
test262-test) to a separated bot which will be triggered by the
corresponding build bot of each platform.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/factories.py:
(TestFactory.__init__):
(TestJSFactory):
(TestJSFactory.__init__):
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (262416 => 262417)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2020-06-02 13:39:50 UTC (rev 262416)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2020-06-02 13:49:05 UTC (rev 262417)
@@ -77,6 +77,9 @@
 { "name": "gtk-linux-slave-9", "platform": "gtk" },
 { "name": "gtk-linux-slave-10", "platform": "gtk" },
 { "name": "gtk-linux-slave-11", "platform": "gtk" },
+{ "name": "gtk-linux-bot-12", "platform": "gtk" },
+{ "name": "gtk-linux-bot-13", "platform": "gtk" },
+{ "name": "gtk-linux-bot-14", "platform": "gtk" },
 
 { "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
 { "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
@@ -87,7 +90,9 @@
 { "name": "wpe-linux-bot-1", "platform": "wpe" },
 { "name": "wpe-linux-bot-2", "platform": "wpe" },
 { "name": "wpe-linux-bot-3", "platform": "wpe" },
-{ "name": "wpe-linux-bot-4", "platform": "wpe" }
+{ "name": "wpe-linux-bot-4", "platform": "wpe" },
+{ "name": "wpe-linux-bot-5", "platform": "wpe" },
+{ "name": "wpe-linux-bot-6", "platform": "wpe" }
   ],
 
 "builders":   [ 
@@ -252,26 +257,37 @@
 {
   "name": "GTK Linux 64-bit Release (Build)", "type": "BuildAndGenerateJSCBundle", "builddir": "gtk-linux-64-release",
   "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
-  "triggers": ["gtk-linux-64-release-tests", "gtk-linux-64-release-wayland-tests", "gtk-linux-64-release-perf-tests"],
+  "triggers": ["gtk-linux-64-release-tests", "gtk-linux-64-release-tests-js",
+   "gtk-linux-64-release-wayland-tests", "gtk-linux-64-release-perf-tests"],
   "slavenames": ["gtk-linux-slave-2"]
 },
 {
-  "name": "GTK Linux 64-bit Release (Tests)", "type": "Test", "builddir": "gtk-linux-64-release-tests",
+  "name": "GTK Linux 64-bit Release (Tests)", "type": "TestAllButJSC", "builddir": "gtk-linux-64-release-tests",
   "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
   "slavenames": ["gtk-linux-slave-6"]
 },
 {
+  "name": "GTK Linux 64-bit Release (Tests JS)", "type": "TestJS", "builddir": "gtk-linux-64-release-tests-js",
+  "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+  "slavenames": ["gtk-linux-bot-12"]
+},
+{
   "name": "GTK Linux 64-bit Debug (Build)", "type": "Build", "builddir": "gtk-linux-64-debug",
   "platform": "gtk", "configuration": "debug", "architectures": ["x86_64"],
-  "triggers": ["gtk-linux-64-debug-tests"],
+  "triggers": ["gtk-linux-64-debug-tests", "gtk-linux-64-debug-tests-js"],
   "slavenames": ["gtk-linux-slave-3"]
 },
 {
-  "name": "GTK Linux 64-bit Debug (Tests)", "type": "Test", "builddir": "gtk-linux-64-debug-tests",
+  "name": "GTK Linux 64-bit Debug (Tests)", "type": "TestAllButJSC", "builddir": "gtk-linux-64-debug-tests",
   "platform": "gtk", "configuration": "debug", "architectures": ["x86_64"],
   "slavenames": ["gtk-linux-slave-7

[webkit-changes] [262416] trunk/Source/WebCore

Title: [262416] trunk/Source/WebCore








Revision 262416
Author you...@apple.com
Date 2020-06-02 06:39:50 -0700 (Tue, 02 Jun 2020)


Log Message
Add some logging to ServiceWorkerThread to track install/activate event handling
https://bugs.webkit.org/show_bug.cgi?id=212523

Reviewed by Chris Dumez.

Add some logging for firing install/activate events and when these events are handled.
No change of behavior.

* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToFireInstallEvent):
(WebCore::ServiceWorkerThread::queueTaskToFireActivateEvent):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (262415 => 262416)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 13:06:35 UTC (rev 262415)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 13:39:50 UTC (rev 262416)
@@ -1,3 +1,17 @@
+2020-06-02  Youenn Fablet  
+
+Add some logging to ServiceWorkerThread to track install/activate event handling
+https://bugs.webkit.org/show_bug.cgi?id=212523
+
+Reviewed by Chris Dumez.
+
+Add some logging for firing install/activate events and when these events are handled.
+No change of behavior.
+
+* workers/service/context/ServiceWorkerThread.cpp:
+(WebCore::ServiceWorkerThread::queueTaskToFireInstallEvent):
+(WebCore::ServiceWorkerThread::queueTaskToFireActivateEvent):
+
 2020-06-02  Carlos Garcia Campos  
 
 [GTK4] Make popup menus work


Modified: trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp (262415 => 262416)

--- trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp	2020-06-02 13:06:35 UTC (rev 262415)
+++ trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp	2020-06-02 13:39:50 UTC (rev 262416)
@@ -146,6 +146,8 @@
 {
 auto serviceWorkerGlobalScope = makeRef(downcast(*workerGlobalScope()));
 serviceWorkerGlobalScope->eventLoop().queueTask(TaskSource::DOMManipulation, [weakThis = makeWeakPtr(this), serviceWorkerGlobalScope = serviceWorkerGlobalScope.copyRef()]() mutable {
+RELEASE_LOG(ServiceWorker, "ServiceWorkerThread::queueTaskToFireInstallEvent firing event for worker %llu", serviceWorkerGlobalScope->thread().identifier().toUInt64());
+
 auto installEvent = ExtendableEvent::create(eventNames().installEvent, { }, ExtendableEvent::IsTrusted::Yes);
 serviceWorkerGlobalScope->dispatchEvent(installEvent);
 
@@ -158,6 +160,7 @@
 }
 }
 callOnMainThread([weakThis = WTFMove(weakThis), hasRejectedAnyPromise] {
+RELEASE_LOG(ServiceWorker, "ServiceWorkerThread::queueTaskToFireInstallEvent finishing for worker %llu", weakThis ? weakThis->identifier().toUInt64() : 0);
 if (weakThis)
 weakThis->finishedFiringInstallEvent(hasRejectedAnyPromise);
 });
@@ -169,11 +172,14 @@
 {
 auto serviceWorkerGlobalScope = makeRef(downcast(*workerGlobalScope()));
 serviceWorkerGlobalScope->eventLoop().queueTask(TaskSource::DOMManipulation, [weakThis = makeWeakPtr(this), serviceWorkerGlobalScope = serviceWorkerGlobalScope.copyRef()]() mutable {
+RELEASE_LOG(ServiceWorker, "ServiceWorkerThread::queueTaskToFireActivateEvent firing event for worker %llu", serviceWorkerGlobalScope->thread().identifier().toUInt64());
+
 auto activateEvent = ExtendableEvent::create(eventNames().activateEvent, { }, ExtendableEvent::IsTrusted::Yes);
 serviceWorkerGlobalScope->dispatchEvent(activateEvent);
 
 activateEvent->whenAllExtendLifetimePromisesAreSettled([weakThis = WTFMove(weakThis)](auto&&) mutable {
 callOnMainThread([weakThis = WTFMove(weakThis)] {
+RELEASE_LOG(ServiceWorker, "ServiceWorkerThread::queueTaskToFireActivateEvent finishing for worker %llu", weakThis ? weakThis->identifier().toUInt64() : 0);
 if (weakThis)
 weakThis->finishedFiringActivateEvent();
 });






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262415] trunk/Source/WebKit

2020-06-02 Thread carlosgc

Title: [262415] trunk/Source/WebKit








Revision 262415
Author carlo...@webkit.org
Date 2020-06-02 06:06:35 -0700 (Tue, 02 Jun 2020)


Log Message
[GTK4] Implement data list drop down menu
https://bugs.webkit.org/show_bug.cgi?id=212333

Reviewed by Adrian Perez de Castro.

Use a GtkPopover for GTK4 instead of a GtkMenu.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createDataListSuggestionsDropdown):
* UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:
(WebKit::WebDataListSuggestionsDropdownGtk::WebDataListSuggestionsDropdownGtk):
(WebKit::WebDataListSuggestionsDropdownGtk::~WebDataListSuggestionsDropdownGtk):
(WebKit::WebDataListSuggestionsDropdownGtk::show):
* UIProcess/gtk/WebDataListSuggestionsDropdownGtk.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp
trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (262414 => 262415)

--- trunk/Source/WebKit/ChangeLog	2020-06-02 13:04:55 UTC (rev 262414)
+++ trunk/Source/WebKit/ChangeLog	2020-06-02 13:06:35 UTC (rev 262415)
@@ -1,5 +1,22 @@
 2020-06-02  Carlos Garcia Campos  
 
+[GTK4] Implement data list drop down menu
+https://bugs.webkit.org/show_bug.cgi?id=212333
+
+Reviewed by Adrian Perez de Castro.
+
+Use a GtkPopover for GTK4 instead of a GtkMenu.
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::createDataListSuggestionsDropdown):
+* UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp:
+(WebKit::WebDataListSuggestionsDropdownGtk::WebDataListSuggestionsDropdownGtk):
+(WebKit::WebDataListSuggestionsDropdownGtk::~WebDataListSuggestionsDropdownGtk):
+(WebKit::WebDataListSuggestionsDropdownGtk::show):
+* UIProcess/gtk/WebDataListSuggestionsDropdownGtk.h:
+
+2020-06-02  Carlos Garcia Campos  
+
 [GTK4] Make popup menus work
 https://bugs.webkit.org/show_bug.cgi?id=211178
 


Modified: trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp (262414 => 262415)

--- trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2020-06-02 13:04:55 UTC (rev 262414)
+++ trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp	2020-06-02 13:06:35 UTC (rev 262415)
@@ -273,11 +273,7 @@
 #if ENABLE(DATALIST_ELEMENT)
 RefPtr PageClientImpl::createDataListSuggestionsDropdown(WebPageProxy& page)
 {
-#if USE(GTK4)
-return nullptr;
-#else
 return WebDataListSuggestionsDropdownGtk::create(m_viewWidget, page);
-#endif
 }
 #endif
 


Modified: trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp (262414 => 262415)

--- trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp	2020-06-02 13:04:55 UTC (rev 262414)
+++ trunk/Source/WebKit/UIProcess/gtk/WebDataListSuggestionsDropdownGtk.cpp	2020-06-02 13:06:35 UTC (rev 262415)
@@ -26,7 +26,7 @@
 #include "config.h"
 #include "WebDataListSuggestionsDropdownGtk.h"
 
-#if ENABLE(DATALIST_ELEMENT) && !USE(GTK4)
+#if ENABLE(DATALIST_ELEMENT)
 
 #include "WebPageProxy.h"
 #include 
@@ -65,10 +65,22 @@
 
 auto* swindow = gtk_scrolled_window_new(nullptr, nullptr);
 gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(swindow), GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
+#if USE(GTK4)
+gtk_scrolled_window_set_child(GTK_SCROLLED_WINDOW(swindow), m_treeView);
+#else
 gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW(swindow), GTK_SHADOW_ETCHED_IN);
 gtk_container_add(GTK_CONTAINER(swindow), m_treeView);
 gtk_widget_show(m_treeView);
+#endif
 
+#if USE(GTK4)
+m_popup = gtk_popover_new();
+gtk_popover_set_has_arrow(GTK_POPOVER(m_popup), FALSE);
+gtk_popover_set_autohide(GTK_POPOVER(m_popup), FALSE);
+gtk_popover_set_position(GTK_POPOVER(m_popup), GTK_POS_BOTTOM);
+gtk_popover_set_child(GTK_POPOVER(m_popup), swindow);
+gtk_widget_set_parent(m_popup, m_webView);
+#else
 m_popup = gtk_window_new(GTK_WINDOW_POPUP);
 gtk_window_set_type_hint(GTK_WINDOW(m_popup), GDK_WINDOW_TYPE_HINT_COMBO);
 gtk_window_set_resizable(GTK_WINDOW(m_popup), FALSE);
@@ -77,6 +89,7 @@
 
 g_signal_connect_object(m_webView, "focus-out-event", G_CALLBACK(gtk_widget_hide), m_popup, G_CONNECT_SWAPPED);
 g_signal_connect_object(m_webView, "unmap-event", G_CALLBACK(gtk_widget_hide), m_popup, G_CONNECT_SWAPPED);
+#endif
 
 #if ENABLE(DEVELOPER_MODE)
 g_object_set_data(G_OBJECT(m_webView), "wk-datalist-popup", m_popup);
@@ -85,12 +98,20 @@
 
 WebDataListSuggestionsDropdownGtk::~WebDataListSuggestionsDropdownGtk()
 {
+#if !USE(GTK4)
 gtk_window_set_transient_for(GTK_WINDOW(m_popup), nullptr);
 gtk_window_set_attached_to(GTK_WINDOW(m_popup), nullptr);
+#endif
+
 #if ENABLE(DEVELOPER_MODE)
 g_object_set_data(G_OBJECT(m_webView), "wk-datalist-popup", nullptr);
 #endif
+
+#if USE(GTK4)
+g_clear_pointer(&m_popup, gtk_widg

[webkit-changes] [262414] trunk

2020-06-02 Thread carlosgc

Title: [262414] trunk








Revision 262414
Author carlo...@webkit.org
Date 2020-06-02 06:04:55 -0700 (Tue, 02 Jun 2020)


Log Message
[GTK4] Make popup menus work
https://bugs.webkit.org/show_bug.cgi?id=211178

Reviewed by Adrian Perez de Castro.

Source/WebCore:

* platform/gtk/GtkVersioning.h:
(gtk_tree_view_column_cell_get_size):

Source/WebKit:

Use a GtkPopover for GTK4 instead of a GtkMenu.

* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createPopupMenuProxy):
* UIProcess/API/gtk/WebKitPopupMenu.cpp:
(WebKit::WebKitPopupMenu::WebKitPopupMenu):
(WebKit::menuCloseCallback):
(WebKit::WebKitPopupMenu::showPopupMenu):
(WebKit::WebKitPopupMenu::hidePopupMenu):
(WebKit::WebKitPopupMenu::cancelTracking):
(WebKit::WebKitPopupMenu::activateItem):
* UIProcess/API/gtk/WebKitPopupMenu.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSizeAllocate): Iterate children and call check_resize on every native one.
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::treeViewButtonReleaseEventCallback):
(WebKit::WebPopupMenuProxyGtk::createPopupMenu):
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
(WebKit::WebPopupMenuProxyGtk::hidePopupMenu):
(WebKit::WebPopupMenuProxyGtk::treeViewRowActivatedCallback): Deleted.
* UIProcess/gtk/WebPopupMenuProxyGtk.h:

Tools:

* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::dismissAllPopupMenus):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/GtkVersioning.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitPopupMenu.cpp
trunk/Source/WebKit/UIProcess/API/gtk/WebKitPopupMenu.h
trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp
trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.cpp
trunk/Source/WebKit/UIProcess/gtk/WebPopupMenuProxyGtk.h
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (262413 => 262414)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 12:52:16 UTC (rev 262413)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 13:04:55 UTC (rev 262414)
@@ -1,3 +1,13 @@
+2020-06-02  Carlos Garcia Campos  
+
+[GTK4] Make popup menus work
+https://bugs.webkit.org/show_bug.cgi?id=211178
+
+Reviewed by Adrian Perez de Castro.
+
+* platform/gtk/GtkVersioning.h:
+(gtk_tree_view_column_cell_get_size):
+
 2020-06-01  Sergio Villar Senin  
 
 [css-flexbox] ChildIntrinsicLogicalWidth should use fit-content, not max-content


Modified: trunk/Source/WebCore/platform/gtk/GtkVersioning.h (262413 => 262414)

--- trunk/Source/WebCore/platform/gtk/GtkVersioning.h	2020-06-02 12:52:16 UTC (rev 262413)
+++ trunk/Source/WebCore/platform/gtk/GtkVersioning.h	2020-06-02 13:04:55 UTC (rev 262414)
@@ -221,6 +221,12 @@
 return context.response;
 }
 
+static inline void
+gtk_tree_view_column_cell_get_size(GtkTreeViewColumn* column, const GdkRectangle*, gint* xOffset, gint* yOffset, gint* width, gint* height)
+{
+gtk_tree_view_column_cell_get_size(column, xOffset, yOffset, width, height);
+}
+
 #else // USE(GTK4)
 
 static inline void


Modified: trunk/Source/WebKit/ChangeLog (262413 => 262414)

--- trunk/Source/WebKit/ChangeLog	2020-06-02 12:52:16 UTC (rev 262413)
+++ trunk/Source/WebKit/ChangeLog	2020-06-02 13:04:55 UTC (rev 262414)
@@ -1,3 +1,32 @@
+2020-06-02  Carlos Garcia Campos  
+
+[GTK4] Make popup menus work
+https://bugs.webkit.org/show_bug.cgi?id=211178
+
+Reviewed by Adrian Perez de Castro.
+
+Use a GtkPopover for GTK4 instead of a GtkMenu.
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::createPopupMenuProxy):
+* UIProcess/API/gtk/WebKitPopupMenu.cpp:
+(WebKit::WebKitPopupMenu::WebKitPopupMenu):
+(WebKit::menuCloseCallback):
+(WebKit::WebKitPopupMenu::showPopupMenu):
+(WebKit::WebKitPopupMenu::hidePopupMenu):
+(WebKit::WebKitPopupMenu::cancelTracking):
+(WebKit::WebKitPopupMenu::activateItem):
+* UIProcess/API/gtk/WebKitPopupMenu.h:
+* UIProcess/API/gtk/WebKitWebViewBase.cpp:
+(webkitWebViewBaseSizeAllocate): Iterate children and call check_resize on every native one.
+* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
+(WebKit::WebPopupMenuProxyGtk::treeViewButtonReleaseEventCallback):
+(WebKit::WebPopupMenuProxyGtk::createPopupMenu):
+(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
+(WebKit::WebPopupMenuProxyGtk::hidePopupMenu):
+(WebKit::WebPopupMenuProxyGtk::treeViewRowActivatedCallback): Deleted.
+* UIProcess/gtk/WebPopupMenuProxyGtk.h:
+
 2020-06-01  Chris Dumez  
 
 Fix thread-safety issue in [WKProcessAssertionBackgroundTaskManager _handleBackgroundTaskExpiration]


Modified: trunk/Source/WebKit/UIProcess/API/gtk/PageClientImpl.cpp (262413 => 262414)

--- trunk/Source/

[webkit-changes] [262413] trunk/Tools

2020-06-02 Thread carlosgc

Title: [262413] trunk/Tools








Revision 262413
Author carlo...@webkit.org
Date 2020-06-02 05:52:16 -0700 (Tue, 02 Jun 2020)


Log Message
[GTK4] Make it possible to run layout tests
https://bugs.webkit.org/show_bug.cgi?id=212328

Reviewed by Carlos Alberto Lopez Perez.

Build WTR with GTK4.

* PlatformGTK.cmake:
* Scripts/webkitdirs.pm:
(builtDylibPathForName): Try with both 4 and 5 API versions.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::setWindowIsKey):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::addToWindow):
(WTR::PlatformWebView::removeFromWindow):
(WTR::PlatformWebView::windowSnapshotImage):
(WTR::PlatformWebView::dismissAllPopupMenus):
* WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
(WTR::UIScriptControllerGtk::copyText):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/PlatformGTK.cmake
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp
trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp
trunk/Tools/WebKitTestRunner/gtk/UIScriptControllerGtk.cpp




Diff

Modified: trunk/Tools/ChangeLog (262412 => 262413)

--- trunk/Tools/ChangeLog	2020-06-02 11:29:12 UTC (rev 262412)
+++ trunk/Tools/ChangeLog	2020-06-02 12:52:16 UTC (rev 262413)
@@ -1,3 +1,29 @@
+2020-06-02  Carlos Garcia Campos  
+
+[GTK4] Make it possible to run layout tests
+https://bugs.webkit.org/show_bug.cgi?id=212328
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Build WTR with GTK4.
+
+* PlatformGTK.cmake:
+* Scripts/webkitdirs.pm:
+(builtDylibPathForName): Try with both 4 and 5 API versions.
+* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+(WTR::PlatformWebView::PlatformWebView):
+(WTR::PlatformWebView::~PlatformWebView):
+(WTR::PlatformWebView::setWindowIsKey):
+(WTR::PlatformWebView::windowFrame):
+(WTR::PlatformWebView::setWindowFrame):
+(WTR::PlatformWebView::addToWindow):
+(WTR::PlatformWebView::removeFromWindow):
+(WTR::PlatformWebView::windowSnapshotImage):
+(WTR::PlatformWebView::dismissAllPopupMenus):
+* WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
+(WTR::UIScriptControllerGtk::copyText):
+
 2020-06-01  Noam Rosenthal  
 
 Make unicode-bidi:isolate the default for an element with a dir attribute (instead of unicode-bidi:embed)


Modified: trunk/Tools/PlatformGTK.cmake (262412 => 262413)

--- trunk/Tools/PlatformGTK.cmake	2020-06-02 11:29:12 UTC (rev 262412)
+++ trunk/Tools/PlatformGTK.cmake	2020-06-02 12:52:16 UTC (rev 262413)
@@ -1,8 +1,5 @@
 if (DEVELOPER_MODE)
-if (NOT USE_GTK4)
-add_subdirectory(WebKitTestRunner)
-endif ()
-
+add_subdirectory(WebKitTestRunner)
 add_subdirectory(ImageDiff)
 
 if (ENABLE_API_TESTS)


Modified: trunk/Tools/Scripts/webkitdirs.pm (262412 => 262413)

--- trunk/Tools/Scripts/webkitdirs.pm	2020-06-02 11:29:12 UTC (rev 262412)
+++ trunk/Tools/Scripts/webkitdirs.pm	2020-06-02 12:52:16 UTC (rev 262413)
@@ -1092,7 +1092,20 @@
 
 if (isGtk()) {
 my $extension = isDarwin() ? ".dylib" : ".so";
-return "$configurationProductDir/lib/libwebkit2gtk-4.0" . $extension;
+my @apiVersions = ("4.0", "5.0");
+for my $apiVersion (@apiVersions) {
+my $libraryPath;
+if ($libraryName eq "_javascript_Core") {
+$libraryPath = "$configurationProductDir/lib/libjavascriptcoregtk-$apiVersion$extension";
+} else {
+$libraryPath = "$configurationProductDir/lib/libwebkit2gtk-$apiVersion$extension";
+}
+if (-e $libraryPath) {
+return $libraryPath;
+}
+}
+
+return "";
 }
 if (isIOSWebKit()) {
 return "$configurationProductDir/$libraryName.framework/$libraryName";


Modified: trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (262412 => 262413)

--- trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp	2020-06-02 11:29:12 UTC (rev 262412)
+++ trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp	2020-06-02 12:52:16 UTC (rev 262413)
@@ -37,6 +37,7 @@
 #include "TestController.h"
 #include "WebKitWebViewBaseInternal.h"
 #include 
+#include 
 #include 
 #include 
 #include 


Modified: trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp (262412 => 262413)

--- trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp	2020-06-02 11:29:12 UTC (rev 262412)
+++ trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp	2020-06-02 12:52:16 UTC (rev 262413)
@@ -28,6 +28,7 @@
 #include "config.h"
 #include "PlatformWebView.h"
 
+#include 
 #include 
 #include 
 #include 
@@ -34,30 +35,46 @@
 #include 
 #include 
 #include 
+#include 
 
 namespa

[webkit-changes] [262412] trunk/Source/JavaScriptCore

2020-06-02 Thread pmatos

Title: [262412] trunk/Source/_javascript_Core








Revision 262412
Author pma...@igalia.com
Date 2020-06-02 04:29:12 -0700 (Tue, 02 Jun 2020)


Log Message
Fix assert message formatting
https://bugs.webkit.org/show_bug.cgi?id=212591

Reviewed by Adrian Perez de Castro.

Fixes warning by gcc - lineParts.size() is size_t, %zu should be used.

* runtime/FuzzerPredictions.cpp:
(JSC::FuzzerPredictions::FuzzerPredictions):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/FuzzerPredictions.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (262411 => 262412)

--- trunk/Source/_javascript_Core/ChangeLog	2020-06-02 11:28:30 UTC (rev 262411)
+++ trunk/Source/_javascript_Core/ChangeLog	2020-06-02 11:29:12 UTC (rev 262412)
@@ -1,3 +1,15 @@
+2020-06-02  Paulo Matos  
+
+Fix assert message formatting
+https://bugs.webkit.org/show_bug.cgi?id=212591
+
+Reviewed by Adrian Perez de Castro.
+
+Fixes warning by gcc - lineParts.size() is size_t, %zu should be used.
+
+* runtime/FuzzerPredictions.cpp:
+(JSC::FuzzerPredictions::FuzzerPredictions):
+
 2020-06-01  Devin Rousso  
 
 Web Inspector: Graphics: should use the `id` (name) of the animation if it exists


Modified: trunk/Source/_javascript_Core/runtime/FuzzerPredictions.cpp (262411 => 262412)

--- trunk/Source/_javascript_Core/runtime/FuzzerPredictions.cpp	2020-06-02 11:28:30 UTC (rev 262411)
+++ trunk/Source/_javascript_Core/runtime/FuzzerPredictions.cpp	2020-06-02 11:29:12 UTC (rev 262412)
@@ -72,7 +72,7 @@
 // FIXME: The current implementation only supports one prediction per lookup key.
 
 const Vector& lineParts = line.split(':');
-RELEASE_ASSERT_WITH_MESSAGE(lineParts.size() == 2, "Expected line with two parts delimited by a colon. Found line with %lu parts.", lineParts.size());
+RELEASE_ASSERT_WITH_MESSAGE(lineParts.size() == 2, "Expected line with two parts delimited by a colon. Found line with %zu parts.", lineParts.size());
 const String& lookupKey = lineParts[0];
 const String& predictionString = lineParts[1];
 bool ok;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [262411] trunk

2020-06-02 Thread svillar

Title: [262411] trunk








Revision 262411
Author svil...@igalia.com
Date 2020-06-02 04:28:30 -0700 (Tue, 02 Jun 2020)


Log Message
[css-flexbox] ChildIntrinsicLogicalWidth should use fit-content, not max-content
https://bugs.webkit.org/show_bug.cgi?id=210465

Reviewed by Javier Fernandez.

Source/WebCore:

When computing the hypothetical cross size of each item in the flexbox algorithm
the current code was using the max-size. However the specs state clearly that we
should use fit-content instead, i.e., the shrink-to-fit size.
See https://drafts.csswg.org/css-flexbox/#algo-cross-item.

Based on Blink's crrev.com/1327746 by 

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const): Use the shrink-to-fit
size instead just the max-size.

LayoutTests:

* TestExpectations: Unskipped flex-wrap-002.html which is now passing.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (262410 => 262411)

--- trunk/LayoutTests/ChangeLog	2020-06-02 11:24:19 UTC (rev 262410)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 11:28:30 UTC (rev 262411)
@@ -1,3 +1,12 @@
+2020-06-01  Sergio Villar Senin  
+
+[css-flexbox] ChildIntrinsicLogicalWidth should use fit-content, not max-content
+https://bugs.webkit.org/show_bug.cgi?id=210465
+
+Reviewed by Javier Fernandez.
+
+* TestExpectations: Unskipped flex-wrap-002.html which is now passing.
+
 2020-06-02  Youenn Fablet  
 
 [ Mac wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is flaky failing.


Modified: trunk/LayoutTests/TestExpectations (262410 => 262411)

--- trunk/LayoutTests/TestExpectations	2020-06-02 11:24:19 UTC (rev 262410)
+++ trunk/LayoutTests/TestExpectations	2020-06-02 11:28:30 UTC (rev 262411)
@@ -4243,7 +4243,6 @@
 webkit.org/b/210093 imported/w3c/web-platform-tests/css/css-flexbox/select-element-zero-height-001.html [ ImageOnlyFailure ]
 webkit.org/b/210093 imported/w3c/web-platform-tests/css/css-flexbox/select-element-zero-height-002.html [ ImageOnlyFailure ]
 webkit.org/b/210144 imported/w3c/web-platform-tests/css/css-flexbox/anonymous-flex-item-005.html [ ImageOnlyFailure ]
-webkit.org/b/210465 imported/w3c/web-platform-tests/css/css-flexbox/flex-wrap-002.html [ ImageOnlyFailure ]
 webkit.org/b/210475 imported/w3c/web-platform-tests/css/css-flexbox/image-items-flake-001.html [ ImageOnlyFailure ]
 webkit.org/b/210478 imported/w3c/web-platform-tests/css/css-flexbox/percentage-heights-006.html [ ImageOnlyFailure ]
 webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/flex-minimum-height-flex-items-005.xht [ ImageOnlyFailure ]


Modified: trunk/Source/WebCore/ChangeLog (262410 => 262411)

--- trunk/Source/WebCore/ChangeLog	2020-06-02 11:24:19 UTC (rev 262410)
+++ trunk/Source/WebCore/ChangeLog	2020-06-02 11:28:30 UTC (rev 262411)
@@ -1,3 +1,21 @@
+2020-06-01  Sergio Villar Senin  
+
+[css-flexbox] ChildIntrinsicLogicalWidth should use fit-content, not max-content
+https://bugs.webkit.org/show_bug.cgi?id=210465
+
+Reviewed by Javier Fernandez.
+
+When computing the hypothetical cross size of each item in the flexbox algorithm
+the current code was using the max-size. However the specs state clearly that we
+should use fit-content instead, i.e., the shrink-to-fit size.
+See https://drafts.csswg.org/css-flexbox/#algo-cross-item.
+
+Based on Blink's crrev.com/1327746 by 
+
+* rendering/RenderFlexibleBox.cpp:
+(WebCore::RenderFlexibleBox::childIntrinsicLogicalWidth const): Use the shrink-to-fit
+size instead just the max-size.
+
 2020-06-02  Youenn Fablet  
 
 MediaPlayerPrivateMediaStreamAVFObjC should enqueue samples in a background thread


Modified: trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp (262410 => 262411)

--- trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2020-06-02 11:24:19 UTC (rev 262410)
+++ trunk/Source/WebCore/rendering/RenderFlexibleBox.cpp	2020-06-02 11:28:30 UTC (rev 262411)
@@ -467,9 +467,10 @@
 // This should only be called if the logical width is the cross size
 ASSERT(hasOrthogonalFlow(child));
 // If our height is auto, make sure that our returned height is unaffected by
-// earlier layouts by returning the max preferred logical width
+// earlier layouts by returning the shrink-to-fit size.
 if (!crossAxisLengthIsDefinite(child, child.style().logicalWidth()))
-return child.maxPreferredLogicalWidth();
+return std::min(child.maxPreferredLogicalWidth(), std::max(child.minPreferredLogicalWidth(), contentLogicalWidth()));
+
 return child.logicalWidth();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-change

[webkit-changes] [262409] trunk

Title: [262409] trunk








Revision 262409
Author you...@apple.com
Date 2020-06-02 04:23:47 -0700 (Tue, 02 Jun 2020)


Log Message
[ Mac wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207515


Reviewed by Chris Dumez.

Source/WebCore:

When a service worker is terminated, we remove it from the map in SWContextManager.
Shortly after a new service worker may be added to the map.
In that case, previously, we were potentially trying to decrement the message count of the old service worker thread, which is confusing the new service worker thread.
Instead, use WeakPtr to decrement if the service worker thread is still valid.
Covered by existing tests.

* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::queueTaskToPostMessage):
(WebCore::ServiceWorkerThread::queueTaskToFireInstallEvent):
(WebCore::ServiceWorkerThread::queueTaskToFireActivateEvent):
(WebCore::ServiceWorkerThread::start):
* workers/service/context/ServiceWorkerThread.h:

LayoutTests:

* http/wpt/service-workers/service-worker-spinning-fetch.https.html:
In case service worker gets closed, fetch failure might be logged as console log message.
* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-fetch.https.html
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp
trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.h




Diff

Modified: trunk/LayoutTests/ChangeLog (262408 => 262409)

--- trunk/LayoutTests/ChangeLog	2020-06-02 07:44:47 UTC (rev 262408)
+++ trunk/LayoutTests/ChangeLog	2020-06-02 11:23:47 UTC (rev 262409)
@@ -1,3 +1,15 @@
+2020-06-02  Youenn Fablet  
+
+[ Mac wk2 ] http/wpt/service-workers/service-worker-spinning-fetch.https.html is flaky failing.
+https://bugs.webkit.org/show_bug.cgi?id=207515
+
+
+Reviewed by Chris Dumez.
+
+* http/wpt/service-workers/service-worker-spinning-fetch.https.html:
+In case service worker gets closed, fetch failure might be logged as console log message.
+* platform/mac-wk2/TestExpectations:
+
 2020-06-01  Myles C. Maxfield  
 
 [WebGPU] Update texture creation validation according to the discussion at https://github.com/gpuweb/gpuweb/pull/799/files


Modified: trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-fetch.https.html (262408 => 262409)

--- trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-fetch.https.html	2020-06-02 07:44:47 UTC (rev 262408)
+++ trunk/LayoutTests/http/wpt/service-workers/service-worker-spinning-fetch.https.html	2020-06-02 11:23:47 UTC (rev 262409)
@@ -1,4 +1,4 @@
-
+

[webkit-changes] [262410] trunk/Source/WebCore