[webkit-changes] [280754] trunk/Source/WebKit
Title: [280754] trunk/Source/WebKit
Revision 280754
Author simon.fra...@apple.com
Date 2021-08-06 21:29:52 -0700 (Fri, 06 Aug 2021)
Log Message
Clarify some identifier naming in RemoteRenderingBackend
https://bugs.webkit.org/show_bug.cgi?id=228886
Reviewed by Said Abou-Hallawa.
Rename some "identifier" variables to differentiate between resource identifiers and
item buffer identifiers.
No behavior change.
* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::createImageBuffer):
(WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):
(WebKit::RemoteRenderingBackend::cacheNativeImage):
(WebKit::RemoteRenderingBackend::cacheFont):
(WebKit::RemoteRenderingBackend::didCreateSharedDisplayListHandle):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (280753 => 280754)
--- trunk/Source/WebKit/ChangeLog 2021-08-07 04:29:10 UTC (rev 280753)
+++ trunk/Source/WebKit/ChangeLog 2021-08-07 04:29:52 UTC (rev 280754)
@@ -1,5 +1,24 @@
2021-08-06 Simon Fraser
+Clarify some identifier naming in RemoteRenderingBackend
+https://bugs.webkit.org/show_bug.cgi?id=228886
+
+Reviewed by Said Abou-Hallawa.
+
+Rename some "identifier" variables to differentiate between resource identifiers and
+item buffer identifiers.
+
+No behavior change.
+
+* GPUProcess/graphics/RemoteRenderingBackend.cpp:
+(WebKit::RemoteRenderingBackend::createImageBuffer):
+(WebKit::RemoteRenderingBackend::wakeUpAndApplyDisplayList):
+(WebKit::RemoteRenderingBackend::cacheNativeImage):
+(WebKit::RemoteRenderingBackend::cacheFont):
+(WebKit::RemoteRenderingBackend::didCreateSharedDisplayListHandle):
+
+2021-08-06 Simon Fraser
+
Page on mhlw.go.jp triggers WebContent termination by GPU process
https://bugs.webkit.org/show_bug.cgi?id=228885
Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (280753 => 280754)
--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-08-07 04:29:10 UTC (rev 280753)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-08-07 04:29:52 UTC (rev 280754)
@@ -152,7 +152,7 @@
send(Messages::RemoteRenderingBackendProxy::DidFlush(flushIdentifier, renderingResourceIdentifier), m_renderingBackendIdentifier);
}
-void RemoteRenderingBackend::createImageBuffer(const FloatSize& logicalSize, RenderingMode renderingMode, float resolutionScale, const DestinationColorSpace& colorSpace, PixelFormat pixelFormat, RenderingResourceIdentifier renderingResourceIdentifier)
+void RemoteRenderingBackend::createImageBuffer(const FloatSize& logicalSize, RenderingMode renderingMode, float resolutionScale, const DestinationColorSpace& colorSpace, PixelFormat pixelFormat, RenderingResourceIdentifier imageBufferResourceIdentifier)
{
ASSERT(!RunLoop::isMain());
ASSERT(renderingMode == RenderingMode::Accelerated || renderingMode == RenderingMode::Unaccelerated);
@@ -160,7 +160,7 @@
RefPtr imageBuffer;
if (renderingMode == RenderingMode::Accelerated) {
-if (auto acceleratedImageBuffer = AcceleratedRemoteImageBuffer::create(logicalSize, resolutionScale, colorSpace, pixelFormat, *this, renderingResourceIdentifier)) {
+if (auto acceleratedImageBuffer = AcceleratedRemoteImageBuffer::create(logicalSize, resolutionScale, colorSpace, pixelFormat, *this, imageBufferResourceIdentifier)) {
#if HAVE(IOSURFACE_SET_OWNERSHIP_IDENTITY)
// Mark the IOSurface as being owned by the WebProcess even though it was constructed by the GPUProcess so that Jetsam knows which process to kill.
acceleratedImageBuffer->setProcessOwnership(m_gpuConnectionToWebProcess->webProcessIdentityToken());
@@ -170,7 +170,7 @@
}
if (!imageBuffer)
-imageBuffer = UnacceleratedRemoteImageBuffer::create(logicalSize, resolutionScale, colorSpace, pixelFormat, *this, renderingResourceIdentifier);
+imageBuffer = UnacceleratedRemoteImageBuffer::create(logicalSize, resolutionScale, colorSpace, pixelFormat, *this, imageBufferResourceIdentifier);
if (!imageBuffer) {
ASSERT_NOT_REACHED();
@@ -180,7 +180,7 @@
m_remoteResourceCache.cacheImageBuffer(makeRef(*imageBuffer));
updateRenderingResourceRequest();
-if (m_pendingWakeupInfo && m_pendingWakeupInfo->shouldPerformWakeup(renderingResourceIdentifier))
+if (m_pendingWakeupInfo && m_pendingWakeupInfo->shouldPerformWakeup(imageBufferResourceIdentifier))
wakeUpAndApplyDisplayList(std::exchange(m_pendingWakeupInfo, std::nullopt)->arguments);
}
@@ -338,6 +338,7 @@
LOG_WITH_STREAM(SharedDisplayLists, stream << "Waking up to Items[" << arguments.itemBufferIdentifier << "] => Image(" << arguments.destinationImageBufferIdentifier << ") at " << arguments.offset);
[webkit-changes] [280753] trunk/Source/WebKit
Title: [280753] trunk/Source/WebKit
Revision 280753
Author simon.fra...@apple.com
Date 2021-08-06 21:29:10 -0700 (Fri, 06 Aug 2021)
Log Message
Page on mhlw.go.jp triggers WebContent termination by GPU process
https://bugs.webkit.org/show_bug.cgi?id=228885
Reviewed by Wenson Hsieh.
https://www.mhlw.go.jp/stf/seisakunitsuite/bunya/164708_1.html triggered an issue
where RemoteRenderingBackend::finalizeRenderingUpdate() would be called when the
GPU process had just processed a "switching to next item buffer" meta command,
but had not yet received the new item buffer. This triggered the
MESSAGE_CHECK(initialHandle, "Missing initial shared display list handle");
in RemoteRenderingBackend::wakeUpAndApplyDisplayList().
Protect against this by having finalizeRenderingUpdate() check that
arguments.itemBufferIdentifier had been received, which is similar to what happens
inside the loop in wakeUpAndApplyDisplayList() already.
Not easily testable.
* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::finalizeRenderingUpdate):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (280752 => 280753)
--- trunk/Source/WebKit/ChangeLog 2021-08-07 02:04:18 UTC (rev 280752)
+++ trunk/Source/WebKit/ChangeLog 2021-08-07 04:29:10 UTC (rev 280753)
@@ -1,3 +1,27 @@
+2021-08-06 Simon Fraser
+
+Page on mhlw.go.jp triggers WebContent termination by GPU process
+https://bugs.webkit.org/show_bug.cgi?id=228885
+
+
+Reviewed by Wenson Hsieh.
+
+https://www.mhlw.go.jp/stf/seisakunitsuite/bunya/164708_1.html triggered an issue
+where RemoteRenderingBackend::finalizeRenderingUpdate() would be called when the
+GPU process had just processed a "switching to next item buffer" meta command,
+but had not yet received the new item buffer. This triggered the
+MESSAGE_CHECK(initialHandle, "Missing initial shared display list handle");
+in RemoteRenderingBackend::wakeUpAndApplyDisplayList().
+
+Protect against this by having finalizeRenderingUpdate() check that
+arguments.itemBufferIdentifier had been received, which is similar to what happens
+inside the loop in wakeUpAndApplyDisplayList() already.
+
+Not easily testable.
+
+* GPUProcess/graphics/RemoteRenderingBackend.cpp:
+(WebKit::RemoteRenderingBackend::finalizeRenderingUpdate):
+
2021-08-06 Tim Horton
Disable WKHoverPlatter for now
Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (280752 => 280753)
--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-08-07 02:04:18 UTC (rev 280752)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-08-07 04:29:10 UTC (rev 280753)
@@ -521,8 +521,13 @@
void RemoteRenderingBackend::finalizeRenderingUpdate(RenderingUpdateID renderingUpdateID)
{
-if (m_pendingWakeupInfo && m_remoteResourceCache.cachedImageBuffer(m_pendingWakeupInfo->arguments.destinationImageBufferIdentifier))
+auto shouldPerformWakeup = [&](const GPUProcessWakeupMessageArguments& arguments) {
+return m_remoteResourceCache.cachedImageBuffer(arguments.destinationImageBufferIdentifier) && m_sharedDisplayListHandles.contains(arguments.itemBufferIdentifier);
+};
+
+if (m_pendingWakeupInfo && shouldPerformWakeup(m_pendingWakeupInfo->arguments))
wakeUpAndApplyDisplayList(std::exchange(m_pendingWakeupInfo, std::nullopt)->arguments);
+
send(Messages::RemoteRenderingBackendProxy::DidFinalizeRenderingUpdate(renderingUpdateID), m_renderingBackendIdentifier);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280752] trunk/Source/WebKit
Title: [280752] trunk/Source/WebKit Revision 280752 Author timothy_hor...@apple.com Date 2021-08-06 19:04:18 -0700 (Fri, 06 Aug 2021) Log Message Disable WKHoverPlatter for now https://bugs.webkit.org/show_bug.cgi?id=228880 Reviewed by Wenson Hsieh. * UIProcess/ios/WKHoverPlatterParameters.mm: (-[WKHoverPlatterParameters setDefaultValues]): Flip the switch. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm Diff Modified: trunk/Source/WebKit/ChangeLog (280751 => 280752) --- trunk/Source/WebKit/ChangeLog 2021-08-07 01:39:53 UTC (rev 280751) +++ trunk/Source/WebKit/ChangeLog 2021-08-07 02:04:18 UTC (rev 280752) @@ -1,5 +1,16 @@ 2021-08-06 Tim Horton +Disable WKHoverPlatter for now +https://bugs.webkit.org/show_bug.cgi?id=228880 + +Reviewed by Wenson Hsieh. + +* UIProcess/ios/WKHoverPlatterParameters.mm: +(-[WKHoverPlatterParameters setDefaultValues]): +Flip the switch. + +2021-08-06 Tim Horton + REGRESSION (r185111): Links to App Store doesn't work when opening a PDF in Safari on iOS and iPadOS https://bugs.webkit.org/show_bug.cgi?id=228881 rdar://81294035 Modified: trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm (280751 => 280752) --- trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm 2021-08-07 01:39:53 UTC (rev 280751) +++ trunk/Source/WebKit/UIProcess/ios/WKHoverPlatterParameters.mm 2021-08-07 02:04:18 UTC (rev 280752) @@ -61,7 +61,7 @@ [super setDefaultValues]; _platterEnabledForMouse = NO; -_platterEnabledForHover = YES; +_platterEnabledForHover = NO; _platterCornerRadius = 6; _platterPadding = 5; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280751] trunk/Source/WebKit
Title: [280751] trunk/Source/WebKit
Revision 280751
Author timothy_hor...@apple.com
Date 2021-08-06 18:39:53 -0700 (Fri, 06 Aug 2021)
Log Message
REGRESSION (r185111): Links to App Store doesn't work when opening a PDF in Safari on iOS and iPadOS
https://bugs.webkit.org/show_bug.cgi?id=228881
rdar://81294035
Reviewed by Andy Estes.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
Clicking a link in PDF should absolutely be allowed to launch an external app.
Humorously, r185111 applied the correct value to PDFPlugin (macOS), but the
wrong value to WKPDFView (iOS). Bring them into alignment.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (280750 => 280751)
--- trunk/Source/WebKit/ChangeLog 2021-08-07 01:33:03 UTC (rev 280750)
+++ trunk/Source/WebKit/ChangeLog 2021-08-07 01:39:53 UTC (rev 280751)
@@ -1,3 +1,17 @@
+2021-08-06 Tim Horton
+
+REGRESSION (r185111): Links to App Store doesn't work when opening a PDF in Safari on iOS and iPadOS
+https://bugs.webkit.org/show_bug.cgi?id=228881
+rdar://81294035
+
+Reviewed by Andy Estes.
+
+* WebProcess/WebPage/WebPage.cpp:
+(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
+Clicking a link in PDF should absolutely be allowed to launch an external app.
+Humorously, r185111 applied the correct value to PDFPlugin (macOS), but the
+wrong value to WKPDFView (iOS). Bring them into alignment.
+
2021-08-06 Fujii Hironori
ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader()
Modified: trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp (280750 => 280751)
--- trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-08-07 01:33:03 UTC (rev 280750)
+++ trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp 2021-08-07 01:39:53 UTC (rev 280751)
@@ -1802,7 +1802,7 @@
auto mouseEvent = MouseEvent::create(eventNames().clickEvent, Event::CanBubble::Yes, Event::IsCancelable::Yes, Event::IsComposed::Yes,
MonotonicTime::now(), nullptr, singleClick, screenPoint, documentPoint, { }, { }, 0, 0, nullptr, 0, WebCore::NoTap);
-mainFrame->loader().changeLocation(mainFrameDocument->completeURL(url), emptyString(), mouseEvent.ptr(), ReferrerPolicy::NoReferrer, ShouldOpenExternalURLsPolicy::ShouldNotAllow);
+mainFrame->loader().changeLocation(mainFrameDocument->completeURL(url), emptyString(), mouseEvent.ptr(), ReferrerPolicy::NoReferrer, ShouldOpenExternalURLsPolicy::ShouldAllow);
}
void WebPage::stopLoadingFrame(FrameIdentifier frameID)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280750] branches/safari-612.1.27.0-branch/Source
Title: [280750] branches/safari-612.1.27.0-branch/Source Revision 280750 Author alanc...@apple.com Date 2021-08-06 18:33:03 -0700 (Fri, 06 Aug 2021) Log Message Versioning. WebKit-7612.1.27.0.3 Modified Paths branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.27.0-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.27.0-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig (280749 => 280750) --- branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-08-07 01:29:35 UTC (rev 280749) +++ branches/safari-612.1.27.0-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-08-07 01:33:03 UTC (rev 280750) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 27; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (280749 => 280750) --- branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-08-07 01:29:35 UTC (rev 280749) +++ branches/safari-612.1.27.0-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-08-07 01:33:03 UTC (rev 280750) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 27; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (280749 => 280750) --- branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-08-07 01:29:35 UTC (rev 280749) +++ branches/safari-612.1.27.0-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-08-07 01:33:03 UTC (rev 280750) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 27; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig (280749 => 280750) --- branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-08-07 01:29:35 UTC (rev 280749) +++ branches/safari-612.1.27.0-branch/Source/WebCore/Configurations/Version.xcconfig 2021-08-07 01:33:03 UTC (rev 280750) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 27; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (280749 => 280750) --- branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-08-07 01:29:35 UTC (rev 280749) +++ branches/safari-612.1.27.0-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-08-07 01:33:03 UTC (rev 280750) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 27; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (280749 => 280750) --- branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-08-07 01:29:35 UTC (rev 280749) +++ branches/safari-612.1.27.0-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-08-07 01:33:03 UTC (rev 280750) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 27; MICRO_VERSION = 0; -NANO_VERSION = 2; +NANO_VERSION = 3; FULL_VERSION =
[webkit-changes] [280749] trunk/LayoutTests
Title: [280749] trunk/LayoutTests Revision 280749 Author jen...@apple.com Date 2021-08-06 18:29:35 -0700 (Fri, 06 Aug 2021) Log Message [ Monterey wk2 Release ] fast/scrolling/iframe-scrollable-after-back.html is a flaky timeout https://bugs.webkit.org/show_bug.cgi?id=228200 Unreviewed test gardening. Remove no longer needed expectation. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (280748 => 280749) --- trunk/LayoutTests/ChangeLog 2021-08-07 01:18:39 UTC (rev 280748) +++ trunk/LayoutTests/ChangeLog 2021-08-07 01:29:35 UTC (rev 280749) @@ -1,5 +1,14 @@ 2021-08-06 Robert Jenner +[ Monterey wk2 Release ] fast/scrolling/iframe-scrollable-after-back.html is a flaky timeout +https://bugs.webkit.org/show_bug.cgi?id=228200 + +Unreviewed test gardening. Remove no longer needed expectation. + +* platform/mac-wk2/TestExpectations: + +2021-08-06 Robert Jenner + [BigSur Release Wk2 Arm64] imported/w3c/web-platform-tests/navigation-timing/test_performance_attributes.sub.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=224784 Unreviewed test gardening. Removing no longer needed expectation. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280748 => 280749) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-07 01:18:39 UTC (rev 280748) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-07 01:29:35 UTC (rev 280749) @@ -1496,9 +1496,6 @@ # rdar://80335706 (REGRESSION: [ Monterey wk2 ] fast/text/international/system-language/navigator-language/navigator-language-ru.html [ Failure ]) [ Monterey ] fast/text/international/system-language/navigator-language/navigator-language-ru.html [ Failure ] -# rdar://80335452 ([ Monterey wk2 Release ] fast/scrolling/iframe-scrollable-after-back.html is a flaky timeout) -[ Monterey ] fast/scrolling/iframe-scrollable-after-back.html [ Pass Timeout ] - webkit.org/b/227776 [ BigSur Release arm64 ] scrollbars/corner-resizer-window-inactive.html [ Pass ImageOnlyFailure ] webkit.org/b/227776 [ Catalina Release ] scrollbars/corner-resizer-window-inactive.html [ Pass ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280748] trunk/LayoutTests
Title: [280748] trunk/LayoutTests Revision 280748 Author jen...@apple.com Date 2021-08-06 18:18:39 -0700 (Fri, 06 Aug 2021) Log Message [BigSur Release Wk2 Arm64] imported/w3c/web-platform-tests/navigation-timing/test_performance_attributes.sub.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=224784 Unreviewed test gardening. Removing no longer needed expectation. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (280747 => 280748) --- trunk/LayoutTests/ChangeLog 2021-08-07 01:16:27 UTC (rev 280747) +++ trunk/LayoutTests/ChangeLog 2021-08-07 01:18:39 UTC (rev 280748) @@ -1,5 +1,13 @@ 2021-08-06 Robert Jenner +[BigSur Release Wk2 Arm64] imported/w3c/web-platform-tests/navigation-timing/test_performance_attributes.sub.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=224784 +Unreviewed test gardening. Removing no longer needed expectation. + +* platform/mac-wk2/TestExpectations: + +2021-08-06 Robert Jenner + [BigSur Wk2 Arm64] http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=224783 Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280747 => 280748) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-07 01:16:27 UTC (rev 280747) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-07 01:18:39 UTC (rev 280748) @@ -1436,8 +1436,6 @@ webkit.org/b/225527 [ BigSur Release arm64 ] http/tests/workers/service/self_registration.html [ Pass Timeout ] -webkit.org/b/224784 [ BigSur Release arm64 ] imported/w3c/web-platform-tests/navigation-timing/test_performance_attributes.sub.html [ Pass Failure ] - webkit.org/b/207474 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ] webkit.org/b/225529 [ BigSur Release arm64 ] scrollingcoordinator/mac/fixed-backgrounds/fixed-background-in-overflow-in-iframe.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280747] trunk/Source/WebCore
Title: [280747] trunk/Source/WebCore Revision 280747 Author katherine_che...@apple.com Date 2021-08-06 18:16:27 -0700 (Fri, 06 Aug 2021) Log Message CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const https://bugs.webkit.org/show_bug.cgi?id=228878 Reviewed by Brent Fulgham. exportData() could return nullptr. We should check the value of rsaComponents before trying to use it. * crypto/keys/CryptoKeyRSA.cpp: (WebCore::CryptoKeyRSA::exportJwk const): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (280746 => 280747) --- trunk/Source/WebCore/ChangeLog 2021-08-07 00:57:57 UTC (rev 280746) +++ trunk/Source/WebCore/ChangeLog 2021-08-07 01:16:27 UTC (rev 280747) @@ -1,3 +1,17 @@ +2021-08-06 Kate Cheney + +CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::CryptoKeyRSA::exportJwk const +https://bugs.webkit.org/show_bug.cgi?id=228878 + + +Reviewed by Brent Fulgham. + +exportData() could return nullptr. We should check the value of +rsaComponents before trying to use it. + +* crypto/keys/CryptoKeyRSA.cpp: +(WebCore::CryptoKeyRSA::exportJwk const): + 2021-08-06 Alexander Mikhaylenko REGRESSION(r279987): [GTK][WPE] It caused 2 new test failures Modified: trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.cpp (280746 => 280747) --- trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.cpp 2021-08-07 00:57:57 UTC (rev 280746) +++ trunk/Source/WebCore/crypto/keys/CryptoKeyRSA.cpp 2021-08-07 01:16:27 UTC (rev 280747) @@ -139,6 +139,9 @@ auto rsaComponents = exportData(); +if (!rsaComponents) +return result; + // public key result.n = base64URLEncodeToString(rsaComponents->modulus()); result.e = base64URLEncodeToString(rsaComponents->exponent()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280746] trunk/LayoutTests
Title: [280746] trunk/LayoutTests Revision 280746 Author jen...@apple.com Date 2021-08-06 17:57:57 -0700 (Fri, 06 Aug 2021) Log Message [BigSur Wk2 Arm64] http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html is flaky failing https://bugs.webkit.org/show_bug.cgi?id=224783 Unreviewed test gardening. Removing no longer needed test expectation. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (280745 => 280746) --- trunk/LayoutTests/ChangeLog 2021-08-07 00:26:26 UTC (rev 280745) +++ trunk/LayoutTests/ChangeLog 2021-08-07 00:57:57 UTC (rev 280746) @@ -1,3 +1,12 @@ +2021-08-06 Robert Jenner + +[BigSur Wk2 Arm64] http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html is flaky failing +https://bugs.webkit.org/show_bug.cgi?id=224783 + +Unreviewed test gardening. Removing no longer needed test expectation. + +* platform/mac-wk2/TestExpectations: + 2021-08-06 Arcady Goldmints-Orlov [GTK] Remove some expectations for tests that don't fail anymore Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280745 => 280746) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-07 00:26:26 UTC (rev 280745) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-07 00:57:57 UTC (rev 280746) @@ -1446,8 +1446,6 @@ webkit.org/b/225533 [ BigSur Release arm64 ] mathml/scripts-removeChild.html [ Pass ImageOnlyFailure ] -webkit.org/b/224783 [ BigSur arm64 ] http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html [ Pass Failure ] - webkit.org/b/225666 http/tests/cache/disk-cache/redirect-chain-limits.html [ Slow ] webkit.org/b/225665 [ Release arm64 ] http/tests/appcache/fail-on-update-2.html [ DumpJSConsoleLogInStdErr Slow ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280745] trunk/Source/JavaScriptCore
Title: [280745] trunk/Source/_javascript_Core
Revision 280745
Author ysuz...@apple.com
Date 2021-08-06 17:26:26 -0700 (Fri, 06 Aug 2021)
Log Message
Unreviewed, build fix on Debug build
https://bugs.webkit.org/show_bug.cgi?id=228810
* yarr/YarrJIT.h:
(JSC::Yarr::BoyerMooreBitmap::addCharacters):
(JSC::Yarr::BoyerMooreBitmap::addRanges):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (280744 => 280745)
--- trunk/Source/_javascript_Core/ChangeLog 2021-08-07 00:02:51 UTC (rev 280744)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-08-07 00:26:26 UTC (rev 280745)
@@ -1,5 +1,14 @@
2021-08-06 Yusuke Suzuki
+Unreviewed, build fix on Debug build
+https://bugs.webkit.org/show_bug.cgi?id=228810
+
+* yarr/YarrJIT.h:
+(JSC::Yarr::BoyerMooreBitmap::addCharacters):
+(JSC::Yarr::BoyerMooreBitmap::addRanges):
+
+2021-08-06 Yusuke Suzuki
+
[JSC] Yarr's character tracking for BoyerMoore search should be more precise
https://bugs.webkit.org/show_bug.cgi?id=228810
Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.h (280744 => 280745)
--- trunk/Source/_javascript_Core/yarr/YarrJIT.h 2021-08-07 00:02:51 UTC (rev 280744)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.h 2021-08-07 00:26:26 UTC (rev 280745)
@@ -143,7 +143,7 @@
{
if (isAllSet())
return;
-ASSERT(std::is_sorted(characters));
+ASSERT(std::is_sorted(characters.begin(), characters.end()));
for (UChar32 character : characters) {
// Early return since characters are sorted.
if (charSize == CharSize::Char8 && character > 0xff)
@@ -157,7 +157,7 @@
{
if (isAllSet())
return;
-ASSERT(std::is_sorted(characters, [](CharacterRange lhs, CharacterRange rhs) {
+ASSERT(std::is_sorted(ranges.begin(), ranges.end(), [](CharacterRange lhs, CharacterRange rhs) {
return lhs.begin < rhs.begin;
}));
for (CharacterRange range : ranges) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280744] trunk/Source/JavaScriptCore
Title: [280744] trunk/Source/_javascript_Core
Revision 280744
Author ysuz...@apple.com
Date 2021-08-06 17:02:51 -0700 (Fri, 06 Aug 2021)
Log Message
[JSC] Yarr's character tracking for BoyerMoore search should be more precise
https://bugs.webkit.org/show_bug.cgi?id=228810
Reviewed by Saam Barati.
We should track up to 2 candidate characters without masking, so
that we can search a character without masking. To track candidates,
we introduce BoyerMooreCharacterCandidates.
We also add support for m_table because m_table can be used
for important CharacterClass like `\s`, and still that does not have
many character candidates if the mode is Char8.
To make `\s` work on Char8 case, we use Char8 / Char16 information
to filter characters that never appears in BoyreMoore search bitmap
construction.
* yarr/YarrJIT.cpp:
(JSC::Yarr::BoyerMooreInfo::BoyerMooreInfo):
(JSC::Yarr::BoyerMooreInfo::set):
(JSC::Yarr::BoyerMooreInfo::addCharacters):
(JSC::Yarr::BoyerMooreInfo::addRanges):
(JSC::Yarr::BoyerMooreInfo::create):
(JSC::Yarr::BoyerMooreInfo::createCandidateBitmap const):
* yarr/YarrJIT.h:
(JSC::Yarr::BoyerMooreCharacterCandidates::isValid const):
(JSC::Yarr::BoyerMooreCharacterCandidates::invalidate):
(JSC::Yarr::BoyerMooreCharacterCandidates::isEmpty const):
(JSC::Yarr::BoyerMooreCharacterCandidates::size const):
(JSC::Yarr::BoyerMooreCharacterCandidates::at const):
(JSC::Yarr::BoyerMooreCharacterCandidates::add):
(JSC::Yarr::BoyerMooreCharacterCandidates::merge):
(JSC::Yarr::BoyerMooreBitmap::characterCandidates const):
(JSC::Yarr::BoyerMooreBitmap::add):
(JSC::Yarr::BoyerMooreBitmap::addCharacters):
(JSC::Yarr::BoyerMooreBitmap::addRanges):
(JSC::Yarr::BoyerMooreBitmap::isMaskEffective const): Deleted.
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/yarr/YarrJIT.cpp
trunk/Source/_javascript_Core/yarr/YarrJIT.h
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (280743 => 280744)
--- trunk/Source/_javascript_Core/ChangeLog 2021-08-06 23:21:07 UTC (rev 280743)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-08-07 00:02:51 UTC (rev 280744)
@@ -1,3 +1,43 @@
+2021-08-06 Yusuke Suzuki
+
+[JSC] Yarr's character tracking for BoyerMoore search should be more precise
+https://bugs.webkit.org/show_bug.cgi?id=228810
+
+Reviewed by Saam Barati.
+
+We should track up to 2 candidate characters without masking, so
+that we can search a character without masking. To track candidates,
+we introduce BoyerMooreCharacterCandidates.
+
+We also add support for m_table because m_table can be used
+for important CharacterClass like `\s`, and still that does not have
+many character candidates if the mode is Char8.
+
+To make `\s` work on Char8 case, we use Char8 / Char16 information
+to filter characters that never appears in BoyreMoore search bitmap
+construction.
+
+* yarr/YarrJIT.cpp:
+(JSC::Yarr::BoyerMooreInfo::BoyerMooreInfo):
+(JSC::Yarr::BoyerMooreInfo::set):
+(JSC::Yarr::BoyerMooreInfo::addCharacters):
+(JSC::Yarr::BoyerMooreInfo::addRanges):
+(JSC::Yarr::BoyerMooreInfo::create):
+(JSC::Yarr::BoyerMooreInfo::createCandidateBitmap const):
+* yarr/YarrJIT.h:
+(JSC::Yarr::BoyerMooreCharacterCandidates::isValid const):
+(JSC::Yarr::BoyerMooreCharacterCandidates::invalidate):
+(JSC::Yarr::BoyerMooreCharacterCandidates::isEmpty const):
+(JSC::Yarr::BoyerMooreCharacterCandidates::size const):
+(JSC::Yarr::BoyerMooreCharacterCandidates::at const):
+(JSC::Yarr::BoyerMooreCharacterCandidates::add):
+(JSC::Yarr::BoyerMooreCharacterCandidates::merge):
+(JSC::Yarr::BoyerMooreBitmap::characterCandidates const):
+(JSC::Yarr::BoyerMooreBitmap::add):
+(JSC::Yarr::BoyerMooreBitmap::addCharacters):
+(JSC::Yarr::BoyerMooreBitmap::addRanges):
+(JSC::Yarr::BoyerMooreBitmap::isMaskEffective const): Deleted.
+
2021-08-05 Mikhail R. Gadelha
Assertion failure when checking array in DFG (32 bits)
Modified: trunk/Source/_javascript_Core/yarr/YarrJIT.cpp (280743 => 280744)
--- trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2021-08-06 23:21:07 UTC (rev 280743)
+++ trunk/Source/_javascript_Core/yarr/YarrJIT.cpp 2021-08-07 00:02:51 UTC (rev 280744)
@@ -36,6 +36,7 @@
#include "YarrMatchingContextHolder.h"
#include
#include
+#include
#include
@@ -50,6 +51,15 @@
JSC_ANNOTATE_JIT_OPERATION(_JITTarget_vmEntryToYarrJITAfter, vmEntryToYarrJITAfter);
#endif
+void BoyerMooreFastCandidates::dump(PrintStream& out) const
+{
+if (!isValid()) {
+out.print("isValid:(false)");
+return;
+}
+out.print("isValid:(true),characters:(", listDump(m_characters), ")");
+}
+
class BoyerMooreInfo {
WTF_MAKE_NONCOPYABLE(BoyerMooreInfo);
WTF_MAKE_FAST_ALLOCATED(BoyerMooreInfo);
@@ -56,8 +66,9 @@
[webkit-changes] [280743] trunk/LayoutTests
Title: [280743] trunk/LayoutTests Revision 280743 Author commit-qu...@webkit.org Date 2021-08-06 16:21:07 -0700 (Fri, 06 Aug 2021) Log Message [GTK] Remove some expectations for tests that don't fail anymore https://bugs.webkit.org/show_bug.cgi?id=225644 Unreviewed test gardening. Patch by Arcady Goldmints-Orlov on 2021-08-06 * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (280742 => 280743) --- trunk/LayoutTests/ChangeLog 2021-08-06 23:14:55 UTC (rev 280742) +++ trunk/LayoutTests/ChangeLog 2021-08-06 23:21:07 UTC (rev 280743) @@ -1,3 +1,12 @@ +2021-08-06 Arcady Goldmints-Orlov + +[GTK] Remove some expectations for tests that don't fail anymore +https://bugs.webkit.org/show_bug.cgi?id=225644 + +Unreviewed test gardening. + +* platform/gtk/TestExpectations: + 2021-08-06 Robert Jenner [ Monterey Release wk2 arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html is a flaky crash Modified: trunk/LayoutTests/platform/gtk/TestExpectations (280742 => 280743) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-06 23:14:55 UTC (rev 280742) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-06 23:21:07 UTC (rev 280743) @@ -941,12 +941,6 @@ webkit.org/b/224967 webkit.org/b/225659 imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html [ Crash Failure ] -webkit.org/b/225644 compositing/transforms/perspective-with-scrolling.html [ ImageOnlyFailure ] -webkit.org/b/225644 fast/repaint/fixed-table-cell.html [ ImageOnlyFailure ] -webkit.org/b/225644 fast/repaint/fixed-table-overflow.html [ ImageOnlyFailure ] -webkit.org/b/225644 fast/repaint/fixed-table-overflow-zindex.html [ ImageOnlyFailure ] -webkit.org/b/225644 compositing/overflow/dynamic-composited-scrolling-status.html [ Failure ] - # # End of Expected failures. # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280742] trunk/Source/WebCore
Title: [280742] trunk/Source/WebCore Revision 280742 Author al...@gnome.org Date 2021-08-06 16:14:55 -0700 (Fri, 06 Aug 2021) Log Message REGRESSION(r279987): [GTK][WPE] It caused 2 new test failures https://bugs.webkit.org/show_bug.cgi?id=228160 Reviewed by Michael Catanzaro. Normally adjustText*() are only called for unstyled elements to adjust their platform appearance, However, for entries we always call it since https://bugs.webkit.org/show_bug.cgi?id=173572 and it causes problems. That change was done for RenderThemeGtk and is not relevant anymore, so we can revert it. * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderTheme.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (280741 => 280742) --- trunk/Source/WebCore/ChangeLog 2021-08-06 23:11:01 UTC (rev 280741) +++ trunk/Source/WebCore/ChangeLog 2021-08-06 23:14:55 UTC (rev 280742) @@ -1,3 +1,20 @@ +2021-08-06 Alexander Mikhaylenko + +REGRESSION(r279987): [GTK][WPE] It caused 2 new test failures +https://bugs.webkit.org/show_bug.cgi?id=228160 + +Reviewed by Michael Catanzaro. + +Normally adjustText*() are only called for unstyled elements to adjust their platform +appearance, However, for entries we always call it since +https://bugs.webkit.org/show_bug.cgi?id=173572 and it causes problems. + +That change was done for RenderThemeGtk and is not relevant anymore, so we can revert +it. + +* rendering/RenderTheme.cpp: +(WebCore::RenderTheme::adjustStyle): + 2021-08-06 Youenn Fablet [GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (280741 => 280742) --- trunk/Source/WebCore/rendering/RenderTheme.cpp 2021-08-06 23:11:01 UTC (rev 280741) +++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2021-08-06 23:14:55 UTC (rev 280742) @@ -93,9 +93,6 @@ style.setAppearance(MenulistButtonPart); part = MenulistButtonPart; break; -case TextFieldPart: -adjustTextFieldStyle(style, element); -FALLTHROUGH; default: style.setAppearance(NoControlPart); break; ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280741] trunk/LayoutTests
Title: [280741] trunk/LayoutTests Revision 280741 Author jen...@apple.com Date 2021-08-06 16:11:01 -0700 (Fri, 06 Aug 2021) Log Message [ Monterey Release wk2 arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html is a flaky crash https://bugs.webkit.org/show_bug.cgi?id=228200 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (280740 => 280741) --- trunk/LayoutTests/ChangeLog 2021-08-06 22:18:49 UTC (rev 280740) +++ trunk/LayoutTests/ChangeLog 2021-08-06 23:11:01 UTC (rev 280741) @@ -1,3 +1,12 @@ +2021-08-06 Robert Jenner + +[ Monterey Release wk2 arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html is a flaky crash +https://bugs.webkit.org/show_bug.cgi?id=228200 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2021-08-06 Fujii Hironori ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader() Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (280740 => 280741) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-06 22:18:49 UTC (rev 280740) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2021-08-06 23:11:01 UTC (rev 280741) @@ -1484,7 +1484,7 @@ [ Monterey ] webrtc/h264-high.html [ Timeout ] # rdar://80346382 ([ Monterey Release wk2 arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html is a flaky crash) -[ Monterey arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html [ Failure Crash ] +[ Monterey arm64 ] platform/mac/fast/overflow/overflow-scrollbar-hit-test.html [ Failure ] # rdar://80333935 (REGRESSION: [ Monterey wk2 arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html and request-animation-frame-throttling-lowPowerMode.html failing) [ Monterey arm64 ] fast/animation/request-animation-frame-throttling-detached-iframe.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280740] trunk
Title: [280740] trunk
Revision 280740
Author hironori.fu...@sony.com
Date 2021-08-06 15:18:49 -0700 (Fri, 06 Aug 2021)
Log Message
ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader()
https://bugs.webkit.org/show_bug.cgi?id=228853
Reviewed by Alex Christensen.
Source/WebKit:
~NetworkResourceLoader() had the assertion ensuring m_networkLoad
was empty. But, this could fail in the following scenario. If a
'keepalive' fetch request is not finished and the page is
navigated away, its NetworkResourceLoader is transferred to the
NetworkSession by NetworkConnectionToWebProcess::transferKeptAliveLoad.
And, before the request is finished, if the NetworkSession is
destroyed, the kept alive NetworkResourceLoader is destroyed.
Test: http/tests/fetch/keepalive-fetch.html
* NetworkProcess/NetworkSession.cpp:
(WebKit::NetworkSession::~NetworkSession): Abort m_keptAliveLoads.
LayoutTests:
* http/tests/fetch/keepalive-fetch-expected.txt: Added.
* http/tests/fetch/keepalive-fetch.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp
Added Paths
trunk/LayoutTests/http/tests/fetch/keepalive-fetch-expected.txt
trunk/LayoutTests/http/tests/fetch/keepalive-fetch.html
Diff
Modified: trunk/LayoutTests/ChangeLog (280739 => 280740)
--- trunk/LayoutTests/ChangeLog 2021-08-06 22:16:34 UTC (rev 280739)
+++ trunk/LayoutTests/ChangeLog 2021-08-06 22:18:49 UTC (rev 280740)
@@ -1,3 +1,13 @@
+2021-08-06 Fujii Hironori
+
+ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader()
+https://bugs.webkit.org/show_bug.cgi?id=228853
+
+Reviewed by Alex Christensen.
+
+* http/tests/fetch/keepalive-fetch-expected.txt: Added.
+* http/tests/fetch/keepalive-fetch.html: Added.
+
2021-08-06 Arcady Goldmints-Orlov
[GTK] Mark some WPT CSS tests as still failing on GTK
Added: trunk/LayoutTests/http/tests/fetch/keepalive-fetch-expected.txt (0 => 280740)
--- trunk/LayoutTests/http/tests/fetch/keepalive-fetch-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/fetch/keepalive-fetch-expected.txt 2021-08-06 22:18:49 UTC (rev 280740)
@@ -0,0 +1 @@
+Send a keepalive fetch request in an ephemeral session. This test should not cause a crash.
Added: trunk/LayoutTests/http/tests/fetch/keepalive-fetch.html (0 => 280740)
--- trunk/LayoutTests/http/tests/fetch/keepalive-fetch.html (rev 0)
+++ trunk/LayoutTests/http/tests/fetch/keepalive-fetch.html 2021-08-06 22:18:49 UTC (rev 280740)
@@ -0,0 +1,8 @@
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+fetch("/resources/slow-script.pl", { keepalive : true });
+
+Send a keepalive fetch request in an ephemeral session. This test should not cause a crash.
Modified: trunk/Source/WebKit/ChangeLog (280739 => 280740)
--- trunk/Source/WebKit/ChangeLog 2021-08-06 22:16:34 UTC (rev 280739)
+++ trunk/Source/WebKit/ChangeLog 2021-08-06 22:18:49 UTC (rev 280740)
@@ -1,3 +1,23 @@
+2021-08-06 Fujii Hironori
+
+ASSERTION FAILED: !m_networkLoad in NetworkResourceLoader::~NetworkResourceLoader()
+https://bugs.webkit.org/show_bug.cgi?id=228853
+
+Reviewed by Alex Christensen.
+
+~NetworkResourceLoader() had the assertion ensuring m_networkLoad
+was empty. But, this could fail in the following scenario. If a
+'keepalive' fetch request is not finished and the page is
+navigated away, its NetworkResourceLoader is transferred to the
+NetworkSession by NetworkConnectionToWebProcess::transferKeptAliveLoad.
+And, before the request is finished, if the NetworkSession is
+destroyed, the kept alive NetworkResourceLoader is destroyed.
+
+Test: http/tests/fetch/keepalive-fetch.html
+
+* NetworkProcess/NetworkSession.cpp:
+(WebKit::NetworkSession::~NetworkSession): Abort m_keptAliveLoads.
+
2021-08-06 Aditya Keerthi
[macOS] 3 second IPC deadlocks involving WebPageProxy::acceptsFirstMouse
Modified: trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp (280739 => 280740)
--- trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-08-06 22:16:34 UTC (rev 280739)
+++ trunk/Source/WebKit/NetworkProcess/NetworkSession.cpp 2021-08-06 22:18:49 UTC (rev 280740)
@@ -137,6 +137,8 @@
#if ENABLE(RESOURCE_LOAD_STATISTICS)
destroyResourceLoadStatistics([] { });
#endif
+for (auto& loader : std::exchange(m_keptAliveLoads, { }))
+loader->abort();
}
#if ENABLE(RESOURCE_LOAD_STATISTICS)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280739] trunk/Tools
Title: [280739] trunk/Tools Revision 280739 Author jbed...@apple.com Date 2021-08-06 15:16:34 -0700 (Fri, 06 Aug 2021) Log Message [git-webkit] Add setup function https://bugs.webkit.org/show_bug.cgi?id=225985 Reviewed by Dewei Zhu. * Scripts/libraries/webkitcorepy/setup.py: Bump version. * Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto. * Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py: (credentials): Key should be pulled from environment variable with key_name in it. * Scripts/libraries/webkitscmpy/setup.py: Bump version. * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: (Git): Move config regexes. (Git.__init__): Add `git remote add`, `git config` and `git fetch fork`. (Git.config): Add user.email to default configuration. (Git.edit_config): Modify configuration file. * Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py: (GitHub): Add list of forks. (GitHub.__enter__): Correctly mock token. (GitHub.request): Add fork check and fork addition. * Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py: (main): Add setup function. * Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub.credentials): Strip email domain, guide user on token permissions. * Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py: Added. (Setup.github): Ensure that GitHub credentials are in the keychain. (Setup.git): Set the user for the repository, along with merge strategy. (Setup.parser): (Setup.main): * Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py: (test_config): Change user name. (test_global_config): Ditto. * Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py: Added. (TestSetup): (TestSetup.setUp): (TestSetup.test_svn): (TestSetup.test_github): (TestSetup.test_git): (TestSetup.test_github_checkout): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitcorepy/setup.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py trunk/Tools/Scripts/libraries/webkitscmpy/setup.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py Added Paths trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py Diff Modified: trunk/Tools/ChangeLog (280738 => 280739) --- trunk/Tools/ChangeLog 2021-08-06 22:13:32 UTC (rev 280738) +++ trunk/Tools/ChangeLog 2021-08-06 22:16:34 UTC (rev 280739) @@ -1,3 +1,46 @@ +2021-08-06 Jonathan Bedard + +[git-webkit] Add setup function +https://bugs.webkit.org/show_bug.cgi?id=225985 + + +Reviewed by Dewei Zhu. + +* Scripts/libraries/webkitcorepy/setup.py: Bump version. +* Scripts/libraries/webkitcorepy/webkitcorepy/__init__.py: Ditto. +* Scripts/libraries/webkitcorepy/webkitcorepy/credentials.py: +(credentials): Key should be pulled from environment variable with key_name in it. +* Scripts/libraries/webkitscmpy/setup.py: Bump version. +* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. +* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/local/git.py: +(Git): Move config regexes. +(Git.__init__): Add `git remote add`, `git config` and `git fetch fork`. +(Git.config): Add user.email to default configuration. +(Git.edit_config): Modify configuration file. +* Scripts/libraries/webkitscmpy/webkitscmpy/mocks/remote/git_hub.py: +(GitHub): Add list of forks. +(GitHub.__enter__): Correctly mock token. +(GitHub.request): Add fork check and fork addition. +* Scripts/libraries/webkitscmpy/webkitscmpy/program/__init__.py: +(main): Add setup function. +* Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: +(GitHub.credentials): Strip email domain, guide user on token permissions. +* Scripts/libraries/webkitscmpy/webkitscmpy/program/setup.py: Added. +(Setup.github): Ensure that GitHub credentials are in the keychain. +(Setup.git): Set the user for the repository, along with merge strategy. +(Setup.parser): +(Setup.main): +* Scripts/libraries/webkitscmpy/webkitscmpy/test/git_unittest.py: +(test_config): Change user name. +(test_global_config): Ditto. +* Scripts/libraries/webkitscmpy/webkitscmpy/test/setup_unittest.py: Added. +(TestSetup): +(TestSetup.setUp): +
[webkit-changes] [280738] trunk/PerformanceTests
Title: [280738] trunk/PerformanceTests
Revision 280738
Author commit-qu...@webkit.org
Date 2021-08-06 15:13:32 -0700 (Fri, 06 Aug 2021)
Log Message
MallocBench: fix ODR violation
https://bugs.webkit.org/show_bug.cgi?id=228874
Patch by Michael Catanzaro on 2021-08-06
Reviewed by Geoffrey Garen.
When built with LTO enabled, GCC will warn about violations of C++'s one-definition rule.
MallocBench has two different Objects in two different files, which is illegal. We could
rename one of them, but I decided it's simplest to just put them each in anonymous
namespaces in order to restrict them to file scope.
* MallocBench/MallocBench/big.cpp:
* MallocBench/MallocBench/stress.cpp:
Modified Paths
trunk/PerformanceTests/ChangeLog
trunk/PerformanceTests/MallocBench/MallocBench/big.cpp
trunk/PerformanceTests/MallocBench/MallocBench/stress.cpp
Diff
Modified: trunk/PerformanceTests/ChangeLog (280737 => 280738)
--- trunk/PerformanceTests/ChangeLog 2021-08-06 22:09:37 UTC (rev 280737)
+++ trunk/PerformanceTests/ChangeLog 2021-08-06 22:13:32 UTC (rev 280738)
@@ -1,3 +1,18 @@
+2021-08-06 Michael Catanzaro
+
+MallocBench: fix ODR violation
+https://bugs.webkit.org/show_bug.cgi?id=228874
+
+Reviewed by Geoffrey Garen.
+
+When built with LTO enabled, GCC will warn about violations of C++'s one-definition rule.
+MallocBench has two different Objects in two different files, which is illegal. We could
+rename one of them, but I decided it's simplest to just put them each in anonymous
+namespaces in order to restrict them to file scope.
+
+* MallocBench/MallocBench/big.cpp:
+* MallocBench/MallocBench/stress.cpp:
+
2021-07-25 Cathie Chen
[Performance test][css-contain] Add test to contain: size layout
Modified: trunk/PerformanceTests/MallocBench/MallocBench/big.cpp (280737 => 280738)
--- trunk/PerformanceTests/MallocBench/MallocBench/big.cpp 2021-08-06 22:09:37 UTC (rev 280737)
+++ trunk/PerformanceTests/MallocBench/MallocBench/big.cpp 2021-08-06 22:13:32 UTC (rev 280738)
@@ -34,11 +34,15 @@
using namespace std;
+namespace {
+
struct Object {
double* p;
size_t size;
};
+}
+
void benchmark_big(CommandLine& commandLine)
{
size_t times = 1;
Modified: trunk/PerformanceTests/MallocBench/MallocBench/stress.cpp (280737 => 280738)
--- trunk/PerformanceTests/MallocBench/MallocBench/stress.cpp 2021-08-06 22:09:37 UTC (rev 280737)
+++ trunk/PerformanceTests/MallocBench/MallocBench/stress.cpp 2021-08-06 22:13:32 UTC (rev 280738)
@@ -39,6 +39,8 @@
static const size_t kB = 1024;
static const size_t MB = kB * kB;
+namespace {
+
struct Object {
Object(void* pointer, size_t size, long uuid)
: pointer(pointer)
@@ -123,6 +125,8 @@
mbfree(object.pointer, object.size);
}
+} // anonymous namespace
+
void benchmark_stress(CommandLine&)
{
const size_t heapSize = 100 * MB;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280737] trunk/LayoutTests
Title: [280737] trunk/LayoutTests Revision 280737 Author commit-qu...@webkit.org Date 2021-08-06 15:09:37 -0700 (Fri, 06 Aug 2021) Log Message [GTK] Mark some WPT CSS tests as still failing on GTK https://bugs.webkit.org/show_bug.cgi?id=228871 These tests were fixed for most platforms in r279568 and r279698 but still fail on GTK. Unreviewed test gardening. Patch by Arcady Goldmints-Orlov on 2021-08-06 * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (280736 => 280737) --- trunk/LayoutTests/ChangeLog 2021-08-06 21:59:14 UTC (rev 280736) +++ trunk/LayoutTests/ChangeLog 2021-08-06 22:09:37 UTC (rev 280737) @@ -1,3 +1,14 @@ +2021-08-06 Arcady Goldmints-Orlov + +[GTK] Mark some WPT CSS tests as still failing on GTK +https://bugs.webkit.org/show_bug.cgi?id=228871 + +These tests were fixed for most platforms in r279568 and r279698 but +still fail on GTK. +Unreviewed test gardening. + +* platform/gtk/TestExpectations: + 2021-08-06 Eric Hutchison Re-baselined imported/w3c/web-platform-tests/html/dom/idlharness.https.html. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (280736 => 280737) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-06 21:59:14 UTC (rev 280736) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-06 22:09:37 UTC (rev 280737) @@ -880,6 +880,9 @@ webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/hyphens/hyphens-span-001.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-tab-005.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-tab-006.html [ ImageOnlyFailure ] +webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-018.html [ ImageOnlyFailure ] +webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/pre-wrap-019.html [ ImageOnlyFailure ] +webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-001.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-031.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-032.html [ ImageOnlyFailure ] webkit.org/b/214290 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-035.html [ ImageOnlyFailure ] @@ -1781,6 +1784,7 @@ webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-force-end-001.xht [ ImageOnlyFailure ] webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-first-001.xht [ Timeout ImageOnlyFailure ] webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/hanging-punctuation/hanging-punctuation-last-001.xht [ Timeout ImageOnlyFailure ] +webkit.org/b/195275 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-pre-wrap-trailing-spaces-002.html [ ImageOnlyFailure ] webkit.org/b/185939 imported/w3c/web-platform-tests/css/WOFF2 [ Pass ] webkit.org/b/185938 imported/w3c/web-platform-tests/css/WOFF2/tabledata-glyf-bbox-001.xht [ ImageOnlyFailure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280736] trunk/Source/WebKit
Title: [280736] trunk/Source/WebKit Revision 280736 Author akeer...@apple.com Date 2021-08-06 14:59:14 -0700 (Fri, 06 Aug 2021) Log Message [macOS] 3 second IPC deadlocks involving WebPageProxy::acceptsFirstMouse https://bugs.webkit.org/show_bug.cgi?id=228834 rdar://75390908 Reviewed by Wenson Hsieh and Tim Horton. Reports show 3 second hangs in WebPageProxy::acceptsFirstMouse, which is the timeout for the sync IPC sent by the method. While this method has always sent a sync IPC, logs show the WebProcess is also blocked on sync IPC, under WebProcess::ensureGPUProcessConnection. If a Web<->GPU process connection has not been established, WebProcess::ensureGPUProcessConnection sends a sync IPC from the WebProcess to the UIProcess to establish get the connection. However, to get the connection, the UIProcess then sends an async IPC with a reply block to the GPUProcess (see GPUProcessProxy::getGPUProcessConnection). The WebProcess remains blocked until the UIProcess receives the reply from the GPUProcess, and then sends a reply to the WebProcess. Now, if a call to acceptsFirstMouse occurs in between the time the async UIProcess -> GPUProcess IPC is sent, and the reply is received, we will experience deadlock. The UIProcess will be blocked waiting on the WebProcess' reply to acceptsFirstMouse, and the reply from the GPUProcess will not be dispatched. Since the reply from the GPUProcess will not be dispatched until the UIProcess is unblocked, the WebProcess will be waiting under WebProcess:ensureGPUProcessConnection, and unable to reply to acceptsFirstMouse. A simple fix for the described scenario would be to introduce a replySendOptions parameter to sendWithAsyncReply, so that the UIProcess could be re-entered to dispatch the GPUProcess reply, even when waiting for acceptsFirstMouse. However, this will not work in cases where the GPUProcess is being launched, due to being blocked on the reply from xpc_connection_send_message_with_reply in ProcessLauncherMac, which is before the IPC::Connection has been established. Since re-entering the UIProcess is not possible in this scenario, given the existing architecture, the next simplest solution is to re-enter the WebProcess on acceptsFirstMouse instead. Consequently, one part of the fix involves sending the acceptsFirstMouse IPC with IPC::SendOption::DispatchMessageEvenWhenWaitingForUnboundedSyncReply and tagging WebProcess::getGPUProcessConnection as unbounded sync IPC. Then, we must also consider the fact that, in the WebProcess, acceptsFirstMouse performs hit-testing. Hit-testing triggers layout and could cause script to run. Script could result in a GPUProcess connection being established, eventually leading us down the path towards the aforementioned deadlock. To avoid deadlock in this scenario, we need to interrupt acceptsFirstMouse if a message to get the GPUProcess connection is received. This is achieved by using waitForAndDispatchImmediately with the InterruptWaitingIfSyncMessageArrives option, and splitting up acceptsFirstMouse into two separate IPCs. * UIProcess/WebPageProxy.h: * UIProcess/WebPageProxy.messages.in: * UIProcess/ios/WebPageProxyIOS.mm: Implementation not required for iOS. * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::acceptsFirstMouse): Send an async IPC with IPC::SendOption::DispatchMessageEvenWhenWaitingForUnboundedSyncReply so that the WebProcess can be re-entered to resolve deadlock if necessary. Then, use waitForAndDispatchImmediately to wait for the reply (essentially making it a sync IPC), so that the wait can be interrupted if another sync message, such as getGPUProcessConnection, is received. (WebKit::WebPageProxy::handleAcceptsFirstMouse): Store the result of the reply from the WebProcess. * WebProcess/WebPage/WebPage.h: * WebProcess/WebPage/WebPage.messages.in: Split the sync IPC into two async IPCs, in order to support the use of waitForAndDispatchImmediately. * WebProcess/WebPage/ios/WebPageIOS.mm: Implementation not required for iOS. * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::requestAcceptsFirstMouse): Exit early if re-entering the WebProcess, to avoid running script on re-entry. * WebProcess/WebProcess.cpp: (WebKit::WebProcess::getGPUProcessConnection): Tag as unbounded sync IPC, so the WebProcess can be re-entered to resolve deadlock. Modified Paths trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/WebPageProxy.h trunk/Source/WebKit/UIProcess/WebPageProxy.messages.in trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm trunk/Source/WebKit/WebProcess/WebPage/WebPage.h trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm trunk/Source/WebKit/WebProcess/WebPage/mac/WebPageMac.mm trunk/Source/WebKit/WebProcess/WebProcess.cpp Diff Modified: trunk/Source/WebKit/ChangeLog (280735 => 280736) --- trunk/Source/WebKit/ChangeLog 2021-08-06
[webkit-changes] [280735] tags/Safari-612.1.27.0.2/
Title: [280735] tags/Safari-612.1.27.0.2/ Revision 280735 Author repst...@apple.com Date 2021-08-06 14:45:01 -0700 (Fri, 06 Aug 2021) Log Message Tag Safari-612.1.27.0.2. Added Paths tags/Safari-612.1.27.0.2/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280734] trunk/Tools
Title: [280734] trunk/Tools
Revision 280734
Author hironori.fu...@sony.com
Date 2021-08-06 13:24:31 -0700 (Fri, 06 Aug 2021)
Log Message
[Win][WebKitTestRunner] WTR::PlatformWebView leaks m_view (WKViewRef)
https://bugs.webkit.org/show_bug.cgi?id=228857
Reviewed by Don Olmstead.
Windows WebKitTestRunner leaked a lot of object because it leaked
WebKit::WebView that retains WebKit::WebPageProxy.
* WebKitTestRunner/win/PlatformWebViewWin.cpp:
(WTR::PlatformWebView::~PlatformWebView): Release m_view.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp
Diff
Modified: trunk/Tools/ChangeLog (280733 => 280734)
--- trunk/Tools/ChangeLog 2021-08-06 19:56:31 UTC (rev 280733)
+++ trunk/Tools/ChangeLog 2021-08-06 20:24:31 UTC (rev 280734)
@@ -1,3 +1,16 @@
+2021-08-06 Fujii Hironori
+
+[Win][WebKitTestRunner] WTR::PlatformWebView leaks m_view (WKViewRef)
+https://bugs.webkit.org/show_bug.cgi?id=228857
+
+Reviewed by Don Olmstead.
+
+Windows WebKitTestRunner leaked a lot of object because it leaked
+WebKit::WebView that retains WebKit::WebPageProxy.
+
+* WebKitTestRunner/win/PlatformWebViewWin.cpp:
+(WTR::PlatformWebView::~PlatformWebView): Release m_view.
+
2021-08-06 Youenn Fablet
[GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled
Modified: trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp (280733 => 280734)
--- trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp 2021-08-06 19:56:31 UTC (rev 280733)
+++ trunk/Tools/WebKitTestRunner/win/PlatformWebViewWin.cpp 2021-08-06 20:24:31 UTC (rev 280734)
@@ -97,6 +97,7 @@
{
if (::IsWindow(m_window))
::DestroyWindow(m_window);
+WKRelease(m_view);
}
void PlatformWebView::resizeTo(unsigned width, unsigned height, WebViewSizingMode)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280733] trunk/LayoutTests
Title: [280733] trunk/LayoutTests
Revision 280733
Author ehutchi...@apple.com
Date 2021-08-06 12:56:31 -0700 (Fri, 06 Aug 2021)
Log Message
Re-baselined imported/w3c/web-platform-tests/html/dom/idlharness.https.html.
https://bugs.webkit.org/show_bug.cgi?id=228751.
Unreviewed test gardening.
* platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (280732 => 280733)
--- trunk/LayoutTests/ChangeLog 2021-08-06 19:06:15 UTC (rev 280732)
+++ trunk/LayoutTests/ChangeLog 2021-08-06 19:56:31 UTC (rev 280733)
@@ -1,3 +1,12 @@
+2021-08-06 Eric Hutchison
+
+Re-baselined imported/w3c/web-platform-tests/html/dom/idlharness.https.html.
+https://bugs.webkit.org/show_bug.cgi?id=228751.
+
+Unreviewed test gardening.
+
+* platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt:
+
2021-08-06 Peng Liu
[macOS] Clean up Feature Flags related code
Modified: trunk/LayoutTests/platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt (280732 => 280733)
--- trunk/LayoutTests/platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2021-08-06 19:06:15 UTC (rev 280732)
+++ trunk/LayoutTests/platform/ipad/imported/w3c/web-platform-tests/html/dom/idlharness.https-expected.txt 2021-08-06 19:56:31 UTC (rev 280733)
@@ -263,7 +263,7 @@
PASS HTMLElement interface: attribute onabort
FAIL HTMLElement interface: attribute onauxclick assert_true: The prototype object must have a property "onauxclick" expected true got false
PASS HTMLElement interface: attribute onblur
-FAIL HTMLElement interface: attribute oncancel assert_true: The prototype object must have a property "oncancel" expected true got false
+PASS HTMLElement interface: attribute oncancel
PASS HTMLElement interface: attribute oncanplay
PASS HTMLElement interface: attribute oncanplaythrough
PASS HTMLElement interface: attribute onchange
@@ -358,7 +358,7 @@
PASS HTMLElement interface: document.createElement("noscript") must inherit property "onabort" with the proper type
FAIL HTMLElement interface: document.createElement("noscript") must inherit property "onauxclick" with the proper type assert_inherits: property "onauxclick" not found in prototype chain
PASS HTMLElement interface: document.createElement("noscript") must inherit property "onblur" with the proper type
-FAIL HTMLElement interface: document.createElement("noscript") must inherit property "oncancel" with the proper type assert_inherits: property "oncancel" not found in prototype chain
+PASS HTMLElement interface: document.createElement("noscript") must inherit property "oncancel" with the proper type
PASS HTMLElement interface: document.createElement("noscript") must inherit property "oncanplay" with the proper type
PASS HTMLElement interface: document.createElement("noscript") must inherit property "oncanplaythrough" with the proper type
PASS HTMLElement interface: document.createElement("noscript") must inherit property "onchange" with the proper type
@@ -4403,7 +4403,7 @@
PASS Window interface: attribute onabort
FAIL Window interface: attribute onauxclick assert_own_property: The global object must have a property "onauxclick" expected property "onauxclick" missing
PASS Window interface: attribute onblur
-FAIL Window interface: attribute oncancel assert_own_property: The global object must have a property "oncancel" expected property "oncancel" missing
+PASS Window interface: attribute oncancel
PASS Window interface: attribute oncanplay
PASS Window interface: attribute oncanplaythrough
PASS Window interface: attribute onchange
@@ -4553,7 +4553,7 @@
PASS Window interface: window must inherit property "onabort" with the proper type
FAIL Window interface: window must inherit property "onauxclick" with the proper type assert_own_property: expected property "onauxclick" missing
PASS Window interface: window must inherit property "onblur" with the proper type
-FAIL Window interface: window must inherit property "oncancel" with the proper type assert_own_property: expected property "oncancel" missing
+PASS Window interface: window must inherit property "oncancel" with the proper type
PASS Window interface: window must inherit property "oncanplay" with the proper type
PASS Window interface: window must inherit property "oncanplaythrough" with the proper type
PASS Window interface: window must inherit property "onchange" with the proper type
@@ -5268,7 +5268,7 @@
PASS SVGElement interface: attribute onabort
FAIL SVGElement interface: attribute onauxclick assert_true: The prototype object must have a property "onauxclick" expected true got false
PASS SVGElement interface: attribute onblur
-FAIL SVGElement interface: attribute
[webkit-changes] [280732] trunk
Title: [280732] trunk
Revision 280732
Author you...@apple.com
Date 2021-08-06 12:06:15 -0700 (Fri, 06 Aug 2021)
Log Message
[GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled
https://bugs.webkit.org/show_bug.cgi?id=228759
Reviewed by Geoffrey Garen.
Source/WebCore:
Revert part of https://trac.webkit.org/changeset/279940/webkit.
* platform/mediastream/RealtimeVideoSource.cpp:
(WebCore::RealtimeVideoSource::sourceSettingsChanged):
Covered by API test.
Tools:
* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
Reenable test.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm
Diff
Modified: trunk/Source/WebCore/ChangeLog (280731 => 280732)
--- trunk/Source/WebCore/ChangeLog 2021-08-06 19:04:17 UTC (rev 280731)
+++ trunk/Source/WebCore/ChangeLog 2021-08-06 19:06:15 UTC (rev 280732)
@@ -1,5 +1,19 @@
2021-08-06 Youenn Fablet
+[GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled
+https://bugs.webkit.org/show_bug.cgi?id=228759
+
+
+Reviewed by Geoffrey Garen.
+
+Revert part of https://trac.webkit.org/changeset/279940/webkit.
+
+* platform/mediastream/RealtimeVideoSource.cpp:
+(WebCore::RealtimeVideoSource::sourceSettingsChanged):
+Covered by API test.
+
+2021-08-06 Youenn Fablet
+
WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash
https://bugs.webkit.org/show_bug.cgi?id=228824
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp (280731 => 280732)
--- trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp 2021-08-06 19:04:17 UTC (rev 280731)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeVideoSource.cpp 2021-08-06 19:06:15 UTC (rev 280732)
@@ -112,7 +112,10 @@
void RealtimeVideoSource::sourceSettingsChanged()
{
auto rotation = m_source->sampleRotation();
-auto size = m_source->size();
+auto size = this->size();
+if (size.isEmpty())
+size = m_source->size();
+
if (rotation == MediaSample::VideoRotation::Left || rotation == MediaSample::VideoRotation::Right)
size = size.transposedSize();
Modified: trunk/Tools/ChangeLog (280731 => 280732)
--- trunk/Tools/ChangeLog 2021-08-06 19:04:17 UTC (rev 280731)
+++ trunk/Tools/ChangeLog 2021-08-06 19:06:15 UTC (rev 280732)
@@ -1,3 +1,14 @@
+2021-08-06 Youenn Fablet
+
+[GPUP] Test WebKit2.CrashGPUProcessAfterApplyingConstraints fails when Media in GPU Process is enabled
+https://bugs.webkit.org/show_bug.cgi?id=228759
+
+
+Reviewed by Geoffrey Garen.
+
+* TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
+Reenable test.
+
2021-08-06 Aakash Jain
[ews] Make config.json compact
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm (280731 => 280732)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2021-08-06 19:04:17 UTC (rev 280731)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit/GetUserMedia.mm 2021-08-06 19:06:15 UTC (rev 280732)
@@ -648,7 +648,7 @@
EXPECT_EQ(webViewPID, [webView _webProcessIdentifier]);
}
-TEST(WebKit2, DISABLED_CrashGPUProcessAfterApplyingConstraints)
+TEST(WebKit2, CrashGPUProcessAfterApplyingConstraints)
{
auto configuration = adoptNS([[WKWebViewConfiguration alloc] init]);
auto preferences = [configuration preferences];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280731] trunk/Source
Title: [280731] trunk/Source
Revision 280731
Author you...@apple.com
Date 2021-08-06 12:04:17 -0700 (Fri, 06 Aug 2021)
Log Message
WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash
https://bugs.webkit.org/show_bug.cgi?id=228824
Reviewed by Eric Carlson.
Source/WebCore:
Manually tested.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferDisplayLayerStatusDidChange):
Recreate a new layer if the previous one failed.
Source/WebKit:
Make WebKit::SampleBufferDisplayLayer listen to GPUProcess connection being closed.
When that happens, notify its client that it failed.
* WebProcess/GPU/GPUProcessConnection.cpp:
* WebProcess/GPU/GPUProcessConnection.h:
* WebProcess/GPU/media/RemoteMediaPlayerManager.cpp:
* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp:
(WebKit::SampleBufferDisplayLayer::create):
(WebKit::SampleBufferDisplayLayer::SampleBufferDisplayLayer):
(WebKit::SampleBufferDisplayLayer::~SampleBufferDisplayLayer):
(WebKit::SampleBufferDisplayLayer::setDidFail):
(WebKit::SampleBufferDisplayLayer::gpuProcessConnectionDidClose):
* WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h:
* WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp:
(WebKit::SampleBufferDisplayLayerManager::createLayer):
* WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp
trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.h
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.cpp
trunk/Source/WebKit/WebProcess/GPU/GPUProcessConnection.h
trunk/Source/WebKit/WebProcess/GPU/media/RemoteMediaPlayerManager.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayer.h
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.cpp
trunk/Source/WebKit/WebProcess/GPU/webrtc/SampleBufferDisplayLayerManager.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (280730 => 280731)
--- trunk/Source/WebCore/ChangeLog 2021-08-06 19:02:32 UTC (rev 280730)
+++ trunk/Source/WebCore/ChangeLog 2021-08-06 19:04:17 UTC (rev 280731)
@@ -1,3 +1,17 @@
+2021-08-06 Youenn Fablet
+
+WebKit::SampleBufferDisplayLayer needs to handle GPUProcess crash
+https://bugs.webkit.org/show_bug.cgi?id=228824
+
+
+Reviewed by Eric Carlson.
+
+Manually tested.
+
+* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferDisplayLayerStatusDidChange):
+Recreate a new layer if the previous one failed.
+
2021-08-06 Andres Gonzalez
Crash at WebKit::WebPage::requestTextRecognition caused by accessibility invocation.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h (280730 => 280731)
--- trunk/Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h 2021-08-06 19:02:32 UTC (rev 280730)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/SampleBufferDisplayLayer.h 2021-08-06 19:04:17 UTC (rev 280731)
@@ -43,7 +43,7 @@
class Client : public CanMakeWeakPtr {
public:
virtual ~Client() = default;
-virtual void sampleBufferDisplayLayerStatusDidChange(SampleBufferDisplayLayer&) = 0;
+virtual void sampleBufferDisplayLayerStatusDidFail() = 0;
};
WEBCORE_EXPORT static std::unique_ptr create(Client&);
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm (280730 => 280731)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm 2021-08-06 19:02:32 UTC (rev 280730)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm 2021-08-06 19:04:17 UTC (rev 280731)
@@ -207,11 +207,8 @@
void LocalSampleBufferDisplayLayer::layerStatusDidChange()
{
ASSERT(isMainThread());
-if (m_sampleBufferDisplayLayer.get().status != AVQueuedSampleBufferRenderingStatusRendering)
-return;
-if (!m_client)
-return;
-m_client->sampleBufferDisplayLayerStatusDidChange(*this);
+if (m_client && m_sampleBufferDisplayLayer.get().status == AVQueuedSampleBufferRenderingStatusFailed)
+m_client->sampleBufferDisplayLayerStatusDidFail();
}
void LocalSampleBufferDisplayLayer::layerErrorDidChange()
Modified:
[webkit-changes] [280730] branches/safari-612.1.27.0-branch/Source/WebKit
Title: [280730] branches/safari-612.1.27.0-branch/Source/WebKit
Revision 280730
Author alanc...@apple.com
Date 2021-08-06 12:02:32 -0700 (Fri, 06 Aug 2021)
Log Message
Cherry-pick r280722. rdar://problem/81618758
REGRESSION: ASSERTION FAILED: !DeprecatedGlobalSettings::shouldManageAudioSessionCategory() || AudioSession::sharedSession().category() == AudioSession::CategoryType::PlayAndRecord
https://bugs.webkit.org/show_bug.cgi?id=228847
Reviewed by Jer Noble.
No new tests, fixes a crashing test.
* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Restore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog
branches/safari-612.1.27.0-branch/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
Diff
Modified: branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog (280729 => 280730)
--- branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog 2021-08-06 18:24:12 UTC (rev 280729)
+++ branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog 2021-08-06 19:02:32 UTC (rev 280730)
@@ -1,3 +1,34 @@
+2021-08-06 Alan Coon
+
+Cherry-pick r280722. rdar://problem/81618758
+
+REGRESSION: ASSERTION FAILED: !DeprecatedGlobalSettings::shouldManageAudioSessionCategory() || AudioSession::sharedSession().category() == AudioSession::CategoryType::PlayAndRecord
+https://bugs.webkit.org/show_bug.cgi?id=228847
+
+
+Reviewed by Jer Noble.
+
+No new tests, fixes a crashing test.
+
+* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
+(WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Restore.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-06 Eric Carlson
+
+REGRESSION: ASSERTION FAILED: !DeprecatedGlobalSettings::shouldManageAudioSessionCategory() || AudioSession::sharedSession().category() == AudioSession::CategoryType::PlayAndRecord
+https://bugs.webkit.org/show_bug.cgi?id=228847
+
+
+Reviewed by Jer Noble.
+
+No new tests, fixes a crashing test.
+
+* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
+(WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Restore.
+
2021-08-06 Russell Epstein
Cherry-pick r280702. rdar://problem/81618758
Modified: branches/safari-612.1.27.0-branch/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp (280729 => 280730)
--- branches/safari-612.1.27.0-branch/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp 2021-08-06 18:24:12 UTC (rev 280729)
+++ branches/safari-612.1.27.0-branch/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp 2021-08-06 19:02:32 UTC (rev 280730)
@@ -100,6 +100,11 @@
CAAudioStreamDescription& description() { return m_description; }
int64_t numberOfFrames() { return m_numberOfFrames; }
+void audioUnitWillStart() final
+{
+AudioSession::sharedSession().setCategory(AudioSession::CategoryType::PlayAndRecord, RouteSharingPolicy::Default);
+}
+
void start()
{
m_shouldReset = true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280729] tags/Safari-612.1.26.1.4/
Title: [280729] tags/Safari-612.1.26.1.4/ Revision 280729 Author repst...@apple.com Date 2021-08-06 11:24:12 -0700 (Fri, 06 Aug 2021) Log Message Tag Safari-612.1.26.1.4. Added Paths tags/Safari-612.1.26.1.4/ Diff ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280728] branches/safari-612.1.26.1-branch/Source
Title: [280728] branches/safari-612.1.26.1-branch/Source Revision 280728 Author repst...@apple.com Date 2021-08-06 11:19:49 -0700 (Fri, 06 Aug 2021) Log Message Versioning. WebKit-7612.1.26.1.4 Modified Paths branches/safari-612.1.26.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig branches/safari-612.1.26.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig branches/safari-612.1.26.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig branches/safari-612.1.26.1-branch/Source/WebCore/Configurations/Version.xcconfig branches/safari-612.1.26.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig branches/safari-612.1.26.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig branches/safari-612.1.26.1-branch/Source/WebKit/Configurations/Version.xcconfig branches/safari-612.1.26.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig Diff Modified: branches/safari-612.1.26.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (280727 => 280728) --- branches/safari-612.1.26.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-08-06 16:52:46 UTC (rev 280727) +++ branches/safari-612.1.26.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig 2021-08-06 18:19:49 UTC (rev 280728) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 26; MICRO_VERSION = 1; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.26.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (280727 => 280728) --- branches/safari-612.1.26.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-08-06 16:52:46 UTC (rev 280727) +++ branches/safari-612.1.26.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig 2021-08-06 18:19:49 UTC (rev 280728) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 26; MICRO_VERSION = 1; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.26.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (280727 => 280728) --- branches/safari-612.1.26.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-08-06 16:52:46 UTC (rev 280727) +++ branches/safari-612.1.26.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig 2021-08-06 18:19:49 UTC (rev 280728) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 26; MICRO_VERSION = 1; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.26.1-branch/Source/WebCore/Configurations/Version.xcconfig (280727 => 280728) --- branches/safari-612.1.26.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-08-06 16:52:46 UTC (rev 280727) +++ branches/safari-612.1.26.1-branch/Source/WebCore/Configurations/Version.xcconfig 2021-08-06 18:19:49 UTC (rev 280728) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 26; MICRO_VERSION = 1; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.26.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (280727 => 280728) --- branches/safari-612.1.26.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-08-06 16:52:46 UTC (rev 280727) +++ branches/safari-612.1.26.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig 2021-08-06 18:19:49 UTC (rev 280728) @@ -25,7 +25,7 @@ MINOR_VERSION = 1; TINY_VERSION = 26; MICRO_VERSION = 1; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION).$(NANO_VERSION); // The bundle version and short version string are set based on the current build configuration, see below. Modified: branches/safari-612.1.26.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (280727 => 280728) --- branches/safari-612.1.26.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-08-06 16:52:46 UTC (rev 280727) +++ branches/safari-612.1.26.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig 2021-08-06 18:19:49 UTC (rev 280728) @@ -2,7 +2,7 @@ MINOR_VERSION = 1; TINY_VERSION = 26; MICRO_VERSION = 1; -NANO_VERSION = 3; +NANO_VERSION = 4; FULL_VERSION =
[webkit-changes] [280727] trunk/Source/WebCore
Title: [280727] trunk/Source/WebCore
Revision 280727
Author andresg...@apple.com
Date 2021-08-06 09:52:46 -0700 (Fri, 06 Aug 2021)
Log Message
Crash at WebKit::WebPage::requestTextRecognition caused by accessibility invocation.
https://bugs.webkit.org/show_bug.cgi?id=228864
rdar://80679512
Reviewed by Chris Fleizach.
* accessibility/AXImage.cpp:
(WebCore::AXImage::imageOverlayElements):
It was calling requestTextRecognition with *element(), but element() can
return nullptr, which would lead to the crash.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AXImage.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (280726 => 280727)
--- trunk/Source/WebCore/ChangeLog 2021-08-06 16:38:28 UTC (rev 280726)
+++ trunk/Source/WebCore/ChangeLog 2021-08-06 16:52:46 UTC (rev 280727)
@@ -1,3 +1,16 @@
+2021-08-06 Andres Gonzalez
+
+Crash at WebKit::WebPage::requestTextRecognition caused by accessibility invocation.
+https://bugs.webkit.org/show_bug.cgi?id=228864
+rdar://80679512
+
+Reviewed by Chris Fleizach.
+
+* accessibility/AXImage.cpp:
+(WebCore::AXImage::imageOverlayElements):
+It was calling requestTextRecognition with *element(), but element() can
+return nullptr, which would lead to the crash.
+
2021-08-06 Jer Noble
[Cocoa] Remove support for AVAssetImageGenerator
Modified: trunk/Source/WebCore/accessibility/AXImage.cpp (280726 => 280727)
--- trunk/Source/WebCore/accessibility/AXImage.cpp 2021-08-06 16:38:28 UTC (rev 280726)
+++ trunk/Source/WebCore/accessibility/AXImage.cpp 2021-08-06 16:52:46 UTC (rev 280727)
@@ -67,7 +67,11 @@
if (!page)
return std::nullopt;
-page->chrome().client().requestTextRecognition(*element(), [] (RefPtr&& imageOverlayHost) {
+auto* element = this->element();
+if (!element)
+return std::nullopt;
+
+page->chrome().client().requestTextRecognition(*element, [] (RefPtr&& imageOverlayHost) {
if (!imageOverlayHost)
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280726] trunk
Title: [280726] trunk Revision 280726 Author peng.l...@apple.com Date 2021-08-06 09:38:28 -0700 (Fri, 06 Aug 2021) Log Message [macOS] Clean up Feature Flags related code https://bugs.webkit.org/show_bug.cgi?id=228803 Reviewed by Tim Horton. Source/WebKit: On macOS, Safari Technology Preview or a local build WebKit/Safari will always get the default preference values through the "Feature Flags" SPI. Unfortunately, this approach won't work if the OS does not provide correct default preference values. With this patch, we only get default preference values with the SPI for system WebKit on macOS. For all other cases, we use hardcoded values. So that WebKit will always get the correct default preference values. This patch also fixes a few mistakes in two preferences: "webm_webaudio" and "vp8_decoder". * FeatureFlags/WebKit-appletvos.plist: * FeatureFlags/WebKit-ios.plist: * FeatureFlags/WebKit-macos.plist: * FeatureFlags/WebKit-watchos.plist: * Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm: (WebKit::isFeatureFlagEnabled): * Shared/WebPreferencesDefaultValues.cpp: (WebKit::isFeatureFlagEnabled): (WebKit::defaultAsyncFrameAndOverflowScrollingEnabled): (WebKit::defaultUseGPUProcessForCanvasRenderingEnabled): (WebKit::defaultUseGPUProcessForDOMRenderingEnabled): (WebKit::defaultUseGPUProcessForMediaEnabled): (WebKit::defaultUseGPUProcessForWebGLEnabled): (WebKit::defaultCaptureAudioInGPUProcessEnabled): (WebKit::defaultCaptureVideoInGPUProcessEnabled): (WebKit::defaultWebRTCCodecsInGPUProcess): (WebKit::defaultIncrementalPDFEnabled): (WebKit::defaultWebMFormatReaderEnabled): (WebKit::defaultVP8DecoderEnabled): (WebKit::defaultVP9DecoderEnabled): (WebKit::defaultVP9SWDecoderEnabledOnBattery): (WebKit::defaultWebMParserEnabled): (WebKit::defaultWebMWebAudioEnabled): (WebKit::defaultInAppBrowserPrivacy): Deleted. * Shared/WebPreferencesDefaultValues.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::creationParameters): Fix a typo. Source/WebKitLegacy/mac: On macOS, Safari Technology Preview or a local build WebKit/Safari will always get the default preference values through the "Feature Flags" SPI. Unfortunately, this approach won't work if the OS does not provide correct default preference values. With this patch, we only get default preference values with the SPI for system WebKit on macOS. For all other cases, we use hardcoded values. So that WebKit will always get the correct default preference values. This patch also fixes a few mistakes in two preferences: "webm_webaudio" and "vp8_decoder". * WebView/WebPreferencesDefaultValues.h: * WebView/WebPreferencesDefaultValues.mm: (WebKit::isFeatureFlagEnabled): (WebKit::defaultIncrementalPDFEnabled): (WebKit::defaultWebXREnabled): (WebKit::defaultWebMParserEnabled): (WebKit::defaultWebMWebAudioEnabled): (WebKit::defaultVP8DecoderEnabled): (WebKit::defaultVP9DecoderEnabled): LayoutTests: Update a mac-bigsur specific test expectation file because the test is passing now. * platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt: Removed. * platform/mac-bigsur/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-bigsur/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist trunk/Source/WebKit/Shared/Cocoa/WebPreferencesDefaultValuesCocoa.mm trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h trunk/Source/WebKit/UIProcess/WebPageProxy.cpp trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.h trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesDefaultValues.mm Removed Paths trunk/LayoutTests/platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (280725 => 280726) --- trunk/LayoutTests/ChangeLog 2021-08-06 16:25:55 UTC (rev 280725) +++ trunk/LayoutTests/ChangeLog 2021-08-06 16:38:28 UTC (rev 280726) @@ -1,3 +1,16 @@ +2021-08-06 Peng Liu + +[macOS] Clean up Feature Flags related code +https://bugs.webkit.org/show_bug.cgi?id=228803 + + +Reviewed by Tim Horton. + +Update a mac-bigsur specific test expectation file because the test is passing now. + +* platform/mac/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt: Removed. +* platform/mac-bigsur/imported/w3c/web-platform-tests/media-source/mediasource-addsourcebuffer-expected.txt: + 2021-08-06 Antti Koivisto REGRESSION (r274038): Keyframe animation with
[webkit-changes] [280725] trunk/Tools
Title: [280725] trunk/Tools
Revision 280725
Author aakash_j...@apple.com
Date 2021-08-06 09:25:55 -0700 (Fri, 06 Aug 2021)
Log Message
[ews] Make config.json compact
https://bugs.webkit.org/show_bug.cgi?id=228862
Reviewed by Jonathan Bedard.
* CISupport/ews-build/config.json:
Modified Paths
trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/config.json (280724 => 280725)
--- trunk/Tools/CISupport/ews-build/config.json 2021-08-06 16:03:29 UTC (rev 280724)
+++ trunk/Tools/CISupport/ews-build/config.json 2021-08-06 16:25:55 UTC (rev 280725)
@@ -1,744 +1,329 @@
{
"workers": [
-{
- "name": "webkit-misc",
- "platform": "*",
- "max_builds": 3
-},
-{
- "name": "igalia-jsc32-armv7-ews",
- "platform": "jsc-only"
-},
-{
- "name": "igalia-jsc32-armv7-ews-02",
- "platform": "jsc-only"
-},
-{
- "name": "igalia-jsc32-mipsel-ews",
- "platform": "jsc-only"
-},
-{
- "name": "igalia-jsc32-mipsel-ews-02",
- "platform": "jsc-only"
-},
-{
- "name": "igalia-jsc32-mipsel-ews-03",
- "platform": "jsc-only"
-},
-{
- "name": "igalia-jsc32-i386-ews",
- "platform": "jsc-only"
-},
-{
- "name": "igalia1-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia2-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia3-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia4-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia5-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia6-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia7-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia8-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia9-gtk-wk2-ews",
- "platform": "gtk"
-},
-{
- "name": "aperez-gtk-ews",
- "platform": "gtk"
-},
-{
- "name": "igalia-wpe-ews",
- "platform": "wpe"
-},
-{
- "name": "aperez-wpe-ews",
- "platform": "wpe"
-},
-{
- "name": "wincairo-ews-001",
- "platform": "wincairo"
-},
-{
- "name": "wincairo-ews-002",
- "platform": "wincairo"
-},
-{
- "name": "wincairo-ews-003",
- "platform": "wincairo"
-},
-{
- "name": "wincairo-ews-004",
- "platform": "wincairo"
-},
-{
- "name": "ews100",
- "platform": "mac-catalina"
-},
-{
- "name": "ews101",
- "platform": "mac-catalina"
-},
-{
- "name": "ews102",
- "platform": "mac-catalina"
-},
-{
- "name": "ews103",
- "platform": "mac-catalina"
-},
-{
- "name": "ews104",
- "platform": "mac-catalina"
-},
-{
- "name": "ews105",
- "platform": "mac-catalina"
-},
-{
- "name": "ews106",
- "platform": "mac-catalina"
-},
-{
- "name": "ews107",
- "platform": "mac-catalina"
-},
-{
- "name": "ews108",
- "platform": "ios-14"
-},
-{
- "name": "ews109",
- "platform": "*"
-},
-{
- "name": "ews112",
- "platform": "mac-catalina"
-},
-{
- "name": "ews113",
- "platform": "mac-catalina"
-},
-{
- "name": "ews114",
- "platform": "mac-catalina"
-},
-{
- "name": "ews115",
- "platform": "mac-catalina"
-},
-{
- "name": "ews116",
- "platform": "mac-catalina"
-},
-{
- "name": "ews117",
- "platform": "mac-catalina"
-},
-{
- "name": "ews118",
- "platform": "mac-catalina"
-},
-{
- "name": "ews119",
- "platform": "mac-catalina"
-},
-{
- "name": "ews120",
- "platform": "mac-catalina"
-},
-{
- "name": "ews121",
- "platform": "ios-simulator-14"
-},
-{
- "name": "ews122",
- "platform": "ios-simulator-14"
-},
-{
- "name": "ews123",
- "platform": "ios-simulator-14"
-},
-{
- "name": "ews124",
- "platform": "ios-simulator-14"
-},
-{
- "name": "ews125",
- "platform": "ios-simulator-14"
-},
-{
- "name": "ews126",
- "platform": "ios-simulator-14"
-},
-{
- "name": "ews127",
- "platform": "mac-catalina"
-},
-{
- "name": "ews128",
- "platform": "mac-catalina"
-},
-{
- "name": "ews150",
- "platform": "*"
-},
-{
- "name": "ews151",
- "platform": "*",
- "max_builds": 3
-},
-{
- "name": "ews152",
- "platform": "*"
-},
-{
- "name": "ews153",
- "platform": "*"
-},
-{
- "name": "ews154",
- "platform": "*"
-},
-{
- "name": "ews155",
- "platform": "*"
-},
-{
- "name": "ews156",
- "platform": "*"
-},
-
[webkit-changes] [280724] branches/safari-612.1.27.0-branch/Source
Title: [280724] branches/safari-612.1.27.0-branch/Source Revision 280724 Author repst...@apple.com Date 2021-08-06 09:03:29 -0700 (Fri, 06 Aug 2021) Log Message Cherry-pick r280702. rdar://problem/81618758 [iOS] getUserMedia sometimes doesn't capture from specified microphone https://bugs.webkit.org/show_bug.cgi?id=228753 rdar://79704226 Reviewed by Youenn Fablet. Source/WebCore: The system will always choose the "default" audio input source unless +[AVAudioSession setPreferredInput:error:] is called first, and that only works if the audio session category has been set to PlayAndRecord *before* it is called, so configure the audio session for recording before we choose and configure the audio capture device. Tested manually, this only reproduces on hardware. * platform/audio/PlatformMediaSessionManager.cpp: (WebCore::PlatformMediaSessionManager::activeAudioSessionRequired const): Audio capture requires an active audio session. (WebCore::PlatformMediaSessionManager::removeSession): Move `#if USE(AUDIO_SESSION)` guard inside of maybeDeactivateAudioSession so it isn't spread throughout the file. (WebCore::PlatformMediaSessionManager::sessionWillBeginPlayback): Ditto. (WebCore::PlatformMediaSessionManager::processWillSuspend): Ditto. (WebCore::PlatformMediaSessionManager::processDidResume): Ditto. (WebCore::PlatformMediaSessionManager::sessionCanProduceAudioChanged): Add logging, call `maybeActivateAudioSession()` so we activate the audio session if necessary. (WebCore::PlatformMediaSessionManager::addAudioCaptureSource): Call updateSessionState instead of scheduleUpdateSessionState so the audio session category is updated immediately. (WebCore::PlatformMediaSessionManager::maybeDeactivateAudioSession): Move `#if USE(AUDIO_SESSION)` into the function so it doesn't need to be spread throughout the file. (WebCore::PlatformMediaSessionManager::maybeActivateAudioSession): Ditto. * platform/audio/PlatformMediaSessionManager.h: (WebCore::PlatformMediaSessionManager::isApplicationInBackground const): * platform/audio/ios/AudioSessionIOS.mm: (WebCore::AudioSessionIOS::setPreferredBufferSize): Log an error if we are unable to set the preferred buffer size. * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h: * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm: (WebCore::AVAudioSessionCaptureDeviceManager::setPreferredAudioSessionDeviceUID): New, set the preferred input so capture will use select the device we want. (WebCore::AVAudioSessionCaptureDeviceManager::scheduleUpdateCaptureDevices): Remove m_recomputeDevices, `setAudioCaptureDevices` has been restructured so we don't need it. (WebCore::AVAudioSessionCaptureDeviceManager::computeCaptureDevices): Ditto. (WebCore::AVAudioSessionCaptureDeviceManager::setAudioCaptureDevices): Don't update the list of capture devices when the default device changes, only when a device is added, removed, enabled, or disabled. * platform/mediastream/mac/CoreAudioCaptureSource.cpp: (WebCore::CoreAudioSharedUnit::setCaptureDevice): Call `setPreferredAudioSessionDeviceUID` so the correct device is selected. (WebCore::CoreAudioSharedUnit::cleanupAudioUnit): Clear m_persistentID. (WebCore::CoreAudioCaptureSource::create): Return an error with a string, or the web process can detect a failure. (WebCore::CoreAudioCaptureSource::stopProducingData): Add logging. Source/WebKit: * UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp: Re (WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Delete, we don't need it now that the web process configures the audio session before capture begins. git-svn-id: https://svn.webkit.org/repository/webkit/trunk@280702 268f45cc-cd09-0410-ab3c-d52691b4dbfc Modified Paths branches/safari-612.1.27.0-branch/Source/WebCore/ChangeLog branches/safari-612.1.27.0-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp branches/safari-612.1.27.0-branch/Source/WebCore/platform/audio/PlatformMediaSessionManager.h branches/safari-612.1.27.0-branch/Source/WebCore/platform/audio/ios/AudioSessionIOS.mm branches/safari-612.1.27.0-branch/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.h branches/safari-612.1.27.0-branch/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm branches/safari-612.1.27.0-branch/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp branches/safari-612.1.27.0-branch/Source/WebKit/ChangeLog branches/safari-612.1.27.0-branch/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp Diff Modified: branches/safari-612.1.27.0-branch/Source/WebCore/ChangeLog (280723 => 280724) --- branches/safari-612.1.27.0-branch/Source/WebCore/ChangeLog 2021-08-06 15:09:20 UTC (rev 280723) +++
[webkit-changes] [280723] trunk/Source
Title: [280723] trunk/Source Revision 280723 Author jer.no...@apple.com Date 2021-08-06 08:09:20 -0700 (Fri, 06 Aug 2021) Log Message [Cocoa] Remove support for AVAssetImageGenerator https://bugs.webkit.org/show_bug.cgi?id=228560 Reviewed by Eric Carlson. Source/WebCore: A much more minimal approach to removing support for AVAssetImageGenerator. The only time we use an AVAssetImageGenerator (as opposed to an AVPlayerItemVideoOutput) is when the latter does not currently have an available image enqueued. Because painting is a synchronous operation, we use a synchronous API (the generator) to create an image for that operation. However, this can create deadlocks if (for example) the resource needs to load data on the main thread in order to complete the painting operation. Instead, allow the main runloop to spin while waiting (up to 1_s) for the video output to receive a decoded frame. Drive-by fixes: - Don't create an AVPlayerLayer at AVPlayer-creation; this causes the AVPlayerItemVideoOutput to never receive a decoded frambe (as the layer is not in a CALayer-heirarchy). - preferredRenderingMode() shouldn't be "none" when the page isn't visible. We already just mark the layer as "hidden" in that case. - Don't tear down the AVPlayerItemVideoOutput when creating an AVPlayerLayer; it'll just get re-created anyway. * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: (WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const): (WebCore::MediaPlayerPrivateAVFoundation::setUpVideoRendering): * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): (WebCore::MediaPlayerPrivateAVFoundationObjC::paintCurrentFrameInContext): (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): (WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput): (WebCore::MediaPlayerPrivateAVFoundationObjC::waitForVideoOutputMediaDataWillChange): (WebCore::MediaPlayerPrivateAVFoundationObjC::outputMediaDataWillChange): (-[WebCoreAVFPullDelegate outputMediaDataWillChange:]): (-[WebCoreAVFPullDelegate setParent:]): Source/WebKit: Drive-by fix: we're passing the wrong value into acceleratedRenderingStateChanged(), and we're not setting the correct initial value on MediaPlayerPrivateRemote creation. * GPUProcess/media/RemoteMediaPlayerProxy.h: * WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp: (WebKit::MediaPlayerPrivateRemote::MediaPlayerPrivateRemote): (WebKit::MediaPlayerPrivateRemote::acceleratedRenderingStateChanged): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.h trunk/Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (280722 => 280723) --- trunk/Source/WebCore/ChangeLog 2021-08-06 15:04:13 UTC (rev 280722) +++ trunk/Source/WebCore/ChangeLog 2021-08-06 15:09:20 UTC (rev 280723) @@ -1,3 +1,44 @@ +2021-08-06 Jer Noble + +[Cocoa] Remove support for AVAssetImageGenerator +https://bugs.webkit.org/show_bug.cgi?id=228560 + + +Reviewed by Eric Carlson. + +A much more minimal approach to removing support for AVAssetImageGenerator. + +The only time we use an AVAssetImageGenerator (as opposed to an AVPlayerItemVideoOutput) +is when the latter does not currently have an available image enqueued. Because painting +is a synchronous operation, we use a synchronous API (the generator) to create an image +for that operation. However, this can create deadlocks if (for example) the resource needs +to load data on the main thread in order to complete the painting operation. + +Instead, allow the main runloop to spin while waiting (up to 1_s) for the video output +to receive a decoded frame. + +Drive-by fixes: +- Don't create an AVPlayerLayer at AVPlayer-creation; this causes the AVPlayerItemVideoOutput + to never receive a decoded frambe (as the layer is not in a CALayer-heirarchy). +- preferredRenderingMode() shouldn't be "none" when the page isn't visible. We already + just mark the layer as "hidden" in that case. +- Don't tear down the AVPlayerItemVideoOutput when creating an AVPlayerLayer; it'll just + get re-created anyway. + +* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp: +(WebCore::MediaPlayerPrivateAVFoundation::preferredRenderingMode const): +
[webkit-changes] [280722] trunk/Source/WebKit
Title: [280722] trunk/Source/WebKit
Revision 280722
Author eric.carl...@apple.com
Date 2021-08-06 08:04:13 -0700 (Fri, 06 Aug 2021)
Log Message
REGRESSION: ASSERTION FAILED: !DeprecatedGlobalSettings::shouldManageAudioSessionCategory() || AudioSession::sharedSession().category() == AudioSession::CategoryType::PlayAndRecord
https://bugs.webkit.org/show_bug.cgi?id=228847
Reviewed by Jer Noble.
No new tests, fixes a crashing test.
* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
(WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Restore.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (280721 => 280722)
--- trunk/Source/WebKit/ChangeLog 2021-08-06 13:42:59 UTC (rev 280721)
+++ trunk/Source/WebKit/ChangeLog 2021-08-06 15:04:13 UTC (rev 280722)
@@ -1,3 +1,16 @@
+2021-08-06 Eric Carlson
+
+REGRESSION: ASSERTION FAILED: !DeprecatedGlobalSettings::shouldManageAudioSessionCategory() || AudioSession::sharedSession().category() == AudioSession::CategoryType::PlayAndRecord
+https://bugs.webkit.org/show_bug.cgi?id=228847
+
+
+Reviewed by Jer Noble.
+
+No new tests, fixes a crashing test.
+
+* UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:
+(WebKit::UserMediaCaptureManagerProxy::SourceProxy::audioUnitWillStart): Restore.
+
2021-08-05 Kate Cheney
LoadWebArchive.FailNavigation1 test is a false positive
Modified: trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp (280721 => 280722)
--- trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp 2021-08-06 13:42:59 UTC (rev 280721)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp 2021-08-06 15:04:13 UTC (rev 280722)
@@ -100,6 +100,11 @@
CAAudioStreamDescription& description() { return m_description; }
int64_t numberOfFrames() { return m_numberOfFrames; }
+void audioUnitWillStart() final
+{
+AudioSession::sharedSession().setCategory(AudioSession::CategoryType::PlayAndRecord, RouteSharingPolicy::Default);
+}
+
void start()
{
m_shouldReset = true;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [280721] trunk
Title: [280721] trunk
Revision 280721
Author an...@apple.com
Date 2021-08-06 06:42:59 -0700 (Fri, 06 Aug 2021)
Log Message
REGRESSION (r274038): Keyframe animation with top/left with percentages fails to animate
https://bugs.webkit.org/show_bug.cgi?id=228811
Reviewed by Alan Bujtas.
LayoutTests/imported/w3c:
* web-platform-tests/css/css-position/animations/bottom-composition-expected.txt:
* web-platform-tests/css/css-position/animations/left-composition-expected.txt:
* web-platform-tests/css/css-position/animations/right-composition-expected.txt:
* web-platform-tests/css/css-position/animations/top-composition-expected.txt:
Source/WebCore:
r274038 ended up disabling interpolation of percent values for top/left/bottom/right.
Test: animations/top-left-percent-interpolation.html
* animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
Enable them.
LayoutTests:
* animations/top-left-percent-interpolation-expected.txt: Added.
* animations/top-left-percent-interpolation.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/animations/bottom-composition-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/animations/left-composition-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/animations/right-composition-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-position/animations/top-composition-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp
Added Paths
trunk/LayoutTests/animations/top-left-percent-interpolation-expected.txt
trunk/LayoutTests/animations/top-left-percent-interpolation.html
Diff
Modified: trunk/LayoutTests/ChangeLog (280720 => 280721)
--- trunk/LayoutTests/ChangeLog 2021-08-06 09:15:49 UTC (rev 280720)
+++ trunk/LayoutTests/ChangeLog 2021-08-06 13:42:59 UTC (rev 280721)
@@ -1,3 +1,14 @@
+2021-08-06 Antti Koivisto
+
+REGRESSION (r274038): Keyframe animation with top/left with percentages fails to animate
+https://bugs.webkit.org/show_bug.cgi?id=228811
+
+
+Reviewed by Alan Bujtas.
+
+* animations/top-left-percent-interpolation-expected.txt: Added.
+* animations/top-left-percent-interpolation.html: Added.
+
2021-08-06 Youenn Fablet
MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible
Added: trunk/LayoutTests/animations/top-left-percent-interpolation-expected.txt (0 => 280721)
--- trunk/LayoutTests/animations/top-left-percent-interpolation-expected.txt (rev 0)
+++ trunk/LayoutTests/animations/top-left-percent-interpolation-expected.txt 2021-08-06 13:42:59 UTC (rev 280721)
@@ -0,0 +1,5 @@
+PASS - "left" property for "box1" element at 0.5s saw something close to: 100
+PASS - "top" property for "box1" element at 0.5s saw something close to: 100
+PASS - "right" property for "box2" element at 0.5s saw something close to: 100
+PASS - "bottom" property for "box2" element at 0.5s saw something close to: 100
+
Added: trunk/LayoutTests/animations/top-left-percent-interpolation.html (0 => 280721)
--- trunk/LayoutTests/animations/top-left-percent-interpolation.html (rev 0)
+++ trunk/LayoutTests/animations/top-left-percent-interpolation.html 2021-08-06 13:42:59 UTC (rev 280721)
@@ -0,0 +1,62 @@
+
+#container {
+ border: 2px solid blue;
+ width:200px;
+ height:200px;
+ position:relative;
+}
+
+#box1 {
+ position: absolute;
+ top: 0;
+ left: 0;
+ width: 100px;
+ height: 100px;
+ background: blue;
+
+ animation: top-left 1s linear;
+}
+
+#box2 {
+ position: absolute;
+ bottom: 0;
+ right: 0;
+ width: 100px;
+ height: 100px;
+ background: green;
+
+ animation: bottom-right 1s linear;
+}
+
+@keyframes top-left {
+ 100% {
+ top: 100%;
+ left: 100%;
+ }
+}
+@keyframes bottom-right {
+ 100% {
+ bottom: 100%;
+ right: 100%;
+ }
+}
+
+
+
+const expectedValues = [
+// [animation-name, time, element-id, property, expected-value, tolerance]
+["top-left", 0.5, "box1", "left", 100, 20],
+["top-left", 0.5, "box1", "top", 100, 20],
+["bottom-right", 0.5, "box2", "right", 100, 20],
+["bottom-right", 0.5, "box2", "bottom", 100, 20],
+];
+
+runAnimationTest(expectedValues);
+
+
+
+
+
+
+
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (280720 => 280721)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-06 09:15:49 UTC (rev 280720)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-08-06 13:42:59 UTC (rev 280721)
@@ -1,3 +1,16 @@
+2021-08-06 Antti Koivisto
+
+REGRESSION (r274038): Keyframe animation with top/left with percentages fails to animate
+https://bugs.webkit.org/show_bug.cgi?id=228811
+
+
+Reviewed by Alan Bujtas.
+
+*
[webkit-changes] [280720] trunk
Title: [280720] trunk
Revision 280720
Author you...@apple.com
Date 2021-08-06 02:15:49 -0700 (Fri, 06 Aug 2021)
Log Message
MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible
https://bugs.webkit.org/show_bug.cgi?id=228816
Reviewed by Eric Carlson.
Source/WebCore:
Do not create layers when not needed.
This prevents enqueuing frames in a AVSampleBufferDisplayLayer that will only buffer them, thus breaking camera capture/video decoding.
We do this by not calling ensureLayers when getting a new track. Instead we react upon player renderingCanBeAccelerated value.
It is also unnecessary and takes CPU cycles to enqueue frames when the video element is not visible.
HTMLMediaElement and RenderVideo thus pass to MediaPlayer a new flag telling whether the video element is visible in the view port.
MediaPlayerPrivateMediaStreamAVFObjC will then skip enqueueing frames if not needed.
Add getter and internals API to cover these changes.
Test: fast/mediastream/mediaPlayer-visibility.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isVisibleInViewportChanged):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::setVisibleInViewport):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setVisibleInViewport):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisible):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVisibleInViewport):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::checkSelectedVideoTrack):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext):
* rendering/RenderVideo.cpp:
(WebCore::RenderVideo::updatePlayer):
* testing/Internals.cpp:
(WebCore::Internals::isPlayerVisibleInViewport const):
* testing/Internals.h:
* testing/Internals.idl:
LayoutTests:
* fast/mediastream/mediaPlayer-visibility-expected.txt: Added.
* fast/mediastream/mediaPlayer-visibility.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.cpp
trunk/Source/WebCore/platform/graphics/MediaPlayer.h
trunk/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h
trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm
trunk/Source/WebCore/rendering/RenderVideo.cpp
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
Added Paths
trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility-expected.txt
trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility.html
Diff
Modified: trunk/LayoutTests/ChangeLog (280719 => 280720)
--- trunk/LayoutTests/ChangeLog 2021-08-06 03:30:45 UTC (rev 280719)
+++ trunk/LayoutTests/ChangeLog 2021-08-06 09:15:49 UTC (rev 280720)
@@ -1,3 +1,14 @@
+2021-08-06 Youenn Fablet
+
+MediaPlayerPrivateMediaStreamAVFObjC should skip enqueuing frames when not visible
+https://bugs.webkit.org/show_bug.cgi?id=228816
+
+
+Reviewed by Eric Carlson.
+
+* fast/mediastream/mediaPlayer-visibility-expected.txt: Added.
+* fast/mediastream/mediaPlayer-visibility.html: Added.
+
2021-08-05 Ryan Haddad
Unreviewed test garening, skip test that is unsupported on WK1.
Added: trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility-expected.txt (0 => 280720)
--- trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility-expected.txt 2021-08-06 09:15:49 UTC (rev 280720)
@@ -0,0 +1,6 @@
+
+
+PASS Check default media stream player visibility
+PASS Check media stream player visibility with CSS
+PASS Check media stream player visibility of unattached media element
+
Added: trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility.html (0 => 280720)
--- trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility.html (rev 0)
+++ trunk/LayoutTests/fast/mediastream/mediaPlayer-visibility.html 2021-08-06 09:15:49 UTC (rev 280720)
@@ -0,0 +1,59 @@
+
+
+
+
+
+
+
+promise_test(async() => {
+if (!window.internals)
+ return Promise.reject("Test requires internals API");
+
+const stream = await navigator.mediaDevices.getUserMedia({video : true});
+video1.srcObject = stream;
+await video1.play();
+
+assert_true(internals.isPlayerVisibleInViewport(video1), "video1");
+}, "Check default media stream player visibility");
+
+promise_test(async() => {
+ if
