[webkit-changes] [282259] trunk/Source/JavaScriptCore

2021-09-09 Thread ross . kirsling 
Title: [282259] trunk/Source/_javascript_Core








Revision 282259
Author ross.kirsl...@sony.com
Date 2021-09-09 22:38:39 -0700 (Thu, 09 Sep 2021)


Log Message
[JSC] Clean up current state of Temporal API
https://bugs.webkit.org/show_bug.cgi?id=230130

Reviewed by Yusuke Suzuki.

This patch perfoms a variety of cleanup tasks following the implementation of Temporal.PlainTime.

  1. Do away with the alias Subdurations and refer to ISO8601::Duration directly.
 (But we can still say "subduration" when referring to a single ordered field, as in `largestSubduration`.)
  2. Represent ToTemporalDuration, ToTemporalDurationRecord, and ToLimitedTemporalDuration more directly in code,
 as TemporalDuration::{toTemporalDuration, fromDurationLike, toISO8601Duration}.
 (Note: The last of these doesn't take a disallowedFields parameter;
Temporal.Instant can do this after the fact, since no one else makes use of this functionality.)
  3. Extract intlOption into a helper function, `temporalRoundingMode`.
  4. Remove largestSubplainTime(), which was declared but not defined.
  5. Correct spelling of TemporalPlainTime::constrainTime().

* runtime/TemporalDuration.cpp:
(JSC::TemporalDuration::create):
(JSC::TemporalDuration::TemporalDuration):
(JSC::TemporalDuration::tryCreateIfValid):
(JSC::TemporalDuration::fromDurationLike): Added.
(JSC::TemporalDuration::toISO8601Duration): Added.
(JSC::TemporalDuration::toTemporalDuration): Added.
(JSC::TemporalDuration::from):
(JSC::totalNanoseconds):
(JSC::TemporalDuration::compare):
(JSC::TemporalDuration::sign):
(JSC::TemporalDuration::with const):
(JSC::TemporalDuration::negated const):
(JSC::TemporalDuration::abs const):
(JSC::largestSubduration): Added.
(JSC::TemporalDuration::balance):
(JSC::TemporalDuration::add const):
(JSC::TemporalDuration::subtract const):
(JSC::TemporalDuration::round):
(JSC::TemporalDuration::round const):
(JSC::TemporalDuration::total const):
(JSC::TemporalDuration::toString const):
(JSC::TemporalDuration::toString):
(JSC::TemporalDuration::fromNonDurationValue): Deleted.
(JSC::TemporalDuration::toDuration): Deleted.
(JSC::TemporalDuration::toDurationRecord): Deleted.
(JSC::TemporalDuration::largestSubduration const): Deleted.
* runtime/TemporalDuration.h:
* runtime/TemporalDurationConstructor.cpp:
* runtime/TemporalDurationPrototype.cpp:
* runtime/TemporalObject.cpp:
(JSC::temporalRoundingMode): Added.
* runtime/TemporalObject.h:
* runtime/TemporalPlainTime.cpp:
(JSC::TemporalPlainTime::round const):
(JSC::TemporalPlainTime::toString const):
(JSC::constrainTime): Added.
(JSC::regulateTime):
(JSC::TemporalPlainTime::add const):
(JSC::TemporalPlainTime::subtract const):
(JSC::extractDifferenceOptions):
(JSC::constraintTime): Deleted.
(JSC::toLimitedTemporalDuration): Deleted.
* runtime/TemporalPlainTime.h:

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/TemporalDuration.cpp
trunk/Source/_javascript_Core/runtime/TemporalDuration.h
trunk/Source/_javascript_Core/runtime/TemporalDurationConstructor.cpp
trunk/Source/_javascript_Core/runtime/TemporalDurationPrototype.cpp
trunk/Source/_javascript_Core/runtime/TemporalObject.cpp
trunk/Source/_javascript_Core/runtime/TemporalObject.h
trunk/Source/_javascript_Core/runtime/TemporalPlainTime.cpp
trunk/Source/_javascript_Core/runtime/TemporalPlainTime.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (282258 => 282259)

--- trunk/Source/_javascript_Core/ChangeLog	2021-09-10 03:56:08 UTC (rev 282258)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-09-10 05:38:39 UTC (rev 282259)
@@ -1,3 +1,67 @@
+2021-09-09  Ross Kirsling  
+
+[JSC] Clean up current state of Temporal API
+https://bugs.webkit.org/show_bug.cgi?id=230130
+
+Reviewed by Yusuke Suzuki.
+
+This patch perfoms a variety of cleanup tasks following the implementation of Temporal.PlainTime.
+
+  1. Do away with the alias Subdurations and refer to ISO8601::Duration directly.
+ (But we can still say "subduration" when referring to a single ordered field, as in `largestSubduration`.)
+  2. Represent ToTemporalDuration, ToTemporalDurationRecord, and ToLimitedTemporalDuration more directly in code,
+ as TemporalDuration::{toTemporalDuration, fromDurationLike, toISO8601Duration}.
+ (Note: The last of these doesn't take a disallowedFields parameter;
+Temporal.Instant can do this after the fact, since no one else makes use of this functionality.)
+  3. Extract intlOption into a helper function, `temporalRoundingMode`.
+  4. Remove largestSubplainTime(), which was declared but not defined.
+  5. Correct spelling of TemporalPlainTime::constrainTime().
+
+* runtime/TemporalDuration.cpp:
+(JSC::TemporalDuration::create):
+(JSC::TemporalDuration::TemporalDuration):
+(JSC::TemporalDuration::tryCreateIfValid):
+

[webkit-changes] [282258] trunk/Source/WebKit

2021-09-09 Thread commit-queue 
Title: [282258] trunk/Source/WebKit








Revision 282258
Author commit-qu...@webkit.org
Date 2021-09-09 20:56:08 -0700 (Thu, 09 Sep 2021)


Log Message
Modernize CertificateInfo decoder
https://bugs.webkit.org/show_bug.cgi?id=230125

Patch by Alex Christensen  on 2021-09-09
Reviewed by Chris Dumez.

Return std::optional instead of bool.

* Shared/WebCoreArgumentCoders.cpp:
* Shared/WebCoreArgumentCoders.h:
* Shared/cf/ArgumentCodersCF.cpp:
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
(IPC::ArgumentCoder>::decode):
* Shared/cf/ArgumentCodersCF.h:
* Shared/curl/WebCoreArgumentCodersCurl.cpp:
(IPC::ArgumentCoder::decode):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder::decode):
* Shared/soup/WebCoreArgumentCodersSoup.cpp:
(IPC::ArgumentCoder::decode):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp
trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h
trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp
trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.h
trunk/Source/WebKit/Shared/curl/WebCoreArgumentCodersCurl.cpp
trunk/Source/WebKit/Shared/mac/WebCoreArgumentCodersMac.mm
trunk/Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp




Diff

Modified: trunk/Source/WebKit/ChangeLog (282257 => 282258)

--- trunk/Source/WebKit/ChangeLog	2021-09-10 03:23:20 UTC (rev 282257)
+++ trunk/Source/WebKit/ChangeLog	2021-09-10 03:56:08 UTC (rev 282258)
@@ -1,3 +1,37 @@
+2021-09-09  Alex Christensen  
+
+Modernize CertificateInfo decoder
+https://bugs.webkit.org/show_bug.cgi?id=230125
+
+Reviewed by Chris Dumez.
+
+Return std::optional instead of bool.
+
+* Shared/WebCoreArgumentCoders.cpp:
+* Shared/WebCoreArgumentCoders.h:
+* Shared/cf/ArgumentCodersCF.cpp:
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+(IPC::ArgumentCoder>::decode):
+* Shared/cf/ArgumentCodersCF.h:
+* Shared/curl/WebCoreArgumentCodersCurl.cpp:
+(IPC::ArgumentCoder::decode):
+* Shared/mac/WebCoreArgumentCodersMac.mm:
+(IPC::ArgumentCoder::decode):
+* Shared/soup/WebCoreArgumentCodersSoup.cpp:
+(IPC::ArgumentCoder::decode):
+
 2021-09-09  Ben Nham  
 
 Preconnected socket is sometimes not used for initial request


Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp (282257 => 282258)

--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2021-09-10 03:23:20 UTC (rev 282257)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp	2021-09-10 03:56:08 UTC (rev 282258)
@@ -37,7 +37,6 @@
 #include 
 #include 
 #include 
-#include 
 #include 
 #include 
 #include 


Modified: trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h (282257 => 282258)

--- trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h	2021-09-10 03:23:20 UTC (rev 282257)
+++ trunk/Source/WebKit/Shared/WebCoreArgumentCoders.h	2021-09-10 03:56:08 UTC (rev 282258)
@@ -294,7 +294,7 @@
 
 template<> struct ArgumentCoder {
 static void encode(Encoder&, const WebCore::CertificateInfo&);
-static WARN_UNUSED_RETURN bool decode(Decoder&, WebCore::CertificateInfo&);
+static std::optional decode(Decoder&);
 };
 
 template<> struct ArgumentCoder {


Modified: trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp (282257 => 282258)

--- trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp	2021-09-10 03:23:20 UTC (rev 282257)
+++ trunk/Source/WebKit/Shared/cf/ArgumentCodersCF.cpp	2021-09-10 03:56:08 UTC (rev 282258)
@@ -193,123 +193,121 @@
 template void ArgumentCoder::encode(Encoder&, CFTypeRef);
 template void ArgumentCoder::encode(StreamConnectionEncoder&, CFTypeRef);
 
-bool ArgumentCoder>::decode(Decoder& decoder, RetainPtr& result)
+std::optional> ArgumentCoder>::decode(Decoder& decoder)
 {
 std::optional type;
 decoder >> type;
 if (!type)
-return false;
+return std::nullopt;
 
 switch (*type) {
 case CFType::CFArray: {
-RetainPtr array;
-if (!decoder.decode(array))
-return false;
-result = WTFMove(array);
-return true;
+std::optional> array;
+decoder >> array;
+if (!array)

[webkit-changes] [282257] trunk

2021-09-09 Thread ysuzuki 
Title: [282257] trunk








Revision 282257
Author ysuz...@apple.com
Date 2021-09-09 20:23:20 -0700 (Thu, 09 Sep 2021)


Log Message
[JSC] Intl.Locale weekendInfo should list all weekend days instead of range
https://bugs.webkit.org/show_bug.cgi?id=230108

Reviewed by Ross Kirsling.

JSTests:

* stress/intl-locale-info.js:
(throw.new.Error):
(let.enGB.new.Intl.Locale.shouldBe): Deleted.
* test262/config.yaml:

Source/_javascript_Core:

We cannot assume that weekend is contiguous. For example, Burnei's weekend is Friday and Sunday.
This is raised in [1], and our conclusion in Sep-9 meeting is that we should have an array which
includes all the weekend days. The change is merged in [2], and this patch changes our implementation
accordingly.

[1]: https://github.com/tc39/proposal-intl-locale-info/issues/25
[2]: https://github.com/tc39/proposal-intl-locale-info/commit/afb1e269dd698476a2514129235cdad88af60e6f

* runtime/IntlLocale.cpp:
(JSC::IntlLocale::weekInfo):
* runtime/IntlObjectInlines.h:
(JSC::createArrayFromIntVector):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/intl-locale-info.js
trunk/JSTests/test262/config.yaml
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/IntlLocale.cpp
trunk/Source/_javascript_Core/runtime/IntlObjectInlines.h




Diff

Modified: trunk/JSTests/ChangeLog (282256 => 282257)

--- trunk/JSTests/ChangeLog	2021-09-10 03:04:42 UTC (rev 282256)
+++ trunk/JSTests/ChangeLog	2021-09-10 03:23:20 UTC (rev 282257)
@@ -1,5 +1,17 @@
 2021-09-09  Yusuke Suzuki  
 
+[JSC] Intl.Locale weekendInfo should list all weekend days instead of range
+https://bugs.webkit.org/show_bug.cgi?id=230108
+
+Reviewed by Ross Kirsling.
+
+* stress/intl-locale-info.js:
+(throw.new.Error):
+(let.enGB.new.Intl.Locale.shouldBe): Deleted.
+* test262/config.yaml:
+
+2021-09-09  Yusuke Suzuki  
+
 [JSC] Optimize op_get_property_enumerator further
 https://bugs.webkit.org/show_bug.cgi?id=230086
 


Modified: trunk/JSTests/stress/intl-locale-info.js (282256 => 282257)

--- trunk/JSTests/stress/intl-locale-info.js	2021-09-10 03:04:42 UTC (rev 282256)
+++ trunk/JSTests/stress/intl-locale-info.js	2021-09-10 03:23:20 UTC (rev 282257)
@@ -5,11 +5,14 @@
 
 {
 let he = new Intl.Locale("he")
-shouldBe(JSON.stringify(he.weekInfo), `{"firstDay":7,"weekendStart":5,"weekendEnd":6,"minimalDays":1}`);
+shouldBe(JSON.stringify(he.weekInfo), `{"firstDay":7,"weekend":[5,6],"minimalDays":1}`);
 let af = new Intl.Locale("af")
-shouldBe(JSON.stringify(af.weekInfo), `{"firstDay":7,"weekendStart":6,"weekendEnd":7,"minimalDays":1}`);
+shouldBe(JSON.stringify(af.weekInfo), `{"firstDay":7,"weekend":[6,7],"minimalDays":1}`);
 let enGB = new Intl.Locale("en-GB")
-shouldBe(JSON.stringify(enGB.weekInfo), `{"firstDay":1,"weekendStart":6,"weekendEnd":7,"minimalDays":4}`);
+shouldBe(JSON.stringify(enGB.weekInfo), `{"firstDay":1,"weekend":[6,7],"minimalDays":4}`);
+let msBN = new Intl.Locale("ms-BN");
+// "weekend" should be [5,7]. But currently ICU/CLDR does not support representing non-contiguous weekend.
+shouldBe(JSON.stringify(msBN.weekInfo), `{"firstDay":1,"weekend":[6,7],"minimalDays":1}`);
 }
 {
 let l = new Intl.Locale("ar")


Modified: trunk/JSTests/test262/config.yaml (282256 => 282257)

--- trunk/JSTests/test262/config.yaml	2021-09-10 03:04:42 UTC (rev 282256)
+++ trunk/JSTests/test262/config.yaml	2021-09-10 03:23:20 UTC (rev 282257)
@@ -72,6 +72,9 @@
 - test/intl402/Locale/constructor-non-iana-canon.js
 - test/intl402/Locale/likely-subtags.js
 
+# The spec is changed, but the test is not updated yet. https://github.com/tc39/proposal-intl-locale-info/pull/44
+- test/intl402/Locale/prototype/weekInfo/output-object-keys.js
+
 # Pass only in ICU 68~
 - test/intl402/Locale/constructor-options-region-valid.js
 - test/intl402/Locale/constructor-tag.js


Modified: trunk/Source/_javascript_Core/ChangeLog (282256 => 282257)

--- trunk/Source/_javascript_Core/ChangeLog	2021-09-10 03:04:42 UTC (rev 282256)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-09-10 03:23:20 UTC (rev 282257)
@@ -1,3 +1,23 @@
+2021-09-09  Yusuke Suzuki  
+
+[JSC] Intl.Locale weekendInfo should list all weekend days instead of range
+https://bugs.webkit.org/show_bug.cgi?id=230108
+
+Reviewed by Ross Kirsling.
+
+We cannot assume that weekend is contiguous. For example, Burnei's weekend is Friday and Sunday.
+This is raised in [1], and our conclusion in Sep-9 meeting is that we should have an array which
+includes all the weekend days. The change is merged in [2], and this patch changes our implementation
+accordingly.
+
+[1]: https://github.com/tc39/proposal-intl-locale-info/issues/25
+[2]: https://github.com/tc39/proposal-intl-locale-info/commit/afb1e269dd698476a2514129235cdad88af60e6f
+
+*

[webkit-changes] [282256] trunk

2021-09-09 Thread zalan 
Title: [282256] trunk








Revision 282256
Author za...@apple.com
Date 2021-09-09 20:04:42 -0700 (Thu, 09 Sep 2021)


Log Message
[Table layout] Incorrect vertical position when the inline level box has 0px used height.
https://bugs.webkit.org/show_bug.cgi?id=230118

Reviewed by Antti Koivisto.

Source/WebCore:

Intrinsic padding is used in table cells to offset the content with their alignments as the content box may not be as tall as the cell itself.
This patch ensures that zero height content (where the baseline is also 0) gets the alignment offset as well.
(This patch also fixes the bug where we may reset the intrinsic padding to 0 on subsequent layouts.)

Test: fast/table/vertical-position-with-0-height-box.html

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeIntrinsicPadding):

LayoutTests:

* fast/table/vertical-position-with-0-height-box-expected.txt: Added.
* fast/table/vertical-position-with-0-height-box.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt
trunk/LayoutTests/platform/ios/fast/css/acid2-expected.txt
trunk/LayoutTests/platform/ios/fast/css/acid2-pixel-expected.txt
trunk/LayoutTests/platform/ios/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
trunk/LayoutTests/platform/ios/http/tests/misc/acid2-expected.txt
trunk/LayoutTests/platform/ios/http/tests/misc/acid2-pixel-expected.txt
trunk/LayoutTests/platform/ios/tables/mozilla/bugs/bug3037-1-expected.txt
trunk/LayoutTests/platform/mac/fast/css/acid2-expected.txt
trunk/LayoutTests/platform/mac/fast/css/acid2-pixel-expected.txt
trunk/LayoutTests/platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt
trunk/LayoutTests/platform/mac/http/tests/misc/acid2-expected.txt
trunk/LayoutTests/platform/mac/http/tests/misc/acid2-pixel-expected.txt
trunk/LayoutTests/platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderTableCell.cpp


Added Paths

trunk/LayoutTests/fast/table/vertical-position-with-0-height-box-expected.txt
trunk/LayoutTests/fast/table/vertical-position-with-0-height-box.html




Diff

Modified: trunk/LayoutTests/ChangeLog (282255 => 282256)

--- trunk/LayoutTests/ChangeLog	2021-09-10 02:25:00 UTC (rev 282255)
+++ trunk/LayoutTests/ChangeLog	2021-09-10 03:04:42 UTC (rev 282256)
@@ -1,3 +1,13 @@
+2021-09-09  Alan Bujtas  
+
+[Table layout] Incorrect vertical position when the inline level box has 0px used height.
+https://bugs.webkit.org/show_bug.cgi?id=230118
+
+Reviewed by Antti Koivisto.
+
+* fast/table/vertical-position-with-0-height-box-expected.txt: Added.
+* fast/table/vertical-position-with-0-height-box.html: Added.
+
 2021-09-09  Fujii Hironori  
 
 [WinCairo] Unreviewed test gardening


Modified: trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt (282255 => 282256)

--- trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt	2021-09-10 02:25:00 UTC (rev 282255)
+++ trunk/LayoutTests/fast/table/table-insert-before-non-anonymous-block-expected.txt	2021-09-10 03:04:42 UTC (rev 282256)
@@ -53,4 +53,4 @@
 RenderTableCell (anonymous) at (0,0) size 50x100 [r=0 c=0 rs=1 cs=1]
   RenderBlock {DIV} at (0,0) size 50x50 [bgcolor=#FF]
   RenderBlock {DIV} at (0,50) size 50x50 [bgcolor=#FF]
-RenderTableCell {DIV} at (50,0) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]
+RenderTableCell {DIV} at (50,50) size 50x0 [bgcolor=#FF] [r=0 c=1 rs=1 cs=1]


Added: trunk/LayoutTests/fast/table/vertical-position-with-0-height-box-expected.txt (0 => 282256)

--- trunk/LayoutTests/fast/table/vertical-position-with-0-height-box-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/table/vertical-position-with-0-height-box-expected.txt	2021-09-10 03:04:42 UTC (rev 282256)
@@ -0,0 +1,2 @@
+The zero height inline level box is supposed to be aligned with the bottom of the green box (20px).
+Inline level box logical top: 20px


Added: trunk/LayoutTests/fast/table/vertical-position-with-0-height-box.html (0 => 282256)

--- trunk/LayoutTests/fast/table/vertical-position-with-0-height-box.html	(rev 0)
+++ trunk/LayoutTests/fast/table/vertical-position-with-0-height-box.html	2021-09-10 03:04:42 UTC (rev 282256)
@@ -0,0 +1,30 @@
+
+td {
+  padding: 0px;
+  vertical-align: baseline;
+}
+
+div {
+  display: inline-block;
+  width: 20px;
+  height: 20px;
+  background: green;
+}
+
+#zero {
+  height: 0px;
+}
+
+
+
+  
+  
+
+
+
+
+document.body.offsetHeight;
+if (window.testRunner)
+  testRunner.dumpAsText();
+result.innerText = "The zero height inline level box is supposed to be aligned with the bottom of the green box (20px).\nInline level box logical top: " + zero.offsetTop + "px";
+


Modified:

[webkit-changes] [282255] trunk/LayoutTests

2021-09-09 Thread Hironori . Fujii 
Title: [282255] trunk/LayoutTests








Revision 282255
Author hironori.fu...@sony.com
Date 2021-09-09 19:25:00 -0700 (Thu, 09 Sep 2021)


Log Message
[WinCairo] Unreviewed test gardening

* platform/wincairo-wk1/TestExpectations:
* platform/wincairo/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/wincairo/TestExpectations
trunk/LayoutTests/platform/wincairo-wk1/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (282254 => 282255)

--- trunk/LayoutTests/ChangeLog	2021-09-10 01:00:54 UTC (rev 282254)
+++ trunk/LayoutTests/ChangeLog	2021-09-10 02:25:00 UTC (rev 282255)
@@ -1,3 +1,10 @@
+2021-09-09  Fujii Hironori  
+
+[WinCairo] Unreviewed test gardening
+
+* platform/wincairo-wk1/TestExpectations:
+* platform/wincairo/TestExpectations:
+
 2021-09-09  Ayumi Kojima  
 
 [ iOS ] editing/selection/ios/select-text-under-hidden-subframe.html is timing out.


Modified: trunk/LayoutTests/platform/wincairo/TestExpectations (282254 => 282255)

--- trunk/LayoutTests/platform/wincairo/TestExpectations	2021-09-10 01:00:54 UTC (rev 282254)
+++ trunk/LayoutTests/platform/wincairo/TestExpectations	2021-09-10 02:25:00 UTC (rev 282255)
@@ -1860,7 +1860,6 @@
 fast/events/wheel/wheelevent-in-horizontal-scrollbar-in-rtl.html [ Failure ]
 fast/events/wheel/wheelevent-in-vertical-scrollbar-in-rtl.html [ Failure ]
 fast/harness/render-tree-as-text-options.html [ Failure ]
-fast/html/broadcast-channel-between-different-sessions.html [ Failure ]
 fast/html/details-comment-crash.html [ ImageOnlyFailure ]
 fast/html/details-marker-style-mixed.html [ Missing ]
 fast/html/details-writing-mode-mixed.html [ Missing ]


Modified: trunk/LayoutTests/platform/wincairo-wk1/TestExpectations (282254 => 282255)

--- trunk/LayoutTests/platform/wincairo-wk1/TestExpectations	2021-09-10 01:00:54 UTC (rev 282254)
+++ trunk/LayoutTests/platform/wincairo-wk1/TestExpectations	2021-09-10 02:25:00 UTC (rev 282255)
@@ -453,3 +453,9 @@
 http/wpt/fetch/inspect-preflight.html [ Failure ]
 
 webkit.org/b/229247 http/tests/fetch/keepalive-fetch-2.html [ Pass Failure ]
+
+# No BroadcastChannel support on Windows.
+fast/html/broadcast-channel-between-different-sessions.html [ Skip ]
+http/tests/messaging/broadcastchannel-partitioning.html [ Skip ]
+
+https://webkit.org/b/230141 [ Debug ] editing/pasteboard/paste-contents-with-side-effects.html [ Crash ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282254] trunk/Tools

2021-09-09 Thread simon . fraser 
Title: [282254] trunk/Tools








Revision 282254
Author simon.fra...@apple.com
Date 2021-09-09 18:00:54 -0700 (Thu, 09 Sep 2021)


Log Message
Fix some lldb data provider issues
https://bugs.webkit.org/show_bug.cgi?id=230134

Reviewed by Daniel Bates.

Fix the color data provider. Add a test for the URL provider. Add an
early return in lstring_to_string that fixed an error.

* lldb/lldbWebKitTester/main.cpp:
(testSummaryProviders):
* lldb/lldb_webkit.py:
(lstring_to_string):
(WebCoreColorProvider):
(WebCoreColorProvider._is_outOfLine):
(WebCoreColorProvider._is_valid):
(WebCoreColorProvider._is_semantic):
(WebCoreColorProvider._color_space):
(WebCoreColorProvider._flags):
(WebCoreColorProvider._to_string_outOfLine):
(WebCoreColorProvider.to_string):
(WebCoreColorProvider._is_extended): Deleted.
(WebCoreColorProvider._to_string_extended): Deleted.
* lldb/lldb_webkit_unittest.py:
(TestSummaryProviders):
(TestSummaryProviders.serial_test_WTFURL_SummaryProvider):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/lldb/lldbWebKitTester/main.cpp
trunk/Tools/lldb/lldb_webkit.py
trunk/Tools/lldb/lldb_webkit_unittest.py




Diff

Modified: trunk/Tools/ChangeLog (282253 => 282254)

--- trunk/Tools/ChangeLog	2021-09-10 00:37:49 UTC (rev 282253)
+++ trunk/Tools/ChangeLog	2021-09-10 01:00:54 UTC (rev 282254)
@@ -1,3 +1,31 @@
+2021-09-09  Simon Fraser  
+
+Fix some lldb data provider issues
+https://bugs.webkit.org/show_bug.cgi?id=230134
+
+Reviewed by Daniel Bates.
+
+Fix the color data provider. Add a test for the URL provider. Add an
+early return in lstring_to_string that fixed an error.
+
+* lldb/lldbWebKitTester/main.cpp:
+(testSummaryProviders):
+* lldb/lldb_webkit.py:
+(lstring_to_string):
+(WebCoreColorProvider):
+(WebCoreColorProvider._is_outOfLine):
+(WebCoreColorProvider._is_valid):
+(WebCoreColorProvider._is_semantic):
+(WebCoreColorProvider._color_space):
+(WebCoreColorProvider._flags):
+(WebCoreColorProvider._to_string_outOfLine):
+(WebCoreColorProvider.to_string):
+(WebCoreColorProvider._is_extended): Deleted.
+(WebCoreColorProvider._to_string_extended): Deleted.
+* lldb/lldb_webkit_unittest.py:
+(TestSummaryProviders):
+(TestSummaryProviders.serial_test_WTFURL_SummaryProvider):
+
 2021-09-09  Wenson Hsieh  
 
 [Mac Catalyst] Korean characters do not combine correctly in editable fields in WKWebView


Modified: trunk/Tools/lldb/lldbWebKitTester/main.cpp (282253 => 282254)

--- trunk/Tools/lldb/lldbWebKitTester/main.cpp	2021-09-10 00:37:49 UTC (rev 282253)
+++ trunk/Tools/lldb/lldbWebKitTester/main.cpp	2021-09-10 01:00:54 UTC (rev 282254)
@@ -29,6 +29,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 #include 
@@ -91,6 +92,8 @@
 CompactPointerTuple exampleCompactPointerTupleSimple { , 7 };
 CompactPointerTuple exampleCompactPointerTupleMaxTypeValue { , 255 };
 CompactPointerTuple exampleCompactPointerTupleSimpleBool { , true };
+
+URL aURL({ }, "https://www.example.com");
 
 breakForTestingSummaryProviders();
 }


Modified: trunk/Tools/lldb/lldb_webkit.py (282253 => 282254)

--- trunk/Tools/lldb/lldb_webkit.py	2021-09-10 00:37:49 UTC (rev 282253)
+++ trunk/Tools/lldb/lldb_webkit.py	2021-09-10 01:00:54 UTC (rev 282254)
@@ -378,6 +378,8 @@
 
 pointer = valobj.GetValueAsUnsigned()
 contents = valobj.GetProcess().ReadMemory(pointer, length, lldb.SBError())
+if not contents:
+return ""
 
 # lldb does not (currently) support returning unicode from python summary providers,
 # so potentially convert this to ascii by escaping
@@ -468,44 +470,70 @@
 
 
 class WebCoreColorProvider:
+SEMANTIC_FLAG   = 1 << 0
+USE_COLOR_FUNCTION_SERIALIZATION_FLAG   = 1 << 1
+VALID_FLAG  = 1 << 2
+OUT_OF_LINE_FLAG= 1 << 3
+
+COLOR_VALUE_MASK= (1 << 48) - 1 # only correct for 64-bit
+FLAGS_SHIFT = 48
+FLAGS_SIZE  = 8
+COLOR_SPACE_SHIFT   = FLAGS_SHIFT + FLAGS_SIZE
+
 "Print a WebCore::Color"
 def __init__(self, valobj, dict):
 self.valobj = valobj
 
-def _is_extended(self, rgba_and_flags):
-return not bool(rgba_and_flags & 0x1)
+def _is_out_of_line(self, rgba_and_flags):
+flags = self._flags(rgba_and_flags)
+return bool(flags & self.OUT_OF_LINE_FLAG)
 
 def _is_valid(self, rgba_and_flags):
-# Assumes not extended.
-return bool(rgba_and_flags & 0x2)
+flags = self._flags(rgba_and_flags)
+return bool(flags & self.VALID_FLAG)
 
 def _is_semantic(self, rgba_and_flags):
-# Assumes not extended.
-return bool(rgba_and_flags & 0x4)
+flags = self._flags(rgba_and_flags)
+

[webkit-changes] [282253] trunk/Source/WebCore

2021-09-09 Thread dpino 
Title: [282253] trunk/Source/WebCore








Revision 282253
Author dp...@igalia.com
Date 2021-09-09 17:37:49 -0700 (Thu, 09 Sep 2021)


Log Message
Build fix for Ubuntu LTS and Debian after r282211

Some functions need to be guarded by ENABLE(LAYOUT_FORMATTING_CONTEXT)

* layout/integration/LayoutIntegrationRunIterator.cpp:
* layout/integration/LayoutIntegrationRunIterator.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp
trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (282252 => 282253)

--- trunk/Source/WebCore/ChangeLog	2021-09-10 00:28:37 UTC (rev 282252)
+++ trunk/Source/WebCore/ChangeLog	2021-09-10 00:37:49 UTC (rev 282253)
@@ -1,3 +1,12 @@
+2021-09-09  Diego Pino Garcia  
+
+Build fix for Ubuntu LTS and Debian after r282211
+
+Some functions need to be guarded by ENABLE(LAYOUT_FORMATTING_CONTEXT)
+
+* layout/integration/LayoutIntegrationRunIterator.cpp:
+* layout/integration/LayoutIntegrationRunIterator.h:
+
 2021-09-09  Darin Adler  
 
 Improve performance by using StringView, not "const StringView&"


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp (282252 => 282253)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp	2021-09-10 00:28:37 UTC (rev 282252)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.cpp	2021-09-10 00:37:49 UTC (rev 282253)
@@ -195,6 +195,7 @@
 return { RunIteratorLegacyPath { legacyInlineTextBox } };
 }
 
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 TextRunIterator textRunFor(const InlineContent& content, const Run& run)
 {
 return textRunFor(content, content.indexForRun(run));
@@ -205,6 +206,7 @@
 ASSERT(content.runs[runIndex].text());
 return { RunIteratorModernPath { content, runIndex } };
 }
+#endif
 
 TextRunRange textRunsFor(const RenderText& text)
 {
@@ -229,10 +231,12 @@
 return { RunIteratorLegacyPath(renderer.inlineBoxWrapper()) };
 }
 
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 RunIterator runFor(const InlineContent& content, size_t runIndex)
 {
 return { RunIteratorModernPath { content, runIndex } };
 }
+#endif
 
 #if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 const RunIteratorModernPath& PathRun::modernPath() const


Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h (282252 => 282253)

--- trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h	2021-09-10 00:28:37 UTC (rev 282252)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationRunIterator.h	2021-09-10 00:37:49 UTC (rev 282253)
@@ -201,12 +201,16 @@
 TextRunIterator firstTextRunFor(const RenderText&);
 TextRunIterator firstTextRunInTextOrderFor(const RenderText&);
 TextRunIterator textRunFor(const LegacyInlineTextBox*);
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 TextRunIterator textRunFor(const InlineContent&, const Run&);
 TextRunIterator textRunFor(const InlineContent&, size_t runIndex);
+#endif
 TextRunRange textRunsFor(const RenderText&);
 RunIterator runFor(const RenderLineBreak&);
 RunIterator runFor(const RenderBox&);
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
 RunIterator runFor(const InlineContent&, size_t runIndex);
+#endif
 
 // ---
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282252] trunk/Source/WebKit

2021-09-09 Thread nham 
Title: [282252] trunk/Source/WebKit








Revision 282252
Author n...@apple.com
Date 2021-09-09 17:28:37 -0700 (Thu, 09 Sep 2021)


Log Message
Preconnected socket is sometimes not used for initial request
https://bugs.webkit.org/show_bug.cgi?id=229686

Reviewed by Alex Christensen.

In the previous release, we preconnected to the main resource origin early in page load from
UIProcess to save ~10-15 ms per page load (https://bugs.webkit.org/show_bug.cgi?id=204992).
The savings comes from the fact that there's some latency in initiating the request in
WebProcess and waiting for the nav delegate reply in UIProcess. We hide that latency by
having the eventual main resource request reuse the early preconnected socket.

However, this optimization doesn't work for connections to known HTTP/1.1 origins due to
CFNetwork's in-memory cache of known HTTP/1.1 origins. If an origin is in this cache, and
a preconnect is still in flight, then the network stack will go wide immediately and issue
the main resource request on a new socket rather than trying to wait for the preconnect to
finish and reuse the preconnected socket. Thus the preconneted socket just goes to waste.
This can also cause issues with single-threaded web servers that serve only one request at
a time, as the main resource request can get head-of-line blocked by the preconnect that
is wasted.

To work around this, this patch tracks a small number of known HTTP/1.1 origins in memory.
If there is a pending preconnect to an HTTP/1.1 origin and a main resource request to that
origin comes in, then we block the request from going out until the preconnect finishes.
This allows the main resource request to utilize the preconnected socket.

This is worth ~1.25%-2.5% on PLT5 depending on device.

* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::didCompleteWithError):
* NetworkProcess/NetworkLoadScheduler.cpp:
(WebKit::NetworkLoadScheduler::schedule):
(WebKit::NetworkLoadScheduler::unschedule):
(WebKit::NetworkLoadScheduler::scheduleLoad):
(WebKit::NetworkLoadScheduler::unscheduleLoad):
(WebKit::NetworkLoadScheduler::scheduleMainResourceLoad):
(WebKit::NetworkLoadScheduler::unscheduleMainResourceLoad):
(WebKit::NetworkLoadScheduler::startedPreconnectForMainResource):
(WebKit::NetworkLoadScheduler::finishedPreconnectForMainResource):
(WebKit::NetworkLoadScheduler::maybePrunePreconnectInfo):
(WebKit::NetworkLoadScheduler::isOriginHTTP1X):
(WebKit::NetworkLoadScheduler::updateOriginProtocolInfo):
* NetworkProcess/NetworkLoadScheduler.h:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::preconnectTo):
* NetworkProcess/PreconnectTask.cpp:
(WebKit::PreconnectTask::PreconnectTask):
(WebKit::PreconnectTask::setTimeout):
(WebKit::PreconnectTask::start):
* NetworkProcess/PreconnectTask.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadScheduler.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoadScheduler.h
trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit/NetworkProcess/PreconnectTask.cpp
trunk/Source/WebKit/NetworkProcess/PreconnectTask.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (282251 => 282252)

--- trunk/Source/WebKit/ChangeLog	2021-09-10 00:25:41 UTC (rev 282251)
+++ trunk/Source/WebKit/ChangeLog	2021-09-10 00:28:37 UTC (rev 282252)
@@ -1,3 +1,55 @@
+2021-09-09  Ben Nham  
+
+Preconnected socket is sometimes not used for initial request
+https://bugs.webkit.org/show_bug.cgi?id=229686
+
+Reviewed by Alex Christensen.
+
+In the previous release, we preconnected to the main resource origin early in page load from
+UIProcess to save ~10-15 ms per page load (https://bugs.webkit.org/show_bug.cgi?id=204992).
+The savings comes from the fact that there's some latency in initiating the request in
+WebProcess and waiting for the nav delegate reply in UIProcess. We hide that latency by
+having the eventual main resource request reuse the early preconnected socket.
+
+However, this optimization doesn't work for connections to known HTTP/1.1 origins due to
+CFNetwork's in-memory cache of known HTTP/1.1 origins. If an origin is in this cache, and
+a preconnect is still in flight, then the network stack will go wide immediately and issue
+the main resource request on a new socket rather than trying to wait for the preconnect to
+finish and reuse the preconnected socket. Thus the preconneted socket just goes to waste.
+This can also cause issues with single-threaded web servers that serve only one request at
+a time, as the main resource request can get head-of-line blocked by the preconnect that
+is wasted.
+
+To work around this, this patch tracks a small number of known HTTP/1.1 origins in memory.
+If there is a pending preconnect to an HTTP/1.1 origin and a main resource request to that
+

[webkit-changes] [282251] tags/Safari-613.1.1.1/

2021-09-09 Thread alancoon 
Title: [282251] tags/Safari-613.1.1.1/








Revision 282251
Author alanc...@apple.com
Date 2021-09-09 17:25:41 -0700 (Thu, 09 Sep 2021)


Log Message
Tag Safari-613.1.1.1.

Added Paths

tags/Safari-613.1.1.1/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282250] branches/safari-613.1.1-branch/Source

2021-09-09 Thread alancoon 
Title: [282250] branches/safari-613.1.1-branch/Source








Revision 282250
Author alanc...@apple.com
Date 2021-09-09 17:22:59 -0700 (Thu, 09 Sep 2021)


Log Message
Versioning.

WebKit-7613.1.1.1

Modified Paths

branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (282249 => 282250)

--- branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
+++ branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-09-10 00:22:59 UTC (rev 282250)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (282249 => 282250)

--- branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
+++ branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-09-10 00:22:59 UTC (rev 282250)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (282249 => 282250)

--- branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
+++ branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-09-10 00:22:59 UTC (rev 282250)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig (282249 => 282250)

--- branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
+++ branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-09-10 00:22:59 UTC (rev 282250)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION = $(BUNDLE_VERSION_$(CONFIGURATION));


Modified: branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (282249 => 282250)

--- branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
+++ branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-09-10 00:22:59 UTC (rev 282250)
@@ -24,9 +24,9 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
 TINY_VERSION = 1;
-MICRO_VERSION = 0;
+MICRO_VERSION = 1;
 NANO_VERSION = 0;
-FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);
+FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION).$(MICRO_VERSION);
 
 // The bundle version and short version string are set based on the current build configuration, see below.
 BUNDLE_VERSION =

[webkit-changes] [282249] branches/safari-613.1.1-branch/Source

2021-09-09 Thread alancoon 
Title: [282249] branches/safari-613.1.1-branch/Source








Revision 282249
Author alanc...@apple.com
Date 2021-09-09 17:22:54 -0700 (Thu, 09 Sep 2021)


Log Message
Revert "Versioning."

This reverts commit 765adb97dc4963500c9371cb6b2e8a4ce04de13f.

Modified Paths

branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (282248 => 282249)

--- branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
+++ branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (282248 => 282249)

--- branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
+++ branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (282248 => 282249)

--- branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
+++ branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig (282248 => 282249)

--- branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
+++ branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (282248 => 282249)

--- branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
+++ branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (282248 => 282249)

--- branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
+++ branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig (282248 => 282249)

--- branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
+++ branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig	2021-09-10 00:22:54 UTC (rev 282249)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 2;
+TINY_VERSION = 1;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified:

[webkit-changes] [282248] branches/safari-613.1.1-branch/Source

2021-09-09 Thread alancoon 
Title: [282248] branches/safari-613.1.1-branch/Source








Revision 282248
Author alanc...@apple.com
Date 2021-09-09 17:20:11 -0700 (Thu, 09 Sep 2021)


Log Message
Versioning.

WebKit-7613.1.2

Modified Paths

branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig
branches/safari-613.1.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig




Diff

Modified: branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig (282247 => 282248)

--- branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-09-10 00:15:44 UTC (rev 282247)
+++ branches/safari-613.1.1-branch/Source/_javascript_Core/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig (282247 => 282248)

--- branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-09-10 00:15:44 UTC (rev 282247)
+++ branches/safari-613.1.1-branch/Source/ThirdParty/ANGLE/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig (282247 => 282248)

--- branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-09-10 00:15:44 UTC (rev 282247)
+++ branches/safari-613.1.1-branch/Source/ThirdParty/libwebrtc/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig (282247 => 282248)

--- branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-09-10 00:15:44 UTC (rev 282247)
+++ branches/safari-613.1.1-branch/Source/WebCore/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig (282247 => 282248)

--- branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-09-10 00:15:44 UTC (rev 282247)
+++ branches/safari-613.1.1-branch/Source/WebCore/PAL/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig (282247 => 282248)

--- branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-09-10 00:15:44 UTC (rev 282247)
+++ branches/safari-613.1.1-branch/Source/WebInspectorUI/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
@@ -1,6 +1,6 @@
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig (282247 => 282248)

--- branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig	2021-09-10 00:15:44 UTC (rev 282247)
+++ branches/safari-613.1.1-branch/Source/WebKit/Configurations/Version.xcconfig	2021-09-10 00:20:11 UTC (rev 282248)
@@ -23,7 +23,7 @@
 
 MAJOR_VERSION = 613;
 MINOR_VERSION = 1;
-TINY_VERSION = 1;
+TINY_VERSION = 2;
 MICRO_VERSION = 0;
 NANO_VERSION = 0;
 FULL_VERSION = $(MAJOR_VERSION).$(MINOR_VERSION).$(TINY_VERSION);


Modified: branches/safari-613.1.1-branch/Source/WebKitLegacy/mac/Configurations/Version.xcconfig

[webkit-changes] [282247] trunk

2021-09-09 Thread wenson_hsieh 
Title: [282247] trunk








Revision 282247
Author wenson_hs...@apple.com
Date 2021-09-09 17:15:44 -0700 (Thu, 09 Sep 2021)


Log Message
[Mac Catalyst] Korean characters do not combine correctly in editable fields in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=230122
rdar://79062204

Reviewed by Devin Rousso.

Source/WebKit:

When using Korean input method (e.g. 2-set Korean) to type into editable input fields in WKWebView on Catalyst,
character combination is broken. While this is partly due to a WebKit-specific UIKit bug (see rdar://82938391),
this is also broken due to the fact that WKContentView reports a UIWKAutocorrectionContext with a
`contextBeforeSelection` that starts with a newline (\n); this causes UIKit to believe that the text selection
range when a single character has been typed is `NSRange { 2, 0 }` instead of `NSRange { 1, 0 }`, due to the
extra newline. This subsequently causes character combination logic to proceed with a range that is off by one
character, which leads to characters not being combined (or the wrong characters being combined).

To address this, we simply avoid including the leading newline in the case where the starting position for the
"context before selection" is exactly at the first position inside the editable root.

Test: AutocorrectionTests.AutocorrectionContextDoesNotIncludeNewlineInTextField

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::autocorrectionContext):

Also drive-by fix a typo in "minContextLenght" while I'm here, and rename `currentPosition` to
`contextStartPosition`, to better describe the purpose of this local variable.

Tools:

Add a new API test to exercise the change. See WebKit/ChangeLog for more information.

* TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
(-[TestWKWebView synchronouslyRequestAutocorrectionContext]):
(TEST):
* TestWebKitAPI/ios/UIKitSPI.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm
trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (282246 => 282247)

--- trunk/Source/WebKit/ChangeLog	2021-09-10 00:01:20 UTC (rev 282246)
+++ trunk/Source/WebKit/ChangeLog	2021-09-10 00:15:44 UTC (rev 282247)
@@ -1,3 +1,30 @@
+2021-09-09  Wenson Hsieh  
+
+[Mac Catalyst] Korean characters do not combine correctly in editable fields in WKWebView
+https://bugs.webkit.org/show_bug.cgi?id=230122
+rdar://79062204
+
+Reviewed by Devin Rousso.
+
+When using Korean input method (e.g. 2-set Korean) to type into editable input fields in WKWebView on Catalyst,
+character combination is broken. While this is partly due to a WebKit-specific UIKit bug (see rdar://82938391),
+this is also broken due to the fact that WKContentView reports a UIWKAutocorrectionContext with a
+`contextBeforeSelection` that starts with a newline (\n); this causes UIKit to believe that the text selection
+range when a single character has been typed is `NSRange { 2, 0 }` instead of `NSRange { 1, 0 }`, due to the
+extra newline. This subsequently causes character combination logic to proceed with a range that is off by one
+character, which leads to characters not being combined (or the wrong characters being combined).
+
+To address this, we simply avoid including the leading newline in the case where the starting position for the
+"context before selection" is exactly at the first position inside the editable root.
+
+Test: AutocorrectionTests.AutocorrectionContextDoesNotIncludeNewlineInTextField
+
+* WebProcess/WebPage/ios/WebPageIOS.mm:
+(WebKit::WebPage::autocorrectionContext):
+
+Also drive-by fix a typo in "minContextLenght" while I'm here, and rename `currentPosition` to
+`contextStartPosition`, to better describe the purpose of this local variable.
+
 2021-09-09  Fujii Hironori  
 
 Enable IPCMessages debug logging for non-Cocoa ports


Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (282246 => 282247)

--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2021-09-10 00:01:20 UTC (rev 282246)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm	2021-09-10 00:15:44 UTC (rev 282247)
@@ -2500,7 +2500,7 @@
 VisiblePosition startPosition = frame->selection().selection().start();
 VisiblePosition endPosition = frame->selection().selection().end();
 const unsigned minContextWordCount = 3;
-const unsigned minContextLenght = 12;
+const unsigned minContextLength = 12;
 const unsigned maxContextLength = 30;
 
 if (frame->selection().isRange())
@@ -2515,25 +2515,26 @@
 markedTextRange.length = selectedText.length();
 }
 } else {
-if (startPosition != startOfEditableContent(startPosition)) {
-VisiblePosition currentPosition =

[webkit-changes] [282246] trunk/Source/WTF

2021-09-09 Thread cdumez 
Title: [282246] trunk/Source/WTF








Revision 282246
Author cdu...@apple.com
Date 2021-09-09 17:01:20 -0700 (Thu, 09 Sep 2021)


Log Message
Unreviewed follow-up to r282105.

Add description for "BroadcastChannel Origin Partitioning" experimental feature.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml




Diff

Modified: trunk/Source/WTF/ChangeLog (282245 => 282246)

--- trunk/Source/WTF/ChangeLog	2021-09-09 23:55:32 UTC (rev 282245)
+++ trunk/Source/WTF/ChangeLog	2021-09-10 00:01:20 UTC (rev 282246)
@@ -1,5 +1,13 @@
 2021-09-09  Chris Dumez  
 
+Unreviewed follow-up to r282105.
+
+Add description for "BroadcastChannel Origin Partitioning" experimental feature.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+
+2021-09-09  Chris Dumez  
+
 Unreviewed, follow-up after r282007
 
 Somehow, the wrong settings got enabled by the patch landed.


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (282245 => 282246)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-09-09 23:55:32 UTC (rev 282245)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-09-10 00:01:20 UTC (rev 282246)
@@ -102,6 +102,8 @@
 
 BroadcastChannelOriginPartitioningEnabled:
   type: bool
+  humanReadableName: "BroadcastChannel Origin Partitioning"
+  humanReadableDescription: "BroadcastChannel Origin Partitioning"
   defaultValue:
 WebKitLegacy:
   default: true






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282245] trunk/Source/WTF

2021-09-09 Thread cdumez 
Title: [282245] trunk/Source/WTF








Revision 282245
Author cdu...@apple.com
Date 2021-09-09 16:55:32 -0700 (Thu, 09 Sep 2021)


Log Message
Unreviewed, follow-up after r282007

Somehow, the wrong settings got enabled by the patch landed.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml




Diff

Modified: trunk/Source/WTF/ChangeLog (282244 => 282245)

--- trunk/Source/WTF/ChangeLog	2021-09-09 23:49:22 UTC (rev 282244)
+++ trunk/Source/WTF/ChangeLog	2021-09-09 23:55:32 UTC (rev 282245)
@@ -1,3 +1,11 @@
+2021-09-09  Chris Dumez  
+
+Unreviewed, follow-up after r282007
+
+Somehow, the wrong settings got enabled by the patch landed.
+
+* Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2021-09-09  Darin Adler  
 
 Improve performance by using StringView, not "const StringView&"


Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (282244 => 282245)

--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-09-09 23:49:22 UTC (rev 282244)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-09-09 23:55:32 UTC (rev 282245)
@@ -351,7 +351,7 @@
 WebKitLegacy:
   default: false
 WebKit:
-  default: false
+  default: true
 WebCore:
   default: false
 
@@ -415,7 +415,7 @@
 WebKitLegacy:
   default: false
 WebKit:
-  default: true
+  default: false
 WebCore:
   default: false
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282244] trunk/LayoutTests

2021-09-09 Thread ayumi_kojima 
Title: [282244] trunk/LayoutTests








Revision 282244
Author ayumi_koj...@apple.com
Date 2021-09-09 16:49:22 -0700 (Thu, 09 Sep 2021)


Log Message
[ iOS ] editing/selection/ios/select-text-under-hidden-subframe.html is timing out.
https://bugs.webkit.org/show_bug.cgi?id=230127#c4

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (282243 => 282244)

--- trunk/LayoutTests/ChangeLog	2021-09-09 23:48:17 UTC (rev 282243)
+++ trunk/LayoutTests/ChangeLog	2021-09-09 23:49:22 UTC (rev 282244)
@@ -1,5 +1,14 @@
 2021-09-09  Ayumi Kojima  
 
+[ iOS ] editing/selection/ios/select-text-under-hidden-subframe.html is timing out.
+https://bugs.webkit.org/show_bug.cgi?id=230127#c4
+
+Unreviewed test gardening.
+
+* platform/ios-wk2/TestExpectations:
+
+2021-09-09  Ayumi Kojima  
+
 [ iOS ] Rebaselining 2 imported/w3c/web-platform-tests/css/cssom-view/* tests.
 https://bugs.webkit.org/show_bug.cgi?id=230123
 


Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (282243 => 282244)

--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-09-09 23:48:17 UTC (rev 282243)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2021-09-09 23:49:22 UTC (rev 282244)
@@ -2033,6 +2033,8 @@
 editing/selection/ios/do-not-hide-selection-in-visible-container.html [ Failure ]
 editing/selection/ios/do-not-hide-selection-in-visible-field.html [ Failure ]
 
+webkit.org/b/230127 editing/selection/ios/select-text-under-hidden-subframe.html [ Timeout ]
+
 # rdar://80393995 ([ iOS15 ] http/tests/media/modern-media-controls/overflow-support/playback-speed-live-broadcast.html is a constant timeout) http/tests/media/modern-media-controls/overflow-support/playback-speed-live-broadcast.html [ Timeout ]
 
 webkit.org/b/168961 fast/events/wheelevent-in-frame.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [282243] branches/safari-612-branch

2021-09-09 Thread repstein 
Title: [282243] branches/safari-612-branch








Revision 282243
Author repst...@apple.com
Date 2021-09-09 16:48:17 -0700 (Thu, 09 Sep 2021)


Log Message
Cherry-pick r281792. rdar://problem/82949614

[Cocoa] Drawing system fallback fonts to canvas causes a crash
https://bugs.webkit.org/show_bug.cgi?id=229633


Reviewed by Wenson Hsieh.

Source/WebCore/PAL:

* pal/spi/cf/CoreTextSPI.h:

Source/WebKit:

Dot-prefixed font names don't survive the round-trip through
CTFontDescriptorCopyAttributes(CTFontCopyFontDescriptor(font)) unless you also
pass in the kCTFontOptionsSystemUIFont option.

Tests: fast/text/system-fallback-canvas.html
   fast/text/draw-synthetic-system-bold-font-into-canvas.html

* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
(IPC::createCTFont):
(IPC::ArgumentCoder>::decodePlatformData):

LayoutTests:

* fast/text/system-fallback-canvas-expected.txt: Added.
* fast/text/system-fallback-canvas.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-612-branch/LayoutTests/ChangeLog
branches/safari-612-branch/Source/WebCore/PAL/ChangeLog
branches/safari-612-branch/Source/WebCore/PAL/pal/spi/cf/CoreTextSPI.h
branches/safari-612-branch/Source/WebKit/ChangeLog
branches/safari-612-branch/Source/WebKit/Shared/Cocoa/WebCoreArgumentCodersCocoa.mm


Added Paths

branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas-expected-mismatch.html
branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas.html
branches/safari-612-branch/LayoutTests/fast/text/system-fallback-canvas-expected.txt
branches/safari-612-branch/LayoutTests/fast/text/system-fallback-canvas.html




Diff

Modified: branches/safari-612-branch/LayoutTests/ChangeLog (282242 => 282243)

--- branches/safari-612-branch/LayoutTests/ChangeLog	2021-09-09 23:39:40 UTC (rev 282242)
+++ branches/safari-612-branch/LayoutTests/ChangeLog	2021-09-09 23:48:17 UTC (rev 282243)
@@ -1,3 +1,49 @@
+2021-09-09  Russell Epstein  
+
+Cherry-pick r281792. rdar://problem/82949614
+
+[Cocoa] Drawing system fallback fonts to canvas causes a crash
+https://bugs.webkit.org/show_bug.cgi?id=229633
+
+
+Reviewed by Wenson Hsieh.
+
+Source/WebCore/PAL:
+
+* pal/spi/cf/CoreTextSPI.h:
+
+Source/WebKit:
+
+Dot-prefixed font names don't survive the round-trip through
+CTFontDescriptorCopyAttributes(CTFontCopyFontDescriptor(font)) unless you also
+pass in the kCTFontOptionsSystemUIFont option.
+
+Tests: fast/text/system-fallback-canvas.html
+   fast/text/draw-synthetic-system-bold-font-into-canvas.html
+
+* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
+(IPC::createCTFont):
+(IPC::ArgumentCoder>::decodePlatformData):
+
+LayoutTests:
+
+* fast/text/system-fallback-canvas-expected.txt: Added.
+* fast/text/system-fallback-canvas.html: Added.
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@281792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2021-08-31  Myles C. Maxfield  
+
+[Cocoa] Drawing system fallback fonts to canvas causes a crash
+https://bugs.webkit.org/show_bug.cgi?id=229633
+
+
+Reviewed by Wenson Hsieh.
+
+* fast/text/system-fallback-canvas-expected.txt: Added.
+* fast/text/system-fallback-canvas.html: Added.
+
 2021-09-01  Russell Epstein  
 
 Cherry-pick r281848. rdar://problem/82652449


Added: branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas-expected-mismatch.html (0 => 282243)

--- branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas-expected-mismatch.html	(rev 0)
+++ branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas-expected-mismatch.html	2021-09-09 23:48:17 UTC (rev 282243)
@@ -0,0 +1,15 @@
+
+
+
+
+canvas {
+width: 200px;
+height: 200px;
+margin-top: 0;
+}
+
+
+
+
+
+


Added: branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas.html (0 => 282243)

--- branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas.html	(rev 0)
+++ branches/safari-612-branch/LayoutTests/fast/text/draw-synthetic-system-bold-font-into-canvas.html	2021-09-09 23:48:17 UTC (rev 282243)
@@ -0,0 +1,32 @@
+
+
+
+
+
+canvas {
+width: 200px;
+height: 200px;
+margin-top: 0;
+}
+
+
+
+
+
+