[webkit-changes] [295525] trunk/Tools
Title: [295525] trunk/Tools
Revision 295525
Author clo...@igalia.com
Date 2022-06-14 10:07:46 -0700 (Tue, 14 Jun 2022)
Log Message
Port to Python3
https://bugs.webkit.org/show_bug.cgi?id=230098
Reviewed by Aakash Jain.
Port browserperfdash-benchmark to python3 and invoke it with
the python3 interpreter on the CI.
* Tools/CISupport/build-webkit-org/steps.py:
(RunBenchmarkTests):
* Tools/Scripts/browserperfdash-benchmark:
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
(BrowserPerfDashRunner._parse_config_file):
(BrowserPerfDashRunner._upload_result):
Canonical link: https://commits.webkit.org/251530@main
Modified Paths
trunk/Tools/CISupport/build-webkit-org/steps.py
trunk/Tools/Scripts/browserperfdash-benchmark
trunk/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (295524 => 295525)
--- trunk/Tools/CISupport/build-webkit-org/steps.py 2022-06-14 16:21:47 UTC (rev 295524)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py 2022-06-14 17:07:46 UTC (rev 295525)
@@ -1128,7 +1128,7 @@
name = "benchmark-test"
description = ["benchmark tests running"]
descriptionDone = ["benchmark tests"]
-command = ["python", "Tools/Scripts/browserperfdash-benchmark", "--allplans",
+command = ["python3", "Tools/Scripts/browserperfdash-benchmark", "--allplans",
"--config-file", "../../browserperfdash-benchmark-config.txt",
"--browser-version", WithProperties("%(archive_revision)s")]
Modified: trunk/Tools/Scripts/browserperfdash-benchmark (295524 => 295525)
--- trunk/Tools/Scripts/browserperfdash-benchmark 2022-06-14 16:21:47 UTC (rev 295524)
+++ trunk/Tools/Scripts/browserperfdash-benchmark 2022-06-14 17:07:46 UTC (rev 295525)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
#
# Copyright (C) 2018 Igalia S.L.
#
Modified: trunk/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py (295524 => 295525)
--- trunk/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py 2022-06-14 16:21:47 UTC (rev 295524)
+++ trunk/Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py 2022-06-14 17:07:46 UTC (rev 295525)
@@ -22,7 +22,7 @@
import argparse
-import ConfigParser
+import configparser
import json
import logging
import os
@@ -81,7 +81,7 @@
def _parse_config_file(self, config_file):
if not os.path.isfile(config_file):
raise Exception('Can not open config file for uploading results at: {config_file}'.format(config_file=config_file))
-self._config_parser = ConfigParser.RawConfigParser()
+self._config_parser = configparser.RawConfigParser()
self._config_parser.read(config_file)
def _get_test_version_string(self, plan_name):
@@ -108,10 +108,10 @@
for server in self._config_parser.sections():
self._result_data['bot_id'] = self._config_parser.get(server, 'bot_id')
self._result_data['bot_password'] = self._config_parser.get(server, 'bot_password')
-post_data = urllib.urlencode(self._result_data)
+post_data = urllib.parse.urlencode(self._result_data).encode('utf-8')
post_url = self._config_parser.get(server, 'post_url')
try:
-post_request = urllib.urlopen(post_url, post_data)
+post_request = urllib.request.urlopen(post_url, post_data)
if post_request.getcode() == 200:
_log.info('Sucesfully uploaded results to server {server_name} for test {test_name} and browser {browser_name} version {browser_version}'.format(
server_name=server, test_name=self._result_data['test_id'], browser_name=self._result_data['browser_id'], browser_version=self._result_data['browser_version']))
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295520] trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/ simple_http_server_driver.py
Title: [295520] trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py
Revision 295520
Author clo...@igalia.com
Date 2022-06-14 03:12:28 -0700 (Tue, 14 Jun 2022)
Log Message
run-benchmark script fails to find the lsof command on Linux
https://bugs.webkit.org/show_bug.cgi?id=241081
Reviewed by Dewei Zhu.
The lsof command is shipped on Linux typically on /usr/bin meanwhile on
Mac is shipped on /usr/sbin. Check if is on PATH before defaulting to the
Mac path.
* Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver._find_http_server_port):
Canonical link: https://commits.webkit.org/251525@main
Modified Paths
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py
Diff
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py (295519 => 295520)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py 2022-06-14 10:01:45 UTC (rev 295519)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py 2022-06-14 10:12:28 UTC (rev 295520)
@@ -2,6 +2,7 @@
import os
import re
import subprocess
+import shutil
import sys
import time
@@ -66,7 +67,9 @@
self._server_port = connections[0].laddr[1]
except ImportError:
try:
-output = subprocess.check_output(['/usr/sbin/lsof', '-a', '-P', '-iTCP', '-sTCP:LISTEN', '-p', str(self._server_process.pid)])
+# lsof on Linux is shipped on /usr/bin typically, but on Mac on /usr/sbin
+lsof_path = shutil.which('lsof') or '/usr/sbin/lsof'
+output = subprocess.check_output([lsof_path, '-a', '-P', '-iTCP', '-sTCP:LISTEN', '-p', str(self._server_process.pid)])
self._server_port = int(re.search(r'TCP .*:(\d+) \(LISTEN\)', str(output)).group(1))
except Exception as error:
_log.info('Error: %s' % error)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [295505] trunk/metadata/contributors.json
Title: [295505] trunk/metadata/contributors.json Revision 295505 Author clo...@igalia.com Date 2022-06-13 16:42:46 -0700 (Mon, 13 Jun 2022) Log Message Add clopez github account to contributors.json https://bugs.webkit.org/show_bug.cgi?id=241578 Unreviewed. * metadata/contributors.json: Canonical link: https://commits.webkit.org/251510@main Modified Paths trunk/metadata/contributors.json Diff Modified: trunk/metadata/contributors.json (295504 => 295505) --- trunk/metadata/contributors.json 2022-06-13 22:48:33 UTC (rev 295504) +++ trunk/metadata/contributors.json 2022-06-13 23:42:46 UTC (rev 295505) @@ -1327,6 +1327,7 @@ "clo...@igalia.com" ], "expertise" : "The WebKitGTK and WPE ports, Tools, Build/test infrastructure", + "github" : "clopez", "name" : "Carlos Alberto Lopez Perez", "nicks" : [ "clopez" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292952] trunk/Source/WebCore
Title: [292952] trunk/Source/WebCore
Revision 292952
Author clo...@igalia.com
Date 2022-04-18 04:47:39 -0700 (Mon, 18 Apr 2022)
Log Message
[GTK][WPE] Build fix after r292951
https://bugs.webkit.org/show_bug.cgi?id=239426
Debug build was broken on GTK and WPE after r292951. Fix it.
Unreviewed build-fix.
No new tests, no change in behaviour.
* platform/network/MIMEHeader.cpp:
(WebCore::MIMEHeader::parseContentTransferEncoding):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/MIMEHeader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (292951 => 292952)
--- trunk/Source/WebCore/ChangeLog 2022-04-18 05:55:56 UTC (rev 292951)
+++ trunk/Source/WebCore/ChangeLog 2022-04-18 11:47:39 UTC (rev 292952)
@@ -1,3 +1,17 @@
+2022-04-18 Carlos Alberto Lopez Perez
+
+[GTK][WPE] Build fix after r292951
+https://bugs.webkit.org/show_bug.cgi?id=239426
+
+Debug build was broken on GTK and WPE after r292951. Fix it.
+
+Unreviewed build-fix.
+
+No new tests, no change in behaviour.
+
+* platform/network/MIMEHeader.cpp:
+(WebCore::MIMEHeader::parseContentTransferEncoding):
+
2022-04-17 Chris Dumez
Leverage StringView in more places
Modified: trunk/Source/WebCore/platform/network/MIMEHeader.cpp (292951 => 292952)
--- trunk/Source/WebCore/platform/network/MIMEHeader.cpp 2022-04-18 05:55:56 UTC (rev 292951)
+++ trunk/Source/WebCore/platform/network/MIMEHeader.cpp 2022-04-18 11:47:39 UTC (rev 292952)
@@ -131,7 +131,7 @@
return SevenBit;
if (equalLettersIgnoringASCIICase(encoding, "binary"))
return Binary;
-LOG_ERROR("Unknown encoding '%s' found in MIME header.", text.ascii().data());
+LOG_ERROR("Unknown encoding '%s' found in MIME header.", text.utf8().data());
return Unknown;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292769] trunk/Tools
Title: [292769] trunk/Tools
Revision 292769
Author clo...@igalia.com
Date 2022-04-12 07:06:35 -0700 (Tue, 12 Apr 2022)
Log Message
[GTK][WPE] generate-bundle: fix typo/bug in the wrapper shell code for the bundle after r292109.
https://bugs.webkit.org/show_bug.cgi?id=237107
There was a typo/bug in the shell code for the bundle that tried to check
if a path was absolute. Fix the issue and also improve the code a bit.
Unreviewed follow-up fix.
* Scripts/webkitpy/binary_bundling/bundle.py:
(BinaryBundler.generate_wrapper_script):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py
Diff
Modified: trunk/Tools/ChangeLog (292768 => 292769)
--- trunk/Tools/ChangeLog 2022-04-12 09:43:52 UTC (rev 292768)
+++ trunk/Tools/ChangeLog 2022-04-12 14:06:35 UTC (rev 292769)
@@ -1,3 +1,16 @@
+2022-04-12 Carlos Alberto Lopez Perez
+
+[GTK][WPE] generate-bundle: fix typo/bug in the wrapper shell code for the bundle after r292109.
+https://bugs.webkit.org/show_bug.cgi?id=237107
+
+There was a typo/bug in the shell code for the bundle that tried to check
+if a path was absolute. Fix the issue and also improve the code a bit.
+
+Unreviewed follow-up fix.
+
+* Scripts/webkitpy/binary_bundling/bundle.py:
+(BinaryBundler.generate_wrapper_script):
+
2022-04-11 Tyler Wilcock
AX: Update isolated tree in response to AXReadOnlyStatusChanged, AXRequiredStatusChanged, and AXPressedStateChanged notifications
Modified: trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py (292768 => 292769)
--- trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py 2022-04-12 09:43:52 UTC (rev 292768)
+++ trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py 2022-04-12 14:06:35 UTC (rev 292769)
@@ -164,12 +164,12 @@
script_handle.write('# Shipped binaries have a relpath to the interpreter, so update passed args with fullpaths and cd to ${MYDIR}\n')
script_handle.write('args_update_relpaths_to_abs() {\n')
script_handle.write('for arg in "$@"; do\n')
-script_handle.write(' [ -e "${arg}" -a "${arg}" != "${a#/}" ] && arg="$(readlink -f "${arg}")"\n')
+script_handle.write(' [ "${arg}" = "${arg#/}" ] && [ -e "${arg}" ] && arg="$(readlink -f -- "${arg}")"\n')
script_handle.write(' printf %s "${arg}" | sed "s/\'/\'\'\'/g;1s/^/\'/;\\$s/\\$/\' /"\n')
script_handle.write('done\n')
script_handle.write('echo " "\n')
script_handle.write('}\n')
-script_handle.write('eval "set -- "$(args_update_relpaths_to_abs "$@")""\n')
+script_handle.write('eval "set -- $(args_update_relpaths_to_abs "$@")"\n')
script_handle.write('cd "${MYDIR}"\n')
if os.path.isfile(os.path.join(share_dir, 'certs/bundle-ca-certificates.pem')):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292601] trunk/Tools/buildstream
Title: [292601] trunk/Tools/buildstream Revision 292601 Author clo...@igalia.com Date 2022-04-08 05:41:25 -0700 (Fri, 08 Apr 2022) Log Message [Flatpak SDK] Update patchelf recipe https://bugs.webkit.org/show_bug.cgi?id=238976 Reviewed by Philippe Normand. Update patchelf to the last stable release (0.14.5) patchelf is needed by the script generate-bundle. * elements/sdk/patchelf.bst: Modified Paths trunk/Tools/buildstream/ChangeLog trunk/Tools/buildstream/elements/sdk/patchelf.bst Diff Modified: trunk/Tools/buildstream/ChangeLog (292600 => 292601) --- trunk/Tools/buildstream/ChangeLog 2022-04-08 12:37:03 UTC (rev 292600) +++ trunk/Tools/buildstream/ChangeLog 2022-04-08 12:41:25 UTC (rev 292601) @@ -1,3 +1,15 @@ +2022-04-08 Carlos Alberto Lopez Perez + +[Flatpak SDK] Update patchelf recipe +https://bugs.webkit.org/show_bug.cgi?id=238976 + +Reviewed by Philippe Normand. + +Update patchelf to the last stable release (0.14.5) +patchelf is needed by the script generate-bundle. + +* elements/sdk/patchelf.bst: + 2022-03-30 Philippe Normand [Flatpak SDK] Bump to Meson 0.62. Modified: trunk/Tools/buildstream/elements/sdk/patchelf.bst (292600 => 292601) --- trunk/Tools/buildstream/elements/sdk/patchelf.bst 2022-04-08 12:37:03 UTC (rev 292600) +++ trunk/Tools/buildstream/elements/sdk/patchelf.bst 2022-04-08 12:41:25 UTC (rev 292601) @@ -1,5 +1,4 @@ kind: autotools - build-depends: - freedesktop-sdk.bst:public-stacks/buildsystem-autotools.bst @@ -9,5 +8,5 @@ sources: - kind: git_tag url: github_com:NixOS/patchelf.git - track: '0.10' - ref: 0.10-0-ge1e39f3639e39360ceebb2f7ed533cede4623070 + track: '0.14.5' + ref: 0.14.5-0-ga35054504293f9ff64539850d1ed0bfd2f5399f2 ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292584] trunk/Tools
Title: [292584] trunk/Tools
Revision 292584
Author clo...@igalia.com
Date 2022-04-07 17:51:43 -0700 (Thu, 07 Apr 2022)
Log Message
REGRESSION(r292109): [GTK][WPE] generate-bundle: Don't try to use the interpreter prefix when not bundling all.
https://bugs.webkit.org/show_bug.cgi?id=237107
For bundles of type --syslibs=generate-install-script we should
not try to prefix the executable with the interpreter.
Add a missing check to ensure that the interpreter has been copied
into the bundle before trying to use it.
Unreviewed follow-up fix.
* Scripts/webkitpy/binary_bundling/bundle.py:
(BinaryBundler.generate_wrapper_script):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py
Diff
Modified: trunk/Tools/ChangeLog (292583 => 292584)
--- trunk/Tools/ChangeLog 2022-04-08 00:49:58 UTC (rev 292583)
+++ trunk/Tools/ChangeLog 2022-04-08 00:51:43 UTC (rev 292584)
@@ -1,3 +1,18 @@
+2022-04-07 Carlos Alberto Lopez Perez
+
+REGRESSION(r292109): [GTK][WPE] generate-bundle: Don't try to use the interpreter prefix when not bundling all.
+https://bugs.webkit.org/show_bug.cgi?id=237107
+
+For bundles of type --syslibs=generate-install-script we should
+not try to prefix the executable with the interpreter.
+Add a missing check to ensure that the interpreter has been copied
+into the bundle before trying to use it.
+
+Unreviewed follow-up fix.
+
+* Scripts/webkitpy/binary_bundling/bundle.py:
+(BinaryBundler.generate_wrapper_script):
+
2022-04-07 Jonathan Bedard
[Merge-Queue] Add PushCommitToWebKitRepo
Modified: trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py (292583 => 292584)
--- trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py 2022-04-08 00:49:58 UTC (rev 292583)
+++ trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py 2022-04-08 00:51:43 UTC (rev 292584)
@@ -213,11 +213,14 @@
dlopenwrap_libname = 'dlopenwrap.so'
if os.path.isfile(os.path.join(lib_dir, dlopenwrap_libname)):
script_handle.write('export LD_PRELOAD="${%s}/lib/%s"\n' % (self.VAR_MYDIR, dlopenwrap_libname))
-# If we have patched the binaries to use a relative relpath then load the binary directly without prefixing it with the interpreter (it allows the process to use the correct progname)
-if self._has_patched_interpreter_relpath:
+
+# Prefix the program with the interpreter when we are bundling all (interpreter is copied) and the path to the interpreter isn't patched.
+# Otherwise prefer to not prefix it, because that allow the process to use a more meaningful progname.
+interpreter_basename = os.path.basename(interpreter)
+if os.path.isfile(os.path.join(lib_dir, interpreter_basename)) and not self._has_patched_interpreter_relpath:
+script_handle.write('INTERPRETER="${%s}/lib/%s"\n' % (self.VAR_MYDIR, interpreter_basename))
+script_handle.write('exec "${INTERPRETER}" "${%s}/bin/%s" "$@"\n' % (self.VAR_MYDIR, binary_to_wrap))
+else:
script_handle.write('exec "${%s}/bin/%s" "$@"\n' % (self.VAR_MYDIR, binary_to_wrap))
-else:
-script_handle.write('INTERPRETER="${%s}/lib/%s"\n' % (self.VAR_MYDIR, os.path.basename(interpreter)))
-script_handle.write('exec "${INTERPRETER}" "${%s}/bin/%s" "$@"\n' % (self.VAR_MYDIR, binary_to_wrap))
os.chmod(script_file, 0o755)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [292109] trunk
Title: [292109] trunk
Revision 292109
Author clo...@igalia.com
Date 2022-03-30 11:39:39 -0700 (Wed, 30 Mar 2022)
Log Message
[GTK][WPE] generate-bundle: self-contained bundle for the MiniBrowser that can work on any distro
https://bugs.webkit.org/show_bug.cgi?id=237107
Rubber-stamped by Philippe Normand.
Source/WebCore:
No new tests, no change in behaviour.
* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession): Allow to load the TLS database specified on the
environment variable WEBKIT_TLS_CAFILE_PEM when DEVELOPER_MODE is enabled
* platform/network/soup/SoupVersioning.h:
(soup_session_set_tls_database):
Tools:
This implements in the generate-bundle script the support to generate a bundle self-contained that can work on any distro.
To achieve that the bundle contains all the required system libraries inside the bundle (even the graphics drivers).
It also contains the required system resources: icons (for gtk), fontconfig files and fonts, etc.
A custom dlopenwrap library is also added and preloaded. The purpose of this library is to wrap all dlopen() calls
and rewrite the paths to ensure that only libraries inside the bundle are loaded.
The bundle has been tested to be generated with the flatpak build and executed on a range of very different distributions
with sucess: Fedora, Ubuntu, Debian, Alpine, CentOS (different versions of each)
* Scripts/bundle-binary:
* Scripts/generate-bundle:
* Scripts/webkitpy/binary_bundling/bundle.py:
(BinaryBundler):
(BinaryBundler.__init__):
(BinaryBundler._is_system_dep):
(BinaryBundler.set_use_sys_lib_directory):
(BinaryBundler.copy_and_maybe_strip_patchelf):
(BinaryBundler.destination_dir):
(BinaryBundler.generate_wrapper_script):
(BinaryBundler.copy_and_remove_rpath): Deleted.
* Scripts/webkitpy/binary_bundling/dlopenwrap/Makefile: Added.
* Scripts/webkitpy/binary_bundling/dlopenwrap/README.txt: Added.
* Scripts/webkitpy/binary_bundling/dlopenwrap/dlopenwrap.c: Added.
(dlopen_wrapper_path_join):
(is_dir):
(dlopen_wrapper_recursive_find):
(dlopen_wrapper_get_path_for_file_under_dir):
(dlopen_wrapper_find_library_on_libpath):
(dlopen):
(dlmopen):
(dlerror):
* Scripts/webkitpy/style/checker.py:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp
trunk/Source/WebCore/platform/network/soup/SoupVersioning.h
trunk/Tools/ChangeLog
trunk/Tools/Scripts/bundle-binary
trunk/Tools/Scripts/generate-bundle
trunk/Tools/Scripts/webkitpy/binary_bundling/bundle.py
trunk/Tools/Scripts/webkitpy/style/checker.py
Added Paths
trunk/Tools/Scripts/webkitpy/binary_bundling/dlopenwrap/
trunk/Tools/Scripts/webkitpy/binary_bundling/dlopenwrap/Makefile
trunk/Tools/Scripts/webkitpy/binary_bundling/dlopenwrap/README.txt
trunk/Tools/Scripts/webkitpy/binary_bundling/dlopenwrap/dlopenwrap.c
Diff
Modified: trunk/Source/WebCore/ChangeLog (292108 => 292109)
--- trunk/Source/WebCore/ChangeLog 2022-03-30 17:38:41 UTC (rev 292108)
+++ trunk/Source/WebCore/ChangeLog 2022-03-30 18:39:39 UTC (rev 292109)
@@ -1,3 +1,18 @@
+2022-03-30 Carlos Alberto Lopez Perez
+
+[GTK][WPE] generate-bundle: self-contained bundle for the MiniBrowser that can work on any distro
+https://bugs.webkit.org/show_bug.cgi?id=237107
+
+Rubber-stamped by Philippe Normand.
+
+No new tests, no change in behaviour.
+
+* platform/network/soup/SoupNetworkSession.cpp:
+(WebCore::SoupNetworkSession::SoupNetworkSession): Allow to load the TLS database specified on the
+environment variable WEBKIT_TLS_CAFILE_PEM when DEVELOPER_MODE is enabled
+* platform/network/soup/SoupVersioning.h:
+(soup_session_set_tls_database):
+
2022-03-30 Chris Dumez
Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets
Modified: trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp (292108 => 292109)
--- trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2022-03-30 17:38:41 UTC (rev 292108)
+++ trunk/Source/WebCore/platform/network/soup/SoupNetworkSession.cpp 2022-03-30 18:39:39 UTC (rev 292109)
@@ -133,6 +133,21 @@
if (soup_auth_negotiate_supported() && !m_sessionID.isEphemeral())
soup_session_add_feature_by_type(m_soupSession.get(), SOUP_TYPE_AUTH_NEGOTIATE);
+#if ENABLE(DEVELOPER_MODE)
+// Optionally load a custom path with the TLS CAFile. This is used on the GTK/WPE bundles. See script generate-bundle
+// Don't enable this outside DEVELOPER_MODE because using a non-default TLS database has surprising undesired effects
+// on how certificate verification is performed. See https://webkit.org/b/237107#c14 and git commit 82999879b on glib
+const char* customTLSCAFile = g_getenv("WEBKIT_TLS_CAFILE_PEM");
+if (customTLSCAFile) {
+GUniqueOutPtr error;
+GRefPtr customTLSDB = adoptGRef(g_tls_file_database_new(customTLSCAFile, ()));
+if (error)
+
[webkit-changes] [289947] trunk/Tools
Title: [289947] trunk/Tools
Revision 289947
Author clo...@igalia.com
Date 2022-02-16 12:52:57 -0800 (Wed, 16 Feb 2022)
Log Message
[EWS][GTK] Send only one e-mail with all the list of flakies
https://bugs.webkit.org/show_bug.cgi?id=236705
Reviewed by Adrian Perez de Castro.
Sending one e-mail per test was too much e-mails and we were
spaming the bot watchers. Change it to only send one e-mail
per run with all the list of flakies on the body of the e-mail.
Fix also some issues detected on the code for sending the e-mails
(like a few undefined variables and function calls with wrong
paramters) that happened when running the unit test.
Add also unit tests to be able to check the contents of the
e-mails generated and also fix a logic error deteted when
working on the unit tests related to reporting
the pre_existent_non_flaky_failures for the GTK EWS.
* CISupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.send_email_for_new_build_failure):
(AnalyzeLayoutTestsResultsRedTree.send_email_for_pre_existent_failures):
(AnalyzeLayoutTestsResultsRedTree.send_email_for_flaky_failures_and_steps):
(AnalyzeLayoutTestsResultsRedTree.start):
* CISupport/ews-build/steps_unittest.py:
(BuildStepMixinAdditions.setUpBuildStep):
(BuildStepMixinAdditions._send_email):
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (289946 => 289947)
--- trunk/Tools/CISupport/ews-build/steps.py 2022-02-16 20:49:59 UTC (rev 289946)
+++ trunk/Tools/CISupport/ews-build/steps.py 2022-02-16 20:52:57 UTC (rev 289947)
@@ -2171,7 +2171,7 @@
if pr_number and not self.should_send_email_for_pr(pr_number):
return
if not patch_id and not (pr_number and sha):
-self._addToLog('Unrecognized change type')
+self._addToLog('stderr', 'Unrecognized change type')
return
change_string = None
@@ -2187,11 +2187,11 @@
self._addToLog('stdio', error)
if not change_author:
-self._addToLog('Unable to determine email address for {} from metadata/contributors.json. Skipping sending email.'.format(self.getProperty('owners', [])))
+self._addToLog('stderr', 'Unable to determine email address for {} from metadata/contributors.json. Skipping sending email.'.format(self.getProperty('owners', [])))
return
builder_name = self.getProperty('buildername', '')
-issue_id = self.getProperty('bug_id', '') or pr_number
+bug_id = self.getProperty('bug_id', '') or pr_number
title = self.getProperty('bug_title', '') or self.getProperty('github.title', '')
worker_name = self.getProperty('workername', '')
platform = self.getProperty('platform', '')
@@ -3038,7 +3038,7 @@
if pr_number and not self.should_send_email_for_pr(pr_number):
return
if not patch_id and not (pr_number and sha):
-self._addToLog('Unrecognized change type')
+self._addToLog('stderr', 'Unrecognized change type')
return
change_string = None
@@ -3054,11 +3054,11 @@
self._addToLog('stdio', error)
if not change_author:
-self._addToLog('Unable to determine email address for {} from metadata/contributors.json. Skipping sending email.'.format(self.getProperty('owners', [])))
+self._addToLog('stderr', 'Unable to determine email address for {} from metadata/contributors.json. Skipping sending email.'.format(self.getProperty('owners', [])))
return
builder_name = self.getProperty('buildername', '')
-issue_id = self.getProperty('bug_id', '') or pr_number
+bug_id = self.getProperty('bug_id', '') or pr_number
title = self.getProperty('bug_title', '') or self.getProperty('github.title', '')
worker_name = self.getProperty('workername', '')
patch_author = self.getProperty('patch_author', '')
@@ -3377,10 +3377,10 @@
pluralSuffix = 's' if number_failures > 1 else ''
email_subject = 'Info about {} pre-existent failure{} at {}'.format(number_failures, pluralSuffix, builder_name)
-email_test = 'Info about pre-existent (non-flaky) test failure{} at EWS:\n'.format(pluralSuffix)
-email_text = '- Build : {}\n'.format(build_url)
-email_text = '- Builder : {}\n'.format(builder_name)
-email_text = '- Worker : {}\n'.format(worker_name)
+email_text = 'Info about pre-existent (non-flaky) test failure{} at EWS:\n'.format(pluralSuffix)
+email_text += ' - Build : {}\n'.format(build_url)
+email_text += ' - Builder : {}\n'.format(builder_name)
+
[webkit-changes] [287196] trunk/LayoutTests
Title: [287196] trunk/LayoutTests Revision 287196 Author clo...@igalia.com Date 2021-12-17 10:55:42 -0800 (Fri, 17 Dec 2021) Log Message Unskip pointerevents layout tests https://bugs.webkit.org/show_bug.cgi?id=233498 Unreviewed gardening. This tests were skipped for all platforms. Skip only globally the pointerevents/ios ones that seem to fail on all platforms (even on iOS, at least on the open source builds). On iOS also the ones imported from WPT fail but those work on other platforms. * TestExpectations: * platform/ios-wk2/TestExpectations: * platform/win/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/ios-wk2/TestExpectations trunk/LayoutTests/platform/win/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (287195 => 287196) --- trunk/LayoutTests/ChangeLog 2021-12-17 18:11:49 UTC (rev 287195) +++ trunk/LayoutTests/ChangeLog 2021-12-17 18:55:42 UTC (rev 287196) @@ -1,3 +1,20 @@ +2021-12-17 Carlos Alberto Lopez Perez + +Unskip pointerevents layout tests +https://bugs.webkit.org/show_bug.cgi?id=233498 + +Unreviewed gardening. + +This tests were skipped for all platforms. +Skip only globally the pointerevents/ios ones that seem to fail on +all platforms (even on iOS, at least on the open source builds). +On iOS also the ones imported from WPT fail but those work on +other platforms. + +* TestExpectations: +* platform/ios-wk2/TestExpectations: +* platform/win/TestExpectations: + 2021-12-17 Gabriel Nava Marino null ptr deref in WebCore::findPlaceForCounter Modified: trunk/LayoutTests/TestExpectations (287195 => 287196) --- trunk/LayoutTests/TestExpectations 2021-12-17 18:11:49 UTC (rev 287195) +++ trunk/LayoutTests/TestExpectations 2021-12-17 18:55:42 UTC (rev 287196) @@ -79,7 +79,6 @@ http/tests/ssl/curl [ Skip ] model-element [ Skip ] system-preview [ Skip ] -pointerevents/ios [ Skip ] editing/pasteboard/dom-paste [ Skip ] editing/pasteboard/mac [ Skip ] fast/media/ios [ Skip ] @@ -1134,9 +1133,8 @@ # This test was created to test a mac-wk2 bugfix fast/animation/request-animation-frame-in-two-pages.html [ Skip ] -# Only supported on iOS -imported/w3c/web-platform-tests/pointerevents [ Skip ] -pointerevents [ Skip ] +# Only supported on iOS internal configurations, see: https://webkit.org/b/193214#c6 +pointerevents/ios [ Skip ] # permessage-deflate WebSocket extension only supported by Soup based ports http/tests/websocket/tests/hybi/imported/blink/permessage-deflate-comp-bit-onoff.html [ Skip ] Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (287195 => 287196) --- trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-12-17 18:11:49 UTC (rev 287195) +++ trunk/LayoutTests/platform/ios-wk2/TestExpectations 2021-12-17 18:55:42 UTC (rev 287196) @@ -2256,4 +2256,8 @@ imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https.html [ Pass Failure ] imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https.html [ Pass Failure ] imported/w3c/web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https.html [ Pass Failure ] -imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html [ Pass Failure ] \ No newline at end of file +imported/w3c/web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html [ Pass Failure ] + +# See webkit.org/b/233498 for context on this pointerevents tests +imported/w3c/web-platform-tests/pointerevents [ Skip ] +pointerevents/mouse [ Failure ] Modified: trunk/LayoutTests/platform/win/TestExpectations (287195 => 287196) --- trunk/LayoutTests/platform/win/TestExpectations 2021-12-17 18:11:49 UTC (rev 287195) +++ trunk/LayoutTests/platform/win/TestExpectations 2021-12-17 18:55:42 UTC (rev 287196) @@ -4771,3 +4771,6 @@ # The DocumentTimeline.maximumFrameRate property which this test is about is not available on Windows. webanimations/frame-rate/document-timeline-maximum-frame-rate.html [ Skip ] + +pointerevents/mouse/pointer-button-and-buttons.html [ Failure ] +pointerevents/mouse/pointer-capture.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287173] trunk/Source/WebCore
Title: [287173] trunk/Source/WebCore
Revision 287173
Author clo...@igalia.com
Date 2021-12-16 22:01:14 -0800 (Thu, 16 Dec 2021)
Log Message
REGRESSION(r287138) [GLIB] Build failure with GCC 8 and 9 in std::array to Span conversion
https://bugs.webkit.org/show_bug.cgi?id=234412
Reviewed by Darin Adler.
GCC < 10 and Clang < 7 have problems doing the conversion of the value if its marked const.
No new tests, is a build fix.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (287172 => 287173)
--- trunk/Source/WebCore/ChangeLog 2021-12-17 05:54:37 UTC (rev 287172)
+++ trunk/Source/WebCore/ChangeLog 2021-12-17 06:01:14 UTC (rev 287173)
@@ -1,3 +1,17 @@
+2021-12-16 Carlos Alberto Lopez Perez
+
+REGRESSION(r287138) [GLIB] Build failure with GCC 8 and 9 in std::array to Span conversion
+https://bugs.webkit.org/show_bug.cgi?id=234412
+
+Reviewed by Darin Adler.
+
+GCC < 10 and Clang < 7 have problems doing the conversion of the value if its marked const.
+
+No new tests, is a build fix.
+
+* accessibility/AccessibilityRenderObject.cpp:
+(WebCore::AccessibilityRenderObject::inheritsPresentationalRole const):
+
2021-12-16 Alex Christensen
Remove more NPAPI plugin code
Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (287172 => 287173)
--- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2021-12-17 05:54:37 UTC (rev 287172)
+++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2021-12-17 06:01:14 UTC (rev 287173)
@@ -3214,7 +3214,7 @@
// those child elements are also presentational. For example, becomes presentational from .
// http://www.w3.org/WAI/PF/aria/complete#presentation
-Span* const> parentTags;
+Span* const> parentTags;
switch (roleValue()) {
case AccessibilityRole::ListItem:
case AccessibilityRole::ListMarker: {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287162] trunk/Tools
Title: [287162] trunk/Tools Revision 287162 Author clo...@igalia.com Date 2021-12-16 16:02:09 -0800 (Thu, 16 Dec 2021) Log Message [GTK][WPE] Don't ignore stderr when calling flatpak in update-webkitgtk-libs https://bugs.webkit.org/show_bug.cgi?id=234407 Reviewed by Michael Catanzaro. Print stderr when calling flatpak, is useful to debug problems when it fails. * flatpak/flatpakutils.py: (WebkitFlatpak.run_in_sandbox): Modified Paths trunk/Tools/ChangeLog trunk/Tools/flatpak/flatpakutils.py Diff Modified: trunk/Tools/ChangeLog (287161 => 287162) --- trunk/Tools/ChangeLog 2021-12-16 23:45:48 UTC (rev 287161) +++ trunk/Tools/ChangeLog 2021-12-17 00:02:09 UTC (rev 287162) @@ -1,3 +1,15 @@ +2021-12-16 Carlos Alberto Lopez Perez + +[GTK][WPE] Don't ignore stderr when calling flatpak in update-webkitgtk-libs +https://bugs.webkit.org/show_bug.cgi?id=234407 + +Reviewed by Michael Catanzaro. + +Print stderr when calling flatpak, is useful to debug problems when it fails. + +* flatpak/flatpakutils.py: +(WebkitFlatpak.run_in_sandbox): + 2021-12-16 Alex Christensen Unreviewed, reverting r287056. Modified: trunk/Tools/flatpak/flatpakutils.py (287161 => 287162) --- trunk/Tools/flatpak/flatpakutils.py 2021-12-16 23:45:48 UTC (rev 287161) +++ trunk/Tools/flatpak/flatpakutils.py 2021-12-17 00:02:09 UTC (rev 287162) @@ -980,7 +980,7 @@ command = flatpak_command if gather_output: -return run_sanitized(command, gather_output=True, ignore_stderr=True, env=flatpak_env) +return run_sanitized(command, gather_output=True, ignore_stderr=False, env=flatpak_env) try: return self.execute_command(command, stdout=stdout, env=flatpak_env, keep_signals=keep_signals) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287134] trunk/Tools
Title: [287134] trunk/Tools
Revision 287134
Author clo...@igalia.com
Date 2021-12-16 07:16:46 -0800 (Thu, 16 Dec 2021)
Log Message
[GTK] Add gtk-wk2 to EWS bubbles
https://bugs.webkit.org/show_bug.cgi?id=209104
Reviewed by Jonathan Bedard.
A new queue was added in 286405 which runs GTK LayoutTests.
This patch adds the queue to the EWS bubbles.
* CISupport/ews-app/ews/views/statusbubble.py:
(StatusBubble):
Modified Paths
trunk/Tools/CISupport/ews-app/ews/views/statusbubble.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-app/ews/views/statusbubble.py (287133 => 287134)
--- trunk/Tools/CISupport/ews-app/ews/views/statusbubble.py 2021-12-16 15:15:13 UTC (rev 287133)
+++ trunk/Tools/CISupport/ews-app/ews/views/statusbubble.py 2021-12-16 15:16:46 UTC (rev 287134)
@@ -44,7 +44,7 @@
# FIXME: Auto-generate this list https://bugs.webkit.org/show_bug.cgi?id=195640
# Note: This list is sorted in the order of which bubbles appear in bugzilla.
ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'mac-AS-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win',
- 'ios-wk2', 'mac-wk1', 'mac-wk2', 'mac-wk2-stress', 'mac-debug-wk1', 'mac-AS-debug-wk2', 'api-ios', 'api-mac', 'api-gtk',
+ 'ios-wk2', 'mac-wk1', 'mac-wk2', 'mac-wk2-stress', 'mac-debug-wk1', 'mac-AS-debug-wk2', 'gtk-wk2', 'api-ios', 'api-mac', 'api-gtk',
'bindings', 'jsc', 'jsc-armv7', 'jsc-armv7-tests', 'jsc-mips', 'jsc-mips-tests', 'jsc-i386', 'webkitperl', 'webkitpy', 'services']
# FIXME: Auto-generate the queue's trigger relationship
QUEUE_TRIGGERS = {
@@ -57,6 +57,7 @@
'mac-debug-wk1': 'mac-debug',
'mac-AS-debug-wk2': 'mac-AS-debug',
'api-gtk': 'gtk',
+'gtk-wk2': 'gtk',
'jsc-mips-tests': 'jsc-mips',
'jsc-armv7-tests': 'jsc-armv7',
}
Modified: trunk/Tools/ChangeLog (287133 => 287134)
--- trunk/Tools/ChangeLog 2021-12-16 15:15:13 UTC (rev 287133)
+++ trunk/Tools/ChangeLog 2021-12-16 15:16:46 UTC (rev 287134)
@@ -1,5 +1,18 @@
2021-12-16 Carlos Alberto Lopez Perez
+[GTK] Add gtk-wk2 to EWS bubbles
+https://bugs.webkit.org/show_bug.cgi?id=209104
+
+Reviewed by Jonathan Bedard.
+
+A new queue was added in 286405 which runs GTK LayoutTests.
+This patch adds the queue to the EWS bubbles.
+
+* CISupport/ews-app/ews/views/statusbubble.py:
+(StatusBubble):
+
+2021-12-16 Carlos Alberto Lopez Perez
+
[GTK][WPE] Apply optimizations to speed up the layout-test EWS and add a few more workers to the build ones.
https://bugs.webkit.org/show_bug.cgi?id=234378
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [287133] trunk/Tools
Title: [287133] trunk/Tools
Revision 287133
Author clo...@igalia.com
Date 2021-12-16 07:15:13 -0800 (Thu, 16 Dec 2021)
Log Message
[GTK][WPE] Apply optimizations to speed up the layout-test EWS and add a few more workers to the build ones.
https://bugs.webkit.org/show_bug.cgi?id=234378
Reviewed by Jonathan Bedard.
This applies two optimizations to speed up the testing on the layout-tests EWS added in r286405
1. Pass --fully-parallel to the retry steps. This makes the tool to utilize all the available workers for running
the tests instead of running them in serial. That makes the time needed to complete the retry steps to be considerable less,
In this example https://ews-build.webkit.org/#/builders/35/builds/1757 it reduces the timing from 43 mins to 12 mins.
2. When the first run fails without giving a list of failures and we have not reached the maximum retry count
we are going to end retring the whole testing anyway, so there is no point in running the tests without patch
in that case, we can skip doing that to save time. See: https://ews-build.webkit.org/#/builders/35/builds/1763
On top of that this patch adds an extra worker to the EWS build queues of GTK and WPE
because I detected that this queues sometimes are not fast enough.
* CISupport/ews-build/config.json:
* CISupport/ews-build/steps.py:
(BugzillaMixin.send_email_for_infrastructure_issue):
(RunWebKitTestsRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree.setLayoutTestCommand):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree.setLayoutTestCommand):
* CISupport/ews-build/steps_unittest.py:
Modified Paths
trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/config.json (287132 => 287133)
--- trunk/Tools/CISupport/ews-build/config.json 2021-12-16 15:00:03 UTC (rev 287132)
+++ trunk/Tools/CISupport/ews-build/config.json 2021-12-16 15:15:13 UTC (rev 287133)
@@ -19,8 +19,10 @@
{ "name": "igalia10-gtk-wk2-ews", "platform": "gtk" },
{ "name": "igalia11-gtk-wk2-ews", "platform": "gtk" },
{ "name": "igalia12-gtk-wk2-ews", "platform": "gtk" },
+{ "name": "igalia13-gtk-wk2-ews", "platform": "gtk" },
{ "name": "aperez-gtk-ews", "platform": "gtk" },
{ "name": "igalia-wpe-ews", "platform": "wpe" },
+{ "name": "igalia2-wpe-ews", "platform": "wpe" },
{ "name": "aperez-wpe-ews", "platform": "wpe" },
{ "name": "wincairo-ews-001", "platform": "wincairo" },
{ "name": "wincairo-ews-002", "platform": "wincairo" },
@@ -115,7 +117,7 @@
"factory": "GTKBuildFactory", "platform": "gtk",
"configuration": "release", "architectures": ["x86_64"],
"triggers": ["api-tests-gtk-ews", "gtk-wk2-tests-ews"],
- "workernames": ["igalia1-gtk-wk2-ews", "igalia2-gtk-wk2-ews", "aperez-gtk-ews"]
+ "workernames": ["aperez-gtk-ews", "igalia1-gtk-wk2-ews", "igalia2-gtk-wk2-ews", "igalia13-gtk-wk2-ews"]
},
{
"name": "GTK-WK2-Tests-EWS", "shortname": "gtk-wk2", "icon": "testOnly",
@@ -240,7 +242,7 @@
"name": "WPE-EWS", "shortname": "wpe", "icon": "buildOnly",
"factory": "WPEFactory", "platform": "wpe",
"configuration": "release", "architectures": ["x86_64"],
- "workernames": ["igalia-wpe-ews", "aperez-wpe-ews"]
+ "workernames": ["aperez-wpe-ews", "igalia-wpe-ews", "igalia2-wpe-ews"]
},
{
"name": "JSC-Tests-EWS", "shortname": "jsc", "icon": "buildAndTest",
Modified: trunk/Tools/CISupport/ews-build/steps.py (287132 => 287133)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-12-16 15:00:03 UTC (rev 287132)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-12-16 15:15:13 UTC (rev 287133)
@@ -755,7 +755,7 @@
build_url = '{}#/builders/{}/builds/{}'.format(self.master.config.buildbotURL, self.build._builderid, self.build.number)
email_subject = 'Infrastructure issue at {}'.format(builder_name)
email_text = 'The following infrastructure issue happened at:\n\n'
-email_text += '- Build : {}\n'.format(build_url)
+email_text += '- Build : email_text += '- Builder : {}\n'.format(builder_name)
email_text += '- Worker : {}\n'.format(worker_name)
email_text += '- Issue: {}\n'.format(infrastructure_issue_text)
@@ -2764,12 +2764,15 @@
self.build.results = SUCCESS
self.setProperty('build_summary', message)
else:
-# We have a failure return code, but not a list of failed or flaky tests.
-# So retry re-running the _whole_ layout tests without-patch to see if
-# this unexpected failure was pre-existent. If the failure was not pre-existent,
-# then we would not report a list of failed test, just a generic "unknown" failure.
+# We have a failure return code but not a list of
[webkit-changes] [286405] trunk/Tools
Title: [286405] trunk/Tools
Revision 286405
Author clo...@igalia.com
Date 2021-12-01 16:42:40 -0800 (Wed, 01 Dec 2021)
Log Message
[EWS][GTK][WPE] Add a new Class for running layout tests on the EWS for the GTK and WPE ports.
https://bugs.webkit.org/show_bug.cgi?id=231999
Reviewed by Jonathan Bedard.
This patch adds a new class to the EWS for running layout tests for the GTK and WPE ports.
It will be used initially for the GTK port and later for the WPE one.
Mac/iOS ports will continue to use the current default EWS, so no behaviour change for them.
This new class is specially designed to:
A. Work with a tree that is not always green (or even that is often quite red).
B. To not report any false positive to the patch author.
C. To allow patch authors to use this EWS to get new expectations for patches that need lot of new re-baselines (like a WPT import)
The very simplified logic of how this works is the following:
1. Run layout tests with patch (abort early at 500 unexpected failures)
2. Run layout tests with patch 10 times for each test that failed consistently (non-flaky) on step 1.
3. Run layout tests without patch 10 times for each test that failed consistently (non-flaky) on step 2.
Then report to the patch author only the new consistent failures (tests that failed always with the patch and passed always without the patch, retrying 10 times)
Any flaky test found is only reported to the bot watchers.
For an explainer about why this is needed, and more details about the flow diagram and several design considerations, please check:
https://people.igalia.com/clopez/wkbug/231999/explainer.html
The patch also add 3 new workers to the queue (to a total of 8) to speed up testing.
* CISupport/ews-build/config.json:
* CISupport/ews-build/factories.py:
(GTKTestsFactory):
* CISupport/ews-build/layout_test_failures.py:
(LayoutTestFailures.__init__):
(LayoutTestFailures.results_from_string):
(LayoutTestFailures.results_from_string.get_failing_tests):
* CISupport/ews-build/steps.py:
(BufferLogHeaderObserver):
(BufferLogHeaderObserver.__init__):
(BufferLogHeaderObserver.headerReceived):
(BufferLogHeaderObserver.getHeaders):
(BugzillaMixin.send_email_for_infrastructure_issue):
(Trigger.propertiesToPassToTriggers):
(RunWebKitTests.setLayoutTestCommand):
(RunWebKitTests.start):
(RunWebKitTests.commandComplete):
(ReRunWebKitTests.evaluateCommand):
(ReRunWebKitTests.commandComplete):
(RunWebKitTestsWithoutPatch.commandComplete):
(AnalyzeLayoutTestsResults.report_failure):
(AnalyzeLayoutTestsResults.send_email_for_flaky_failure):
(AnalyzeLayoutTestsResults.send_email_for_new_test_failures):
(AnalyzeLayoutTestsResults.start):
(RunWebKit1Tests.start):
(RunWebKitTestsRedTree):
(RunWebKitTestsRedTree._did_command_timed_out):
(RunWebKitTestsRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree):
(RunWebKitTestsRepeatFailuresRedTree.__init__):
(RunWebKitTestsRepeatFailuresRedTree.setLayoutTestCommand):
(RunWebKitTestsRepeatFailuresRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresRedTree.commandComplete):
(RunWebKitTestsRepeatFailuresRedTree.start):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree.__init__):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree.setLayoutTestCommand):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree.evaluateCommand):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree.commandComplete):
(RunWebKitTestsRepeatFailuresWithoutPatchRedTree.start):
(RunWebKitTestsWithoutPatchRedTree):
(RunWebKitTestsWithoutPatchRedTree.evaluateCommand):
(AnalyzeLayoutTestsResultsRedTree):
(AnalyzeLayoutTestsResultsRedTree.report_success):
(AnalyzeLayoutTestsResultsRedTree.report_warning):
(AnalyzeLayoutTestsResultsRedTree.report_infrastructure_issue_and_maybe_retry_build):
(AnalyzeLayoutTestsResultsRedTree.send_email_for_pre_existent_failures):
(AnalyzeLayoutTestsResultsRedTree.start):
* CISupport/ews-build/steps_unittest.py:
Modified Paths
trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/CISupport/ews-build/factories.py
trunk/Tools/CISupport/ews-build/layout_test_failures.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/config.json (286404 => 286405)
--- trunk/Tools/CISupport/ews-build/config.json 2021-12-02 00:31:47 UTC (rev 286404)
+++ trunk/Tools/CISupport/ews-build/config.json 2021-12-02 00:42:40 UTC (rev 286405)
@@ -16,6 +16,9 @@
{ "name": "igalia7-gtk-wk2-ews", "platform": "gtk" },
{ "name": "igalia8-gtk-wk2-ews", "platform": "gtk" },
{ "name": "igalia9-gtk-wk2-ews", "platform": "gtk" },
+{ "name": "igalia10-gtk-wk2-ews", "platform": "gtk" },
+{ "name": "igalia11-gtk-wk2-ews", "platform": "gtk&
[webkit-changes] [285496] trunk/Tools
Title: [285496] trunk/Tools
Revision 285496
Author clo...@igalia.com
Date 2021-11-09 06:40:32 -0800 (Tue, 09 Nov 2021)
Log Message
[EWS] Allow the optimization of running only the subset of failed tests on run-layout-tests-without-patch also for patches modifying the TestExpectations files
https://bugs.webkit.org/show_bug.cgi?id=231265
Reviewed by Alexey Proskuryakov.
On r274475 an optimization was applied to run-layout-tests-without-patch to only
run the subset of tests that failed with patch instead of the whole layout tests.
But this optimization had a corner case where it couldn't be applied.
It seems that we can still apply this optimization in this corner case if we pass
'--skipped=always' to run-webkit-tests so that Skipped tests are not run even if
those are specified as arguments on the command-line.
* CISupport/ews-build/steps.py:
(RunWebKitTests.setLayoutTestCommand):
(RunWebKitTestsWithoutPatch.setLayoutTestCommand):
* CISupport/ews-build/steps_unittest.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(RunTest.test_ews_corner_case_failing_test):
(RunTest):
(RunTest.test_ews_corner_case_failing_directory):
(RunTest.test_ews_corner_case_skipped_test):
(RunTest.test_ews_corner_case_skipped_directory):
* Scripts/webkitpy/port/test.py:
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py
trunk/Tools/Scripts/webkitpy/port/test.py
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (285495 => 285496)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-11-09 14:35:50 UTC (rev 285495)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-11-09 14:40:32 UTC (rev 285496)
@@ -2218,31 +2218,6 @@
if self.ENABLE_GUARD_MALLOC:
self.setCommand(self.command + ['--guard-malloc'])
-if self.name == 'run-layout-tests-without-patch':
-# In order to speed up testing, on the step that retries running the layout tests without patch
-# only run the subset of tests that failed on the previous steps.
-# But only do that if the previous steps didn't exceed the test failure limit and the patch doesn't
-# modify the TestExpectations files (there are corner cases where we can't guarantee the correctnes
-# of this optimization if the patch modifies the TestExpectations files, for example, if the patch
-# removes skipped tests but those tests still fail).
-first_results_did_exceed_test_failure_limit = self.getProperty('first_results_exceed_failure_limit', False)
-second_results_did_exceed_test_failure_limit = self.getProperty('second_results_exceed_failure_limit', False)
-if not first_results_did_exceed_test_failure_limit and not second_results_did_exceed_test_failure_limit:
-patch_modifies_expectation_files = False
-patch = self._get_patch()
-if patch:
-for line in patch.splitlines():
-line = line.strip()
-# patch is stored by buildbot as bytes: https://github.com/buildbot/buildbot/issues/5812#issuecomment-790175979
-if (b'LayoutTests/' in line and b'TestExpectations' in line) and (line.startswith(b'---') or line.startswith(b'+++')):
-patch_modifies_expectation_files = True
-break
-if not patch_modifies_expectation_files:
-first_results_failing_tests = set(self.getProperty('first_run_failures', set()))
-second_results_failing_tests = set(self.getProperty('second_run_failures', set()))
-list_retry_tests = sorted(first_results_failing_tests.union(second_results_failing_tests))
-self.setCommand(self.command + list_retry_tests)
-
def start(self):
self.log_observer = logobserver.BufferLogObserver(wantStderr=True)
self.addLogObserver('stdio', self.log_observer)
@@ -2498,7 +2473,26 @@
self._addToLog(self.test_failures_log_name, '\n'.join(clean_tree_results.failing_tests))
self._parseRunWebKitTestsOutput(logText)
+def setLayoutTestCommand(self):
+super(RunWebKitTestsWithoutPatch, self).setLayoutTestCommand()
+# In order to speed up testing, on the step that retries running the layout tests without patch
+# only run the subset of tests that failed on the previous steps.
+# But only do that if the previous steps didn't exceed the test failure limit
+# Also pass '--skipped=always' to avoid running a test that is skipped on the clean tree and that
+# the patch removed from the TestExpectations file meanwhile it still fails with the patch (so
+# it is passed as an argument on the command-line)
+# The flag
[webkit-changes] [284784] trunk/Tools
Title: [284784] trunk/Tools
Revision 284784
Author clo...@igalia.com
Date 2021-10-25 08:17:47 -0700 (Mon, 25 Oct 2021)
Log Message
[webkitpy] webkit-test-runner doesn't report all results when a test is run several times
https://bugs.webkit.org/show_bug.cgi?id=231790
Reviewed by Jonathan Bedard.
WTR was only picking one of the failure results when a test was run more than once
(for example with the flag --repeat-each=X), so it was not reporting all the values
that the test generated. This is a major issue when searching for flaky tests.
This patch adds a dictionary to store all the results of a given test on the repeated
repeats and then it ensures those values are taken into account when reporting the
final results for the test. It marks the test as flaky if more than one different value
was generated.
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.__init__):
(TestRunResults.add):
(TestRunResults.merge):
(summarize_results):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
Diff
Modified: trunk/Tools/ChangeLog (284783 => 284784)
--- trunk/Tools/ChangeLog 2021-10-25 14:36:41 UTC (rev 284783)
+++ trunk/Tools/ChangeLog 2021-10-25 15:17:47 UTC (rev 284784)
@@ -1,3 +1,25 @@
+2021-10-25 Carlos Alberto Lopez Perez
+
+[webkitpy] webkit-test-runner doesn't report all results when a test is run several times
+https://bugs.webkit.org/show_bug.cgi?id=231790
+
+Reviewed by Jonathan Bedard.
+
+WTR was only picking one of the failure results when a test was run more than once
+(for example with the flag --repeat-each=X), so it was not reporting all the values
+that the test generated. This is a major issue when searching for flaky tests.
+
+This patch adds a dictionary to store all the results of a given test on the repeated
+repeats and then it ensures those values are taken into account when reporting the
+final results for the test. It marks the test as flaky if more than one different value
+was generated.
+
+* Scripts/webkitpy/layout_tests/models/test_run_results.py:
+(TestRunResults.__init__):
+(TestRunResults.add):
+(TestRunResults.merge):
+(summarize_results):
+
2021-10-25 Aakash Jain
Add support for fast-cq mode to webkit-patch land-safely command
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (284783 => 284784)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2021-10-25 14:36:41 UTC (rev 284783)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2021-10-25 15:17:47 UTC (rev 284784)
@@ -58,6 +58,7 @@
self.expected_results_by_name = {}
self.unexpected_results_by_name = {}
self.failures_by_name = {}
+self.repeated_results_by_name = {} # Map of test name to a list of results, when a tests is run more than once (like when passing --repeat-each)
self.total_failures = 0
self.expected_skips = 0
for expectation in test_expectations.TestExpectations.EXPECTATIONS.values():
@@ -70,6 +71,9 @@
def add(self, test_result, expected):
self.tests_by_expectation[test_result.type].add(test_result.test_name)
+if test_result.test_name not in self.repeated_results_by_name:
+self.repeated_results_by_name[test_result.test_name] = set()
+self.repeated_results_by_name[test_result.test_name].add(test_result.type)
self.results_by_name[test_result.test_name] = self.results_by_name.get(test_result.test_name, test_result)
if test_result.is_other_crash:
return
@@ -158,6 +162,7 @@
self.unexpected_timeouts += test_run_results.unexpected_timeouts
self.tests_by_expectation = merge_dict_sets(self.tests_by_expectation, test_run_results.tests_by_expectation)
self.tests_by_timeline = merge_dict_sets(self.tests_by_timeline, test_run_results.tests_by_timeline)
+self.repeated_results_by_name = merge_dict_sets(self.repeated_results_by_name, test_run_results.repeated_results_by_name)
self.results_by_name.update(test_run_results.results_by_name)
self.all_results += test_run_results.all_results
self.expected_results_by_name.update(test_run_results.expected_results_by_name)
@@ -315,7 +320,9 @@
num_regressions += 1
test_dict['report'] = 'REGRESSION'
elif retry_results and test_name in retry_results.expected_results_by_name:
-actual.append(keywords[retry_results.expected_results_by_name[test_name].type])
+retry_result_name = keywords[retry_results.expected_results_by_name[test_name].type]
+if retry_result_name not in actual:
+actual.append(retry_result_name)
num_flaky += 1
[webkit-changes] [284198] trunk/Tools
Title: [284198] trunk/Tools
Revision 284198
Author clo...@igalia.com
Date 2021-10-14 14:18:44 -0700 (Thu, 14 Oct 2021)
Log Message
[webkitpy] The actual results reported for a flaky tests shouldn't include the expectation
https://bugs.webkit.org/show_bug.cgi?id=231241
Reviewed by Jonathan Bedard.
When a test is marked as flaky and fails the expectations on the
first run but passes on the second run (the retry) the current code
was adding the expectations to the actual results.
This is missleading and makes really hard to detect when a test stops
giving a specific expectation.
Instead of doing that report the actual results of the test on both runs.
* Scripts/webkitpy/layout_tests/models/test_run_results.py:
(TestRunResults.__init__):
(TestRunResults.add):
(TestRunResults.merge):
(summarize_results):
* Scripts/webkitpy/layout_tests/views/buildbot_results.py:
(BuildBotPrinter.print_unexpected_results):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py
trunk/Tools/Scripts/webkitpy/layout_tests/views/buildbot_results.py
Diff
Modified: trunk/Tools/ChangeLog (284197 => 284198)
--- trunk/Tools/ChangeLog 2021-10-14 21:14:26 UTC (rev 284197)
+++ trunk/Tools/ChangeLog 2021-10-14 21:18:44 UTC (rev 284198)
@@ -1,3 +1,26 @@
+2021-10-14 Carlos Alberto Lopez Perez
+
+[webkitpy] The actual results reported for a flaky tests shouldn't include the expectation
+https://bugs.webkit.org/show_bug.cgi?id=231241
+
+Reviewed by Jonathan Bedard.
+
+When a test is marked as flaky and fails the expectations on the
+first run but passes on the second run (the retry) the current code
+was adding the expectations to the actual results.
+This is missleading and makes really hard to detect when a test stops
+giving a specific expectation.
+
+Instead of doing that report the actual results of the test on both runs.
+
+* Scripts/webkitpy/layout_tests/models/test_run_results.py:
+(TestRunResults.__init__):
+(TestRunResults.add):
+(TestRunResults.merge):
+(summarize_results):
+* Scripts/webkitpy/layout_tests/views/buildbot_results.py:
+(BuildBotPrinter.print_unexpected_results):
+
2021-10-14 Myles C. Maxfield
All the SDKVariant.xcconfig files should match
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py (284197 => 284198)
--- trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2021-10-14 21:14:26 UTC (rev 284197)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/test_run_results.py 2021-10-14 21:18:44 UTC (rev 284198)
@@ -55,6 +55,7 @@
self.tests_by_timeline = {}
self.results_by_name = {} # Map of test name to the last result for the test.
self.all_results = [] # All results from a run, including every iteration of every test.
+self.expected_results_by_name = {}
self.unexpected_results_by_name = {}
self.failures_by_name = {}
self.total_failures = 0
@@ -79,6 +80,7 @@
self.total_failures += 1
self.failures_by_name[test_result.test_name] = test_result.failures
if expected:
+self.expected_results_by_name[test_result.test_name] = test_result
self.expected += 1
if test_result.type == test_expectations.SKIP:
self.expected_skips += 1
@@ -158,6 +160,7 @@
self.tests_by_timeline = merge_dict_sets(self.tests_by_timeline, test_run_results.tests_by_timeline)
self.results_by_name.update(test_run_results.results_by_name)
self.all_results += test_run_results.all_results
+self.expected_results_by_name.update(test_run_results.expected_results_by_name)
self.unexpected_results_by_name.update(test_run_results.unexpected_results_by_name)
self.failures_by_name.update(test_run_results.failures_by_name)
self.total_failures += test_run_results.total_failures
@@ -296,11 +299,7 @@
num_missing += 1
test_dict['report'] = 'MISSING'
elif test_name in initial_results.unexpected_results_by_name:
-if retry_results and test_name not in retry_results.unexpected_results_by_name:
-actual.extend(expectations.model().get_expectations_string(test_name).split(" "))
-num_flaky += 1
-test_dict['report'] = 'FLAKY'
-elif retry_results:
+if retry_results and test_name in retry_results.unexpected_results_by_name:
retry_result_type = retry_results.unexpected_results_by_name[test_name].type
if result_type != retry_result_type:
if enabled_pixel_tests_in_retry and result_type == test_expectations.TEXT and (retry_result_type == test_expectations.IMAGE_PLUS_TEXT or retry_result_type == test_expectations.MISSING):
@@ -315,6 +314,10 @@
[webkit-changes] [282100] trunk/Tools
Title: [282100] trunk/Tools
Revision 282100
Author clo...@igalia.com
Date 2021-09-07 11:18:49 -0700 (Tue, 07 Sep 2021)
Log Message
[build.webkit.org][ews-build.webkit.org] Only try to download from S3 on the production server
https://bugs.webkit.org/show_bug.cgi?id=230006
Reviewed by Aakash Jain.
The URL identifiers used for the S3 built products are not random,
they depend on the revision number or the patch number. So it can
happen than on a test deployment the tester downloads the built-product
from the official deployment at webkit.org rather than from its own worker.
Avoid this by ensuring that only on the official deployment it is tried to
download from S3. On the test deployments the code will now skip the step to
download from S3 and instead it will download the built product from the master.
* CISupport/build-webkit-org/steps.py:
(DownloadBuiltProduct.start):
* CISupport/ews-build/steps.py:
(DownloadBuiltProduct.getResultSummary):
(DownloadBuiltProduct.start):
* CISupport/ews-build/steps_unittest.py:
Modified Paths
trunk/Tools/CISupport/build-webkit-org/steps.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (282099 => 282100)
--- trunk/Tools/CISupport/build-webkit-org/steps.py 2021-09-07 18:14:25 UTC (rev 282099)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py 2021-09-07 18:18:49 UTC (rev 282100)
@@ -405,7 +405,12 @@
flunkOnFailure = False
def start(self):
-return shell.ShellCommand.start(self)
+# Only try to download from S3 on the official deployment
+if CURRENT_HOSTNAME == BUILD_WEBKIT_HOSTNAME:
+return shell.ShellCommand.start(self)
+self.build.addStepsAfterCurrentStep([DownloadBuiltProductFromMaster()])
+self.finished(SKIPPED)
+return defer.succeed(None)
def evaluateCommand(self, cmd):
rc = shell.ShellCommand.evaluateCommand(self, cmd)
Modified: trunk/Tools/CISupport/ews-build/steps.py (282099 => 282100)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-09-07 18:14:25 UTC (rev 282099)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-09-07 18:18:49 UTC (rev 282100)
@@ -2791,7 +2791,7 @@
flunkOnFailure = False
def getResultSummary(self):
-if self.results != SUCCESS:
+if self.results not in [SUCCESS, SKIPPED]:
return {'step': 'Failed to download built product from S3'}
return super(DownloadBuiltProduct, self).getResultSummary()
@@ -2798,6 +2798,14 @@
def __init__(self, **kwargs):
super(DownloadBuiltProduct, self).__init__(logEnviron=False, **kwargs)
+def start(self):
+# Only try to download from S3 on the official deployment
+if CURRENT_HOSTNAME == EWS_BUILD_HOSTNAME:
+return shell.ShellCommand.start(self)
+self.build.addStepsAfterCurrentStep([DownloadBuiltProductFromMaster()])
+self.finished(SKIPPED)
+return defer.succeed(None)
+
def evaluateCommand(self, cmd):
rc = shell.ShellCommand.evaluateCommand(self, cmd)
if rc == FAILURE:
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (282099 => 282100)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-09-07 18:14:25 UTC (rev 282099)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-09-07 18:18:49 UTC (rev 282100)
@@ -3039,7 +3039,8 @@
+ 0,
)
self.expectOutcome(result=SUCCESS, state_string='Downloaded built product')
-return self.runStep()
+with current_hostname(EWS_BUILD_HOSTNAME):
+return self.runStep()
def test_failure(self):
self.setupStep(DownloadBuiltProduct())
@@ -3056,9 +3057,20 @@
+ 2,
)
self.expectOutcome(result=FAILURE, state_string='Failed to download built product from S3')
-return self.runStep()
+with current_hostname(EWS_BUILD_HOSTNAME):
+return self.runStep()
+def test_deployment_skipped(self):
+self.setupStep(DownloadBuiltProduct())
+self.setProperty('fullPlatform', 'gtk')
+self.setProperty('configuration', 'release')
+self.setProperty('architecture', 'x86_64')
+self.setProperty('patch_id', '123456')
+self.expectOutcome(result=SKIPPED)
+with current_hostname('test-ews-deployment.igalia.com'):
+return self.runStep()
+
class TestDownloadBuiltProductFromMaster(BuildStepMixinAdditions, unittest.TestCase):
READ_LIMIT = 1000
Modified: trunk/Tools/ChangeLog (282099 => 282100)
--- trunk/Tools/ChangeLog 2021-09-07 18:14:25 UTC (rev 282099)
+++ trunk/Tools/ChangeLog 2021-09-07 18:18:49 UTC (rev 282100)
@@ -1,3 +1,26 @@
+2021-09-07 Carlos Alberto Lopez Perez
+
+[build.webkit.org][ews-build.webkit.org] Only try to download from S3 on the production server
+
[webkit-changes] [282082] trunk/Tools
Title: [282082] trunk/Tools Revision 282082 Author clo...@igalia.com Date 2021-09-07 07:13:50 -0700 (Tue, 07 Sep 2021) Log Message [GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash (v3) https://bugs.webkit.org/show_bug.cgi?id=229758 Reviewed by Philippe Normand. Add a new function in XvfbDriver() to ensure that the display server at a given display_id is replying as expected. Ask it for the screen size at monitor 0 and compare the result with the one we expect to have inside Xvfb. For doing this check a external python program is called which does the query using GTK. Using a external program is more robust against possible failures calling into GTK and also will allow re-using this program also to check that the weston server is also replying as expected for the weston driver (on a future patch). If the Xvfb driver is not replying as expected then restart it and try again, up to 3 retries. Use this also on the weston driver to check that the Xvfb driver is ready. The code is both compatible with python2 and python3, when running on python2 it will try first to use subprocess32 if available, otherwise will use standard python2 subprocess without using the timeout feature. On this v3 fix an error that caused that the subprocess stderr was redirected to stdout by mistake. * Scripts/webkitpy/common/system/executive_mock.py: (MockProcess.__init__): (MockProcess.communicate): * Scripts/webkitpy/port/westondriver.py: (WestonDriver._setup_environ_for_test): * Scripts/webkitpy/port/westondriver_unittest.py: (WestonXvfbDriverDisplayTest._xvfb_check_if_ready): * Scripts/webkitpy/port/xvfbdriver.py: (XvfbDriver): (XvfbDriver.__init__): (XvfbDriver.check_driver): (XvfbDriver._xvfb_run): (XvfbDriver._xvfb_screen_size): (XvfbDriver._xvfb_stop): (XvfbDriver._xvfb_check_if_ready): (XvfbDriver._setup_environ_for_test): (XvfbDriver.has_crashed): (XvfbDriver.stop): * Scripts/webkitpy/port/xvfbdriver_unittest.py: (XvfbDriverTest.make_driver): (XvfbDriverTest.assertDriverStartSuccessful): (XvfbDriverTest.test_xvfb_start_and_ready): (XvfbDriverTest.test_xvfb_start_arbitrary_worker_number): (XvfbDriverTest.test_xvfb_not_replying): * gtk/print-screen-size: Added. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py trunk/Tools/Scripts/webkitpy/port/westondriver.py trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py trunk/Tools/Scripts/webkitpy/port/xvfbdriver.py trunk/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py Added Paths trunk/Tools/gtk/print-screen-size Diff Modified: trunk/Tools/ChangeLog (282081 => 282082) --- trunk/Tools/ChangeLog 2021-09-07 13:52:05 UTC (rev 282081) +++ trunk/Tools/ChangeLog 2021-09-07 14:13:50 UTC (rev 282082) @@ -1,3 +1,58 @@ +2021-09-07 Carlos Alberto Lopez Perez + +[GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash (v3) +https://bugs.webkit.org/show_bug.cgi?id=229758 + +Reviewed by Philippe Normand. + +Add a new function in XvfbDriver() to ensure that the display server +at a given display_id is replying as expected. Ask it for the screen +size at monitor 0 and compare the result with the one we expect to +have inside Xvfb. For doing this check a external python program is +called which does the query using GTK. Using a external program is +more robust against possible failures calling into GTK and also will +allow re-using this program also to check that the weston server is +also replying as expected for the weston driver (on a future patch). + +If the Xvfb driver is not replying as expected then restart it and +try again, up to 3 retries. + +Use this also on the weston driver to check that the Xvfb driver is +ready. + +The code is both compatible with python2 and python3, when running on +python2 it will try first to use subprocess32 if available, otherwise +will use standard python2 subprocess without using the timeout feature. + +On this v3 fix an error that caused that the subprocess stderr was +redirected to stdout by mistake. + +* Scripts/webkitpy/common/system/executive_mock.py: +(MockProcess.__init__): +(MockProcess.communicate): +* Scripts/webkitpy/port/westondriver.py: +(WestonDriver._setup_environ_for_test): +* Scripts/webkitpy/port/westondriver_unittest.py: +(WestonXvfbDriverDisplayTest._xvfb_check_if_ready): +* Scripts/webkitpy/port/xvfbdriver.py: +(XvfbDriver): +(XvfbDriver.__init__): +(XvfbDriver.check_driver): +(XvfbDriver._xvfb_run): +(XvfbDriver._xvfb_screen_size): +(XvfbDriver._xvfb_stop): +(XvfbDriver._xvfb_check_if_ready): +(XvfbDriver._setup_environ_for_test): +(XvfbDriver.has_crashed): +(XvfbDriver.stop): +
[webkit-changes] [282071] trunk/LayoutTests
Title: [282071] trunk/LayoutTests Revision 282071 Author clo...@igalia.com Date 2021-09-06 18:54:49 -0700 (Mon, 06 Sep 2021) Log Message [GTK][WPE] Gardening of two flaky tests and timeout. Unreviewed test gardening. * TestExpectations: * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (282070 => 282071) --- trunk/LayoutTests/ChangeLog 2021-09-07 01:14:51 UTC (rev 282070) +++ trunk/LayoutTests/ChangeLog 2021-09-07 01:54:49 UTC (rev 282071) @@ -1,3 +1,12 @@ +2021-09-06 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of two flaky tests and timeout. + +Unreviewed test gardening. + +* TestExpectations: +* platform/glib/TestExpectations: + 2021-09-06 Arcady Goldmints-Orlov [Gstreamer] Mark tests media/track/in-band/track-in-band-*-added-once.html as flaky Modified: trunk/LayoutTests/TestExpectations (282070 => 282071) --- trunk/LayoutTests/TestExpectations 2021-09-07 01:14:51 UTC (rev 282070) +++ trunk/LayoutTests/TestExpectations 2021-09-07 01:54:49 UTC (rev 282071) @@ -5084,3 +5084,5 @@ webkit.org/b/229726 imported/w3c/web-platform-tests/css/css-font-loading/fontface-override-descriptors.html [ ImageOnlyFailure ] webkit.org/b/229726 imported/w3c/web-platform-tests/css/css-font-loading/fontface-size-adjust-descriptor.html [ ImageOnlyFailure ] webkit.org/b/229727 imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-load-var.html [ Skip ] + +webkit.org/b/229975 fast/text/FontFaceSet-status-after-style-update.html [ Failure Pass ] Modified: trunk/LayoutTests/platform/glib/TestExpectations (282070 => 282071) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-09-07 01:14:51 UTC (rev 282070) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-09-07 01:54:49 UTC (rev 282071) @@ -2439,6 +2439,10 @@ webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-clip-content-box-002.html [ ImageOnlyFailure ] +webkit.org/b/229764 animations/background-position.html [ ImageOnlyFailure Pass ] + +webkit.org/b/229979 media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ] + # End: Common failures between GTK and WPE. # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [282065] trunk
Title: [282065] trunk
Revision 282065
Author clo...@igalia.com
Date 2021-09-06 15:03:44 -0700 (Mon, 06 Sep 2021)
Log Message
[CMake] Prefer python3 over python2
https://bugs.webkit.org/show_bug.cgi?id=229969
Reviewed by Michael Catanzaro.
Use the CMake module FindPython instead of FindPythonInterp.
FindPython looks preferably for version 3 of Python. If not found, then it looks for version 2.
* Source/cmake/WebKitCommon.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/WebKitCommon.cmake
Diff
Modified: trunk/ChangeLog (282064 => 282065)
--- trunk/ChangeLog 2021-09-06 19:48:30 UTC (rev 282064)
+++ trunk/ChangeLog 2021-09-06 22:03:44 UTC (rev 282065)
@@ -1,3 +1,15 @@
+2021-09-06 Carlos Alberto Lopez Perez
+
+[CMake] Prefer python3 over python2
+https://bugs.webkit.org/show_bug.cgi?id=229969
+
+Reviewed by Michael Catanzaro.
+
+Use the CMake module FindPython instead of FindPythonInterp.
+FindPython looks preferably for version 3 of Python. If not found, then it looks for version 2.
+
+* Source/cmake/WebKitCommon.cmake:
+
2021-09-03 Michael Catanzaro
Disable GCC_OFFLINEASM_SOURCE_MAP
Modified: trunk/Source/cmake/WebKitCommon.cmake (282064 => 282065)
--- trunk/Source/cmake/WebKitCommon.cmake 2021-09-06 19:48:30 UTC (rev 282064)
+++ trunk/Source/cmake/WebKitCommon.cmake 2021-09-06 22:03:44 UTC (rev 282065)
@@ -177,8 +177,10 @@
find_package(Perl 5.10.0 REQUIRED)
find_package(PerlModules COMPONENTS JSON::PP REQUIRED)
-set(Python_ADDITIONAL_VERSIONS 3)
-find_package(PythonInterp 2.7.0 REQUIRED)
+# This module looks preferably for version 3 of Python. If not found, version 2 is searched.
+find_package(Python COMPONENTS Interpreter REQUIRED)
+# Set the variable with uppercase name to keep compatibility with code and users expecting it.
+set(PYTHON_EXECUTABLE ${Python_EXECUTABLE} CACHE FILEPATH "Path to the Python interpreter")
# We cannot check for RUBY_FOUND because it is set only when the full package is installed and
# the only thing we need is the interpreter. Unlike Python, cmake does not provide a macro
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [282064] trunk/Tools
Title: [282064] trunk/Tools Revision 282064 Author clo...@igalia.com Date 2021-09-06 12:48:30 -0700 (Mon, 06 Sep 2021) Log Message [GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash https://bugs.webkit.org/show_bug.cgi?id=229758 Reviewed by Philippe Normand. Add a new function in XvfbDriver() to ensure that the display server at a given display_id is replying as expected. Ask it for the screen size at monitor 0 and compare the result with the one we expect to have inside Xvfb. For doing this check a external python program is called which does the query using GTK. Using a external program is more robust against possible failures calling into GTK and also will allow re-using this program also to check that the weston server is also replying as expected for the weston driver (on a future patch). If the Xvfb driver is not replying as expected then restart it and try again, up to 3 retries. Use this also on the weston driver to check that the Xvfb driver is ready. The code is both compatible with python2 and python3, when running on python2 it will try first to use subprocess32 if available, otherwise will use standard python2 subprocess without using the timeout feature. * Scripts/webkitpy/common/system/executive_mock.py: (MockProcess.__init__): (MockProcess.communicate): * Scripts/webkitpy/port/westondriver.py: (WestonDriver._setup_environ_for_test): * Scripts/webkitpy/port/westondriver_unittest.py: (WestonXvfbDriverDisplayTest._xvfb_check_if_ready): * Scripts/webkitpy/port/xvfbdriver.py: (XvfbDriver): (XvfbDriver.__init__): (XvfbDriver.check_driver): (XvfbDriver._xvfb_run): (XvfbDriver._xvfb_screen_size): (XvfbDriver._xvfb_stop): (XvfbDriver._xvfb_check_if_ready): (XvfbDriver._setup_environ_for_test): (XvfbDriver.has_crashed): (XvfbDriver.stop): * Scripts/webkitpy/port/xvfbdriver_unittest.py: (XvfbDriverTest.make_driver): (XvfbDriverTest.assertDriverStartSuccessful): (XvfbDriverTest.test_xvfb_start_and_ready): (XvfbDriverTest.test_xvfb_start_arbitrary_worker_number): (XvfbDriverTest.test_xvfb_not_replying): * gtk/print-screen-size: Added. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py trunk/Tools/Scripts/webkitpy/port/westondriver.py trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py trunk/Tools/Scripts/webkitpy/port/xvfbdriver.py trunk/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py Added Paths trunk/Tools/gtk/print-screen-size Diff Modified: trunk/Tools/ChangeLog (282063 => 282064) --- trunk/Tools/ChangeLog 2021-09-06 19:30:19 UTC (rev 282063) +++ trunk/Tools/ChangeLog 2021-09-06 19:48:30 UTC (rev 282064) @@ -1,3 +1,55 @@ +2021-09-06 Carlos Alberto Lopez Perez + +[GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash +https://bugs.webkit.org/show_bug.cgi?id=229758 + +Reviewed by Philippe Normand. + +Add a new function in XvfbDriver() to ensure that the display server +at a given display_id is replying as expected. Ask it for the screen +size at monitor 0 and compare the result with the one we expect to +have inside Xvfb. For doing this check a external python program is +called which does the query using GTK. Using a external program is +more robust against possible failures calling into GTK and also will +allow re-using this program also to check that the weston server is +also replying as expected for the weston driver (on a future patch). + +If the Xvfb driver is not replying as expected then restart it and +try again, up to 3 retries. + +Use this also on the weston driver to check that the Xvfb driver is +ready. + +The code is both compatible with python2 and python3, when running on +python2 it will try first to use subprocess32 if available, otherwise +will use standard python2 subprocess without using the timeout feature. + +* Scripts/webkitpy/common/system/executive_mock.py: +(MockProcess.__init__): +(MockProcess.communicate): +* Scripts/webkitpy/port/westondriver.py: +(WestonDriver._setup_environ_for_test): +* Scripts/webkitpy/port/westondriver_unittest.py: +(WestonXvfbDriverDisplayTest._xvfb_check_if_ready): +* Scripts/webkitpy/port/xvfbdriver.py: +(XvfbDriver): +(XvfbDriver.__init__): +(XvfbDriver.check_driver): +(XvfbDriver._xvfb_run): +(XvfbDriver._xvfb_screen_size): +(XvfbDriver._xvfb_stop): +(XvfbDriver._xvfb_check_if_ready): +(XvfbDriver._setup_environ_for_test): +(XvfbDriver.has_crashed): +(XvfbDriver.stop): +* Scripts/webkitpy/port/xvfbdriver_unittest.py: +(XvfbDriverTest.make_driver): +(XvfbDriverTest.assertDriverStartSuccessful): +(XvfbDriverTest.test_xvfb_start_and_ready): +
[webkit-changes] [281958] trunk/Tools
Title: [281958] trunk/Tools
Revision 281958
Author clo...@igalia.com
Date 2021-09-02 15:09:41 -0700 (Thu, 02 Sep 2021)
Log Message
[run-perf-tests] Add support for python3 and use it by default
https://bugs.webkit.org/show_bug.cgi?id=229783
Reviewed by Jonathan Bedard.
Make the script compatible with python3 and set it to use python3
by default. The script is still compatible with python2.
* CISupport/build-webkit-org/steps.py:
(RunAndUploadPerfTests):
* Scripts/run-perf-tests:
* Scripts/webkitpy/common/net/file_uploader.py:
(FileUploader._upload_data.callback):
(FileUploader):
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_upload_json):
Modified Paths
trunk/Tools/CISupport/build-webkit-org/steps.py
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-perf-tests
trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py
trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (281957 => 281958)
--- trunk/Tools/CISupport/build-webkit-org/steps.py 2021-09-02 22:00:58 UTC (rev 281957)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py 2021-09-02 22:09:41 UTC (rev 281958)
@@ -1024,7 +1024,7 @@
name = "perf-test"
description = ["perf-tests running"]
descriptionDone = ["perf-tests"]
-command = ["python", "./Tools/Scripts/run-perf-tests",
+command = ["python3", "./Tools/Scripts/run-perf-tests",
"--output-json-path", "perf-test-results.json",
"--worker-config-json-path", "../../perf-test-config.json",
"--no-show-results",
Modified: trunk/Tools/ChangeLog (281957 => 281958)
--- trunk/Tools/ChangeLog 2021-09-02 22:00:58 UTC (rev 281957)
+++ trunk/Tools/ChangeLog 2021-09-02 22:09:41 UTC (rev 281958)
@@ -1,3 +1,23 @@
+2021-09-02 Carlos Alberto Lopez Perez
+
+[run-perf-tests] Add support for python3 and use it by default
+https://bugs.webkit.org/show_bug.cgi?id=229783
+
+Reviewed by Jonathan Bedard.
+
+Make the script compatible with python3 and set it to use python3
+by default. The script is still compatible with python2.
+
+* CISupport/build-webkit-org/steps.py:
+(RunAndUploadPerfTests):
+* Scripts/run-perf-tests:
+* Scripts/webkitpy/common/net/file_uploader.py:
+(FileUploader._upload_data.callback):
+(FileUploader):
+* Scripts/webkitpy/performance_tests/perftestsrunner.py:
+* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+(MainTest.test_upload_json):
+
2021-09-02 Jonathan Bedard
[contributors.json] Relocation (Part 6)
Modified: trunk/Tools/Scripts/run-perf-tests (281957 => 281958)
--- trunk/Tools/Scripts/run-perf-tests 2021-09-02 22:00:58 UTC (rev 281957)
+++ trunk/Tools/Scripts/run-perf-tests 2021-09-02 22:09:41 UTC (rev 281958)
@@ -1,4 +1,4 @@
-#!/usr/bin/env python
+#!/usr/bin/env python3
# Copyright (C) 2012 Google Inc. All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
Modified: trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py (281957 => 281958)
--- trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py 2021-09-02 22:00:58 UTC (rev 281957)
+++ trunk/Tools/Scripts/webkitpy/common/net/file_uploader.py 2021-09-02 22:09:41 UTC (rev 281958)
@@ -31,6 +31,7 @@
import sys
from webkitpy.common.net.networktransaction import NetworkTransaction, NetworkTimeout
+from webkitcorepy import string_utils, unicode
if sys.version_info > (3, 0):
from urllib.request import Request, urlopen
@@ -105,7 +106,7 @@
# FIXME: Setting a timeout, either globally using socket.setdefaulttimeout()
# or in urlopen(), doesn't appear to work on Mac 10.5 with Python 2.7.
# For now we will ignore the timeout value and hope for the best.
-request = Request(self._url, data, {"Content-Type": content_type})
+request = Request(self._url, string_utils.encode(data), {string_utils.encode(b'Content-Type'): string_utils.encode(content_type)})
return urlopen(request)
return NetworkTransaction(timeout_seconds=self._timeout_seconds).run(callback)
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (281957 => 281958)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2021-09-02 22:00:58 UTC (rev 281957)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2021-09-02 22:09:41 UTC (rev 281958)
@@ -32,6 +32,7 @@
import json
import logging
import optparse
+import sys
import time
import datetime
@@ -42,6 +43,7 @@
from webkitpy.common.net.file_uploader import FileUploader
from webkitpy.performance_tests.perftest import PerfTestFactory
from webkitpy.performance_tests.perftest
[webkit-changes] [281942] trunk/Tools
Title: [281942] trunk/Tools Revision 281942 Author clo...@igalia.com Date 2021-09-02 11:41:23 -0700 (Thu, 02 Sep 2021) Log Message [GTK][WPE] Port API test runner to python3 (v2) https://bugs.webkit.org/show_bug.cgi?id=229782 Unreviewed follow-up fix after r281919 Remove change on the shebang of run-perf-tests that doesn't belong to this patch, not sure how this ended here, seems I messed it when working on the patch for bug 229783 * Scripts/run-perf-tests: Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/run-perf-tests Diff Modified: trunk/Tools/ChangeLog (281941 => 281942) --- trunk/Tools/ChangeLog 2021-09-02 18:37:07 UTC (rev 281941) +++ trunk/Tools/ChangeLog 2021-09-02 18:41:23 UTC (rev 281942) @@ -1,3 +1,15 @@ +2021-09-02 Carlos Alberto Lopez Perez + +[GTK][WPE] Port API test runner to python3 (v2) +https://bugs.webkit.org/show_bug.cgi?id=229782 + +Unreviewed follow-up fix after r281919 + +Remove change on the shebang of run-perf-tests that doesn't belong to this patch, +not sure how this ended here, seems I messed it when working on the patch for bug 229783 + +* Scripts/run-perf-tests: + 2021-09-02 Aakash Jain Move few scripts from python 2 to python3 Modified: trunk/Tools/Scripts/run-perf-tests (281941 => 281942) --- trunk/Tools/Scripts/run-perf-tests 2021-09-02 18:37:07 UTC (rev 281941) +++ trunk/Tools/Scripts/run-perf-tests 2021-09-02 18:41:23 UTC (rev 281942) @@ -1,4 +1,4 @@ -#!/usr/bin/env python3 +#!/usr/bin/env python # Copyright (C) 2012 Google Inc. All rights reserved. # # Redistribution and use in source and binary forms, with or without ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281919] trunk/Tools
Title: [281919] trunk/Tools
Revision 281919
Author clo...@igalia.com
Date 2021-09-02 04:45:38 -0700 (Thu, 02 Sep 2021)
Log Message
[GTK][WPE] Port API test runner to python3
https://bugs.webkit.org/show_bug.cgi?id=229782
Reviewed by Philippe Normand.
Port the GTK/WPE API test runner to be compatible with python3
and set it to run with python3 by default.
The runner is still compatible with python2 after this patch, so
we can land this without immediately requiring a restart of the CI.
* Scripts/run-gtk-tests:
(GtkTestRunner): Deleted.
(GtkTestRunner.__init__): Deleted.
(GtkTestRunner._ensure_accessibility_service_is_running): Deleted.
(GtkTestRunner._setup_testing_environment): Deleted.
(GtkTestRunner._tear_down_testing_environment): Deleted.
(GtkTestRunner.is_glib_test): Deleted.
(GtkTestRunner.is_google_test): Deleted.
(GtkTestRunner.is_qt_test): Deleted.
* Scripts/run-perf-tests:
* Scripts/run-wpe-tests:
(WPETestRunner): Deleted.
(WPETestRunner.__init__): Deleted.
(WPETestRunner.is_glib_test): Deleted.
(WPETestRunner.is_google_test): Deleted.
(WPETestRunner.is_qt_test): Deleted.
* glib/api_test_runner.py:
(TestRunner._get_tests_from_google_test_suite):
(TestRunner.run_tests):
(TestRunner.run_tests.number_of_tests):
* glib/common.py:
(parse_output_lines):
* glib/glib_test_runner.py:
(Message.create.read_string):
(Message):
(GLibTestRunner._read_from_pipe):
(GLibTestRunner._read_from_stderr):
(GLibTestRunner.run):
Modified Paths
trunk/Tools/CISupport/build-webkit-org/steps.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests
trunk/Tools/Scripts/run-perf-tests
trunk/Tools/Scripts/run-wpe-tests
trunk/Tools/glib/api_test_runner.py
trunk/Tools/glib/common.py
trunk/Tools/glib/glib_test_runner.py
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/steps.py (281918 => 281919)
--- trunk/Tools/CISupport/build-webkit-org/steps.py 2021-09-02 11:03:53 UTC (rev 281918)
+++ trunk/Tools/CISupport/build-webkit-org/steps.py 2021-09-02 11:45:38 UTC (rev 281919)
@@ -940,11 +940,11 @@
class RunGtkAPITests(RunGLibAPITests):
-command = ["python", "./Tools/Scripts/run-gtk-tests", WithProperties("--%(configuration)s")]
+command = ["python3", "./Tools/Scripts/run-gtk-tests", WithProperties("--%(configuration)s")]
class RunWPEAPITests(RunGLibAPITests):
-command = ["python", "./Tools/Scripts/run-wpe-tests", WithProperties("--%(configuration)s")]
+command = ["python3", "./Tools/Scripts/run-wpe-tests", WithProperties("--%(configuration)s")]
class RunWebDriverTests(shell.Test):
Modified: trunk/Tools/CISupport/ews-build/steps.py (281918 => 281919)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-09-02 11:03:53 UTC (rev 281918)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-09-02 11:45:38 UTC (rev 281919)
@@ -2857,7 +2857,7 @@
def start(self):
platform = self.getProperty('platform')
if platform == 'gtk':
-command = ['python', 'Tools/Scripts/run-gtk-tests',
+command = ['python3', 'Tools/Scripts/run-gtk-tests',
'--{0}'.format(self.getProperty('configuration')),
'--json-output={0}'.format(self.jsonFileName)]
self.setCommand(command)
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (281918 => 281919)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-09-02 11:03:53 UTC (rev 281918)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-09-02 11:45:38 UTC (rev 281919)
@@ -3275,7 +3275,7 @@
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
-command=['python', 'Tools/Scripts/run-gtk-tests', '--release', '--json-output={0}'.format(self.jsonFileName)],
+command=['python3', 'Tools/Scripts/run-gtk-tests', '--release', '--json-output={0}'.format(self.jsonFileName)],
logfiles={'json': self.jsonFileName},
)
+ ExpectShell.log('stdio', stdout='''...
@@ -3552,7 +3552,7 @@
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
-command=['python',
+command=['python3',
'Tools/Scripts/run-gtk-tests',
'--debug',
'--json-output={0}'.format(self.jsonFileName)],
Modified: trunk/Tools/ChangeLog (281918 => 281919)
--- trunk/Tools/ChangeLog 2021-09-02 11:03:53 UTC (rev 281918)
+++ trunk/Tools/ChangeLog 2021-09-02 11:45:38 UTC (rev 281919)
@@ -1,3 +1,44 @@
+2021-09-02 Carlos Alberto Lopez Perez
+
+[GTK][WPE] Port API test runner to python3
+https://bugs.webkit.org/show_bug.cgi?id=229782
+
+Reviewed by Philippe Normand.
+
+Port the GTK/WPE API test
[webkit-changes] [281874] trunk/Tools
Title: [281874] trunk/Tools
Revision 281874
Author clo...@igalia.com
Date 2021-09-01 13:56:14 -0700 (Wed, 01 Sep 2021)
Log Message
Unreviewed, reverting r281870.
It broke the GTK api test runner.
Reverted changeset:
"[GTK] The Xvfb display server may fail to start sometimes
causing tests to randomly crash"
https://bugs.webkit.org/show_bug.cgi?id=229758
https://commits.webkit.org/r281870
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py
trunk/Tools/Scripts/webkitpy/port/westondriver.py
trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py
trunk/Tools/Scripts/webkitpy/port/xvfbdriver.py
trunk/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py
Removed Paths
trunk/Tools/gtk/print-screen-size
Diff
Modified: trunk/Tools/ChangeLog (281873 => 281874)
--- trunk/Tools/ChangeLog 2021-09-01 20:44:40 UTC (rev 281873)
+++ trunk/Tools/ChangeLog 2021-09-01 20:56:14 UTC (rev 281874)
@@ -1,3 +1,16 @@
+2021-09-01 Carlos Alberto Lopez Perez
+
+Unreviewed, reverting r281870.
+
+It broke the GTK api test runner.
+
+Reverted changeset:
+
+"[GTK] The Xvfb display server may fail to start sometimes
+causing tests to randomly crash"
+https://bugs.webkit.org/show_bug.cgi?id=229758
+https://commits.webkit.org/r281870
+
2021-09-01 Jonathan Bedard
[git-webkit] Automatic rebasing or pull-requests (Follow-up fix.)
Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py (281873 => 281874)
--- trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py 2021-09-01 20:44:40 UTC (rev 281873)
+++ trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py 2021-09-01 20:56:14 UTC (rev 281874)
@@ -37,12 +37,12 @@
class MockProcess(object):
-def __init__(self, stdout='MOCK STDOUT\n', stderr='', returncode=0):
+def __init__(self, stdout='MOCK STDOUT\n', stderr=''):
self.pid = 42
self.stdout = BytesIO(string_utils.encode(stdout))
self.stderr = BytesIO(string_utils.encode(stderr))
self.stdin = BytesIO()
-self.returncode = returncode
+self.returncode = 0
self._is_running = False
def wait(self):
@@ -49,11 +49,9 @@
self._is_running = False
return self.returncode
-def communicate(self, input=None, timeout=None):
+def communicate(self, input=None):
self._is_running = False
-stdout = self.stdout.read() if isinstance(self.stdout, BytesIO) else self.stdout
-stderr = self.stderr.read() if isinstance(self.stderr, BytesIO) else self.stderr
-return (stdout, stderr)
+return (self.stdout, self.stderr)
def poll(self):
if self._is_running:
Modified: trunk/Tools/Scripts/webkitpy/port/westondriver.py (281873 => 281874)
--- trunk/Tools/Scripts/webkitpy/port/westondriver.py 2021-09-01 20:44:40 UTC (rev 281873)
+++ trunk/Tools/Scripts/webkitpy/port/westondriver.py 2021-09-01 20:56:14 UTC (rev 281874)
@@ -56,18 +56,7 @@
def _setup_environ_for_test(self):
driver_environment = super(WestonDriver, self)._setup_environ_for_test()
-xvfb_display_id = self._xvfbdriver._xvfb_run(driver_environment)
-driver_environment['DISPLAY'] = ':%d' % xvfb_display_id
-
-# Ensure that Xvfb is ready and replying and expected before continuing, give it 3 tries.
-if not self._xvfbdriver._xvfb_check_if_ready(xvfb_display_id):
-self._xvfbdriver._current_retry_start_xvfb += 1
-if self._xvfbdriver._current_retry_start_xvfb > 3:
-_log.error('Failed to start Xvfb display server ... giving up after 3 retries.')
-raise RuntimeError('Unable to start Xvfb display server')
-_log.error('Failed to start Xvfb display server ... retrying [ %s of 3 ].' % self._xvfbdriver._current_retry_start_xvfb)
-return self._setup_environ_for_test()
-
+driver_environment['DISPLAY'] = ":%d" % self._xvfbdriver._xvfb_run(driver_environment)
weston_socket = 'WKTesting-weston-%032x' % random.getrandbits(128)
weston_command = ['weston', '--socket=%s' % weston_socket, '--width=1024', '--height=768', '--use-pixman']
if self._port._should_use_jhbuild():
Modified: trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py (281873 => 281874)
--- trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py 2021-09-01 20:44:40 UTC (rev 281873)
+++ trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py 2021-09-01 20:56:14 UTC (rev 281874)
@@ -50,10 +50,7 @@
def _xvfb_run(self, environment):
return self._expected_xvfbdisplay
-def _xvfb_check_if_ready(self, display_id):
-return True
-
class WestonDriverTest(unittest.TestCase):
def make_driver(self):
port = Port(MockSystemHost(log_executive=True), 'westondrivertestport', options=MockOptions(configuration='Release'))
Modified:
[webkit-changes] [281870] trunk/Tools
Title: [281870] trunk/Tools Revision 281870 Author clo...@igalia.com Date 2021-09-01 13:20:47 -0700 (Wed, 01 Sep 2021) Log Message [GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash https://bugs.webkit.org/show_bug.cgi?id=229758 Reviewed by Philippe Normand. Add a new function in XvfbDriver() to ensure that the display server at a given display_id is replying as expected. Ask it for the screen size at monitor 0 and compare the result with the one we expect to have inside Xvfb. For doing this check a external python program is called which does the query using GTK. Using a external program is more robust against possible failures calling into GTK and also will allow re-using this program also to check that the weston server is also replying as expected for the weston driver (on a future patch). If the Xvfb driver is not replying as expected then restart it and try again, up to 3 retries. Use this also on the weston driver to check that the Xvfb driver is ready. * Scripts/webkitpy/common/system/executive_mock.py: (MockProcess.__init__): (MockProcess.communicate): * Scripts/webkitpy/port/westondriver.py: (WestonDriver._setup_environ_for_test): * Scripts/webkitpy/port/westondriver_unittest.py: (WestonXvfbDriverDisplayTest._xvfb_check_if_ready): * Scripts/webkitpy/port/xvfbdriver.py: (XvfbDriver): (XvfbDriver.__init__): (XvfbDriver.check_driver): (XvfbDriver._xvfb_run): (XvfbDriver._xvfb_screen_size): (XvfbDriver._xvfb_stop): (XvfbDriver._xvfb_check_if_ready): (XvfbDriver._setup_environ_for_test): (XvfbDriver.has_crashed): (XvfbDriver.stop): * Scripts/webkitpy/port/xvfbdriver_unittest.py: (XvfbDriverTest.make_driver): (XvfbDriverTest.assertDriverStartSuccessful): (XvfbDriverTest.test_xvfb_start_and_ready): (XvfbDriverTest.test_xvfb_start_arbitrary_worker_number): (XvfbDriverTest.test_xvfb_not_replying): * gtk/print-screen-size: Added. Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py trunk/Tools/Scripts/webkitpy/port/westondriver.py trunk/Tools/Scripts/webkitpy/port/westondriver_unittest.py trunk/Tools/Scripts/webkitpy/port/xvfbdriver.py trunk/Tools/Scripts/webkitpy/port/xvfbdriver_unittest.py Added Paths trunk/Tools/gtk/print-screen-size Diff Modified: trunk/Tools/ChangeLog (281869 => 281870) --- trunk/Tools/ChangeLog 2021-09-01 20:18:13 UTC (rev 281869) +++ trunk/Tools/ChangeLog 2021-09-01 20:20:47 UTC (rev 281870) @@ -1,3 +1,51 @@ +2021-09-01 Carlos Alberto Lopez Perez + +[GTK] The Xvfb display server may fail to start sometimes causing tests to randomly crash +https://bugs.webkit.org/show_bug.cgi?id=229758 + +Reviewed by Philippe Normand. + +Add a new function in XvfbDriver() to ensure that the display server +at a given display_id is replying as expected. Ask it for the screen +size at monitor 0 and compare the result with the one we expect to +have inside Xvfb. For doing this check a external python program is +called which does the query using GTK. Using a external program is +more robust against possible failures calling into GTK and also will +allow re-using this program also to check that the weston server is +also replying as expected for the weston driver (on a future patch). + +If the Xvfb driver is not replying as expected then restart it and +try again, up to 3 retries. + +Use this also on the weston driver to check that the Xvfb driver is +ready. + +* Scripts/webkitpy/common/system/executive_mock.py: +(MockProcess.__init__): +(MockProcess.communicate): +* Scripts/webkitpy/port/westondriver.py: +(WestonDriver._setup_environ_for_test): +* Scripts/webkitpy/port/westondriver_unittest.py: +(WestonXvfbDriverDisplayTest._xvfb_check_if_ready): +* Scripts/webkitpy/port/xvfbdriver.py: +(XvfbDriver): +(XvfbDriver.__init__): +(XvfbDriver.check_driver): +(XvfbDriver._xvfb_run): +(XvfbDriver._xvfb_screen_size): +(XvfbDriver._xvfb_stop): +(XvfbDriver._xvfb_check_if_ready): +(XvfbDriver._setup_environ_for_test): +(XvfbDriver.has_crashed): +(XvfbDriver.stop): +* Scripts/webkitpy/port/xvfbdriver_unittest.py: +(XvfbDriverTest.make_driver): +(XvfbDriverTest.assertDriverStartSuccessful): +(XvfbDriverTest.test_xvfb_start_and_ready): +(XvfbDriverTest.test_xvfb_start_arbitrary_worker_number): +(XvfbDriverTest.test_xvfb_not_replying): +* gtk/print-screen-size: Added. + 2021-09-01 Jonathan Bedard [git-webkit] Add automatic Editor configuration Modified: trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py (281869 => 281870) --- trunk/Tools/Scripts/webkitpy/common/system/executive_mock.py 2021-09-01 20:18:13 UTC (rev 281869) +++
[webkit-changes] [281824] trunk/LayoutTests
Title: [281824] trunk/LayoutTests Revision 281824 Author clo...@igalia.com Date 2021-08-31 14:57:15 -0700 (Tue, 31 Aug 2021) Log Message [GTK][WPE] Gardening of test failures Unreviewed test gardening. Report and mark new expected failures and rebase-line a few tests. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: * platform/gtk/fast/forms/basic-textareas-expected.png: * platform/gtk/fast/forms/basic-textareas-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt: Added. * platform/wpe/fast/forms/basic-textareas-expected.png: Added. * platform/wpe/fast/forms/basic-textareas-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.png trunk/LayoutTests/platform/gtk/fast/forms/basic-textareas-expected.txt Added Paths trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/inert/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt trunk/LayoutTests/platform/wpe/fast/forms/ trunk/LayoutTests/platform/wpe/fast/forms/basic-textareas-expected.png trunk/LayoutTests/platform/wpe/fast/forms/basic-textareas-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/inert/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (281823 => 281824) --- trunk/LayoutTests/ChangeLog 2021-08-31 21:15:32 UTC (rev 281823) +++ trunk/LayoutTests/ChangeLog 2021-08-31 21:57:15 UTC (rev 281824) @@ -1,3 +1,20 @@ +2021-08-31 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of test failures + +Unreviewed test gardening. + +Report and mark new expected failures and rebase-line a few tests. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: +* platform/gtk/fast/forms/basic-textareas-expected.png: +* platform/gtk/fast/forms/basic-textareas-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt: Added. +* platform/wpe/fast/forms/basic-textareas-expected.png: Added. +* platform/wpe/fast/forms/basic-textareas-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/inert/inert-retargeting-iframe.tentative-expected.txt: Added. + 2021-08-31 Eric Hutchison [Big Sur wk2] fast/hidpi/image-srcset-svg-canvas-2x.html is a flaky failure. Modified: trunk/LayoutTests/platform/glib/TestExpectations (281823 => 281824) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-08-31 21:15:32 UTC (rev 281823) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-08-31 21:57:15 UTC (rev 281824) @@ -2430,6 +2430,15 @@ webkit.org/b/229665 [ Debug ] fast/mediastream/screencapture-user-gesture.html [ Timeout ] webkit.org/b/229665 [ Debug ] webrtc/h264-high.html [ Timeout ] +webkit.org/b/229734 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-normal-hyphens-002.html [ ImageOnlyFailure ] +webkit.org/b/229734 imported/w3c/web-platform-tests/css/css-text/line-break/line-break-strict-hyphens-002.html [ ImageOnlyFailure ] + +webkit.org/b/229738 fast/text/whitespace/pre-break-word.html [ Failure ] +webkit.org/b/229738 fast/text/whitespace/tab-character-basics.html [ Failure ] +webkit.org/b/229738 fast/text/word-break.html [ Failure ] + +webkit.org/b/206753 imported/w3c/web-platform-tests/css/css-backgrounds/background-clip-content-box-002.html [ ImageOnlyFailure ] + # End: Common failures between GTK and WPE. # Modified: trunk/LayoutTests/platform/gtk/TestExpectations (281823 => 281824) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-31 21:15:32 UTC (rev 281823) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-31 21:57:15 UTC (rev 281824) @@ -951,10 +951,13 @@ webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-003.html [ ImageOnlyFailure ] webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-004.html [ ImageOnlyFailure ] +webkit.org/b/229732 imported/w3c/web-platform-tests/css/css-fonts/font-display/font-display-failure-fallback.html [ Failure ] +webkit.org/b/229732 fast/text/font-promises-gc.html [ Failure ] + +webkit.org/b/229740 fast/box-shadow/box-shadow-huge-area-crash.html [ ImageOnlyFailure Crash ] + # # End of Expected failures. -# -# Don't add
[webkit-changes] [281708] trunk
Title: [281708] trunk
Revision 281708
Author clo...@igalia.com
Date 2021-08-27 11:41:28 -0700 (Fri, 27 Aug 2021)
Log Message
[CMake] ICU 61.2 is required to build WebKit since r281375
https://bugs.webkit.org/show_bug.cgi?id=229608
Reviewed by Yusuke Suzuki.
Raise the minimum version required for ICU.
* Source/cmake/OptionsAppleWin.cmake:
* Source/cmake/OptionsFTW.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsJSCOnly.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/OptionsWinCairo.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/OptionsAppleWin.cmake
trunk/Source/cmake/OptionsFTW.cmake
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsJSCOnly.cmake
trunk/Source/cmake/OptionsMac.cmake
trunk/Source/cmake/OptionsPlayStation.cmake
trunk/Source/cmake/OptionsWPE.cmake
trunk/Source/cmake/OptionsWinCairo.cmake
Diff
Modified: trunk/ChangeLog (281707 => 281708)
--- trunk/ChangeLog 2021-08-27 18:20:51 UTC (rev 281707)
+++ trunk/ChangeLog 2021-08-27 18:41:28 UTC (rev 281708)
@@ -1,3 +1,21 @@
+2021-08-27 Carlos Alberto Lopez Perez
+
+[CMake] ICU 61.2 is required to build WebKit since r281375
+https://bugs.webkit.org/show_bug.cgi?id=229608
+
+Reviewed by Yusuke Suzuki.
+
+Raise the minimum version required for ICU.
+
+* Source/cmake/OptionsAppleWin.cmake:
+* Source/cmake/OptionsFTW.cmake:
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsJSCOnly.cmake:
+* Source/cmake/OptionsMac.cmake:
+* Source/cmake/OptionsPlayStation.cmake:
+* Source/cmake/OptionsWPE.cmake:
+* Source/cmake/OptionsWinCairo.cmake:
+
2021-08-25 Myles C. Maxfield
Add command to enable logging in the docs
Modified: trunk/Source/cmake/OptionsAppleWin.cmake (281707 => 281708)
--- trunk/Source/cmake/OptionsAppleWin.cmake 2021-08-27 18:20:51 UTC (rev 281707)
+++ trunk/Source/cmake/OptionsAppleWin.cmake 2021-08-27 18:41:28 UTC (rev 281708)
@@ -32,7 +32,7 @@
set(SQLite3_NAMES SQLite3${DEBUG_SUFFIX})
-find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
find_package(LibXml2 REQUIRED)
find_package(LibXslt REQUIRED)
find_package(SQLite3 REQUIRED)
Modified: trunk/Source/cmake/OptionsFTW.cmake (281707 => 281708)
--- trunk/Source/cmake/OptionsFTW.cmake 2021-08-27 18:20:51 UTC (rev 281707)
+++ trunk/Source/cmake/OptionsFTW.cmake 2021-08-27 18:41:28 UTC (rev 281708)
@@ -202,7 +202,7 @@
endif ()
find_package(CURL 7.60.0 REQUIRED)
-find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
find_package(JPEG 1.5.2 REQUIRED)
find_package(OpenSSL 2.0.0 REQUIRED)
find_package(PNG 1.6.34 REQUIRED)
Modified: trunk/Source/cmake/OptionsGTK.cmake (281707 => 281708)
--- trunk/Source/cmake/OptionsGTK.cmake 2021-08-27 18:20:51 UTC (rev 281707)
+++ trunk/Source/cmake/OptionsGTK.cmake 2021-08-27 18:41:28 UTC (rev 281708)
@@ -14,7 +14,7 @@
find_package(LibGcrypt 1.6.0 REQUIRED)
find_package(GLIB 2.44.0 REQUIRED COMPONENTS gio gio-unix gobject gthread gmodule)
find_package(HarfBuzz 0.9.18 REQUIRED COMPONENTS ICU)
-find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
find_package(JPEG REQUIRED)
find_package(LibXml2 2.8.0 REQUIRED)
find_package(PNG REQUIRED)
Modified: trunk/Source/cmake/OptionsJSCOnly.cmake (281707 => 281708)
--- trunk/Source/cmake/OptionsJSCOnly.cmake 2021-08-27 18:20:51 UTC (rev 281707)
+++ trunk/Source/cmake/OptionsJSCOnly.cmake 2021-08-27 18:41:28 UTC (rev 281708)
@@ -105,7 +105,7 @@
SET_AND_EXPOSE_TO_BUILD(WTF_DEFAULT_EVENT_LOOP 0)
endif ()
-find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
if (APPLE)
add_definitions(-DU_DISABLE_RENAMING=1)
endif ()
Modified: trunk/Source/cmake/OptionsMac.cmake (281707 => 281708)
--- trunk/Source/cmake/OptionsMac.cmake 2021-08-27 18:20:51 UTC (rev 281707)
+++ trunk/Source/cmake/OptionsMac.cmake 2021-08-27 18:41:28 UTC (rev 281708)
@@ -114,6 +114,6 @@
set(WebCore_LIBRARY_TYPE SHARED)
set(WebCoreTestSupport_LIBRARY_TYPE SHARED)
-find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+find_package(ICU 61.2 REQUIRED COMPONENTS data i18n uc)
find_package(LibXml2 2.8.0 REQUIRED)
find_package(LibXslt 1.1.7 REQUIRED)
Modified: trunk/Source/cmake/OptionsPlayStation.cmake (281707 => 281708)
--- trunk/Source/cmake/OptionsPlayStation.cmake 2021-08-27 18:20:51 UTC (rev 281707)
+++ trunk/Source/cmake/OptionsPlayStation.cmake 2021-08-27 18:41:28 UTC (rev 281708)
@@ -131,7 +131,7 @@
find_package(Fontconfig REQUIRED)
find_package(Freetype REQUIRED)
find_package(HarfBuzz REQUIRED COMPONENTS ICU)
-find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+find_package(ICU 61.2 REQUIRED COMPONENTS data i18n
[webkit-changes] [281333] trunk
Title: [281333] trunk
Revision 281333
Author clo...@igalia.com
Date 2021-08-20 13:05:57 -0700 (Fri, 20 Aug 2021)
Log Message
REGRESSION(r274166): [GTK] It broke run-_javascript_core-tests causing all tests to use lot of memory
https://bugs.webkit.org/show_bug.cgi?id=229321
Unreviewed, reverting r274166 because it caused JSC tests to use too much memory.
Reverted changeset:
"[GTK] Reenable -fvisibility=hidden"
https://bugs.webkit.org/show_bug.cgi?id=181916
https://commits.webkit.org/r274166
.:
* Source/cmake/OptionsGTK.cmake:
Source/WebCore:
Covered by existing tests.
* PlatformGTK.cmake:
* dom/EventTarget.cpp:
* dom/EventTarget.h:
Tools:
* TestWebKitAPI/PlatformGTK.cmake:
* TestWebKitAPI/glib/TestExpectations.json:
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformGTK.cmake
trunk/Source/WebCore/dom/EventTarget.cpp
trunk/Source/WebCore/dom/EventTarget.h
trunk/Source/cmake/OptionsGTK.cmake
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/PlatformGTK.cmake
trunk/Tools/TestWebKitAPI/glib/TestExpectations.json
Diff
Modified: trunk/ChangeLog (281332 => 281333)
--- trunk/ChangeLog 2021-08-20 19:44:41 UTC (rev 281332)
+++ trunk/ChangeLog 2021-08-20 20:05:57 UTC (rev 281333)
@@ -1,3 +1,17 @@
+2021-08-20 Carlos Alberto Lopez Perez
+
+REGRESSION(r274166): [GTK] It broke run-_javascript_core-tests causing all tests to use lot of memory
+https://bugs.webkit.org/show_bug.cgi?id=229321
+
+Unreviewed, reverting r274166 because it caused JSC tests to use too much memory.
+
+Reverted changeset:
+"[GTK] Reenable -fvisibility=hidden"
+https://bugs.webkit.org/show_bug.cgi?id=181916
+https://commits.webkit.org/r274166
+
+* Source/cmake/OptionsGTK.cmake:
+
2021-08-16 David Kilzer
"make analyze" should run clang static analyzer in deep mode
Modified: trunk/Source/WebCore/ChangeLog (281332 => 281333)
--- trunk/Source/WebCore/ChangeLog 2021-08-20 19:44:41 UTC (rev 281332)
+++ trunk/Source/WebCore/ChangeLog 2021-08-20 20:05:57 UTC (rev 281333)
@@ -1,3 +1,21 @@
+2021-08-20 Carlos Alberto Lopez Perez
+
+REGRESSION(r274166): [GTK] It broke run-_javascript_core-tests causing all tests to use lot of memory
+https://bugs.webkit.org/show_bug.cgi?id=229321
+
+Unreviewed, reverting r274166 because it caused JSC tests to use too much memory.
+
+Reverted changeset:
+"[GTK] Reenable -fvisibility=hidden"
+https://bugs.webkit.org/show_bug.cgi?id=181916
+https://commits.webkit.org/r274166
+
+Covered by existing tests.
+
+* PlatformGTK.cmake:
+* dom/EventTarget.cpp:
+* dom/EventTarget.h:
+
2021-08-20 Dean Jackson
[WebXR] A session with only one view should cover the full screen
Modified: trunk/Source/WebCore/PlatformGTK.cmake (281332 => 281333)
--- trunk/Source/WebCore/PlatformGTK.cmake 2021-08-20 19:44:41 UTC (rev 281332)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2021-08-20 20:05:57 UTC (rev 281333)
@@ -8,6 +8,13 @@
set(WebCore_OUTPUT_NAME WebCoreGTK)
+# FIXME: https://bugs.webkit.org/show_bug.cgi?id=181916
+# Remove these lines when turning on hidden visibility
+list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::WTF)
+if (NOT USE_SYSTEM_MALLOC)
+list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::bmalloc)
+endif ()
+
list(APPEND WebCore_UNIFIED_SOURCE_LIST_FILES
"SourcesGTK.txt"
Modified: trunk/Source/WebCore/dom/EventTarget.cpp (281332 => 281333)
--- trunk/Source/WebCore/dom/EventTarget.cpp 2021-08-20 19:44:41 UTC (rev 281332)
+++ trunk/Source/WebCore/dom/EventTarget.cpp 2021-08-20 20:05:57 UTC (rev 281333)
@@ -66,8 +66,6 @@
return EventTargetConcrete::create(context);
}
-EventTarget::~EventTarget() = default;
-
bool EventTarget::isNode() const
{
return false;
Modified: trunk/Source/WebCore/dom/EventTarget.h (281332 => 281333)
--- trunk/Source/WebCore/dom/EventTarget.h 2021-08-20 19:44:41 UTC (rev 281332)
+++ trunk/Source/WebCore/dom/EventTarget.h 2021-08-20 20:05:57 UTC (rev 281333)
@@ -103,7 +103,7 @@
const EventTargetData* eventTargetData() const;
protected:
-WEBCORE_EXPORT virtual ~EventTarget();
+virtual ~EventTarget() = default;
virtual EventTargetData* eventTargetData() = 0;
virtual EventTargetData* eventTargetDataConcurrently() = 0;
Modified: trunk/Source/cmake/OptionsGTK.cmake (281332 => 281333)
--- trunk/Source/cmake/OptionsGTK.cmake 2021-08-20 19:44:41 UTC (rev 281332)
+++ trunk/Source/cmake/OptionsGTK.cmake 2021-08-20 20:05:57 UTC (rev 281333)
@@ -5,10 +5,6 @@
SET_PROJECT_VERSION(2 33 3)
-set(CMAKE_C_VISIBILITY_PRESET hidden)
-set(CMAKE_CXX_VISIBILITY_PRESET hidden)
-set(bmalloc_LIBRARY_TYPE OBJECT)
-set(WTF_LIBRARY_TYPE OBJECT)
set(USER_AGENT_BRANDING "" CACHE STRING "Branding to add to user agent string")
Modified:
[webkit-changes] [281329] trunk/LayoutTests
Title: [281329] trunk/LayoutTests Revision 281329 Author clo...@igalia.com Date 2021-08-20 12:28:02 -0700 (Fri, 20 Aug 2021) Log Message [GTK][WPE] Gardening of expected failures Unreviewed gardening. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (281328 => 281329) --- trunk/LayoutTests/ChangeLog 2021-08-20 18:43:35 UTC (rev 281328) +++ trunk/LayoutTests/ChangeLog 2021-08-20 19:28:02 UTC (rev 281329) @@ -1,3 +1,12 @@ +2021-08-20 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of expected failures + +Unreviewed gardening. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: + 2021-08-20 Eric Hutchison [iOS wk2, Mac wk2] http/wpt/mediarecorder/video-rotation.html is a flaky failure. Modified: trunk/LayoutTests/platform/glib/TestExpectations (281328 => 281329) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-08-20 18:43:35 UTC (rev 281328) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-08-20 19:28:02 UTC (rev 281329) @@ -2355,6 +2355,12 @@ webkit.org/b/207062 imported/w3c/web-platform-tests/media-source/mediasource-replay.html [ Failure Pass ] +webkit.org/b/229343 fast/mediastream/getDisplayMedia-frame-rate.html [ Timeout ] + +webkit.org/b/229346 webrtc/multi-audio.html [ Timeout Pass ] + +webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-cluster-002.html [ ImageOnlyFailure ] + # End: Common failures between GTK and WPE. # Modified: trunk/LayoutTests/platform/gtk/TestExpectations (281328 => 281329) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-20 18:43:35 UTC (rev 281328) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-08-20 19:28:02 UTC (rev 281329) @@ -943,6 +943,13 @@ webkit.org/b/224967 webkit.org/b/225659 imported/w3c/web-platform-tests/css/selectors/focus-visible-002.html [ Crash Failure ] +webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-009.html [ ImageOnlyFailure ] +webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-010.html [ ImageOnlyFailure ] +webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-001.html [ ImageOnlyFailure ] +webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-002.html [ ImageOnlyFailure ] +webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-003.html [ ImageOnlyFailure ] +webkit.org/b/229347 imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-anywhere-inline-004.html [ ImageOnlyFailure ] + # # End of Expected failures. # @@ -1217,6 +1224,9 @@ webkit.org/b/229268 media/media-fragments/TC0009.html [ Failure Pass ] +# Flaky on skip-failing-test bot (EWS) +webkit.org/b/229270 fast/events/monotonic-event-time.html [ Failure Pass ] + # # End of Flaky tests # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281327] trunk/Tools
Title: [281327] trunk/Tools
Revision 281327
Author clo...@igalia.com
Date 2021-08-20 11:25:27 -0700 (Fri, 20 Aug 2021)
Log Message
[build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should run only layout tests
https://bugs.webkit.org/show_bug.cgi?id=229312
Reviewed by Jonathan Bedard.
Add a new factory for testing only layout tests and make this bot use it.
* CISupport/build-webkit-org/config.json:
* CISupport/build-webkit-org/factories.py:
(TestLayoutFactory):
(TestLayoutFactory.__init__):
* CISupport/build-webkit-org/factories_unittest.py:
(TestExpectedBuildSteps):
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/CISupport/build-webkit-org/factories.py
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (281326 => 281327)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2021-08-20 18:09:48 UTC (rev 281326)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2021-08-20 18:25:27 UTC (rev 281327)
@@ -436,7 +436,7 @@
"workernames": ["gtk-linux-bot-18"]
},
{
- "name": "GTK-Linux-64-bit-Release-Skip-Failing-Tests", "factory": "TestAllButJSCFactory", "builddir": "gtk-linux-64-release-skip-failing-tests",
+ "name": "GTK-Linux-64-bit-Release-Skip-Failing-Tests", "factory": "TestLayoutFactory", "builddir": "gtk-linux-64-release-skip-failing-tests",
"platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
"additionalArguments": ["--skip-failing-tests"],
"workernames": ["gtk-linux-bot-19"]
Modified: trunk/Tools/CISupport/build-webkit-org/factories.py (281326 => 281327)
--- trunk/Tools/CISupport/build-webkit-org/factories.py 2021-08-20 18:09:48 UTC (rev 281326)
+++ trunk/Tools/CISupport/build-webkit-org/factories.py 2021-08-20 18:25:27 UTC (rev 281327)
@@ -215,6 +215,20 @@
self.addStep(RunTest262Tests())
+class TestLayoutFactory(Factory):
+def __init__(self, platform, configuration, architectures, additionalArguments=None, device_model=None):
+Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, device_model)
+self.addStep(DownloadBuiltProduct())
+self.addStep(ExtractBuiltProduct())
+self.addStep(RunWebKitTests())
+if not platform.startswith('win'):
+self.addStep(RunDashboardTests())
+self.addStep(ArchiveTestResults())
+self.addStep(UploadTestResults())
+self.addStep(ExtractTestResults())
+self.addStep(SetPermissions())
+
+
class TestWebDriverFactory(Factory):
def __init__(self, platform, configuration, architectures, additionalArguments=None, device_model=None):
Factory.__init__(self, platform, configuration, architectures, False, additionalArguments, device_model)
Modified: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (281326 => 281327)
--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2021-08-20 18:09:48 UTC (rev 281326)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2021-08-20 18:25:27 UTC (rev 281327)
@@ -1052,12 +1052,7 @@
'archive-test-results',
'upload',
'extract-test-results',
-'set-permissions',
-'webkitpy-test',
-'webkitperl-test',
-'bindings-generation-tests',
-'builtins-generator-tests',
-'API-tests'
+'set-permissions'
],
'WinCairo-64-bit-WKL-Release-Build': [
'configure-build',
Modified: trunk/Tools/ChangeLog (281326 => 281327)
--- trunk/Tools/ChangeLog 2021-08-20 18:09:48 UTC (rev 281326)
+++ trunk/Tools/ChangeLog 2021-08-20 18:25:27 UTC (rev 281327)
@@ -1,5 +1,21 @@
2021-08-20 Carlos Alberto Lopez Perez
+[build.webkit.org] GTK-Linux-64-bit-Release-Skip-Failing-Tests worker should run only layout tests
+https://bugs.webkit.org/show_bug.cgi?id=229312
+
+Reviewed by Jonathan Bedard.
+
+Add a new factory for testing only layout tests and make this bot use it.
+
+* CISupport/build-webkit-org/config.json:
+* CISupport/build-webkit-org/factories.py:
+(TestLayoutFactory):
+(TestLayoutFactory.__init__):
+* CISupport/build-webkit-org/factories_unittest.py:
+(TestExpectedBuildSteps):
+
+2021-08-20 Carlos Alberto Lopez Perez
+
[ews-build.webkit.org] Add unit test with the expected build steps for each queue
https://bugs.webkit.org/show_bug.cgi?id=229319
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [281286] trunk/Tools
Title: [281286] trunk/Tools
Revision 281286
Author clo...@igalia.com
Date 2021-08-19 17:38:54 -0700 (Thu, 19 Aug 2021)
Log Message
[build.webkit.org] Port old unit test with the expected build steps to the new buildbot
https://bugs.webkit.org/show_bug.cgi?id=229311
Reviewed by Aakash Jain.
Port the test that checked every worker and the expected steps to the new buildbot version.
Also delete the file steps_unittest_old.py because the gross of the other tests contained in
this old file are already ported in the current steps_unittests.py
* CISupport/build-webkit-org/factories_unittest.py: Added.
(TestExpectedBuildSteps):
(TestExpectedBuildSteps.setUp):
(TestExpectedBuildSteps.test_all_expected_results):
(TestExpectedBuildSteps.test_unnecessary_expected_results):
* CISupport/build-webkit-org/steps_unittest_old.py: Removed.
Modified Paths
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/CISupport/build-webkit-org/factories_unittest.py
Removed Paths
trunk/Tools/CISupport/build-webkit-org/steps_unittest_old.py
Diff
Added: trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (0 => 281286)
--- trunk/Tools/CISupport/build-webkit-org/factories_unittest.py (rev 0)
+++ trunk/Tools/CISupport/build-webkit-org/factories_unittest.py 2021-08-20 00:38:54 UTC (rev 281286)
@@ -0,0 +1,1392 @@
+# Copyright (C) 2011-2020 Apple Inc. All rights reserved.
+# Copyright (C) 2021 Igalia S.L.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions
+# are met:
+# 1. Redistributions of source code must retain the above copyright
+# notice, this list of conditions and the following disclaimer.
+# 2. Redistributions in binary form must reproduce the above copyright
+# notice, this list of conditions and the following disclaimer in the
+# documentation and/or other materials provided with the distribution.
+#
+# THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND
+# ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
+# WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+# DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR
+# ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+# DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+# SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+# CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+# OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+import loadConfig
+import os
+
+from twisted.trial import unittest
+
+
+class TestExpectedBuildSteps(unittest.TestCase):
+
+expected_steps = {
+"Apple-BigSur-Release-Build": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"compile-webkit",
+"archive-built-product",
+"upload",
+"archive-built-product",
+"upload",
+"transfer-to-s3",
+"trigger"
+],
+"Apple-BigSur-AppleSilicon-Release-Test262-Tests": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"download-built-product",
+"extract-built-product",
+"test262-test"
+],
+"Apple-BigSur-Release-Test262-Tests": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"download-built-product",
+"extract-built-product",
+"test262-test"
+],
+"Apple-BigSur-Release-WK1-Tests": [
+"configure-build",
+"configuration",
+"clean-and-update-working-directory",
+"show-identifier",
+"kill-old-processes",
+"delete-WebKitBuild-directory",
+"delete-stale-build-files",
+"download-built-product",
+"extract-built-product",
+"wait-for-crash-collection",
+"layout-test",
+"dashboard-tests",
+"archive-test-results",
+"upload",
+"extract-test-results",
+"set-permissions",
+"run-api-tests",
+"lldb-webkit-test",
+
[webkit-changes] [281219] trunk/LayoutTests
Title: [281219] trunk/LayoutTests Revision 281219 Author clo...@igalia.com Date 2021-08-18 18:15:03 -0700 (Wed, 18 Aug 2021) Log Message [GTK][WPE] Gardening of layout tests Unreviewed test gardening. Mark expected failures after r281108 and others and update list of flaky tests. Rebaseline tests after r281136, r281127 and r281097. * platform/glib/TestExpectations: * platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added. * platform/gtk/TestExpectations: * platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Added Paths trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt trunk/LayoutTests/platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/ trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (281218 => 281219) --- trunk/LayoutTests/ChangeLog 2021-08-19 00:34:51 UTC (rev 281218) +++ trunk/LayoutTests/ChangeLog 2021-08-19 01:15:03 UTC (rev 281219) @@ -1,3 +1,23 @@ +2021-08-18 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of layout tests + +Unreviewed test gardening. + +Mark expected failures after r281108 and others and update list of flaky tests. +Rebaseline tests after r281136, r281127 and r281097. + +* platform/glib/TestExpectations: +* platform/glib/imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/module/integrity-expected.txt: Added. +* platform/gtk/TestExpectations: +* platform/gtk/fast/repaint/line-layout-block-shrink-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/rotate-by-added-angle-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-max-px-em-expected.txt: Added. +* platform/wpe/imported/w3c/web-platform-tests/css/css-typed-om/width-by-min-px-em-expected.txt: Added. + 2021-08-18 Fujii Hironori [Fetch API][WebKit1] http/tests/fetch/keepalive-fetch-2.html is randomly failing Modified: trunk/LayoutTests/platform/glib/TestExpectations (281218 => 281219) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-08-19 00:34:51 UTC (rev 281218) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-08-19 01:15:03 UTC (rev 281219) @@ -352,6 +352,8 @@ # Not supported. Skipped also in mac-wk1 and win ports. accessibility/nested-textareas-value-changed-notifications.html [ Skip ] +webkit.org/b/229261 accessibility/element-line-rects-and-text.html [ Missing ] + # # End of Accessibility-related bugs # @@ -2352,6 +2354,10 @@ # Test is a flaky timeout. The test is also
[webkit-changes] [281002] trunk/LayoutTests
Title: [281002] trunk/LayoutTests Revision 281002 Author clo...@igalia.com Date 2021-08-12 18:26:01 -0700 (Thu, 12 Aug 2021) Log Message [GTK][WPE] Gardening of layout test failures Unreviewed gardening Rebaseline tests after r280953 and r279838 and report and mark new expected failures. * platform/glib/TestExpectations: * platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/header-parsing.https-expected.txt: Added. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Added Paths trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/header-parsing.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (281001 => 281002) --- trunk/LayoutTests/ChangeLog 2021-08-13 01:13:17 UTC (rev 281001) +++ trunk/LayoutTests/ChangeLog 2021-08-13 01:26:01 UTC (rev 281002) @@ -1,3 +1,17 @@ +2021-08-12 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of layout test failures + +Unreviewed gardening + +Rebaseline tests after r280953 and r279838 and report and mark new expected failures. + +* platform/glib/TestExpectations: +* platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/dedicatedworker-report-only-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/content-security-policy/inside-worker/serviceworker-report-only.https.sub-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/html/cross-origin-embedder-policy/header-parsing.https-expected.txt: Added. +* platform/gtk/TestExpectations: + 2021-08-12 Ayumi Kojima [ Mac wk1 ] imported/w3c/web-platform-tests/FileAPI/url/url-in-tags.window.html is flaky failing. Modified: trunk/LayoutTests/platform/glib/TestExpectations (281001 => 281002) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-08-13 01:13:17 UTC (rev 281001) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-08-13 01:26:01 UTC (rev 281002) @@ -197,7 +197,6 @@ imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/form-controls/select-sizing-001.html [ Pass ] imported/w3c/web-platform-tests/html/rendering/non-replaced-elements/the-fieldset-and-legend-elements/fieldset-vertical.html [ Pass ] -imported/w3c/web-platform-tests/html/rendering/widgets/button-layout/propagate-text-decoration.html [ Pass ] imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/sizes-dynamic-002.html [ Pass ] @@ -1096,6 +1095,15 @@ webkit.org/b/219340 webgl/1.0.3/conformance/extensions/angle-instanced-arrays-out-of-bounds.html [ Failure ] +# Tests related with the WebGL/Metal backend, maybe should be skipped +webkit.org/b/229050 fast/canvas/webgl/shader-with-comma-op.html [ Failure ] +webkit.org/b/229050 fast/canvas/webgl/shader-with-struct-array.html [ Failure ] + +webkit.org/b/229051 webgl/1.0.x/conformance/glsl/bugs/character-set.html [ Failure ] +webkit.org/b/229051 webgl/1.0.x/conformance/misc/invalid-passed-params.html [ Failure ] + +webkit.org/b/229052 webgl/1.0.x/conformance/textures/misc/texture-corner-case-videos.html [ Failure ] + # # End of WebGL-related bugs # @@ -1155,6 +1163,8 @@ webkit.org/b/227987 http/tests/media/media-stream/get-display-media-prompt.html [ Timeout Pass ] +webkit.org/b/229055 http/wpt/webrtc/sframe-transform-error.html [ Failure ] + # # End of WebRTC-related bugs # @@ -2339,6 +2349,12 @@ webkit.org/b/228778 mhtml [ ImageOnlyFailure Pass ] +webkit.org/b/229057 media/event-attributes.html [ Pass Failure ] +webkit.org/b/229057 media/video-background-tab-playback.html [ Pass Failure ] + +webkit.org/b/229062 fast/forms/caps-lock-indicator-width.html [
[webkit-changes] [280466] trunk
Title: [280466] trunk
Revision 280466
Author clo...@igalia.com
Date 2021-07-29 19:57:55 -0700 (Thu, 29 Jul 2021)
Log Message
[WPE][GTK] build broken with python2 after r280382
https://bugs.webkit.org/show_bug.cgi?id=228629
Reviewed by Philippe Normand.
Source/_javascript_Core:
Call {PYTHON_EXECUTABLE} instead of python3.
* PlatformGTK.cmake:
Source/WebKit:
Call {PYTHON_EXECUTABLE} instead of python3. Our build currently
supports both versions of python (2 and 3). If the user wants
to force a specific version it can do that via the CMake argument
-DPYTHON_EXECUTABLE=/path/to/python/interpreter
No new tests, is a build fix.
* PlatformGTK.cmake:
* PlatformWPE.cmake:
Tools:
Fix compatibility with python2.
* glib/apply-build-revision-to-files.py:
(main):
Modified Paths
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/PlatformGTK.cmake
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/PlatformGTK.cmake
trunk/Source/WebKit/PlatformWPE.cmake
trunk/Tools/ChangeLog
trunk/Tools/glib/apply-build-revision-to-files.py
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (280465 => 280466)
--- trunk/Source/_javascript_Core/ChangeLog 2021-07-30 02:32:26 UTC (rev 280465)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-07-30 02:57:55 UTC (rev 280466)
@@ -1,3 +1,14 @@
+2021-07-29 Carlos Alberto Lopez Perez
+
+[WPE][GTK] build broken with python2 after r280382
+https://bugs.webkit.org/show_bug.cgi?id=228629
+
+Reviewed by Philippe Normand.
+
+Call {PYTHON_EXECUTABLE} instead of python3.
+
+* PlatformGTK.cmake:
+
2021-07-29 Tadeu Zagallo
definePropertyOnReceiver should check if receiver canPerformFastPutInline
Modified: trunk/Source/_javascript_Core/PlatformGTK.cmake (280465 => 280466)
--- trunk/Source/_javascript_Core/PlatformGTK.cmake 2021-07-30 02:32:26 UTC (rev 280465)
+++ trunk/Source/_javascript_Core/PlatformGTK.cmake 2021-07-30 02:57:55 UTC (rev 280466)
@@ -6,7 +6,7 @@
if (EXISTS "${TOOLS_DIR}/glib/apply-build-revision-to-files.py")
configure_file(_javascript_coregtk.pc.in ${_javascript_Core_PKGCONFIG_FILE} @ONLY)
add_custom_target(_javascript_Core-build-revision
-python3 "${TOOLS_DIR}/glib/apply-build-revision-to-files.py" ${_javascript_Core_PKGCONFIG_FILE}
+${PYTHON_EXECUTABLE} "${TOOLS_DIR}/glib/apply-build-revision-to-files.py" ${_javascript_Core_PKGCONFIG_FILE}
DEPENDS ${_javascript_Core_PKGCONFIG_FILE}
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} VERBATIM)
list(APPEND _javascript_Core_DEPENDENCIES
Modified: trunk/Source/WebKit/ChangeLog (280465 => 280466)
--- trunk/Source/WebKit/ChangeLog 2021-07-30 02:32:26 UTC (rev 280465)
+++ trunk/Source/WebKit/ChangeLog 2021-07-30 02:57:55 UTC (rev 280466)
@@ -1,3 +1,20 @@
+2021-07-29 Carlos Alberto Lopez Perez
+
+[WPE][GTK] build broken with python2 after r280382
+https://bugs.webkit.org/show_bug.cgi?id=228629
+
+Reviewed by Philippe Normand.
+
+Call {PYTHON_EXECUTABLE} instead of python3. Our build currently
+supports both versions of python (2 and 3). If the user wants
+to force a specific version it can do that via the CMake argument
+-DPYTHON_EXECUTABLE=/path/to/python/interpreter
+
+No new tests, is a build fix.
+
+* PlatformGTK.cmake:
+* PlatformWPE.cmake:
+
2021-07-29 Jer Noble
[macOS|AS] VTImageRotationSession returns a kVTImageRotationNotSupportedErr, breaks painting rotated videos
Modified: trunk/Source/WebKit/PlatformGTK.cmake (280465 => 280466)
--- trunk/Source/WebKit/PlatformGTK.cmake 2021-07-30 02:32:26 UTC (rev 280465)
+++ trunk/Source/WebKit/PlatformGTK.cmake 2021-07-30 02:57:55 UTC (rev 280466)
@@ -17,7 +17,7 @@
configure_file(gtk/webkit2gtk-web-extension.pc.in ${WebKit2WebExtension_PKGCONFIG_FILE} @ONLY)
configure_file(Shared/glib/BuildRevision.h.in ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/BuildRevision.h @ONLY)
add_custom_target(WebKit-build-revision
-python3 "${TOOLS_DIR}/glib/apply-build-revision-to-files.py" ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/BuildRevision.h ${WebKit2_PKGCONFIG_FILE} ${WebKit2WebExtension_PKGCONFIG_FILE}
+${PYTHON_EXECUTABLE} "${TOOLS_DIR}/glib/apply-build-revision-to-files.py" ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/BuildRevision.h ${WebKit2_PKGCONFIG_FILE} ${WebKit2WebExtension_PKGCONFIG_FILE}
DEPENDS ${WebKit2Gtk_FRAMEWORK_HEADERS_DIR}/BuildRevision.h ${WebKit2_PKGCONFIG_FILE} ${WebKit2WebExtension_PKGCONFIG_FILE}
WORKING_DIRECTORY ${CMAKE_SOURCE_DIR} VERBATIM)
list(APPEND WebKit_DEPENDENCIES
Modified: trunk/Source/WebKit/PlatformWPE.cmake (280465 => 280466)
--- trunk/Source/WebKit/PlatformWPE.cmake 2021-07-30 02:32:26 UTC (rev 280465)
+++ trunk/Source/WebKit/PlatformWPE.cmake 2021-07-30 02:57:55 UTC (rev 280466)
@@ -21,7 +21,7 @@
if (EXISTS "${TOOLS_DIR}/glib/apply-build-revision-to-files.py")
[webkit-changes] [280159] trunk/LayoutTests
Title: [280159] trunk/LayoutTests Revision 280159 Author clo...@igalia.com Date 2021-07-21 13:33:31 -0700 (Wed, 21 Jul 2021) Log Message [GTK][WPE] Update test expectations after r279987 and r280077. Unreviewed test gardening. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (280158 => 280159) --- trunk/LayoutTests/ChangeLog 2021-07-21 20:31:17 UTC (rev 280158) +++ trunk/LayoutTests/ChangeLog 2021-07-21 20:33:31 UTC (rev 280159) @@ -1,3 +1,12 @@ +2021-07-21 Carlos Alberto Lopez Perez + +[GTK][WPE] Update test expectations after r279987 and r280077. + +Unreviewed test gardening. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: + 2021-07-21 Robert Jenner [ Win EWS ] Multiple fast layout-tests are slowing down results Modified: trunk/LayoutTests/platform/glib/TestExpectations (280158 => 280159) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-07-21 20:31:17 UTC (rev 280158) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-07-21 20:33:31 UTC (rev 280159) @@ -1284,11 +1284,6 @@ # Flaky Unhandled promise rejection messages webkit.org/b/171094 imported/w3c/web-platform-tests/html/canvas/offscreen/fill-and-stroke-styles/2d.pattern.paint.repeat.coord1.html [ Pass Failure ] -webkit.org/b/214455 imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-change-checkbox.html [ Pass ] -webkit.org/b/214455 imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-alpha.html [ Pass ] -webkit.org/b/214455 imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-iframe-background-mismatch-opaque.html [ Pass ] -webkit.org/b/214455 imported/w3c/web-platform-tests/css/css-color-adjust/rendering/dark-color-scheme/color-scheme-visited-link-initial.html [ Pass ] - webkit.org/b/214456 imported/w3c/web-platform-tests/css/css-images/conic-gradient-center.html [ Pass ] webkit.org/b/214456 imported/w3c/web-platform-tests/css/css-images/multiple-position-color-stop-conic-2.html [ Pass ] webkit.org/b/214456 imported/w3c/web-platform-tests/css/css-images/tiled-conic-gradients.html [ Pass ] @@ -2326,6 +2321,9 @@ webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__secure.header.html [ Failure ] webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/document-cookie.non-secure.html [ Failure ] +webkit.org/b/228160 fast/selectors/input-with-selection-pseudo-element.html [ ImageOnlyFailure ] +webkit.org/b/228160 imported/blink/fast/table/whitespace-between-elements-with-table-cell-display-3.html [ ImageOnlyFailure ] + # End: Common failures between GTK and WPE. # Modified: trunk/LayoutTests/platform/gtk/TestExpectations (280158 => 280159) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-07-21 20:31:17 UTC (rev 280158) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-07-21 20:33:31 UTC (rev 280159) @@ -104,8 +104,6 @@ http/tests/cookies/same-site [ Pass ] -# Passing since r259532. -imported/w3c/web-platform-tests/css/css-ui/outline-019.html [ Pass ] imported/w3c/web-platform-tests/service-workers/service-worker/fetch-audio-tainting.https.html [ Pass ] @@ -1979,6 +1977,162 @@ webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/upper-armenian/css3-counter-styles-109.html [ ImageOnlyFailure ] webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/upper-armenian/css3-counter-styles-110.html [ ImageOnlyFailure ] +webkit.org/b/228153 accessibility/math-multiscript-attributes.html [ Failure ] +webkit.org/b/228153 css1/font_properties/font.html [ Failure ] +webkit.org/b/228153 css1/pseudo/multiple_pseudo_elements.html [ Failure ] +webkit.org/b/228153 css2.1/t051201-c23-first-line-00-b.html [ Failure ] +webkit.org/b/228153 css2.1/t1508-c527-font-04-b.html [ Failure ] +webkit.org/b/228153 css2.1/t1508-c527-font-05-b.html [ Failure ] +webkit.org/b/228153 css2.1/t1508-c527-font-07-b.html [ Failure ] +webkit.org/b/228153 css2.1/t1508-c527-font-10-c.html [ Failure ] +webkit.org/b/228153 css3/font-feature-font-face-local.html [ ImageOnlyFailure ] +webkit.org/b/228153 css3/masking/mask-base64.html [ ImageOnlyFailure ] +webkit.org/b/228153 fast/block/lineboxcontain/block-glyphs-replaced.html [ Failure ] +webkit.org/b/228153 fast/block/lineboxcontain/glyphs.html [ Failure ] +webkit.org/b/228153 fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-ink.html [ ImageOnlyFailure ] +webkit.org/b/228153 fast/css/css2-system-fonts.html [ Failure ] +webkit.org/b/228153
[webkit-changes] [279844] trunk/Tools
Title: [279844] trunk/Tools
Revision 279844
Author clo...@igalia.com
Date 2021-07-12 11:56:16 -0700 (Mon, 12 Jul 2021)
Log Message
[GTK] Add a new GTK layout tester bot to build.webkit.org that runs with --skip-failing-tests switch
https://bugs.webkit.org/show_bug.cgi?id=227744
Reviewed by Jonathan Bedard.
On the EWS the layout tests run with this switch --skip-failing-tests
which changes the order in which tests are run (those expected to fail
are not scheduled). I think this may be causing different results on
other tests (like unexpected failures or unexpected flakies).
Having a bot in build.webkit.org running with this switch will help
to detect and garden those cases.
* CISupport/build-webkit-org/config.json:
Modified Paths
trunk/Tools/CISupport/build-webkit-org/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build-webkit-org/config.json (279843 => 279844)
--- trunk/Tools/CISupport/build-webkit-org/config.json 2021-07-12 18:52:58 UTC (rev 279843)
+++ trunk/Tools/CISupport/build-webkit-org/config.json 2021-07-12 18:56:16 UTC (rev 279844)
@@ -113,6 +113,7 @@
{ "name": "gtk-linux-bot-16", "platform": "gtk" },
{ "name": "gtk-linux-bot-17", "platform": "gtk" },
{ "name": "gtk-linux-bot-18", "platform": "gtk" },
+{ "name": "gtk-linux-bot-19", "platform": "gtk" },
{ "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
{ "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
@@ -352,7 +353,8 @@
"name": "GTK-Linux-64-bit-Release-Build", "factory": "BuildAndGenerateJSCBundleFactory", "builddir": "gtk-linux-64-release",
"platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
"triggers": ["gtk-linux-64-release-tests", "gtk-linux-64-release-tests-js", "gtk-linux-64-release-tests-webdriver",
- "gtk-linux-64-release-wayland-tests", "gtk-linux-64-release-perf-tests", "gtk-linux-64-release-gtk4-tests"],
+ "gtk-linux-64-release-wayland-tests", "gtk-linux-64-release-perf-tests", "gtk-linux-64-release-gtk4-tests",
+ "gtk-linux-64-release-skip-failing-tests"],
"workernames": ["gtk-linux-bot-2"]
},
{
@@ -433,6 +435,12 @@
"workernames": ["gtk-linux-bot-18"]
},
{
+ "name": "GTK-Linux-64-bit-Release-Skip-Failing-Tests", "factory": "TestAllButJSCFactory", "builddir": "gtk-linux-64-release-skip-failing-tests",
+ "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+ "additionalArguments": ["--skip-failing-tests"],
+ "workernames": ["gtk-linux-bot-19"]
+},
+{
"name": "WinCairo-64-bit-WKL-Release-Build", "factory": "BuildFactory", "builddir": "wincairo-wkl-release",
"platform": "wincairo", "configuration": "release", "architectures": ["x86_64"],
"triggers": ["wincairo-wkl-release-tests", "wincairo-jsc-release-tests"],
@@ -694,6 +702,9 @@
{ "type": "Triggerable", "name": "gtk-linux-64-release-wayland-tests",
"builderNames": ["GTK-Linux-64-bit-Release-Wayland-Tests"]
},
+{ "type": "Triggerable", "name": "gtk-linux-64-release-skip-failing-tests",
+ "builderNames": ["GTK-Linux-64-bit-Release-Skip-Failing-Tests"]
+},
{ "type": "Triggerable", "name": "wincairo-wkl-release-tests",
"builderNames": ["WinCairo-64-bit-WKL-Release-Tests"]
},
Modified: trunk/Tools/ChangeLog (279843 => 279844)
--- trunk/Tools/ChangeLog 2021-07-12 18:52:58 UTC (rev 279843)
+++ trunk/Tools/ChangeLog 2021-07-12 18:56:16 UTC (rev 279844)
@@ -1,3 +1,19 @@
+2021-07-12 Carlos Alberto Lopez Perez
+
+[GTK] Add a new GTK layout tester bot to build.webkit.org that runs with --skip-failing-tests switch
+https://bugs.webkit.org/show_bug.cgi?id=227744
+
+Reviewed by Jonathan Bedard.
+
+On the EWS the layout tests run with this switch --skip-failing-tests
+which changes the order in which tests are run (those expected to fail
+are not scheduled). I think this may be causing different results on
+other tests (like unexpected failures or unexpected flakies).
+Having a bot in build.webkit.org running with this switch will help
+to detect and garden those cases.
+
+* CISupport/build-webkit-org/config.json:
+
2021-07-12 Jer Noble
[Cocoa] Incorrect deprecation declaration for
[webkit-changes] [279825] trunk
Title: [279825] trunk
Revision 279825
Author clo...@igalia.com
Date 2021-07-12 06:05:40 -0700 (Mon, 12 Jul 2021)
Log Message
Unreviewed, reverting r279778.
It caused unexpected text diffs on http/tests/storageAccess
tests
Reverted changeset:
"[GTK][WPE][libsoup] Test imported/w3c/web-platform-
tests/cookies/samesite/about-blank-toplevel.https.html crashes
since it was imported"
https://bugs.webkit.org/show_bug.cgi?id=227819
https://commits.webkit.org/r279778
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/glib/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
Removed Paths
trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/samesite/
Diff
Modified: trunk/LayoutTests/ChangeLog (279824 => 279825)
--- trunk/LayoutTests/ChangeLog 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/LayoutTests/ChangeLog 2021-07-12 13:05:40 UTC (rev 279825)
@@ -1,3 +1,18 @@
+2021-07-12 Carlos Alberto Lopez Perez
+
+Unreviewed, reverting r279778.
+
+It caused unexpected text diffs on http/tests/storageAccess
+tests
+
+Reverted changeset:
+
+"[GTK][WPE][libsoup] Test imported/w3c/web-platform-
+tests/cookies/samesite/about-blank-toplevel.https.html crashes
+since it was imported"
+https://bugs.webkit.org/show_bug.cgi?id=227819
+https://commits.webkit.org/r279778
+
2021-07-12 Rob Buis
Resync web-platform-tests/css/css-overflow from upstream
Modified: trunk/LayoutTests/platform/glib/TestExpectations (279824 => 279825)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-07-12 13:05:40 UTC (rev 279825)
@@ -270,8 +270,6 @@
imported/w3c/web-platform-tests/fetch/http-cache/basic-auth-cache-test.html [ Pass ]
-imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html [ Pass ]
-
#
# End of PASSING tests.
#
@@ -2324,6 +2322,8 @@
webkit.org/b/227665 fast/css/parsing-relative-color-syntax.html [ Failure ]
+webkit.org/b/227819 imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html [ Crash ]
+
webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.document-cookie.html [ Failure ]
webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.document-cookie.https.html [ Failure ]
webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.header.html [ Failure ]
Modified: trunk/Source/WebCore/ChangeLog (279824 => 279825)
--- trunk/Source/WebCore/ChangeLog 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/Source/WebCore/ChangeLog 2021-07-12 13:05:40 UTC (rev 279825)
@@ -1,3 +1,18 @@
+2021-07-12 Carlos Alberto Lopez Perez
+
+Unreviewed, reverting r279778.
+
+It caused unexpected text diffs on http/tests/storageAccess
+tests
+
+Reverted changeset:
+
+"[GTK][WPE][libsoup] Test imported/w3c/web-platform-
+tests/cookies/samesite/about-blank-toplevel.https.html crashes
+since it was imported"
+https://bugs.webkit.org/show_bug.cgi?id=227819
+https://commits.webkit.org/r279778
+
2021-07-12 Alexander Mikhaylenko
[GTK][WPE] Match Adwaita scrollbars more closely
Modified: trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp (279824 => 279825)
--- trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2021-07-12 13:02:12 UTC (rev 279824)
+++ trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp 2021-07-12 13:05:40 UTC (rev 279825)
@@ -552,9 +552,6 @@
return false;
auto cookieURI = sameSiteInfo.isSameSite ? urlToSoupURI(url) : nullptr;
-if (!cookieURI)
-return false;
-
GUniquePtr cookies(soup_cookie_jar_get_cookie_list_with_same_site_info(cookieStorage(), uri.get(), firstPartyURI.get(), cookieURI.get(), TRUE, sameSiteInfo.isSafeHTTPMethod, sameSiteInfo.isTopSite));
#else
GUniquePtr cookies(soup_cookie_jar_get_cookie_list(cookieStorage(), uri.get(), TRUE));
@@ -595,9 +592,6 @@
return { { }, false };
auto cookieURI = sameSiteInfo.isSameSite ? urlToSoupURI(url) : nullptr;
-if (!cookieURI)
-return { { }, false };
-
GSList* cookies = soup_cookie_jar_get_cookie_list_with_same_site_info(session.cookieStorage(), uri.get(), firstPartyURI.get(), cookieURI.get(), forHTTPHeader, sameSiteInfo.isSafeHTTPMethod, sameSiteInfo.isTopSite);
#else
GSList* cookies = soup_cookie_jar_get_cookie_list(session.cookieStorage(), uri.get(), forHTTPHeader);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [279778] trunk
Title: [279778] trunk Revision 279778 Author clo...@igalia.com Date 2021-07-09 04:18:29 -0700 (Fri, 09 Jul 2021) Log Message [GTK][WPE][libsoup] Test imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html crashes since it was imported https://bugs.webkit.org/show_bug.cgi?id=227819 Reviewed by Carlos Garcia Campos. Source/WebCore: Add missings null-checks to avoid calling soup_cookie_jar_get_cookie_list_with_same_site_info() with a null pointer in site_for_cookies argument. Covered by existing tests. * platform/network/soup/NetworkStorageSessionSoup.cpp: (WebCore::NetworkStorageSession::getRawCookies const): (WebCore::cookiesForSession): LayoutTests: Mark the test as passing (is marked as flaky on the general expectations) and add expectation for passing test. * platform/glib/TestExpectations: * platform/glib/imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp Added Paths trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/samesite/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (279777 => 279778) --- trunk/LayoutTests/ChangeLog 2021-07-09 08:31:05 UTC (rev 279777) +++ trunk/LayoutTests/ChangeLog 2021-07-09 11:18:29 UTC (rev 279778) @@ -1,3 +1,15 @@ +2021-07-09 Carlos Alberto Lopez Perez + +[GTK][WPE][libsoup] Test imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html crashes since it was imported +https://bugs.webkit.org/show_bug.cgi?id=227819 + +Reviewed by Carlos Garcia Campos. + +Mark the test as passing (is marked as flaky on the general expectations) and add expectation for passing test. + +* platform/glib/TestExpectations: +* platform/glib/imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt: Added. + 2021-07-09 Arcady Goldmints-Orlov [GLIB] Unreviewed test gardening, update baselines after r279723 Modified: trunk/LayoutTests/platform/glib/TestExpectations (279777 => 279778) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-07-09 08:31:05 UTC (rev 279777) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-07-09 11:18:29 UTC (rev 279778) @@ -270,6 +270,8 @@ imported/w3c/web-platform-tests/fetch/http-cache/basic-auth-cache-test.html [ Pass ] +imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html [ Pass ] + # # End of PASSING tests. # @@ -2322,8 +2324,6 @@ webkit.org/b/227665 fast/css/parsing-relative-color-syntax.html [ Failure ] -webkit.org/b/227819 imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html [ Crash ] - webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.document-cookie.html [ Failure ] webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.document-cookie.https.html [ Failure ] webkit.org/b/227823 imported/w3c/web-platform-tests/cookies/prefix/__host.header.html [ Failure ] Added: trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt (0 => 279778) --- trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt (rev 0) +++ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https-expected.txt 2021-07-09 11:18:29 UTC (rev 279778) @@ -0,0 +1,3 @@ + +PASS SameSite cookies with top-level about:blank window + Modified: trunk/Source/WebCore/ChangeLog (279777 => 279778) --- trunk/Source/WebCore/ChangeLog 2021-07-09 08:31:05 UTC (rev 279777) +++ trunk/Source/WebCore/ChangeLog 2021-07-09 11:18:29 UTC (rev 279778) @@ -1,3 +1,19 @@ +2021-07-09 Carlos Alberto Lopez Perez + +[GTK][WPE][libsoup] Test imported/w3c/web-platform-tests/cookies/samesite/about-blank-toplevel.https.html crashes since it was imported +https://bugs.webkit.org/show_bug.cgi?id=227819 + +Reviewed by Carlos Garcia Campos. + +Add missings null-checks to avoid calling soup_cookie_jar_get_cookie_list_with_same_site_info() +with a null pointer in site_for_cookies argument. + +Covered by existing tests. + +* platform/network/soup/NetworkStorageSessionSoup.cpp: +(WebCore::NetworkStorageSession::getRawCookies const): +(WebCore::cookiesForSession): + 2021-07-08 Kate Cheney Unreviewed iOS build fix
[webkit-changes] [279775] trunk/Tools
Title: [279775] trunk/Tools Revision 279775 Author clo...@igalia.com Date 2021-07-09 01:10:19 -0700 (Fri, 09 Jul 2021) Log Message [webkitcorepy] run-webkit-tests may hang with python2 after r271683 https://bugs.webkit.org/show_bug.cgi?id=227715 Reviewed by Philippe Normand. When an exception is raised from a worker if the workers are terminated via a SIGKILL signal that later causes the task-queue to hang at close(). The issue is not reproducible with python3. So keep the same behaviour for python3, and for python2 just use terminate() to stop the workers. * Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py: (TaskPool.__exit__): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py Diff Modified: trunk/Tools/ChangeLog (279774 => 279775) --- trunk/Tools/ChangeLog 2021-07-09 07:14:30 UTC (rev 279774) +++ trunk/Tools/ChangeLog 2021-07-09 08:10:19 UTC (rev 279775) @@ -1,3 +1,18 @@ +2021-07-09 Carlos Alberto Lopez Perez + +[webkitcorepy] run-webkit-tests may hang with python2 after r271683 +https://bugs.webkit.org/show_bug.cgi?id=227715 + +Reviewed by Philippe Normand. + +When an exception is raised from a worker if the workers are terminated +via a SIGKILL signal that later causes the task-queue to hang at close(). +The issue is not reproducible with python3. So keep the same behaviour for +python3, and for python2 just use terminate() to stop the workers. + +* Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py: +(TaskPool.__exit__): + 2021-07-08 Yijia Huang Add Yijia Huang as a committer Modified: trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py (279774 => 279775) --- trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py 2021-07-09 07:14:30 UTC (rev 279774) +++ trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py 2021-07-09 08:10:19 UTC (rev 279775) @@ -458,7 +458,8 @@ if sys.version_info >= (3, 7): worker.kill() -elif hasattr(signal, 'SIGKILL'): +# With python2 killing directly the workers causes the queue to hang on close() +elif hasattr(signal, 'SIGKILL') and sys.version_info.major > 2: try: os.kill(worker.pid, signal.SIGKILL) except OSError as e: ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279766] trunk/LayoutTests
Title: [279766] trunk/LayoutTests Revision 279766 Author clo...@igalia.com Date 2021-07-08 17:09:23 -0700 (Thu, 08 Jul 2021) Log Message [GTK][WPE] Gardening of tests after r279585 and 279705 Re-baseline the tests that have consistent text output, mark the ones that are flaky as failing and report a crash. Unreviewed gardening. * platform/glib/TestExpectations: * platform/glib/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/attributes/invalid-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/attributes/max-age-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/attributes/path-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/attributes/secure-non-secure-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/encoding/charset-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/name/name-ctl-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/ordering/ordering.sub-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/path/match-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/cookies/value/value-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations Added Paths trunk/LayoutTests/platform/glib/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/attributes/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/attributes/invalid-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/attributes/max-age-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/attributes/path-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/attributes/secure-non-secure-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/encoding/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/encoding/charset-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/name/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/name/name-ctl-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/ordering/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/ordering/ordering.sub-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/path/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/path/match-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/value/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/cookies/value/value-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (279765 => 279766) --- trunk/LayoutTests/ChangeLog 2021-07-09 00:06:11 UTC (rev 279765) +++ trunk/LayoutTests/ChangeLog 2021-07-09 00:09:23 UTC (rev 279766) @@ -1,3 +1,25 @@ +2021-07-08 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of tests after r279585 and 279705 + +Re-baseline the tests that have consistent text output, mark the +ones that are flaky as failing and report a crash. + +Unreviewed gardening. + +* platform/glib/TestExpectations: +* platform/glib/http/tests/websocket/tests/hybi/multiple-set-cookies-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/attributes/invalid-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/attributes/max-age-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/attributes/path-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/attributes/secure-non-secure-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/encoding/charset-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/name/name-ctl-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/ordering/ordering.sub-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/path/match-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/value/value-ctl-expected.txt: Added. +* platform/glib/imported/w3c/web-platform-tests/cookies/value/value-expected.txt: Added. + 2021-07-08 Ayumi Kojima [Mac]
[webkit-changes] [279100] trunk/LayoutTests
Title: [279100] trunk/LayoutTests Revision 279100 Author clo...@igalia.com Date 2021-06-21 18:55:02 -0700 (Mon, 21 Jun 2021) Log Message [GLIB] Gardening of test failures. Unreviewed gardening Remove tests that pass after r279065. * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (279099 => 279100) --- trunk/LayoutTests/ChangeLog 2021-06-22 01:24:46 UTC (rev 279099) +++ trunk/LayoutTests/ChangeLog 2021-06-22 01:55:02 UTC (rev 279100) @@ -1,3 +1,13 @@ +2021-06-21 Carlos Alberto Lopez Perez + +[GLIB] Gardening of test failures. + +Unreviewed gardening + +Remove tests that pass after r279065. + +* platform/glib/TestExpectations: + 2021-06-21 Wenson Hsieh [macOS] [WebKitLegacy] Non-actionable "Look Up" action appears when right clicking images Modified: trunk/LayoutTests/platform/glib/TestExpectations (279099 => 279100) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-06-22 01:24:46 UTC (rev 279099) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-06-22 01:55:02 UTC (rev 279100) @@ -2325,30 +2325,6 @@ webkit.org/b/227232 imported/w3c/web-platform-tests/css/css-contain/contain-size-replaced-003a.html [ ImageOnlyFailure Pass ] webkit.org/b/227232 imported/w3c/web-platform-tests/css/css-contain/contain-size-replaced-003b.html [ ImageOnlyFailure Pass ] -webkit.org/b/227233 http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html [ Failure ] -webkit.org/b/227233 imported/w3c/web-platform-tests/webrtc-priority/RTCPeerConnection-ondatachannel.html [ Failure ] -webkit.org/b/227233 inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Timeout ] -webkit.org/b/227233 webrtc/calling-peerconnection-once-closed.html [ Failure ] -webkit.org/b/227233 webrtc/candidate-stats.html [ Failure ] -webkit.org/b/227233 webrtc/closing-peerconnection.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/basic.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/binary.html [ Failure ] -webkit.org/b/227233 webrtc/datachannel/bufferedAmount-afterClose.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/bufferedAmountLowThreshold-default.html [ Failure ] -webkit.org/b/227233 webrtc/datachannel/bufferedAmountLowThreshold.html [ Failure ] -webkit.org/b/227233 webrtc/datachannel/datachannel-gc.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/datachannel-page-cache.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/datachannel-page-cache-send.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/datachannel-stats.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/dtls10.html [ Failure ] -webkit.org/b/227233 webrtc/datachannel/filter-ice-candidate.html [ Timeout ] -webkit.org/b/227233 webrtc/datachannel/gather-candidates-networkprocess-crash.html [ Failure ] -webkit.org/b/227233 webrtc/datachannel/getStats-no-prflx-remote-candidate.html [ Failure ] -webkit.org/b/227233 webrtc/datachannel/multi-channel.html [ Failure ] -webkit.org/b/227233 webrtc/filtering-ice-candidate-after-reload.html [ Timeout ] -webkit.org/b/227233 webrtc/legacy-api.html [ Failure ] -webkit.org/b/227233 webrtc/no-port-zero-in-upd-candidates.html [ Failure ] - # End: Common failures between GTK and WPE. # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [279080] trunk/LayoutTests
Title: [279080] trunk/LayoutTests Revision 279080 Author clo...@igalia.com Date 2021-06-21 13:53:33 -0700 (Mon, 21 Jun 2021) Log Message [GTK][WPE] Gardening of test failures Unreviewed gardening. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (279079 => 279080) --- trunk/LayoutTests/ChangeLog 2021-06-21 20:47:29 UTC (rev 279079) +++ trunk/LayoutTests/ChangeLog 2021-06-21 20:53:33 UTC (rev 279080) @@ -1,3 +1,12 @@ +2021-06-21 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of test failures + +Unreviewed gardening. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: + 2021-06-21 Rob Buis CSSOM test for serializing font-variant fails Modified: trunk/LayoutTests/platform/glib/TestExpectations (279079 => 279080) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-06-21 20:47:29 UTC (rev 279079) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-06-21 20:53:33 UTC (rev 279080) @@ -2322,6 +2322,33 @@ # Require expect file for dumped render tree. webkit.org/b/227189 fast/forms/checkbox-and-pseudo.html [ Skip ] +webkit.org/b/227232 imported/w3c/web-platform-tests/css/css-contain/contain-size-replaced-003a.html [ ImageOnlyFailure Pass ] +webkit.org/b/227232 imported/w3c/web-platform-tests/css/css-contain/contain-size-replaced-003b.html [ ImageOnlyFailure Pass ] + +webkit.org/b/227233 http/wpt/webrtc/third-party-frame-ice-candidate-filtering.html [ Failure ] +webkit.org/b/227233 imported/w3c/web-platform-tests/webrtc-priority/RTCPeerConnection-ondatachannel.html [ Failure ] +webkit.org/b/227233 inspector/page/overrideSetting-ICECandidateFilteringEnabled.html [ Timeout ] +webkit.org/b/227233 webrtc/calling-peerconnection-once-closed.html [ Failure ] +webkit.org/b/227233 webrtc/candidate-stats.html [ Failure ] +webkit.org/b/227233 webrtc/closing-peerconnection.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/basic.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/binary.html [ Failure ] +webkit.org/b/227233 webrtc/datachannel/bufferedAmount-afterClose.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/bufferedAmountLowThreshold-default.html [ Failure ] +webkit.org/b/227233 webrtc/datachannel/bufferedAmountLowThreshold.html [ Failure ] +webkit.org/b/227233 webrtc/datachannel/datachannel-gc.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/datachannel-page-cache.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/datachannel-page-cache-send.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/datachannel-stats.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/dtls10.html [ Failure ] +webkit.org/b/227233 webrtc/datachannel/filter-ice-candidate.html [ Timeout ] +webkit.org/b/227233 webrtc/datachannel/gather-candidates-networkprocess-crash.html [ Failure ] +webkit.org/b/227233 webrtc/datachannel/getStats-no-prflx-remote-candidate.html [ Failure ] +webkit.org/b/227233 webrtc/datachannel/multi-channel.html [ Failure ] +webkit.org/b/227233 webrtc/filtering-ice-candidate-after-reload.html [ Timeout ] +webkit.org/b/227233 webrtc/legacy-api.html [ Failure ] +webkit.org/b/227233 webrtc/no-port-zero-in-upd-candidates.html [ Failure ] + # End: Common failures between GTK and WPE. # Modified: trunk/LayoutTests/platform/gtk/TestExpectations (279079 => 279080) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-06-21 20:47:29 UTC (rev 279079) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-06-21 20:53:33 UTC (rev 279080) @@ -1966,6 +1966,22 @@ webkit.org/b/224076 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-zero-fontsize-002.html [ ImageOnlyFailure ] +webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/armenian/css3-counter-styles-006.html [ ImageOnlyFailure ] +webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/armenian/css3-counter-styles-007.html [ ImageOnlyFailure ] +webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/armenian/css3-counter-styles-008.html [ ImageOnlyFailure ] +webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/armenian/css3-counter-styles-009.html [ ImageOnlyFailure ] +webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/georgian/css3-counter-styles-010.html [ ImageOnlyFailure ] +webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/georgian/css3-counter-styles-011.html [ ImageOnlyFailure ] +webkit.org/b/227231 imported/w3c/web-platform-tests/css/css-counter-styles/georgian/css3-counter-styles-012.html [ ImageOnlyFailure ] +webkit.org/b/227231
[webkit-changes] [279036] trunk/Source/WebCore
Title: [279036] trunk/Source/WebCore
Revision 279036
Author clo...@igalia.com
Date 2021-06-18 06:37:53 -0700 (Fri, 18 Jun 2021)
Log Message
[LFC][WPE] Build failure with GCC 8.x
https://bugs.webkit.org/show_bug.cgi?id=227166
Reviewed by Alan Bujtas.
The build fails with the error: converting to 'std::in_place_t' from initializer list
would use explicit constructor 'constexpr std::in_place_t::in_place_t()'
No new tests, is a build fix.
* layout/integration/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::prepareLayoutState):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (279035 => 279036)
--- trunk/Source/WebCore/ChangeLog 2021-06-18 10:58:18 UTC (rev 279035)
+++ trunk/Source/WebCore/ChangeLog 2021-06-18 13:37:53 UTC (rev 279036)
@@ -1,3 +1,18 @@
+2021-06-18 Carlos Alberto Lopez Perez
+
+[LFC][WPE] Build failure with GCC 8.x
+https://bugs.webkit.org/show_bug.cgi?id=227166
+
+Reviewed by Alan Bujtas.
+
+The build fails with the error: converting to 'std::in_place_t' from initializer list
+would use explicit constructor 'constexpr std::in_place_t::in_place_t()'
+
+No new tests, is a build fix.
+
+* layout/integration/LayoutIntegrationLineLayout.cpp:
+(WebCore::LayoutIntegration::LineLayout::prepareLayoutState):
+
2021-06-18 Philippe Normand
[GStreamer] imported/w3c/web-platform-tests/mediacapture-streams/MediaStream-MediaElement-srcObject.https.html is failing since r273645
Modified: trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp (279035 => 279036)
--- trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2021-06-18 10:58:18 UTC (rev 279035)
+++ trunk/Source/WebCore/layout/integration/LayoutIntegrationLineLayout.cpp 2021-06-18 13:37:53 UTC (rev 279036)
@@ -250,7 +250,7 @@
auto& rootGeometry = m_layoutState.ensureGeometryForBox(rootLayoutBox());
rootGeometry.setContentBoxWidth(flow().contentSize().width());
-rootGeometry.setPadding({ { } });
+rootGeometry.setPadding({ });
rootGeometry.setBorder({ });
rootGeometry.setHorizontalMargin({ });
rootGeometry.setVerticalMargin({ });
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [278753] trunk
Title: [278753] trunk
Revision 278753
Author clo...@igalia.com
Date 2021-06-10 21:52:23 -0700 (Thu, 10 Jun 2021)
Log Message
[CMake][GTK][WPE] Improve error message when libsoup3 is not found
https://bugs.webkit.org/show_bug.cgi?id=226905
Reviewed by Adrian Perez de Castro.
When libsoup 3 is not found be more clear about the problem and
offer possible workaround to continue the build.
* Source/cmake/FindLibSoup.cmake:
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
Modified Paths
trunk/ChangeLog
trunk/Source/cmake/FindLibSoup.cmake
trunk/Source/cmake/OptionsGTK.cmake
trunk/Source/cmake/OptionsWPE.cmake
Diff
Modified: trunk/ChangeLog (278752 => 278753)
--- trunk/ChangeLog 2021-06-11 03:37:18 UTC (rev 278752)
+++ trunk/ChangeLog 2021-06-11 04:52:23 UTC (rev 278753)
@@ -1,3 +1,17 @@
+2021-06-10 Carlos Alberto Lopez Perez
+
+[CMake][GTK][WPE] Improve error message when libsoup3 is not found
+https://bugs.webkit.org/show_bug.cgi?id=226905
+
+Reviewed by Adrian Perez de Castro.
+
+When libsoup 3 is not found be more clear about the problem and
+offer possible workaround to continue the build.
+
+* Source/cmake/FindLibSoup.cmake:
+* Source/cmake/OptionsGTK.cmake:
+* Source/cmake/OptionsWPE.cmake:
+
2021-06-10 Philippe Normand
[WPE] Enable Cog for developer builds
Modified: trunk/Source/cmake/FindLibSoup.cmake (278752 => 278753)
--- trunk/Source/cmake/FindLibSoup.cmake 2021-06-11 03:37:18 UTC (rev 278752)
+++ trunk/Source/cmake/FindLibSoup.cmake 2021-06-11 04:52:23 UTC (rev 278753)
@@ -42,7 +42,7 @@
# .pc file, so we need to rely on PC_LIBSOUP_VERSION and REQUIRE the .pc file
# to be found.
find_package(PkgConfig QUIET)
-pkg_check_modules(PC_LIBSOUP REQUIRED QUIET "libsoup-${LIBSOUP_API_VERSION}")
+pkg_check_modules(PC_LIBSOUP QUIET "libsoup-${LIBSOUP_API_VERSION}")
find_path(LIBSOUP_INCLUDE_DIRS
NAMES libsoup/soup.h
Modified: trunk/Source/cmake/OptionsGTK.cmake (278752 => 278753)
--- trunk/Source/cmake/OptionsGTK.cmake 2021-06-11 03:37:18 UTC (rev 278752)
+++ trunk/Source/cmake/OptionsGTK.cmake 2021-06-11 04:52:23 UTC (rev 278753)
@@ -213,8 +213,16 @@
set(SOUP_API_VERSION 3.0)
set(ENABLE_SERVER_PRECONNECT ON)
endif ()
-find_package(LibSoup ${SOUP_MINIMUM_VERSION} REQUIRED)
+find_package(LibSoup ${SOUP_MINIMUM_VERSION})
+if (NOT LibSoup_FOUND)
+if (USE_SOUP2)
+message(FATAL_ERROR "libsoup is required.")
+else ()
+message(FATAL_ERROR "libsoup 3 is required. Enable USE_SOUP2 to use libsoup 2 (disables HTTP/2)")
+endif ()
+endif ()
+
if (USE_GTK4)
set(WEBKITGTK_API_VERSION 5.0)
set(WEBKITGTK_API_DOC_VERSION 5.0)
Modified: trunk/Source/cmake/OptionsWPE.cmake (278752 => 278753)
--- trunk/Source/cmake/OptionsWPE.cmake 2021-06-11 03:37:18 UTC (rev 278752)
+++ trunk/Source/cmake/OptionsWPE.cmake 2021-06-11 04:52:23 UTC (rev 278753)
@@ -132,8 +132,16 @@
set(WPE_API_DOC_VERSION 1.0)
set(ENABLE_SERVER_PRECONNECT ON)
endif ()
-find_package(LibSoup ${SOUP_MINIMUM_VERSION} REQUIRED)
+find_package(LibSoup ${SOUP_MINIMUM_VERSION})
+if (NOT LibSoup_FOUND)
+if (USE_SOUP2)
+message(FATAL_ERROR "libsoup is required.")
+else ()
+message(FATAL_ERROR "libsoup 3 is required. Enable USE_SOUP2 to use libsoup 2 (disables HTTP/2)")
+endif ()
+endif ()
+
if (WPE_API_VERSION VERSION_EQUAL "1.0")
CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(WEBKIT 18 0 15)
else ()
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [276868] trunk/Tools
Title: [276868] trunk/Tools
Revision 276868
Author clo...@igalia.com
Date 2021-04-30 18:20:56 -0700 (Fri, 30 Apr 2021)
Log Message
[tools] Make run-buildbot-test compatible with buildbot 2.10.5
https://bugs.webkit.org/show_bug.cgi?id=222540
Reviewed by Aakash Jain.
This renames the previous tool run-buildbot-test to start-buildbot-server-virtualenv
and it makes several changes to it:
- Use python3 and refactor the code.
- Make it also work with the EWS config (previously it only worked for the build.webkit.org config).
- Use newer buildbot configs.
- Instead of hardcoding values try to automatically detect the values from the config dir.
- Instead of starting Nth workers by default start only one round-robin worker (local-worker).
It also modifies the configuration of the EWS server to add a force scheduler in order
to allow to manually trigger builds (only in test mode).
* CISupport/build-webkit-org/run-buildbot-test.py: Removed.
* CISupport/ews-build/loadConfig.py:
(loadBuilderConfig):
* CISupport/ews-build/steps.py:
(ApplyPatch.start):
* CISupport/start-local-buildbot-server: Added.
(check_tcp_port_open):
(create_tempdir):
(print_if_error_stdout_stderr):
(cmd_exists):
(BuildbotTestRunner):
(BuildbotTestRunner.__init__):
(BuildbotTestRunner._get_config_tcp_ports):
(BuildbotTestRunner.start):
(BuildbotTestRunner._wait_for_server_ready):
(BuildbotTestRunner._create_mock_worker_passwords_dict):
(BuildbotTestRunner._setup_server_workdir):
(BuildbotTestRunner._setup_virtualenv):
(BuildbotTestRunner._upgrade_db_needed):
(BuildbotTestRunner._start_server):
(BuildbotTestRunner._get_list_workers):
(BuildbotTestRunner._start_worker):
(BuildbotTestRunner._clean):
Modified Paths
trunk/Tools/CISupport/ews-build/loadConfig.py
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/ChangeLog
Added Paths
trunk/Tools/CISupport/start-local-buildbot-server
Removed Paths
trunk/Tools/CISupport/build-webkit-org/run-buildbot-test.py
Diff
Deleted: trunk/Tools/CISupport/build-webkit-org/run-buildbot-test.py (276867 => 276868)
--- trunk/Tools/CISupport/build-webkit-org/run-buildbot-test.py 2021-05-01 01:19:18 UTC (rev 276867)
+++ trunk/Tools/CISupport/build-webkit-org/run-buildbot-test.py 2021-05-01 01:20:56 UTC (rev 276868)
@@ -1,347 +0,0 @@
-#!/usr/bin/env python
-#
-# Copyright (C) 2017 Igalia S.L.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions are
-# met:
-#
-# * Redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer.
-#
-# * Redistributions in binary form must reproduce the above
-# copyright notice, this list of conditions and the following disclaimer
-# in the documentation and/or other materials provided with the
-# distribution.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
-#
-import sys
-import signal
-import os
-import argparse
-import subprocess
-import tempfile
-import shutil
-import socket
-import json
-import traceback
-import multiprocessing
-from time import sleep
-
-test_buildbot_master_tac = """
-import os
-from twisted.application import service
-try:
-from buildbot.master.bot import BuildMaster
-except:
-from buildbot.master import BuildMaster
-
-basedir = os.path.dirname(os.path.realpath(__file__))
-configfile = r'master.cfg'
-
-application = service.Application('buildmaster')
-BuildMaster(basedir, configfile).setServiceParent(application)
-"""
-
-worker_buildbot_master_tac = """
-import os
-from twisted.application import service
-from buildslave.bot import BuildSlave
-
-basedir = os.path.dirname(os.path.realpath(__file__))
-buildmaster_host = 'localhost'
-port = 17000
-slavename = '{}'
-passwd = '1234'
-keepalive = 600
-usepty = 1
-
-application = service.Application('buildslave')
-BuildSlave(buildmaster_host, port, slavename, passwd, basedir, keepalive, usepty).setServiceParent(application)
-"""
-
-
-def check_tcp_port_open(address, port):
-s = socket.socket()
-try:
-s.connect((address, port))
-return True
-except:
-return False
-
-
-def upgrade_db_needed(log):
-try:
-with open(log) as f:
-for l in f:
-
[webkit-changes] [275423] trunk/LayoutTests
Title: [275423] trunk/LayoutTests Revision 275423 Author clo...@igalia.com Date 2021-04-02 09:48:51 -0700 (Fri, 02 Apr 2021) Log Message [GTK][WPE] Gardening of flaky tests Unreviewed gardening. Update list of flaky tests. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (275422 => 275423) --- trunk/LayoutTests/ChangeLog 2021-04-02 16:23:39 UTC (rev 275422) +++ trunk/LayoutTests/ChangeLog 2021-04-02 16:48:51 UTC (rev 275423) @@ -1,3 +1,14 @@ +2021-04-02 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of flaky tests + +Unreviewed gardening. + +Update list of flaky tests. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: + 2021-04-02 Chris Lord Implement text rendering on OffscreenCanvas in a Worker Modified: trunk/LayoutTests/platform/glib/TestExpectations (275422 => 275423) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-04-02 16:23:39 UTC (rev 275422) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-04-02 16:48:51 UTC (rev 275423) @@ -580,14 +580,16 @@ # HTTP-related bugs # -webkit.org/b/214797 http/tests/images/jpeg-partial-load.html [ ImageOnlyFailure Timeout Pass ] +webkit.org/b/214797 http/tests/images/jpeg-partial-load.html [ ImageOnlyFailure Timeout Crash Pass ] -webkit.org/b/214798 http/tests/images/image-supports-video.html [ Missing Timeout Pass ] +webkit.org/b/214798 http/tests/images/image-supports-video.html [ Missing Timeout Crash Pass ] webkit.org/b/207723 http/tests/contentextensions/hide-on-ping-with-ping-that-redirects.html [ Pass Failure ] webkit.org/b/217961 webkit.org/b/223636 http/tests/images/mp4-partial-load.html [ Crash Timeout Pass ] +webkit.org/b/224109 http/tests/privateClickMeasurement/store-private-click-measurement-with-source-nonce.html [ Failure Pass ] + # # End of HTTP-related bugs # @@ -640,6 +642,8 @@ webkit.org/b/216871 imported/w3c/web-platform-tests/mathml/relations/css-styling/color-004.tentative.html [ ImageOnlyFailure ] +webkit.org/b/224111 imported/w3c/web-platform-tests/mathml/presentation-markup/operators/mo-form-dynamic-002.html [ ImageOnlyFailure Pass ] + # # End of MathML-related bugs # @@ -740,6 +744,7 @@ webkit.org/b/211837 perf/rel-list-remove.html [ Failure Pass ] webkit.org/b/213520 perf/htmlcollection-backwards-iteration.html [ Pass Failure ] webkit.org/b/218609 perf/clone-with-focus.html [ Failure Pass ] +webkit.org/b/224118 perf/array-reverse.html [ Failure Pass ] # # End of Perf-related bugs @@ -2039,7 +2044,7 @@ webkit.org/b/167108 imported/w3c/web-platform-tests/media-source/mediasource-seekable.html [ Failure ] webkit.org/b/197711 imported/w3c/web-platform-tests/media-source/mediasource-correct-frames.html [ Pass Timeout Failure ] webkit.org/b/203078 imported/w3c/web-platform-tests/media-source/mediasource-seek-beyond-duration.html [ Crash Failure ] -webkit.org/b/214349 [ Debug ] imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Failure Crash ] +webkit.org/b/214349 imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative.html [ Failure Crash ] webkit.org/b/220083 [ Debug ] media/media-source/media-source-unnecessary-seek-seeked.html [ Pass Crash ] webkit.org/b/220242 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-av-framesize.html [ Pass Failure ] @@ -2057,6 +2062,12 @@ webkit.org/b/224071 webgl/pending/conformance/context/context-attributes-alpha-depth-stencil-antialias.html [ Timeout ] +webkit.org/b/155196 security/contentSecurityPolicy/video-with-file-url-allowed-by-media-src-star.html [ ImageOnlyFailure Pass ] +webkit.org/b/224107 fast/images/animated-image-mp4-crash.html [ Crash Timeout Pass ] +webkit.org/b/224114 imported/w3c/web-platform-tests/wasm/webapi/instantiateStreaming-bad-imports.any.worker.html [ Failure Pass ] +webkit.org/b/224115 imported/w3c/web-platform-tests/service-workers/service-worker/unregister-immediately-before-installed.https.html [ Failure Pass ] +webkit.org/b/224116 imported/w3c/web-platform-tests/navigation-timing/test_performance_attributes.sub.html [ Failure Pass ] + # End: Common failures between GTK and WPE.
[webkit-changes] [275409] trunk/Source/ThirdParty/libwebrtc
Title: [275409] trunk/Source/ThirdParty/libwebrtc
Revision 275409
Author clo...@igalia.com
Date 2021-04-02 01:19:56 -0700 (Fri, 02 Apr 2021)
Log Message
[CMake][GStremer] Fails to build if OpenH264 is not present
https://bugs.webkit.org/show_bug.cgi?id=224089
Reviewed by Philippe Normand.
* CMakeLists.txt: Only try to link with OpenH264 when it is found.
Modified Paths
trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt
trunk/Source/ThirdParty/libwebrtc/ChangeLog
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt (275408 => 275409)
--- trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2021-04-02 08:11:44 UTC (rev 275408)
+++ trunk/Source/ThirdParty/libwebrtc/CMakeLists.txt 2021-04-02 08:19:56 UTC (rev 275409)
@@ -1530,7 +1530,9 @@
target_link_libraries(webrtc ${LIBOPUS_LIBRARY})
-target_link_libraries(webrtc ${Openh264_LIBRARY})
+if (Openh264_FOUND)
+target_link_libraries(webrtc ${Openh264_LIBRARY})
+endif ()
# libsrtp package compilation
set(libsrtp_SOURCES
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (275408 => 275409)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-04-02 08:11:44 UTC (rev 275408)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2021-04-02 08:19:56 UTC (rev 275409)
@@ -1,3 +1,12 @@
+2021-04-02 Carlos Alberto Lopez Perez
+
+[CMake][GStremer] Fails to build if OpenH264 is not present
+https://bugs.webkit.org/show_bug.cgi?id=224089
+
+Reviewed by Philippe Normand.
+
+* CMakeLists.txt: Only try to link with OpenH264 when it is found.
+
2021-03-31 Youenn Fablet
In case WebRTC VTB decoder returns a null frame, mark the decoder as failing
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [275376] trunk/LayoutTests
Title: [275376] trunk/LayoutTests Revision 275376 Author clo...@igalia.com Date 2021-04-01 13:43:00 -0700 (Thu, 01 Apr 2021) Log Message [GTK][WPE] Gardening of layout tests. Unreviewed gardening. Report and mark new failures. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (275375 => 275376) --- trunk/LayoutTests/ChangeLog 2021-04-01 20:05:48 UTC (rev 275375) +++ trunk/LayoutTests/ChangeLog 2021-04-01 20:43:00 UTC (rev 275376) @@ -1,3 +1,14 @@ +2021-04-01 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of layout tests. + +Unreviewed gardening. + +Report and mark new failures. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: + 2021-04-01 Chris Gambrell Flaky LayoutTests in http/tests/appcache Modified: trunk/LayoutTests/platform/glib/TestExpectations (275375 => 275376) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-04-01 20:05:48 UTC (rev 275375) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-04-01 20:43:00 UTC (rev 275376) @@ -2054,6 +2054,10 @@ webkit.org/b/223965 http/tests/contentextensions/hide-on-csp-report.py [ Crash ] webkit.org/b/223965 http/tests/contentextensions/main-resource-redirect-blocked.py [ Crash ] +webkit.org/b/224068 http/wpt/webrtc/webrtc-late-transform.html [ Failure ] + +webkit.org/b/224071 webgl/pending/conformance/context/context-attributes-alpha-depth-stencil-antialias.html [ Timeout ] + # End: Common failures between GTK and WPE. # Modified: trunk/LayoutTests/platform/gtk/TestExpectations (275375 => 275376) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-04-01 20:05:48 UTC (rev 275375) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-04-01 20:43:00 UTC (rev 275376) @@ -1647,7 +1647,7 @@ # EventSender::dumpFilenameBeingDragged not implemented. webkit.org/b/61826 fast/events/drag-image-filename.html [ Timeout ] -webkit.org/b/108925 http/tests/media/video-play-stall.html [ Failure ] +webkit.org/b/108925 http/tests/media/video-play-stall.html [ Failure Timeout ] webkit.org/b/147518 inspector/debugger/nested-inspectors.html [ Timeout ] @@ -1758,6 +1758,10 @@ webkit.org/b/219979 gamepad/gamepad-polling-access.html [ Timeout Pass ] +webkit.org/b/224073 media/non-existent-video-playback-interrupted.html [ Timeout Pass ] + +webkit.org/b/224074 webrtc/concurrentVideoPlayback.html [ Timeout Pass ] + # # End of Tests timing out # @@ -2457,6 +2461,18 @@ webkit.org/b/223981 inspector/canvas/recording-2d-saves.html [ Failure ] +webkit.org/b/224062 webgl/1.0.3/conformance/glsl/misc/shaders-with-missing-varyings.html [ Failure ] +webkit.org/b/224062 webgl/1.0.3/conformance/glsl/misc/shaders-with-varyings.html [ Failure ] +webkit.org/b/224062 webgl/1.0.3/conformance/rendering/gl-scissor-test.html [ Failure ] + +webkit.org/b/224064 media/video-orientation-canvas.html [ Failure ] + +webkit.org/b/222495 media/media-source/media-source-webm-vorbis-partial.html [ Failure ] + +webkit.org/b/224067 media/media-source/media-source-timestampoffset-trim.html [ Failure ] + +webkit.org/b/224076 imported/w3c/web-platform-tests/css/css-text/white-space/white-space-zero-fontsize-002.html [ ImageOnlyFailure ] + # # End of non-crashing, non-flaky tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [275274] trunk/LayoutTests
Title: [275274] trunk/LayoutTests Revision 275274 Author clo...@igalia.com Date 2021-03-31 01:41:16 -0700 (Wed, 31 Mar 2021) Log Message REGRESSION(r274244): [GTK][WPE] Two http/tests/security/contentSecurityPolicy tests crash https://bugs.webkit.org/show_bug.cgi?id=223978 Reviewed by Philippe Normand. Apache not longer sends a Content-Length header with the cgi/python version of this tests, but it used chunked transfer encoding. It seems this confuses libsoup causing a critical event. Add an empty \r\n at the end of the test to indicate that the server has finished sending the data. * http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py: * http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (275273 => 275274) --- trunk/LayoutTests/ChangeLog 2021-03-31 08:30:41 UTC (rev 275273) +++ trunk/LayoutTests/ChangeLog 2021-03-31 08:41:16 UTC (rev 275274) @@ -1,3 +1,19 @@ +2021-03-31 Carlos Alberto Lopez Perez + +REGRESSION(r274244): [GTK][WPE] Two http/tests/security/contentSecurityPolicy tests crash +https://bugs.webkit.org/show_bug.cgi?id=223978 + +Reviewed by Philippe Normand. + +Apache not longer sends a Content-Length header with the cgi/python version of this tests, +but it used chunked transfer encoding. +It seems this confuses libsoup causing a critical event. +Add an empty \r\n at the end of the test to indicate that the server has finished sending +the data. + +* http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py: +* http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py: + 2021-03-31 Alexey Shvayka Optimize constructors of ES6 collections Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py (275273 => 275274) --- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py 2021-03-31 08:30:41 UTC (rev 275273) +++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py 2021-03-31 08:41:16 UTC (rev 275274) @@ -24,4 +24,5 @@ ' '\n' '\n' +'\r\n' ) \ No newline at end of file Modified: trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py (275273 => 275274) --- trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py 2021-03-31 08:30:41 UTC (rev 275273) +++ trunk/LayoutTests/http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py 2021-03-31 08:41:16 UTC (rev 275274) @@ -24,4 +24,5 @@ ' '\n' '\n' +'\r\n' ) \ No newline at end of file Modified: trunk/LayoutTests/platform/glib/TestExpectations (275273 => 275274) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-03-31 08:30:41 UTC (rev 275273) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-03-31 08:41:16 UTC (rev 275274) @@ -2054,9 +2054,6 @@ webkit.org/b/223965 http/tests/contentextensions/hide-on-csp-report.py [ Crash ] webkit.org/b/223965 http/tests/contentextensions/main-resource-redirect-blocked.py [ Crash ] -webkit.org/b/223978 http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py [ Crash ] -webkit.org/b/223978 http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py [ Crash ] - # End: Common failures between GTK and WPE. # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [275263] trunk/LayoutTests
Title: [275263] trunk/LayoutTests Revision 275263 Author clo...@igalia.com Date 2021-03-30 20:30:41 -0700 (Tue, 30 Mar 2021) Log Message [GTK][WPE] Gardening of tests. Unreviewed gardening Update list of expected failures. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (275262 => 275263) --- trunk/LayoutTests/ChangeLog 2021-03-31 03:01:11 UTC (rev 275262) +++ trunk/LayoutTests/ChangeLog 2021-03-31 03:30:41 UTC (rev 275263) @@ -1,3 +1,14 @@ +2021-03-30 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of tests. + +Unreviewed gardening + +Update list of expected failures. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: + 2021-03-30 Jiewen Tan PCM: Introduce PrivateClickMeasurementNetworkLoader Modified: trunk/LayoutTests/platform/glib/TestExpectations (275262 => 275263) --- trunk/LayoutTests/platform/glib/TestExpectations 2021-03-31 03:01:11 UTC (rev 275262) +++ trunk/LayoutTests/platform/glib/TestExpectations 2021-03-31 03:30:41 UTC (rev 275263) @@ -1590,6 +1590,9 @@ # Depends on HTTP Live Streaming (non-supported in non-Apple ports). fast/url/data-url-mediatype.html [ Skip ] +# Needs Cocoa specific features +editing/pasteboard/copy-paste-data-detected-links.html [ Skip ] + # # End of UNSUPPORTED tests. # @@ -2045,7 +2048,15 @@ webkit.org/b/220242 imported/w3c/web-platform-tests/media-source/mediasource-config-change-mp4-v-framesize.html [ Pass Failure ] webkit.org/b/220242 imported/w3c/web-platform-tests/media-source/mediasource-config-change-webm-v-framesize.html [ Pass Failure ] +webkit.org/b/223965 http/tests/contentextensions/block-cookies-in-csp-report.py [ Crash ] +webkit.org/b/223965 http/tests/contentextensions/block-csp-report.py [ Crash ] +webkit.org/b/223965 http/tests/contentextensions/block-everything-unless-domain-redirect.py [ Crash ] +webkit.org/b/223965 http/tests/contentextensions/hide-on-csp-report.py [ Crash ] +webkit.org/b/223965 http/tests/contentextensions/main-resource-redirect-blocked.py [ Crash ] +webkit.org/b/223978 http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy.py [ Crash ] +webkit.org/b/223978 http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy.py [ Crash ] + # End: Common failures between GTK and WPE. # Modified: trunk/LayoutTests/platform/gtk/TestExpectations (275262 => 275263) --- trunk/LayoutTests/platform/gtk/TestExpectations 2021-03-31 03:01:11 UTC (rev 275262) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2021-03-31 03:30:41 UTC (rev 275263) @@ -1159,6 +1159,8 @@ webkit.org/b/212232 editing/async-clipboard/clipboard-read-while-pasting.html [ Crash ] +webkit.org/b/223960 editing/execCommand/insert-image-in-composed-list.html [ Crash ] + # # End of Crashing tests # @@ -2451,6 +2453,10 @@ webkit.org/b/222908 imported/w3c/web-platform-tests/web-animations/timing-model/animations/reverse-running-animation.html [ ImageOnlyFailure ] +webkit.org/b/223980 editing/deleting/insert-in-orphaned-selection-crash.html [ Failure ] + +webkit.org/b/223981 inspector/canvas/recording-2d-saves.html [ Failure ] + # # End of non-crashing, non-flaky tests failing # ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [274475] trunk/Tools
Title: [274475] trunk/Tools
Revision 274475
Author clo...@igalia.com
Date 2021-03-16 07:03:50 -0700 (Tue, 16 Mar 2021)
Log Message
[EWS] run-layout-tests-without-patch step should only retry the tests that failed on the previous steps.
https://bugs.webkit.org/show_bug.cgi?id=219500
Reviewed by Aakash Jain.
On the step to retry running the layout tests without patch only
run the subset of tests that failed on the previous steps.
But only do that if the previous steps didn't exceed the test
failure limit and the patch doesn't modify the TestExpectations files.
This helps to speed up the test times on the EWS when the patch
doesn't pass on the first try.
* CISupport/ews-build/steps.py:
(RunWebKitTests.start):
Modified Paths
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (274474 => 274475)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-03-16 13:52:20 UTC (rev 274474)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-03-16 14:03:50 UTC (rev 274475)
@@ -2028,6 +2028,12 @@
shell.Test.__init__(self, logEnviron=False, **kwargs)
self.incorrectLayoutLines = []
+def _get_patch(self):
+sourcestamp = self.build.getSourceStamp(self.getProperty('codebase', ''))
+if not sourcestamp or not sourcestamp.patch:
+return None
+return sourcestamp.patch[1]
+
def doStepIf(self, step):
return not ((self.getProperty('buildername', '').lower() == 'commit-queue') and
(self.getProperty('revert') or self.getProperty('passed_mac_wk2')))
@@ -2056,6 +2062,32 @@
if additionalArguments:
self.setCommand(self.command + additionalArguments)
+
+if self.name == 'run-layout-tests-without-patch':
+# In order to speed up testing, on the step that retries running the layout tests without patch
+# only run the subset of tests that failed on the previous steps.
+# But only do that if the previous steps didn't exceed the test failure limit and the patch doesn't
+# modify the TestExpectations files (there are corner cases where we can't guarantee the correctnes
+# of this optimization if the patch modifies the TestExpectations files, for example, if the patch
+# removes skipped tests but those tests still fail).
+first_results_did_exceed_test_failure_limit = self.getProperty('first_results_exceed_failure_limit', False)
+second_results_did_exceed_test_failure_limit = self.getProperty('second_results_exceed_failure_limit', False)
+if not first_results_did_exceed_test_failure_limit and not second_results_did_exceed_test_failure_limit:
+patch_modifies_expectation_files = False
+patch = self._get_patch()
+if patch:
+for line in patch.splitlines():
+line = line.strip()
+# patch is stored by buildbot as bytes: https://github.com/buildbot/buildbot/issues/5812#issuecomment-790175979
+if (b'LayoutTests/' in line and b'TestExpectations' in line) and (line.startswith(b'---') or line.startswith(b'+++')):
+patch_modifies_expectation_files = True
+break
+if not patch_modifies_expectation_files:
+first_results_failing_tests = set(self.getProperty('first_run_failures', set()))
+second_results_failing_tests = set(self.getProperty('second_run_failures', set()))
+list_retry_tests = sorted(first_results_failing_tests.union(second_results_failing_tests))
+self.setCommand(self.command + list_retry_tests)
+
return shell.Test.start(self)
# FIXME: This will break if run-webkit-tests changes its default log formatter.
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (274474 => 274475)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-03-16 13:52:20 UTC (rev 274474)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2021-03-16 14:03:50 UTC (rev 274475)
@@ -1927,6 +1927,119 @@
self.expectOutcome(result=SUCCESS, state_string='layout-tests')
return self.runStep()
+def test_success_retry_only_subset(self):
+self.configureStep()
+self.setProperty('fullPlatform', 'ios-simulator')
+self.setProperty('configuration', 'release')
+self.setProperty('first_run_failures', ['test1', 'test2', 'test3'])
+self.setProperty('second_run_failures', ['test1', 'test3', 'test4'])
+self.expectRemoteCommands(
+ExpectShell(workdir='wkdir',
+logfiles={'json': self.jsonFileName},
+logEnviron=False,
+command=['python',
+
[webkit-changes] [270361] trunk/Tools
Title: [270361] trunk/Tools
Revision 270361
Author clo...@igalia.com
Date 2020-12-02 12:07:40 -0800 (Wed, 02 Dec 2020)
Log Message
Remove unused JSC ARMv7 worker from EWS
https://bugs.webkit.org/show_bug.cgi?id=219444
Reviewed by Aakash Jain.
Worker igalia-jsc32-armv7-ews-03 is unused and there isn't any
plan to use it on the near future.
* CISupport/ews-build/config.json:
Modified Paths
trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/config.json (270360 => 270361)
--- trunk/Tools/CISupport/ews-build/config.json 2020-12-02 19:35:34 UTC (rev 270360)
+++ trunk/Tools/CISupport/ews-build/config.json 2020-12-02 20:07:40 UTC (rev 270361)
@@ -14,10 +14,6 @@
"platform": "jsc-only"
},
{
- "name": "igalia-jsc32-armv7-ews-03",
- "platform": "jsc-only"
-},
-{
"name": "igalia-jsc32-mipsel-ews",
"platform": "jsc-only"
},
Modified: trunk/Tools/ChangeLog (270360 => 270361)
--- trunk/Tools/ChangeLog 2020-12-02 19:35:34 UTC (rev 270360)
+++ trunk/Tools/ChangeLog 2020-12-02 20:07:40 UTC (rev 270361)
@@ -1,3 +1,15 @@
+2020-12-02 Carlos Alberto Lopez Perez
+
+Remove unused JSC ARMv7 worker from EWS
+https://bugs.webkit.org/show_bug.cgi?id=219444
+
+Reviewed by Aakash Jain.
+
+Worker igalia-jsc32-armv7-ews-03 is unused and there isn't any
+plan to use it on the near future.
+
+* CISupport/ews-build/config.json:
+
2020-12-02 Jonathan Bedard
[webkitscmpy] Provide switch to exclude commit message
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [270348] trunk/Tools
Title: [270348] trunk/Tools
Revision 270348
Author clo...@igalia.com
Date 2020-12-02 08:39:03 -0800 (Wed, 02 Dec 2020)
Log Message
Switch EWS workers for JSC-ARMv7-32bits build and test queues to a new machine.
https://bugs.webkit.org/show_bug.cgi?id=219189
Reviewed by Aakash Jain.
This switches the workers for the JSC-ARMv7-32bits-Build-EWS and
JSC-ARMv7-32bits-Test-EWS queues to a new ARM server that will run
things faster than the previous combination of cross-builder + RPis
Since now the tets run natively there is no need for passing the
"--remote-config-file" switch to the run-_javascript_core-tests script.
However "--memory-limited" is still needed because the issues with
failures on memory intensive tests happen on all Linux machines.
So the check to pass this flag is generalized like we do for all
Linux ports on the build.webkit.org buildbot config.
* CISupport/ews-build/config.json:
* CISupport/ews-build/steps.py:
(RunJavaScriptCoreTests.start):
* CISupport/ews-build/steps_unittest.py:
(TestRunJavaScriptCoreTests.test_remote_success):
(TestRunJavaScriptCoreTests.test_dfg_air_and_stress_test_failure):
(TestReRunJavaScriptCoreTests.test_remote_success):
Modified Paths
trunk/Tools/CISupport/ews-build/config.json
trunk/Tools/CISupport/ews-build/steps.py
trunk/Tools/CISupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/ews-build/config.json (270347 => 270348)
--- trunk/Tools/CISupport/ews-build/config.json 2020-12-02 16:05:56 UTC (rev 270347)
+++ trunk/Tools/CISupport/ews-build/config.json 2020-12-02 16:39:03 UTC (rev 270348)
@@ -586,8 +586,7 @@
"platform": "jsc-only",
"configuration": "release",
"architectures": ["armv7"],
- "workernames": ["igalia-jsc32-armv7-ews"],
- "remotes": "../../EWS-test-devices.json"
+ "workernames": ["igalia-jsc32-armv7-ews-02"]
},
{
"name": "JSC-i386-32bits-EWS",
Modified: trunk/Tools/CISupport/ews-build/steps.py (270347 => 270348)
--- trunk/Tools/CISupport/ews-build/steps.py 2020-12-02 16:05:56 UTC (rev 270347)
+++ trunk/Tools/CISupport/ews-build/steps.py 2020-12-02 16:39:03 UTC (rev 270348)
@@ -1613,7 +1613,14 @@
platform = self.getProperty('platform')
if platform == 'jsc-only' and remotesfile:
-self.command.extend(['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited'])
+# FIXME: the bundle copied to the remote should include the testair, testb3, testapi, etc.. binaries
+self.command.extend(['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi'])
+
+# Linux bots have currently problems with JSC tests that try to use large amounts of memory.
+# Check: https://bugs.webkit.org/show_bug.cgi?id=175140
+if platform in ('gtk', 'wpe', 'jsc-only'):
+self.command.extend(['--memory-limited', '--verbose'])
+
appendCustomBuildFlags(self, self.getProperty('platform'), self.getProperty('fullPlatform'))
return shell.Test.start(self)
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (270347 => 270348)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-12-02 16:05:56 UTC (rev 270347)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-12-02 16:39:03 UTC (rev 270348)
@@ -1279,7 +1279,7 @@
self.expectRemoteCommands(
ExpectShell(workdir='wkdir',
logEnviron=False,
-command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited', '--jsc-only'],
+command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--remote-config-file=remote-machines.json', '--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--memory-limited', '--verbose', '--jsc-only'],
logfiles={'json': self.jsonFileName},
)
+ 0,
@@ -1375,7 +1375,7 @@
ExpectShell(workdir='wkdir',
logEnviron=False,
logfiles={'json': self.jsonFileName},
-command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--jsc-only'],
+command=['perl', 'Tools/Scripts/run-_javascript_core-tests', '--no-build', '--no-fail-fast', '--json-output={0}'.format(self.jsonFileName), '--release', '--memory-limited', '--verbose', '--jsc-only'],
)
+ 2
+ ExpectShell.log('json',
[webkit-changes] [269949] trunk/Tools
Title: [269949] trunk/Tools
Revision 269949
Author clo...@igalia.com
Date 2020-11-18 02:44:41 -0800 (Wed, 18 Nov 2020)
Log Message
[FlatPak] update-webkitgtk-libs fails after a clean build
https://bugs.webkit.org/show_bug.cgi?id=218724
Reviewed by Philippe Normand.
The issue was caused because when adding a new flatpak repository
via the method FlatpakRepos.add() that repository is not added to
the internal list of available repositories inside the object FlatpakRepos.
So then the check on setup_builddir() added in r268542 failed because
the internal list of repositories on the object FlatpakRepos() was
empty on the first run (after a clean build).
To fix this we ensure to re-generate the internal list of flatpak
repositories any time that a new reporistory is added by calling
FlatpakRepos.update() after FlatpakRepos.add()
On top of that fix, we add another fix to make the code more robust.
Now it allows the generation of toolchains to fail without causing
a fatal error. Also a new check is added in order to retry to generate
the toolchains in the next run if is detected that they were not
correctly generated.
* flatpak/flatpakutils.py:
(FlatpakRepos.add):
(WebkitFlatpak.load_from_args):
(WebkitFlatpak.main):
(WebkitFlatpak.check_toolchains_generated):
(WebkitFlatpak.pack_toolchain):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/flatpak/flatpakutils.py
Diff
Modified: trunk/Tools/ChangeLog (269948 => 269949)
--- trunk/Tools/ChangeLog 2020-11-18 09:31:39 UTC (rev 269948)
+++ trunk/Tools/ChangeLog 2020-11-18 10:44:41 UTC (rev 269949)
@@ -1,3 +1,33 @@
+2020-11-18 Carlos Alberto Lopez Perez
+
+[FlatPak] update-webkitgtk-libs fails after a clean build
+https://bugs.webkit.org/show_bug.cgi?id=218724
+
+Reviewed by Philippe Normand.
+
+The issue was caused because when adding a new flatpak repository
+via the method FlatpakRepos.add() that repository is not added to
+the internal list of available repositories inside the object FlatpakRepos.
+So then the check on setup_builddir() added in r268542 failed because
+the internal list of repositories on the object FlatpakRepos() was
+empty on the first run (after a clean build).
+To fix this we ensure to re-generate the internal list of flatpak
+repositories any time that a new reporistory is added by calling
+FlatpakRepos.update() after FlatpakRepos.add()
+
+On top of that fix, we add another fix to make the code more robust.
+Now it allows the generation of toolchains to fail without causing
+a fatal error. Also a new check is added in order to retry to generate
+the toolchains in the next run if is detected that they were not
+correctly generated.
+
+* flatpak/flatpakutils.py:
+(FlatpakRepos.add):
+(WebkitFlatpak.load_from_args):
+(WebkitFlatpak.main):
+(WebkitFlatpak.check_toolchains_generated):
+(WebkitFlatpak.pack_toolchain):
+
2020-11-17 Diego Pino Garcia
[buildbot] Add buildAndTest bot for WebKitGTK (GTK4)
Modified: trunk/Tools/flatpak/flatpakutils.py (269948 => 269949)
--- trunk/Tools/flatpak/flatpakutils.py 2020-11-18 09:31:39 UTC (rev 269948)
+++ trunk/Tools/flatpak/flatpakutils.py 2020-11-18 10:44:41 UTC (rev 269949)
@@ -263,31 +263,34 @@
self.packages = FlatpakPackages(self)
def add(self, repo, override=True):
-same_name = None
-for name, tmprepo in self.repos.items():
-if repo.url == tmprepo.url:
-return tmprepo
-elif repo.name == name:
-same_name = tmprepo
+try:
+same_name = None
+for name, tmprepo in self.repos.items():
+if repo.url == tmprepo.url:
+return tmprepo
+elif repo.name == name:
+same_name = tmprepo
-if same_name:
-if override:
-self.flatpak("remote-modify", repo.name, "--url="" + repo.url)
-same_name.url = ""
+if same_name:
+if override:
+self.flatpak("remote-modify", repo.name, "--url="" + repo.url)
+same_name.url = ""
-return same_name
+return same_name
+else:
+return None
else:
-return None
-else:
-args = ["remote-add", repo.name, "--if-not-exists"]
-if repo.repo_file:
-args.extend(["--from", repo.repo_file.name])
-else:
-args.extend(["--no-gpg-verify", repo.url])
-self.flatpak(*args, comment="Adding repo %s" % repo.name)
+args = ["remote-add", repo.name, "--if-not-exists"]
+if repo.repo_file:
+args.extend(["--from", repo.repo_file.name])
+else:
+
[webkit-changes] [269626] trunk/LayoutTests
Title: [269626] trunk/LayoutTests Revision 269626 Author clo...@igalia.com Date 2020-11-10 06:58:51 -0800 (Tue, 10 Nov 2020) Log Message [GTK][WPE] Rebaseline tests after r269510, r269598, r269600 and r269612. Unreviewed GTK/WPE gardening. * platform/gtk/editing/selection/simple-line-layout-caret-is-gone-expected.txt: Removed. * platform/gtk/fast/dom/Window/window-lookup-precedence-expected.txt: * platform/gtk/fast/repaint/focus-ring-repaint-expected.txt: * platform/gtk/fast/table/005-expected.txt: Copied from LayoutTests/platform/glib/fast/table/005-expected.txt. * platform/gtk/fast/table/unbreakable-images-quirk-expected.txt: Copied from LayoutTests/platform/glib/fast/table/unbreakable-images-quirk-expected.txt. * platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.image-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.worker-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/html/semantics/interfaces-expected.txt: * platform/gtk/tables/mozilla/bugs/bug2973-expected.txt: Renamed from LayoutTests/platform/glib/tables/mozilla/bugs/bug2973-expected.txt. * platform/gtk/tables/mozilla_expected_failures/bugs/bug8499-expected.txt: * platform/wpe/css3/filters/effect-brightness-clamping-expected.txt: * platform/wpe/css3/filters/effect-brightness-clamping-hw-expected.txt: * platform/wpe/css3/filters/effect-brightness-expected.txt: * platform/wpe/css3/filters/effect-brightness-hw-expected.txt: * platform/wpe/css3/filters/effect-combined-expected.txt: * platform/wpe/css3/filters/effect-combined-hw-expected.txt: * platform/wpe/css3/filters/effect-contrast-expected.txt: * platform/wpe/css3/filters/effect-contrast-hw-expected.txt: * platform/wpe/css3/filters/effect-drop-shadow-expected.txt: * platform/wpe/css3/filters/effect-drop-shadow-hw-expected.txt: * platform/wpe/css3/filters/effect-grayscale-expected.txt: * platform/wpe/css3/filters/effect-grayscale-hw-expected.txt: * platform/wpe/css3/filters/effect-hue-rotate-expected.txt: * platform/wpe/css3/filters/effect-hue-rotate-hw-expected.txt: * platform/wpe/css3/filters/effect-invert-expected.txt: * platform/wpe/css3/filters/effect-invert-hw-expected.txt: * platform/wpe/css3/filters/effect-opacity-expected.txt: * platform/wpe/css3/filters/effect-opacity-hw-expected.txt: * platform/wpe/css3/filters/effect-saturate-expected.txt: * platform/wpe/css3/filters/effect-saturate-hw-expected.txt: * platform/wpe/css3/filters/effect-sepia-expected.txt: * platform/wpe/css3/filters/effect-sepia-hw-expected.txt: * platform/wpe/fast/table/005-expected.txt: Renamed from LayoutTests/platform/glib/fast/table/005-expected.txt. * platform/wpe/fast/table/unbreakable-images-quirk-expected.txt: Renamed from LayoutTests/platform/glib/fast/table/unbreakable-images-quirk-expected.txt. * platform/wpe/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.image-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/canvas/offscreen/drawing-images-to-the-canvas/2d.drawImage.zerosource.worker-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-attribute-changes-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-empty-content-value-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-first-valid-applies-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-insert-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-no-content-value-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-presentational-hint-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-remove-head-expected.txt: Added. * platform/wpe/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/color-scheme/meta-color-scheme-single-value-in-body-expected.txt:
[webkit-changes] [269625] trunk/Tools
Title: [269625] trunk/Tools Revision 269625 Author clo...@igalia.com Date 2020-11-10 05:30:30 -0800 (Tue, 10 Nov 2020) Log Message [GTK] [REGRESSSION(r269390) Several editing/ tests are flaky https://bugs.webkit.org/show_bug.cgi?id=218607 Reviewed by Adrian Perez de Castro. After r269390 some of the internal preferences like LiveRangeSelectionEnabled are not resetted to their default value on WTR between test runs. So when a test changes some of this properties it may cause failures on the next tests that will run on the same WTR process. * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues): Add back the call to WKPreferencesResetAllInternalDebugFeatures() that was removed on r269390. Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/TestController.cpp Diff Modified: trunk/Tools/ChangeLog (269624 => 269625) --- trunk/Tools/ChangeLog 2020-11-10 11:44:33 UTC (rev 269624) +++ trunk/Tools/ChangeLog 2020-11-10 13:30:30 UTC (rev 269625) @@ -1,3 +1,18 @@ +2020-11-10 Carlos Alberto Lopez Perez + +[GTK] [REGRESSSION(r269390) Several editing/ tests are flaky +https://bugs.webkit.org/show_bug.cgi?id=218607 + +Reviewed by Adrian Perez de Castro. + +After r269390 some of the internal preferences like LiveRangeSelectionEnabled +are not resetted to their default value on WTR between test runs. +So when a test changes some of this properties it may cause failures on +the next tests that will run on the same WTR process. + +* WebKitTestRunner/TestController.cpp: +(WTR::TestController::resetPreferencesToConsistentValues): Add back the call to WKPreferencesResetAllInternalDebugFeatures() that was removed on r269390. + 2020-11-10 Carlos Garcia Campos [GTK] MiniBrowser: add buttons to insert ordered/unordered lists to editor toolbar Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (269624 => 269625) --- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-11-10 11:44:33 UTC (rev 269624) +++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-11-10 13:30:30 UTC (rev 269625) @@ -829,6 +829,7 @@ WKPreferencesResetTestRunnerOverrides(preferences); WKPreferencesEnableAllExperimentalFeatures(preferences); +WKPreferencesResetAllInternalDebugFeatures(preferences); // FIXME: Convert these to default values for TestOptions. WKPreferencesSetProcessSwapOnNavigationEnabled(preferences, options.shouldEnableProcessSwapOnNavigation()); ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269514] trunk/Tools
Title: [269514] trunk/Tools
Revision 269514
Author clo...@igalia.com
Date 2020-11-06 09:08:04 -0800 (Fri, 06 Nov 2020)
Log Message
REGRESSION(r268930): It broke the http server of run-benchmark
https://bugs.webkit.org/show_bug.cgi?id=218643
Reviewed by Jonathan Bedard.
The http server was failing to start because it is executed in a
subprocess and it can't find webkitpy.autoinstalled because the
scripts dir is not in PYTHONPATH.
Fix this and also add a check to ensure the http server is alive,
and if not, then raise an error with the return code and outputs
from the http server process.
* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
(SimpleHTTPServerDriver.serve):
(SimpleHTTPServerDriver):
(SimpleHTTPServerDriver._find_http_server_port):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py
trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py
Diff
Modified: trunk/Tools/ChangeLog (269513 => 269514)
--- trunk/Tools/ChangeLog 2020-11-06 17:03:51 UTC (rev 269513)
+++ trunk/Tools/ChangeLog 2020-11-06 17:08:04 UTC (rev 269514)
@@ -1,5 +1,26 @@
2020-11-06 Carlos Alberto Lopez Perez
+REGRESSION(r268930): It broke the http server of run-benchmark
+https://bugs.webkit.org/show_bug.cgi?id=218643
+
+Reviewed by Jonathan Bedard.
+
+The http server was failing to start because it is executed in a
+subprocess and it can't find webkitpy.autoinstalled because the
+scripts dir is not in PYTHONPATH.
+
+Fix this and also add a check to ensure the http server is alive,
+and if not, then raise an error with the return code and outputs
+from the http server process.
+
+* Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
+* Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
+(SimpleHTTPServerDriver.serve):
+(SimpleHTTPServerDriver):
+(SimpleHTTPServerDriver._find_http_server_port):
+
+2020-11-06 Carlos Alberto Lopez Perez
+
webkitpy: Add a --no-comment switch to webkit-patch land
https://bugs.webkit.org/show_bug.cgi?id=218067
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py (269513 => 269514)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py 2020-11-06 17:03:51 UTC (rev 269513)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py 2020-11-06 17:08:04 UTC (rev 269514)
@@ -5,6 +5,12 @@
import os
import sys
+# Since we execute this script directly as a subprocess, we need to ensure
+# that Tools/Scripts is in sys.path for the next imports to work correctly.
+script_dir = os.path.abspath(os.path.join(os.path.dirname(os.path.abspath(__file__)), '../../../..'))
+if script_dir not in sys.path:
+sys.path.append(script_dir)
+
from pkg_resources import require, VersionConflict, DistributionNotFound
from webkitpy.autoinstalled import twisted
Modified: trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py (269513 => 269514)
--- trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py 2020-11-06 17:03:51 UTC (rev 269513)
+++ trunk/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py 2020-11-06 17:08:04 UTC (rev 269514)
@@ -33,39 +33,36 @@
if self._ip:
interface_args.extend(['--interface', self._ip])
self._server_process = subprocess.Popen(["python", http_server_path, web_root] + interface_args, stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-
max_attempt = 5
interval = 0.5
_log.info('Start to fetching the port number of the http server')
+for attempt in range(max_attempt):
+self._find_http_server_port()
+if self._server_port:
+_log.info('HTTP Server is serving at port: %d', self._server_port)
+break
+_log.info('Server port is not found this time, retry after %f seconds' % interval)
+time.sleep(interval)
+interval *= 2
+else:
+raise Exception("Server is not listening on port, max tries exceeded. HTTP server may be installing dependent modules.")
+self._wait_for_http_server()
+
+def _find_http_server_port(self):
+if self._server_process.poll() is not None:
+stdout_data, stderr_data = self._server_process.communicate()
+raise RuntimeError('The http server terminated unexpectedly with return code {} and with the following
[webkit-changes] [269513] trunk/Tools
Title: [269513] trunk/Tools
Revision 269513
Author clo...@igalia.com
Date 2020-11-06 09:03:51 -0800 (Fri, 06 Nov 2020)
Log Message
webkitpy: Add a --no-comment switch to webkit-patch land
https://bugs.webkit.org/show_bug.cgi?id=218067
Reviewed by Ryosuke Niwa.
Add an optional --no-comment switch to webkit-patch land.
This is useful when landing gardening, build-fixes or follow-up patches
on a bug and you don't want the tool to automatically add a comment with
the revision landed because you preffer to later add a comment manually.
Note that it will still close the bug, if you don't want the bug to
be closed you need to pass also --no-close.
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzilla.close_bug_as_fixed):
* Scripts/webkitpy/tool/commands/download_unittest.py:
(DownloadCommandsTest._default_options):
(test_land_no_close):
* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
(CloseBugForLandDiff.options):
(CloseBugForLandDiff.run):
* Scripts/webkitpy/tool/steps/options.py:
(Options):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py
trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py
trunk/Tools/Scripts/webkitpy/tool/steps/closebugforlanddiff.py
trunk/Tools/Scripts/webkitpy/tool/steps/options.py
Diff
Modified: trunk/Tools/ChangeLog (269512 => 269513)
--- trunk/Tools/ChangeLog 2020-11-06 16:01:31 UTC (rev 269512)
+++ trunk/Tools/ChangeLog 2020-11-06 17:03:51 UTC (rev 269513)
@@ -1,3 +1,29 @@
+2020-11-06 Carlos Alberto Lopez Perez
+
+webkitpy: Add a --no-comment switch to webkit-patch land
+https://bugs.webkit.org/show_bug.cgi?id=218067
+
+Reviewed by Ryosuke Niwa.
+
+Add an optional --no-comment switch to webkit-patch land.
+This is useful when landing gardening, build-fixes or follow-up patches
+on a bug and you don't want the tool to automatically add a comment with
+the revision landed because you preffer to later add a comment manually.
+
+Note that it will still close the bug, if you don't want the bug to
+be closed you need to pass also --no-close.
+
+* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
+(MockBugzilla.close_bug_as_fixed):
+* Scripts/webkitpy/tool/commands/download_unittest.py:
+(DownloadCommandsTest._default_options):
+(test_land_no_close):
+* Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
+(CloseBugForLandDiff.options):
+(CloseBugForLandDiff.run):
+* Scripts/webkitpy/tool/steps/options.py:
+(Options):
+
2020-11-05 John Wilander
PCM: Switch to JSON report format
Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py (269512 => 269513)
--- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py 2020-11-06 16:01:31 UTC (rev 269512)
+++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py 2020-11-06 17:03:51 UTC (rev 269513)
@@ -473,7 +473,7 @@
def reopen_bug(self, bug_id, message):
_log.info("MOCK reopen_bug %s with comment '%s'" % (bug_id, message))
-def close_bug_as_fixed(self, bug_id, message):
+def close_bug_as_fixed(self, bug_id, comment_text=None):
pass
def clear_attachment_flags(self, attachment_id, message):
Modified: trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py (269512 => 269513)
--- trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2020-11-06 16:01:31 UTC (rev 269512)
+++ trunk/Tools/Scripts/webkitpy/tool/commands/download_unittest.py 2020-11-06 17:03:51 UTC (rev 269513)
@@ -84,6 +84,7 @@
options.check_style_filter = None
options.clean = True
options.close_bug = True
+options.comment_bug = True
options.force_clean = False
options.non_interactive = False
options.parent_command = 'MOCK parent command'
@@ -148,7 +149,7 @@
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824:
-Updating bug 5
+Adding comment and closing bug 5
"""
mock_tool = MockTool()
mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
@@ -191,7 +192,7 @@
Running _javascript_Core tests
Running run-webkit-tests
Committed r49824:
-Updating bug 5
+Adding comment and closing bug 5
"""
mock_tool = MockTool()
mock_tool.buildbot.light_tree_on_fire()
@@ -275,6 +276,51 @@
"""
self.assert_execute_outputs(LandFromURL(), ["https://bugs.webkit.org/show_bug.cgi?id=5"], options=self._default_options(), expected_logs=expected_logs)
+def test_land_no_comment(self):
+expected_logs = """Building WebKit
+Running Python unit tests
+Running Perl unit tests
+Running _javascript_Core tests
+Running run-webkit-tests
+Committed r49824:
+Not updating bug 5
+"""
+options = self._default_options()
+options.comment_bug = False
[webkit-changes] [269302] trunk/LayoutTests
Title: [269302] trunk/LayoutTests Revision 269302 Author clo...@igalia.com Date 2020-11-03 06:46:10 -0800 (Tue, 03 Nov 2020) Log Message [GTK][WPE] Move passing tests to the top of the TestExpectation files. Some tests like http/tests/contentextensions/service-worker.https.html are flaky and we have it marked as such at the GTK/WPE expectation file. But the bots continue to complain about unexpected flakiness for this test. This is because we have our section of tests passing at the bottom of the TestExpectation files. And the layout test runner evaluates the rules from top to bottom and it picks as the valid rule the last one matching. So when we unskip folders from the main TestExpectation file like "http/tests/contentextensions [ Pass ]" we are also resetting the value of all those tests to just Pass. To avoid this problem move the expected passes to the top of the files. Unreviewed test gardening. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (269301 => 269302) --- trunk/LayoutTests/ChangeLog 2020-11-03 14:34:01 UTC (rev 269301) +++ trunk/LayoutTests/ChangeLog 2020-11-03 14:46:10 UTC (rev 269302) @@ -1,3 +1,25 @@ +2020-11-03 Carlos Alberto Lopez Perez + +[GTK][WPE] Move passing tests to the top of the TestExpectation files. + +Some tests like http/tests/contentextensions/service-worker.https.html +are flaky and we have it marked as such at the GTK/WPE expectation file. +But the bots continue to complain about unexpected flakiness for this test. +This is because we have our section of tests passing at the bottom +of the TestExpectation files. And the layout test runner evaluates +the rules from top to bottom and it picks as the valid rule the last +one matching. +So when we unskip folders from the main TestExpectation file like +"http/tests/contentextensions [ Pass ]" we are also resetting the +value of all those tests to just Pass. +To avoid this problem move the expected passes to the top of the files. + +Unreviewed test gardening. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: +* platform/wpe/TestExpectations: + 2020-11-03 Diego Pino Garcia [GTK] Unreviewed test gardening. Remove stale flaky crashes. Modified: trunk/LayoutTests/platform/glib/TestExpectations (269301 => 269302) --- trunk/LayoutTests/platform/glib/TestExpectations 2020-11-03 14:34:01 UTC (rev 269301) +++ trunk/LayoutTests/platform/glib/TestExpectations 2020-11-03 14:46:10 UTC (rev 269302) @@ -14,6 +14,14 @@ # (like WebAnimation, PageOverlay, WebGL) will mirror their top-level LayoutTests/ # folders, but others like CSS and GStreamer may have entries from multiple folders. # +# * PASSING tests +# * Usually to override tests skipped/failing by Mac ports. +# NOTE: Passing tests should be on the top of the file to ensure that +# expected failures below are not overriden by a folder that is +# set to Pass to unskip it from the main expectations file and +# declared after the expected failure. +# The layout test runner evaluates the rules from top to bottom +# and it picks as the valid rule the last one matching. # * Accessibility # * CSS # * Fonts @@ -32,8 +40,6 @@ # * WebSocket # * WPT # * XHR -# * PASSING tests -# * Usually to override tests skipped/failing by Mac ports. # * UNSUPPORTED tests # * Things we do not test. (i.e. Skipped) # * NEEDS TRIAGING @@ -46,6 +52,95 @@ # * Only PASSING/UNSUPPORTED should have expectations without bug entries. # +# TESTS PASSING +# + +animations/missing-values-first-keyframe.html [ Pass ] +animations/missing-values-last-keyframe.html [ Pass ] + +# RSA-PSS tests are for now skipped on all ports, so we for now explicitly enable the passing ones here. +crypto/subtle/ecdh-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html [ Pass ] +crypto/subtle/ecdh-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html [ Pass ] +crypto/subtle/ecdsa-import-pkcs8-key-p256-validate-ecprivatekey-parameters-publickey.html [ Pass ] +crypto/subtle/ecdsa-import-pkcs8-key-p384-validate-ecprivatekey-parameters-publickey.html [ Pass ] +crypto/subtle/ecdh-import-spki-key-ecdh-identifier.html [ Pass ] +crypto/subtle/rsa-pss-generate-export-key-jwk-sha1.html [ Pass ] +crypto/subtle/rsa-pss-generate-export-key-jwk-sha224.html [ Pass ]
[webkit-changes] [269178] trunk/LayoutTests
Title: [269178] trunk/LayoutTests Revision 269178 Author clo...@igalia.com Date 2020-10-29 20:26:56 -0700 (Thu, 29 Oct 2020) Log Message [GTK][WPE] Gardening of new failures after r269177 and mark more flaky tests. Unreviewed gardening. * platform/glib/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (269177 => 269178) --- trunk/LayoutTests/ChangeLog 2020-10-30 02:27:30 UTC (rev 269177) +++ trunk/LayoutTests/ChangeLog 2020-10-30 03:26:56 UTC (rev 269178) @@ -1,3 +1,12 @@ +2020-10-29 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of new failures after r269177 and mark more flaky tests. + +Unreviewed gardening. + +* platform/glib/TestExpectations: +* platform/gtk/TestExpectations: + 2020-10-29 Myles C. Maxfield [GPU Process] Add tests for sbix and COLR fonts in canvas Modified: trunk/LayoutTests/platform/glib/TestExpectations (269177 => 269178) --- trunk/LayoutTests/platform/glib/TestExpectations 2020-10-30 02:27:30 UTC (rev 269177) +++ trunk/LayoutTests/platform/glib/TestExpectations 2020-10-30 03:26:56 UTC (rev 269178) @@ -16,6 +16,7 @@ # # * Accessibility # * CSS +# * Fonts # * GStreamer # * HiDPI # * IndexedDB @@ -220,6 +221,45 @@ # +# Fonts-related bugs +# + +# Missing support for COLR/CPAL fonts. +webkit.org/b/218372 fast/text/canvas-color-fonts/COLR.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/fill-color-shadow-COLR.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/fill-color-shadow-ctm-COLR.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/linedash-COLR.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/stroke-color-COLR.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/stroke-color-shadow-COLR.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/stroke-color-shadow-ctm-COLR.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/stroke-gradient-COLR-3.html [ ImageOnlyFailure ] +webkit.org/b/218372 fast/text/canvas-color-fonts/stroke-gradient-COLR-4.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/ctm-sbix-2.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/ctm-sbix-3.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/ctm-sbix-4.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-color-sbix-2.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-color-sbix-3.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-color-sbix-4.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-color-shadow-ctm-sbix.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-color-shadow-sbix.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-gradient-sbix-2.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-gradient-sbix-3.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/fill-gradient-sbix-4.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/stroke-color-sbix.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/stroke-color-shadow-ctm-sbix.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/stroke-color-shadow-sbix.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/text-sbix-2.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/text-sbix-3.html [ ImageOnlyFailure ] +webkit.org/b/218372 http/tests/canvas/color-fonts/text-sbix-4.html [ ImageOnlyFailure ] + +# +# End of Fonts-related bugs +# + +# # GStreamer-related bugs # @@ -426,6 +466,7 @@ webkit.org/b/126523 perf/accessibility-title-ui-element.html [ Failure Pass ]
[webkit-changes] [269079] trunk/LayoutTests
Title: [269079] trunk/LayoutTests Revision 269079 Author clo...@igalia.com Date 2020-10-27 16:23:28 -0700 (Tue, 27 Oct 2020) Log Message [GTK][WPE] Rebaseline tests after r269044 and r269036 https://bugs.webkit.org/show_bug.cgi?id=218151 Unreviewed gardening. * platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: * platform/gtk/fast/forms/option-index-expected.txt: * platform/gtk/fast/text/basic/generic-family-reset-expected.txt: * platform/gtk/fast/xsl/xslt-enc-cyr-expected.txt: * platform/gtk/fast/xsl/xslt-enc-expected.txt: * platform/gtk/fast/xsl/xslt-enc16-expected.txt: * platform/gtk/fast/xsl/xslt-enc16to16-expected.txt: * platform/gtk/http/tests/navigation/postredirect-basic-expected.txt: * platform/gtk/http/tests/navigation/postredirect-goback1-expected.txt: * platform/gtk/inspector/timeline/line-column-expected.txt: * platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: * platform/wpe/fast/css/text-overflow-ellipsis-bidi-expected.txt: * platform/wpe/fast/css/text-overflow-ellipsis-strict-expected.txt: * platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: * platform/wpe/fast/text/basic/generic-family-reset-expected.txt: * platform/wpe/fast/xsl/xslt-enc-cyr-expected.txt: * platform/wpe/fast/xsl/xslt-enc-expected.txt: * platform/wpe/fast/xsl/xslt-enc16-expected.txt: * platform/wpe/fast/xsl/xslt-enc16to16-expected.txt: * platform/wpe/http/tests/navigation/_javascript_link-frames-expected.txt: * platform/wpe/http/tests/navigation/postredirect-basic-expected.txt: * platform/wpe/http/tests/navigation/postredirect-goback1-expected.txt: * platform/wpe/svg/text/text-overflow-ellipsis-svgfont-expected.txt: * platform/wpe/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt: * platform/wpe/svg/wicd/test-rightsizing-b-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt trunk/LayoutTests/platform/gtk/fast/forms/option-index-expected.txt trunk/LayoutTests/platform/gtk/fast/text/basic/generic-family-reset-expected.txt trunk/LayoutTests/platform/gtk/fast/xsl/xslt-enc-cyr-expected.txt trunk/LayoutTests/platform/gtk/fast/xsl/xslt-enc-expected.txt trunk/LayoutTests/platform/gtk/fast/xsl/xslt-enc16-expected.txt trunk/LayoutTests/platform/gtk/fast/xsl/xslt-enc16to16-expected.txt trunk/LayoutTests/platform/gtk/http/tests/navigation/postredirect-basic-expected.txt trunk/LayoutTests/platform/gtk/http/tests/navigation/postredirect-goback1-expected.txt trunk/LayoutTests/platform/gtk/inspector/timeline/line-column-expected.txt trunk/LayoutTests/platform/gtk/svg/wicd/test-rightsizing-b-expected.txt trunk/LayoutTests/platform/wpe/fast/css/text-overflow-ellipsis-bidi-expected.txt trunk/LayoutTests/platform/wpe/fast/css/text-overflow-ellipsis-strict-expected.txt trunk/LayoutTests/platform/wpe/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt trunk/LayoutTests/platform/wpe/fast/text/basic/generic-family-reset-expected.txt trunk/LayoutTests/platform/wpe/fast/xsl/xslt-enc-cyr-expected.txt trunk/LayoutTests/platform/wpe/fast/xsl/xslt-enc-expected.txt trunk/LayoutTests/platform/wpe/fast/xsl/xslt-enc16-expected.txt trunk/LayoutTests/platform/wpe/fast/xsl/xslt-enc16to16-expected.txt trunk/LayoutTests/platform/wpe/http/tests/navigation/_javascript_link-frames-expected.txt trunk/LayoutTests/platform/wpe/http/tests/navigation/postredirect-basic-expected.txt trunk/LayoutTests/platform/wpe/http/tests/navigation/postredirect-goback1-expected.txt trunk/LayoutTests/platform/wpe/svg/text/text-overflow-ellipsis-svgfont-expected.txt trunk/LayoutTests/platform/wpe/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt trunk/LayoutTests/platform/wpe/svg/wicd/test-rightsizing-b-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (269078 => 269079) --- trunk/LayoutTests/ChangeLog 2020-10-27 22:22:01 UTC (rev 269078) +++ trunk/LayoutTests/ChangeLog 2020-10-27 23:23:28 UTC (rev 269079) @@ -1,3 +1,36 @@ +2020-10-27 Carlos Alberto Lopez Perez + +[GTK][WPE] Rebaseline tests after r269044 and r269036 +https://bugs.webkit.org/show_bug.cgi?id=218151 + +Unreviewed gardening. + +* platform/gtk/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: +* platform/gtk/fast/forms/option-index-expected.txt: +* platform/gtk/fast/text/basic/generic-family-reset-expected.txt: +* platform/gtk/fast/xsl/xslt-enc-cyr-expected.txt: +* platform/gtk/fast/xsl/xslt-enc-expected.txt: +* platform/gtk/fast/xsl/xslt-enc16-expected.txt: +* platform/gtk/fast/xsl/xslt-enc16to16-expected.txt: +* platform/gtk/http/tests/navigation/postredirect-basic-expected.txt: +* platform/gtk/http/tests/navigation/postredirect-goback1-expected.txt: +* platform/gtk/inspector/timeline/line-column-expected.txt: +* platform/gtk/svg/wicd/test-rightsizing-b-expected.txt: +*
[webkit-changes] [269057] trunk/Tools
Title: [269057] trunk/Tools
Revision 269057
Author clo...@igalia.com
Date 2020-10-27 11:25:55 -0700 (Tue, 27 Oct 2020)
Log Message
[GTK] Don't disable MSE build support on Debian and Ubuntu LTS bots
https://bugs.webkit.org/show_bug.cgi?id=218247
Reviewed by Philippe Normand.
The version of gstreamer on this bots (Ubuntu-18.04 and Debian 10)
is now newer enough (1.14) to enable MSE support.
* CISupport/build.webkit.org-config/config.json:
Modified Paths
trunk/Tools/CISupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/CISupport/build.webkit.org-config/config.json (269056 => 269057)
--- trunk/Tools/CISupport/build.webkit.org-config/config.json 2020-10-27 17:59:07 UTC (rev 269056)
+++ trunk/Tools/CISupport/build.webkit.org-config/config.json 2020-10-27 18:25:55 UTC (rev 269057)
@@ -348,13 +348,13 @@
{
"name": "GTK-Linux-64-bit-Release-Debian-Stable-Build", "factory": "BuildFactory", "builddir": "gtk-linux-64-release-debian",
"platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
- "additionalArguments": ["--no-experimental-features", "--no-media-source"],
+ "additionalArguments": ["--no-experimental-features"],
"workernames": ["gtk-linux-bot-10"]
},
{
"name": "GTK-Linux-64-bit-Release-Ubuntu-LTS-Build", "factory": "BuildFactory", "builddir": "gtk-linux-64-release-ubuntu",
"platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
- "additionalArguments": ["--no-experimental-features", "--no-media-source"],
+ "additionalArguments": ["--no-experimental-features"],
"workernames": ["gtk-linux-bot-11"]
},
{
Modified: trunk/Tools/ChangeLog (269056 => 269057)
--- trunk/Tools/ChangeLog 2020-10-27 17:59:07 UTC (rev 269056)
+++ trunk/Tools/ChangeLog 2020-10-27 18:25:55 UTC (rev 269057)
@@ -1,3 +1,15 @@
+2020-10-27 Carlos Alberto Lopez Perez
+
+[GTK] Don't disable MSE build support on Debian and Ubuntu LTS bots
+https://bugs.webkit.org/show_bug.cgi?id=218247
+
+Reviewed by Philippe Normand.
+
+The version of gstreamer on this bots (Ubuntu-18.04 and Debian 10)
+is now newer enough (1.14) to enable MSE support.
+
+* CISupport/build.webkit.org-config/config.json:
+
2020-10-27 Aakash Jain
Rename BuildSlaveSupport to CISupport
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269053] trunk/Source/WebCore
Title: [269053] trunk/Source/WebCore Revision 269053 Author clo...@igalia.com Date 2020-10-27 10:43:33 -0700 (Tue, 27 Oct 2020) Log Message Fix build for non-unified builds after r269041. https://bugs.webkit.org/show_bug.cgi?id=218233 Unreviewed build fix. Add missing include that can cause a build breakage for non-unified builds or for unified builds depending on how the included files are listed- * rendering/RenderBlockFlow.cpp: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/rendering/RenderBlockFlow.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (269052 => 269053) --- trunk/Source/WebCore/ChangeLog 2020-10-27 17:38:13 UTC (rev 269052) +++ trunk/Source/WebCore/ChangeLog 2020-10-27 17:43:33 UTC (rev 269053) @@ -1,3 +1,16 @@ +2020-10-27 Carlos Alberto Lopez Perez + +Fix build for non-unified builds after r269041. +https://bugs.webkit.org/show_bug.cgi?id=218233 + +Unreviewed build fix. + +Add missing include that can cause a build breakage for non-unified +builds or for unified builds depending on how the included files +are listed- + +* rendering/RenderBlockFlow.cpp: + 2020-10-27 Kenneth Russell [ iOS wk2 ] webgl/1.0.3/conformance/textures/copy-tex-image-2d-formats.html is failing. Modified: trunk/Source/WebCore/rendering/RenderBlockFlow.cpp (269052 => 269053) --- trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2020-10-27 17:38:13 UTC (rev 269052) +++ trunk/Source/WebCore/rendering/RenderBlockFlow.cpp 2020-10-27 17:43:33 UTC (rev 269053) @@ -35,6 +35,7 @@ #include "HTMLTextAreaElement.h" #include "HitTestLocation.h" #include "InlineTextBox.h" +#include "LayoutIntegrationLineIterator.h" #include "LayoutIntegrationLineLayout.h" #include "LayoutRepainter.h" #include "Logging.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [269042] trunk/Tools
Title: [269042] trunk/Tools
Revision 269042
Author clo...@igalia.com
Date 2020-10-27 08:57:51 -0700 (Tue, 27 Oct 2020)
Log Message
[GTK] Move step for generating the JSC bundle back to the release build bot
https://bugs.webkit.org/show_bug.cgi?id=218207
Reviewed by Adrian Perez de Castro.
On r266208 I moved the step to generate the JSC bundle from the default
GTK release build bot to the new bots for Ubuntu-20.04 packaging.
But it seems the ICU version of Ubuntu-20.04 (66) is not new enough for
testing some Intl features like Intl.ListFormat as JS Intl feature behaviors
are derived from ICU versions.
Move back this step to the GTK release build bot that runs with flatpak,
so it bundles the version of ICU from the FreeDesktop SDK (67 currently)
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (269041 => 269042)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2020-10-27 15:57:15 UTC (rev 269041)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2020-10-27 15:57:51 UTC (rev 269042)
@@ -291,7 +291,7 @@
"workernames": ["bot545"]
},
{
- "name": "GTK-Linux-64-bit-Release-Build", "factory": "BuildFactory", "builddir": "gtk-linux-64-release",
+ "name": "GTK-Linux-64-bit-Release-Build", "factory": "BuildAndGenerateJSCBundleFactory", "builddir": "gtk-linux-64-release",
"platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
"triggers": ["gtk-linux-64-release-tests", "gtk-linux-64-release-tests-js", "gtk-linux-64-release-tests-webdriver",
"gtk-linux-64-release-wayland-tests", "gtk-linux-64-release-perf-tests"],
@@ -364,7 +364,7 @@
"workernames": ["gtk-linux-bot-16"]
},
{
- "name": "GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004", "factory": "BuildAndGenerateMiniBrowserJSCBundleFactory", "builddir": "gtk-linux-64-packaging-nigthly-ubuntu2004",
+ "name": "GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004", "factory": "BuildAndGenerateMiniBrowserBundleFactory", "builddir": "gtk-linux-64-packaging-nigthly-ubuntu2004",
"platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
"additionalArguments": ["--no-bubblewrap-sandbox"],
"workernames": ["gtk-linux-bot-17"]
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py (269041 => 269042)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py 2020-10-27 15:57:15 UTC (rev 269041)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py 2020-10-27 15:57:51 UTC (rev 269042)
@@ -570,7 +570,7 @@
'GTK-Linux-64-bit-Debug-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'layout-test', 'webkitpy-test', 'webkitperl-test', 'bindings-generation-tests', 'builtins-generator-tests', 'dashboard-tests', 'archive-test-results', 'upload', 'MasterShellCommand', 'API-tests'],
'GTK-Linux-64-bit-Debug-WebDriver-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'webdriver-test'],
'GTK-Linux-64-bit-Debug-JS-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'jscore-test', 'test262-test'],
-'GTK-Linux-64-bit-Release-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'],
+'GTK-Linux-64-bit-Release-Build': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'compile-webkit', 'generate-jsc-bundle', 'archive-built-product', 'upload', 'transfer-to-s3', 'trigger'],
'GTK-Linux-64-bit-Release-Perf': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory', 'delete-stale-build-files', 'jhbuild', 'download-built-product', 'extract-built-product', 'perf-test', 'benchmark-test'],
'GTK-Linux-64-bit-Release-Tests': ['configure-build', 'svn', 'kill-old-processes', 'delete-WebKitBuild-directory',
[webkit-changes] [269021] trunk/LayoutTests
Title: [269021] trunk/LayoutTests Revision 269021 Author clo...@igalia.com Date 2020-10-26 21:39:26 -0700 (Mon, 26 Oct 2020) Log Message [GTK][WPE] Gardening of layout test failures. Unreviewed gardening. * platform/glib/TestExpectations: * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (269020 => 269021) --- trunk/LayoutTests/ChangeLog 2020-10-27 02:13:14 UTC (rev 269020) +++ trunk/LayoutTests/ChangeLog 2020-10-27 04:39:26 UTC (rev 269021) @@ -1,3 +1,12 @@ +2020-10-26 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of layout test failures. + +Unreviewed gardening. + +* platform/glib/TestExpectations: +* platform/wpe/TestExpectations: + 2020-10-26 Timothy Horton fast/events/touch/ios/show-modal-alert-during-touch-start.html logs about unexpected argument Modified: trunk/LayoutTests/platform/glib/TestExpectations (269020 => 269021) --- trunk/LayoutTests/platform/glib/TestExpectations 2020-10-27 02:13:14 UTC (rev 269020) +++ trunk/LayoutTests/platform/glib/TestExpectations 2020-10-27 04:39:26 UTC (rev 269021) @@ -238,7 +238,7 @@ webkit.org/b/203078 media/media-source/media-source-remove-unload-crash.html [ Crash Timeout Pass ] webkit.org/b/210528 media/media-source/media-source-seek-back.html [ Crash Pass ] -webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout ] +webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout Crash ] webkit.org/b/210528 media/video-src-blob-replay.html [ Crash Pass ] @@ -687,6 +687,8 @@ webkit.org/b/216763 webrtc/captureCanvas-webrtc-software-h264-high.html [ Crash Failure ] +webkit.org/b/218221 webrtc/vp9-profile2.html [ Failure ] + # # End of WebRTC-related bugs # @@ -1224,6 +1226,9 @@ webkit.org/b/217363 js/throw-large-string-oom.html [ Pass Crash Timeout ] +# Fails when built with GCC but passes with Clang +webkit.org/b/218220 editing/execCommand/switch-list-type-with-orphaned-li.html [ Pass Failure ] + # # End of NEEDS TRIAGING. Don't put expectations below this section. # Modified: trunk/LayoutTests/platform/wpe/TestExpectations (269020 => 269021) --- trunk/LayoutTests/platform/wpe/TestExpectations 2020-10-27 02:13:14 UTC (rev 269020) +++ trunk/LayoutTests/platform/wpe/TestExpectations 2020-10-27 04:39:26 UTC (rev 269021) @@ -1612,7 +1612,6 @@ webkit.org/b/171726 media/media-source/media-source-init-segment-duration.html [ Failure ] webkit.org/b/168373 media/media-source/media-source-resize.html [ Failure ] webkit.org/b/168373 media/media-source/only-bcp47-language-tags-accepted-as-valid.html [ Timeout ] -webkit.org/b/214636 media/media-source/media-source-webm.html [ Timeout ] webkit.org/b/177871 http/wpt/resource-timing/rt-shared-resource-in-workers.html [ Failure ] webkit.org/b/168357 http/wpt/resource-timing/rt-initiatorType-media.html [ Pass Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268903] trunk/LayoutTests
Title: [268903] trunk/LayoutTests Revision 268903 Author clo...@igalia.com Date 2020-10-22 20:49:41 -0700 (Thu, 22 Oct 2020) Log Message [GTK][WPE] Gardening of failures happening on the bots. Unreviewed gardening. * platform/glib/TestExpectations: * platform/gtk-wayland/TestExpectations: * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/glib/TestExpectations trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/gtk-wayland/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (268902 => 268903) --- trunk/LayoutTests/ChangeLog 2020-10-23 01:38:25 UTC (rev 268902) +++ trunk/LayoutTests/ChangeLog 2020-10-23 03:49:41 UTC (rev 268903) @@ -1,3 +1,13 @@ +2020-10-22 Carlos Alberto Lopez Perez + +[GTK][WPE] Gardening of failures happening on the bots. + +Unreviewed gardening. + +* platform/glib/TestExpectations: +* platform/gtk-wayland/TestExpectations: +* platform/gtk/TestExpectations: + 2020-10-22 Simon Fraser REGRESSION(r268476): [ macOS ] tiled-drawing/scrolling/non-fast-region/handlers-in-iframes.html is a flaky failure Modified: trunk/LayoutTests/platform/glib/TestExpectations (268902 => 268903) --- trunk/LayoutTests/platform/glib/TestExpectations 2020-10-23 01:38:25 UTC (rev 268902) +++ trunk/LayoutTests/platform/glib/TestExpectations 2020-10-23 03:49:41 UTC (rev 268903) @@ -747,7 +747,7 @@ webkit.org/b/175586 imported/w3c/web-platform-tests/xhr/send-network-error-sync-events.sub.htm [ Failure ] webkit.org/b/202736 http/tests/appcache/remove-cache.html [ DumpJSConsoleLogInStdErr ] -webkit.org/b/202736 [ Release ] http/wpt/cache-storage/quota-third-party.https.html [ Slow ] +webkit.org/b/202736 [ Release ] http/wpt/cache-storage/quota-third-party.https.html [ Pass Timeout ] webkit.org/b/203240 imported/w3c/web-platform-tests/css/css-shapes/shape-outside/shape-image/shape-image-025.html [ ImageOnlyFailure Pass ] @@ -1208,6 +1208,8 @@ imported/w3c/web-platform-tests/webaudio/the-audio-api/the-audionode-interface/audionode-disconnect-audioparam.html [ DumpJSConsoleLogInStdErr ] +webkit.org/b/217363 js/throw-large-string-oom.html [ Pass Crash Timeout ] + # # End of NEEDS TRIAGING. Don't put expectations below this section. # Modified: trunk/LayoutTests/platform/gtk/TestExpectations (268902 => 268903) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-10-23 01:38:25 UTC (rev 268902) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-10-23 03:49:41 UTC (rev 268903) @@ -3421,7 +3421,7 @@ webkit.org/b/202229 css-dark-mode/color-scheme-css.html [ Failure ] webkit.org/b/202229 css-dark-mode/color-scheme-meta.html [ Failure ] -webkit.org/b/202229 css-dark-mode/older-syntax/supported-color-schemes-css.html [ Failure ] +webkit.org/b/202229 css-dark-mode/older-syntax/supported-color-schemes-css.html [ Crash Failure ] webkit.org/b/202229 css-dark-mode/older-syntax/supported-color-schemes-meta.html [ Failure ] webkit.org/b/202744 compositing/layer-creation/absolute-in-async-overflow-scroll.html [ Failure ] @@ -3465,6 +3465,8 @@ webkit.org/b/212744 compositing/repaint/compositing-toggle-in-overflow-scroll-repaint.html [ Failure ] +webkit.org/b/218111 compositing/clipping/border-radius-async-overflow-stacking.html [ ImageOnlyFailure ] + # # End of non-crashing, non-flaky tests failing # Modified: trunk/LayoutTests/platform/gtk-wayland/TestExpectations (268902 => 268903) --- trunk/LayoutTests/platform/gtk-wayland/TestExpectations 2020-10-23 01:38:25 UTC (rev 268902) +++ trunk/LayoutTests/platform/gtk-wayland/TestExpectations 2020-10-23 03:49:41 UTC (rev 268903) @@ -29,7 +29,6 @@ #// # NetworkProcess -webkit.org/b/217363 js/throw-large-string-oom.html [ Pass Crash ] webkit.org/b/217363 imported/w3c/web-platform-tests/xhr/sync-no-timeout.any.html [ Failure Crash ] # Workers ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268855] trunk/Tools
Title: [268855] trunk/Tools
Revision 268855
Author clo...@igalia.com
Date 2020-10-21 23:43:54 -0700 (Wed, 21 Oct 2020)
Log Message
[JHbuild] Add patch to wpebackend-fdo to fix the build on Ubuntu-18.04
https://bugs.webkit.org/show_bug.cgi?id=218068
Reviewed by Adrian Perez de Castro.
On r268591 I updated the version of wpebackend-fdo to the last stable 1.8
but this version is failing to build on Ubuntu-18.04 because of the cmake version.
Backport a patch to fix this.
* gtk/jhbuild.modules:
* gtk/patches/wpebackend-fdo-cmake-buildfix-3.10.patch: Added.
* jhbuild/jhbuild-minimal.modules:
* jhbuild/patches/wpebackend-fdo-cmake-buildfix-3.10.patch: Added.
* wpe/jhbuild.modules:
* wpe/patches/wpebackend-fdo-cmake-buildfix-3.10.patch: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/gtk/jhbuild.modules
trunk/Tools/jhbuild/jhbuild-minimal.modules
trunk/Tools/wpe/jhbuild.modules
Added Paths
trunk/Tools/gtk/patches/wpebackend-fdo-cmake-buildfix-3.10.patch
trunk/Tools/jhbuild/patches/wpebackend-fdo-cmake-buildfix-3.10.patch
trunk/Tools/wpe/patches/wpebackend-fdo-cmake-buildfix-3.10.patch
Diff
Modified: trunk/Tools/ChangeLog (268854 => 268855)
--- trunk/Tools/ChangeLog 2020-10-22 05:24:58 UTC (rev 268854)
+++ trunk/Tools/ChangeLog 2020-10-22 06:43:54 UTC (rev 268855)
@@ -1,3 +1,21 @@
+2020-10-21 Carlos Alberto Lopez Perez
+
+[JHbuild] Add patch to wpebackend-fdo to fix the build on Ubuntu-18.04
+https://bugs.webkit.org/show_bug.cgi?id=218068
+
+Reviewed by Adrian Perez de Castro.
+
+On r268591 I updated the version of wpebackend-fdo to the last stable 1.8
+but this version is failing to build on Ubuntu-18.04 because of the cmake version.
+Backport a patch to fix this.
+
+* gtk/jhbuild.modules:
+* gtk/patches/wpebackend-fdo-cmake-buildfix-3.10.patch: Added.
+* jhbuild/jhbuild-minimal.modules:
+* jhbuild/patches/wpebackend-fdo-cmake-buildfix-3.10.patch: Added.
+* wpe/jhbuild.modules:
+* wpe/patches/wpebackend-fdo-cmake-buildfix-3.10.patch: Added.
+
2020-10-21 Ryosuke Niwa
IPC testing API should have the capability to observe messages being sent and received
Modified: trunk/Tools/gtk/jhbuild.modules (268854 => 268855)
--- trunk/Tools/gtk/jhbuild.modules 2020-10-22 05:24:58 UTC (rev 268854)
+++ trunk/Tools/gtk/jhbuild.modules 2020-10-22 06:43:54 UTC (rev 268855)
@@ -483,7 +483,9 @@
repo="wpewebkit"
-hash="sha256:9652a99c75fe1c6eab0585b6395f4e104b2427e4d1f42969f1f77df29920d253"/>
+hash="sha256:9652a99c75fe1c6eab0585b6395f4e104b2427e4d1f42969f1f77df29920d253">
+
+
Added: trunk/Tools/jhbuild/patches/wpebackend-fdo-cmake-buildfix-3.10.patch (0 => 268855)
--- trunk/Tools/jhbuild/patches/wpebackend-fdo-cmake-buildfix-3.10.patch (rev 0)
+++ trunk/Tools/jhbuild/patches/wpebackend-fdo-cmake-buildfix-3.10.patch 2020-10-22 06:43:54 UTC (rev 268855)
@@ -0,0 +1,35 @@
+From 1d1a01452fb5df6c7cba1aff5a21636ab6cf838b Mon Sep 17 00:00:00 2001
+From: Carlos Alberto Lopez Perez
+Date: Mon, 19 Oct 2020 21:09:57 +0200
+Subject: [PATCH] cmake: use add_definitions instead of add_compile_definitions
+
+* add_compile_definitions() requires CMake 3.12, but Ubuntu-18.04
+ships CMake 3.10. This fixes the build for old CMake versions.
+---
+ CMakeLists.txt | 10 +-
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 16741f0..6920aaf 100644
+--- a/CMakeLists.txt
b/CMakeLists.txt
+@@ -45,11 +45,11 @@ find_package(Wayland REQUIRED client server egl)
+ find_package(WaylandScanner REQUIRED)
+ find_package(WPE 1.5.90 REQUIRED)
+
+-add_compile_definitions(
+-WPE_FDO_COMPILATION
+-G_LOG_DOMAIN=\"WPE-FDO\"
+-_FILE_OFFSET_BITS=64
+-_LARGEFILE64_SOURCE=1
++add_definitions(
++-DWPE_FDO_COMPILATION
++-DG_LOG_DOMAIN=\"WPE-FDO\"
++-D_FILE_OFFSET_BITS=64
++-D_LARGEFILE64_SOURCE=1
+ )
+
+ configure_file(include/wpe/version.h.cmake "${CMAKE_BINARY_DIR}/version.h" @ONLY)
+--
+2.20.1
+
Modified: trunk/Tools/wpe/jhbuild.modules (268854 => 268855)
--- trunk/Tools/wpe/jhbuild.modules 2020-10-22 05:24:58 UTC (rev 268854)
+++ trunk/Tools/wpe/jhbuild.modules 2020-10-22 06:43:54 UTC (rev 268855)
@@ -198,7 +198,9 @@
repo="wpewebkit"
-hash="sha256:9652a99c75fe1c6eab0585b6395f4e104b2427e4d1f42969f1f77df29920d253"/>
+hash="sha256:9652a99c75fe1c6eab0585b6395f4e104b2427e4d1f42969f1f77df29920d253">
+
+
Added: trunk/Tools/wpe/patches/wpebackend-fdo-cmake-buildfix-3.10.patch (0 => 268855)
--- trunk/Tools/wpe/patches/wpebackend-fdo-cmake-buildfix-3.10.patch (rev 0)
+++ trunk/Tools/wpe/patches/wpebackend-fdo-cmake-buildfix-3.10.patch 2020-10-22 06:43:54 UTC (rev 268855)
@@ -0,0 +1,35 @@
+From 1d1a01452fb5df6c7cba1aff5a21636ab6cf838b Mon Sep 17 00:00:00 2001
[webkit-changes] [268850] trunk/Source/WebCore
Title: [268850] trunk/Source/WebCore
Revision 268850
Author clo...@igalia.com
Date 2020-10-21 18:12:49 -0700 (Wed, 21 Oct 2020)
Log Message
REGRESSION(r268798): Fix build without ENABLE_LAYOUT_FORMATTING_CONTEXT
https://bugs.webkit.org/show_bug.cgi?id=218017
Unreviewed build-fix.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange): Add missing ifdef guards.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBox.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (268849 => 268850)
--- trunk/Source/WebCore/ChangeLog 2020-10-22 00:46:20 UTC (rev 268849)
+++ trunk/Source/WebCore/ChangeLog 2020-10-22 01:12:49 UTC (rev 268850)
@@ -1,3 +1,13 @@
+2020-10-21 Carlos Alberto Lopez Perez
+
+REGRESSION(r268798): Fix build without ENABLE_LAYOUT_FORMATTING_CONTEXT
+https://bugs.webkit.org/show_bug.cgi?id=218017
+
+Unreviewed build-fix.
+
+* rendering/RenderBox.cpp:
+(WebCore::RenderBox::styleDidChange): Add missing ifdef guards.
+
2020-10-21 Sam Weinig
Remove use of in-makefile grepping of FEATURE_AND_PLATFORM_DEFINES
Modified: trunk/Source/WebCore/rendering/RenderBox.cpp (268849 => 268850)
--- trunk/Source/WebCore/rendering/RenderBox.cpp 2020-10-22 00:46:20 UTC (rev 268849)
+++ trunk/Source/WebCore/rendering/RenderBox.cpp 2020-10-22 01:12:49 UTC (rev 268850)
@@ -409,10 +409,12 @@
if (isOutOfFlowPositioned() && parent() && parent()->style().isDisplayFlexibleOrGridBox())
clearOverrideContentSize();
+#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
if (diff == StyleDifference::Layout) {
if (auto* lineLayout = LayoutIntegration::LineLayout::containing(*this))
lineLayout->updateStyle(*this);
}
+#endif
}
void RenderBox::updateGridPositionAfterStyleChange(const RenderStyle& style, const RenderStyle* oldStyle)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268827] trunk/Tools
Title: [268827] trunk/Tools
Revision 268827
Author clo...@igalia.com
Date 2020-10-21 14:37:25 -0700 (Wed, 21 Oct 2020)
Log Message
update-webkitgtk-libs and run-webkit-tests fail silently if flatpak has problems updating
https://bugs.webkit.org/show_bug.cgi?id=218047
Reviewed by Philippe Normand.
This scripts were returning zero status when flatpak failed to
update in some cases. Fix them to return a non-zero status.
* Scripts/update-webkit-flatpak: Add missing sys.exit call with the return code.
* flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox): In python false is zero when casted to int.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-flatpak
trunk/Tools/flatpak/flatpakutils.py
Diff
Modified: trunk/Tools/ChangeLog (268826 => 268827)
--- trunk/Tools/ChangeLog 2020-10-21 21:33:05 UTC (rev 268826)
+++ trunk/Tools/ChangeLog 2020-10-21 21:37:25 UTC (rev 268827)
@@ -1,3 +1,17 @@
+2020-10-21 Carlos Alberto Lopez Perez
+
+update-webkitgtk-libs and run-webkit-tests fail silently if flatpak has problems updating
+https://bugs.webkit.org/show_bug.cgi?id=218047
+
+Reviewed by Philippe Normand.
+
+This scripts were returning zero status when flatpak failed to
+update in some cases. Fix them to return a non-zero status.
+
+* Scripts/update-webkit-flatpak: Add missing sys.exit call with the return code.
+* flatpak/flatpakutils.py:
+(WebkitFlatpak.run_in_sandbox): In python false is zero when casted to int.
+
2020-10-21 Lauro Moura
webkitpy: Check for duplicated keys in json expectation files
Modified: trunk/Tools/Scripts/update-webkit-flatpak (268826 => 268827)
--- trunk/Tools/Scripts/update-webkit-flatpak 2020-10-21 21:33:05 UTC (rev 268826)
+++ trunk/Tools/Scripts/update-webkit-flatpak 2020-10-21 21:37:25 UTC (rev 268827)
@@ -25,4 +25,4 @@
from flatpakutils import WebkitFlatpak
if __name__ == "__main__":
-WebkitFlatpak.load_from_args(["--update"] + sys.argv[1:]).run()
+sys.exit(WebkitFlatpak.load_from_args(["--update"] + sys.argv[1:]).run())
Modified: trunk/Tools/flatpak/flatpakutils.py (268826 => 268827)
--- trunk/Tools/flatpak/flatpakutils.py 2020-10-21 21:33:05 UTC (rev 268826)
+++ trunk/Tools/flatpak/flatpakutils.py 2020-10-21 21:37:25 UTC (rev 268827)
@@ -659,7 +659,7 @@
def run_in_sandbox(self, *args, **kwargs):
if not self.setup_builddir():
-return False
+return 1
cwd = kwargs.get("cwd", None)
extra_env_vars = kwargs.get("env", {})
stdout = kwargs.get("stdout", sys.stdout)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268591] trunk/Tools
Title: [268591] trunk/Tools Revision 268591 Author clo...@igalia.com Date 2020-10-16 08:27:18 -0700 (Fri, 16 Oct 2020) Log Message [JHBuild] Update libwpe and wpebackend-fdo and add libmanette to minimal moduleset https://bugs.webkit.org/show_bug.cgi?id=217825 Reviewed by Adrian Perez de Castro. libmanette 0.2.4 is required for enabling gamepad support, which defaults to on since r268389 for developer builds. The version shipped by ubuntu-20.04 is not enough (0.2.3), so we should include this on the minimal moduleset which is used to generate the bundle products on the packaging bots. Seize to also update the libwpe and wpebackend-fdo libraries. * gtk/jhbuild.modules: * jhbuild/jhbuild-minimal.modules: * wpe/jhbuild.modules: Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/jhbuild.modules trunk/Tools/jhbuild/jhbuild-minimal.modules trunk/Tools/wpe/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (268590 => 268591) --- trunk/Tools/ChangeLog 2020-10-16 15:22:48 UTC (rev 268590) +++ trunk/Tools/ChangeLog 2020-10-16 15:27:18 UTC (rev 268591) @@ -1,3 +1,22 @@ +2020-10-16 Carlos Alberto Lopez Perez + +[JHBuild] Update libwpe and wpebackend-fdo and add libmanette to minimal moduleset +https://bugs.webkit.org/show_bug.cgi?id=217825 + +Reviewed by Adrian Perez de Castro. + +libmanette 0.2.4 is required for enabling gamepad support, which +defaults to on since r268389 for developer builds. The version +shipped by ubuntu-20.04 is not enough (0.2.3), so we should include +this on the minimal moduleset which is used to generate the bundle +products on the packaging bots. + +Seize to also update the libwpe and wpebackend-fdo libraries. + +* gtk/jhbuild.modules: +* jhbuild/jhbuild-minimal.modules: +* wpe/jhbuild.modules: + 2020-10-16 Sam Sneddon Match webkitpy.port.base.Port's merging of .webarchive/.txt Modified: trunk/Tools/gtk/jhbuild.modules (268590 => 268591) --- trunk/Tools/gtk/jhbuild.modules 2020-10-16 15:22:48 UTC (rev 268590) +++ trunk/Tools/gtk/jhbuild.modules 2020-10-16 15:27:18 UTC (rev 268591) @@ -470,8 +470,9 @@ - + @@ -480,8 +481,9 @@ - + - + @@ -72,7 +73,9 @@ - + @@ -96,6 +99,16 @@ hash="sha256:f8fd0aeb66252dfcc638f14d9be1e2362fdaf2ca86bde0444ff4d5cc961b560f"/> + + +manette-0.2.pc + + + + Modified: trunk/Tools/wpe/jhbuild.modules (268590 => 268591) --- trunk/Tools/wpe/jhbuild.modules 2020-10-16 15:22:48 UTC (rev 268590) +++ trunk/Tools/wpe/jhbuild.modules 2020-10-16 15:27:18 UTC (rev 268591) @@ -186,9 +186,9 @@ - + @@ -196,7 +196,9 @@ - + ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [268581] trunk/Tools
Title: [268581] trunk/Tools
Revision 268581
Author clo...@igalia.com
Date 2020-10-16 05:33:52 -0700 (Fri, 16 Oct 2020)
Log Message
Ensure the tests are run with US/Pacific time zone
https://bugs.webkit.org/show_bug.cgi?id=186612
Reviewed by Michael Catanzaro.
Some tests fail if the time zone is not set to US/Pacific, and
this causes issues for contributors living outside of that timezone.
Ideally we should fix those tests, but in the meantime setting this
environment variable before starting the layout tests seems like
an acceptable workaround. Note that something similar is also
already done for the JSC tests.
* Scripts/webkitpy/port/base.py:
(Port.setup_environ_for_server):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/base.py
Diff
Modified: trunk/Tools/ChangeLog (268580 => 268581)
--- trunk/Tools/ChangeLog 2020-10-16 12:33:15 UTC (rev 268580)
+++ trunk/Tools/ChangeLog 2020-10-16 12:33:52 UTC (rev 268581)
@@ -1,3 +1,20 @@
+2020-10-16 Carlos Alberto Lopez Perez
+
+Ensure the tests are run with US/Pacific time zone
+https://bugs.webkit.org/show_bug.cgi?id=186612
+
+Reviewed by Michael Catanzaro.
+
+Some tests fail if the time zone is not set to US/Pacific, and
+this causes issues for contributors living outside of that timezone.
+Ideally we should fix those tests, but in the meantime setting this
+environment variable before starting the layout tests seems like
+an acceptable workaround. Note that something similar is also
+already done for the JSC tests.
+
+* Scripts/webkitpy/port/base.py:
+(Port.setup_environ_for_server):
+
2020-10-15 Sam Weinig
Attempt to fix the build.
Modified: trunk/Tools/Scripts/webkitpy/port/base.py (268580 => 268581)
--- trunk/Tools/Scripts/webkitpy/port/base.py 2020-10-16 12:33:15 UTC (rev 268580)
+++ trunk/Tools/Scripts/webkitpy/port/base.py 2020-10-16 12:33:52 UTC (rev 268581)
@@ -930,6 +930,9 @@
[name, value] = string_variable.split('=', 1)
clean_env[name] = value
+# FIXME: Some tests fail if the time zone is not set to US/Pacific ()
+clean_env['TZ'] = 'US/Pacific'
+
return clean_env
def _clear_global_caches_and_temporary_files(self):
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266267] trunk/Tools
Title: [266267] trunk/Tools Revision 266267 Author clo...@igalia.com Date 2020-08-27 19:00:34 -0700 (Thu, 27 Aug 2020) Log Message [webkitpy] repository svn version is incorrect when working on a branch https://bugs.webkit.org/show_bug.cgi?id=215863 Reviewed by Jonathan Bedard. When working on a SVN branch, the information pointed in the Revision field doesn't reflect the last change on the branch, but the last change on trunk. Instead of picking that changeset, pick the "Last Changed Rev" one that should reflect the last change done in the current checkout (working directory). * Scripts/webkitpy/common/checkout/scm/svn.py: (SVN.svn_revision): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py Diff Modified: trunk/Tools/ChangeLog (266266 => 266267) --- trunk/Tools/ChangeLog 2020-08-28 01:24:15 UTC (rev 266266) +++ trunk/Tools/ChangeLog 2020-08-28 02:00:34 UTC (rev 266267) @@ -1,3 +1,18 @@ +2020-08-27 Carlos Alberto Lopez Perez + +[webkitpy] repository svn version is incorrect when working on a branch +https://bugs.webkit.org/show_bug.cgi?id=215863 + +Reviewed by Jonathan Bedard. + +When working on a SVN branch, the information pointed in the Revision field +doesn't reflect the last change on the branch, but the last change on trunk. +Instead of picking that changeset, pick the "Last Changed Rev" one that should +reflect the last change done in the current checkout (working directory). + +* Scripts/webkitpy/common/checkout/scm/svn.py: +(SVN.svn_revision): + 2020-08-27 Devin Rousso [iOS] provide a way to get previously inserted alternatives for the selected text Modified: trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py (266266 => 266267) --- trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py 2020-08-28 01:24:15 UTC (rev 266266) +++ trunk/Tools/Scripts/webkitpy/common/checkout/scm/svn.py 2020-08-28 02:00:34 UTC (rev 266267) @@ -274,7 +274,7 @@ return "svn" def svn_revision(self, path): -return self.value_from_svn_info(path, 'Revision') +return self.value_from_svn_info(path, 'Last Changed Rev') def svn_branch(self, path): relative_url = self.value_from_svn_info(path, 'Relative URL')[2:] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266208] trunk/Tools
Title: [266208] trunk/Tools
Revision 266208
Author clo...@igalia.com
Date 2020-08-26 17:10:05 -0700 (Wed, 26 Aug 2020)
Log Message
[GTK][WPE] Add bots for generating nightly bundle packages
https://bugs.webkit.org/show_bug.cgi?id=215623
Reviewed by Aakash Jain.
This adds a new type of bots for GTK and WPE that runs nightly (once per day).
The goal of this bots its to build WebKit for a specific distribution (Ubuntu LTS and LTS-1)
and generate a bundle with the result of the build. The bundles are then uploaded to a
server for consumption on other CIs like WPT.
The MiniBrowser bundle targets a specific distribution, so each one of this new bots has to
run the generate-minibrowser-bundle step. However, the JSC bundle is distro-agnostic because
for JSC is possible to bundle all the system libraries (similar to a static build).
That means that we only need to run the step generate-jsc-bundle in one of the bots.
This step for generating the JSC bundle was previously executed in the bot
'GTK Linux 64-bit Release (Build)'. This patch moves it to one of this new added bots.
* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/factories.py:
(BuildFactory):
(BuildFactory.__init__):
(TestFactory):
(TestFactory.__init__):
(BuildAndGenerateMiniBrowserBundleFactory):
(BuildAndGenerateMiniBrowserJSCBundleFactory):
* BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
* BuildSlaveSupport/build.webkit.org-config/steps.py:
(GenerateJSCBundle):
(GenerateMiniBrowserBundle):
* BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/factories.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/loadConfig.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (266207 => 266208)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2020-08-27 00:08:22 UTC (rev 266207)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json 2020-08-27 00:10:05 UTC (rev 266208)
@@ -88,6 +88,8 @@
{ "name": "gtk-linux-bot-13", "platform": "gtk" },
{ "name": "gtk-linux-bot-14", "platform": "gtk" },
{ "name": "gtk-linux-bot-15", "platform": "gtk" },
+{ "name": "gtk-linux-bot-16", "platform": "gtk" },
+{ "name": "gtk-linux-bot-17", "platform": "gtk" },
{ "name": "jsconly-linux-igalia-bot-1", "platform": "jsc-only" },
{ "name": "jsconly-linux-igalia-bot-2", "platform": "jsc-only" },
@@ -100,7 +102,9 @@
{ "name": "wpe-linux-bot-3", "platform": "wpe" },
{ "name": "wpe-linux-bot-4", "platform": "wpe" },
{ "name": "wpe-linux-bot-5", "platform": "wpe" },
-{ "name": "wpe-linux-bot-6", "platform": "wpe" }
+{ "name": "wpe-linux-bot-6", "platform": "wpe" },
+{ "name": "wpe-linux-bot-7", "platform": "wpe" },
+{ "name": "wpe-linux-bot-8", "platform": "wpe" }
],
"builders": [
@@ -288,7 +292,7 @@
"slavenames": ["bot545"]
},
{
- "name": "GTK Linux 64-bit Release (Build)", "type": "BuildAndGenerateJSCBundle", "builddir": "gtk-linux-64-release",
+ "name": "GTK Linux 64-bit Release (Build)", "type": "Build", "builddir": "gtk-linux-64-release",
"platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
"triggers": ["gtk-linux-64-release-tests", "gtk-linux-64-release-tests-js", "gtk-linux-64-release-tests-webdriver",
"gtk-linux-64-release-wayland-tests", "gtk-linux-64-release-perf-tests"],
@@ -355,6 +359,18 @@
"slavenames": ["gtk-linux-slave-11"]
},
{
+ "name": "GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu1804", "type": "BuildAndGenerateMiniBrowserBundle", "builddir": "gtk-linux-64-packaging-nigthly-ubuntu1804",
+ "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+ "additionalArguments": ["--no-bubblewrap-sandbox"],
+ "slavenames": ["gtk-linux-bot-16"]
+},
+{
+ "name": "GTK-Linux-64bit-Release-Packaging-Nightly-Ubuntu2004", "type": "BuildAndGenerateMiniBrowserJSCBundle", "builddir": "gtk-linux-64-packaging-nigthly-ubuntu2004",
+ "platform": "gtk", "configuration": "release",
[webkit-changes] [266154] trunk/Tools
Title: [266154] trunk/Tools
Revision 266154
Author clo...@igalia.com
Date 2020-08-25 17:08:37 -0700 (Tue, 25 Aug 2020)
Log Message
[GTK][WPE] Add a script for generating MiniBrowser bundles (follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=215266
Unreviewed follow-up fix.
Ensure the install-dependencies script of the bundle calls apt-get update
before trying to install the system packages when --autoinstall is passed.
* Scripts/generate-bundle:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-bundle
Diff
Modified: trunk/Tools/ChangeLog (266153 => 266154)
--- trunk/Tools/ChangeLog 2020-08-25 23:55:22 UTC (rev 266153)
+++ trunk/Tools/ChangeLog 2020-08-26 00:08:37 UTC (rev 266154)
@@ -1,3 +1,15 @@
+2020-08-25 Carlos Alberto Lopez Perez
+
+[GTK][WPE] Add a script for generating MiniBrowser bundles (follow-up fix)
+https://bugs.webkit.org/show_bug.cgi?id=215266
+
+Unreviewed follow-up fix.
+
+Ensure the install-dependencies script of the bundle calls apt-get update
+before trying to install the system packages when --autoinstall is passed.
+
+* Scripts/generate-bundle:
+
2020-08-25 Alex Christensen
Remove unneeded HAVE(NETWORK_FRAMEWORK) macro
Modified: trunk/Tools/Scripts/generate-bundle (266153 => 266154)
--- trunk/Tools/Scripts/generate-bundle 2020-08-25 23:55:22 UTC (rev 266153)
+++ trunk/Tools/Scripts/generate-bundle 2020-08-26 00:08:37 UTC (rev 266154)
@@ -67,12 +67,17 @@
if [[ -z "${TOINSTALL}" ]]; then
echo "All required dependencies are already installed"
else
+echo "Need to install the following extra packages: ${TOINSTALL}"
+[[ ${#} -gt 0 ]] && [[ "${1}" == "--printonly" ]] && exit 0
+SUDO=""
+[[ ${UID} -ne 0 ]] && SUDO="sudo"
AUTOINSTALL=""
-[[ ${#} -gt 0 ]] && [[ "${1}" == "--autoinstall" ]] && AUTOINSTALL="-y" && export DEBIAN_FRONTEND="noninteractive"
-SUDO=""
-[[ ${UID} -ne 0 ]] && SUDO="sudo --preserve-env=DEBIAN_FRONTEND"
-
-echo "Need to install the following extra packages: ${TOINSTALL}"
+if [[ ${#} -gt 0 ]] && [[ "${1}" == "--autoinstall" ]]; then
+AUTOINSTALL="-y"
+export DEBIAN_FRONTEND="noninteractive"
+[[ ${UID} -ne 0 ]] && SUDO="sudo --preserve-env=DEBIAN_FRONTEND"
+${SUDO} apt-get update
+fi
set -x
${SUDO} apt-get install --no-install-recommends ${AUTOINSTALL} ${TOINSTALL}
fi
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [266141] trunk
Title: [266141] trunk
Revision 266141
Author clo...@igalia.com
Date 2020-08-25 13:20:59 -0700 (Tue, 25 Aug 2020)
Log Message
[WPE][Qt] Fix qt-wpe-minibrowser on Debian10
https://bugs.webkit.org/show_bug.cgi?id=215730
Reviewed by Philippe Normand.
Source/WebKit:
QWheelEvent position is not available on Qt < 5.14. Use posF instead in that case.
Tested with Qt 5.11
No new tests, is a build fix.
* UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:
(WPEQtViewBackend::dispatchWheelEvent):
Tools:
When not running in flatpak the path to the qml directory is different.
* Scripts/run-qt-wpe-minibrowser:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-qt-wpe-minibrowser
Diff
Modified: trunk/Source/WebKit/ChangeLog (266140 => 266141)
--- trunk/Source/WebKit/ChangeLog 2020-08-25 19:09:16 UTC (rev 266140)
+++ trunk/Source/WebKit/ChangeLog 2020-08-25 20:20:59 UTC (rev 266141)
@@ -1,3 +1,18 @@
+2020-08-25 Carlos Alberto Lopez Perez
+
+[WPE][Qt] Fix qt-wpe-minibrowser on Debian10
+https://bugs.webkit.org/show_bug.cgi?id=215730
+
+Reviewed by Philippe Normand.
+
+QWheelEvent position is not available on Qt < 5.14. Use posF instead in that case.
+Tested with Qt 5.11
+
+No new tests, is a build fix.
+
+* UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:
+(WPEQtViewBackend::dispatchWheelEvent):
+
2020-08-25 Jer Noble
[Mac] REGRESSION(r262322): Focusable elements are focused when exiting from video fullscreen mode.
Modified: trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp (266140 => 266141)
--- trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp 2020-08-25 19:09:16 UTC (rev 266140)
+++ trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp 2020-08-25 20:20:59 UTC (rev 266141)
@@ -24,6 +24,7 @@
#include "WPEQtView.h"
#include
#include
+#include
static PFNGLEGLIMAGETARGETTEXTURE2DOESPROC imageTargetTexture2DOES;
@@ -297,18 +298,24 @@
wpe_view_backend_dispatch_pointer_event(backend(), );
}
+#if (QT_VERSION >= QT_VERSION_CHECK(5, 14, 0))
+#define QWHEEL_POSITION position()
+#else
+#define QWHEEL_POSITION posF()
+#endif
+
void WPEQtViewBackend::dispatchWheelEvent(QWheelEvent* event)
{
QPoint delta = event->angleDelta();
QPoint numDegrees = delta / 8;
struct wpe_input_axis_2d_event wpeEvent;
-if (delta.y() == event->position().y())
+if (delta.y() == event->QWHEEL_POSITION.y())
wpeEvent.x_axis = numDegrees.x();
else
wpeEvent.y_axis = numDegrees.y();
wpeEvent.base.type = static_cast(wpe_input_axis_event_type_mask_2d | wpe_input_axis_event_type_motion_smooth);
-wpeEvent.base.x = event->position().x();
-wpeEvent.base.y = event->position().y();
+wpeEvent.base.x = event->QWHEEL_POSITION.x();
+wpeEvent.base.y = event->QWHEEL_POSITION.y();
wpe_view_backend_dispatch_axis_event(backend(), );
}
Modified: trunk/Tools/ChangeLog (266140 => 266141)
--- trunk/Tools/ChangeLog 2020-08-25 19:09:16 UTC (rev 266140)
+++ trunk/Tools/ChangeLog 2020-08-25 20:20:59 UTC (rev 266141)
@@ -1,3 +1,14 @@
+2020-08-25 Carlos Alberto Lopez Perez
+
+[WPE][Qt] Fix qt-wpe-minibrowser on Debian10
+https://bugs.webkit.org/show_bug.cgi?id=215730
+
+Reviewed by Philippe Normand.
+
+When not running in flatpak the path to the qml directory is different.
+
+* Scripts/run-qt-wpe-minibrowser:
+
2020-08-25 Devin Rousso
REGRESSION(r265601): invalid blame URL copied when `include_revision` is `false`
Modified: trunk/Tools/Scripts/run-qt-wpe-minibrowser (266140 => 266141)
--- trunk/Tools/Scripts/run-qt-wpe-minibrowser 2020-08-25 19:09:16 UTC (rev 266140)
+++ trunk/Tools/Scripts/run-qt-wpe-minibrowser 2020-08-25 20:20:59 UTC (rev 266141)
@@ -50,7 +50,14 @@
checkFrameworks();
if (!inFlatpakSandbox()) {
-$libPath = "$productDir/lib/qml" if $productDir;
+if ($productDir) {
+for my $qmlsubdir ("lib/qml", "lib/qt5/qml") {
+if (-d "$productDir/$qmlsubdir") {
+$libPath = "$productDir/$qmlsubdir";
+last;
+}
+}
+}
$ENV{"QML2_IMPORT_PATH"} = "$libPath" if $libPath;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [265606] trunk/Tools
Title: [265606] trunk/Tools
Revision 265606
Author clo...@igalia.com
Date 2020-08-13 08:35:18 -0700 (Thu, 13 Aug 2020)
Log Message
[GTK][WPE] Add a script for generating MiniBrowser bundles
https://bugs.webkit.org/show_bug.cgi?id=215266
Reviewed by Carlos Garcia Campos.
This converts the previous generate-jsc-bundle into a new script
that is now able to do the following:
- generate a jsc bundle
- generate a MiniBrowse bundle
- generate an all bundle (jsc+MiniBrowser)
The bundle can include all the system-libraries from the system,
so that way (in theory) the bundle would run on any other distribution
or it can generate an install-dependencies script so it generates
a lightweight bundle with only the minimum libraries included that
would run only on the distribution where it has been created
(after running the install-dependencies script)
We already have a bot generating the jsc bundle and we plan to also
have bots for generating the MiniBrowser bundles as well.
* BuildSlaveSupport/build.webkit.org-config/steps.py: Update the step for the new command.
(GenerateJSCBundle):
* Scripts/generate-bundle: Added.
* Scripts/generate-jsc-bundle: Removed.
* jhbuild/jhbuildutils.py:
(enter_jhbuild_environment_if_available): Unicode argument not longer available on python3's gettext.install()
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/ChangeLog
trunk/Tools/jhbuild/jhbuildutils.py
Added Paths
trunk/Tools/Scripts/generate-bundle
Removed Paths
trunk/Tools/Scripts/generate-jsc-bundle
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (265605 => 265606)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2020-08-13 15:23:03 UTC (rev 265605)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2020-08-13 15:35:18 UTC (rev 265606)
@@ -301,9 +301,10 @@
class GenerateJSCBundle(shell.ShellCommand):
-command = ["python", "./Tools/Scripts/generate-jsc-bundle", "--builder-name", WithProperties("%(buildername)s"),
- WithProperties("--platform=%(fullPlatform)s"), WithProperties("--%(configuration)s"),
- WithProperties("--revision=%(got_revision)s"), "--remote-config-file", "../../remote-jsc-bundle-upload-config.json"]
+command = ["./Tools/Scripts/generate-bundle", "--builder-name", WithProperties("%(buildername)s"),
+ "--bundle=jsc", "--syslibs=bundle-all", WithProperties("--platform=%(fullPlatform)s"),
+ WithProperties("--%(configuration)s"), WithProperties("--revision=%(got_revision)s"),
+ "--remote-config-file", "../../remote-jsc-bundle-upload-config.json"]
name = "generate-jsc-bundle"
description = ["generating jsc bundle"]
descriptionDone = ["generated jsc bundle"]
Modified: trunk/Tools/ChangeLog (265605 => 265606)
--- trunk/Tools/ChangeLog 2020-08-13 15:23:03 UTC (rev 265605)
+++ trunk/Tools/ChangeLog 2020-08-13 15:35:18 UTC (rev 265606)
@@ -1,3 +1,32 @@
+2020-08-13 Carlos Alberto Lopez Perez
+
+[GTK][WPE] Add a script for generating MiniBrowser bundles
+https://bugs.webkit.org/show_bug.cgi?id=215266
+
+Reviewed by Carlos Garcia Campos.
+
+This converts the previous generate-jsc-bundle into a new script
+that is now able to do the following:
+ - generate a jsc bundle
+ - generate a MiniBrowse bundle
+ - generate an all bundle (jsc+MiniBrowser)
+The bundle can include all the system-libraries from the system,
+so that way (in theory) the bundle would run on any other distribution
+or it can generate an install-dependencies script so it generates
+a lightweight bundle with only the minimum libraries included that
+would run only on the distribution where it has been created
+(after running the install-dependencies script)
+
+We already have a bot generating the jsc bundle and we plan to also
+have bots for generating the MiniBrowser bundles as well.
+
+* BuildSlaveSupport/build.webkit.org-config/steps.py: Update the step for the new command.
+(GenerateJSCBundle):
+* Scripts/generate-bundle: Added.
+* Scripts/generate-jsc-bundle: Removed.
+* jhbuild/jhbuildutils.py:
+(enter_jhbuild_environment_if_available): Unicode argument not longer available on python3's gettext.install()
+
2020-08-12 Keith Rollin
Remove the need for defining USE_NEW_BUILD_SYSTEM
Added: trunk/Tools/Scripts/generate-bundle (0 => 265606)
--- trunk/Tools/Scripts/generate-bundle (rev 0)
+++ trunk/Tools/Scripts/generate-bundle 2020-08-13 15:35:18 UTC (rev 265606)
@@ -0,0 +1,642 @@
+#!/usr/bin/env python3
+#
+# Copyright (C) 2018, 2020 Igalia S.L.
+#
+# Redistribution and use in source and binary forms, with or without
+# modification, are permitted provided that the following conditions are met:
+#
+# 1.
[webkit-changes] [264463] trunk/LayoutTests
Title: [264463] trunk/LayoutTests Revision 264463 Author clo...@igalia.com Date 2020-07-16 09:38:38 -0700 (Thu, 16 Jul 2020) Log Message Update WPT tests for css-writing-modes (follow-up fix) https://bugs.webkit.org/show_bug.cgi?id=214278 Unreviewed follow-up to r264337. LayoutTests/imported/w3c: Add missing binary files from r264337. The files were recorded on the import log but I messed it up by not passing --binary when generating the patch. * web-platform-tests/css/css-writing-modes/support/blue-200x100.png: Added. * web-platform-tests/css/css-writing-modes/support/mn+arabic.png: Added. * web-platform-tests/css/css-writing-modes/support/mn+latin.png: Added. * web-platform-tests/css/css-writing-modes/support/mn-orientation.png: Added. * web-platform-tests/css/css-writing-modes/support/mn_ar_wrap.png: Added. * web-platform-tests/css/css-writing-modes/support/mn_en_wrap.png: Added. * web-platform-tests/css/css-writing-modes/support/wm-propagation-body-035-exp-res.png: Added. * web-platform-tests/css/css-writing-modes/support/world.png: Added. * web-platform-tests/css/css-writing-modes/support/zh+arabic.png: Added. * web-platform-tests/css/css-writing-modes/support/zh+latin.png: Added. * web-platform-tests/css/css-writing-modes/support/zh-orientation.png: Added. * web-platform-tests/css/css-writing-modes/support/zh_ar_wrap.png: Added. * web-platform-tests/css/css-writing-modes/support/zh_en_wrap.png: Added. LayoutTests: * TestExpectations: Update expectation for test passing now. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog Added Paths trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/blue-200x100.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/mn+arabic.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/mn+latin.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/mn-orientation.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/mn_ar_wrap.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/mn_en_wrap.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/wm-propagation-body-035-exp-res.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/world.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/zh+arabic.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/zh+latin.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/zh-orientation.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/zh_ar_wrap.png trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-writing-modes/support/zh_en_wrap.png Diff Modified: trunk/LayoutTests/ChangeLog (264462 => 264463) --- trunk/LayoutTests/ChangeLog 2020-07-16 16:29:25 UTC (rev 264462) +++ trunk/LayoutTests/ChangeLog 2020-07-16 16:38:38 UTC (rev 264463) @@ -1,3 +1,12 @@ +2020-07-16 Carlos Alberto Lopez Perez + +Update WPT tests for css-writing-modes (follow-up fix) +https://bugs.webkit.org/show_bug.cgi?id=214278 + +Unreviewed follow-up to r264337. + +* TestExpectations: Update expectation for test passing now. + 2020-07-16 Hector Lopez [ macOS wk2 ] REGRESSION(r263485): fast/scrolling/mac/scroll-snapping-in-progress.html is a flaky failure Modified: trunk/LayoutTests/TestExpectations (264462 => 264463) --- trunk/LayoutTests/TestExpectations 2020-07-16 16:29:25 UTC (rev 264462) +++ trunk/LayoutTests/TestExpectations 2020-07-16 16:38:38 UTC (rev 264463) @@ -4399,8 +4399,6 @@ webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/baseline-with-orthogonal-flow-001.html [ ImageOnlyFailure ] webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/direction-upright-001.html [ ImageOnlyFailure ] webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/direction-upright-002.html [ ImageOnlyFailure ] -webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/img-intrinsic-size-contribution-001.html [ ImageOnlyFailure ] -webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/img-intrinsic-size-contribution-002.html [ ImageOnlyFailure ] webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/inline-box-border-vlr-001.html [ ImageOnlyFailure ] webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/slr-alongside-vlr-floats.html [ ImageOnlyFailure ] webkit.org/b/214291 imported/w3c/web-platform-tests/css/css-writing-modes/srl-alongside-vrl-floats.html [ ImageOnlyFailure ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (264462 => 264463) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-07-16 16:29:25 UTC (rev 264462) +++
[webkit-changes] [264404] trunk/Tools
Title: [264404] trunk/Tools
Revision 264404
Author clo...@igalia.com
Date 2020-07-15 10:34:44 -0700 (Wed, 15 Jul 2020)
Log Message
build-webkit script tries to execute command xcodebuild on Linux
https://bugs.webkit.org/show_bug.cgi?id=214353
Reviewed by Jonathan Bedard.
Recently, when running the script build-webkit on Linux the following warning is printed:
Can't exec "xcodebuild": No such file or directory at Tools/Scripts/webkitdirs.pm line 602
To fix this, change the code to only call the function determineXcodeSDK() when
building for an Apple/Cocoa platform.
* Scripts/webkitdirs.pm:
(determineArchitecture):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm
Diff
Modified: trunk/Tools/ChangeLog (264403 => 264404)
--- trunk/Tools/ChangeLog 2020-07-15 17:26:41 UTC (rev 264403)
+++ trunk/Tools/ChangeLog 2020-07-15 17:34:44 UTC (rev 264404)
@@ -1,3 +1,19 @@
+2020-07-15 Carlos Alberto Lopez Perez
+
+build-webkit script tries to execute command xcodebuild on Linux
+https://bugs.webkit.org/show_bug.cgi?id=214353
+
+Reviewed by Jonathan Bedard.
+
+Recently, when running the script build-webkit on Linux the following warning is printed:
+Can't exec "xcodebuild": No such file or directory at Tools/Scripts/webkitdirs.pm line 602
+
+To fix this, change the code to only call the function determineXcodeSDK() when
+building for an Apple/Cocoa platform.
+
+* Scripts/webkitdirs.pm:
+(determineArchitecture):
+
2020-07-15 Jim Mason
[WTF] Fix PackedAlignedPtr for X86_64 canonical addresses
Modified: trunk/Tools/Scripts/webkitdirs.pm (264403 => 264404)
--- trunk/Tools/Scripts/webkitdirs.pm 2020-07-15 17:26:41 UTC (rev 264403)
+++ trunk/Tools/Scripts/webkitdirs.pm 2020-07-15 17:34:44 UTC (rev 264404)
@@ -388,10 +388,10 @@
return if defined $architecture;
determineBaseProductDir();
-determineXcodeSDK();
$architecture = nativeArchitecture();
if (isAppleCocoaWebKit()) {
+determineXcodeSDK();
if (open ARCHITECTURE, "$baseProductDir/Architecture") {
$architecture = ;
close ARCHITECTURE;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [264354] trunk/LayoutTests
Title: [264354] trunk/LayoutTests Revision 264354 Author clo...@igalia.com Date 2020-07-14 11:01:11 -0700 (Tue, 14 Jul 2020) Log Message [GTK] Gardening after r264345 Unreviewed gardening. Add GTK baselines for new tests added. * platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-without-codecs-parameter-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-expected.txt: Added. * platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported-expected.txt: * platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-expected.txt: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported-expected.txt Added Paths trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-without-codecs-parameter-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-expected.txt trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (264353 => 264354) --- trunk/LayoutTests/ChangeLog 2020-07-14 17:59:12 UTC (rev 264353) +++ trunk/LayoutTests/ChangeLog 2020-07-14 18:01:11 UTC (rev 264354) @@ -1,3 +1,18 @@ +2020-07-14 Carlos Alberto Lopez Perez + +[GTK] Gardening after r264345 + +Unreviewed gardening. + +Add GTK baselines for new tests added. + +* platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-negative-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-without-codecs-parameter-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-getvideoplaybackquality-expected.txt: Added. +* platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported-expected.txt: +* platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode-expected.txt: Added. + 2020-07-14 Zalan Bujtas Use "font-family: Ahem" to improve coverage. Added: trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt (0 => 264354) --- trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt (rev 0) +++ trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/media-source/mediasource-changetype-play-implicit-expected.txt 2020-07-14 18:01:11 UTC (rev 264354) @@ -0,0 +1,17 @@ + +PASS Check if browser supports enough test media types and pairs of audio-only or video-only media with same bytestream format +PASS Test audio-only implicit changeType for audio/webm; codecs="vorbis" <-> audio/webm; codecs="vorbis" +PASS Test audio-only implicit changeType for audio/webm; codecs="vorbis" <-> audio/webm; codecs="vorbis" (using types without codecs parameters for addSourceBuffer) +PASS Test audio-only implicit changeType for audio/mp4; codecs="mp4a.40.2" <-> audio/mp4; codecs="mp4a.40.2" +PASS Test audio-only implicit changeType for audio/mp4; codecs="mp4a.40.2" <-> audio/mp4; codecs="mp4a.40.2" (using types without codecs parameters for addSourceBuffer) +PASS Test video-only implicit changeType for video/webm; codecs="vp8" <-> video/webm; codecs="vp8" +PASS Test video-only implicit changeType for video/webm; codecs="vp8" <-> video/webm; codecs="vp8" (using types without codecs parameters for addSourceBuffer) +FAIL Test video-only implicit changeType for video/webm; codecs="vp8" <-> video/webm; codecs="vp9" assert_unreached: Unexpected event 'error' Reached unreachable code +FAIL Test video-only implicit changeType for video/webm; codecs="vp8" <-> video/webm; codecs="vp9" (using types without codecs parameters for addSourceBuffer) assert_unreached: Unexpected event 'error' Reached unreachable code +FAIL Test video-only implicit changeType for video/webm; codecs="vp9" <-> video/webm; codecs="vp8" assert_unreached: Unexpected event 'error' Reached unreachable
[webkit-changes] [264339] trunk/LayoutTests
Title: [264339] trunk/LayoutTests
Revision 264339
Author clo...@igalia.com
Date 2020-07-14 08:32:51 -0700 (Tue, 14 Jul 2020)
Log Message
WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
https://bugs.webkit.org/show_bug.cgi?id=214301
Reviewed by Manuel Rego Casasnovas.
LayoutTests/imported/w3c:
Import commit 4b5101fabe from WPT.
* web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt:
* web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html:
LayoutTests:
Remove platform-specific expectations not longer needed.
* platform/gtk/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
* platform/wpe/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt
trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html
Removed Paths
trunk/LayoutTests/platform/gtk/imported/w3c/web-platform-tests/css/css-grid/
trunk/LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-grid/
trunk/LayoutTests/platform/wpe/imported/w3c/web-platform-tests/css/css-grid/
Diff
Modified: trunk/LayoutTests/ChangeLog (264338 => 264339)
--- trunk/LayoutTests/ChangeLog 2020-07-14 14:06:17 UTC (rev 264338)
+++ trunk/LayoutTests/ChangeLog 2020-07-14 15:32:51 UTC (rev 264339)
@@ -1,5 +1,18 @@
2020-07-14 Carlos Alberto Lopez Perez
+WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
+https://bugs.webkit.org/show_bug.cgi?id=214301
+
+Reviewed by Manuel Rego Casasnovas.
+
+Remove platform-specific expectations not longer needed.
+
+* platform/gtk/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
+* platform/ios-wk2/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
+* platform/wpe/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt: Removed.
+
+2020-07-14 Carlos Alberto Lopez Perez
+
Update WPT tests for css-text
https://bugs.webkit.org/show_bug.cgi?id=214275
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (264338 => 264339)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-07-14 14:06:17 UTC (rev 264338)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-07-14 15:32:51 UTC (rev 264339)
@@ -1,5 +1,17 @@
2020-07-14 Carlos Alberto Lopez Perez
+WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
+https://bugs.webkit.org/show_bug.cgi?id=214301
+
+Reviewed by Manuel Rego Casasnovas.
+
+Import commit 4b5101fabe from WPT.
+
+* web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt:
+* web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html:
+
+2020-07-14 Carlos Alberto Lopez Perez
+
Update WPT tests for css-text
https://bugs.webkit.org/show_bug.cgi?id=214275
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt (264338 => 264339)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt 2020-07-14 14:06:17 UTC (rev 264338)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001-expected.txt 2020-07-14 15:32:51 UTC (rev 264339)
@@ -1,118 +1,47 @@
-Blocked access to external URL https://wpt.live/css/support/grid.css
-Blocked access to external URL https://wpt.live/resources/testharness.js
-Blocked access to external URL https://wpt.live/resources/testharnessreport.js
-Blocked access to external URL https://wpt.live/resources/check-layout-th.js
-CONSOLE MESSAGE: ReferenceError: Can't find variable: checkLayout
-layer at (0,0) size 800x600
- RenderView at (0,0) size 800x600
-layer at (0,0) size 800x194
- RenderBlock {HTML} at (0,0) size 800x194
-RenderBody {BODY} at (8,16) size 784x170
- RenderBlock {DIV} at (0,0) size 784x0
- RenderBlock {P} at (0,0) size 784x18
-RenderText {#text} at (0,0) size 410x18
- text run at (0,0) width 410: "This test checks that repeat(auto-fit, ) syntax works as expected."
-layer at (8,50) size 204x4
- RenderBlock (relative positioned) {DIV} at (0,34) size 204x4 [border: (2px solid #FF00FF)]
-RenderBlock {DIV} at (2,2) size 200x0
[webkit-changes] [264094] trunk/Tools
Title: [264094] trunk/Tools Revision 264094 Author clo...@igalia.com Date 2020-07-08 04:02:30 -0700 (Wed, 08 Jul 2020) Log Message [GTK][WPE] install-dependencies should install the gstreamer plugins https://bugs.webkit.org/show_bug.cgi?id=214045 Reviewed by Adrian Perez de Castro. When building webkit against system libraries (without flatpak/jhbuild) its needed to have installed the webkit plugins to play media files. The install-dependencies script should install them. gstreamer-plugins-ugly its likely not needed for the majority of the cases, but it can be required by some ugly media files that require an ugly decoder. Since we are installing it on the flatpak, let's add it here as well. * gtk/install-dependencies: * wpe/install-dependencies: Modified Paths trunk/Tools/ChangeLog trunk/Tools/gtk/install-dependencies trunk/Tools/wpe/install-dependencies Diff Modified: trunk/Tools/ChangeLog (264093 => 264094) --- trunk/Tools/ChangeLog 2020-07-08 10:53:26 UTC (rev 264093) +++ trunk/Tools/ChangeLog 2020-07-08 11:02:30 UTC (rev 264094) @@ -1,3 +1,21 @@ +2020-07-08 Carlos Alberto Lopez Perez + +[GTK][WPE] install-dependencies should install the gstreamer plugins +https://bugs.webkit.org/show_bug.cgi?id=214045 + +Reviewed by Adrian Perez de Castro. + +When building webkit against system libraries (without flatpak/jhbuild) +its needed to have installed the webkit plugins to play media files. +The install-dependencies script should install them. + +gstreamer-plugins-ugly its likely not needed for the majority of the cases, +but it can be required by some ugly media files that require an ugly decoder. +Since we are installing it on the flatpak, let's add it here as well. + +* gtk/install-dependencies: +* wpe/install-dependencies: + 2020-07-08 Philippe Normand [webkitpy] run-minibrowser doesn't handle unicode urls Modified: trunk/Tools/gtk/install-dependencies (264093 => 264094) --- trunk/Tools/gtk/install-dependencies 2020-07-08 10:53:26 UTC (rev 264093) +++ trunk/Tools/gtk/install-dependencies 2020-07-08 11:02:30 UTC (rev 264094) @@ -249,6 +249,16 @@ python3-secretstorage \ subversion" +# These are GStreamer plugins needed to play different media files. +packages="$packages \ +gstreamer1.0-gl \ +gstreamer1.0-libav \ +gstreamer1.0-plugins-bad \ +gstreamer1.0-plugins-base \ +gstreamer1.0-plugins-good \ +gstreamer1.0-plugins-ugly \ +gstreamer1.0-pulseaudio" + apt-get install $packages # Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path. @@ -280,7 +290,6 @@ grep \ groff \ gstreamer \ -gst-plugins-bad \ gst-plugins-base-libs \ gzip \ hyphen \ @@ -424,6 +433,14 @@ packages="$packages \ python-secretstorage \ svn" + +# These are GStreamer plugins needed to play different media files. +packages="$packages \ +gst-plugins-bad \ +gst-plugins-base \ +gst-plugins-good \ +gst-plugins-ugly" + pacman -S --needed $packages cat <<-EOF @@ -599,6 +616,15 @@ python3-secretstorage \ subversion" +# These are GStreamer plugins needed to play different media files. +packages="$packages \ +gstreamer1-plugins-bad-free \ +gstreamer1-plugins-bad-free-extras \ +gstreamer1-plugins-base \ +gstreamer1-plugins-good \ +gstreamer1-plugins-good-extras \ +gstreamer1-plugins-ugly-free" + dnf install $packages } Modified: trunk/Tools/wpe/install-dependencies (264093 => 264094) --- trunk/Tools/wpe/install-dependencies 2020-07-08 10:53:26 UTC (rev 264093) +++ trunk/Tools/wpe/install-dependencies 2020-07-08 11:02:30 UTC (rev 264094) @@ -152,6 +152,16 @@ python3-secretstorage \ subversion" +# These are GStreamer plugins needed to play different media files. +packages="$packages \ +gstreamer1.0-gl \ +gstreamer1.0-libav \ +gstreamer1.0-plugins-bad \ +gstreamer1.0-plugins-base \ +gstreamer1.0-plugins-good \ +gstreamer1.0-plugins-ugly \ +gstreamer1.0-pulseaudio" + apt-get install $packages # Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path. @@ -181,7 +191,6 @@ grep \ groff \ gstreamer \ -gst-plugins-bad \ gst-plugins-base-libs \ gzip \ icu \ @@ -266,6 +275,14 @@ packages="$packages \ python-secretstorage \ svn" + +# These are GStreamer plugins needed to play different media files. +packages="$packages \ +gst-plugins-bad \ +gst-plugins-base \ +gst-plugins-good \ +gst-plugins-ugly" + pacman -S --needed $packages cat <<-EOF @@ -390,6 +407,15 @@
[webkit-changes] [264092] trunk/Tools
Title: [264092] trunk/Tools
Revision 264092
Author clo...@igalia.com
Date 2020-07-08 03:41:54 -0700 (Wed, 08 Jul 2020)
Log Message
[JHBuild] Add support for using a minimal moduleset
https://bugs.webkit.org/show_bug.cgi?id=213614
Reviewed by Carlos Garcia Campos.
This patch introduces a way of specifying a moduleset other than the default
via the environment variable WEBKIT_JHBUILD_MODULESET and adds a minimal moduleset
that allows building WebKit with it. This minimal moduleset includes the libraries
needed for building WebKit on Ubuntu-18.04, and those libraries are only build if
needed since they include the entries that tells JHBuild to not build
them if those are already installed system wide. So this minimal moduleset should
work also on newer versions of Ubuntu or even other distributions.
Currently a recipe for newer libsoup than the one shipped by Ubuntu-18.04 is included
since we need this to have support for SameSite cookie support.
The minimal moduleset is shared between WPE and GTK to reduce code duplication.
To use this, you have to export on the build environment:
WEBKIT_JHBUILD=1
WEBKIT_JHBUILD_MODULESET=minimal
* Scripts/update-webkit-libs-jhbuild:
(getJhbuildIncludedFilePaths):
(jhbuildModulesetNameChanged):
(jhbuildConfigurationChanged):
(saveJhbuildMd5):
(saveJhbuildModulesetName):
(saveJhbuildConfig):
(deleteJhbuildMd5):
(deleteJhbuildModulesetName):
(deleteJhbuildConfig):
* Scripts/webkitdirs.pm:
(getJhbuildModulesetName):
* gtk/jhbuild-minimal.modules: Added.
* jhbuild/jhbuild-minimal.modules: Added.
* jhbuild/jhbuildrc_common.py:
(init):
* jhbuild/patches/libsoup-lower-glib-dependency-to-2.38.patch: Added.
* wpe/jhbuild-minimal.modules: Added.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/update-webkit-libs-jhbuild
trunk/Tools/Scripts/webkitdirs.pm
trunk/Tools/jhbuild/jhbuildrc_common.py
Added Paths
trunk/Tools/gtk/jhbuild-minimal.modules
trunk/Tools/jhbuild/jhbuild-minimal.modules
trunk/Tools/jhbuild/patches/
trunk/Tools/jhbuild/patches/libsoup-lower-glib-dependency-to-2.38.patch
trunk/Tools/wpe/jhbuild-minimal.modules
Diff
Modified: trunk/Tools/ChangeLog (264091 => 264092)
--- trunk/Tools/ChangeLog 2020-07-08 10:07:59 UTC (rev 264091)
+++ trunk/Tools/ChangeLog 2020-07-08 10:41:54 UTC (rev 264092)
@@ -1,3 +1,45 @@
+2020-07-08 Carlos Alberto Lopez Perez
+
+[JHBuild] Add support for using a minimal moduleset
+https://bugs.webkit.org/show_bug.cgi?id=213614
+
+Reviewed by Carlos Garcia Campos.
+
+This patch introduces a way of specifying a moduleset other than the default
+via the environment variable WEBKIT_JHBUILD_MODULESET and adds a minimal moduleset
+that allows building WebKit with it. This minimal moduleset includes the libraries
+needed for building WebKit on Ubuntu-18.04, and those libraries are only build if
+needed since they include the entries that tells JHBuild to not build
+them if those are already installed system wide. So this minimal moduleset should
+work also on newer versions of Ubuntu or even other distributions.
+
+Currently a recipe for newer libsoup than the one shipped by Ubuntu-18.04 is included
+since we need this to have support for SameSite cookie support.
+The minimal moduleset is shared between WPE and GTK to reduce code duplication.
+
+To use this, you have to export on the build environment:
+WEBKIT_JHBUILD=1
+WEBKIT_JHBUILD_MODULESET=minimal
+
+* Scripts/update-webkit-libs-jhbuild:
+(getJhbuildIncludedFilePaths):
+(jhbuildModulesetNameChanged):
+(jhbuildConfigurationChanged):
+(saveJhbuildMd5):
+(saveJhbuildModulesetName):
+(saveJhbuildConfig):
+(deleteJhbuildMd5):
+(deleteJhbuildModulesetName):
+(deleteJhbuildConfig):
+* Scripts/webkitdirs.pm:
+(getJhbuildModulesetName):
+* gtk/jhbuild-minimal.modules: Added.
+* jhbuild/jhbuild-minimal.modules: Added.
+* jhbuild/jhbuildrc_common.py:
+(init):
+* jhbuild/patches/libsoup-lower-glib-dependency-to-2.38.patch: Added.
+* wpe/jhbuild-minimal.modules: Added.
+
2020-07-08 Philippe Normand
[webkitpy] run-minibrowser doesn't default to mac and stdout/stderr are not displayed
Modified: trunk/Tools/Scripts/update-webkit-libs-jhbuild (264091 => 264092)
--- trunk/Tools/Scripts/update-webkit-libs-jhbuild 2020-07-08 10:07:59 UTC (rev 264091)
+++ trunk/Tools/Scripts/update-webkit-libs-jhbuild 2020-07-08 10:41:54 UTC (rev 264092)
@@ -48,6 +48,7 @@
sub getJhbuildIncludedFilePaths
{
my $jhbuildFile = shift;
+die "Can't find file $jhbuildFile" if ! -e $jhbuildFile;
my $dom = XML::LibXML->load_xml(location => $jhbuildFile);
my @includes;
@@ -95,10 +96,23 @@
}
}
+sub jhbuildModulesetNameChanged()
+{
+my $jhBuildModulesetNameFile = join('/', getJhbuildPath(),
[webkit-changes] [264002] trunk/Tools
Title: [264002] trunk/Tools
Revision 264002
Author clo...@igalia.com
Date 2020-07-06 17:46:03 -0700 (Mon, 06 Jul 2020)
Log Message
svn-apply should use verbose mode when adding files to git
https://bugs.webkit.org/show_bug.cgi?id=214022
Reviewed by Darin Adler.
If a patch contains several copy or add operations it can happen that there is
no output for more than 600 seconds meanwhile the tool is applying the patch.
This can cause a fatal error on the EWS. Pass the verbose flag to git,
so it outputs the name of the file after adding it to the index.
This is consequent how "svn add" works by default (it outputs the name of the file),
or how "git rm" works (it also outputs the name of the file by default as well).
* Scripts/svn-apply:
(scmCopy):
(scmAdd):
(scmCommitQueueAdded):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/svn-apply
Diff
Modified: trunk/Tools/ChangeLog (264001 => 264002)
--- trunk/Tools/ChangeLog 2020-07-07 00:15:28 UTC (rev 264001)
+++ trunk/Tools/ChangeLog 2020-07-07 00:46:03 UTC (rev 264002)
@@ -1,3 +1,22 @@
+2020-07-06 Carlos Alberto Lopez Perez
+
+svn-apply should use verbose mode when adding files to git
+https://bugs.webkit.org/show_bug.cgi?id=214022
+
+Reviewed by Darin Adler.
+
+If a patch contains several copy or add operations it can happen that there is
+no output for more than 600 seconds meanwhile the tool is applying the patch.
+This can cause a fatal error on the EWS. Pass the verbose flag to git,
+so it outputs the name of the file after adding it to the index.
+This is consequent how "svn add" works by default (it outputs the name of the file),
+or how "git rm" works (it also outputs the name of the file by default as well).
+
+* Scripts/svn-apply:
+(scmCopy):
+(scmAdd):
+(scmCommitQueueAdded):
+
2020-07-06 Chris Fleizach
AX: Implement user action spec for Escape action
Modified: trunk/Tools/Scripts/svn-apply (264001 => 264002)
--- trunk/Tools/Scripts/svn-apply 2020-07-07 00:15:28 UTC (rev 264001)
+++ trunk/Tools/Scripts/svn-apply 2020-07-07 00:46:03 UTC (rev 264002)
@@ -468,7 +468,7 @@
system("svn", "copy", $escapedSource, $escapedDestination) == 0 or die "Failed to svn copy $escapedSource $escapedDestination.";
} elsif (isGit()) {
copy($source, $destination) or die "Failed to copy $source $destination.";
-system("git", "add", $destination) == 0 or die "Failed to git add $destination.";
+system("git", "add", "-v", $destination) == 0 or die "Failed to git add $destination.";
}
}
@@ -479,7 +479,7 @@
my $escapedPath = escapeSubversionPath($path);
system("svn", "add", $escapedPath) == 0 or die "Failed to svn add $escapedPath.";
} elsif (isGit()) {
-system("git", "add", $path) == 0 or die "Failed to git add $path.";
+system("git", "add", "-v", $path) == 0 or die "Failed to git add $path.";
}
}
@@ -526,7 +526,7 @@
if (isSVN()) {
@cmdBase = ("svn", "add")
} elsif (isGit()) {
-@cmdBase = ("git", "add")
+@cmdBase = ("git", "add", "-v")
}
# When we are handling a very large patch (more than 1000 files modified)
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263897] trunk/Tools
Title: [263897] trunk/Tools Revision 263897 Author clo...@igalia.com Date 2020-07-03 08:00:49 -0700 (Fri, 03 Jul 2020) Log Message [WPE][webkitpy] Use headless driver instead of wayland driver https://bugs.webkit.org/show_bug.cgi?id=213914 Reviewed by Philippe Normand. WPE now supports running tests completely headless, but we are still using the webkitpy WaylandDriver to run the tests. This causes an error if the environment doesn't have defined the WAYLAND_DISPLAY or WAYLAND_SOCKET environment variables. Switch the driver to HeadlessDriver. * Scripts/webkitpy/port/wpe.py: (WPEPort._driver_class): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/port/wpe.py Diff Modified: trunk/Tools/ChangeLog (263896 => 263897) --- trunk/Tools/ChangeLog 2020-07-03 14:55:10 UTC (rev 263896) +++ trunk/Tools/ChangeLog 2020-07-03 15:00:49 UTC (rev 263897) @@ -1,3 +1,19 @@ +2020-07-03 Carlos Alberto Lopez Perez + +[WPE][webkitpy] Use headless driver instead of wayland driver +https://bugs.webkit.org/show_bug.cgi?id=213914 + +Reviewed by Philippe Normand. + +WPE now supports running tests completely headless, but we are +still using the webkitpy WaylandDriver to run the tests. +This causes an error if the environment doesn't have defined the +WAYLAND_DISPLAY or WAYLAND_SOCKET environment variables. +Switch the driver to HeadlessDriver. + +* Scripts/webkitpy/port/wpe.py: +(WPEPort._driver_class): + 2020-07-03 Carlos Garcia Campos REGRESSION(r261779): [GTK][WPE] http/tests/resourceLoadStatistics/third-party-cookie-blocking-ephemeral.html is failing Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (263896 => 263897) --- trunk/Tools/Scripts/webkitpy/port/wpe.py 2020-07-03 14:55:10 UTC (rev 263896) +++ trunk/Tools/Scripts/webkitpy/port/wpe.py 2020-07-03 15:00:49 UTC (rev 263897) @@ -32,7 +32,6 @@ from webkitpy.port.base import Port from webkitpy.port.headlessdriver import HeadlessDriver from webkitpy.port.linux_get_crash_log import GDBCrashLogGenerator -from webkitpy.port.waylanddriver import WaylandDriver class WPEPort(Port): @@ -70,7 +69,7 @@ @memoized def _driver_class(self): -return WaylandDriver +return HeadlessDriver def setup_environ_for_server(self, server_name=None): environment = super(WPEPort, self).setup_environ_for_server(server_name) ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [263557] trunk/Tools
Title: [263557] trunk/Tools
Revision 263557
Author clo...@igalia.com
Date 2020-06-26 07:44:38 -0700 (Fri, 26 Jun 2020)
Log Message
generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
https://bugs.webkit.org/show_bug.cgi?id=213615
Reviewed by Žan Doberšek.
Raise an exception if the parameter passed as remote-config-file is not a file.
* Scripts/generate-jsc-bundle:
(main):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/generate-jsc-bundle
Diff
Modified: trunk/Tools/ChangeLog (263556 => 263557)
--- trunk/Tools/ChangeLog 2020-06-26 13:36:43 UTC (rev 263556)
+++ trunk/Tools/ChangeLog 2020-06-26 14:44:38 UTC (rev 263557)
@@ -1,3 +1,15 @@
+2020-06-26 Carlos Alberto Lopez Perez
+
+generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
+https://bugs.webkit.org/show_bug.cgi?id=213615
+
+Reviewed by Žan Doberšek.
+
+Raise an exception if the parameter passed as remote-config-file is not a file.
+
+* Scripts/generate-jsc-bundle:
+(main):
+
2020-06-26 Takashi Komori
Add myself to contributors.json
Modified: trunk/Tools/Scripts/generate-jsc-bundle (263556 => 263557)
--- trunk/Tools/Scripts/generate-jsc-bundle 2020-06-26 13:36:43 UTC (rev 263556)
+++ trunk/Tools/Scripts/generate-jsc-bundle 2020-06-26 14:44:38 UTC (rev 263557)
@@ -239,7 +239,9 @@
bundleFilePath = createJSCBundle(configuration, options.revision, options.buildername, platform)
print('Bundle file created at: %s' % bundleFilePath)
-if options.remoteConfigFile is not None and os.path.isfile(options.remoteConfigFile):
+if options.remoteConfigFile is not None:
+if not os.path.isfile(options.remoteConfigFile):
+raise ValueError("Can't find remote config file for upload at path %s" % options.remoteConfigFile)
return uploadJSCBundle(bundleFilePath, options.remoteConfigFile, options.configuration, options.revision)
return 0
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [262840] trunk/LayoutTests
Title: [262840] trunk/LayoutTests Revision 262840 Author clo...@igalia.com Date 2020-06-10 08:35:24 -0700 (Wed, 10 Jun 2020) Log Message Layout tests outside of the WPT import should not use resources from it https://bugs.webkit.org/show_bug.cgi?id=212661 Reviewed by Youenn Fablet. Some layout tests were using resource files from the imported WPT tests. This is an issue because updating the WPT tests may break this tests in the future. To fix this the used resource files are copied inside the main folder of each test and the tests modified to use them. On top of that, some tests are de-duplicates (in favor of the WPT versions, which are the same). This is the list of tests de-duplicated: canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.emptysrc.html canvas/philip/tests/2d.drawImage.incomplete.nosrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.nosrc.html canvas/philip/tests/2d.drawImage.incomplete.removedsrc.html -> imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/2d.drawImage.incomplete.removedsrc.html canvas/philip/tests/2d.pattern.image.incomplete.emptysrc.html -> imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.emptysrc.html canvas/philip/tests/2d.pattern.image.incomplete.removedsrc.html -> imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.pattern.image.incomplete.removedsrc.html fast/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html -> imported/w3c/web-platform-tests/shadow-dom/capturing-and-bubbling-event-listeners-across-shadow-trees.html * canvas/philip/tests/2d.drawImage.incomplete.emptysrc-expected.txt: Removed. * canvas/philip/tests/2d.drawImage.incomplete.emptysrc.html: Removed. * canvas/philip/tests/2d.drawImage.incomplete.nosrc-expected.txt: Removed. * canvas/philip/tests/2d.drawImage.incomplete.nosrc.html: Removed. * canvas/philip/tests/2d.drawImage.incomplete.removedsrc-expected.txt: Removed. * canvas/philip/tests/2d.drawImage.incomplete.removedsrc.html: Removed. * canvas/philip/tests/2d.pattern.image.incomplete.emptysrc-expected.txt: Removed. * canvas/philip/tests/2d.pattern.image.incomplete.emptysrc.html: Removed. * canvas/philip/tests/2d.pattern.image.incomplete.removedsrc-expected.txt: Removed. * canvas/philip/tests/2d.pattern.image.incomplete.removedsrc.html: Removed. * fast/css/resources/shadow-helper.js: Added. (getElementByShadowIds): (ceClass.): (installCustomElement): * fast/css/shadow-parts/exportparts-syntax.html: * fast/css/shadow-parts/invalidation-class-before-after.html: * fast/css/shadow-parts/invalidation-class-descendant-combinator-export.html: * fast/css/shadow-parts/invalidation-class-descendant-combinator.html: * fast/css/shadow-parts/invalidation-class-sibling-combinator-export.html: * fast/css/shadow-parts/invalidation-class-sibling-combinator.html: * fast/custom-elements/DOMImplementation-createDocument.html: * fast/custom-elements/adopting-from-frameless-document.html: * fast/custom-elements/disconnected-callback-in-detached-iframe.html: * fast/custom-elements/document-createElementNS.html: * fast/custom-elements/enqueue-custom-element-callback-reactions-inside-another-callback.html: * fast/custom-elements/perform-microtask-checkpoint-before-construction.html: * fast/custom-elements/reactions-for-webkit-extensions.html: * fast/custom-elements/resources/custom-elements-helpers.js: Added. (create_window_in_test): (test_with_window): (prototype.attributeChangedCallback): (prototype.connectedCallback): (prototype.disconnectedCallback): (prototype.adoptedCallback): (return.takeLog): (create_constructor_log): (assert_constructor_log_entry): (create_connected_callback_log): (assert_connected_log_entry): (create_disconnected_callback_log): (assert_disconnected_log_entry): (assert_adopted_log_entry): (create_adopted_callback_log): (create_attribute_changed_callback_log): (assert_attribute_log_entry): (define_new_custom_element.CustomElement): (define_new_custom_element.CustomElement.prototype.attributeChangedCallback): (define_new_custom_element.CustomElement.prototype.connectedCallback): (define_new_custom_element.CustomElement.prototype.disconnectedCallback): (define_new_custom_element.CustomElement.prototype.adoptedCallback): (define_new_custom_element.return.takeLog): (CustomElement): (CustomElement.prototype.attributeChangedCallback): (CustomElement.prototype.connectedCallback): (CustomElement.prototype.disconnectedCallback): (CustomElement.prototype.adoptedCallback): * fast/custom-elements/resources/reactions.js: Added. (testNodeConnector): (testNodeDisconnector): (testInsertingMarkup): (testParsingMarkup): (prototype.test): (testReflectBooleanAttribute): (testAttributeAdder): *
[webkit-changes] [262565] trunk/Tools
Title: [262565] trunk/Tools
Revision 262565
Author clo...@igalia.com
Date 2020-06-04 13:16:05 -0700 (Thu, 04 Jun 2020)
Log Message
Improve watchlist logic for comments on patches touching imported WPT tests.
https://bugs.webkit.org/show_bug.cgi?id=212597
Reviewed by Youenn Fablet.
On r262295 I added a watchlist comment for patches touching the imported WPT tests.
However, this is commenting on patches that are importing WPT tests.
To avoid this situations, this patch adds a new rule to detect if the changes modify
any of the w3c-import.log files, and then changes the logic to make the comment only
for patches that modify the WPT imported tests but not the w3c-import.log files.
In order to support this new logic, watchlist rule parsing is improved to support
the "and" and "not" operators. Previously it only supported the "or" operator.
* Scripts/webkitpy/common/config/watchlist:
* Scripts/webkitpy/common/watchlist/watchlistparser.py:
(WatchListParser._rule_definitions_as_set):
* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
(WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion):
(WatchListParserTest):
(WatchListParserTest.test_cc_rule_with_complex_logic):
* Scripts/webkitpy/common/watchlist/watchlistrule.py:
(WatchListRule.__init__):
(WatchListRule._match_test_definitions):
(WatchListRule.match):
* Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
(WatchListRuleTest.test_complex_definition_or):
(WatchListRuleTest):
(WatchListRuleTest.test_complex_definition_and):
(WatchListRuleTest.test_complex_definition_not):
(WatchListRuleTest.test_complex_definition_combined):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistrule.py
trunk/Tools/Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (262564 => 262565)
--- trunk/Tools/ChangeLog 2020-06-04 20:02:29 UTC (rev 262564)
+++ trunk/Tools/ChangeLog 2020-06-04 20:16:05 UTC (rev 262565)
@@ -1,5 +1,40 @@
2020-06-04 Carlos Alberto Lopez Perez
+Improve watchlist logic for comments on patches touching imported WPT tests.
+https://bugs.webkit.org/show_bug.cgi?id=212597
+
+Reviewed by Youenn Fablet.
+
+On r262295 I added a watchlist comment for patches touching the imported WPT tests.
+However, this is commenting on patches that are importing WPT tests.
+
+To avoid this situations, this patch adds a new rule to detect if the changes modify
+any of the w3c-import.log files, and then changes the logic to make the comment only
+for patches that modify the WPT imported tests but not the w3c-import.log files.
+
+In order to support this new logic, watchlist rule parsing is improved to support
+the "and" and "not" operators. Previously it only supported the "or" operator.
+
+* Scripts/webkitpy/common/config/watchlist:
+* Scripts/webkitpy/common/watchlist/watchlistparser.py:
+(WatchListParser._rule_definitions_as_set):
+* Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
+(WatchListParserTest.test_cc_rule_with_undefined_defintion_with_suggestion):
+(WatchListParserTest):
+(WatchListParserTest.test_cc_rule_with_complex_logic):
+* Scripts/webkitpy/common/watchlist/watchlistrule.py:
+(WatchListRule.__init__):
+(WatchListRule._match_test_definitions):
+(WatchListRule.match):
+* Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
+(WatchListRuleTest.test_complex_definition_or):
+(WatchListRuleTest):
+(WatchListRuleTest.test_complex_definition_and):
+(WatchListRuleTest.test_complex_definition_not):
+(WatchListRuleTest.test_complex_definition_combined):
+
+2020-06-04 Carlos Alberto Lopez Perez
+
svn-apply command is too slow with big patches
https://bugs.webkit.org/show_bug.cgi?id=212766
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (262564 => 262565)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2020-06-04 20:02:29 UTC (rev 262564)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2020-06-04 20:16:05 UTC (rev 262565)
@@ -380,6 +380,9 @@
"WebPlatformTests": {
"filename": r"LayoutTests/imported/w3c/web-platform-tests/((?!-expected\.txt).)*$",
},
+"WebPlatformTestsImport": {
+"filename": r"LayoutTests/imported/w3c/web-platform-tests/.*w3c-import.log$",
+},
"WebRTC": {
"filename": r"Source/ThirdParty/libwebrtc/"
r"|Source/WebKit/Shared/*RTC*"
@@ -478,7 +481,7 @@
"See http://trac.webkit.org/wiki/UpdatingANGLE", ],
[webkit-changes] [262561] trunk/LayoutTests
Title: [262561] trunk/LayoutTests Revision 262561 Author clo...@igalia.com Date 2020-06-04 12:52:52 -0700 (Thu, 04 Jun 2020) Log Message Gardening after r262539 https://bugs.webkit.org/show_bug.cgi?id=212770 Unreviewed gardening. Add baselines for GTK/WPE and comment out enabling offscreen canvas tests that are now broken. Fixing them in bug 212613. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/compositing/2d.composite.globalAlpha.canvascopy-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/drawimage_canvas-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.cone.bottom-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.cone.cylinder-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.cone.front-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.cone.shape1-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.cone.top-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.inside1-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.inside2-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.inside3-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.outside1-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.outside2-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.outside3-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/2d.gradient.radial.touch2-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/image-smoothing/imagesmoothing-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/canvas-createImageBitmap-resize-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-drawImage-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-flipY-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-invalid-args-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-serializable-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/imagebitmap/createImageBitmap-transfer-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.isPointInStroke.scaleddashes-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.rect.winding-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/shadows/shadowBlur_gaussian_tolerance.1-expected.txt: Added. * platform/glib/imported/w3c/web-platform-tests/html/canvas/element/text-styles/2d.text.draw.baseline.ideographic-expected.txt: Added. * platform/gtk/TestExpectations: * platform/wpe/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/LayoutTests/platform/wpe/TestExpectations Added Paths trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/compositing/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/compositing/2d.composite.globalAlpha.canvascopy-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/ trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/drawimage_canvas-expected.txt trunk/LayoutTests/platform/glib/imported/w3c/web-platform-tests/html/canvas/element/fill-and-stroke-styles/
[webkit-changes] [262559] trunk/Tools
Title: [262559] trunk/Tools
Revision 262559
Author clo...@igalia.com
Date 2020-06-04 12:44:30 -0700 (Thu, 04 Jun 2020)
Log Message
svn-apply command is too slow with big patches
https://bugs.webkit.org/show_bug.cgi?id=212766
Reviewed by Darin Adler.
The script svn-apply was calling a "git add" or "svn add" command
after adding each new file. This caused the git or svn command to
re-check the internal SCM database each time they were called, and
this was really slow when lot of new files are added.
Instead of doing this, we queue the list of new files in memory,
and at the end we call "git add" or "svn add" once (or a few times).
On top of that, another optimization is added for the case of git,
to avoid calling scmKnowsOfFile() inside addDirectoriesIfNeeded(),
which is a slow operation and gets called a lot (once per file).
Doing that for git is totally unneeded, as the only thing we have
to take care about, is of ensuring that the directory is created.
See: https://wkb.ug/86973
This reduces the time spent in the large test patch that caused
this issue (see bug):
- Git: 8 hours (before) -> 8 minutes (now).
- SVN: 25 minutes (before) -> 5 minutes (now).
* Scripts/svn-apply:
(addDirectoriesIfNeeded):
(handleBinaryChange):
(handleGitBinaryChange):
(patch):
(scmRemove):
(scmAddQueued):
(scmCommitQueueAdded):
(scmToggleExecutableBitQueued):
(scmCommitQueueToggledExecutableBit):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/svn-apply
Diff
Modified: trunk/Tools/ChangeLog (262558 => 262559)
--- trunk/Tools/ChangeLog 2020-06-04 19:42:08 UTC (rev 262558)
+++ trunk/Tools/ChangeLog 2020-06-04 19:44:30 UTC (rev 262559)
@@ -1,3 +1,40 @@
+2020-06-04 Carlos Alberto Lopez Perez
+
+svn-apply command is too slow with big patches
+https://bugs.webkit.org/show_bug.cgi?id=212766
+
+Reviewed by Darin Adler.
+
+The script svn-apply was calling a "git add" or "svn add" command
+after adding each new file. This caused the git or svn command to
+re-check the internal SCM database each time they were called, and
+this was really slow when lot of new files are added.
+Instead of doing this, we queue the list of new files in memory,
+and at the end we call "git add" or "svn add" once (or a few times).
+
+On top of that, another optimization is added for the case of git,
+to avoid calling scmKnowsOfFile() inside addDirectoriesIfNeeded(),
+which is a slow operation and gets called a lot (once per file).
+Doing that for git is totally unneeded, as the only thing we have
+to take care about, is of ensuring that the directory is created.
+See: https://wkb.ug/86973
+
+This reduces the time spent in the large test patch that caused
+this issue (see bug):
+ - Git: 8 hours (before) -> 8 minutes (now).
+ - SVN: 25 minutes (before) -> 5 minutes (now).
+
+* Scripts/svn-apply:
+(addDirectoriesIfNeeded):
+(handleBinaryChange):
+(handleGitBinaryChange):
+(patch):
+(scmRemove):
+(scmAddQueued):
+(scmCommitQueueAdded):
+(scmToggleExecutableBitQueued):
+(scmCommitQueueToggledExecutableBit):
+
2020-06-04 Jonathan Bedard
Add watchOS and tvOS to build-webkit
Modified: trunk/Tools/Scripts/svn-apply (262558 => 262559)
--- trunk/Tools/Scripts/svn-apply 2020-06-04 19:42:08 UTC (rev 262558)
+++ trunk/Tools/Scripts/svn-apply 2020-06-04 19:44:30 UTC (rev 262559)
@@ -85,7 +85,11 @@
sub scmKnowsOfFile($);
sub scmCopy($$);
sub scmAdd($);
+sub scmAddQueued($);
+sub scmCommitQueueToggledExecutableBit();
+sub scmCommitQueueAdded();
sub scmRemove($);
+sub scmToggleExecutableBitQueued($$);
my $merge = 0;
my $showHelp = 0;
@@ -92,6 +96,8 @@
my $reviewer;
my $force = 0;
my $skipChangeLogs = 0;
+my @scmQueuedFilesToAdd = ();
+my %scmQueuedExecutableBits;
my $optionParseSuccess = GetOptions(
"merge!" => \$merge,
@@ -159,6 +165,16 @@
patch($diffHashRef);
}
+# For git we need to toggle the executable bit before adding the files
+# For SVN is the other way around.
+if (isGit()) {
+scmCommitQueueToggledExecutableBit();
+scmCommitQueueAdded();
+} elsif (isSVN()) {
+scmCommitQueueAdded();
+scmCommitQueueToggledExecutableBit();
+}
+
removeDirectoriesIfNeeded();
exit $globalExitStatus;
@@ -165,34 +181,34 @@
sub addDirectoriesIfNeeded($)
{
-# Git removes a directory once the last file in it is removed. We need
-# explicitly check for the existence of each directory along the path
-# (and create it if it doesn't) so as to support patches that move all files in
-# directory A to A/B. That is, we cannot depend on %checkedDirectories.
my ($path) = @_;
my @dirs = File::Spec->splitdir($path);
my $dir = ".";
while (scalar @dirs) {
$dir = File::Spec->catdir($dir, shift @dirs);
-next if !isGit() && exists
[webkit-changes] [262379] trunk/Tools
Title: [262379] trunk/Tools
Revision 262379
Author clo...@igalia.com
Date 2020-06-01 09:15:43 -0700 (Mon, 01 Jun 2020)
Log Message
[EWS] Add a special case for running the layout test step without aborting in case of many failures for WPT tests
https://bugs.webkit.org/show_bug.cgi?id=212381
Reviewed by Jonathan Bedard.
Add a special case for patches uploaded by the bugzilla user that would be used
for prototyping a bot that helps automating the import of WPT tests. For patches
uploaded by this user don't pass the parameters that make the step abort early in
case of many errors, and only run the layout tests inside the WPT import directory.
* BuildSlaveSupport/ews-build/steps.py:
(RunWebKitTests):
(RunWebKitTests.start):
* BuildSlaveSupport/ews-build/steps_unittest.py:
(test_success):
(test_warnings):
(test_parse_results_json_regression):
(test_parse_results_json_flakes):
(test_parse_results_json_flakes_and_regressions):
(test_parse_results_json_with_newlines):
(test_unexpected_error):
(test_failure):
(test_success_wpt_import_bot):
(TestRunWebKitTestsWithoutPatch.test_success):
(TestRunWebKitTestsWithoutPatch.test_failure):
(TestRunWebKit1Tests.test_success):
(TestRunWebKit1Tests.test_failure):
Modified Paths
trunk/Tools/BuildSlaveSupport/ews-build/steps.py
trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps.py (262378 => 262379)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-06-01 15:18:31 UTC (rev 262378)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps.py 2020-06-01 16:15:43 UTC (rev 262379)
@@ -1682,8 +1682,6 @@
'--no-show-results',
'--no-new-test-results',
'--clobber-old-results',
- '--exit-after-n-failures', '30',
- '--skip-failing-tests',
WithProperties('--%(configuration)s')]
def __init__(self, **kwargs):
@@ -1710,6 +1708,12 @@
self.setCommand(self.command + ['--results-directory', self.resultDirectory])
self.setCommand(self.command + ['--debug-rwt-logging'])
+patch_author = self.getProperty('patch_author')
+if patch_author in ['webkit-wpt-import-...@igalia.com']:
+self.setCommand(self.command + ['imported/w3c/web-platform-tests'])
+else:
+self.setCommand(self.command + ['--exit-after-n-failures', '30', '--skip-failing-tests'])
+
if additionalArguments:
self.setCommand(self.command + additionalArguments)
return shell.Test.start(self)
Modified: trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py (262378 => 262379)
--- trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-06-01 15:18:31 UTC (rev 262378)
+++ trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py 2020-06-01 16:15:43 UTC (rev 262379)
@@ -1552,7 +1552,7 @@
ExpectShell(workdir='wkdir',
logfiles={'json': self.jsonFileName},
logEnviron=False,
-command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results', '--no-new-test-results', '--clobber-old-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--release', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results', '--no-new-test-results', '--clobber-old-results', '--release', '--results-directory', 'layout-test-results', '--debug-rwt-logging', '--exit-after-n-failures', '30', '--skip-failing-tests'],
)
+ 0,
)
@@ -1567,7 +1567,7 @@
ExpectShell(workdir='wkdir',
logfiles={'json': self.jsonFileName},
logEnviron=False,
-command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results', '--no-new-test-results', '--clobber-old-results', '--exit-after-n-failures', '30', '--skip-failing-tests', '--release', '--results-directory', 'layout-test-results', '--debug-rwt-logging'],
+command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results', '--no-new-test-results', '--clobber-old-results', '--release', '--results-directory', 'layout-test-results', '--debug-rwt-logging', '--exit-after-n-failures', '30', '--skip-failing-tests'],
)
+ 0
+ ExpectShell.log('stdio', stdout='''Unexpected flakiness: timeouts (2)
@@ -1604,7 +1604,7 @@
ExpectShell(workdir='wkdir',
logfiles={'json': self.jsonFileName},
logEnviron=False,
-command=['python', 'Tools/Scripts/run-webkit-tests', '--no-build', '--no-show-results', '--no-new-test-results', '--clobber-old-results', '--exit-after-n-failures', '30',
[webkit-changes] [262295] trunk/Tools
Title: [262295] trunk/Tools
Revision 262295
Author clo...@igalia.com
Date 2020-05-29 08:47:40 -0700 (Fri, 29 May 2020)
Log Message
Add watchlist comment for patches touching imported WPT tests.
https://bugs.webkit.org/show_bug.cgi?id=212362
Reviewed by Youenn Fablet.
Add a watchlist trigger to comment on patches touching imported WPT tests
with a link to documentation about the export process.
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (262294 => 262295)
--- trunk/Tools/ChangeLog 2020-05-29 14:56:21 UTC (rev 262294)
+++ trunk/Tools/ChangeLog 2020-05-29 15:47:40 UTC (rev 262295)
@@ -1,3 +1,15 @@
+2020-05-29 Carlos Alberto Lopez Perez
+
+Add watchlist comment for patches touching imported WPT tests.
+https://bugs.webkit.org/show_bug.cgi?id=212362
+
+Reviewed by Youenn Fablet.
+
+Add a watchlist trigger to comment on patches touching imported WPT tests
+with a link to documentation about the export process.
+
+* Scripts/webkitpy/common/config/watchlist:
+
2020-05-29 Lauro Moura
[Flatpak] Fix os.system return code for better signal handling.
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (262294 => 262295)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2020-05-29 14:56:21 UTC (rev 262294)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2020-05-29 15:47:40 UTC (rev 262295)
@@ -377,6 +377,9 @@
r"|Source/WebCore/platform/graphics/gpu/"
r"|Source/WebCore/platform/graphics/gpu/cocoa/",
},
+"WebPlatformTests": {
+"filename": r"LayoutTests/imported/w3c/web-platform-tests/((?!-expected\.txt).)*$",
+},
"WebRTC": {
"filename": r"Source/ThirdParty/libwebrtc/"
r"|Source/WebKit/Shared/*RTC*"
@@ -454,6 +457,7 @@
"JSBuiltins": [ "joep...@webkit.org" ],
"JSBuiltinsGenerator": [ "bb...@apple.com" ],
"WPEDependencies": [ "ape...@igalia.com", "clo...@igalia.com" ],
+"WebPlatformTests": [ "clo...@igalia.com", "youe...@gmail.com" ],
"WebKitGTKDependencies": [ "ago...@igalia.com", "lti...@igalia.com", "clo...@igalia.com" ],
"WebKitGTKTranslations": [ "g...@gnome.org", "be...@igalia.com", "cgar...@igalia.com" ],
"WebSocket": [ "yu...@chromium.org", "toyos...@chromium.org" ],
@@ -474,6 +478,7 @@
"See http://trac.webkit.org/wiki/UpdatingANGLE", ],
"WebInspectorProtocol": [ "This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features." ],
"WebInspectorGenerator": [ "This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)" ],
+"WebPlatformTests": [ "This patch modifies the imported WPT tests. Please ensure that any changes on the tests are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess" ],
"JSBuiltinsGenerator": [ "This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)" ],
"WasmJSON": [ "This patch modifies one of the wasm.json files. Please ensure that any changes in one have been mirrored to the other. You can find the wasm.json files at \"Source/_javascript_Core/wasm/wasm.json\" and \"JSTests/wasm/wasm.json\"." ],
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [262139] trunk/LayoutTests
Title: [262139] trunk/LayoutTests Revision 262139 Author clo...@igalia.com Date 2020-05-26 01:46:45 -0700 (Tue, 26 May 2020) Log Message [css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails https://bugs.webkit.org/show_bug.cgi?id=212054 Reviewed by Manuel Rego Casasnovas. LayoutTests/imported/w3c: Update the test to use the Ahem font, and rely on different font colors (instead of different glyps) to check that each box of the test is placed correctly. * web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html: * web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html: LayoutTests: Remove expectations for passing test. * TestExpectations: * platform/glib/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html trunk/LayoutTests/platform/glib/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (262138 => 262139) --- trunk/LayoutTests/ChangeLog 2020-05-26 08:01:14 UTC (rev 262138) +++ trunk/LayoutTests/ChangeLog 2020-05-26 08:46:45 UTC (rev 262139) @@ -1,3 +1,15 @@ +2020-05-25 Carlos Alberto Lopez Perez + +[css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails +https://bugs.webkit.org/show_bug.cgi?id=212054 + +Reviewed by Manuel Rego Casasnovas. + +Remove expectations for passing test. + +* TestExpectations: +* platform/glib/TestExpectations: + 2020-05-25 Diego Pino Garcia [WPE] Gardening, update baselines after r262127 Modified: trunk/LayoutTests/TestExpectations (262138 => 262139) --- trunk/LayoutTests/TestExpectations 2020-05-26 08:01:14 UTC (rev 262138) +++ trunk/LayoutTests/TestExpectations 2020-05-26 08:46:45 UTC (rev 262139) @@ -4258,7 +4258,6 @@ webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/scrollbars.html [ ImageOnlyFailure ] webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-fixed-min-width.html [ ImageOnlyFailure ] webkit.org/b/212046 imported/w3c/web-platform-tests/css/css-flexbox/table-as-item-narrow-content.html [ ImageOnlyFailure ] -webkit.org/b/212054 imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html [ ImageOnlyFailure ] # CSS Masonry Layout not supported. imported/w3c/web-platform-tests/css/css-grid/masonry.tentative [ Skip ] Modified: trunk/LayoutTests/imported/w3c/ChangeLog (262138 => 262139) --- trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-26 08:01:14 UTC (rev 262138) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-05-26 08:46:45 UTC (rev 262139) @@ -1,3 +1,16 @@ +2020-05-25 Carlos Alberto Lopez Perez + +[css-flexbox] WPT Test css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html fails +https://bugs.webkit.org/show_bug.cgi?id=212054 + +Reviewed by Manuel Rego Casasnovas. + +Update the test to use the Ahem font, and rely on different font colors (instead of different glyps) +to check that each box of the test is placed correctly. + +* web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html: +* web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse.html: + 2020-05-25 Oriol Brufau [css-grid] Prevent grid-template-rows from serializing adjacent Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html (262138 => 262139) --- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html 2020-05-26 08:01:14 UTC (rev 262138) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/flex-lines/multi-line-wrap-reverse-column-reverse-expected.html 2020-05-26 08:46:45 UTC (rev 262139) @@ -4,8 +4,9 @@ CSS Test Reference: flex container multiline wrapping-reverse in column-reverse direction +-* { margin:0; padding:0; font-size:100%; line-height:1; }+* { margin:0; padding:0; font-size:100%; line-height:1; font-family: Ahem; } .test { width: 300px; @@ -21,26 +22,32 @@ #row1-col1 { height: 90px; +color: orange; } #row1-col2 {
[webkit-changes] [262062] trunk/LayoutTests
Title: [262062] trunk/LayoutTests Revision 262062 Author clo...@igalia.com Date 2020-05-22 10:32:05 -0700 (Fri, 22 May 2020) Log Message Gardening after r262056 Unreviewed. * TestExpectations: Skip a test that crashes on debug. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (262061 => 262062) --- trunk/LayoutTests/ChangeLog 2020-05-22 16:45:36 UTC (rev 262061) +++ trunk/LayoutTests/ChangeLog 2020-05-22 17:32:05 UTC (rev 262062) @@ -1,3 +1,11 @@ +2020-05-22 Carlos Alberto Lopez Perez + +Gardening after r262056 + +Unreviewed. + +* TestExpectations: Skip a test that crashes on debug. + 2020-05-22 Oriol Brufau Don't put out-of-flow boxes in anonymous flex/grid items Modified: trunk/LayoutTests/TestExpectations (262061 => 262062) --- trunk/LayoutTests/TestExpectations 2020-05-22 16:45:36 UTC (rev 262061) +++ trunk/LayoutTests/TestExpectations 2020-05-22 17:32:05 UTC (rev 262062) @@ -4286,7 +4286,6 @@ webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-002.html [ ImageOnlyFailure ] webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-003.html [ ImageOnlyFailure ] webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-mixed-baseline-004.html [ ImageOnlyFailure ] -webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-self-baseline-001.html [ ImageOnlyFailure ] webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-001.html [ ImageOnlyFailure ] webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-002.html [ ImageOnlyFailure ] webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-self-alignment-baseline-with-grid-003.html [ ImageOnlyFailure ] @@ -4298,3 +4297,4 @@ webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-areas-overflowing-grid-container-005.html [ ImageOnlyFailure ] webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-001.html [ ImageOnlyFailure ] webkit.org/b/212246 imported/w3c/web-platform-tests/css/css-grid/grid-model/grid-overflow-padding-002.html [ ImageOnlyFailure ] +webkit.org/b/212267 imported/w3c/web-platform-tests/css/css-grid/alignment/grid-item-self-baseline-001.html [ Skip ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261914] trunk/Tools
Title: [261914] trunk/Tools Revision 261914 Author clo...@igalia.com Date 2020-05-20 06:29:09 -0700 (Wed, 20 May 2020) Log Message update-test-expectations-from-bugzilla tool not working with new EWS https://bugs.webkit.org/show_bug.cgi?id=210975 Reviewed by Youenn Fablet. With the new EWS, the layout test archive results are not longer posted to bugzilla as attachment. Now we need to inspect the EWS server to get the status of the runs for the patch id, and then query the EWS builbot server in order to get the details of each run to finally obtain the URL with the zip file for the results. The tool now automatically applies platform-specific and generic results automatically (its not longer needed to specify whether the result its generic or not). It uses mac-wk2 results as generic. Also now it updates the test results for tests where the result is MISSING. * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: (configure_logging): (argument_parser): (TestExpectationUpdater.__init__): (TestExpectationUpdater._platform_name): (TestExpectationUpdater): (TestExpectationUpdater._get_layout_tests_run): (TestExpectationUpdater._lookup_ews_results): (TestExpectationUpdater._tests_to_update): (TestExpectationUpdater._update_for_generic_bot): (TestExpectationUpdater._update_for_platform_specific_bot): (TestExpectationUpdater.do_update): (main): * Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: (MockAttachment.__init__): (MockAttachment.is_patch): (MockAttachment): (MockAttachment.is_obsolete): (MockBugzilla): (MockBugzilla.attachments): (MockRequests): (MockRequests.__init__): (MockRequests.get): (MockRequests.content): (MockRequests.text): (MockZip.__init__): (TestExpectationUpdaterTest.test_update_test_expectations): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py trunk/Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py Diff Modified: trunk/Tools/ChangeLog (261913 => 261914) --- trunk/Tools/ChangeLog 2020-05-20 13:22:15 UTC (rev 261913) +++ trunk/Tools/ChangeLog 2020-05-20 13:29:09 UTC (rev 261914) @@ -1,3 +1,51 @@ +2020-05-20 Carlos Alberto Lopez Perez + +update-test-expectations-from-bugzilla tool not working with new EWS +https://bugs.webkit.org/show_bug.cgi?id=210975 + +Reviewed by Youenn Fablet. + +With the new EWS, the layout test archive results are not longer +posted to bugzilla as attachment. Now we need to inspect the EWS +server to get the status of the runs for the patch id, and then +query the EWS builbot server in order to get the details of each +run to finally obtain the URL with the zip file for the results. + +The tool now automatically applies platform-specific and generic +results automatically (its not longer needed to specify whether +the result its generic or not). It uses mac-wk2 results as generic. + +Also now it updates the test results for tests where the result +is MISSING. + +* Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py: +(configure_logging): +(argument_parser): +(TestExpectationUpdater.__init__): +(TestExpectationUpdater._platform_name): +(TestExpectationUpdater): +(TestExpectationUpdater._get_layout_tests_run): +(TestExpectationUpdater._lookup_ews_results): +(TestExpectationUpdater._tests_to_update): +(TestExpectationUpdater._update_for_generic_bot): +(TestExpectationUpdater._update_for_platform_specific_bot): +(TestExpectationUpdater.do_update): +(main): +* Scripts/webkitpy/common/net/bugzilla/test_expectation_updater_unittest.py: +(MockAttachment.__init__): +(MockAttachment.is_patch): +(MockAttachment): +(MockAttachment.is_obsolete): +(MockBugzilla): +(MockBugzilla.attachments): +(MockRequests): +(MockRequests.__init__): +(MockRequests.get): +(MockRequests.content): +(MockRequests.text): +(MockZip.__init__): +(TestExpectationUpdaterTest.test_update_test_expectations): + 2020-05-20 Carlos Garcia Campos Unreviewed. Fix GTK4 build with GTK 3.98.4 Modified: trunk/Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py (261913 => 261914) --- trunk/Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py 2020-05-20 13:22:15 UTC (rev 261913) +++ trunk/Tools/Scripts/webkitpy/common/net/bugzilla/test_expectation_updater.py 2020-05-20 13:29:09 UTC (rev 261914) @@ -1,6 +1,7 @@ #!/usr/bin/env python # Copyright (C) 2017 Apple Inc. All rights reserved. +# Copyright (C) 2020 Igalia S.L. # # Redistribution and use in source and binary forms, with or without # modification, are permitted provided that the following conditions @@ -32,6 +33,7 @@
[webkit-changes] [261871] trunk/Tools
Title: [261871] trunk/Tools
Revision 261871
Author clo...@igalia.com
Date 2020-05-19 11:06:15 -0700 (Tue, 19 May 2020)
Log Message
[buildbot][GTK][WPE] Pass --verbose flag when running _javascript_Core tests
https://bugs.webkit.org/show_bug.cgi?id=212088
Reviewed by Philippe Normand.
Pass the "--verbose" flag to run-_javascript_core-tests also for GTK and WPE.
Also change the way we are currently passing "--memory-limited" to make
it more obvious that this is needed for all Linux bots (GTK+WPE+JSCOnly).
* BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunJavaScriptCoreTests.start):
(RunRemoteJavaScriptCoreTests.start):
Modified Paths
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py
trunk/Tools/ChangeLog
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py (261870 => 261871)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2020-05-19 17:53:51 UTC (rev 261870)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py 2020-05-19 18:06:15 UTC (rev 261871)
@@ -381,11 +381,11 @@
architecture = self.getProperty("architecture")
# Currently run-_javascript_core-test doesn't support run _javascript_ core test binaries list below remotely
if architecture in ['mips', 'armv7', 'aarch64']:
-self.command += ['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--verbose']
+self.command += ['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi']
# Linux bots have currently problems with JSC tests that try to use large amounts of memory.
# Check: https://bugs.webkit.org/show_bug.cgi?id=175140
-if platform in ('gtk', 'wpe'):
-self.setCommand(self.command + ['--memory-limited'])
+if platform in ('gtk', 'wpe', 'jsc-only'):
+self.setCommand(self.command + ['--memory-limited', '--verbose'])
# WinCairo uses the Windows command prompt, not Cygwin.
elif platform == 'wincairo':
self.setCommand(self.command + ['--test-writer=ruby'])
@@ -414,7 +414,7 @@
class RunRemoteJavaScriptCoreTests(RunJavaScriptCoreTests):
def start(self):
-self.setCommand(self.command + ["--memory-limited", "--remote-config-file", "../../remote-jsc-tests-config.json"])
+self.setCommand(self.command + ["--remote-config-file", "../../remote-jsc-tests-config.json"])
return RunJavaScriptCoreTests.start(self)
Modified: trunk/Tools/ChangeLog (261870 => 261871)
--- trunk/Tools/ChangeLog 2020-05-19 17:53:51 UTC (rev 261870)
+++ trunk/Tools/ChangeLog 2020-05-19 18:06:15 UTC (rev 261871)
@@ -1,3 +1,18 @@
+2020-05-19 Carlos Alberto Lopez Perez
+
+[buildbot][GTK][WPE] Pass --verbose flag when running _javascript_Core tests
+https://bugs.webkit.org/show_bug.cgi?id=212088
+
+Reviewed by Philippe Normand.
+
+Pass the "--verbose" flag to run-_javascript_core-tests also for GTK and WPE.
+Also change the way we are currently passing "--memory-limited" to make
+it more obvious that this is needed for all Linux bots (GTK+WPE+JSCOnly).
+
+* BuildSlaveSupport/build.webkit.org-config/steps.py:
+(RunJavaScriptCoreTests.start):
+(RunRemoteJavaScriptCoreTests.start):
+
2020-05-19 Michael Catanzaro
Fixups for r261689 "stress/array-buffer-view-watchpoint-can-be-fired-in-really-add-in-dfg.js failing on ppc64le and s390x"
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [261552] trunk/Tools
Title: [261552] trunk/Tools
Revision 261552
Author clo...@igalia.com
Date 2020-05-12 04:17:57 -0700 (Tue, 12 May 2020)
Log Message
WPT test importer fails to update references in tags
https://bugs.webkit.org/show_bug.cgi?id=211762
Reviewed by Youenn Fablet.
When importing WPT test references, ensure relative paths are also
updated for the href attribute in tags.
Also fix a bug that was causing wrong updates on the paths due to
the characters in reference_relpath not escaped when performing
the regex substitution in convert_reference_relpaths(). For example:
"resources/script.js" was changed to "resourcscript.js" when reference_relpath was '../'
Improve also the unit test case to check for the fixes in this patch.
* Scripts/webkitpy/w3c/test_converter.py:
(_W3CTestConverter.convert_reference_relpaths):
(_W3CTestConverter.convert_attributes_if_needed):
* Scripts/webkitpy/w3c/test_converter_unittest.py:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/w3c/test_converter.py
trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
Diff
Modified: trunk/Tools/ChangeLog (261551 => 261552)
--- trunk/Tools/ChangeLog 2020-05-12 10:51:03 UTC (rev 261551)
+++ trunk/Tools/ChangeLog 2020-05-12 11:17:57 UTC (rev 261552)
@@ -1,3 +1,24 @@
+2020-05-12 Carlos Alberto Lopez Perez
+
+WPT test importer fails to update references in tags
+https://bugs.webkit.org/show_bug.cgi?id=211762
+
+Reviewed by Youenn Fablet.
+
+When importing WPT test references, ensure relative paths are also
+updated for the href attribute in tags.
+Also fix a bug that was causing wrong updates on the paths due to
+the characters in reference_relpath not escaped when performing
+the regex substitution in convert_reference_relpaths(). For example:
+"resources/script.js" was changed to "resourcscript.js" when reference_relpath was '../'
+
+Improve also the unit test case to check for the fixes in this patch.
+
+* Scripts/webkitpy/w3c/test_converter.py:
+(_W3CTestConverter.convert_reference_relpaths):
+(_W3CTestConverter.convert_attributes_if_needed):
+* Scripts/webkitpy/w3c/test_converter_unittest.py:
+
2020-05-12 Philippe Normand
[Flatpak SDK] Include clang++ and g++ in toolchains
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_converter.py (261551 => 261552)
--- trunk/Tools/Scripts/webkitpy/w3c/test_converter.py 2020-05-12 10:51:03 UTC (rev 261551)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_converter.py 2020-05-12 11:17:57 UTC (rev 261552)
@@ -186,8 +186,8 @@
if converted.find(path) != -1:
# FIXME: This doesn't handle an edge case where simply removing the relative path doesn't work.
# See http://webkit.org/b/135677 for details.
-new_path = re.sub(self.reference_support_info['reference_relpath'], '', path, 1)
-converted = re.sub(path, new_path, converted)
+new_path = re.sub(re.escape(self.reference_support_info['reference_relpath']), '', path, 1)
+converted = re.sub(re.escape(path), new_path, converted)
return converted
@@ -219,13 +219,19 @@
new_style = self.convert_style_data(attr[1])
converted = re.sub(re.escape(attr[1]), new_style, converted)
+# Convert relative paths
src_tags = ('script', 'style', 'img', 'frame', 'iframe', 'input', 'layer', 'textarea', 'video', 'audio')
-if tag in src_tags and self.reference_support_info is not None and self.reference_support_info != {}:
-for attr_name, attr_value in attrs:
-if attr_name == 'src':
-new_path = self.convert_reference_relpaths(attr_value)
-converted = re.sub(re.escape(attr_value), new_path, converted)
-
+if self.reference_support_info is not None and self.reference_support_info != {}:
+if tag in src_tags:
+for attr_name, attr_value in attrs:
+if attr_name == 'src':
+new_path = self.convert_reference_relpaths(attr_value)
+converted = re.sub(re.escape(attr_value), new_path, converted)
+if tag == 'link':
+for attr_name, attr_value in attrs:
+if attr_name == 'href':
+new_path = self.convert_reference_relpaths(attr_value)
+converted = re.sub(re.escape(attr_value), new_path, converted)
self.converted_data.append(converted)
def add_webkit_test_runner_options_if_needed(self):
Modified: trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py (261551 => 261552)
--- trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py 2020-05-12 10:51:03 UTC (rev 261551)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py 2020-05-12 11:17:57 UTC (rev 261552)
@@ -296,6
[webkit-changes] [260430] trunk/LayoutTests
Title: [260430] trunk/LayoutTests Revision 260430 Author clo...@igalia.com Date 2020-04-21 09:12:38 -0700 (Tue, 21 Apr 2020) Log Message [GTK] Gardening of WPT tests for Intersection Observer v2 after r260388 Unreviewed. * platform/gtk/TestExpectations: Due to the override for Pass/Fail in the folder above its needed to repeat the Skip expectation here to avoid the Missing result. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (260429 => 260430) --- trunk/LayoutTests/ChangeLog 2020-04-21 16:05:46 UTC (rev 260429) +++ trunk/LayoutTests/ChangeLog 2020-04-21 16:12:38 UTC (rev 260430) @@ -1,3 +1,12 @@ +2020-04-21 Carlos Alberto Lopez Perez + +[GTK] Gardening of WPT tests for Intersection Observer v2 after r260388 + +Unreviewed. + +* platform/gtk/TestExpectations: Due to the override for Pass/Fail in the folder above +its needed to repeat the Skip expectation here to avoid the Missing result. + 2020-04-20 Diego Pino Garcia [GTK] Gardening, update expectations after r260356 Modified: trunk/LayoutTests/platform/gtk/TestExpectations (260429 => 260430) --- trunk/LayoutTests/platform/gtk/TestExpectations 2020-04-21 16:05:46 UTC (rev 260429) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-04-21 16:12:38 UTC (rev 260430) @@ -4370,6 +4370,8 @@ webkit.org/b/191000 imported/w3c/web-platform-tests/shadow-dom/input-element-list.html [ Failure ] webkit.org/b/191002 imported/w3c/web-platform-tests/intersection-observer/ [ Pass Failure ] +webkit.org/b/208052 imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-effects.sub.html [ Skip ] +webkit.org/b/208052 imported/w3c/web-platform-tests/intersection-observer/v2/cross-origin-occlusion.sub.html [ Skip ] webkit.org/b/191003 imported/w3c/web-platform-tests/mimesniff/mime-types/charset-parameter.window.html [ Failure ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
