[webkit-changes] [208557] trunk/LayoutTests

[ryanhaddad]

Title: [208557] trunk/LayoutTests








Revision 208557
Author ryanhad...@apple.com
Date 2016-11-10 12:07:06 -0800 (Thu, 10 Nov 2016)


Log Message
Marking inspector/sampling-profiler tests as flaky timeouts.
https://bugs.webkit.org/show_bug.cgi?id=164388

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208556 => 208557)

--- trunk/LayoutTests/ChangeLog	2016-11-10 20:05:52 UTC (rev 208556)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 20:07:06 UTC (rev 208557)
@@ -1,5 +1,14 @@
 2016-11-10  Ryan Haddad  
 
+Marking inspector/sampling-profiler tests as flaky timeouts.
+https://bugs.webkit.org/show_bug.cgi?id=164388
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2016-11-10  Ryan Haddad  
+
 Marking http/tests/cache/disk-cache/disk-cache-request-headers.html as flaky on ios-simulator.
 https://bugs.webkit.org/show_bug.cgi?id=164594
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (208556 => 208557)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 20:05:52 UTC (rev 208556)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 20:07:06 UTC (rev 208557)
@@ -1467,7 +1467,6 @@
 
 webkit.org/b/164277 fast/preloader/image-srcset.html [ Pass Failure ]
 
-webkit.org/b/164388 inspector/sampling-profiler/call-frame-with-dom-functions.html [ Pass Timeout ]
-webkit.org/b/164388 inspector/sampling-profiler/_expression_-location-info.html [ Pass Timeout ]
+webkit.org/b/164388 inspector/sampling-profiler [ Pass Timeout ]
 
 webkit.org/b/164570 fast/loader/reload-zero-byte-plugin.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208562] trunk/Source/bmalloc

[ggaren]

Title: [208562] trunk/Source/bmalloc








Revision 208562
Author gga...@apple.com
Date 2016-11-10 13:40:56 -0800 (Thu, 10 Nov 2016)


Log Message
bmalloc threads should have a non-default QoS
https://bugs.webkit.org/show_bug.cgi?id=164612

Reviewed by Filip Pizlo.

* bmalloc/AsyncTask.h:
(bmalloc::Function>::threadEntryPoint): Request user-interactive quality
of service because user-interactive tasks use malloc.

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/AsyncTask.h




Diff

Modified: trunk/Source/bmalloc/ChangeLog (208561 => 208562)

--- trunk/Source/bmalloc/ChangeLog	2016-11-10 21:31:01 UTC (rev 208561)
+++ trunk/Source/bmalloc/ChangeLog	2016-11-10 21:40:56 UTC (rev 208562)
@@ -1,3 +1,14 @@
+2016-11-10  Geoffrey Garen  
+
+bmalloc threads should have a non-default QoS
+https://bugs.webkit.org/show_bug.cgi?id=164612
+
+Reviewed by Filip Pizlo.
+
+* bmalloc/AsyncTask.h:
+(bmalloc::Function>::threadEntryPoint): Request user-interactive quality
+of service because user-interactive tasks use malloc.
+
 2016-10-20  Mark Lam  
 
 bmalloc api should crash on failure to allocate when !isBmallocEnabled.


Modified: trunk/Source/bmalloc/bmalloc/AsyncTask.h (208561 => 208562)

--- trunk/Source/bmalloc/bmalloc/AsyncTask.h	2016-11-10 21:31:01 UTC (rev 208561)
+++ trunk/Source/bmalloc/bmalloc/AsyncTask.h	2016-11-10 21:40:56 UTC (rev 208562)
@@ -103,6 +103,10 @@
 template
 void AsyncTask::threadEntryPoint(AsyncTask* asyncTask)
 {
+#if BOS(DARWIN)
+pthread_set_qos_class_self_np(QOS_CLASS_USER_INTERACTIVE, 0);
+#endif
+
 asyncTask->threadRunLoop();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208566] trunk/LayoutTests

[ryanhaddad]

Title: [208566] trunk/LayoutTests








Revision 208566
Author ryanhad...@apple.com
Date 2016-11-10 15:03:28 -0800 (Thu, 10 Nov 2016)


Log Message
Marking swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=164572

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208565 => 208566)

--- trunk/LayoutTests/ChangeLog	2016-11-10 22:21:35 UTC (rev 208565)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 23:03:28 UTC (rev 208566)
@@ -1,3 +1,12 @@
+2016-11-10  Ryan Haddad  
+
+Marking swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html as failing.
+https://bugs.webkit.org/show_bug.cgi?id=164572
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
 2016-11-10  Ryosuke Niwa  
 
 Copied text would contain text inside CDATA sections and comments


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (208565 => 208566)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-11-10 22:21:35 UTC (rev 208565)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2016-11-10 23:03:28 UTC (rev 208566)
@@ -599,3 +599,6 @@
 webkit.org/b/163453 [ Sierra Release ] http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade-cors.https.html [ Pass Timeout ]
 
 webkit.org/b/163702 platform/mac-wk2/plugins/muted-state.html [ Failure ]
+
+webkit.org/b/164572 [ ElCapitan ] swipe/main-frame-pinning-requirement.html [ Failure ]
+webkit.org/b/164572 [ ElCapitan ] swipe/pushState-cached-back-swipe.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208556] trunk/Source

[commit-queue]

Title: [208556] trunk/Source








Revision 208556
Author commit-qu...@webkit.org
Date 2016-11-10 12:05:52 -0800 (Thu, 10 Nov 2016)


Log Message
Remove unused CFURLCACHE code
https://bugs.webkit.org/show_bug.cgi?id=164551

Patch by Alex Christensen  on 2016-11-10
Reviewed by Antti Koivisto.

Source/WebKit2:

WebKit2 doesn't use CFURLCache, but we still have some unused code that seems to use it.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::fetchDiskCacheEntries):
(WebKit::clearDiskCacheEntries):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::partitionName): Deleted.
(WebKit::NetworkProcess::cfURLCacheOrigins): Deleted.
(WebKit::NetworkProcess::clearCFURLCacheForOrigins): Deleted.

Source/WTF:

* wtf/Platform.h:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Platform.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp
trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h
trunk/Source/WebKit2/NetworkProcess/cocoa/NetworkProcessCocoa.mm




Diff

Modified: trunk/Source/WTF/ChangeLog (208555 => 208556)

--- trunk/Source/WTF/ChangeLog	2016-11-10 19:44:51 UTC (rev 208555)
+++ trunk/Source/WTF/ChangeLog	2016-11-10 20:05:52 UTC (rev 208556)
@@ -1,3 +1,12 @@
+2016-11-10  Alex Christensen  
+
+Remove unused CFURLCACHE code
+https://bugs.webkit.org/show_bug.cgi?id=164551
+
+Reviewed by Antti Koivisto.
+
+* wtf/Platform.h:
+
 2016-11-09  Alex Christensen  
 
 Allow RefPtrs of const ThreadSafeRefCounted types


Modified: trunk/Source/WTF/wtf/Platform.h (208555 => 208556)

--- trunk/Source/WTF/wtf/Platform.h	2016-11-10 19:44:51 UTC (rev 208555)
+++ trunk/Source/WTF/wtf/Platform.h	2016-11-10 20:05:52 UTC (rev 208556)
@@ -600,10 +600,6 @@
 #define USE_CFURLCONNECTION 1
 #endif
 
-#if USE(CFURLCONNECTION) || PLATFORM(COCOA)
-#define USE_CFURLCACHE 1
-#endif
-
 #if !defined(HAVE_ACCESSIBILITY)
 #if PLATFORM(COCOA) || PLATFORM(WIN) || PLATFORM(GTK) || PLATFORM(EFL)
 #define HAVE_ACCESSIBILITY 1


Modified: trunk/Source/WebKit2/ChangeLog (208555 => 208556)

--- trunk/Source/WebKit2/ChangeLog	2016-11-10 19:44:51 UTC (rev 208555)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-10 20:05:52 UTC (rev 208556)
@@ -1,3 +1,21 @@
+2016-11-10  Alex Christensen  
+
+Remove unused CFURLCACHE code
+https://bugs.webkit.org/show_bug.cgi?id=164551
+
+Reviewed by Antti Koivisto.
+
+WebKit2 doesn't use CFURLCache, but we still have some unused code that seems to use it.
+
+* NetworkProcess/NetworkProcess.cpp:
+(WebKit::fetchDiskCacheEntries):
+(WebKit::clearDiskCacheEntries):
+* NetworkProcess/NetworkProcess.h:
+* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
+(WebKit::partitionName): Deleted.
+(WebKit::NetworkProcess::cfURLCacheOrigins): Deleted.
+(WebKit::NetworkProcess::clearCFURLCacheForOrigins): Deleted.
+
 2016-11-10  Carlos Garcia Campos  
 
 [Linux] Memory process values shown by the WebMemorySampler in linux are wrong


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp (208555 => 208556)

--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp	2016-11-10 19:44:51 UTC (rev 208555)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.cpp	2016-11-10 20:05:52 UTC (rev 208556)
@@ -336,15 +336,8 @@
 }
 #endif
 
-Vector entries;
-
-#if USE(CFURLCACHE)
-for (auto& origin : NetworkProcess::cfURLCacheOrigins())
-entries.append(WebsiteData::Entry { WTFMove(origin), WebsiteDataType::DiskCache, 0 });
-#endif
-
-RunLoop::main().dispatch([completionHandler = WTFMove(completionHandler), entries = WTFMove(entries)] {
-completionHandler(entries);
+RunLoop::main().dispatch([completionHandler = WTFMove(completionHandler)] {
+completionHandler({ });
 });
 }
 
@@ -438,10 +431,6 @@
 }
 #endif
 
-#if USE(CFURLCACHE)
-NetworkProcess::clearCFURLCacheForOrigins(origins);
-#endif
-
 RunLoop::main().dispatch(WTFMove(completionHandler));
 }
 


Modified: trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h (208555 => 208556)

--- trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h	2016-11-10 19:44:51 UTC (rev 208555)
+++ trunk/Source/WebKit2/NetworkProcess/NetworkProcess.h	2016-11-10 20:05:52 UTC (rev 208556)
@@ -96,11 +96,6 @@
 void logDiagnosticMessageWithResult(uint64_t webPageID, const String& message, const String& description, WebCore::DiagnosticLoggingResultType, WebCore::ShouldSample);
 void logDiagnosticMessageWithValue(uint64_t webPageID, const String& message, const String& description, const String& value, WebCore::ShouldSample);
 
-#if USE(CFURLCACHE)
-static Vector cfURLCacheOrigins();
-static void clearCFURLCacheForOrigins(const Vector&);
-#endif
-
 #if PLATFORM(COCOA)
 RetainPtr 

[webkit-changes] [208564] trunk

[commit-queue]

Title: [208564] trunk








Revision 208564
Author commit-qu...@webkit.org
Date 2016-11-10 14:03:24 -0800 (Thu, 10 Nov 2016)


Log Message
test262: DataView / TypedArray methods should throw RangeErrors for negative numbers (ToIndex)
https://bugs.webkit.org/show_bug.cgi?id=164450

Patch by Joseph Pecoraro  on 2016-11-10
Reviewed by Darin Adler.

JSTests:

* stress/dataview-typedarray-toindex.js: Added.
Tests for all cases where ToIndex should be used.

* test262.yaml:
New passing tests.

Source/_javascript_Core:

* runtime/JSCJSValue.h:
* runtime/JSCJSValueInlines.h:
(JSC::JSValue::toIndex):
Introduce a method for toIndex, which is used by DataView and TypedArrays
to convert an argument to a number with the possibility of throwing
RangeErrors for negative values. We also throw RangeErrors for large
values, because wherever this is used we expect an unsigned.

* runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer):
* runtime/JSDataViewPrototype.cpp:
(JSC::getData):
(JSC::setData):
* runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
(JSC::constructGenericTypedArrayView):
Use toIndex instead of toUint32 where required.

LayoutTests:

* fast/canvas/webgl/data-view-crash-expected.txt:
* fast/canvas/webgl/data-view-test-expected.txt:
Better error message.

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/test262.yaml
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/canvas/webgl/data-view-crash-expected.txt
trunk/LayoutTests/fast/canvas/webgl/data-view-test-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/runtime/JSArrayBufferConstructor.cpp
trunk/Source/_javascript_Core/runtime/JSCJSValue.h
trunk/Source/_javascript_Core/runtime/JSCJSValueInlines.h
trunk/Source/_javascript_Core/runtime/JSDataViewPrototype.cpp
trunk/Source/_javascript_Core/runtime/JSGenericTypedArrayViewConstructorInlines.h


Added Paths

trunk/JSTests/stress/dataview-typedarray-toindex.js




Diff

Modified: trunk/JSTests/ChangeLog (208563 => 208564)

--- trunk/JSTests/ChangeLog	2016-11-10 21:42:33 UTC (rev 208563)
+++ trunk/JSTests/ChangeLog	2016-11-10 22:03:24 UTC (rev 208564)
@@ -1,3 +1,16 @@
+2016-11-10  Joseph Pecoraro  
+
+test262: DataView / TypedArray methods should throw RangeErrors for negative numbers (ToIndex)
+https://bugs.webkit.org/show_bug.cgi?id=164450
+
+Reviewed by Darin Adler.
+
+* stress/dataview-typedarray-toindex.js: Added.
+Tests for all cases where ToIndex should be used.
+
+* test262.yaml:
+New passing tests.
+
 2016-11-10  Mark Lam  
 
 Graph::methodOfGettingAValueProfileFor() should be returning the profile for the operand node.


Added: trunk/JSTests/stress/dataview-typedarray-toindex.js (0 => 208564)

--- trunk/JSTests/stress/dataview-typedarray-toindex.js	(rev 0)
+++ trunk/JSTests/stress/dataview-typedarray-toindex.js	2016-11-10 22:03:24 UTC (rev 208564)
@@ -0,0 +1,121 @@
+function assert(condition) {
+if (!condition)
+throw new Error("Bad assertion");
+}
+
+function shouldThrowRangeError(func) {
+var errorThrown = false;
+var error = null;
+try {
+func();
+} catch (e) {
+errorThrown = true;
+error = e;
+}
+if (!errorThrown)
+throw new Error('not thrown');
+if (!(error instanceof RangeError))
+throw new Error(`bad error: ${String(error)}`);
+}
+
+// ToIndex (value) https://tc39.github.io/ecma262/#sec-toindex
+// - Convert undefined to 0.
+// - Convert value to Integer, and throws a RangeError if negative.
+// - _javascript_Core also throws a TypeError for Infinity because that would convert tp 2^53 - 1 which is too large for all cases.
+
+let buffer = new ArrayBuffer(128);
+let dataView = new DataView(buffer);
+let rangeErrorValues = [-1, -Infinity, Infinity];
+let typedArrays = [Int8Array, Uint8Array, Uint8ClampedArray, Int16Array, Uint16Array, Int32Array, Uint32Array, Float32Array, Float64Array];
+
+// ArrayBuffer(length*) https://tc39.github.io/ecma262/#sec-arraybuffer-length
+assert((new ArrayBuffer).byteLength === 0);
+assert((new ArrayBuffer(undefined)).byteLength === 0);
+assert((new ArrayBuffer(-0.9)).byteLength === 0);
+assert((new ArrayBuffer(2.5)).byteLength === 2);
+for (let badValue of rangeErrorValues)
+shouldThrowRangeError(() => { new ArrayBuffer(badValue); });
+
+// TypedArray(length*) https://tc39.github.io/ecma262/#sec-typedarray-length
+// TypedArray(buffer, byteOffset*, length*) https://tc39.github.io/ecma262/#sec-typedarray-buffer-byteoffset-length
+for (let typedArray of typedArrays) {
+assert((new typedArray).length === 0);
+assert((new typedArray(2.5)).length === 2);
+assert((new typedArray(-0.9)).length === 0);
+assert((new typedArray(buffer, typedArray.BYTES_PER_ELEMENT + 0.5)).byteOffset === typedArray.BYTES_PER_ELEMENT);
+

[webkit-changes] [208561] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [208561] trunk/Source/WebInspectorUI








Revision 208561
Author nvasil...@apple.com
Date 2016-11-10 13:31:01 -0800 (Thu, 10 Nov 2016)


Log Message
Web Inspector: Call RuntimeAgent.disableControlFlowProfiler when Code Coverage Profiler is turned off
https://bugs.webkit.org/show_bug.cgi?id=163407


Reviewed by Joseph Pecoraro.

Turning Code Coverage off by clicking [C] icon now disables its backend by calling RuntimeAgent.disableControlFlowProfiler().

* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor.prototype.set _basicBlockAnnotatorEnabled):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (208560 => 208561)

--- trunk/Source/WebInspectorUI/ChangeLog	2016-11-10 21:19:52 UTC (rev 208560)
+++ trunk/Source/WebInspectorUI/ChangeLog	2016-11-10 21:31:01 UTC (rev 208561)
@@ -1,3 +1,16 @@
+2016-11-10  Nikita Vasilyev  
+
+Web Inspector: Call RuntimeAgent.disableControlFlowProfiler when Code Coverage Profiler is turned off
+https://bugs.webkit.org/show_bug.cgi?id=163407
+
+
+Reviewed by Joseph Pecoraro.
+
+Turning Code Coverage off by clicking [C] icon now disables its backend by calling RuntimeAgent.disableControlFlowProfiler().
+
+* UserInterface/Views/SourceCodeTextEditor.js:
+(WebInspector.SourceCodeTextEditor.prototype.set _basicBlockAnnotatorEnabled):
+
 2016-11-10  Aaron Chu  
 
 Web Inspector: AXI: clarify button roles (e.g. toggle or popup button)


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js (208560 => 208561)

--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2016-11-10 21:19:52 UTC (rev 208560)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.js	2016-11-10 21:31:01 UTC (rev 208561)
@@ -1909,6 +1909,7 @@
 if (!this._controlFlowScrollHandler)
 this._enableScrollEventsForControlFlowAnnotator();
 } else {
+RuntimeAgent.disableControlFlowProfiler();
 this._basicBlockAnnotator.clear();
 
 if (this._controlFlowScrollHandler)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208567] trunk

[jfbastien]

Title: [208567] trunk








Revision 208567
Author jfbast...@apple.com
Date 2016-11-10 15:07:15 -0800 (Thu, 10 Nov 2016)


Log Message
ASSERTION FAILED: length > offset encountered with wasm.yaml/wasm/js-api/test_Module.js.default-wasm
https://bugs.webkit.org/show_bug.cgi?id=164597

Reviewed by Keith Miller.

JSTests:

Trim the array buffer before returning it: it's optimistically
over-allocated to avoid growing all the time, but when parsed it
can't have extra content.

* wasm/Builder_WebAssemblyBinary.js:
(export.const.Binary):
* wasm/LowLevelBinary.js:
(export.default.LowLevelBinary.prototype.get return):

Source/_javascript_Core:

* wasm/WasmParser.h:
(JSC::Wasm::Parser::parseVarUInt32): move closer to other parsers
(JSC::Wasm::Parser::parseVarUInt64): move closer to other parsers

Source/WTF:

Decoding at end of file should fail, not assert.

* wtf/LEBDecoder.h:
(WTF::LEBDecoder::decodeUInt):
(WTF::LEBDecoder::decodeInt32):

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/wasm/Builder_WebAssemblyBinary.js
trunk/JSTests/wasm/LowLevelBinary.js
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/wasm/WasmParser.h
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/LEBDecoder.h




Diff

Modified: trunk/JSTests/ChangeLog (208566 => 208567)

--- trunk/JSTests/ChangeLog	2016-11-10 23:03:28 UTC (rev 208566)
+++ trunk/JSTests/ChangeLog	2016-11-10 23:07:15 UTC (rev 208567)
@@ -1,3 +1,19 @@
+2016-11-10  JF Bastien  
+
+ASSERTION FAILED: length > offset encountered with wasm.yaml/wasm/js-api/test_Module.js.default-wasm
+https://bugs.webkit.org/show_bug.cgi?id=164597
+
+Reviewed by Keith Miller.
+
+Trim the array buffer before returning it: it's optimistically
+over-allocated to avoid growing all the time, but when parsed it
+can't have extra content.
+
+* wasm/Builder_WebAssemblyBinary.js:
+(export.const.Binary):
+* wasm/LowLevelBinary.js:
+(export.default.LowLevelBinary.prototype.get return):
+
 2016-11-10  Joseph Pecoraro  
 
 test262: DataView / TypedArray methods should throw RangeErrors for negative numbers (ToIndex)


Modified: trunk/JSTests/wasm/Builder_WebAssemblyBinary.js (208566 => 208567)

--- trunk/JSTests/wasm/Builder_WebAssemblyBinary.js	2016-11-10 23:03:28 UTC (rev 208566)
+++ trunk/JSTests/wasm/Builder_WebAssemblyBinary.js	2016-11-10 23:07:15 UTC (rev 208567)
@@ -103,5 +103,6 @@
 }
 sectionBin.apply();
 }
+wasmBin.trim();
 return wasmBin;
 };


Modified: trunk/JSTests/wasm/LowLevelBinary.js (208566 => 208567)

--- trunk/JSTests/wasm/LowLevelBinary.js	2016-11-10 23:03:28 UTC (rev 208566)
+++ trunk/JSTests/wasm/LowLevelBinary.js	2016-11-10 23:07:15 UTC (rev 208567)
@@ -76,6 +76,7 @@
 // Utilities.
 get() { return this._buf; }
 hexdump() { return _hexdump(this._buf, this._used); }
+trim() { this._buf = this._buf.slice(0, this._used); }
 _maybeGrow(bytes) {
 const allocated = this._buf.length;
 if (allocated - this._used < bytes) {


Modified: trunk/Source/_javascript_Core/ChangeLog (208566 => 208567)

--- trunk/Source/_javascript_Core/ChangeLog	2016-11-10 23:03:28 UTC (rev 208566)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-11-10 23:07:15 UTC (rev 208567)
@@ -1,3 +1,14 @@
+2016-11-10  JF Bastien  
+
+ASSERTION FAILED: length > offset encountered with wasm.yaml/wasm/js-api/test_Module.js.default-wasm
+https://bugs.webkit.org/show_bug.cgi?id=164597
+
+Reviewed by Keith Miller.
+
+* wasm/WasmParser.h:
+(JSC::Wasm::Parser::parseVarUInt32): move closer to other parsers
+(JSC::Wasm::Parser::parseVarUInt64): move closer to other parsers
+
 2016-11-10  Joseph Pecoraro  
 
 test262: DataView / TypedArray methods should throw RangeErrors for negative numbers (ToIndex)


Modified: trunk/Source/_javascript_Core/wasm/WasmParser.h (208566 => 208567)

--- trunk/Source/_javascript_Core/wasm/WasmParser.h	2016-11-10 23:03:28 UTC (rev 208566)
+++ trunk/Source/_javascript_Core/wasm/WasmParser.h	2016-11-10 23:07:15 UTC (rev 208567)
@@ -46,15 +46,15 @@
 bool WARN_UNUSED_RETURN consumeString(const char*);
 bool WARN_UNUSED_RETURN consumeUTF8String(String&, size_t);
 
-bool WARN_UNUSED_RETURN parseVarUInt1(uint8_t& result);
-bool WARN_UNUSED_RETURN parseInt7(int8_t& result);
-bool WARN_UNUSED_RETURN parseUInt7(uint8_t& result);
-bool WARN_UNUSED_RETURN parseUInt32(uint32_t& result);
-bool WARN_UNUSED_RETURN parseVarUInt32(uint32_t& result) { return WTF::LEBDecoder::decodeUInt32(m_source, m_sourceLength, m_offset, result); }
-bool WARN_UNUSED_RETURN parseVarUInt64(uint64_t& result) { return WTF::LEBDecoder::decodeUInt64(m_source, m_sourceLength, m_offset, result); }
+bool WARN_UNUSED_RETURN parseVarUInt1(uint8_t&);
+bool WARN_UNUSED_RETURN parseInt7(int8_t&);
+bool 

[webkit-changes] [208560] trunk

[mark . lam]

Title: [208560] trunk








Revision 208560
Author mark@apple.com
Date 2016-11-10 13:19:52 -0800 (Thu, 10 Nov 2016)


Log Message
Graph::methodOfGettingAValueProfileFor() should be returning the profile for the operand node.
https://bugs.webkit.org/show_bug.cgi?id=164600


Reviewed by Filip Pizlo.

JSTests:

* stress/osr-exit-on-op-negate-should-no-fail-assertions.js: Added.

Source/_javascript_Core:

Currently, Graph::methodOfGettingAValueProfileFor() assumes that the operand DFG
node that it is provided with always has a different origin than the node that is
using that operand.  For example, in a DFG graph that looks like this:

a: ...
b: ArithAdd(@a, ...)

... when emitting speculation checks on @a for the ArithAdd node at @b,
Graph::methodOfGettingAValueProfileFor() is passed @a, and expects @a's to
originate from a different bytecode than @b.  The intent here is to get the
profile for @a so that the OSR exit ramp for @b can update @a's profile with the
observed result type from @a so that future type prediction on incoming args for
the ArithAdd node can take this into consideration.

However, op_negate can be compiled into the following series of nodes:

a: ...
b: BooleanToNumber(@a)
c: DoubleRep(@b)
d: ArithNegate(@c)

All 3 nodes @b, @c, and @d maps to the same op_negate bytecode i.e. they have the
same origin.  When the speculativeJIT emits a speculationCheck for DoubleRep, it
calls Graph::methodOfGettingAValueProfileFor() to get the ArithProfile for the
BooleanToNumber node.  But because all 3 nodes have the same origin,
Graph::methodOfGettingAValueProfileFor() erroneously returns the ArithProfile for
the op_negate.  Subsequently, the OSR exit ramp will modify the ArithProfile of
the op_negate and corrupt its profile.  Instead, what the OSR exit ramp should be
doing is update the ArithProfile of op_negate's operand i.e. BooleanToNumber's
operand @a in this case.

The fix is to always pass the current node we're generating code for (in addition
to the operand node) to Graph::methodOfGettingAValueProfileFor().  This way, we
know the profile is valid if and only if the current node and its operand node
does not have the same origin.

In this patch, we also fixed the following:
1. Teach Graph::methodOfGettingAValueProfileFor() to get the profile for
   BooleanToNumber's operand if the operand node it is given is BooleanToNumber.
2. Change JITCompiler::appendExceptionHandlingOSRExit() to explicitly pass an
   empty MethodOfGettingAValueProfile().  It was implicitly doing this before.
3. Change SpeculativeJIT::emitInvalidationPoint() to pass an empty
   MethodOfGettingAValueProfile().  It has no child node.  Hence, it doesn't
   make sense to call Graph::methodOfGettingAValueProfileFor() for a child node
   that does not exist.

* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):
* dfg/DFGGraph.h:
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::appendExceptionHandlingOSRExit):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::emitInvalidationPoint):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::appendOSRExitDescriptor):

Modified Paths

trunk/JSTests/ChangeLog
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGGraph.cpp
trunk/Source/_javascript_Core/dfg/DFGGraph.h
trunk/Source/_javascript_Core/dfg/DFGJITCompiler.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/ftl/FTLLowerDFGToB3.cpp


Added Paths

trunk/JSTests/stress/osr-exit-on-op-negate-should-no-fail-assertions.js




Diff

Modified: trunk/JSTests/ChangeLog (208559 => 208560)

--- trunk/JSTests/ChangeLog	2016-11-10 20:52:54 UTC (rev 208559)
+++ trunk/JSTests/ChangeLog	2016-11-10 21:19:52 UTC (rev 208560)
@@ -1,3 +1,13 @@
+2016-11-10  Mark Lam  
+
+Graph::methodOfGettingAValueProfileFor() should be returning the profile for the operand node.
+https://bugs.webkit.org/show_bug.cgi?id=164600
+
+
+Reviewed by Filip Pizlo.
+
+* stress/osr-exit-on-op-negate-should-no-fail-assertions.js: Added.
+
 2016-11-08  Yusuke Suzuki  
 
 [JSC] Avoid cloned arguments allocation in ArrayPrototype methods


Added: trunk/JSTests/stress/osr-exit-on-op-negate-should-no-fail-assertions.js (0 => 208560)

--- trunk/JSTests/stress/osr-exit-on-op-negate-should-no-fail-assertions.js	(rev 0)
+++ trunk/JSTests/stress/osr-exit-on-op-negate-should-no-fail-assertions.js	2016-11-10 21:19:52 UTC (rev 208560)
@@ -0,0 +1,22 @@
+//@ runFTLNoCJIT
+// This test passes if it does not crash or fail any assertions.
+
+function inlineable(x) {
+return -x;
+}
+
+function test(y) {
+var results = [];
+for (var j = 0; j < 300; j++) {
+var k = j % y.length;
+try {
+results.push(inlineable(y[k]));
+} catch (e) {
+}
+}
+}
+noInline(test);
+
+for 

[webkit-changes] [208563] trunk/Source/JavaScriptCore

[mark . lam]

Title: [208563] trunk/Source/_javascript_Core








Revision 208563
Author mark@apple.com
Date 2016-11-10 13:42:33 -0800 (Thu, 10 Nov 2016)


Log Message
A few bits of minor code clean up.
https://bugs.webkit.org/show_bug.cgi?id=164523

Reviewed by Yusuke Suzuki.

* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::dump):
- Insert a space to make the dump more legible.

* runtime/Options.h:
- Fixed some typos.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplaceUsingRegExp):
(JSC::stringProtoFuncReplaceUsingStringSearch):
- Use the VM& that is already available.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp
trunk/Source/_javascript_Core/runtime/Options.h
trunk/Source/_javascript_Core/runtime/StringPrototype.cpp




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (208562 => 208563)

--- trunk/Source/_javascript_Core/ChangeLog	2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-11-10 21:42:33 UTC (rev 208563)
@@ -1,5 +1,24 @@
 2016-11-10  Mark Lam  
 
+A few bits of minor code clean up.
+https://bugs.webkit.org/show_bug.cgi?id=164523
+
+Reviewed by Yusuke Suzuki.
+
+* interpreter/StackVisitor.cpp:
+(JSC::StackVisitor::Frame::dump):
+- Insert a space to make the dump more legible.
+
+* runtime/Options.h:
+- Fixed some typos.
+
+* runtime/StringPrototype.cpp:
+(JSC::stringProtoFuncReplaceUsingRegExp):
+(JSC::stringProtoFuncReplaceUsingStringSearch):
+- Use the VM& that is already available.
+
+2016-11-10  Mark Lam  
+
 Graph::methodOfGettingAValueProfileFor() should be returning the profile for the operand node.
 https://bugs.webkit.org/show_bug.cgi?id=164600
 


Modified: trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp (208562 => 208563)

--- trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp	2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/interpreter/StackVisitor.cpp	2016-11-10 21:42:33 UTC (rev 208563)
@@ -395,7 +395,7 @@
 " ", RawPointer(reinterpret_cast(locationRawBits)), "\n");
 out.print(indent, "codeBlock: ", RawPointer(codeBlock));
 if (codeBlock)
-out.print(*codeBlock);
+out.print(" ", *codeBlock);
 out.print("\n");
 if (codeBlock && !isInlined) {
 indent++;


Modified: trunk/Source/_javascript_Core/runtime/Options.h (208562 => 208563)

--- trunk/Source/_javascript_Core/runtime/Options.h	2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/runtime/Options.h	2016-11-10 21:42:33 UTC (rev 208563)
@@ -153,8 +153,8 @@
 v(bool, dumpBytecodeAtDFGTime, false, Normal, "dumps bytecode of JS function being DFG compiled") \
 v(bool, dumpGraphAfterParsing, false, Normal, nullptr) \
 v(bool, dumpGraphAtEachPhase, false, Normal, nullptr) \
-v(bool, dumpDFGGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase DFG of complitaion (note this excludes DFG graphs during FTL compilation)") \
-v(bool, dumpDFGFTLGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase DFG of complitaion when compiling FTL code") \
+v(bool, dumpDFGGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase of DFG compilation (note this excludes DFG graphs during FTL compilation)") \
+v(bool, dumpDFGFTLGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase of DFG compilation when compiling FTL code") \
 v(bool, dumpB3GraphAtEachPhase, false, Normal, "dumps the B3 graph at each phase of compilation") \
 v(bool, dumpAirGraphAtEachPhase, false, Normal, "dumps the Air graph at each phase of compilation") \
 v(bool, verboseDFGByteCodeParsing, false, Normal, nullptr) \


Modified: trunk/Source/_javascript_Core/runtime/StringPrototype.cpp (208562 => 208563)

--- trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2016-11-10 21:40:56 UTC (rev 208562)
+++ trunk/Source/_javascript_Core/runtime/StringPrototype.cpp	2016-11-10 21:42:33 UTC (rev 208563)
@@ -852,7 +852,7 @@
 return JSValue::encode(jsUndefined());
 
 scope.release();
-return replaceUsingRegExpSearch(exec->vm(), exec, string, searchValue, exec->argument(1));
+return replaceUsingRegExpSearch(vm, exec, string, searchValue, exec->argument(1));
 }
 
 EncodedJSValue JSC_HOST_CALL stringProtoFuncReplaceUsingStringSearch(ExecState* exec)
@@ -863,7 +863,7 @@
 JSString* string = exec->thisValue().toString(exec);
 RETURN_IF_EXCEPTION(scope, encodedJSValue());
 
-return replaceUsingStringSearch(exec->vm(), exec, string, exec->argument(0), exec->argument(1));
+return replaceUsingStringSearch(vm, exec, string, exec->argument(0), exec->argument(1));
 }
 
 EncodedJSValue JIT_OPERATION operationStringProtoFuncReplaceGeneric(

[webkit-changes] [208565] trunk

[rniwa]

Title: [208565] trunk








Revision 208565
Author rn...@webkit.org
Date 2016-11-10 14:21:35 -0800 (Thu, 10 Nov 2016)


Log Message
Copied text would contain text inside CDATA sections and comments
https://bugs.webkit.org/show_bug.cgi?id=164578
Source/WebCore:



Reviewed by Darin Adler.

The bug was caused by HTMLConverter::_traverseNode always including the content of a Text node.
Since Comment and CDataSection nodes are also Text nodes, we need to exclude them.

In the long term, we should check the visibility of the text as done in MarkupAccumulator.

Test: editing/mac/attributed-string/comment-cdata-section.html

* editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_traverseNode):

LayoutTests:

Reviewed by Darin Adler.

Added a regression test for creating an attributed string from different kinds of Text nodes.
Comment and CDataSection should not be included in the attributed string.

* editing/mac/attributed-string/comment-cdata-section-expected.txt: Added.
* editing/mac/attributed-string/comment-cdata-section.html: Added.
* platform/mac-yosemite/editing/mac/attributed-string/comment-cdata-section-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/cocoa/HTMLConverter.mm


Added Paths

trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section-expected.txt
trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section.html
trunk/LayoutTests/platform/mac-yosemite/editing/mac/attributed-string/comment-cdata-section-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (208564 => 208565)

--- trunk/LayoutTests/ChangeLog	2016-11-10 22:03:24 UTC (rev 208564)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 22:21:35 UTC (rev 208565)
@@ -1,3 +1,17 @@
+2016-11-10  Ryosuke Niwa  
+
+Copied text would contain text inside CDATA sections and comments
+https://bugs.webkit.org/show_bug.cgi?id=164578
+
+Reviewed by Darin Adler.
+
+Added a regression test for creating an attributed string from different kinds of Text nodes.
+Comment and CDataSection should not be included in the attributed string.
+
+* editing/mac/attributed-string/comment-cdata-section-expected.txt: Added.
+* editing/mac/attributed-string/comment-cdata-section.html: Added.
+* platform/mac-yosemite/editing/mac/attributed-string/comment-cdata-section-expected.txt: Added.
+
 2016-11-10  Joseph Pecoraro  
 
 test262: DataView / TypedArray methods should throw RangeErrors for negative numbers (ToIndex)


Added: trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section-expected.txt (0 => 208565)

--- trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section-expected.txt	2016-11-10 22:21:35 UTC (rev 208565)
@@ -0,0 +1,31 @@
+Input:
+hello  world.
+
+Output:
+NSParagraphStyle:
+Alignment 4
+LineSpacing: 0
+ParagraphSpacing: 0
+ParagraphSpacingBefore: 0
+HeadIndent: 0
+TailIndent: 0
+FirstLineHeadIndent: 0
+LineHeight: 0/0
+LineHeightMultiple: 0
+LineBreakMode: 0
+Tabs: ()
+DefaultTabInterval: 36
+Blocks: (
+)
+Lists: (
+)
+BaseWritingDirection: 0
+HyphenationFactor: 0
+TighteningForTruncation: YES
+HeaderLevel: 0
+[hello world. ]
+NSFont: Times-Roman 16.00 pt.
+NSKern: 0pt
+NSStrokeColor: NSDeviceRGBColorSpace 0 0 0 1
+NSStrokeWidth: 0
+


Added: trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section.html (0 => 208565)

--- trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section.html	(rev 0)
+++ trunk/LayoutTests/editing/mac/attributed-string/comment-cdata-section.html	2016-11-10 22:21:35 UTC (rev 208565)
@@ -0,0 +1,9 @@
+
+
+

[webkit-changes] [208579] trunk

[utatane . tea]

Title: [208579] trunk








Revision 208579
Author utatane@gmail.com
Date 2016-11-10 22:08:18 -0800 (Thu, 10 Nov 2016)


Log Message
[DOMJIT] Document#body should have DOMJIT patchpoint
https://bugs.webkit.org/show_bug.cgi?id=164627

Reviewed by Darin Adler.

Source/WebCore:

This patch implements document.body accessor. To implement it, we need,

1. DOM traversing ability from ASM.
2. Checking HTMLElement.
3. Checking HTMLElement's localName.

The above features are already implemented in CSSJIT.
We extract some of utilities from CSSJIT to share them with DOMJIT.

Test: js/dom/domjit-accessor-document-body.html

* cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateWalkToParentElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateWalkToNextAdjacentElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateWalkToPreviousAdjacentElement):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeValueExactMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementAttributeFunctionCallValueMatching):
(WebCore::SelectorCompiler::jumpIfElementIsNotEmpty):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasTagName):
(WebCore::SelectorCompiler::testIsElementFlagOnNode): Deleted.
(WebCore::SelectorCompiler::testIsHTMLFlagOnNode): Deleted.
* dom/Document.idl:
* dom/Element.h:
* dom/QualifiedName.h:
* domjit/DOMJITAbstractHeapRepository.yaml:
* domjit/DOMJITHelpers.h:
(WebCore::DOMJIT::branchTestIsElementFlagOnNode):
(WebCore::DOMJIT::branchTestIsHTMLFlagOnNode):
* domjit/JSDocumentDOMJIT.cpp:
(WebCore::DocumentBodyDOMJIT::checkDOM):
(WebCore::loadLocalName):
(WebCore::DocumentBodyDOMJIT::callDOMGetter):

LayoutTests:

* js/dom/domjit-accessor-document-body-expected.txt: Added.
* js/dom/domjit-accessor-document-body.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/cssjit/SelectorCompiler.cpp
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/Element.h
trunk/Source/WebCore/dom/QualifiedName.h
trunk/Source/WebCore/domjit/DOMJITAbstractHeapRepository.yaml
trunk/Source/WebCore/domjit/DOMJITHelpers.h
trunk/Source/WebCore/domjit/JSDocumentDOMJIT.cpp


Added Paths

trunk/LayoutTests/js/dom/domjit-accessor-document-body-expected.txt
trunk/LayoutTests/js/dom/domjit-accessor-document-body.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208578 => 208579)

--- trunk/LayoutTests/ChangeLog	2016-11-11 04:37:06 UTC (rev 208578)
+++ trunk/LayoutTests/ChangeLog	2016-11-11 06:08:18 UTC (rev 208579)
@@ -1,3 +1,13 @@
+2016-11-10  Yusuke Suzuki  
+
+[DOMJIT] Document#body should have DOMJIT patchpoint
+https://bugs.webkit.org/show_bug.cgi?id=164627
+
+Reviewed by Darin Adler.
+
+* js/dom/domjit-accessor-document-body-expected.txt: Added.
+* js/dom/domjit-accessor-document-body.html: Added.
+
 2016-11-10  John Wilander  
 
 Add link information to data transfer pasteboard for drag and drop links


Added: trunk/LayoutTests/js/dom/domjit-accessor-document-body-expected.txt (0 => 208579)

--- trunk/LayoutTests/js/dom/domjit-accessor-document-body-expected.txt	(rev 0)
+++ trunk/LayoutTests/js/dom/domjit-accessor-document-body-expected.txt	2016-11-11 06:08:18 UTC (rev 208579)
@@ -0,0 +1,79 @@
+Test DOMJIT document.body accessor works.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS (
+function testHTMLDocument(element, result)
+{
+for (var i = 0; i < 1e4; ++i) {
+if (element.body !== result)
+return false;
+}
+return true;
+}
+)(target, result) is true
+PASS (
+function testXMLDocument(element, result)
+{
+for (var i = 0; i < 1e4; ++i) {
+if (element.body !== result)
+return false;
+}
+return true;
+}
+)(target, result) is true
+PASS (
+function testXMLDocument2(element, result)
+{
+for (var i = 0; i < 1e4; ++i) {
+if (element.body !== result)
+return false;
+}
+return true;
+}
+)(target, result) is true
+PASS (
+function testNull(element, result)
+{
+for (var i = 0; i < 1e4; ++i) {
+if (element.body !== result)
+return false;
+}
+return true;
+}
+)(target, result) is true
+PASS (
+function 

[webkit-changes] [208576] trunk

[wilander]

Title: [208576] trunk








Revision 208576
Author wilan...@apple.com
Date 2016-11-10 20:15:41 -0800 (Thu, 10 Nov 2016)


Log Message
Add link information to data transfer pasteboard for drag and drop links
https://bugs.webkit.org/show_bug.cgi?id=163468


Reviewed by Brent Fulgham.

Source/WebCore:

Test: editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html
This test ensures data transfers still work for types 'text' and 'url', i.e. that we don't
regress in-page use of the drag pasteboard.

* page/DragController.cpp:
(WebCore::DragController::startDrag):
Now adds trustworthy link information to the drag pasteboard.
* platform/Pasteboard.h:
New function declaration Pasteboard::writeTrustworthyWebURLsPboardType.
* platform/efl/PasteboardEfl.cpp:
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
Empty, i.e. not implemented.
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
Empty, i.e. not implemented.
* platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
Calls ASSERT_NOT_REACHED() to make sure we don't use this function before we have
decided on a trustrworthy URL pasteboard type on iOS. Currently not used since we
don't support drag & drop on iOS.
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
Writes the given URL to the WebURLsWithTitlesPboardType. This pasteboard type
serves as a trusted drop source.
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
Empty, i.e. not implemented.

LayoutTests:

* editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard-expected.txt: Added.
* editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html: Added.
This test ensures data transfer is not deleted or overwritten for the types 'text' and 'url'.
* platform/ios-simulator/TestExpectations:
Drag & drop is not supported on iOS.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/DragController.cpp
trunk/Source/WebCore/platform/Pasteboard.h
trunk/Source/WebCore/platform/efl/PasteboardEfl.cpp
trunk/Source/WebCore/platform/gtk/PasteboardGtk.cpp
trunk/Source/WebCore/platform/ios/PasteboardIOS.mm
trunk/Source/WebCore/platform/mac/PasteboardMac.mm
trunk/Source/WebCore/platform/win/PasteboardWin.cpp


Added Paths

trunk/LayoutTests/editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard-expected.txt
trunk/LayoutTests/editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208575 => 208576)

--- trunk/LayoutTests/ChangeLog	2016-11-11 02:20:48 UTC (rev 208575)
+++ trunk/LayoutTests/ChangeLog	2016-11-11 04:15:41 UTC (rev 208576)
@@ -1,3 +1,17 @@
+2016-11-10  John Wilander  
+
+Add link information to data transfer pasteboard for drag and drop links
+https://bugs.webkit.org/show_bug.cgi?id=163468
+
+
+Reviewed by Brent Fulgham.
+
+* editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard-expected.txt: Added.
+* editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard.html: Added.
+This test ensures data transfer is not deleted or overwritten for the types 'text' and 'url'.
+* platform/ios-simulator/TestExpectations:
+Drag & drop is not supported on iOS.
+
 2016-11-10  Chris Dumez  
 
 REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure


Added: trunk/LayoutTests/editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard-expected.txt (0 => 208576)

--- trunk/LayoutTests/editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/pasteboard/drag-link-with-data-transfer-adds-trusted-link-to-pasteboard-expected.txt	2016-11-11 04:15:41 UTC (rev 208576)
@@ -0,0 +1,14 @@
+PASS '_javascript_:alert('Set by data transfer');' was set in the data transfer for firstAnchorSource and not overwritten.
+PASS 'http://webkit.org/setByDataTransfer' was set in the data transfer for secondAnchorSource and not overwritten.
+PASS '_javascript_:alert('Set by data transfer');' was set in the data transfer for firstSvgSource and not overwritten.
+PASS 'http://webkit.org/setByDataTransfer' was set in the data transfer for secondSvgSource and not overwritten.
+
+This only has an ondragenter handler and is here to make sure dragging over it doesn't change the pasteboard.
+This only has an ondragover handler and is here to make sure dragging over it doesn't change the pasteboard.
+firstAnchorSource
+secondAnchorSource
+https://webkit.org

[webkit-changes] [208581] trunk/Source/WebCore

[commit-queue]

Title: [208581] trunk/Source/WebCore








Revision 208581
Author commit-qu...@webkit.org
Date 2016-11-10 22:29:44 -0800 (Thu, 10 Nov 2016)


Log Message
[SVG] Start moving special casing of SVG out of the bindings - SVGPreserveAspectRatio
https://bugs.webkit.org/show_bug.cgi?id=164622

Patch by Sam Weinig  on 2016-11-10
Reviewed by Darin Adler.

Part 2 of moving special casing of SVG out of the bindings.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
Add new files.

* bindings/scripts/CodeGenerator.pm:
(GenerateCompileTimeCheckForEnumsIfNeeded):
* bindings/scripts/IDLAttributes.txt:
Allow specifying a different scope for the constants to be declared in.
This allows us to have only one copy of the constants in the implementation
of SVGAngle/SVGAngleValue and SVGPreserveAspectRatio/SVGPreserveAspectRatioValue.

* loader/FrameLoader.cpp:
* rendering/svg/RenderSVGImage.h:
Remove unnecessary #include.

* svg/SVGAngle.h:
Remove redundant enum declaration.

* svg/SVGAngle.idl:
Specify a ConstantsScope of SVGAngleValue.

* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::updateImageViewport):
* svg/PatternAttributes.h:
(WebCore::PatternAttributes::preserveAspectRatio):
(WebCore::PatternAttributes::setPreserveAspectRatio):
* svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::constructFromString):
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::calculateAnimatedValue):
* svg/SVGAnimatedPreserveAspectRatio.h:
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::createPreserveAspectRatio):
* svg/SVGAnimatedType.h:
(WebCore::SVGAnimatedType::preserveAspectRatio):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::parseAttribute):
* svg/SVGFitToViewBox.cpp:
(WebCore::SVGFitToViewBox::viewBoxToViewTransform):
* svg/SVGFitToViewBox.h:
(WebCore::SVGFitToViewBox::parseAttribute):
* svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::parseAttribute):
* svg/SVGViewSpec.cpp:
(WebCore::SVGViewSpec::preserveAspectRatioString):
(WebCore::SVGViewSpec::lookupOrCreatePreserveAspectRatioWrapper):
(WebCore::SVGViewSpec::reset):
(WebCore::SVGViewSpec::parseViewSpec):
* svg/SVGViewSpec.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::computeIntrinsicDimensions):
* svg/graphics/filters/SVGFEImage.cpp:
(WebCore::FEImage::FEImage):
(WebCore::FEImage::createWithImage):
(WebCore::FEImage::createWithIRIReference):
* svg/graphics/filters/SVGFEImage.h:
Replace SVGPreserveAspectRatio usage with SVGPreserveAspectRatioValue.

* svg/SVGPreserveAspectRatio.cpp: Removed.
* svg/SVGPreserveAspectRatio.h: Replaced.
* svg/SVGPreserveAspectRatio.idl:
* svg/SVGPreserveAspectRatioValue.cpp: Copied from Source/WebCore/svg/SVGPreserveAspectRatio.cpp.
* svg/SVGPreserveAspectRatioValue.h: Copied from Source/WebCore/svg/SVGPreserveAspectRatio.h.
Rename SVGPreserveAspectRatio to SVGPreserveAspectRatioValue and add a new SVGPreserveAspectRatio
that acts as the binding object.

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGImage.cpp
trunk/Source/WebCore/rendering/svg/RenderSVGImage.h
trunk/Source/WebCore/svg/PatternAttributes.h
trunk/Source/WebCore/svg/SVGAllInOne.cpp
trunk/Source/WebCore/svg/SVGAngle.h
trunk/Source/WebCore/svg/SVGAngle.idl
trunk/Source/WebCore/svg/SVGAnimatedPreserveAspectRatio.cpp
trunk/Source/WebCore/svg/SVGAnimatedPreserveAspectRatio.h
trunk/Source/WebCore/svg/SVGAnimatedType.cpp
trunk/Source/WebCore/svg/SVGAnimatedType.h
trunk/Source/WebCore/svg/SVGFEImageElement.cpp
trunk/Source/WebCore/svg/SVGFitToViewBox.cpp
trunk/Source/WebCore/svg/SVGFitToViewBox.h
trunk/Source/WebCore/svg/SVGImageElement.cpp
trunk/Source/WebCore/svg/SVGPreserveAspectRatio.h
trunk/Source/WebCore/svg/SVGPreserveAspectRatio.idl
trunk/Source/WebCore/svg/SVGViewSpec.cpp
trunk/Source/WebCore/svg/SVGViewSpec.h
trunk/Source/WebCore/svg/graphics/SVGImage.cpp
trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.cpp
trunk/Source/WebCore/svg/graphics/filters/SVGFEImage.h


Added Paths

trunk/Source/WebCore/svg/SVGPreserveAspectRatioValue.cpp
trunk/Source/WebCore/svg/SVGPreserveAspectRatioValue.h


Removed Paths

trunk/Source/WebCore/svg/SVGPreserveAspectRatio.cpp




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (208580 => 208581)

--- trunk/Source/WebCore/CMakeLists.txt	2016-11-11 06:16:08 UTC (rev 208580)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-11-11 06:29:44 UTC (rev 208581)
@@ -2802,7 +2802,7 @@
 svg/SVGPolyElement.cpp
 svg/SVGPolygonElement.cpp
 svg/SVGPolylineElement.cpp
-svg/SVGPreserveAspectRatio.cpp
+svg/SVGPreserveAspectRatioValue.cpp
 svg/SVGRadialGradientElement.cpp
 svg/SVGRectElement.cpp
 svg/SVGSVGElement.cpp


Modified: 

[webkit-changes] [208577] trunk/Source/WebCore

[cdumez]

Title: [208577] trunk/Source/WebCore








Revision 208577
Author cdu...@apple.com
Date 2016-11-10 20:32:41 -0800 (Thu, 10 Nov 2016)


Log Message
Speed up HTMLInputElement validation
https://bugs.webkit.org/show_bug.cgi?id=164603

Reviewed by Ryosuke Niwa.

Speed up HTMLInputElement validation by doing 1 virtual function call
instead of 9 and calling HTMLInputElement::value() only once per
validation instead of 9 times. Calling value() is expensive because
of sanitization.

No new tests, no Web-exposed behavior change.

* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::fallbackValue):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::isValid):
* html/FormAssociatedElement.h:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::isValidFormControlElement):
(WebCore::HTMLFormControlElement::updateValidity):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isValid):
(WebCore::HTMLInputElement::value):
* html/HTMLInputElement.h:
* html/TextFieldInputType.cpp:
(WebCore::limitLength):
* html/ValidityState.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/BaseCheckableInputType.cpp
trunk/Source/WebCore/html/FormAssociatedElement.cpp
trunk/Source/WebCore/html/FormAssociatedElement.h
trunk/Source/WebCore/html/HTMLFormControlElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.cpp
trunk/Source/WebCore/html/HTMLInputElement.h
trunk/Source/WebCore/html/TextFieldInputType.cpp
trunk/Source/WebCore/html/ValidityState.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (208576 => 208577)

--- trunk/Source/WebCore/ChangeLog	2016-11-11 04:15:41 UTC (rev 208576)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 04:32:41 UTC (rev 208577)
@@ -1,3 +1,33 @@
+2016-11-10  Chris Dumez  
+
+Speed up HTMLInputElement validation
+https://bugs.webkit.org/show_bug.cgi?id=164603
+
+Reviewed by Ryosuke Niwa.
+
+Speed up HTMLInputElement validation by doing 1 virtual function call
+instead of 9 and calling HTMLInputElement::value() only once per
+validation instead of 9 times. Calling value() is expensive because
+of sanitization.
+
+No new tests, no Web-exposed behavior change.
+
+* html/BaseCheckableInputType.cpp:
+(WebCore::BaseCheckableInputType::fallbackValue):
+* html/FormAssociatedElement.cpp:
+(WebCore::FormAssociatedElement::isValid):
+* html/FormAssociatedElement.h:
+* html/HTMLFormControlElement.cpp:
+(WebCore::HTMLFormControlElement::isValidFormControlElement):
+(WebCore::HTMLFormControlElement::updateValidity):
+* html/HTMLInputElement.cpp:
+(WebCore::HTMLInputElement::isValid):
+(WebCore::HTMLInputElement::value):
+* html/HTMLInputElement.h:
+* html/TextFieldInputType.cpp:
+(WebCore::limitLength):
+* html/ValidityState.idl:
+
 2016-11-10  John Wilander  
 
 Add link information to data transfer pasteboard for drag and drop links


Modified: trunk/Source/WebCore/html/BaseCheckableInputType.cpp (208576 => 208577)

--- trunk/Source/WebCore/html/BaseCheckableInputType.cpp	2016-11-11 04:15:41 UTC (rev 208576)
+++ trunk/Source/WebCore/html/BaseCheckableInputType.cpp	2016-11-11 04:32:41 UTC (rev 208577)
@@ -93,7 +93,8 @@
 
 String BaseCheckableInputType::fallbackValue() const
 {
-return ASCIILiteral("on");
+static NeverDestroyed on("on", AtomicString::ConstructFromLiteral);
+return on.get();
 }
 
 bool BaseCheckableInputType::storesValueSeparateFromAttribute()


Modified: trunk/Source/WebCore/html/FormAssociatedElement.cpp (208576 => 208577)

--- trunk/Source/WebCore/html/FormAssociatedElement.cpp	2016-11-11 04:15:41 UTC (rev 208576)
+++ trunk/Source/WebCore/html/FormAssociatedElement.cpp	2016-11-11 04:32:41 UTC (rev 208577)
@@ -237,7 +237,7 @@
 return false;
 }
 
-bool FormAssociatedElement::valid() const
+bool FormAssociatedElement::isValid() const
 {
 bool someError = typeMismatch() || stepMismatch() || rangeUnderflow() || rangeOverflow()
 || tooShort() || tooLong() || patternMismatch() || valueMissing() || hasBadInput() || customError();


Modified: trunk/Source/WebCore/html/FormAssociatedElement.h (208576 => 208577)

--- trunk/Source/WebCore/html/FormAssociatedElement.h	2016-11-11 04:15:41 UTC (rev 208576)
+++ trunk/Source/WebCore/html/FormAssociatedElement.h	2016-11-11 04:32:41 UTC (rev 208577)
@@ -82,7 +82,7 @@
 virtual bool typeMismatch() const;
 virtual bool valueMissing() const;
 virtual String validationMessage() const;
-bool valid() const;
+virtual bool isValid() const;
 virtual void setCustomValidity(const String&);
 
 void formAttributeTargetChanged();


Modified: trunk/Source/WebCore/html/HTMLFormControlElement.cpp (208576 => 208577)

--- trunk/Source/WebCore/html/HTMLFormControlElement.cpp	2016-11-11 04:15:41 UTC (rev 208576)
+++ 

[webkit-changes] [208580] trunk

[achristensen]

Title: [208580] trunk








Revision 208580
Author achristen...@apple.com
Date 2016-11-10 22:16:08 -0800 (Thu, 10 Nov 2016)


Log Message
Fix assertion after r208534.
https://bugs.webkit.org/show_bug.cgi?id=160497

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(WebInstallMemoryPressureHandler):
WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
(TestWebKitAPI::TEST):
Add a regression test.

Modified Paths

trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj


Added Paths

trunk/Tools/TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm




Diff

Modified: trunk/Source/WebKit/mac/ChangeLog (208579 => 208580)

--- trunk/Source/WebKit/mac/ChangeLog	2016-11-11 06:08:18 UTC (rev 208579)
+++ trunk/Source/WebKit/mac/ChangeLog	2016-11-11 06:16:08 UTC (rev 208580)
@@ -1,5 +1,17 @@
 2016-11-10  Alex Christensen  
 
+Fix assertion after r208534.
+https://bugs.webkit.org/show_bug.cgi?id=160497
+
+* WebView/WebView.mm:
+(-[WebView _commonInitializationWithFrameName:groupName:]):
+(WebInstallMemoryPressureHandler):
+WebInstallMemoryPressureHandler can be called before [WebView initWithFrame:frameName:groupName:]
+When this happens, we should use the same std::once_flag to make sure we install the MemoryPressureHandler::singleton
+only once, otherwise we get an assertion !m_installed in MemoryPressureHandler::setLowMemoryHandler.
+
+2016-11-10  Alex Christensen  
+
 Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
 https://bugs.webkit.org/show_bug.cgi?id=164573
 


Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (208579 => 208580)

--- trunk/Source/WebKit/mac/WebView/WebView.mm	2016-11-11 06:08:18 UTC (rev 208579)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm	2016-11-11 06:16:08 UTC (rev 208580)
@@ -1430,19 +1430,8 @@
 _private->page->settings().setFontFallbackPrefersPictographs(true);
 #endif
 
-if (![[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitSuppressMemoryPressureHandler"]) {
-WebCore::registerMemoryReleaseNotifyCallbacks();
+WebInstallMemoryPressureHandler();
 
-static std::once_flag onceFlag;
-std::call_once(onceFlag, [] {
-auto& memoryPressureHandler = MemoryPressureHandler::singleton();
-memoryPressureHandler.setLowMemoryHandler([] (Critical critical, Synchronous synchronous) {
-WebCore::releaseMemory(critical, synchronous);
-});
-memoryPressureHandler.install();
-});
-}
-
 if (!WebKitLinkedOnOrAfter(WEBKIT_FIRST_VERSION_WITH_LOCAL_RESOURCE_SECURITY_RESTRICTION)) {
 // Originally, we allowed all local loads.
 SecurityPolicy::setLocalLoadPolicy(SecurityPolicy::AllowLocalLoadsForAll);
@@ -9800,6 +9789,16 @@
 
 void WebInstallMemoryPressureHandler(void)
 {
-if (![[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitSuppressMemoryPressureHandler"])
-MemoryPressureHandler::singleton().install();
+if (![[NSUserDefaults standardUserDefaults] boolForKey:@"WebKitSuppressMemoryPressureHandler"]) {
+WebCore::registerMemoryReleaseNotifyCallbacks();
+
+static std::once_flag onceFlag;
+std::call_once(onceFlag, [] {
+auto& memoryPressureHandler = MemoryPressureHandler::singleton();
+memoryPressureHandler.setLowMemoryHandler([] (Critical critical, Synchronous synchronous) {
+WebCore::releaseMemory(critical, synchronous);
+});
+memoryPressureHandler.install();
+});
+}
 }


Modified: trunk/Tools/ChangeLog (208579 => 208580)

--- trunk/Tools/ChangeLog	2016-11-11 06:08:18 UTC (rev 208579)
+++ trunk/Tools/ChangeLog	2016-11-11 06:16:08 UTC (rev 208580)
@@ -1,3 +1,13 @@
+2016-11-10  Alex Christensen  
+
+Fix assertion after r208534.
+https://bugs.webkit.org/show_bug.cgi?id=160497
+
+* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
+* TestWebKitAPI/Tests/mac/MemoryPressureHandler.mm: Added.
+(TestWebKitAPI::TEST):
+Add a regression test.
+
 2016-11-10  Chris Dumez  
 
 REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure


Modified: trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj (208579 => 208580)

--- 

[webkit-changes] [208578] trunk/Source/WebCore

[wilander]

Title: [208578] trunk/Source/WebCore








Revision 208578
Author wilan...@apple.com
Date 2016-11-10 20:37:06 -0800 (Thu, 10 Nov 2016)


Log Message
Remove unused parameter name to fix build error on iOS
https://bugs.webkit.org/show_bug.cgi?id=163468

No review.

No new tests.

* platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
Removed parameter name 'pasteboardURL' in unimplemented function.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ios/PasteboardIOS.mm




Diff

Modified: trunk/Source/WebCore/ChangeLog (208577 => 208578)

--- trunk/Source/WebCore/ChangeLog	2016-11-11 04:32:41 UTC (rev 208577)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 04:37:06 UTC (rev 208578)
@@ -1,3 +1,16 @@
+2016-11-10  John Wilander  
+
+Remove unused parameter name to fix build error on iOS
+https://bugs.webkit.org/show_bug.cgi?id=163468
+
+No review.
+
+No new tests.
+
+* platform/ios/PasteboardIOS.mm:
+(WebCore::Pasteboard::writeTrustworthyWebURLsPboardType):
+Removed parameter name 'pasteboardURL' in unimplemented function.
+
 2016-11-10  Chris Dumez  
 
 Speed up HTMLInputElement validation


Modified: trunk/Source/WebCore/platform/ios/PasteboardIOS.mm (208577 => 208578)

--- trunk/Source/WebCore/platform/ios/PasteboardIOS.mm	2016-11-11 04:32:41 UTC (rev 208577)
+++ trunk/Source/WebCore/platform/ios/PasteboardIOS.mm	2016-11-11 04:37:06 UTC (rev 208578)
@@ -127,7 +127,7 @@
 platformStrategies()->pasteboardStrategy()->writeToPasteboard(kUTTypeURL, pasteboardURL.url.string());
 }
 
-void Pasteboard::writeTrustworthyWebURLsPboardType(const PasteboardURL& pasteboardURL)
+void Pasteboard::writeTrustworthyWebURLsPboardType(const PasteboardURL&)
 {
 // A trustworthy URL pasteboard type needs to be decided on
 // before we allow calls to this function. A page data transfer






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208571] trunk/Source/WebCore

[zalan]

Title: [208571] trunk/Source/WebCore








Revision 208571
Author za...@apple.com
Date 2016-11-10 16:26:53 -0800 (Thu, 10 Nov 2016)


Log Message
Move update image calls to RenderElement::styleDidChange.
https://bugs.webkit.org/show_bug.cgi?id=164623

Reviewed by Simon Fraser.

There should be no dependency on the image update between ::styleWillChange and ::styleDidChange.

Covered by existing tests.

* rendering/RenderElement.cpp:
(WebCore::RenderElement::initializeStyle):
(WebCore::RenderElement::setStyle):
(WebCore::RenderElement::styleDidChange):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderElement.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208570 => 208571)

--- trunk/Source/WebCore/ChangeLog	2016-11-11 00:01:14 UTC (rev 208570)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 00:26:53 UTC (rev 208571)
@@ -1,3 +1,19 @@
+2016-11-10  Zalan Bujtas  
+
+Move update image calls to RenderElement::styleDidChange.
+https://bugs.webkit.org/show_bug.cgi?id=164623
+
+Reviewed by Simon Fraser.
+
+There should be no dependency on the image update between ::styleWillChange and ::styleDidChange.
+
+Covered by existing tests.
+
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::initializeStyle):
+(WebCore::RenderElement::setStyle):
+(WebCore::RenderElement::styleDidChange):
+
 2016-11-10  Joseph Pecoraro  
 
 After r207459 ASSERT in CachedResourceLoader under InspectorPageAgent::cachedResource


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (208570 => 208571)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2016-11-11 00:01:14 UTC (rev 208570)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2016-11-11 00:26:53 UTC (rev 208571)
@@ -376,16 +376,7 @@
 Style::loadPendingResources(m_style, document(), element());
 
 styleWillChange(StyleDifferenceNewStyle, style());
-
 m_hasInitializedStyle = true;
-
-updateFillImages(nullptr, m_style.backgroundLayers());
-updateFillImages(nullptr, m_style.maskLayers());
-
-updateImage(nullptr, m_style.borderImage().image());
-updateImage(nullptr, m_style.maskBoxImage().image());
-updateShapeImage(nullptr, m_style.shapeOutside());
-
 styleDidChange(StyleDifferenceNewStyle, nullptr);
 
 // We shouldn't have any text children that would need styleDidChange at this point.
@@ -414,19 +405,9 @@
 Style::loadPendingResources(style, document(), element());
 
 styleWillChange(diff, style);
-
 auto oldStyle = WTFMove(m_style);
 m_style = WTFMove(style);
-
-updateFillImages(oldStyle.backgroundLayers(), m_style.backgroundLayers());
-updateFillImages(oldStyle.maskLayers(), m_style.maskLayers());
-
-updateImage(oldStyle.borderImage().image(), m_style.borderImage().image());
-updateImage(oldStyle.maskBoxImage().image(), m_style.maskBoxImage().image());
-updateShapeImage(oldStyle.shapeOutside(), m_style.shapeOutside());
-
-bool doesNotNeedLayout = !parent();
-
+bool detachedFromParent = !parent();
 styleDidChange(diff, );
 
 // Text renderers use their parent style. Notify them about the change.
@@ -435,9 +416,9 @@
 
 // FIXME: |this| might be destroyed here. This can currently happen for a RenderTextFragment when
 // its first-letter block gets an update in RenderTextFragment::styleDidChange. For RenderTextFragment(s),
-// we will safely bail out with the doesNotNeedLayout flag. We might want to broaden this condition
+// we will safely bail out with the detachedFromParent flag. We might want to broaden this condition
 // in the future as we move renderer changes out of layout and into style changes.
-if (doesNotNeedLayout)
+if (detachedFromParent)
 return;
 
 // Now that the layer (if any) has been updated, we need to adjust the diff again,
@@ -990,6 +971,12 @@
 
 void RenderElement::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
 {
+updateFillImages(oldStyle ? oldStyle->backgroundLayers() : nullptr, m_style.backgroundLayers());
+updateFillImages(oldStyle ? oldStyle->maskLayers() : nullptr, m_style.maskLayers());
+updateImage(oldStyle ? oldStyle->borderImage().image() : nullptr, m_style.borderImage().image());
+updateImage(oldStyle ? oldStyle->maskBoxImage().image() : nullptr, m_style.maskBoxImage().image());
+updateShapeImage(oldStyle ? oldStyle->shapeOutside() : nullptr, m_style.shapeOutside());
+
 if (s_affectsParentBlock)
 handleDynamicFloatPositionChange();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208572] trunk/Source/WebCore

[dino]

Title: [208572] trunk/Source/WebCore








Revision 208572
Author d...@apple.com
Date 2016-11-10 16:49:06 -0800 (Thu, 10 Nov 2016)


Log Message
Add CSS Color Level 4 to features.

* features.json:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/features.json




Diff

Modified: trunk/Source/WebCore/ChangeLog (208571 => 208572)

--- trunk/Source/WebCore/ChangeLog	2016-11-11 00:26:53 UTC (rev 208571)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 00:49:06 UTC (rev 208572)
@@ -1,3 +1,9 @@
+2016-11-10  Dean Jackson  
+
+Add CSS Color Level 4 to features.
+
+* features.json:
+
 2016-11-10  Zalan Bujtas  
 
 Move update image calls to RenderElement::styleDidChange.


Modified: trunk/Source/WebCore/features.json (208571 => 208572)

--- trunk/Source/WebCore/features.json	2016-11-11 00:26:53 UTC (rev 208571)
+++ trunk/Source/WebCore/features.json	2016-11-11 00:49:06 UTC (rev 208572)
@@ -3,7 +3,7 @@
 {
 "name": "Battery Status API",
 "status": {
-	"status": "Removed"
+"status": "Removed"
 },
 "url": "https://w3c.github.io/battery/",
 "webkit-url": "https://webkit.org/b/62698",
@@ -29,6 +29,17 @@
 }
 },
 {
+"name": "CSS Color Level 4",
+"status": {
+"status": "In Development",
+"enabled-by-default": true
+},
+"url": "https://drafts.csswg.org/css-color/",
+"keywords": ["css color", "color"],
+"category": "css",
+"description": "Allows content to specify colors outside of the sRGB Color Space."
+},
+{
 "name": "CSS Fonts Level 4",
 "url": "https://drafts.csswg.org/css-fonts-4/",
 "keywords": ["css fonts", "fonts"],






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208569] trunk

[cdumez]

Title: [208569] trunk








Revision 208569
Author cdu...@apple.com
Date 2016-11-10 15:59:42 -0800 (Thu, 10 Nov 2016)


Log Message
REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=164570

Reviewed by Simon Fraser.

Tools:

Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
avoid flakiness.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetStateToConsistentValues):

LayoutTests:

Unskip test which should no longer be flaky.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations
trunk/Tools/ChangeLog
trunk/Tools/WebKitTestRunner/TestController.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (208568 => 208569)

--- trunk/LayoutTests/ChangeLog	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 23:59:42 UTC (rev 208569)
@@ -1,3 +1,14 @@
+2016-11-10  Chris Dumez  
+
+REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=164570
+
+Reviewed by Simon Fraser.
+
+Unskip test which should no longer be flaky.
+
+* platform/mac/TestExpectations:
+
 2016-11-10  Brady Eidson  
 
 IndexedDB 2.0 Support the IDBDatabase.onclose event.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (208568 => 208569)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 23:59:42 UTC (rev 208569)
@@ -1469,4 +1469,3 @@
 
 webkit.org/b/164388 inspector/sampling-profiler [ Pass Timeout ]
 
-webkit.org/b/164570 fast/loader/reload-zero-byte-plugin.html [ Pass Failure ]


Modified: trunk/Tools/ChangeLog (208568 => 208569)

--- trunk/Tools/ChangeLog	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/Tools/ChangeLog	2016-11-10 23:59:42 UTC (rev 208569)
@@ -1,3 +1,16 @@
+2016-11-10  Chris Dumez  
+
+REGRESSION (r208522): LayoutTest fast/loader/reload-zero-byte-plugin.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=164570
+
+Reviewed by Simon Fraser.
+
+Properly reset TestController::m_shouldDownloadUndisplayableMIMETypes between tests to
+avoid flakiness.
+
+* WebKitTestRunner/TestController.cpp:
+(WTR::TestController::resetStateToConsistentValues):
+
 2016-11-10  Miguel Gomez  
 
 Unreviewed. Added myself to the list of committers.


Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (208568 => 208569)

--- trunk/Tools/WebKitTestRunner/TestController.cpp	2016-11-10 23:27:37 UTC (rev 208568)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp	2016-11-10 23:59:42 UTC (rev 208569)
@@ -771,6 +771,8 @@
 // Reset Custom Policy Delegate.
 setCustomPolicyDelegate(false, false);
 
+m_shouldDownloadUndisplayableMIMETypes = false;
+
 m_workQueueManager.clearWorkQueue();
 
 m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges = false;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208573] trunk/Source/WebCore

[bfulgham]

Title: [208573] trunk/Source/WebCore








Revision 208573
Author bfulg...@apple.com
Date 2016-11-10 16:59:53 -0800 (Thu, 10 Nov 2016)


Log Message
[Win][Direct2D] Add transparency layer support
https://bugs.webkit.org/show_bug.cgi?id=164614

Reviewed by Dean Jackson.

Provide a stackable implementation of transparency layers so that
multiple layers with opacity draw propery.

Tested by fast/layers/opacity-stacking.html and others.

* platform/graphics/win/GraphicsContextDirect2D.cpp:
(WebCore::GraphicsContext::platformContext): Remove unneeded assertion.
(WebCore::GraphicsContextPlatformPrivate::renderTarget): Return current context taking
into account the presence of transparency layers.
(WebCore::GraphicsContextPlatformPrivate::setAlpha): Added.
(WebCore::GraphicsContextPlatformPrivate::currentGlobalAlpha): Get current global
alpha for current layer.
(WebCore::GraphicsContext::colorWithGlobalAlpha): Compute proper color taking into
account the current layer.
(WebCore::drawWithShadowHelper): Helper function to share code.
(WebCore::GraphicsContext::drawWithShadow): Use new helper function.
(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer): Added.
(WebCore::GraphicsContext::beginPlatformTransparencyLayer): Call new implementation.
(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer): Added.
(WebCore::GraphicsContext::endPlatformTransparencyLayer): Call new implementation.
(WebCore::GraphicsContext::clearRect): Clear to transparent color.
(WebCore::GraphicsContext::setPlatformAlpha): Pass new alpha on to any active
transparency layer.
* platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h:
(WebCore::GraphicsContextPlatformPrivate::renderTarget): Deleted.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp
trunk/Source/WebCore/platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (208572 => 208573)

--- trunk/Source/WebCore/ChangeLog	2016-11-11 00:49:06 UTC (rev 208572)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 00:59:53 UTC (rev 208573)
@@ -1,3 +1,36 @@
+2016-11-10  Brent Fulgham  
+
+[Win][Direct2D] Add transparency layer support
+https://bugs.webkit.org/show_bug.cgi?id=164614
+
+Reviewed by Dean Jackson.
+
+Provide a stackable implementation of transparency layers so that
+multiple layers with opacity draw propery.
+
+Tested by fast/layers/opacity-stacking.html and others.
+
+* platform/graphics/win/GraphicsContextDirect2D.cpp:
+(WebCore::GraphicsContext::platformContext): Remove unneeded assertion.
+(WebCore::GraphicsContextPlatformPrivate::renderTarget): Return current context taking
+into account the presence of transparency layers.
+(WebCore::GraphicsContextPlatformPrivate::setAlpha): Added.
+(WebCore::GraphicsContextPlatformPrivate::currentGlobalAlpha): Get current global
+alpha for current layer.
+(WebCore::GraphicsContext::colorWithGlobalAlpha): Compute proper color taking into
+account the current layer.
+(WebCore::drawWithShadowHelper): Helper function to share code.
+(WebCore::GraphicsContext::drawWithShadow): Use new helper function.
+(WebCore::GraphicsContextPlatformPrivate::beginTransparencyLayer): Added.
+(WebCore::GraphicsContext::beginPlatformTransparencyLayer): Call new implementation.
+(WebCore::GraphicsContextPlatformPrivate::endTransparencyLayer): Added.
+(WebCore::GraphicsContext::endPlatformTransparencyLayer): Call new implementation.
+(WebCore::GraphicsContext::clearRect): Clear to transparent color.
+(WebCore::GraphicsContext::setPlatformAlpha): Pass new alpha on to any active
+transparency layer.
+* platform/graphics/win/GraphicsContextPlatformPrivateDirect2D.h:
+(WebCore::GraphicsContextPlatformPrivate::renderTarget): Deleted.
+
 2016-11-10  Dean Jackson  
 
 Add CSS Color Level 4 to features.


Modified: trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp (208572 => 208573)

--- trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp	2016-11-11 00:49:06 UTC (rev 208572)
+++ trunk/Source/WebCore/platform/graphics/win/GraphicsContextDirect2D.cpp	2016-11-11 00:59:53 UTC (rev 208573)
@@ -151,10 +151,31 @@
 ID2D1RenderTarget* GraphicsContext::platformContext() const
 {
 ASSERT(!paintingDisabled());
-ASSERT(m_data->renderTarget());
 return m_data->renderTarget();
 }
 
+ID2D1RenderTarget* GraphicsContextPlatformPrivate::renderTarget()
+{
+if (!m_transparencyLayerStack.isEmpty())
+return m_transparencyLayerStack.last().renderTarget.get();
+
+return m_renderTarget.get();
+}
+
+void GraphicsContextPlatformPrivate::setAlpha(float alpha)
+{
+ASSERT(m_transparencyLayerStack.isEmpty());
+m_alpha = alpha;
+}

[webkit-changes] [208574] trunk/JSTests

[mark . lam]

Title: [208574] trunk/JSTests








Revision 208574
Author mark@apple.com
Date 2016-11-10 17:27:02 -0800 (Thu, 10 Nov 2016)


Log Message
Fix broken have-a-bad-time-with-arguments.js test.
https://bugs.webkit.org/show_bug.cgi?id=164626

Reviewed by Filip Pizlo.

But also saved a copy of the broken one as broken-have-a-bad-time-with-arguments-for-gc-testing.js
because coincidentally, it stresses the GC in ways that help reveal bugs.

* stress/broken-have-a-bad-time-with-arguments-for-gc-testing.js: Added.
(testFunction):
(warmupFunction):
(let.argsDeclIndex.in.argumentsDecls.let.indexToReturnIndex.in.indicesToReturn.let.insertElementActionIndex.in.insertElementActions.let.tierWarmupCountIndex.in.tierWarmupCounts.let.testArgsIndex.in.testArgsList.catch):
* stress/have-a-bad-time-with-arguments.js:

Modified Paths

trunk/JSTests/ChangeLog
trunk/JSTests/stress/have-a-bad-time-with-arguments.js


Added Paths

trunk/JSTests/stress/broken-have-a-bad-time-with-arguments-for-gc-testing.js




Diff

Modified: trunk/JSTests/ChangeLog (208573 => 208574)

--- trunk/JSTests/ChangeLog	2016-11-11 00:59:53 UTC (rev 208573)
+++ trunk/JSTests/ChangeLog	2016-11-11 01:27:02 UTC (rev 208574)
@@ -1,3 +1,19 @@
+2016-11-10  Mark Lam  
+
+Fix broken have-a-bad-time-with-arguments.js test.
+https://bugs.webkit.org/show_bug.cgi?id=164626
+
+Reviewed by Filip Pizlo.
+
+But also saved a copy of the broken one as broken-have-a-bad-time-with-arguments-for-gc-testing.js
+because coincidentally, it stresses the GC in ways that help reveal bugs.
+
+* stress/broken-have-a-bad-time-with-arguments-for-gc-testing.js: Added.
+(testFunction):
+(warmupFunction):
+(let.argsDeclIndex.in.argumentsDecls.let.indexToReturnIndex.in.indicesToReturn.let.insertElementActionIndex.in.insertElementActions.let.tierWarmupCountIndex.in.tierWarmupCounts.let.testArgsIndex.in.testArgsList.catch):
+* stress/have-a-bad-time-with-arguments.js:
+
 2016-11-10  JF Bastien  
 
 ASSERTION FAILED: length > offset encountered with wasm.yaml/wasm/js-api/test_Module.js.default-wasm


Added: trunk/JSTests/stress/broken-have-a-bad-time-with-arguments-for-gc-testing.js (0 => 208574)

--- trunk/JSTests/stress/broken-have-a-bad-time-with-arguments-for-gc-testing.js	(rev 0)
+++ trunk/JSTests/stress/broken-have-a-bad-time-with-arguments-for-gc-testing.js	2016-11-11 01:27:02 UTC (rev 208574)
@@ -0,0 +1,140 @@
+//@ runFTLNoCJIT
+
+// Tests accessing an element in arguments before and after having a bad time.
+// This test should not crash.
+
+let verbose = false;
+
+var utilities = 'function shouldEqual(testId, actual, expected) {' + '\n' +
+'if (actual != expected)' + '\n' +
+'throw testId + ": ERROR: expect " + expected + ", actual " + actual;' + '\n' +
+'}' + '\n';
+
+var haveABadTime =  'Object.defineProperty(Object.prototype, 20, { get() { return 20; } });' + '\n';
+
+var directArgumentsDecl =   'var args = arguments;' + '\n';
+
+var scopedArgumentsDecl =   'var args = arguments;' + '\n' +
+'function closure() { return x; }' + '\n';
+
+var clonedArgumentsDecl =   '"use strict";' + '\n' +
+'var args = arguments;' + '\n';
+
+function testFunction(argsDecl, insertElementAction, indexToReturn) {
+var script ='function test(x) {' + '\n' +
+ argsDecl +
+ insertElementAction +
+'return args[' + indexToReturn + '];' + '\n' +
+'}' + '\n' +
+'noInline(test);' + '\n';
+return script;
+}
+
+function warmupFunction(tierWarmupCount, testArgs) {
+var script ='function warmup() {' + '\n' +
+'for (var i = 0; i < ' + tierWarmupCount + '; i++) {' + '\n' +
+'test(' + testArgs + ');' + '\n' +
+'}' + '\n' +
+'}' + '\n';
+return script;
+}
+
+let argumentsDecls = {
+direct: directArgumentsDecl,
+scoped: scopedArgumentsDecl,
+cloned: clonedArgumentsDecl
+};
+
+let indicesToReturn = {
+inBounds: 0,
+outOfBoundsInsertedElement: 10,
+outOfBoundsInPrototype: 20
+};
+
+let tierWarmupCounts = {
+llint: 1,
+baseline: 50,
+dfg: 1000,
+ftl: 1
+};
+
+let testArgsList = {
+noArgs:   {
+args: '',
+result: {
+inBounds: { beforeBadTime: 'undefined', afterBadTime: 'undefined', },
+outOfBoundsInsertedElement: { beforeBadTime: '10', afterBadTime: '10', },
+outOfBoundsInPrototype: { 

[webkit-changes] [208568] trunk

[beidson]

Title: [208568] trunk








Revision 208568
Author beid...@apple.com
Date 2016-11-10 15:27:37 -0800 (Thu, 10 Nov 2016)


Log Message
IndexedDB 2.0 Support the IDBDatabase.onclose event.
https://bugs.webkit.org/show_bug.cgi?id=164602

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/IndexedDB/interfaces-expected.txt:

Source/WebCore:

No new tests (Covered by existing tests).

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::connectionToServerLost): Fire "onclose" after "onerror"
* Modules/indexeddb/IDBDatabase.idl:

LayoutTests:

* TestExpectations:
* storage/indexeddb/modern/handle-user-delete-expected.txt:
* storage/indexeddb/modern/resources/handle-user-delete.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/interfaces-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/handle-user-delete-expected.txt
trunk/LayoutTests/storage/indexeddb/modern/resources/handle-user-delete.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.idl




Diff

Modified: trunk/LayoutTests/ChangeLog (208567 => 208568)

--- trunk/LayoutTests/ChangeLog	2016-11-10 23:07:15 UTC (rev 208567)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 23:27:37 UTC (rev 208568)
@@ -1,3 +1,14 @@
+2016-11-10  Brady Eidson  
+
+IndexedDB 2.0 Support the IDBDatabase.onclose event.
+https://bugs.webkit.org/show_bug.cgi?id=164602
+
+Reviewed by Alex Christensen.
+
+* TestExpectations:
+* storage/indexeddb/modern/handle-user-delete-expected.txt:
+* storage/indexeddb/modern/resources/handle-user-delete.js:
+
 2016-11-10  Ryan Haddad  
 
 Marking swipe/pushState-cached-back-swipe.html and swipe/main-frame-pinning-requirement.html as failing.


Modified: trunk/LayoutTests/TestExpectations (208567 => 208568)

--- trunk/LayoutTests/TestExpectations	2016-11-10 23:07:15 UTC (rev 208567)
+++ trunk/LayoutTests/TestExpectations	2016-11-10 23:27:37 UTC (rev 208568)
@@ -803,9 +803,6 @@
 
 ### START OF IndexedDB failures
 
-# Our IDL parser test harness is not what this test expects
-imported/w3c/web-platform-tests/IndexedDB/interfaces.html [ Skip ]
-
 # Times out for unexplored reasons 
 storage/indexeddb/database-quota.html [ Skip ]
 storage/indexeddb/database-quota-private.html [ Skip ]


Modified: trunk/LayoutTests/imported/w3c/ChangeLog (208567 => 208568)

--- trunk/LayoutTests/imported/w3c/ChangeLog	2016-11-10 23:07:15 UTC (rev 208567)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2016-11-10 23:27:37 UTC (rev 208568)
@@ -1,3 +1,12 @@
+2016-11-10  Brady Eidson  
+
+IndexedDB 2.0 Support the IDBDatabase.onclose event.
+https://bugs.webkit.org/show_bug.cgi?id=164602
+
+Reviewed by Alex Christensen.
+
+* web-platform-tests/IndexedDB/interfaces-expected.txt:
+
 2016-11-05  Jiewen Tan  
 
 Update SubtleCrypto::importKey to match the latest spec


Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/interfaces-expected.txt (208567 => 208568)

--- trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/interfaces-expected.txt	2016-11-10 23:07:15 UTC (rev 208567)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/interfaces-expected.txt	2016-11-10 23:27:37 UTC (rev 208568)
@@ -1,2 +1,161 @@
-FAIL: Timed out waiting for notifyDone to be called
+IndexedDB IDL tests
 
+
+PASS Window interface: attribute indexedDB 
+PASS IDBKeyRange interface: existence and properties of interface object 
+PASS IDBKeyRange interface object length 
+PASS IDBKeyRange interface object name 
+PASS IDBKeyRange interface: existence and properties of interface prototype object 
+PASS IDBKeyRange interface: existence and properties of interface prototype object's "constructor" property 
+PASS IDBKeyRange interface: attribute lower 
+PASS IDBKeyRange interface: attribute upper 
+PASS IDBKeyRange interface: attribute lowerOpen 
+PASS IDBKeyRange interface: attribute upperOpen 
+PASS IDBKeyRange interface: operation only(any) 
+PASS IDBKeyRange interface: operation lowerBound(any,boolean) 
+PASS IDBKeyRange interface: operation upperBound(any,boolean) 
+PASS IDBKeyRange interface: operation bound(any,any,boolean,boolean) 
+PASS IDBKeyRange must be primary interface of IDBKeyRange.only(0) 
+PASS Stringification of IDBKeyRange.only(0) 
+PASS IDBKeyRange interface: IDBKeyRange.only(0) must inherit property "lower" with the proper type (0) 
+PASS IDBKeyRange interface: IDBKeyRange.only(0) must inherit property "upper" with the proper type (1) 
+PASS IDBKeyRange interface: IDBKeyRange.only(0) must inherit property "lowerOpen" with the 

[webkit-changes] [208570] trunk/Source/WebCore

[commit-queue]

Title: [208570] trunk/Source/WebCore








Revision 208570
Author commit-qu...@webkit.org
Date 2016-11-10 16:01:14 -0800 (Thu, 10 Nov 2016)


Log Message
After r207459 ASSERT in CachedResourceLoader under InspectorPageAgent::cachedResource
https://bugs.webkit.org/show_bug.cgi?id=164621

Patch by Joseph Pecoraro  on 2016-11-10
Reviewed by Youenn Fablet.

* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResource):
CachedResourceLoader expects a sanitized URL.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorPageAgent.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208569 => 208570)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 23:59:42 UTC (rev 208569)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 00:01:14 UTC (rev 208570)
@@ -1,3 +1,14 @@
+2016-11-10  Joseph Pecoraro  
+
+After r207459 ASSERT in CachedResourceLoader under InspectorPageAgent::cachedResource
+https://bugs.webkit.org/show_bug.cgi?id=164621
+
+Reviewed by Youenn Fablet.
+
+* inspector/InspectorPageAgent.cpp:
+(WebCore::InspectorPageAgent::cachedResource):
+CachedResourceLoader expects a sanitized URL.
+
 2016-11-10  Brady Eidson  
 
 IndexedDB 2.0 Support the IDBDatabase.onclose event.


Modified: trunk/Source/WebCore/inspector/InspectorPageAgent.cpp (208569 => 208570)

--- trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2016-11-10 23:59:42 UTC (rev 208569)
+++ trunk/Source/WebCore/inspector/InspectorPageAgent.cpp	2016-11-11 00:01:14 UTC (rev 208570)
@@ -272,7 +272,7 @@
 if (url.isNull())
 return nullptr;
 
-CachedResource* cachedResource = frame->document()->cachedResourceLoader().cachedResource(url);
+CachedResource* cachedResource = frame->document()->cachedResourceLoader().cachedResource(MemoryCache::removeFragmentIdentifierIfNeeded(url));
 if (!cachedResource) {
 ResourceRequest request(url);
 #if ENABLE(CACHE_PARTITIONING)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208575] trunk/Source/WebCore

[commit-queue]

Title: [208575] trunk/Source/WebCore








Revision 208575
Author commit-qu...@webkit.org
Date 2016-11-10 18:20:48 -0800 (Thu, 10 Nov 2016)


Log Message
REGRESSION(r207182): [iOS] Crash because of passing freed CFDictionaryRef to CG when decoding a sub-sampled large image
https://bugs.webkit.org/show_bug.cgi?id=164617

Patch by Said Abou-Hallawa  on 2016-11-10
Reviewed by Tim Horton.

This covered by the test fast/images/image-subsampling.html but it should
run with --guard-malloc --repeat-each=10 to show the bug or to verify the
fix.

imageSourceOptions() returns a non static RetainPtr if
the subsamplingLevel is not zero. Because we are assigning the raw pointer
to a local variable in ImageDecoder::createFrameImageAtIndex(), CFRelease()
is called for the CFDictionaryRef immediately after this assignment. This
causes its memory to be freed in this case even before calling CG.

This bug does not happen if the subsamplingLevel is zero because we cache
the returned value in a static NeverDestroyed 208575)

--- trunk/Source/WebCore/ChangeLog	2016-11-11 01:27:02 UTC (rev 208574)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 02:20:48 UTC (rev 208575)
@@ -1,3 +1,33 @@
+2016-11-10  Said Abou-Hallawa  
+
+REGRESSION(r207182): [iOS] Crash because of passing freed CFDictionaryRef to CG when decoding a sub-sampled large image
+https://bugs.webkit.org/show_bug.cgi?id=164617
+
+Reviewed by Tim Horton.
+
+This covered by the test fast/images/image-subsampling.html but it should
+run with --guard-malloc --repeat-each=10 to show the bug or to verify the
+fix.
+
+imageSourceOptions() returns a non static RetainPtr if
+the subsamplingLevel is not zero. Because we are assigning the raw pointer
+to a local variable in ImageDecoder::createFrameImageAtIndex(), CFRelease()
+is called for the CFDictionaryRef immediately after this assignment. This
+causes its memory to be freed in this case even before calling CG.
+
+This bug does not happen if the subsamplingLevel is zero because we cache
+the returned value in a static NeverDestroyed
 
 [Win][Direct2D] Add transparency layer support


Modified: trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp (208574 => 208575)

--- trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp	2016-11-11 01:27:02 UTC (rev 208574)
+++ trunk/Source/WebCore/platform/graphics/cg/ImageDecoderCG.cpp	2016-11-11 02:20:48 UTC (rev 208575)
@@ -343,13 +343,13 @@
 {
 LOG(Images, "ImageDecoder %p createFrameImageAtIndex %lu", this, index);
 
-const auto* options = imageSourceOptions(subsamplingLevel, decodingMode).get();
+RetainPtr options = imageSourceOptions(subsamplingLevel, decodingMode);
 RetainPtr image;
 
 if (decodingMode == DecodingMode::OnDemand)
-image = adoptCF(CGImageSourceCreateImageAtIndex(m_nativeDecoder.get(), index, options));
+image = adoptCF(CGImageSourceCreateImageAtIndex(m_nativeDecoder.get(), index, options.get()));
 else
-image = adoptCF(CGImageSourceCreateThumbnailAtIndex(m_nativeDecoder.get(), index, options));
+image = adoptCF(CGImageSourceCreateThumbnailAtIndex(m_nativeDecoder.get(), index, options.get()));
 
 #if PLATFORM(IOS)
 //  - CoreGraphics changed the default caching behaviour in iOS 4.0 to kCGImageCachingTransient






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208582] trunk/Source/WebCore

[utatane . tea]

Title: [208582] trunk/Source/WebCore








Revision 208582
Author utatane@gmail.com
Date 2016-11-10 23:42:05 -0800 (Thu, 10 Nov 2016)


Log Message
[DOMJIT] DOMJIT accessor attribute in IDL should say like DOMJIT=Getter
https://bugs.webkit.org/show_bug.cgi?id=164632

Reviewed by Sam Weinig.

Currently, DOMJIT patchpoint is only allowed for getter in attributes.
To make it explicit, we use IDL attribute DOMJIT=Getter instead of
DOMJIT.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/IDLAttributes.txt:
* bindings/scripts/test/TestDOMJIT.idl:
* dom/Document.idl:
* dom/Node.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt
trunk/Source/WebCore/bindings/scripts/test/TestDOMJIT.idl
trunk/Source/WebCore/dom/Document.idl
trunk/Source/WebCore/dom/Node.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (208581 => 208582)

--- trunk/Source/WebCore/ChangeLog	2016-11-11 06:29:44 UTC (rev 208581)
+++ trunk/Source/WebCore/ChangeLog	2016-11-11 07:42:05 UTC (rev 208582)
@@ -1,3 +1,22 @@
+2016-11-10  Yusuke Suzuki  
+
+[DOMJIT] DOMJIT accessor attribute in IDL should say like DOMJIT=Getter
+https://bugs.webkit.org/show_bug.cgi?id=164632
+
+Reviewed by Sam Weinig.
+
+Currently, DOMJIT patchpoint is only allowed for getter in attributes.
+To make it explicit, we use IDL attribute DOMJIT=Getter instead of
+DOMJIT.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateHeader):
+(GenerateImplementation):
+* bindings/scripts/IDLAttributes.txt:
+* bindings/scripts/test/TestDOMJIT.idl:
+* dom/Document.idl:
+* dom/Node.idl:
+
 2016-11-10  Sam Weinig  
 
 [SVG] Start moving special casing of SVG out of the bindings - SVGPreserveAspectRatio


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (208581 => 208582)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-11-11 06:29:44 UTC (rev 208581)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-11-11 07:42:05 UTC (rev 208582)
@@ -1792,6 +1792,7 @@
 push(@headerContent,"// DOMJIT emitters for attributes\n\n");
 foreach my $attribute (@{$interface->attributes}) {
 next unless $attribute->extendedAttributes->{"DOMJIT"};
+assert("Only DOMJIT=Getter is supported for attributes") unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter");
 
 my $interfaceName = $interface->type->name;
 my $className = $interfaceName . $codeGenerator->WK_ucfirst($attribute->name);
@@ -3403,6 +3404,8 @@
 push(@implContent, "}\n\n");
 
 if ($attribute->extendedAttributes->{"DOMJIT"}) {
+assert("Only DOMJIT=Getter is supported for attributes") unless $codeGenerator->ExtendedAttributeContains($attribute->extendedAttributes->{DOMJIT}, "Getter");
+
 $implIncludes{""} = 1;
 $implIncludes{"DOMJITIDLTypeFilter.h"} = 1;
 my $interfaceName = $interface->type->name;


Modified: trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt (208581 => 208582)

--- trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt	2016-11-11 06:29:44 UTC (rev 208581)
+++ trunk/Source/WebCore/bindings/scripts/IDLAttributes.txt	2016-11-11 07:42:05 UTC (rev 208582)
@@ -52,7 +52,7 @@
 CustomSetPrototype
 CustomSetter
 CustomToJSObject
-DOMJIT=|ReadDOM
+DOMJIT=|ReadDOM|Getter
 DoNotCheckConstants
 DoNotCheckSecurity
 DoNotCheckSecurityOnGetter


Modified: trunk/Source/WebCore/bindings/scripts/test/TestDOMJIT.idl (208581 => 208582)

--- trunk/Source/WebCore/bindings/scripts/test/TestDOMJIT.idl	2016-11-11 06:29:44 UTC (rev 208581)
+++ trunk/Source/WebCore/bindings/scripts/test/TestDOMJIT.idl	2016-11-11 07:42:05 UTC (rev 208582)
@@ -27,42 +27,42 @@
  */
 
 interface TestDOMJIT : Node {
-[DOMJIT] readonly attribute any anyAttr;
-[DOMJIT] readonly attribute boolean booleanAttr;
-[DOMJIT] readonly attribute byte byteAttr;
-[DOMJIT] readonly attribute octet octetAttr;
-[DOMJIT] readonly attribute short shortAttr;
-[DOMJIT] readonly attribute unsigned short unsignedShortAttr;
-[DOMJIT] readonly attribute long longAttr;
-[DOMJIT] readonly attribute unsigned long unsignedLongAttr;
-[DOMJIT] readonly attribute long long longLongAttr;
-[DOMJIT] readonly attribute unsigned long long unsignedLongLongAttr;
-[DOMJIT] readonly attribute float floatAttr;
-[DOMJIT] readonly attribute unrestricted float unrestrictedFloatAttr;
-[DOMJIT] readonly attribute double doubleAttr;
-[DOMJIT] readonly attribute unrestricted double unrestrictedDoubleAttr;
-[DOMJIT] readonly attribute DOMString domStringAttr;
-[DOMJIT] readonly attribute ByteString 

[webkit-changes] [208558] trunk/Source

[achristensen]

Title: [208558] trunk/Source








Revision 208558
Author achristen...@apple.com
Date 2016-11-10 12:52:17 -0800 (Thu, 10 Nov 2016)


Log Message
Move SecurityOrigin::databaseIdentifier() to SecurityOriginData
https://bugs.webkit.org/show_bug.cgi?id=164573

Reviewed by Brady Eidson.

Source/WebCore:

No change in behavior.

* Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:
(WebCore::WebKitMediaKeySession::mediaKeysStorageDirectory):
* Modules/indexeddb/IDBDatabaseIdentifier.cpp:
(WebCore::IDBDatabaseIdentifier::databaseDirectoryRelativeToRoot):
* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesForOrigins):
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::hasEntryForOriginNoLock):
(WebCore::DatabaseTracker::hasEntryForDatabase):
(WebCore::DatabaseTracker::originPath):
(WebCore::DatabaseTracker::fullPathForDatabaseNoLock):
(WebCore::DatabaseTracker::databaseNamesForOriginNoLock):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::originLockFor):
(WebCore::DatabaseTracker::deleteOriginLockFor):
(WebCore::DatabaseTracker::quotaForOriginNoLock):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
* dom/Document.cpp:
(WebCore::Document::origin):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerMediaKeysStorageDirectory):
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::ApplicationCacheStorage::calculateQuotaForOrigin):
(WebCore::ApplicationCacheStorage::calculateUsageForOrigin):
(WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache):
(WebCore::ApplicationCacheStorage::storeUpdatedQuotaForOrigin):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::ensureOriginRecord):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::databaseIdentifier): Deleted.
* page/SecurityOrigin.h:
* page/SecurityOriginData.cpp:
(WebCore::SecurityOriginData::databaseIdentifier):
* page/SecurityOriginData.h:

Source/WebKit:

* Storage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::create):
* Storage/StorageTracker.cpp:
(WebKit::StorageTracker::deleteOrigin):
(WebKit::StorageTracker::diskUsageForOrigin):

Source/WebKit/mac:

* WebCoreSupport/WebSecurityOrigin.mm:
(-[WebSecurityOrigin databaseIdentifier]):

Source/WebKit2:

* Shared/API/c/WKSecurityOriginRef.cpp:
(WKSecurityOriginCopyDatabaseIdentifier):
* UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath):
(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
(WebKit::LocalStorageDatabaseTracker::deleteDatabaseWithOrigin):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeMediaKeys):
* WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
(WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyOriginsWithApplicationCache):
* WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:
(WebKit::WebMediaKeyStorageManager::mediaKeyStorageDirectoryForOrigin):
* WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:
(WebKit::UserMediaPermissionRequestManager::startUserMediaRequest):
(WebKit::UserMediaPermissionRequestManager::enumerateMediaDevices):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBDatabaseIdentifier.cpp
trunk/Source/WebCore/Modules/indexeddb/server/IDBServer.cpp
trunk/Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp
trunk/Source/WebCore/Modules/webdatabase/SQLTransactionCoordinator.cpp
trunk/Source/WebCore/dom/Document.cpp
trunk/Source/WebCore/html/HTMLMediaElement.cpp
trunk/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp
trunk/Source/WebCore/page/SecurityOrigin.cpp
trunk/Source/WebCore/page/SecurityOrigin.h
trunk/Source/WebCore/page/SecurityOriginData.cpp
trunk/Source/WebCore/page/SecurityOriginData.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Storage/StorageAreaImpl.cpp
trunk/Source/WebKit/Storage/StorageTracker.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebCoreSupport/WebSecurityOrigin.mm
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKSecurityOriginRef.cpp
trunk/Source/WebKit2/UIProcess/Storage/LocalStorageDatabaseTracker.cpp
trunk/Source/WebKit2/UIProcess/WebsiteData/WebsiteDataStore.cpp

[webkit-changes] [208533] trunk/Source/JavaScriptCore

[ossy]

Title: [208533] trunk/Source/_javascript_Core








Revision 208533
Author o...@webkit.org
Date 2016-11-10 05:37:38 -0800 (Thu, 10 Nov 2016)


Log Message
[ARM] Unreviewed buildfix after r208450.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::load8SignedExtendTo32): Added.

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (208532 => 208533)

--- trunk/Source/_javascript_Core/ChangeLog	2016-11-10 10:15:30 UTC (rev 208532)
+++ trunk/Source/_javascript_Core/ChangeLog	2016-11-10 13:37:38 UTC (rev 208533)
@@ -1,3 +1,10 @@
+2016-11-10  Csaba Osztrogonác  
+
+[ARM] Unreviewed buildfix after r208450.
+
+* assembler/MacroAssemblerARM.h:
+(JSC::MacroAssemblerARM::load8SignedExtendTo32): Added.
+
 2016-11-08  Yusuke Suzuki  
 
 [JSC] Avoid cloned arguments allocation in ArrayPrototype methods


Modified: trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h (208532 => 208533)

--- trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2016-11-10 10:15:30 UTC (rev 208532)
+++ trunk/Source/_javascript_Core/assembler/MacroAssemblerARM.h	2016-11-10 13:37:38 UTC (rev 208533)
@@ -394,6 +394,11 @@
 m_assembler.dataTransfer32(ARMAssembler::LoadUint8, dest, ARMRegisters::S0, 0);
 }
 
+void load8SignedExtendTo32(Address address, RegisterID dest)
+{
+m_assembler.dataTransfer16(ARMAssembler::LoadInt8, dest, address.base, address.offset);
+}
+
 void load8SignedExtendTo32(BaseIndex address, RegisterID dest)
 {
 m_assembler.baseIndexTransfer16(ARMAssembler::LoadInt8, dest, address.base, address.index, static_cast(address.scale), address.offset);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208534] trunk/Source

[carlosgc]

Title: [208534] trunk/Source








Revision 208534
Author carlo...@webkit.org
Date 2016-11-10 06:24:26 -0800 (Thu, 10 Nov 2016)


Log Message
MemoryPressureHandler shouldn't know how to release WebCore memory
https://bugs.webkit.org/show_bug.cgi?id=160497

Reviewed by Michael Catanzaro.

Source/WebCore:

All processes should set their own low memory handler, instead of leaving the web process using the default one
that needs to access APIs that are not in platform layer. This patch fixes all the layering violations in the
MemoryPressureHandler. Since the default implementation, that releases the WebCore memory, is shared by the
WebProcess in WebKit2 and WebKit1 ports, it has been moved to its own file to the WebCore layer.

* CMakeLists.txt: Add new files to compilation.
* PlatformMac.cmake: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad): Use WebCore::jettisonExpensiveObjectsOnTopLevelNavigation().
* page/MemoryRelease.cpp: Added.
(WebCore::releaseNoncriticalMemory):
(WebCore::releaseCriticalMemory):
(WebCore::releaseMemory):
(WebCore::platformReleaseMemory):
(WebCore::jettisonExpensiveObjectsOnTopLevelNavigation):
(WebCore::registerMemoryReleaseNotifyCallbacks):
* page/MemoryRelease.h: Added.
* page/cocoa/MemoryReleaseCocoa.mm: Added.
(WebCore::platformReleaseMemory):
(WebCore::jettisonExpensiveObjectsOnTopLevelNavigation):
(WebCore::registerMemoryReleaseNotifyCallbacks):
* platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
(WebCore::MemoryPressureHandler::beginSimulatedMemoryPressure):
(WebCore::MemoryPressureHandler::releaseMemory): Use the current handler if it has been set.
(WebCore::MemoryPressureHandler::platformReleaseMemory): Deleted.
* platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::setLowMemoryHandler):
(WebCore::MemoryPressureHandler::m_releaseMemoryBlock):
* platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::respondToMemoryPressure): Call releaseMemory() instead of using the handler directly.
(WebCore::MemoryPressureHandler::platformReleaseMemory): Deleted.
* platform/linux/MemoryPressureHandlerLinux.cpp:
* platform/win/MemoryPressureHandlerWin.cpp:
(WebCore::MemoryPressureHandler::respondToMemoryPressure): Call releaseMemory() instead of using the handler directly.

Source/WebKit/mac:

Set the low memory handler before installing the memory pressure handler.

* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/win:

Set the low memory handler before installing the memory pressure handler.

* WebView.cpp:
(WebView::initWithFrame):

Source/WebKit2:

Set the low memory handler before installing the memory pressure handler.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::platformInitializeWebProcess):

Modified Paths

trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformMac.cmake
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebCore/platform/MemoryPressureHandler.cpp
trunk/Source/WebCore/platform/MemoryPressureHandler.h
trunk/Source/WebCore/platform/cocoa/MemoryPressureHandlerCocoa.mm
trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp
trunk/Source/WebCore/platform/win/MemoryPressureHandlerWin.cpp
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebView.mm
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebView.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebProcess.cpp
trunk/Source/WebKit2/WebProcess/cocoa/WebProcessCocoa.mm


Added Paths

trunk/Source/WebCore/page/MemoryRelease.cpp
trunk/Source/WebCore/page/MemoryRelease.h
trunk/Source/WebCore/page/cocoa/MemoryReleaseCocoa.mm




Diff

Modified: trunk/Source/WebCore/CMakeLists.txt (208533 => 208534)

--- trunk/Source/WebCore/CMakeLists.txt	2016-11-10 13:37:38 UTC (rev 208533)
+++ trunk/Source/WebCore/CMakeLists.txt	2016-11-10 14:24:26 UTC (rev 208534)
@@ -2040,6 +2040,7 @@
 page/IntersectionObserverEntry.cpp
 page/Location.cpp
 page/MainFrame.cpp
+page/MemoryRelease.cpp
 page/MouseEventWithHitTestResults.cpp
 page/Navigator.cpp
 page/NavigatorBase.cpp


Modified: trunk/Source/WebCore/ChangeLog (208533 => 208534)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 13:37:38 UTC (rev 208533)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 14:24:26 UTC (rev 208534)
@@ -1,3 +1,47 @@
+2016-10-14  Carlos Garcia Campos  
+
+MemoryPressureHandler shouldn't know how to release WebCore memory
+https://bugs.webkit.org/show_bug.cgi?id=160497
+
+Reviewed by Michael Catanzaro.
+
+All processes should set their own low memory handler, instead of leaving the web process using the default one
+that needs to access APIs 

[webkit-changes] [208532] trunk

[svillar]

Title: [208532] trunk








Revision 208532
Author svil...@igalia.com
Date 2016-11-10 02:15:30 -0800 (Thu, 10 Nov 2016)


Log Message
[GTK] New API to notify about dynamically added forms
https://bugs.webkit.org/show_bug.cgi?id=164050

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

This new API exports the WebCore event didAssociateFormControls through the web extension
mechanism. This will help clients (mainly web browsers) to implement robust auto filling
mechanisms. It deals nicely with dynamically created forms (and form controls) as many JS
frameworks do nowadays.

* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Added a FormClient implementation of
API::InjectedBundle::FormClient.
(webkitWebPageFormControlsAssociated): Emit the new signal.
(webkit_web_page_class_init): Added the new signal "forms-controls-associated".
(webkitWebPageCreate): Set the WebPage as a FormClient.

Tools:

Added a new test case to verify that dinamically added forms correctly trigger the
"form-controls-associated" signal from WebPage.

* TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
(didAssociateFormControlsCallback):
(testWebExtensionFormControlsAssociated):
(beforeAll):
* TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(DelayedSignal::DelayedSignal):
(emitFormControlsAssociated):
(formControlsAssociatedCallback):
(pageCreatedCallback):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp
trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208531 => 208532)

--- trunk/Source/WebKit2/ChangeLog	2016-11-10 10:08:19 UTC (rev 208531)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-10 10:15:30 UTC (rev 208532)
@@ -1,3 +1,21 @@
+2016-10-27  Sergio Villar Senin  
+
+[GTK] New API to notify about dynamically added forms
+https://bugs.webkit.org/show_bug.cgi?id=164050
+
+Reviewed by Carlos Garcia Campos.
+
+This new API exports the WebCore event didAssociateFormControls through the web extension
+mechanism. This will help clients (mainly web browsers) to implement robust auto filling
+mechanisms. It deals nicely with dynamically created forms (and form controls) as many JS
+frameworks do nowadays.
+
+* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp: Added a FormClient implementation of
+API::InjectedBundle::FormClient.
+(webkitWebPageFormControlsAssociated): Emit the new signal.
+(webkit_web_page_class_init): Added the new signal "forms-controls-associated".
+(webkitWebPageCreate): Set the WebPage as a FormClient.
+
 2016-11-10  Carlos Alberto Lopez Perez  
 
 [GTK] Allow to use WebMemorySampler feature.


Modified: trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp (208531 => 208532)

--- trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp	2016-11-10 10:08:19 UTC (rev 208531)
+++ trunk/Source/WebKit2/WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp	2016-11-10 10:15:30 UTC (rev 208532)
@@ -31,6 +31,7 @@
 #include "WebKitConsoleMessagePrivate.h"
 #include "WebKitContextMenuPrivate.h"
 #include "WebKitDOMDocumentPrivate.h"
+#include "WebKitDOMElementPrivate.h"
 #include "WebKitFramePrivate.h"
 #include "WebKitMarshal.h"
 #include "WebKitPrivate.h"
@@ -60,6 +61,7 @@
 SEND_REQUEST,
 CONTEXT_MENU,
 CONSOLE_MESSAGE_SENT,
+FORM_CONTROLS_ASSOCIATED,
 
 LAST_SIGNAL
 };
@@ -340,6 +342,28 @@
 WebKitWebPage* m_webPage;
 };
 
+class FormClient final : public API::InjectedBundle::FormClient {
+public:
+explicit FormClient(WebKitWebPage* webPage)
+: m_webPage(webPage)
+{
+}
+
+void didAssociateFormControls(WebPage*, const Vector& elements) override
+{
+GRefPtr formElements = adoptGRef(g_ptr_array_sized_new(elements.size()));
+for (size_t i = 0; i < elements.size(); ++i)
+g_ptr_array_add(formElements.get(), WebKit::kit(elements[i].get()));
+
+g_signal_emit(m_webPage, signals[FORM_CONTROLS_ASSOCIATED], 0, formElements.get());
+}
+
+bool shouldNotifyOnFormChanges(WebPage*) override { return true; }
+
+private:
+WebKitWebPage* m_webPage;
+};
+
 static void webkitWebPageGetProperty(GObject* object, guint propId, GValue* value, GParamSpec* paramSpec)
 {
 WebKitWebPage* webPage = WEBKIT_WEB_PAGE(object);
@@ -473,6 +497,33 @@
 g_cclosure_marshal_VOID__BOXED,
 G_TYPE_NONE, 1,
 WEBKIT_TYPE_CONSOLE_MESSAGE | G_SIGNAL_TYPE_STATIC_SCOPE);
+
+/**
+ * WebKitWebPage::form-controls-associated:
+ * @web_page: the #WebKitWebPage on which the signal is emitted
+ * @elements: (element-type WebKit.DOMElement) (transfer none): a #GPtrArray of
+ * #WebKitDOMElement with the list of forms 

[webkit-changes] [208530] trunk/Source/WebCore

[commit-queue]

Title: [208530] trunk/Source/WebCore








Revision 208530
Author commit-qu...@webkit.org
Date 2016-11-10 01:01:21 -0800 (Thu, 10 Nov 2016)


Log Message
[WebRTC] [OpenWebRTC] RTX default parameters broken after r207952
https://bugs.webkit.org/show_bug.cgi?id=164541

Patch by Alejandro G. Castro  on 2016-11-10
Reviewed by Philippe Normand.

Fixed typo in refactoring.

* platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:
(WebCore::MediaEndpointOwr::getDefaultVideoPayloads):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208529 => 208530)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 08:46:13 UTC (rev 208529)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 09:01:21 UTC (rev 208530)
@@ -1,3 +1,15 @@
+2016-11-10  Alejandro G. Castro  
+
+[WebRTC] [OpenWebRTC] RTX default parameters broken after r207952
+https://bugs.webkit.org/show_bug.cgi?id=164541
+
+Reviewed by Philippe Normand.
+
+Fixed typo in refactoring.
+
+* platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:
+(WebCore::MediaEndpointOwr::getDefaultVideoPayloads):
+
 2016-11-08  Philippe Normand  
 
 [WebRTC] white-list turns urls from the RTCConfiguration


Modified: trunk/Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp (208529 => 208530)

--- trunk/Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp	2016-11-10 08:46:13 UTC (rev 208529)
+++ trunk/Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp	2016-11-10 09:01:21 UTC (rev 208530)
@@ -161,8 +161,8 @@
 payload3.type = 120;
 payload3.encodingName = "RTX";
 payload3.clockRate = 9;
-payload1.addParameter("apt", 100);
-payload1.addParameter("rtxTime", 200);
+payload3.addParameter("apt", 100);
+payload3.addParameter("rtxTime", 200);
 payloads.append(WTFMove(payload3));
 
 return payloads;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208540] trunk

[commit-queue]

Title: [208540] trunk








Revision 208540
Author commit-qu...@webkit.org
Date 2016-11-10 09:10:09 -0800 (Thu, 10 Nov 2016)


Log Message
Web Inspector: AXI: clarify button roles (e.g. toggle or popup button)
https://bugs.webkit.org/show_bug.cgi?id=130726


Patch by Aaron Chu  on 2016-11-10
Reviewed by Brian Burg.

Source/_javascript_Core:

Add the isPopupButton flag to the AccessibilityProperties type.

* inspector/protocol/DOM.json:

Source/WebCore:

Test: accessibility/ax-differentiate-button-types.html

Added special case logic to make sure PopUpButtonRole and ToggleButtonRole to user ButtonRole as role.
Added an "isPopUpButton" property to be exposed to the Inspector's use.

* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::computedRoleString):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):

Source/WebInspectorUI:

Updated Inspector to show the button type using the new mapping information.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode.prototype.accessibilityProperties.accessibilityPropertiesCallback):
(WebInspector.DOMNode.prototype.accessibilityProperties):
* UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility.accessibilityPropertiesCallback):
(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshAccessibility):

LayoutTests:

Updated related test cases.

* accessibility/roles-computedRoleString-expected.txt:
* accessibility/roles-computedRoleString.html:
* inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
* inspector/dom/getAccessibilityPropertiesForNode.html:
* platform/mac/accessibility/roles-computedRoleString-expected.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt
trunk/LayoutTests/accessibility/roles-computedRoleString.html
trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt
trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode.html
trunk/LayoutTests/platform/mac/accessibility/roles-computedRoleString-expected.txt
trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/inspector/protocol/DOM.json
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/accessibility/AccessibilityObject.cpp
trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js
trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js




Diff

Modified: trunk/LayoutTests/ChangeLog (208539 => 208540)

--- trunk/LayoutTests/ChangeLog	2016-11-10 17:08:41 UTC (rev 208539)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 17:10:09 UTC (rev 208540)
@@ -1,3 +1,19 @@
+2016-11-10  Aaron Chu  
+
+Web Inspector: AXI: clarify button roles (e.g. toggle or popup button)
+https://bugs.webkit.org/show_bug.cgi?id=130726
+
+
+Reviewed by Brian Burg.
+
+Updated related test cases.
+
+* accessibility/roles-computedRoleString-expected.txt:
+* accessibility/roles-computedRoleString.html:
+* inspector/dom/getAccessibilityPropertiesForNode-expected.txt:
+* inspector/dom/getAccessibilityPropertiesForNode.html:
+* platform/mac/accessibility/roles-computedRoleString-expected.txt:
+
 2016-11-10  Antoine Quint  
 
 [Modern Media Controls] Media Controller: update controls based on fullscreen playback on macOS


Modified: trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt (208539 => 208540)

--- trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt	2016-11-10 17:08:41 UTC (rev 208539)
+++ trunk/LayoutTests/accessibility/roles-computedRoleString-expected.txt	2016-11-10 17:10:09 UTC (rev 208540)
@@ -54,7 +54,7 @@
 PASS: section:not([aria-label]:not([aria-labelledby]) -> group. 
 PASS: section[aria-label] -> region. 
 PASS: section[aria-labelledby] -> region. 
-PASS: select:not([multiple]) -> . 
+PASS: select:not([multiple]) -> button. 
 PASS: select[multiple] -> listbox. 
 PASS: option -> option. 
 PASS: optgroup -> option. 


Modified: trunk/LayoutTests/accessibility/roles-computedRoleString.html (208539 => 208540)

--- trunk/LayoutTests/accessibility/roles-computedRoleString.html	2016-11-10 17:08:41 UTC (rev 208539)
+++ trunk/LayoutTests/accessibility/roles-computedRoleString.html	2016-11-10 17:10:09 UTC (rev 208540)
@@ -82,7 +82,7 @@
 
 X
 
-
+
 X
 
 X


Modified: trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt (208539 => 208540)

--- trunk/LayoutTests/inspector/dom/getAccessibilityPropertiesForNode-expected.txt	2016-11-10 17:08:41 UTC (rev 208539)
+++ 

[webkit-changes] [208531] trunk

[svillar]

Title: [208531] trunk








Revision 208531
Author svil...@igalia.com
Date 2016-11-10 02:08:19 -0800 (Thu, 10 Nov 2016)


Log Message
[css-grid] Fix fr tracks sizing under min|max-size constraints
https://bugs.webkit.org/show_bug.cgi?id=150674

Reviewed by Darin Adler.

Source/WebCore:

The min|max-sizes must be used to compute the flex fraction for indefinite free
spaces. According to the spec "If using this flex fraction would cause the grid to be
smaller than the grid container’s min-width/height (or larger than the grid container’s
max-width/height), then redo this step, treating the free space as definite and the
available grid space as equal to the grid container’s content box size when it’s sized to
its min-width/height (max-width/height)."

This only affects indefinite heights because during layout both definite sizes and any kind
of widths are properly constrained by min|max-width restrictions.

Tests: fast/css-grid-layout/flex-sizing-columns-min-max-width.html
   fast/css-grid-layout/flex-sizing-rows-min-max-height.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeFlexSizedTracksGrowth):
* rendering/RenderGrid.h:

LayoutTests:

* fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt: Added.
* fast/css-grid-layout/flex-sizing-columns-min-max-width.html: Added.
* fast/css-grid-layout/flex-sizing-rows-min-max-height-expected.txt: Added.
* fast/css-grid-layout/flex-sizing-rows-min-max-height.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h


Added Paths

trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt
trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width.html
trunk/LayoutTests/fast/css-grid-layout/flex-sizing-rows-min-max-height-expected.txt
trunk/LayoutTests/fast/css-grid-layout/flex-sizing-rows-min-max-height.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208530 => 208531)

--- trunk/LayoutTests/ChangeLog	2016-11-10 09:01:21 UTC (rev 208530)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 10:08:19 UTC (rev 208531)
@@ -1,3 +1,15 @@
+2016-11-08  Sergio Villar Senin  
+
+[css-grid] Fix fr tracks sizing under min|max-size constraints
+https://bugs.webkit.org/show_bug.cgi?id=150674
+
+Reviewed by Darin Adler.
+
+* fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt: Added.
+* fast/css-grid-layout/flex-sizing-columns-min-max-width.html: Added.
+* fast/css-grid-layout/flex-sizing-rows-min-max-height-expected.txt: Added.
+* fast/css-grid-layout/flex-sizing-rows-min-max-height.html: Added.
+
 2016-11-09  Ryosuke Niwa  
 
 WebHTMLView's _attributeStringFromDOMRange should use HTMLConverter instead of NSAttributedString's _initWithDOMRange


Added: trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt (0 => 208531)

--- trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt	2016-11-10 10:08:19 UTC (rev 208531)
@@ -0,0 +1,17 @@
+This test PASS if all the grids in the same row look the same.
+
+PASS
+PASS
+PASS
+
+PASS
+PASS
+PASS
+
+PASS
+PASS
+PASS
+
+PASS
+PASS
+PASS
Property changes on: trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width-expected.txt
___


Added: svn:eol-style
+LF
\ No newline at end of property

Added: trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width.html (0 => 208531)

--- trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/flex-sizing-columns-min-max-width.html	2016-11-10 10:08:19 UTC (rev 208531)
@@ -0,0 +1,88 @@
+
+
+
+
+.grid {
+   margin: 3px;
+   grid: 50px / minmax(10px, 1fr) minmax(10px, 4fr);
+   grid-column-gap: 33px;
+   border: 5px dashed;
+   padding: 2px;
+}
+
+.float { float: left; }
+
+.item:nth-child(1) { background-color: purple; }
+.item:nth-child(2) { background-color: blue; }
+
+

[webkit-changes] [208537] trunk

[commit-queue]

Title: [208537] trunk








Revision 208537
Author commit-qu...@webkit.org
Date 2016-11-10 07:43:53 -0800 (Thu, 10 Nov 2016)


Log Message
[Modern Media Controls] Media Controller: update controls based on fullscreen playback on macOS
https://bugs.webkit.org/show_bug.cgi?id=164554


Patch by Antoine Quint  on 2016-11-10
Reviewed by Dean Jackson.

Source/WebCore:

When toggling fullscreen on macOS, toggle between MacOSInlineMediaControls and MacOSFullscreenMediaControls.
To facilitate this, support objects are created and destroyed when changing the controls in order for the
right control objects to be hooked up to the media controller. A new destroy() method on MediaControllerSupport
subclasses can be overridden to remove event listeners added by support objects in their constructor.

Test: media/modern-media-controls/media-controller/media-controller-fullscreen-change.html

* Modules/modern-media-controls/media/fullscreen-support.js:
(FullscreenSupport.prototype.destroy):
* Modules/modern-media-controls/media/media-controller-support.js:
(MediaControllerSupport.prototype.destroy):
* Modules/modern-media-controls/media/media-controller.js:
(MediaController):
(MediaController.prototype.get layoutTraits):
(MediaController.prototype.handleEvent):
(MediaController.prototype._updateControlsIfNeeded):
(MediaController.prototype._controlsClass):

LayoutTests:

Adding a new test to check that we use fullscreen controls on macOS once we've entered fullscreen.

* media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt: Added.
* media/modern-media-controls/media-controller/media-controller-fullscreen-change.html: Added.
* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/modern-media-controls/media/fullscreen-support.js
trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller-support.js
trunk/Source/WebCore/Modules/modern-media-controls/media/media-controller.js


Added Paths

trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt
trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208536 => 208537)

--- trunk/LayoutTests/ChangeLog	2016-11-10 15:02:08 UTC (rev 208536)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 15:43:53 UTC (rev 208537)
@@ -1,3 +1,17 @@
+2016-11-10  Antoine Quint  
+
+[Modern Media Controls] Media Controller: update controls based on fullscreen playback on macOS
+https://bugs.webkit.org/show_bug.cgi?id=164554
+
+
+Reviewed by Dean Jackson.
+
+Adding a new test to check that we use fullscreen controls on macOS once we've entered fullscreen.
+
+* media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt: Added.
+* media/modern-media-controls/media-controller/media-controller-fullscreen-change.html: Added.
+* platform/ios-simulator/TestExpectations:
+
 2016-11-08  Sergio Villar Senin  
 
 [css-grid] Fix fr tracks sizing under min|max-size constraints


Added: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt (0 => 208537)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt	(rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change-expected.txt	2016-11-10 15:43:53 UTC (rev 208537)
@@ -0,0 +1,17 @@
+Testing the MediaController behavior when entering and leaving fullscreen.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Media entered fullscreen
+PASS mediaController.layoutTraits is LayoutTraits.macOS | LayoutTraits.Fullscreen
+PASS mediaController.controls instanceof MacOSFullscreenMediaControls is true
+
+Media exited fullscreen
+PASS mediaController.layoutTraits is LayoutTraits.macOS
+PASS mediaController.controls instanceof MacOSInlineMediaControls is true
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+


Added: trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html (0 => 208537)

--- trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html	(rev 0)
+++ trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-fullscreen-change.html	2016-11-10 15:43:53 UTC (rev 208537)
@@ -0,0 +1,64 @@
+
+
+
+
+
+
+window.jsTestIsAsync = true;
+
+description("Testing the MediaController behavior when entering and leaving fullscreen.");
+
+const shadowRoot = 

[webkit-changes] [208538] trunk/Source/WebKit2

[carlosgc]

Title: [208538] trunk/Source/WebKit2








Revision 208538
Author carlo...@webkit.org
Date 2016-11-10 08:03:51 -0800 (Thu, 10 Nov 2016)


Log Message
[Linux] Memory process values shown by the WebMemorySampler in linux are wrong
https://bugs.webkit.org/show_bug.cgi?id=164591

Reviewed by Michael Catanzaro.

It's parsing /proc/self/statm, and returning the values as if they were bytes, but they are number of pages, so
to get the bytes we need to take the page size into account. In r208534 I added a method to get /proc/self/statm
values in bytes to Platform layer, so we can simply use that instead.

* Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::WebMemorySampler::sampleWebKit): Use currentProcessMemoryStatus() and update the descriptions to
clarify that values are in bytes.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208537 => 208538)

--- trunk/Source/WebKit2/ChangeLog	2016-11-10 15:43:53 UTC (rev 208537)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-10 16:03:51 UTC (rev 208538)
@@ -1,3 +1,18 @@
+2016-11-10  Carlos Garcia Campos  
+
+[Linux] Memory process values shown by the WebMemorySampler in linux are wrong
+https://bugs.webkit.org/show_bug.cgi?id=164591
+
+Reviewed by Michael Catanzaro.
+
+It's parsing /proc/self/statm, and returning the values as if they were bytes, but they are number of pages, so
+to get the bytes we need to take the page size into account. In r208534 I added a method to get /proc/self/statm
+values in bytes to Platform layer, so we can simply use that instead.
+
+* Shared/linux/WebMemorySamplerLinux.cpp:
+(WebKit::WebMemorySampler::sampleWebKit): Use currentProcessMemoryStatus() and update the descriptions to
+clarify that values are in bytes.
+
 2016-10-14  Carlos Garcia Campos  
 
 MemoryPressureHandler shouldn't know how to release WebCore memory


Modified: trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp (208537 => 208538)

--- trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp	2016-11-10 15:43:53 UTC (rev 208537)
+++ trunk/Source/WebKit2/Shared/linux/WebMemorySamplerLinux.cpp	2016-11-10 16:03:51 UTC (rev 208538)
@@ -28,10 +28,11 @@
 
 #if ENABLE(MEMORY_SAMPLER)
 
-#include "NotImplemented.h"
 #include <_javascript_Core/MemoryStatistics.h>
+#include 
+#include 
+#include 
 #include 
-#include 
 #include 
 #include 
 #include 
@@ -44,16 +45,6 @@
 
 namespace WebKit {
 
-struct ApplicationMemoryStats {
-size_t totalProgramSize;
-size_t residentSetSize;
-size_t sharedSize;
-size_t textSize;
-size_t librarySize;
-size_t dataStackSize;
-size_t dirtyPageSize;
-};
-
 static const unsigned int maxBuffer = 128;
 static const unsigned int maxProcessPath = 35;
 
@@ -84,28 +75,6 @@
 stats.values.append(value);
 }
 
-static ApplicationMemoryStats sampleMemoryAllocatedForApplication()
-{
-ApplicationMemoryStats applicationStats = {0, 0, 0, 0, 0, 0, 0};
-char processPath[maxProcessPath];
-snprintf(processPath, maxProcessPath, "/proc/self/statm");
-FILE* statmFileDescriptor = fopen(processPath, "r");
-if (!statmFileDescriptor)
-return applicationStats;
-
-applicationStats.totalProgramSize = nextToken(statmFileDescriptor).toInt();
-applicationStats.residentSetSize = nextToken(statmFileDescriptor).toInt();
-applicationStats.sharedSize = nextToken(statmFileDescriptor).toInt();
-applicationStats.textSize = nextToken(statmFileDescriptor).toInt();
-applicationStats.librarySize = nextToken(statmFileDescriptor).toInt();
-applicationStats.dataStackSize = nextToken(statmFileDescriptor).toInt();
-applicationStats.dirtyPageSize = nextToken(statmFileDescriptor).toInt();
-
-fclose(statmFileDescriptor);
-
-return applicationStats;
-}
-
 String WebMemorySampler::processName() const
 {
 char processPath[maxProcessPath];
@@ -130,15 +99,16 @@
 
 appendKeyValuePair(webKitMemoryStats, ASCIILiteral("Timestamp"), now);
 
-ApplicationMemoryStats applicationStats = sampleMemoryAllocatedForApplication();
+ProcessMemoryStatus processMemoryStatus;
+currentProcessMemoryStatus(processMemoryStatus);
 
-appendKeyValuePair(webKitMemoryStats, ASCIILiteral("Total Program Size"), applicationStats.totalProgramSize);
-appendKeyValuePair(webKitMemoryStats, ASCIILiteral("RSS"), applicationStats.residentSetSize);
-appendKeyValuePair(webKitMemoryStats, ASCIILiteral("Shared"), applicationStats.sharedSize);
-appendKeyValuePair(webKitMemoryStats, ASCIILiteral("Text"), applicationStats.textSize);
-appendKeyValuePair(webKitMemoryStats, ASCIILiteral("Library"), applicationStats.librarySize);
-appendKeyValuePair(webKitMemoryStats, ASCIILiteral("Data/Stack"), applicationStats.dataStackSize);
-appendKeyValuePair(webKitMemoryStats, 

[webkit-changes] [208536] trunk/Source/WebCore

[carlosgc]

Title: [208536] trunk/Source/WebCore








Revision 208536
Author carlo...@webkit.org
Date 2016-11-10 07:02:08 -0800 (Thu, 10 Nov 2016)


Log Message
[Linux] Memory values shown by memory pressure handler logger are not useful
https://bugs.webkit.org/show_bug.cgi?id=164589

Reviewed by Michael Catanzaro.

We are currently using the VmSize field from /proc/self/status which is the virtual memory size of the process
and doesn't normally change even when the memory pressure handler manages to release memory. So, most of the
time we see that there's no changes in memory usage in the logs.
We should use the actual memory used by the process, memory that the process can release and then it's relevant
for the memory pressure handler. Using other fields from /proc/self/status we could do something like VmRSS -
(RssFile + RssShme), but there's also /proc/self/statm that provides the same information in a single. The main
different is that statm provides both resident and shared memory directly, but in number of pages, so we need to
multiply by the size of the page.
This patch adds a method to parse /proc/self/statm in its given file, because I plan to use this for the linux
memory sampler that is incorrectly parsing /proc/self/statm.

* platform/Linux.cmake: Add new files to compilation.
* platform/linux/CurrentProcessMemoryStatus.cpp: Added.
(WebCore::systemPageSize): Return the page size.
(WebCore::currentProcessMemoryStatus): Parse /proc/self/statm and fill the given ProcessMemoryStatus.
* platform/linux/CurrentProcessMemoryStatus.h: Added.
* platform/linux/MemoryPressureHandlerLinux.cpp:
(WebCore::MemoryPressureHandler::processMemoryUsage(): Helper function to return the memory used by the process
in bytes.
(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage): Use processMemoryUsage().

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/Linux.cmake
trunk/Source/WebCore/platform/linux/MemoryPressureHandlerLinux.cpp


Added Paths

trunk/Source/WebCore/platform/linux/CurrentProcessMemoryStatus.cpp
trunk/Source/WebCore/platform/linux/CurrentProcessMemoryStatus.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (208535 => 208536)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 14:38:06 UTC (rev 208535)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 15:02:08 UTC (rev 208536)
@@ -1,3 +1,31 @@
+2016-11-10  Carlos Garcia Campos  
+
+[Linux] Memory values shown by memory pressure handler logger are not useful
+https://bugs.webkit.org/show_bug.cgi?id=164589
+
+Reviewed by Michael Catanzaro.
+
+We are currently using the VmSize field from /proc/self/status which is the virtual memory size of the process
+and doesn't normally change even when the memory pressure handler manages to release memory. So, most of the
+time we see that there's no changes in memory usage in the logs.
+We should use the actual memory used by the process, memory that the process can release and then it's relevant
+for the memory pressure handler. Using other fields from /proc/self/status we could do something like VmRSS -
+(RssFile + RssShme), but there's also /proc/self/statm that provides the same information in a single. The main
+different is that statm provides both resident and shared memory directly, but in number of pages, so we need to
+multiply by the size of the page.
+This patch adds a method to parse /proc/self/statm in its given file, because I plan to use this for the linux
+memory sampler that is incorrectly parsing /proc/self/statm.
+
+* platform/Linux.cmake: Add new files to compilation.
+* platform/linux/CurrentProcessMemoryStatus.cpp: Added.
+(WebCore::systemPageSize): Return the page size.
+(WebCore::currentProcessMemoryStatus): Parse /proc/self/statm and fill the given ProcessMemoryStatus.
+* platform/linux/CurrentProcessMemoryStatus.h: Added.
+* platform/linux/MemoryPressureHandlerLinux.cpp:
+(WebCore::MemoryPressureHandler::processMemoryUsage(): Helper function to return the memory used by the process
+in bytes.
+(WebCore::MemoryPressureHandler::ReliefLogger::platformMemoryUsage): Use processMemoryUsage().
+
 2016-10-14  Carlos Garcia Campos  
 
 MemoryPressureHandler shouldn't know how to release WebCore memory


Modified: trunk/Source/WebCore/platform/Linux.cmake (208535 => 208536)

--- trunk/Source/WebCore/platform/Linux.cmake	2016-11-10 14:38:06 UTC (rev 208535)
+++ trunk/Source/WebCore/platform/Linux.cmake	2016-11-10 15:02:08 UTC (rev 208536)
@@ -5,5 +5,7 @@
 
 list(APPEND WebCore_SOURCES
 platform/gamepad/linux/GamepadDeviceLinux.cpp
+
+platform/linux/CurrentProcessMemoryStatus.cpp
 platform/linux/MemoryPressureHandlerLinux.cpp
 )


Added: trunk/Source/WebCore/platform/linux/CurrentProcessMemoryStatus.cpp (0 => 208536)

--- 

[webkit-changes] [208545] trunk/Source/WebCore

[beidson]

Title: [208545] trunk/Source/WebCore








Revision 208545
Author beid...@apple.com
Date 2016-11-10 10:04:03 -0800 (Thu, 10 Nov 2016)


Log Message
IndexedDB 2.0: REGRESSION(r208467) Fix flaky crashes in IDB GC-related code.
https://bugs.webkit.org/show_bug.cgi?id=164596

Reviewed by Eric Carlson.

No new tests (Covered by existing tests).

We can't just WTFMove the pointers from the deleted-IDBObject maps...
We need to remove the entries, too.

* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::rollbackForVersionChangeAbort):

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::internalAbort):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp
trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208544 => 208545)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 17:30:34 UTC (rev 208544)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 18:04:03 UTC (rev 208545)
@@ -1,3 +1,21 @@
+2016-11-10  Brady Eidson  
+
+IndexedDB 2.0: REGRESSION(r208467) Fix flaky crashes in IDB GC-related code.
+https://bugs.webkit.org/show_bug.cgi?id=164596
+
+Reviewed by Eric Carlson.
+
+No new tests (Covered by existing tests).
+
+We can't just WTFMove the pointers from the deleted-IDBObject maps...
+We need to remove the entries, too.
+
+* Modules/indexeddb/IDBObjectStore.cpp:
+(WebCore::IDBObjectStore::rollbackForVersionChangeAbort):
+
+* Modules/indexeddb/IDBTransaction.cpp:
+(WebCore::IDBTransaction::internalAbort):
+
 2016-11-10  Youenn Fablet  
 
 MediaStreamTrack should use more Ref<> and less RefPtr<>


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp (208544 => 208545)

--- trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp	2016-11-10 17:30:34 UTC (rev 208544)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp	2016-11-10 18:04:03 UTC (rev 208545)
@@ -618,13 +618,19 @@
 }
 
 Locker locker(m_referencedIndexLock);
+
+Vector identifiersToRemove;
 for (auto& iterator : m_deletedIndexes) {
 if (m_info.hasIndex(iterator.key)) {
 auto name = iterator.value->info().name();
 m_referencedIndexes.set(name, WTFMove(iterator.value));
+identifiersToRemove.append(iterator.key);
 }
 }
 
+for (auto identifier : identifiersToRemove)
+m_deletedIndexes.remove(identifier);
+
 for (auto& index : m_referencedIndexes.values())
 index->rollbackInfoForVersionChangeAbort();
 }


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp (208544 => 208545)

--- trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp	2016-11-10 17:30:34 UTC (rev 208544)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTransaction.cpp	2016-11-10 18:04:03 UTC (rev 208545)
@@ -226,13 +226,18 @@
 Locker locker(m_referencedObjectStoreLock);
 
 auto& info = m_database->info();
+Vector identifiersToRemove;
 for (auto& iterator : m_deletedObjectStores) {
 if (info.infoForExistingObjectStore(iterator.key)) {
 auto name = iterator.value->info().name();
 m_referencedObjectStores.set(name, WTFMove(iterator.value));
+identifiersToRemove.append(iterator.key);
 }
 }
 
+for (auto identifier : identifiersToRemove)
+m_deletedObjectStores.remove(identifier);
+
 for (auto& objectStore : m_referencedObjectStores.values())
 objectStore->rollbackForVersionChangeAbort();
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208547] trunk/LayoutTests

[ryanhaddad]

Title: [208547] trunk/LayoutTests








Revision 208547
Author ryanhad...@apple.com
Date 2016-11-10 10:31:59 -0800 (Thu, 10 Nov 2016)


Log Message
Marking media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=164598

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208546 => 208547)

--- trunk/LayoutTests/ChangeLog	2016-11-10 18:08:06 UTC (rev 208546)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 18:31:59 UTC (rev 208547)
@@ -1,5 +1,14 @@
 2016-11-10  Ryan Haddad  
 
+Marking media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=164598
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2016-11-10  Ryan Haddad  
+
 Temporarily marking storage/domstorage/sessionstorage/blocked-file-access.html as failing.
 https://bugs.webkit.org/show_bug.cgi?id=164592
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (208546 => 208547)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 18:08:06 UTC (rev 208546)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 18:31:59 UTC (rev 208547)
@@ -1463,6 +1463,7 @@
 webkit.org/b/164298 media/modern-media-controls/placard-support/placard-support-airplay.html [ Pass Timeout ]
 webkit.org/b/164322 [ ElCapitan ] media/modern-media-controls/placard-support/placard-support-pip.html [ Timeout ]
 webkit.org/b/164328 media/modern-media-controls/scrubber-support/scrubber-support-drag.html [ Pass Failure Timeout ]
+webkit.org/b/164598 media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html [ Pass Failure ]
 
 webkit.org/b/164277 fast/preloader/image-srcset.html [ Pass Failure ]
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208549] trunk

[dbates]

Title: [208549] trunk








Revision 208549
Author dba...@webkit.org
Date 2016-11-10 10:50:08 -0800 (Thu, 10 Nov 2016)


Log Message
REGRESSION (r195004): Scripts and plugins blocked for subsequent loads in same WebContent
process after receiving HTTP 0.9 response
https://bugs.webkit.org/show_bug.cgi?id=164387


Reviewed by Brent Fulgham.

Source/WebCore:

Fixes an issue where the HTTP 0.9 sandbox persisted across subsequent loads in the same
WebContent process.

Currently when an HTTP 0.9 response is received for a request made to a default port
(e.g. 80) we apply a sandbox policy on the FrameLoader for the main resource that
disallows scripts and plugins. A FrameLoader may be re-used for navigations. Therefore,
the sandbox policy applied to one site may be applied to another site. Moreover the
sandbox policy was applied to the FrameLoader of the main resource regardless of whether
the HTTP response was for a subresource. Instead we should apply the sandbox on a per-
Document basis and only if we receive an HTTP 0.9 response for the document when the
corresponding HTTP request was made to a default port.

As a side benefit of this change, we emit exactly one console message to Web Inspector
when the HTTP 0.9 sandbox is applied to a document as opposed to three console messages.
Moreover, we only emit this console message when the document load is not blocked.

Test: http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html

* dom/Document.cpp:
(WebCore::Document::initSecurityContext): Disallow scripts and plugins if an HTTP 0.9
response was received for this document. Note that if this function is called for a
document associated with an HTTP 0.9 response then the corresponding HTTP request was
made to a default port. DocumentLoader::responseReceived() blocks the load for a document
with an HTTP 0.9 response corresponding to an HTTP request made to a non-default port.
This invariant is covered by the tests LayoutTests/http/tests/security/http-0.9/default-port-{plugin, script}-blocked.html.
(WebCore::Document::shouldEnforceHTTP0_9Sandbox): Added. Returns whether an HTTP 0.9 response
was received for this document.
* dom/Document.h:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived): Remove logic to apply sandbox policy to the
FrameLoader associated with the main resource. We will apply the sandbox during initialization
of the document.
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse): Ditto.
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse): Ditto.

LayoutTests:

Add a new test to ensure that the HTTP 0.9 sandbox policy does not persist across navigations.

Unskip HTTP 0.9 tests and update expected results for existing tests as needed.

* TestExpectations: Unskip the HTTP 0.9 tests.
* http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt: Remove duplicate console
messages now that we emit the console message exactly once per document.
* http/tests/security/http-0.9/default-port-script-blocked-expected.txt: Ditto.
* http/tests/security/http-0.9/iframe-blocked-expected.txt: Update expected result now that we
no longer emit a console message for a blocked load.
* http/tests/security/http-0.9/image-blocked-expected.txt: Ditto.
* http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-expected.txt: Remove
duplicate console messages now that we emit the console message exactly once per document.
* http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked-expected.txt: Ditto.
* http/tests/security/http-0.9/resources/sandbox-should-not-persist-on-navigation.html: Added.
* http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation-expected.txt: Added.
* http/tests/security/http-0.9/sandbox-should-not-persist-on-navigation.html: Added.
* http/tests/security/http-0.9/worker-connect-src-blocked-expected.txt: Update expected result
now that we no longer apply a sandbox policy to the main resource if a subresource had an HTTP 0.9
response.
* http/tests/security/http-0.9/worker-importScripts-blocked-expected.txt: Ditto.
* http/tests/security/http-0.9/xhr-asynchronous-blocked-expected.txt: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/LayoutTests/http/tests/security/http-0.9/default-port-plugin-blocked-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/default-port-script-blocked-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/iframe-blocked-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/image-blocked-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/image-on-HTTP-0.9-default-port-page-allowed-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/image-on-HTTP-0.9-page-blocked-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/worker-connect-src-blocked-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/worker-importScripts-blocked-expected.txt

[webkit-changes] [208550] trunk/Source/WebCore

[bfulgham]

Title: [208550] trunk/Source/WebCore








Revision 208550
Author bfulg...@apple.com
Date 2016-11-10 10:54:37 -0800 (Thu, 10 Nov 2016)


Log Message
Local file restrictions should not block sessionStorage access.
https://bugs.webkit.org/show_bug.cgi?id=155609
 

Reviewed by Andy Estes.

Re-landing this fix that was lost when the localStorage change was rolled out.

Use of 'sessionStorage' is governed by SecurityOrigin with third party access
set to 'ShouldAllowFromThirdParty::AlwaysAllowFromThirdParty'. We should not
reject local files for this combination of arguments.

Tested by storage/domstorage/sessionstorage/blocked-file-access.html.

* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::canAccessStorage): For the case of sessionStorage,
allow local file access.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/page/SecurityOrigin.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208549 => 208550)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 18:50:08 UTC (rev 208549)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 18:54:37 UTC (rev 208550)
@@ -1,3 +1,23 @@
+2016-11-10  Brent Fulgham  
+
+Local file restrictions should not block sessionStorage access.
+https://bugs.webkit.org/show_bug.cgi?id=155609
+ 
+
+Reviewed by Andy Estes.
+
+Re-landing this fix that was lost when the localStorage change was rolled out.
+
+Use of 'sessionStorage' is governed by SecurityOrigin with third party access
+set to 'ShouldAllowFromThirdParty::AlwaysAllowFromThirdParty'. We should not
+reject local files for this combination of arguments.
+
+Tested by storage/domstorage/sessionstorage/blocked-file-access.html.
+
+* page/SecurityOrigin.cpp:
+(WebCore::SecurityOrigin::canAccessStorage): For the case of sessionStorage,
+allow local file access.
+
 2016-11-10  Daniel Bates  
 
 REGRESSION (r195004): Scripts and plugins blocked for subsequent loads in same WebContent


Modified: trunk/Source/WebCore/page/SecurityOrigin.cpp (208549 => 208550)

--- trunk/Source/WebCore/page/SecurityOrigin.cpp	2016-11-10 18:50:08 UTC (rev 208549)
+++ trunk/Source/WebCore/page/SecurityOrigin.cpp	2016-11-10 18:54:37 UTC (rev 208550)
@@ -328,7 +328,7 @@
 if (isUnique())
 return false;
 
-if (isLocal() && !needsStorageAccessFromFileURLsQuirk() && !m_universalAccess)
+if (isLocal() && !needsStorageAccessFromFileURLsQuirk() && !m_universalAccess && shouldAllowFromThirdParty != AlwaysAllowFromThirdParty)
 return false;
 
 if (m_storageBlockingPolicy == BlockAllStorage)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208551] trunk/LayoutTests

[dbates]

Title: [208551] trunk/LayoutTests








Revision 208551
Author dba...@webkit.org
Date 2016-11-10 10:56:55 -0800 (Thu, 10 Nov 2016)


Log Message
Add test that image load over default port using HTTP 0.9 protocol is blocked when page is
served with a different HTTP version
https://bugs.webkit.org/show_bug.cgi?id=164552

Reviewed by Brent Fulgham.

* http/tests/security/http-0.9/image-default-port-blocked-expected.txt: Added.
* http/tests/security/http-0.9/image-default-port-blocked.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog


Added Paths

trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked-expected.txt
trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked.html




Diff

Modified: trunk/LayoutTests/ChangeLog (208550 => 208551)

--- trunk/LayoutTests/ChangeLog	2016-11-10 18:54:37 UTC (rev 208550)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 18:56:55 UTC (rev 208551)
@@ -1,5 +1,16 @@
 2016-11-10  Daniel Bates  
 
+Add test that image load over default port using HTTP 0.9 protocol is blocked when page is
+served with a different HTTP version
+https://bugs.webkit.org/show_bug.cgi?id=164552
+
+Reviewed by Brent Fulgham.
+
+* http/tests/security/http-0.9/image-default-port-blocked-expected.txt: Added.
+* http/tests/security/http-0.9/image-default-port-blocked.html: Added.
+
+2016-11-10  Daniel Bates  
+
 REGRESSION (r195004): Scripts and plugins blocked for subsequent loads in same WebContent
 process after receiving HTTP 0.9 response
 https://bugs.webkit.org/show_bug.cgi?id=164387


Added: trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked-expected.txt (0 => 208551)

--- trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked-expected.txt	2016-11-10 18:56:55 UTC (rev 208551)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: Cancelled resource load from 'http://127.0.0.1:8000/security/http-0.9/resources/nph-image.pl' because it is using HTTP/0.9 and the document was loaded with a different HTTP version.
+ALERT: PASS
+


Added: trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked.html (0 => 208551)

--- trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked.html	(rev 0)
+++ trunk/LayoutTests/http/tests/security/http-0.9/image-default-port-blocked.html	2016-11-10 18:56:55 UTC (rev 208551)
@@ -0,0 +1,15 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+if (window.internals)
+internals.registerDefaultPortForProtocol(8000, "http");
+}
+
+
+
+
+
+






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208542] trunk/Source/WebCore

[commit-queue]

Title: [208542] trunk/Source/WebCore








Revision 208542
Author commit-qu...@webkit.org
Date 2016-11-10 09:26:22 -0800 (Thu, 10 Nov 2016)


Log Message
MediaStreamTrack should use more Ref<> and less RefPtr<>
https://bugs.webkit.org/show_bug.cgi?id=164560

Patch by Youenn Fablet  on 2016-11-10
Reviewed by Eric Carlson.

No change of behavior.

Make MediaStreamTrack take a Ref<>& instead of a reference.
Using Ref<>&& instead of RefPtr<>&& in MediaStreamTrackPrivate.
Updating constness of some methods accordingly.

* Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::createReceiver):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::create):
(WebCore::MediaStreamTrack::MediaStreamTrack):
(WebCore::MediaStreamTrack::clone):
* Modules/mediastream/MediaStreamTrack.h:
* Modules/webaudio/MediaStreamAudioSource.cpp:
(WebCore::MediaStreamAudioSource::capabilities):
(WebCore::MediaStreamAudioSource::settings):
* Modules/webaudio/MediaStreamAudioSource.h:
* platform/mediastream/MediaEndpoint.cpp:
* platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::create):
* platform/mediastream/MediaStreamTrackPrivate.cpp:
(WebCore::MediaStreamTrackPrivate::create):
(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
(WebCore::MediaStreamTrackPrivate::clone):
* platform/mediastream/MediaStreamTrackPrivate.h:
(WebCore::MediaStreamTrackPrivate::setMuted):
(WebCore::MediaStreamTrackPrivate::source):
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/mac/AVMediaCaptureSource.h:
* platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::initializeSettings):
(WebCore::AVMediaCaptureSource::settings):
(WebCore::AVMediaCaptureSource::initializeCapabilities):
(WebCore::AVMediaCaptureSource::capabilities):
* platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:
(WebCore::RealtimeMediaSourceOwr::capabilities):
(WebCore::RealtimeMediaSourceOwr::settings):
* platform/mock/MockRealtimeMediaSource.cpp:
(WebCore::MockRealtimeMediaSource::initializeCapabilities):
(WebCore::MockRealtimeMediaSource::capabilities):
(WebCore::MockRealtimeMediaSource::initializeSettings):
(WebCore::MockRealtimeMediaSource::settings):
* platform/mock/MockRealtimeMediaSource.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaEndpointPeerConnection.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.cpp
trunk/Source/WebCore/Modules/mediastream/MediaStreamTrack.h
trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.cpp
trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSource.h
trunk/Source/WebCore/platform/mediastream/MediaEndpoint.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamPrivate.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.cpp
trunk/Source/WebCore/platform/mediastream/MediaStreamTrackPrivate.h
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h
trunk/Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.h
trunk/Source/WebCore/platform/mediastream/mac/AVMediaCaptureSource.mm
trunk/Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSource.cpp
trunk/Source/WebCore/platform/mock/MockRealtimeMediaSource.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (208541 => 208542)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 17:23:01 UTC (rev 208541)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 17:26:22 UTC (rev 208542)
@@ -1,3 +1,54 @@
+2016-11-10  Youenn Fablet  
+
+MediaStreamTrack should use more Ref<> and less RefPtr<>
+https://bugs.webkit.org/show_bug.cgi?id=164560
+
+Reviewed by Eric Carlson.
+
+No change of behavior.
+
+Make MediaStreamTrack take a Ref<>& instead of a reference.
+Using Ref<>&& instead of RefPtr<>&& in MediaStreamTrackPrivate.
+Updating constness of some methods accordingly.
+
+* Modules/mediastream/MediaEndpointPeerConnection.cpp:
+(WebCore::MediaEndpointPeerConnection::createReceiver):
+* Modules/mediastream/MediaStreamTrack.cpp:
+(WebCore::MediaStreamTrack::create):
+(WebCore::MediaStreamTrack::MediaStreamTrack):
+(WebCore::MediaStreamTrack::clone):
+* Modules/mediastream/MediaStreamTrack.h:
+* Modules/webaudio/MediaStreamAudioSource.cpp:
+(WebCore::MediaStreamAudioSource::capabilities):
+(WebCore::MediaStreamAudioSource::settings):
+* Modules/webaudio/MediaStreamAudioSource.h:
+* platform/mediastream/MediaEndpoint.cpp:
+* platform/mediastream/MediaStreamPrivate.cpp:
+(WebCore::MediaStreamPrivate::create):
+* platform/mediastream/MediaStreamTrackPrivate.cpp:
+(WebCore::MediaStreamTrackPrivate::create):
+(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate):
+

[webkit-changes] [208544] tags/Safari-603.1.12/Source/WebCore

[matthew_hanson]

Title: [208544] tags/Safari-603.1.12/Source/WebCore








Revision 208544
Author matthew_han...@apple.com
Date 2016-11-10 09:30:34 -0800 (Thu, 10 Nov 2016)


Log Message
Merge r208504. rdar://problem/29185888

Modified Paths

tags/Safari-603.1.12/Source/WebCore/ChangeLog
tags/Safari-603.1.12/Source/WebCore/WebCorePrefix.h




Diff

Modified: tags/Safari-603.1.12/Source/WebCore/ChangeLog (208543 => 208544)

--- tags/Safari-603.1.12/Source/WebCore/ChangeLog	2016-11-10 17:30:32 UTC (rev 208543)
+++ tags/Safari-603.1.12/Source/WebCore/ChangeLog	2016-11-10 17:30:34 UTC (rev 208544)
@@ -1,5 +1,15 @@
 2016-11-10  Matthew Hanson  
 
+Merge r208504. rdar://problem/29185888
+
+2016-11-09  Anders Carlsson  
+
+Fix STP build.
+
+* WebCorePrefix.h:
+
+2016-11-10  Matthew Hanson  
+
 Merge r208464. rdar://problem/29098431
 
 2016-11-09  Jer Noble  


Modified: tags/Safari-603.1.12/Source/WebCore/WebCorePrefix.h (208543 => 208544)

--- tags/Safari-603.1.12/Source/WebCore/WebCorePrefix.h	2016-11-10 17:30:32 UTC (rev 208543)
+++ tags/Safari-603.1.12/Source/WebCore/WebCorePrefix.h	2016-11-10 17:30:34 UTC (rev 208544)
@@ -172,7 +172,7 @@
 #define delete ("if you use new/delete make sure to include config.h at the top of the file"()) 
 #endif
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && __has_include()
 #include 
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208543] tags/Safari-603.1.12/Source/WebCore

[matthew_hanson]

Title: [208543] tags/Safari-603.1.12/Source/WebCore








Revision 208543
Author matthew_han...@apple.com
Date 2016-11-10 09:30:32 -0800 (Thu, 10 Nov 2016)


Log Message
Merge r208464. rdar://problem/29098431

Modified Paths

tags/Safari-603.1.12/Source/WebCore/ChangeLog
tags/Safari-603.1.12/Source/WebCore/html/MediaElementSession.h




Diff

Modified: tags/Safari-603.1.12/Source/WebCore/ChangeLog (208542 => 208543)

--- tags/Safari-603.1.12/Source/WebCore/ChangeLog	2016-11-10 17:26:22 UTC (rev 208542)
+++ tags/Safari-603.1.12/Source/WebCore/ChangeLog	2016-11-10 17:30:32 UTC (rev 208543)
@@ -1,3 +1,22 @@
+2016-11-10  Matthew Hanson  
+
+Merge r208464. rdar://problem/29098431
+
+2016-11-09  Jer Noble  
+
+REGRESSION (r208149): Media scrubber is not displayed in media controls
+https://bugs.webkit.org/show_bug.cgi?id=164514
+
+Reviewed by Darin Adler.
+
+Fixes broken Media Controls API tests.
+
+Added a new PlatformMediaSessionType; need to add that same type to the TYPE_TRAITS section of
+MediaElementSession.h so that is<> and downcast<> work correctly.
+
+* html/MediaElementSession.h:
+(isType):
+
 2016-11-07  Ryan Haddad  
 
 Unreviewed, rolling out r208382.


Modified: tags/Safari-603.1.12/Source/WebCore/html/MediaElementSession.h (208542 => 208543)

--- tags/Safari-603.1.12/Source/WebCore/html/MediaElementSession.h	2016-11-10 17:26:22 UTC (rev 208542)
+++ tags/Safari-603.1.12/Source/WebCore/html/MediaElementSession.h	2016-11-10 17:30:32 UTC (rev 208543)
@@ -127,6 +127,13 @@
 bool allowsPlaybackControlsForAutoplayingAudio() const;
 bool allowsNowPlayingControlsVisibility() const override;
 
+static bool isMediaElementSessionMediaType(MediaType type)
+{
+return type == Video
+|| type == Audio
+|| type == VideoAudio;
+}
+
 private:
 
 #if ENABLE(WIRELESS_PLAYBACK_TARGET)
@@ -165,7 +172,7 @@
 } // namespace WebCore
 
 SPECIALIZE_TYPE_TRAITS_BEGIN(WebCore::MediaElementSession)
-static bool isType(const WebCore::PlatformMediaSession& session) { return session.mediaType() == WebCore::PlatformMediaSession::Video || session.mediaType() == WebCore::PlatformMediaSession::Audio; }
+static bool isType(const WebCore::PlatformMediaSession& session) { return WebCore::MediaElementSession::isMediaElementSessionMediaType(session.mediaType()); }
 SPECIALIZE_TYPE_TRAITS_END()
 
 #endif // ENABLE(VIDEO)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208546] trunk/LayoutTests

[ryanhaddad]

Title: [208546] trunk/LayoutTests








Revision 208546
Author ryanhad...@apple.com
Date 2016-11-10 10:08:06 -0800 (Thu, 10 Nov 2016)


Log Message
Temporarily marking storage/domstorage/sessionstorage/blocked-file-access.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=164592

Unreviewed test gardening.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208545 => 208546)

--- trunk/LayoutTests/ChangeLog	2016-11-10 18:04:03 UTC (rev 208545)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 18:08:06 UTC (rev 208546)
@@ -1,3 +1,12 @@
+2016-11-10  Ryan Haddad  
+
+Temporarily marking storage/domstorage/sessionstorage/blocked-file-access.html as failing.
+https://bugs.webkit.org/show_bug.cgi?id=164592
+
+Unreviewed test gardening.
+
+* TestExpectations:
+
 2016-11-10  Aaron Chu  
 
 Web Inspector: AXI: clarify button roles (e.g. toggle or popup button)


Modified: trunk/LayoutTests/TestExpectations (208545 => 208546)

--- trunk/LayoutTests/TestExpectations	2016-11-10 18:04:03 UTC (rev 208545)
+++ trunk/LayoutTests/TestExpectations	2016-11-10 18:08:06 UTC (rev 208546)
@@ -987,3 +987,5 @@
 
 webkit.org/b/164080 http/tests/websocket/tests/hybi/closed-when-entering-page-cache.html [ Pass Failure ]
 webkit.org/b/164080 http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html [ Pass Failure ]
+
+webkit.org/b/164592 storage/domstorage/sessionstorage/blocked-file-access.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208541] trunk/Source/WebCore

[pvollan]

Title: [208541] trunk/Source/WebCore








Revision 208541
Author pvol...@apple.com
Date 2016-11-10 09:23:01 -0800 (Thu, 10 Nov 2016)


Log Message
[Win32] Crash in layout tests.
https://bugs.webkit.org/show_bug.cgi?id=164411

Reviewed by Mark Lam.

Use the calling convention expected by the callers of the generated functions.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestDOMJIT.cpp:
(WebCore::unsafeJsTestDOMJITPrototypeFunctionGetAttribute):
(WebCore::unsafeJsTestDOMJITPrototypeFunctionItem):
(WebCore::unsafeJsTestDOMJITPrototypeFunctionHasAttribute):
(WebCore::unsafeJsTestDOMJITPrototypeFunctionGetElementById):
(WebCore::unsafeJsTestDOMJITPrototypeFunctionGetElementsByName):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208540 => 208541)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 17:10:09 UTC (rev 208540)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 17:23:01 UTC (rev 208541)
@@ -1,3 +1,21 @@
+2016-11-10  Per Arne Vollan  
+
+[Win32] Crash in layout tests.
+https://bugs.webkit.org/show_bug.cgi?id=164411
+
+Reviewed by Mark Lam.
+
+Use the calling convention expected by the callers of the generated functions.
+
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateImplementation):
+* bindings/scripts/test/JS/JSTestDOMJIT.cpp:
+(WebCore::unsafeJsTestDOMJITPrototypeFunctionGetAttribute):
+(WebCore::unsafeJsTestDOMJITPrototypeFunctionItem):
+(WebCore::unsafeJsTestDOMJITPrototypeFunctionHasAttribute):
+(WebCore::unsafeJsTestDOMJITPrototypeFunctionGetElementById):
+(WebCore::unsafeJsTestDOMJITPrototypeFunctionGetElementsByName):
+
 2016-11-10  Aaron Chu  
 
 Web Inspector: AXI: clarify button roles (e.g. toggle or popup button)


Modified: trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (208540 => 208541)

--- trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-11-10 17:10:09 UTC (rev 208540)
+++ trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm	2016-11-10 17:23:01 UTC (rev 208541)
@@ -2661,7 +2661,7 @@
 if ($function->extendedAttributes->{DOMJIT}) {
 $implIncludes{"DOMJITIDLType.h"} = 1;
 my $unsafeFunctionName = "unsafe" . $codeGenerator->WK_ucfirst($functionName);
-my $functionSignature = "JSC::EncodedJSValue JSC_HOST_CALL ${unsafeFunctionName}(JSC::ExecState*, $className*";
+my $functionSignature = "JSC::EncodedJSValue JIT_OPERATION ${unsafeFunctionName}(JSC::ExecState*, $className*";
 foreach my $argument (@{$function->arguments}) {
 my $type = $argument->type;
 my $argumentType = GetUnsafeArgumentType($interface, $type);
@@ -3909,7 +3909,7 @@
 if ($function->extendedAttributes->{DOMJIT}) {
 $implIncludes{""} = 1;
 my $unsafeFunctionName = "unsafe" . $codeGenerator->WK_ucfirst($functionName);
-push(@implContent, "JSC::EncodedJSValue JSC_HOST_CALL ${unsafeFunctionName}(JSC::ExecState* state, $className* castedThis");
+push(@implContent, "JSC::EncodedJSValue JIT_OPERATION ${unsafeFunctionName}(JSC::ExecState* state, $className* castedThis");
 foreach my $argument (@{$function->arguments}) {
 my $type = $argument->type;
 my $argumentType = GetUnsafeArgumentType($interface, $type);


Modified: trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp (208540 => 208541)

--- trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp	2016-11-10 17:10:09 UTC (rev 208540)
+++ trunk/Source/WebCore/bindings/scripts/test/JS/JSTestDOMJIT.cpp	2016-11-10 17:23:01 UTC (rev 208541)
@@ -45,15 +45,15 @@
 // Functions
 
 JSC::EncodedJSValue JSC_HOST_CALL jsTestDOMJITPrototypeFunctionGetAttribute(JSC::ExecState*);
-JSC::EncodedJSValue JSC_HOST_CALL unsafeJsTestDOMJITPrototypeFunctionGetAttribute(JSC::ExecState*, JSTestDOMJIT*, DOMJIT::IDLJSArgumentType);
+JSC::EncodedJSValue JIT_OPERATION unsafeJsTestDOMJITPrototypeFunctionGetAttribute(JSC::ExecState*, JSTestDOMJIT*, DOMJIT::IDLJSArgumentType);
 JSC::EncodedJSValue JSC_HOST_CALL jsTestDOMJITPrototypeFunctionItem(JSC::ExecState*);
-JSC::EncodedJSValue JSC_HOST_CALL unsafeJsTestDOMJITPrototypeFunctionItem(JSC::ExecState*, JSTestDOMJIT*, DOMJIT::IDLJSArgumentType, DOMJIT::IDLJSArgumentType);
+JSC::EncodedJSValue JIT_OPERATION unsafeJsTestDOMJITPrototypeFunctionItem(JSC::ExecState*, JSTestDOMJIT*, DOMJIT::IDLJSArgumentType, DOMJIT::IDLJSArgumentType);
 JSC::EncodedJSValue JSC_HOST_CALL jsTestDOMJITPrototypeFunctionHasAttribute(JSC::ExecState*);
-JSC::EncodedJSValue JSC_HOST_CALL 

[webkit-changes] [208528] trunk/Source/WebKit2

[philn]

Title: [208528] trunk/Source/WebKit2








Revision 208528
Author ph...@webkit.org
Date 2016-11-10 00:01:10 -0800 (Thu, 10 Nov 2016)


Log Message
[WK2][GTK][GStreamer] Build fails when -plugins-base and -core headers are not installed in the same directory
https://bugs.webkit.org/show_bug.cgi?id=148894

Reviewed by Carlos Garcia Campos.

The pbutils (gst-plugins-base-utils) headers are needed in
WebKit2/GTK for the permission request API related with the
GStreamer codec installer. It builds fine in most cases without
explicitely requiring the pbutils include directory path because
usually all the GStreamer headers are installed in the same path,
excepted for some distributions, like NixOS.

* PlatformGTK.cmake: The GStreamer pbutils include directory was
missing in the header search path.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformGTK.cmake




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208527 => 208528)

--- trunk/Source/WebKit2/ChangeLog	2016-11-10 07:53:34 UTC (rev 208527)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-10 08:01:10 UTC (rev 208528)
@@ -1,3 +1,20 @@
+2016-11-10  Philippe Normand  
+
+[WK2][GTK][GStreamer] Build fails when -plugins-base and -core headers are not installed in the same directory
+https://bugs.webkit.org/show_bug.cgi?id=148894
+
+Reviewed by Carlos Garcia Campos.
+
+The pbutils (gst-plugins-base-utils) headers are needed in
+WebKit2/GTK for the permission request API related with the
+GStreamer codec installer. It builds fine in most cases without
+explicitely requiring the pbutils include directory path because
+usually all the GStreamer headers are installed in the same path,
+excepted for some distributions, like NixOS.
+
+* PlatformGTK.cmake: The GStreamer pbutils include directory was
+missing in the header search path.
+
 2016-11-09  Chris Dumez  
 
 [WK2][!NETWORK_SESSION] Add support for downloading file backed blobs


Modified: trunk/Source/WebKit2/PlatformGTK.cmake (208527 => 208528)

--- trunk/Source/WebKit2/PlatformGTK.cmake	2016-11-10 07:53:34 UTC (rev 208527)
+++ trunk/Source/WebKit2/PlatformGTK.cmake	2016-11-10 08:01:10 UTC (rev 208528)
@@ -885,6 +885,7 @@
 ${ENCHANT_INCLUDE_DIRS}
 ${GEOCLUE_INCLUDE_DIRS}
 ${GSTREAMER_INCLUDE_DIRS}
+${GSTREAMER_PBUTILS_INCLUDE_DIRS}
 ${HARFBUZZ_INCLUDE_DIRS}
 ${LIBSOUP_INCLUDE_DIRS}
 )






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208529] trunk/Source/WebKit2

[clopez]

Title: [208529] trunk/Source/WebKit2








Revision 208529
Author clo...@igalia.com
Date 2016-11-10 00:46:13 -0800 (Thu, 10 Nov 2016)


Log Message
[GTK] Allow to use WebMemorySampler feature.
https://bugs.webkit.org/show_bug.cgi?id=164517

Reviewed by Carlos Garcia Campos.

Enable the WebMemorySampler with the environment variable WEBKIT_SAMPLE_MEMORY.

When enabled, it will dump the stats to /tmp each second.

* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (208528 => 208529)

--- trunk/Source/WebKit2/ChangeLog	2016-11-10 08:01:10 UTC (rev 208528)
+++ trunk/Source/WebKit2/ChangeLog	2016-11-10 08:46:13 UTC (rev 208529)
@@ -1,3 +1,17 @@
+2016-11-10  Carlos Alberto Lopez Perez  
+
+[GTK] Allow to use WebMemorySampler feature.
+https://bugs.webkit.org/show_bug.cgi?id=164517
+
+Reviewed by Carlos Garcia Campos.
+
+Enable the WebMemorySampler with the environment variable WEBKIT_SAMPLE_MEMORY.
+
+When enabled, it will dump the stats to /tmp each second.
+
+* UIProcess/API/gtk/WebKitWebContext.cpp:
+(webkitWebContextConstructed):
+
 2016-11-10  Philippe Normand  
 
 [WK2][GTK][GStreamer] Build fails when -plugins-base and -core headers are not installed in the same directory


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (208528 => 208529)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2016-11-10 08:01:10 UTC (rev 208528)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp	2016-11-10 08:46:13 UTC (rev 208529)
@@ -280,6 +280,11 @@
 priv->tlsErrorsPolicy = WEBKIT_TLS_ERRORS_POLICY_FAIL;
 priv->processPool->setIgnoreTLSErrors(false);
 
+#if ENABLE(MEMORY_SAMPLER)
+if (getenv("WEBKIT_SAMPLE_MEMORY"))
+priv->processPool->startMemorySampler(0);
+#endif
+
 attachInjectedBundleClientToContext(webContext);
 attachDownloadClientToContext(webContext);
 attachRequestManagerClientToContext(webContext);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208553] trunk/LayoutTests

[ryanhaddad]

Title: [208553] trunk/LayoutTests








Revision 208553
Author ryanhad...@apple.com
Date 2016-11-10 11:38:58 -0800 (Thu, 10 Nov 2016)


Log Message
Marking fast/loader/reload-zero-byte-plugin.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=164570

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208552 => 208553)

--- trunk/LayoutTests/ChangeLog	2016-11-10 19:00:26 UTC (rev 208552)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 19:38:58 UTC (rev 208553)
@@ -1,3 +1,12 @@
+2016-11-10  Ryan Haddad  
+
+Marking fast/loader/reload-zero-byte-plugin.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=164570
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
 2016-11-10  Brent Fulgham  
 
 Unmarking storage/domstorage/sessionstorage/blocked-file-access.html.


Modified: trunk/LayoutTests/platform/mac/TestExpectations (208552 => 208553)

--- trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 19:00:26 UTC (rev 208552)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2016-11-10 19:38:58 UTC (rev 208553)
@@ -1469,3 +1469,5 @@
 
 webkit.org/b/164388 inspector/sampling-profiler/call-frame-with-dom-functions.html [ Pass Timeout ]
 webkit.org/b/164388 inspector/sampling-profiler/_expression_-location-info.html [ Pass Timeout ]
+
+webkit.org/b/164570 fast/loader/reload-zero-byte-plugin.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208554] trunk/LayoutTests

[ryanhaddad]

Title: [208554] trunk/LayoutTests








Revision 208554
Author ryanhad...@apple.com
Date 2016-11-10 11:43:05 -0800 (Thu, 10 Nov 2016)


Log Message
Marking http/tests/cache/disk-cache/disk-cache-request-headers.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=164594

Unreviewed test gardening.

* platform/ios-simulator/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios-simulator/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208553 => 208554)

--- trunk/LayoutTests/ChangeLog	2016-11-10 19:38:58 UTC (rev 208553)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 19:43:05 UTC (rev 208554)
@@ -1,5 +1,14 @@
 2016-11-10  Ryan Haddad  
 
+Marking http/tests/cache/disk-cache/disk-cache-request-headers.html as flaky on ios-simulator.
+https://bugs.webkit.org/show_bug.cgi?id=164594
+
+Unreviewed test gardening.
+
+* platform/ios-simulator/TestExpectations:
+
+2016-11-10  Ryan Haddad  
+
 Marking fast/loader/reload-zero-byte-plugin.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=164570
 


Modified: trunk/LayoutTests/platform/ios-simulator/TestExpectations (208553 => 208554)

--- trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-11-10 19:38:58 UTC (rev 208553)
+++ trunk/LayoutTests/platform/ios-simulator/TestExpectations	2016-11-10 19:43:05 UTC (rev 208554)
@@ -2751,3 +2751,5 @@
 
 # This test is Mac-specific since it checks that we have custom controls in fullscreen.
 media/modern-media-controls/media-controller/media-controller-fullscreen-change.html [ Skip ]
+
+webkit.org/b/164594 http/tests/cache/disk-cache/disk-cache-request-headers.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [208555] trunk/Source/WebCore

[zalan]

Title: [208555] trunk/Source/WebCore








Revision 208555
Author za...@apple.com
Date 2016-11-10 11:44:51 -0800 (Thu, 10 Nov 2016)


Log Message
RenderElement::invalidateFlowThreadContainingBlockIncludingDescendants should be on RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=164601

Reviewed by Simon Fraser.

FlowThread containing blocks are cached at RenderBlocks. It makes no sense to call the invalidate function on a RenderElement.
Move invalidateFlowThreadContainingBlockIncludingDescendants to RenderBlock.

No change in functionality.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::invalidateFlowThreadContainingBlockIncludingDescendants):
* rendering/RenderBlock.h:
* rendering/RenderElement.cpp:
(WebCore::RenderElement::invalidateFlowThreadContainingBlockIncludingDescendants): Deleted.
* rendering/RenderElement.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::splitInlines):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderBlock.cpp
trunk/Source/WebCore/rendering/RenderBlock.h
trunk/Source/WebCore/rendering/RenderElement.cpp
trunk/Source/WebCore/rendering/RenderElement.h
trunk/Source/WebCore/rendering/RenderInline.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (208554 => 208555)

--- trunk/Source/WebCore/ChangeLog	2016-11-10 19:43:05 UTC (rev 208554)
+++ trunk/Source/WebCore/ChangeLog	2016-11-10 19:44:51 UTC (rev 208555)
@@ -1,3 +1,24 @@
+2016-11-10  Zalan Bujtas  
+
+RenderElement::invalidateFlowThreadContainingBlockIncludingDescendants should be on RenderBlock.
+https://bugs.webkit.org/show_bug.cgi?id=164601
+
+Reviewed by Simon Fraser.
+
+FlowThread containing blocks are cached at RenderBlocks. It makes no sense to call the invalidate function on a RenderElement.
+Move invalidateFlowThreadContainingBlockIncludingDescendants to RenderBlock.
+
+No change in functionality.
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::invalidateFlowThreadContainingBlockIncludingDescendants):
+* rendering/RenderBlock.h:
+* rendering/RenderElement.cpp:
+(WebCore::RenderElement::invalidateFlowThreadContainingBlockIncludingDescendants): Deleted.
+* rendering/RenderElement.h:
+* rendering/RenderInline.cpp:
+(WebCore::RenderInline::splitInlines):
+
 2016-11-10  Brent Fulgham  
 
 Local file restrictions should not block sessionStorage access.


Modified: trunk/Source/WebCore/rendering/RenderBlock.cpp (208554 => 208555)

--- trunk/Source/WebCore/rendering/RenderBlock.cpp	2016-11-10 19:43:05 UTC (rev 208554)
+++ trunk/Source/WebCore/rendering/RenderBlock.cpp	2016-11-10 19:44:51 UTC (rev 208555)
@@ -3377,6 +3377,28 @@
 return rareData->m_flowThreadContainingBlock.value();
 }
 
+void RenderBlock::invalidateFlowThreadContainingBlockIncludingDescendants()
+{
+if (flowThreadState() == NotInsideFlowThread)
+return;
+
+if (cachedFlowThreadContainingBlockNeedsUpdate())
+return;
+
+auto* flowThread = cachedFlowThreadContainingBlock();
+setCachedFlowThreadContainingBlockNeedsUpdate();
+
+if (flowThread)
+flowThread->removeFlowChildInfo(this);
+
+for (auto& child : childrenOfType(*this)) {
+if (flowThread)
+flowThread->removeFlowChildInfo();
+if (is(child))
+downcast(child).invalidateFlowThreadContainingBlockIncludingDescendants();
+}
+}
+
 LayoutUnit RenderBlock::paginationStrut() const
 {
 RenderBlockRareData* rareData = getBlockRareData(this);


Modified: trunk/Source/WebCore/rendering/RenderBlock.h (208554 => 208555)

--- trunk/Source/WebCore/rendering/RenderBlock.h	2016-11-10 19:43:05 UTC (rev 208554)
+++ trunk/Source/WebCore/rendering/RenderBlock.h	2016-11-10 19:44:51 UTC (rev 208555)
@@ -307,6 +307,7 @@
 RenderFlowThread* cachedFlowThreadContainingBlock() const;
 void setCachedFlowThreadContainingBlockNeedsUpdate();
 virtual bool cachedFlowThreadContainingBlockNeedsUpdate() const;
+void invalidateFlowThreadContainingBlockIncludingDescendants();
 
 protected:
 RenderFlowThread* locateFlowThreadContainingBlock() const override;


Modified: trunk/Source/WebCore/rendering/RenderElement.cpp (208554 => 208555)

--- trunk/Source/WebCore/rendering/RenderElement.cpp	2016-11-10 19:43:05 UTC (rev 208554)
+++ trunk/Source/WebCore/rendering/RenderElement.cpp	2016-11-10 19:44:51 UTC (rev 208555)
@@ -2237,31 +2237,6 @@
 setFlowThreadState(NotInsideFlowThread);
 }
 
-void RenderElement::invalidateFlowThreadContainingBlockIncludingDescendants(RenderFlowThread* flowThread)
-{
-if (flowThreadState() == NotInsideFlowThread)
-return;
-
-if (is(*this)) {
-RenderBlock& block = downcast(*this);
-
-if (block.cachedFlowThreadContainingBlockNeedsUpdate())
-return;
-
-flowThread = block.cachedFlowThreadContainingBlock();
-

[webkit-changes] [208552] trunk/LayoutTests

[bfulgham]

Title: [208552] trunk/LayoutTests








Revision 208552
Author bfulg...@apple.com
Date 2016-11-10 11:00:26 -0800 (Thu, 10 Nov 2016)


Log Message
Unmarking storage/domstorage/sessionstorage/blocked-file-access.html.
https://bugs.webkit.org/show_bug.cgi?id=164592

Unreviewed test gardening after r208550.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (208551 => 208552)

--- trunk/LayoutTests/ChangeLog	2016-11-10 18:56:55 UTC (rev 208551)
+++ trunk/LayoutTests/ChangeLog	2016-11-10 19:00:26 UTC (rev 208552)
@@ -1,3 +1,12 @@
+2016-11-10  Brent Fulgham  
+
+Unmarking storage/domstorage/sessionstorage/blocked-file-access.html.
+https://bugs.webkit.org/show_bug.cgi?id=164592
+
+Unreviewed test gardening after r208550.
+
+* TestExpectations:
+
 2016-11-10  Daniel Bates  
 
 Add test that image load over default port using HTTP 0.9 protocol is blocked when page is


Modified: trunk/LayoutTests/TestExpectations (208551 => 208552)

--- trunk/LayoutTests/TestExpectations	2016-11-10 18:56:55 UTC (rev 208551)
+++ trunk/LayoutTests/TestExpectations	2016-11-10 19:00:26 UTC (rev 208552)
@@ -984,5 +984,3 @@
 
 webkit.org/b/164080 http/tests/websocket/tests/hybi/closed-when-entering-page-cache.html [ Pass Failure ]
 webkit.org/b/164080 http/tests/websocket/tests/hybi/stop-on-resume-in-error-handler.html [ Pass Failure ]
-
-webkit.org/b/164592 storage/domstorage/sessionstorage/blocked-file-access.html [ Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes