[webkit-changes] [230656] trunk/Tools

[zalan]

Title: [230656] trunk/Tools








Revision 230656
Author za...@apple.com
Date 2018-04-13 21:48:35 -0700 (Fri, 13 Apr 2018)


Log Message
[LayoutReloaded] Update class documentation
https://bugs.webkit.org/show_bug.cgi?id=184625

Reviewed by Antti Koivisto.

* LayoutReloaded/DisplayTree/Box.js:
* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
* LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
* LayoutReloaded/FormattingContext/FloatingContext.js:
* LayoutReloaded/FormattingContext/FormattingContext.js:
* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
* LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
* LayoutReloaded/FormattingState/BlockFormattingState.js:
* LayoutReloaded/FormattingState/FloatingState.js:
* LayoutReloaded/FormattingState/FormattingState.js:
* LayoutReloaded/FormattingState/InlineFormattingState.js:
* LayoutReloaded/LayoutState.js:
* LayoutReloaded/LayoutTree/BlockContainer.js:
* LayoutReloaded/LayoutTree/Box.js:
* LayoutReloaded/LayoutTree/Container.js:
* LayoutReloaded/LayoutTree/InlineBox.js:
* LayoutReloaded/LayoutTree/InlineContainer.js:
* LayoutReloaded/LayoutTree/Text.js:
* LayoutReloaded/misc/headers/BlockContainer.h: Removed.
* LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
* LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
* LayoutReloaded/misc/headers/Box.h: Removed.
* LayoutReloaded/misc/headers/Container.h: Removed.
* LayoutReloaded/misc/headers/FloatingContext.h: Removed.
* LayoutReloaded/misc/headers/FormattingContext.h: Removed.
* LayoutReloaded/misc/headers/InitialBlockContainer.h: Removed.
* LayoutReloaded/misc/headers/InlineBox.h: Removed.
* LayoutReloaded/misc/headers/LayoutContext.h: Removed.
* LayoutReloaded/misc/headers/Line.h: Removed.
* LayoutReloaded/misc/headers/Text.h: Removed.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/DisplayTree/Box.js
trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js
trunk/Tools/LayoutReloaded/FormattingContext/FloatingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/Line.js
trunk/Tools/LayoutReloaded/FormattingState/BlockFormattingState.js
trunk/Tools/LayoutReloaded/FormattingState/FloatingState.js
trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js
trunk/Tools/LayoutReloaded/FormattingState/InlineFormattingState.js
trunk/Tools/LayoutReloaded/LayoutState.js
trunk/Tools/LayoutReloaded/LayoutTree/BlockContainer.js
trunk/Tools/LayoutReloaded/LayoutTree/Box.js
trunk/Tools/LayoutReloaded/LayoutTree/Container.js
trunk/Tools/LayoutReloaded/LayoutTree/InlineBox.js
trunk/Tools/LayoutReloaded/LayoutTree/InlineContainer.js
trunk/Tools/LayoutReloaded/LayoutTree/Text.js


Removed Paths

trunk/Tools/LayoutReloaded/misc/headers/




Diff

Modified: trunk/Tools/ChangeLog (230655 => 230656)

--- trunk/Tools/ChangeLog	2018-04-14 03:21:59 UTC (rev 230655)
+++ trunk/Tools/ChangeLog	2018-04-14 04:48:35 UTC (rev 230656)
@@ -1,5 +1,43 @@
 2018-04-13  Zalan Bujtas  
 
+[LayoutReloaded] Update class documentation
+https://bugs.webkit.org/show_bug.cgi?id=184625
+
+Reviewed by Antti Koivisto.
+
+* LayoutReloaded/DisplayTree/Box.js:
+* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
+* LayoutReloaded/FormattingContext/BlockFormatting/BlockMarginCollapse.js:
+* LayoutReloaded/FormattingContext/FloatingContext.js:
+* LayoutReloaded/FormattingContext/FormattingContext.js:
+* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
+* LayoutReloaded/FormattingContext/InlineFormatting/Line.js:
+* LayoutReloaded/FormattingState/BlockFormattingState.js:
+* LayoutReloaded/FormattingState/FloatingState.js:
+* LayoutReloaded/FormattingState/FormattingState.js:
+* LayoutReloaded/FormattingState/InlineFormattingState.js:
+* LayoutReloaded/LayoutState.js:
+* LayoutReloaded/LayoutTree/BlockContainer.js:
+* LayoutReloaded/LayoutTree/Box.js:
+* LayoutReloaded/LayoutTree/Container.js:
+* LayoutReloaded/LayoutTree/InlineBox.js:
+* LayoutReloaded/LayoutTree/InlineContainer.js:
+* LayoutReloaded/LayoutTree/Text.js:
+* LayoutReloaded/misc/headers/BlockContainer.h: Removed.
+* LayoutReloaded/misc/headers/BlockFormattingContext.h: Removed.
+* LayoutReloaded/misc/headers/BlockMarginCollapse.h: Removed.
+* LayoutReloaded/misc/headers/Box.h: Removed.
+* LayoutReloaded/misc/headers/Container.h: Removed.
+* LayoutReloaded/misc/headers/FloatingContext.h: Removed.
+

[webkit-changes] [230643] trunk/Source

[cdumez]

Title: [230643] trunk/Source








Revision 230643
Author cdu...@apple.com
Date 2018-04-13 14:23:54 -0700 (Fri, 13 Apr 2018)


Log Message
Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame
https://bugs.webkit.org/show_bug.cgi?id=184591

Reviewed by Sam Weinig.

Source/WebCore:

Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
This is work towards fixing Bug 184515.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):
* bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::didCreateWindowProxy):
(WebCore::DOMWrapperWorld::didDestroyWindowProxy):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMWindowBase.cpp:
(WebCore::toJSDOMWindow):
* bindings/js/JSDOMWindowProxy.cpp:
(WebCore::toJS):
(WebCore::toJSDOMWindowProxy):
* bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::loadModuleScriptInWorld):
(WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld):
(WebCore::ScriptController::evaluateModule):
(WebCore::ScriptController::clearWindowProxiesNotMatchingDOMWindow):
(WebCore::ScriptController::setDOMWindowForWindowProxy):
(WebCore::ScriptController::initScriptForWindowProxy):
(WebCore::ScriptController::setupModuleScriptHandlers):
(WebCore::ScriptController::windowProxyController):
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::enableWebAssembly):
(WebCore::ScriptController::disableEval):
(WebCore::ScriptController::disableWebAssembly):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::executeIfJavaScriptURL):
* bindings/js/ScriptController.h:
(WebCore::ScriptController::globalObject):
* bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
* bindings/js/ScriptState.cpp:
(WebCore::mainWorldExecState):
* bindings/js/WindowProxyController.cpp: Added.
(WebCore::WindowProxyController::WindowProxyController):
(WebCore::WindowProxyController::destroyWindowProxy):
(WebCore::WindowProxyController::createWindowProxy):
(WebCore::WindowProxyController::windowProxies):
(WebCore::WindowProxyController::createWindowProxyWithInitializedScript):
* bindings/js/WindowProxyController.h: Added.
(WebCore::WindowProxyController::releaseWindowProxies):
(WebCore::WindowProxyController::setWindowProxies):
(WebCore::WindowProxyController::windowProxy):
(WebCore::WindowProxyController::existingWindowProxy const):
(WebCore::WindowProxyController::globalObject):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
* page/AbstractFrame.cpp:
(WebCore::AbstractFrame::AbstractFrame):
* page/AbstractFrame.h:
(WebCore::AbstractFrame::windowProxyController):
(WebCore::AbstractFrame::windowProxyController const):

Source/WebKit:

Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
This is work towards fixing Bug 184515.

* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):

Source/WebKitLegacy/mac:

Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame.
RemoteFrames do not need a ScriptController but do need to maintain WindowProxies.
This is work towards fixing Bug 184515.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
* WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):

Source/WTF:

Add isEmpty() convenience method to SizedIteratorRange.

* wtf/IteratorRange.h:
(WTF::SizedIteratorRange::isEmpty const):

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/IteratorRange.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/bindings/js/DOMWrapperWorld.cpp
trunk/Source/WebCore/bindings/js/DOMWrapperWorld.h
trunk/Source/WebCore/bindings/js/JSBindingsAllInOne.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowBase.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.cpp
trunk/Source/WebCore/bindings/js/JSDOMWindowProxy.h
trunk/Source/WebCore/bindings/js/ScriptCachedFrameData.cpp
trunk/Source/WebCore/bindings/js/ScriptController.cpp
trunk/Source/WebCore/bindings/js/ScriptController.h
trunk/Source/WebCore/bindings/js/ScriptControllerMac.mm

[webkit-changes] [230635] trunk/Source/WebKit

[dbates]

Title: [230635] trunk/Source/WebKit








Revision 230635
Author dba...@webkit.org
Date 2018-04-13 09:48:56 -0700 (Fri, 13 Apr 2018)


Log Message
Inline NetworkLoad::sharedWillSendRedirectedRequest() into NetworkLoad::willPerformHTTPRedirection()
https://bugs.webkit.org/show_bug.cgi?id=184593

Reviewed by Alex Christensen.

Following the removal of the pre-Network Session code in r227364, NetworkLoad::sharedWillSendRedirectedRequest()
is only referenced from NetworkLoad::willPerformHTTPRedirection(). We should inline its
implementation into the NetworkLoad::willPerformHTTPRedirection(), remove a function call,
and the cognitive load to follow such a function call when reading the code.

No functionality changed. So, no new tests.

* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::willPerformHTTPRedirection): Moved the implementation of NetworkLoad::sharedWillSendRedirectedRequest()
into this function.
(WebKit::NetworkLoad::sharedWillSendRedirectedRequest): Deleted. Moved its implementation
into NetworkLoad::willPerformHTTPRedirection().
* NetworkProcess/NetworkLoad.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (230634 => 230635)

--- trunk/Source/WebKit/ChangeLog	2018-04-13 16:29:08 UTC (rev 230634)
+++ trunk/Source/WebKit/ChangeLog	2018-04-13 16:48:56 UTC (rev 230635)
@@ -1,3 +1,24 @@
+2018-04-13  Daniel Bates  
+
+Inline NetworkLoad::sharedDidReceiveResponse() into NetworkLoad::notifyDidReceiveResponse()
+https://bugs.webkit.org/show_bug.cgi?id=184592
+
+Reviewed by Alex Christensen.
+
+Following the removal of the pre-Network Session code in r227364, NetworkLoad::sharedDidReceiveResponse()
+is only referenced from NetworkLoad::notifyDidReceiveResponse(). We should inline its
+implementation into the NetworkLoad::notifyDidReceiveResponse(), remove a function
+call, and the cognitive load to follow such a function call when reading the code.
+
+No functionality changed. So, no new tests.
+
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::notifyDidReceiveResponse): Moved the implementation of NetworkLoad::sharedDidReceiveResponse()
+into this function.
+(WebKit::NetworkLoad::sharedDidReceiveResponse): Deleted. Moved its implementation into
+NetworkLoad::notifyDidReceiveResponse().
+* NetworkProcess/NetworkLoad.h:
+
 2018-04-13  Brent Fulgham  
 
 REGRESSION(r230468): Improper assertion firing under STP


Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp (230634 => 230635)

--- trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2018-04-13 16:29:08 UTC (rev 230634)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2018-04-13 16:48:56 UTC (rev 230635)
@@ -191,15 +191,6 @@
 return m_client.get().shouldCaptureExtraNetworkLoadMetrics();
 }
 
-NetworkLoadClient::ShouldContinueDidReceiveResponse NetworkLoad::sharedDidReceiveResponse(ResourceResponse&& response)
-{
-response.setSource(ResourceResponse::Source::Network);
-if (m_parameters.needsCertificateInfo)
-response.includeCertificateInfo();
-
-return m_client.get().didReceiveResponse(WTFMove(response));
-}
-
 void NetworkLoad::sharedWillSendRedirectedRequest(ResourceRequest&& request, ResourceResponse&& redirectResponse)
 {
 // We only expect to get the willSendRequest callback from ResourceHandle as the result of a redirect.
@@ -343,7 +334,11 @@
 m_recorder->recordResponseReceived(response);
 #endif
 
-if (sharedDidReceiveResponse(WTFMove(response)) == NetworkLoadClient::ShouldContinueDidReceiveResponse::No) {
+response.setSource(ResourceResponse::Source::Network);
+if (m_parameters.needsCertificateInfo)
+response.includeCertificateInfo();
+
+if (m_client.get().didReceiveResponse(WTFMove(response)) == NetworkLoadClient::ShouldContinueDidReceiveResponse::No) {
 m_responseCompletionHandler = WTFMove(completionHandler);
 return;
 }


Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoad.h (230634 => 230635)

--- trunk/Source/WebKit/NetworkProcess/NetworkLoad.h	2018-04-13 16:29:08 UTC (rev 230634)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoad.h	2018-04-13 16:48:56 UTC (rev 230635)
@@ -79,7 +79,6 @@
 #endif
 void initialize(NetworkSession&);
 
-NetworkLoadClient::ShouldContinueDidReceiveResponse sharedDidReceiveResponse(WebCore::ResourceResponse&&);
 void sharedWillSendRedirectedRequest(WebCore::ResourceRequest&&, WebCore::ResourceResponse&&);
 
 // NetworkDataTaskClient






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230638] trunk/Tools

[philn]

Title: [230638] trunk/Tools








Revision 230638
Author ph...@webkit.org
Date 2018-04-13 10:31:45 -0700 (Fri, 13 Apr 2018)


Log Message
Update my emails ordering in contributors.json
https://bugs.webkit.org/show_bug.cgi?id=184587

Patch by Thibault Saunier  on 2018-04-13
Rubber-stamped by Philippe Normand.

Bugzilla seems to pick up tsaun...@igalia.com which is not the one I use there.

* Scripts/webkitpy/common/config/contributors.json:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/contributors.json




Diff

Modified: trunk/Tools/ChangeLog (230637 => 230638)

--- trunk/Tools/ChangeLog	2018-04-13 17:01:40 UTC (rev 230637)
+++ trunk/Tools/ChangeLog	2018-04-13 17:31:45 UTC (rev 230638)
@@ -1,3 +1,14 @@
+2018-04-13  Thibault Saunier  
+
+Update my emails ordering in contributors.json
+https://bugs.webkit.org/show_bug.cgi?id=184587
+
+Rubber-stamped by Philippe Normand.
+
+Bugzilla seems to pick up tsaun...@igalia.com which is not the one I use there.
+
+* Scripts/webkitpy/common/config/contributors.json:
+
 2018-04-13  Michael Catanzaro  
 
 [WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb


Modified: trunk/Tools/Scripts/webkitpy/common/config/contributors.json (230637 => 230638)

--- trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-04-13 17:01:40 UTC (rev 230637)
+++ trunk/Tools/Scripts/webkitpy/common/config/contributors.json	2018-04-13 17:31:45 UTC (rev 230638)
@@ -5364,8 +5364,8 @@
},
"Thibault Saunier" : {
   "emails" : [
- "tsaun...@igalia.com",
- "tsaun...@gnome.org"
+ "tsaun...@gnome.org",
+ "tsaun...@igalia.com"
   ],
   "expertise" : "WebRTC",
   "nicks" : [






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230636] trunk/Source/WebKit

[dbates]

Title: [230636] trunk/Source/WebKit








Revision 230636
Author dba...@webkit.org
Date 2018-04-13 09:54:12 -0700 (Fri, 13 Apr 2018)


Log Message
Inline NetworkLoad::sharedWillSendRedirectedRequest() into NetworkLoad::willPerformHTTPRedirection()
https://bugs.webkit.org/show_bug.cgi?id=184593

Reviewed by Alex Christensen.

Following the removal of the pre-Network Session code in r227364, NetworkLoad::sharedWillSendRedirectedRequest()
is only referenced from NetworkLoad::willPerformHTTPRedirection(). We should inline its
implementation into the NetworkLoad::willPerformHTTPRedirection(), remove a function call,
and the cognitive load to follow such a function call when reading the code.

No functionality changed. So, no new tests.

* NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::willPerformHTTPRedirection): Moved the implementation of NetworkLoad::sharedWillSendRedirectedRequest()
into this function.
(WebKit::NetworkLoad::sharedWillSendRedirectedRequest): Deleted. Moved its implementation
into NetworkLoad::willPerformHTTPRedirection().
* NetworkProcess/NetworkLoad.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp
trunk/Source/WebKit/NetworkProcess/NetworkLoad.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (230635 => 230636)

--- trunk/Source/WebKit/ChangeLog	2018-04-13 16:48:56 UTC (rev 230635)
+++ trunk/Source/WebKit/ChangeLog	2018-04-13 16:54:12 UTC (rev 230636)
@@ -1,5 +1,26 @@
 2018-04-13  Daniel Bates  
 
+Inline NetworkLoad::sharedWillSendRedirectedRequest() into NetworkLoad::willPerformHTTPRedirection()
+https://bugs.webkit.org/show_bug.cgi?id=184593
+
+Reviewed by Alex Christensen.
+
+Following the removal of the pre-Network Session code in r227364, NetworkLoad::sharedWillSendRedirectedRequest()
+is only referenced from NetworkLoad::willPerformHTTPRedirection(). We should inline its
+implementation into the NetworkLoad::willPerformHTTPRedirection(), remove a function call,
+and the cognitive load to follow such a function call when reading the code.
+
+No functionality changed. So, no new tests.
+
+* NetworkProcess/NetworkLoad.cpp:
+(WebKit::NetworkLoad::willPerformHTTPRedirection): Moved the implementation of NetworkLoad::sharedWillSendRedirectedRequest()
+into this function.
+(WebKit::NetworkLoad::sharedWillSendRedirectedRequest): Deleted. Moved its implementation
+into NetworkLoad::willPerformHTTPRedirection().
+* NetworkProcess/NetworkLoad.h:
+
+2018-04-13  Daniel Bates  
+
 Inline NetworkLoad::sharedDidReceiveResponse() into NetworkLoad::notifyDidReceiveResponse()
 https://bugs.webkit.org/show_bug.cgi?id=184592
 


Modified: trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp (230635 => 230636)

--- trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2018-04-13 16:48:56 UTC (rev 230635)
+++ trunk/Source/WebKit/NetworkProcess/NetworkLoad.cpp	2018-04-13 16:54:12 UTC (rev 230636)
@@ -191,22 +191,6 @@
 return m_client.get().shouldCaptureExtraNetworkLoadMetrics();
 }
 
-void NetworkLoad::sharedWillSendRedirectedRequest(ResourceRequest&& request, ResourceResponse&& redirectResponse)
-{
-// We only expect to get the willSendRequest callback from ResourceHandle as the result of a redirect.
-ASSERT(!redirectResponse.isNull());
-ASSERT(RunLoop::isMain());
-
-#if ENABLE(NETWORK_CAPTURE)
-if (m_recorder)
-m_recorder->recordRedirectReceived(request, redirectResponse);
-#endif
-
-auto oldRequest = WTFMove(m_currentRequest);
-m_currentRequest = request;
-m_client.get().willSendRedirectedRequest(WTFMove(oldRequest), WTFMove(request), WTFMove(redirectResponse));
-}
-
 bool NetworkLoad::isAllowedToAskUserForCredentials() const
 {
 return m_client.get().isAllowedToAskUserForCredentials();
@@ -249,11 +233,22 @@
 m_task->setPendingDownload(pendingDownload);
 }
 
-void NetworkLoad::willPerformHTTPRedirection(ResourceResponse&& response, ResourceRequest&& request, RedirectCompletionHandler&& completionHandler)
+void NetworkLoad::willPerformHTTPRedirection(ResourceResponse&& redirectResponse, ResourceRequest&& request, RedirectCompletionHandler&& completionHandler)
 {
+ASSERT(!redirectResponse.isNull());
+ASSERT(RunLoop::isMain());
 ASSERT(!m_redirectCompletionHandler);
+
 m_redirectCompletionHandler = WTFMove(completionHandler);
-sharedWillSendRedirectedRequest(WTFMove(request), WTFMove(response));
+
+#if ENABLE(NETWORK_CAPTURE)
+if (m_recorder)
+m_recorder->recordRedirectReceived(request, redirectResponse);
+#endif
+
+auto oldRequest = WTFMove(m_currentRequest);
+m_currentRequest = request;
+m_client.get().willSendRedirectedRequest(WTFMove(oldRequest), WTFMove(request), WTFMove(redirectResponse));
 }
 
 void NetworkLoad::didReceiveChallenge(const AuthenticationChallenge& challenge, 

[webkit-changes] [230641] trunk/Tools

[jbedard]

Title: [230641] trunk/Tools








Revision 230641
Author jbed...@apple.com
Date 2018-04-13 11:11:14 -0700 (Fri, 13 Apr 2018)


Log Message
Boot fewer simulators in CI/EWS machines
https://bugs.webkit.org/show_bug.cgi?id=184594


Reviewed by Alexey Proskuryakov.

This is a temporary workaround fro .

* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py




Diff

Modified: trunk/Tools/ChangeLog (230640 => 230641)

--- trunk/Tools/ChangeLog	2018-04-13 18:04:22 UTC (rev 230640)
+++ trunk/Tools/ChangeLog	2018-04-13 18:11:14 UTC (rev 230641)
@@ -1,3 +1,16 @@
+2018-04-13  Jonathan Bedard  
+
+Boot fewer simulators in CI/EWS machines
+https://bugs.webkit.org/show_bug.cgi?id=184594
+
+
+Reviewed by Alexey Proskuryakov.
+
+This is a temporary workaround fro .
+
+* Scripts/webkitpy/xcode/simulated_device.py:
+(SimulatedDeviceManager): Treat simulators as taking 6 gigs instead of 2.
+
 2018-04-13  Brady Eidson  
 
 Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.


Modified: trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py (230640 => 230641)

--- trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2018-04-13 18:04:22 UTC (rev 230640)
+++ trunk/Tools/Scripts/webkitpy/xcode/simulated_device.py	2018-04-13 18:11:14 UTC (rev 230641)
@@ -61,7 +61,8 @@
 AVAILABLE_DEVICES = []
 INITIALIZED_DEVICES = None
 
-MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE = 2 * (1024 ** 3)  # 2GB a simulator.
+# FIXME: Simulators should only take up 2GB, but because of  something in the OS thinks they're taking closer to 6GB
+MEMORY_ESTIMATE_PER_SIMULATOR_INSTANCE = 6 * (1024 ** 3)  # 6GB a simulator.
 PROCESS_COUNT_ESTIMATE_PER_SIMULATOR_INSTANCE = 125
 
 xcrun = '/usr/bin/xcrun'






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230642] trunk/Tools

[zalan]

Title: [230642] trunk/Tools








Revision 230642
Author za...@apple.com
Date 2018-04-13 11:40:07 -0700 (Fri, 13 Apr 2018)


Log Message
Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).

* LayoutReloaded/misc/LayoutReloadedWebKit.patch:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/misc/LayoutReloadedWebKit.patch




Diff

Modified: trunk/Tools/ChangeLog (230641 => 230642)

--- trunk/Tools/ChangeLog	2018-04-13 18:11:14 UTC (rev 230641)
+++ trunk/Tools/ChangeLog	2018-04-13 18:40:07 UTC (rev 230642)
@@ -1,3 +1,9 @@
+2018-04-13  Zalan Bujtas  
+
+Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).
+
+* LayoutReloaded/misc/LayoutReloadedWebKit.patch:
+
 2018-04-13  Jonathan Bedard  
 
 Boot fewer simulators in CI/EWS machines


Modified: trunk/Tools/LayoutReloaded/misc/LayoutReloadedWebKit.patch (230641 => 230642)

--- trunk/Tools/LayoutReloaded/misc/LayoutReloadedWebKit.patch	2018-04-13 18:11:14 UTC (rev 230641)
+++ trunk/Tools/LayoutReloaded/misc/LayoutReloadedWebKit.patch	2018-04-13 18:40:07 UTC (rev 230642)
@@ -24,10 +24,10 @@
  $(WebCore)/dom/TreeWalker.idl \
  $(WebCore)/dom/UIEvent.idl \
 diff --git a/Source/WebCore/Sources.txt b/Source/WebCore/Sources.txt
-index ff942b36a44..5bc30f914af 100644
+index a461719e2dd..2d48c60758b 100644
 --- a/Source/WebCore/Sources.txt
 +++ b/Source/WebCore/Sources.txt
-@@ -1797,7 +1797,9 @@ rendering/InlineBox.cpp
+@@ -1802,7 +1802,9 @@ rendering/InlineBox.cpp
  rendering/InlineElementBox.cpp
  rendering/InlineFlowBox.cpp
  rendering/InlineIterator.cpp
@@ -38,7 +38,7 @@
  rendering/LayoutRepainter.cpp
  rendering/LayoutState.cpp
 diff --git a/Source/WebCore/WebCore.xcodeproj/project.pbxproj b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
-index 2ae0c8a22d5..edcd82aa95a 100644
+index a6a138060f6..91fb8a5cd04 100644
 --- a/Source/WebCore/WebCore.xcodeproj/project.pbxproj
 +++ b/Source/WebCore/WebCore.xcodeproj/project.pbxproj
 @@ -396,6 +396,10 @@
@@ -52,7 +52,7 @@
  		11CB2789203BA570004A1DC9 /* RenderTreeBuilderFullScreen.h in Headers */ = {isa = PBXBuildFile; fileRef = 11CB2787203BA570004A1DC9 /* RenderTreeBuilderFullScreen.h */; };
  		11E067EE1E6246E500162D16 /* SimpleLineLayoutCoverage.h in Headers */ = {isa = PBXBuildFile; fileRef = 11E067ED1E6246E500162D16 /* SimpleLineLayoutCoverage.h */; settings = {ATTRIBUTES = (Private, ); }; };
  		1400D7A817136EA70077CE05 /* ScriptWrappableInlines.h in Headers */ = {isa = PBXBuildFile; fileRef = 1400D7A717136EA70077CE05 /* ScriptWrappableInlines.h */; settings = {ATTRIBUTES = (Private, ); }; };
-@@ -5699,6 +5703,13 @@
+@@ -5706,6 +5710,13 @@
  		119340951FED715500935F1E /* RenderTreeBuilderFormControls.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderFormControls.h; sourceTree = ""; };
  		119340A01FEE024000935F1E /* RenderTreeBuilderBlock.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = RenderTreeBuilderBlock.cpp; sourceTree = ""; };
  		119340A11FEE024000935F1E /* RenderTreeBuilderBlock.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderBlock.h; sourceTree = ""; };
@@ -66,7 +66,7 @@
  		11C5F1162003E7750001AE60 /* RenderTreeBuilderInline.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderTreeBuilderInline.cpp; sourceTree = ""; };
  		11C5F1182003E7760001AE60 /* RenderTreeBuilderInline.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderInline.h; sourceTree = ""; };
  		11C5F11D2003F69E0001AE60 /* RenderTreeBuilderBlockFlow.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderTreeBuilderBlockFlow.h; sourceTree = ""; };
-@@ -22115,6 +22126,7 @@
+@@ -22145,6 +22156,7 @@
  		A83B79100CCB001B000B0825 /* Core */ = {
  			isa = PBXGroup;
  			children = (
@@ -74,7 +74,7 @@
  7C30D97E1F815AC000268356 /* JSAbortController.cpp */,
  7C30D9801F815AC100268356 /* JSAbortController.h */,
  7C30D9821F815AC200268356 /* JSAbortSignal.cpp */,
-@@ -25447,6 +25459,10 @@
+@@ -25479,6 +25491,10 @@
  		F523D2F302DE443B018635CA /* rendering */ = {
  			isa = PBXGroup;
  			children = (
@@ -85,7 +85,7 @@
  FFB698C81832F10B00158A31 /* line */,
  439046C212DA25CE00AF80A2 /* mathml */,
  FD08A879175D3926002CD360 /* shapes */,
-@@ -25742,6 +25758,8 @@
+@@ -25775,6 +25791,8 @@
  		F523D32402DE4478018635CA /* dom */ = {
  			isa = PBXGroup;
  			children = (
@@ -94,7 +94,7 @@
  CE2616A4187E65C1007955F3 /* ios */,
  2D5036661BCDDDC400E20BB3 /* mac */,
  51ECC3E42005831F00483EAE /* messageports */,
-@@ -26736,6 +26754,7 @@
+@@ -26771,6 +26789,7 @@
  31DCD29D1AB4FBDE0072E817 /* AnimationTrigger.h in Headers */,
  0F580FAF149800D400FB5BD8 /* AnimationUtilities.h in Headers */,
  93309DD7099E64920056E581 /* 

[webkit-changes] [230639] trunk

[cdumez]

Title: [230639] trunk








Revision 230639
Author cdu...@apple.com
Date 2018-04-13 10:37:31 -0700 (Fri, 13 Apr 2018)


Log Message
input.webkitEntries does not work as expected when folder contains accented chars
https://bugs.webkit.org/show_bug.cgi?id=184517


Reviewed by Alex Christensen.

Source/WebCore:

Use String::fromUTF8() to construct a WTF String from the char* returned by
dirname() in FileSystem::directoryName(). Previously, we were just calling
the String constructor, which would treat the input as latin 1 instead of
UTF-8.

Change is covered by an API test rather than a layout test due to file versioning
limitations.

* platform/posix/FileSystemPOSIX.cpp:
(WebCore::FileSystem::directoryName):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
(TestWebKitAPI::TEST_F):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230638 => 230639)

--- trunk/Source/WebCore/ChangeLog	2018-04-13 17:31:45 UTC (rev 230638)
+++ trunk/Source/WebCore/ChangeLog	2018-04-13 17:37:31 UTC (rev 230639)
@@ -1,3 +1,22 @@
+2018-04-13  Chris Dumez  
+
+input.webkitEntries does not work as expected when folder contains accented chars
+https://bugs.webkit.org/show_bug.cgi?id=184517
+
+
+Reviewed by Alex Christensen.
+
+Use String::fromUTF8() to construct a WTF String from the char* returned by
+dirname() in FileSystem::directoryName(). Previously, we were just calling
+the String constructor, which would treat the input as latin 1 instead of
+UTF-8.
+
+Change is covered by an API test rather than a layout test due to file versioning
+limitations.
+
+* platform/posix/FileSystemPOSIX.cpp:
+(WebCore::FileSystem::directoryName):
+
 2018-04-13  Yusuke Suzuki  
 
 [WebCore] Use @getByIdDirectPrivate / @putByIdDirectPrivate in WebCore JS


Modified: trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp (230638 => 230639)

--- trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp	2018-04-13 17:31:45 UTC (rev 230638)
+++ trunk/Source/WebCore/platform/posix/FileSystemPOSIX.cpp	2018-04-13 17:37:31 UTC (rev 230639)
@@ -351,7 +351,7 @@
 if (!fsRep.data() || fsRep.data()[0] == '\0')
 return String();
 
-return dirname(fsRep.mutableData());
+return String::fromUTF8(dirname(fsRep.mutableData()));
 }
 
 Vector listDirectory(const String& path, const String& filter)


Modified: trunk/Tools/ChangeLog (230638 => 230639)

--- trunk/Tools/ChangeLog	2018-04-13 17:31:45 UTC (rev 230638)
+++ trunk/Tools/ChangeLog	2018-04-13 17:37:31 UTC (rev 230639)
@@ -1,3 +1,16 @@
+2018-04-13  Chris Dumez  
+
+input.webkitEntries does not work as expected when folder contains accented chars
+https://bugs.webkit.org/show_bug.cgi?id=184517
+
+
+Reviewed by Alex Christensen.
+
+Add API test coverage.
+
+* TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
+(TestWebKitAPI::TEST_F):
+
 2018-04-13  Thibault Saunier  
 
 Update my emails ordering in contributors.json


Modified: trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp (230638 => 230639)

--- trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2018-04-13 17:31:45 UTC (rev 230638)
+++ trunk/Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp	2018-04-13 17:37:31 UTC (rev 230639)
@@ -139,4 +139,12 @@
 EXPECT_EQ(strlen(FileSystemTestData), static_cast(targetMetadata.value().length));
 }
 
+TEST_F(FileSystemTest, UnicodeDirectoryName)
+{
+String path = String::fromUTF8("/test/a\u0308lo/test.txt");
+String directoryName = FileSystem::directoryName(path);
+String expectedDirectoryName = String::fromUTF8("/test/a\u0308lo");
+EXPECT_TRUE(expectedDirectoryName == directoryName);
 }
+
+}






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230637] trunk/Source/WebCore

[utatane . tea]

Title: [230637] trunk/Source/WebCore








Revision 230637
Author utatane@gmail.com
Date 2018-04-13 10:01:40 -0700 (Fri, 13 Apr 2018)


Log Message
[WebCore] Use @getByIdDirectPrivate / @putByIdDirectPrivate in WebCore JS
https://bugs.webkit.org/show_bug.cgi?id=184401

Rubber stamped by Saam Barati.

Apply bug 183970 changes to WebCore JS too. This offers solid type checking
with @getByIdDirectPrivate().

* Modules/mediastream/RTCPeerConnection.js:
(initializeRTCPeerConnection):
(getLocalStreams):
(getStreamById):
(addStream):
* Modules/mediastream/RTCPeerConnectionInternals.js:
(isRTCPeerConnection):
* Modules/streams/ReadableByteStreamController.js:
(enqueue):
(error):
(close):
(getter.byobRequest):
* Modules/streams/ReadableByteStreamInternals.js:
(privateInitializeReadableStreamBYOBReader):
(privateInitializeReadableByteStreamController):
(privateInitializeReadableStreamBYOBRequest):
(isReadableByteStreamController):
(isReadableStreamBYOBRequest):
(isReadableStreamBYOBReader):
(readableByteStreamControllerCancel):
(readableByteStreamControllerError):
(readableByteStreamControllerClose):
(readableByteStreamControllerClearPendingPullIntos):
(readableByteStreamControllerGetDesiredSize):
(readableStreamHasBYOBReader):
(readableStreamHasDefaultReader):
(readableByteStreamControllerHandleQueueDrain):
(readableByteStreamControllerPull):
(readableByteStreamControllerShouldCallPull):
(readableByteStreamControllerCallPullIfNeeded):
(readableByteStreamControllerEnqueue):
(readableByteStreamControllerEnqueueChunk):
(readableByteStreamControllerRespondWithNewView):
(readableByteStreamControllerRespond):
(readableByteStreamControllerRespondInternal):
(readableByteStreamControllerRespondInReadableState):
(readableByteStreamControllerRespondInClosedState):
(readableByteStreamControllerProcessPullDescriptors):
(readableByteStreamControllerFillDescriptorFromQueue):
(readableByteStreamControllerShiftPendingDescriptor):
(readableByteStreamControllerInvalidateBYOBRequest):
(readableByteStreamControllerCommitDescriptor):
(readableStreamFulfillReadIntoRequest):
(readableByteStreamControllerPullInto):
(readableStreamAddReadIntoRequest):
* Modules/streams/ReadableStream.js:
(initializeReadableStream):
(pipeThrough):
* Modules/streams/ReadableStreamBYOBReader.js:
(cancel):
(read):
(releaseLock):
(getter.closed):
* Modules/streams/ReadableStreamBYOBRequest.js:
(respond):
(respondWithNewView):
(getter.view):
* Modules/streams/ReadableStreamDefaultController.js:
(error):
* Modules/streams/ReadableStreamDefaultReader.js:
(cancel):
(read):
(releaseLock):
(getter.closed):
* Modules/streams/ReadableStreamInternals.js:
(privateInitializeReadableStreamDefaultReader):
(readableStreamReaderGenericInitialize):
(readableStreamDefaultControllerError):
(readableStreamPipeTo):
(readableStreamTee):
(isReadableStream):
(isReadableStreamDefaultReader):
(isReadableStreamDefaultController):
(readableStreamError):
(readableStreamDefaultControllerCallPullIfNeeded):
(readableStreamDefaultControllerGetDesiredSize):
(readableStreamReaderGenericCancel):
(readableStreamCancel):
(readableStreamDefaultControllerCancel):
(readableStreamDefaultControllerPull):
(readableStreamDefaultControllerClose):
(readableStreamClose):
(readableStreamFulfillReadRequest):
(readableStreamDefaultReaderRead):
(readableStreamAddReadRequest):
(isReadableStreamDisturbed):
(readableStreamReaderGenericRelease):
(readableStreamDefaultControllerCanCloseOrEnqueue):
(privateInitializeReadableStreamDefaultController): Deleted.
* Modules/streams/StreamInternals.js:
(validateAndNormalizeQueuingStrategy):
* Modules/streams/WritableStream.js:
(initializeWritableStream):
(abort):
(close):
(write):
(getter.closed):
(getter.ready):
(getter.state):
* Modules/streams/WritableStreamInternals.js:
(isWritableStream):
(syncWritableStreamStateWithQueue):
(errorWritableStream):
(callOrScheduleWritableStreamAdvanceQueue):
* bindings/js/JSDOMBindingInternals.js:
(mapLikeForEach):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.js
trunk/Source/WebCore/Modules/mediastream/RTCPeerConnectionInternals.js
trunk/Source/WebCore/Modules/streams/ReadableByteStreamController.js
trunk/Source/WebCore/Modules/streams/ReadableByteStreamInternals.js
trunk/Source/WebCore/Modules/streams/ReadableStream.js
trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBReader.js
trunk/Source/WebCore/Modules/streams/ReadableStreamBYOBRequest.js
trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultController.js
trunk/Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js
trunk/Source/WebCore/Modules/streams/ReadableStreamInternals.js
trunk/Source/WebCore/Modules/streams/StreamInternals.js
trunk/Source/WebCore/Modules/streams/WritableStream.js
trunk/Source/WebCore/Modules/streams/WritableStreamInternals.js
trunk/Source/WebCore/bindings/js/JSDOMBindingInternals.js




Diff

Modified: trunk/Source/WebCore/ChangeLog (230636 => 230637)

--- 

[webkit-changes] [230640] trunk

[beidson]

Title: [230640] trunk








Revision 230640
Author beid...@apple.com
Date 2018-04-13 11:04:22 -0700 (Fri, 13 Apr 2018)


Log Message
Introduce SuspendedPageProxy to keep old web processes around after their WebPageProxy has been swapped to a new one.
https://bugs.webkit.org/show_bug.cgi?id=184559

Reviewed by Alex Christensen.

Source/WebCore:

Covered by new API test.

WebCore changes rework the meaning of a "ForSuspension" policy to simply navigate the page to about:blank.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

Source/WebKit:

Before this patch, when a WebPageProxy navigates and is swapped to a new process, the old process almost always goes away.

This is not desirable for a few reasons:
1 - We can't keep the PageCache working for back/forward scenarios
2 - We throw away a "foo.com" web process, meaning the next time we need to host a "foo.com" web page we have to launch
and initialize a new web process.

This patch adds a SuspendedPageProxy object to keep around the old web process and to manage communication with it.

For now, a WebPageProxy keeps exactly one "suspended page" representing the most recently visited page and its process.
Additionally, that process is never reused.

So no benefit is achieved with this patch, but it enables future benefits.

* Platform/Logging.h:

* Shared/WebBackForwardListItem.cpp:
(WebKit::WebBackForwardListItem::setSuspendedPage):
* Shared/WebBackForwardListItem.h:

New object to represent the state of a WebPageProxy in an old web process that is not currently hosting the view.
* UIProcess/SuspendedPageProxy.cpp: Added.
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
(WebKit::SuspendedPageProxy::~SuspendedPageProxy):
(WebKit::SuspendedPageProxy::webProcessDidClose):
(WebKit::SuspendedPageProxy::didFinishLoad):
(WebKit::SuspendedPageProxy::didReceiveMessage):
(WebKit::SuspendedPageProxy::loggingString const):
* UIProcess/SuspendedPageProxy.h: Copied from Source/WebKit/Platform/Logging.h.
(WebKit::SuspendedPageProxy::create):
(WebKit::SuspendedPageProxy::page const):
(WebKit::SuspendedPageProxy::process const):
(WebKit::SuspendedPageProxy::item const):
(WebKit::SuspendedPageProxy::finishedSuspending const):

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::attachToProcessForNavigation):
(WebKit::WebPageProxy::maybeCreateSuspendedPage):
(WebKit::WebPageProxy::suspendedPageProcessClosed):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::didFinishLoadForFrame):
* UIProcess/WebPageProxy.h:

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::suspendWebPageProxy):
(WebKit::WebProcessProxy::suspendedPageWasDestroyed):
(WebKit::WebProcessProxy::removeWebPage):
(WebKit::WebProcessProxy::didReceiveMessage): Optionally pass WebPageProxy messages along to SuspendedPageProxy objects.
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::maybeShutDown):
(WebKit::WebProcessProxy::canTerminateChildProcess): Don't terminate child processes if they still have suspended pages.
* UIProcess/WebProcessProxy.h:

* WebKit.xcodeproj/project.pbxproj:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setIsSuspended):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::isSuspended const): For now, used only by WebProcess::updateActivePages. Will have more uses soon.
* WebProcess/WebPage/WebPage.messages.in:

* WebProcess/WebProcess.messages.in:
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::updateActivePages): Allow the UIProcess to request an update of the web processes user visible name.

Source/WTF:

* wtf/DebugUtilities.h:
(WTF::debugString): Add a debug utility to easily construct a "const char*" that is released after a spin of the run loop.
  This greatly eases uses our String classes and functions inside of "%s" style environments like printf and LOG.

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

Modified Paths

trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/DebugUtilities.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/DocumentLoader.cpp
trunk/Source/WebCore/loader/DocumentLoader.h
trunk/Source/WebCore/loader/FrameLoader.cpp
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Platform/Logging.h
trunk/Source/WebKit/Shared/WebBackForwardListItem.cpp
trunk/Source/WebKit/Shared/WebBackForwardListItem.h
trunk/Source/WebKit/UIProcess/WebPageProxy.cpp
trunk/Source/WebKit/UIProcess/WebPageProxy.h
trunk/Source/WebKit/UIProcess/WebProcessProxy.cpp
trunk/Source/WebKit/UIProcess/WebProcessProxy.h
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp
trunk/Source/WebKit/WebProcess/WebPage/WebPage.h

[webkit-changes] [230653] trunk/Tools

[clopez]

Title: [230653] trunk/Tools








Revision 230653
Author clo...@igalia.com
Date 2018-04-13 19:14:02 -0700 (Fri, 13 Apr 2018)


Log Message
[WPE] [webkitpy] The driver requirements should be checked before starting the tests
https://bugs.webkit.org/show_bug.cgi?id=184595

Reviewed by Michael Catanzaro.

Ensure Driver.check_driver() is checked at check_sys_deps() time.

* Scripts/webkitpy/port/wpe.py:
(WPEPort.check_sys_deps):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/port/wpe.py




Diff

Modified: trunk/Tools/ChangeLog (230652 => 230653)

--- trunk/Tools/ChangeLog	2018-04-14 01:07:24 UTC (rev 230652)
+++ trunk/Tools/ChangeLog	2018-04-14 02:14:02 UTC (rev 230653)
@@ -1,3 +1,15 @@
+2018-04-13  Carlos Alberto Lopez Perez  
+
+[WPE] [webkitpy] The driver requirements should be checked before starting the tests
+https://bugs.webkit.org/show_bug.cgi?id=184595
+
+Reviewed by Michael Catanzaro.
+
+Ensure Driver.check_driver() is checked at check_sys_deps() time.
+
+* Scripts/webkitpy/port/wpe.py:
+(WPEPort.check_sys_deps):
+
 2018-04-13  Zalan Bujtas  
 
 Rebaseline LayoutReloaded patch file (collectRenderersWithNeedsLayout).


Modified: trunk/Tools/Scripts/webkitpy/port/wpe.py (230652 => 230653)

--- trunk/Tools/Scripts/webkitpy/port/wpe.py	2018-04-14 01:07:24 UTC (rev 230652)
+++ trunk/Tools/Scripts/webkitpy/port/wpe.py	2018-04-14 02:14:02 UTC (rev 230653)
@@ -77,6 +77,9 @@
 environment['WEBKIT_EXEC_PATH'] = self._build_path('bin')
 return environment
 
+def check_sys_deps(self, needs_http):
+return super(WPEPort, self).check_sys_deps(needs_http) and self._driver_class().check_driver(self)
+
 def _generate_all_test_configurations(self):
 configurations = []
 for build_type in self.ALL_BUILD_TYPES:






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230652] trunk/Source/WebKit

[ryanhaddad]

Title: [230652] trunk/Source/WebKit








Revision 230652
Author ryanhad...@apple.com
Date 2018-04-13 18:07:24 -0700 (Fri, 13 Apr 2018)


Log Message
Unreviewed, rolling out r230447.

Caused flaky selection test failures on iOS

Reverted changeset:

"Switch to UIWKTextInteractionAssistant for non-editable text"
https://bugs.webkit.org/show_bug.cgi?id=182834
https://trac.webkit.org/changeset/230447

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (230651 => 230652)

--- trunk/Source/WebKit/ChangeLog	2018-04-14 00:39:59 UTC (rev 230651)
+++ trunk/Source/WebKit/ChangeLog	2018-04-14 01:07:24 UTC (rev 230652)
@@ -1,3 +1,15 @@
+2018-04-13  Ryan Haddad  
+
+Unreviewed, rolling out r230447.
+
+Caused flaky selection test failures on iOS
+
+Reverted changeset:
+
+"Switch to UIWKTextInteractionAssistant for non-editable text"
+https://bugs.webkit.org/show_bug.cgi?id=182834
+https://trac.webkit.org/changeset/230447
+
 2018-04-13  Chris Dumez  
 
 Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame


Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (230651 => 230652)

--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-04-14 00:39:59 UTC (rev 230651)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm	2018-04-14 01:07:24 UTC (rev 230652)
@@ -1902,17 +1902,30 @@
 
 - (void)useSelectionAssistantWithGranularity:(WKSelectionGranularity)selectionGranularity
 {
-_webSelectionAssistant = nil;
+#if ENABLE(UNIFIED_TEXT_SELECTION)
+selectionGranularity = WKSelectionGranularityCharacter;
+#endif
+if (selectionGranularity == WKSelectionGranularityDynamic) {
+if (_textSelectionAssistant) {
+[_textSelectionAssistant deactivateSelection];
+_textSelectionAssistant = nil;
+}
+if (!_webSelectionAssistant)
+_webSelectionAssistant = adoptNS([[UIWKSelectionAssistant alloc] initWithView:self]);
+} else if (selectionGranularity == WKSelectionGranularityCharacter) {
+if (_webSelectionAssistant)
+_webSelectionAssistant = nil;
 
-if (!_textSelectionAssistant)
-_textSelectionAssistant = adoptNS([[UIWKTextInteractionAssistant alloc] initWithView:self]);
-else {
-// Reset the gesture recognizers in case editibility has changed.
-[_textSelectionAssistant setGestureRecognizers];
+if (!_textSelectionAssistant)
+_textSelectionAssistant = adoptNS([[UIWKTextInteractionAssistant alloc] initWithView:self]);
+else {
+// Reset the gesture recognizers in case editibility has changed.
+[_textSelectionAssistant setGestureRecognizers];
+}
+
+if (self.isFirstResponder && !self.suppressAssistantSelectionView)
+[_textSelectionAssistant activateSelection];
 }
-
-if (self.isFirstResponder && !self.suppressAssistantSelectionView)
-[_textSelectionAssistant activateSelection];
 }
 
 - (void)clearSelection






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230654] trunk/LayoutTests

[commit-queue]

Title: [230654] trunk/LayoutTests








Revision 230654
Author commit-qu...@webkit.org
Date 2018-04-13 20:14:45 -0700 (Fri, 13 Apr 2018)


Log Message
[GTK][Wayland] Unflag test-case fast/canvas/canvas-createPattern-video-modify.html
https://bugs.webkit.org/show_bug.cgi?id=182432

Patch by Carlos Ramalho  on 2018-04-13
Reviewed by Michael Catanzaro.

* platform/gtk-wayland/TestExpectations: Unmarked fast/canvas/canvas-createPattern-video-modify.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wayland/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230653 => 230654)

--- trunk/LayoutTests/ChangeLog	2018-04-14 02:14:02 UTC (rev 230653)
+++ trunk/LayoutTests/ChangeLog	2018-04-14 03:14:45 UTC (rev 230654)
@@ -1,3 +1,12 @@
+2018-04-13  Carlos Ramalho  
+
+[GTK][Wayland] Unflag test-case fast/canvas/canvas-createPattern-video-modify.html
+https://bugs.webkit.org/show_bug.cgi?id=182432
+
+Reviewed by Michael Catanzaro.
+
+* platform/gtk-wayland/TestExpectations: Unmarked fast/canvas/canvas-createPattern-video-modify.html
+
 2018-04-13  Ryan Haddad  
 
 Mark http/wpt/service-workers/header-filtering.https.html as flaky.


Modified: trunk/LayoutTests/platform/gtk-wayland/TestExpectations (230653 => 230654)

--- trunk/LayoutTests/platform/gtk-wayland/TestExpectations	2018-04-14 02:14:02 UTC (rev 230653)
+++ trunk/LayoutTests/platform/gtk-wayland/TestExpectations	2018-04-14 03:14:45 UTC (rev 230654)
@@ -17,7 +17,6 @@
 
 webkit.org/b/156717 editing/pasteboard/gtk/middle-click-onpaste.html [ Failure ]
 webkit.org/b/156717 editing/pasteboard/paste-global-selection.html [ Failure ]
-webkit.org/b/182432 fast/canvas/canvas-createPattern-video-modify.html [ Failure ]
 webkit.org/b/156717 fast/repaint/animation-after-layer-scroll.html [ Failure ]
 webkit.org/b/156717 imported/blink/css3/blending/mix-blend-mode-has-ancestor-clipping-layer.html [ ImageOnlyFailure ]
 webkit.org/b/156717 imported/blink/css3/blending/mix-blend-mode-multiply.html [ ImageOnlyFailure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230655] trunk/Tools

[zalan]

Title: [230655] trunk/Tools








Revision 230655
Author za...@apple.com
Date 2018-04-13 20:21:59 -0700 (Fri, 13 Apr 2018)


Log Message
[LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
https://bugs.webkit.org/show_bug.cgi?id=184621

Reviewed by Antti Koivisto.

This is just a simple, mark ancestors dirty implementation.

* LayoutReloaded/FormattingState/FormattingState.js:
(FormattingState.prototype.markNeedsLayout):
* LayoutReloaded/LayoutState.js:
(LayoutState.prototype.markNeedsLayout):
(LayoutState.prototype.setNeedsLayoutById): Deleted.
(LayoutState.prototype.setNeedsLayout): Deleted.
* LayoutReloaded/TreeBuilder.js:
(TreeBuilder.prototype._createAndAttachBox):
(TreeBuilder.prototype._findBox): Deleted.
* LayoutReloaded/Utils.js:
(Utils.layoutBoxById):
* LayoutReloaded/test/index.html:
* LayoutReloaded/test/simple-incremental-layout-with-static-content.html:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js
trunk/Tools/LayoutReloaded/LayoutState.js
trunk/Tools/LayoutReloaded/TreeBuilder.js
trunk/Tools/LayoutReloaded/Utils.js
trunk/Tools/LayoutReloaded/test/index.html
trunk/Tools/LayoutReloaded/test/simple-incremental-layout-with-static-content.html




Diff

Modified: trunk/Tools/ChangeLog (230654 => 230655)

--- trunk/Tools/ChangeLog	2018-04-14 03:14:45 UTC (rev 230654)
+++ trunk/Tools/ChangeLog	2018-04-14 03:21:59 UTC (rev 230655)
@@ -1,3 +1,26 @@
+2018-04-13  Zalan Bujtas  
+
+[LayoutReloaded] Add simple implementation for FormattingState::markNeedsLayout()
+https://bugs.webkit.org/show_bug.cgi?id=184621
+
+Reviewed by Antti Koivisto.
+
+This is just a simple, mark ancestors dirty implementation.
+
+* LayoutReloaded/FormattingState/FormattingState.js:
+(FormattingState.prototype.markNeedsLayout):
+* LayoutReloaded/LayoutState.js:
+(LayoutState.prototype.markNeedsLayout):
+(LayoutState.prototype.setNeedsLayoutById): Deleted.
+(LayoutState.prototype.setNeedsLayout): Deleted.
+* LayoutReloaded/TreeBuilder.js:
+(TreeBuilder.prototype._createAndAttachBox):
+(TreeBuilder.prototype._findBox): Deleted.
+* LayoutReloaded/Utils.js:
+(Utils.layoutBoxById):
+* LayoutReloaded/test/index.html:
+* LayoutReloaded/test/simple-incremental-layout-with-static-content.html:
+
 2018-04-13  Carlos Alberto Lopez Perez  
 
 [WPE] [webkitpy] The driver requirements should be checked before starting the tests


Modified: trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js (230654 => 230655)

--- trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js	2018-04-14 03:14:45 UTC (rev 230654)
+++ trunk/Tools/LayoutReloaded/FormattingState/FormattingState.js	2018-04-14 03:21:59 UTC (rev 230655)
@@ -80,7 +80,19 @@
 }
 
 markNeedsLayout(layoutBox) {
+// Never mark the formatting root dirty. It belongs to the parent formatting context (or none if ICB).
+ASSERT(layoutBox != this.formattingRoot());
 this.m_needsLayoutBoxList.set(layoutBox);
+// FIXME: Let's just mark all the ancestors dirty in this formatting scope.
+let containingBlock = layoutBox.containingBlock();
+if (!containingBlock || containingBlock == this.formattingRoot())
+return;
+if (!FormattingContext.isInFormattingContext(containingBlock, this.formattingRoot()))
+return;
+if (this.needsLayout(containingBlock))
+return;
+
+this.markNeedsLayout(containingBlock);
 }
 
 clearNeedsLayout(layoutBox) {


Modified: trunk/Tools/LayoutReloaded/LayoutState.js (230654 => 230655)

--- trunk/Tools/LayoutReloaded/LayoutState.js	2018-04-14 03:14:45 UTC (rev 230654)
+++ trunk/Tools/LayoutReloaded/LayoutState.js	2018-04-14 03:21:59 UTC (rev 230655)
@@ -61,16 +61,12 @@
 return null;
 }
 
-// This is for testing only.
-setNeedsLayoutById(layoutBoxId) {
-}
-
-setNeedsLayout(layoutBox) {
+markNeedsLayout(layoutBox) {
 let formattingState = this.formattingStateForBox(layoutBox);
 // Newly created formatting state will obviously mark all the boxes dirty.
 if (!formattingState)
 return;
-formattingState.setNeedsLayout(layoutBox);
+formattingState.markNeedsLayout(layoutBox);
 }
 
 needsLayout() {


Modified: trunk/Tools/LayoutReloaded/TreeBuilder.js (230654 => 230655)

--- trunk/Tools/LayoutReloaded/TreeBuilder.js	2018-04-14 03:14:45 UTC (rev 230654)
+++ trunk/Tools/LayoutReloaded/TreeBuilder.js	2018-04-14 03:21:59 UTC (rev 230655)
@@ -64,7 +64,7 @@
 if (box)
 box.setRendererName(name);
 
-let parentBox = this._findBox(initialBlockContainer, parentId);
+let parentBox = Utils.layoutBoxById(parentId, initialBlockContainer);
 // WebKit does not construct anonymous 

[webkit-changes] [230647] trunk/LayoutTests

[ryanhaddad]

Title: [230647] trunk/LayoutTests








Revision 230647
Author ryanhad...@apple.com
Date 2018-04-13 16:30:46 -0700 (Fri, 13 Apr 2018)


Log Message
Skip animations/added-while-suspended.html and transitions/created-while-suspended.html.
https://bugs.webkit.org/show_bug.cgi?id=184608

Unreviewed test gardening.

* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/ios/TestExpectations
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230646 => 230647)

--- trunk/LayoutTests/ChangeLog	2018-04-13 22:50:59 UTC (rev 230646)
+++ trunk/LayoutTests/ChangeLog	2018-04-13 23:30:46 UTC (rev 230647)
@@ -1,3 +1,13 @@
+2018-04-13  Ryan Haddad  
+
+Skip animations/added-while-suspended.html and transitions/created-while-suspended.html.
+https://bugs.webkit.org/show_bug.cgi?id=184608
+
+Unreviewed test gardening.
+
+* platform/ios/TestExpectations:
+* platform/mac/TestExpectations:
+
 2018-04-12  Antoine Quint  
 
 [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default


Modified: trunk/LayoutTests/platform/ios/TestExpectations (230646 => 230647)

--- trunk/LayoutTests/platform/ios/TestExpectations	2018-04-13 22:50:59 UTC (rev 230646)
+++ trunk/LayoutTests/platform/ios/TestExpectations	2018-04-13 23:30:46 UTC (rev 230647)
@@ -2590,6 +2590,9 @@
 webkit.org/b/154253 animations/animation-delay-changed.html [ Pass Failure ]
 webkit.org/b/154253 legacy-animation-engine/animations/animation-delay-changed.html [ Pass Failure ]
 
+webkit.org/b/184608 [ Debug ] animations/added-while-suspended.html [ Skip ]
+webkit.org/b/184608 [ Debug ] transitions/created-while-suspended.html [ Skip ]
+
 webkit.org/b/155095 fast/table/border-collapsing/table-rtl-row-mixed-direction.html [ ImageOnlyFailure Pass ]
 webkit.org/b/155095 fast/table/border-collapsing/table-ltr-rows-mixed-direction.html [ ImageOnlyFailure Pass ]
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (230646 => 230647)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-04-13 22:50:59 UTC (rev 230646)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-04-13 23:30:46 UTC (rev 230647)
@@ -160,6 +160,9 @@
 webkit.org/b/113598 legacy-animation-engine/animations/animation-delay-changed.html [ Pass Failure ]
 webkit.org/b/113599 svg/animations/reinserting-svg-into-document.html [ Pass Failure ]
 
+webkit.org/b/184608 [ Debug ] animations/added-while-suspended.html [ Skip ]
+webkit.org/b/184608 [ Debug ] transitions/created-while-suspended.html [ Skip ]
+
 # Safari doesn't allow to customize outermost scrollbars.
 webkit.org/b/43960 scrollbars/custom-scrollbar-with-incomplete-style.html
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230646] tags/Safari-605.1.33.1.4/

[kocsen_chung]

Title: [230646] tags/Safari-605.1.33.1.4/








Revision 230646
Author kocsen_ch...@apple.com
Date 2018-04-13 15:50:59 -0700 (Fri, 13 Apr 2018)


Log Message
Tag Safari-605.1.33.1.4.

Added Paths

tags/Safari-605.1.33.1.4/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230645] tags/Safari-605.1.33.0.3/

[kocsen_chung]

Title: [230645] tags/Safari-605.1.33.0.3/








Revision 230645
Author kocsen_ch...@apple.com
Date 2018-04-13 15:48:44 -0700 (Fri, 13 Apr 2018)


Log Message
Tag Safari-605.1.33.0.3.

Added Paths

tags/Safari-605.1.33.0.3/




Diff




___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230650] trunk/LayoutTests

[ryanhaddad]

Title: [230650] trunk/LayoutTests








Revision 230650
Author ryanhad...@apple.com
Date 2018-04-13 17:39:58 -0700 (Fri, 13 Apr 2018)


Log Message
Mark http/tests/cache-storage/cache-records-persistency.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177380

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230649 => 230650)

--- trunk/LayoutTests/ChangeLog	2018-04-14 00:39:56 UTC (rev 230649)
+++ trunk/LayoutTests/ChangeLog	2018-04-14 00:39:58 UTC (rev 230650)
@@ -1,5 +1,14 @@
 2018-04-13  Ryan Haddad  
 
+Mark http/tests/cache-storage/cache-records-persistency.https.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=177380
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2018-04-13  Ryan Haddad  
+
 Mark media/audio-concurrent-supported.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=184612
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (230649 => 230650)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-14 00:39:56 UTC (rev 230649)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-14 00:39:58 UTC (rev 230650)
@@ -888,3 +888,5 @@
 webkit.org/b/184245 http/tests/workers/service/service-worker-cache-api.https.html [ Pass Failure ]
 
 webkit.org/b/184051 fast/loader/submit-form-while-parsing-2.html [ Pass Timeout ]
+
+webkit.org/b/177380 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230651] trunk/LayoutTests

[ryanhaddad]

Title: [230651] trunk/LayoutTests








Revision 230651
Author ryanhad...@apple.com
Date 2018-04-13 17:39:59 -0700 (Fri, 13 Apr 2018)


Log Message
Mark http/wpt/service-workers/header-filtering.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184469

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230650 => 230651)

--- trunk/LayoutTests/ChangeLog	2018-04-14 00:39:58 UTC (rev 230650)
+++ trunk/LayoutTests/ChangeLog	2018-04-14 00:39:59 UTC (rev 230651)
@@ -1,5 +1,14 @@
 2018-04-13  Ryan Haddad  
 
+Mark http/wpt/service-workers/header-filtering.https.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=184469
+
+Unreviewed test gardening.
+
+* platform/mac-wk2/TestExpectations:
+
+2018-04-13  Ryan Haddad  
+
 Mark http/tests/cache-storage/cache-records-persistency.https.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=177380
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (230650 => 230651)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-14 00:39:58 UTC (rev 230650)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-14 00:39:59 UTC (rev 230651)
@@ -890,3 +890,5 @@
 webkit.org/b/184051 fast/loader/submit-form-while-parsing-2.html [ Pass Timeout ]
 
 webkit.org/b/177380 http/tests/cache-storage/cache-records-persistency.https.html [ Pass Failure ]
+
+webkit.org/b/184469 http/wpt/service-workers/header-filtering.https.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230648] trunk/LayoutTests

[ryanhaddad]

Title: [230648] trunk/LayoutTests








Revision 230648
Author ryanhad...@apple.com
Date 2018-04-13 17:39:53 -0700 (Fri, 13 Apr 2018)


Log Message
Mark media/video-volume-slider-drag.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184610

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230647 => 230648)

--- trunk/LayoutTests/ChangeLog	2018-04-13 23:30:46 UTC (rev 230647)
+++ trunk/LayoutTests/ChangeLog	2018-04-14 00:39:53 UTC (rev 230648)
@@ -1,5 +1,14 @@
 2018-04-13  Ryan Haddad  
 
+Mark media/video-volume-slider-drag.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=184610
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2018-04-13  Ryan Haddad  
+
 Skip animations/added-while-suspended.html and transitions/created-while-suspended.html.
 https://bugs.webkit.org/show_bug.cgi?id=184608
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (230647 => 230648)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-04-13 23:30:46 UTC (rev 230647)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-04-14 00:39:53 UTC (rev 230648)
@@ -1754,3 +1754,5 @@
 
 [ Debug ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker.html [ Crash ]
 [ Debug ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html [ Crash ]
+
+webkit.org/b/184610 media/video-volume-slider-drag.html [ Pass Timeout ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230649] trunk/LayoutTests

[ryanhaddad]

Title: [230649] trunk/LayoutTests








Revision 230649
Author ryanhad...@apple.com
Date 2018-04-13 17:39:56 -0700 (Fri, 13 Apr 2018)


Log Message
Mark media/audio-concurrent-supported.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=184612

Unreviewed test gardening.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230648 => 230649)

--- trunk/LayoutTests/ChangeLog	2018-04-14 00:39:53 UTC (rev 230648)
+++ trunk/LayoutTests/ChangeLog	2018-04-14 00:39:56 UTC (rev 230649)
@@ -1,5 +1,14 @@
 2018-04-13  Ryan Haddad  
 
+Mark media/audio-concurrent-supported.html as flaky.
+https://bugs.webkit.org/show_bug.cgi?id=184612
+
+Unreviewed test gardening.
+
+* platform/mac/TestExpectations:
+
+2018-04-13  Ryan Haddad  
+
 Mark media/video-volume-slider-drag.html as flaky.
 https://bugs.webkit.org/show_bug.cgi?id=184610
 


Modified: trunk/LayoutTests/platform/mac/TestExpectations (230648 => 230649)

--- trunk/LayoutTests/platform/mac/TestExpectations	2018-04-14 00:39:53 UTC (rev 230648)
+++ trunk/LayoutTests/platform/mac/TestExpectations	2018-04-14 00:39:56 UTC (rev 230649)
@@ -1756,3 +1756,5 @@
 [ Debug ] imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method.html [ Crash ]
 
 webkit.org/b/184610 media/video-volume-slider-drag.html [ Pass Timeout ]
+
+webkit.org/b/184612 [ Debug ] media/audio-concurrent-supported.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230644] trunk/Source/WebCore

[rniwa]

Title: [230644] trunk/Source/WebCore








Revision 230644
Author rn...@webkit.org
Date 2018-04-13 15:42:24 -0700 (Fri, 13 Apr 2018)


Log Message
WebKit crashes when libwebrtc.dylib is missing
https://bugs.webkit.org/show_bug.cgi?id=184607

Rubber-stamped by Jer Noble.

Don't call LibWebRTC related code when libwebrtc is not available.

* dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
(WebCore::Document::suspend):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/Document.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230643 => 230644)

--- trunk/Source/WebCore/ChangeLog	2018-04-13 21:23:54 UTC (rev 230643)
+++ trunk/Source/WebCore/ChangeLog	2018-04-13 22:42:24 UTC (rev 230644)
@@ -1,3 +1,16 @@
+2018-04-13  Ryosuke Niwa  
+
+WebKit crashes when libwebrtc.dylib is missing
+https://bugs.webkit.org/show_bug.cgi?id=184607
+
+Rubber-stamped by Jer Noble.
+
+Don't call LibWebRTC related code when libwebrtc is not available.
+
+* dom/Document.cpp:
+(WebCore::Document::prepareForDestruction):
+(WebCore::Document::suspend):
+
 2018-04-13  Chris Dumez  
 
 Split WindowProxy handling out of ScriptController and into a new class owned by AbstractFrame


Modified: trunk/Source/WebCore/dom/Document.cpp (230643 => 230644)

--- trunk/Source/WebCore/dom/Document.cpp	2018-04-13 21:23:54 UTC (rev 230643)
+++ trunk/Source/WebCore/dom/Document.cpp	2018-04-13 22:42:24 UTC (rev 230644)
@@ -2358,8 +2358,11 @@
 m_frame->animation().detachFromDocument(this);
 
 #if USE(LIBWEBRTC)
-if (auto* page = this->page())
-page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+// FIXME: This should be moved to Modules/mediastream.
+if (LibWebRTCProvider::webRTCAvailable()) {
+if (auto* page = this->page())
+page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+}
 #endif
 
 #if ENABLE(SERVICE_WORKER)
@@ -4891,8 +4894,11 @@
 }
 
 #if USE(LIBWEBRTC)
-if (auto* page = this->page())
-page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+// FIXME: This should be moved to Modules/mediastream.
+if (LibWebRTCProvider::webRTCAvailable()) {
+if (auto* page = this->page())
+page->libWebRTCProvider().unregisterMDNSNames(identifier().toUInt64());
+}
 #endif
 
 #if ENABLE(SERVICE_WORKER)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230624] trunk/Tools

[carlosgc]

Title: [230624] trunk/Tools








Revision 230624
Author carlo...@webkit.org
Date 2018-04-13 00:26:59 -0700 (Fri, 13 Apr 2018)


Log Message
[GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
https://bugs.webkit.org/show_bug.cgi?id=184531

Reviewed by Michael Catanzaro.

It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.

* TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
* TestWebKitAPI/glib/UtilitiesGLib.cpp:
(TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
(TestWebKitAPI::Util::sleep): Ditto.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp
trunk/Tools/TestWebKitAPI/glib/UtilitiesGLib.cpp




Diff

Modified: trunk/Tools/ChangeLog (230623 => 230624)

--- trunk/Tools/ChangeLog	2018-04-13 06:52:36 UTC (rev 230623)
+++ trunk/Tools/ChangeLog	2018-04-13 07:26:59 UTC (rev 230624)
@@ -1,3 +1,22 @@
+2018-04-13  Carlos Garcia Campos  
+
+[GLIB] Tests WTF_RefPtr.ReleaseInNonMainThread and WTF_RefPtr.ReleaseInNonMainThreadDestroyInMainThread are crashing since they were added
+https://bugs.webkit.org/show_bug.cgi?id=184531
+
+Reviewed by Michael Catanzaro.
+
+It's not a bug in WebKit, but in the tests. The problem is that those tests are using RunLoop::main() but main
+run loop hasn't been initialized. ReleaseInNonMainThread doesn't really need to initialize the main run loop if
+we change Util::run() to always use RunLop::current() instead of RunLoop::main(). But
+ReleaseInNonMainThreadDestroyInMainThread ends up scheduling a task to the main thread, and the generic
+implementation fo that uses RunLoop::main(), so we need to initialize the main loop in this case.
+
+* TestWebKitAPI/Tests/WTF/RefPtr.cpp:
+(TestWebKitAPI::TEST): Call RunLoop::initializeMainRunLoop().
+* TestWebKitAPI/glib/UtilitiesGLib.cpp:
+(TestWebKitAPI::Util::run): Use RunLop::current() to stop the current run loop.
+(TestWebKitAPI::Util::sleep): Ditto.
+
 2018-04-12  Zalan Bujtas  
 
 [LayoutReloaded] Add support for incremental layout


Modified: trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp (230623 => 230624)

--- trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp	2018-04-13 06:52:36 UTC (rev 230623)
+++ trunk/Tools/TestWebKitAPI/Tests/WTF/RefPtr.cpp	2018-04-13 07:26:59 UTC (rev 230624)
@@ -33,6 +33,7 @@
 #include 
 #include 
 #include 
+#include 
 #include 
 #include 
 
@@ -577,6 +578,7 @@
 
 TEST(WTF_RefPtr, ReleaseInNonMainThreadDestroyInMainThread)
 {
+RunLoop::initializeMainRunLoop();
 done = false;
 Thread::create("", [object = MainThreadSafeRefCountedObject::create()] { });
 TestWebKitAPI::Util::run();


Modified: trunk/Tools/TestWebKitAPI/glib/UtilitiesGLib.cpp (230623 => 230624)

--- trunk/Tools/TestWebKitAPI/glib/UtilitiesGLib.cpp	2018-04-13 06:52:36 UTC (rev 230623)
+++ trunk/Tools/TestWebKitAPI/glib/UtilitiesGLib.cpp	2018-04-13 07:26:59 UTC (rev 230624)
@@ -37,7 +37,7 @@
 g_idle_add([](gpointer userData) -> gboolean {
 bool* done = static_cast(userData);
 if (*done)
-RunLoop::main().stop();
+RunLoop::current().stop();
 
 return !*done;
 }, done);
@@ -58,7 +58,7 @@
 RunLoop::main().stop();
 return G_SOURCE_REMOVE;
 }, nullptr);
-RunLoop::main().stop();
+RunLoop::current().stop();
 }
 
 } // namespace Util






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230625] trunk/Source

[calvaris]

Title: [230625] trunk/Source








Revision 230625
Author calva...@igalia.com
Date 2018-04-13 01:50:42 -0700 (Fri, 13 Apr 2018)


Log Message
[GStreamer] Convert GStreamerUtilities in GStreamerCommon and include the GStreamer smart pointer traits
https://bugs.webkit.org/show_bug.cgi?id=184533

Reviewed by Philippe Normand.

Renamed GStreamerUtilities* files into GStreamerCommon* and
modified files including them accordingly. Include
GRefPtrGStreamer.h and GUniquePtrGStreamer.h in GStreamerCommon.h
to avoid problems destroying objects when those files are
forgotten to be included.

Source/WebCore:

* Modules/webaudio/AudioContext.cpp:
* platform/GStreamer.cmake:
* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
* platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/GStreamerCommon.cpp: Renamed from Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.cpp.
* platform/graphics/gstreamer/GStreamerCommon.h: Renamed from Source/WebCore/platform/graphics/gstreamer/GStreamerUtilities.h.
* platform/graphics/gstreamer/ImageGStreamer.h:
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp:
* platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/gstreamer/MediaSampleGStreamer.cpp:
* platform/graphics/gstreamer/MediaSampleGStreamer.h:
* platform/graphics/gstreamer/TextCombinerGStreamer.cpp:
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
* platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
* platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
* platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp:
* platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h:
* platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
* platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
* platform/graphics/gstreamer/mse/AppendPipeline.cpp:
* platform/graphics/gstreamer/mse/AppendPipeline.h:
* platform/graphics/gstreamer/mse/GStreamerMediaDescription.cpp:
* platform/graphics/gstreamer/mse/GStreamerMediaDescription.h:
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
* platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:
* platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
* platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
* platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.h:

Source/WebKit:

* UIProcess/gtk/WebProcessPoolGtk.cpp:
* UIProcess/wpe/WebProcessPoolWPE.cpp:
* WebProcess/soup/WebProcessSoup.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webaudio/AudioContext.cpp
trunk/Source/WebCore/platform/GStreamer.cmake
trunk/Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/ImageGStreamerCairo.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h
trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h
trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h
trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp
trunk/Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp

[webkit-changes] [230614] tags/Safari-606.1.13/Source/WebKit

[kocsen_chung]

Title: [230614] tags/Safari-606.1.13/Source/WebKit








Revision 230614
Author kocsen_ch...@apple.com
Date 2018-04-12 17:02:46 -0700 (Thu, 12 Apr 2018)


Log Message
Cherry-pick r230606. rdar://problem/39386359

Use -iframework to ensure that frameworks from user paths and system paths are
ordered appropriately
https://bugs.webkit.org/show_bug.cgi?id=184557
-and corresponding-
rdar://problem/39386359

Reviewed by Dean Jackson.

* Configurations/WebKit.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

tags/Safari-606.1.13/Source/WebKit/ChangeLog
tags/Safari-606.1.13/Source/WebKit/Configurations/WebKit.xcconfig




Diff

Modified: tags/Safari-606.1.13/Source/WebKit/ChangeLog (230613 => 230614)

--- tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-12 23:55:02 UTC (rev 230613)
+++ tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-13 00:02:46 UTC (rev 230614)
@@ -1,5 +1,35 @@
 2018-04-12  Kocsen Chung  
 
+Cherry-pick r230606. rdar://problem/39386359
+
+Use -iframework to ensure that frameworks from user paths and system paths are 
+ordered appropriately
+https://bugs.webkit.org/show_bug.cgi?id=184557
+-and corresponding-
+rdar://problem/39386359
+
+Reviewed by Dean Jackson.
+
+* Configurations/WebKit.xcconfig:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-04-12  Beth Dakin  
+
+Use -iframework to ensure that frameworks from user paths and system paths are
+ordered appropriately
+https://bugs.webkit.org/show_bug.cgi?id=184557
+-and corresponding-
+rdar://problem/39386359
+
+Reviewed by Dean Jackson.
+
+* Configurations/WebKit.xcconfig:
+
+2018-04-12  Kocsen Chung  
+
 Revert r230359. rdar://problem/39396724
 
 2018-04-12  Kocsen Chung  


Modified: tags/Safari-606.1.13/Source/WebKit/Configurations/WebKit.xcconfig (230613 => 230614)

--- tags/Safari-606.1.13/Source/WebKit/Configurations/WebKit.xcconfig	2018-04-12 23:55:02 UTC (rev 230613)
+++ tags/Safari-606.1.13/Source/WebKit/Configurations/WebKit.xcconfig	2018-04-13 00:02:46 UTC (rev 230614)
@@ -117,7 +117,7 @@
 LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
 LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR);
 
-OTHER_LDFLAGS = $(inherited) -F"$(SDK_DIR)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks" $(UNEXPORTED_SYMBOL_LDFLAGS) $(ASAN_OTHER_LDFLAGS) $(FRAMEWORK_AND_LIBRARY_LDFLAGS) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS);
+OTHER_LDFLAGS = $(inherited) -iframework"$(SDK_DIR)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks" $(UNEXPORTED_SYMBOL_LDFLAGS) $(ASAN_OTHER_LDFLAGS) $(FRAMEWORK_AND_LIBRARY_LDFLAGS) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS);
 
 REEXPORTED_FRAMEWORK_NAMES = WebKitLegacy;
 REEXPORTED_FRAMEWORK_NAMES[sdk=macosx*] = $(inherited) WebCore;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230613] trunk/Source/WebCore

[cdumez]

Title: [230613] trunk/Source/WebCore








Revision 230613
Author cdu...@apple.com
Date 2018-04-12 16:55:02 -0700 (Thu, 12 Apr 2018)


Log Message
Introduce remote variants of Frame / DOMWindow classes
https://bugs.webkit.org/show_bug.cgi?id=184467


Reviewed by Ryosuke Niwa.

Introduce remote variants of Frame / DOMWindow classes, for when these frames / windows
are hosted on another WebProcess. Those will be used in a follow-up patch.

The hierarchy is as follows (class naming will be improved in a follow-up patch to minimise
patch size):
- AbstractFrame: A frame that can be either local or remote (hosted on another WebProcess)
- Frame: A local frame
- RemoteFrame: A frame hosted on another WebProcess. A RemoteFrame's window is also remote.
- AbstractDOMWindow: A window that be either local or remote (hosted on another WebProcess)
- DOMWindow: A local DOMWindow
- RemoteDOMWindow: A window hosted on another WebProcess. A RemoteDOMWindow's frame is also
  remote. A RemoteDOMWindow is always cross-origin.

This patch introduces global identifiers (unique across all WebProcesses) for both Frames and
Windows. This is useful as we need to know which Frame / DOMWindow a particular RemoteFrame /
RemoteDOMWindow is pointing to.

Follow-up patch will add support for converting a local DOMWindow / Frame into a remote ones,
when a newly opened window (via window.open) is navigated cross-origin (Bug 184515).

Other things we'll need to implement in follow-ups:
- RemoteDOMWindow will need to know about its opener in order to support the window.opener
  API. Internally, the opener will be stored as a RemoteFrame so that window.opener always
  returns the current window in the opener frame (which changes upon navigation).
- Nullify a RemoteDOMWindow's frame whenever the window it is pointing to becomes frameless.
  A frameless window behaves very differently (e.g. very little API is exposed to the Web).
  This happens when either the newly opened window is either closed or navigated.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* loader/ContentFilter.cpp:
(WebCore::ContentFilter::didDecide):
* page/AbstractDOMWindow.cpp: Added.
(WebCore::AbstractDOMWindow::AbstractDOMWindow):
(WebCore::AbstractDOMWindow::~AbstractDOMWindow):
* page/AbstractDOMWindow.h: Added.
(WebCore::AbstractDOMWindow::identifier const):
* page/AbstractFrame.cpp: Added.
(WebCore::AbstractFrame::AbstractFrame):
(WebCore::AbstractFrame::~AbstractFrame):
* page/AbstractFrame.h: Added.
(WebCore::AbstractFrame::window const):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::DOMWindow):
* page/DOMWindow.h:
(isType):
* page/Frame.cpp:
(WebCore::Frame::window const):
(WebCore::Frame::virtualWindow const):
* page/Frame.h:
(isType):
* page/GlobalFrameIdentifier.h: Added.
(WebCore::GlobalFrameIdentifier::encode const):
(WebCore::GlobalFrameIdentifier::decode):
* page/GlobalWindowIdentifier.h: Added.
(WebCore::operator==):
(WebCore::GlobalWindowIdentifier::hash const):
(WebCore::GlobalWindowIdentifier::encode const):
(WebCore::GlobalWindowIdentifier::decode):
(WTF::GlobalWindowIdentifierHash::hash):
(WTF::GlobalWindowIdentifierHash::equal):
(WTF::HashTraits::emptyValue):
(WTF::HashTraits::constructDeletedValue):
(WTF::HashTraits::isDeletedValue):

* page/RemoteDOMWindow.cpp: Added.
(WebCore::RemoteDOMWindow::RemoteDOMWindow):
(WebCore::RemoteDOMWindow::~RemoteDOMWindow):
(WebCore::RemoteDOMWindow::self const):
(WebCore::RemoteDOMWindow::location const):
(WebCore::RemoteDOMWindow::close):
(WebCore::RemoteDOMWindow::closed const):
(WebCore::RemoteDOMWindow::focus):
(WebCore::RemoteDOMWindow::blur):
(WebCore::RemoteDOMWindow::length const):
(WebCore::RemoteDOMWindow::top const):
(WebCore::RemoteDOMWindow::opener const):
(WebCore::RemoteDOMWindow::parent const):
(WebCore::RemoteDOMWindow::postMessage):
The DOM API exposed on RemoteDOMWindow is only the subset of the DOMWindow API that is exposed cross origin,
since remote DOMWindow are always from a different origin. The short-term plan is to implement these in a
follow-up by relying on IPC (synchronous when necessary) to fetch the information from the real window in
the WebProcess where it lives. Longer term, we should probably keep RemoteDOMWindow members in sync with the
DOMWindow they're pointing to, so we do not have to rely on synchronous IPC.

* page/RemoteDOMWindow.h: Added.
(isType):
* page/RemoteFrame.cpp: Added.
(WebCore::RemoteFrame::RemoteFrame):
(WebCore::RemoteFrame::~RemoteFrame):
(WebCore::RemoteFrame::virtualWindow const):
* page/RemoteFrame.h: Added.
(isType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Sources.txt
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/loader/ContentFilter.cpp
trunk/Source/WebCore/page/DOMWindow.cpp
trunk/Source/WebCore/page/DOMWindow.h
trunk/Source/WebCore/page/Frame.cpp
trunk/Source/WebCore/page/Frame.h


Added Paths

trunk/Source/WebCore/page/AbstractDOMWindow.cpp

[webkit-changes] [230607] branches/safari-605.1.33.1-branch

[kocsen_chung]

Title: [230607] branches/safari-605.1.33.1-branch








Revision 230607
Author kocsen_ch...@apple.com
Date 2018-04-12 16:27:43 -0700 (Thu, 12 Apr 2018)


Log Message
Cherry-pick r229505. rdar://problem/39371567

Turn off offset*/scroll* optimization for input elements with shadow content
https://bugs.webkit.org/show_bug.cgi?id=182383


Reviewed by Antti Koivisto.

Source/WebCore:

We normally ensure clean tree before calling offsetHeight/Width, scrollHeight/Width.
In certain cases (see updateLayoutIfDimensionsOutOfDate() for details), it's okay to return
the previously computed values even when some part of the tree is dirty.
In case of shadow content, updateLayoutIfDimensionsOutOfDate() might return false (no need to layout)
for the root, while true (needs layout) for the shadow content.
This could confuse the caller (Element::scrollWidth/Height etc) and lead to incorrect result.

Test: fast/forms/scrollheight-with-mutation-crash.html

* dom/Document.cpp:
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):

LayoutTests:

* fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
* fast/forms/scrollheight-with-mutation-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-605.1.33.1-branch/LayoutTests/ChangeLog
branches/safari-605.1.33.1-branch/Source/WebCore/ChangeLog
branches/safari-605.1.33.1-branch/Source/WebCore/dom/Document.cpp


Added Paths

branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt
branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html




Diff

Modified: branches/safari-605.1.33.1-branch/LayoutTests/ChangeLog (230606 => 230607)

--- branches/safari-605.1.33.1-branch/LayoutTests/ChangeLog	2018-04-12 23:24:14 UTC (rev 230606)
+++ branches/safari-605.1.33.1-branch/LayoutTests/ChangeLog	2018-04-12 23:27:43 UTC (rev 230607)
@@ -1,3 +1,45 @@
+2018-04-12  Kocsen Chung  
+
+Cherry-pick r229505. rdar://problem/39371567
+
+Turn off offset*/scroll* optimization for input elements with shadow content
+https://bugs.webkit.org/show_bug.cgi?id=182383
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+We normally ensure clean tree before calling offsetHeight/Width, scrollHeight/Width.
+In certain cases (see updateLayoutIfDimensionsOutOfDate() for details), it's okay to return
+the previously computed values even when some part of the tree is dirty.
+In case of shadow content, updateLayoutIfDimensionsOutOfDate() might return false (no need to layout)
+for the root, while true (needs layout) for the shadow content.
+This could confuse the caller (Element::scrollWidth/Height etc) and lead to incorrect result.
+
+Test: fast/forms/scrollheight-with-mutation-crash.html
+
+* dom/Document.cpp:
+(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
+
+LayoutTests:
+
+* fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
+* fast/forms/scrollheight-with-mutation-crash.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-03-09  Zalan Bujtas  
+
+Turn off offset*/scroll* optimization for input elements with shadow content
+https://bugs.webkit.org/show_bug.cgi?id=182383
+
+
+Reviewed by Antti Koivisto.
+
+* fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
+* fast/forms/scrollheight-with-mutation-crash.html: Added.
+
 2018-02-28  Jason Marcell  
 
 Cherry-pick r229086. rdar://problem/37991718


Added: branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt (0 => 230607)

--- branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt	(rev 0)
+++ branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt	2018-04-12 23:27:43 UTC (rev 230607)
@@ -0,0 +1 @@
+PASS if no crash.  


Added: branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html (0 => 230607)

--- branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html	(rev 0)
+++ branches/safari-605.1.33.1-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html	2018-04-12 23:27:43 UTC (rev 230607)
@@ -0,0 +1,20 @@
+
+input:enabled { 
+content: url(#foo);
+width: 10vmin;
+}
+
+keygen {
+-webkit-transform: scale(12, 125);
+}
+
+PASS if no crash.
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.offsetHeight;
+keygen.remove();

[webkit-changes] [230604] branches/safari-605.1.33.0-branch

[kocsen_chung]

Title: [230604] branches/safari-605.1.33.0-branch








Revision 230604
Author kocsen_ch...@apple.com
Date 2018-04-12 16:21:42 -0700 (Thu, 12 Apr 2018)


Log Message
Cherry-pick r229505. rdar://problem/39355225

Turn off offset*/scroll* optimization for input elements with shadow content
https://bugs.webkit.org/show_bug.cgi?id=182383


Reviewed by Antti Koivisto.

Source/WebCore:

We normally ensure clean tree before calling offsetHeight/Width, scrollHeight/Width.
In certain cases (see updateLayoutIfDimensionsOutOfDate() for details), it's okay to return
the previously computed values even when some part of the tree is dirty.
In case of shadow content, updateLayoutIfDimensionsOutOfDate() might return false (no need to layout)
for the root, while true (needs layout) for the shadow content.
This could confuse the caller (Element::scrollWidth/Height etc) and lead to incorrect result.

Test: fast/forms/scrollheight-with-mutation-crash.html

* dom/Document.cpp:
(WebCore::Document::updateLayoutIfDimensionsOutOfDate):

LayoutTests:

* fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
* fast/forms/scrollheight-with-mutation-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-605.1.33.0-branch/LayoutTests/ChangeLog
branches/safari-605.1.33.0-branch/Source/WebCore/ChangeLog
branches/safari-605.1.33.0-branch/Source/WebCore/dom/Document.cpp


Added Paths

branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt
branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html




Diff

Modified: branches/safari-605.1.33.0-branch/LayoutTests/ChangeLog (230603 => 230604)

--- branches/safari-605.1.33.0-branch/LayoutTests/ChangeLog	2018-04-12 23:19:02 UTC (rev 230603)
+++ branches/safari-605.1.33.0-branch/LayoutTests/ChangeLog	2018-04-12 23:21:42 UTC (rev 230604)
@@ -1,3 +1,45 @@
+2018-04-12  Kocsen Chung  
+
+Cherry-pick r229505. rdar://problem/39355225
+
+Turn off offset*/scroll* optimization for input elements with shadow content
+https://bugs.webkit.org/show_bug.cgi?id=182383
+
+
+Reviewed by Antti Koivisto.
+
+Source/WebCore:
+
+We normally ensure clean tree before calling offsetHeight/Width, scrollHeight/Width.
+In certain cases (see updateLayoutIfDimensionsOutOfDate() for details), it's okay to return
+the previously computed values even when some part of the tree is dirty.
+In case of shadow content, updateLayoutIfDimensionsOutOfDate() might return false (no need to layout)
+for the root, while true (needs layout) for the shadow content.
+This could confuse the caller (Element::scrollWidth/Height etc) and lead to incorrect result.
+
+Test: fast/forms/scrollheight-with-mutation-crash.html
+
+* dom/Document.cpp:
+(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
+
+LayoutTests:
+
+* fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
+* fast/forms/scrollheight-with-mutation-crash.html: Added.
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-03-09  Zalan Bujtas  
+
+Turn off offset*/scroll* optimization for input elements with shadow content
+https://bugs.webkit.org/show_bug.cgi?id=182383
+
+
+Reviewed by Antti Koivisto.
+
+* fast/forms/scrollheight-with-mutation-crash-expected.txt: Added.
+* fast/forms/scrollheight-with-mutation-crash.html: Added.
+
 2018-02-28  Jason Marcell  
 
 Cherry-pick r229086. rdar://problem/37991818


Added: branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt (0 => 230604)

--- branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt	(rev 0)
+++ branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash-expected.txt	2018-04-12 23:21:42 UTC (rev 230604)
@@ -0,0 +1 @@
+PASS if no crash.  


Added: branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html (0 => 230604)

--- branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html	(rev 0)
+++ branches/safari-605.1.33.0-branch/LayoutTests/fast/forms/scrollheight-with-mutation-crash.html	2018-04-12 23:21:42 UTC (rev 230604)
@@ -0,0 +1,20 @@
+
+input:enabled { 
+content: url(#foo);
+width: 10vmin;
+}
+
+keygen {
+-webkit-transform: scale(12, 125);
+}
+
+PASS if no crash.
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+document.body.offsetHeight;
+keygen.remove();

[webkit-changes] [230609] trunk/Source/WebKit

[bdakin]

Title: [230609] trunk/Source/WebKit








Revision 230609
Author bda...@apple.com
Date 2018-04-12 16:33:56 -0700 (Thu, 12 Apr 2018)


Log Message
Fix the MOBILE_WIFI build
https://bugs.webkit.org/show_bug.cgi?id=184571
-and corresponding-


Reviewed by Jer Noble.

* config.h:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/config.h




Diff

Modified: trunk/Source/WebKit/ChangeLog (230608 => 230609)

--- trunk/Source/WebKit/ChangeLog	2018-04-12 23:27:46 UTC (rev 230608)
+++ trunk/Source/WebKit/ChangeLog	2018-04-12 23:33:56 UTC (rev 230609)
@@ -1,5 +1,16 @@
 2018-04-12  Beth Dakin  
 
+Fix the MOBILE_WIFI build
+https://bugs.webkit.org/show_bug.cgi?id=184571
+-and corresponding-
+
+
+Reviewed by Jer Noble.
+
+* config.h:
+
+2018-04-12  Beth Dakin  
+
 Use -iframework to ensure that frameworks from user paths and system paths are 
 ordered appropriately
 https://bugs.webkit.org/show_bug.cgi?id=184557


Modified: trunk/Source/WebKit/config.h (230608 => 230609)

--- trunk/Source/WebKit/config.h	2018-04-12 23:27:46 UTC (rev 230608)
+++ trunk/Source/WebKit/config.h	2018-04-12 23:33:56 UTC (rev 230609)
@@ -126,7 +126,7 @@
 #endif
 
 #ifndef HAVE_MOBILE_WIFI
-#if PLATFORM(IOS) && !TARGET_OS_SIMULATOR && USE(APPLE_INTERNAL_SDK)
+#if PLATFORM(IOS) && !TARGET_OS_SIMULATOR && !ENABLE(MINIMAL_SIMULATOR) && USE(APPLE_INTERNAL_SDK)
 #define HAVE_MOBILE_WIFI 1
 #else
 #define HAVE_MOBILE_WIFI 0






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230606] trunk/Source/WebKit

[bdakin]

Title: [230606] trunk/Source/WebKit








Revision 230606
Author bda...@apple.com
Date 2018-04-12 16:24:14 -0700 (Thu, 12 Apr 2018)


Log Message
Use -iframework to ensure that frameworks from user paths and system paths are 
ordered appropriately
https://bugs.webkit.org/show_bug.cgi?id=184557
-and corresponding-
rdar://problem/39386359

Reviewed by Dean Jackson.

* Configurations/WebKit.xcconfig:

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Configurations/WebKit.xcconfig




Diff

Modified: trunk/Source/WebKit/ChangeLog (230605 => 230606)

--- trunk/Source/WebKit/ChangeLog	2018-04-12 23:21:46 UTC (rev 230605)
+++ trunk/Source/WebKit/ChangeLog	2018-04-12 23:24:14 UTC (rev 230606)
@@ -1,3 +1,15 @@
+2018-04-12  Beth Dakin  
+
+Use -iframework to ensure that frameworks from user paths and system paths are 
+ordered appropriately
+https://bugs.webkit.org/show_bug.cgi?id=184557
+-and corresponding-
+rdar://problem/39386359
+
+Reviewed by Dean Jackson.
+
+* Configurations/WebKit.xcconfig:
+
 2018-04-12  Wenson Hsieh  
 
 [Extra zoom mode] Suppress UI for inputs of type file in extra zoom mode


Modified: trunk/Source/WebKit/Configurations/WebKit.xcconfig (230605 => 230606)

--- trunk/Source/WebKit/Configurations/WebKit.xcconfig	2018-04-12 23:21:46 UTC (rev 230605)
+++ trunk/Source/WebKit/Configurations/WebKit.xcconfig	2018-04-12 23:24:14 UTC (rev 230606)
@@ -117,7 +117,7 @@
 LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_NO = $(WEBCORE_FRAMEWORKS_DIR)/WebCore.framework/Versions/A/Frameworks;
 LIBWEBRTC_LIBRARY_DIR_USE_OVERRIDE_FRAMEWORKS_DIR_YES = $(WK_OVERRIDE_FRAMEWORKS_DIR);
 
-OTHER_LDFLAGS = $(inherited) -F"$(SDK_DIR)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks" $(UNEXPORTED_SYMBOL_LDFLAGS) $(ASAN_OTHER_LDFLAGS) $(FRAMEWORK_AND_LIBRARY_LDFLAGS) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS);
+OTHER_LDFLAGS = $(inherited) -iframework"$(SDK_DIR)$(SYSTEM_LIBRARY_DIR)/PrivateFrameworks" $(UNEXPORTED_SYMBOL_LDFLAGS) $(ASAN_OTHER_LDFLAGS) $(FRAMEWORK_AND_LIBRARY_LDFLAGS) $(WK_RELOCATABLE_FRAMEWORK_LDFLAGS);
 
 REEXPORTED_FRAMEWORK_NAMES = WebKitLegacy;
 REEXPORTED_FRAMEWORK_NAMES[sdk=macosx*] = $(inherited) WebCore;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230608] branches/safari-605.1.33.1-branch

[kocsen_chung]

Title: [230608] branches/safari-605.1.33.1-branch








Revision 230608
Author kocsen_ch...@apple.com
Date 2018-04-12 16:27:46 -0700 (Thu, 12 Apr 2018)


Log Message
Cherry-pick r230101. rdar://problem/39371537

Out-of-bounds accesses due to a missing check for MAX_STORAGE_VECTOR_LENGTH in unshiftCountForAnyIndexingType
https://bugs.webkit.org/show_bug.cgi?id=183657
JSTests:

Reviewed by Keith Miller.

* stress/large-unshift-splice.js: Added.
(make_contig_arr):

Source/_javascript_Core:



Reviewed by Keith Miller.

There was just a missing check in unshiftCountForIndexingType.
I've also replaced 'return false' by 'return true' in the case of an 'out-of-memory' exception, because 'return false' means 'please continue to the slow path',
and the slow path has an assert that there is no unhandled exception (line 360 of ArrayPrototype.cpp).
Finally, I made the assert in ensureLength a release assert as it would have caught this bug and prevented it from being a security risk.

* runtime/ArrayPrototype.cpp:
(JSC::unshift):
* runtime/JSArray.cpp:
(JSC::JSArray::unshiftCountWithAnyIndexingType):
* runtime/JSObject.h:
(JSC::JSObject::ensureLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-605.1.33.1-branch/JSTests/ChangeLog
branches/safari-605.1.33.1-branch/Source/_javascript_Core/ChangeLog
branches/safari-605.1.33.1-branch/Source/_javascript_Core/runtime/ArrayPrototype.cpp
branches/safari-605.1.33.1-branch/Source/_javascript_Core/runtime/JSArray.cpp
branches/safari-605.1.33.1-branch/Source/_javascript_Core/runtime/JSObject.h


Added Paths

branches/safari-605.1.33.1-branch/JSTests/stress/large-unshift-splice.js




Diff

Modified: branches/safari-605.1.33.1-branch/JSTests/ChangeLog (230607 => 230608)

--- branches/safari-605.1.33.1-branch/JSTests/ChangeLog	2018-04-12 23:27:43 UTC (rev 230607)
+++ branches/safari-605.1.33.1-branch/JSTests/ChangeLog	2018-04-12 23:27:46 UTC (rev 230608)
@@ -1,3 +1,46 @@
+2018-04-12  Kocsen Chung  
+
+Cherry-pick r230101. rdar://problem/39371537
+
+Out-of-bounds accesses due to a missing check for MAX_STORAGE_VECTOR_LENGTH in unshiftCountForAnyIndexingType
+https://bugs.webkit.org/show_bug.cgi?id=183657
+JSTests:
+
+Reviewed by Keith Miller.
+
+* stress/large-unshift-splice.js: Added.
+(make_contig_arr):
+
+Source/_javascript_Core:
+
+
+
+Reviewed by Keith Miller.
+
+There was just a missing check in unshiftCountForIndexingType.
+I've also replaced 'return false' by 'return true' in the case of an 'out-of-memory' exception, because 'return false' means 'please continue to the slow path',
+and the slow path has an assert that there is no unhandled exception (line 360 of ArrayPrototype.cpp).
+Finally, I made the assert in ensureLength a release assert as it would have caught this bug and prevented it from being a security risk.
+
+* runtime/ArrayPrototype.cpp:
+(JSC::unshift):
+* runtime/JSArray.cpp:
+(JSC::JSArray::unshiftCountWithAnyIndexingType):
+* runtime/JSObject.h:
+(JSC::JSObject::ensureLength):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-03-30  Robin Morisset  
+
+Out-of-bounds accesses due to a missing check for MAX_STORAGE_VECTOR_LENGTH in unshiftCountForAnyIndexingType
+https://bugs.webkit.org/show_bug.cgi?id=183657
+
+Reviewed by Keith Miller.
+
+* stress/large-unshift-splice.js: Added.
+(make_contig_arr):
+
 2018-02-21  Jason Marcell  
 
 Cherry-pick r228860. rdar://problem/37751729


Added: branches/safari-605.1.33.1-branch/JSTests/stress/large-unshift-splice.js (0 => 230608)

--- branches/safari-605.1.33.1-branch/JSTests/stress/large-unshift-splice.js	(rev 0)
+++ branches/safari-605.1.33.1-branch/JSTests/stress/large-unshift-splice.js	2018-04-12 23:27:46 UTC (rev 230608)
@@ -0,0 +1,16 @@
+//@ skip if $memoryLimited
+
+function make_contig_arr(sz)
+{
+let a = []; 
+while (a.length < sz / 8)
+a.push(3.14); 
+a.length *= 8;
+return a;
+}
+
+let ARRAY_LENGTH = 0x1000;
+let a = make_contig_arr(ARRAY_LENGTH);
+let b = make_contig_arr(0xff00);
+b.unshift(a.length-0x1, 0);
+Array.prototype.splice.apply(a, b);


Modified: branches/safari-605.1.33.1-branch/Source/_javascript_Core/ChangeLog (230607 => 230608)

--- branches/safari-605.1.33.1-branch/Source/_javascript_Core/ChangeLog	2018-04-12 23:27:43 UTC (rev 230607)
+++ branches/safari-605.1.33.1-branch/Source/_javascript_Core/ChangeLog	2018-04-12 23:27:46 UTC (rev 230608)
@@ -1,3 +1,56 @@
+2018-04-12  Kocsen Chung  
+
+Cherry-pick r230101. 

[webkit-changes] [230610] trunk/LayoutTests

[krollin]

Title: [230610] trunk/LayoutTests








Revision 230610
Author krol...@apple.com
Date 2018-04-12 16:38:19 -0700 (Thu, 12 Apr 2018)


Log Message
Address possible "CFNetwork SSLHandshake failed (-9847)" test failure.
https://bugs.webkit.org/show_bug.cgi?id=184487

Unreviewed test gardening. Mark
upgrade-redirect-https-to-http-script-in-iframe.html as no longer
flaky.

* platform/mac/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230609 => 230610)

--- trunk/LayoutTests/ChangeLog	2018-04-12 23:33:56 UTC (rev 230609)
+++ trunk/LayoutTests/ChangeLog	2018-04-12 23:38:19 UTC (rev 230610)
@@ -1,3 +1,14 @@
+2018-04-12  Keith Rollin  
+
+Address possible "CFNetwork SSLHandshake failed (-9847)" test failure.
+https://bugs.webkit.org/show_bug.cgi?id=184487
+
+Unreviewed test gardening. Mark
+upgrade-redirect-https-to-http-script-in-iframe.html as no longer
+flaky.
+
+* platform/mac/TestExpectations:
+
 2018-04-12  Daniel Bates  
 
 Content-Type not enforced for 

[webkit-changes] [230603] tags/Safari-606.1.13/Source/WebKit

[kocsen_chung]

Title: [230603] tags/Safari-606.1.13/Source/WebKit








Revision 230603
Author kocsen_ch...@apple.com
Date 2018-04-12 16:19:02 -0700 (Thu, 12 Apr 2018)


Log Message
Revert r230359. rdar://problem/39396724

Modified Paths

tags/Safari-606.1.13/Source/WebKit/ChangeLog
tags/Safari-606.1.13/Source/WebKit/Platform/IPC/Connection.h




Diff

Modified: tags/Safari-606.1.13/Source/WebKit/ChangeLog (230602 => 230603)

--- tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-12 22:32:40 UTC (rev 230602)
+++ tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-12 23:19:02 UTC (rev 230603)
@@ -1,5 +1,9 @@
 2018-04-12  Kocsen Chung  
 
+Revert r230359. rdar://problem/39396724
+
+2018-04-12  Kocsen Chung  
+
 Cherry-pick r230560. rdar://problem/39025726
 
 [iOS] Add a mechanism for holding Wi-Fi assertions


Modified: tags/Safari-606.1.13/Source/WebKit/Platform/IPC/Connection.h (230602 => 230603)

--- tags/Safari-606.1.13/Source/WebKit/Platform/IPC/Connection.h	2018-04-12 22:32:40 UTC (rev 230602)
+++ tags/Safari-606.1.13/Source/WebKit/Platform/IPC/Connection.h	2018-04-12 23:19:02 UTC (rev 230603)
@@ -32,7 +32,6 @@
 #include "Encoder.h"
 #include "HandleMessage.h"
 #include "MessageReceiver.h"
-#include 
 #include 
 #include 
 #include 
@@ -388,9 +387,6 @@
 {
 COMPILE_ASSERT(T::isSync, SyncMessageExpected);
 
-RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(sendSyncOptions.contains(SendSyncOption::DoNotProcessIncomingMessagesWhenWaitingForSyncReply)
-|| WebCore::ScriptDisallowedScope::isEventAllowedInMainThread());
-
 uint64_t syncRequestID = 0;
 std::unique_ptr encoder = createSyncMessageEncoder(T::receiverName(), T::name(), destinationID, syncRequestID);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230612] trunk/LayoutTests

[krollin]

Title: [230612] trunk/LayoutTests








Revision 230612
Author krol...@apple.com
Date 2018-04-12 16:41:41 -0700 (Thu, 12 Apr 2018)


Log Message
[mac-wk2] LayoutTest http/tests/security/anchor-download-allow-data.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=161745


Unreviewed test gardening. Re-enable this test now that it is
consistently passing.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230611 => 230612)

--- trunk/LayoutTests/ChangeLog	2018-04-12 23:40:22 UTC (rev 230611)
+++ trunk/LayoutTests/ChangeLog	2018-04-12 23:41:41 UTC (rev 230612)
@@ -1,5 +1,16 @@
 2018-04-12  Keith Rollin  
 
+[mac-wk2] LayoutTest http/tests/security/anchor-download-allow-data.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=161745
+
+
+Unreviewed test gardening. Re-enable this test now that it is
+consistently passing.
+
+* platform/mac-wk2/TestExpectations:
+
+2018-04-12  Keith Rollin  
+
 REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/cross-origin-plugin-allowed.html is a flaky failure
 https://bugs.webkit.org/show_bug.cgi?id=161539
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (230611 => 230612)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-12 23:40:22 UTC (rev 230611)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-12 23:41:41 UTC (rev 230612)
@@ -626,8 +626,6 @@
 
 webkit.org/b/162524 [ Sierra Release ] http/tests/cache/disk-cache/disk-cache-redirect.html [ Pass Timeout ]
 
-webkit.org/b/161745 http/tests/security/anchor-download-allow-data.html [ Pass Failure ]
-
 webkit.org/b/161926 storage/indexeddb/index-cursor.html [ Pass Timeout ]
 
 webkit.org/b/162685  http/tests/cache/disk-cache/disk-cache-204-status-code.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230615] tags/Safari-606.1.13/Source/WebKit

[kocsen_chung]

Title: [230615] tags/Safari-606.1.13/Source/WebKit








Revision 230615
Author kocsen_ch...@apple.com
Date 2018-04-12 17:02:48 -0700 (Thu, 12 Apr 2018)


Log Message
Cherry-pick r230609. rdar://problem/39398181

Fix the MOBILE_WIFI build
https://bugs.webkit.org/show_bug.cgi?id=184571
-and corresponding-


Reviewed by Jer Noble.

* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

tags/Safari-606.1.13/Source/WebKit/ChangeLog
tags/Safari-606.1.13/Source/WebKit/config.h




Diff

Modified: tags/Safari-606.1.13/Source/WebKit/ChangeLog (230614 => 230615)

--- tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-13 00:02:46 UTC (rev 230614)
+++ tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-13 00:02:48 UTC (rev 230615)
@@ -1,5 +1,33 @@
 2018-04-12  Kocsen Chung  
 
+Cherry-pick r230609. rdar://problem/39398181
+
+Fix the MOBILE_WIFI build
+https://bugs.webkit.org/show_bug.cgi?id=184571
+-and corresponding-
+
+
+Reviewed by Jer Noble.
+
+* config.h:
+
+
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-04-12  Beth Dakin  
+
+Fix the MOBILE_WIFI build
+https://bugs.webkit.org/show_bug.cgi?id=184571
+-and corresponding-
+
+
+Reviewed by Jer Noble.
+
+* config.h:
+
+2018-04-12  Kocsen Chung  
+
 Cherry-pick r230606. rdar://problem/39386359
 
 Use -iframework to ensure that frameworks from user paths and system paths are 


Modified: tags/Safari-606.1.13/Source/WebKit/config.h (230614 => 230615)

--- tags/Safari-606.1.13/Source/WebKit/config.h	2018-04-13 00:02:46 UTC (rev 230614)
+++ tags/Safari-606.1.13/Source/WebKit/config.h	2018-04-13 00:02:48 UTC (rev 230615)
@@ -126,7 +126,7 @@
 #endif
 
 #ifndef HAVE_MOBILE_WIFI
-#if PLATFORM(IOS) && !TARGET_OS_SIMULATOR && USE(APPLE_INTERNAL_SDK)
+#if PLATFORM(IOS) && !TARGET_OS_SIMULATOR && !ENABLE(MINIMAL_SIMULATOR) && USE(APPLE_INTERNAL_SDK)
 #define HAVE_MOBILE_WIFI 1
 #else
 #define HAVE_MOBILE_WIFI 0






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230611] trunk/LayoutTests

[krollin]

Title: [230611] trunk/LayoutTests








Revision 230611
Author krol...@apple.com
Date 2018-04-12 16:40:22 -0700 (Thu, 12 Apr 2018)


Log Message
REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/cross-origin-plugin-allowed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=161539


Unreviewed test gardening. Re-enabled this test. It passes in local
testing and the flakiness dashboard doesn't show any problems with it.

* platform/mac-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230610 => 230611)

--- trunk/LayoutTests/ChangeLog	2018-04-12 23:38:19 UTC (rev 230610)
+++ trunk/LayoutTests/ChangeLog	2018-04-12 23:40:22 UTC (rev 230611)
@@ -1,5 +1,16 @@
 2018-04-12  Keith Rollin  
 
+REGRESSION: [mac-wk2 release] LayoutTest http/tests/security/cross-origin-plugin-allowed.html is a flaky failure
+https://bugs.webkit.org/show_bug.cgi?id=161539
+
+
+Unreviewed test gardening. Re-enabled this test. It passes in local
+testing and the flakiness dashboard doesn't show any problems with it.
+
+* platform/mac-wk2/TestExpectations:
+
+2018-04-12  Keith Rollin  
+
 Address possible "CFNetwork SSLHandshake failed (-9847)" test failure.
 https://bugs.webkit.org/show_bug.cgi?id=184487
 


Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (230610 => 230611)

--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-12 23:38:19 UTC (rev 230610)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-04-12 23:40:22 UTC (rev 230611)
@@ -615,8 +615,6 @@
 
 webkit.org/b/161633 [ Debug ] storage/indexeddb/objectstore-cursor.html [ Pass Timeout ]
 
-webkit.org/b/161539 [ Release ] http/tests/security/cross-origin-plugin-allowed.html [ Pass Failure ]
-
 webkit.org/b/161742 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/keyorder.htm [ Pass Failure ]
 
 webkit.org/b/161547 [ Debug ] tiled-drawing/scrolling/fixed/four-bars-zoomed.html [ Pass Failure ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230616] trunk/Source/WebCore

[dbates]

Title: [230616] trunk/Source/WebCore








Revision 230616
Author dba...@webkit.org
Date 2018-04-12 17:11:06 -0700 (Thu, 12 Apr 2018)


Log Message
Attmept to fix the Windows build following 
(https://bugs.webkit.org/show_bug.cgi?id=184386)

Visual Studio cannot prove that all cases in the switch are covered :(
So, add an ASSERT_NOT_REACHED() and a return a value outside of the switch block.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::destinationForType):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230615 => 230616)

--- trunk/Source/WebCore/ChangeLog	2018-04-13 00:02:48 UTC (rev 230615)
+++ trunk/Source/WebCore/ChangeLog	2018-04-13 00:11:06 UTC (rev 230616)
@@ -1,3 +1,14 @@
+2018-04-12  Daniel Bates  
+
+Attmept to fix the Windows build following 
+(https://bugs.webkit.org/show_bug.cgi?id=184386)
+
+Visual Studio cannot prove that all cases in the switch are covered :(
+So, add an ASSERT_NOT_REACHED() and a return a value outside of the switch block. 
+
+* loader/cache/CachedResourceLoader.cpp:
+(WebCore::destinationForType):
+
 2018-04-12  Chris Dumez  
 
 Introduce remote variants of Frame / DOMWindow classes


Modified: trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp (230615 => 230616)

--- trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2018-04-13 00:02:48 UTC (rev 230615)
+++ trunk/Source/WebCore/loader/cache/CachedResourceLoader.cpp	2018-04-13 00:11:06 UTC (rev 230616)
@@ -766,6 +766,8 @@
 // The caller is responsible for setting the appropriate destination.
 return FetchOptions::Destination::EmptyString;
 }
+ASSERT_NOT_REACHED();
+return FetchOptions::Destination::EmptyString;
 }
 
 ResourceErrorOr CachedResourceLoader::requestResource(CachedResource::Type type, CachedResourceRequest&& request, ForPreload forPreload, DeferOption defer)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230619] trunk/Source/WebCore

[commit-queue]

Title: [230619] trunk/Source/WebCore








Revision 230619
Author commit-qu...@webkit.org
Date 2018-04-12 18:27:54 -0700 (Thu, 12 Apr 2018)


Log Message
[Curl] Cookie Database on memory path should be :memory:
https://bugs.webkit.org/show_bug.cgi?id=184572

Patch by Christopher Reid  on 2018-04-12
Reviewed by Alex Christensen.

CookieJarDB::isOnMemory is comparing the database path with :onmemory: but it should be using :memory:
For reference, see: https://www.sqlite.org/inmemorydb.html

* platform/network/curl/CookieJarDB.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CookieJarDB.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (230618 => 230619)

--- trunk/Source/WebCore/ChangeLog	2018-04-13 01:09:50 UTC (rev 230618)
+++ trunk/Source/WebCore/ChangeLog	2018-04-13 01:27:54 UTC (rev 230619)
@@ -1,3 +1,15 @@
+2018-04-12  Christopher Reid  
+
+[Curl] Cookie Database on memory path should be :memory:
+https://bugs.webkit.org/show_bug.cgi?id=184572
+
+Reviewed by Alex Christensen.
+
+CookieJarDB::isOnMemory is comparing the database path with :onmemory: but it should be using :memory:
+For reference, see: https://www.sqlite.org/inmemorydb.html
+
+* platform/network/curl/CookieJarDB.h:
+
 2018-04-12  Daniel Bates  
 
 Attmept to fix the Windows build following 


Modified: trunk/Source/WebCore/platform/network/curl/CookieJarDB.h (230618 => 230619)

--- trunk/Source/WebCore/platform/network/curl/CookieJarDB.h	2018-04-13 01:09:50 UTC (rev 230618)
+++ trunk/Source/WebCore/platform/network/curl/CookieJarDB.h	2018-04-13 01:27:54 UTC (rev 230619)
@@ -62,7 +62,7 @@
 
 bool m_detectedDatabaseCorruption {false};
 
-bool isOnMemory() const { return (m_databasePath == ":onmemory:"); };
+bool isOnMemory() const { return (m_databasePath == ":memory:"); };
 
 bool openDatabase();
 void closeDatabase();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230617] tags/Safari-606.1.13/Source

[kocsen_chung]

Title: [230617] tags/Safari-606.1.13/Source








Revision 230617
Author kocsen_ch...@apple.com
Date 2018-04-12 17:33:26 -0700 (Thu, 12 Apr 2018)


Log Message
Revert r230521. rdar://problem/39399564

Modified Paths

tags/Safari-606.1.13/Source/WebCore/ChangeLog
tags/Safari-606.1.13/Source/WebCore/page/RuntimeEnabledFeatures.h
tags/Safari-606.1.13/Source/WebKit/ChangeLog
tags/Safari-606.1.13/Source/WebKit/Shared/WebPreferences.yaml




Diff

Modified: tags/Safari-606.1.13/Source/WebCore/ChangeLog (230616 => 230617)

--- tags/Safari-606.1.13/Source/WebCore/ChangeLog	2018-04-13 00:11:06 UTC (rev 230616)
+++ tags/Safari-606.1.13/Source/WebCore/ChangeLog	2018-04-13 00:33:26 UTC (rev 230617)
@@ -1,3 +1,7 @@
+2018-04-12  Kocsen Chung  
+
+Revert r230521. rdar://problem/39399564
+
 2018-04-11  Antoine Quint  
 
 [Web Animations] Turn Web Animations on by default


Modified: tags/Safari-606.1.13/Source/WebCore/page/RuntimeEnabledFeatures.h (230616 => 230617)

--- tags/Safari-606.1.13/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-04-13 00:11:06 UTC (rev 230616)
+++ tags/Safari-606.1.13/Source/WebCore/page/RuntimeEnabledFeatures.h	2018-04-13 00:33:26 UTC (rev 230617)
@@ -336,7 +336,7 @@
 bool m_isWritableStreamAPIEnabled { false };
 #endif
 
-bool m_areWebAnimationsEnabled { true };
+bool m_areWebAnimationsEnabled { false };
 bool m_areCSSAnimationsAndCSSTransitionsBackedByWebAnimationsEnabled { false };
 
 #if ENABLE(WEBGL2)


Modified: tags/Safari-606.1.13/Source/WebKit/ChangeLog (230616 => 230617)

--- tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-13 00:11:06 UTC (rev 230616)
+++ tags/Safari-606.1.13/Source/WebKit/ChangeLog	2018-04-13 00:33:26 UTC (rev 230617)
@@ -1,5 +1,9 @@
 2018-04-12  Kocsen Chung  
 
+Revert r230521. rdar://problem/39399564
+
+2018-04-12  Kocsen Chung  
+
 Cherry-pick r230609. rdar://problem/39398181
 
 Fix the MOBILE_WIFI build


Modified: tags/Safari-606.1.13/Source/WebKit/Shared/WebPreferences.yaml (230616 => 230617)

--- tags/Safari-606.1.13/Source/WebKit/Shared/WebPreferences.yaml	2018-04-13 00:11:06 UTC (rev 230616)
+++ tags/Safari-606.1.13/Source/WebKit/Shared/WebPreferences.yaml	2018-04-13 00:33:26 UTC (rev 230617)
@@ -1173,7 +1173,7 @@
 
 WebAnimationsEnabled:
   type: bool
-  defaultValue: true
+  defaultValue: false
   humanReadableName: "Web Animations"
   humanReadableDescription: "Web Animations prototype"
   category: experimental






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230605] branches/safari-605.1.33.0-branch

[kocsen_chung]

Title: [230605] branches/safari-605.1.33.0-branch








Revision 230605
Author kocsen_ch...@apple.com
Date 2018-04-12 16:21:46 -0700 (Thu, 12 Apr 2018)


Log Message
Cherry-pick r230101. rdar://problem/39355291

Out-of-bounds accesses due to a missing check for MAX_STORAGE_VECTOR_LENGTH in unshiftCountForAnyIndexingType
https://bugs.webkit.org/show_bug.cgi?id=183657
JSTests:

Reviewed by Keith Miller.

* stress/large-unshift-splice.js: Added.
(make_contig_arr):

Source/_javascript_Core:



Reviewed by Keith Miller.

There was just a missing check in unshiftCountForIndexingType.
I've also replaced 'return false' by 'return true' in the case of an 'out-of-memory' exception, because 'return false' means 'please continue to the slow path',
and the slow path has an assert that there is no unhandled exception (line 360 of ArrayPrototype.cpp).
Finally, I made the assert in ensureLength a release assert as it would have caught this bug and prevented it from being a security risk.

* runtime/ArrayPrototype.cpp:
(JSC::unshift):
* runtime/JSArray.cpp:
(JSC::JSArray::unshiftCountWithAnyIndexingType):
* runtime/JSObject.h:
(JSC::JSObject::ensureLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

branches/safari-605.1.33.0-branch/JSTests/ChangeLog
branches/safari-605.1.33.0-branch/Source/_javascript_Core/ChangeLog
branches/safari-605.1.33.0-branch/Source/_javascript_Core/runtime/ArrayPrototype.cpp
branches/safari-605.1.33.0-branch/Source/_javascript_Core/runtime/JSArray.cpp
branches/safari-605.1.33.0-branch/Source/_javascript_Core/runtime/JSObject.h


Added Paths

branches/safari-605.1.33.0-branch/JSTests/stress/large-unshift-splice.js




Diff

Modified: branches/safari-605.1.33.0-branch/JSTests/ChangeLog (230604 => 230605)

--- branches/safari-605.1.33.0-branch/JSTests/ChangeLog	2018-04-12 23:21:42 UTC (rev 230604)
+++ branches/safari-605.1.33.0-branch/JSTests/ChangeLog	2018-04-12 23:21:46 UTC (rev 230605)
@@ -1,3 +1,46 @@
+2018-04-12  Kocsen Chung  
+
+Cherry-pick r230101. rdar://problem/39355291
+
+Out-of-bounds accesses due to a missing check for MAX_STORAGE_VECTOR_LENGTH in unshiftCountForAnyIndexingType
+https://bugs.webkit.org/show_bug.cgi?id=183657
+JSTests:
+
+Reviewed by Keith Miller.
+
+* stress/large-unshift-splice.js: Added.
+(make_contig_arr):
+
+Source/_javascript_Core:
+
+
+
+Reviewed by Keith Miller.
+
+There was just a missing check in unshiftCountForIndexingType.
+I've also replaced 'return false' by 'return true' in the case of an 'out-of-memory' exception, because 'return false' means 'please continue to the slow path',
+and the slow path has an assert that there is no unhandled exception (line 360 of ArrayPrototype.cpp).
+Finally, I made the assert in ensureLength a release assert as it would have caught this bug and prevented it from being a security risk.
+
+* runtime/ArrayPrototype.cpp:
+(JSC::unshift):
+* runtime/JSArray.cpp:
+(JSC::JSArray::unshiftCountWithAnyIndexingType):
+* runtime/JSObject.h:
+(JSC::JSObject::ensureLength):
+
+git-svn-id: https://svn.webkit.org/repository/webkit/trunk@230101 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+2018-03-30  Robin Morisset  
+
+Out-of-bounds accesses due to a missing check for MAX_STORAGE_VECTOR_LENGTH in unshiftCountForAnyIndexingType
+https://bugs.webkit.org/show_bug.cgi?id=183657
+
+Reviewed by Keith Miller.
+
+* stress/large-unshift-splice.js: Added.
+(make_contig_arr):
+
 2018-02-21  Jason Marcell  
 
 Cherry-pick r228860. rdar://problem/37751729


Added: branches/safari-605.1.33.0-branch/JSTests/stress/large-unshift-splice.js (0 => 230605)

--- branches/safari-605.1.33.0-branch/JSTests/stress/large-unshift-splice.js	(rev 0)
+++ branches/safari-605.1.33.0-branch/JSTests/stress/large-unshift-splice.js	2018-04-12 23:21:46 UTC (rev 230605)
@@ -0,0 +1,16 @@
+//@ skip if $memoryLimited
+
+function make_contig_arr(sz)
+{
+let a = []; 
+while (a.length < sz / 8)
+a.push(3.14); 
+a.length *= 8;
+return a;
+}
+
+let ARRAY_LENGTH = 0x1000;
+let a = make_contig_arr(ARRAY_LENGTH);
+let b = make_contig_arr(0xff00);
+b.unshift(a.length-0x1, 0);
+Array.prototype.splice.apply(a, b);


Modified: branches/safari-605.1.33.0-branch/Source/_javascript_Core/ChangeLog (230604 => 230605)

--- branches/safari-605.1.33.0-branch/Source/_javascript_Core/ChangeLog	2018-04-12 23:21:42 UTC (rev 230604)
+++ branches/safari-605.1.33.0-branch/Source/_javascript_Core/ChangeLog	2018-04-12 23:21:46 UTC (rev 230605)
@@ -1,3 +1,56 @@
+2018-04-12  Kocsen Chung  
+
+Cherry-pick r230101. 

[webkit-changes] [230622] trunk/Tools

[zalan]

Title: [230622] trunk/Tools








Revision 230622
Author za...@apple.com
Date 2018-04-12 22:27:52 -0700 (Thu, 12 Apr 2018)


Log Message
[LayoutReloaded] Add support for incremental layout
https://bugs.webkit.org/show_bug.cgi?id=184578

Reviewed by Antti Koivisto.

* LayoutReloaded/Layout.js:
(layout):
* LayoutReloaded/LayoutState.js:
(LayoutState.prototype.rootContainer):
(LayoutState.prototype.setNeedsLayoutById):
* LayoutReloaded/Utils.js:
(Utils.layoutTreeDump):
* LayoutReloaded/test/TestHarness.js:
(verifyLayout):
(runLayout):
(verifyLayoutTreeDump): Deleted.
* LayoutReloaded/test/index.html:
* LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/Layout.js
trunk/Tools/LayoutReloaded/LayoutState.js
trunk/Tools/LayoutReloaded/Utils.js
trunk/Tools/LayoutReloaded/test/TestHarness.js
trunk/Tools/LayoutReloaded/test/index.html


Added Paths

trunk/Tools/LayoutReloaded/test/simple-incremental-layout-with-static-content.html




Diff

Modified: trunk/Tools/ChangeLog (230621 => 230622)

--- trunk/Tools/ChangeLog	2018-04-13 03:09:03 UTC (rev 230621)
+++ trunk/Tools/ChangeLog	2018-04-13 05:27:52 UTC (rev 230622)
@@ -1,5 +1,26 @@
 2018-04-12  Zalan Bujtas  
 
+[LayoutReloaded] Add support for incremental layout
+https://bugs.webkit.org/show_bug.cgi?id=184578
+
+Reviewed by Antti Koivisto.
+
+* LayoutReloaded/Layout.js:
+(layout):
+* LayoutReloaded/LayoutState.js:
+(LayoutState.prototype.rootContainer):
+(LayoutState.prototype.setNeedsLayoutById):
+* LayoutReloaded/Utils.js:
+(Utils.layoutTreeDump):
+* LayoutReloaded/test/TestHarness.js:
+(verifyLayout):
+(runLayout):
+(verifyLayoutTreeDump): Deleted.
+* LayoutReloaded/test/index.html:
+* LayoutReloaded/test/simple-incremental-layout-with-static-content.html: Added.
+
+2018-04-12  Zalan Bujtas  
+
 [LayoutReloaded] Move root container ownership to layout state
 https://bugs.webkit.org/show_bug.cgi?id=184575
 


Modified: trunk/Tools/LayoutReloaded/Layout.js (230621 => 230622)

--- trunk/Tools/LayoutReloaded/Layout.js	2018-04-13 03:09:03 UTC (rev 230621)
+++ trunk/Tools/LayoutReloaded/Layout.js	2018-04-13 05:27:52 UTC (rev 230622)
@@ -23,12 +23,18 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-function layout(window, viewportSize) {
-let treeBuilder = new TreeBuilder();
-let initialContainingBlock = treeBuilder.createTree(window.document, window.renderTreeStructure);
-let displayBox = new Display.Box();
-displayBox.setSize(viewportSize);
-let layoutState = new LayoutState(initialContainingBlock, displayBox);
-layoutState.formattingContext(initialContainingBlock).layout();
-return Utils.layoutTreeDump(initialContainingBlock, layoutState);
+function layout(window, viewportSize, layoutState) {
+let rootContainer = null;
+if (layoutState)
+rootContainer = layoutState.rootContainer();
+else {
+// This is top level layout (initial containing block, etc).
+let treeBuilder = new TreeBuilder();
+rootContainer = treeBuilder.createTree(window.document, window.renderTreeStructure);
+let displayBox = new Display.Box();
+displayBox.setSize(viewportSize);
+layoutState = new LayoutState(rootContainer, displayBox);
+}
+layoutState.formattingContext(rootContainer).layout();
+return layoutState;
 }


Modified: trunk/Tools/LayoutReloaded/LayoutState.js (230621 => 230622)

--- trunk/Tools/LayoutReloaded/LayoutState.js	2018-04-13 03:09:03 UTC (rev 230621)
+++ trunk/Tools/LayoutReloaded/LayoutState.js	2018-04-13 05:27:52 UTC (rev 230622)
@@ -36,6 +36,10 @@
 return this._formattingContext(this.establishedFormattingState(formattingRoot));
 }
 
+rootContainer() {
+return this.m_rootContainer;
+}
+
 establishedFormattingState(formattingRoot) {
 ASSERT(formattingRoot.establishesFormattingContext());
 let formattingState = this.m_formattingStates.get(formattingRoot);
@@ -57,6 +61,10 @@
 return null;
 }
 
+// This is for testing only.
+setNeedsLayoutById(layoutBoxId) {
+}
+
 setNeedsLayout(layoutBox) {
 let formattingState = this.formattingStateForBox(layoutBox);
 // Newly created formatting state will obviously mark all the boxes dirty.


Modified: trunk/Tools/LayoutReloaded/Utils.js (230621 => 230622)

--- trunk/Tools/LayoutReloaded/Utils.js	2018-04-13 03:09:03 UTC (rev 230621)
+++ trunk/Tools/LayoutReloaded/Utils.js	2018-04-13 05:27:52 UTC (rev 230622)
@@ -549,8 +549,8 @@
 }
 
 // "RenderView at (0,0) size 1317x366\n HTML RenderBlock at (0,0) size 1317x116\n  BODY RenderBody at (8,8) size 1301x100\n   DIV RenderBlock at (0,0) size 100x100\n";
-static 

[webkit-changes] [230621] trunk/Tools

[zalan]

Title: [230621] trunk/Tools








Revision 230621
Author za...@apple.com
Date 2018-04-12 20:09:03 -0700 (Thu, 12 Apr 2018)


Log Message
[LayoutReloaded] Move root container ownership to layout state
https://bugs.webkit.org/show_bug.cgi?id=184575

Reviewed by Antti Koivisto.

Now the root container is on the associated layout state (ICB only at this point though).

* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
(BlockFormattingContext.prototype.layout):
* LayoutReloaded/FormattingContext/FormattingContext.js:
(FormattingContext.prototype._layoutOutOfFlowDescendants):
* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
(InlineFormattingContext.prototype._handleInlineBlockContainer):
(InlineFormattingContext.prototype._handleFloatingBox):
* LayoutReloaded/Layout.js:
(layout):
* LayoutReloaded/LayoutState.js:
(LayoutState):
(LayoutState.prototype.formattingContext):
(LayoutState.prototype.establishedFormattingState):
(LayoutState.prototype.formattingStateForBox):
(LayoutState.prototype.needsLayout):
(LayoutState.prototype.displayBox):
(LayoutState.prototype._formattingContext):
(LayoutState.prototype.layout): Deleted.
(LayoutState.prototype.formattingStates): Deleted.
(LayoutState.prototype.initialDisplayBox): Deleted.
* LayoutReloaded/Utils.js:
(Utils._dumpBox):
(Utils._findDisplayBox): Deleted.

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js
trunk/Tools/LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js
trunk/Tools/LayoutReloaded/Layout.js
trunk/Tools/LayoutReloaded/LayoutState.js
trunk/Tools/LayoutReloaded/Utils.js




Diff

Modified: trunk/Tools/ChangeLog (230620 => 230621)

--- trunk/Tools/ChangeLog	2018-04-13 01:56:24 UTC (rev 230620)
+++ trunk/Tools/ChangeLog	2018-04-13 03:09:03 UTC (rev 230621)
@@ -1,3 +1,36 @@
+2018-04-12  Zalan Bujtas  
+
+[LayoutReloaded] Move root container ownership to layout state
+https://bugs.webkit.org/show_bug.cgi?id=184575
+
+Reviewed by Antti Koivisto.
+
+Now the root container is on the associated layout state (ICB only at this point though).
+
+* LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js:
+(BlockFormattingContext.prototype.layout):
+* LayoutReloaded/FormattingContext/FormattingContext.js:
+(FormattingContext.prototype._layoutOutOfFlowDescendants):
+* LayoutReloaded/FormattingContext/InlineFormatting/InlineFormattingContext.js:
+(InlineFormattingContext.prototype._handleInlineBlockContainer):
+(InlineFormattingContext.prototype._handleFloatingBox):
+* LayoutReloaded/Layout.js:
+(layout):
+* LayoutReloaded/LayoutState.js:
+(LayoutState):
+(LayoutState.prototype.formattingContext):
+(LayoutState.prototype.establishedFormattingState):
+(LayoutState.prototype.formattingStateForBox):
+(LayoutState.prototype.needsLayout):
+(LayoutState.prototype.displayBox):
+(LayoutState.prototype._formattingContext):
+(LayoutState.prototype.layout): Deleted.
+(LayoutState.prototype.formattingStates): Deleted.
+(LayoutState.prototype.initialDisplayBox): Deleted.
+* LayoutReloaded/Utils.js:
+(Utils._dumpBox):
+(Utils._findDisplayBox): Deleted.
+
 2018-04-12  Jonathan Bedard  
 
 Fix --build-directory flag for run-webkit-tests


Modified: trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js (230620 => 230621)

--- trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-04-13 01:56:24 UTC (rev 230620)
+++ trunk/Tools/LayoutReloaded/FormattingContext/BlockFormatting/BlockFormattingContext.js	2018-04-13 03:09:03 UTC (rev 230621)
@@ -47,7 +47,7 @@
 this.computeWidth(layoutBox);
 this._computeStaticPosition(layoutBox);
 if (layoutBox.establishesFormattingContext()) {
-this.layoutState().layout(layoutBox);
+this.layoutState().formattingContext(layoutBox).layout();
 break;
 }
 let childToLayout = this._firstInFlowChildWithNeedsLayout(layoutBox);


Modified: trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js (230620 => 230621)

--- trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js	2018-04-13 01:56:24 UTC (rev 230620)
+++ trunk/Tools/LayoutReloaded/FormattingContext/FormattingContext.js	2018-04-13 03:09:03 UTC (rev 230621)
@@ -173,7 +173,7 @@
 for (let outOfFlowBox of outOfFlowDescendants) {
 this._addToLayoutQueue(outOfFlowBox);
 this._computeOutOfFlowWidth(outOfFlowBox);
-

[webkit-changes] [230618] trunk/Source/WebInspectorUI

[nvasilyev]

Title: [230618] trunk/Source/WebInspectorUI








Revision 230618
Author nvasil...@apple.com
Date 2018-04-12 18:09:50 -0700 (Thu, 12 Apr 2018)


Log Message
Web Inspector: Refactoring: move popover styles from JS to CSS
https://bugs.webkit.org/show_bug.cgi?id=184558

Reviewed by Brian Burg.

Introduce several CSS variables to customize popover appearance in CSS
and not _javascript_.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._waterfallPopoverContentForResource):
(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):
* UserInterface/Views/Popover.css:
(.popover):
* UserInterface/Views/Popover.js:
(WI.Popover):
(WI.Popover.prototype._drawBackground):
Replace `var` with `let`.

(WI.Popover.prototype.get backgroundStyle): Deleted.
(WI.Popover.prototype.set backgroundStyle): Deleted.
* UserInterface/Views/ResourceTimingBreakdownView.css:
(.popover.waterfall-popover):
(.waterfall-popover-content .resource-timing-breakdown):
(.waterfall-popover .resource-timing-breakdown): Deleted.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype._waterfallPopoverContentForResource):
(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):
* UserInterface/Views/Popover.css:
(.popover):
* UserInterface/Views/Popover.js:
(WI.Popover):
(WI.Popover.prototype._drawBackground):
* UserInterface/Views/ResourceTimingBreakdownView.css:
(.popover.waterfall-popover):
(.waterfall-popover-content .resource-timing-breakdown):

Modified Paths

trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js
trunk/Source/WebInspectorUI/UserInterface/Views/Popover.css
trunk/Source/WebInspectorUI/UserInterface/Views/Popover.js
trunk/Source/WebInspectorUI/UserInterface/Views/ResourceTimingBreakdownView.css




Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (230617 => 230618)

--- trunk/Source/WebInspectorUI/ChangeLog	2018-04-13 00:33:26 UTC (rev 230617)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-04-13 01:09:50 UTC (rev 230618)
@@ -1,3 +1,42 @@
+2018-04-12  Nikita Vasilyev  
+
+Web Inspector: Refactoring: move popover styles from JS to CSS
+https://bugs.webkit.org/show_bug.cgi?id=184558
+
+Reviewed by Brian Burg.
+
+Introduce several CSS variables to customize popover appearance in CSS
+and not _javascript_.
+
+* UserInterface/Views/NetworkTableContentView.js:
+(WI.NetworkTableContentView.prototype._waterfallPopoverContentForResource):
+(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):
+* UserInterface/Views/Popover.css:
+(.popover):
+* UserInterface/Views/Popover.js:
+(WI.Popover):
+(WI.Popover.prototype._drawBackground):
+Replace `var` with `let`.
+
+(WI.Popover.prototype.get backgroundStyle): Deleted.
+(WI.Popover.prototype.set backgroundStyle): Deleted.
+* UserInterface/Views/ResourceTimingBreakdownView.css:
+(.popover.waterfall-popover):
+(.waterfall-popover-content .resource-timing-breakdown):
+(.waterfall-popover .resource-timing-breakdown): Deleted.
+
+* UserInterface/Views/NetworkTableContentView.js:
+(WI.NetworkTableContentView.prototype._waterfallPopoverContentForResource):
+(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):
+* UserInterface/Views/Popover.css:
+(.popover):
+* UserInterface/Views/Popover.js:
+(WI.Popover):
+(WI.Popover.prototype._drawBackground):
+* UserInterface/Views/ResourceTimingBreakdownView.css:
+(.popover.waterfall-popover):
+(.waterfall-popover-content .resource-timing-breakdown):
+
 2018-04-07  Nikita Vasilyev  
 
 Web Inspector: Errors glyph doesn't fully change to blue when active


Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js (230617 => 230618)

--- trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js	2018-04-13 00:33:26 UTC (rev 230617)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js	2018-04-13 01:09:50 UTC (rev 230618)
@@ -1404,7 +1404,7 @@
 _waterfallPopoverContentForResource(resource)
 {
 let contentElement = document.createElement("div");
-contentElement.className = "waterfall-popover";
+contentElement.className = "waterfall-popover-content";
 
 if (!resource.hasResponse() || !resource.timingData.startTime || !resource.timingData.responseEnd) {
 contentElement.textContent = WI.UIString("Resource has no timing data");
@@ -1422,7 +1422,7 @@
 {
 if (!this._waterfallPopover) {
 this._waterfallPopover = new WI.Popover;
-this._waterfallPopover.backgroundStyle = WI.Popover.BackgroundStyle.White;
+

[webkit-changes] [230620] trunk/Source/WebCore

[commit-queue]

Title: [230620] trunk/Source/WebCore








Revision 230620
Author commit-qu...@webkit.org
Date 2018-04-12 18:56:24 -0700 (Thu, 12 Apr 2018)


Log Message
[Curl] Fix clang build error in CurlContext.cpp
https://bugs.webkit.org/show_bug.cgi?id=184561

Patch by Christopher Reid  on 2018-04-12
Reviewed by Darin Adler.

MSVC allows explicit template specialization in classes but gcc/clang do not.

* platform/network/curl/CurlContext.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/curl/CurlContext.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (230619 => 230620)

--- trunk/Source/WebCore/ChangeLog	2018-04-13 01:27:54 UTC (rev 230619)
+++ trunk/Source/WebCore/ChangeLog	2018-04-13 01:56:24 UTC (rev 230620)
@@ -1,5 +1,16 @@
 2018-04-12  Christopher Reid  
 
+[Curl] Fix clang build error in CurlContext.cpp
+https://bugs.webkit.org/show_bug.cgi?id=184561
+
+Reviewed by Darin Adler.
+
+MSVC allows explicit template specialization in classes but gcc/clang do not.
+
+* platform/network/curl/CurlContext.cpp:
+
+2018-04-12  Christopher Reid  
+
 [Curl] Cookie Database on memory path should be :memory:
 https://bugs.webkit.org/show_bug.cgi?id=184572
 


Modified: trunk/Source/WebCore/platform/network/curl/CurlContext.cpp (230619 => 230620)

--- trunk/Source/WebCore/platform/network/curl/CurlContext.cpp	2018-04-13 01:27:54 UTC (rev 230619)
+++ trunk/Source/WebCore/platform/network/curl/CurlContext.cpp	2018-04-13 01:56:24 UTC (rev 230620)
@@ -66,12 +66,14 @@
 ASSERT_NOT_REACHED();
 return nullptr;
 }
-
-// define specialized member function for specific type.
-template<> constexpr const char* sscanTemplate() { return "%d"; }
-template<> constexpr const char* sscanTemplate() { return "%u"; }
 };
 
+template<>
+constexpr const char* EnvironmentVariableReader::sscanTemplate() { return "%d"; }
+
+template<>
+constexpr const char* EnvironmentVariableReader::sscanTemplate() { return "%u"; }
+
 // CurlContext ---
 
 CurlContext& CurlContext::singleton()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230623] trunk/Source/bmalloc

[sbarati]

Title: [230623] trunk/Source/bmalloc








Revision 230623
Author sbar...@apple.com
Date 2018-04-12 23:52:36 -0700 (Thu, 12 Apr 2018)


Log Message
Lessen partial scavenge interval on x86-64
https://bugs.webkit.org/show_bug.cgi?id=184577

Rubber-stamped by Filip Pizlo.

I initially made the scavenge interval longer because I had thought the
shorter interval caused a JetStream regression. I was mistaken though.
I was looking at the wrong commit range when analyzing perf data.

This patch shortens the interval, but still keeps x86-64 50% longer than
other architectures. We know that scavenging frequently on Mac is less
important to overall system performance than it is on iOS.

* bmalloc/Scavenger.cpp:
(bmalloc::Scavenger::threadRunLoop):

Modified Paths

trunk/Source/bmalloc/ChangeLog
trunk/Source/bmalloc/bmalloc/Scavenger.cpp




Diff

Modified: trunk/Source/bmalloc/ChangeLog (230622 => 230623)

--- trunk/Source/bmalloc/ChangeLog	2018-04-13 05:27:52 UTC (rev 230622)
+++ trunk/Source/bmalloc/ChangeLog	2018-04-13 06:52:36 UTC (rev 230623)
@@ -1,5 +1,23 @@
 2018-04-12  Saam Barati  
 
+Lessen partial scavenge interval on x86-64
+https://bugs.webkit.org/show_bug.cgi?id=184577
+
+Rubber-stamped by Filip Pizlo.
+
+I initially made the scavenge interval longer because I had thought the
+shorter interval caused a JetStream regression. I was mistaken though.
+I was looking at the wrong commit range when analyzing perf data.
+
+This patch shortens the interval, but still keeps x86-64 50% longer than
+other architectures. We know that scavenging frequently on Mac is less
+important to overall system performance than it is on iOS.
+
+* bmalloc/Scavenger.cpp:
+(bmalloc::Scavenger::threadRunLoop):
+
+2018-04-12  Saam Barati  
+
 Raise the partial scavenge interval even more on x86-64
 https://bugs.webkit.org/show_bug.cgi?id=184551
 


Modified: trunk/Source/bmalloc/bmalloc/Scavenger.cpp (230622 => 230623)

--- trunk/Source/bmalloc/bmalloc/Scavenger.cpp	2018-04-13 05:27:52 UTC (rev 230622)
+++ trunk/Source/bmalloc/bmalloc/Scavenger.cpp	2018-04-13 06:52:36 UTC (rev 230623)
@@ -408,7 +408,7 @@
 }
 
 #if BCPU(X86_64)
-auto partialScavengeInterval = std::chrono::milliseconds(36000);
+auto partialScavengeInterval = std::chrono::milliseconds(12000);
 #else
 auto partialScavengeInterval = std::chrono::milliseconds(8000);
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230626] trunk/Source/JavaScriptCore

[utatane . tea]

Title: [230626] trunk/Source/_javascript_Core








Revision 230626
Author utatane@gmail.com
Date 2018-04-13 02:05:52 -0700 (Fri, 13 Apr 2018)


Log Message
[DFG] Remove duplicate 32bit ProfileType implementation
https://bugs.webkit.org/show_bug.cgi?id=184536

Reviewed by Saam Barati.

This patch removes duplicate 32bit ProfileType implementation by unifying 32/64 implementations.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileProfileType):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::branchIfUndefined):
(JSC::AssemblyHelpers::branchIfNull):

Modified Paths

trunk/Source/_javascript_Core/ChangeLog
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.h
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT32_64.cpp
trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT64.cpp
trunk/Source/_javascript_Core/jit/AssemblyHelpers.h




Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (230625 => 230626)

--- trunk/Source/_javascript_Core/ChangeLog	2018-04-13 08:50:42 UTC (rev 230625)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-04-13 09:05:52 UTC (rev 230626)
@@ -1,3 +1,23 @@
+2018-04-13  Yusuke Suzuki  
+
+[DFG] Remove duplicate 32bit ProfileType implementation
+https://bugs.webkit.org/show_bug.cgi?id=184536
+
+Reviewed by Saam Barati.
+
+This patch removes duplicate 32bit ProfileType implementation by unifying 32/64 implementations.
+
+* dfg/DFGSpeculativeJIT.cpp:
+(JSC::DFG::SpeculativeJIT::compileProfileType):
+* dfg/DFGSpeculativeJIT.h:
+* dfg/DFGSpeculativeJIT32_64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* dfg/DFGSpeculativeJIT64.cpp:
+(JSC::DFG::SpeculativeJIT::compile):
+* jit/AssemblyHelpers.h:
+(JSC::AssemblyHelpers::branchIfUndefined):
+(JSC::AssemblyHelpers::branchIfNull):
+
 2018-04-12  Mark Lam  
 
 Consolidate some PtrTags.


Modified: trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp (230625 => 230626)

--- trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-04-13 08:50:42 UTC (rev 230625)
+++ trunk/Source/_javascript_Core/dfg/DFGSpeculativeJIT.cpp	2018-04-13 09:05:52 UTC (rev 230626)
@@ -61,6 +61,7 @@
 #include "ScopedArguments.h"
 #include "ScratchRegisterAllocator.h"
 #include "SuperSampler.h"
+#include "TypeProfilerLog.h"
 #include "WeakMapImpl.h"
 #include 
 #include 
@@ -12796,6 +12797,76 @@
 jsValueResult(resultRegs, node);
 }
 
+void SpeculativeJIT::compileProfileType(Node* node)
+{
+JSValueOperand value(this, node->child1());
+GPRTemporary scratch1(this);
+GPRTemporary scratch2(this);
+GPRTemporary scratch3(this);
+
+JSValueRegs valueRegs = value.jsValueRegs();
+GPRReg scratch1GPR = scratch1.gpr();
+GPRReg scratch2GPR = scratch2.gpr();
+GPRReg scratch3GPR = scratch3.gpr();
+
+MacroAssembler::JumpList jumpToEnd;
+
+jumpToEnd.append(m_jit.branchIfEmpty(valueRegs));
+
+TypeLocation* cachedTypeLocation = node->typeLocation();
+// Compile in a predictive type check, if possible, to see if we can skip writing to the log.
+// These typechecks are inlined to match those of the 64-bit JSValue type checks.
+if (cachedTypeLocation->m_lastSeenType == TypeUndefined)
+jumpToEnd.append(m_jit.branchIfUndefined(valueRegs));
+else if (cachedTypeLocation->m_lastSeenType == TypeNull)
+jumpToEnd.append(m_jit.branchIfNull(valueRegs));
+else if (cachedTypeLocation->m_lastSeenType == TypeBoolean)
+jumpToEnd.append(m_jit.branchIfBoolean(valueRegs, scratch1GPR));
+else if (cachedTypeLocation->m_lastSeenType == TypeAnyInt)
+jumpToEnd.append(m_jit.branchIfInt32(valueRegs));
+else if (cachedTypeLocation->m_lastSeenType == TypeNumber)
+jumpToEnd.append(m_jit.branchIfNumber(valueRegs, scratch1GPR));
+else if (cachedTypeLocation->m_lastSeenType == TypeString) {
+MacroAssembler::Jump isNotCell = m_jit.branchIfNotCell(valueRegs);
+jumpToEnd.append(m_jit.branchIfString(valueRegs.payloadGPR()));
+isNotCell.link(_jit);
+}
+
+// Load the TypeProfilerLog into Scratch2.
+TypeProfilerLog* cachedTypeProfilerLog = m_jit.vm()->typeProfilerLog();
+m_jit.move(TrustedImmPtr(cachedTypeProfilerLog), scratch2GPR);
+
+// Load the next LogEntry into Scratch1.
+m_jit.loadPtr(MacroAssembler::Address(scratch2GPR, TypeProfilerLog::currentLogEntryOffset()), scratch1GPR);
+
+// Store the JSValue onto the log entry.
+m_jit.storeValue(valueRegs, MacroAssembler::Address(scratch1GPR, TypeProfilerLog::LogEntry::valueOffset()));
+
+// Store the structureID of the cell if valueRegs is a cell, otherwise, store 0 on the log entry.
+

[webkit-changes] [230628] trunk/LayoutTests

[csaavedra]

Title: [230628] trunk/LayoutTests








Revision 230628
Author csaave...@igalia.com
Date 2018-04-13 03:27:35 -0700 (Fri, 13 Apr 2018)


Log Message
[GTK][GStreamer] Mark a few crashing tests since playbin3 was made available

Unreviewed gardening
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230627 => 230628)

--- trunk/LayoutTests/ChangeLog	2018-04-13 10:09:23 UTC (rev 230627)
+++ trunk/LayoutTests/ChangeLog	2018-04-13 10:27:35 UTC (rev 230628)
@@ -1,3 +1,10 @@
+2018-04-13  Claudio Saavedra  
+
+[GTK][GStreamer] Mark a few crashing tests since playbin3 was made available
+
+Unreviewed gardening
+* platform/gtk/TestExpectations:
+
 2018-04-12  Keith Rollin  
 
 [mac-wk2] LayoutTest http/tests/security/anchor-download-allow-data.html is a flaky failure


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (230627 => 230628)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2018-04-13 10:09:23 UTC (rev 230627)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2018-04-13 10:27:35 UTC (rev 230628)
@@ -1006,8 +1006,6 @@
 # Tests failing with GStreamer 1.6.3
 webkit.org/b/154390 http/tests/media/video-throttled-load-metadata.html [ Pass Failure ]
 webkit.org/b/154390 http/tests/media/video-redirect.html [ Timeout Pass ]
-webkit.org/b/154390 [ Release ] http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure ]
-webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure ]
 webkit.org/b/154390 [ Release ] http/tests/media/hls/hls-video-resize.html [ Timeout Failure ]
 webkit.org/b/154390 http/tests/security/local-video-source-from-remote.html [ Timeout Pass ]
 
@@ -1253,6 +1251,11 @@
 
 webkit.org/b/152043 [ Debug ] http/tests/media/hls [ Timeout Crash ]
 
+# Tests crashing since addition of playbin3 usage
+webkit.org/b/184581 http/tests/media/hls/hls-audio-tracks-locale-selection.html [ Timeout Failure Crash ]
+webkit.org/b/184581 http/tests/media/hls/hls-progress.html [ Crash ]
+webkit.org/b/184581 http/tests/media/hls/video-controller-getStartDate.html [ Timeout Failure Crash ]
+
 webkit.org/b/152642 http/tests/misc/detached-frame-console.html [ Crash Pass Timeout Failure ]
 
 webkit.org/b/153692 imported/blink/fast/css/first-letter-float-block.html [ Crash Pass ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230630] trunk/Source/WebCore

[svillar]

Title: [230630] trunk/Source/WebCore








Revision 230630
Author svil...@igalia.com
Date 2018-04-13 08:19:00 -0700 (Fri, 13 Apr 2018)


Log Message
[WebVR][OpenVR] Implement requestPresent()/exitPresent() and getLayers()
https://bugs.webkit.org/show_bug.cgi?id=184530

Reviewed by Žan Doberšek.

WebVR apps should invoke requestPresent() to start presenting contents of a VRLayerInit
(right now a HTML canvas with a WebGL context) on the VRDisplay. This request might fail for
a variety of reasons and can be eventually cancelled with exitPresent(). Once we are
presenting we could access the presenting layers (right now just one) with getLayers().

Note that we are not presenting anything to the HMD yet, that will be done later in a follow
up patch.

I took the chance to correct a mistak in the VRDisplayCapabilities object which has a method
that should be called maxLayers instead of maxLayer.

* Modules/webvr/VRDisplay.cpp:
(WebCore::VRDisplay::requestPresent):
(WebCore::VRDisplay::stopPresenting):
(WebCore::VRDisplay::exitPresent):
(WebCore::VRDisplay::getLayers const):
(WebCore::VRDisplay::isPresenting const): Deleted. Implemented in the header file.
* Modules/webvr/VRDisplay.h:
(WebCore::VRDisplay::isPresenting const):
* Modules/webvr/VRDisplayCapabilities.h:
(WebCore::VRDisplayCapabilities::maxLayers const): Renamed from maxLayer().
(WebCore::VRDisplayCapabilities::maxLayer const): Deleted.
* Modules/webvr/VRDisplayCapabilities.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp
trunk/Source/WebCore/Modules/webvr/VRDisplay.h
trunk/Source/WebCore/Modules/webvr/VRDisplayCapabilities.h
trunk/Source/WebCore/Modules/webvr/VRDisplayCapabilities.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (230629 => 230630)

--- trunk/Source/WebCore/ChangeLog	2018-04-13 13:18:29 UTC (rev 230629)
+++ trunk/Source/WebCore/ChangeLog	2018-04-13 15:19:00 UTC (rev 230630)
@@ -1,3 +1,34 @@
+2018-04-13  Sergio Villar Senin  
+
+[WebVR][OpenVR] Implement requestPresent()/exitPresent() and getLayers()
+https://bugs.webkit.org/show_bug.cgi?id=184530
+
+Reviewed by Žan Doberšek.
+
+WebVR apps should invoke requestPresent() to start presenting contents of a VRLayerInit
+(right now a HTML canvas with a WebGL context) on the VRDisplay. This request might fail for
+a variety of reasons and can be eventually cancelled with exitPresent(). Once we are
+presenting we could access the presenting layers (right now just one) with getLayers().
+
+Note that we are not presenting anything to the HMD yet, that will be done later in a follow
+up patch.
+
+I took the chance to correct a mistak in the VRDisplayCapabilities object which has a method
+that should be called maxLayers instead of maxLayer.
+
+* Modules/webvr/VRDisplay.cpp:
+(WebCore::VRDisplay::requestPresent):
+(WebCore::VRDisplay::stopPresenting):
+(WebCore::VRDisplay::exitPresent):
+(WebCore::VRDisplay::getLayers const):
+(WebCore::VRDisplay::isPresenting const): Deleted. Implemented in the header file.
+* Modules/webvr/VRDisplay.h:
+(WebCore::VRDisplay::isPresenting const):
+* Modules/webvr/VRDisplayCapabilities.h:
+(WebCore::VRDisplayCapabilities::maxLayers const): Renamed from maxLayer().
+(WebCore::VRDisplayCapabilities::maxLayer const): Deleted.
+* Modules/webvr/VRDisplayCapabilities.idl:
+
 2018-04-13  Miguel Gomez  
 
 REGRESSION(r230627): [GTK][WPE] Possible deadlock when destroying the player in non AC mode


Modified: trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp (230629 => 230630)

--- trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp	2018-04-13 13:18:29 UTC (rev 230629)
+++ trunk/Source/WebCore/Modules/webvr/VRDisplay.cpp	2018-04-13 15:19:00 UTC (rev 230630)
@@ -26,9 +26,12 @@
 #include "config.h"
 #include "VRDisplay.h"
 
+#include "CanvasRenderingContext.h"
 #include "Chrome.h"
+#include "DOMException.h"
 #include "Page.h"
 #include "ScriptedAnimationController.h"
+#include "UserGestureIndicator.h"
 #include "VRDisplayCapabilities.h"
 #include "VREyeParameters.h"
 #include "VRFrameData.h"
@@ -68,11 +71,6 @@
 return m_display->getDisplayInfo().isConnected();
 }
 
-bool VRDisplay::isPresenting() const
-{
-return false;
-}
-
 const VRDisplayCapabilities& VRDisplay::capabilities() const
 {
 return *m_capabilities;
@@ -132,20 +130,76 @@
 m_scriptedAnimationController->cancelCallback(id);
 }
 
-void VRDisplay::requestPresent(const Vector&, Ref&&)
+void VRDisplay::requestPresent(const Vector& layers, Ref&& promise)
 {
+auto rejectRequestAndStopPresenting = [this, ] (ExceptionCode exceptionCode, ASCIILiteral message) {
+promise->reject(Exception { exceptionCode, message });
+if (m_presentingLayer)
+stopPresenting();
+};
+
+if 

[webkit-changes] [230631] trunk/LayoutTests

[pvollan]

Title: [230631] trunk/LayoutTests








Revision 230631
Author pvol...@apple.com
Date 2018-04-13 08:46:15 -0700 (Fri, 13 Apr 2018)


Log Message
Mark some legacy-animation-engine tests as failures on Windows.
https://bugs.webkit.org/show_bug.cgi?id=184482

Unreviewed test gardening.

* platform/win/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/win/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (230630 => 230631)

--- trunk/LayoutTests/ChangeLog	2018-04-13 15:19:00 UTC (rev 230630)
+++ trunk/LayoutTests/ChangeLog	2018-04-13 15:46:15 UTC (rev 230631)
@@ -1,3 +1,12 @@
+2018-04-13  Per Arne Vollan  
+
+Mark some legacy-animation-engine tests as failures on Windows.
+https://bugs.webkit.org/show_bug.cgi?id=184482
+
+Unreviewed test gardening.
+
+* platform/win/TestExpectations:
+
 2018-04-13  Claudio Saavedra  
 
 [GTK][GStreamer] Mark a few crashing tests since playbin3 was made available


Modified: trunk/LayoutTests/platform/win/TestExpectations (230630 => 230631)

--- trunk/LayoutTests/platform/win/TestExpectations	2018-04-13 15:19:00 UTC (rev 230630)
+++ trunk/LayoutTests/platform/win/TestExpectations	2018-04-13 15:46:15 UTC (rev 230631)
@@ -4045,5 +4045,8 @@
 webkit.org/b/184482 legacy-animation-engine/compositing/layer-creation/translate-scale-transition-overlap.html [ Failure ]
 webkit.org/b/184482 legacy-animation-engine/compositing/layer-creation/translate-transition-overlap.html [ Failure ]
 webkit.org/b/184482 legacy-animation-engine/compositing/reflections/load-video-in-reflection.html [ Failure ]
+webkit.org/b/184482 legacy-animation-engine/animations/3d/change-transform-in-end-event.html [ Skip ]
+webkit.org/b/184482 legacy-animation-engine/compositing/reflections/animation-inside-reflection.html [ Skip ]
+webkit.org/b/184482 legacy-animation-engine/compositing/reflections/nested-reflection-animated.html [ Skip ]
 
 webkit.org/b/184537 fast/forms/file/entries-api/webkitEntries-nonascii-folder-name.html [ Skip ]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230632] trunk

[graouts]

Title: [230632] trunk








Revision 230632
Author grao...@webkit.org
Date 2018-04-13 09:02:11 -0700 (Fri, 13 Apr 2018)


Log Message
[Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default
https://bugs.webkit.org/show_bug.cgi?id=184569


Reviewed by Jon Lee.

LayoutTests/imported/w3c:

This test now fails at a later assertion, so updating the expectation for it.

* web-platform-tests/web-animations/interfaces/Animatable/animate-expected.txt:

Source/WebCore:

We now set the CSS Animations and CSS Transitions as Web Animations flag on by default. To ensure that some remaining
tests pass with this flag on, we expose a way to get to a PseudoElement via a new internals.pseudoElement() method. This
allows tests that used internals.pauseAnimationAtTimeOnPseudoElement() and internals.pauseTransitionAtTimeOnPseudoElement()
to now work with the Web Animations API.

* page/RuntimeEnabledFeatures.h:
* testing/Internals.cpp:
(WebCore::Internals::pseudoElement):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit:

* Shared/WebPreferences.yaml:

Source/WebKitLegacy/mac:

* WebView/WebPreferences.mm:

Source/WebKitLegacy/win:

Make sure Web Animations and CSS Animations and CSS Transitions are enabled by default on Windows.

* WebPreferences.cpp:

Tools:

We set the default value for the CSS Animations and CSS Transitions as Web Animations flag to true
but override it to be false always in the LayoutTests/legacy-animation-engine directory.

* DumpRenderTree/TestOptions.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(shouldOverrideAndDisableCSSAnimationsAndCSSTransitionsBackedByWebAnimationsPreference):
(runTest):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
* WebKitTestRunner/TestOptions.cpp:
(WTR::isLegacyAnimationEngineTestPath):
(WTR::TestOptions::TestOptions):
* WebKitTestRunner/TestOptions.h:

LayoutTests:

* TestExpectations: A small number of tests regressed with the flag on, so we list them and have raised
bugs to fix them ASAP.
* animations/animation-direction-alternate-reverse-expected.txt:
* animations/animation-direction-alternate-reverse.html: This test was incorrect since it assumes that at the
end active boundary time we are using the end value whereas we are using the start value. Indeed, since the
fill-mode is "none", at the end of the active time, the progress is null per the Web Animations spec.
* animations/animation-hit-test-transform.html: Stop using the internals method.
* animations/animation-internals-api-expected.txt: Removed.
* animations/animation-internals-api-multiple-keyframes-expected.txt: Removed.
* animations/animation-internals-api-multiple-keyframes.html: Removed. This test only tests an internals method
that is no longer relevant for the new animation engine, but preserved for compatibility with legacy tests.
* animations/animation-internals-api.html: Removed. This test only tests an internals method that is no longer
relevant for the new animation engine, but preserved for compatibility with legacy tests.
* animations/big-rotation-expected.txt:
* animations/big-rotation.html: Here again we are correcting a test which made the wrong assumption about the
value generated at the end active boundary time.
* animations/duplicated-keyframes-name.html: We make the animation fill forwards to check that we are using
the correct end value for an animation with multiple 100% keyframe.
* animations/fill-forwards-end-state.html: Same as previous test.
* animations/fill-mode-forwards-zero-duration-expected.txt:
* animations/fill-mode-forwards-zero-duration.html: This test should seek after its delay + duration, so we test
at 3s instead of 1s. This is due to a behavior difference between internals.pauseAnimationAtTimeOnElement() and
its replacement.
* fast/css-generated-content/pseudo-animation.html: Use internals.pseudoElement() and the Web Animations API rather
than internals.pauseAnimationAtTimeOnPseudoElement().
* fast/css-generated-content/pseudo-transition.html: Use internals.pseudoElement() and the Web Animations API rather
than internals.pauseTransitionAtTimeOnPseudoElement().
* platform/ios/TestExpectations:
* platform/win/TestExpectations: Remove references to tests that we are removing.
* transitions/remove-transition-style.html: Use document.getAnimations() to figure out how many animations are running.
* transitions/transition-drt-api-delay-expected.txt: Removed.
* transitions/transition-drt-api-delay.html: Removed. This test only tests an internals method that is no longer
relevant for the new animation engine, but preserved for compatibility with legacy tests.
* transitions/transition-drt-api-expected.txt: Removed.
* transitions/transition-drt-api.html: Removed. This test only tests an internals method that is no longer
relevant for the new animation engine, but preserved for compatibility with legacy tests.
* transitions/transition-hit-test-transform.html: Stop using 

[webkit-changes] [230633] trunk/Source/WebKit

[bfulgham]

Title: [230633] trunk/Source/WebKit








Revision 230633
Author bfulg...@apple.com
Date 2018-04-13 09:17:44 -0700 (Fri, 13 Apr 2018)


Log Message
REGRESSION(r230468): Improper assertion firing under STP


Unreviewed, rolling out an improper assertion.

I added an assertion in Bug 184322 that should not have been added. I did not notice that this
call stack was always used in builds where NSApp is still active. Builds where we stop relying
on AppKit runloops uses a different code path to shut down.

* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::stopNSAppRunLoop):

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm




Diff

Modified: trunk/Source/WebKit/ChangeLog (230632 => 230633)

--- trunk/Source/WebKit/ChangeLog	2018-04-13 16:02:11 UTC (rev 230632)
+++ trunk/Source/WebKit/ChangeLog	2018-04-13 16:17:44 UTC (rev 230633)
@@ -1,3 +1,17 @@
+2018-04-13  Brent Fulgham  
+
+REGRESSION(r230468): Improper assertion firing under STP
+
+
+Unreviewed, rolling out an improper assertion.
+
+I added an assertion in Bug 184322 that should not have been added. I did not notice that this
+call stack was always used in builds where NSApp is still active. Builds where we stop relying
+on AppKit runloops uses a different code path to shut down.
+
+* Shared/mac/ChildProcessMac.mm:
+(WebKit::ChildProcess::stopNSAppRunLoop):
+
 2018-04-12  Antoine Quint  
 
 [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default


Modified: trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm (230632 => 230633)

--- trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm	2018-04-13 16:02:11 UTC (rev 230632)
+++ trunk/Source/WebKit/Shared/mac/ChildProcessMac.mm	2018-04-13 16:17:44 UTC (rev 230633)
@@ -38,7 +38,6 @@
 #import 
 #import 
 #import 
-#import 
 #import 
 #import 
 
@@ -206,7 +205,6 @@
 void ChildProcess::stopNSAppRunLoop()
 {
 ASSERT([NSApp isRunning]);
-RELEASE_ASSERT(hasProcessPrivilege(ProcessPrivilege::CanCommunicateWithWindowServer));
 [NSApp stop:nil];
 
 NSEvent *event = [NSEvent otherEventWithType:NSEventTypeApplicationDefined location:NSMakePoint(0, 0) modifierFlags:0 timestamp:0.0 windowNumber:0 context:nil subtype:0 data1:0 data2:0];






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [230634] trunk/Tools

[mcatanzaro]

Title: [230634] trunk/Tools








Revision 230634
Author mcatanz...@igalia.com
Date 2018-04-13 09:29:08 -0700 (Fri, 13 Apr 2018)


Log Message
[WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
https://bugs.webkit.org/show_bug.cgi?id=184388

Reviewed by Carlos Alberto Lopez Perez.

Remove libxkbcommon from the JHBuild environment. We could alternatively add
xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
not believe it depends on anything else in the JHBuild environment.

* wpe/install-dependencies:
* wpe/jhbuild.modules:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/wpe/install-dependencies
trunk/Tools/wpe/jhbuild.modules




Diff

Modified: trunk/Tools/ChangeLog (230633 => 230634)

--- trunk/Tools/ChangeLog	2018-04-13 16:17:44 UTC (rev 230633)
+++ trunk/Tools/ChangeLog	2018-04-13 16:29:08 UTC (rev 230634)
@@ -1,3 +1,17 @@
+2018-04-13  Michael Catanzaro  
+
+[WPE] xkbcommon: ERROR: failed to add default include path /home/mcatanzaro/Projects/WebKit/WebKitBuild/DependenciesWPE/Root/share/X11/xkb
+https://bugs.webkit.org/show_bug.cgi?id=184388
+
+Reviewed by Carlos Alberto Lopez Perez.
+
+Remove libxkbcommon from the JHBuild environment. We could alternatively add
+xkeyboard-config, but there doesn't seem to be any need to build libxkbcommon because I do
+not believe it depends on anything else in the JHBuild environment.
+
+* wpe/install-dependencies:
+* wpe/jhbuild.modules:
+
 2018-04-12  Antoine Quint  
 
 [Web Animations] Turn CSS Animations and CSS Transitions as Web Animations on by default


Modified: trunk/Tools/wpe/install-dependencies (230633 => 230634)

--- trunk/Tools/wpe/install-dependencies	2018-04-13 16:17:44 UTC (rev 230633)
+++ trunk/Tools/wpe/install-dependencies	2018-04-13 16:29:08 UTC (rev 230634)
@@ -123,6 +123,7 @@
 libvorbis-dev \
 libvpx-dev \
 libxcb-xkb-dev \
+libxkbcommon-dev \
 libxml-libxml-perl \
 libwayland-dev \
 luajit \
@@ -209,6 +210,7 @@
 libvorbis \
 libvpx \
 libxcb \
+libxkbcommon \
 luajit \
 mesa \
 mesa-libgl \
@@ -295,6 +297,7 @@
 libvorbis-devel \
 libvpx-devel \
 libxcb-devel \
+libxkbcommon-devel \
 libXrandr-devel \
 luajit \
 luajit-devel \


Modified: trunk/Tools/wpe/jhbuild.modules (230633 => 230634)

--- trunk/Tools/wpe/jhbuild.modules	2018-04-13 16:17:44 UTC (rev 230633)
+++ trunk/Tools/wpe/jhbuild.modules	2018-04-13 16:29:08 UTC (rev 230634)
@@ -16,7 +16,6 @@
   
   
   
-  
   
   
   
@@ -41,8 +40,6 @@
   href=""
  href=""
-href=""
   @@ -165,13 +162,6 @@
 hash="sha1:c6f7b99986f93c9df78653c3e6a3b5043f65145e"/>
   
 
-  
-
-  
-
   
  tag="3013faaebab42e7ef7497b3850a2902978eb3d6f" />
@@ -181,7 +171,6 @@
 
   
   
-  
 
  tag="064c60806422ff1bb32cef7fb1de68923aecba82"/>






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes