[webkit-changes] [235421] trunk/Source/WebCore
Title: [235421] trunk/Source/WebCore
Revision 235421
Author commit-qu...@webkit.org
Date 2018-08-28 00:49:14 -0700 (Tue, 28 Aug 2018)
Log Message
Fix gcc compilation warnings after r235230
https://bugs.webkit.org/show_bug.cgi?id=188981
Patch by Alejandro G. Castro on 2018-08-28
Reviewed by Eric Carlson.
Replace the pragma clang with pragma GCC, it is understood by
clang and gcc.
* Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
* platform/mediastream/RealtimeIncomingAudioSource.h:
* platform/mediastream/RealtimeIncomingVideoSource.h:
* platform/mediastream/RealtimeOutgoingAudioSource.h:
* platform/mediastream/RealtimeOutgoingVideoSource.h:
* platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
* platform/mediastream/libwebrtc/LibWebRTCProvider.h:
* testing/MockLibWebRTCPeerConnection.h:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h
trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h
trunk/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h
trunk/Source/WebCore/platform/mediastream/RealtimeIncomingVideoSource.h
trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h
trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h
trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCAudioModule.h
trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.cpp
trunk/Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCProvider.h
trunk/Source/WebCore/testing/MockLibWebRTCPeerConnection.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (235420 => 235421)
--- trunk/Source/WebCore/ChangeLog 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/ChangeLog 2018-08-28 07:49:14 UTC (rev 235421)
@@ -1,3 +1,24 @@
+2018-08-28 Alejandro G. Castro
+
+Fix gcc compilation warnings after r235230
+https://bugs.webkit.org/show_bug.cgi?id=188981
+
+Reviewed by Eric Carlson.
+
+Replace the pragma clang with pragma GCC, it is understood by
+clang and gcc.
+
+* Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h:
+* Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
+* platform/mediastream/RealtimeIncomingAudioSource.h:
+* platform/mediastream/RealtimeIncomingVideoSource.h:
+* platform/mediastream/RealtimeOutgoingAudioSource.h:
+* platform/mediastream/RealtimeOutgoingVideoSource.h:
+* platform/mediastream/libwebrtc/LibWebRTCAudioModule.h:
+* platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
+* platform/mediastream/libwebrtc/LibWebRTCProvider.h:
+* testing/MockLibWebRTCPeerConnection.h:
+
2018-08-27 Justin Fan
WebGL 2 conformance: framebuffer-test
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h (235420 => 235421)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCDataChannelHandler.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -29,12 +29,12 @@
#include "LibWebRTCMacros.h"
#include "RTCDataChannelHandler.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
namespace WebCore {
Modified: trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h (235420 => 235421)
--- trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -33,8 +33,8 @@
#include "RealtimeOutgoingVideoSource.h"
#include
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include
#include
@@ -41,7 +41,7 @@
#include
#include
-#pragma clang diagnostic pop
+#pragma GCC diagnostic pop
#include
#include
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h (235420 => 235421)
--- trunk/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h 2018-08-28 06:38:29 UTC (rev 235420)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeIncomingAudioSource.h 2018-08-28 07:49:14 UTC (rev 235421)
@@ -35,12 +35,12 @@
#include "LibWebRTCMacros.h"
#include "RealtimeMediaSource.h"
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wunused-parameter"
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wunused-parameter"
#include
-#pragma clang diag
[webkit-changes] [235422] trunk/Source/WebCore
Title: [235422] trunk/Source/WebCore
Revision 235422
Author eric.carl...@apple.com
Date 2018-08-28 06:29:36 -0700 (Tue, 28 Aug 2018)
Log Message
Revert changes to RealtimeMediaSource.cpp made in r235086
https://bugs.webkit.org/show_bug.cgi?id=189046
Unreviewed, reverting an accidental change.
* platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::supportsSizeAndFrameRate):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (235421 => 235422)
--- trunk/Source/WebCore/ChangeLog 2018-08-28 07:49:14 UTC (rev 235421)
+++ trunk/Source/WebCore/ChangeLog 2018-08-28 13:29:36 UTC (rev 235422)
@@ -1,3 +1,14 @@
+2018-08-28 Eric Carlson
+
+Revert changes to RealtimeMediaSource.cpp made in r235086
+https://bugs.webkit.org/show_bug.cgi?id=189046
+
+
+Unreviewed, reverting an accidental change.
+
+* platform/mediastream/RealtimeMediaSource.cpp:
+(WebCore::RealtimeMediaSource::supportsSizeAndFrameRate):
+
2018-08-28 Alejandro G. Castro
Fix gcc compilation warnings after r235230
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp (235421 => 235422)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2018-08-28 07:49:14 UTC (rev 235421)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp 2018-08-28 13:29:36 UTC (rev 235422)
@@ -246,8 +246,10 @@
}
distance = std::min(distance, constraintDistance);
-auto range = capabilities.width();
-width = widthConstraint->valueForCapabilityRange(size().width(), range.rangeMin().asInt, range.rangeMax().asInt);
+if (widthConstraint->isMandatory()) {
+auto range = capabilities.width();
+width = widthConstraint->valueForCapabilityRange(size().width(), range.rangeMin().asInt, range.rangeMax().asInt);
+}
}
std::optional height;
@@ -259,8 +261,10 @@
}
distance = std::min(distance, constraintDistance);
-auto range = capabilities.height();
-height = heightConstraint->valueForCapabilityRange(size().height(), range.rangeMin().asInt, range.rangeMax().asInt);
+if (heightConstraint->isMandatory()) {
+auto range = capabilities.height();
+height = heightConstraint->valueForCapabilityRange(size().height(), range.rangeMin().asInt, range.rangeMax().asInt);
+}
}
std::optional frameRate;
@@ -272,8 +276,10 @@
}
distance = std::min(distance, constraintDistance);
-auto range = capabilities.frameRate();
-frameRate = frameRateConstraint->valueForCapabilityRange(this->frameRate(), range.rangeMin().asDouble, range.rangeMax().asDouble);
+if (frameRateConstraint->isMandatory()) {
+auto range = capabilities.frameRate();
+frameRate = frameRateConstraint->valueForCapabilityRange(this->frameRate(), range.rangeMin().asDouble, range.rangeMax().asDouble);
+}
}
// Each of the non-null values is supported individually, see if they all can be applied at the same time.
@@ -286,7 +292,7 @@
badConstraint = frameRateConstraint->name();
return false;
}
-
+
return true;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235423] trunk/Source/WebCore
Title: [235423] trunk/Source/WebCore
Revision 235423
Author za...@apple.com
Date 2018-08-28 08:01:37 -0700 (Tue, 28 Aug 2018)
Log Message
[LFC][Floating] Remove redundant FloatAvoider functions.
https://bugs.webkit.org/show_bug.cgi?id=189035
Reviewed by Antti Koivisto.
and move some code from FloatContext to FloatAvoider.
* layout/floats/FloatAvoider.cpp:
(WebCore::Layout::FloatAvoider::initializePosition):
(WebCore::Layout::FloatAvoider::rect const):
(WebCore::Layout::FloatAvoider::setVerticalConstraint):
(WebCore::Layout::FloatAvoider::setHorizontalConstraints):
(WebCore::Layout::FloatAvoider::resetHorizontalConstraint):
(WebCore::Layout::FloatAvoider::initialVerticalPosition const):
(WebCore::Layout::FloatAvoider::initialHorizontalPosition const):
(WebCore::Layout::FloatAvoider::rectInContainingBlock const):
(WebCore::Layout::FloatAvoider::setLeft): Deleted.
(WebCore::Layout::FloatAvoider::setTopLeft): Deleted.
(WebCore::Layout::FloatAvoider::resetVertically): Deleted.
(WebCore::Layout::FloatAvoider::resetHorizontally): Deleted.
(WebCore::Layout::FloatAvoider::topLeftInContainingBlock const): Deleted.
* layout/floats/FloatAvoider.h:
(WebCore::Layout::FloatAvoider::top const): Deleted.
(WebCore::Layout::FloatAvoider::left const): Deleted.
(WebCore::Layout::FloatAvoider::marginTop const): Deleted.
(WebCore::Layout::FloatAvoider::marginLeft const): Deleted.
(WebCore::Layout::FloatAvoider::marginBottom const): Deleted.
(WebCore::Layout::FloatAvoider::marginRight const): Deleted.
(WebCore::Layout::FloatAvoider::rectWithMargin const): Deleted.
(WebCore::Layout::FloatAvoider::setTop): Deleted.
* layout/floats/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::floatingPosition const):
(WebCore::Layout::FloatingPair::horizontalConstraints const):
(WebCore::Layout::FloatingPair::horiztonalPosition const): Deleted.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/layout/floats/FloatAvoider.cpp
trunk/Source/WebCore/layout/floats/FloatAvoider.h
trunk/Source/WebCore/layout/floats/FloatingContext.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (235422 => 235423)
--- trunk/Source/WebCore/ChangeLog 2018-08-28 13:29:36 UTC (rev 235422)
+++ trunk/Source/WebCore/ChangeLog 2018-08-28 15:01:37 UTC (rev 235423)
@@ -1,3 +1,41 @@
+2018-08-28 Zalan Bujtas
+
+[LFC][Floating] Remove redundant FloatAvoider functions.
+https://bugs.webkit.org/show_bug.cgi?id=189035
+
+Reviewed by Antti Koivisto.
+
+and move some code from FloatContext to FloatAvoider.
+
+* layout/floats/FloatAvoider.cpp:
+(WebCore::Layout::FloatAvoider::initializePosition):
+(WebCore::Layout::FloatAvoider::rect const):
+(WebCore::Layout::FloatAvoider::setVerticalConstraint):
+(WebCore::Layout::FloatAvoider::setHorizontalConstraints):
+(WebCore::Layout::FloatAvoider::resetHorizontalConstraint):
+(WebCore::Layout::FloatAvoider::initialVerticalPosition const):
+(WebCore::Layout::FloatAvoider::initialHorizontalPosition const):
+(WebCore::Layout::FloatAvoider::rectInContainingBlock const):
+(WebCore::Layout::FloatAvoider::setLeft): Deleted.
+(WebCore::Layout::FloatAvoider::setTopLeft): Deleted.
+(WebCore::Layout::FloatAvoider::resetVertically): Deleted.
+(WebCore::Layout::FloatAvoider::resetHorizontally): Deleted.
+(WebCore::Layout::FloatAvoider::topLeftInContainingBlock const): Deleted.
+* layout/floats/FloatAvoider.h:
+(WebCore::Layout::FloatAvoider::top const): Deleted.
+(WebCore::Layout::FloatAvoider::left const): Deleted.
+(WebCore::Layout::FloatAvoider::marginTop const): Deleted.
+(WebCore::Layout::FloatAvoider::marginLeft const): Deleted.
+(WebCore::Layout::FloatAvoider::marginBottom const): Deleted.
+(WebCore::Layout::FloatAvoider::marginRight const): Deleted.
+(WebCore::Layout::FloatAvoider::rectWithMargin const): Deleted.
+(WebCore::Layout::FloatAvoider::setTop): Deleted.
+* layout/floats/FloatingContext.cpp:
+(WebCore::Layout::FloatingContext::positionForFloat const):
+(WebCore::Layout::FloatingContext::floatingPosition const):
+(WebCore::Layout::FloatingPair::horizontalConstraints const):
+(WebCore::Layout::FloatingPair::horiztonalPosition const): Deleted.
+
2018-08-28 Eric Carlson
Revert changes to RealtimeMediaSource.cpp made in r235086
Modified: trunk/Source/WebCore/layout/floats/FloatAvoider.cpp (235422 => 235423)
--- trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2018-08-28 13:29:36 UTC (rev 235422)
+++ trunk/Source/WebCore/layout/floats/FloatAvoider.cpp 2018-08-28 15:01:37 UTC (rev 235423)
@@ -49,8 +49,7 @@
void FloatAvoider::initializePosition()
{
-resetVertically();
-resetHorizontally();
+m_absoluteDisplayBox.setTopLeft({ initialHorizontalPosition(), init
[webkit-changes] [235424] trunk
Title: [235424] trunk Revision 235424 Author aj...@chromium.org Date 2018-08-28 08:45:32 -0700 (Tue, 28 Aug 2018) Log Message [IntersectionObserver] Schedule intersection observation updates https://bugs.webkit.org/show_bug.cgi?id=189007 Reviewed by Simon Fraser. LayoutTests/imported/w3c: Rebaseline tests that now pass. * web-platform-tests/intersection-observer/bounding-box-expected.txt: * web-platform-tests/intersection-observer/containing-block-expected.txt: * web-platform-tests/intersection-observer/remove-element-expected.txt: * web-platform-tests/intersection-observer/same-document-root-expected.txt: * web-platform-tests/intersection-observer/unclipped-root-expected.txt: Source/WebCore: Schedule intersection observation updates in the following situations: 1) A new observation target is added. 2) FrameView::viewportContentsChanged -- this covers changes to layout and to scroll positions for same-document observation. Scheduling for cross-document observation will be handled in a future patch. 3) Style is resolved without triggering layout -- this handles updates that were deferred because of a pending style recalculation. Tested by existing tests in imported/w3c/web-platform-tests/intersection-observer. * dom/Document.cpp: (WebCore::Document::resolveStyle): (WebCore::Document::updateIntersectionObservations): (WebCore::Document::scheduleIntersectionObservationUpdate): * dom/Document.h: * page/FrameView.cpp: (WebCore::FrameView::viewportContentsChanged): * page/IntersectionObserver.cpp: (WebCore::IntersectionObserver::observe): Modified Paths trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/remove-element-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/same-document-root-expected.txt trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/unclipped-root-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Document.cpp trunk/Source/WebCore/dom/Document.h trunk/Source/WebCore/page/FrameView.cpp trunk/Source/WebCore/page/IntersectionObserver.cpp Diff Modified: trunk/LayoutTests/imported/w3c/ChangeLog (235423 => 235424) --- trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-28 15:01:37 UTC (rev 235423) +++ trunk/LayoutTests/imported/w3c/ChangeLog 2018-08-28 15:45:32 UTC (rev 235424) @@ -1,3 +1,18 @@ +2018-08-28 Ali Juma + +[IntersectionObserver] Schedule intersection observation updates +https://bugs.webkit.org/show_bug.cgi?id=189007 + +Reviewed by Simon Fraser. + +Rebaseline tests that now pass. + +* web-platform-tests/intersection-observer/bounding-box-expected.txt: +* web-platform-tests/intersection-observer/containing-block-expected.txt: +* web-platform-tests/intersection-observer/remove-element-expected.txt: +* web-platform-tests/intersection-observer/same-document-root-expected.txt: +* web-platform-tests/intersection-observer/unclipped-root-expected.txt: + 2018-08-27 Andy Estes [Payment Request] Update payment-request web platform tests Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt (235423 => 235424) --- trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt 2018-08-28 15:01:37 UTC (rev 235423) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/bounding-box-expected.txt 2018-08-28 15:45:32 UTC (rev 235424) @@ -1,5 +1,5 @@ PASS Test that the target's border bounding box is used to calculate intersection. PASS First rAF. -FAIL target.style.transform = 'translateY(195px)' assert_equals: entries.length expected 2 but got 1 +PASS target.style.transform = 'translateY(195px)' Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block-expected.txt (235423 => 235424) --- trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block-expected.txt 2018-08-28 15:01:37 UTC (rev 235423) +++ trunk/LayoutTests/imported/w3c/web-platform-tests/intersection-observer/containing-block-expected.txt 2018-08-28 15:45:32 UTC (rev 235424) @@ -1,7 +1,7 @@ PASS IntersectionObserver should only report intersections if root is a containing block ancestor of target. -FAIL In containing block and intersecting. assert_equals: entries[0].boundingClientRect.top expected 18 but got 258 -FAIL In containing block and not intersecting. assert_equals: entries.length expected 2 but got 1 -FAIL Not in containing block and intersecting. assert_equals: entries.length expected 2 but got 1 -FAIL Not in containing block and not intersecting. assert_equals: entries.length expected 2 but g
[webkit-changes] [235425] trunk/LayoutTests
Title: [235425] trunk/LayoutTests
Revision 235425
Author simon.fra...@apple.com
Date 2018-08-28 08:51:55 -0700 (Tue, 28 Aug 2018)
Log Message
More results.html cleanup
https://bugs.webkit.org/show_bug.cgi?id=189038
Reviewed by Zalan Bujtas.
Use a map of table-id to SectionBuilderClass to drive the table builder class selection,
rather than hardcoding the builder class; this will allow for SectionBuilders to stay alive
longer in future, so they can be used to build the expanded state of each row.
Refactor the code that generates the expand link and test name, to de-duplicate some HTML strings,
and let SectionBuilders control whether their rows are expandable and test names linkifyable.
Put a "data-test-name" attribute on each row so we can easily map from HTML elements to
TestResults in future.
The test result change is a progression; there is nothing to show for a test with missing results,
so the row should not be expandable.
* fast/harness/results-expected.txt:
* fast/harness/results.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/harness/results-expected.txt
trunk/LayoutTests/fast/harness/results.html
Diff
Modified: trunk/LayoutTests/ChangeLog (235424 => 235425)
--- trunk/LayoutTests/ChangeLog 2018-08-28 15:45:32 UTC (rev 235424)
+++ trunk/LayoutTests/ChangeLog 2018-08-28 15:51:55 UTC (rev 235425)
@@ -1,3 +1,26 @@
+2018-08-28 Simon Fraser
+
+More results.html cleanup
+https://bugs.webkit.org/show_bug.cgi?id=189038
+
+Reviewed by Zalan Bujtas.
+
+Use a map of table-id to SectionBuilderClass to drive the table builder class selection,
+rather than hardcoding the builder class; this will allow for SectionBuilders to stay alive
+longer in future, so they can be used to build the expanded state of each row.
+
+Refactor the code that generates the expand link and test name, to de-duplicate some HTML strings,
+and let SectionBuilders control whether their rows are expandable and test names linkifyable.
+
+Put a "data-test-name" attribute on each row so we can easily map from HTML elements to
+TestResults in future.
+
+The test result change is a progression; there is nothing to show for a test with missing results,
+so the row should not be expandable.
+
+* fast/harness/results-expected.txt:
+* fast/harness/results.html:
+
2018-08-27 Mark Lam
Fix exception throwing code so that topCallFrame and topEntryFrame stay true to their names.
Modified: trunk/LayoutTests/fast/harness/results-expected.txt (235424 => 235425)
--- trunk/LayoutTests/fast/harness/results-expected.txt 2018-08-28 15:45:32 UTC (rev 235424)
+++ trunk/LayoutTests/fast/harness/results-expected.txt 2018-08-28 15:51:55 UTC (rev 235425)
@@ -18,7 +18,7 @@
Tests that had no expected results (probably new) (1): flag all
test results image results actual failure expected failure history
-+svg/batik/smallFonts.svg missing history
+svg/batik/smallFonts.svg missing history
Tests that timed out (1): flag all
+platform/mac/media/audio-session-category-video-paused.html expected actual diff pretty diff history
Modified: trunk/LayoutTests/fast/harness/results.html (235424 => 235425)
--- trunk/LayoutTests/fast/harness/results.html 2018-08-28 15:45:32 UTC (rev 235424)
+++ trunk/LayoutTests/fast/harness/results.html 2018-08-28 15:51:55 UTC (rev 235425)
@@ -444,6 +444,8 @@
this.hasImageFailures = false;
this.hasTextFailures = false;
+this._testsByName = new Map;
+
this._forEachTest(this._results.tests, '');
this._forOtherCrashes(this._results.other_crashes);
}
@@ -482,9 +484,16 @@
{
return this._results.has_wdiff;
}
+
+testWithName(testName)
+{
+return this._testsByName.get(testName);
+}
_processResultForTest(testResult)
{
+this._testsByName.set(testResult.name, testResult);
+
let test = testResult.name;
if (testResult.hasStdErr())
this.testsWithStderr.push(testResult);
@@ -589,28 +598,28 @@
}
if (this.testResults.crashTests.length)
-this.containerElement.appendChild(this.buildOneSection(this.testResults.crashTests, CrashingTestsSectionBuilder));
+this.containerElement.appendChild(this.buildOneSection(this.testResults.crashTests, 'crash-tests-table'));
if (this.testResults.crashOther.length)
-this.containerElement.appendChild(this.buildOneSection(this.testResults.crashOther, OtherCrashesSectionBuilder));
+this.containerElement.appendChild(this.buildOneSection(this.testResults.crashOther, 'other-crash-tests-table'));
if (this.testResults.failingTests.length)
-this.containerElement.appendChild(this.buildOneSection(this.testResults.failingTests, FailingTestsSectionBuilder));
+this.containe
[webkit-changes] [235426] trunk
Title: [235426] trunk
Revision 235426
Author akeer...@apple.com
Date 2018-08-28 09:34:25 -0700 (Tue, 28 Aug 2018)
Log Message
[iOS] Support inputmode=none
https://bugs.webkit.org/show_bug.cgi?id=188896
Reviewed by Tim Horton.
LayoutTests/imported/w3c:
* web-platform-tests/html/dom/reflection-misc-expected.txt: Rebaseline.
Source/WebCore:
Updated InputMode.cpp to ensure that "none" is recognized as a valid value for the
inputmode attribute. This keyword is useful for content that renders its own
keyboard control.
Spec: https://html.spec.whatwg.org/multipage/interaction.html#input-modalities%3A-the-inputmode-attribute
Test: fast/forms/ios/inputmode-none.html
* html/InputMode.cpp:
(WebCore::inputModeForAttributeValue):
(WebCore::stringForInputMode):
(WebCore::InputModeNames::none):
* html/InputMode.h:
Source/WebKit:
inputmode=none is used by content that renders its own keyboard control.
Consequently, we should not display the virtual keyboard when a user interacts
with an element that has the inputmode attribute set to the "none" value.
In order to achieve this behavior, we return a UIView with a bounds of CGRectZero
as the inputView of the WKContentView when inputmode=none is present. Furthermore,
we do not provide an accessory view in this case.
Updated the logic that zooms and scrolls to a control when it gains focus, as that
behavior currently relies on an accessory view being present.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _displayFormNodeInputView]):
(-[WKContentView inputView]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView textInputTraits]):
LayoutTests:
Added new test to verify that the system keyboard does not show for inputs with
inputmode=none. Updated existing inputmode tests to reflect the addition of the
"none" value.
* fast/forms/inputmode-attribute-contenteditable-expected.txt:
* fast/forms/inputmode-attribute-contenteditable.html:
* fast/forms/inputmode-attribute-input-expected.txt:
* fast/forms/inputmode-attribute-input.html:
* fast/forms/inputmode-attribute-textarea-expected.txt:
* fast/forms/inputmode-attribute-textarea.html:
* fast/forms/ios/inputmode-none-expected.txt: Added.
* fast/forms/ios/inputmode-none.html: Added.
* resources/ui-helper.js:
(window.UIHelper.activateFormControl):
(window.UIHelper.inputViewBounds):
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/inputmode-attribute-contenteditable-expected.txt
trunk/LayoutTests/fast/forms/inputmode-attribute-contenteditable.html
trunk/LayoutTests/fast/forms/inputmode-attribute-input-expected.txt
trunk/LayoutTests/fast/forms/inputmode-attribute-input.html
trunk/LayoutTests/fast/forms/inputmode-attribute-textarea-expected.txt
trunk/LayoutTests/fast/forms/inputmode-attribute-textarea.html
trunk/LayoutTests/imported/w3c/ChangeLog
trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-misc-expected.txt
trunk/LayoutTests/resources/ui-helper.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/html/InputMode.cpp
trunk/Source/WebCore/html/InputMode.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm
Added Paths
trunk/LayoutTests/fast/forms/ios/inputmode-none-expected.txt
trunk/LayoutTests/fast/forms/ios/inputmode-none.html
Diff
Modified: trunk/LayoutTests/ChangeLog (235425 => 235426)
--- trunk/LayoutTests/ChangeLog 2018-08-28 15:51:55 UTC (rev 235425)
+++ trunk/LayoutTests/ChangeLog 2018-08-28 16:34:25 UTC (rev 235426)
@@ -1,3 +1,26 @@
+2018-08-28 Aditya Keerthi
+
+[iOS] Support inputmode=none
+https://bugs.webkit.org/show_bug.cgi?id=188896
+
+Reviewed by Tim Horton.
+
+Added new test to verify that the system keyboard does not show for inputs with
+inputmode=none. Updated existing inputmode tests to reflect the addition of the
+"none" value.
+
+* fast/forms/inputmode-attribute-contenteditable-expected.txt:
+* fast/forms/inputmode-attribute-contenteditable.html:
+* fast/forms/inputmode-attribute-input-expected.txt:
+* fast/forms/inputmode-attribute-input.html:
+* fast/forms/inputmode-attribute-textarea-expected.txt:
+* fast/forms/inputmode-attribute-textarea.html:
+* fast/forms/ios/inputmode-none-expected.txt: Added.
+* fast/forms/ios/inputmode-none.html: Added.
+* resources/ui-helper.js:
+(window.UIHelper.activateFormControl):
+(window.UIHelper.inputViewBounds):
+
2018-08-28 Simon Fraser
More results.html cleanup
Modified: trunk/LayoutTests/fast/forms/inputmode-attribute-contenteditable-expected.txt (235425 => 235426)
--- trunk/LayoutTests/fast/forms/inputmode-attribute-contenteditable-expected.txt 2018-08-28 15:51:55 UTC (rev 235425)
+++ trunk/LayoutTests/fast/forms/inputmode-attribute-contenteditable-expected.txt 2018-08-28 16:34:25 UTC (rev 235426)
@@ -10,6 +10,9 @@
PASS editor.setAttribute("inputmode", "baz"); editor.inputMode
[webkit-changes] [235427] trunk
Title: [235427] trunk
Revision 235427
Author akeer...@apple.com
Date 2018-08-28 10:02:56 -0700 (Tue, 28 Aug 2018)
Log Message
[Datalist] Pressing enter without a selected option shouldn't change the input
https://bugs.webkit.org/show_bug.cgi?id=189010
Reviewed by Tim Horton.
Source/WebKit:
Currently, the value of an input field gets cleared if there is no selected
datalist suggestion when the enter key is pressed. The correct behavior is to
leave the value of the input as-is.
The incorrect behavior is a consequence of the fact that an empty string is
returned by [WKDataListSuggestionsView currentSelectedString] if there is no
selection. To fix the behavior, the method now returns an std::optional instead
of an empty string. If std::nullopt is returned, we do not make any modification
to the value of the input. This ensures that we can still change the value of
an input field to an empty string in the case that an empty string is part of
the suggestions.
Augmented test: fast/forms/datalist/datalist-textinput-keydown.html
* UIProcess/mac/WebDataListSuggestionsDropdownMac.mm:
(WebKit::WebDataListSuggestionsDropdownMac::selectOption):
(-[WKDataListSuggestionCell drawRect:]): Quick fix. The mouseover color was incorrect.
(-[WKDataListSuggestionsView currentSelectedString]):
LayoutTests:
Augmented test to verify that pressing enter when there is no selected datalist
suggestion does not change the value of the input field.
* fast/forms/datalist/datalist-textinput-keydown-expected.txt:
* fast/forms/datalist/datalist-textinput-keydown.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown-expected.txt
trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown.html
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WebDataListSuggestionsDropdownMac.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (235426 => 235427)
--- trunk/LayoutTests/ChangeLog 2018-08-28 16:34:25 UTC (rev 235426)
+++ trunk/LayoutTests/ChangeLog 2018-08-28 17:02:56 UTC (rev 235427)
@@ -1,5 +1,18 @@
2018-08-28 Aditya Keerthi
+[Datalist] Pressing enter without a selected option shouldn't change the input
+https://bugs.webkit.org/show_bug.cgi?id=189010
+
+Reviewed by Tim Horton.
+
+Augmented test to verify that pressing enter when there is no selected datalist
+suggestion does not change the value of the input field.
+
+* fast/forms/datalist/datalist-textinput-keydown-expected.txt:
+* fast/forms/datalist/datalist-textinput-keydown.html:
+
+2018-08-28 Aditya Keerthi
+
[iOS] Support inputmode=none
https://bugs.webkit.org/show_bug.cgi?id=188896
Modified: trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown-expected.txt (235426 => 235427)
--- trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown-expected.txt 2018-08-28 16:34:25 UTC (rev 235426)
+++ trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown-expected.txt 2018-08-28 17:02:56 UTC (rev 235427)
@@ -5,6 +5,7 @@
PASS input.value is "Apple"
PASS input.value is "Pear"
+PASS input.value is "Appl"
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown.html (235426 => 235427)
--- trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown.html 2018-08-28 16:34:25 UTC (rev 235426)
+++ trunk/LayoutTests/fast/forms/datalist/datalist-textinput-keydown.html 2018-08-28 17:02:56 UTC (rev 235427)
@@ -22,7 +22,6 @@
UIHelper.activateElement(input);
eventSender.keyDown("downArrow");
eventSender.keyDown("\r");
-
shouldBe('input.value', '"Apple"');
input.value = "";
@@ -30,9 +29,14 @@
UIHelper.activateElement(input);
eventSender.keyDown("upArrow");
eventSender.keyDown("\r");
-
shouldBe('input.value', '"Pear"');
+input.value = "Appl";
+
+UIHelper.activateElement(input);
+eventSender.keyDown("\r");
+shouldBe('input.value', '"Appl"');
+
[webkit-changes] [235428] trunk/Source/WebCore
Title: [235428] trunk/Source/WebCore Revision 235428 Author aj...@chromium.org Date 2018-08-28 10:53:15 -0700 (Tue, 28 Aug 2018) Log Message [IntersectionObserver] Fix build after r235424 https://bugs.webkit.org/show_bug.cgi?id=189051 Rubber-stamped by Simon Fraser. Fix unused variable warning by using the variable. * page/FrameView.cpp: (WebCore::FrameView::viewportContentsChanged): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/FrameView.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (235427 => 235428) --- trunk/Source/WebCore/ChangeLog 2018-08-28 17:02:56 UTC (rev 235427) +++ trunk/Source/WebCore/ChangeLog 2018-08-28 17:53:15 UTC (rev 235428) @@ -1,3 +1,15 @@ +2018-08-28 Ali Juma + +[IntersectionObserver] Fix build after r235424 +https://bugs.webkit.org/show_bug.cgi?id=189051 + +Rubber-stamped by Simon Fraser. + +Fix unused variable warning by using the variable. + +* page/FrameView.cpp: +(WebCore::FrameView::viewportContentsChanged): + 2018-08-28 Aditya Keerthi [iOS] Support inputmode=none Modified: trunk/Source/WebCore/page/FrameView.cpp (235427 => 235428) --- trunk/Source/WebCore/page/FrameView.cpp 2018-08-28 17:02:56 UTC (rev 235427) +++ trunk/Source/WebCore/page/FrameView.cpp 2018-08-28 17:53:15 UTC (rev 235428) @@ -2004,7 +2004,7 @@ #if ENABLE(INTERSECTION_OBSERVER) if (auto* document = frame().document()) -frame().document()->scheduleIntersectionObservationUpdate(); +document->scheduleIntersectionObservationUpdate(); #endif } ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235429] trunk
Title: [235429] trunk
Revision 235429
Author you...@apple.com
Date 2018-08-28 11:00:00 -0700 (Tue, 28 Aug 2018)
Log Message
WebKitMediaSession should be GC collectable when its document is being stopped
https://bugs.webkit.org/show_bug.cgi?id=189016
Reviewed by Eric Carlson.
Source/WebCore:
Make sure WebKitMediaSession is collectable after its document is stopped.
This is done by nullifying m_session when calling close.
This way hasPendingActivity() returns false when stop() is called.
Test: http/tests/media/clearkey/collect-webkit-media-session.html
* Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp:
(WebCore::WebKitMediaKeySession::WebKitMediaKeySession):
(WebCore::WebKitMediaKeySession::close):
* Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
LayoutTests:
* http/tests/media/clearkey/collect-webkit-media-session-expected.txt: Added.
* http/tests/media/clearkey/collect-webkit-media-session.html: Added.
* http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.cpp
trunk/Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h
Added Paths
trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session-expected.txt
trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html
trunk/LayoutTests/http/tests/media/clearkey/resources/
trunk/LayoutTests/http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm
Diff
Modified: trunk/LayoutTests/ChangeLog (235428 => 235429)
--- trunk/LayoutTests/ChangeLog 2018-08-28 17:53:15 UTC (rev 235428)
+++ trunk/LayoutTests/ChangeLog 2018-08-28 18:00:00 UTC (rev 235429)
@@ -1,3 +1,14 @@
+2018-08-28 Youenn Fablet
+
+WebKitMediaSession should be GC collectable when its document is being stopped
+https://bugs.webkit.org/show_bug.cgi?id=189016
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/clearkey/collect-webkit-media-session-expected.txt: Added.
+* http/tests/media/clearkey/collect-webkit-media-session.html: Added.
+* http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm: Added.
+
2018-08-28 Aditya Keerthi
[Datalist] Pressing enter without a selected option shouldn't change the input
Added: trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session-expected.txt (0 => 235429)
--- trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session-expected.txt (rev 0)
+++ trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session-expected.txt 2018-08-28 18:00:00 UTC (rev 235429)
@@ -0,0 +1,4 @@
+
+
+PASS Ensure that the frame's document get collected after being stopped while doing some webkit media session calls
+
Added: trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html (0 => 235429)
--- trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html (rev 0)
+++ trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html 2018-08-28 18:00:00 UTC (rev 235429)
@@ -0,0 +1,45 @@
+
+
+
+function waitFor(duration)
+{
+return new Promise((resolve) => setTimeout(resolve, duration));
+}
+
+var resolveCallback, rejectCallback;
+var promise = new Promise((resolve, reject) => {
+resolveCallback = resolve;
+rejectCallback = reject;
+});
+
+async function done()
+{
+try {
+const frameIdentifier = internals.documentIdentifier(iframe.contentDocument);
+iframe.src = ""
+let counter = 0;
+while (++counter < 10) {
+if (!internals.isDocumentAlive(frameIdentifier)) {
+resolveCallback();
+return;
+}
+if (window.GCController)
+GCController.collect();
+
+await waitFor(50);
+}
+} finally {
+rejectCallback("Test failed");
+}
+}
+
+promise_test((test) => {
+if (!window.internals)
+rejectCallback("Test require internals API");
+return promise;
+}, "Ensure that the frame's document get collected after being stopped while doing some webkit media session calls");
+
+
+
Added: trunk/LayoutTests/http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm (0 => 235429)
--- trunk/LayoutTests/http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm (rev 0)
+++ trunk/LayoutTests/http/tests/media/clearkey/resources/mywebkitmediasessionframe.htm 2018-08-28 18:00:00 UTC (rev 235429)
@@ -0,0 +1,32 @@
+
+
+
+
+var keyId;
+var session;
+
+function go()
+{
+video.addEventListener('webkitneedkey', needkey, true);
+video.src = '';
+}
+
+function needkey(event)
+{
+if (!video.webkitKeys)
+video.webkitSetMediaKeys(new WebK
[webkit-changes] [235431] trunk/Tools
Title: [235431] trunk/Tools
Revision 235431
Author wenson_hs...@apple.com
Date 2018-08-28 11:04:54 -0700 (Tue, 28 Aug 2018)
Log Message
[iOS] WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging encounters an exception on iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=189049
Reviewed by Tim Horton.
Wrap an NSURL in a RetainPtr to prevent it from being freed prematurely. It seems this broke when I changed the
load handler from an Objective-C block that captured `folderURL` to a C++ lambda that didn't retain `folderURL`.
* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(simulateFolderDragWithURL):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm
Diff
Modified: trunk/Tools/ChangeLog (235430 => 235431)
--- trunk/Tools/ChangeLog 2018-08-28 18:00:45 UTC (rev 235430)
+++ trunk/Tools/ChangeLog 2018-08-28 18:04:54 UTC (rev 235431)
@@ -1,3 +1,16 @@
+2018-08-28 Wenson Hsieh
+
+[iOS] WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging encounters an exception on iOS simulator
+https://bugs.webkit.org/show_bug.cgi?id=189049
+
+Reviewed by Tim Horton.
+
+Wrap an NSURL in a RetainPtr to prevent it from being freed prematurely. It seems this broke when I changed the
+load handler from an Objective-C block that captured `folderURL` to a C++ lambda that didn't retain `folderURL`.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
+(simulateFolderDragWithURL):
+
2018-08-27 Wenson Hsieh
[Attachment Support] Remove WebCore::AttachmentDisplayOptions and friends
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm (235430 => 235431)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2018-08-28 18:00:45 UTC (rev 235430)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm 2018-08-28 18:04:54 UTC (rev 235431)
@@ -416,8 +416,8 @@
auto folderProvider = adoptNS([[NSItemProvider alloc] init]);
[folderProvider setSuggestedName:folderURL.lastPathComponent];
[folderProvider setPreferredPresentationStyle:UIPreferredPresentationStyleAttachment];
-[folderProvider registerFileRepresentationForTypeIdentifier:(__bridge NSString *)kUTTypeFolder fileOptions:0 visibility:NSItemProviderRepresentationVisibilityAll loadHandler:[&] (void(^completion)(NSURL *, BOOL, NSError *)) -> NSProgress * {
-completion(folderURL, NO, nil);
+[folderProvider registerFileRepresentationForTypeIdentifier:(__bridge NSString *)kUTTypeFolder fileOptions:0 visibility:NSItemProviderRepresentationVisibilityAll loadHandler:[protectedFolderURL = retainPtr(folderURL)] (void(^completion)(NSURL *, BOOL, NSError *)) -> NSProgress * {
+completion(protectedFolderURL.get(), NO, nil);
return nil;
}];
simulator.externalItemProviders = @[ folderProvider.get() ];
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235432] trunk/Source/JavaScriptCore
Title: [235432] trunk/Source/_javascript_Core Revision 235432 Author keith_mil...@apple.com Date 2018-08-28 11:11:23 -0700 (Tue, 28 Aug 2018) Log Message Add nullablity attributes to JSValue https://bugs.webkit.org/show_bug.cgi?id=189047 Reviewed by Geoffrey Garen. * API/JSValue.h: Modified Paths trunk/Source/_javascript_Core/API/JSValue.h trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/API/JSValue.h (235431 => 235432) --- trunk/Source/_javascript_Core/API/JSValue.h 2018-08-28 18:04:54 UTC (rev 235431) +++ trunk/Source/_javascript_Core/API/JSValue.h 2018-08-28 18:11:23 UTC (rev 235432) @@ -48,9 +48,9 @@ @interface JSValue : NSObject #if (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED < JSC_MAC_VERSION_TBA) || (defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED < JSC_IOS_VERSION_TBA) -typedef NSString *JSValueProperty; +typedef NSString * _Nonnull JSValueProperty; #else -typedef id JSValueProperty; +typedef id _Nullable JSValueProperty; #endif /*! @@ -57,7 +57,7 @@ @property @abstract The JSContext that this value originates from. */ -@property (readonly, strong) JSContext *context; +@property (readonly, strong, nonnull) JSContext *context; /*! @methodgroup Creating _javascript_ Values @@ -69,7 +69,7 @@ @param value The Objective-C object to be converted. @result The new JSValue. */ -+ (JSValue *)valueWithObject:(id)value inContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithObject:(nullable id)value inContext:(nonnull JSContext *)context; /*! @method @@ -77,7 +77,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (JSValue *)valueWithBool:(BOOL)value inContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithBool:(BOOL)value inContext:(nonnull JSContext *)context; /*! @method @@ -85,7 +85,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (JSValue *)valueWithDouble:(double)value inContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithDouble:(double)value inContext:(nonnull JSContext *)context; /*! @method @@ -93,7 +93,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (JSValue *)valueWithInt32:(int32_t)value inContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithInt32:(int32_t)value inContext:(nonnull JSContext *)context; /*! @method @@ -101,7 +101,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (JSValue *)valueWithUInt32:(uint32_t)value inContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithUInt32:(uint32_t)value inContext:(nonnull JSContext *)context; /*! @method @@ -109,7 +109,7 @@ @param context The JSContext in which the resulting object will be created. @result The new _javascript_ object. */ -+ (JSValue *)valueWithNewObjectInContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithNewObjectInContext:(nonnull JSContext *)context; /*! @method @@ -117,7 +117,7 @@ @param context The JSContext in which the resulting array will be created. @result The new _javascript_ array. */ -+ (JSValue *)valueWithNewArrayInContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithNewArrayInContext:(nonnull JSContext *)context; /*! @method @@ -127,7 +127,7 @@ @param context The JSContext in which the resulting regular _expression_ object will be created. @result The new _javascript_ regular _expression_ object. */ -+ (JSValue *)valueWithNewRegularExpressionFromPattern:(NSString *)pattern flags:(NSString *)flags inContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithNewRegularExpressionFromPattern:(nonnull NSString *)pattern flags:(nonnull NSString *)flags inContext:(nonnull JSContext *)context; /*! @method @@ -136,7 +136,7 @@ @param context The JSContext in which the resulting error object will be created. @result The new _javascript_ error object. */ -+ (JSValue *)valueWithNewErrorFromMessage:(NSString *)message inContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithNewErrorFromMessage:(nonnull NSString *)message inContext:(nonnull JSContext *)context; /*! @method @@ -144,7 +144,7 @@ @param context The JSContext to which the resulting JSValue belongs. @result The JSValue representing the _javascript_ value null. */ -+ (JSValue *)valueWithNullInContext:(JSContext *)context; ++ (nonnull JSValue *)valueWithNullInContext:(nonnull JSContext *)context; /*! @method @@ -152,7 +152,7 @@ @param context The JSContext to which the resulting JSValue belongs. @result The JSValue representing the _javascript_ value undefined. */ -+ (JSValue *)valueWithUndefinedInCont
[webkit-changes] [235433] trunk/Tools
Title: [235433] trunk/Tools Revision 235433 Author achristen...@apple.com Date 2018-08-28 11:29:13 -0700 (Tue, 28 Aug 2018) Log Message REGRESSION (r235391): [iOS] TestWebKitAPI.WebKit.RestoreSessionStateWithoutNavigation is timing out https://bugs.webkit.org/show_bug.cgi?id=189050 Reviewed by Tim Horton. * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: This test wasn't run on iOS before. Let's re-introduce the WK_HAVE_C_SPI guard. Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm Diff Modified: trunk/Tools/ChangeLog (235432 => 235433) --- trunk/Tools/ChangeLog 2018-08-28 18:11:23 UTC (rev 235432) +++ trunk/Tools/ChangeLog 2018-08-28 18:29:13 UTC (rev 235433) @@ -1,3 +1,13 @@ +2018-08-28 Alex Christensen + +REGRESSION (r235391): [iOS] TestWebKitAPI.WebKit.RestoreSessionStateWithoutNavigation is timing out +https://bugs.webkit.org/show_bug.cgi?id=189050 + +Reviewed by Tim Horton. + +* TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: +This test wasn't run on iOS before. Let's re-introduce the WK_HAVE_C_SPI guard. + 2018-08-28 Wenson Hsieh [iOS] WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging encounters an exception on iOS simulator Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm (235432 => 235433) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm 2018-08-28 18:11:23 UTC (rev 235432) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm 2018-08-28 18:29:13 UTC (rev 235433) @@ -25,7 +25,7 @@ #include "config.h" -#if WK_API_ENABLED +#if PLATFORM(MAC) #include "_javascript_Test.h" #include "PlatformUtilities.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235434] trunk/Tools
Title: [235434] trunk/Tools Revision 235434 Author achristen...@apple.com Date 2018-08-28 11:37:46 -0700 (Tue, 28 Aug 2018) Log Message Fix 32-bit Mac build. * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: Modified Paths trunk/Tools/ChangeLog trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm Diff Modified: trunk/Tools/ChangeLog (235433 => 235434) --- trunk/Tools/ChangeLog 2018-08-28 18:29:13 UTC (rev 235433) +++ trunk/Tools/ChangeLog 2018-08-28 18:37:46 UTC (rev 235434) @@ -1,5 +1,11 @@ 2018-08-28 Alex Christensen +Fix 32-bit Mac build. + +* TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm: + +2018-08-28 Alex Christensen + REGRESSION (r235391): [iOS] TestWebKitAPI.WebKit.RestoreSessionStateWithoutNavigation is timing out https://bugs.webkit.org/show_bug.cgi?id=189050 Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm (235433 => 235434) --- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm 2018-08-28 18:29:13 UTC (rev 235433) +++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm 2018-08-28 18:37:46 UTC (rev 235434) @@ -25,7 +25,7 @@ #include "config.h" -#if PLATFORM(MAC) +#if PLATFORM(MAC) && WK_API_ENABLED #include "_javascript_Test.h" #include "PlatformUtilities.h" ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235435] trunk
Title: [235435] trunk
Revision 235435
Author akeer...@apple.com
Date 2018-08-28 11:56:37 -0700 (Tue, 28 Aug 2018)
Log Message
[macOS] Color wells should appear rounded and textured
https://bugs.webkit.org/show_bug.cgi?id=189039
Reviewed by Tim Horton.
Source/WebCore:
Color wells should have a rounded and textured appearance on macOS. We can use
NSBezelStyleTexturedSquare to achieve this appearance.
Also updated the user-agent stylesheet to match the system appearance.
Rebaselined existing test: fast/forms/color/input-appearance-color.html
* css/html.css:
(input[type="color"]::-webkit-color-swatch-wrapper):
(input[type="color"]::-webkit-color-swatch):
* platform/mac/ThemeMac.mm:
(WebCore::setUpButtonCell):
* rendering/RenderThemeMac.h: Build fix.
Source/WebKit:
* UIProcess/mac/WebColorPickerMac.mm: Build fix.
LayoutTests:
Rebaseline tests to match new color-well appearance.
* platform/mac/fast/forms/color/input-appearance-color-expected.png:
* platform/mac/fast/forms/color/input-appearance-color-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.png
trunk/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/html.css
trunk/Source/WebCore/platform/mac/ThemeMac.mm
trunk/Source/WebCore/rendering/RenderThemeMac.h
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/mac/WebColorPickerMac.mm
Diff
Modified: trunk/LayoutTests/ChangeLog (235434 => 235435)
--- trunk/LayoutTests/ChangeLog 2018-08-28 18:37:46 UTC (rev 235434)
+++ trunk/LayoutTests/ChangeLog 2018-08-28 18:56:37 UTC (rev 235435)
@@ -1,3 +1,15 @@
+2018-08-28 Aditya Keerthi
+
+[macOS] Color wells should appear rounded and textured
+https://bugs.webkit.org/show_bug.cgi?id=189039
+
+Reviewed by Tim Horton.
+
+Rebaseline tests to match new color-well appearance.
+
+* platform/mac/fast/forms/color/input-appearance-color-expected.png:
+* platform/mac/fast/forms/color/input-appearance-color-expected.txt:
+
2018-08-28 Youenn Fablet
WebKitMediaSession should be GC collectable when its document is being stopped
Modified: trunk/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt (235434 => 235435)
--- trunk/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt 2018-08-28 18:37:46 UTC (rev 235434)
+++ trunk/LayoutTests/platform/mac/fast/forms/color/input-appearance-color-expected.txt 2018-08-28 18:56:37 UTC (rev 235435)
@@ -12,10 +12,10 @@
RenderBR {BR} at (456,14) size 1x0
RenderBlock {INPUT} at (0,18) size 44x23 [bgcolor=#FF] [border: none (2px inset #00) none (2px inset #00)]
RenderFlexibleBox {DIV} at (3,1) size 38x21
-RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#00] [border: (1px solid #8A8A8A)]
+RenderBlock {DIV} at (2,4) size 34x12 [bgcolor=#00]
RenderBlock {INPUT} at (44,18) size 44x23 [bgcolor=#FF] [border: none (2px inset #00) none (2px inset #00)]
RenderFlexibleBox {DIV} at (3,1) size 38x21
-RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#00] [border: (1px solid #8A8A8A)]
+RenderBlock {DIV} at (2,4) size 34x12 [bgcolor=#00]
RenderText {#text} at (0,0) size 0x0
RenderBlock {H3} at (0,100) size 784x23
RenderText {#text} at (0,0) size 162x22
@@ -26,32 +26,32 @@
RenderBR {BR} at (589,14) size 1x0
RenderBlock {INPUT} at (0,18) size 44x23 [bgcolor=#FF] [border: none (2px inset #00) none (2px inset #00)]
RenderFlexibleBox {DIV} at (3,1) size 38x21
-RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#00FF00] [border: (1px solid #8A8A8A)]
+RenderBlock {DIV} at (2,4) size 34x12 [bgcolor=#00FF00]
RenderText {#text} at (44,21) size 4x18
text run at (44,21) width 4: " "
RenderBlock {INPUT} at (48,18) size 44x23 [bgcolor=#FF] [border: none (2px inset #00) none (2px inset #00)]
RenderFlexibleBox {DIV} at (3,1) size 38x21
-RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#00FF00] [border: (1px solid #8A8A8A)]
+RenderBlock {DIV} at (2,4) size 34x12 [bgcolor=#00FF00]
RenderText {#text} at (92,21) size 4x18
text run at (92,21) width 4: " "
RenderBlock {INPUT} at (96,18) size 44x23 [bgcolor=#FF] [border: none (2px inset #00) none (2px inset #00)]
RenderFlexibleBox {DIV} at (3,1) size 38x21
-RenderBlock {DIV} at (2,4) size 34x13 [bgcolor=#00FF00] [border: (1px solid #8A8A8A)]
+RenderBlock {DIV} at (2,4) size 34x12 [bgcolor=#00FF00]
RenderText {#text} at (140,21) size
[webkit-changes] [235436] trunk/Source/JavaScriptCore
Title: [235436] trunk/Source/_javascript_Core Revision 235436 Author keith_mil...@apple.com Date 2018-08-28 13:00:35 -0700 (Tue, 28 Aug 2018) Log Message Add nullablity attributes to JSValue https://bugs.webkit.org/show_bug.cgi?id=189047 Reviewed by Dan Bernstein. Switch to using NS_ASSUME_NONNULL_BEGIN/END. * API/JSValue.h: Modified Paths trunk/Source/_javascript_Core/API/JSValue.h trunk/Source/_javascript_Core/ChangeLog Diff Modified: trunk/Source/_javascript_Core/API/JSValue.h (235435 => 235436) --- trunk/Source/_javascript_Core/API/JSValue.h 2018-08-28 18:56:37 UTC (rev 235435) +++ trunk/Source/_javascript_Core/API/JSValue.h 2018-08-28 20:00:35 UTC (rev 235436) @@ -30,6 +30,8 @@ #import +NS_ASSUME_NONNULL_BEGIN + @class JSContext; /*! @@ -48,7 +50,7 @@ @interface JSValue : NSObject #if (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED < JSC_MAC_VERSION_TBA) || (defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED < JSC_IOS_VERSION_TBA) -typedef NSString * _Nonnull JSValueProperty; +typedef NSString * JSValueProperty; #else typedef id _Nullable JSValueProperty; #endif @@ -57,7 +59,7 @@ @property @abstract The JSContext that this value originates from. */ -@property (readonly, strong, nonnull) JSContext *context; +@property (readonly, strong) JSContext *context; /*! @methodgroup Creating _javascript_ Values @@ -69,7 +71,7 @@ @param value The Objective-C object to be converted. @result The new JSValue. */ -+ (nonnull JSValue *)valueWithObject:(nullable id)value inContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithObject:(nullable id)value inContext:(JSContext *)context; /*! @method @@ -77,7 +79,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (nonnull JSValue *)valueWithBool:(BOOL)value inContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithBool:(BOOL)value inContext:(JSContext *)context; /*! @method @@ -85,7 +87,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (nonnull JSValue *)valueWithDouble:(double)value inContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithDouble:(double)value inContext:(JSContext *)context; /*! @method @@ -93,7 +95,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (nonnull JSValue *)valueWithInt32:(int32_t)value inContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithInt32:(int32_t)value inContext:(JSContext *)context; /*! @method @@ -101,7 +103,7 @@ @param context The JSContext in which the resulting JSValue will be created. @result The new JSValue representing the equivalent boolean value. */ -+ (nonnull JSValue *)valueWithUInt32:(uint32_t)value inContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithUInt32:(uint32_t)value inContext:(JSContext *)context; /*! @method @@ -109,7 +111,7 @@ @param context The JSContext in which the resulting object will be created. @result The new _javascript_ object. */ -+ (nonnull JSValue *)valueWithNewObjectInContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithNewObjectInContext:(JSContext *)context; /*! @method @@ -117,7 +119,7 @@ @param context The JSContext in which the resulting array will be created. @result The new _javascript_ array. */ -+ (nonnull JSValue *)valueWithNewArrayInContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithNewArrayInContext:(JSContext *)context; /*! @method @@ -127,7 +129,7 @@ @param context The JSContext in which the resulting regular _expression_ object will be created. @result The new _javascript_ regular _expression_ object. */ -+ (nonnull JSValue *)valueWithNewRegularExpressionFromPattern:(nonnull NSString *)pattern flags:(nonnull NSString *)flags inContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithNewRegularExpressionFromPattern:(NSString *)pattern flags:(NSString *)flags inContext:(JSContext *)context; /*! @method @@ -136,7 +138,7 @@ @param context The JSContext in which the resulting error object will be created. @result The new _javascript_ error object. */ -+ (nonnull JSValue *)valueWithNewErrorFromMessage:(nonnull NSString *)message inContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithNewErrorFromMessage:(NSString *)message inContext:(JSContext *)context; /*! @method @@ -144,7 +146,7 @@ @param context The JSContext to which the resulting JSValue belongs. @result The JSValue representing the _javascript_ value null. */ -+ (nonnull JSValue *)valueWithNullInContext:(nonnull JSContext *)context; ++ (JSValue *)valueWithNullInContext:(JSContext *)context; /*! @method @@ -152,7 +154,7 @@ @param context The JSContext to which the resulting JSValue belongs. @resu
[webkit-changes] [235438] trunk
Title: [235438] trunk
Revision 235438
Author you...@apple.com
Date 2018-08-28 13:53:17 -0700 (Tue, 28 Aug 2018)
Log Message
MediaDevices should be collectable as soon as its document is stopped
https://bugs.webkit.org/show_bug.cgi?id=189021
Reviewed by Eric Carlson.
Source/WebCore:
Introduce ActiveDOMObject::isContextStopped to check whether the context is stopped.
Use this check in MediaDevices::hasPendingActivity so that it returns false as soon as active dom objects are stopped.
Test: http/tests/media/collect-media-devices.https.html
* Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::hasPendingActivity const):
* dom/ActiveDOMObject.cpp:
(WebCore::ActiveDOMObject::hasPendingActivity const):
(WebCore::ActiveDOMObject::isContextStopped const):
* dom/ActiveDOMObject.h:
LayoutTests:
* http/tests/media/media-stream/collect-media-devices.https-expected.txt: Added.
* http/tests/media/media-stream/collect-media-devices.https.html: Added.
* http/tests/media/media-stream/resources/mymediadevicesframe.htm: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp
trunk/Source/WebCore/dom/ActiveDOMObject.cpp
trunk/Source/WebCore/dom/ActiveDOMObject.h
Diff
Modified: trunk/LayoutTests/ChangeLog (235437 => 235438)
--- trunk/LayoutTests/ChangeLog 2018-08-28 20:50:19 UTC (rev 235437)
+++ trunk/LayoutTests/ChangeLog 2018-08-28 20:53:17 UTC (rev 235438)
@@ -1,3 +1,14 @@
+2018-08-28 Youenn Fablet
+
+MediaDevices should be collectable as soon as its document is stopped
+https://bugs.webkit.org/show_bug.cgi?id=189021
+
+Reviewed by Eric Carlson.
+
+* http/tests/media/media-stream/collect-media-devices.https-expected.txt: Added.
+* http/tests/media/media-stream/collect-media-devices.https.html: Added.
+* http/tests/media/media-stream/resources/mymediadevicesframe.htm: Added.
+
2018-08-28 Basuke Suzuki
[Curl] Fix issue that extra cookie is added when redirect happens.
Modified: trunk/Source/WebCore/ChangeLog (235437 => 235438)
--- trunk/Source/WebCore/ChangeLog 2018-08-28 20:50:19 UTC (rev 235437)
+++ trunk/Source/WebCore/ChangeLog 2018-08-28 20:53:17 UTC (rev 235438)
@@ -1,3 +1,22 @@
+2018-08-28 Youenn Fablet
+
+MediaDevices should be collectable as soon as its document is stopped
+https://bugs.webkit.org/show_bug.cgi?id=189021
+
+Reviewed by Eric Carlson.
+
+Introduce ActiveDOMObject::isContextStopped to check whether the context is stopped.
+Use this check in MediaDevices::hasPendingActivity so that it returns false as soon as active dom objects are stopped.
+
+Test: http/tests/media/collect-media-devices.https.html
+
+* Modules/mediastream/MediaDevices.cpp:
+(WebCore::MediaDevices::hasPendingActivity const):
+* dom/ActiveDOMObject.cpp:
+(WebCore::ActiveDOMObject::hasPendingActivity const):
+(WebCore::ActiveDOMObject::isContextStopped const):
+* dom/ActiveDOMObject.h:
+
2018-08-28 Basuke Suzuki
[Curl] Fix issue that extra cookie is added when redirect happens.
Modified: trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp (235437 => 235438)
--- trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp 2018-08-28 20:50:19 UTC (rev 235437)
+++ trunk/Source/WebCore/Modules/mediastream/MediaDevices.cpp 2018-08-28 20:53:17 UTC (rev 235438)
@@ -162,7 +162,7 @@
bool MediaDevices::hasPendingActivity() const
{
-return scriptExecutionContext() && hasEventListeners(m_eventNames.devicechangeEvent);
+return !isContextStopped() && hasEventListeners(m_eventNames.devicechangeEvent);
}
const char* MediaDevices::activeDOMObjectName() const
Modified: trunk/Source/WebCore/dom/ActiveDOMObject.cpp (235437 => 235438)
--- trunk/Source/WebCore/dom/ActiveDOMObject.cpp 2018-08-28 20:50:19 UTC (rev 235437)
+++ trunk/Source/WebCore/dom/ActiveDOMObject.cpp 2018-08-28 20:53:17 UTC (rev 235438)
@@ -106,4 +106,9 @@
{
}
+bool ActiveDOMObject::isContextStopped() const
+{
+return !scriptExecutionContext() || scriptExecutionContext()->activeDOMObjectsAreStopped();
+}
+
} // namespace WebCore
Modified: trunk/Source/WebCore/dom/ActiveDOMObject.h (235437 => 235438)
--- trunk/Source/WebCore/dom/ActiveDOMObject.h 2018-08-28 20:50:19 UTC (rev 235437)
+++ trunk/Source/WebCore/dom/ActiveDOMObject.h 2018-08-28 20:53:17 UTC (rev 235438)
@@ -110,6 +110,8 @@
return adoptRef(*new PendingActivity(thisObject));
}
+bool isContextStopped() const;
+
protected:
explicit ActiveDOMObject(ScriptExecutionContext*);
virtual ~ActiveDOMObject();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235439] trunk/Tools
Title: [235439] trunk/Tools
Revision 235439
Author ddkil...@apple.com
Date 2018-08-28 14:02:34 -0700 (Tue, 28 Aug 2018)
Log Message
Fix incorrect use of `sourceTree = "";` for built products and frameworks in Xcode projects
Found by tidy-Xcode-project-file script (see Bug 188754).
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
(IOKit.framework): Use `sourceTree = "";` to match
other frameworks in the project.
* MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
(WebKit.framework): Use `sourceTree = BUILT_PRODUCTS_DIR;` for
built product instead of relative build directory path.
* jsc-cli/jsc-cli.xcodeproj/project.pbxproj:
(_javascript_Core.framework): Ditto.
* lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
(libWTF.a): Ditto.
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj
trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj
trunk/Tools/jsc-cli/jsc-cli.xcodeproj/project.pbxproj
trunk/Tools/lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj
Diff
Modified: trunk/Tools/ChangeLog (235438 => 235439)
--- trunk/Tools/ChangeLog 2018-08-28 20:53:17 UTC (rev 235438)
+++ trunk/Tools/ChangeLog 2018-08-28 21:02:34 UTC (rev 235439)
@@ -1,3 +1,21 @@
+2018-08-28 David Kilzer
+
+Fix incorrect use of `sourceTree = "";` for built products and frameworks in Xcode projects
+
+Found by tidy-Xcode-project-file script (see Bug 188754).
+
+* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
+(IOKit.framework): Use `sourceTree = "";` to match
+other frameworks in the project.
+* MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
+(WebKit.framework): Use `sourceTree = BUILT_PRODUCTS_DIR;` for
+built product instead of relative build directory path.
+* jsc-cli/jsc-cli.xcodeproj/project.pbxproj:
+(_javascript_Core.framework): Ditto.
+* lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
+(libWTF.a): Use `sourceTree = BUILT_PRODUCTS_DIR;` for built
+product.
+
2018-08-28 Alex Christensen
Fix 32-bit Mac build.
Modified: trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj (235438 => 235439)
--- trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2018-08-28 20:53:17 UTC (rev 235438)
+++ trunk/Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj 2018-08-28 21:02:34 UTC (rev 235439)
@@ -263,7 +263,7 @@
1A4CCD4E171375A300981040 /* ToStringAndValueOfObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ToStringAndValueOfObject.cpp; sourceTree = ""; };
1A5CC1F3137DD2EC00A5D7E7 /* GetURLWithJavaScriptURL.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = GetURLWithJavaScriptURL.cpp; sourceTree = ""; };
1A66C34F14576A920099A115 /* ContentsScaleFactor.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = ContentsScaleFactor.cpp; sourceTree = ""; };
- 1A7961061803454C00FE42CD /* IOKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = IOKit.framework; path = /System/Library/Frameworks/IOKit.framework; sourceTree = ""; };
+ 1A7961061803454C00FE42CD /* IOKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = IOKit.framework; path = /System/Library/Frameworks/IOKit.framework; sourceTree = ""; };
1A8F024C0BB9B056008CFA34 /* TestObject.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TestObject.h; sourceTree = ""; };
1AC6C77F0D07589B00CD3161 /* main.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = main.cpp; sourceTree = ""; };
1AC6C7800D07589B00CD3161 /* PluginObject.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = PluginObject.cpp; sourceTree = ""; };
Modified: trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj (235438 => 235439)
--- trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj 2018-08-28 20:53:17 UTC (rev 235438)
+++ trunk/Tools/MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj 2018-08-28 21:02:34 UTC (rev 235439)
@@ -82,7 +82,7 @@
CD1DAFBB1D709EF200017CF0 /* TabViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = TabViewController.m; sourceTree = ""; };
CD1DAFBC1D709EF200017CF0 /* WebViewController.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WebViewController.h; sourceTree = ""; };
CD1DAFBD1D709EF200017CF0 /* WebViewController.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = WebViewController.m; sourceTree
[webkit-changes] [235440] trunk
Title: [235440] trunk
Revision 235440
Author sihui_...@apple.com
Date 2018-08-28 14:26:22 -0700 (Tue, 28 Aug 2018)
Log Message
Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
https://bugs.webkit.org/show_bug.cgi?id=189037
Reviewed by Chris Dumez.
Source/WebKit:
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _getMainResourceDataWithCompletionHandler:]):
(-[WKWebView _getWebArchiveDataWithCompletionHandler:]):
(-[WKWebView _getContentsAsStringWithCompletionHandler:]):
Tools:
* TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
(TEST):
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm
trunk/Tools/ChangeLog
trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm
Diff
Modified: trunk/Source/WebKit/ChangeLog (235439 => 235440)
--- trunk/Source/WebKit/ChangeLog 2018-08-28 21:02:34 UTC (rev 235439)
+++ trunk/Source/WebKit/ChangeLog 2018-08-28 21:26:22 UTC (rev 235440)
@@ -1,3 +1,15 @@
+2018-08-28 Sihui Liu
+
+Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
+https://bugs.webkit.org/show_bug.cgi?id=189037
+
+Reviewed by Chris Dumez.
+
+* UIProcess/API/Cocoa/WKWebView.mm:
+(-[WKWebView _getMainResourceDataWithCompletionHandler:]):
+(-[WKWebView _getWebArchiveDataWithCompletionHandler:]):
+(-[WKWebView _getContentsAsStringWithCompletionHandler:]):
+
2018-08-28 Basuke Suzuki
[Curl] Fix issue that extra cookie is added when redirect happens.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (235439 => 235440)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-08-28 21:02:34 UTC (rev 235439)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-08-28 21:26:22 UTC (rev 235440)
@@ -4573,8 +4573,7 @@
void (^completionHandlerBlock)(NSData *, NSError *) = (void (^)(NSData *, NSError *))handler.get();
if (error != WebKit::CallbackBase::Error::None) {
// FIXME: Pipe a proper error in from the WebPageProxy.
-RetainPtr error = adoptNS([[NSError alloc] init]);
-completionHandlerBlock(nil, error.get());
+completionHandlerBlock(nil, [NSError errorWithDomain:WKErrorDomain code:static_cast(error) userInfo:nil]);
} else
completionHandlerBlock(wrapper(*data), nil);
});
@@ -4588,8 +4587,7 @@
void (^completionHandlerBlock)(NSData *, NSError *) = (void (^)(NSData *, NSError *))handler.get();
if (error != WebKit::CallbackBase::Error::None) {
// FIXME: Pipe a proper error in from the WebPageProxy.
-RetainPtr error = adoptNS([[NSError alloc] init]);
-completionHandlerBlock(nil, error.get());
+completionHandlerBlock(nil, [NSError errorWithDomain:WKErrorDomain code:static_cast(error) userInfo:nil]);
} else
completionHandlerBlock(wrapper(*data), nil);
});
@@ -4602,8 +4600,7 @@
_page->getContentsAsString([handler](String string, WebKit::CallbackBase::Error error) {
if (error != WebKit::CallbackBase::Error::None) {
// FIXME: Pipe a proper error in from the WebPageProxy.
-RetainPtr error = adoptNS([[NSError alloc] init]);
-handler(nil, error.get());
+handler(nil, [NSError errorWithDomain:WKErrorDomain code:static_cast(error) userInfo:nil]);
} else
handler(string, nil);
});
Modified: trunk/Tools/ChangeLog (235439 => 235440)
--- trunk/Tools/ChangeLog 2018-08-28 21:02:34 UTC (rev 235439)
+++ trunk/Tools/ChangeLog 2018-08-28 21:26:22 UTC (rev 235440)
@@ -1,3 +1,13 @@
+2018-08-28 Sihui Liu
+
+Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
+https://bugs.webkit.org/show_bug.cgi?id=189037
+
+Reviewed by Chris Dumez.
+
+* TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
+(TEST):
+
2018-08-28 David Kilzer
Fix incorrect use of `sourceTree = "";` for built products and frameworks in Xcode projects
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm (235439 => 235440)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm 2018-08-28 21:02:34 UTC (rev 235439)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm 2018-08-28 21:26:22 UTC (rev 235440)
@@ -229,19 +229,22 @@
__block WKWebView *view = webView.get();
[webView _getContentsAsStringWithCompletionHandler:^(NSString *contents, NSError *error) {
-EXPECT_TRUE(!!error);
+if (!!error)
+EXPECT_EQ(WKErrorWebContentProcessTerminated, error.code);
++callbackCount;
if (callbackCount == 6)
calledAllCallbacks = true;
}];
[webView _getContentsAsStringWithCo
[webkit-changes] [235441] trunk/LayoutTests
Title: [235441] trunk/LayoutTests Revision 235441 Author tsav...@apple.com Date 2018-08-28 14:30:46 -0700 (Tue, 28 Aug 2018) Log Message Moving test expectations for webkit.org/b/188985 from mac-wk2 to General test expectations due to failing on iOS. https://bugs.webkit.org/show_bug.cgi?id=188985 Unreviewed test gardening. * TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (235440 => 235441) --- trunk/LayoutTests/ChangeLog 2018-08-28 21:26:22 UTC (rev 235440) +++ trunk/LayoutTests/ChangeLog 2018-08-28 21:30:46 UTC (rev 235441) @@ -1,3 +1,13 @@ +2018-08-28 Truitt Savell + +Moving test expectations for webkit.org/b/188985 from mac-wk2 to General test expectations due to failing on iOS. +https://bugs.webkit.org/show_bug.cgi?id=188985 + +Unreviewed test gardening. + +* TestExpectations: +* platform/mac-wk2/TestExpectations: + 2018-08-28 Youenn Fablet MediaDevices should be collectable as soon as its document is stopped Modified: trunk/LayoutTests/TestExpectations (235440 => 235441) --- trunk/LayoutTests/TestExpectations 2018-08-28 21:26:22 UTC (rev 235440) +++ trunk/LayoutTests/TestExpectations 2018-08-28 21:30:46 UTC (rev 235441) @@ -2235,3 +2235,30 @@ # This test is currently only relevant on mac-wk2 fast/canvas/webgl/context-update-on-display-configuration.html [ Skip ] + +# skip manual payment-request tests +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentValidationErrors/retry-shows-error-member-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/algorithms-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/change-shipping-option-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/change-shipping-option-select-last-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/complete-method-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/methodName-attribute-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/onpayerdetailchange-attribute.manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/payerEmail-attribute-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/payerName-attribute-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/payerPhone-attribute-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/rejects_if_not_active-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/requestId-attribute-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/retry-method-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/shippingAddress-attribute-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/shippingOption-attribute-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentAddress/attributes-and-toJSON-method-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/shipping-address-changed-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-resolves-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/show-method-postmessage-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/updateWith-method-pmi-handling-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/user-abort-algorithm-manual.https.html [ Skip ] +webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html [ Skip ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (235440 => 235441) --- trunk/LayoutTest
[webkit-changes] [235442] trunk/Source/WebKit
Title: [235442] trunk/Source/WebKit
Revision 235442
Author wenson_hs...@apple.com
Date 2018-08-28 15:05:20 -0700 (Tue, 28 Aug 2018)
Log Message
Remove references to "APIAttachmentCocoa.h" in WebKit.xcodeproj
Follow-up to https://bugs.webkit.org/show_bug.cgi?id=188933
Rubber-stamped by David Kilzer.
This header was not removed from the Xcode project file after being deleted.
* WebKit.xcodeproj/project.pbxproj:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/WebKit/ChangeLog (235441 => 235442)
--- trunk/Source/WebKit/ChangeLog 2018-08-28 21:30:46 UTC (rev 235441)
+++ trunk/Source/WebKit/ChangeLog 2018-08-28 22:05:20 UTC (rev 235442)
@@ -1,3 +1,14 @@
+2018-08-28 Wenson Hsieh
+
+Remove references to "APIAttachmentCocoa.h" in WebKit.xcodeproj
+Follow-up to https://bugs.webkit.org/show_bug.cgi?id=188933
+
+Rubber-stamped by David Kilzer.
+
+This header was not removed from the Xcode project file after being deleted.
+
+* WebKit.xcodeproj/project.pbxproj:
+
2018-08-28 Sihui Liu
Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
Modified: trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj (235441 => 235442)
--- trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-08-28 21:30:46 UTC (rev 235441)
+++ trunk/Source/WebKit/WebKit.xcodeproj/project.pbxproj 2018-08-28 22:05:20 UTC (rev 235442)
@@ -1811,7 +1811,6 @@
ED82A7F2128C6FAF004477B3 /* WKBundlePageOverlay.h in Headers */ = {isa = PBXBuildFile; fileRef = 1A22F0FF1289FCD90085E74F /* WKBundlePageOverlay.h */; settings = {ATTRIBUTES = (Private, ); }; };
EDCA71B7128DDA8C00201B26 /* WKBundlePageOverlay.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 1A22F1001289FCD90085E74F /* WKBundlePageOverlay.cpp */; };
F409BA181E6E64BC009DA28E /* WKDragDestinationAction.h in Headers */ = {isa = PBXBuildFile; fileRef = F409BA171E6E64B3009DA28E /* WKDragDestinationAction.h */; settings = {ATTRIBUTES = (Private, ); }; };
- F41056622130699A0092281D /* APIAttachmentCocoa.h in Headers */ = {isa = PBXBuildFile; fileRef = F41056602130699A0092281D /* APIAttachmentCocoa.h */; };
F41056632130699A0092281D /* APIAttachmentCocoa.mm in Sources */ = {isa = PBXBuildFile; fileRef = F41056612130699A0092281D /* APIAttachmentCocoa.mm */; };
F44291921FA591C9002CC93E /* _WKAttachment.h in Headers */ = {isa = PBXBuildFile; fileRef = F44291911FA59107002CC93E /* _WKAttachment.h */; settings = {ATTRIBUTES = (Private, ); }; };
F44291941FA59311002CC93E /* _WKAttachment.mm in Sources */ = {isa = PBXBuildFile; fileRef = F44291931FA59311002CC93E /* _WKAttachment.mm */; };
@@ -4656,7 +4655,6 @@
ECBFC1DB1E6A4D66000300C7 /* ExtraPublicSymbolsForTAPI.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ExtraPublicSymbolsForTAPI.h; sourceTree = ""; };
F036978715F4BF0500C3A80E /* WebColorPicker.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = WebColorPicker.cpp; sourceTree = ""; };
F409BA171E6E64B3009DA28E /* WKDragDestinationAction.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = WKDragDestinationAction.h; sourceTree = ""; };
- F41056602130699A0092281D /* APIAttachmentCocoa.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = APIAttachmentCocoa.h; sourceTree = ""; };
F41056612130699A0092281D /* APIAttachmentCocoa.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = APIAttachmentCocoa.mm; sourceTree = ""; };
F44291911FA59107002CC93E /* _WKAttachment.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = _WKAttachment.h; sourceTree = ""; };
F44291931FA59311002CC93E /* _WKAttachment.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = _WKAttachment.mm; sourceTree = ""; };
@@ -6213,7 +6211,6 @@
5CB237891DF0DD4300117AA3 /* _WKWebsitePolicies.h */,
5CB2378A1DF0DD4300117AA3 /* _WKWebsitePolicies.mm */,
5CB2378D1DF0E0C200117AA3 /* _WKWebsitePoliciesInternal.h */,
-F41056602130699A0092281D /* APIAttachmentCocoa.h */,
F41056612130699A0092281D /* APIAttachmentCocoa.mm */,
7CEFA9601AC0999300B910FD /* APIContentRuleListStoreCocoa.mm */,
FED3C1DA1B447AE800E0EB7F /* APISerializedScriptValueCocoa.mm */,
@@ -9004,7 +9001,6 @@
634842511FB26E7100946E3C /* APIApplicationManifest.h in Headers */,
BC64697011DBE603006455B0 /* APIArray.h in Headers */,
2E5C770E1FA7D429005932C3 /* APIAttachment.h in Headers */,
-F41056622130699A0092281D /* APIAttachmentCocoa.h in Headers */,
99C81D5D1C21F38B005C4C82 /* APIAutomationClient.h in Headers */,
990D28C01C6553F100986977 /* APIAutomationSessionClient.h in Headers */,
1A3DD206125E5A2F004515E6 /* APIClient.h in Headers */,
___
w
[webkit-changes] [235443] trunk/Source/ThirdParty/ANGLE
Title: [235443] trunk/Source/ThirdParty/ANGLE
Revision 235443
Author ddkil...@apple.com
Date 2018-08-28 15:13:27 -0700 (Tue, 28 Aug 2018)
Log Message
Move PMurHash.{cpp,h} into 'src' folder to match path on disk
* ANGLE.xcodeproj/project.pbxproj:
(src/common/third_party/smhasher/src): Add folder and move
PMurHash.{cpp,h} into it. This makes tidy-Xcode-project-file
run smoothly when updating the ANGLE project.
Modified Paths
trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj
trunk/Source/ThirdParty/ANGLE/ChangeLog
Diff
Modified: trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj (235442 => 235443)
--- trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2018-08-28 22:05:20 UTC (rev 235442)
+++ trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj 2018-08-28 22:13:27 UTC (rev 235443)
@@ -1411,8 +1411,7 @@
315EBE251FCF806A00AC7A89 /* smhasher */ = {
isa = PBXGroup;
children = (
-315EBE261FCF808C00AC7A89 /* PMurHash.cpp */,
-315EBE271FCF808C00AC7A89 /* PMurHash.h */,
+44B8F2972135FBC200A99829 /* src */,
);
name = smhasher;
sourceTree = "";
@@ -1425,6 +1424,15 @@
name = trace_event;
sourceTree = "";
};
+ 44B8F2972135FBC200A99829 /* src */ = {
+ isa = PBXGroup;
+ children = (
+315EBE261FCF808C00AC7A89 /* PMurHash.cpp */,
+315EBE271FCF808C00AC7A89 /* PMurHash.h */,
+ );
+ name = src;
+ sourceTree = "";
+ };
5C1BAA931DFB60E2002906BB /* EGL */ = {
isa = PBXGroup;
children = (
Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (235442 => 235443)
--- trunk/Source/ThirdParty/ANGLE/ChangeLog 2018-08-28 22:05:20 UTC (rev 235442)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog 2018-08-28 22:13:27 UTC (rev 235443)
@@ -1,3 +1,12 @@
+2018-08-28 David Kilzer
+
+Move PMurHash.{cpp,h} into 'src' folder to match path on disk
+
+* ANGLE.xcodeproj/project.pbxproj:
+(src/common/third_party/smhasher/src): Add folder and move
+PMurHash.{cpp,h} into it. This makes tidy-Xcode-project-file
+run smoothly when updating the ANGLE project.
+
2018-08-27 Keith Rollin
Unreviewed build fix -- disable LTO for production builds
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235444] trunk/Source/WebKit
Title: [235444] trunk/Source/WebKit
Revision 235444
Author achristen...@apple.com
Date 2018-08-28 15:25:38 -0700 (Tue, 28 Aug 2018)
Log Message
Remove assertion introduced in r235413
https://bugs.webkit.org/show_bug.cgi?id=188701
* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):
r235413 did not change behavior. The assertion was invalid.
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp
Diff
Modified: trunk/Source/WebKit/ChangeLog (235443 => 235444)
--- trunk/Source/WebKit/ChangeLog 2018-08-28 22:13:27 UTC (rev 235443)
+++ trunk/Source/WebKit/ChangeLog 2018-08-28 22:25:38 UTC (rev 235444)
@@ -1,3 +1,12 @@
+2018-08-28 Alex Christensen
+
+Remove assertion introduced in r235413
+https://bugs.webkit.org/show_bug.cgi?id=188701
+
+* NetworkProcess/NetworkResourceLoader.cpp:
+(WebKit::NetworkResourceLoader::didFinishWithRedirectResponse):
+r235413 did not change behavior. The assertion was invalid.
+
2018-08-28 Wenson Hsieh
Remove references to "APIAttachmentCocoa.h" in WebKit.xcodeproj
Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (235443 => 235444)
--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2018-08-28 22:13:27 UTC (rev 235443)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp 2018-08-28 22:25:38 UTC (rev 235444)
@@ -641,9 +641,7 @@
void NetworkResourceLoader::didFinishWithRedirectResponse(ResourceResponse&& redirectResponse)
{
redirectResponse.setType(ResourceResponse::Type::Opaqueredirect);
-didReceiveResponse(WTFMove(redirectResponse), [](auto action) {
-ASSERT_UNUSED(action, action == PolicyAction::Use);
-});
+didReceiveResponse(WTFMove(redirectResponse), [] (auto) { });
WebCore::NetworkLoadMetrics networkLoadMetrics;
networkLoadMetrics.markComplete();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235445] trunk/Tools
Title: [235445] trunk/Tools
Revision 235445
Author dba...@webkit.org
Date 2018-08-28 16:04:30 -0700 (Tue, 28 Aug 2018)
Log Message
lldb-webkit: KeyError thrown for OptionSet
https://bugs.webkit.org/show_bug.cgi?id=189062
Reviewed by Simon Fraser.
For some reason lldb(1) may not retrieve the enumerator names for an enum value
when it calls update() on the synthetic children provider. If this occurs then
bail out as we cannot compute what enumerators are in the set.
* lldb/lldb_webkit.py:
(WTFOptionSetProvider.update):
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/lldb/lldb_webkit.py
Diff
Modified: trunk/Tools/ChangeLog (235444 => 235445)
--- trunk/Tools/ChangeLog 2018-08-28 22:25:38 UTC (rev 235444)
+++ trunk/Tools/ChangeLog 2018-08-28 23:04:30 UTC (rev 235445)
@@ -1,3 +1,17 @@
+2018-08-28 Daniel Bates
+
+lldb-webkit: KeyError thrown for OptionSet
+https://bugs.webkit.org/show_bug.cgi?id=189062
+
+Reviewed by Simon Fraser.
+
+For some reason lldb(1) may not retrieve the enumerator names for an enum value
+when it calls update() on the synthetic children provider. If this occurs then
+bail out as we cannot compute what enumerators are in the set.
+
+* lldb/lldb_webkit.py:
+(WTFOptionSetProvider.update):
+
2018-08-28 Sihui Liu
Add error information to help debug test failure in WKNavigation.ProcessCrashDuringCallback
Modified: trunk/Tools/lldb/lldb_webkit.py (235444 => 235445)
--- trunk/Tools/lldb/lldb_webkit.py 2018-08-28 22:25:38 UTC (rev 235444)
+++ trunk/Tools/lldb/lldb_webkit.py 2018-08-28 23:04:30 UTC (rev 235445)
@@ -616,6 +616,8 @@
template_argument_sbType = self.valobj.GetType().GetTemplateArgumentType(0)
enumerator_value_to_name_map = {sbTypeEnumMember.GetValueAsUnsigned(): sbTypeEnumMember.GetName() for sbTypeEnumMember in template_argument_sbType.get_enum_members_array()}
+if not enumerator_value_to_name_map:
+return
# Iterate from least significant bit to most significant bit.
elements = []
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235446] trunk/LayoutTests
Title: [235446] trunk/LayoutTests Revision 235446 Author david_fen...@apple.com Date 2018-08-28 16:20:20 -0700 (Tue, 28 Aug 2018) Log Message Layout Test imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https.html is flaky https://bugs.webkit.org/show_bug.cgi?id=187935 Unreviewed test gardening. * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (235445 => 235446) --- trunk/LayoutTests/ChangeLog 2018-08-28 23:04:30 UTC (rev 235445) +++ trunk/LayoutTests/ChangeLog 2018-08-28 23:20:20 UTC (rev 235446) @@ -1,3 +1,12 @@ +2018-08-28 David Fenton + +Layout Test imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https.html is flaky +https://bugs.webkit.org/show_bug.cgi?id=187935 + +Unreviewed test gardening. + +* platform/mac-wk2/TestExpectations: + 2018-08-28 Truitt Savell Moving test expectations for webkit.org/b/188985 from mac-wk2 to General test expectations due to failing on iOS. Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (235445 => 235446) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-08-28 23:04:30 UTC (rev 235445) +++ trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-08-28 23:20:20 UTC (rev 235446) @@ -606,6 +606,8 @@ webkit.org/b/164870 [ Debug ] imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm [ Pass Failure ] +webkit.org/b/187935 [ Release ] imported/w3c/web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html [ Pass Failure ] + webkit.org/b/165352 fast/dom/Window/window-resize-contents.html [ Pass Timeout ] webkit.org/b/167653 http/tests/contentextensions/block-everything-unless-domain.html [ Pass Timeout ] ___ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235447] trunk/Source/WebInspectorUI
Title: [235447] trunk/Source/WebInspectorUI
Revision 235447
Author drou...@apple.com
Date 2018-08-28 16:26:58 -0700 (Tue, 28 Aug 2018)
Log Message
Web Inspector: Search bar is too narrow in some localizations
https://bugs.webkit.org/show_bug.cgi?id=189060
Reviewed by Brian Burg.
* UserInterface/Views/Toolbar.css:
(.toolbar .search-bar):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (235446 => 235447)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-08-28 23:20:20 UTC (rev 235446)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-08-28 23:26:58 UTC (rev 235447)
@@ -1,3 +1,14 @@
+2018-08-28 Devin Rousso
+
+Web Inspector: Search bar is too narrow in some localizations
+https://bugs.webkit.org/show_bug.cgi?id=189060
+
+
+Reviewed by Brian Burg.
+
+* UserInterface/Views/Toolbar.css:
+(.toolbar .search-bar):
+
2018-08-27 Keith Rollin
Unreviewed build fix -- disable LTO for production builds
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css (235446 => 235447)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2018-08-28 23:20:20 UTC (rev 235446)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Toolbar.css 2018-08-28 23:26:58 UTC (rev 235447)
@@ -118,7 +118,7 @@
.toolbar .search-bar {
width: 100%;
-min-width: 100px;
+min-width: 125px;
}
.toolbar .search-bar > input[type="search"] {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235448] trunk/Source
Title: [235448] trunk/Source Revision 235448 Author wenson_hs...@apple.com Date 2018-08-28 16:28:19 -0700 (Tue, 28 Aug 2018) Log Message Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm https://bugs.webkit.org/show_bug.cgi?id=189054 Reviewed by Andy Estes. Source/WebCore: Remove the pasteboard type argument from PlatformPasteboard::readURL(). Currently, we only ever pass it "public.url" anyways; for reading other types of strings, readString() already exists, which takes an arbitrary pasteboard type. * platform/PasteboardStrategy.h: * platform/PlatformPasteboard.h: * platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::readPasteboardWebContentDataForType): (WebCore::Pasteboard::readPlatformValueAsString): * platform/ios/PlatformPasteboardIOS.mm: (WebCore::PlatformPasteboard::readURL): Source/WebKit: Remove the pasteboard type argument from readURLFromPasteboard. * UIProcess/Cocoa/WebPasteboardProxyCocoa.mm: (WebKit::WebPasteboardProxy::readURLFromPasteboard): * UIProcess/WebPasteboardProxy.h: * UIProcess/WebPasteboardProxy.messages.in: * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp: (WebKit::WebPlatformStrategies::readURLFromPasteboard): * WebProcess/WebCoreSupport/WebPlatformStrategies.h: Source/WebKitLegacy/mac: Remove the pasteboard type argument from readURLFromPasteboard. * WebCoreSupport/WebPlatformStrategies.h: * WebCoreSupport/WebPlatformStrategies.mm: (WebPlatformStrategies::readURLFromPasteboard): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/PasteboardStrategy.h trunk/Source/WebCore/platform/PlatformPasteboard.h trunk/Source/WebCore/platform/ios/PasteboardIOS.mm trunk/Source/WebCore/platform/ios/PlatformPasteboardIOS.mm trunk/Source/WebKit/ChangeLog trunk/Source/WebKit/UIProcess/Cocoa/WebPasteboardProxyCocoa.mm trunk/Source/WebKit/UIProcess/WebPasteboardProxy.h trunk/Source/WebKit/UIProcess/WebPasteboardProxy.messages.in trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp trunk/Source/WebKit/WebProcess/WebCoreSupport/WebPlatformStrategies.h trunk/Source/WebKitLegacy/mac/ChangeLog trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.h trunk/Source/WebKitLegacy/mac/WebCoreSupport/WebPlatformStrategies.mm Diff Modified: trunk/Source/WebCore/ChangeLog (235447 => 235448) --- trunk/Source/WebCore/ChangeLog 2018-08-28 23:26:58 UTC (rev 235447) +++ trunk/Source/WebCore/ChangeLog 2018-08-28 23:28:19 UTC (rev 235448) @@ -1,3 +1,22 @@ +2018-08-28 Wenson Hsieh + +Work towards: [iOS] Consolidate the implementations of readString, stringForType, and readURL in PlatformPasteboardIOS.mm +https://bugs.webkit.org/show_bug.cgi?id=189054 + +Reviewed by Andy Estes. + +Remove the pasteboard type argument from PlatformPasteboard::readURL(). Currently, we only ever pass it +"public.url" anyways; for reading other types of strings, readString() already exists, which takes an arbitrary +pasteboard type. + +* platform/PasteboardStrategy.h: +* platform/PlatformPasteboard.h: +* platform/ios/PasteboardIOS.mm: +(WebCore::Pasteboard::readPasteboardWebContentDataForType): +(WebCore::Pasteboard::readPlatformValueAsString): +* platform/ios/PlatformPasteboardIOS.mm: +(WebCore::PlatformPasteboard::readURL): + 2018-08-28 Youenn Fablet MediaDevices should be collectable as soon as its document is stopped Modified: trunk/Source/WebCore/platform/PasteboardStrategy.h (235447 => 235448) --- trunk/Source/WebCore/platform/PasteboardStrategy.h 2018-08-28 23:26:58 UTC (rev 235447) +++ trunk/Source/WebCore/platform/PasteboardStrategy.h 2018-08-28 23:28:19 UTC (rev 235448) @@ -50,7 +50,7 @@ virtual int getPasteboardItemsCount(const String& pasteboardName) = 0; virtual String readStringFromPasteboard(int index, const String& pasteboardType, const String& pasteboardName) = 0; virtual RefPtr readBufferFromPasteboard(int index, const String& pasteboardType, const String& pasteboardName) = 0; -virtual URL readURLFromPasteboard(int index, const String& pasteboardType, const String& pasteboardName, String& title) = 0; +virtual URL readURLFromPasteboard(int index, const String& pasteboardName, String& title) = 0; virtual Vector allPasteboardItemInfo(const String& pasteboardName) = 0; virtual PasteboardItemInfo informationForItemAtIndex(int index, const String& pasteboardName) = 0; virtual void updateSupportedTypeIdentifiers(const Vector& identifiers, const String& pasteboardName) = 0; Modified: trunk/Source/WebCore/platform/PlatformPasteboard.h (235447 => 235448) --- trunk/Source/WebCore/platform/PlatformPasteboard.h 2018-08-28 23:26:58 UTC (rev 235447) +++ trunk/Source/WebCore/platform/PlatformPasteboard.h 2018-08-28 23:28:19 UTC (rev 235448) @@ -93,7 +93,7 @@ WEBCORE_EXPORT void write(const PasteboardURL&);
[webkit-changes] [235449] trunk/LayoutTests
Title: [235449] trunk/LayoutTests Revision 235449 Author tsav...@apple.com Date 2018-08-28 16:40:05 -0700 (Tue, 28 Aug 2018) Log Message Edditing test expectations from webkit.org/b/188985. https://bugs.webkit.org/show_bug.cgi?id=188985 Unreviewed test gardening. * TestExpectations: * platform/mac-wk2/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/TestExpectations trunk/LayoutTests/platform/mac-wk2/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (235448 => 235449) --- trunk/LayoutTests/ChangeLog 2018-08-28 23:28:19 UTC (rev 235448) +++ trunk/LayoutTests/ChangeLog 2018-08-28 23:40:05 UTC (rev 235449) @@ -1,3 +1,13 @@ +2018-08-28 Truitt Savell + +Edditing test expectations from webkit.org/b/188985. +https://bugs.webkit.org/show_bug.cgi?id=188985 + +Unreviewed test gardening. + +* TestExpectations: +* platform/mac-wk2/TestExpectations: + 2018-08-28 David Fenton Layout Test imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https.html is flaky Modified: trunk/LayoutTests/TestExpectations (235448 => 235449) --- trunk/LayoutTests/TestExpectations 2018-08-28 23:28:19 UTC (rev 235448) +++ trunk/LayoutTests/TestExpectations 2018-08-28 23:40:05 UTC (rev 235449) @@ -2235,30 +2235,3 @@ # This test is currently only relevant on mac-wk2 fast/canvas/webgl/context-update-on-display-configuration.html [ Skip ] - -# skip manual payment-request tests -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentValidationErrors/retry-shows-error-member-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentValidationErrors/retry-shows-payer-member-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentValidationErrors/retry-shows-shippingAddress-member-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/algorithms-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/change-shipping-option-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/change-shipping-option-select-last-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/complete-method-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/methodName-attribute-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/onpayerdetailchange-attribute.manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/payerEmail-attribute-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/payerName-attribute-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/payerPhone-attribute-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/rejects_if_not_active-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/requestId-attribute-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/retry-method-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/shippingAddress-attribute-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/payment-response/shippingOption-attribute-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/PaymentAddress/attributes-and-toJSON-method-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/shipping-address-changed-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-rejects-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/show-method-optional-promise-resolves-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/show-method-postmessage-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/updateWith-method-pmi-handling-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/user-abort-algorithm-manual.https.html [ Skip ] -webkit.org/b/188985 imported/w3c/web-platform-tests/payment-request/user-accepts-payment-request-algo-manual.https.html [ Skip ] Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (235448 => 235449) --- trunk/LayoutTests/platform/mac-wk2/TestExpectations 2018-08-28 23:28:19 UTC (rev 235448)
[webkit-changes] [235450] trunk/Source/JavaScriptCore
Title: [235450] trunk/Source/_javascript_Core
Revision 235450
Author mark@apple.com
Date 2018-08-28 16:43:59 -0700 (Tue, 28 Aug 2018)
Log Message
Fix bit-rotted Interpreter::dumpRegisters() and move it to the VMInspector.
https://bugs.webkit.org/show_bug.cgi?id=189059
Reviewed by Saam Barati.
1. Moved Interpreter::dumpRegisters() to VMInspector::dumpRegisters().
2. Added $vm.dumpRegisters().
Usage: $vm.dumpRegisters(N) // dump the registers of the Nth CallFrame.
Usage: $vm.dumpRegisters() // dump the registers of the current CallFrame.
Note: Currently, $vm.dumpRegisters() only dump registers in the physical frame.
It will treat inlined frames content as registers in the bounding physical frame.
Here's an example of such a dump on a DFG frame:
Register frame:
-
use| address |value
-
[r 12 arguments[ 7]] | 0x7ffeefbfd330 | 0xaUndefined
[r 11 arguments[ 6]] | 0x7ffeefbfd328 | 0x10bbb3e80Object: 0x10bbb3e80 with butterfly 0x0 (Structure 0x10bbf20d0:[Object, {}, NonArray, Proto:0x10bbb4000]), StructureID: 76
[r 10 arguments[ 5]] | 0x7ffeefbfd320 | 0xaUndefined
[r 9 arguments[ 4]] | 0x7ffeefbfd318 | 0xaUndefined
[r 8 arguments[ 3]] | 0x7ffeefbfd310 | 0xaUndefined
[r 7 arguments[ 2]] | 0x7ffeefbfd308 | 0x000a5eaa Int32: 679594
[r 6 arguments[ 1]] | 0x7ffeefbfd300 | 0x10bbd00f0Object: 0x10bbd00f0 with butterfly 0x8000f8248 (Structure 0x10bba4700:[Function, {name:100, prototype:101, length:102, Symbol.species:103, isArray:104}, NonArray, Proto:0x10bbd, Leaf]), StructureID: 160
[r 5 this] | 0x7ffeefbfd2f8 | 0x10bbeObject: 0x10bbe with butterfly 0x8000d8808 (Structure 0x10bb35340:[global, {parseInt:100, parseFloat:101, Object:102, Function:103, Array:104, RegExp:105, RangeError:106, TypeError:107, PrivateSymbol.Object:108, PrivateSymbol.Array:109, ArrayBuffer:110, String:111, Symbol:112, Number:113, Boolean:114, Error:115, Map:116, Set:117, Promise:118, eval:119, Reflect:121, $vm:122, WebAssembly:123, debug:124, describe:125, describeArray:126, print:127, printErr:128, quit:129, gc:130, fullGC:131, edenGC:132, forceGCSlowPaths:133, gcHeapSize:134, addressOf:135, version:136, run:137, runString:138, load:139, loadString:140, readFile:141, read:142, checkSyntax:143, sleepSeconds:144, jscStack:145, readline:146, preciseTime:147, neverInlineFunction:148, noInline:149, noDFG:150, noFTL:151, numberOfDFGCompiles:153, jscOptions:154, optimizeNextInvocation:155, reoptimizationRetryCount:156, transferArrayBuffer:157, failNextNew
CodeBlock:158, OSRExit:159, isFinalTier:160, predictInt32:161, isInt32:162, isPureNaN:163, fiatInt52:164, effectful42:165, makeMasquerader:166, hasCustomProperties:167, createGlobalObject:168, dumpTypesForAllVariables:169, drainMicrotasks:170, getRandomSeed:171, setRandomSeed:172, isRope:173, callerSourceOrigin:174, is32BitPlatform:175, loadModule:176, checkModuleSyntax:177, platformSupportsSamplingProfiler:178, generateHeapSnapshot:179, resetSuperSamplerState:180, ensureArrayStorage:181, startSamplingProfiler:182, samplingProfilerStackTraces:183, maxArguments:184, asyncTestStart:185, asyncTestPassed:186, WebAssemblyMemoryMode:187, console:188, $:189, $262:190, waitForReport:191, heapCapacity:192, flashHeapAccess:193, disableRichSourceInfo:194, mallocInALoop:195, totalCompileTime:196, Proxy:197, uneval:198, WScript:199, failWithMessage:200, triggerAssertFalse:201, isNaN:202, isFinite:203, escape:204, unescape:205, decodeURI:206, decodeURIComponent:207, encodeURI:208, encodeURICompon
ent:209, EvalError:210, ReferenceError:211, SyntaxError:212, URIError:213, JSON:214, Math:215, Int8Array:216, PrivateSymbol.Int8Array:217, Int16Array:218, PrivateSymbol.Int16Array:219, Int32Array:220, PrivateSymbol.Int32Array:221, Uint8Array:222, PrivateSymbol.Uint8Array:223, Uint8ClampedArray:224, PrivateSymbol.Uint8ClampedArray:225, Uint16Array:226, PrivateSymbol.Uint16Array:227, Uint32Array:228, PrivateSymbol.Uint32Array:229, Float32Array:230, PrivateSymbol.Float32Array:231, Float64Array:232, PrivateSymbol.Float64Array:233, DataView:234, Date:235, WeakMap:236, WeakSet:237, Intl:120, desc:238}, NonArray, Proto:0x10bbb4000, UncacheableDictionary, Leaf]), StructureID: 474
-
[ArgumentCount]| 0x7ffeefbfd2f0 | 7
[ReturnVPC]| 0x7ffeefbfd2f0 | 164 (line 57)
[Callee] | 0x7ffeefbfd2e8 | 0x10bb68db0Object: 0x10bb68db0 with butterfly 0x0 (Structure 0x10bbf1c00:[Fun
[webkit-changes] [235451] trunk/Source/WebInspectorUI
Title: [235451] trunk/Source/WebInspectorUI
Revision 235451
Author drou...@apple.com
Date 2018-08-28 17:06:40 -0700 (Tue, 28 Aug 2018)
Log Message
Web Inspector: REGRESSION: CanvasSidebarPanel is empty for imported recordings
https://bugs.webkit.org/show_bug.cgi?id=189061
Reviewed by Brian Burg.
When recordings are imported, they don't have an associated `WI.Canvas`, meaning that the
`WI.Recording` is never added to the canvas' `WI.RecordingCollection`. Previously, the
canvas sidebar relied upon the `ItemAdded` event to update the recording `WI.ScopeBar`.
Since the imported recording isn't ever added to the collection, this is never fired.
This patch moves the function call that updates the `WI.ScopeBar` to a more universal path,
ensuring that no matter how a `WI.Recording` is set for the sidebar, it will be shown.
* UserInterface/Views/CanvasSidebarPanel.js:
(WI.CanvasSidebarPanel.prototype.set recording):
(WI.CanvasSidebarPanel.prototype._recordingAdded):
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
Modified Paths
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (235450 => 235451)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-08-28 23:43:59 UTC (rev 235450)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-08-29 00:06:40 UTC (rev 235451)
@@ -1,5 +1,25 @@
2018-08-28 Devin Rousso
+Web Inspector: REGRESSION: CanvasSidebarPanel is empty for imported recordings
+https://bugs.webkit.org/show_bug.cgi?id=189061
+
+Reviewed by Brian Burg.
+
+When recordings are imported, they don't have an associated `WI.Canvas`, meaning that the
+`WI.Recording` is never added to the canvas' `WI.RecordingCollection`. Previously, the
+canvas sidebar relied upon the `ItemAdded` event to update the recording `WI.ScopeBar`.
+Since the imported recording isn't ever added to the collection, this is never fired.
+
+This patch moves the function call that updates the `WI.ScopeBar` to a more universal path,
+ensuring that no matter how a `WI.Recording` is set for the sidebar, it will be shown.
+
+* UserInterface/Views/CanvasSidebarPanel.js:
+(WI.CanvasSidebarPanel.prototype.set recording):
+(WI.CanvasSidebarPanel.prototype._recordingAdded):
+(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
+
+2018-08-28 Devin Rousso
+
Web Inspector: Search bar is too narrow in some localizations
https://bugs.webkit.org/show_bug.cgi?id=189060
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js (235450 => 235451)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2018-08-28 23:43:59 UTC (rev 235450)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js 2018-08-29 00:06:40 UTC (rev 235451)
@@ -119,6 +119,8 @@
this._recording.addEventListener(WI.Recording.Event.StartProcessingFrame, this._handleRecordingStartProcessingFrame, this);
}
+this._updateRecordNavigationItem();
+this._updateRecordingScopeBar();
this._recordingChanged();
}
@@ -221,9 +223,6 @@
_recordingAdded(event)
{
-this._updateRecordNavigationItem();
-this._updateRecordingScopeBar();
-
this.recording = event.data.item;
}
@@ -458,7 +457,7 @@
this._recordingNavigationBar.element.classList.toggle("hidden", !this._canvas);
-let hasRecordings = this._canvas && this._canvas.recordingCollection.size;
+let hasRecordings = this._recording || (this._canvas && this._canvas.recordingCollection.size);
this.element.classList.toggle("has-recordings", hasRecordings);
if (!hasRecordings)
return;
@@ -465,7 +464,8 @@
let scopeBarItems = [];
let selectedScopeBarItem = null;
-for (let recording of this._canvas.recordingCollection) {
+
+let createScopeBarItem = (recording) => {
let scopeBarItem = new WI.ScopeBarItem(recording.displayName, recording.displayName);
if (recording === this._recording)
selectedScopeBarItem = scopeBarItem;
@@ -473,8 +473,16 @@
scopeBarItem.selected = false;
scopeBarItem.__recording = recording;
scopeBarItems.push(scopeBarItem);
+};
+
+if (this._canvas && this._canvas.recordingCollection) {
+for (let recording of this._canvas.recordingCollection)
+createScopeBarItem(recording);
}
+if (this._recording && (!this._canvas || !this._canvas.recordingCollection.has(this._recording)))
+createScopeBarItem(this._recording);
+
if (!selectedScopeBarItem) {
selectedScopeBarItem = scopeBarItems[0];
___
webkit-changes ma
[webkit-changes] [235452] trunk
Title: [235452] trunk
Revision 235452
Author drou...@apple.com
Date 2018-08-28 18:36:36 -0700 (Tue, 28 Aug 2018)
Log Message
console.log() shows (anonymous function) instead of the passed string when a certain format is used
https://bugs.webkit.org/show_bug.cgi?id=188946
Reviewed by Brian Burg.
Source/WebInspectorUI:
Stack trace URLs are much more likely to follow the following format:
://::
Modify the test regexp to always require that a protocol exists and to check that there are
no ":" inside the protocol or path. Additionally, stack traces usually have more than one
frame, so return false if there isn't more than one line.
* UserInterface/Models/StackTrace.js:
(WI.StackTrace.isLikelyStackTrace):
LayoutTests:
* inspector/console/js-isLikelyStackTrace-expected.txt:
* inspector/console/js-isLikelyStackTrace.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/js-isLikelyStackTrace-expected.txt
trunk/LayoutTests/inspector/console/js-isLikelyStackTrace.html
trunk/Source/WebInspectorUI/ChangeLog
trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js
Diff
Modified: trunk/LayoutTests/ChangeLog (235451 => 235452)
--- trunk/LayoutTests/ChangeLog 2018-08-29 00:06:40 UTC (rev 235451)
+++ trunk/LayoutTests/ChangeLog 2018-08-29 01:36:36 UTC (rev 235452)
@@ -1,3 +1,14 @@
+2018-08-28 Devin Rousso
+
+console.log() shows (anonymous function) instead of the passed string when a certain format is used
+https://bugs.webkit.org/show_bug.cgi?id=188946
+
+
+Reviewed by Brian Burg.
+
+* inspector/console/js-isLikelyStackTrace-expected.txt:
+* inspector/console/js-isLikelyStackTrace.html:
+
2018-08-28 Truitt Savell
Edditing test expectations from webkit.org/b/188985.
Modified: trunk/LayoutTests/inspector/console/js-isLikelyStackTrace-expected.txt (235451 => 235452)
--- trunk/LayoutTests/inspector/console/js-isLikelyStackTrace-expected.txt 2018-08-29 00:06:40 UTC (rev 235451)
+++ trunk/LayoutTests/inspector/console/js-isLikelyStackTrace-expected.txt 2018-08-29 01:36:36 UTC (rev 235452)
@@ -18,3 +18,11 @@
Expected: truthy
Actual: false
+-- Running test case: testFormattedStrings
+PASS: "video:1:2" should not be a stacktrace.
+PASS: "video/mp4:1:2" should not be a stacktrace.
+PASS: "video/mp4 : 11:22:33-44:55:66" should not be a stacktrace.
+PASS: "http://video:1:2" should not be a stacktrace.
+PASS: "http://video/mp4:1:2" should not be a stacktrace.
+PASS: "http://video/mp4 : 11:22:33-44:55:66" should not be a stacktrace.
+
Modified: trunk/LayoutTests/inspector/console/js-isLikelyStackTrace.html (235451 => 235452)
--- trunk/LayoutTests/inspector/console/js-isLikelyStackTrace.html 2018-08-29 00:06:40 UTC (rev 235451)
+++ trunk/LayoutTests/inspector/console/js-isLikelyStackTrace.html 2018-08-29 01:36:36 UTC (rev 235452)
@@ -95,6 +95,25 @@
}
});
+suite.addTestCase({
+name: "testFormattedStrings",
+test(resolve, reject) {
+const strings = [
+"video:1:2",
+"video/mp4:1:2",
+"video/mp4 : 11:22:33-44:55:66",
+"http://video:1:2",
+"http://video/mp4:1:2",
+"http://video/mp4 : 11:22:33-44:55:66",
+];
+
+for (let string of strings)
+InspectorTest.expectThat(!WI.StackTrace.isLikelyStackTrace(string), `"${string}" should not be a stacktrace.`);
+
+resolve();
+}
+});
+
suite.runTestCasesAndFinish();
}
Modified: trunk/Source/WebInspectorUI/ChangeLog (235451 => 235452)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-08-29 00:06:40 UTC (rev 235451)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-08-29 01:36:36 UTC (rev 235452)
@@ -1,5 +1,24 @@
2018-08-28 Devin Rousso
+console.log() shows (anonymous function) instead of the passed string when a certain format is used
+https://bugs.webkit.org/show_bug.cgi?id=188946
+
+
+Reviewed by Brian Burg.
+
+Stack trace URLs are much more likely to follow the following format:
+
+://::
+
+Modify the test regexp to always require that a protocol exists and to check that there are
+no ":" inside the protocol or path. Additionally, stack traces usually have more than one
+frame, so return false if there isn't more than one line.
+
+* UserInterface/Models/StackTrace.js:
+(WI.StackTrace.isLikelyStackTrace):
+
+2018-08-28 Devin Rousso
+
Web Inspector: REGRESSION: CanvasSidebarPanel is empty for imported recordings
https://bugs.webkit.org/show_bug.cgi?id=189061
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js (235451 => 235452)
--- trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.js 2018-08-29 00:06:40 UTC (rev 235451)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/StackTrace.j
[webkit-changes] [235453] trunk/LayoutTests
Title: [235453] trunk/LayoutTests
Revision 235453
Author you...@apple.com
Date 2018-08-28 19:37:08 -0700 (Tue, 28 Aug 2018)
Log Message
WebKitMediaSession should be GC collectable when its document is being stopped
https://bugs.webkit.org/show_bug.cgi?id=189016
Unreviewed.
Increasing number of GC and checks to unflake tests on bots.
* http/tests/IndexedDB/collect-IDB-objects.https.html:
* http/tests/media/clearkey/collect-webkit-media-session.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html
trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html
Diff
Modified: trunk/LayoutTests/ChangeLog (235452 => 235453)
--- trunk/LayoutTests/ChangeLog 2018-08-29 01:36:36 UTC (rev 235452)
+++ trunk/LayoutTests/ChangeLog 2018-08-29 02:37:08 UTC (rev 235453)
@@ -1,3 +1,15 @@
+2018-08-28 Youenn Fablet
+
+WebKitMediaSession should be GC collectable when its document is being stopped
+https://bugs.webkit.org/show_bug.cgi?id=189016
+
+
+Unreviewed.
+Increasing number of GC and checks to unflake tests on bots.
+
+* http/tests/IndexedDB/collect-IDB-objects.https.html:
+* http/tests/media/clearkey/collect-webkit-media-session.html:
+
2018-08-28 Devin Rousso
console.log() shows (anonymous function) instead of the passed string when a certain format is used
Modified: trunk/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html (235452 => 235453)
--- trunk/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html 2018-08-29 01:36:36 UTC (rev 235452)
+++ trunk/LayoutTests/http/tests/IndexedDB/collect-IDB-objects.https.html 2018-08-29 02:37:08 UTC (rev 235453)
@@ -20,7 +20,7 @@
const frameIdentifier = internals.documentIdentifier(iframe.contentDocument);
iframe.src = ""
let counter = 0;
-while (++counter < 10) {
+while (++counter < 50) {
if (!internals.isDocumentAlive(frameIdentifier)) {
resolveCallback();
return;
Modified: trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html (235452 => 235453)
--- trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html 2018-08-29 01:36:36 UTC (rev 235452)
+++ trunk/LayoutTests/http/tests/media/clearkey/collect-webkit-media-session.html 2018-08-29 02:37:08 UTC (rev 235453)
@@ -20,7 +20,7 @@
const frameIdentifier = internals.documentIdentifier(iframe.contentDocument);
iframe.src = ""
let counter = 0;
-while (++counter < 10) {
+while (++counter < 50) {
if (!internals.isDocumentAlive(frameIdentifier)) {
resolveCallback();
return;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235455] trunk/Source/ThirdParty/libwebrtc
Title: [235455] trunk/Source/ThirdParty/libwebrtc
Revision 235455
Author ddkil...@apple.com
Date 2018-08-28 21:06:53 -0700 (Tue, 28 Aug 2018)
Log Message
[libwebrtc] Remove references to Source/webrtc/modules/audio_coding/codecs/isac/main/source/fft.h
Found by tidy-Xcode-project-file script (see Bug 188754).
* libwebrtc.xcodeproj/project.pbxproj:
(Source/webrtc/modules/audio_coding/codecs/isac/main/source/fft.h):
Remove references to this file since it doesn't exist.
Modified Paths
trunk/Source/ThirdParty/libwebrtc/ChangeLog
trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (235454 => 235455)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-08-29 03:58:32 UTC (rev 235454)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-08-29 04:06:53 UTC (rev 235455)
@@ -1,3 +1,13 @@
+2018-08-28 David Kilzer
+
+[libwebrtc] Remove references to Source/webrtc/modules/audio_coding/codecs/isac/main/source/fft.h
+
+Found by tidy-Xcode-project-file script (see Bug 188754).
+
+* libwebrtc.xcodeproj/project.pbxproj:
+(Source/webrtc/modules/audio_coding/codecs/isac/main/source/fft.h):
+Remove references to this file since it doesn't exist.
+
2018-08-28 Youenn Fablet
Reenable -Wexit-time-destructors -and Wglobal-constructors in libwebrtc
Modified: trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj (235454 => 235455)
--- trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2018-08-29 03:58:32 UTC (rev 235454)
+++ trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj 2018-08-29 04:06:53 UTC (rev 235455)
@@ -2231,7 +2231,6 @@
5CDD87B71E43BC0500621E92 /* encode.c in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD87811E43BC0500621E92 /* encode.c */; };
5CDD87B81E43BC0500621E92 /* entropy_coding.c in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD87821E43BC0500621E92 /* entropy_coding.c */; };
5CDD87B91E43BC0500621E92 /* entropy_coding.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CDD87831E43BC0500621E92 /* entropy_coding.h */; };
- 5CDD87BB1E43BC0500621E92 /* fft.h in Headers */ = {isa = PBXBuildFile; fileRef = 5CDD87851E43BC0500621E92 /* fft.h */; };
5CDD87BC1E43BC0500621E92 /* filter_functions.c in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD87861E43BC0500621E92 /* filter_functions.c */; };
5CDD87BF1E43BC0500621E92 /* filterbanks.c in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD87891E43BC0500621E92 /* filterbanks.c */; };
5CDD87C01E43BC0500621E92 /* intialize.c in Sources */ = {isa = PBXBuildFile; fileRef = 5CDD878A1E43BC0500621E92 /* intialize.c */; };
@@ -5602,7 +5601,6 @@
5CDD87811E43BC0500621E92 /* encode.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = encode.c; path = source/encode.c; sourceTree = ""; };
5CDD87821E43BC0500621E92 /* entropy_coding.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = entropy_coding.c; path = source/entropy_coding.c; sourceTree = ""; };
5CDD87831E43BC0500621E92 /* entropy_coding.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = entropy_coding.h; path = source/entropy_coding.h; sourceTree = ""; };
- 5CDD87851E43BC0500621E92 /* fft.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name = fft.h; path = source/fft.h; sourceTree = ""; };
5CDD87861E43BC0500621E92 /* filter_functions.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = filter_functions.c; path = source/filter_functions.c; sourceTree = ""; };
5CDD87891E43BC0500621E92 /* filterbanks.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = filterbanks.c; path = source/filterbanks.c; sourceTree = ""; };
5CDD878A1E43BC0500621E92 /* intialize.c */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.c; name = intialize.c; path = source/intialize.c; sourceTree = ""; };
@@ -10371,7 +10369,6 @@
5CDD87801E43BC0500621E92 /* encode_lpc_swb.h */,
5CDD87821E43BC0500621E92 /* entropy_coding.c */,
5CDD87831E43BC0500621E92 /* entropy_coding.h */,
-5CDD87851E43BC0500621E92 /* fft.h */,
5CDD87861E43BC0500621E92 /* filter_functions.c */,
5CDD87891E43BC0500621E92 /* filterbanks.c */,
5CDD878A1E43BC0500621E92 /* intialize.c */,
@@ -12095,7 +12092,6 @@
41E02C8E212734B900C27CD6 /* fec_rate_table.h in Headers */,
5CDD887C1E43BE3C00621E92 /* fec_test_helper.h in Headers */,
41F2638921267F4000274F59 /* fft.h in Headers */,
-5CDD87BB1E43BC0500621E92 /* fft.h in Headers */,
41433D221F79B33400387B4D /* fft.h in Headers */,
41F2636F21267B3E00274F59 /* fft4g.h in Headers */,
41F9BFD32051DDE500ABF0B9 /* fft_buffer.h in Headers */,
__
[webkit-changes] [235456] trunk/Source/WebCore
Title: [235456] trunk/Source/WebCore
Revision 235456
Author you...@apple.com
Date 2018-08-28 21:52:45 -0700 (Tue, 28 Aug 2018)
Log Message
IDBDatabase should not return true to hasPendingActivity after being stopped
https://bugs.webkit.org/show_bug.cgi?id=189073
Reviewed by Darin Adler.
There is a chance that IDBDatabase::hasPendingActivity returns true.
The case that might happen is when stop() is called but there are still some active/being committed transactions.
In that case, hasPendingActivity will return true until these transactions get finalized.
While these transactions will probably be finalized at some point, it delays GC for no good reason.
And we might want in a follow-up patch to assert that ActiveDOMObject are GC-able whenever their context is stopped.
For that purpose, make sure hasPendingActivity returns false when context is stopped.
* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::hasPendingActivity const):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (235455 => 235456)
--- trunk/Source/WebCore/ChangeLog 2018-08-29 04:06:53 UTC (rev 235455)
+++ trunk/Source/WebCore/ChangeLog 2018-08-29 04:52:45 UTC (rev 235456)
@@ -1,3 +1,20 @@
+2018-08-28 Youenn Fablet
+
+IDBDatabase should not return true to hasPendingActivity after being stopped
+https://bugs.webkit.org/show_bug.cgi?id=189073
+
+Reviewed by Darin Adler.
+
+There is a chance that IDBDatabase::hasPendingActivity returns true.
+The case that might happen is when stop() is called but there are still some active/being committed transactions.
+In that case, hasPendingActivity will return true until these transactions get finalized.
+While these transactions will probably be finalized at some point, it delays GC for no good reason.
+And we might want in a follow-up patch to assert that ActiveDOMObject are GC-able whenever their context is stopped.
+For that purpose, make sure hasPendingActivity returns false when context is stopped.
+
+* Modules/indexeddb/IDBDatabase.cpp:
+(WebCore::IDBDatabase::hasPendingActivity const):
+
2018-08-28 Don Olmstead
[CMake] Use CMake's FindFreetype
Modified: trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp (235455 => 235456)
--- trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2018-08-29 04:06:53 UTC (rev 235455)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBDatabase.cpp 2018-08-29 04:52:45 UTC (rev 235456)
@@ -76,7 +76,7 @@
{
ASSERT(&originThread() == &Thread::current() || mayBeGCThread());
-if (m_closedInServer)
+if (m_closedInServer || isContextStopped())
return false;
if (!m_activeTransactions.isEmpty() || !m_committingTransactions.isEmpty() || !m_abortingTransactions.isEmpty())
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [235458] trunk
Title: [235458] trunk Revision 235458 Author rn...@webkit.org Date 2018-08-28 22:31:57 -0700 (Tue, 28 Aug 2018) Log Message Changes to slot children should trigger slotchange https://bugs.webkit.org/show_bug.cgi?id=169718 Reviewed by Darin Adler. LayoutTests/imported/w3c: Rebaselined the test now that relevant test cases pass. * web-platform-tests/shadow-dom/slotchange-expected.txt: Source/WebCore: Fix the bug that slotchange event is not fired when a slot's fallback content is updated now that slotchange event is more formally specified. This particular behavior corresponds to step 7.5. of the concept *to insert a node* where it says: "[I]f parent’s root is a shadow root, and parent is a slot whose assigned nodes is the empty list, then run signal a slot change for parent." See https://dom.spec.whatwg.org/#concept-node-insert Tests: fast/shadow-dom/slotchange-in-fallback.html imported/w3c/web-platform-tests/shadow-dom/slotchange.html * dom/Element.cpp: (WebCore::Element::childrenChanged): Updated the comment. * dom/ShadowRoot.cpp: (WebCore::ShadowRoot::addSlotElementByName): Added an assertion. (WebCore::ShadowRoot::slotFallbackDidChange): Added. * dom/ShadowRoot.h: * dom/SlotAssignment.cpp: (WebCore::SlotAssignment::slotFallbackDidChange): Added. When the assigned nodes is empty, we enqueue a slotchange. Because assignedNodesForSlot invokes assignSlots, this can be O(n) but we don't expect mutating slot's fallback contents and shadow host's children in turn to be a common scenario so this shouldn't be an issue in practice. * dom/SlotAssignment.h: * html/HTMLSlotElement.cpp: (WebCore::HTMLSlotElement::insertedIntoAncestor): Be explicit about auto* being used here. (WebCore::HTMLSlotElement::childrenChanged): Added. Invokes slotFallbackDidChange whenver child node is muated. * html/HTMLSlotElement.h: LayoutTests: Added a W3C style testharness.js test for firing slotchange event for the fallback content change since web-platform-tests/shadow-dom/slotchange.html doesn't have adequate set of tests. Chrome and Firefox pass all test cases. WebKit used to fail all test cases before this patch. * fast/shadow-dom/slotchange-in-fallback-expected.txt: Added. * fast/shadow-dom/slotchange-in-fallback.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/imported/w3c/ChangeLog trunk/LayoutTests/imported/w3c/web-platform-tests/shadow-dom/slotchange-expected.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/Element.cpp trunk/Source/WebCore/dom/ShadowRoot.cpp trunk/Source/WebCore/dom/ShadowRoot.h trunk/Source/WebCore/dom/SlotAssignment.cpp trunk/Source/WebCore/dom/SlotAssignment.h trunk/Source/WebCore/html/HTMLSlotElement.cpp trunk/Source/WebCore/html/HTMLSlotElement.h Added Paths trunk/LayoutTests/fast/shadow-dom/slotchange-in-fallback-expected.txt trunk/LayoutTests/fast/shadow-dom/slotchange-in-fallback.html Diff Modified: trunk/LayoutTests/ChangeLog (235457 => 235458) --- trunk/LayoutTests/ChangeLog 2018-08-29 05:05:23 UTC (rev 235457) +++ trunk/LayoutTests/ChangeLog 2018-08-29 05:31:57 UTC (rev 235458) @@ -1,3 +1,19 @@ +2018-08-28 Ryosuke Niwa + +Changes to slot children should trigger slotchange +https://bugs.webkit.org/show_bug.cgi?id=169718 + + +Reviewed by Darin Adler. + +Added a W3C style testharness.js test for firing slotchange event for the fallback content change +since web-platform-tests/shadow-dom/slotchange.html doesn't have adequate set of tests. + +Chrome and Firefox pass all test cases. WebKit used to fail all test cases before this patch. + +* fast/shadow-dom/slotchange-in-fallback-expected.txt: Added. +* fast/shadow-dom/slotchange-in-fallback.html: Added. + 2018-08-28 Don Olmstead Check for null renderer in canBeScrolledIntoView Added: trunk/LayoutTests/fast/shadow-dom/slotchange-in-fallback-expected.txt (0 => 235458) --- trunk/LayoutTests/fast/shadow-dom/slotchange-in-fallback-expected.txt (rev 0) +++ trunk/LayoutTests/fast/shadow-dom/slotchange-in-fallback-expected.txt 2018-08-29 05:31:57 UTC (rev 235458) @@ -0,0 +1,66 @@ + +PASS slotchange event should be fired when appending a text node to a default slot whose assigned nodes is empty in a connected closed mode shadow root +PASS slotchange event should be fired when appending a text node to a default slot whose assigned nodes is empty in a disconnected closed mode shadow root +PASS slotchange event should be fired when appending a text node to a default slot whose assigned nodes is empty in a connected open mode shadow root +PASS slotchange event should be fired when appending a text node to a default slot whose assigned nodes is empty in a disconnected open mode shadow root +PASS slotchange event should be fired when appending a text node to a named slot whose assigned nodes is empty in a connected closed mode shadow root +PASS slotchange event should be
