[Wesnoth-bugs] [bug #25082] UB in tutorial start

2016-09-19 Thread Daniel
Follow-up Comment #1, bug #25082 (project wesnoth):


Hmm the log noticed 3 issues. the first (lua/ltable.cpp) and the last
(font.cpp) seems both related to integer overflow in hash functions, which is
usually expected in such functions.

the second might come from attack_type::is_for_listing_ not beein initilized
in the attack_type ctor, not sure though.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25083] leaks in AI vs AI match

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: leaks in AI vs AI match
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 03:02:54 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Artificial Intelligence
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

I was having a local multiplayer match where 2 AIs fought.
wesnoth @ 8508b42bed28a956aa5aa8a120cb17ed9bf8404f 




___

File Attachments:


---
Date: Mon 19 Sep 2016 03:02:54 PM UTC  Name: AI_leaks.log  Size: 86kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25078] game hangs/freezes in addon screen with git build

2016-09-19 Thread Charles Dang
Update of bug #25078 (project wesnoth):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #1:

Duplicate of https://gna.org/bugs/?25073

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25082] UB in tutorial start

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: UB in tutorial start
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 02:14:16 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

There is some UB showing up when starting the tutorial and having clicked
through all the mandatory popups.

log attached,  @  8508b42bed28a956aa5aa8a120cb17ed9bf8404f

The font one is most likely this one:  http://gna.org/bugs/?25079





___

File Attachments:


---
Date: Mon 19 Sep 2016 02:14:16 PM UTC  Name: UB_tutorial.log  Size: 15kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25080] UB in map resize window

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: UB in map resize window
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 01:53:14 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Editor
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

There is some UB that shows up when the map resize window of the editor is
shown.

log attached

@ 8508b42-Clean



___

File Attachments:


---
Date: Mon 19 Sep 2016 01:53:14 PM UTC  Name: UB_editor_resize_map.log  Size:
4kB   By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25081] memleaks in tutorial start

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: memleaks in tutorial start
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 01:59:40 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Units
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

Just launch the tutorial from the main menu and quit as soon as the map loaded
and you got through the mandatory popup windows.

wesnoth @ 8508b42bed28a956aa5aa8a120cb17ed9bf8404f 



___

File Attachments:


---
Date: Mon 19 Sep 2016 01:59:40 PM UTC  Name: leaks_tutorial.log  Size: 14kB  
By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25079] UB in font code

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: UB in font code
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 01:41:50 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

through several paths it is possible to trigger this UB in font code, the
easiest is to just launch the wesnoth help from the main menu

log attached



___

File Attachments:


---
Date: Mon 19 Sep 2016 01:41:50 PM UTC  Name: UB_font.log  Size: 8kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25078] game hangs/freezes in addon screen with git build

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: game hangs/freezes in addon screen with git build
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 01:34:07 PM UTC
Category: Bug
Severity: 4 - Important
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

From main menu:

Addons -> connect to add-ons.wesnoth.org ->
message: "There are no add-ons matching the specified criteria on this
server." (probably version incompatibility with git) -> click "Options" =>
game hangs/ screen does not update

@ 8508b42




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25077] memleak in wesnoth help

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: memleak in wesnoth help
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 01:25:15 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

I accessed the wesnoth help from the main menu and clicked a bit through
random entries.

log attached

8508b42bed28a956aa5aa8a120cb17ed9bf8404f



___

File Attachments:


---
Date: Mon 19 Sep 2016 01:25:15 PM UTC  Name: help_memleak.log  Size: 7kB   By:
matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25076] memleak: "Multiplayer" windows (from main menu)

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: memleak: "Multiplayer" windows (from main menu)
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 01:13:58 PM UTC
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux

___

Details:

Starting the game and just showing the "Multiplayer" window (without actually
connecting to any lobby server) leaks memory (see attached logfile)

wesnoth @ 8508b42bed28a956aa5aa8a120cb17ed9bf8404f



___

File Attachments:


---
Date: Mon 19 Sep 2016 01:13:59 PM UTC  Name: leak_multiplayer_window.log 
Size: 45kB   By: matthiaskrgr



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25073] Development build fails to parse add-ons server data

2016-09-19 Thread Charles Dang
Update of bug #25073 (project wesnoth):

Severity:  3 - Normal => 5 - Blocker

___

Follow-up Comment #1:

Raising this to a blocker for 1.13.6. We can't release with a non-functional
addons manager. Either we fix the GUI1 version (which might be more trouble
than it's worth), or we wire in network functionality to the GUI2 manager,
where this does not occur.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #24927] Load game dialogue does not show file summary for several languages

2016-09-19 Thread Wedge009
Update of bug #24927 (project wesnoth):

  Status:None => Fixed  
 Assigned to:None => gfgtdf 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25075] heap use after free when window resolution is changed during launch

2016-09-19 Thread Matthias Krüger
Additional Item Attachment, bug #25075 (project wesnoth):

File name: startupcrash.log   Size:13 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25075] heap use after free when window resolution is changed during launch

2016-09-19 Thread Matthias Krüger
URL:
  

 Summary: heap use after free when window resolution is
changed during launch
 Project: Battle for Wesnoth
Submitted by: matthiaskrgr
Submitted on: Mon 19 Sep 2016 11:42:51 AM UTC
Category: Bug
Severity: 4 - Important
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: git
Operating System: linux/fedora

___

Details:

I compiled the game with asan/ubsan.
When I change the window resolution while the main menu hasn't shown yet, the
game crashes under asan:


Battle for Wesnoth v1.13.5+dev (21f01b0-Clean)
Started on Mon Sep 19 13:40:46 2016

Automatically found a possible data directory at
/home/matthias/vcs/github/wesnoth/build/..

Data directory:   /home/matthias/vcs/github/wesnoth/build/..
User configuration directory: /home/matthias/.config/wesnoth
User data directory:  /home/matthias/.local/share/wesnoth/1.13
Cache directory:  /home/matthias/.cache/wesnoth

Setting mode to 800x600
=
==28153==ERROR: AddressSanitizer: heap-use-after-free on address
0x60c00050c918 at pc 0x059a9bc8 bp 0x7f4f90171a40 sp 0x7f4f90171a30
READ of size 8 at 0x60c00050c918 thread T4
#0 0x59a9bc7 in std::_Rb_tree,
std::pair const, std::vector >
>, std::_Select1st const, std::vector > > >, std::less >,
std::allocator const, std::vector > > > >::size() const
/usr/include/c++/6.1.1/bits/stl_tree.h:916
#1 0x59a9bc7 in std::_Rb_tree,
std::pair const, std::vector >
>, std::_Select1st const, std::vector > > >, std::less >,
std::allocator const, std::vector > > >
>::_M_get_insert_hint_unique_pos(std::_Rb_tree_const_iterator const, std::vector > > >, std::__cxx11::basic_string const&)
/usr/include/c++/6.1.1/bits/stl_tree.h:1908
#2 0x59aa3d6 in
std::_Rb_tree_iterator const, std::vector > > > std::_Rb_tree,
std::pair const, std::vector >
>, std::_Select1st const, std::vector > > >, std::less >,
std::allocator const, std::vector > > >
>::_M_emplace_hint_unique,
std::allocator > const&>, std::tuple<>
>(std::_Rb_tree_const_iterator const, std::vector > > >, std::piecewise_construct_t const&,
std::tuple const&>&&, std::tuple<>&&)
/usr/include/c++/6.1.1/bits/stl_tree.h:2170
#3 0x59abdd5 in std::map, std::vector >, std::less >,
std::allocator const, std::vector > > > >::operator[](std::__cxx11::basic_string const&)
/usr/include/c++/6.1.1/bits/stl_map.h:483
#4 0x5947166 in 

[Wesnoth-bugs] [bug #10592] Remember "Create game" choices: opponent kind, factions, etc

2016-09-19 Thread Daniel
Update of bug #10592 (project wesnoth):

  Status:   Need Info => None   


___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25074] Shavian English date formatting is incorrect and causes crashes

2016-09-19 Thread Wedge009
URL:
  

 Summary: Shavian English date formatting is incorrect and
causes crashes
 Project: Battle for Wesnoth
Submitted by: wedge009
Submitted on: Mon 19 Sep 2016 06:58:40 PM AEST
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group:  None of the others
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13.5+dev
Operating System: Windows

___

Details:

po/wesnoth/e...@shaw.po lines 8241 and 8247.

I don't think whoever did the translation really knew what these characters
were supposed to do and he/she transcribed them into Shavian English
characters. This results in a severe slow down in Linux but a complete crash
in Windows. I would try to revert this to the original date formatting string
but I don't think I have any editors which recognise the Shavian character set
(ISO-15924). Trying to convert to UTF-8 results in a bunch of Chinese
characters instead.

... though I suppose if anyone actually used Shavian English they would have
encountered this by now.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #10592] Remember "Create game" choices: opponent kind, factions, etc

2016-09-19 Thread Victor Sergienko
Follow-up Comment #2, bug #10592 (project wesnoth):

> I'm suprised to see a bugreport from 2007 complaing about wesnoth 1.13 

It's clearly a typo, 1.3 is meant.

>> 3. People prefer to play with the same faction; 
> Actually i'd disagree on both, players often play different factions (so
that don't use random faction special because they don't want to play with the
same faction twice)

I disagree with your disagreement. There are new players, players who have
favorite factions, players who wish to master a specific faction...
OK, this one is subjective.

>> 2. It's more likely that user is playing several local games in a row and
several network games after, then interchanging the type. 
> it's posible that people play a local game on a new map first to get an
overview of the map and then play on the mp server vs. humans. 

It's possible, but interchanging play type is a rare case - most times, if you
play several games in a row, you more frequently play the same type of game
than not.

> Also note that the mp create/connect has changes quite a bit since 2007 so
this might no longer be an issue.

Well, it still is.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #24927] Load game dialogue does not show file summary for several languages

2016-09-19 Thread Wedge009
Follow-up Comment #6, bug #24927 (project wesnoth):

Note discussion in PR #777.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs


[Wesnoth-bugs] [bug #25073] Development build fails to parse add-ons server data

2016-09-19 Thread Wedge009
URL:
  

 Summary: Development build fails to parse add-ons server data
 Project: Battle for Wesnoth
Submitted by: wedge009
Submitted on: Mon 19 Sep 2016 06:19:42 PM AEST
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: Networking
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.13.5+dev
Operating System: All

___

Details:

Noting this for the record. Attempting to browse the 1.13.x add-ons server in
the current master results in a 'There are no add-ons matching the specified
criteria on this server.' message.

Additionally, attempting to click the Options button results in a dead-lock -
the UI is still responsive, you can click on other buttons but nothing will
happen. No choice thereafter but to close the entire program and start again.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs