[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Wedge009]

Update of bug #21564 (project wesnoth):

  Status:  Ready For Test => Fixed  

___

Follow-up Comment #7:

I can no longer get the error with the particular scenario I described
previously. Looks good to me.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Daniel]

Update of bug #21564 (project wesnoth):

  Status:   Confirmed => Ready For Test 

___

Follow-up Comment #6:

https://github.com/wesnoth/wesnoth/commit/da5f00c2b671b79fcec8c36aa5316e1c7663a355

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Daniel]

Update of bug #21564 (project wesnoth):

Severity:  3 - Normal => 4 - Important  
Priority:  5 - Normal => 6  

___

Follow-up Comment #5:

I think the problme here migth be that some widgets (in particular [spacer])
calculate their width/height based on a formula like
https://github.com/wesnoth/wesnoth/blob/1.13.6/data/gui/window/wml_message.cfg#L512
thta uses screen width and is only evaulated when a widgets is created not
when the dialog is relayouted.

I'm makring this as important since this alspo effects the gui2 loadingscreen
which maked the game crash if this happens.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Wedge009]

Update of bug #21564 (project wesnoth):

  Status:None => Confirmed  
Operating System:   Win7N => All


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Wedge009]

Follow-up Comment #4, bug #21564 (project wesnoth):

Duplicate of #19544.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Wedge009]

Follow-up Comment #3, bug #21564 (project wesnoth):

As best as I can tell, the issue arises from the story dialogue being a static
rectangle which, when resizing the window, has its width becoming bigger than
what's available in the remaining game flow window.

twindow::layout() in src/gui/widgets/window.cpp is called. The maximum_width
becomes the remaining available game flow width after resizing. But when it
gets to the twindow_implementation::layout() call later on, the x-dimension of
the dialogue exceeds this maximum_width variable, causing the
tlayout_exception_resize_failed exception.

There is a 'to do' comment in the catch block which states that scroll bars on
the window should be implemented. ...I'm not sure how to go about this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Wedge009]

Follow-up Comment #2, bug #21564 (project wesnoth):

Never mind - managed to do so while resizing the horizontal resolution while
story dialogue is displayed.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Wedge009]

Follow-up Comment #1, bug #21564 (project wesnoth):

Do you still encounter this problem? If so, how do you reproduce it?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Miltos Nedelkos]

URL:
  http://gna.org/bugs/?21564

 Summary: Failed to show a dialog, which doesn't fit on the
screen. 
 Project: Battle for Wesnoth
Submitted by: sindorej
Submitted on: Thu 30 Jan 2014 09:51:36 PM GMT
Category: Bug
Severity: 3 - Normal
Priority: 5 - Normal
  Item Group: User Interface
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Release: 1.10.7
Operating System: Win7N

___

Details:

As shown in the picture there was an error along with some black horizontal
lines. It happened when i clicked the Restore Down button. It was working well
while it was maximized. 

Game Language : Greek
System Language : English
CPU : Intel i7 4820K @ 3.7GHz
GPU : MSI Global N770 TF 2GD5/OC
RAM : 8GB
Screen Resolution : 1920x1080
Operating System : Win7N (Up to date)




___

Reply to this item at:

  http://gna.org/bugs/?21564

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs

[Wesnoth-bugs] [bug #21564] Failed to show a dialog, which doesn't fit on the screen.

[Miltos Nedelkos]

Additional Item Attachment, bug #21564 (project wesnoth):

File name: screenshot.png Size:494 KB


___

Reply to this item at:

  http://gna.org/bugs/?21564

___
  Message sent via/by Gna!
  http://gna.org/


___
Wesnoth-bugs mailing list
Wesnoth-bugs@gna.org
https://mail.gna.org/listinfo/wesnoth-bugs