Re: [Wicket-develop] committing code
better is to upload it in our rfe/patch tracker!johanOn 10/12/06, Matej Knopp [EMAIL PROTECTED] wrote: Hi.Send the patch to the dev list, we will look at it and if we like what we see we will commit it. :)Thanks.-Matej[EMAIL PROTECTED] wrote: Hi,I have made some enhancement to the wicket treetable component and created a TreeTable2 component. With this component, It is possible to populate the editable columns with dynamic data. Could someone tell me how to go about committing the code to CVS. Regards, V.Omprakash ___ PrivatePhone^TM - FREE telephone number voicemail. A number so private, you can make it public. http://www.privatephone.com - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Tomcat deployment
is your app deployed under the context helloworld?Do you have an index.html in the root that points to the helloworld/app (app == servletname) with a meta redirect?johan On 10/3/06, Lurlay, Patrick [EMAIL PROTECTED] wrote: All,I am a wicket nubie.I just wrote a sample appdeploy the war undertomcat, the log tells me that the app is deploy, but when I point mybrowserto http://localhost:8083/helloworld , I get a 404 error(page notfound).I am at a lost any idea?ThanksPs: I am using tomcat 5.5.17Patrick-Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Unable to deploy application after build
Are you saying that you have an application that runs on 1.2.2 and when you have the current wicket-1.x branch compiled you get that error?That shouldn't happen.If you upgrade to trunk, thats 2.0, then this could happen and you won't be able to just shutdown tomcat (saving all the sessions) and then restarting it. Because to much is changed and the serialization will fail.But are you saying that the application itself doesn't startup completely??Do you have a full stacktrace for me?johan On 9/27/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Hi, I have compiled the wicket sources and when I try to start tomcat, I get the error Error loading previous sessions and an invalidClassException. While this goes away if I use the same version of JDK for my build and tomcat (Ibelieve this has to do with the serialVersionUID. could someone point to the right way of doing this), the application fails to load with the error Unable to create application of class and gives the reason as ClassNotFoundException. I have the applicationunder context-root/web-inf/classesunder the right package structure.The same eample application was loading fine when I used the wicket-1.2.2 binary jar. Could someone tell me the best way to go about building wicket and then using it to run the examples. Regards, prakash ___ PrivatePhoneTM- FREE telephone number voicemail. A number so private, you can make it public. http://www.privatephone.com -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] test
wohoooOn 10/3/06, Igor Vaynberg [EMAIL PROTECTED] wrote: test -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] V2: FormExample: Submit button no longer localized
yes i already did know that that this was the problem.This is already discussed in another thread.We need to make it a bit better (that attribute map)johanOn 10/2/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: Found the problem. Johan added markupattributes to Component which ofcourse is not updated when markup is re-loaded, e.g. due to localechanges.JuergenOn 9/29/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Crappy SF mailinglists... resend: The problem has to do with markup loading/ caching. If you set a breakpoint in ImageButton#onComponentTag, you'll see that the tag always refers to input wicket:id=saveButton type=image value=buttonFactory:save:Save/ from the first loaded markup file, while it should refer to: input wicket:id=saveButton type=image value=buttonFactory:save:Sichern/ This works in 1.2 but not in 2.0 Eelco On 9/27/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: In V2 trunk when you run the Form example and change the language to e.g. German the submit and cancel button won't change to the German words anymore. Juergen - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop- Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Fragments and Ajax problem
unit test?On 9/29/06, Martijn Dashorst [EMAIL PROTECTED] wrote: (the mailinglist seems borked again, so I'm sending this again). I think I stumbled upon a bug in Wicket's fragments + ajax. Here's the exception I get: Caused by: java.lang.IndexOutOfBoundsException: Index: 294, Size: 294 at java.util.ArrayList.RangeCheck (ArrayList.java:546) at java.util.ArrayList.get(ArrayList.java:321) at wicket.markup.MarkupFragment.get(MarkupFragment.java:96) at wicket.markup.Markup.get(Markup.java:155) at wicket.markup.MarkupStream.get(MarkupStream.java:337) at wicket.markup.MarkupStream.setCurrentIndex(MarkupStream.java:205) at wicket.markup.html.panel.Fragment.renderFragment(Fragment.java:264) at wicket.markup.html.panel.Fragment.onComponentTagBody(Fragment.java:200) at wicket.Component.renderComponent(Component.java :1696) ... 38 more The usecase is the following: I have 2 fragments in my page. One of them gets rendered with thefirst page render, the other is rendered on an ajax request. The second time an ajax request tries to render the second fragment everything goes right.When I render both fragments on the first page render, everything goes OK. Martijn -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] WebApplication.getRootPath NullPointerException
yes this can't be done. I am looking how to over come this but we need the request to calculatethe rootpath if it isn't calculated yet.That is because of the servlet spec. You can't for example ask or get the context path in your Servlet.init method.. That is just not possible. (they solve this in the next spec i believe)So a full rootpath that includes servletpath and contextpath can only be calculated in the first request.. So i don't know what to return there if there is no request...I can't just return because that is a lie..johanOn 9/27/06, Stefan Lindner [EMAIL PROTECTED] wrote:When I call getRootPath() in the init method of the application I run into ajava.lang.NullPointerException atwicket.protocol.http.WebApplication.getRootPath(WebApplication.java:708)Stefan Lindner- Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] official Wicket 2.0 releases
Yes put an alpha as soon as possible out of the doorThings change after that but that is the idea.johanOn 9/26/06, Igor Vaynberg [EMAIL PROTECTED] wrote:after juergen and i (but mostly juergen) figure out this border+ialternateparent thing i think all the major functionalities will be there. -IgorOn 9/26/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Hey devs,When are we going to put our first 'official' alphas/ betas out?Eelco-Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] official Wicket 2.0 releases
do remind me, what is that model walking thing?I did fix a few things. But what things are now still open things? You did move the getNestedModel right?And get rid of the stack of property models?Or do you mean with model walking the thing to get the real model? johanOn 9/26/06, Igor Vaynberg [EMAIL PROTECTED] wrote: do you think you will have the new model walking thing done soon? would be nice to have that in the alpha and let it get lots of exposure.-Igor On 9/26/06, Johan Compagner [EMAIL PROTECTED] wrote: Yes put an alpha as soon as possible out of the doorThings change after that but that is the idea.johan On 9/26/06, Igor Vaynberg [EMAIL PROTECTED] wrote:after juergen and i (but mostly juergen) figure out this border+ialternateparent thing i think all the major functionalities will be there. -IgorOn 9/26/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Hey devs,When are we going to put our first 'official' alphas/ betas out?Eelco-Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Wicket and OSGi
If you just point out to use the places we do cache to much and that you can't replace somehowplease let us know.johanOn 9/24/06, Niclas Hedhman [EMAIL PROTECTED] wrote: On 9/24/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Niclas, as you can see, we would be open for it, but not too soon. Iopened up an RFE here http://sourceforge.net/tracker/index.php?func=detailaid=1564174group_id=119783atid=684978 Sure. The reason why we are using Wicket in the first place is that it is good enough in terms of classloader control, resource handling and other areas which is required. So for 2.0, can you guys confirm;* No caching of resources, classes, classloaders, etc in Wicket itself (or, allowing us to evict those under our control). That is an area that I have not investigated, and could interfere with 'reloadable clients'. * If we provide you with some Manifest entries, you ship them standard in the various Wicket jars, to make them bundle conformant and directly deployable on OSGi platform? I am willing to maintain this, especially now when you are going to Apache ;o) CheersNiclas -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] localized attributes
we still have the problem of looking up the message at render time everytime.I just want an option to do it once. Just with the markup loading. No components what so ever are touched/added or needed. As long as we also have that option it is fine by me.
johanOn 9/23/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:
(cont)Because of Johan's performance concerns we came up with asolution which doesn't have that penality. If the wicket messagehandler detects a wicket:message attribute, it could add an attributemodifier to the component tag, and the render process make sure they
get attached to the components associated with these tags, hence noperformance penalty.JuergenOn 9/23/06, Juergen Donnerstag [EMAIL PROTECTED]
wrote: We are going in circles, the solution already was laid out. Why are we starting at the beginning again? wicket:message already creates a container (not exactly, it creates
a label) to replace the text. Changing wicket tag identifier IMO would the completely wrong way of doing it. If we do that we'll end up with discussions like my attribute should create a compent tag as well.. IMO the rule is very
simple: every tag which has a wicket:id becomes a component tag. Handlers, like WicketMessageHandler need to set the wicket:id with an automatically generated id, and we have several examples for that
already. For the render process you now must register a resolver to handle tags with wicket:message where the id has been generated automaticaly, because you must automatically create a very simple container for
that. This 5 lines of code, very simple. The real issue is that wicket:message attributes might appear in *any* component. Now you call it IComponentTagHandler, when I outlined the solution before I called it IOnComponentRenderListener and the methods
are slightly different, but it essentially the same. The reason why we were looking for another solution is because Johan was complaining about the performance. Every component when rendered iterates over the
list of application level handlers, and in case of wicket:message checks the attributes if an wicket:message attribute exists or not. Johan is worried about the penality it takes for all the components
which don't have wicket:message tags, besides that he think wicket:message doesn't need to be extended at all. Juergen On 9/23/06, Igor Vaynberg
[EMAIL PROTECTED] wrote: i guess part 1 can be done in a tag handler... -Igor On 9/22/06, Igor Vaynberg
[EMAIL PROTECTED] wrote: well, i looked into it and here is what you have to do. i dont have the time this weeend (jewish new year) so maybe someone who does can implement
the full func. 1) you have to let wicket resolvers handle markup that has wicket:message attr and no wicket:id, for this you need to make wicket think this tag is
not raw markup - so an id needs to be set WicketTagIdentifier:126 // Identify wicket:message attr tags if
(xmlTag.getAttributes().containsKey(wicket:message)tag.getId()==null) { // replace random with some counter - but you get the
idea... tag.setId(wicket-message + Math.random()); } now we need to autoadd a webmarkupcontainer for any of these tags
WicketMessageResolver:74 if (tag.getAttributes ().containsKey(wicket:message)tag.getId().startsWith(wicket-message))
{ final String id = _message_ + container.getPage().getAutoIndex(); container.autoAdd(new WebMarkupContainer(id)
{ public boolean isTransparentResolver() { return true; }
}); return true; } and thats the meat of it, now you need that IComponentTagHandler {
oncomponenttag() } deal, a way to register it in settings and something like Component:1666 === wow Iterator handlers = getApplicationSettings().getComponentTagHandlers().iterator();
while (handlers.hasNext()) {((IComponentTagHandler)handlers.next()).onComponentTag(this, tag); }
and oh yeah...the taghandler that does the actual resource lookup -Igor
On 9/22/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/22/06, Igor Vaynberg
[EMAIL PROTECTED] wrote: but you DO want it to sync with your component tree because you want the localization lookup to be synced to the component tree.
Yep. I want it to work the same as wicket:message. Eelco-
Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
Wicket-develop mailing listWicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop -
Take Surveys. Earn Cash.
Re: [Wicket-develop] localized attributes
there is one other problemOur localizer object is not the fastest thing in the world.So i guess that thing will be called everytime? Because the components can be attachedby any locale but the markup itself is also for one. I just would love to have an option that my messages are parsed once at loading of the markupWe can have other approaches if people want messages in all strange places by doing at at render time.johan On 9/22/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: What if the Message markup filter (which is only executed when themarkup is loaded) were able to add a stateless attributemodifier tothe component tag and that AM gets automatically attached to thecomponent at render time. That would mean basically no overhead at runtime.Because the very same AM gets re-used for all compent tags withwicket:message attribute it must be stateless.JuergenOn 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: But i want a choice that i want it on markup loading time i don't want the penalty for constantly looking all the resources up when it is not needed So we should support both. johan On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: You are talking about *your* use cases, while the more complex lookup mechanism came from actual requests from people. I think resource bundles work good for many cases, and I think the fact that we're able to do such lookups is a good selling point for Wicket. Also, again, while we should try to keep things simple in our implementations, it shouldn't be the major factor in deciding whether to support something or not. This feature was asked for by users, and when voted on, it got quite some plusses of users that wanted it. And now that I'm writing about localization, I thought this feature, together with wicket:message is actually pretty powerful. So, if we can find a reasonable way to support this, I'd be all for it. Eelco On 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: what we currently do is over complex and in all my usecases i have totally not needed but maybe in my cases i had where real i18n was needed it was always different The messages where always comming from a database. Never from property files. I think the current way of walking the hierachy and so on is extremely complex We should reduce the choices not extend them.Keep it simple johan On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote:I would rather not support it at all if it is that limited. Like Isaid before, we would support an advanced lookup with wicket:message key=foo but something very basic with bar wicket:message=bar=foo/. I don't want to explain this to users, and I don't like theinconsistency. I'm for the best solution, not the easiest for us to implement or maintain. Eelco On 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: i think i still prefer the doing it once by loading the markup. The maybe we loose some advanced localization but i find this acceptable. What options do we then loose? If these options work then it is fine: Xxxx.html gets its messages from: Xxxx.properties MyApplicaiton.properties and there own Localization component should be able to resolve it by key (if they are comming from a database) johan On 9/19/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: You are mixing things here. Markup tags become component tags if they have a wicket:id. This is the only rule. wicket:xxx because by default it doesn't have a wicket:id gets an id automatically (auto-xxx) assigned for the markup tag to become a component tags. The same happens to autolinks, body etc and it happens at markup load time and hence just once per component *type*. While rendering a component *instance* the resolvers are applied and in case of span wicket:message=myMessage wicket:id=auto-1234 a resolver could localize an attributes values. The resolver in these case would actually be independent from any component type as it would look for wicket:message in the current tag only and on the fly modify the attribute. JuergenOn 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:We do that already in other cases. Make it an auto component and youcan easily hook a resolver on it. That would only work for tags that are not component tags to begin. As soon as you would decide to put wicket:id in it, it wouldn't go through a component resolver and would thus not be processed, right? Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance
Re: [Wicket-develop] how do stateless components and pages work in Wicket 2.0?
A Page is stateless just as before in wicket 1.2, there are no callbacks to the page.But we have now a nice option to reduce those callbacks: /** * Returns whether the component can be stateless. Being able to be
* stateless doesn't necessary mean, that the component should be stateless. * Whether the component should be stateless depends on * * @return whether the component can be stateless */
protected boolean getStatelessHint() { return true; }Byt default it is true. But for all components that are implementing a listener do overridethis method and return false.
We have a 2 StatelessComponents so developers will notice them better and the code makes it clearthat they are really meant to be stateless:StatelessLink and StatelessFormThese extend Link and Form but then return true again for the hint.
When that hint returs true the component can return true on the isStateless() call (if also all behaviours are stateless)if that is the case and the page is bookmarkable (default constructor or page param constructor)
then a special url is generated that is a bookmarkable part and the interface part in one goso you have the bookmarkablePage=xxx and the interface=xxx in the url. (or a mount with that interface=xxx)When a request comes in for such an url. It fist checks the interface stuff (is the page still there) and if it finds
the page it goes on as a normal Interface request. If it isn't it becomes bookmarkalble interface request.This means that the page is created just as a normal bookmarkable request but not only for rendering but
first it calls the interface that was asked for.If all components on the page are stateless (stateless hint returns true and no statefull behaviours) and the pageis not redirected to (this will make the page statefull) the page will be stateless and all urls will be bookmarkable
or a combination of bookmarkable and an interface request..So you could build now a login screen (that is the first screen you see when you hit the side)that will not make a session and can always be used by using a StatelessForm as the login form.
Or you could have a main page where you have a search box but for the rest it is only static data. Also then a stateless form would be the best option. One thing ofcourse to remember when using a StatelessLink, StatelessForm or your own component
that returns true for the getStatelessHint(). Is that you can't use model data that can change over the livetimeof a page.The model data is always exactly that data that is there when the page is constructed! It doesn't have to be
the same data that was there the time the component did render. Because the page is or can be recreated.so you have a 'clean' page again. The StatelessForm is a bit of an exception because the state of the form
is pushed from the client. for the large part through the form components. So getModelObject in a statelessform on a submit will work just as fine. The only thing here is that if you have form components can't be altered
in the live time (over multiply request) of a page. For example setting an other validator or setting requiredat some point other then page construction won't work. Because the page can be recreated when the form
is submitted so the formcomponents will then be in the initial state. But i guess this is not a problemfor many cases.johanP.S. Matej any comments?On 9/22/06,
Eelco Hillenius [EMAIL PROTECTED] wrote:
Hi,Can someone (Johan?) explain exactly how/ when pages are statelesswith Wicket 2.0 and what the corner cases are? I'm writing somethingabout it now, and even though I kind of reversed engineered it, It'd
like to hear from the people who built it.Cheers,Eelco-Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net
's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] localized attributes
The localizer is not really fast. Especially when the string is not foundor deeply nested or something. Because in the past we tried to localize all optionswe generated for the AbstractChoice:if (localizeDisplayValues())
{ display = getLocalizer().getString(displayValue, this, displayValue); }we didn't have that if around it. If you remove that if or you return true in that methodand you have pretty large combobox (50 values or something)
then the localizer popups up in the profiler.. Thats why i introduced that methodand by default it is false.johanOn 9/22/06, Juergen Donnerstag
[EMAIL PROTECTED] wrote:
Well I don't think it is slow. It caches all properties, they areautomatically reloaded if the properties files changes, and once inmemory it is just a question of creating keys and traversing somemaps. And btw if the key was found previously it doesn't traverse the
properties maps anymore, it gets the value from the front-line cacheright away. Can it be any faster?The attributemodifier would only be attached if a wicket:message tagwas found by the markup handler. It doesn't affect any application
which doesn't use wicket:message attributes.You do have that option already. It is trivial to add a flag toWicketMessageHandler or create different ones to control it defaultbehavior: resolve or attach AM
JuergenOn 9/22/06, Johan Compagner [EMAIL PROTECTED] wrote: there is one other problem Our localizer object is not the fastest thing in the world.
So i guess that thing will be called everytime? Because the components can be attached by any locale but the markup itself is also for one. I just would love to have an option that my messages are parsed once at
loading of the markup We can have other approaches if people want messages in all strange places by doing at at render time. johan On 9/22/06, Juergen Donnerstag
[EMAIL PROTECTED] wrote: What if the Message markup filter (which is only executed when the markup is loaded) were able to add a stateless attributemodifier to
the component tag and that AM gets automatically attached to the component at render time. That would mean basically no overhead at runtime. Because the very same AM gets re-used for all compent tags with
wicket:message attribute it must be stateless. Juergen On 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote:
But i want a choice that i want it on markup loading time i don't want the penalty for constantly looking all the resources up when it is not needed So we should support both.
johan On 9/19/06, Eelco Hillenius [EMAIL PROTECTED]
wrote:You are talking about *your* use cases, while the more complex lookupmechanism came from actual requests from people. I think resourcebundles work good for many cases, and I think the fact that we're able
to do such lookups is a good selling point for Wicket. Also, again,while we should try to keep things simple in our implementations, itshouldn't be the major factor in deciding whether to support something
or not. This feature was asked for by users, and when voted on, it gotquite some plusses of users that wanted it. And now that I'm writingabout localization, I thought this feature, together with
wicket:message is actually pretty powerful. So, if we can find a reasonable way to support this, I'd be all for it.
Eelco On 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: what we currently do is over complex and in all my usecases i have
totally not needed but maybe in my cases i had where real i18n was needed it was always different The messages where always comming from a database. Never from
property files. I think the current way of walking the hierachy and so on is extremely complex
We should reduce the choices not extend them.Keep it simple johan
On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: I would rather not support it at all if it is that limited. Like I
said before, we would support an advanced lookup with wicket:message key=foo but something very basic with bar wicket:message=bar=foo
/. I don't want to explain this to users, and I don't like the inconsistency. I'm for the best solution, not the easiest for us to implement or maintain.
EelcoOn 9/19/06, Johan Compagner
[EMAIL PROTECTED] wrote: i think i still prefer the doing it once by loading the markup. The maybe we loose some advanced localization but i find this
acceptable. What options do we then loose? If these options work then it is fine:
Xxxx.html gets its messages from:
Xxxx.properties MyApplicaiton.properties and there own Localization component should be able to resolve
it by key (if they are comming from a database)johan
On 9/19/06, Juergen Donnerstag
Re: [Wicket-develop] localized attributes
I think behaviours/attribute modifiers could be stateless or reusedas long as it doesn't do something or depends in this method:IBehaviour void bind(Component component);johan On 9/22/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/22/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: What if the Message markup filter (which is only executed when the markup is loaded) were able to add a stateless attributemodifier to the component tag and that AM gets automatically attached to the component at render time. That would mean basically no overhead at runtime. Because the very same AM gets re-used for all compent tags with wicket:message attribute it must be stateless.That sounds awesome. As general functionality too... attachingstatelss AMs. This is not something that exists today right? Or did Imiss something (again)? Eelco-Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cashhttp://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] IOnComponentRenderListener
so every component will go through a Implementation of thatthat can be registered in the settings?phhOn 9/21/06, Eelco Hillenius
[EMAIL PROTECTED] wrote:Regarding the discussion here:
http://www.nabble.com/localized-attributes-tf2288202.html#a6393222What do you think about an interface like IOnComponentRenderListenerpulic interface IOnComponentRenderListener {void beginComponentRender(Component, ComponentTag)
void beginComponentRender(Component, ComponentTag) }Pro: it would make the wicket:message attribute possible, and wouldopen some more possibilities for AOP-ish constructs.Con: though I don't think we'd open up pandora's box, we are providing
a way for people to break encapsulation.You opinions or votes in case you're absolutely for or against?Eelco-Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] localized attributes
what we currently do is over complex and in all my usecases i have totally not neededbut maybe in my cases i had where real i18n was needed it was always differentThe messages where always comming from a database. Never from property files. I think the current way of walking the hierachy and so on is extremely complexWe should reduce the choices not extend them. Keep it simplejohanOn 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: I would rather not support it at all if it is that limited. Like Isaid before, we would support an advanced lookup with wicket:messagekey=foo but something very basic with bar wicket:message=bar=foo /. I don't want to explain this to users, and I don't like theinconsistency. I'm for the best solution, not the easiest for us toimplement or maintain.EelcoOn 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: i think i still prefer the doing it once by loading the markup. The maybe we loose some advanced localization but i find this acceptable. What options do we then loose? If these options work then it is fine: Xxxx.html gets its messages from: Xxxx.properties MyApplicaiton.properties and there own Localization component should be able to resolve it by key (if they are comming from a database)johan On 9/19/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: You are mixing things here. Markup tags become component tags if they have a wicket:id. This is the only rule. wicket:xxx because by default it doesn't have a wicket:id gets an id automatically (auto-xxx) assigned for the markup tag to become a component tags. The same happens to autolinks, body etc and it happens at markup load time and hence just once per component *type*. While rendering a component *instance* the resolvers are applied and in case of span wicket:message=myMessage wicket:id=auto-1234 a resolver could localize an attributes values. The resolver in these case would actually be independent from any component type as it would look for wicket:message in the current tag only and on the fly modify the attribute. JuergenOn 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:We do that already in other cases. Make it an auto component and you can easily hook a resolver on it. That would only work for tags that are not component tags to begin. As soon as you would decide to put wicket:id in it, it wouldn't go through a component resolver and would thus not be processed, right? Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop-Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID
Re: [Wicket-develop] localized attributes
with there own localization component i meant there implementation of IStringResourceLoader.It is a bit deeper away in wicket then i am used to in other frameworks (see my other post)johan On 9/19/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: and there own Localization component should be able to resolve it by key (if they are comming from a database)what do mean by and there own Localization component? At markup loadtime you only have the component type, not the instance. It would be the localizer registered with the application to find the localizedvalue.The point Eelco was making earlier is the inconsistency betweenwicket:message and wicket:message. The former one *is* resolved at render time and hence has all the component information at hand.wicket:message in contrast has not.JuergenOn 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: i think i still prefer the doing it once by loading the markup. The maybe we loose some advanced localization but i find this acceptable. What options do we then loose? If these options work then it is fine: Xxxx.html gets its messages from: Xxxx.properties MyApplicaiton.properties and there own Localization component should be able to resolve it by key (if they are comming from a database) johan On 9/19/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: You are mixing things here. Markup tags become component tags if they have a wicket:id. This is the only rule. wicket:xxx because by default it doesn't have a wicket:id gets an id automatically (auto-xxx) assigned for the markup tag to become a component tags. The same happens to autolinks, body etc and it happens at markup load time and hence just once per component *type*. While rendering a component *instance* the resolvers are applied and in case of span wicket:message=myMessage wicket:id=auto-1234 a resolver could localize an attributes values. The resolver in these case would actually be independent from any component type as it would look for wicket:message in the current tag only and on the fly modify the attribute. Juergen On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:We do that already in other cases. Make it an auto component and youcan easily hook a resolver on it. That would only work for tags that are not component tags to begin. As soon as you would decide to put wicket:id in it, it wouldn't go through a component resolver and would thus not be processed, right? Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cashhttp://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID
Re: [Wicket-develop] localized attributes
By the way i like to resolve the messages at load time not render time.The only drawback i see is reloading of those messages when the change..that can be tricky.. others are only plusses. johan On 9/19/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: and there own Localization component should be able to resolve it by key (if they are comming from a database)what do mean by and there own Localization component? At markup loadtime you only have the component type, not the instance. It would be the localizer registered with the application to find the localizedvalue.The point Eelco was making earlier is the inconsistency betweenwicket:message and wicket:message. The former one *is* resolved at render time and hence has all the component information at hand.wicket:message in contrast has not.JuergenOn 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: i think i still prefer the doing it once by loading the markup. The maybe we loose some advanced localization but i find this acceptable. What options do we then loose? If these options work then it is fine: Xxxx.html gets its messages from: Xxxx.properties MyApplicaiton.properties and there own Localization component should be able to resolve it by key (if they are comming from a database) johan On 9/19/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: You are mixing things here. Markup tags become component tags if they have a wicket:id. This is the only rule. wicket:xxx because by default it doesn't have a wicket:id gets an id automatically (auto-xxx) assigned for the markup tag to become a component tags. The same happens to autolinks, body etc and it happens at markup load time and hence just once per component *type*. While rendering a component *instance* the resolvers are applied and in case of span wicket:message=myMessage wicket:id=auto-1234 a resolver could localize an attributes values. The resolver in these case would actually be independent from any component type as it would look for wicket:message in the current tag only and on the fly modify the attribute. Juergen On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:We do that already in other cases. Make it an auto component and youcan easily hook a resolver on it. That would only work for tags that are not component tags to begin. As soon as you would decide to put wicket:id in it, it wouldn't go through a component resolver and would thus not be processed, right? Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop -Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cashhttp://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID
Re: [Wicket-develop] localized attributes
But i want a choice that i want it on markup loading timei don't want the penalty for constantly looking all the resources up when it is not neededSo we should support both.johan On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: You are talking about *your* use cases, while the more complex lookupmechanism came from actual requests from people. I think resourcebundles work good for many cases, and I think the fact that we're ableto do such lookups is a good selling point for Wicket. Also, again, while we should try to keep things simple in our implementations, itshouldn't be the major factor in deciding whether to support somethingor not. This feature was asked for by users, and when voted on, it got quite some plusses of users that wanted it. And now that I'm writingabout localization, I thought this feature, together withwicket:message is actually pretty powerful.So, if we can find a reasonable way to support this, I'd be all for it. EelcoOn 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: what we currently do is over complex and in all my usecases i have totally not needed but maybe in my cases i had where real i18n was needed it was always different The messages where always comming from a database. Never from property files. I think the current way of walking the hierachy and so on is extremely complex We should reduce the choices not extend them.Keep it simple johan On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: I would rather not support it at all if it is that limited. Like I said before, we would support an advanced lookup with wicket:message key=foo but something very basic with bar wicket:message=bar=foo /. I don't want to explain this to users, and I don't like the inconsistency. I'm for the best solution, not the easiest for us to implement or maintain. Eelco On 9/19/06, Johan Compagner [EMAIL PROTECTED] wrote: i think i still prefer the doing it once by loading the markup. The maybe we loose some advanced localization but i find this acceptable. What options do we then loose? If these options work then it is fine: Xxxx.html gets its messages from: Xxxx.properties MyApplicaiton.properties and there own Localization component should be able to resolve it by key (if they are comming from a database)johan On 9/19/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:You are mixing things here. Markup tags become component tags if they have a wicket:id. This is the only rule. wicket:xxx because bydefault it doesn't have a wicket:id gets an id automatically(auto-xxx) assigned for the markup tag to become a component tags. The same happens to autolinks, body etc and it happens at markupload time and hence just once per component *type*. While rendering a component *instance* the resolvers are applied and in case of span wicket:message=myMessage wicket:id=auto-1234 aresolver could localize an attributes values. The resolver in these case would actually be independent from any component type as it wouldlook for wicket:message in the current tag only and on the fly modifythe attribute. Juergen On 9/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 9/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: We do that already in other cases. Make it an auto component and you can easily hook a resolver on it. That would only work for tags that are not component tags to begin. As soon as you would decide to put wicket:id in it, it wouldn't go through a component resolver and would thus not be processed, right? Eelco - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of ITJoin SourceForge.net's Techsay panel and you'll get the chance to share youropinions on IT business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.phpp=sourceforgeCID=DEVDEV ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net 's Techsay panel and you'll get the chance
Re: [Wicket-develop] [ wicket-Feature Requests-1560074 ] Support nested forms
Then we need to look at all the FormComponent visitors (validation/input conversion finding the submit button)because we need to stop add the form we could then encounter.On 9/17/06, SourceForge.net [EMAIL PROTECTED] wrote: Feature Requests item #1560074, was opened at 2006-09-17 11:56Message generated for change (Tracker Item Submitted) made by Item SubmitterYou can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=684978aid=1560074group_id=119783Please note that this message will contain a full copy of the comment thread,including the initial issue submission, for this request, not just the latest update.Category: coreGroup: 1.3Status: OpenPriority: 5Submitted By: Martijn Dashorst (dashorst)Assigned to: Nobody/Anonymous (nobody)Summary: Support nested forms Initial Comment:We have all the stuff ready and available to support nested forms.Idea: - outer form stays - inner form becomes span - buttons/links submit outer form with special identifier - inputs of outer form stay as raw input - inputs of inner form get converted and validated - normal behavior of inner form is performedwhen the page gets rerendered, the original input of the outer formcomponents is preserved, and any stuff that is used within the inner form is processed.It will not cover 100% of all usecases, but it is something that might makeworking with Wicket a bit better again by removing yet another quirk ofHTML.-- You can respond by visiting:https://sourceforge.net/tracker/?func=detailatid=684978aid=1560074group_id=119783 -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] File descriptor leak in DEVELOPMENT mode
Let m know if that helps for your situation.if really a jar url connection is returned in your case. Because this doesn't have to be the case. Any kind of UrlConnection can be returned (WebLogic does have its own ZipUrlConnection or something like that) In the end this is a problem of the ClassLoader not closing its internal stuff. Or that UrlConnection doesn't have a disconnect() method in its interface what every UrlConnection must implement.. So that we can disconnect any url connection. I really don't get it why there is a connect() in the interface but no cleanup methodIt is know bug in the java bug parade. Dont know directly what the number is. Search this mailing list it is talked about quite a lot. johanOn 9/16/06, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: Hi,When deploying a Wicket applicationin DEVELOPMENT mode with onlyJARs inWEB-INF/lib (no WEB-INF/classes), andtemplates includedinJARs,thenumberof filedescriptorsincreasessteadily, leading to an OS error: «Too many files open».Whenturning configurationto DEPLOYMENT,the problemdoes notarise.Soit seems liketemplate reloading is leakingJAR filedescriptors.Note: another Wicketuser told me about thisexact problem.I'm not the only one apparently.Are you aware of the problem?Do you think the attached patch could fix the problem?I will letthepatched systemrununtil tomorrowto seeifit isstillleakingfiles. To watch the number of times the JARs are open I'm using thefollowing command: lsof -p java-process-id | grep WEB-INF/lib | cut -b60- | sort | uniq -cFWIW I found a similar problem described at Sun: http://bugs.sun.com/bugdatabase/view_bug.do;:YfiG?bug_id=4386865Thanks for your help,-- Jean-Baptiste QuenotakaJohn Banana Qwerty http://caraldi.com/jbq/-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] File descriptor leak in DEVELOPMENT mode
Ok looked and debug it a bit through and i don't think that will help much that patch.First of all you also should do that in the lastModifiedTime call of the URLResourceStream class.But when debugging i see that the JarFile instance field in the JarUrlConnection instance that i get
is not there yet when in the lastModified calll. The last modified call doesn't open the file yet. It just looks to the time stamp of the file i guess.The real opening of the jar file is in another method:
public InputStream getInputStream() throws ResourceStreamNotFoundException { if (inputStream == null) { try {inputStream = url.openStream();
} catch (IOException e) {throw new ResourceStreamNotFoundException(Resource + url + could not be opened, e);
} } return inputStream; }i think this is the big problem.. url.openStream() does a url.openConnection().getInputStream()And then the jar file is suddenly there!
we do close the input stream but that doesn't have any effect on the JarUrlConnection that is madebyt openConnection()So i guess we should do that in 2 steps.. First openConnection or self. Keep that in an internal reference just like
inputstream. And also try to close that if we can by testing if it is a httpurlconnection or a jarurlconnection..can you test that if that works?johanOn 9/16/06,
Johan Compagner [EMAIL PROTECTED] wrote:
Let m know if that helps for your situation.if really a jar url connection is returned in your case. Because this doesn't have to be the case. Any kind of UrlConnection can be returned (WebLogic does have its own ZipUrlConnection or something like that)
In the end this is a problem of the ClassLoader not closing its internal stuff. Or that UrlConnection doesn't have a disconnect() method in its interface what every UrlConnection must implement.. So that we can disconnect any url connection.
I really don't get it why there is a connect() in the interface but no cleanup methodIt is know bug in the java bug parade. Dont know directly what the number is. Search this mailing list it is talked about quite a lot.
johanOn 9/16/06, Jean-Baptiste Quenot
[EMAIL PROTECTED] wrote:
Hi,When deploying a Wicket applicationin DEVELOPMENT mode with onlyJARs inWEB-INF/lib (no WEB-INF/classes), andtemplates includedinJARs,thenumberof filedescriptorsincreasessteadily,
leading to an OS error: «Too many files open».Whenturning configurationto DEPLOYMENT,the problemdoes notarise.Soit seems liketemplate reloading is leakingJAR filedescriptors.Note: another Wicketuser told me about thisexact problem.I'm
not the only one apparently.Are you aware of the problem?Do you think the attached patch could fix the problem?I will letthepatched systemrununtil tomorrowto seeifit isstillleakingfiles.
To watch the number of times the JARs are open I'm using thefollowing command: lsof -p java-process-id | grep WEB-INF/lib | cut -b60- | sort | uniq -cFWIW I found a similar problem described at Sun:
http://bugs.sun.com/bugdatabase/view_bug.do;:YfiG?bug_id=4386865
Thanks for your help,-- Jean-Baptiste QuenotakaJohn Banana Qwerty
http://caraldi.com/jbq/-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] File descriptor leak in DEVELOPMENT mode... and in DEPLOYMENT as well
first of all always go through the URI when making a File out of a URLgetFile() doesn't work. (empty spaces, encoded you name it)One problem if we completely skip the jars... More and more people use OSGI and bundles those can be updated on the fly. But if we don't see that then we never serve the new file.So just not testing any kind of jar will break stuff.johanOn 9/16/06, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: * Johan Compagner: First ofall youalso should dothat inthe lastModifiedTime call of the URLResourceStream class.Right, thanks for pointing out. The problem is more serious thanI thought first, because thefile descriptor leak also happens in DEPLOYMENT mode, although a lot less.InDEVELOPMENT modetemplatesin JARfilesare checkedeverysecond(by default),sofileleaking isveryquick.ButinDEPLOYMENT mode, it's only whenloading other resources (CSS, JS, images) that the leak occurs. And because of browser caching youdon't notice the leak a lot.I have a very radical solution to that: prevent to update the lastmodified timefor resources in JARsas it doesn't makea lot of sense anyway to reload resources from JARs.I couldn't figure outa more elegant approach.Please find patch attached.If youthink it's worth, I'll add itto the SF tracker.-- Jean-Baptiste Quenot akaJohn Banana Qwertyhttp://caraldi.com/jbq/-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] 1.x branch is missing files
wicket 1.x is still 1.2.3 as far as i know.On 9/16/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:forget about it, everything is okJuergenOn 9/16/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: Provided I didn't misunderstand it, than wicket-1.x is the development branch for 1.3. I checked out all sources (parent, wicket, extension and examples) from SVN, created the eclipse file with maven, cleaned up the project and completely rebuild everything. But I still have ~60 compiler errors AbstractTree cannot be resolved to a type AjaxEditableChoiceLabel ... AjaxEditableMultiLineLabel IColumn... DiffUtil ... ModalWindow... and so on any idea? Juergen- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] ICompoundModel versus IInheritableModel
the CompoundPropertyModel impl/name is right as far as i can seebecause that is a Compound model based on property access.and that is an InheritableModel.ICompoundModel in the javadoc should be renamed. On 9/14/06, Martijn Dashorst [EMAIL PROTECTED] wrote: I see two different names for the model formally known asCompoundPropertyModel (and subclasses thereof):IInheritableModelTICompoundModel (in javadoc)CompoundPropertyModelBoundCompoundPropertyModel AbstractPropertyInheritableModelTAbstractDetachableInheritableModelTIs the new name now InheritableXXX? Or do we keep CompoundXXX?Martijn--Download Wicket 1.2.2 now! New Ajax components: Tree, TreeTable and ModalWindow -- http://wicketframework.org-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Model change in 2.0
i don't think we can remove it completely. At specific points i have to know if the modeli have now in the componet is a wrap model so that i can do things or call the getNestedModel()that method getNestedModel() can be removed from IModel if it where me and added to IWrapModel
johanOn 9/15/06, Martijn Dashorst [EMAIL PROTECTED] wrote:
The outcome of this statement is unclear... Should the IWrapModel go?It is still there (woogle is down, so I can't search the irc logs, tofind if there was a conclusion)MartijnOn 6/22/06, Igor Vaynberg
[EMAIL PROTECTED] wrote: johan, you are back? my gut tells me we should start with IModel and then if we run into a situation that realy really requires us to know about the wrapper we should
introduce iwrapmodel back. -Igor On 6/22/06, Johan Compagner [EMAIL PROTECTED] wrote: no compound is inheritable
And i still don't know if that should really returns a IWrapModel thing or just a IModel The question is do we really need to know if it is a wrap model in some cases. Don't know.
johan On 6/22/06, Matej Knopp [EMAIL PROTECTED] wrote: Btw., ICompoundModel is no longer used, is it?
Matej Knopp wrote: public interface IInheritableModelT extends IModelT { C IModelC wrapOnInhertance(ComponentC component);
} But maybe it makes sense to have a Marker interface for inherited models. -Matej Eelco Hillenius wrote:
getNestedModel was what we plussed on, right? I'm not sure how you can do without IWrapModel though. It's used in several wrapOnxx methods, and it's used to keep the parameterized type. I didn't look at it in a
lot of detail though, so Igor/ Johan will know that better. Eelco On 6/22/06, Matej Knopp
[EMAIL PROTECTED] wrote: I also think we should get rid of getNestedModel and IWrapModel. Anyone objects?
-Matej Martijn Dashorst wrote: +1 for 2.0 less is more.
Martijn On 6/21/06, Eelco Hillenius [EMAIL PROTECTED]
wrote: If we can can rid of it, all the better. I don't think the semantics are great, and they are covered through other means now. If we remove
getNestedModel, we should also remove wicket.Component#sameRootModel(wicket.Component ) and wicket.Component#sameRootModel
(IModel) and update the documentation. Eelco On 6/21/06, Igor Vaynberg
[EMAIL PROTECTED] wrote: i am also thinking of moving getNestedModel into a separate interface because not all models have nested models, and im not even sure we
need it period so removing it completely is also an option imho thoughts?
-igor On 6/21/06, Matej Knopp
[EMAIL PROTECTED] wrote: I'm looking bit deeper and it seems that the semantics of IWrapModel is slightly different than I though, so just silently ignore the
question :) Matej Knopp wrote: Sorry, I meant getNestedModel of course (as there's no such thing
as getWrappedModel). Matej Knopp wrote: Hi,
I'm going through the big model change in 2.0 and I noticed that now we have IWrapModel, but IModel still contains getWrappedModel().
Wouldn't it be cleaner if the getWrappedModel was a member of IWrapModel? -Matej
___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop ___
Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop ___
Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop ___
Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop All the advantages of Linux Managed Hosting--Without the Cost and
Risk! Fully trained technicians. The highest number of Red Hat certifications in the hosting industry. Fanatical Support. Click to learn more
http://sel.as-us.falkag.net/sel?cmd=lnkkid=107521bid=248729dat=121642 ___
Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop All the advantages of Linux Managed Hosting--Without the Cost and Risk! Fully trained technicians. The highest number of Red Hat certifications
in the hosting industry. Fanatical Support. Click to learn more http://sel.as-us.falkag.net/sel?cmd=lnkkid=107521bid=248729dat=121642
___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https
Re: [Wicket-develop] Model change in 2.0
what would happen if you share that model over more then one component?(like you do with compoundmodel by default, i agree with resource on assigment is it maybe a bit different but doesn't have to be)johan
On 9/15/06, Martijn Dashorst [EMAIL PROTECTED] wrote:
Perhaps I'm suffering from late night drowziness, but if I look atResourceModel, I don't see the need for wrapping the object.The assignment is purely for getting the component. I think a betterinterface name would be INeedMyComponentModel.
So resourcemodel.wrapOnAssignment(Component component) would become:public void wrapOnAssignment(Component component) {setComponent(component);}This saves the extra model (== memory). But I might be wrong of course.
MartijnOn 9/15/06, Johan Compagner [EMAIL PROTECTED] wrote: i don't think we can remove it completely. At specific points i have to know if the model
i have now in the componet is a wrap model so that i can do things or call the getNestedModel() that method getNestedModel() can be removed from IModel if it where me and added to IWrapModel
johan On 9/15/06, Martijn Dashorst [EMAIL PROTECTED] wrote: The outcome of this statement is unclear... Should the IWrapModel go?
It is still there (woogle is down, so I can't search the irc logs, to find if there was a conclusion) Martijn On 6/22/06, Igor Vaynberg
[EMAIL PROTECTED] wrote: johan, you are back? my gut tells me we should start with IModel and then if we run into a situation that realy really requires us to know about the wrapper we
should introduce iwrapmodel back. -Igor On 6/22/06, Johan Compagner [EMAIL PROTECTED]
wrote: no compound is inheritable And i still don't know if that should really returns a IWrapModel thing or just a IModel The question is do we really need to know if it is a wrap model in some
cases. Don't know. johan On 6/22/06, Matej Knopp [EMAIL PROTECTED] wrote:
Btw., ICompoundModel is no longer used, is it?Matej Knopp wrote:public interface IInheritableModelT extends IModelT{
C IModelC wrapOnInhertance(ComponentC component);} But maybe it makes sense to have a Marker interface for inherited
models. -Matej Eelco Hillenius wrote:getNestedModel was what we plussed on, right? I'm not sure how you
cando without IWrapModel though. It's used in several wrapOnxx methods,and it's used to keep the parameterized type. I didn't look at it in alot of detail though, so Igor/ Johan will know that better.
Eelco On 6/22/06, Matej Knopp
[EMAIL PROTECTED] wrote:I also think we should get rid of getNestedModel and IWrapModel.Anyone objects? -Matej
Martijn Dashorst wrote:+1 for 2.0 less is more.
Martijn On 6/21/06, Eelco Hillenius [EMAIL PROTECTED] wrote:
If we can can rid of it, all the better. I don't think the semanticsare great, and they are covered through other means now. If we
removegetNestedModel, we should also removewicket.Component#sameRootModel(wicket.Component ) and
wicket.Component#sameRootModel (IModel) and update the documentation. Eelco
On 6/21/06, Igor Vaynberg [EMAIL PROTECTED] wrote:i am also thinking of moving getNestedModel into a separate
interfacebecause not all models have nested models, and im not even sure we need itperiod so removing it completely is also an option imho
thoughts? -igor
On 6/21/06, Matej Knopp [EMAIL PROTECTED] wrote:
I'm looking bit deeper and it seems that the semantics of IWrapModel isslightly different than I though, so just silently ignore the
question :) Matej Knopp wrote:Sorry, I meant getNestedModel of course (as there's no such
thing asgetWrappedModel). Matej Knopp wrote:
Hi, I'm going through the big model change in 2.0 and I noticed
that now wehave IWrapModel, but IModel still contains getWrappedModel(). Wouldn't it be cleaner if the getWrappedModel was a member of
IWrapModel?-Matej
___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop___
Wicket-develop mailing listWicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
___
Wicket-develop mailing listWicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https
Re: [Wicket-develop] 2 junit tests failing: validator and Button
and what did stop you to run the test in 2.0 before you commit?johan 'couldn't resist' pain in the ass.On 9/13/06, Igor Vaynberg [EMAIL PROTECTED] wrote:sorrybutton test was there only in 2.0 and i tested the change in 1.0 before porting it to 2.0.-IgorOn 9/13/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: There are currently 2 unit tests failing. One related to validatorsand the other due to Button. Would the dev who made the change pleasecheck the respective unit test and either modify the test or the coresource code, depending on what needs to be changed. Thanks Juergen-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] response length and charset
i will look at it this week.On 9/12/06, Igor Vaynberg [EMAIL PROTECTED] wrote: i think there is already a bug reported against it that suggests doing resource.tostring().getbytes().length which should fix this. is someone going to look into this? this isnt exactly my forte -Igor On 9/12/06, jan_bar [EMAIL PROTECTED] wrote: Hi,(wicket 1.2.2) If I setPackagedTextTemplate.setCharset(Charset.forName(utf-8)) the responselength is bad, because the undelying IResourceStream returns length in'char' unit (StringBuffer.length ()), but theAbstractStringResourceStream.getInputStream() returns the buffer convertedto bytes, which may be longer if there are non-ascii characters in thebuffer. So the response is cut.Here is (not compilable sample): PackagedTextTemplate test= new PackagedTextTemplate(...);System.out.println(length: + test.length());// returnsstringBuffer.lenght();// returns getString().getBytes(getCharset().name()) bytes int bytes = Streams.copy(test.getInputStream(), newByteArrayOutputStream());System.out.println(bytes: + bytes);It seems like a bug, Jan- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] wicket validators 2.0
fine by meOn 9/11/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
oh yeah, i also want to move ivalidator and friends out of wicket.markup.html.form.validation into wicket.validation, anyone against? 2.0 only of course.-Igor
On 9/11/06,
Igor Vaynberg [EMAIL PROTECTED] wrote:
first pass of this is in svn, so now is the time to look over it and complain about something.the javadoc is not finished but it is coming tomorrow morning so no need to complain about that just yet.
it feels so good to finish the day at 1am working on wicket! no joke, havent had the chance to do this in a while :)
-IgorOn 9/4/06, Igor Vaynberg
[EMAIL PROTECTED] wrote:
i am working on an app that uses wicket and remoting, so i need to
do validation in wicket and in the business layer. the problem is that
our validators do not translate well into the business layer, and i
hate to write them twice. i can do all the validation in the service
layer, but then it is not trivial to map the errors back to the form
components if you need formcomponent precise errors for the ui.
to ease the pain i was thinking of something like thisIValidationContext { Object getValue(); void error(List,Map); }and FormComponent implements IValidationContextwhere
getValue would map onto getConvertedInput() and error would map
directly (obviously we already have getvalue() so it would have to be
called something else)
it still lacks but at least i would be able to reuse the same
validators in a non-wicket context. it also would be great to provide a
seperate wicket-validation.jar or some such.what do you guys think? i havent thought this through in any amount of detail, so perhaps there are better ways to do this.
error(List,Map) is a bit dirty as well, maybe it can be cleaned up somehow.it
will also make validators easier to understand because when you see
validate(FormComponent) your first thought is what the hell do i do
now? where some sort of IValidationContext would be more expressive
and guide the user better.
-Igor
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [ wicket-Bugs-1554508 ] Infinite Loop on Session.getPage
ahh in 2.0 fixed that.On 9/11/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: I've got 184 junit tests failingjava.lang.NullPointerExceptionat wicket.Session.requestDetached (Session.java:1095)at wicket.RequestCycle.detach(RequestCycle.java:858)at wicket.RequestCycle.steps(RequestCycle.java:1100)at wicket.RequestCycle.request(RequestCycle.java:454)at wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:321)at wicket.protocol.http.MockWebApplication.processRequestCycle(MockWebApplication.java:310)at wicket.WicketTestCase.executeTest (WicketTestCase.java:72)at wicket.markup.html.basic.SimplePageTest.testRenderHomePage(SimplePageTest.java:54)at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:39)at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)at java.lang.reflect.Method.invoke(Method.java:585)at junit.framework.TestCase.runTest (TestCase.java:154)at junit.framework.TestCase.runBare(TestCase.java:127)at junit.framework.TestResult$1.protect(TestResult.java:106)at junit.framework.TestResult.runProtected(TestResult.java :124)at junit.framework.TestResult.run(TestResult.java:109)at junit.framework.TestCase.run(TestCase.java:118)at org.eclipse.jdt.internal.junit.runner.junit3.JUnit3TestReference.run(JUnit3TestReference.java :128)at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:38)at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:460)at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests (RemoteTestRunner.java:673)at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:386)at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java :196)JuergenOn 9/11/06, Johan Compagner [EMAIL PROTECTED] wrote: I am now synchronizing around the pagemap (that maybe will be 'window' in 2.0) so that a page access will lock the pagemap. So every page that is touched through the request page is save to be altered/accessed. Also the release is different now. Now not the page id (now pagemap) is released for that thread one by one.But everything that was locked by that thread is released in the detach of the request. I think we can kill the synch on session for the page request targets. because now page request are synced over the pagemap. But i don't know if we have it all then for example bookmarkable request? But i guess this should all go fine. johan On 9/11/06, SourceForge.net [EMAIL PROTECTED] wrote: Bugs item #1554508, was opened at 2006-09-08 06:33 Message generated for change (Comment added) made by joco01 You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=684975aid=1554508group_id=119783 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: core Group: 1.2 Status: Closed Resolution: Fixed Priority: 7 Submitted By: Eelco Hillenius (eelco12) Assigned to: Johan Compagner (joco01) Summary: Infinite Loop on Session.getPage Initial Comment: From thread: http://www.nabble.com/Infinite-Loop-on-Session.getPage%28%29-tf2233107.html Here's a trace of what happens that causes the problem : During the RESOLVE_TARGET step of RequestCycle, the target is trying to be resolved using the DefaultRequestTargetResolverStrategy, which first inside the resolveRenderedPage() method uses Session.getPage() to get the page,(which adds it to the usedPages map,a hidden side-effect imho),and then calls resolveListenerInterfaceTarget() where it retrieves the Component for the path and calls isVisibleInHierarchy() on it. This method throws an exception in my application, which is caught back in the RequestCycle. Now, the target didn't have a chance to be added to requestTargets, but the page has been added to the usedPages. In the detach phase, the requestTargets are detached one by one, which in this case is only the exception page generated. So when i push back and click on another link with the same page id, it'll fall into the loop mentioned, cause the thread hasn't been cleared. I guess this somehow means a problem with the usedPages map, where it should be cleared on an exception. -- Comment By: Johan Compagner (joco01) Date: 2006-09-11 10:53 Message: Logged In: YES user_id=379231 this should be fixed now. -- Comment By: Eelco Hillenius (eelco12) Date: 2006-09-08 07:00 Message: Logged In: YES user_id=820266 Ultimately, the problem comes down to synchronization being scattered over various places. Can we find a way to synchronize all we need from one place without loosing the efficiency we have now
Re: [Wicket-develop] BookmarkablePageLink.getUrl should be public
just call:getRequestCycle().urlFor(pageMap, pageClass, parameters);if you want a bookmarkable url for a page class.johanOn 9/11/06, jan_bar [EMAIL PROTECTED] wrote: Maybe the public getURL() is not needed, because it doesn't work as Iexpected, see user list Get url of BookmarkablePageLink.Regards, Janjan_bar [EMAIL PROTECTED] wrote inmessage news:[EMAIL PROTECTED] Hi wicketeers, (wicket 1.2.2) is there any special reason whyBookmarkablePageLink.getUrl() is protected? I need to know the url outside the component. Should I fill change request? Thanks, Jan-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [ wicket-Bugs-1554508 ] Infinite Loop on Session.getPage
ahh really? can't i say something?Session is not threadsafe anyway..that is pretty hard. you can have SharedResources that can do something with the session.We do things with the session outside of the blocks ourselfs. detach/attach methods.. johanOn 9/11/06, Igor Vaynberg [EMAIL PROTECTED] wrote: nevermind-IgorOn 9/11/06, Igor Vaynberg [EMAIL PROTECTED] wrote: if we dont sync on session then the user will have to himself, and that would really suck.-Igor On 9/11/06, Johan Compagner [EMAIL PROTECTED] wrote: I am now synchronizing around the pagemap (that maybe will be 'window' in 2.0) so that a pageaccess will lock the pagemap. So every page that is touched through the request page is save to be altered/accessed. Also the release is different now. Now not the page id (now pagemap) is released for that thread one by one.But everything that was locked by that thread is released in the detach of the request. I think we can kill the synch on session for the page request targets. because now page request are synced over the pagemap. But i don't know if we have it all then for example bookmarkable request? But i guess this should all go fine.johanOn 9/11/06, SourceForge.net [EMAIL PROTECTED] wrote: Bugs item #1554508, was opened at 2006-09-08 06:33Message generated for change (Comment added) made by joco01You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=684975aid=1554508group_id=119783Please note that this message will contain a full copy of the comment thread,including the initial issue submission, for this request, not just the latest update.Category: coreGroup: 1.2Status: ClosedResolution: FixedPriority: 7Submitted By: Eelco Hillenius (eelco12) Assigned to: Johan Compagner (joco01)Summary: Infinite Loop on Session.getPageInitial Comment:From thread:http://www.nabble.com/Infinite-Loop-on-Session.getPage%28%29-tf2233107.html Here's a trace of what happens that causes the problem :During the RESOLVE_TARGET step of RequestCycle, thetarget is trying tobe resolved using theDefaultRequestTargetResolverStrategy, which first inside the resolveRenderedPage() method usesSession.getPage() to getthe page,(which adds it to the usedPages map,a hiddenside-effectimho),and then calls resolveListenerInterfaceTarget()where it retrieves the Component for the path and callsisVisibleInHierarchy() on it. Thismethod throws an exception in my application, which iscaught back inthe RequestCycle. Now, the target didn't have a chanceto be added to requestTargets, but the page has been added to theusedPages. In thedetach phase, the requestTargets are detached one byone, which in thiscase is only the exception page generated. So when ipush back and click on another link with the same page id, it'll fall intothe loopmentioned, cause the thread hasn't been cleared. Iguess this somehowmeans a problem with the usedPages map, where it shouldbe cleared on an exception.--Comment By: Johan Compagner (joco01)Date: 2006-09-11 10:53Message:Logged In: YES user_id=379231 this should be fixed now.--Comment By: Eelco Hillenius (eelco12)Date: 2006-09-08 07:00Message: Logged In: YESuser_id=820266 Ultimately, the problem comes down to synchronization beingscattered over various places. Can we find a way tosynchronize all we need from one place without loosing theefficiency we have now?-- You can respond by visiting:https://sourceforge.net/tracker/?func=detailatid=684975aid=1554508group_id=119783 -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere
Re: [Wicket-develop] Wicket 1.2 servlet mapping
I am curious that if it is really needed that a context path just always must end with / If that is the case then that patch is not correct because it is very funny that when the servlet path = that you add a / to the context path.. That is strange.If the context path just always have to end with / then the patch should be a few lines up.johan On 9/9/06, Jean-Baptiste Quenot [EMAIL PROTECTED] wrote: Hello Wicket Developers,I discovered aserious problem in Wicket 1.2 whilemy Wicket appwent in production.Previously I was using (root context) in the servlet containerconfiguration,and servletmapping/* in web.xml.Itworksgreat.Youmay be surprised,but yes,it works.Idon't havestatic resourcesto serve, soI didn'tneed to dothe /app/*servlet mapping that is recommended in the documentation. But for production we had thebad idea to change the context pathto /myapp(non-root context), still withservlet mapping /*.And in this configuration, Wicket ceased to work properly. Note: I'mnottalking aboutservletmapping/, whichisadifferent story, I know using that will not work with Wicket.I'monly talking about servlet mapping /*.Thesymptom isthatsubmitting formsusingthe POSTmethod leaded to strangeerrors that revealed that allform values werelost.Looking at the pagesource, form's action attribute gaveme a hint, it was written:form action="" wicket:id=registerForm method=post id=registerForm ^^^Instead of:form action="" wicket:id=registerForm method=post id=registerForm ^^^Inthis case,the servletengine willredirect from/myapp to/myapp/to forceusing acanonical URL,and that'swhy Iwasloosing the form values after POST.The good news is that a one-line patch to WebRequestCodingStrategy is sufficientto fix thewrong Wicket behaviour(see attached).As youknow the URL prefixis computed only atthe first Wicketrequest, andwhen Irequest http://myserver/myapp/ the servletcontainer returns (empty string) asgetServletPath().So theempty string shall notbe a no-go for appending a/ at the endof the URL.Itested thepatch onlywith Jetty5, butif youfeel itis necessary, I can take the time to test on other servlet containerstoo.Thanks for reading up to the end!-- Jean-Baptiste QuenotakaJohn Banana Qwertyhttp://caraldi.com/jbq/ -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [ wicket-Bugs-1554508 ] Infinite Loop on Session.getPage
The stupid thing is that the sync we have build in the RequestTarget isn't doing much currentlybecause the barrier we setup in getPage() already takes care of the sync around the page(without a real large sync blok) So if we want to make one place. Then the current barrier in getPage() is the one that should be thereand the rest can maybe be removed.What we then do miss is this: In Page A there is a reference to Page B and page a does have a barrier but page B ofcourse not. So if a request comes in for A and that request touched B through A thenanother request for B doesn't know that. And currently that is what RequestTarget sync around sessionalso resolves. (and maybe the Session object itself. But that one isn't really threadsafe all the way anyway currently) What we could do is don't make the barrier on Page id's but just on page (any) access in that place.If we have that then any page request will be blocked at that place (as it would be now in RequestTarget.requestAndRespond )johanOn 9/8/06, SourceForge.net [EMAIL PROTECTED] wrote: Bugs item #1554508, was opened at 2006-09-08 06:33Message generated for change (Comment added) made by eelco12You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=684975aid=1554508group_id=119783Please note that this message will contain a full copy of the comment thread,including the initial issue submission, for this request, not just the latest update.Category: coreGroup: 1.2Status: OpenResolution: NonePriority: 7Submitted By: Eelco Hillenius (eelco12)Assigned to: Johan Compagner (joco01)Summary: Infinite Loop on Session.getPageInitial Comment:From thread:http://www.nabble.com/Infinite-Loop-on-Session.getPage%28%29-tf2233107.html Here's a trace of what happens that causes the problem :During the RESOLVE_TARGET step of RequestCycle, thetarget is trying tobe resolved using theDefaultRequestTargetResolverStrategy, which first inside the resolveRenderedPage() method usesSession.getPage() to getthe page,(which adds it to the usedPages map,a hiddenside-effectimho),and then calls resolveListenerInterfaceTarget()where it retrieves the Component for the path and callsisVisibleInHierarchy() on it. Thismethod throws an exception in my application, which iscaught back inthe RequestCycle. Now, the target didn't have a chanceto be added to requestTargets, but the page has been added to theusedPages. In thedetach phase, the requestTargets are detached one byone, which in thiscase is only the exception page generated. So when ipush back and click on another link with the same page id, it'll fall intothe loopmentioned, cause the thread hasn't been cleared. Iguess this somehowmeans a problem with the usedPages map, where it shouldbe cleared on an exception.--Comment By: Eelco Hillenius (eelco12)Date: 2006-09-08 07:00Message:Logged In: YESuser_id=820266 Ultimately, the problem comes down to synchronization beingscattered over various places. Can we find a way tosynchronize all we need from one place without loosing theefficiency we have now?-- You can respond by visiting:https://sourceforge.net/tracker/?func=detailatid=684975aid=1554508group_id=119783 - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
[Wicket-develop] redirecting to an url..(VOTE?)
Hi,The question did popup again how to redirect to an url (external or internal doesn't matter)We already had a RedirectPage that does a meta tag refresh (can be a delayed one)But i also added a RedirectRequestTarget that can be used now. Now the question is should we hide this target as we do with page ?With page you just say: RequestCycle.setResponsePage(page)so should i add RequestCycle.setResponseUrl()?We could also add RequestCycle.redirectTo(url) but this resembles the redirectTo(Page) methodand that method isn't supposed to be called from the outside of the framework.So what is easier?1 use RedirectRequestTarget directly: RequestCycle.setRequestTarget(new RedirectRequestTarget(url));2 have a RequestCycle.setResponseUrl() besides setResponsePage()3 have a RequestCycle.redirectTo(String url)i am thinking just learn how to use RequestTargets so 1 (thats how wicket really works) But i can live with 2 but i am against 3.johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] VOTE: StringValueConversionException as Unchecked
[0] IndifferentOn 9/7/06, Eelco Hillenius [EMAIL PROTECTED] wrote: [0] IndifferentEelcoOn 9/7/06, Nick Heudecker [EMAIL PROTECTED] wrote: I'd like to start a vote on this. [+1] Change StringValueConversionException to an unchecked exception [0] Indifferent [-1] Leave it as is. Here's my non-binding +1. - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] switching parents in 2.0
what about the option:parent.addMovedChild(IMoveable)then it is always compile save and you only have to have moved() on the interface.johanOn 9/7/06,
Igor Vaynberg [EMAIL PROTECTED] wrote:
because components have access to a lot more information on creation it is not always safe to move them around (switch parents) because the underlying markup changes, for exampleclass MyComponent extends Panel {
public MyComponent(...) { if (getAttributes().get(mode).equals(one)) { new MyInnerPanel1(...); } else { new MyInnerPanel2(...); }}so when this component is moved to a different parent it will be attached to a different tag - maybe with a different value of mode defined - so it needs to react to this and adjust or not support moving at all.
there are two lines of thought on this1) allow all components to be movable - that means the implementors of context sensitive components need to always implement the logic to allow their components to readjust when moved
2) only allow components that want to be moved to be movable - that means we dont provide a public api for moving and do something like this:protected Component.switchParent(MContainer newparent) { if (!(isntanceof IMovable)) { throw new exception...} do the parent switching stuff; onMoved(); }}
interface IMovable { void moveTo(MContainer newparent); void onMoved();}the moving api is protected - and should be exposed publicly by users through implementing IMovable (names are up for grabs).what do you guys think? which way sounds better?
-Igor
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] wicket validators 2.0
Is IValidationError really needed?Can't that be a normal class what would the interface really give us?johanOn 9/7/06, Igor Vaynberg
[EMAIL PROTECTED] wrote:ok, so
IValidatableT { T getValue(); error(IValidationError error); }IValidationError { String getMessage(ILocalizer localizer); }ILocalizer { String getMessage(String key); String getMessage(String key, Map params);//not sure if need to have one that also takes params but would be nice
}advantage of IValidationError is that we can get rid of the bunch of ugly error() messages in abstract validator that are messy.thoughts?-Igor
On 9/6/06,
Igor Vaynberg [EMAIL PROTECTED] wrote:
that sounds reasonable, context is the standard term that all the other validation frameworks use so i figured it would be familiar to people.-Igor
On 9/6/06,
Jonathan Locke [EMAIL PROTECTED] wrote:
yeah.i dislike the word 'context' in general because it rarelyseems to add anything intuitive.what about just IValidatable?something that is validatable can be validated by a validator.that makes more sense to me.
igor.vaynberg wrote: actually i18n comes into play so i think i would like void error(String key, Map params) -Igor On 9/5/06, Igor Vaynberg
[EMAIL PROTECTED] wrote: yeah, that makes sense to me.
IValidationContext FormComponent.getValidationContext() { return new IValidationContext() {
T getValue() { return getConvertedInput(); } void error(String s) { FormComponent.this.error (s); } }} -Igor On 9/5/06, Jonathan Locke
[EMAIL PROTECTED] wrote: the list and map look like implementation details to me.
isn't the component itself the validation context?so something more like: IValidationContextT { T getValue();
void error(String); } then an adaptor class connects the two methods to the component. jon
igor.vaynberg wrote: i am working on an app that uses wicket and remoting, so i need to do validation in wicket and in the business layer. the problem is that
our validators do not translate well into the business layer, and i hate to write them twice. i can do all the validation in the service layer,
but then it is not trivial to map the errors back to the form components if youneed formcomponent precise errors for the ui.
to ease the pain i was thinking of something like this IValidationContext { Object getValue(); void error(List,Map); }
and FormComponent implements IValidationContext where getValue would map onto getConvertedInput() and error would map directly (obviously we already have getvalue() so it would have to be
called something else) it still lacks but at least i would be able to reuse the same validators in
a non-wicket context. it also would be great to provide a seperate wicket-validation.jar or some such. what do you guys think? i havent thought this through in any amount
of detail, so perhaps there are better ways to do this. error(List,Map) is a bit dirty as well, maybe it can be cleaned up somehow.
it will also make validators easier to understand because when you see validate(FormComponent) your first thought is what the hell do i do
now? where some sort of IValidationContext would be more expressive and guide the user better.
-Igor - Using Tomcat but need to do more? Need to support web services,
security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server
v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-- View this message in context:
http://www.nabble.com/wicket-validators-2.0-tf2218528.html#a6156683
Sent from the Wicket - Dev forum at Nabble.com .
-
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
- Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
Re: [Wicket-develop] switching parents in 2.0
that would be bad. That will nobody implement. Nobody is going to think about that..Then just let it be moveable and be done with it and warn people about the possible dangerous things(like attributes and id/name changes becaues of the different hierarchy) johanOn 9/7/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Well, if you really think we need such a thing and you want to go forsimplicity, I'd like to see a more optimistic approach: instead of aninterface that allows moving and denying by default, have an interfacethat blocks moving by allow moving by default. EelcoOn 9/7/06, Igor Vaynberg [EMAIL PROTECTED] wrote: the first makes it a lot more work. if you design a component and dont think about it moving and another team member writes code that uses that component and moves it you can have some subtle bugs. (2) makes the moving part explicit - ie this component can be moved - that one cannot. so yeah its an additional interface/api but i think it makes authoring components simpler. -Igor On 9/7/06, Eelco Hillenius [EMAIL PROTECTED] wrote: 1) allow all components to be movable - that means the implementors of context sensitive components need to always implement the logic to allow their components to readjust when moved 2) only allow components that want to be moved to be movable - that means we dont provide a public api for moving and do something like this: Definitively the first. 2) means yet another API addition for a case that strikes me rather theoretical; I'd expect component writers that depend on a certain markup to do the checking themselves whenever they feel they need it. Eelco - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] switching parents in 2.0
the attributes yes but also the markupid (when constructed by the completely hierarchy)johanOn 9/7/06, Eelco Hillenius [EMAIL PROTECTED] wrote:On 9/7/06, Igor Vaynberg [EMAIL PROTECTED] wrote: none of the code youve written so far counts unless are are writing an app against 2.0 because the interfearing features here are only available in 2.0. and even then its a very young concept and code. So which features are they then? Anything else other than the abilityto read markup (attributes)?And why/ when does the markup that the component is attached toswitch? Isn't this only the case when e.g. the parent depends onmarkup of a child? And is it always the component itself we want toprotect, or is it the parent? what we are talking about here is support moving by default - probably breaking things or denying moving by default - yes extra interface which might or might not be api bloatWell, the 'propably breaking thing' is where we don't agree on, as Ithink it's not a common case at all (or read will be if you like). And even if a component got initialized using some attribute of the markupit's attached to and that markup changes somehow (though I don't seehow this happens by switching the parent), even that doesn't mean it is suddenly in an illegal state. Only if the component developerdecides to, which he can by rechecking attributes e.g. when rendering.Eelco- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] switching parents in 2.0
i still think (we need that method anyway) thatparent.switchParent(IMoveable child) is better. (or what ever you wanna call it)It is compile save, instead of runtime and then it is just a marker and they don't have to implement moveTo()
(which is an internal thing in the end anyway)And people can see the api and know and learn it that they can movething by looking at the apiinstead of just having just an interface somewherejohan
On 9/8/06, Eelco Hillenius [EMAIL PROTECTED] wrote:
I get it now. By default such moving is not even supported - you cancreate a new component for a parent or reattach older ones. However,there are some case where you want to be able to move components tonew parents,
e.g. gridview with item reuse == true. As the markup of acomponent is relative to it's parent, the 'new' markup may differ in away that changes the meaning of the component if it was constructedwith that new markup. So it must have some way of re-initializing/
checking it's state when it is attached to another parent.I'm +1 on'2) only allow components that want to be moved to be movable - thatmeans we dont provide a public api for moving and do something like
this:protected Component.switchParent(MContainer newparent) { if(!(isntanceof IMovable)) { throw new exception...} do the parentswitching stuff; onMoved(); }}interface IMovable { void moveTo(MContainer newparent); void onMoved();}'
Eelco-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___Wicket-develop mailing listWicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] StringValueConversionException as Unchecked
the same for me.The thing is if it is a checked how would you handle it now? Can you handle it more gracefully?If it is unchecked people are getting the normal error page much sooner, because it is very unlikely that it will be handled.johanOn 9/6/06, Eelco Hillenius [EMAIL PROTECTED] wrote:I'm completely neutral. Something to say for both sides. If someonewould put a gun to my head to decide, I'd go for unchecked, as most of Wicket's exceptions are unchecked and there has been a tendencytowards unchecked exceptions by many frameworks.EelcoOn 9/5/06, Nick Heudecker [EMAIL PROTECTED] wrote: I'd like to open this (http://www.mail-archive.com/wicket-develop%40lists.sourceforge.net/msg08690.html ) discussion again. The argument for keeping StringValueConversionException checked was to ensure the user didn't enter bogus data.However, as a checked exception, developers are forced to handle this exception on a page-by-page basis, when it could be handled more gracefully, as an unchecked exception, for all pages using Wicket's IExceptionSettings.UnexpectedExceptionDisplay. If developers still want to check for and handle bogus data on a page-by-page basis, that option is still available to them. Thoughts?Thanks for your time. - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [VOTE] Backport fix of [ 1543832 ] FileUpload must be documented better
hmm just not doing a super.onDetach() call in that method is just wrong. I think eclipse will generate it anyway..And killing the onDetach() for subclasses could be bad in the future.johan
On 9/6/06, Frank Bille [EMAIL PROTECTED] wrote:
But should it be final in 2.0? I would like that, because if users override that and don't think about closing streams then they *will* get into trouble because now they think it will be cleaned.
Frank
On 9/6/06, Frank Bille [EMAIL PROTECTED]
wrote:
Ok, no final, fine..And of course no @Override ;) (That patch was for 2.0)Frank
On 9/6/06, Martijn Dashorst
[EMAIL PROTECTED] wrote:And don't add the @OverrideMartijn
On 9/6/06, Johan Compagner [EMAIL PROTECTED] wrote: no doesn't break any binary thing, it should be a drop in replacement
only the behaviour is slightly difference that the streams are getting to be
closed on the end of a request (as it should!) i am +1 Only this should be changed for the patch: +@Override +protected final void onDetach() +{
+super.onDetach(); + +fileUpload.closeStreams(); +} don't make it final. Because that could be a binary drop in replacement problem.
johan On 9/5/06, Martijn Dashorst [EMAIL PROTECTED]
wrote: Does it break binary compatibility?
Martijn On 9/5/06, Frank Bille [EMAIL PROTECTED] wrote: Hey
If you just take you time to skim the bug report[1] then I would like to
know if it would be ok to backport the fix (the patch attached to it or revision 7227 in svn) to 1.x and therefore 1.2. It would be ok for 1.3 I think, but it would also be quite good for
1.2 because it would *maybe* fix a lot of problems the user could have with non-closed input streams. So: +/- on backporting it to 1.x (1.2)? Frank
[1]: http://sourceforge.net/support/tracker.php?aid=1543832
-
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server
v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
--
Download Wicket 1.2.2 now! New Ajax components: Tree, TreeTable and ModalWindow -- http://wicketframework.org
-
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server
v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
--
Download Wicket 1.2.2 now! New Ajax components: Tree, TreeTable and ModalWindow-- http://wicketframework.org
-
Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___
Wicket-develop mailing listWicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
[Wicket-develop] The default impl of: AbstractAjaxBehavior.getCallbackUrl()
Why is that this: /** * Gets the url that references this handler. * * @return the url that references this handler */ public CharSequence getCallbackUrl() { return getCallbackUrl(true, false);
}calling this method:public final CharSequence getCallbackUrl(final boolean recordPageVersion, final boolean onlyTargetActivePage)if it was me then we do exactly the inverse: return getCallbackUrl(false, true);
because for an ajax request you don't want page versioning and you do want to target only the active page (for i guess 90%+ of the time)because ajax calls not on the active page don't seem very usefull to me and page versioning for ajax is also not very usefull
most of the time, because all other urls and forms still point to the old one. So the page will be rollbacked pretty often.I just debugged a problem that uses the normal getCallbackUrl() where the had very vague problems about page expires.
This was happening because of the ajax request that was happening just right after a post. (onBlur)So the ajax call didn't do the work in the active page but on another page in the pagemap..so the new page was thrown out.
This vague behaviour can happen to a lot of people because of these defaults we have, which in my eyes are wrongbut maybe i don't see all the cases.johan
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] wicket validators 2.0
hmm i am not to happy with yet another getValueXXX method on FormComponent. We should clean that up!So i would map to an existing method (i guess getConvertedValue())But you want to sent the FormComponent instances to the service layer? Is the service layer always on the same machine?
(if that is seperated like 1 or more Web servers that handle http load and one service server that does the db handling and so on) you have a problemwhen sending over the formcomponent (that will take everything with it)
And shoudnt the validation context have more info? What property are you validating? Where do i get getValue() on?But can't this be wrapped in a ServiceLayourValidator that makes or is that IValidationContext? And calls the service layer?
johanOn 9/5/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
i am working on an app that uses wicket and remoting, so i need to
do validation in wicket and in the business layer. the problem is that
our validators do not translate well into the business layer, and i
hate to write them twice. i can do all the validation in the service
layer, but then it is not trivial to map the errors back to the form
components if you need formcomponent precise errors for the ui.
to ease the pain i was thinking of something like thisIValidationContext { Object getValue(); void error(List,Map); }and FormComponent implements IValidationContextwhere
getValue would map onto getConvertedInput() and error would map
directly (obviously we already have getvalue() so it would have to be
called something else)
it still lacks but at least i would be able to reuse the same
validators in a non-wicket context. it also would be great to provide a
seperate wicket-validation.jar or some such.what do you guys think? i havent thought this through in any amount of detail, so perhaps there are better ways to do this.
error(List,Map) is a bit dirty as well, maybe it can be cleaned up somehow.it
will also make validators easier to understand because when you see
validate(FormComponent) your first thought is what the hell do i do
now? where some sort of IValidationContext would be more expressive
and guide the user better.
-Igor
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] property models and private field access
fine by me. I altered PropertyResolver and added some test i had to change some behaviour now because testMapSizeLookup() was failing nowbecause findField does find much more then then before.But all test are running fine. Is this wanted in
1.x or just in 2.0?johanOn 9/5/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:
+1JuergenOn 9/5/06, Matej Knopp [EMAIL PROTECTED]
wrote: I'm +1 too. -Matej Eelco Hillenius wrote: I'd be +1 for that. Now that Hibernate, Spring, etc all allow access to private fields, I wouldn't feel bad about supporting that.
EelcoOn 9/4/06, Igor Vaynberg [EMAIL PROTECTED] wrote: should we let our property models access to private fields?
often i have constructs like class MyPage { private String str; new PropertyModel(this, str);
} it sucks to have public getters and setters for str because it breaks encapsulation and beacuse i hate that they take up space in my files :)
what do you all think? -Igor-
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server
v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop -
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1
based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop-Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] wicket validators 2.0
But you want to sent the FormComponent instances to the service layer? Is the service layer always on the same machine? (if that is seperated like 1 or more Web servers that handle http load and one service server that does the db handling and so on) you have a problemwhen sending over the formcomponent (that will take everything with it) no, because validation still happens in wicket layer. i am talking about writing separate validator objects that wicket and the service layer can reuse. So It is pure code reuse. It is not something that you all the same kind of service with both of them. But how do you call it? What triggers the validation?is that a FormValidatior somehow?johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] wicket validators 2.0
wasn't there talk about a common validation framework?you can do what you want now also pretty easy.Only one extra adapterclass inbetween:FormComponent.add(new ServiceLayerValidator(new ZipcodeValidator()));
But some general change/addition into form component is fine by me(i do like that second approach of an extra method returning the ValidationContext instead of letting it implement it)johan
On 9/5/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
basically what i want to do is to have a validation lib that i can use for wicket and /inside/ my service layer.right now i cannot reuse wicket validators because they are tightly bound to form components. if we decouple IValidator from FormComponent via some context interface i can take a StringValidator that we have in wicket and use it inside my service layer.
so here is an examplei have a ZipcodeValidator that validates a string to see if its a valid zipcode.what i would like to be able to do is this:FormComponent.add(new ZipcodeValidator());
and then in my service layerMyUberAddressService.saveAddress(AddressBean bean) { ValidationContext ctx=new ValidationContext(); new ZipcodeValidator().validate(
bean.getZipcode(), ctx); if (ctx.hasError()) { throw new ValidationException(ctx); }}-Igor
On 9/5/06,
Johan Compagner [EMAIL PROTECTED] wrote:
But you want to sent the FormComponent instances to the service layer? Is the service layer always on the same machine?
(if that is seperated like 1 or more Web servers that handle http load and one service server that does the db handling and so on) you have a problemwhen sending over the formcomponent (that will take everything with it)
no, because validation still happens in wicket layer. i am talking about writing separate validator objects that wicket and the service layer can reuse.
So It is pure code reuse. It is not something that you all the same kind of service with both of them.
But how do you call it? What triggers the validation?is that a FormValidatior somehow?johan
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] rename AbstractChoice.getDefaultChoice()-getDefaultChoiceMarkup()
fine by meOn 9/3/06, Igor Vaynberg [EMAIL PROTECTED] wrote: getdefaultchoice actually generates markup, but the name does not express that. renaming to getDefaultChoiceMarkup() will make things much more understandable. we can do only in 2.0 or create a deprecated delegate in 1.3 as well. -Igor -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] icomponentresolver broken in 2.0
yeah from a purely code view or what ever view at itbut in the end, the end result is the same.1 component finds markup2 markup finds componentSo if one implements only the first then the second could fail?
I guess that is maybe not true because if 1 succeeds then 2 won't happen anyway?But if only 2 is implemented then 1 will fail.. So someone who implements 2 shouldalso make sure that 1 works.. But in the end if 1 works then 2 isn't needed anymore.
hmjohanOn 8/29/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:
They are doing exactly the oppositeJuergenOn 8/28/06, Johan Compagner
[EMAIL PROTECTED] wrote: 2 interfaces which do in the end the same (kind) of thing? how are we going to explain that? If they implement one should they also do
the other? If that is the case the i want 1 interface johan On 8/28/06, Igor Vaynberg [EMAIL PROTECTED]
wrote: ayya! can we at least make it so a component can implement IMarkupFinder just like it can IComponentResolver? otherwise its too disjointed to create a separate
imarkupfinder that you register somewhere far away from AnyIdAdapter even though thats the only place that its used at. so you are too busy to do the refactor we talked about in that prototype i
wrote? that would make all these things almost obsolete. i still dont understand/have knowledge about how all this markupstream/resolvers work to do that refactor on my own. -Igor
On 8/28/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: Create a IMarkupFinder which does exactly the opposite to
IComponentResolver and register it with the Application. The resolver tries to find the component to be associated with the Markup (tag). And the MarkupFragmentFinder tries to find the markup associated with
the component. Because we are now calling MarkupFragmentFinder in the Component constructor to find the markup associated with Label(somelable, ..) in your case, it will of course fail. Your
IMarkupFinder must check if component parent == AnyIdAdapter and if yes position the markup stream at the open tag. Thats not especially elegant I know and may be we should a method to
IComponentResolver which is called from MarkupFragmentFinder. In principle I don't like the idea of having to implement two complementary algorithms to achieve what we want but I have no idea
yet on how to solve it. We always need to find the markup associated to a component and if a container we need to iterate of the Markup and find the component associated with a tag.
Juergen On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote: so what do i need to do to make my original example work in
2.0? -Igor On 8/28/06, Juergen Donnerstag [EMAIL PROTECTED]
wrote:You can't. Please see Border.resolve () or all the XXXResolver. I'm notsure you are viewing the IComponentResolvers the right way. See
MarkupContainer.renderNext() as well. Whenever during a render get(id)does not find the component associated with the id, and that happensmore often than you might think, than first the container and all its
parents are checked if they implement IComponentResolver. If yes, itis called and only if not successful it will continue with the search.After the parent hierarchy all IComponentResolvers registered with the
application are called as well, until a resolver returned withsuccess. Basically the resolvers can do whatever they want and theyare not at all limited to finding a component and render it.
Juergen On 8/28/06, Johan Compagner [EMAIL PROTECTED] wrote: thats fine by me.
On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
why not refactor the icomponentresolver to do what it says - resolve the index of the component in the markup - the rendering can be factored
out to places that call resolve()-Igor
On 8/28/06, Johan Compagner [EMAIL PROTECTED]
wrote: i think this is the discussion we had (juergen) in another thread. If you write a IComponentResovler you should also write
something else to be able to look up the childs components markup. Can't we add another method on IComponentResolver? That the
markupfinder can call on the parent for a child? johan
On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
if i understand correctly in
1.2 i can do something like this class AnyIdAdapter extends WebMarkupContainer implements IComponentResolver {
public final boolean resolve(MarkupContainer container, MarkupStream markupStream, ComponentTag tag) {
iterator().next().render(markupStream); return true; } }
so this webmarkup container would render any child with any id so i can do
AnyIdAdapter adapter=new AnyIdAdapter(adapter); adapter.add(new Label
Re: [Wicket-develop] icomponentresolver broken in 2.0
but that shouldn't be the case.in 2.0 in the rendering phase shouldn't happen anything anymoreespecially not markup finding. Because that should be already done in the constructor.The component already has exactly the markup (position) it should have, so what should then be resolved? (except auto components or something like that)johanOn 8/29/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:On 8/29/06, Johan Compagner [EMAIL PROTECTED] wrote: yeah from a purely code view or what ever view at it but in the end, the end result is the same. 1 component finds markup 2 markup finds component So if one implements only the first then the second could fail? I guess that is maybe not true because if 1 succeedsthen 2 won't happen anyway?no. IMarkupFinder is called in the constructor and not needed anymore except for ajax calls. And Icomponentresolver are required during therender phase.Juergen But if only 2 is implemented then 1 will fail.. So someone who implements 2 should also make sure that 1 works.. But in the end if 1 works then 2 isn't needed anymore. hm johan On 8/29/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: They are doing exactly the opposite Juergen On 8/28/06, Johan Compagner [EMAIL PROTECTED] wrote: 2 interfaces which do in the end the same (kind) of thing? how are we going to explain that? If they implement one should they also do the other? If that is the case the i want 1 interface johan On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote: ayya! can we at least make it so a component can implement IMarkupFinder just like it can IComponentResolver? otherwise its too disjointed to create a separate imarkupfinder that you register somewhere far away from AnyIdAdapter even though thats the only place that its used at. so you are too busy to do the refactor we talked about in that prototype i wrote? that would make all these things almost obsolete. i still dont understand/have knowledge about how all this markupstream/resolvers work to do that refactor on my own. -IgorOn 8/28/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: Create a IMarkupFinder which does exactly the opposite to IComponentResolver and register it with the Application. The resolver tries to find the component to be associated with the Markup (tag). And the MarkupFragmentFinder tries to find the markup associated with the component. Because we are now calling MarkupFragmentFinder in the Component constructor to find the markup associated with Label(somelable, ..) in your case, it will of course fail. Your IMarkupFinder must check if component parent == AnyIdAdapter and if yes position the markup stream at the open tag. Thats not especially elegant I know and may be we should a method to IComponentResolver which is called from MarkupFragmentFinder. In principle I don't like the idea of having to implement two complementary algorithms to achieve what we want but I have no idea yet on how to solve it. We always need to find the markup associated to a component and if a container we need to iterate of the Markup and find the component associated with a tag. Juergen On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote:so what do i need to do to make my original example work in 2.0? -Igor On 8/28/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: You can't. Please see Border.resolve () or all the XXXResolver. I'm not sure you are viewing the IComponentResolvers the right way. See MarkupContainer.renderNext() as well. Whenever during a render get(id) does not find the component associated with the id, and that happens more often than you might think, than first the container and all its parents are checked if they implement IComponentResolver. If yes, it is called and only if not successful it will continue with the search. After the parent hierarchy all IComponentResolvers registered with the application are called as well, until a resolver returned with success. Basically the resolvers can do whatever they want and they are not at all limited to finding a component and render it. Juergen On 8/28/06, Johan Compagner [EMAIL PROTECTED] wrote: thats fine by me. On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote: why not refactor the icomponentresolver to do what it says - resolvethe index of the component in the markup - the rendering can be factored outto places that call resolve() -Igor On 8/28/06, Johan Compagner [EMAIL PROTECTED] wrote: i think this is the discussion we had (juergen) in another thread.If you write a IComponentResovler you should also write somethingelse to be able to look up the childs components markup. Can't we add another method on IComponentResolver? That themarkupfinder can
Re: [Wicket-develop] icomponentresolver broken in 2.0
hmm i think we should reverse it then (what igor also proposes)we iterate over the components and let the component handle the markup rendering (which it already should have)johan On 8/29/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: On 8/29/06, Johan Compagner [EMAIL PROTECTED] wrote: but that shouldn't be the case. in 2.0 in the rendering phase shouldn't happen anything anymore especially not markup finding. Because that should be already done in the constructor.we don't but we need to find the component for component tags in the tag body. The component already has exactly the markup (position) it should have, so what should then be resolved? (except auto components or something like that)all the child components of course. During render you iterate over themarkup and whenever you hit a wicket tag you need to find the component. What may work is that we iterate over the completecomponent hierarchy to find the component which has the very samemarkup attached which the container is currently positioned at whilerendering the child components. Juergen johan On 8/29/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: On 8/29/06, Johan Compagner [EMAIL PROTECTED] wrote: yeah from a purely code view or what ever view at it but in the end, the end result is the same. 1 component finds markup 2 markup finds componentSo if one implements only the first then the second could fail? I guess that is maybe not true because if 1 succeedsthen 2 won't happen anyway? no. IMarkupFinder is called in the constructor and not needed anymore except for ajax calls. And Icomponentresolver are required during the render phase. Juergen But if only 2 is implemented then 1 will fail.. So someone who implements 2 should also make sure that 1 works.. But in the end if 1 works then 2 isn't needed anymore. hm johan On 8/29/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:They are doing exactly the opposite Juergen On 8/28/06, Johan Compagner [EMAIL PROTECTED] wrote: 2 interfaces which do in the end the same (kind) of thing? how are we going to explain that? If they implement one should they also do the other? If that is the case the i want 1 interface johan On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote:ayya! can we at least make it so a component can implement IMarkupFinder just like it can IComponentResolver? otherwise its too disjointed to create a separate imarkupfinder that you register somewhere far away from AnyIdAdapter even though thats the only place that its used at. so you are too busy to do the refactor we talked about in that prototype i wrote? that would make all these things almost obsolete. i still dont understand/have knowledge about how all this markupstream/resolvers work to do that refactor on my own. -Igor On 8/28/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:Create a IMarkupFinder which does exactly the opposite to IComponentResolver and register it with the Application. The resolvertries to find the component to be associated with the Markup (tag).And the MarkupFragmentFinder tries to find the markup associated with the component. Because we are now calling MarkupFragmentFinder in theComponent constructor to find the markup associated withLabel(somelable, ..) in your case, it will of course fail. Your IMarkupFinder must check if component parent == AnyIdAdapter and ifyes position the markup stream at the open tag. Thats not especially elegant I know and may be we should a method to IComponentResolver which is called from MarkupFragmentFinder. Inprinciple I don't like the idea of having to implement twocomplementary algorithms to achieve what we want but I have no idea yet on how to solve it. We always need to find the markup associatedto a component and if a container we need to iterate of the Markup andfind the component associated with a tag. Juergen On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote: so what do i need to do to make my original example work in 2.0? -Igor On 8/28/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: You can't. Please see Border.resolve () or all the XXXResolver. I'm not sure you are viewing the IComponentResolvers the right way. See MarkupContainer.renderNext() as well. Whenever during a render get(id) does not find the component associated with the id, and that happens more often than you might think, than first the container and all its parents are checked if they implement IComponentResolver. If yes, it is called and only if not successful it will continue with the search. After the parent hierarchy all IComponentResolvers registered with the application are called as well, until a resolver returned with success. Basically the resolvers can do whatever they want
Re: [Wicket-develop] icomponentresolver broken in 2.0
and that map is created upfront by the page.doRender() or what every render call it is (ajax) So that when streaming the resolving is never be done anymore?I'd much rather attach the markupfragment to each component in theconstructor (but allow for lazy loading) and at the beginning of render() find the associate component for a markup tag but traversingthe component hierarchy and find the component which has exactly thatmarkup already assigned.ahh that looks fine to me.. But what do resolvers do then? Do remember every component should have the markup attached in its constructor.So the markup what its wants to render is always know (or should) after the constructor is done.so what needs to be looked up after that? and what do you mean with lazy loading? When is it loaded then?johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] feature freeze for 1.2 branch
yeah just wait a week and see where we end before starting to do things in 3 branches.johanOn 8/30/06, Igor Vaynberg [EMAIL PROTECTED] wrote:wicket-1.2.2 is pretty much feature complete, and its time to concentrate on wicket-1.3working on 1.3 means committing to wicket-1.x but if we do that now it means we have to branch wicket and havewicket-1.x -- head for 1.3wicket-1.2.x --- head for 1.2because 1.x will have api breaksif we do that _now_ we have to commit bug fixes for 1.2 into at least two, possibly three branchestrunkwicket-1.xwicket-1.2.x this obviously sucks big time, having to commit into two branches is already a pain - having three will drive anyone insaneso what we should do is wait for a week and see if any serious bugs surface ( so far two have ) and fix them in the 1.x branch. after a week we can create the wicket-1.2.x and start using 1.x for 1.3 head. ( the branch that is there now will go away until this weekend )the idea here is that hopefully in a week all major bugs in 1.2.2 will be found+fixed and the chances of having to tweak something in 1.2.x will be significantly reduced.in order to ensure stability of 1.x NO NEW FEATURES SHOULD BE COMMITTED, ONLY BUG FIXES ARE ALLOWED everyone agree? no work on 1.3 or new features for 1.2 for at least a week. if you got itchy fingers knock yourselves out on 2.0i want to see some +1s here people!-Igor -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] icomponentresolver broken in 2.0
i think this is the discussion we had (juergen) in another thread.If you write a IComponentResovler you should also write something else to be able to look up the childs components markup.Can't we add another method on IComponentResolver? That the markupfinder can call on the parent for a child?
johanOn 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
if i understand correctly in 1.2 i can do something like thisclass AnyIdAdapter extends WebMarkupContainer implements IComponentResolver { public final boolean resolve(MarkupContainer container, MarkupStream markupStream, ComponentTag tag)
{ iterator().next().render(markupStream); return true; }}so this webmarkup container would render any child with any id so i can doAnyIdAdapter adapter=new AnyIdAdapter(adapter);
adapter.add(new Label(somelabel, hi));span wicket:id=adapterspan wicket:id=
somerandomid/span/spanand this should work nicely, but it doesnt work in 2.0 - i get wicket.WicketRuntimeException: Unable to find the markup for the component: item
at wicket.MarkupFragmentFinder.find(MarkupFragmentFinder.java:89) at wicket.Component.loadMarkupStream(Component.java:663) at wicket.Component.init(Component.java:629)
because MarkupFragmentFinder doesnt take IComponentResolver into account - and how could it because IComponentResolver also renders the component while MarkupFragmentFinder only locates it.so what should we do? have some IComponentFinder interface, tweak something else?
-Igor
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
[Wicket-develop] Why doesn't IBehaviour have the isEnabled() of a AttributeModifier?
I have the ajax auto complete behaviour attached to a fieldBut if that field is set to disabled or readonly i want the auto complete also not to be rendered.With a AttributeModifier we have isEnabled() but that isn't in the basic IBehaviour interface is there a reason for this? johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] icomponentresolver broken in 2.0
thats fine by me.On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
why not refactor the icomponentresolver to do what it says - resolve the index of the component in the markup - the rendering can be factored out to places that call resolve()-Igor
On 8/28/06, Johan Compagner [EMAIL PROTECTED] wrote:
i think this is the discussion we had (juergen) in another thread.If you write a IComponentResovler you should also write something else to be able to look up the childs components markup.Can't we add another method on IComponentResolver? That the markupfinder can call on the parent for a child?
johanOn 8/28/06, Igor Vaynberg
[EMAIL PROTECTED] wrote:
if i understand correctly in 1.2 i can do something like thisclass AnyIdAdapter extends WebMarkupContainer implements IComponentResolver { public final boolean resolve(MarkupContainer container, MarkupStream markupStream, ComponentTag tag)
{ iterator().next().render(markupStream); return true; }}so this webmarkup container would render any child with any id so i can doAnyIdAdapter adapter=new AnyIdAdapter(adapter);
adapter.add(new Label(somelabel, hi));span wicket:id=adapterspan wicket:id=
somerandomid/span/spanand this should work nicely, but it doesnt work in 2.0 - i get wicket.WicketRuntimeException: Unable to find the markup for the component: item
at wicket.MarkupFragmentFinder.find(MarkupFragmentFinder.java:89) at wicket.Component.loadMarkupStream(Component.java:663) at wicket.Component.init(Component.java:629)
because MarkupFragmentFinder doesnt take IComponentResolver into account - and how could it because IComponentResolver also renders the component while MarkupFragmentFinder only locates it.so what should we do? have some IComponentFinder interface, tweak something else?
-Igor
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] icomponentresolver broken in 2.0
2 interfaces which do in the end the same (kind) of thing?how are we going to explain that? If they implement one should they also do the other?If that is the case the i want 1 interfacejohan
On 8/28/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
ayya!can we at least make it so a component can implement IMarkupFinder just like it can IComponentResolver? otherwise its too disjointed to create a separate imarkupfinder that you register somewhere far away from AnyIdAdapter even though thats the only place that its used at.
so you are too busy to do the refactor we talked about in that prototype i wrote? that would make all these things almost obsolete. i still dont understand/have knowledge about how all this markupstream/resolvers work to do that refactor on my own.
-IgorOn 8/28/06, Juergen Donnerstag
[EMAIL PROTECTED] wrote:
Create a IMarkupFinder which does exactly the opposite toIComponentResolver and register it with the Application. The resolvertries to find the component to be associated with the Markup (tag).And the MarkupFragmentFinder tries to find the markup associated with
the component. Because we are now calling MarkupFragmentFinder in theComponent constructor to find the markup associated withLabel(somelable, ..) in your case, it will of course fail. Your
IMarkupFinder must check if component parent == AnyIdAdapter and ifyes position the markup stream at the open tag.Thats not especially elegant I know and may be we should a method toIComponentResolver which is called from MarkupFragmentFinder. In
principle I don't like the idea of having to implement twocomplementary algorithms to achieve what we want but I have no ideayet on how to solve it. We always need to find the markup associatedto a component and if a container we need to iterate of the Markup and
find the component associated with a tag.JuergenOn 8/28/06, Igor Vaynberg [EMAIL PROTECTED]
wrote: so what do i need to do to make my original example work in
2.0? -Igor On 8/28/06, Juergen Donnerstag [EMAIL PROTECTED]
wrote: You can't. Please see Border.resolve
() or all the XXXResolver. I'm not sure you are viewing the IComponentResolvers the right way. See MarkupContainer.renderNext() as well. Whenever during a render get(id) does not find the component associated with the id, and that happens
more often than you might think, than first the container and all its parents are checked if they implement IComponentResolver. If yes, it is called and only if not successful it will continue with the search.
After the parent hierarchy all IComponentResolvers registered with the application are called as well, until a resolver returned with success. Basically the resolvers can do whatever they want and they
are not at all limited to finding a component and render it. Juergen On 8/28/06, Johan Compagner
[EMAIL PROTECTED]
wrote: thats fine by me. On 8/28/06, Igor Vaynberg
[EMAIL PROTECTED]
wrote: why not refactor the icomponentresolver to do what it says - resolve the index of the component in the markup - the rendering can be factored out
to places that call resolve() -Igor
On 8/28/06, Johan Compagner [EMAIL PROTECTED] wrote:
i think this is the discussion we had (juergen) in another thread.
If you write a IComponentResovler you should also write something else to be able to look up the childs components markup. Can't we add another method on IComponentResolver? That the
markupfinder can call on the parent for a child? johan
On 8/28/06, Igor Vaynberg [EMAIL PROTECTED]
wrote:
if i understand correctly in 1.2 i can do something like this class AnyIdAdapter extends WebMarkupContainer implements
IComponentResolver {public final boolean resolve(MarkupContainer container, MarkupStream markupStream, ComponentTag tag)
{ iterator().next().render(markupStream); return true; } }
so this webmarkup container would render any child with any id so i can do AnyIdAdapter adapter=new AnyIdAdapter(adapter);
adapter.add(new Label(somelabel, hi)); span wicket:id=adapterspan wicket:id= somerandomid/span/span
and this should work nicely, but it doesnt work in 2.0 - i get wicket.WicketRuntimeException: Unable to find the markup for the
component: item at wicket.MarkupFragmentFinder.find
(MarkupFragmentFinder.java:89) at wicket.Component.loadMarkupStream (Component.java:663) at wicket.Component.init(Component.java:629)
because MarkupFragmentFinder doesnt take IComponentResolver into account - and how could it because IComponentResolver also renders the component
while MarkupFragmentFinder only locates it. so what should we do? have some IComponentFinder interface, tweak something else?
-Igor
Re: [Wicket-develop] New svn repo structure
all fine by me but just curious for one thing:Who is doing that commit to releses/wicket-1.2.2 (after which it is readonly)?Because i think you can have a working copy of the changes you want in that release branch/tag and commit that to a tag saying that you want to commit the working copy. I don't know if that works exactly that way i just see that option when i say in eclipse: Team-Branch/Tag johan On 8/25/06, Martijn Dashorst [EMAIL PROTECTED] wrote: All,We've discussed this over and over, and we keep running in circels,having the same conversation and arguments over and over.This is how we're going to do it, it is a combination of the thingsthat have passed. branches/wicket-1.x- wicket 1.3 development after this weekendbranches/wicket-1.2.x- wicket 1.2 bug fixing after this weekendreleases/wicket-1.2.2 - wicket 1.2.2 release branch, which is 'read only' after delivery of wicket-1.2.2.ziptags/wicket-1.2.2 - points to the branching point for the releasetag, serves as patch base pointIf someone needs to build the wicket-1.2.2 release, then he needs to check out: releases/wicket-1.2.2if someone needs to create a patch against 1.2.2, then he has to do soagainst tags/wicket-1.2.2if we need a bug fix for 1.2.2, then it needs to go intobranches/wicket- 1.2.x, and possibly into branches/wicket-1.x and trunkI'm taking the whole sunday for this to 'restructure' the repo and build 1.2.2.If you have any outstanding changes for 1.2, then please get them into branches/WICKET_1_2, because after sunday this branch will be renamedbranches/wicket-1.xMartijn--Download Wicket 1.2.1 now! Embed Wicket components in your portals!-- http://wicketframework.org-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [VOTE] New svn repo structure resolving confusion for Wicket 1.x branches
fine by me except that i don't really like this:Wicket 2.0.1 is released. This means: * copy branches/WICKET_2_0 to tags/START_RELEASE_WICKET_2_0 _1 * copy tags/START_RELEASE_WICKET_2_0_1 to releases/WICKET_2_0_1 * check out releases/WICKET_2_0_1 in a clean workspace * build release, fix version numbers and do the maven magic to buildthe wicket release. * commit changes to releases/WICKET_2_0_1and then the last sentence. what does that mean? commit changes to that release? (releases tag is for me the same as tags it should be readonly) johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [VOTE] New svn repo structure resolving confusion for Wicket 1.x branches
So you only want to commit something that are specific for that build?So after that it is readonly ?Thats fine by me. i thought we then have to branch there.If you need such a thing make a releases\ folder where the releases are with some extra commits that are purely for that releasejohanOn 8/24/06, Martijn Dashorst [EMAIL PROTECTED] wrote:Let me reiterate: *I* have a strong desire to commit changes to the project files I make during a release build. *I* therefore need aplace to commit them.branches was not good. releases is not good. what is left? Shall Ijust go forward and do it the way I seem fit? MartijnOn 8/24/06, Johan Compagner [EMAIL PROTECTED] wrote: fine by me except that i don't really like this: Wicket 2.0.1 is released. This means: * copy branches/WICKET_2_0 to tags/START_RELEASE_WICKET_2_0 _1 * copy tags/START_RELEASE_WICKET_2_0_1 to releases/WICKET_2_0_1 * check out releases/WICKET_2_0_1 in a clean workspace * build release, fix version numbers and do the maven magic to build the wicket release. * commit changes to releases/WICKET_2_0_1 and then the last sentence. what does that mean? commit changes to that release? (releases tag is for me the same as tags it should be readonly) johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop--Download Wicket 1.2.1 now! Embed Wicket components in your portals!-- http://wicketframework.org -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Fwd: [Wicket-autocvs] SF.net SVN: wicket: [7033] branches/WICKET_1_2/wicket/src/java/wicket/markup/MarkupParser.java
All of them don't worklook at the pattern that we had:Pattern.compile(\\[if .+\\](.|\n|\r)*!\\[endif\\]--);and what it is now:Pattern.compile
(\\[if .+\\](.|\n|\r)*!\\[endif\\]);see the -- is gone.That is because the comments we test, so i take the first of below:!--[if IE]style type=text/css@import url(
ie.css);/style![endif]--is always just this[if IE]style type=text/css@import url(ie.css);/style![endif]Because !-- and -- is already stripped.
So the pattern never evaluated to truejohanOn 8/23/06, Juergen Donnerstag
[EMAIL PROTECTED] wrote:Johan,from
http://de.selfhtml.org/css/layouts/browserweichen.htm you'll thatit should look like!--[if IE]style type=text/css@import url(ie.css);/style![endif]--
!--[if IE 6]style type=text/css@import url(ie6.css);/style![endif]--!--[if gte IE 5.5]style type=text/css@import url(ie55+.css);/style
![endif]--!--[if lte IE 5.5999]style type=text/css@import url(ie55-.css);/style![endif]--!--[if lt IE 5.1]style type=text/css@import url(
ie50.css);/style![endif]--based on this information, it was correct. Which pattern didn't work?Juergen-- Forwarded message --From:
[EMAIL PROTECTED] [EMAIL PROTECTED]Date: Aug 23, 2006 4:31 PMSubject: [Wicket-autocvs] SF.net SVN: wicket: [7033]branches/WICKET_1_2/wicket/src/java/wicket/markup/MarkupParser.java
To: [EMAIL PROTECTED]Revision: 7033Author: joco01Date: 2006-08-23 07:31:32 -0700 (Wed, 23 Aug 2006)ViewCVS:
http://svn.sourceforge.net/wicket/?rev=7033view=revLog Message:---wrong pattern for special comments (with if IE check) ended with --and that is already strippedModified Paths:
-- branches/WICKET_1_2/wicket/src/java/wicket/markup/MarkupParser.javaModified: branches/WICKET_1_2/wicket/src/java/wicket/markup/MarkupParser.java===
--- branches/WICKET_1_2/wicket/src/java/wicket/markup/MarkupParser.java2006-08-23 04:29:25 UTC (rev 7032)+++ branches/WICKET_1_2/wicket/src/java/wicket/markup/MarkupParser.java2006-08-23 14:31:32 UTC (rev 7033)
@@ -60,7 +60,7 @@ public class MarkupParser { /** Conditional comment section, which is NOT treated as acomment section */- private static final Pattern CONDITIONAL_COMMENT =Pattern.compile
(\\[if .+\\](.|\n|\r)*!\\[endif\\]--);+ private static final Pattern CONDITIONAL_COMMENT =Pattern.compile(\\[if .+\\](.|\n|\r)*!\\[endif\\]); /** The XML parser to use */
private final IXmlPullParser xmlParser;This was sent by the SourceForge.net collaborative developmentplatform, the world's largest Open Source development site.-
Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-autocvs mailing list[EMAIL PROTECTED]https://lists.sourceforge.net/lists/listinfo/wicket-autocvs
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___Wicket-develop mailing listWicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Wicket 1.2.2 and 1.3
thats what i just wanted to say.Maybe if i have the time on sunday (don't have it on friday and saturday) i will look once more to the completel list of patches and bugs to see what still needs to be done for 1.2.2 Most of those ajax bugs we had (matej) we should fix if possible (matej!) johanOn 8/23/06, Eelco Hillenius [EMAIL PROTECTED] wrote:With the added not that before we start working on 1.3 we should besure that we got rid of all real bugs in 1.2EelcoOn 8/23/06, Eelco Hillenius [EMAIL PROTECTED] wrote: +1 Eelco On 8/23/06, Igor Vaynberg [EMAIL PROTECTED] wrote: yeah, i think we have a lot of good changes for 1.2.2 -Igor On 8/23/06, Martijn Dashorst [EMAIL PROTECTED] wrote: All, We've been developing 1.2.x for a while now, and assuming the proposed repo restructure takes in effect, I suggest the following: - restructure repo - release 1.2.2 - start work on 1.3 Martijn -- Download Wicket 1.2.1 now! Embed Wicket components in your portals! -- http://wicketframework.org - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Wicket 1.2.2 and 1.3
On 8/24/06, Matej Knopp [EMAIL PROTECTED] wrote: Johan Compagner wrote: thats what i just wanted to say. Maybe if i have the time on sunday (don't have it on friday and saturday) i will look once more to the completel list of patches and bugs to see what still needs to be done for 1.2.2 Most of those ajax bugs we had (matej) we should fix if possible (matej!)Yeah, yeah... I'm still backporting some stuff and after I'm done I will definitely look at that.-MatejMatej is DA MAN!johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [ wicket-Bugs-1543832 ] FileUpload must be documented better
what should be the best solution for this then?Just document it that a new stream is created everytime when you call that method and you need to close it? Or that the closing part is done by wicket itself?
johanOn 8/21/06, Matej Knopp [EMAIL PROTECTED] wrote:
Yeah. +1I've been using file upload and I'm not sure if I've closed it all thetime. Hmm.. some nasty leaks could have been there... I should go andcheck it.-MatejSourceForge.net wrote: Bugs item #1543832, was opened at 2006-08-21 11:53
Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting:
https://sourceforge.net/tracker/?func=detailatid=684975aid=1543832group_id=119783 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request,
not just the latest update. Category: None Group: 1.2 Status: Open Resolution: None Priority: 5 Submitted By: Johan Compagner (joco01) Assigned to: Nobody/Anonymous (nobody)
Summary: FileUpload must be documented better Initial Comment: because we do this: public InputStream getInputStream() throws IOException { if (!dfos.isInMemory())
{ return new FileInputStream(dfos.getFile()); } if (cachedContent == null) { cachedContent =
dfos.getData(); } return new ByteArrayInputStream(cachedContent); } that means we don't have a reference to the inputstream WE make. So the outside world should close the
inputstream. This should really be documented. Or we should keep a reference somewhere and have a close that is called. so that we close it ourselfs. --
You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=684975aid=1543832group_id=119783
- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop-Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] switching parents in 2.0?
we could have something likecomponent.moveToParent(parent) ( i don't like just component.setParent() )you do know that this could open up much more things.. You could make panels upfront by just giving them an empty panel parent (with the wizard or something) and then move them to the right place later on.johanOn 8/22/06, Igor Vaynberg [EMAIL PROTECTED] wrote:so whats the deal with this, i would like to upgrade the repeaters package. johan, you have the usecases in your app - how are they working now? do you have an idea of how the api would look? -Igor On 8/8/06, Igor Vaynberg [EMAIL PROTECTED] wrote:i just dont think its a very common usecase to do that...thats all -IgorOn 8/8/06, Johan Compagner [EMAIL PROTECTED] wrote:thats why i wanted at first that panels where roots (instead of only pages) because with servoy we switch a lot of panels (to really different places in the markup of the page) But a panel has its ownso the markup really never changes for the components .. The paths do. The question is how many things we think now are in a fixed/not mutable state? But if we allow a parent switch then suddenly all that state needs to be reevaluated.allow between pages? johan On 8/8/06, Igor Vaynberg [EMAIL PROTECTED] wrote: i dont know. youd have to kinda switch the parent and the id together. set attributes i think we do need to keep, not sure. at least in this case the tag it is being reattached to is the same.i did say parent refactor is not without cons :) -IgorOn 8/8/06, Johan Compagner [EMAIL PROTECTED] wrote: we could allow it somehow, but what to do with the attributes? Reload and throw the current once away? Keep what the developer did set?The markup should be relookuped (and the markup index reset)I dont know what problems could all arise when we do it. But wouldnt repareting be a bit strange for the current setup? Parent Container and Id are more or less now required and final for a component.johan On 8/8/06, Igor Vaynberg [EMAIL PROTECTED] wrote: On 8/8/06, Igor Vaynberg [EMAIL PROTECTED] wrote: ive actually been putting that off on purpose until we flush out more of the 2.0. the problem here is that you need to be able to switch parents of items which 2.0 doesnt allow right nowfor examplerow1: item1 item2 item3 row2: item4 item5now when we delete item2 with itemreuse strategy on that means item 4 will now belong to row1 - so we need to switch its parent somehow.any thoughts? feel free to forward to dev. -IgorOn 8/8/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: 2.0: Could you please have a look at GridView Example - demonstratesa grid view and why it fails.thanksJuergen -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web
Re: [Wicket-develop] relax when MarkupFragmentFinder unable to find Markup
i want to stress out that it is not just for ajax!It is for everything in 2.0. Markup should be there when the component is constructedbecause developers could depend on it now in the constructor and if because of some parent in the change that couldn't match somehow it suddenly doesn't work everything could break.johanOn 8/22/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: Not yet, until now I prepared the markup loading process to be betterprepared for the change. The change we are talking about is not asmall change. It means to turn the render process inside out and Ithought that is planned for V3. IMO there will be no perfect solution for V2 which is due in ~2 months. We'll have a more flexible andpluggable markup finder implementation soon, but users implementingthere own component resolvers will have to implement there own markupfinder as well (if the component is meant to be accessible from ajax). So, for V2 everything is possible, but with room for improvement. Thequestion probably is how many users are implementing there ownresolvers and hence are affected.JuergenOn 8/22/06, Igor Vaynberg [EMAIL PROTECTED] wrote: so whats the deal with the resolvers? you guys come up with something concrete? i was thinking about the repeaters - currently if you look at ICellPopulator the populateItem method looks like this: void populateItem(final Item cellItem, final String componentId, final IModel rowModel); that componentId is not really necessary because i can use IComponentResolver to match the markup to any id as long as there is only one component in the cellItem. so that will save some pain. there are a few other places that are in the exact same boat, so there we can also improve. but before i do this i would like to know if we are going to rip out the icomponentresolver and replace it with something else or if its going to stay for good. -Igor On 8/8/06, Johan Compagner [EMAIL PROTECTED] wrote: But we really need to find a solution for that before the final of 2.0 Drop the resolver completely or whatever for me we can't support both things Then when using a custom what ever resolver will completely bypase the constructor change.. That just can't be in my eyes. We should just think about a solution as soon as possible so that all the components gets on constructor time there markup resolved. Not at render time anymore So how can we do that.. How would you rewrite the current resolvers we have here in core (So don't think about custom resolves) johan On 8/8/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: On 8/8/06, Johan Compagner [EMAIL PROTECTED] wrote: yeah looking that the IComponentResolvers implementations They are not really for resolving markup for a component But they are much more resolving components (creating them) for the markup. And some are really calling render() on components so they really think they are in the render phase. But we have to resolve the markup of the component in the constructor Everything just depends on that now. We are saying now in 2.0 that you can do anything in the constructor of your component/panel. That you have everything there now (attributes and so on) We just can't make exceptions there that sometimes that isn't true.. That would just be wrong. The current implementation is already a temporary solution only. I don't see any issues with changing it until the resolver approach has been completely removed. Keeping it as is means that some 1.2 code doesn't work in 2.0. That includes e.g. bordered pages as well as all apps where users created there own resolvers. So we just have to find a way to always be able to resolve the (none autoadd) components that are added in the constructor.. What kind of situations do fail now? see above. Because users have been allowed to create there own resolvers, and they did in the past, IMO there is no simple solution. Eventually they'll have to create a IMarkupFinder for there own resolvers, but until we changed the core these applications shouldn't fail all by a sudden. Juergen johan On 8/8/06, Juergen Donnerstag [EMAIL PROTECTED] wrote:On 8/8/06, Johan Compagner [EMAIL PROTECTED] wrote: What do you mean the current new code (the code now in components constuctor?) is only there for ajax? The MarkupFragmentFinder has been developed to support AJAX calls. Asit can be used to detected markup errors early, it has been added to the Component constructor.It has nothing to do with ajax. It has everything to do with fail as early as possible when clearly it has. see above.adding components to a parent. The MarkupFinder has to be improved that it uses also the MarkupResolvers somehow. I don't think that it is possible. Resolvers work exactly the reverseorder. Resolvers take a wicket:id and find the component in the hierarchy. MarkupFragmentFinder takes
Re: [Wicket-develop] relax when MarkupFragmentFinder unable to find Markup
The component that has the markup itself doesn't have to load it in the constructor i guess.Because we don't have to resolve it really.But how do we know that?johan On 8/22/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: A problem I came across recently: container.newMarkupResourceStream()is called to load the markup and overriding it allows users to developcomponents with very special needs regarding the source of the markupstream. As this method is invoked from Component.init, you can not rely on any parameter passed to MyComponent.init nor on anyinitializating in your component to control markup loading. It renderscontainer.newMarkupResourceStream() almost useless now. Wouldn't it be better to lazy load the markup when needed or at least to allow forlazy loading if needed?JuergenOn 8/22/06, Johan Compagner [EMAIL PROTECTED] wrote: i want to stress out that it is not just for ajax! It is for everything in 2.0. Markup should be there when the component is constructed because developers could depend on it now in the constructor and if because of some parent in the change that couldn't match somehow it suddenly doesn't work everything could break. johan On 8/22/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: Not yet, until now I prepared the markup loading process to be better prepared for the change. The change we are talking about is not a small change. It means to turn the render process inside out and I thought that is planned for V3. IMO there will be no perfect solution for V2 which is due in ~2 months. We'll have a more flexible and pluggable markup finder implementation soon, but users implementing there own component resolvers will have to implement there own markup finder as well (if the component is meant to be accessible from ajax). So, for V2 everything is possible, but with room for improvement. The question probably is how many users are implementing there own resolvers and hence are affected. Juergen On 8/22/06, Igor Vaynberg [EMAIL PROTECTED] wrote: so whats the deal with the resolvers? you guys come up with something concrete? i was thinking about the repeaters - currently if you look at ICellPopulator the populateItem method looks like this: void populateItem(final Item cellItem, final String componentId, final IModel rowModel); that componentId is not really necessary because i can use IComponentResolver to match the markup to any id as long as there is only one component in the cellItem. so that will save some pain. there are a few other places that are in the exact same boat, so there we can also improve. but before i do this i would like to know if we are going to rip out the icomponentresolver and replace it with something else or if its going to stay for good. -Igor On 8/8/06, Johan Compagner [EMAIL PROTECTED] wrote: But we really need to find a solution for that before the final of 2.0 Drop the resolver completely or whatever for me we can't support both things Then when using a custom what ever resolver will completely bypase the constructor change.. That just can't be in my eyes. We should just think about a solution as soon as possible so that all the components gets on constructor time there markup resolved. Not at render time anymore So how can we do that.. How would you rewrite the current resolvers we have here in core (So don't think about custom resolves)johan On 8/8/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: On 8/8/06, Johan Compagner [EMAIL PROTECTED] wrote:yeah looking that the IComponentResolvers implementationsThey are not really for resolving markup for a componentBut they are much more resolving components (creating them) for the markup.And some are really calling render() on components so they really think theyare in the render phase. But we have to resolve the markup of the component in the constructor Everything just depends on that now. We are saying now in 2.0 that you cando anythingin the constructor of your component/panel. That you have everything therenow (attributes and so on) We just can't make exceptions there that sometimes that isn't true.. Thatwould just be wrong. The current implementation is already a temporary solution only. I don't see any issues with changing it until the resolver approach has been completely removed. Keeping it as is means that some 1.2 code doesn't work in 2.0. That includes e.g. bordered pages as well as all apps where users created there own resolvers. So we just have to find a way to always be able to resolve the (none autoadd) components that areadded in the constructor.. What kind of situations do fail now? see above. Because users have been allowed to create there own resolvers, and they did in the past, IMO there is no simple solution. Eventually they'll have to create a IMarkupFinder for there own resolvers, but until we changed the core
Re: [Wicket-develop] models for 2.0
we have still a little discussion about them. But i don't think they will change much.The discussion is purely about IWrapModel and the getNestedModel() method of IModel.What to do with both.I think getting rid of IWrapModel will be a bit hard. Because we need to know on some places that it is a wrapmodel.. so that we know we have to check for its nested one.(look for example at Component.setModel())And i know that getNestedModel() method of IModel is used ofter in a projectfor getting the real internal model. But i think i am +1 to just move the getNestedModel() to the IWrapModel and keep the IWrapModel.johanOn 8/21/06, Eelco Hillenius [EMAIL PROTECTED] wrote:Hi guys,How are we doing on models for 2.0? Is it getting stable? Can I start writing about them? Or are there a couple of things on the todo liststill?Eelco-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [VOTE] New svn repo structure resolving confusion for Wicket 1.x branches
yes 1.3 will be another branch wicket_1_3_xthis has to be done because 1.2 should stay a branch by itsself. (because it could be that there has to be 1 few importand bugs fixed there)johan On 8/21/06, Martijn Dashorst [EMAIL PROTECTED] wrote: Like I said in the message:trunk/wicket-1.x/ will be the main development stream for 1.xversions. It will be the HEAD for 1.3, 1.4, 1.5, 1.6trunk/wicket-2.x/ will be the main development stream for 2.x versions. It will be the HEAD for 2.0, 2.1, 2.2, 2.3, etc.For 3.x we'll have to see when that happens.We're working on 2 seperate wicket versions at the same time. We'reforked. Better reflect that in the repository than having the problems for 1.2, 1.3, 1.4 etc.Where should 1.3 in your proposal stay? branches/WICKET_1_2 ? Orshould we create another branch? branches/WICKET_1_3? and make thatour primary development stream for wicket 1.x? When should we do create that branch then? How can we prevent people from committingsomething to 1_2 instead of 1_3?MartijnOn 8/20/06, Johan Compagner [EMAIL PROTECTED] wrote: I dont know about this Where will 1.3 reside? and 2.1 ? or 3.x ? (or better said 2.0 when we have released it) 1.2 is just a a branch in my eyes. Oknot really a maintenance branch but something more. But it is in my eyes still a branch I just like this trunk == wicket X (the last wicket where we work on) branch == wicket1.2/wicket1.3 en wicket2.0 when trunk is now wicket2.1 And always tag all the (final) releases we do under tags On 8/20/06, Martijn Dashorst [EMAIL PROTECTED] wrote: There has been some confusion on the branches and Wicket 1.x development. This document proposes a solution to this confusion, and asks for a vote on structure. But first a short analysis of the problems at hand. According to me, the root cause of this confusion is that we have effectively two main development streams: Wicket 1.x and Wicket 2.x. The Wicket 1.x main development stream happens in the branch, and 2.xdevelopment happens in trunk. This effectively makes it harder to distinguish between release branches (1.2.1 for instance) and development branches. To make the distinction more clear on what constitutes the main development streams, I propose to split our current trunk into two forks: wicket-1.x and wicket-2.x. The future development of Wicket will still remain in wicket-2.x, but for support of those already in production we keep the latest version of wicket-1.x up to date with bugfixes and backports. The solution to our problem at hand is that we should: 1. move trunk/ to trunk/wicket-2.x / 2. move branches/WICKET_1_2/ to trunk/wicket-1.x/ 3. copy the specific 1.2 release moment (the actual revision when the 1.2 branch was created) to the branches/WICKET_1_2 directory. 4. copy WICKET_1_2 (the point where the branch was created) to tags/WICKET_1_2 5. copy WICKET_1_2_1 (the point where the branch was created) to tags/WICKET_1_2_1 This way people can get to the bare starting point easier (look in tags/) or check out the branch if they want to replicate the build itself. The final repo directory structure would then be: svnroot/wicket/ branches/ WICKET_1_2/- final build for 1.2 WICKET_1_2_1/- final build for 1.2.1 tags/ WICKET_1_2/- marking start of 1.2 WICKET_1_2_1/- marking start of 1.2.1 trunk/ wicket-1.x/- main development of 1.x (1.2, 1.3, etc) wicket-2.x/- main development of 2.x (2.0, 2.1, etc) If we were to implement this, then *after* the repo repair, the 1.2.2 build would look like the following: 1. create tag from trunk/wicket-1.x/ : tags/WICKET_1_2_2 2. copy tag to branch: branches/WICKET_1_2_2 3. create release from branch, commit release changes to branch 4. merge improvements from WICKET_1_2_2 branch to trunk/wicket- 1.x and trunk/wicket-2.x when applicable. So both in tags/ and branches/ WICKET_1_2_2 tags will be available, where the tags *mark* the release point in time on the trunk, and the branch will contain the artifacts particular for that release. Please vote for this proposal, committers have binding votes. The votewill last for 48 hours. Martijn -- Download Wicket 1.2.1 now! Embed Wicket components in your portals! -- http://wicketframework.org - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application
Re: [Wicket-develop] [VOTE] New svn repo structure resolving confusion for Wicket 1.x branches
But that second thing is what Upayavira proposes so trunk is always just the latest code (head) now 2.0and we just have branches 1.2 and 1.3 and what ever we get.johan On 8/21/06, Martijn Dashorst [EMAIL PROTECTED] wrote: but when we will have 3 main development streams: 1.2, 1.3 and 2.0What I'm proposing is not to branch a development stream, but to tickoff releases from a main development stream, requiring us not toswitch to other directories: With the literal names:trunk/wicket-1.xtrunk/wicket-2.xortrunk/branches/wicket-1.xThe following is NOT what I'm proposing:trunk/wicket-1.2trunk/wicket-1.3 trunk/wicket-2.0trunk/wicket-2.1I think the former communicates the best intent for the repositorystructure: 1.x and 2.x are both under active development, and boththeir HEAD's can be found in trunk. MartijnOn 8/21/06, Johan Compagner [EMAIL PROTECTED] wrote: yes 1.3 will be another branch wicket_1_3_x this has to be done because 1.2 should stay a branch by itsself. (because it could be that there has to be 1 few importand bugs fixed there) johanOn 8/21/06, Martijn Dashorst [EMAIL PROTECTED] wrote: Like I said in the message: trunk/wicket-1.x/ will be the main development stream for 1.x versions. It will be the HEAD for 1.3 , 1.4, 1.5, 1.6 trunk/wicket-2.x/ will be the main development stream for 2.x versions. It will be the HEAD for 2.0, 2.1, 2.2, 2.3, etc. For 3.x we'll have to see when that happens. We're working on 2 seperate wicket versions at the same time. We're forked. Better reflect that in the repository than having the problems for 1.2, 1.3, 1.4 etc. Where should 1.3 in your proposal stay? branches/WICKET_1_2 ? Or should we create another branch? branches/WICKET_1_3? and make that our primary development stream for wicket 1.x? When should we do create that branch then? How can we prevent people from committing something to 1_2 instead of 1_3? Martijn On 8/20/06, Johan Compagner [EMAIL PROTECTED] wrote: I dont know about this Where will 1.3 reside? and 2.1 ? or 3.x ? (or better said 2.0 when we have released it) 1.2 is just a a branch in my eyes. Oknot really a maintenance branch but something more. But it is in my eyes still a branch I just like this trunk == wicket X (the last wicket where we work on) branch == wicket1.2/wicket1.3 en wicket2.0 when trunk is now wicket2.1 And always tag all the (final) releases we do under tags On 8/20/06, Martijn Dashorst [EMAIL PROTECTED] wrote: There has been some confusion on the branches and Wicket 1.x development. This document proposes a solution to this confusion, and asks for a vote on structure. But first a short analysis of the problems at hand. According to me, the root cause of this confusion is that we have effectively two main development streams: Wicket 1.x and Wicket 2.x. The Wicket 1.x main development stream happens in the branch, and 2.x development happens in trunk. This effectively makes it harder to distinguish between release branches (1.2.1 for instance) and development branches. To make the distinction more clear on what constitutes the main development streams, I propose to split our current trunk into two forks: wicket-1.x and wicket-2.x. The future development of Wicket will still remain in wicket-2.x, but for support of those already in production we keep the latest version of wicket-1.x up to date with bugfixes and backports. The solution to our problem at hand is that we should: 1. move trunk/ to trunk/wicket-2.x / 2. move branches/WICKET_1_2/ to trunk/wicket-1.x/ 3. copy the specific 1.2 release moment (the actual revision when the 1.2 branch was created) to the branches/WICKET_1_2 directory. 4. copy WICKET_1_2 (the point where the branch was created) to tags/WICKET_1_2 5. copy WICKET_1_2_1 (the point where the branch was created) to tags/WICKET_1_2_1 This way people can get to the bare starting point easier (look in tags/) or check out the branch if they want to replicate the build itself. The final repo directory structure would then be: svnroot/wicket/ branches/ WICKET_1_2/- final build for 1.2 WICKET_1_2_1/- final build for 1.2.1 tags/ WICKET_1_2/- marking start of 1.2 WICKET_1_2_1/- marking start of 1.2.1 trunk/ wicket-1.x/- main development of 1.x (1.2, 1.3, etc) wicket-2.x/- main development of 2.x (2.0 , 2.1, etc) If we were to implement this, then *after* the repo repair, the 1.2.2 build would look like the following: 1. create tag from trunk/wicket- 1.x/ : tags/WICKET_1_2_2 2. copy tag to branch: branches/WICKET_1_2_2 3. create release from branch, commit release changes to branch 4. merge improvements from WICKET_1_2_2 branch to trunk/wicket- 1.x and trunk/wicket-2.x when applicable. So both in tags/ and branches/ WICKET_1_2_2 tags will be available, where the tags *mark* the release point in time on the trunk
Re: [Wicket-develop] VOTE: incubation at Apache
[X] Yes, let's go Apachelets join the old boys club.On 8/21/06, Eelco Hillenius [EMAIL PROTECTED] wrote:Hi all,Some time ago we announced that we started negotiations with Apache to start an incubation process. That basically means we would be enteringa 'test period' where we proof ourselves to fit in as an Apacheprocess, adhering Apache's rules for creating distributions, voting,etc. The proposal is written up here: http://wiki.apache.org/incubator/WicketProposalThe time is now to vote whether we should get on with this. Wicket'scommitters are the only ones having binding votes. But if you want to air support or concerns, please do. If this proposal passes, the nextstep is that the proposal will be voted on over at Apache.[] Yes, let's go Apache[] No, let's not do that and look for other alternatives Eelco-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Related to: [ 1531861 ] CookieValuePersister support more encoding
+1 for me to backportSo when upgrading the cookies are one time invalid and not recognized? That doesn't seem to bad for me. If it really does fix problems for some languagesjohan On 8/20/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: Related to: [ 1531861 ] CookieValuePersister support more encodingQ:As RFC 2109 defined, cookie only supports ASCII code.Current implementation of CookieValuePersister(wicket 1.2.0) does not encode cookie value as ASCII String. Thus value persistent of FormComponentdoes not work properly when user input Chinese,Japanese... etc.I used URLEncoder/Decoder to convert the cookie name and value. As weuse : for the component path separator and as the component path becomes the Cookie name, after migration the old Cookies will not berecognized anymore. Is that an issue for anyone for V2? Shall Ibackport it to 1.3 as well?Juergen- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] TagModifier
+ for puttin it into coreIt falls under the category like StatelessLink/Form which also users can easily create themselfs.Only by having such a thing with the naming you can better read the code so you know what it does. johanOn 8/20/06, Jonathan Locke [EMAIL PROTECTED] wrote: based on the fact that there are a number of different reasons i could beusing it in voicetribe, and that is not really a huge project, i'd have tosay, yes.i think this will be used in the majority of non-trivial wicket applications.this is the reason i would like to see it in core.Gwyn wrote: I've not doing much actual Wicket coding (as till recently my main target architechture was WL6.1/JDK1.3.1), so can't comment myself, but do you think this is likely to be of use in the majority of (non-trivial) Wicket apps? If so, I'd support Core, whereas I'd think Extensions might be better if it's more specialised... /Gwyn On 19/08/06, Jonathan Locke [EMAIL PROTECTED] wrote: yeah, i'm certainly someone who could have written this component too. only i didn't.and now i've slowly added more and more instances of the one time solution of webmarkupcontainer + simpleattributemodifier. the only hope here is to have a handy core component.i would have used that throughout.another argument in favor is that this is such a common problem that we'll either have (a) no implementation of a custom component to fix the problem and the requisite small messes everywhere or (b) slightly different implementations of this component in every project possibly each with its own quirks or bugs or naming conventions.i don't think either alternative is good. jon Eelco Hillenius wrote: On 8/19/06, Igor Vaynberg [EMAIL PROTECTED] wrote: -1 for core +1 for extensions It wouldn't make sense to me to put this in extensions. I'm +1 only for core. Otherwise I wouldn't bother. i think you are actually doing the newbies a disservice by providing this. these are elementary concepts they need to master. I understand your point but I don't agree. TagModifier would be much better alternative to using WebMarkupContainer. Yes, people *could* make their own. But they don't. We don't either, as examples but also e.g. Teachscape is pretty dense with WebMarkupContainers with attrib mods attached to it. *My* whole agreement with Jonathan is not so much that it saves some code - which is the main argument of some of the other convenience components - but just that we then have a component to express a common cause with a name that very clearly communicates it's intend. Re the elementary concepts.. you mean they have to learn about creating custom components or how to use attribute modifiers or both? I don't think having this component will have a large effect on that either way. So... +1 for core, or -1 otherwise. Eelco -- Download Wicket 1.2.1 now! - http://wicketframework.org - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop--View this message in context: http://www.nabble.com/TagModifier-tf2133025.html#a5889143 Sent from the Wicket - Dev forum at Nabble.com.-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Generic Converter for Domain Model
yes the conversion exception is catched by the convert method of the form component.And then the form component handles this by adding an error (for the feedback panel)We should improve the javadoc of IConverter.convert
so that it tells us what exceptions could be thrownOr make ConversionException not a runtime exception, which i take in this case could be a good thing.johanOn 8/20/06,
Jean-Baptiste Quenot [EMAIL PROTECTED] wrote:
* Johan Compagner: But i think a converter itself should be even simpler like we have now in 2.0 IConverter: Object convertToObject(String value, Locale locale);That's interesting.In Cocoon it is called convertFromString()
instead of convertToObject(), because a [1]ConversionResult isreturned instead of Object.Basically a ConversionResult contains the actual result, but alsostores any possible conversion problem:
public class ConversionResult {private ValidationError validationError;private boolean successful;private Object result;}Does Wicket 2.0 already handle conversion errors?Does it even
catch exceptions at all?-- Jean-Baptiste QuenotakaJohn Banana Qwertyhttp://caraldi.com/jbq/[1]
http://svn.apache.org/viewvc/cocoon/trunk/blocks/cocoon-forms/cocoon-forms-impl/src/main/java/org/apache/cocoon/forms/datatype/convertor/Convertor.java?revision=392574view=markup-
Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] how to use ResourceReference
See for an example the FormInputApplication in wicket examples.But the simple thing is in the init of your app:getSharedResouces().add(myimage, new XxxxResource());and thenImageButton(mybutton', new ResourceReference(myimage)) johanOn 8/19/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:Hi ,can anybody tell me how to use ResourceReference to get button image from any specific folder.?I want to create a ImageButton .Regards,Pradip Nehe(201) 284 3711- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [VOTE] New svn repo structure resolving confusion for Wicket 1.x branches
I dont know about thisWhere will 1.3 reside? and 2.1 ? or 3.x ?(or better said 2.0 when we have released it)1.2 is just a a branch in my eyes. Ok not really a maintenance branch but something more. But it is in my eyes still a branchI just like thistrunk == wicket X (the last wicket where we work on)branch == wicket1.2/wicket1.3 en wicket2.0 when trunk is now wicket2.1And always tag all the (final) releases we do under tags On 8/20/06, Martijn Dashorst [EMAIL PROTECTED] wrote: There has been some confusion on the branches and Wicket 1.xdevelopment. This document proposes a solution to this confusion, andasks for a vote on structure. But first a short analysis of theproblems at hand. According to me, the root cause of this confusion is that we haveeffectively two main development streams: Wicket 1.x and Wicket 2.x.The Wicket 1.x main development stream happens in the branch, and 2.x development happens in trunk. This effectively makes it harder todistinguish between release branches (1.2.1 for instance) anddevelopment branches.To make the distinction more clear on what constitutes the main development streams, I propose to split our current trunk into twoforks: wicket-1.x and wicket-2.x. The future development of Wicketwill still remain in wicket-2.x, but for support of those already inproduction we keep the latest version of wicket-1.x up to date withbugfixes and backports.The solution to our problem at hand is that we should:1. move trunk/ to trunk/wicket-2.x/2. move branches/WICKET_1_2/ to trunk/wicket-1.x/3. copy the specific 1.2 release moment (the actual revision when the1.2 branch was created) to the branches/WICKET_1_2 directory.4. copy WICKET_1_2 (the point where the branch was created) to tags/WICKET_1_25. copy WICKET_1_2_1 (the point where the branch was created) to tags/WICKET_1_2_1This way people can get to the bare starting point easier (look intags/) or check out the branch if they want to replicate the builditself.The final repo directory structure would then be: svnroot/wicket/branches/WICKET_1_2/- final build for 1.2WICKET_1_2_1/- final build for 1.2.1tags/WICKET_1_2/- marking start of 1.2WICKET_1_2_1/- marking start of 1.2.1trunk/wicket-1.x/- main development of 1.x (1.2, 1.3, etc)wicket-2.x/- main development of 2.x (2.0, 2.1, etc)If we were to implement this, then *after* the repo repair, the 1.2.2build would look like the following:1. create tag from trunk/wicket-1.x/ : tags/WICKET_1_2_22. copy tag to branch: branches/WICKET_1_2_2 3. create release from branch, commit release changes to branch4. merge improvements from WICKET_1_2_2 branch to trunk/wicket-1.x andtrunk/wicket-2.x when applicable.So both in tags/ and branches/ WICKET_1_2_2 tags will be available, where the tags *mark* the release point in time on the trunk, and thebranch will contain the artifacts particular for that release.Please vote for this proposal, committers have binding votes. The vote will last for 48 hours.Martijn--Download Wicket 1.2.1 now! Embed Wicket components in your portals!-- http://wicketframework.org- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] urlfor funcs
No we should hide the thread local access. That is prefectly fine.It is much more clear that all the things you do you do not on the component but on the request cycle.It just makes much more sense. just some setResponsePage() somewhere in the code in a component. What is that
why call that on the component? what has that to do with the component you are inCompletely nothing, It just looks like some static import that you can call.The problem also now is that we must have all those methods in sync. So add one in request cycle
and we also have to delegate it again in the component. That is in my eyes not needed. This one is the only one that i think should stay:public final CharSequence urlFor(final RequestListenerInterface listener)
because for that you really ask the url of this component for that listener interface the component has.So that one should stay because you really ask something from that component.johan
On 8/20/06, Martijn Dashorst [EMAIL PROTECTED] wrote:
I think that Delegate is an appropiate pattern here, which is used inmuch of the convenience methods. One of the biggest problems Java isfacing is the verbosity ofthe language. Removing these delegatingmethods will make reading the application methods a lot less clear.
I don't 'get' what someone will possibly understand better from havinggetRequestCycle() everywhere in the Java class. If it is a problem ofunderstanding, then we need some serious extra documentation.
And while you're at it, why not remove getRequestCycle() andgetSession() also? RequestCycle.get() and Session.get() are just oneextra character, and communicate intent even better?If we're going to move responsibilities to their respective classes,
then why not movethe 'convenience methods' to their classes:public static final void RequestCycle.setResponsePage(Page page) {RequestCycle.get().setResponsePage(page);}This way you can do:
public void onSubmit() {RequestCycle.setResponsePage(new MyPage());}MartijnOn 8/19/06, Johan Compagner [EMAIL PROTECTED] wrote: yes if i have to clean up component, then i am really going to clean it up!!
Then i will remove pretty much all those silly redirect methods.. I personally never liked them from day one. Developers need to understand what exactly happen. just calling in a onSubmit() setResponsePage(new MyPage()) out of the blue
is a bit strange because what does that have to do with the component/innerclass you are currently on? Developers don't learn anything if you ask me. getRequestCycle().setResponsePage(xxx) is maybe a bit more
verbose but it makes things really clear.. Those methods are in my eyes something like Static imports (the feature of java 5 i really don't like) johan
On 8/19/06, Martijn Dashorst [EMAIL PROTECTED] wrote: +1 and this can get on the list for 1.3 as well IMO, or will this become a big api change?
Martijn On 8/18/06, Igor Vaynberg [EMAIL PROTECTED] wrote: is there any reason why urlfor calls are not synchronized between
requestcycle and component? i know component had some urlfor that were conviniences and basically passed in this for some params - but what about
requestcycle.urlfor(page) - should that not also be in component? i think it was a mistake to start with to pollute component with urlfor - its too late to do anything now but maybe in
2.0 we can get rid of them? there is nothing wrong with getRequestCycle().urlFor() syntax imho -Igor -
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server
v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-- Download Wicket 1.2.1 now! Embed Wicket components in your portals! -- http://wicketframework.org
- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job
easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop -
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server
v.1.0.1 based on Apache Geronimo http://sel.as
Re: [Wicket-develop] urlfor funcs
no not hiding in a sense of make them private or somethingBut more in a sense that developers don't have to call that normally.We hide the static access and the usage of a thread local for normal use.johan
On 8/20/06, Matej Knopp [EMAIL PROTECTED] wrote:
Which ones? RequestCycle.get() and Session.get()? Don't you dare to hidethose! :-)-MatejJohan Compagner wrote: ohh forgot to mention. I don't like static access methods. Those if needed (for threadlocals)
should be hidden as possible. johan On 8/20/06, * Johan Compagner* [EMAIL PROTECTED] mailto:
[EMAIL PROTECTED] wrote: No we should hide the thread local access. That is prefectly fine. It is much more clear that all the things you do you do not on the component but on the request cycle.
It just makes much more sense. just some setResponsePage() somewhere in the code in a component. What is that why call that on the component? what has that to do with the
component you are in Completely nothing, It just looks like some static import that you can call. The problem also now is that we must have all those methods in sync.
So add one in request cycle and we also have to delegate it again in the component. That is in my eyes not needed. This one is the only one that i think should stay:
public final CharSequence urlFor(final RequestListenerInterface listener) because for that you really ask the url of this component for that listener interface the component has.
So that one should stay because you really ask something from that component. johan On 8/20/06, *Martijn Dashorst*
[EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: I think that Delegate is an appropiate pattern here, which is
used in much of the convenience methods. One of the biggest problems Java is facing is the verbosity ofthe language. Removing these delegating methods will make reading the application methods a lot less clear.
I don't 'get' what someone will possibly understand better from having getRequestCycle() everywhere in the Java class. If it is a problem of understanding, then we need some serious extra documentation.
And while you're at it, why not remove getRequestCycle() and getSession() also? RequestCycle.get() and Session.get() are just one extra character, and communicate intent even better?
If we're going to move responsibilities to their respective classes, then why not movethe 'convenience methods' to their classes: public static final void
RequestCycle.setResponsePage(Page page) { RequestCycle.get().setResponsePage(page); } This way you can do: public void onSubmit() {
RequestCycle.setResponsePage(new MyPage()); } Martijn On 8/19/06, Johan Compagner [EMAIL PROTECTED] mailto:
[EMAIL PROTECTED] wrote: yes if i have to clean up component, then i am really going to clean it up!! Then i will remove pretty much all those silly redirect
methods.. I personally never liked them from day one. Developers need to understand what exactly happen. just calling in a onSubmit() setResponsePage(new MyPage()) out
of the blue is a bit strange because what does that have to do with the component/innerclass you are currently on? Developers don't learn anything if you
ask me. getRequestCycle().setResponsePage(xxx) is maybe a bit more verbose but it makes things really clear.. Those methods are in my eyes something like Static imports
(the feature of java 5 i really don't like) johanOn 8/19/06, Martijn Dashorst
[EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: +1 and this can get on the list for
1.3 as well IMO, or will this become a big api change? Martijn On 8/18/06, Igor Vaynberg
[EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: is there any reason why urlfor calls are not synchronized
between requestcycle and component? i know component had some urlfor that were conviniences and basically passed in this for some
params - but what about requestcycle.urlfor(page) - should that not also be in component? i think it was a mistake to start with to pollute
component with urlfor - its too late to do anything now but maybe in 2.0 we can get rid of them? there is nothing wrong with getRequestCycle().urlFor()
syntax imho -Igor-
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to
make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___ Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net mailto:Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-- Download Wicket 1.2.1 now! Embed Wicket components in your portals
Re: [Wicket-develop] [VOTE] New svn repo structure resolving confusion for Wicket 1.x branches
also +1 for meand this sandbox approache:/sandbox/ajax_tryoutOn 8/20/06, Eelco Hillenius [EMAIL PROTECTED] wrote: We should have: /trunk - 2.0 /branches/wicket-1.2 - 1.2 /releases/wicket-1.2.0 /releases/wicket-1.2.1 /releases/wicket-1.2.2That makes sense to me: +1 on that.Eelco- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] TagModifier
TagModifierContainer ;)On 8/20/06, Eelco Hillenius [EMAIL PROTECTED] wrote: the counter point being that you are adding components to a TagModifier - which is a bit weird since TagModifier doesnt really communicate its a container, but that is the common usecase here right? You have a point there...Eelco-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Reloading markup does not affects attributes of existing component instances in 2.0.
Yes (we, igor and me) already had this discussion sometime ago when discussing the copy on write map..The problem is we should merge it somehow.. because what if people just added, removed or updated a attribute??? johanOn 8/19/06, Igor Vaynberg [EMAIL PROTECTED] wrote: we load the attrs into a copy-on-write map - we need to reset the map when the markup is reloaded i guess, right johan?-Igor On 8/19/06, Matej Knopp [EMAIL PROTECTED] wrote: I didn't add any attribute modifier. input style=abc/new TextField(...then I changed markup toinput style=xyzthe markup reloaded but until I created new instance of page (and thus new instance of the TextField), the rendered style was abc.-MatejJuergen Donnerstag wrote: Sorry, I don't understand it. Can you be a bit more explicit input style=xxx TextField field = new field.add(new AttributeModifier(style, ...) or are you talking about Component.setStyle()? Juergen On 8/19/06, Matej Knopp [EMAIL PROTECTED] wrote: My current use case is that I have an input with a style attribute (attached to a TextField). When I change the content of the style attribute, markup is reloaded but new style is not displayed, because TextField remembers old attribute. Why is that? Shouldn't it only remember the attributes after I change it in code (using getMarkupAttributes)? -Matej Juergen Donnerstag wrote: What is the use case for changing Component attributes due to the associate Markup being re-loaded? Which component attributes should be reset? To which value? In V2 you may call MarkupCache.addAfterLoadListener() to register a listener though not invented for this purpose. Juergen On 8/19/06, Matej Knopp [EMAIL PROTECTED] wrote: Is this a feature or a bug? -Matej - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Re: [Wicket-develop] urlfor funcs
yes if i have to clean up component, then i am really going to clean it up!!Then i will remove pretty much all those silly redirect methods..I personally never liked them from day one. Developers need to understand what exactly happen. just calling in a onSubmit() setResponsePage(new MyPage()) out of the blueis a bit strange because what does that have to do with the component/innerclassyou are currently on? Developers don't learn anything if you ask me. getRequestCycle().setResponsePage(xxx) is maybe a bit more verbosebut it makes things really clear..Those methods are in my eyes something like Static imports (the feature of java 5 i really don't like) johanOn 8/19/06, Martijn Dashorst [EMAIL PROTECTED] wrote: +1 and this can get on the list for 1.3 as well IMO, or will thisbecome a big api change?MartijnOn 8/18/06, Igor Vaynberg [EMAIL PROTECTED] wrote: is there any reason why urlfor calls are not synchronized between requestcycle and component? i know component had some urlfor that were conviniences and basically passed in this for some params - but what about requestcycle.urlfor(page) - should that not also be in component? i think it was a mistake to start with to pollute component with urlfor - its too late to do anything now but maybe in 2.0 we can get rid of them? there is nothing wrong with getRequestCycle().urlFor() syntax imho -Igor - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop--Download Wicket 1.2.1 now! Embed Wicket components in your portals!-- http://wicketframework.org -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] AJAX supported browsers
really? if you press Q it prints A?Strange keyword indeed.johanOn 8/19/06, Frank Bille [EMAIL PROTECTED] wrote:... and I need to get out of here... it should have been a Q and not an A. damn keyboardOn 8/19/06, Frank Bille [EMAIL PROTECTED] wrote:And someone has already come up with a better A in the FAQ.. The link is now: http://www.wicket-wiki.org.uk/wiki/index.php/FAQs#Which_browsers_has_been_tested_with_Wicket_AJAX On 8/19/06, Frank Bille [EMAIL PROTECTED] wrote: HeyI have created a FAQ entry in the wiki. But I don't know all the supported browsers. If you know a browser (or a version) which work please add it. http://www.wicket-wiki.org.uk/wiki/index.php/FAQs#Which_browsers_works_with_Wicket_AJAX- Frank -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] AJAX supported browsers
hmmmit seems that also my keyboard is not working correctly;)johanOn 8/19/06, Igor Vaynberg [EMAIL PROTECTED] wrote:you mean a keyboard? -IgorOn 8/19/06, Johan Compagner [EMAIL PROTECTED] wrote: really? if you press Q it prints A?Strange keyword indeed.johanOn 8/19/06, Frank Bille [EMAIL PROTECTED] wrote:... and I need to get out of here... it should have been a Q and not an A. damn keyboardOn 8/19/06, Frank Bille [EMAIL PROTECTED] wrote:And someone has already come up with a better A in the FAQ.. The link is now: http://www.wicket-wiki.org.uk/wiki/index.php/FAQs#Which_browsers_has_been_tested_with_Wicket_AJAX On 8/19/06, Frank Bille [EMAIL PROTECTED] wrote: HeyI have created a FAQ entry in the wiki. But I don't know all the supported browsers. If you know a browser (or a version) which work please add it. http://www.wicket-wiki.org.uk/wiki/index.php/FAQs#Which_browsers_works_with_Wicket_AJAX- Frank -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] urlfor funcs
yip also my sentiment.. Dont break api in 1.3 if it is not really needed (== cleanup)johanOn 8/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote:Yeah. Do it for 2.0. I'm not much in favor of doing this for 1.3. Weshould keep API for 1.3 minimal to make transition from 1.2. to 1.3. -something hopefully a lot of people will do - will be relativelypainless.EelcoOn 8/19/06, Igor Vaynberg [EMAIL PROTECTED] wrote: go ahead, i dare you! -Igor On 8/19/06, Johan Compagner [EMAIL PROTECTED] wrote: yes if i have to clean up component, then i am really going to clean it up!! Then i will remove pretty much all those silly redirect methods.. I personally never liked them from day one. Developers need to understand what exactly happen. just calling in a onSubmit() setResponsePage(new MyPage()) out of the blue is a bit strange because what does that have to do with the component/innerclass you are currently on? Developers don't learn anything if you ask me. getRequestCycle().setResponsePage(xxx) is maybe a bit more verbose but it makes things really clear.. Those methods are in my eyes something like Static imports (the feature of java 5 i really don't like)johan On 8/19/06, Martijn Dashorst [EMAIL PROTECTED] wrote: +1 and this can get on the list for 1.3 as well IMO, or will this become a big api change? Martijn On 8/18/06, Igor Vaynberg [EMAIL PROTECTED] wrote:is there any reason why urlfor calls are not synchronized betweenrequestcycle and component? i know component had some urlfor that wereconviniences and basically passed in this for some params - but what aboutrequestcycle.urlfor(page) - should that not also be in component? i think it was a mistake to start with to pollute component with urlfor - its too late to do anything now but maybe in 2.0 we can get rid of them?there is nothing wrong with getRequestCycle().urlFor() syntax imho -Igor -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your jobeasierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -- Download Wicket 1.2.1 now! Embed Wicket components in your portals! -- http://wicketframework.org - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support
Re: [Wicket-develop] two small feature ideas
fine by me but we shouldn't go to far with itThings like RequiredTextField which is now only one property...But again it is widely used i think so it serves it purpose.And we now also have StatelessLink/Form ( 2.0) that also really overrides one method But those are really handy and it is directly visible that you want to do stateless.And much better then when they always have to override that method.johan On 8/19/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 8/19/06, Martijn Dashorst [EMAIL PROTECTED] wrote: Coming in late for the party, but now you see the benefits of mailinglists instead of IRC :-) And I was just about to propose to shut down the lists in favor of theIRC channel. Or wait... I agree with Igor, in the sense that we should be careful with adding convenience stuff to core. On the other hand we try to create a workable framework that actually saves people time. I think this could be a perfect example for the Wiki, or an example document on our front page, showing how *you* can expand the Wicket framework.Ok, so say we make that class in the examples, and we use iteverywhere where we now use WebMarkupContainer. I almost smell thosemessages pouring in like: 'where can I find that component? Why isn't it part of core?'.I still feel that of all the convenience we can think of, this is thelightest offender and is actually helpful in the way that it gives abetter name for something people will do a lot. And even if they can easily create such a component themselves, they probably don't, justlike none of use haven't for any of the comparable cases.Maybe I should put this differently, or start a vote: who is reallyagainst this? Eelco Martijn On 8/15/06, Eelco Hillenius [EMAIL PROTECTED] wrote: On 8/14/06, Igor Vaynberg [EMAIL PROTECTED] wrote: i think 1 is trivial and should not be part of the core. our api has a pretty large surface for the users to learn already and i dont think we need to throw such things in. I would usually agree with that, but in this case I'd be +1 for the addition. TagModifier looks a lot better to me than WebMarkupContainer, the latter being a base class, and TagModifier's name only implying it is for a specific purpose. *If* we would agree to put this in the project, we state in it's API docs that it is not mean for anything else. Eelco -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___Wicket-develop mailing listWicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Reloading markup does not affects attributes of existing component instances in 2.0.
i am not pro for ditching thati like the getAttributes() approachBecause they are going to use it for getting stuff in the constructorso if they can't set it then we get those questions again!And i don't like the attributemodifier anyway for the simple things.
johanOn 8/19/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
we thought it would be nice to just be able to do public MyComponent(MarkupContainer parent, String id) { super(parent, id); getAttributes().put(class,error);}
instead of overriding oncomponenttag or using attributemodifier for simple situations like these.
but maybe we should ditch the idea.-IgorOn 8/19/06,
Juergen Donnerstag [EMAIL PROTECTED]
wrote:What I haven't understood yet is why this map is modifyable? Why isn't
it just a read-only map. What is wrong with using AttributeModifierinstead.JuergenOn 8/19/06, Johan Compagner
[EMAIL PROTECTED] wrote: Yes (we, igor and me) already had this discussion sometime ago when
discussing the copy on write map.. The problem is we should merge it somehow.. because what if people just added, removed or updated a attribute??? johan
On 8/19/06, Igor Vaynberg [EMAIL PROTECTED] wrote: we load the attrs into a copy-on-write map - we need to reset the map when
the markup is reloaded i guess, right johan?-Igor On 8/19/06, Matej Knopp
[EMAIL PROTECTED] wrote: I didn't add any attribute modifier. input style=abc/ new TextField(...
then I changed markup to input style=xyz the markup reloaded but until I created new instance of page (and thus
new instance of the TextField), the rendered style was abc. -Matej Juergen Donnerstag wrote:Sorry, I don't understand it. Can you be a bit more explicit
input style=xxx TextField field = new field.add(new AttributeModifier(style, ...)or are you talking about
Component.setStyle()? Juergen On 8/19/06, Matej Knopp
[EMAIL PROTECTED] wrote:My current use case is that I have an input with a style attribute
(attached to a TextField). When I change the content of the styleattribute, markup is reloaded but new style is not displayed, becauseTextField remembers old attribute.
Why is that? Shouldn't it only remember the attributes after I change itin code (using getMarkupAttributes)?
-Matej Juergen Donnerstag wrote:
What is the use case for changing Component attributes due to theassociate Markup being re-loaded? Which component attributes should bereset? To which value? In V2 you may call
MarkupCache.addAfterLoadListener() to register a listener though notinvented for this purpose. Juergen
On 8/19/06, Matej Knopp [EMAIL PROTECTED] wrote:
Is this a feature or a bug?
-Matej -Using Tomcat but need to do more? Need to support web services,
security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1
based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-Using Tomcat but need to do more? Need to support web services,
security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-Using Tomcat but need to do more? Need to support web services,
security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache
Geronimohttp://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642
___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job
easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop
Re: [Wicket-develop] urlfor funcs
+10On 8/18/06, Juergen Donnerstag [EMAIL PROTECTED] wrote: +1JuergenOn 8/18/06, Eelco Hillenius [EMAIL PROTECTED] wrote: Component's urlFor methods are only convenience and they are a left over from when we didn't have IRequestCycle I think. I'd be +1 for cleaning that up for 2.0. Eelco On 8/17/06, Igor Vaynberg [EMAIL PROTECTED] wrote: is there any reason why urlfor calls are not synchronized between requestcycle and component? i know component had some urlfor that were conviniences and basically passed in this for some params - but what about requestcycle.urlfor(page) - should that not also be in component? i think it was a mistake to start with to pollute component with urlfor - its too late to do anything now but maybe in 2.0 we can get rid of them? there is nothing wrong with getRequestCycle().urlFor() syntax imho -Igor- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop-Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] AJAX requests and session expired
matej means i guess set a request header (the one like: accept-encoding, or what kind of browser you are) with a ajax requestread that header out on the server and you know that it is a ajax request..johan On 8/14/06, Frank Bille [EMAIL PROTECTED] wrote: On 8/14/06, Matej Knopp [EMAIL PROTECTED] wrote: Another parameter? Do we really need it? Isn't this something that canbe put into request header? (either on client or server side).Not sure what you mean by request header? What I don't think we should have is something that is placed in memory on the server and stays there even if the session is expired. - Frank -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] AJAX requests and session expired
to have one general always working thing for different ajax impl? (just make sure you set the header?)johanOn 8/14/06, Igor Vaynberg [EMAIL PROTECTED] wrote:i get why it helps with the session expired page, i am just wondering why the stuff for setresponsepage() being changed? -IgorOn 8/14/06, Matej Knopp [EMAIL PROTECTED] wrote: Yes, but it doesn't work for expired pages. Or other error (i'm not sure here). The solution with headers would be much more general (and perhapsalso simpler).Each ajax request would set a wicket:ajax header.If request cycle detects this headers, setResponsePage would automatically turn redirect on and sendRedirect of WebResponse would setwicket-ajax-location instead of location header.The _javascript_ then detects presence of wicket-ajax-location a setswindow.location if the header is there. Thoughts?-MatejIgor Vaynberg wrote: i thought we already took care of (1) and (3) with the IRequestTargetInterceptor. if you are inside an ajax request and call setresponsepage() then the window.location _javascript_ is generated for you. how is this better? -Igor On 8/14/06, *Frank Bille* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: We just talked about it on IRC and we will try to do it like this: 1. All redirects should be handled different if it's ajax (send ajax-location instead of location). This has nothing to do with the expired session problem, but has to do with how to redirect to a different page, when using ajax. Instead of doing appendJavascript(window.location = URL) we change the requestcycle to add ajax-location instead of location when doing the header redirect. 2. Add an ajax indicator to all ajax requests. This is done in the _javascript_ so the server knows it's ajax even if all session related objects is gone.3. Whenever setresponsepage is called in an ajax request, we call setRedirect(true), so we force the ajax-location header. I think this could work out just fine. - Frank On 8/14/06, *Frank Bille* [EMAIL PROTECTED] mailto: [EMAIL PROTECTED] wrote: Ok, can _javascript_ do that? That would be just as good. - Frank On 8/14/06, * Johan Compagner* [EMAIL PROTECTED] mailto: [EMAIL PROTECTED] wrote: matej means i guess set a request header (the one like: accept-encoding, or what kind of browser you are) with a ajax request read that header out on the server and you know that it is a ajax request.. johan On 8/14/06, *Frank Bille* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: On 8/14/06, *Matej Knopp* [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Another parameter? Do we really need it? Isn't this something that can be put into request header? (either on client or server side). Not sure what you mean by request header? What I don't think we should have is something that is placed in memory on the server and stays there even if the session is expired. - Frank - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net mailto:Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net mailto: Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop https://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642 ___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net mailto: Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [7] url on error pointing to offending page instead of error page [WAS VOTE 1.3.0 roadmap]
Ok i have implemented igors patch and sorted out the problem by resetting the response (if the response can handle that)It should work fine now in the situations i can think of:1 no redirect (one_pass_render or bookmarkable request), buffered response: the buffer is reset (build up string and redirect url) 2 redirect_to_buffer: the redirect buffer is another buffer by itself, so the reset even doesn't have any effect. 3 normal_redirect strategy: this is in the end the same effect as 1The only thing that will not work if the response is not a buffered response and it is a 1. (the redirect_to_buffer wil still work) Because i can't reset it. But now i think about it. The previous behaviour didn't work at all.Because then we had already written to the servlet output writer. And then a redirect to an ExceptionPAge would happen But this can't be done, because the response is already committed. So the exception page would generate again an exception.So i guess just writting the error output directly after the partial page is even the best solution. So i want to commit this for 1.2.2 also because it seems to be fixing even a potential problem.johanOn 8/13/06, Johan Compagner [EMAIL PROTECTED] wrote: On 8/13/06, Igor Vaynberg [EMAIL PROTECTED] wrote: On 8/13/06, Johan Compagner [EMAIL PROTECTED] wrote: Buf if we are in a bookmarkable request (or another render strategy) which is rendered immediantly then we have 2 ways i gues:1 buffered output: We have to reset the buffered output somehow completely.. (maybe the DefaultExceptionResponseStrategy should just set a new buffer) you mean set a new buffered response object?yes, or reset the current one.Can you try your current code? Just hit a bookmarkable url (so there is no redirect) and in the rendering process (onComponentTag of some component) throw an exception. What is then the output currently?johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] AJAX requests and session expired
frank??what is this?_javascript_??johanOn 8/14/06, Frank Bille [EMAIL PROTECTED] wrote: I'm trying it out and it seems to work just fine. As soon as I have something, I'll create a patch. Matej, if you're reading this, I have figured out how to append headers to the xmlhttprequest. It's really easy as you said :) -FrankOn 8/14/06, Igor Vaynberg [EMAIL PROTECTED] wrote: ah, now we are getting somewhere - so there is no automagic way to make it work like its been suggested. ok sounds good, go for it but please do clean up the bits and pieces we no longer need. -Igor On 8/14/06, Frank Bille [EMAIL PROTECTED] wrote: On 8/14/06, Igor Vaynberg [EMAIL PROTECTED] wrote: i really dont get it. i do an ajax call using lets say prototype - i expect some html back. i add the wicket:ajax header so wicket knows its an ajax request. now while im processing i call setresponsepage(page) - how is that going to redirect to the page? the prototype's ajax handler is expecting some html back...what is it going to get? A response with ajax-location: URL in the header instead of Location: URL. You need to wrap prototype to be able to handle it of course. - Frank -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [7] url on error pointing to offending page instead of error page [WAS VOTE 1.3.0 roadmap]
What happens if we are already in the response fase?And the previous page is already rendered for 50% ?For a redirect to buffer strategy it goes ok when we are in the WebRequestCycle.redirectTo() methodBecause then that page was rendered in a separate buffer which was completely discarded. Buf if we are in a bookmarkable request (or another render strategy) which is rendered immediantly then we have 2 ways i gues:1 buffered output: We have to reset the buffered output somehow completely.. (maybe the DefaultExceptionResponseStrategy should just set a new buffer) 2 not buffered output: I think we are out of luck.. but i guess this is also now the case.I think we just need to build some test cases for buffered/none buffered and different redirect strategies if a page in the middle of its rendering throws an error.johanOn 8/13/06, Igor Vaynberg [EMAIL PROTECTED] wrote:im attaching a patch that implements [7]. there are no api breaks but the behavior is a bit different when it comes to errors obviously. could you guys please review and test. should we put this into 1.2.2 or save for 1.3? -Igor -Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] DefaultExceptionResponseStrategy
i was also just looking at that code. (because i did see in your patch that you thrown away that piece)But that code really looks stupidIn the end it is the same thing.. because the getPageFactory is final on page.
So no loss that i can see.johanOn 8/13/06, Igor Vaynberg [EMAIL PROTECTED] wrote:
inside the exception handler we have the following code:// Show internal error page
final IPageFactory pageFactory;IRequestTarget requestTarget = requestCycle.getRequestTarget();if (requestTarget instanceof IPageRequestTarget)
{pageFactory = session.getPageFactory(((IPageRequestTarget)requestTarget).getPage());}else{pageFactory = session.getPageFactory();}is the if/else here really necessary?
public final Session.IPageFactory getPageFactory(final Page page) { if (page != null) { return page.getPageFactory(); } return getPageFactory();
}andpublic final Page.IPageFactory getPageFactory() { return getSession().getPageFactory(); }now since the above methods are final we go back to the
session.getPageFactory() anyways - so it seems to me this is a waste of code. did i miss something?session.getpagefactory(page) - page.getpagefactory() - session.getpagefactory() so just call session.getpagefactory
() in the first place-Igor
-Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___Wicket-develop mailing list
Wicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [7] url on error pointing to offending page instead of error page [WAS VOTE 1.3.0 roadmap]
On 8/13/06, Igor Vaynberg [EMAIL PROTECTED] wrote: On 8/13/06, Johan Compagner [EMAIL PROTECTED] wrote: Buf if we are in a bookmarkable request (or another render strategy) which is rendered immediantly then we have 2 ways i gues:1 buffered output: We have to reset the buffered output somehow completely.. (maybe the DefaultExceptionResponseStrategy should just set a new buffer) you mean set a new buffered response object?yes, or reset the current one.Can you try your current code? Just hit a bookmarkable url (so there is no redirect) and in the rendering process (onComponentTag of some component) throw an exception. What is then the output currently?johan - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] Proposal: IAuthorizationStrategy improvement
so you want to catch the setResponsePage call with the class constructor?A bookmarkable page link is a bit different because that link shouldn't throw an exceptionor redirect to something i think. That one should just base his visibility on the constructor params
And that is done by: boolean isActionAuthorized(Component component, Action action);and then the RENDER action. The only problem is that you can't get the params back out(there is no getParameters() and getPageClass())
But this is pretty solveable by making your own simple BookmarkablePageLinkThe setResponsePage(Class [, PageParams] ) is different there you can't easily come between somethingIf you want to catch if you can construct that page after the redirect. I don't know what the best way would be
currently this is the code:public void respond(RequestCycle requestCycle) { if (pageClass != null) { if (requestCycle.getRedirect()) {IRequestCycleProcessor processor =
requestCycle.getProcessor();String redirectUrl = processor.getRequestCodingStrategy() .encode(requestCycle, this).toString();requestCycle.getResponse().redirect(redirectUrl);
} else {// Let the page render itselfgetPage(requestCycle).renderPage(); } } }so in the if (requestCycle.getRedirect
()) we could call something. So that we fail early... instead of only after the redirect.johanOn 8/12/06, Stefan Arentz
[EMAIL PROTECTED] wrote:On 8/12/06, Johan Compagner
[EMAIL PROTECTED] wrote: public final boolean isInstantiationAuthorized(final Class componentClass) { if (instanceOf(componentClass, MyPagePage.class)) {
Map params = RequestCycle.get().getRequest().getRequestParameters().getParameters(); if(params.get(mykey).equals(cantbethis)) return false; }
return true; } The only thing is that this may not work for mount urls. Because i think that getParameters() don't return encoded params like /param1/valuePlease note that I am not pleading for doing authorization on pages
based on page parameters.I am looking for a simple uniform wicket-provided way to protect pagesthat have page parameters. Specifically for two use-cases:setResponsePage(MyProtectedPage.class, parameters);
andnew BookmarkablePageLink(fooLink, MyProtectedPage.class, parameters);Right now support for that is non existent or only possible with hacksas workarounds. S.-
Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop
-
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___
Wicket-develop mailing list
Wicket-develop@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wicket-develop
Re: [Wicket-develop] [2.0]need add target class to convertToObject method
That is not the idea if a IConverter interface.an implementation of the IConverter interface does now what type it has to do.for example BooleanConverter or IntegerConverter or PhonenumberConverter.the IConverterLocator is there for getting the right converter for a specific class: public IConverter getConverter(Class type);adding a class param only makes it all much more fuzzier what does what.johanOn 8/12/06, Kuisong Tong [EMAIL PROTECTED] wrote: Hi, all:When I create a converter in wicket 2.0, I can't finish my work,because target class is missing in IConverter's convertToObject method.Some generic converters need to know the target class when convert String to class, for example EnumConverter and EntityConverter.When convert String to enum, I don't want write a converter for everyenum, only one is enough if I can't know the target class inconvertToObject method. The EntityConverter is same when I want convert a id to a domain entity (use orm).So, I suggest to add Class targetClass parameter to convertToObjectmethod.Best regards,Kuisong Tong- Using Tomcat but need to do more? Need to support web services, security?Get stuff done quickly with pre-integrated technology to make your job easierDownload IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing listWicket-develop@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/wicket-develop - Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnkkid=120709bid=263057dat=121642___ Wicket-develop mailing list Wicket-develop@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-develop
