Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
i believe in the 1.x branch we always override. -igor On 12/27/06, Caleb Land <[EMAIL PROTECTED]> wrote: I have a project that uses Wicket 1.x, and it's overwriting my hardcoded ids with generated ones if setOutputMarkupId it true. If this is not the intended behavior then I will open a JIRA issue. On 12/18/06, Otan <[EMAIL PROTECTED]> wrote: > It works fine now. Thanks > > > On 19/12/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > > try now > > > > -igor > > > > > > > > > > On 12/18/06, Otan < [EMAIL PROTECTED]> wrote: > > > > > > why do I still get this exception: > > > > > > > > > SEVERE: cannot update component that does not have setOutputMarkupId > property set to true. Component: [MarkupContainer [Component id = title, > page = openknowledge.EditPage, path = 5:editForm:title.RequiredTextField , > isVisible = true, isVersioned = false]] > > > > > > java.lang.IllegalArgumentException: cannot update > component that does not have setOutputMarkupId property set to true. > Component: [MarkupContainer [Component id = title, page = > openknowledge.EditPage, path = 5:editForm:title.RequiredTextField, isVisible > = true, isVersioned = false]] > > > > > > at > wicket.ajax.AjaxRequestTarget.addComponent(AjaxRequestTarget.java > :97) > > > at > openknowledge.EditPage$2.onRevisionSelected(EditPage.java:153) > > > at > openknowledge.RevisionListPanel$SelectActionPanel$1.onClick( RevisionListPanel.java:60) > > > at > wicket.ajax.markup.html.AjaxFallbackLink$1.onEvent > (AjaxFallbackLink.java:79) > > > at > wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:162) > > > at > wicket.ajax.AbstractDefaultAjaxBehavior.onRequest( AbstractDefaultAjaxBehavior.java:224) > > > at > wicket.request.target.component.listener.BehaviorRequestTarget.processEvents (BehaviorRequestTarget.java:98) > > > at > wicket.request.compound.DefaultEventProcessorStrategy.processEvents( DefaultEventProcessorStrategy.java > :68) > > > at > wicket.request.compound.AbstractCompoundRequestCycleProcessor.processEvents (AbstractCompoundRequestCycleProcessor.java:56) > > > at > wicket.RequestCycle.doProcessEventsAndRespond(RequestCycle.java:938) > > > at > wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:978) > > > at wicket.RequestCycle.step(RequestCycle.java:1054) > > > at wicket.RequestCycle.steps(RequestCycle.java:1125) > > > at wicket.RequestCycle.request(RequestCycle.java:470) > > > at > wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:232) > > > at > wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122) > > > > > > I don't get that exception before I updated my copy of Wicket 2.0 > snapshots. > > > > > > > > > > > > On 13/12/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote: > > > > its reverted > > > > > > > > -igor > > > > > > > > > > > > > > > > > > > > On 12/12/06, Martijn Dashorst < [EMAIL PROTECTED]> wrote: > > > > > On 12/12/06, Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > > > > yeah i changed it, didnt think anyone was using this particular > facet. > > > > > > > > > > We use it also. > > > > > > > > > > > im not sure if we should put it back. the problem is sometimes you > can paint > > > > > > yourself into a nasty corner. if you have a component that uses a > hardcoded > > > > > > id, and later the user of that component uses it twice in a page, > or puts it > > > > > > into a repeater you will have duplicate ids in html which is not > legal, and > > > > > > whats worse is it will break ajax/js/css but it will be very hard > to track > > > > > > down. > > > > > > > > > > Most of the time you are in full control of the markup id. In my > > > > > experience it is in a rare occaission that you have to worry about > > > > > reuse. Repeaters, listview are tricky, and for those I typically let > > > > > Wicket generate the markup id using setOutputMarkupId. > > > > > > > > > > So -1 for not honoring existing markup ids. > > > > > > > > > > Martijn > > > > > > > > > > > On 12/11/06, Caleb Land < [EMAIL PROTECTED] > wrote: > > > > > > > I've been using 2.0-SNAPSHOT for a while now and I noticed a > behavior > > > > > > > recently that is new. If I have an HTML id defined in my > markup: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced > with > > > > > > > something that is generated by Wicket like "labels40". > > > > > > > > > > > > > > I looked through the svn changelog for MarkupContainer and > noticed > > > > > > > that the getMarkupId() method has been changed, and the javadoc > for > > > > > > > that method that said: > > > > > > > > > > > > > > "If the id attribute is present in the markup attributes of this > component > > > > > > > it will be used, otherwise the page-relative path of this > component will > > > > > > > be used." > > > > > > > > > > > > > >
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
I have a project that uses Wicket 1.x, and it's overwriting my hardcoded ids with generated ones if setOutputMarkupId it true. If this is not the intended behavior then I will open a JIRA issue. On 12/18/06, Otan <[EMAIL PROTECTED]> wrote: > It works fine now. Thanks > > > On 19/12/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > > > > try now > > > > -igor > > > > > > > > > > On 12/18/06, Otan < [EMAIL PROTECTED]> wrote: > > > > > > why do I still get this exception: > > > > > > > > > SEVERE: cannot update component that does not have setOutputMarkupId > property set to true. Component: [MarkupContainer [Component id = title, > page = openknowledge.EditPage, path = 5:editForm:title.RequiredTextField, > isVisible = true, isVersioned = false]] > > > > > > java.lang.IllegalArgumentException: cannot update > component that does not have setOutputMarkupId property set to true. > Component: [MarkupContainer [Component id = title, page = > openknowledge.EditPage, path = 5:editForm:title.RequiredTextField, isVisible > = true, isVersioned = false]] > > > > > > at > wicket.ajax.AjaxRequestTarget.addComponent(AjaxRequestTarget.java > :97) > > > at > openknowledge.EditPage$2.onRevisionSelected(EditPage.java:153) > > > at > openknowledge.RevisionListPanel$SelectActionPanel$1.onClick(RevisionListPanel.java:60) > > > at > wicket.ajax.markup.html.AjaxFallbackLink$1.onEvent > (AjaxFallbackLink.java:79) > > > at > wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:162) > > > at > wicket.ajax.AbstractDefaultAjaxBehavior.onRequest(AbstractDefaultAjaxBehavior.java:224) > > > at > wicket.request.target.component.listener.BehaviorRequestTarget.processEvents(BehaviorRequestTarget.java:98) > > > at > wicket.request.compound.DefaultEventProcessorStrategy.processEvents(DefaultEventProcessorStrategy.java > :68) > > > at > wicket.request.compound.AbstractCompoundRequestCycleProcessor.processEvents(AbstractCompoundRequestCycleProcessor.java:56) > > > at > wicket.RequestCycle.doProcessEventsAndRespond(RequestCycle.java:938) > > > at > wicket.RequestCycle.processEventsAndRespond(RequestCycle.java:978) > > > at wicket.RequestCycle.step(RequestCycle.java:1054) > > > at wicket.RequestCycle.steps(RequestCycle.java:1125) > > > at wicket.RequestCycle.request(RequestCycle.java:470) > > > at > wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:232) > > > at > wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122) > > > > > > I don't get that exception before I updated my copy of Wicket 2.0 > snapshots. > > > > > > > > > > > > On 13/12/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote: > > > > its reverted > > > > > > > > -igor > > > > > > > > > > > > > > > > > > > > On 12/12/06, Martijn Dashorst < [EMAIL PROTECTED]> wrote: > > > > > On 12/12/06, Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > > > > yeah i changed it, didnt think anyone was using this particular > facet. > > > > > > > > > > We use it also. > > > > > > > > > > > im not sure if we should put it back. the problem is sometimes you > can paint > > > > > > yourself into a nasty corner. if you have a component that uses a > hardcoded > > > > > > id, and later the user of that component uses it twice in a page, > or puts it > > > > > > into a repeater you will have duplicate ids in html which is not > legal, and > > > > > > whats worse is it will break ajax/js/css but it will be very hard > to track > > > > > > down. > > > > > > > > > > Most of the time you are in full control of the markup id. In my > > > > > experience it is in a rare occaission that you have to worry about > > > > > reuse. Repeaters, listview are tricky, and for those I typically let > > > > > Wicket generate the markup id using setOutputMarkupId. > > > > > > > > > > So -1 for not honoring existing markup ids. > > > > > > > > > > Martijn > > > > > > > > > > > On 12/11/06, Caleb Land < [EMAIL PROTECTED] > wrote: > > > > > > > I've been using 2.0-SNAPSHOT for a while now and I noticed a > behavior > > > > > > > recently that is new. If I have an HTML id defined in my > markup: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced > with > > > > > > > something that is generated by Wicket like "labels40". > > > > > > > > > > > > > > I looked through the svn changelog for MarkupContainer and > noticed > > > > > > > that the getMarkupId() method has been changed, and the javadoc > for > > > > > > > that method that said: > > > > > > > > > > > > > > "If the id attribute is present in the markup attributes of this > component > > > > > > > it will be used, otherwise the page-relative path of this > component will > > > > > > > be used." > > > > > > > > > > > > > > has been deleted... > > > > > > > > > > > > > > Should I be able to hard code HTML ids in the future or was that > >
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
It works fine now. Thanks On 19/12/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: try now -igor On 12/18/06, Otan <[EMAIL PROTECTED]> wrote: > why do I still get this exception: > > SEVERE: cannot update component that does not have setOutputMarkupId > property set to true. Component: [MarkupContainer [Component id = title, > page = openknowledge.EditPage, path = 5:editForm:title.RequiredTextField, > isVisible = true, isVersioned = false]] > > java.lang.IllegalArgumentException: cannot update component that does > not have setOutputMarkupId property set to true. Component: [MarkupContainer > [Component id = title, page = openknowledge.EditPage, path = 5:editForm: > title.RequiredTextField, isVisible = true, isVersioned = false]] > at wicket.ajax.AjaxRequestTarget.addComponent( > AjaxRequestTarget.java :97) > at openknowledge.EditPage$2.onRevisionSelected(EditPage.java > :153) > at openknowledge.RevisionListPanel$SelectActionPanel$1.onClick( > RevisionListPanel.java:60) > at wicket.ajax.markup.html.AjaxFallbackLink$1.onEvent ( > AjaxFallbackLink.java:79) > at wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java > :162) > at wicket.ajax.AbstractDefaultAjaxBehavior.onRequest( > AbstractDefaultAjaxBehavior.java:224) > at > wicket.request.target.component.listener.BehaviorRequestTarget.processEvents > (BehaviorRequestTarget.java:98) > at > wicket.request.compound.DefaultEventProcessorStrategy.processEvents( > DefaultEventProcessorStrategy.java :68) > at > wicket.request.compound.AbstractCompoundRequestCycleProcessor.processEvents > (AbstractCompoundRequestCycleProcessor.java:56) > at wicket.RequestCycle.doProcessEventsAndRespond( > RequestCycle.java:938) > at wicket.RequestCycle.processEventsAndRespond(RequestCycle.java > :978) > at wicket.RequestCycle.step(RequestCycle.java:1054) > at wicket.RequestCycle.steps(RequestCycle.java:1125) > at wicket.RequestCycle.request(RequestCycle.java:470) > at wicket.protocol.http.WicketFilter.doGet(WicketFilter.java > :232) > at wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java > :122) > > I don't get that exception before I updated my copy of Wicket 2.0snapshots. > > On 13/12/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote: > > > > its reverted > > > > -igor > > > > > > On 12/12/06, Martijn Dashorst < [EMAIL PROTECTED]> wrote: > > > > > > On 12/12/06, Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > > yeah i changed it, didnt think anyone was using this particular > > > facet. > > > > > > We use it also. > > > > > > > im not sure if we should put it back. the problem is sometimes you > > > can paint > > > > yourself into a nasty corner. if you have a component that uses a > > > hardcoded > > > > id, and later the user of that component uses it twice in a page, > > > or puts it > > > > into a repeater you will have duplicate ids in html which is not > > > legal, and > > > > whats worse is it will break ajax/js/css but it will be very hard > > > to track > > > > down. > > > > > > Most of the time you are in full control of the markup id. In my > > > experience it is in a rare occaission that you have to worry about > > > reuse. Repeaters, listview are tricky, and for those I typically let > > > > > > Wicket generate the markup id using setOutputMarkupId. > > > > > > So -1 for not honoring existing markup ids. > > > > > > Martijn > > > > > > > On 12/11/06, Caleb Land < [EMAIL PROTECTED] > wrote: > > > > > I've been using 2.0-SNAPSHOT for a while now and I noticed a > > > behavior > > > > > recently that is new. If I have an HTML id defined in my > > > markup: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced > > > with > > > > > something that is generated by Wicket like "labels40". > > > > > > > > > > I looked through the svn changelog for MarkupContainer and > > > noticed > > > > > that the getMarkupId() method has been changed, and the javadoc > > > for > > > > > that method that said: > > > > > > > > > > "If the id attribute is present in the markup attributes of this > > > component > > > > > it will be used, otherwise the page-relative path of this > > > component will > > > > > be used." > > > > > > > > > > has been deleted... > > > > > > > > > > Should I be able to hard code HTML ids in the future or was that > > > > > "feature" removed? I used hard coded HTML ids in my Page markup > > > files > > > > > I sometimes use HTML ids to reference elements from CSS and > > > javascript > > > > > and I had to use a class instead because of these generated Ids. > > > > > > > > > > -- > > > > > Caleb Land > > > > > ( [EMAIL PROTECTED]) > > > > > > > > > > > > > > > > > - > > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > > Join SourceForge.net's Techsay panel and you
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
try now -igor On 12/18/06, Otan <[EMAIL PROTECTED]> wrote: why do I still get this exception: SEVERE: cannot update component that does not have setOutputMarkupId property set to true. Component: [MarkupContainer [Component id = title, page = openknowledge.EditPage, path = 5:editForm:title.RequiredTextField, isVisible = true, isVersioned = false]] java.lang.IllegalArgumentException: cannot update component that does not have setOutputMarkupId property set to true. Component: [MarkupContainer [Component id = title, page = openknowledge.EditPage, path = 5:editForm: title.RequiredTextField, isVisible = true, isVersioned = false]] at wicket.ajax.AjaxRequestTarget.addComponent( AjaxRequestTarget.java :97) at openknowledge.EditPage$2.onRevisionSelected(EditPage.java:153) at openknowledge.RevisionListPanel$SelectActionPanel$1.onClick( RevisionListPanel.java:60) at wicket.ajax.markup.html.AjaxFallbackLink$1.onEvent ( AjaxFallbackLink.java:79) at wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java :162) at wicket.ajax.AbstractDefaultAjaxBehavior.onRequest( AbstractDefaultAjaxBehavior.java:224) at wicket.request.target.component.listener.BehaviorRequestTarget.processEvents (BehaviorRequestTarget.java:98) at wicket.request.compound.DefaultEventProcessorStrategy.processEvents( DefaultEventProcessorStrategy.java :68) at wicket.request.compound.AbstractCompoundRequestCycleProcessor.processEvents (AbstractCompoundRequestCycleProcessor.java:56) at wicket.RequestCycle.doProcessEventsAndRespond(RequestCycle.java:938) at wicket.RequestCycle.processEventsAndRespond(RequestCycle.java :978) at wicket.RequestCycle.step(RequestCycle.java:1054) at wicket.RequestCycle.steps(RequestCycle.java:1125) at wicket.RequestCycle.request(RequestCycle.java:470) at wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:232) at wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java :122) I don't get that exception before I updated my copy of Wicket 2.0snapshots. On 13/12/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote: > > its reverted > > -igor > > > On 12/12/06, Martijn Dashorst < [EMAIL PROTECTED]> wrote: > > > > On 12/12/06, Igor Vaynberg < [EMAIL PROTECTED] > wrote: > > > yeah i changed it, didnt think anyone was using this particular > > facet. > > > > We use it also. > > > > > im not sure if we should put it back. the problem is sometimes you > > can paint > > > yourself into a nasty corner. if you have a component that uses a > > hardcoded > > > id, and later the user of that component uses it twice in a page, or > > puts it > > > into a repeater you will have duplicate ids in html which is not > > legal, and > > > whats worse is it will break ajax/js/css but it will be very hard to > > track > > > down. > > > > Most of the time you are in full control of the markup id. In my > > experience it is in a rare occaission that you have to worry about > > reuse. Repeaters, listview are tricky, and for those I typically let > > Wicket generate the markup id using setOutputMarkupId. > > > > So -1 for not honoring existing markup ids. > > > > Martijn > > > > > On 12/11/06, Caleb Land < [EMAIL PROTECTED] > wrote: > > > > I've been using 2.0-SNAPSHOT for a while now and I noticed a > > behavior > > > > recently that is new. If I have an HTML id defined in my markup: > > > > > > > > > > > > > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced with > > > > something that is generated by Wicket like "labels40". > > > > > > > > I looked through the svn changelog for MarkupContainer and noticed > > > > that the getMarkupId() method has been changed, and the javadoc > > for > > > > that method that said: > > > > > > > > "If the id attribute is present in the markup attributes of this > > component > > > > it will be used, otherwise the page-relative path of this > > component will > > > > be used." > > > > > > > > has been deleted... > > > > > > > > Should I be able to hard code HTML ids in the future or was that > > > > "feature" removed? I used hard coded HTML ids in my Page markup > > files > > > > I sometimes use HTML ids to reference elements from CSS and > > javascript > > > > and I had to use a class instead because of these generated Ids. > > > > > > > > -- > > > > Caleb Land > > > > ( [EMAIL PROTECTED]) > > > > > > > > > > > > > - > > > > Take Surveys. Earn Cash. Influence the Future of IT > > > > Join SourceForge.net's Techsay panel and you'll get the chance to > > share > > > your > > > > opinions on IT & business topics through brief surveys - and earn > > cash > > > > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > > ___ > > > > Wicket-user mailing list > > > > Wicket-user@lists.sourceforge.net >
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
why do I still get this exception: SEVERE: cannot update component that does not have setOutputMarkupId property set to true. Component: [MarkupContainer [Component id = title, page = openknowledge.EditPage, path = 5:editForm:title.RequiredTextField, isVisible = true, isVersioned = false]] java.lang.IllegalArgumentException: cannot update component that does not have setOutputMarkupId property set to true. Component: [MarkupContainer [Component id = title, page = openknowledge.EditPage, path = 5:editForm: title.RequiredTextField, isVisible = true, isVersioned = false]] at wicket.ajax.AjaxRequestTarget.addComponent(AjaxRequestTarget.java :97) at openknowledge.EditPage$2.onRevisionSelected(EditPage.java:153) at openknowledge.RevisionListPanel$SelectActionPanel$1.onClick( RevisionListPanel.java:60) at wicket.ajax.markup.html.AjaxFallbackLink$1.onEvent( AjaxFallbackLink.java:79) at wicket.ajax.AjaxEventBehavior.respond(AjaxEventBehavior.java:162) at wicket.ajax.AbstractDefaultAjaxBehavior.onRequest( AbstractDefaultAjaxBehavior.java:224) at wicket.request.target.component.listener.BehaviorRequestTarget.processEvents (BehaviorRequestTarget.java:98) at wicket.request.compound.DefaultEventProcessorStrategy.processEvents( DefaultEventProcessorStrategy.java:68) at wicket.request.compound.AbstractCompoundRequestCycleProcessor.processEvents( AbstractCompoundRequestCycleProcessor.java:56) at wicket.RequestCycle.doProcessEventsAndRespond(RequestCycle.java :938) at wicket.RequestCycle.processEventsAndRespond(RequestCycle.java :978) at wicket.RequestCycle.step(RequestCycle.java:1054) at wicket.RequestCycle.steps(RequestCycle.java:1125) at wicket.RequestCycle.request(RequestCycle.java:470) at wicket.protocol.http.WicketFilter.doGet(WicketFilter.java:232) at wicket.protocol.http.WicketFilter.doFilter(WicketFilter.java:122) I don't get that exception before I updated my copy of Wicket 2.0 snapshots. On 13/12/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: its reverted -igor On 12/12/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: > > On 12/12/06, Igor Vaynberg <[EMAIL PROTECTED] > wrote: > > yeah i changed it, didnt think anyone was using this particular facet. > > We use it also. > > > im not sure if we should put it back. the problem is sometimes you can > paint > > yourself into a nasty corner. if you have a component that uses a > hardcoded > > id, and later the user of that component uses it twice in a page, or > puts it > > into a repeater you will have duplicate ids in html which is not > legal, and > > whats worse is it will break ajax/js/css but it will be very hard to > track > > down. > > Most of the time you are in full control of the markup id. In my > experience it is in a rare occaission that you have to worry about > reuse. Repeaters, listview are tricky, and for those I typically let > Wicket generate the markup id using setOutputMarkupId. > > So -1 for not honoring existing markup ids. > > Martijn > > > On 12/11/06, Caleb Land <[EMAIL PROTECTED] > wrote: > > > I've been using 2.0-SNAPSHOT for a while now and I noticed a > behavior > > > recently that is new. If I have an HTML id defined in my markup: > > > > > > > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced with > > > something that is generated by Wicket like "labels40". > > > > > > I looked through the svn changelog for MarkupContainer and noticed > > > that the getMarkupId() method has been changed, and the javadoc for > > > that method that said: > > > > > > "If the id attribute is present in the markup attributes of this > component > > > it will be used, otherwise the page-relative path of this component > will > > > be used." > > > > > > has been deleted... > > > > > > Should I be able to hard code HTML ids in the future or was that > > > "feature" removed? I used hard coded HTML ids in my Page markup > files > > > I sometimes use HTML ids to reference elements from CSS and > javascript > > > and I had to use a class instead because of these generated Ids. > > > > > > -- > > > Caleb Land > > > ( [EMAIL PROTECTED]) > > > > > > > > > - > > > Take Surveys. Earn Cash. Influence the Future of IT > > > Join SourceForge.net's Techsay panel and you'll get the chance to > share > > your > > > opinions on IT & business topics through brief surveys - and earn > cash > > > > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > > ___ > > > Wicket-user mailing list > > > Wicket-user@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > > > > > > - > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and yo
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
its reverted -igor On 12/12/06, Martijn Dashorst <[EMAIL PROTECTED]> wrote: On 12/12/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > yeah i changed it, didnt think anyone was using this particular facet. We use it also. > im not sure if we should put it back. the problem is sometimes you can paint > yourself into a nasty corner. if you have a component that uses a hardcoded > id, and later the user of that component uses it twice in a page, or puts it > into a repeater you will have duplicate ids in html which is not legal, and > whats worse is it will break ajax/js/css but it will be very hard to track > down. Most of the time you are in full control of the markup id. In my experience it is in a rare occaission that you have to worry about reuse. Repeaters, listview are tricky, and for those I typically let Wicket generate the markup id using setOutputMarkupId. So -1 for not honoring existing markup ids. Martijn > On 12/11/06, Caleb Land <[EMAIL PROTECTED]> wrote: > > I've been using 2.0-SNAPSHOT for a while now and I noticed a behavior > > recently that is new. If I have an HTML id defined in my markup: > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced with > > something that is generated by Wicket like "labels40". > > > > I looked through the svn changelog for MarkupContainer and noticed > > that the getMarkupId() method has been changed, and the javadoc for > > that method that said: > > > > "If the id attribute is present in the markup attributes of this component > > it will be used, otherwise the page-relative path of this component will > > be used." > > > > has been deleted... > > > > Should I be able to hard code HTML ids in the future or was that > > "feature" removed? I used hard coded HTML ids in my Page markup files > > I sometimes use HTML ids to reference elements from CSS and javascript > > and I had to use a class instead because of these generated Ids. > > > > -- > > Caleb Land > > ([EMAIL PROTECTED]) > > > > > - > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > > opinions on IT & business topics through brief surveys - and earn cash > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > ___ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > ___ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.3 is as easy as 1-2-3. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
On 12/12/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > yeah i changed it, didnt think anyone was using this particular facet. We use it also. > im not sure if we should put it back. the problem is sometimes you can paint > yourself into a nasty corner. if you have a component that uses a hardcoded > id, and later the user of that component uses it twice in a page, or puts it > into a repeater you will have duplicate ids in html which is not legal, and > whats worse is it will break ajax/js/css but it will be very hard to track > down. Most of the time you are in full control of the markup id. In my experience it is in a rare occaission that you have to worry about reuse. Repeaters, listview are tricky, and for those I typically let Wicket generate the markup id using setOutputMarkupId. So -1 for not honoring existing markup ids. Martijn > On 12/11/06, Caleb Land <[EMAIL PROTECTED]> wrote: > > I've been using 2.0-SNAPSHOT for a while now and I noticed a behavior > > recently that is new. If I have an HTML id defined in my markup: > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced with > > something that is generated by Wicket like "labels40". > > > > I looked through the svn changelog for MarkupContainer and noticed > > that the getMarkupId() method has been changed, and the javadoc for > > that method that said: > > > > "If the id attribute is present in the markup attributes of this component > > it will be used, otherwise the page-relative path of this component will > > be used." > > > > has been deleted... > > > > Should I be able to hard code HTML ids in the future or was that > > "feature" removed? I used hard coded HTML ids in my Page markup files > > I sometimes use HTML ids to reference elements from CSS and javascript > > and I had to use a class instead because of these generated Ids. > > > > -- > > Caleb Land > > ([EMAIL PROTECTED]) > > > > > - > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > > opinions on IT & business topics through brief surveys - and earn cash > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > ___ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > ___ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > -- Vote for Wicket at the http://www.thebeststuffintheworld.com/vote_for/wicket Wicket 1.2.3 is as easy as 1-2-3. Download Wicket now! http://wicketframework.org - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
Hi Igor, I also have a few hardcoded ids in my current Wicket 1.2 application. Regards, Erik. Igor Vaynberg schreef: > yeah i changed it, didnt think anyone was using this particular facet. > > im not sure if we should put it back. the problem is sometimes you can > paint yourself into a nasty corner. if you have a component that uses > a hardcoded id, and later the user of that component uses it twice in > a page, or puts it into a repeater you will have duplicate ids in html > which is not legal, and whats worse is it will break ajax/js/css but > it will be very hard to track down. > > thoughts? > > -igor > -- Erik van Oosten http://www.day-to-day-stuff.blogspot.com/ - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
Imo, quite strongly this time, if it is explicitly set, it should be honored. As for the dangers of having conflicting ids, we could introduce another debug utility that checks on duplicate ids when (or after) rendering. Eelco On 12/11/06, Igor Vaynberg <[EMAIL PROTECTED]> wrote: > yeah i changed it, didnt think anyone was using this particular facet. > > im not sure if we should put it back. the problem is sometimes you can paint > yourself into a nasty corner. if you have a component that uses a hardcoded > id, and later the user of that component uses it twice in a page, or puts it > into a repeater you will have duplicate ids in html which is not legal, and > whats worse is it will break ajax/js/css but it will be very hard to track > down. > > thoughts? > > -igor > > > On 12/11/06, Caleb Land <[EMAIL PROTECTED]> wrote: > > I've been using 2.0-SNAPSHOT for a while now and I noticed a behavior > > recently that is new. If I have an HTML id defined in my markup: > > > > > > > > > > > > When the panel is rendered the HTML id attribute is replaced with > > something that is generated by Wicket like "labels40". > > > > I looked through the svn changelog for MarkupContainer and noticed > > that the getMarkupId() method has been changed, and the javadoc for > > that method that said: > > > > "If the id attribute is present in the markup attributes of this component > > it will be used, otherwise the page-relative path of this component will > > be used." > > > > has been deleted... > > > > Should I be able to hard code HTML ids in the future or was that > > "feature" removed? I used hard coded HTML ids in my Page markup files > > I sometimes use HTML ids to reference elements from CSS and javascript > > and I had to use a class instead because of these generated Ids. > > > > -- > > Caleb Land > > ([EMAIL PROTECTED]) > > > > > - > > Take Surveys. Earn Cash. Influence the Future of IT > > Join SourceForge.net's Techsay panel and you'll get the chance to share > your > > opinions on IT & business topics through brief surveys - and earn cash > > > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > ___ > > Wicket-user mailing list > > Wicket-user@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > > > - > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > > ___ > Wicket-user mailing list > Wicket-user@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wicket-user > > > - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
Re: [Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
yeah i changed it, didnt think anyone was using this particular facet. im not sure if we should put it back. the problem is sometimes you can paint yourself into a nasty corner. if you have a component that uses a hardcoded id, and later the user of that component uses it twice in a page, or puts it into a repeater you will have duplicate ids in html which is not legal, and whats worse is it will break ajax/js/css but it will be very hard to track down. thoughts? -igor On 12/11/06, Caleb Land <[EMAIL PROTECTED]> wrote: I've been using 2.0-SNAPSHOT for a while now and I noticed a behavior recently that is new. If I have an HTML id defined in my markup: When the panel is rendered the HTML id attribute is replaced with something that is generated by Wicket like "labels40". I looked through the svn changelog for MarkupContainer and noticed that the getMarkupId() method has been changed, and the javadoc for that method that said: "If the id attribute is present in the markup attributes of this component it will be used, otherwise the page-relative path of this component will be used." has been deleted... Should I be able to hard code HTML ids in the future or was that "feature" removed? I used hard coded HTML ids in my Page markup files I sometimes use HTML ids to reference elements from CSS and javascript and I had to use a class instead because of these generated Ids. -- Caleb Land ([EMAIL PROTECTED]) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
[Wicket-user] HTML ids in 2.0-SNAPHOT are being generated even when hardcoded
I've been using 2.0-SNAPSHOT for a while now and I noticed a behavior recently that is new. If I have an HTML id defined in my markup: When the panel is rendered the HTML id attribute is replaced with something that is generated by Wicket like "labels40". I looked through the svn changelog for MarkupContainer and noticed that the getMarkupId() method has been changed, and the javadoc for that method that said: "If the id attribute is present in the markup attributes of this component it will be used, otherwise the page-relative path of this component will be used." has been deleted... Should I be able to hard code HTML ids in the future or was that "feature" removed? I used hard coded HTML ids in my Page markup files I sometimes use HTML ids to reference elements from CSS and javascript and I had to use a class instead because of these generated Ids. -- Caleb Land ([EMAIL PROTECTED]) - Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ___ Wicket-user mailing list Wicket-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wicket-user
