[Wikidata-bugs] [Maniphest] T363721: Show "small logo or icon" as fallback image in search
thiemowmde edited projects, added Desktop Improvements (Vector 2022), Discovery-Search; removed Advanced-Search. thiemowmde added a comment. This appears to be exclusive to the new Vector 2022 skin. Which surprises me very much. What's the reason to make such a basic feature behave different in one skin? Will this be resolved via T125725 <https://phabricator.wikimedia.org/T125725>? Which team is responsible for this? TASK DETAIL https://phabricator.wikimedia.org/T363721 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, ChristianKl, Danny_Benjafield_WMDE, JCW555, S8321414, hnijhuis, Astuthiodit_1, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Dringsim, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, KimKelting, LawExplorer, Iniquity, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T363721: Show "small logo or icon" as fallback image in search
thiemowmde added a comment. I honestly can't tell what this refers to. There are no icons anywhere: Not on Special:Search, not in #advanced-search <https://phabricator.wikimedia.org/tag/advanced-search/>, not in the #MediaWiki-User-Interface <https://phabricator.wikimedia.org/tag/mediawiki-user-interface/>. What kind of "search" is this about? F53155059: Screenshot from 2024-05-14 09-23-47.png <https://phabricator.wikimedia.org/F53155059> TASK DETAIL https://phabricator.wikimedia.org/T363721 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, ChristianKl, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, Dringsim, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0
thiemowmde added a project: Advanced-Search. thiemowmde added a comment. #advanced-search <https://phabricator.wikimedia.org/tag/advanced-search/> is the only #wmde-techwish <https://phabricator.wikimedia.org/tag/wmde-techwish/> product that contains client-side `mw.hook` hooks. These have always been documented as public and stable. We also added `@stable` tags to the code now, see https://gerrit.wikimedia.org/r/1021410. We consider this done. TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: WMDE-Fisch, Jdforrester-WMF, WMDE-leszek, ItamarWMDE, thiemowmde, Aklapper, Jdlrobson, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Dringsim, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362660: WikidataPageBanner doesn't seem to use wpb_banner wpb_banner_focus_x or wpb_banner_focus_y page properties
thiemowmde added a comment. There is a single place in the code <https://phabricator.wikimedia.org/diffusion/EWDP/browse/master/resources/ext.WikidataPageBanner.positionBanner/ext.WikidataPageBanner.positionBanner.js$48> that uses the data-pos-x and data-pos-y attributes from the DOM. I assume this is what we see in action. The page properties appear to be unrelated to that. TASK DETAIL https://phabricator.wikimedia.org/T362660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: cscott, thiemowmde Cc: thiemowmde, Tgr, Jdlrobson, cscott, Aklapper, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Nishu02, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, ovasileva, Winter, Lewizho99, Maathavan, Neuronton, Wikidata-bugs, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI
thiemowmde added a project: WMDE-TechWish-Sprint-2024-04-12. thiemowmde claimed this task. thiemowmde closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T362505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: hoo, Lucas_Werkmeister_WMDE, Lydia_Pintscher, thiemowmde, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Shliilh65, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, WMDE-Fisch, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI
thiemowmde lowered the priority of this task from "Unbreak Now!" to "Needs Triage". thiemowmde added a comment. Thanks a lot for looking into this! So far it really looks like some state makes it from one test to the next – but where exactly this happens we don't know, or do we? The linked patches are attempts to make some of the involved test setups more robust. TASK DETAIL https://phabricator.wikimedia.org/T362505 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: hoo, Lucas_Werkmeister_WMDE, Lydia_Pintscher, thiemowmde, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, S8321414, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Shliilh65, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Taiwania_Justo, Neuronton, Scott_WUaS, Wikidata-bugs, WMDE-Fisch, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362660: WikidataPageBanner doesn't seem to use wpb_banner wpb_banner_focus_x or wpb_banner_focus_y page properties
thiemowmde added a comment. I found T114424#7554051 <https://phabricator.wikimedia.org/T114424#7554051>. It makes it sound like this was indeed never used. TASK DETAIL https://phabricator.wikimedia.org/T362660 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: cscott, thiemowmde Cc: thiemowmde, Tgr, Jdlrobson, cscott, Aklapper, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786, Biggs657, Juan90264, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, Maathavan, Neuronton, Wikidata-bugs, Lydia_Pintscher ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI
thiemowmde triaged this task as "Unbreak Now!" priority.
thiemowmde added subscribers: Lydia_Pintscher, Lucas_Werkmeister_WMDE, hoo.
thiemowmde added a comment.
`{{WBREPONAME}}` is a custom magic word that comes with Wikibase. The test
results make it look like it just stopped working. I have no idea why.
Especially why only a few WikibaseClient tests fail.
I know this is not really an unbreak now as it's apparently (at least I hope)
not about production but "only" tests. Unfortunately issues like this are
seemingly becoming the norm recently in my working area (T362383
<https://phabricator.wikimedia.org/T362383> was just 1 workday ago), which is
getting exhausting.
TASK DETAIL
https://phabricator.wikimedia.org/T362505
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: hoo, Lucas_Werkmeister_WMDE, Lydia_Pintscher, thiemowmde,
Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot,
maantietaja, ItamarWMDE, Akuckartz, Shliilh65, Nandana, lucamauri, Lahi, Gq86,
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89, _jensen,
rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, WMDE-Fisch, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T362505: Failing Wikibase InfoAction tests block CI
thiemowmde created this task.
thiemowmde added projects: Wikidata, MediaWiki-extensions-WikibaseClient,
Move-Files-To-Commons.
TASK DESCRIPTION
I really have no idea what's going on. Neither the failing
InfoActionHookHandlerTest nor anything related to core's InfoAction was touched
the past months and years.
Example for a blocked patch: https://gerrit.wikimedia.org/r/1017918
Console output:
https://integration.wikimedia.org/ci/job/wmf-quibble-vendor-mysql-php81/133/console
08:40:13 4)
Wikibase\Client\Tests\Unit\Hooks\InfoActionHookHandlerTest::testOnInfoAction
with data set #0 (array(array(array('TestWiki item ID', 'https://www.wikidata...Q4')), array(array('TestWiki entities used in
this page', 'https://www>'))),
MediaWiki\Context\RequestContext Object (...), array(array()), true,
Wikibase\DataModel\Entity\ItemId Object (...), null, null, 'item id link')
08:40:13 item id link
08:40:13 Failed asserting that two arrays are equal.
08:40:13 --- Expected
08:40:13 +++ Actual
08:40:13 @@ @@
08:40:13 Array (
08:40:13 'header-basic' => Array (
08:40:13 0 => Array (
08:40:13 -0 => 'TestWiki item ID'
08:40:13 +0 => '{{WBREPONAME}} item ID'
08:40:13 1 => 'https://www.wikidata...Q4'
08:40:13 )
08:40:13 )
08:40:13 'header-properties' => Array (
08:40:13 0 => Array (
08:40:13 -0 => 'TestWiki entities used in this page'
08:40:13 +0 => '{{WBREPONAME}} entities used in this page'
08:40:13 1 => 'https://www>'
08:40:13 )
08:40:13 )
08:40:13 )
TASK DETAIL
https://phabricator.wikimedia.org/T362505
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: thiemowmde, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE,
Invadibot, maantietaja, ItamarWMDE, Akuckartz, Shliilh65, Nandana, lucamauri,
Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, JJMC89,
_jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Wikidata-bugs, WMDE-Fisch,
aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348079: WMDE: Review stable code (hooks, mw object, undocumented) and mark (un)stable interfaces before 1.42.0
thiemowmde added a subscriber: WMDE-Fisch. thiemowmde added a comment. I still try to understand what needs to be done here? I can see that mw:Stable interface policy/Frontend <https://www.mediawiki.org/wiki/Stable_interface_policy/Frontend> talks about hooks, and a few WMDE products happen to contain `mw.hook` calls. However, … - Does mw:Stable interface policy/Frontend <https://www.mediawiki.org/wiki/Stable_interface_policy/Frontend> even apply to extensions the same way it applies to core? I mean, aren't extensions the //consumers// of the stable interfaces MediaWiki core provides? Most policy documents phrase it this way. mw:Development policy <https://www.mediawiki.org/wiki/Development_policy> for example explicitly says //"changes to MediaWiki core […] must follow the Stable interface policy."// While I understand that some central extensions effectively behave as if they are part of "the core experience on the Wikimedia cluster", I don't think that applies to everything. - It feels like it makes a lot of sense to consider all code in an extension unstable by default, unless otherwise noted. In case this is not backed by the current documents, what's the best way to state that in the documentation of the extension? Is a sentence in the top-level README enough? - I would love to follow best-practices, but have a hard time finding real-world examples in other, typically well maintained products like VisualEditor and DiscussionTools <https://codesearch.wmcloud.org/search/?q=mw%5C.hook.*%5C.fire=%5C.js%24=Extension%3ADiscussionTools%2CExtension%3AVisualEditor>. I mean, if such central codebases don't follow the policy, how can we expect other teams to do so? Furthermore, some of the code examples on mw:Stable interface policy/Frontend <https://www.mediawiki.org/wiki/Stable_interface_policy/Frontend> appear to call `mw.hook.fire()` and `mw.hook.add()`, but code like this doesn't exist <https://codesearch.wmcloud.org/search/?q=mw%5C.hook%5C.=%5C.js%24>. Is this an obsolete signature or a mistake? TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: WMDE-Fisch, Jdforrester-WMF, WMDE-leszek, ItamarWMDE, thiemowmde, Aklapper, Jdlrobson, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T323778: [ACTION-API] [TECH] Wikibase doesn’t validate formatter options, can crash with different TypeErrors
thiemowmde added a comment. Quick response from a dev who worked with this code back in 2014 and is at least partially responsible for the mess. ️ The formatter options are (mis)used for two, maybe three different purposes. 1. Only very few options are meant to accept values the user can freely choose from. 2. Many options are never presented to the user. They are part of a round-trip where the decision is made in the backend, send as part of the HTML/JS to the client, where they become part of formatter calls in the UI. I think nobody bothered adding user-friendly validation here because it would be unreachable in all real-world scenarios. 3. Some options are not meant to be accessible from the outside at all. They became an option either because it was unclear that this would make it public, or because we didn't know better, ignored YAGNI, and made it public anyway. Please feel free to identify these, remove them from the options system and turn them into dedicated constructor parameters. TASK DETAIL https://phabricator.wikimedia.org/T323778 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: ArthurTaylor, thiemowmde Cc: thiemowmde, Arian_Bozorg, ArthurTaylor, ItamarWMDE, Michael, Lucas_Werkmeister_WMDE, Aklapper, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, KimKelting, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase
thiemowmde added a subscriber: WMDE-leszek. thiemowmde added a comment. Oh, got it. It's the wrong way around. The weird code was added in patchset 20 in July 2018, apparently by @WMDE-leszek: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/441203/19..20/lib/includes/SimpleCacheWithBagOStuff.php. The commit message was edited in the same patchset. It mentions 3 sources, but I can't find `utf8_…` mentioned on these pages. I tried to read the discussion, but it's not very helpful. Unfortunately I wasn't involved back then. There is also no Phabricator task linked. What's done in the code directly after the weird `utf8_encode` is a `hash_hmac` call. Could it be that this is not able to work with UTF-8 strings, but expects something else? What is `SimpleCacheWithBagOStuff` even used for? What does the extra hashing do? My suggestion is to not touch this class, but mark it as deprecated and replace all usages with something reliable from core. An alternative is to change the serialization format and add a 3rd array element with a version number `2`. Cache entries without this number are still passed through the old deserialization. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: WMDE-leszek, thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T324202: Remove use of utf8_encode and utf8_decode in Wikibase
thiemowmde added a comment. > though “correct” in that the methods perform their inverse operations […] we’re just putting JSONified mojibake in the inner cache. The `utf8_decode` documentation says "UTF-8 characters which do not exist in ISO-8859-1 (that is, code points above U+00FF) are replaced with `?`". This operation is not reversible. I can confirm this from personal experience. TASK DETAIL https://phabricator.wikimedia.org/T324202 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Paladox, Michael, ItamarWMDE, Aklapper, Lucas_Werkmeister_WMDE, Danny_Benjafield_WMDE, Astuthiodit_1, malberts, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, TK-999, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T288813: Decrease template maintenance with Lua conversion, Wikidata and completed TemplateData
thiemowmde closed this task as "Declined". thiemowmde removed projects: VisualEditor, Wikidata, TemplateData. thiemowmde added a comment. This sounds like a super abstract project idea that didn't went anywhere. Or did it? As far as I can tell this is about potentially //using// features of #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/>, #TemplateData <https://phabricator.wikimedia.org/tag/templatedata/>, and #Scribunto <https://phabricator.wikimedia.org/tag/mediawiki-extensions-scribunto/>, but not about making changes to any of these codebases. The tags are misleading and should not be used. But if I remove them not much is left but a historic Hackathon tag. Please feel free to reopen this if I misunderstood. TASK DETAIL https://phabricator.wikimedia.org/T288813 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Theklan, Aklapper, Feldo, ThomasErhel, Kasyap, srishakatux, Bodhisattwa, Ainali, Danny_Benjafield_WMDE, 1313, Astuthiodit_1, Eragon_Shadeslayer, VPuffetMichel, karapayneWMDE, ycrepeau, Invadibot, Mohammadmalek554, maantietaja, Catie99, ItamarWMDE, Akuckartz, keithbrianpadilla, Saimongoltinio, WikimeSteve, ppelberg, Nandana, marcella, Revansx, OhKayeSierra, takidelfin, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess, Dvorapa, _jensen, rosalieper, Scott_WUaS, Srdjan, Jrf, Husun1297, Wikidata-bugs, aude, Mvolz, Swainr, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T351630: Special:PagesWithBadges broken on wikidata.org
thiemowmde closed this task as "Invalid". thiemowmde added a comment. Oh, I'm sorry. I somehow expected this to list the Wikidata items that have the badge assigned. But that's not what the special page is designed to do. TASK DETAIL https://phabricator.wikimedia.org/T351630 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, thiemowmde, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T351630: Special:PagesWithBadges broken on wikidata.org
thiemowmde created this task. thiemowmde added projects: Wikidata, Wikidata Dev Team (Wikidata.org Slice). Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION Special:PagesWithBadges appears to be completely broken. It doesn't list anything. Example: https://www.wikidata.org/wiki/Special:PagesWithBadges?badge=Q17437796. Am I doing something wrong? TASK DETAIL https://phabricator.wikimedia.org/T351630 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Lydia_Pintscher, thiemowmde, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T349240: Create list of places likely going to break due to pseudo-Entity Ids
thiemowmde added a comment. I see. Thanks for the clarification. Sure, it should "break" in a reliable way and ideally with a message that helps the user understand what's going on, and what options they have. TASK DETAIL https://phabricator.wikimedia.org/T349240 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T349240: Create list of places likely going to break due to pseudo-Entity Ids
thiemowmde added a comment.
I'm curious if Lua integration and parser functions like `{{#statements:…}}`
are even needed for EntitySchemas? What would be the use case?
Or to ask this question the other way around: Isn't it much easier to leave
it disconnected as it is for the moment, and only start working on these parts
of the codebase the moment a user group comes up with a use cases that can't be
resolved in another way?
TASK DETAIL
https://phabricator.wikimedia.org/T349240
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: thiemowmde, Aklapper, Michael, Danny_Benjafield_WMDE, Astuthiodit_1,
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi,
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS,
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348079: WMDE: Review code on mw object and mark (un)stable interfaces before 1.42.0
thiemowmde added a comment. The ticket claims to be about "code on mw object". But the #wmde-techwish <https://phabricator.wikimedia.org/tag/wmde-techwish/> products I'm responsible for don't look like <https://codesearch.wmcloud.org/search/?q=%5Cbmw%5C.=%5C.js%24=Extension%3AAdvancedSearch%2CExtension%3ARevisionSlider> they have code that matches this description. The Wikibase examples also don't match <https://codesearch.wmcloud.org/search/?q=%5Cbmw%5C.=%5C.js%24=Extension%3AWikibase> the description (as you said yourself) but use the hook system as documented <https://www.mediawiki.org/wiki/ResourceLoader/Core_modules#mw.hook>. What's wrong with that? What's the problem this ticket aims to solve? TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, Jdlrobson, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T348079: WMDE: Review code on mw object and mark (un)stable interfaces before 1.42.0
thiemowmde removed projects: Revision-Slider, Advanced-Search. thiemowmde added a comment. I'm afraid I don't understand how the #wmde-techwish <https://phabricator.wikimedia.org/tag/wmde-techwish/> products are affected. I had a brief look at the codebases but couldn't spot any suspicious code. Please provide e.g. example code snippets or a CodeSearch link. TASK DETAIL https://phabricator.wikimedia.org/T348079 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, Jdlrobson, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Lea_WMDE, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344609: Revisit the EntitySchema v2 Technical Decision
thiemowmde added a comment. It might be a good idea to expand that ADR then. It appears to be incomplete. I miss, for example, an explanation what that mental load is, and how it compares to the problems that come with EntityDocument. If you want you can think of EntityDocument as a migration path away from the previous Entity class <https://github.com/wmde/WikibaseDataModel/blob/15c79d/src/Entity/Entity.php>. It was never meant to solve much other than making it easier to get rid of it and focus on what an entity type really is. What's left in the class boils down to "something with a getId method". That's it. But we already have a concept for that: use EntityId. I tried to follow a few code paths that currently use EntityDocument. What I find in the end is always something like this <https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/Store/Sql/Terms/DatabaseMatchingTermsLookup.php$143>. This is cheating. This code pretends to forget the entity type – just to send it somewhere where the code paths separate again. And sure, it needs to. Without knowing the type (or trait, e.g. StatementListProvider) no code could do anything meaningful with an EntityDocument alone. But what's even the point then? What we currently have is a codebase where everything is written with certain entity types or traits in mind, but the code doesn't say that. Making more classes implement EntityDocument makes this worse. Not using EntityDocument means we end with more code that clearly says for which entity type it is written. Or even better: code that mentions the traits it is interested in, e.g. StatementListProvider, as listed above. TASK DETAIL https://phabricator.wikimedia.org/T344609 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, thiemowmde Cc: Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, hoo, Bugreporter, Aklapper, Michael, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344609: Revisit the EntitySchema v2 Technical Decision
thiemowmde added a subscriber: Lydia_Pintscher. thiemowmde added a comment. I don't want to fuel this discussion unnecessarily. Unfortunately it feels like this comes up every few years. We had the same fights back then in 2014 when I had my head deep <https://github.com/wmde/WikibaseDataModel/graphs/contributors> in the DataModel. "Being an entity in the code" – i.e. using the EntityDocument base class – was never terribly meaningful. Guess why it's so weirdly named <https://github.com/wmde/WikibaseDataModel/pull/118#issuecomment-46111585>. I tried to avoid using it whenever possible, even started <https://gerrit.wikimedia.org/r/260351> phasing it out. What matters instead is: - Can an entity be described the same way items and properties can? → Use FingerprintProvider. (It's fine to hate the name – I never liked it myself – but this doesn't make it less useful.) - Can an entity have labels and descriptions, but not aliases? → Skip fingerprint but use LabelsProvider and DescriptionsProvider directly. - Can an entity have statements? → Use StatementListProvider for read-only access, otherwise StatementListHolder. (I came up with "holder". I'm sorry.) - Do you want to address your entities the same way as e.g. properties? → Use EntityId. TL;DR: Entities share traits. This is what should be modeled. Not a hierarchy. Not that it matters much, but I fundamentally disagree with the idea that an EntitySchema would just be an "entity with a shape expression attached to it" when it really, really should be the opposite: The only thing that makes an EntitySchema and EntitySchema is the shape expression. Please treat it as such. TASK DETAIL https://phabricator.wikimedia.org/T344609 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, thiemowmde Cc: Lydia_Pintscher, thiemowmde, Lucas_Werkmeister_WMDE, hoo, Bugreporter, Aklapper, Michael, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T344609: Revisit the EntitySchema v2 Technical Decision
thiemowmde added a comment. I don't want to fuel this discussion unnecessarily. Unfortunately it feels like this comes up every few years. We had the same fights back then in 2014 when I had my head deep <https://github.com/wmde/WikibaseDataModel/graphs/contributors> in the DataModel. TL;DR: "Being an entity in the code" – i.e. using the EntityDocument base class – was never terribly meaningful. Guess why it's so weirdly named <https://github.com/wmde/WikibaseDataModel/pull/118#issuecomment-46111585>. What matters is: - Can an - Can an entity have labels and descriptions, but not aliases? → Use `LabelsProvider` and `DescriptionsProvider`. - Can an entity have statements? → Use `StatementListProvider` for read-only access, otherwise `StatementListHolder`. TASK DETAIL https://phabricator.wikimedia.org/T344609 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael, thiemowmde Cc: thiemowmde, Lucas_Werkmeister_WMDE, hoo, Bugreporter, Aklapper, Michael, Danny_Benjafield_WMDE, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, pdehaye, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T313048: Can reference tooltips be moved out of beta mode?
thiemowmde edited projects, added WMDE-TechWish; removed wdwb-tech, Wikidata. TASK DETAIL https://phabricator.wikimedia.org/T313048 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Galobtter, Manuel, Aklapper, Jdlrobson, jdfraine, Timur_Vorkul_WMDE, darthmon_wmde, Andrew-WMDE, Izno, Dinoguy1000, Jay8g, Danny_Benjafield_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T145171: without lat/long should use coordinates from Wikidata
thiemowmde closed this task as "Resolved".
thiemowmde added a comment.
While this is probably more semi-automatic, this is now possible since
T307695: Display coordinate markers in Kartographer maps from QID
<https://phabricator.wikimedia.org/T307695>. Minimal example: `{ "type": "ExternalData", "service": "geopoint",
"ids": "Q8288" }`. It's also possible to do this from a Lua module
with the id filled in automatically.
TASK DETAIL
https://phabricator.wikimedia.org/T145171
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: thiemowmde, Pikne, Ayack, Liuxinyu970226, daniel, MaxSem, Lydia_Pintscher,
Aklapper, Yurik, Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1,
karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Alilje, Nabetaro,
Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden,
Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS,
phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs,
aude, awight, TheDJ, Mbch331, Jay8g
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T337228: Kartographer maps embedded in Wikibase entity pages refer to a dummy page title, leading to errors from maps.wikimedia.org
thiemowmde added a comment. @hoo, can you please try setting the ParserOptions in your CachingKartographerEmbeddingHandler to be in preview mode? (Or section preview, if you prefer.) Not for the entire page but really only for the parsing of the `` tag. This will partially disable the problematic static map rendering. The thing is: It's impossible to render a static .png map when the renderer doesn't have access to the GeoJSON data. Which is the case here because the relevant piece of GeoJSON is created dynamically, not stored in the expected place, and not available via the `mapdata` query API. It's effectively only a "preview". But it's always possible to render a trivial static map based on nothing but a pair of coordinates and a zoom factor. This is the current no-JS fallback that probably also works on entity pages. It's also a good idea to test the https://www.wikidata.org/wiki/Q17151#P625 example page with JavaScript disabled. This way the two bad requests can be seen directly as broken images. I worked a lot on the relevant Kartographer rendering code the past months. I'm happy to pair on this one! TASK DETAIL https://phabricator.wikimedia.org/T337228 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Celenduin, Aklapper, hoo, Danny_Benjafield_WMDE, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Alilje, Nabetaro, Nandana, MSantos, lucamauri, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, awight, Yurik, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321532: Console error - 'Error: View mediainfoview does not exist' on Commons File pages
thiemowmde renamed this task from "[commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages" to "Console error - 'Error: View mediainfoview does not exist' on Commons File pages". TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, thiemowmde, Jdlrobson, Krinkle, Tacsipacsi, mdaniels5757, vadim-kovalenko, matthiasmullie, SimoneThisDot, CBogen, Aklapper, Etonkovidova, Astuthiodit_1, Trngsh15, karapayneWMDE, toberto, Invadibot, Mengs21, GFontenelle_WMF, maantietaja, FRomeo_WMF, EgbeRef, ItamarWMDE, Vaibhav0199, Nintendofan885, Akuckartz, Tinzawoo533, darthmon_wmde, Rosalie_WMDE, Onmir, DannyS712, Nandana, JKSTNK, Mh-3110, Amorymeltzer, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, enigmaeth, rohitt, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Dixtosa, Susannaanas, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages
thiemowmde added a project: Wikidata-UX. thiemowmde added subscribers: Lucas_Werkmeister_WMDE, Lydia_Pintscher. thiemowmde added a comment. The piece of code that fails turns out to be part of the good old Wikidata entity page UI that's build with jQuery UI. See https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/resources/wikibase.ui.entityViewInit.js$357. The thing is: This UI is not used on Commons file pages. This code should never be called, as far as I can tell. Why is it? TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Lydia_Pintscher, Lucas_Werkmeister_WMDE, thiemowmde, Jdlrobson, Krinkle, Tacsipacsi, mdaniels5757, vadim-kovalenko, matthiasmullie, SimoneThisDot, CBogen, Aklapper, Etonkovidova, Astuthiodit_1, Trngsh15, karapayneWMDE, toberto, Invadibot, Mengs21, GFontenelle_WMF, maantietaja, FRomeo_WMF, EgbeRef, ItamarWMDE, Vaibhav0199, Nintendofan885, Akuckartz, Tinzawoo533, darthmon_wmde, Rosalie_WMDE, Onmir, DannyS712, Nandana, JKSTNK, Mh-3110, Amorymeltzer, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, enigmaeth, rohitt, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Dixtosa, Susannaanas, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages
thiemowmde added a comment. I currently get this error on every single File page on Commons, even when I am not logged in. counterexample Error: View mediainfoview does not exist at SELF._getView (load.php?debug=1=en=codex-search-styles%2CdataValues%2Cjquery%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%2CvalueFormatters%2CvalueParsers%2Cwikibase%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.echo.centralauth%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Ci18n%2Cinterface%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery.animateWithEvent%2Cclient%2Ci18n%2Cinputautoexpand%2Cspinner%2CtextSelection%2Cui%2Culs%2Cvalueview%7Cjquery.event.special.eachchange%7Cjquery.spinner.styles%7Cjquery.ui.commonssuggester%2Clanguagesuggester%2Csuggester%7Cjquery.uls.data%2Cgrid%7Cjquery.util.getDirectionality%7Cjquery.valueview.Expert%2CExpertExtender%2CExpertStore%7Cjquery.valueview.experts.CommonsMediaType%2CEmptyValue%2CGeoShape%2CGlobeCoordinateInput%2CMonolingualText%2CQuantityInput%2CStringValue%2CTabularData%2CTimeInput%2CUnDeserializableValue%7Cjquery.wikibase.entityselector%2Cwbtooltip%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cpulsatingdot%2Crouter%2Cstorage%2Ctemplate%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.action.edit.editWarning%7Cmediawiki.action.view.metadata%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%2Cmustache%2Bdom%7Cmediawiki.ui.button%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cmw.config.values.wbDataTypes%2CwbEnableMulLanguageCode%2CwbRefTabsEnabled%2CwbRepo%2CwbSiteDetails%2CwbTmpAlwaysShowMulLanguageCode%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-toolbars.icons%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-editing-core%2Cicons-interactions%2Cicons-location%2Cicons-movement%2Cindicators%7Cskins.vector.legacy.js%7Cutil.ContentLanguages%2CExtendable%2CMessageProvider%2CMessageProviders%2CNotifier%2ChighlightSubstring%2Cinherit%7CvalueParsers.ValueParserStore%2Cparsers%7Cwikibase.EntityInitializer%2CSite%2CWikibaseContentLanguages%2CbuildErrorOutput%2Cdatamodel%2CgetLanguageNameByCode%2CgetUserLanguages%2Cserialization%2Csites%2Ctemplates%7Cwikibase.api.RepoApi%2CValueCaller%7Cwikibase.entityChangers.EntityChangersFactory%7Cwikibase.entityPage.entityLoaded%7Cwikibase.experts.Entity%2CItem%2CProperty%2C__namespace%2Cmodules%7Cwikibase.formatters.ApiValueFormatter%7Cwikibase.mediainfo.base%2CfilePageDisplay%2Cstatements%2Culs%7Cwikibase.ui.entityViewInit%7Cwikibase.utilities.ClaimGuidGenerator%7Cwikibase.view.ControllerViewFactory%2CReadModeViewFactory%2C__namespace=vector=ztntf:45918:10) at SELF.getEntityView (load.php?debug=1=en=codex-search-styles%2CdataValues%2Cjquery%2Coojs%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Coojs-ui-windows%2Csite%2CvalueFormatters%2CvalueParsers%2Cwikibase%7CdataValues.DataValue%2CTimeValue%2Cvalues%7Cext.centralNotice.choiceData%2Cdisplay%2CgeoIP%2CimpressionDiet%2CkvStore%2CstartUp%7Cext.centralauth.ForeignApi%2Ccentralautologin%7Cext.echo.centralauth%7Cext.eventLogging%2CnavigationTiming%2CwikimediaEvents%7Cext.uls.common%2Ccompactlinks%2Ci18n%2Cinterface%2Clanguagenames%2Cmediawiki%2Cmessages%2Cpreferences%2Cwebfonts%7Cext.wikimediaEvents.wikibase%7Cjquery.animateWithEvent%2Cclient%2Ci18n%2Cinputautoexpand%2Cspinner%2CtextSelection%2Cui%2Culs%2Cvalueview%7Cjquery.event.special.eachchange%7Cjquery.spinner.styles%7Cjquery.ui.commonssuggester%2Clanguagesuggester%2Csuggester%7Cjquery.uls.data%2Cgrid%7Cjquery.util.getDirectionality%7Cjquery.valueview.Expert%2CExpertExtender%2CExpertStore%7Cjquery.valueview.experts.CommonsMediaType%2CEmptyValue%2CGeoShape%2CGlobeCoordinateInput%2CMonolingualText%2CQuantityInput%2CStringValue%2CTabularData%2CTimeInput%2CUnDeserializableValue%7Cjquery.wikibase.entityselector%2Cwbtooltip%7Cmediawiki.ForeignApi%2CString%2CTitle%2CUri%2Capi%2Cbase%2Ccldr%2CconfirmCloseWindow%2Ccookie%2Cexperiments%2CjqueryMsg%2Clanguage%2Cpulsatingdot%2Crouter%2Cstorage%2Ctemplate%2Ctoc%2Cuser%2Cutil%2CvisibleTimeout%7Cmediawiki.ForeignApi.core%7Cmediawiki.action.edit.editWarning%7Cmediawiki.action.view.metadata%7Cmediawiki.editfont.styles%7Cmediawiki.libs.pluralruleparser%7Cmediawiki.page.ready%7Cmediawiki.page.watch.ajax%7Cmediawiki.template.mustache%2Cmustache%2Bdom%7Cmediawiki.ui.button%7Cmmv.bootstrap%2Chead%7Cmmv.bootstrap.autostart%7Cmw.config.values.wbDataTypes%2CwbEnableMulLanguageCode%2CwbRefTabsEnabled%2CwbRepo%2CwbSiteDetails%2CwbTmpAlwaysShowMulLanguageCode%7Coojs-ui
[Wikidata-bugs] [Maniphest] T336601: Error: View mediainfoview does not exist
thiemowmde closed this task as a duplicate of T321532: [commons-wmf.6] Console error - Error: View mediainfoview does not exist on File pages. TASK DETAIL https://phabricator.wikimedia.org/T336601 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jdlrobson, Astuthiodit_1, Trngsh15, karapayneWMDE, toberto, Invadibot, Mengs21, maantietaja, EgbeRef, CBogen, ItamarWMDE, Vaibhav0199, Akuckartz, Tinzawoo533, darthmon_wmde, Rosalie_WMDE, Onmir, DannyS712, Nandana, Mh-3110, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, enigmaeth, rohitt, LawExplorer, _jensen, rosalieper, Scott_WUaS, Dixtosa, Verdy_p, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T321532: [commons-wmf.6] Console error - 'Error: View mediainfoview does not exist' on File pages
thiemowmde merged a task: T336601: Error: View mediainfoview does not exist. thiemowmde added a subscriber: Jdlrobson. TASK DETAIL https://phabricator.wikimedia.org/T321532 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jdlrobson, Krinkle, Tacsipacsi, mdaniels5757, vadim-kovalenko, matthiasmullie, SimoneThisDot, CBogen, Aklapper, Etonkovidova, Astuthiodit_1, Trngsh15, karapayneWMDE, toberto, Invadibot, Mengs21, GFontenelle_WMF, maantietaja, FRomeo_WMF, EgbeRef, ItamarWMDE, Vaibhav0199, Nintendofan885, Akuckartz, Tinzawoo533, darthmon_wmde, Rosalie_WMDE, Onmir, DannyS712, Nandana, JKSTNK, Mh-3110, Amorymeltzer, Lahi, Gq86, E1presidente, Ramsey-WMF, Cparle, SandraF_WMF, GoranSMilovanovic, QZanden, enigmaeth, rohitt, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Dixtosa, Susannaanas, Verdy_p, Fuzheado, Jane023, Wikidata-bugs, Base, aude, Daniel_Mietchen, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Raymond, Jdforrester-WMF, Steinsplitter, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T341409: Use LanguageNameUtils::ALL for monolingual text and lexemes
thiemowmde added subscribers: Manuel, Lydia_Pintscher, Amire80, jhsoby, Lucas_Werkmeister_WMDE, thiemowmde. thiemowmde added a comment. I might get this wrong. But as I understand the proposal it would make the currently established processes of how languages on wikidata.org are managed, requested, and confirmed (briefly described in T312845 <https://phabricator.wikimedia.org/T312845>) obsolete. https://phabricator.wikimedia.org/project/profile/4981/ contains more details. As far as I remember (note this might be outdated as I'm not part of the Wikidata team any more) the basic idea is that there is an "official" working group that intentionally reviews and accepts new languages one by one only when they are actually needed. I added people that are most probably interested in this and suggest to decline or approve this ticket in a timely manner to reduce confusion. TASK DETAIL https://phabricator.wikimedia.org/T341409 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Lucas_Werkmeister_WMDE, jhsoby, Amire80, Lydia_Pintscher, Manuel, mrephabricator, Nikki, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T341210: FlaggedRevs ReviewHandlerTest::testWithMinParams fails in EntitySchema CI
thiemowmde added a comment. We have T256296 <https://phabricator.wikimedia.org/T256296>, T340004 <https://phabricator.wikimedia.org/T340004>, and this now, all attacking the probably same issue from different perspectives. I still can't explain it 100%. As of now, https://gerrit.wikimedia.org/r/936252 sets the page name back to "UTTest". This might indeed "fix" or more precisely hide the error in certain situations, while making it come back in others. We believe what's going on is that the `flaggedrevs` database table is not properly cleaned up, and later tests find unrelated rows in there that randomly happen to have the same page id again. I'm still working on it. TASK DETAIL https://phabricator.wikimedia.org/T341210 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, awight, Lucas_Werkmeister_WMDE, Aklapper, Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, Asartea, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Dzaky17, Hook696, Kent7301, pdehaye, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, tsca, Andrawaag, GoranSMilovanovic, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, Lewizho99, Maathavan, _jensen, rosalieper, XanonymusX, Neuronton, Scott_WUaS, Cirdan, MisterSynergy, abian, Zache, Wikidata-bugs, aude, jeblad, Tacsipacsi, Lydia_Pintscher, Jdforrester-WMF, Ladsgroup, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens
thiemowmde added a comment. I think the problem we have are the unknown unknowns – situations we currently can't think of. I would love to ask the question the other way around: When does it make sense to cut off an arbitrary part of a button label? Or maybe like this: What's worse, a button that get's cut-off when it shouldn't or a button that wraps when it shouldn't? Sure, both is a problem. In both cases we want to look for other solutions. But I'm afraid we can't avoid running into this problem in all possible situations, including the ones we currently can't think of (unknown unknowns). If it happens the user should be able to continue using the interface without guessing what a button might mean, and ideally report the problem to us so we can fix it. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, thiemowmde Cc: Arian_Bozorg, hoo, jon_amar-WMDE, ItamarWMDE, Lucas_Werkmeister_WMDE, karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thiemowmde, Lucie, Sjoerddebruin, Aklapper, Astuthiodit_1, Prufkick, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Puik, _jensen, rosalieper, xSavitar, Envlh, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Tobias1984, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T174443: Some extension name are localized though most are not
thiemowmde removed a project: WMDE-TechWish-Maintenance. thiemowmde closed this task as "Invalid". thiemowmde added a comment. I don't think there is anything to do here. If you think a specific extension should be translatable (or not be translated) please open separate bug reports per extension. TASK DETAIL https://phabricator.wikimedia.org/T174443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Jdlrobson, Legoktm, Aklapper, Bugreporter, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lea_WMDE, _jensen, rosalieper, Scott_WUaS, freephile, Wikidata-bugs, aude, brion, TheDJ, Mbch331, Jay8g, Sms2sms, Luke081515 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T326908: Update WMDE Engineering-owned products that may be affected by IP Masking
thiemowmde removed a project: WMDE-TechWish-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T326908 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: WMDE-Fisch, WMDE-leszek, ItamarWMDE, Niharika, ARamirez_WMF, SCherukuwada, Aklapper, Tchanders, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, kostajh, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Ltrlg, Sms2sms, Luke081515, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T211676: Inline Kartographer mapframes: Take precision into account
thiemowmde added a comment. There is a highly relevant piece of code in the #Kartographer <https://phabricator.wikimedia.org/tag/kartographer/> extension that does the opposite: The input is a zoom factor from 0 to 19 and the output a precision. You "just" need to turn the formula around. https://phabricator.wikimedia.org/diffusion/EKAR/browse/master/modules/box/Map.js$782 I also suggest to limit the zoom factor, i.e. never go to 19 but stop much earlier. Maybe just keep using the current 13 as a limit. I find this reasonable. Such a limit is relevant because many coordinates on Wikidata appear to have an unreasonably high precision because of conversion artifacts. I'm not sure to what "Marius lined out a solution" refers to. Do you have a link? TASK DETAIL https://phabricator.wikimedia.org/T211676 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Nikki, LennardHofmann, Ainali, Ayack, Aklapper, Lucas_Werkmeister_WMDE, Sjoerddebruin, Lydia_Pintscher, aude, thiemowmde, hoo, TheDJ, mrephabricator, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Alilje, Nabetaro, Nandana, MSantos, lucamauri, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, awight, Yurik, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T165870: MUL - Submit button on Special:SetLabelDescriptionAliases is too wide on smaller screens
thiemowmde added a comment. As someone still watching this ticket: I honestly never understood why OOUI hard-codes <https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/src/styles/elements/ButtonElement.less$15> a `nowrap` in this situation. It's never helpful, especially not in an environment where we have to consider over 200 <https://translatewiki.net/> languages. It might make sense to combine it with `text-overflow: ellipsis` in situations where we know the end of the string is not that important, or when we know the full text can be found somewhere else. But this is not the case for a button label. When a button label is long there is a reason for that. We should never just cut off an arbitrary piece. Reducing the text to "Publish" in English unfortunately doesn't make the issue go away. Any of the over 200 localizations might still be significantly longer, as @Nikki demonstrates. I strongly suggest to embrace these "limitations", let button labels wrap and choose **meaningful** labels that make it easy to understand what a button does. TASK DETAIL https://phabricator.wikimedia.org/T165870 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Lucas_Werkmeister_WMDE, karapayneWMDE, Michael, Lydia_Pintscher, Manuel, Sarai-WMDE, Nikki, Liuxinyu970226, PokestarFan, thiemowmde, Lucie, Sjoerddebruin, Aklapper, Astuthiodit_1, Prufkick, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Puik, _jensen, rosalieper, xSavitar, Envlh, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Wikidata-bugs, aude, Tobias1984, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T214002: Wikidata web form recognizes Japanese date 2001年8月31日 but not 2016年7月1日
thiemowmde added a comment. > or worse, Wikibase might even fall back to another parser and still successfully parse the date […] … which might be good or bad: - Unambiguous dates will be parsed just fine by one of the later, more relaxed parsers. These will ignore the day of the week anyway. Making an earlier parser more strict doesn't mean "2023年3月12日 (月)" will be rejected. We would need to change the entire approach to give this guarantee – which I think we shouldn't do. - We know the final PHP date parser can sometimes produce weird results. It's always better to make an earlier parser accept a date when we have enough certainty. I think this is the case here. The day of the week at the end of "2023年3月12日 (月)" can be wrong for many reasons. It's very unlikely such a mismatch means the date is entirely wrong and needs to be rejected, in my opinion. And even if, we don't have a good way to tell the user. TASK DETAIL https://phabricator.wikimedia.org/T214002 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Lucas_Werkmeister_WMDE, Nikki, thiemowmde, Nicolas_Raoul, Aklapper, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, 786, Biggs657, karapayneWMDE, Invadibot, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T90852: Create a system to store and query links to books
thiemowmde added a project: WMDE-References-FocusArea. TASK DETAIL https://phabricator.wikimedia.org/T90852 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: PokestarFan, Elitre, VIGNERON, Sumit, Minervaxox, Shrutika719, Mvolz, CeruleanDreamer, Magnus, Jdouglas, Lydia_Pintscher, Qgil, Aklapper, Ladsgroup, Astuthiodit_1, AWesterinen, bking, BeautifulBold, VPuffetMichel, Suran38, karapayneWMDE, Invadibot, MPhamWMF, diegodlh, maantietaja, Anasskoko, Peteosx1x, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, Ironie, ET4Eva, Nandana, Namenlos314, Zambujo, Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, Gehel, _jensen, rosalieper, Jason_Quinn, Scott_WUaS, Jonas, FloNight, Xmlizer, Shangkuanlc, jkroll, Wikidata-bugs, aude, Tobias1984, Daniel_Mietchen, Dinoguy1000, Manybubbles, Gryllida, jayvdb, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T166304: Consider making a WikiCite extension for cross-cluster loading of structured citations (replacing Cite extension for those uses)
thiemowmde added a project: WMDE-References-FocusArea. TASK DETAIL https://phabricator.wikimedia.org/T166304 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Carn, Izno, PokestarFan, Jdforrester-WMF, Aklapper, 1313, Astuthiodit_1, BeautifulBold, VPuffetMichel, Suran38, karapayneWMDE, ycrepeau, Invadibot, Mohammadmalek554, maantietaja, Anasskoko, Peteosx1x, NavinRizwi, ItamarWMDE, Akuckartz, keithbrianpadilla, Saimongoltinio, WikimeSteve, ppelberg, Nandana, marcella, Revansx, OhKayeSierra, Zambujo, takidelfin, Lahi, Gq86, Necroarcano, Robinma, GoranSMilovanovic, QZanden, merbst, LawExplorer, Wess, _jensen, rosalieper, Scott_WUaS, Srdjan, Jrf, Husun1297, Wikidata-bugs, aude, Daniel_Mietchen, Dinoguy1000, Gryllida, jeblad, jayvdb, Swainr, fbstj, Jackmcbarn, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T326768: OutOfRangeException: Lexeme L136328 doesn't have Form L136328-F2
thiemowmde added a comment. It was the other way around. I suggested to remove the problematic `hasForm` after the "unchecked errors" patch got stale. Reading the discussion I still don't understand why it wasn't merged. (Well, not being linked to a ticket definitely played a role.) The patcher just throws the wrong exception. It could be so easy. Please feel free to restore or redo the patch. TASK DETAIL https://phabricator.wikimedia.org/T326768 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Lucas_Werkmeister_WMDE, ItamarWMDE, Michael, Aklapper, jeena, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Akuckartz, darthmon_wmde, Rosalie_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Verdy_p, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T204813: Allow looking for items and lexemes namespaces together by default
thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T204813 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, MPhamWMF, So9q, EBernhardson, dcausse, abian, Smalyshev, Lydia_Pintscher, Lea_Lacroix_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T204813: Allow looking for items and lexemes namespaces together by default
thiemowmde reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T204813 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, MPhamWMF, So9q, EBernhardson, dcausse, abian, Smalyshev, Lydia_Pintscher, Lea_Lacroix_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, CBogen, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T209035: When creating a statement linking to a Sense show all Senses of a Lexeme in entity selector if Lexeme ID is entered
thiemowmde removed a project: Discovery-Search. thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T209035 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, MPhamWMF, Infovarius, EBernhardson, dcausse, Smalyshev, Lydia_Pintscher, Addshore, Lucas_Werkmeister_WMDE, iecetcwcpggwqpgciazwvzpfjpwomjxn, Nikki, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, CBogen, EBjune ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T209035: When creating a statement linking to a Sense show all Senses of a Lexeme in entity selector if Lexeme ID is entered
thiemowmde reopened this task as "Open". TASK DETAIL https://phabricator.wikimedia.org/T209035 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, MPhamWMF, Infovarius, EBernhardson, dcausse, Smalyshev, Lydia_Pintscher, Addshore, Lucas_Werkmeister_WMDE, iecetcwcpggwqpgciazwvzpfjpwomjxn, Nikki, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T202254: Use ExtensionRegistry instead of class_exists to check for CirrusSearch in Wikibase
thiemowmde changed the task status from "Declined" to "Resolved". thiemowmde removed projects: CirrusSearch, Discovery-Search. TASK DETAIL https://phabricator.wikimedia.org/T202254 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: MPhamWMF, Addshore, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g, Wilmanbeno, CBogen, EBjune, jayvdb, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T189744: Add hints parameter to wbsearchentities
thiemowmde reopened this task as "Open". thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T189744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, MPhamWMF, So9q, Nuria, Jonas, EBernhardson, gerritbot, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Astuthiodit_1, bking, karapayneWMDE, Invadibot, maantietaja, CBogen, ItamarWMDE, Akuckartz, ET4Eva, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Avner, Gehel, _jensen, rosalieper, Scott_WUaS, FloNight, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T189736: [Epic] Lexeme search
thiemowmde reopened subtask T189737: [Epic] Implement completion search for Lexemes as Open. TASK DETAIL https://phabricator.wikimedia.org/T189736 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Liuxinyu970226, Esc3300, debt, EBjune, Lydia_Pintscher, daniel, Aklapper, Smalyshev, Astuthiodit_1, bking, BeautifulBold, Suran38, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, Peteosx1x, NavinRizwi, ItamarWMDE, Akuckartz, ET4Eva, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Avner, Gehel, _jensen, rosalieper, Scott_WUaS, FloNight, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T189737: [Epic] Implement completion search for Lexemes
thiemowmde reopened this task as "Open". thiemowmde added a comment. #Wikidata <https://phabricator.wikimedia.org/tag/wikidata/> is not owned by Search. Please try to be more careful. TASK DETAIL https://phabricator.wikimedia.org/T189737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, thiemowmde Cc: thiemowmde, Aklapper, daniel, Lydia_Pintscher, Smalyshev, Astuthiodit_1, bking, BeautifulBold, Suran38, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, Peteosx1x, NavinRizwi, ItamarWMDE, Akuckartz, ET4Eva, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, Avner, Gehel, _jensen, rosalieper, Scott_WUaS, FloNight, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T189737: [Epic] Implement completion search for Lexemes
thiemowmde reopened subtask T189744: Add hints parameter to wbsearchentities as Open. TASK DETAIL https://phabricator.wikimedia.org/T189737 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Smalyshev, thiemowmde Cc: Aklapper, daniel, Lydia_Pintscher, Smalyshev, Astuthiodit_1, bking, BeautifulBold, Suran38, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, Peteosx1x, NavinRizwi, ItamarWMDE, Akuckartz, ET4Eva, Nandana, Lahi, Gq86, GoranSMilovanovic, Mahir256, QZanden, EBjune, LawExplorer, Avner, Gehel, _jensen, rosalieper, Scott_WUaS, FloNight, Wikidata-bugs, aude, Dinoguy1000, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T188291: Display point features (coordinates) from the results of a SPARQL query on a map in Wikipedia
thiemowmde closed subtask T300042: Investigation: display SPARQL queries in a map in Wikipedia as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T188291 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Abbe98, Conny, Theklan, ECohen_WMDE, Larske, Dipsacus_fullonum, Sabas88, CamelCaseNick, Ainali, Rehman, Spinster, Laurentius, Yair_rand, MSantos, Liuxinyu970226, Capankajsmilyo, Haros, putnik, Evad37, Jonas, Yurik, Aklapper, Ayack, karapayneWMDE, Invadibot, MPhamWMF, maantietaja, CBogen, Akuckartz, Alilje, Nabetaro, Nandana, Namenlos314, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Sturm, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, Xmlizer, GAllegre, Susannaanas, ferdbold, lxbarth, jkroll, Planemad, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, awight, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T145171: without lat/long should use coordinates from Wikidata
thiemowmde added a project: WMDE-GeoInfo-FocusArea. TASK DETAIL https://phabricator.wikimedia.org/T145171 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Pikne, Ayack, Liuxinyu970226, daniel, MaxSem, Lydia_Pintscher, Aklapper, Yurik, Invadibot, maantietaja, Akuckartz, Alilje, Nabetaro, Nandana, MSantos, Lahi, Gq86, Looniverse, GoranSMilovanovic, Sturm, QZanden, Orienteerix, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, GAllegre, Susannaanas, ferdbold, lxbarth, Planemad, Wikidata-bugs, aude, awight, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T188291: Display point features (coordinates) from the results of a SPARQL query on a map in Wikipedia
thiemowmde added a subtask: T300042: Investigation: display SPARQL queries in a map in Wikipedia. TASK DETAIL https://phabricator.wikimedia.org/T188291 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Abbe98, Conny, Theklan, ECohen_WMDE, Larske, Dipsacus_fullonum, Sabas88, CamelCaseNick, Ainali, Rehman, Spinster, Laurentius, Yair_rand, MSantos, Liuxinyu970226, Capankajsmilyo, Haros, putnik, Evad37, Jonas, Yurik, Aklapper, Ayack, Invadibot, MPhamWMF, maantietaja, CBogen, Akuckartz, Alilje, Nabetaro, Nandana, Namenlos314, Lahi, Gq86, Looniverse, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Sturm, QZanden, EBjune, Orienteerix, merbst, LawExplorer, Ddproxy, _jensen, rosalieper, JGirault, Scott_WUaS, phabyogi, Xmlizer, GAllegre, Susannaanas, ferdbold, lxbarth, jkroll, Planemad, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release
thiemowmde closed subtask T300349: Fix use of errorbox in TemplateData as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, thiemowmde Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Nishu02, fenpedia, toberto, bwang, Invadibot, LaMagiaaa, Lectrician1, Zabe, Asartea, Florian_COLLIN, R4356th, maantietaja, Wilmanbeno, CBogen, Akuckartz, Dzaky17, CptViraj, darthmon_wmde, WDoranWMF, Majavah, EvanProdromou, 94rain, DannyS712, wildly_boy, Nandana, Chief_Mike, Jony, Patriccck, CycloneIsaac, Lahi, Gq86, Ramsey-WMF, mojoaxel, Daimona, Gboyers, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Winter, Litanwei, JJMC89, _jensen, rosalieper, Agabi10, XanonymusX, Scott_WUaS, Cirdan, Pchelolo, Wong128hk, Luke081515, Nirmos, Unapersona, Zache, Wikidata-bugs, Snowolf, aude, Nullzero, Huji, Dinoguy1000, jeblad, jayvdb, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release
thiemowmde closed subtask T300342: Fix use of warningbox in TwoColConflict as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, thiemowmde Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Nishu02, fenpedia, toberto, bwang, Invadibot, LaMagiaaa, Lectrician1, Zabe, Asartea, Florian_COLLIN, R4356th, maantietaja, Wilmanbeno, CBogen, Akuckartz, Dzaky17, CptViraj, darthmon_wmde, WDoranWMF, Majavah, EvanProdromou, 94rain, DannyS712, wildly_boy, Nandana, Chief_Mike, Jony, Patriccck, CycloneIsaac, Lahi, Gq86, Ramsey-WMF, mojoaxel, Daimona, Gboyers, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Winter, Litanwei, JJMC89, _jensen, rosalieper, Agabi10, XanonymusX, Scott_WUaS, Cirdan, Pchelolo, Wong128hk, Luke081515, Nirmos, Unapersona, Zache, Wikidata-bugs, Snowolf, aude, Nullzero, Huji, Dinoguy1000, jeblad, jayvdb, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T300306: successbox, errorbox and warningbox classes will no longer function in 1.39 release
thiemowmde closed subtask T300343: Fix uses of error- and warningbox in FileImporter as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T300306 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Jdlrobson, thiemowmde Cc: Volker_E, Esanders, Aklapper, Tacsipacsi, Nikerabbit, Iniquity, Johan, PeterBowman, Amorymeltzer, Jdforrester-WMF, ovasileva, Trizek-WMF, Izno, Patafisik, Jdlrobson, Nishu02, fenpedia, toberto, bwang, Invadibot, LaMagiaaa, Lectrician1, Zabe, Asartea, Florian_COLLIN, R4356th, maantietaja, Wilmanbeno, CBogen, Akuckartz, Dzaky17, CptViraj, darthmon_wmde, WDoranWMF, Majavah, EvanProdromou, 94rain, DannyS712, wildly_boy, Nandana, Chief_Mike, Jony, Patriccck, CycloneIsaac, Lahi, Gq86, Ramsey-WMF, mojoaxel, Daimona, Gboyers, GoranSMilovanovic, ihojose, QZanden, LawExplorer, Winter, Litanwei, JJMC89, _jensen, rosalieper, Agabi10, XanonymusX, Scott_WUaS, Cirdan, Pchelolo, Wong128hk, Luke081515, Nirmos, Unapersona, Zache, Wikidata-bugs, Snowolf, aude, Nullzero, Huji, Dinoguy1000, jeblad, jayvdb, RandomDSdevel, fbstj, Lydia_Pintscher, Florian, Isarra, Billinghurst, Ladsgroup, Addshore, Jackmcbarn, Mbch331, Jay8g, Ltrlg, Glaisher, jeremyb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T174443: Some extension name are localized though most are not
thiemowmde added a project: WMDE-Technical-Wishes-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T174443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jdlrobson, Legoktm, Aklapper, Bugreporter, Invadibot, maantietaja, Akuckartz, Sms2sms, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lea_WMDE, _jensen, rosalieper, Scott_WUaS, Luke081515, Wikidata-bugs, aude, brion, TheDJ, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T165488: [Hackathon 2017] "Progressive Enhancement": Added JS makes UI jump
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T165488 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lydia_Pintscher, thiemowmde Cc: Volker_E, Lea_WMDE, Aklapper, WMDE-Fisch, Lydia_Pintscher, daniel, Jan_Dittrich, Invadibot, maantietaja, Rost_WMDE, Akuckartz, Erdinc_Ciftci_WMDE, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Puik, _jensen, rosalieper, xSavitar, Envlh, Scott_WUaS, Wikidata-bugs, aude, Tobias1984, Mbch331, Jay8g, dueltodeath, KasiaWMDE, jayvdb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T144616: Enable the revisionslider on test.wikidata.org
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T144616 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, thiemowmde Cc: Lea_Lacroix_WMDE, Glorian_Yapinus, gerritbot, Sjoerddebruin, Lydia_Pintscher, Lea_WMDE, Aklapper, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Addshore, Mbch331, Jay8g, dueltodeath, KasiaWMDE, jayvdb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T174443: Some extension name are localized though most are not
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T174443 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Jdlrobson, Legoktm, Aklapper, Bugreporter, Invadibot, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lea_WMDE, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, brion, TheDJ, Mbch331, Jay8g, dueltodeath, KasiaWMDE, jayvdb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T183096: Use ExtensionRegistry instead of class_exists to check for enabled extensions
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T183096 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, thiemowmde Cc: TheDJ, gerritbot, Ebe123, Aklapper, TerraCodes, aude, hoo, Addshore, WMDE-leszek, Ladsgroup, thiemowmde, 786, Suran38, Biggs657, Invadibot, Gaurav24072002, Abhinay76, Lalamarie69, Annysah01, Rohitgeddam, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Soda, Chaytanya, JorisDarlingtonQuarshie, Hook696, darthmon_wmde, wiki-helenatxu, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Tks4Fish, Gaboe420, lucamauri, Mh-3110, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, JakeTheDeveloper, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, xSavitar, Scott_WUaS, MuhammadShuaib, Izno, Tmalhotra, SimmeD, Wikidata-bugs, Dinoguy1000, Mbch331, Jay8g, dueltodeath, Lea_WMDE, KasiaWMDE, jayvdb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T196166: Add Wikibase-specific search-options to Advanced search
thiemowmde removed a project: TCB-Team (now WMDE-TechWish). TASK DETAIL https://phabricator.wikimedia.org/T196166 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gabriel-wmde, Aklapper, MichaelSchoenitzer_WMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, dueltodeath, Lea_WMDE, KasiaWMDE, jayvdb ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T214002: Wikidata web form recognizes Japanese date 2001年8月31日 but not 2016年7月1日
thiemowmde added a comment. I can explain this behavior, if it helps. The first date is unambiguous. We do have a parser that ignores all punctuation. It checks if it can find 3 numbers, and if there is only one way these 3 numbers can be mapped to a year, month, and day. This works for an input like "2001 8 31", but not "2016 7 1". The later can be January 7th or July 1st. The current set of parsers can't know and gives up. One possible solution is to add a new parser especially for Japanese dates. TASK DETAIL https://phabricator.wikimedia.org/T214002 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Nicolas_Raoul, Aklapper, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T47925: [Task] Apply normalization to string values in statements
thiemowmde added a comment. I suggest two separate data types for strings that should be trimmed (which should be the norm) and "binary" strings that aren't. TASK DETAIL https://phabricator.wikimedia.org/T47925 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Addshore, Herzi.Pinki, MichaelSchoenitzer, Billinghurst, Esc3300, ChristianKl, thiemowmde, Ricordisamoa, Aklapper, adrianheine, Snaterlicious, Mushroom, Lydia_Pintscher, daniel, Raymond, Invadibot, maantietaja, Akuckartz, Dinadineke, DannyS712, Nandana, lucamauri, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, TheDJ, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T188395: [Task] Make sure all Wikibase codebases run PHPCS during `composer test`
thiemowmde added a comment. I'm not working with these codebases any more. But since I created this ticket once, I had a quick look at some random codebases I could find. These execute phpcs as part of `composer test`: - https://github.com/wmde/Number/blob/master/composer.json#L56 - https://github.com/wmde/Time/blob/master/composer.json#L54 - https://github.com/DataValues/Validators/blob/master/composer.json#L50 - … These **don't**: - https://github.com/wmde/WikibaseDataModel/blob/master/composer.json#L59 - https://github.com/wmde/WikibaseDataModelSerialization/blob/master/composer.json#L62 - https://github.com/wmde/WikibaseDataModelServices/blob/master/composer.json#L49 - https://github.com/wmde/WikibaseInternalSerialization/blob/master/composer.json#L55 - … - There are also quite some `data-values/*` components that aren't forked to the `wmde` organization yet, and also do not execute phpcs as part of `composer test`. Whatever you decide (and I believe the team currently working with these codebases should be free to decide whatever they find most helpful), my personal recommendation is to make sure all codebases do the same on `composer test`. As of now there isn't much consistency, not even for the few codebases still in the DataValues org <https://github.com/search?q=org%3ADataValues+%22phpcs+-p%22=code>. Note: When you change `composer test` to include phpcs, please make sure the existing `ci` command does not execute phpcs twice <https://github.com/wmde/WikibaseInternalSerialization/pull/136/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34L64>. TASK DETAIL https://phabricator.wikimedia.org/T188395 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: bete, thiemowmde Cc: Addshore, JeroenDeDauw, Ladsgroup, Jonas, Lucas_Werkmeister_WMDE, Rzuwig, thiemowmde, Aklapper, Invadibot, maantietaja, Akuckartz, Iflorez, darthmon_wmde, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, aude, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T260178: Use html entity for space in wikibaselexeme-formidformatter-separator-grammatical-features
thiemowmde assigned this task to Umherirrender. thiemowmde set the point value for this task to "1". thiemowmde closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T260178 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Umherirrender, thiemowmde Cc: Umherirrender, Abhinay76, Annysah01, Rohitgeddam, Alter-paule, Beast1978, Un1tY, Akuckartz, Soda, Chaytanya, Hook696, wiki-helenatxu, Kent7301, joker88john, CucyNoiD, Nandana, Kieubinhtb, Tks4Fish, Gaboe420, Mh-3110, Giuliamocci, Asad_Ali_Palijo, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, xSavitar, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, Tmalhotra, SimmeD, abian, Wikidata-bugs, aude, Gryllida, Shizhao, Arrbee, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 in actively developed Wikibase related repositories and retire wikibase-codesniffer
thiemowmde added a comment. I feel like we need to talk about this a little more. > We call them the Wikimedia coding standards. Yes, and no. Sure, one of the purposes of the #mediawiki-codesniffer <https://phabricator.wikimedia.org/tag/mediawiki-codesniffer/> is to encode https://www.mediawiki.org/wiki/Manual:Coding_conventions/PHP. But the two are not entirely identical. The manual page lists things that aren't or just can't be checked by a sniff (for example, it's probably impossible to tell if a `==` should be a `===` or vice versa). And we have more and more sniffs for details that are not listed on the manual page. For example, the manual page doesn't say anything about `assertCount` and such – yet we have sniffs that discourage using certain combinations. That alone is not a problem. We typically think of a coding standard as something that should ideally apply to 100% of all code. When code doesn't conform, it should probably be rewritten. But here is the problem: We started to add more and more sniffs with known exceptions that are not "broken" and don't need "fixing". Other sniffs are disputable. For example, I think that the extra space in `@param bool $enable` really, really isn't a problem (this happens when you vertically align multiple @param). It should be ok when the owner of a codebase excludes this. T264948 <https://phabricator.wikimedia.org/T264948> is a another example that already caused issues, see T269332 <https://phabricator.wikimedia.org/T269332>. Is this a problem? Shouldn't be. We have know solutions, e.g. using `// phpcs:…` comments or ``, as discussed above. But it can become an issue when a sniff's message or a tool like #libup <https://phabricator.wikimedia.org/tag/libup/> create the impression that the owner of a codebase is doing something wrong – when they don't. It's about the tone. That's why I hope we can do more fine-tuning like this <https://gerrit.wikimedia.org/r/c/mediawiki/tools/codesniffer/+/654807/4/MediaWiki/Sniffs/Commenting/DocumentationTypeTrait.php>. TASK DETAIL https://phabricator.wikimedia.org/T266823 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, thiemowmde Cc: WMDE-leszek, Umherirrender, Legoktm, Lucas_Werkmeister_WMDE, Jdforrester-WMF, thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, Iflorez, alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field
thiemowmde added a comment. James, such a passive-aggressive tone is inakzeptable. If you are unable to explain yourself then please don't comment, especially if you are not even asked for your opinion. TASK DETAIL https://phabricator.wikimedia.org/T229939 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Physikerwelt, thiemowmde Cc: Jdforrester-WMF, TheDJ, awight, Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T229939: Implement wikidata entity selector in OOUI input field
thiemowmde added a subscriber: TheDJ. thiemowmde added a comment. I know this is frustrating. WMDE staff is happy to help, but is currently not in a position to invest substantial resources into the Math extension. According to https://www.mediawiki.org/wiki/Developers/Maintainers the owner of the extension is the WMF editing team (lead by @Esanders), as well as @TheDJ and you. My personal opinion: When there aren't any objections from Ed or their team, this might be one of the rare situations where it's fine to self-merge your own patch. 路♂️ TASK DETAIL https://phabricator.wikimedia.org/T229939 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Physikerwelt, thiemowmde Cc: TheDJ, awight, Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Hagarshilo, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Lewizho99, Maathavan, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T269232: Localized precision in geocoordinate inputs
thiemowmde added a comment. > - 1/1' > > Should we make that […] translatable as well? Yes, I suggest to make it translatable. One might want to localize this as "1/1 of a second", or something like "1/10.000 Sekunde" in German. It appears like the Geo library was heavily changed in 2019. I can't tell how much the precision detection changed as well when this happened. I found a bit of code that limits seconds to at most 4 decimal places, i.e. 0.0001 or 1/10,000. TASK DETAIL https://phabricator.wikimedia.org/T269232 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE, thiemowmde Cc: thiemowmde, Lydia_Pintscher, Aklapper, Lea_Lacroix_WMDE, noarave, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T157673: Don't use PHP serialization to determine revision size for Entities
thiemowmde added a subscriber: Lydia_Pintscher. thiemowmde added a comment. It sounds like the only place that uses these numbers is the history. It displays both the page size for each revision (in a tooltip), as well as +/- changes. Touching this code will have these consequences: - All these numbers will finally be correct. - Note I assume we use the compact JSON serialization as it is when using Special:EntityData <https://www.wikidata.org/wiki/Special:EntityData/Q59222763.json>. This is what I would expect as a user. - Counter-argument: It might be that these numbers are not used for anything. It really doesn't matter how "correct" they are, as long as they show a reasonable +/- trend. - Old rows in the history will not be updated automatically. It will most probably look like all pages get significantly smaller for a reason a user looking at the history can't understand. However: - This happened before and will happen again when something is changed or added to the serialization. An edit to an old entity will migrate it to use the new serialization. The reported size will change in a way the user can't understand. This is to be expected. - It should be possible to update all old history entries. It just might not be worth it. Essentially: This is a PM decision. @Lydia_Pintscher? The code change is rather trivial. TASK DETAIL https://phabricator.wikimedia.org/T157673 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Lydia_Pintscher, StudiesWorld, JanZerebecki, Addshore, aude, hoo, thiemowmde, Aklapper, daniel, Akuckartz, darthmon_wmde, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Izno, Wikidata-bugs, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T221949: Remove uses of Title::moveTo
thiemowmde edited projects, added MediaWiki-extensions-WikimediaMaintenance; removed MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T221949 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DannyS712, thiemowmde Cc: Art-Baltai, Peter.ovchyn, daniel, DannyS712, Aklapper, Lucas_Werkmeister_WMDE, Simetrical, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, eprodromou, Hook696, darthmon_wmde, WDoranWMF, Kent7301, holger.knust, EvanProdromou, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, TheDragonFire, RazeSoldier, QZanden, LawExplorer, Tuxxic, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Izno, Wikidata-bugs, aude, Dinoguy1000, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort
thiemowmde removed a project: MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Andrew-WMDE, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort
thiemowmde added a project: MediaWiki-extensions-Maintenance. TASK DETAIL https://phabricator.wikimedia.org/T236891 WORKBOARD https://phabricator.wikimedia.org/project/board/2323/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Andrew-WMDE, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort
thiemowmde removed a project: archived--TCB-Team. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Andrew-WMDE, Wikidata-bugs, aude, Mbch331, dueltodeath, Lea_WMDE, KasiaWMDE, jayvdb ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T236891: AdvancedSearch does not offer nor describe “incoming_links_desc” sort
thiemowmde added a project: WMDE-Technical-Wishes-Team. TASK DETAIL https://phabricator.wikimedia.org/T236891 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Lucas_Werkmeister_WMDE, Alter-paule, Beast1978, Un1tY, dueltodeath, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lea_WMDE, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Andrew-WMDE, KasiaWMDE, Wikidata-bugs, aude, jayvdb, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T266823: Use mediawiki codesniffer v33 or v32.1 and retire wikibase-codesniffer
thiemowmde added a comment. My suggestion for this migration would be to copy-paste the entire file https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml to every codebase that currently uses the WikibaseCodeSniffer, and slowly simplify it, e.g. remove exclusions you don't want to exclude any more, as well as remove additions you don't care about. I suggest to keep the comments, as they help other developers to understand that some exclusions are very intentional, and the Wikidata team doesn't want anybody to re-enable them (if this is still the case). Note that excluding a sniff is not a bad thing, and doesn't mean the code is bad. At this point we have sooo many sniffs, and many of them are about teeny tiny details nobody would really argue about. Feel free to diverge from the MediaWiki rule set a bit if it makes your team feel more comfortable. TASK DETAIL https://phabricator.wikimedia.org/T266823 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Aklapper, Michael, Ladsgroup, Addshore, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Lethexie, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Legoktm ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T164653: Review rules in wikibase/wikibase-codesniffer and see which are appropriate for MW-CS
thiemowmde added a comment. No, as far as I can see this was everything. I suggest to copy-paste the entire file https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml to every codebase that currently uses the WikibaseCodeSniffer, and slowly simplify it, e.g. remove exclusions you don't want to exclude any more, as well as remove additions you don't care about. I suggest to keep the comments, as they help other developers to understand that some exclusions are very intentional, and the Wikidata team doesn't want anybody to re-enable them (if this is still the case). Note that excluding a sniff is not a bad thing, and doesn't mean the code is bad. At this point we have sooo many sniffs, and many of them are about teeny tiny details nobody would really argue about. Feel free to diverge from the MediaWiki rule set a bit if it makes your team feel more comfortable. TASK DETAIL https://phabricator.wikimedia.org/T164653 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: gerritbot, Ricordisamoa, Addshore, Aleksey_WMDE, thiemowmde, Legoktm, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Lethexie, Maathavan, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T265992: Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given
thiemowmde moved this task from incoming to Features/bugs for next release on the Wikibase-Quality-Constraints board. thiemowmde added a project: WMDE-QWERTY-Sprint-2020-10-21. TASK DETAIL https://phabricator.wikimedia.org/T265992 WORKBOARD https://phabricator.wikimedia.org/project/board/1202/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Lucas_Werkmeister_WMDE, Aklapper, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T265992: Argument 1 passed to ViolationMessageSerializer::serializeEntityId() must be an instance of EntityId, string given
thiemowmde claimed this task. thiemowmde added a project: Unplanned-Sprint-Work. thiemowmde set the point value for this task to "2". TASK DETAIL https://phabricator.wikimedia.org/T265992 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Lucas_Werkmeister_WMDE, Aklapper, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Scott_WUaS, Verdy_p, abian, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T122711: Appending ".json" to an entity url should work (Feature Request)
thiemowmde reopened this task as "Open". thiemowmde added a comment. With all the respect, but the task specifically asks to make https://www.wikidata.org/wiki/Q269728.json work. It might be that this is not something the Wikidata team want's to implement and maintain. If this is the case, the task needs to be declined, not closed as "resolved". TASK DETAIL https://phabricator.wikimedia.org/T122711 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Multichill, thiemowmde Cc: Diwanshu885, Nirmos, Ivanhercaz, Lea_Lacroix_WMDE, cscott, Lucas_Werkmeister_WMDE, thiemowmde, Multichill, hoo, HakanIST, Aklapper, Pengo, StudiesWorld, Rohitgeddam, Akuckartz, Soda, Chaytanya, darthmon_wmde, wiki-helenatxu, Nandana, Kieubinhtb, Tks4Fish, lucamauri, Mh-3110, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, JakeTheDeveloper, QZanden, LawExplorer, _jensen, rosalieper, xSavitar, Scott_WUaS, MuhammadShuaib, Tmalhotra, SimmeD, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T109420: [Story] Make exports formats more visible
thiemowmde reopened subtask T122711: Appending .json to an entity url should work (Feature Request) as Open. TASK DETAIL https://phabricator.wikimedia.org/T109420 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Ivanhercaz, Lucas_Werkmeister_WMDE, thiemowmde, Jan_Dittrich, Aklapper, Lydia_Pintscher, Rohitgeddam, Akuckartz, Soda, Chaytanya, darthmon_wmde, wiki-helenatxu, Dinadineke, DannyS712, Nandana, Kieubinhtb, Tks4Fish, lucamauri, Mh-3110, tabish.shaikh91, Asad_Ali_Palijo, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, merbst, LawExplorer, _jensen, rosalieper, xSavitar, Scott_WUaS, MuhammadShuaib, Tmalhotra, SimmeD, Wikidata-bugs, aude, TheDJ, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T169559: Imageheader Gadget at Wikidata - zoom of image
thiemowmde closed this task as "Invalid". thiemowmde added a comment. Given this is 3 years old and not much information was given in the first place (no examples, no screen resolution), I will be a bit bold and close this for now. This doesn't mean the gadget can't be improved. It certainly can. But how? I know there is already code in the gadget that can, for example, detect faces and properly center portraits on the face. Sure, this is far from perfect (how could it), but often good enough. TASK DETAIL https://phabricator.wikimedia.org/T169559 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: PokestarFan, thiemowmde, Lydia_Pintscher, Jonas, TerraCodes, Sjoerddebruin, Aklapper, Esc3300, Akuckartz, darthmon_wmde, Dinadineke, DannyS712, Nandana, tabish.shaikh91, Lahi, Gq86, GoranSMilovanovic, Soteriaspace, Jayprakash12345, JakeTheDeveloper, QZanden, dachary, merbst, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Ricordisamoa, Tacsipacsi, TheDJ, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field
thiemowmde added a comment. I might oversimplify this, but exposing the API endpoint should be possible like that: name=In SpecialMathWikibase.php $settings = WikibaseClient::getDefaultInstance()->getSettings(); $url = $settings->getSetting( 'repoUrl' ); $scriptPath = $settings->getSetting( 'repoScriptPath' ); $this->getOutput()->addJsConfigVars( 'repoApiUrl', $url . $scriptPath . '/api.php' ); name=In ext.math.wikibase.js var repoApiUrl = mw.config.get( 'repoApiUrl' ); For the language, the code currently uses `mw.config.get( 'wgContentLanguage' )`. I think this is fine. It's what I would do as well. TASK DETAIL https://phabricator.wikimedia.org/T229939 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Physikerwelt, thiemowmde Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, MaxSem, thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, Akuckartz, darthmon_wmde, Nandana, Hagarshilo, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field
thiemowmde added a comment. @Physikerwelt, sorry for not responding earlier. My advice is: don't use jquery.wikibase.entityselector. Write your own code, ideally based on OOUI, not jQuery. Seriously. It's your code then, and it does exactly what you want, which isn't that much. The existing entityselector code appears complicated, but it really doesn't do much. All it essentially does is querying the wbsearchentities API. There is a bit of caching on top, and a lot of configuration you probably don't need. The probably only configuration you need is the address of the API, because you want to query the Wikidata server from e.g. the English Wikipedia. On wikis with WikibaseRepo enabled this is exposed to JavaScript as part of the `wbRepo` configuration, see \Wikibase\Lib\Modules\RepoAccessModule. You might need to expose this configuration yourself on your special page (but only on the special page). This can be done directly in the special page's class using e.g. \ResourceLoader::makeConfigSetScript(). TASK DETAIL https://phabricator.wikimedia.org/T229939 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Physikerwelt, thiemowmde Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, MaxSem, thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, Akuckartz, darthmon_wmde, Nandana, Hagarshilo, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T229939: Use wikidata entity selector in OOUI input field
thiemowmde added a comment. As far as I understand the issue is that whatever method you choose to load a module, it only works when the module is //known//, i.e. it is registered in the extension registration. The `jquery.wikibase.entityselector` module is part of WikibaseView. I had a closer look, and the official way to load it is currently via `wfLoadExtension( 'extension-repo.json" )`, i.e. it is loaded together with the WikibaseRepo extension registration. Is WikibaseRepo loaded every time the Math code that needs the module runs? According to https://en.wikipedia.org/wiki/Special:Version it is not – and probably shouldn't. One possibly way forward is to move the module from WikibaseRepo to WikibaseClient. I'm not sure how hard this is, because everything it depends on would need to move as well. Another way forward might be to extract the module into an entirely separate codebase with it's own extension registration. TASK DETAIL https://phabricator.wikimedia.org/T229939 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Liuxinyu970226, Ladsgroup, Lucas_Werkmeister_WMDE, hoo, Aklapper, Framawiki, MaxSem, thiemowmde, Tgr, cscott, Niedzielski, Esanders, Physikerwelt, Andreg-p, Akuckartz, darthmon_wmde, Nandana, Hagarshilo, Lahi, Gq86, GoranSMilovanovic, Maosef, QZanden, LawExplorer, Debenben, _jensen, rosalieper, xSavitar, Scott_WUaS, Izno, ferdbold, Wikidata-bugs, aude, fredw, Pkra, Gryllida, Ricordisamoa, scfc, Jdforrester-WMF, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T259783: LanguageFallbackChain does not end in 'en'
thiemowmde added a comment. I believe this caused both T259744 <https://phabricator.wikimedia.org/T259744> and T259745 <https://phabricator.wikimedia.org/T259745>. I already created T259779 <https://phabricator.wikimedia.org/T259779> where I describe an idea that is a little different from "should always and in en". One of the two tickets might be a duplicate now. TASK DETAIL https://phabricator.wikimedia.org/T259783 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Addshore, thiemowmde, Lydia_Pintscher, Pablo-WMDE, Aklapper, Michael, Akuckartz, darthmon_wmde, Nandana, jijiki, Klaas_Z4us_V, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, elukey, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't
thiemowmde added a comment. T259744#6364309 <https://phabricator.wikimedia.org/T259744#6364309> mentions the patch that changed the behavior of the factory. It's now possible that language chains can be empty when the interface language is not a valid term language. There are a few language codes that are intentionally excluded from being term languages, e.g. "en-simple". One possible fix is to make sure all these invalid term languages fall back to a valid one when FALLBACK_SELF (or FALLBACK_ALL) is specified. For example, "en-simple" falls back to "en". At the moment, this exclude-list is hard-coded in WikibaseContentLanguages <https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/WikibaseContentLanguages.php$169>. Fallbacks are available via core, e.g. the official fallback for "de-formal" <https://phabricator.wikimedia.org/source/mediawiki/browse/master/languages/messages/MessagesDe_formal.php> is "de". TASK DETAIL https://phabricator.wikimedia.org/T259779 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, hoo, liangent, brennen, Ammarpad, Umherirrender, Michael, Cparle, thiemowmde, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Ricordisamoa, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T259744: Argument 3 passed to CachingFallbackLabelDescriptionLookup::buildCacheKey() must be of the type string, null given
thiemowmde added a comment. This is actually the exact same root cause as in T259745 <https://phabricator.wikimedia.org/T259745>: The language fallback chain in question is empty, and calling `$languageCode = $languageCodes[0]` on an empty array results in the language code being null. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608628 is indeed what caused this, specifically https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608628/13/lib/includes/TermLanguageFallbackChain.php. I created T259779 <https://phabricator.wikimedia.org/T259779> to keep track of the common root cause. TASK DETAIL https://phabricator.wikimedia.org/T259744 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Agusbou2015, toan, Ladsgroup, Addshore, Pablo-WMDE, Michael, Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, SundanceRaphael, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, alex-mashin, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, jayvdb, MrStradivarius, Lydia_Pintscher, Anomie, Jdforrester-WMF, Jackmcbarn, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed
thiemowmde added subscribers: Umherirrender, thiemowmde. thiemowmde added a comment. The problematic `...` was added in patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseMediaInfo/+/538388 (T224772 <https://phabricator.wikimedia.org/T224772>) by @Umherirrender 10 months ago. I think I understand why: I believe Phan gets confused by how the called `\OOUI\Tag::appendContent()` method is documented. The method accepts any number of `string`, `\OOUI\Tag`, or `\OOUI\HtmlSnippet` in whatever combination and order, either as an array or as a list of parameters. So the documentation would need to say something like `string|Tag|HtmlSnippet|(string|Tag|HtmlSnippet)[]`, but talks about a generic `array` instead. Note that while adding the `...` slightly changed the semantics (while an array can be empty, a list of parameters can not), this was not a mistake! According to the documentation of getLanguagesOrderedByFallbackChain() it can never return an empty array, so getCaptionsContent() can never be an empty array as well. I believe there is another bug that makes these methods return empty arrays. I created T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't <https://phabricator.wikimedia.org/T259779> to keep track of this. TASK DETAIL https://phabricator.wikimedia.org/T259745 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Ammarpad, thiemowmde Cc: thiemowmde, Umherirrender, Agusbou2015, Catrope, Aklapper, brennen, CBogen, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Ramsey-WMF, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Jonas, Ixocactus, Wong128hk, Wikidata-bugs, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Lydia_Pintscher, Jdforrester-WMF, Steinsplitter, Mbch331, Rxy, Jay8g, Krenair, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T259779: LanguageFallbackChainFactory returns empty fallback chain when it shouldn't
thiemowmde created this task. thiemowmde added projects: WikibaseMediaInfo, Wikidata, Wikimedia-production-error. Restricted Application added a subscriber: Aklapper. TASK DESCRIPTION While working on a hot-fix for T259745: Uncaught ArgumentCountError: Too few arguments to function OOUI\Tag::appendContent(), 0 passed <https://phabricator.wikimedia.org/T259745> I realized the #wikimedia-production-error <https://phabricator.wikimedia.org/tag/wikimedia-production-error/> probably hints at //another// bug. This is the code that failed: $layout->appendContent( ...$this->getCaptionsContent( $entity->getLabels(), $this->getLanguagesOrderedByFallbackChain( $entity ) ) ); Since appendContent() requires at least one argument, it fails when getCaptionsContent() returns an empty array. But wait, how is this possible? getLanguagesOrderedByFallbackChain() is documented to return at least the interface language. So it should be impossible that getCaptionsContent() returns nothing. How can the interface language get lost? The LanguageFallbackChain in question is created in WikibaseMediaInfoHooks::createEmptyStructuredData() <https://phabricator.wikimedia.org/diffusion/EWBI/browse/master/src/WikibaseMediaInfoHooks.php$521> with no $mode flag set, which means it should default to FALLBACK_ALL when LanguageFallbackChainFactory::newFromLanguage() <https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/LanguageFallbackChainFactory.php$67> is called. That //should// always include the original language in the result – but the code path is not obvious. I guess the task is to find out what's going on here, under which circumstances this LanguageFallbackChain can be empty, or add tracking code for this edge-case and monitor this potential bug further. TASK DETAIL https://phabricator.wikimedia.org/T259779 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, hoo, liangent, brennen, Ammarpad, Umherirrender, Michael, Cparle, thiemowmde, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Ricordisamoa, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T239208: Lexemes: Grammatical form can render as `[object Object]`
thiemowmde added a comment.
I was working on T249167 <https://phabricator.wikimedia.org/T249167> and
T258337 <https://phabricator.wikimedia.org/T258337> and found what causes this:
Never call `setLabel()` with anything but plain text. When you want a more
complex HTML label, do it like this:
new OO.ui.…Widget( {
label: 'Plain text',
$label: $( '' ).attr( { 'href': '…' } ),
} );
Or like this:
// This is exactly what the LabelElement constructor does
widget.setLabel( 'Plain text' );
widget.setLabelElement( $( '' ).attr( { 'href': '…' } ) );
In both cases the plain text label and the HTML element that wraps the text
are passed in separately.
This is a workaround that avoids any of the broken code in `setLabel()`.
TASK DETAIL
https://phabricator.wikimedia.org/T239208
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: thiemowmde
Cc: thiemowmde, Nikki, DannyS712, Akuckartz, darthmon_wmde, Nandana,
Mringgaard, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen,
rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Updated] T253624: Evaluate the future of wikibase-codesniffer
thiemowmde added a comment. Related tickets: - In T243296#5820465 <https://phabricator.wikimedia.org/T243296#5820465> we briefly talked about the past and future of the custom Wikibase CodeSniffer already. - Via T164653 <https://phabricator.wikimedia.org/T164653> some of the customizations got merged into the upstream #mediawiki-codesniffer <https://phabricator.wikimedia.org/tag/mediawiki-codesniffer/> already. Back in 2017 I had multiple reasons to push for a custom rule set. Many of them are not valid any more: - Back then none of the Wikibase codebases on GitHub <https://github.com/wmde?q=wikibase> used the upstream MediaWiki rule set, but custom `phpcs.xml`, each heavily different (example <https://github.com/wmde/WikibaseDataModel/blob/e55e9a1a8800981fa19312f787bd34d2765d5246/phpcs.xml>). This was partly because one of the original developers disagreed with parts of the MediaWiki style guide. Introducing the Wikibase rule set was a way to first replace these different `phpcs.xml` with an accepted standard, and then slowly migrate towards the upstream standard. - It was a place where I was free to play around with custom rules, without having to convince people outside of the Wikidata team. - It allowed to introduce much stricter rules that won't be accepted upstream. - I realized that all Wikibase codebases excluded the same upstream sniffs that conflicted with the code style the Wikidata team agreed on. These exclusions are all documented and reasoned here: https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml - I wanted to have a single place that allows to update all codebases at once. This didn't worked out great. This is mostly because the MediaWiki CodeSniffer project got much, much more active and pushed out releases much faster. Keeping up with this is expensive, and might not be worth it at all. Because of this I removed the Wiklibase CodeSniffer from many codebases already <https://gerrit.wikimedia.org/r/#/q/author:thiemo+is:merged+%22mediawiki+codesniffer%22>. Reviewing some individual customizations: - I believe Wikibase.Commenting.DisallowedDocTags <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/Sniffs/Commenting/DisallowedDocTagsSniff.php> might be mostly obsolete via MediaWiki.Commenting.FunctionAnnotations <https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/Sniffs/Commenting/FunctionAnnotationsSniff.php>. It's a very different sniff, but might cover everything that matters. - Wikibase.Namespaces.UnnecessaryUse <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/Sniffs/Namespaces/UnnecessaryUseSniff.php> as well as Wikibase.Namespaces.UnusedUse <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/Sniffs/Namespaces/UnusedUseSniff.php> should be obsolete via MediaWiki.Classes.UnusedUseStatement <https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/Sniffs/Classes/UnusedUseStatementSniff.php>. - Wikibase.Usage.InArrayUsage <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/Sniffs/Usage/InArrayUsageSniff.php> is obsolete via MediaWiki.Usage.InArrayUsage <https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/Sniffs/Usage/InArrayUsageSniff.php>. This leaves only a few things: - Wikibase.Commenting.ClassLevelDocumentation <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/Sniffs/Commenting/ClassLevelDocumentationSniff.php> might be acceptable upstream when it's disabled by default. I will try to do this <https://gerrit.wikimedia.org/r/603495>. Until then, the Wikidata team might be fine with temporarily loosing this sniff. - Wikibase.Commenting.RedundantVarName <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/Sniffs/Commenting/RedundantVarNameSniff.php> is already upstream <https://gerrit.wikimedia.org/r/603493>. - Wikibase.Namespaces.FullQualifiedClassName <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/Sniffs/Namespaces/FullQualifiedClassNameSniff.php> might as well be acceptable upstream if the sniff doesn't do anything by default. I will try to do this as well <https://gerrit.wikimedia.org/r/603496>. The Wikidata team might be fine with temporarily loosing this sniff. It's still possible to look for this in code reviews. Or just be fine with full qualified class names being used without a `use`. - The exclusions and additions <https://github.com/wmde/WikibaseCodeSniffer/blob/master/Wikibase/ruleset.xml> are not lost. The Wikidata team just needs to repeat them in every codebase. That should be fine, I believe. It might even be reasonable to stop excluding some of these, which is something the team can then decide per codebase. **TL;DR:** I suggest
[Wikidata-bugs] [Maniphest] [Updated] T255319: Eventually deprecate SkinTemplateNavigation::SpecialPage and SkinTemplateNavigation hooks in favor of SkinTemplateNavigation::Universal
thiemowmde removed a project: Move-Files-To-Commons. TASK DETAIL https://phabricator.wikimedia.org/T255319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Aklapper, Krinkle, Ammarpad, Jdlrobson, Blissjay007, Oblanco79, Llanddewi, Alter-paule, NavinRizwi, Beast1978, Un1tY, Akuckartz, keithbrianpadilla, Demian, Dzaky17, dlo, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Tombolano, Saimongoltinio, WikimeSteve, abi_, Kent7301, pdehaye, ppelberg, BryghtShadow, Meekrab2012, joker88john, Kfield, 94rain, DannyS712, CucyNoiD, Nandana, Lens0021, NebulousIris, JamesDriscoll, Schtom, ElanHR, marcella, Tumz24, kostajh, Gaboe420, Revansx, aoxomoxoa, Jony, Pwirth, Mmiller0712, OhKayeSierra, Versusxo, Bhaskargoyal24, Majesticalreaper22, priyanshu_varshney, Amorymeltzer, Giuliamocci, AbhinavKhare, Nikhil-nk, lakshay234, 2angelic1, Adrian1985, Apoorv07, Cpaulf30, AkinkuotuFunmi, takidelfin, Lahi, Himanshuc3, Gq86, Af420, Xinbenlv, Necroarcano, Darkminds3113, SapphieWillie, Bsandipan, Lordiis, Devi59, Robinma, Xover, Andrawaag, GoranSMilovanovic, Fz-29, Kamsuri5, The-Gradient, Adik2382, 45Jayjay1969, Chicocvenancio, Nakohdo, Jonathan3, Th3d3v1ls, Ramalepe, Liugev6, QZanden, Xephyr826, YULdigitalpreservation, Nicolas_NALLET, EnricoCNC, merbst, LawExplorer, spatton, EHCliffe, Snowwh1th3, Salgo60, WSH1906, Lewizho99, Maathavan, Wess, Kc5vcx, Tshrinivasan, SteffenFelix, _jensen, Jseddon, rosalieper, Mkdw, XanonymusX, Taiwania_Justo, shinjiman, gabriel-wmde, Scott_WUaS, Srdjan_m, Cirdan, Info-farmer, c.holtermann, RHeigl, Samwilson, DStrine, SBisson, Lmorillas, Vedmaka, MisterSynergy, RichardHeigl, Oetterer, Aschroet, Jrf, Husun1297, abian, Zache, Wikidata-bugs, Yaron_Koren, Base, Tinaj1234, aude, Candalua, AndyRussG, Pcoombe, Jongfeli, Bawolff, QuimGil, Dinoguy1000, Gryllida, jeblad, Harej, brion, Swainr, fbstj, Prtksxna, Catrope, Lydia_Pintscher, 01tonythomas, Tpt, Nikerabbit, KartikMistry, Isarra, He7d3r, TheDJ, Jackmcbarn, Mbch331, Jay8g, ashley, Legoktm, Shliilh65, JJMC89, WMDE-Fisch ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T252803: AffectedPagesFinder: Call to a member function exists() on null
thiemowmde added a comment. This is caused by https://gerrit.wikimedia.org/r/594610, merged 9 days ago. Wikibase had a custom TitleFactory that was introduced very early, in 2014, see https://gerrit.wikimedia.org/r/168579. The duplicate in core was introduced very late, in 2019, see https://gerrit.wikimedia.org/r/543918. It looks like the duplicate in core was created from scratch, not being aware of the one in Wikibase. This might be why the two behave slightly different. The newer one returns null in a few more cases, where the old one was throwing exceptions. I checked all callers and fixed them in https://gerrit.wikimedia.org/r/596543. This was clearly a mistake when reviewing https://gerrit.wikimedia.org/r/596543 (which I was involved in ), plus there was obviously not a single test case triggering any of these code paths. I hope we don't need to revert the change, but can backport the much smaller fix. TASK DETAIL https://phabricator.wikimedia.org/T252803 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, DannyS712, Liuxinyu970226, hashar, Aklapper, Blissjay007, Oblanco79, Alter-paule, Beast1978, Un1tY, Hook696, Daryl-TTMG, RomaAmorRoma, E.S.A-Sheild, darthmon_wmde, Kent7301, Meekrab2012, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, lucamauri, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T214300: Square brackets not allowed in URLs on Wikidata
thiemowmde added a comment. Yes, I believe so. Short answer: It's not Wikibase, it's MediaWiki. https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/repo/includes/Validators/UrlSchemeValidators.php$53 https://phabricator.wikimedia.org/source/mediawiki/browse/master/includes/parser/Parser.php$95 As of now, Wikibase intentionally blacklists the same characters in URLs that are also blacklisted when using URLs in wikitext. The reason square brackets are blacklisted is MediaWiki's URL syntax: `[http://example.com label]`. Prominent help pages like https://en.wikipedia.org/wiki/Help:URL explain how to work around this limitation: replace `[` and `]` with `%5B` and `%5D`. Since what is stored in the Wikibase database is not wikitext, it would be possible to lift this limitation – in theory. We could even allow whitespace, for example. However, this requires us to encode these characters when the value is used. And that might be the main problem: we don't own most of the code that consumes Wikibase data. Allowing square brackets might result in 3rd party tools outputting broken wikitext. The formatters Wikibase itself provides could be updated to support a larger character set: https://phabricator.wikimedia.org/diffusion/EWBA/browse/master/lib/includes/Formatters/WikibaseValueFormatterBuilders.php$328 There is a StringFormatter in this code that does **not** do any escaping (denoted with a comment). This would need to be replaced with a formatter that escapes just the right characters, just the right way, to result in an URL the MediaWiki parser can understand. In theory, this means replacing all characters that are blacklisted in the MediaWiki parser with their `%…` hex escape sequence. However, I'm not sure if this can safely be done in all cases. It might as well result in broken URLs. Unfortunately, most consumers don't use the Wikibase fomatters. TASK DETAIL https://phabricator.wikimedia.org/T214300 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Michael, Lydia_Pintscher, thiemowmde, Jc86035, Pigsonthewing, Aklapper, Biaoo, Philoserf, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, Hydriz, aude, Mbch331, Jay8g ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T92009: Support more fine-grained date fields than xsd:dateTime
thiemowmde added a comment. The question was: A lot of time values in the Wikidata database name a year only. Does it even make sense to export these as xsd:dateTime? Shouldn't we export these as xsd:gYear? TASK DETAIL https://phabricator.wikimedia.org/T92009 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: Gehel, thiemowmde, JanZerebecki, Aklapper, Smalyshev, darthmon_wmde, ET4Eva, Nandana, Lahi, Gq86, Darkminds3113, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, Avner, _jensen, rosalieper, Scott_WUaS, Jonas, FloNight, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T247458: PHP Notice: Undefined index: wgKartographerLiveData
thiemowmde added a comment. I do not know the involved CachingKartographerEmbeddingHandler class in Wikibase very well. But according to what I see in https://codesearch.wmflabs.org/search/?q=wgKartographerLiveData I suspect that: 1. I believe this is **not** a serious issue. Just a notice. The missing variable is cast to an empty array. From there, I believe all following code is fine with an empty array. 2. The root cause appears to be a mismatch between the code in the Kartographer extension where the variable is created, and the code in Wikibase that consumes it. Note that the variable is only created under specific circumstances, but Wikibase **always** expects it. Just a few lines below in the same class is a check that creates the variable in case it is missing. https://gerrit.wikimedia.org/g/mediawiki/extensions/Wikibase/+/master/lib/includes/Formatters/CachingKartographerEmbeddingHandler.php#174 But this line is in JavaScript. It appears like the same check needs to be done in PHP. TASK DETAIL https://phabricator.wikimedia.org/T247458 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: thiemowmde Cc: thiemowmde, Agusbou2015, Krinkle, Aklapper, brennen, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T245629: mediawiki/core webdriver.io tests fail in EntitySchema extension
thiemowmde added a comment. When someone is able and willing to identify the original issue, we can undo code changes that are not needed any more then. As long as this is not the case let us please, please unblock people from working on these codebases. TASK DETAIL https://phabricator.wikimedia.org/T245629 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: nnikkhoui, thiemowmde Cc: Peter.ovchyn, Umherirrender, thiemowmde, Jdforrester-WMF, Legoktm, Krinkle, Addshore, Daimona, Aklapper, Lucas_Werkmeister_WMDE, darthmon_wmde, pdehaye, DannyS712, Nandana, Lahi, Gq86, Andrawaag, Pablo-WMDE, GoranSMilovanovic, Jayprakash12345, QZanden, YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, Jonas, MGChecker, MisterSynergy, abian, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Rxy, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
