[Wikidata-bugs] [Maniphest] T307319: Design System Codex / Wikit
AnneT closed subtask T309239: Add Field component to Codex as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T307319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAbad, AnneT Cc: Sarai-WMDE, AOdit_WMF, elal, Michael, Abbe98, ItamarWMDE, DAbad, SWakiyama, Aklapper, Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Shizhao, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T307319: Design System Codex / Wikit
AnneT closed subtask T309246: Label: Add Label component to Codex as Resolved. TASK DETAIL https://phabricator.wikimedia.org/T307319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAbad, AnneT Cc: Sarai-WMDE, AOdit_WMF, elal, Michael, Abbe98, ItamarWMDE, DAbad, SWakiyama, Aklapper, Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Shizhao, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T327510: Vector Search: Adjust bolding pattern of suggestions in Wikidata
AnneT added a subscriber: Jdlrobson. AnneT added a comment. Hi @noarave! I think this will require a change in that Vector code that you linked, so that it first checks if `highlightQuery` is set in the `VectorWvuiSearchOptions` config variable. If so, it should respect that value, and if not, it can do what it currently does. Perhaps this should be captured in a separate task? cc @Jdlrobson TASK DETAIL https://phabricator.wikimedia.org/T327510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, AnneT Cc: Jdlrobson, AnneT, Lydia_Pintscher, Michael, Sarai-WMDE, Arian_Bozorg, Aklapper, Isabelladantes1983, Themindcoder, Adamm71, JCW555, hnijhuis, Jersione, Hellket777, NHillard-WMF, LisafBia6531, Astuthiodit_1, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T307319: Design System Codex / Wikit
AnneT changed the status of subtask T309246: Label: Add Label component or composable to Codex from Open to In Progress. TASK DETAIL https://phabricator.wikimedia.org/T307319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAbad, AnneT Cc: Sarai-WMDE, AOdit_WMF, elal, Michael, Abbe98, ItamarWMDE, DAbad, SWakiyama, Aklapper, Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Shizhao, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T307319: Design System Codex / Wikit
AnneT changed the status of subtask T309239: Add Field component to Codex from Open to In Progress. TASK DETAIL https://phabricator.wikimedia.org/T307319 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: DAbad, AnneT Cc: Sarai-WMDE, AOdit_WMF, elal, Michael, Abbe98, ItamarWMDE, DAbad, SWakiyama, Aklapper, Astuthiodit_1, STH, karapayneWMDE, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Shizhao, Lydia_Pintscher, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T327510: Vector Search: Adjust bolding pattern of suggestions in Wikidata
AnneT added a comment. Search query highlighting behavior can be turned off via the `highlightQuery` prop, which is a boolean prop of both CdxTypeaheadSearch and the Vector search app. Currently, in Vector, `highlightQuery` is set to `true` or `false` based on the UI language and whether words can safely be split to highlight the search query in that language. To turn this off for Wikidata, some logic would need to be added there to also allow this to be configured via a config variable. TASK DETAIL https://phabricator.wikimedia.org/T327510 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: AnneT, Lydia_Pintscher, Michael, Sarai-WMDE, Arian_Bozorg, Aklapper, Dominika_Naumiuk, JCW555, hnijhuis, NHillard-WMF, Astuthiodit_1, STH, Patafisik_WMF, karapayneWMDE, Invadibot, Selby, Universal_Omega, maantietaja, ItamarWMDE, Akuckartz, Demian, DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT moved this task from Design Sign-Off to QTE Sign-off on the Design-Systems-Team (Design-Systems-Sprint) board. AnneT reassigned this task from Volker_E to EUdoh-WMF. TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD https://phabricator.wikimedia.org/project/board/5859/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, AnneT Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard
AnneT added a comment. @Lucas_Werkmeister_WMDE FYI we've just merged the new release of Codex into core, which includes your change <https://gerrit.wikimedia.org/r/c/design/codex/+/854049> and will ride the train next week! TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: mpopov, cchen, EBernhardson, ItamarWMDE, dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael, Lucas_Werkmeister_WMDE, phuedx, Adamm71, hnijhuis, Jersione, Hellket777, NHillard-WMF, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, MPhamWMF, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, CBogen, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard
AnneT added a comment. @Lucas_Werkmeister_WMDE our next scheduled Codex release is Tuesday, November 22nd, so it would ride the train the following week. Is that acceptable, or is this needed sooner? TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: mpopov, cchen, EBernhardson, ItamarWMDE, dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael, Lucas_Werkmeister_WMDE, phuedx, Adamm71, hnijhuis, Jersione, Hellket777, NHillard-WMF, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, Patafisik_WMF, karapayneWMDE, Invadibot, MPhamWMF, Selby, Universal_Omega, maantietaja, Juan90264, Alter-paule, NavinRizwi, Beast1978, CBogen, Un1tY, Akuckartz, Demian, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, EBjune, LawExplorer, Lewizho99, JJMC89, Maathavan, Iniquity, _jensen, rosalieper, Agabi10, Neuronton, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT added a comment. @Volker_E can we move forward with this patch <https://gerrit.wikimedia.org/r/c/design/codex/+/850261> and accept that we will not make a similar change in OOUI, per the previous comments? TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, AnneT Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT added a comment. Could we accept such a slight divergence between Codex and OOUI? I would hate to hold back Codex because of the old system, and I'm not convinced that both versions must be completely in sync, especially when it comes to a single-pixel difference. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, AnneT Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Adamm71, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT added a comment. cc @Sarai-WMDE on the message above ^ if you have a second, could you please confirm if this is the correct style now, especially for TypeaheadSearch? I had thought there was supposed to be a -1px margin-top on the menu, but it seems like that's not indicated in the designs. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, AnneT Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT added a comment. @EUdoh-WMF @bmartinezcalvo I've opened a patch that I think should resolve all of those things, although the bug that happens in Chrome at 175% zoom is still a bit of an issue. Check it out here <https://850261--wikimedia-codex.netlify.app/components/demos/menu.html>. The 175% bug, where you can see a tiny bit of the underlying text, is probably an unfortunate rendering thing in Chrome. The calculations for the Menu border and height are correct, and everything looks right at other zooms and in other browsers, so like Bárbara said, I don't think we should spend time trying to cater to this. The patch resolves these issues by removing the -1px border-top that used to be added to the menu element. The designs show the input and menu sitting next to each other with no overlap, so that's what I've tried to achieve here. Please be sure to test all components that have menus (Combobox, Lookup, Select, and TypeaheadSearch). TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: EUdoh-WMF, AnneT Cc: SaraiSan, EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, AnneT Cc: EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT added a subscriber: EUdoh-WMF. AnneT added a comment. @Sarai-WMDE and @EUdoh-WMF, you can test this new functionality via the "menu with scroll enabled" demo <https://doc.wikimedia.org/codex/main/components/demos/menu.html#menu-with-scrolling-enabled> on the docs site. No other demos should be affected since the default behavior is to show all menu items at once. TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, AnneT Cc: EUdoh-WMF, NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT added a comment. In T306932#8256431 <https://phabricator.wikimedia.org/T306932#8256431>, @Sarai-WMDE wrote: > Tiniest nitpick about the demo, but the width of the input to enter the number of visible items should be increased, so it can take two digits: > On the other hand, it'd be great if the label and the input were aligned in the center of their flex container @Sarai-WMDE I've included both of these changes in the latest patch! TASK DETAIL https://phabricator.wikimedia.org/T306932 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, AnneT Cc: NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT moved this task from Code Review to Design Sign-Off on the Design-Systems-Team (Design-Systems-Sprint) board. AnneT assigned this task to Sarai-WMDE. TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD https://phabricator.wikimedia.org/project/board/5859/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Sarai-WMDE, AnneT Cc: NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard
AnneT added a comment. > tracking these as a submit event instead of a click also seems a bug +1, thanks for weighing in! TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael, Lucas_Werkmeister_WMDE, phuedx, hnijhuis, NHillard-WMF, Astuthiodit_1, STH, Patafisik_WMF, karapayneWMDE, Invadibot, MPhamWMF, Selby, Universal_Omega, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, Demian, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, EBjune, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T317682: Make new Vector search navigate to search result URL when selecting search result using keyboard
AnneT added a comment. We could potentially fix this by updating the `onSubmit()` handler in CdxTypeaheadSearch to check if there is a currently highlighted item and, if so, do the following: - `preventDefault()` on the submit event - run the `onSearchResultClick()` method to emit the proper data for instrumentation - navigate to the highlighted item's URL - return We might even be able to bypass all of this via some key modifiers on the menu item links in the template, but I haven't looked into that yet. Would this be acceptable from the Web team's standpoint, given that the form would no longer be submitted under this circumstance, and a different event would be emitted (`search-result-click` instead of `submit`)? TASK DETAIL https://phabricator.wikimedia.org/T317682 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: dcausse, Gehel, Jdlrobson, Catrope, AnneT, jhsoby, Aklapper, Michael, Lucas_Werkmeister_WMDE, phuedx, hnijhuis, VirginiaPoundstone, NHillard-WMF, Astuthiodit_1, STH, Patafisik_WMF, karapayneWMDE, Invadibot, MPhamWMF, Selby, Universal_Omega, maantietaja, NavinRizwi, CBogen, ItamarWMDE, Akuckartz, Demian, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, EBjune, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T317681: Make new Vector search navigate to item search results on Wikidata
AnneT added subscribers: Jdlrobson, AnneT. AnneT added a comment. @Jdlrobson Could you provide some background on why the URL for a search result goes through Special:Search, rather than linking directly to the page? If we could make linking directly to the page the default behavior for search results, this would be one less customization needed for wikidata, but I'm assuming there's a reason it was set up this way. TASK DETAIL https://phabricator.wikimedia.org/T317681 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: AnneT, Jdlrobson, Michael, Aklapper, jhsoby, Lucas_Werkmeister_WMDE, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, NavinRizwi, ItamarWMDE, Akuckartz, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Dinoguy1000, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T306932: Add configurable scroll behavior to the Menu component
AnneT moved this task from Ready for Design to In Development on the Design-Systems-Team (Design-Systems-Sprint) board. AnneT changed the task status from "Open" to "In Progress". TASK DETAIL https://phabricator.wikimedia.org/T306932 WORKBOARD https://phabricator.wikimedia.org/project/board/5859/ EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: NHillard-WMF, Catrope, DAbad, ldelench_wmf, Sarai-WMDE, Erdinc_Ciftci_WMDE, Michael, Aklapper, bmartinezcalvo, Volker_E, AnneT, Jersione, VirginiaPoundstone, Hellket777, LisafBia6531, Astuthiodit_1, STH, 786, Biggs657, karapayneWMDE, Invadibot, Manishagoenka, maantietaja, Juan90264, Alter-paule, Beast1978, cristiana023, ItamarWMDE, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, JGirault, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T305091: [TypeaheadSearch] Support lang and dir attributes for text nodes within MenuItem component
AnneT removed AnneT as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, Sarai-WMDE, Aklapper, STH, AnneT, Michael, NHillard-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T305091: [TypeaheadSearch] Support lang and dir attributes for text nodes within MenuItem component
AnneT updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Ladsgroup, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, Sarai-WMDE, Aklapper, STHart, AnneT, Michael, NHillard-WMF, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, ItamarWMDE, Akuckartz, DannyS712, Nandana, Lahi, Gq86, Xover, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Volker_E, Wikidata-bugs, aude, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T305091: Support lang and dir attributes for text nodes within MenuItem component
AnneT added a comment. Thanks, everyone, for your thoughtful comments, examples, and suggestions! I think we should move forward with keeping all menu items justified according to the interface direction, given the feedback here. We can always reevaluate if we get more feedback from RTL readers. In terms of mixed directionality, the screenshot @Michael posted is fairly close to what will happen if we wrap the label, match, and description in `` tags. One minor difference is that, in the Wikidata example, the label's language is added as an attribute to an element that wraps both the label and the match, so there's no differentiation there. You can see this with the "Liebfrauenkirche" result. This label comes back with the language code `en` (presumably because this is the label's value in English and English is a fallback for Farsi while German is not), so the whole line is wrapped in an element with `lang="en"` and is therefore all readable left-to-right: F35040242: image.png <https://phabricator.wikimedia.org/F35040242> However, in this screenshot of the Codex TypeaheadSearch component, you can see that the label and match maintain the same order no matter what the languages are, so they arguably appear "backward" for this specific item: F35040209: Screen Shot 2022-04-05 at 4.00.55 PM.png <https://phabricator.wikimedia.org/F35040209> I suppose we could check to see if the language and match have the same lang code, and wrap them together if that's true. But you could also argue that the consistency of the current state is better. I've updated the patch associated with this task to include `` tags around each piece of text within a Menuitem. Please let me know if you have further feedback, either here or in the patch! TASK DETAIL https://phabricator.wikimedia.org/T305091 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Lucas_Werkmeister_WMDE, Lydia_Pintscher, Catrope, Mooeypoo, bmartinezcalvo, Sarai-WMDE, Aklapper, STHart, AnneT, Michael, Fernandobacasegua34, Astuthiodit_1, 786, Suran38, Biggs657, karapayneWMDE, Invadibot, Lalamarie69, R4356th, maantietaja, Juan90264, Alter-paule, Beast1978, ItamarWMDE, Un1tY, Akuckartz, Demian, Hook696, darthmon_wmde, Kent7301, egardner, holger.knust, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, NatHillard, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, Xover, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Neuronton, Scott_WUaS, Volker_E, Niedzielski, Wikidata-bugs, Jdlrobson, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction
AnneT added a comment. Thank you, @Sarai-WMDE, for your thorough response! It's really helpful to learn from your experience with design tokens in WiKit so far. I have some remaining questions/thoughts about one topic, but everything else seems clear to me. > This all sounds about right, but I would encourage the DST to prevent the creation of said single "component tokens" as much as possible. Meaning: Wikimedia UI base (or whichever token solution is built from it, T288383 <https://phabricator.wikimedia.org/T288383>) should ideally anticipate and provide an exhaustive and organized list of the available, premade design decisions that communicate intent and can be used with as many components as possible, all in order to centralize and propagate the system's source of truth. This makes sense, although it's something I didn't fully understand about the design token architecture proposal until now. Single-component-specific variables are used widely in OOUI and WVUI in the name of theming (something that actually exists in OOUI, and could potentially exist in WVUI). I was thinking the design token architecture would apply to these variables, too, but perhaps it would be more accurate to say that we will try to expand WikimediaUI base with more tokens that come from design decisions and can be used by components, but that we will keep single-component variables separate. All in all, I think I will be able to best understand this whole process once we start experimenting with it! I hope we can do this within the shared library as soon as possible. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E, Invadibot, caldera, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Niedzielski, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction
AnneT added a comment. Another practical question: when does a variable become a design token? This is the process I've been following: 1. Is it a simple keyword, like `display: flex`? If so, probably don't use a token, unless it's something that gets repeated a lot like the value of `cursor: disabled` 2. Is it a simple value, like `width: 100%` or `margin: 0`? If so, probably don't use a token 3. Is there an existing token in Wikimedia UI base whose name makes semantic sense for this component-specific use? e.g. `border-color: @border-color-base`? If so, just use the Wikimedia UI base token 4. Is there an existing token in Wikimedia UI base but the name doesn't make semantic sense for this component-specific use, like `background-color: @color-primary--active` or `border-color: @wmui-color-base20`? If so, create a new component-specific token 5. If none of these things are true, create a new component-specific token There's a lot of gray area in here, though, especially step 2. I looked through some WVUI components I've built and found some examples of values for which I did not create a token: - `outline: 1px solid transparent` - `content: ' '` - `top: 50%` - `border: @border-width-base @border-style-base transparent` - `transition: background-color @transition-base, border-color @transition-base, border-width @transition-base;` Those could all be debatable. The goal would be to take the debate out of it as much as possible with clear instructions on when one should create a token. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E, Invadibot, caldera, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Niedzielski, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction
AnneT added subscribers: Tonina_Zhelyazkova_WMDE, Catrope, egardner. AnneT added a comment. Some thoughts post-Designer summit: Designer-developer handoff -- This could use stronger definition. Is the designer creating tokens for some values in Figma? Will the designer and developer meet to discuss which tokens will likely be needed? Or will this happen during the development process? I ask because during our experimental WVUI development, we would identify component-specific tokens that were needed while building the component, since these values sometimes depend on the template and stylesheet structure (e.g. will it be a margin-left or a margin-right?) It's hard to imagine being able to accurately identify and name all tokens solely based on the design. Where do component-specific tokens live? Initially I thought they should live along with the component code in the shared library, but @Tonina_Zhelyazkova_WMDE brought up an excellent point that tokens should be technology-agnostic (e.g. what if someone needs the token and is building in OOUI rather than Vue?) So, they should probably live along with the base tokens in Wikimedia UI Base. However, if we have to add or update a token during development in the shared component library, we would have to update a separate repository, create a new release, then consume that new release. We have been following this process in WVUI development so far and it is quite inefficient. I would propose we consider a monorepo setup that includes the shared component library and WikimediaUI Base as separate but related exports to resolve this inefficiency. Token visualization --- From the development side, easy access to tokens during development is important. Right now, I have to open the Wikimedia UI Base file somewhere separate from where I'm working, which is inconvenient. I would propose doing something similar to what WMDE has done in WiKit to visualize design tokens within Storybook (which would be possible if we did the monorepo setup mentioned above). TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: egardner, Catrope, Tonina_Zhelyazkova_WMDE, Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E, Invadibot, caldera, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Niedzielski, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction
AnneT added a comment. Quick comment that's probably obvious, but from a developer standpoint, one thing I would prioritize is ease of use/visibility during development. Two concerns: - In MediaWiki extensions, we use a pretty manual process to include and update Wikimedia UI base, which must be set up per-extension - In WVUI (and any codebase that properly uses Wikimedia UI base as an npm module), it's easy to include and update the library, but difficult to view it. I have to open up the variable sheet elsewhere, or dig into node_modules TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E, Invadibot, caldera, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Niedzielski, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266688: Evaluate variables aka tokens abstraction
AnneT renamed this task from "Evaluate (and implement) variables aka tokens abstraction" to "Evaluate variables aka tokens abstraction". TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E, Invadibot, caldera, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Niedzielski, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T266688: Evaluate (and implement) variables aka tokens abstraction
AnneT added a parent task: T286951: Decide on CSS Architecture for shared component library. TASK DETAIL https://phabricator.wikimedia.org/T266688 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Jakob_WMDE, Michael, AnneT, Pginer-WMF, raja_wmde, ItamarWMDE, Sarai-WMDE, Aklapper, Volker_E, Invadibot, caldera, maantietaja, Akuckartz, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Iniquity, _jensen, rosalieper, JGirault, Scott_WUaS, Niedzielski, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g ___ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT added a comment. Thanks for your review, @Etonkovidova! (1) I think this task was created before the Other tab was a thing. I figured since it's a media tab, the license filter applies, but we should confirm this (@Ramsey-WMF?) (2) A patch to fix this was merged last week but didn't make it onto the train, so it should show up next year (3) Good find, I'll fix this ASAP! TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, AnneT Cc: Etonkovidova, Cparle, Nathank2, Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, GFontenelle_WMF, Muchiri124, Alter-paule, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT added a comment. I've tested the UI patch and confirmed it's working when pointing to production API endpoints. It's now ready for code review. TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, AnneT Cc: Cparle, Nathank2, Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, Muchiri124, Alter-paule, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT added a comment. Also wondering if we've missed some...I'm testing my patch locally and an image with the license Creative Commons Attribution-Share Alike 3.0 it <https://creativecommons.org/licenses/by-sa/3.0/it/deed.en> is popping up under "other" instead of share with attributtion/cc-by-sa. TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Cparle, AnneT Cc: Cparle, Nathank2, Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, Muchiri124, Alter-paule, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT removed Cparle as the assignee of this task. AnneT added a subscriber: Cparle. AnneT added a comment. I've updated the UI patch but will keep it labeled WIP until the license mapping config is in place. TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Cparle, Nathank2, Ramsey-WMF, kaldari, JeanFred, AnneT, dcausse, Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, Alter-paule, Beast1978, Un1tY, Nintendofan885, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT added a comment. @matthiasmullie any thoughts on getting around the search string character limit here? Now that I've rebased this patch onto the one that swaps out the search modules, I'm hitting the default limit of 300 characters for the cc-by and cc-by-sa filter options, and the "other" option is over the hard limit of 2048 (by about 150 characters, but this could always grow as more license items are added). TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, darthmon_wmde, Kent7301, joker88john, CucyNoiD, Nandana, JKSTNK, Gaboe420, Giuliamocci, Cpaulf30, Lahi, PDrouin-WMF, Gq86, Af420, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, Bsandipan, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Lewizho99, Maathavan, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, Akuckartz, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, Akuckartz, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] T257938: License type filter for media search
AnneT added a parent task: T256160: [L] Additional Filters for Media Search. TASK DETAIL https://phabricator.wikimedia.org/T257938 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Multichill, EBernhardson, matthiasmullie, mwilliams, Aklapper, CBogen, Akuckartz, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Cparle, Anooprao, SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, Poyekhali, _jensen, rosalieper, Taiwania_Justo, Scott_WUaS, Susannaanas, Ixocactus, Wong128hk, Jane023, Wikidata-bugs, Base, aude, El_Grafo, Dinoguy1000, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331, Ltrlg, Keegan ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown
AnneT added a comment. Oops, the patch I referred to isn't on production yet. EntityLookupElement was refactored to EntityInputWidget, which is live on prod at the moment with the failing `onMousedown` method. Stephen suggested this might be an issue related to the way events are connected and fired in OOUI, which I'll start digging into but may need help from the OOUI gods at some point... TASK DETAIL https://phabricator.wikimedia.org/T237048 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T237048: [Bug] Commons Structured Data clicks through to Wikidata in Dropdown
AnneT added a comment. Hey @Niedzielski, that component was refactored into `EntityAutocompleteInputWidget` in a later patch, see here <https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikibaseMediaInfo/+/refs/heads/master/resources/statements/inputs/EntityAutocompleteInputWidget.js>. TASK DETAIL https://phabricator.wikimedia.org/T237048 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Cparle, Jdlrobson, Niedzielski, Sadads, Premeditated, SandraF_WMF, Tohaomg, Masumrezarock100, egardner, LucasWerkmeister, Ramsey-WMF, Aklapper, Astinson, darthmon_wmde, Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Anooprao, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, Silverfish, _jensen, rosalieper, Scott_WUaS, Susannaanas, Abit, Jane023, Wikidata-bugs, Base, matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, Raymond, Steinsplitter, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T239163: Inform users about constraint violation
AnneT updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T239163 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Jheald, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, PDrouin-WMF, Multichill, egardner, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Abit, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Edited] T239163: Inform users about constraint violation
AnneT updated the task description. TASK DETAIL https://phabricator.wikimedia.org/T239163 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: AnneT Cc: Jheald, Lucas_Werkmeister_WMDE, WMDE-leszek, Aklapper, PDrouin-WMF, Multichill, egardner, darthmon_wmde, DannyS712, Nandana, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Abit, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331 ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
