from:"BPirkle"

[Wikidata-bugs] [Maniphest] T353199: prop=description does not respect language variants properly

2024-03-28 Thread BPirkle

BPirkle triaged this task as "Low" priority.
BPirkle moved this task from Incoming (Needs Triage) to Backlog (Triaged and 
Ready) on the MW-Interfaces-Team board.

TASK DETAIL
  https://phabricator.wikimedia.org/T353199

WORKBOARD
  https://phabricator.wikimedia.org/project/board/6931/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, Ericliu1912, Winston_Sung, JTannerWMF, ABorbaWMF, matmarex, 
Aklapper, Tgr, Stang, cooltey, Danny_Benjafield_WMDE, S8321414, Astuthiodit_1, 
Atieno, karapayneWMDE, Invadibot, DAbad, maantietaja, Confetti68, ItamarWMDE, 
DAlangi_WMF, Akuckartz, Nandana, lucamauri, Lahi, Gq86, Sharvaniharan, scblr, 
GoranSMilovanovic, QZanden, KimKelting, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Wikidata-bugs, aude, Dbrant, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T332953: Migrate PipelineLib repos to GitLab

2023-04-26 Thread BPirkle

BPirkle added subscribers: Tgr, BPirkle.
BPirkle added a comment.


  The old image suggestions api (mediawiki/services/image-suggestion-api 
<https://gerrit.wikimedia.org/g/mediawiki/services/image-suggestion-api>) is 
unlikely to receive further development. The Jan 2023 update listed in the 
table above was a deployment-related housekeeping update by Ahmon that, while 
appreciated, does not indicate code maintenance or new development. It hasn't 
otherwise been touched in over a year, and probably won't be.
  
  The only reason I'm aware of to even keep this service around is that it is 
used in Growth's default developer setup 
<https://www.mediawiki.org/wiki/Extension:GrowthExperiments/developer_setup>. 
Per Slack conversation with @Tgr , this could be switched to the anticipated 
new image suggestions api contemplated under T306349: Public-facing API for 
querying image suggestion recommendations and submitting user feedback 
<https://phabricator.wikimedia.org/T306349>, once such a thing is actually 
created.
  
  Given all that, is it necessary to move this one to GitLab, or can it just 
hang out in Gerrit while it waits to die?

TASK DETAIL
  https://phabricator.wikimedia.org/T332953

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: BPirkle, Tgr, Eevans, Seddon, MSantos, kevinbazira, odimitrijevic, BTullis, 
Ottomata, calbon, fgiunchedi, WMDE-leszek, leila, fkaelin, ItamarWMDE, elukey, 
KartikMistry, santhosh, Martaannaj, sbassett, bking, bd808, Ladsgroup, Krinkle, 
Legoktm, tstarling, Physikerwelt, dcausse, Jdrewniak, taavi, hnowlan, 
Michaelcochez, cjming, Jdforrester-WMF, dduvall, Aklapper, thcipriani, 
Bellucii32, Themindcoder, Stevemunene, Adamm71, Jersione, Itsmeduncan, 
Hellket777, Cleo_Lemoisson, Brielikethecheese, LisafBia6531, JArguello-WMF, 
Astuthiodit_1, Atieno, 786, EChetty, TheReadOnly, Biggs657, karapayneWMDE, 
toberto, joanna_borun, Simonmaignan, Invadibot, DAbad, MPhamWMF, Devnull, 
maantietaja, Juan90264, Muchiri124, Confetti68, Anerka, Alter-paule, Beast1978, 
CBogen, Un1tY, Nintendofan885, Akuckartz, Otr500, Hook696, WDoranWMF, Ddurigon, 
MJL, Kent7301, brennen, Mateo1977, EvanProdromou, joker88john, Legado_Shulgin, 
ReaperDawn, CucyNoiD, Nandana, NebulousIris, Namenlos314, aezell, 
skpuneethumar, Gaboe420, Zylc, Giuliamocci, Davinaclare77, Abdeaitali, 
Cpaulf30, 1978Gage2001, Techguru.pc, Lahi, Operator873, Gq86, Af420, Xinbenlv, 
Vacio, Sharvaniharan, Bsandipan, scblr, Xover, GoranSMilovanovic, SPoore, 
TBolliger, Chicocvenancio, Hfbn0, QZanden, EBjune, Tbscho, Taquo, LawExplorer, 
catalandres, Eginhard, Lewizho99, Zppix, JJMC89, Maathavan, TerraCodes, DDJJ, 
_jensen, rosalieper, Agabi10, PEarleyWMF, Neuronton, RuyP, Liudvikas, 
Scott_WUaS, Pchelolo, Karthik_sripal, Izno, Wong128hk, Luke081515, Bsadowski1, 
Niharika, Wikidata-bugs, Jitrixis, aude, Bawolff, Dbrant, Dinoguy1000, 
Gryllida, Lydia_Pintscher, faidon, Grunny, ssastry, scfc, Alchimista, Arlolra, 
csteipp, Mbch331, Jay8g, Krenair
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T290299: Replace token store in MW OAuth WCQS proxy with JWT

2021-09-09 Thread BPirkle

BPirkle added a comment.


  I was not previously familiar with mw-oauth-proxy. Here are some related 
links for any other subscribers that may have a similar knowledge gap:
  
  - https://gerrit.wikimedia.org/r/c/wikidata/query/rdf/+/605922
  - 
https://codesearch.wmcloud.org/search/?q=mw-oauth-proxy=nope===
  - https://gerrit.wikimedia.org/r/admin/repos/wikidata/query/rdf
  - 
https://gerrit.wikimedia.org/g/wikidata/query/rdf/+/a9b059f9416c692b0fe7e1a17b98efabb85ffba0/mw-oauth-proxy/src/main/java/org/wikidata/query/rdf/mwoauth/OAuthProxyService.java
  
  I don't pretend to have absorbed all of this, but I did notice this in 
OAuthProxyService.java:
  
private OAuth10aService service;
  
  Are you planning to use OAuth 1 (and not  OAuth 2)? Or maybe I am misreading 
this?

TASK DETAIL
  https://phabricator.wikimedia.org/T290299

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: ttaylor, CBogen, Gehel, Aklapper, Zache, BPirkle, sdkim, hnowlan, RKemper, 
Zbyszko, Invadibot, MPhamWMF, maantietaja, Akuckartz, Nandana, Namenlos314, 
Lahi, Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T284981: SELECT query arriving to wikidatawiki db codfw hosts causing pile ups during schema change

2021-06-22 Thread BPirkle

BPirkle removed a project: Platform Engineering.

TASK DETAIL
  https://phabricator.wikimedia.org/T284981

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Ladsgroup, Addshore, Aklapper, Marostegui, joanna_borun, the0001, 
Invadibot, Ramtin0071, Selby, Devnull, AndreCstr, maantietaja, XeroS_SkalibuR, 
lmata, Muchiri124, Akuckartz, Adidsone1, RhinosF1, Legado_Shulgin, DannyS712, 
ReaperDawn, Nandana, Mirahamira, Phukettaxigroup, Davinaclare77, Qtn1293, 
Techguru.pc, Lahi, Gq86, Markhalsey, GoranSMilovanovic, Jayprakash12345, 
Th3d3v1ls, Hfbn0, QZanden, LawExplorer, Zppix, _jensen, rosalieper, Scott_WUaS, 
Wong128hk, Wikidata-bugs, aude, mark, faidon, Mbch331, Jay8g, fgiunchedi, 
WDoranWMF, holger.knust, EvanProdromou, Agabi10, Pchelolo
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T214267: Name of slots should be localized in diff

2021-05-26 Thread BPirkle

BPirkle removed BPirkle as the assignee of this task.
BPirkle added a comment.


  Removing myself as assignee because I am not currently working on this, and 
am not scheduled to in the near future. I would not object to working on it on 
the future if plans and priorities allow, but I do not want to give a false 
impression of status or discourage anyone else from taking it over.

TASK DETAIL
  https://phabricator.wikimedia.org/T214267

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: BPirkle, Raymond, daniel, Aklapper, Bugreporter, Invadibot, maantietaja, 
FRomeo_WMF, Naike, CBogen, Nintendofan885, Akuckartz, DannyS712, Nandana, 
JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, 
rosalieper, Agabi10, Scott_WUaS, Srdjan, MuhammadShuaib, LNDDYL, Psychoslave, 
Wikidata-bugs, aude, Gryllida, Shizhao, Lydia_Pintscher, Arrbee, 
Jdforrester-WMF, Mbch331, Jay8g, Ltrlg
___
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

[Wikidata-bugs] [Maniphest] T45283: InfoAction doesn't take namespace protection into account

2021-03-23 Thread BPirkle

BPirkle added subscribers: AMooney, BPirkle.
BPirkle removed a project: Platform Engineering.
BPirkle added a comment.


  @AMooney to assign a reviewer

TASK DETAIL
  https://phabricator.wikimedia.org/T45283

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: matej_suchanek, BPirkle
Cc: BPirkle, AMooney, Addshore, WMDE-leszek, Lucas_Werkmeister_WMDE, 
Lydia_Pintscher, Mike_Peel, DannyS712, gerritbot, jrbs, Krenair, Legoktm, 
Nemo_bis, SPQRobin, mxn, MZMcBride, Aklapper, Lejonel, Beta16, Invadibot, 
maantietaja, Naike, Alter-paule, Beast1978, Un1tY, Akuckartz, eprodromou, 
Hook696, Iflorez, DutchTina, Kent7301, alaa_wmde, joker88john, CucyNoiD, 
Nandana, Gaboe420, Jony, Amorymeltzer, Giuliamocci, Cpaulf30, Lahi, Gq86, 
Af420, Bsandipan, GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, 
Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Mbch331, WDoranWMF, holger.knust, EvanProdromou, Agabi10, Pchelolo
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T270710: Allow values other than ParserOutput to be stored in a ParserCache instance

2021-03-23 Thread BPirkle

BPirkle triaged this task as "Medium" priority.
BPirkle edited projects, added Platform Engineering Roadmap Decision Making; 
removed Platform Engineering.

TASK DETAIL
  https://phabricator.wikimedia.org/T270710

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: daniel, BPirkle
Cc: Lydia_Pintscher, Addshore, Pchelolo, SubrahamanyamVarma, Aklapper, daniel, 
Invadibot, maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, 
Kent7301, joker88john, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, 
Lahi, Gq86, Af420, CCicalese_WMF, Bsandipan, GoranSMilovanovic, QZanden, 
LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Wikidata-bugs, aude, Mbch331, WDoranWMF, holger.knust, EvanProdromou, Agabi10
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T275251: Rest Search API is not wikidata aware (only accepts queries beginning with Q

2021-03-09 Thread BPirkle

BPirkle edited projects, added Platform Engineering; removed Platform Team 
Workboards.

TASK DETAIL
  https://phabricator.wikimedia.org/T275251

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: ovasileva, Addshore, Lydia_Pintscher, Aklapper, Jdlrobson, Selby, caldera, 
maantietaja, Akuckartz, Demian, darthmon_wmde, WDoranWMF, holger.knust, 
EvanProdromou, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
pmiazga, LawExplorer, JJMC89, Iniquity, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Volker_E, Niedzielski, Izno, abian, Wikidata-bugs, aude, 
GWicke, Dinoguy1000, Mbch331, Jay8g, Naike, eprodromou
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T276551: Allow extensions to use NameTableStore for their own tables

2021-03-09 Thread BPirkle

BPirkle moved this task from Inbox to Tracking/Watching on the Platform 
Engineering board.
BPirkle added a comment.


  No objections from Platform Team.

TASK DETAIL
  https://phabricator.wikimedia.org/T276551

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3654/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: BPirkle, Addshore, Aklapper, Lucas_Werkmeister_WMDE, maantietaja, 
Akuckartz, WDoranWMF, holger.knust, EvanProdromou, Nandana, Banyek, Rayssa-, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Agabi10, Scott_WUaS, Pchelolo, abian, Wikidata-bugs, aude, Dinoguy1000, 
Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T245989: RecentChanges query API fails with timeout when asking for 5 RC redirects in on Wikidata

2021-02-18 Thread BPirkle

BPirkle moved this task from Discussing to Later on the Platform Team 
Workboards (Clinic Duty Team) board.
BPirkle triaged this task as "Medium" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T245989

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4149/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Masti, Marostegui, Aklapper, pywikibot-bugs-list, Dvorapa, Jyoo1011, 
JohnsonLee01, SHEKH, Naike, Dijkstra, Khutuck, Akuckartz, Zkhalido, eprodromou, 
WDoranWMF, Viztor, DannyS712, Nandana, Wenyi, Amorymeltzer, Lahi, Gq86, 
GoranSMilovanovic, QZanden, Tbscho, MayS, LawExplorer, Sethakill, Mdupont, 
JJMC89, dg711, _jensen, rosalieper, Agabi10, Altostratus, Avicennasis, 
Scott_WUaS, Pchelolo, mys_721tx, Wikidata-bugs, aude, jayvdb, Alchimista, 
Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T245989: RecentChanges query API fails with timeout when asking for 5 RC redirects in on Wikidata

2021-01-14 Thread BPirkle

BPirkle renamed this task from "RecetChanges query API fails with timeout when 
asking for 5 RC redirects in on Wikidata" to "RecentChanges query API fails 
with timeout when asking for 5 RC redirects in on Wikidata".

TASK DETAIL
  https://phabricator.wikimedia.org/T245989

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Masti, Marostegui, Aklapper, pywikibot-bugs-list, Dvorapa, JohnsonLee01, 
SHEKH, Naike, Dijkstra, Khutuck, Akuckartz, Zkhalido, eprodromou, WDoranWMF, 
Viztor, DannyS712, Nandana, Wenyi, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, 
QZanden, Tbscho, MayS, LawExplorer, Sethakill, Mdupont, JJMC89, dg711, _jensen, 
rosalieper, Agabi10, Altostratus, Avicennasis, Scott_WUaS, Pchelolo, mys_721tx, 
Wikidata-bugs, aude, jayvdb, Alchimista, Mbch331, Rxy
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-10-07 Thread BPirkle

BPirkle created this task.
BPirkle added projects: Wikimedia-production-error, Wikidata-Campsite, 
MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Error
  -
  
  `MediaWiki version:`  **`1.36.0-wmf.10`**
  
  name=message
$pageId must be an integer > 0
  
  
  
  Impact
  --
  
  Notes
  -
  
  See https://phabricator.wikimedia.org/T114352 (old ticket)
  
  exception.class: InvalidArgumentException
  exception.code: 0

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Aklapper, BPirkle, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264928: MediaWiki::restInPeace: transaction round 'Cognate\CacheUpdateJob::run' still running

2020-10-07 Thread BPirkle

BPirkle created this task.
BPirkle added projects: Wikimedia-production-error, Cognate, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Error
  -
  
  `MediaWiki version:`  **`1.36.0-wmf.10`**
  
  name=message
MediaWiki::restInPeace: transaction round 'Cognate\CacheUpdateJob::run' 
still running
  
  
  
  Impact
  --
  
  Notes
  -
  
  4 occurrences for request id 94940455-73d1-4702-ac31-ff91f1cd1a29 seen on 
these 4 wikis:
  jawiktionary
  chrwiktionary
  kowiktionary
  zhwiktionary
  
  exception.class: Wikimedia\Rdbms\DBTransactionError
  exception.code: 0

TASK DETAIL
  https://phabricator.wikimedia.org/T264928

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Aklapper, BPirkle, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Thibaut120094, Wikidata-bugs, aude, Lydia_Pintscher, Darkdadaah, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Ltrlg, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T260847: Wikibase\DataModel\Services\Lookup\EntityLookupException: the execution time limit of 60 seconds was exceeded

2020-08-19 Thread BPirkle

BPirkle created this task.
BPirkle added projects: Wikimedia-production-error, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  name=Error message

[19f50cc3-e17e-41cb-9040-57dbd593711b] 
/wiki/Special:EntityData/Q81068910.nt   
Wikibase\DataModel\Services\Lookup\EntityLookupException from line 51 of 
/srv/mediawiki/php-1.36.0-wmf.4/extensions/Wikibase/lib/includes/Store/RevisionBasedEntityLookup.php:
 the execution time limit of 60 seconds was exceeded
  
  name=Stack Trace
#0 
/srv/mediawiki/php-1.36.0-wmf.4/vendor/wikibase/data-model-services/src/Lookup/RedirectResolvingEntityLookup.php(51):
 
Wikibase\Lib\Store\RevisionBasedEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
#1 
/srv/mediawiki/php-1.36.0-wmf.4/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(462):
 
Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup->getEntity(Wikibase\DataModel\Entity\ItemId)
#2 
/srv/mediawiki/php-1.36.0-wmf.4/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(230):
 
Wikibase\Repo\Rdf\RdfBuilder->resolveMentionedEntities(Wikibase\DataModel\Services\Lookup\RedirectResolvingEntityLookup)
#3 
/srv/mediawiki/php-1.36.0-wmf.4/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(175):
 
Wikibase\Repo\LinkedData\EntityDataSerializationService->rdfSerialize(Wikibase\Lib\Store\EntityRevision,
 NULL, array, Wikibase\Repo\Rdf\RdfBuilder, NULL)
#4 
/srv/mediawiki/php-1.36.0-wmf.4/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(527):
 
Wikibase\Repo\LinkedData\EntityDataSerializationService->getSerializedData(string,
 Wikibase\Lib\Store\EntityRevision, NULL, array, NULL)
#5 
/srv/mediawiki/php-1.36.0-wmf.4/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(276):
 Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(WebRequest, 
OutputPage, string, Wikibase\DataModel\Entity\ItemId, integer)
#6 
/srv/mediawiki/php-1.36.0-wmf.4/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(156):
 Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, 
WebRequest, OutputPage)
#7 
/srv/mediawiki/php-1.36.0-wmf.4/includes/specialpage/SpecialPage.php(600): 
Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#8 
/srv/mediawiki/php-1.36.0-wmf.4/includes/specialpage/SpecialPageFactory.php(681):
 SpecialPage->run(string)
#9 /srv/mediawiki/php-1.36.0-wmf.4/includes/MediaWiki.php(307): 
MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.36.0-wmf.4/includes/MediaWiki.php(940): 
MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.36.0-wmf.4/includes/MediaWiki.php(543): 
MediaWiki->main()
#12 /srv/mediawiki/php-1.36.0-wmf.4/index.php(53): MediaWiki->run()
#13 /srv/mediawiki/php-1.36.0-wmf.4/index.php(46): wfIndexMain()
#14 /srv/mediawiki/w/index.php(3): require(string)
#15 {main}
  
  
  
  Impact
  --
  
  Notes
  -
  
  We think this is new but were unable to confirm

TASK DETAIL
  https://phabricator.wikimedia.org/T260847

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Aklapper, BPirkle, Akuckartz, darthmon_wmde, Nandana, Lahi, Gq86, 
Pablo-WMDE, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T260179: The ApiQueryDescription should handle Chinese language variant correctly

2020-08-11 Thread BPirkle

BPirkle triaged this task as "Medium" priority.
BPirkle edited projects, added Platform Team Workboards (Clinic Duty Team); 
removed Platform Engineering.

TASK DETAIL
  https://phabricator.wikimedia.org/T260179

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Aklapper, Cosine02, cooltey, Naike, Akuckartz, eprodromou, darthmon_wmde, 
WDoranWMF, DannyS712, Nandana, Amorymeltzer, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, Sethakill, dg711, _jensen, rosalieper, Agabi10, 
Scott_WUaS, Pchelolo, Wikidata-bugs, aude, jayvdb, Anomie, Mbch331, Rxy, 
Legoktm, holger.knust, EvanProdromou
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T93273: UnresolvedRedirectException "Unresolved redirect to Q…" from WikiPageEntityRevisionLookup.php

2020-07-29 Thread BPirkle

BPirkle added a comment.


  6 occurrences seen in logstash on 2020-07-29.

TASK DETAIL
  https://phabricator.wikimedia.org/T93273

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: BPirkle, gerritbot, PokestarFan, Krinkle, mmodell, Addshore, Bene, hoo, 
JanZerebecki, thiemowmde, Lydia_Pintscher, aude, Aklapper, CBogen, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, 
Jdforrester-WMF, Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T255804: overzealous throttling on Wikidata

2020-06-24 Thread BPirkle

BPirkle removed a project: Core Platform Team.
BPirkle added a comment.


  Untagging CPT as this may not actually be an issue. Retag us if needed.

TASK DETAIL
  https://phabricator.wikimedia.org/T255804

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: BPirkle, Addshore, Tagishsimon, Spinster, Magnus, Multichill, Ladsgroup, 
Aklapper, Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Mbch331, WDoranWMF, holger.knust, EvanProdromou, 
Agabi10, Pchelolo
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-07-11 Thread BPirkle

BPirkle added a comment.


  I've uploaded patches for all issues identified in this task. In an effort to 
keep this task focused on ar_text_id and rev_text_id, I created several related 
tasks for things that deserve attention and which are related to MCR, but not 
directly to rev_text_id or ar_text_id:
  
  T220884 <https://phabricator.wikimedia.org/T220884> (additional 
DeletePagesForGood extension updates)
  T227836 <https://phabricator.wikimedia.org/T227836> (maintenance script 
related to DeletePagesForGood, but possibly also generically useful)
  T227840 <https://phabricator.wikimedia.org/T227840> (additional Duplicator 
extension updates)
  
  While it may be slightly disingenuous to push the additional work to other 
tasks and declare this task done, I think it does make sense to move the 
extension work that is not part of the MCR Schema migration critical path to 
more focused tasks. Focused tasks are good practice, and extension-specific 
tasks are more likely to be noticed by people interested in those specific 
extensions.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, WDoranWMF, holger.knust, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Ramsey-WMF, Darkminds3113, Bsandipan, 
Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Pchelolo, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-04-24 Thread BPirkle

BPirkle added a comment.


  Unless I'm missing something, @Anomie already did the bulk of the work for 
the first two (ApiQueryAllDeletedRevisions and ApiQueryDeletedRevisions) in 
commit 07842be3 
<https://phabricator.wikimedia.org/rMW07842be379ca3d4d0bc0608c217dd0e8cd7cbe4b> 
as part of T200568 <https://phabricator.wikimedia.org/T200568>, particularly by 
adding ApiQueryRevisionsBase::extractSlotInfo().
  
  ApiQueryDeletedrevs would require larger changes because, as Anomie noted in 
the commit message for 07842be3 
<https://phabricator.wikimedia.org/rMW07842be379ca3d4d0bc0608c217dd0e8cd7cbe4b> 
, "ApiQueryDeletedrevs wasn't touched,
  since it has been deprecated since 1.25 anyway." May I remove it? If not, may 
I no-op it?
  
  I'm posting a change for just the first two bullet points. If I can remove or 
no-op ApiQueryDeletedrevs, I'll do that as a separate change.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-04-23 Thread BPirkle

BPirkle added a comment.


  I'm also seeing three few ungated ar_text_id references in core:
  
  - ApiQueryAllDeletedRevisions::run()
  - ApiQueryDeletedRevisions::run()
  - ApiQueryDeletedrevs::execute()
  
  These all use ar_text_id to load content by joining the text table. I'll 
refactor that to use the newer approach.
  
  The ar_text_id field shows up a number of other times in core code, but after 
looking at them individually, I think the rest are intentional, and the above 
three are the only problematic references remaining.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, 
Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
QZanden, LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, 
rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

2019-04-17 Thread BPirkle

BPirkle added a comment.


  In T198342#5118274 <https://phabricator.wikimedia.org/T198342#5118274>, 
@daniel wrote:
  
  > Ooops, too fast, there is an open patch needing review: 
https://gerrit.wikimedia.org/r/c/mediawiki/core/+/500755
  
  
  That patch is for T198341 <https://phabricator.wikimedia.org/T198341>, but 
this comment is on T198342 <https://phabricator.wikimedia.org/T198342>.
  
  However, I did just find three usages of getQueryInfo() with the 'text' flag 
in extensions:
  
  - SpamBlacklist/includes/BaseBlacklist.php
  - Translate/MessageCollection.php
  - Translate/translationaids/TranslationAidDataProvider.php
  
  I'll see about fixing those.

TASK DETAIL
  https://phabricator.wikimedia.org/T198342

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: BPirkle, Aklapper, aude, Addshore, Anomie, Jdforrester-WMF, Tgr, gerritbot, 
daniel, WDoranWMF, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, 
Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-04-08 Thread BPirkle

BPirkle added a comment.


  Per discussion in this task, I created new task T220450 
<https://phabricator.wikimedia.org/T220450> for the additional Postgres changes 
(searchindex table).

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198342: Remove all usages of the 'text' flag in calls to Revision::getQueryInfo() and RevisionStore::getQueryInfo().

2019-04-03 Thread BPirkle

BPirkle added a comment.


  Usages found:
  
  - includes/api/ApiQueryAllRevisions.php, line 85, in function run()
  - includes/api/ApiQueryRevisions.php, line 162, in function run() (if 
$this->fetchContent is true)
  - maintenance/testCompression.php line 51
  - tests/phpunit/includes/RevisionDbTestBase.php, line 1601, in function 
testGetRevisionText(), via data provider provideGetRevisionText()
  - tests/phpunit/includes/RevisionMcrReadNewDbTest.php, data provider 
provideGetRevisionText()
  - test/phpunit/includes/Revision/RevisionQueryInfoTest.php line 1054, in 
function testRevisionGetQueryInfo(), via data provider provideQueryInfo()
  - test/phpunit/includes/Revision/RevisionQueryInfoTest.php line 1068, in 
function testRevisionStoreGetQueryInfo(), via data provider provideQueryInfo()
  
  The occurrences in the tests may be intentional?

TASK DETAIL
  https://phabricator.wikimedia.org/T198342

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: BPirkle, Aklapper, aude, Addshore, Anomie, Jdforrester-WMF, Tgr, gerritbot, 
daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, 
JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-03-21 Thread BPirkle

BPirkle added a comment.


  In T198341#5024626 <https://phabricator.wikimedia.org/T198341#5024626>, 
@Anomie wrote:
  
  > In T198341#5022412 <https://phabricator.wikimedia.org/T198341#5022412>, 
@daniel wrote:
  >
  > > In T198341#5021347 <https://phabricator.wikimedia.org/T198341#5021347>, 
@BPirkle wrote:
  > >
  > > > - includes/search/SearchPostgres.php
  > >
  > >
  > > odd stuff, maybe @anomie can help. Two uses seem completely pointless, 
the third one should probably use getQueryInfo?
  >
  >
  > Note in the PostgreSQL schema the "text" table is named "pagecontent". That 
was done in rSVN15791 <https://phabricator.wikimedia.org/rSVN15791>; I don't 
know why quoting wasn't just used instead. The plan for T164898 
<https://phabricator.wikimedia.org/T164898>/T191231 
<https://phabricator.wikimedia.org/T191231> includes renaming it back to "text".
  >
  > It looks like that file needs some #technical-debt 
<https://phabricator.wikimedia.org/tag/technical-debt/> cleanup to use the 
IDatabase querying methods rather than building SQL strings directly, but that 
alone would probably be out of scope here.
  >
  > What is in scope is that it's trying to search directly against the `text` 
table, having added an extra column for that purpose, and will need to be 
converted to use a `searchindex` table like MySQL does.
  
  
  To make sure I'm heading in the right direction:
  
  - Postgres currently uses columns in specific tables (pagecontent.textvector 
and page.titlevector, both of type tsvector) to store search index information
  - Postgres also currently uses triggers/procedures to maintain these tables
  - And directly related to this task, searchPostgres.php currently and 
undesirably references fields rev_text_id and old_id
  
  I should:
  
  - add a searchindex table, similar to the MySQL one, but adapted to Postgres 
data types
  - add related indexes/triggers/procedures to maintain this table
  - add necessary documentation and install/update support for these db changes
  - modify searchPostgres.php to use the new db changes
  
  Questions:
  
  - I'm assuming we are using triggers/procedures to maintain the existing 
tsvector search columns because that works well in Postgres, and we want to 
retain that technique with the searchindex table. Am I right, or do we want to 
do more of this at the PHP level per SearchMySQL.php?
  - should I remove/refactor the existing columns/triggers/procedures and have 
all Postgres searches work off (only) the new searchindex table? Or should I 
leave that alone for now and use $wgMultiContentRevisionSchemaMigrationStage 
gating in searchPostgres.php to continue to use the existing columns if we're 
reading the old schema? Leaving the old and maintaining two sets of indexes at 
the db level sounds inefficient. But maybe there's a reason I'm missing to 
retain it.
  - there are a. bunch of "ts2_" prefixes floating around in 
postgres/tables.sql (ex. "CREATE TRIGGER ts2_page_text..."). Is that a 
meaningful naming convention I should be aware of and retain, or is that just 
"text search 2" to indicate it was a "new thing" at some point?
  - is there developer documentation on 
update.php/DatabaseUpdater.php/PostgresUpdater.php? I've looked through that 
code (and postgres/tables.sql). I have a formative understanding, but I need to 
be more solid on how all this works.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-03-14 Thread BPirkle

BPirkle added a comment.


  In T198341#5025536 <https://phabricator.wikimedia.org/T198341#5025536>, 
@daniel wrote:
  
  > In T198341#5024626 <https://phabricator.wikimedia.org/T198341#5024626>, 
@Anomie wrote:
  >
  > > Here's one place where Daniel and I differ: I'd put most of these in one 
patch instead of having 10+ single-file changes.
  >
  >
  > Ok, compromise: one patch for SearchPostgres, one for checkStorage.php and 
compressOld.php, and one for the rest.
  
  
  Should compressOld.php and trackBlobs.php be in the same patch, as they both 
suffer from the " processing multiple blobs per revision" problem?

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-03-13 Thread BPirkle

BPirkle added a comment.

  In T198341#5022332 <https://phabricator.wikimedia.org/T198341#5022332>, 
@daniel wrote:

  > > includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All 
other references are either gated directly, or are in private functions with 
all calls gated)
  >
  > getQueryInfo() should have proper gating as well. If you think it  does 
not, let's talk before you change things.

  I looked again, you are correct. I saw the comment mentioning this task 
(T198341 <https://phabricator.wikimedia.org/T198341>) and initially thought 
there was something to do.  We just need to be sure callers don't pass a "text" 
option, but that's already covered under T198342 
<https://phabricator.wikimedia.org/T198342> (which is probably a good candidate 
for my next task after I finish this one).  So nothing to do to getQueryInfo() 
at the moment.

  Thanks very much for your comments on the other items.  I'll proceed down the 
list, making separate patches for each.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-03-13 Thread BPirkle

BPirkle added a comment.


  Thanks.
  
  MessageCache.php was not listed in my previous comment, because I've already 
incorporated Daniel's patch from June into my local codebase, but that'll be 
part of the final change as well.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, 
Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-03-13 Thread BPirkle

BPirkle added a subscriber: tstarling.
BPirkle added a comment.


  Thank you.  With that in mind, here's my current understanding. The list 
below applies only to rev_text_id, not ar_text_id or text.old_id. When touching 
code for rev_text_id, I'll also remove any references to the other two fields. 
I'll then loop back and review/remove any remaining references to them.
  
  rev_text_id references that will be removed/refactored in this task:
  
  - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo().  All 
other references are either gated directly, or are in private functions with 
all calls gated)
  - includes/search/SearchPostgres.php
  - maintenance/Maintenance.php
  - maintenance/populateContentTables.php
  - maintenance/rebuildtextindex.php
  - maintenance/storage/checkStorage.php
  - maintenance/storage/compressOld.php
  - maintenance/storage/fixT22757.php (this script will be removed entirely, 
pending confirmation from @tstarling )
  - maintenance/storage/trackBlobs.php
  - tests/phpunit/includes/ActorMigrationTest.php
  
  rev_text_id references that will not be touched in this task:
  
  - HISTORY (documentation)
  - includes/export/WikiExporter.php (gated, will be addressed in T198706 
<https://phabricator.wikimedia.org/T198706> and T174031 
<https://phabricator.wikimedia.org/T174031>)
  - includes/export/XmlDumpWriter.php (will be addressed in T198706 
<https://phabricator.wikimedia.org/T198706> and T174031 
<https://phabricator.wikimedia.org/T174031>)
  - includes/installer/MssqlUpdater.php (schema, historical)
  - includes/installer/MysqlUpdater.php (schema, historical)
  - includes/installer/PostgresUpdater.php (schema, historical)
  - includes/installer/SqliteUpdate.php (schema, historical)
  - includes/page/WikiPage.php (gated)
  - includes/Revision.php (gated and deprecated)
  - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo().  All 
other references are either gated directly, or are in private functions with 
all calls gated)
  - maintenance/tables.sql (schema)
  - maintenance/archives/patch-rev_text_id-default.sql (schema, historical)
  - maintenance/archives/patch-rev_text_id.sql (schema, historical)
  - maintenance/mssql/tables.sql (schema)
  - maintenance/mssql/archives/patch-rev_text_id-default.sql (schema, 
historical)
  - maintenance/oracle/tables.sql (schema)
  - maintenance/postgres/tables.sql (schema)
  - maintenance/postgres/patch-textsearch_bug66650.sql (schema)
  - maintenance/sqlite/archives/initial-indexes.sql (schema)
  - maintenance/sqlite/archives/patch-comment-table.sql (schema)
  - maintenance/sqlite/archives/patch-rev_text_id-default.sql (schema, 
historical)
  - tests/phpunit/data/db/sqlite/tables-1.13.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.15.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.16.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.17.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.18.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.19.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.20.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.21.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.22.sql (historical)
  - tests/phpunit/data/db/sqlite/tables-1.23.sql (historical)
  - tests/phpunit/includes/RevisionMcrReadNewDbTest.php (testing)
  - tests/phpunit/includes/RevisionMcrWriteBothDbTest.php (testing)
  - tests/phpunit/includes/RevisionNoContentModelDbTest.php (testing)
  - tests/phpunit/includes/RevisionPreMcrDbTest.php (testing)
  - tests/phpunit/includes/Revision/create-pre-mcr-fiels.sql (testing)
  - tests/phpunit/includes/Revision/drop-pre-mcr-fields.sql (testing)
  - tests/phpunit/includes/Revision/McrReadNewRevisionStoreDbTest.php (testing)
  - tests/phpunit/includes/Revision/McrWriteBothRevisionStoreDbTest.php 
(testing)
  - tests/phpunit/includes/Revision/NoContentModelRevisionStoreDbTest.php 
(testing)
  - tests/phpunit/includes/Revision/PreMcrRevisionStoreDbTest.php (testing)
  - tests/phpunit/includes/Revision/RevisionQueryInfoTest.php (testing)
  - tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php (testing)
  - tests/phpunit/includes/Revision/RevisionStoreTest.php (testing)
  
  If anyone notices anything glaringly incorrect in that list, please let me 
know. Otherwise, I'll proceed and ask any further questions as they arise.

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, 
Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, Lewizho99, JJMC89, Maatha

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-03-13 Thread BPirkle

BPirkle added a comment.


  Thank you. Will ping Tim on that one when it is daylight for him.
  
  One more question: rev_text_id is referenced in 
tests/phpunit/includes/ActorMigrationTest.php function provideInsertRoundTrip, 
which is a data provider for function testInsertRoundTrip. That function does 
many things with the SCHEMA_COMPAT_ constants, but related to the Actor 
migration, not the MCR Schema migration. Therefore the rev_text_id reference 
needs to be removed from that file. Am I correct about that?

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, 
alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-03-12 Thread BPirkle

BPirkle added a comment.


  Question on one occurrence of these fields:  is the maintenance script 
fixT22757.php still relevant?

TASK DETAIL
  https://phabricator.wikimedia.org/T198341

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, 
alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, 
Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-02-18 Thread BPirkle

BPirkle added a comment.
Task description refers to "RevisionStore::newRevisionRecordFromRow()".  Should that be "RevisionStore::newRevisionFromRow()"?TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Claimed] T198341: Remove all references to the rev_text_id and ar_text_id fields

2019-02-18 Thread BPirkle

BPirkle claimed this task.
TASK DETAILhttps://phabricator.wikimedia.org/T198341EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, Agabi10, Wikidata-bugs, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T198557: Remove support for legacy pre-MCR schema

2019-02-18 Thread BPirkle

BPirkle added a comment.
I was, however, able to claim T198341.  I'll start there.TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, Agabi10, MGChecker, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T198557: Remove support for legacy pre-MCR schema

2019-02-18 Thread BPirkle

BPirkle added a comment.
I'm happy to, but it appears that I cannot edit or claim the task.TASK DETAILhttps://phabricator.wikimedia.org/T198557EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Fjalapeno, CCicalese_WMF, Aklapper, daniel, holger.knust, EvanProdromou, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, JJMC89, _jensen, Agabi10, MGChecker, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T211806: Passing in the "body" request option as an array to send a POST request has been deprecated

2018-12-12 Thread BPirkle

BPirkle added a comment.
This looks more promising:

			if ( is_array( $postData )  ) {
$this->guzzleOptions['form_params'] = $postData;
			} else {
$this->guzzleOptions['body'] = $postData;
			}

Per http://docs.guzzlephp.org/en/stable/quickstart.html, Guzzle will automatically set Content-Type to application/x-www-form-urlencoded .  This happens within Guzzle's Client.php on line 314.  This mirrors curl's behavior with CURLOPT_POSTFIELDS, which we previously used in CurlHttpRequest.php.  Per https://curl.haxx.se/libcurl/c/CURLOPT_POSTFIELDS.html, if CURLOPT_POSTFIELDS is set :

This POST is a normal application/x-www-form-urlencoded kind (and libcurl will set that Content-Type by default when this option is used), which is commonly used by HTML forms.

So the normal case of sending an array of POST fields should work happily, and callers can also override as needed.  I'm running unit tests locally right now, but of course, that only goes so far (else we wouldn't be here in the first place).

Worst case, if this doesn't work out, we can get the train unblocked by modifying HttpRequestFactory::create to only use guzzle if explicitly requested.  The CurlHttpRequest and PhpHttpRequest code remains in the codebase.TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: Legoktm, Reedy, BPirkle, Aklapper, TerraCodes, Liuxinyu970226, zeljkofilipin, Eladio.15, Nandana, Lahi, Gq86, GoranSMilovanovic, Nakohdo, QZanden, LawExplorer, Reasno, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T211806: Passing in the "body" request option as an array to send a POST request has been deprecated

2018-12-12 Thread BPirkle

BPirkle added a comment.
Reproduced the exception locally using trivial test data:

$params = [ 'foo' => 'bar' ];
$response = Http::post(
	'http://www.example.net',
	[ 'postData' => $params ]
);

Then confirmed the exception disappeared per the suggestion from stack overflow, by adding this to GuzzleHttpRequest.php just before we use $postData:

			if ( is_array( $postData) ) {
$postData = json_encode( $postData );
			}

Now looking at more complex cases, and confirming actual functionality rather than just lack of an exception.TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: Legoktm, Reedy, BPirkle, Aklapper, TerraCodes, Liuxinyu970226, zeljkofilipin, Eladio.15, Nandana, Lahi, Gq86, GoranSMilovanovic, Nakohdo, QZanden, LawExplorer, Reasno, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T211806: Passing in the "body" request option as an array to send a POST request has been deprecated

2018-12-12 Thread BPirkle

BPirkle added a comment.
GuzzleHttpRequest.php line 94, we are indeed setting the 'body' field and trusting that $postData was happily passed to the constructor by calling code.  Fiddling...TASK DETAILhttps://phabricator.wikimedia.org/T211806EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: Legoktm, Reedy, BPirkle, Aklapper, TerraCodes, Liuxinyu970226, zeljkofilipin, Eladio.15, Nandana, Lahi, Gq86, GoranSMilovanovic, Nakohdo, QZanden, LawExplorer, Reasno, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, jayvdb, Lydia_Pintscher, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T110022: Create a library with HTTP related functions/code

2018-12-10 Thread BPirkle

BPirkle added a comment.
Guzzle has been added to the codebase and made available through the new GuzzleHttpRequest class, per T202110.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: MGChecker, Imarlier, BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Nandana, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, _jensen, D3r1ck01, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T198706: Make BackupDumper, WikiExporter and XmlDumpWriter compliant with the MCR revision retrival mechanism (main slot only)

2018-10-03 Thread BPirkle

BPirkle closed subtask T203424: Replace the WikiExporter backup dump streaming mode with batched queries as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T198706EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: daniel, BPirkleCc: ArielGlenn, gerritbot, CCicalese_WMF, Aklapper, Fjalapeno, daniel, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, Agabi10, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331, Ltrlg___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-09 Thread BPirkle

BPirkle added a comment.
I’m also a soft lean to Guzzle.  It seems more active recently than most of the alternatives, suitable to our needs, and generally popular.  I hate to overweigh “popularity” as a metric, but in the case of open source, momentum doesn’t hurt.  It is also much easier to google for, as searching for "requests" gives a flood of false positives.

It seems like Requests is less active - the author says as much here:

https://github.com/rmccue/Requests/issues/320

However, that’s not necessarily negative, it could simply mean the library is stable.  Its continued use WordPress should help maintain its critical mass, and gives us a reference implementation (for whatever that is or isn't worth).

My goals with this conversation are


avoid burning  unnecessary time by exploring obvious dead ends, or missing an obvious winner
gather sufficient consensus and detail to create a properly focused subtask for the actual implementation


I don't mind at all doing exploratory implementations with both Guzzle and Requests as part of that process.  (In fact, I already have them both installed in my local copy of mediawiki and have confirmed that basic GET operations work happily with both.)

At this point, I think I'll explore Guzzle for more sophisticated usages, and await comments from @Krinkle to decide if I should do the same for Requests.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: Imarlier, BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-07 Thread BPirkle

BPirkle added a comment.
Localization questions aside, it seemed that in 2016 (on T139169), @Krinkle preferred Requests, while @Tgr preferred Guzzle.  Do each of you still feel the same, and are there any additional possibilities that you've become aware of since then?TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-06 Thread BPirkle

BPirkle added a comment.
I wish we could map by exception class, but it seems challenging to do that in a useful way. Looking at the two libraries that have been mentioned:

Guzzle tends to throw generic exception classes. The most popular appear to be:

InvalidArgumentException (49 occurrences)
LogicException (6 occurrences)
RuntimeException (33 occurrences)

Requests, on the other hand, pretty much only throws Requests_Exception (29 occurrences)

In neither case would a message based on the exception class be helpful for diagnosing an issue. The exception message is the interesting part, and also the hardest part to localize.

Who would our intended audience be for localized exception messages? They're probably incomprehensible to end users whether translated or not, and I'm assuming that developers speak sufficient English to read the untranslated messages (given that the code and its comments are in English). So are localized exception messages intended for people who administer/configure mediawiki sites? I'm wondering if they need to be translated at all.

The other aspect is that what constitutes an "exception" to a library may be a different thing than what constitutes an exception to the calling code. A socket timeout may constitute an exception to Requests, but I'm guessing that calling code would want to catch that and give a meaningful message in the context of whatever operation was being performed.

I very much like the idea of having centralized, or at least consistent, ways of handling things. But in this situation, I wonder if on a practical level we'll find that the fact that something is a "library" implies that its calling code must interpret exceptions on a case-by-case basis.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Commented On] T110022: Create a library with HTTP related functions/code

2018-08-03 Thread BPirkle

BPirkle added a comment.
If we do care about localization, there's also the possibility of wrapping an external library in custom code that does support localization.  Current http-* entries in en.json are fairly generic and could continue to be so.  The external library would handle the details of the actual request, including the fallback from curl to php streams as necessary.  In that model, MWHttpRequest and MultiHttpClient continue to exist, but much simplified compared to their current implementations.  From my brief read, Wordpress used that approach.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Updated] T110022: Create a library with HTTP related functions/code

2018-08-02 Thread BPirkle

BPirkle added a comment.
This task has been around for awhile, and related discussion and action has since occurred elsewhere.  To summarize from this task and from T139169, T137926, and T139170:


we would like to make curl optional (with a suitable warning)



we made MultiHttpClient work without curl in T139169, but at the cost of introducing an undesirable dependency on MWHttpRequest, which is currently not within includes/libs.  So in solving one issue, we created another.



we should either use an external library, or create our own.  Options presented were:


— Requests (https://packagist.org/packages/rmccue/requests), used by WordPress
— Guzzle (http://docs.guzzlephp.org), originally required curl but now has a fallback to PHP streams
— librarize our existing code (per this tasks description) . Requires librarizing some dependencies (StatusValue, etc.)

Here’s an article about when Wordpress switched to Requests: https://make.wordpress.org/core/2016/07/27/http-api-in-4-6/  Scroll down to the comments for some (admittedly dated) discussion of Requests vs Guzzle from their perspective.

I support pursuing using an external library, as there seem to be (at least) two suitable existing options.  MultiHttpClient might be a good place to start, as it is currently breaking our rules.  I'm happy to create a task for that and take it on, but before I get started I'm curious if the summary I just wrote above still accurately reflects our larger goals, and if there are additional thoughts I should consider.TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: BPirkle, Nikerabbit, Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] [Unblock] T110022: Create a library with HTTP related functions/code

2018-07-23 Thread BPirkle

BPirkle closed subtask T139169: Add non-parallel MultiHttpClient fallback for environments that don't have curl available as "Resolved".
TASK DETAILhttps://phabricator.wikimedia.org/T110022EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: BPirkleCc: Dereckson, Ladsgroup, Krinkle, PokestarFan, Tgr, Lydia_Pintscher, Ricordisamoa, Legoktm, Addshore, Aklapper, Arch2all, Lahi, Gq86, dmaza, GoranSMilovanovic, DFelten, QZanden, LawExplorer, HakanIST, Abbe98, Hannolans, Samwilson, Wikidata-bugs, aude, Dinoguy1000, fbstj, Tpt, Mbch331, bd808___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

45 matches

Mail list logo