BPirkle added a subscriber: tstarling. BPirkle added a comment.
Thank you. With that in mind, here's my current understanding. The list below applies only to rev_text_id, not ar_text_id or text.old_id. When touching code for rev_text_id, I'll also remove any references to the other two fields. I'll then loop back and review/remove any remaining references to them. rev_text_id references that will be removed/refactored in this task: - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated) - includes/search/SearchPostgres.php - maintenance/Maintenance.php - maintenance/populateContentTables.php - maintenance/rebuildtextindex.php - maintenance/storage/checkStorage.php - maintenance/storage/compressOld.php - maintenance/storage/fixT22757.php (this script will be removed entirely, pending confirmation from @tstarling ) - maintenance/storage/trackBlobs.php - tests/phpunit/includes/ActorMigrationTest.php rev_text_id references that will not be touched in this task: - HISTORY (documentation) - includes/export/WikiExporter.php (gated, will be addressed in T198706 <https://phabricator.wikimedia.org/T198706> and T174031 <https://phabricator.wikimedia.org/T174031>) - includes/export/XmlDumpWriter.php (will be addressed in T198706 <https://phabricator.wikimedia.org/T198706> and T174031 <https://phabricator.wikimedia.org/T174031>) - includes/installer/MssqlUpdater.php (schema, historical) - includes/installer/MysqlUpdater.php (schema, historical) - includes/installer/PostgresUpdater.php (schema, historical) - includes/installer/SqliteUpdate.php (schema, historical) - includes/page/WikiPage.php (gated) - includes/Revision.php (gated and deprecated) - includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated) - maintenance/tables.sql (schema) - maintenance/archives/patch-rev_text_id-default.sql (schema, historical) - maintenance/archives/patch-rev_text_id.sql (schema, historical) - maintenance/mssql/tables.sql (schema) - maintenance/mssql/archives/patch-rev_text_id-default.sql (schema, historical) - maintenance/oracle/tables.sql (schema) - maintenance/postgres/tables.sql (schema) - maintenance/postgres/patch-textsearch_bug66650.sql (schema) - maintenance/sqlite/archives/initial-indexes.sql (schema) - maintenance/sqlite/archives/patch-comment-table.sql (schema) - maintenance/sqlite/archives/patch-rev_text_id-default.sql (schema, historical) - tests/phpunit/data/db/sqlite/tables-1.13.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.15.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.16.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.17.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.18.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.19.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.20.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.21.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.22.sql (historical) - tests/phpunit/data/db/sqlite/tables-1.23.sql (historical) - tests/phpunit/includes/RevisionMcrReadNewDbTest.php (testing) - tests/phpunit/includes/RevisionMcrWriteBothDbTest.php (testing) - tests/phpunit/includes/RevisionNoContentModelDbTest.php (testing) - tests/phpunit/includes/RevisionPreMcrDbTest.php (testing) - tests/phpunit/includes/Revision/create-pre-mcr-fiels.sql (testing) - tests/phpunit/includes/Revision/drop-pre-mcr-fields.sql (testing) - tests/phpunit/includes/Revision/McrReadNewRevisionStoreDbTest.php (testing) - tests/phpunit/includes/Revision/McrWriteBothRevisionStoreDbTest.php (testing) - tests/phpunit/includes/Revision/NoContentModelRevisionStoreDbTest.php (testing) - tests/phpunit/includes/Revision/PreMcrRevisionStoreDbTest.php (testing) - tests/phpunit/includes/Revision/RevisionQueryInfoTest.php (testing) - tests/phpunit/includes/Revision/RevisionStoreDbTestBase.php (testing) - tests/phpunit/includes/Revision/RevisionStoreTest.php (testing) If anyone notices anything glaringly incorrect in that list, please let me know. Otherwise, I'll proceed and ask any further questions as they arise. TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
